@aztec/validator-client 0.0.1-commit.934299a21 → 0.0.1-commit.949a33fd8

package/dest/validator.js

@@ -1,26 +1,22 @@
 import { getBlobsPerL1Block } from '@aztec/blob-lib';
-import { validateFeeAssetPriceModifier } from '@aztec/ethereum/contracts';
-import { BlockNumber, SlotNumber } from '@aztec/foundation/branded-types';
-import { TimeoutError } from '@aztec/foundation/error';
+import { CheckpointNumber } from '@aztec/foundation/branded-types';
 import { createLogger } from '@aztec/foundation/log';
-import { retryUntil } from '@aztec/foundation/retry';
 import { RunningPromise } from '@aztec/foundation/running-promise';
 import { sleep } from '@aztec/foundation/sleep';
 import { DateProvider } from '@aztec/foundation/timer';
 import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
 import { OffenseType, WANT_TO_SLASH_EVENT } from '@aztec/slasher';
-import { getEpochAtSlot, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
-import { accumulateCheckpointOutHashes } from '@aztec/stdlib/messaging';
+import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
 import { AttestationTimeoutError } from '@aztec/stdlib/validators';
 import { getTelemetryClient } from '@aztec/telemetry-client';
-import { createHASigner } from '@aztec/validator-ha-signer/factory';
+import { createHASigner, createLocalSignerWithProtection, createSignerFromSharedDb } from '@aztec/validator-ha-signer/factory';
 import { DutyType } from '@aztec/validator-ha-signer/types';
 import { EventEmitter } from 'events';
-import { BlockProposalHandler } from './block_proposal_handler.js';
 import { ValidationService } from './duties/validation_service.js';
 import { HAKeyStore } from './key_store/ha_key_store.js';
 import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
 import { ValidatorMetrics } from './metrics.js';
+import { ProposalHandler } from './proposal_handler.js';
 // We maintain a set of proposers who have proposed invalid blocks.
 // Just cap the set to avoid unbounded growth.
 const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
@@ -35,14 +31,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
     keyStore;
     epochCache;
     p2pClient;
-    blockProposalHandler;
+    proposalHandler;
     blockSource;
     checkpointsBuilder;
     worldState;
     l1ToL2MessageSource;
     config;
     blobClient;
-    haSigner;
+    slashingProtectionSigner;
     dateProvider;
     tracer;
     validationService;
@@ -54,15 +50,16 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
     /** Tracks the last checkpoint proposal we created. */ lastProposedCheckpoint;
     lastEpochForCommitteeUpdateLoop;
     epochCacheUpdateLoop;
+    /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */ lastAttestedEpochByAttester;
     proposersOfInvalidBlocks;
     /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */ lastAttestedProposal;
-    constructor(keyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, haSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
-        super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.blockProposalHandler = blockProposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.haSigner = haSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.proposersOfInvalidBlocks = new Set();
+    constructor(keyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
+        super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.proposalHandler = proposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = new Set();
         // Create child logger with fisherman prefix if in fisherman mode
         this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
         this.tracer = telemetry.getTracer('Validator');
         this.metrics = new ValidatorMetrics(telemetry);
-        this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
+        this.validationService = new ValidationService(keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
         // Refresh epoch cache every second to trigger alert if participation in committee changes
         this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
         const myAddresses = this.getValidatorAddresses();
@@ -96,6 +93,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
                 this.log.trace(`No committee found for slot`);
                 return;
             }
+            this.metrics.setCurrentEpoch(epoch);
             if (epoch !== this.lastEpochForCommitteeUpdateLoop) {
                 const me = this.getValidatorAddresses();
                 const committeeSet = new Set(committee.map((v)=>v.toString()));
@@ -111,40 +109,63 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             this.log.error(`Error updating epoch committee`, err);
         }
     }
-    static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient()) {
+    static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), slashingProtectionDb) {
         const metrics = new ValidatorMetrics(telemetry);
         const blockProposalValidator = new BlockProposalValidator(epochCache, {
-            txsPermitted: !config.disableTransactions
+            txsPermitted: !config.disableTransactions,
+            maxTxsPerBlock: config.validateMaxTxsPerBlock,
+            signatureContext: {
+                chainId: config.l1ChainId,
+                rollupAddress: config.l1Contracts.rollupAddress
+            }
         });
-        const blockProposalHandler = new BlockProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, metrics, dateProvider, telemetry);
+        const proposalHandler = new ProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, blobClient, metrics, dateProvider, telemetry, undefined);
         const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
-        let validatorKeyStore = nodeKeystoreAdapter;
-        let haSigner;
-        if (config.haSigningEnabled) {
+        let slashingProtectionSigner;
+        if (slashingProtectionDb) {
+            // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
+            ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
+                telemetryClient: telemetry,
+                dateProvider
+            }));
+        } else if (config.haSigningEnabled) {
+            // Multi-node HA mode: use PostgreSQL-backed distributed locking.
             // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
             const haConfig = {
                 ...config,
                 maxStuckDutiesAgeMs: config.maxStuckDutiesAgeMs ?? epochCache.getL1Constants().slotDuration * 2 * 1000
             };
-            const { signer } = await createHASigner(haConfig, {
+            ({ signer: slashingProtectionSigner } = await createHASigner(haConfig, {
                 telemetryClient: telemetry,
                 dateProvider
-            });
-            haSigner = signer;
-            validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, signer);
+            }));
+        } else {
+            // Single-node mode: use LMDB-backed local signing protection.
+            // This prevents double-signing if the node crashes and restarts mid-proposal.
+            ({ signer: slashingProtectionSigner } = await createLocalSignerWithProtection(config, {
+                telemetryClient: telemetry,
+                dateProvider
+            }));
         }
-        const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, haSigner, dateProvider, telemetry);
+        const validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
+        const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider, telemetry);
         return validator;
     }
     getValidatorAddresses() {
         return this.keyStore.getAddresses().filter((addr)=>!this.config.disabledValidators.some((disabled)=>disabled.equals(addr)));
     }
-    getBlockProposalHandler() {
-        return this.blockProposalHandler;
+    getProposalHandler() {
+        return this.proposalHandler;
     }
     signWithAddress(addr, msg, context) {
         return this.keyStore.signTypedDataWithAddress(addr, msg, context);
     }
+    getSignatureContext() {
+        return {
+            chainId: this.config.l1ChainId,
+            rollupAddress: this.config.l1Contracts.rollupAddress
+        };
+    }
     getCoinbaseForAttestor(attestor) {
         return this.keyStore.getCoinbaseAddress(attestor);
     }
@@ -161,18 +182,9 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
         };
     }
     reloadKeystore(newManager) {
-        if (this.config.haSigningEnabled && !this.haSigner) {
-            this.log.warn('HA signing is enabled in config but was not initialized at startup. ' + 'Restart the node to enable HA signing.');
-        } else if (!this.config.haSigningEnabled && this.haSigner) {
-            this.log.warn('HA signing was disabled via config update but the HA signer is still active. ' + 'Restart the node to fully disable HA signing.');
-        }
         const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
-        if (this.haSigner) {
-            this.keyStore = new HAKeyStore(newAdapter, this.haSigner);
-        } else {
-            this.keyStore = newAdapter;
-        }
-        this.validationService = new ValidationService(this.keyStore, this.log.createChild('validation-service'));
+        this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
+        this.validationService = new ValidationService(this.keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
     }
     async start() {
         if (this.epochCacheUpdateLoop.isRunning()) {
@@ -205,7 +217,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             // The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
             // and processed separately via the block handler above.
             const checkpointHandler = (checkpoint, proposalSender)=>this.attestToCheckpointProposal(checkpoint, proposalSender);
-            this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
+            this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
             // Duplicate proposal handler - triggers slashing for equivocation
             this.p2pClient.registerDuplicateProposalCallback((info)=>{
                 this.handleDuplicateProposal(info);
@@ -234,13 +246,12 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
             return false;
         }
-        // Ignore proposals from ourselves (may happen in HA setups)
+        // Log self-proposals from HA peers (same validator key on different nodes)
         if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
-            this.log.warn(`Ignoring block proposal from self for slot ${slotNumber}`, {
+            this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
                 proposer: proposer.toString(),
                 slotNumber
             });
-            return false;
         }
         // Check if we're in the committee (for metrics purposes)
         const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
@@ -256,12 +267,12 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
         });
         // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
         // In fisherman mode, we always reexecute to validate proposals.
-        const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
-        const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute || partOfCommittee && validatorReexecute || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
-        const validationResult = await this.blockProposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
+        const { slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
+        const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n || partOfCommittee || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
+        const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
         if (!validationResult.isValid) {
-            this.log.warn(`Block proposal validation failed: ${validationResult.reason}`, proposalInfo);
             const reason = validationResult.reason || 'unknown';
+            this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
             // Classify failure reason: bad proposal vs node issue
             const badProposalReasons = [
                 'invalid_proposal',
@@ -301,58 +312,46 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
    * the lastBlock is extracted and processed separately via the block handler.
    * @returns Checkpoint attestations if valid, undefined otherwise
    */ async attestToCheckpointProposal(proposal, _proposalSender) {
-        const slotNumber = proposal.slotNumber;
+        const proposalSlotNumber = proposal.slotNumber;
         const proposer = proposal.getSender();
         // If escape hatch is open for this slot's epoch, do not attest.
-        if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
-            this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
-            return undefined;
-        }
-        // Reject proposals with invalid signatures
-        if (!proposer) {
-            this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
+        if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
+            this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
             return undefined;
         }
         // Ignore proposals from ourselves (may happen in HA setups)
-        if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
-            this.log.warn(`Ignoring block proposal from self for slot ${slotNumber}`, {
+        if (proposer && this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
+            this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
                 proposer: proposer.toString(),
-                slotNumber
+                proposalSlotNumber
             });
             return undefined;
         }
-        // Validate fee asset price modifier is within allowed range
-        if (!validateFeeAssetPriceModifier(proposal.feeAssetPriceModifier)) {
-            this.log.warn(`Received checkpoint proposal with invalid feeAssetPriceModifier ${proposal.feeAssetPriceModifier} for slot ${slotNumber}`);
-            return undefined;
-        }
-        // Check that I have any address in current committee before attesting
-        const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
+        // Check that I have any address in the committee where this checkpoint will land before attesting
+        const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
         const partOfCommittee = inCommittee.length > 0;
         const proposalInfo = {
-            slotNumber,
+            proposalSlotNumber,
             archive: proposal.archive.toString(),
-            proposer: proposer.toString(),
-            txCount: proposal.txHashes.length
+            proposer: proposer?.toString()
         };
-        this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
+        this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
             ...proposalInfo,
-            txHashes: proposal.txHashes.map((t)=>t.toString()),
             fishermanMode: this.config.fishermanMode || false
         });
-        // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
+        // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
+        // Uses the cached result from the all-nodes callback if available (avoids double validation).
+        let checkpointNumber;
         if (this.config.skipCheckpointProposalValidation) {
-            this.log.warn(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
+            this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
+            checkpointNumber = CheckpointNumber(0);
         } else {
-            const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
+            const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
             if (!validationResult.isValid) {
                 this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
                 return undefined;
             }
-        }
-        // Upload blobs to filestore if we can (fire and forget)
-        if (this.blobClient.canUpload()) {
-            void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
+            checkpointNumber = validationResult.checkpointNumber;
         }
         // Check that I have any address in current committee before attesting
         // In fisherman mode, we still create attestations for validation even if not in committee
@@ -361,12 +360,22 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             return undefined;
         }
         // Provided all of the above checks pass, we can attest to the proposal
-        this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
+        this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`, {
             ...proposalInfo,
             inCommittee: partOfCommittee,
             fishermanMode: this.config.fishermanMode || false
         });
         this.metrics.incSuccessfulAttestations(inCommittee.length);
+        // Track epoch participation per attester: count each (attester, epoch) pair at most once
+        const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
+        for (const attester of inCommittee){
+            const key = attester.toString();
+            const lastEpoch = this.lastAttestedEpochByAttester.get(key);
+            if (lastEpoch === undefined || proposalEpoch > lastEpoch) {
+                this.lastAttestedEpochByAttester.set(key, proposalEpoch);
+                this.metrics.incAttestedEpochCount(attester);
+            }
+        }
         // Determine which validators should attest
         let attestors;
         if (partOfCommittee) {
@@ -383,13 +392,13 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
         }
         if (this.config.fishermanMode) {
             // bail out early and don't save attestations to the pool in fisherman mode
-            this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
+            this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
                 ...proposalInfo,
                 attestors: attestors.map((a)=>a.toString())
             });
             return undefined;
         }
-        return await this.createCheckpointAttestationsFromProposal(proposal, attestors);
+        return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
     }
     /**
    * Checks if we should attest to a slot based on equivocation prevention rules.
@@ -406,160 +415,18 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
         }
         return true;
     }
-    async createCheckpointAttestationsFromProposal(proposal, attestors = []) {
+    async createCheckpointAttestationsFromProposal(proposal, attestors = [], checkpointNumber) {
         // Equivocation check: must happen right before signing to minimize the race window
         if (!this.shouldAttestToSlot(proposal.slotNumber)) {
             return undefined;
         }
-        const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
+        const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
         // Track the proposal we attested to (to prevent equivocation)
         this.lastAttestedProposal = proposal;
         await this.p2pClient.addOwnCheckpointAttestations(attestations);
         return attestations;
     }
     /**
-   * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
-   * @returns Validation result with isValid flag and reason if invalid.
-   */ async validateCheckpointProposal(proposal, proposalInfo) {
-        const slot = proposal.slotNumber;
-        // Timeout block syncing at the start of the next slot
-        const config = this.checkpointsBuilder.getConfig();
-        const nextSlotTimestampSeconds = Number(getTimestampForSlot(SlotNumber(slot + 1), config));
-        const timeoutSeconds = Math.max(1, nextSlotTimestampSeconds - Math.floor(this.dateProvider.now() / 1000));
-        // Wait for last block to sync by archive
-        let lastBlockHeader;
-        try {
-            lastBlockHeader = await retryUntil(async ()=>{
-                await this.blockSource.syncImmediate();
-                return this.blockSource.getBlockHeaderByArchive(proposal.archive);
-            }, `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`, timeoutSeconds, 0.5);
-        } catch (err) {
-            if (err instanceof TimeoutError) {
-                this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
-                return {
-                    isValid: false,
-                    reason: 'last_block_not_found'
-                };
-            }
-            this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
-            return {
-                isValid: false,
-                reason: 'block_fetch_error'
-            };
-        }
-        if (!lastBlockHeader) {
-            this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
-            return {
-                isValid: false,
-                reason: 'last_block_not_found'
-            };
-        }
-        // Get all full blocks for the slot and checkpoint
-        const blocks = await this.blockSource.getBlocksForSlot(slot);
-        if (blocks.length === 0) {
-            this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
-            return {
-                isValid: false,
-                reason: 'no_blocks_for_slot'
-            };
-        }
-        // Ensure the last block for this slot matches the archive in the checkpoint proposal
-        if (!blocks.at(-1)?.archive.root.equals(proposal.archive)) {
-            this.log.warn(`Last block archive mismatch for checkpoint proposal`, proposalInfo);
-            return {
-                isValid: false,
-                reason: 'last_block_archive_mismatch'
-            };
-        }
-        this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
-            ...proposalInfo,
-            blockNumbers: blocks.map((b)=>b.number)
-        });
-        // Get checkpoint constants from first block
-        const firstBlock = blocks[0];
-        const constants = this.extractCheckpointConstants(firstBlock);
-        const checkpointNumber = firstBlock.checkpointNumber;
-        // Get L1-to-L2 messages for this checkpoint
-        const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
-        // Collect the out hashes of all the checkpoints before this one in the same epoch
-        const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
-        const previousCheckpointOutHashes = (await this.blockSource.getCheckpointsDataForEpoch(epoch)).filter((c)=>c.checkpointNumber < checkpointNumber).map((c)=>c.checkpointOutHash);
-        // Fork world state at the block before the first block
-        const parentBlockNumber = BlockNumber(firstBlock.number - 1);
-        const fork = await this.worldState.fork(parentBlockNumber);
-        try {
-            // Create checkpoint builder with all existing blocks
-            const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(checkpointNumber, constants, proposal.feeAssetPriceModifier, l1ToL2Messages, previousCheckpointOutHashes, fork, blocks, this.log.getBindings());
-            // Complete the checkpoint to get computed values
-            const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
-            // Compare checkpoint header with proposal
-            if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
-                this.log.warn(`Checkpoint header mismatch`, {
-                    ...proposalInfo,
-                    computed: computedCheckpoint.header.toInspect(),
-                    proposal: proposal.checkpointHeader.toInspect()
-                });
-                return {
-                    isValid: false,
-                    reason: 'checkpoint_header_mismatch'
-                };
-            }
-            // Compare archive root with proposal
-            if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
-                this.log.warn(`Archive root mismatch`, {
-                    ...proposalInfo,
-                    computed: computedCheckpoint.archive.root.toString(),
-                    proposal: proposal.archive.toString()
-                });
-                return {
-                    isValid: false,
-                    reason: 'archive_mismatch'
-                };
-            }
-            // Check that the accumulated epoch out hash matches the value in the proposal.
-            // The epoch out hash is the accumulated hash of all checkpoint out hashes in the epoch.
-            const checkpointOutHash = computedCheckpoint.getCheckpointOutHash();
-            const computedEpochOutHash = accumulateCheckpointOutHashes([
-                ...previousCheckpointOutHashes,
-                checkpointOutHash
-            ]);
-            const proposalEpochOutHash = proposal.checkpointHeader.epochOutHash;
-            if (!computedEpochOutHash.equals(proposalEpochOutHash)) {
-                this.log.warn(`Epoch out hash mismatch`, {
-                    proposalEpochOutHash: proposalEpochOutHash.toString(),
-                    computedEpochOutHash: computedEpochOutHash.toString(),
-                    checkpointOutHash: checkpointOutHash.toString(),
-                    previousCheckpointOutHashes: previousCheckpointOutHashes.map((h)=>h.toString()),
-                    ...proposalInfo
-                });
-                return {
-                    isValid: false,
-                    reason: 'out_hash_mismatch'
-                };
-            }
-            this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
-            return {
-                isValid: true
-            };
-        } finally{
-            await fork.close();
-        }
-    }
-    /**
-   * Extract checkpoint global variables from a block.
-   */ extractCheckpointConstants(block) {
-        const gv = block.header.globalVariables;
-        return {
-            chainId: gv.chainId,
-            version: gv.version,
-            slotNumber: gv.slotNumber,
-            timestamp: gv.timestamp,
-            coinbase: gv.coinbase,
-            feeRecipient: gv.feeRecipient,
-            gasFees: gv.gasFees
-        };
-    }
-    /**
    * Uploads blobs for a checkpoint to the filestore (fire and forget).
    */ async uploadBlobsForCheckpoint(proposal, proposalInfo) {
         try {
@@ -644,7 +511,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             }
         ]);
     }
-    async createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
+    async createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
         // Validate that we're not creating a proposal for an older or equal position
         if (this.lastProposedBlock) {
             const lastSlot = this.lastProposedBlock.slotNumber;
@@ -655,14 +522,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             }
         }
         this.log.info(`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`);
-        const newProposal = await this.validationService.createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
+        const newProposal = await this.validationService.createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
             ...options,
             broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal
         });
         this.lastProposedBlock = newProposal;
         return newProposal;
     }
-    async createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options = {}) {
+    async createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options = {}) {
         // Validate that we're not creating a proposal for an older or equal slot
         if (this.lastProposedCheckpoint) {
             const lastSlot = this.lastProposedCheckpoint.slotNumber;
@@ -672,23 +539,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             }
         }
         this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
-        const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options);
+        const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options);
         this.lastProposedCheckpoint = newProposal;
         return newProposal;
     }
     async broadcastBlockProposal(proposal) {
         await this.p2pClient.broadcastProposal(proposal);
     }
-    async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber) {
-        return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
+    async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber) {
+        return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber);
     }
-    async collectOwnAttestations(proposal) {
+    async collectOwnAttestations(proposal, checkpointNumber) {
         const slot = proposal.slotNumber;
         const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
         this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, {
             inCommittee
         });
-        const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
+        const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
         if (!attestations) {
             return [];
         }
@@ -700,7 +567,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
         });
         return attestations;
     }
-    async collectAttestations(proposal, required, deadline) {
+    async collectAttestations(proposal, required, deadline, checkpointNumber) {
         // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
         const slot = proposal.slotNumber;
         this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
@@ -708,7 +575,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             this.log.error(`Deadline ${deadline.toISOString()} for collecting ${required} attestations for slot ${slot} is in the past`);
             throw new AttestationTimeoutError(0, required, slot);
         }
-        await this.collectOwnAttestations(proposal);
+        await this.collectOwnAttestations(proposal, checkpointNumber);
         const proposalId = proposal.archive.toString();
         const myAddresses = this.getValidatorAddresses();
         let attestations = [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aztec/validator-client",
-  "version": "0.0.1-commit.934299a21",
+  "version": "0.0.1-commit.949a33fd8",
   "main": "dest/index.js",
   "type": "module",
   "exports": {
@@ -64,30 +64,30 @@
     ]
   },
   "dependencies": {
-    "@aztec/blob-client": "0.0.1-commit.934299a21",
-    "@aztec/blob-lib": "0.0.1-commit.934299a21",
-    "@aztec/constants": "0.0.1-commit.934299a21",
-    "@aztec/epoch-cache": "0.0.1-commit.934299a21",
-    "@aztec/ethereum": "0.0.1-commit.934299a21",
-    "@aztec/foundation": "0.0.1-commit.934299a21",
-    "@aztec/node-keystore": "0.0.1-commit.934299a21",
-    "@aztec/noir-protocol-circuits-types": "0.0.1-commit.934299a21",
-    "@aztec/p2p": "0.0.1-commit.934299a21",
-    "@aztec/protocol-contracts": "0.0.1-commit.934299a21",
-    "@aztec/prover-client": "0.0.1-commit.934299a21",
-    "@aztec/simulator": "0.0.1-commit.934299a21",
-    "@aztec/slasher": "0.0.1-commit.934299a21",
-    "@aztec/stdlib": "0.0.1-commit.934299a21",
-    "@aztec/telemetry-client": "0.0.1-commit.934299a21",
-    "@aztec/validator-ha-signer": "0.0.1-commit.934299a21",
+    "@aztec/blob-client": "0.0.1-commit.949a33fd8",
+    "@aztec/blob-lib": "0.0.1-commit.949a33fd8",
+    "@aztec/constants": "0.0.1-commit.949a33fd8",
+    "@aztec/epoch-cache": "0.0.1-commit.949a33fd8",
+    "@aztec/ethereum": "0.0.1-commit.949a33fd8",
+    "@aztec/foundation": "0.0.1-commit.949a33fd8",
+    "@aztec/node-keystore": "0.0.1-commit.949a33fd8",
+    "@aztec/noir-protocol-circuits-types": "0.0.1-commit.949a33fd8",
+    "@aztec/p2p": "0.0.1-commit.949a33fd8",
+    "@aztec/protocol-contracts": "0.0.1-commit.949a33fd8",
+    "@aztec/prover-client": "0.0.1-commit.949a33fd8",
+    "@aztec/simulator": "0.0.1-commit.949a33fd8",
+    "@aztec/slasher": "0.0.1-commit.949a33fd8",
+    "@aztec/stdlib": "0.0.1-commit.949a33fd8",
+    "@aztec/telemetry-client": "0.0.1-commit.949a33fd8",
+    "@aztec/validator-ha-signer": "0.0.1-commit.949a33fd8",
     "koa": "^2.16.1",
     "koa-router": "^13.1.1",
     "tslib": "^2.4.0",
     "viem": "npm:@aztec/viem@2.38.2"
   },
   "devDependencies": {
-    "@aztec/archiver": "0.0.1-commit.934299a21",
-    "@aztec/world-state": "0.0.1-commit.934299a21",
+    "@aztec/archiver": "0.0.1-commit.949a33fd8",
+    "@aztec/world-state": "0.0.1-commit.949a33fd8",
     "@electric-sql/pglite": "^0.3.14",
     "@jest/globals": "^30.0.0",
     "@types/jest": "^30.0.0",