@aztec/validator-client 0.0.1-commit.7b86788 → 0.0.1-commit.7cbc774

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (40) hide show
  1. package/README.md +51 -11
  2. package/dest/checkpoint_builder.d.ts +14 -4
  3. package/dest/checkpoint_builder.d.ts.map +1 -1
  4. package/dest/checkpoint_builder.js +101 -30
  5. package/dest/config.d.ts +1 -1
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +33 -7
  8. package/dest/duties/validation_service.d.ts +12 -13
  9. package/dest/duties/validation_service.d.ts.map +1 -1
  10. package/dest/duties/validation_service.js +33 -45
  11. package/dest/factory.d.ts +10 -4
  12. package/dest/factory.d.ts.map +1 -1
  13. package/dest/factory.js +11 -5
  14. package/dest/index.d.ts +2 -2
  15. package/dest/index.d.ts.map +1 -1
  16. package/dest/index.js +1 -1
  17. package/dest/key_store/ha_key_store.js +1 -1
  18. package/dest/metrics.d.ts +14 -2
  19. package/dest/metrics.d.ts.map +1 -1
  20. package/dest/metrics.js +24 -0
  21. package/dest/proposal_handler.d.ts +135 -0
  22. package/dest/proposal_handler.d.ts.map +1 -0
  23. package/dest/proposal_handler.js +1111 -0
  24. package/dest/validator.d.ts +31 -21
  25. package/dest/validator.d.ts.map +1 -1
  26. package/dest/validator.js +260 -263
  27. package/package.json +19 -19
  28. package/src/checkpoint_builder.ts +124 -35
  29. package/src/config.ts +33 -6
  30. package/src/duties/validation_service.ts +52 -54
  31. package/src/factory.ts +20 -3
  32. package/src/index.ts +1 -1
  33. package/src/key_store/ha_key_store.ts +1 -1
  34. package/src/metrics.ts +37 -1
  35. package/src/proposal_handler.ts +1207 -0
  36. package/src/validator.ts +338 -305
  37. package/dest/block_proposal_handler.d.ts +0 -63
  38. package/dest/block_proposal_handler.d.ts.map +0 -1
  39. package/dest/block_proposal_handler.js +0 -532
  40. package/src/block_proposal_handler.ts +0 -535
package/dest/validator.js CHANGED
@@ -1,48 +1,70 @@
1
1
  import { getBlobsPerL1Block } from '@aztec/blob-lib';
2
- import { validateFeeAssetPriceModifier } from '@aztec/ethereum/contracts';
3
- import { BlockNumber, SlotNumber } from '@aztec/foundation/branded-types';
4
- import { TimeoutError } from '@aztec/foundation/error';
2
+ import { CheckpointNumber } from '@aztec/foundation/branded-types';
3
+ import { FifoSet } from '@aztec/foundation/fifo-set';
5
4
  import { createLogger } from '@aztec/foundation/log';
6
- import { retryUntil } from '@aztec/foundation/retry';
7
5
  import { RunningPromise } from '@aztec/foundation/running-promise';
8
6
  import { sleep } from '@aztec/foundation/sleep';
9
7
  import { DateProvider } from '@aztec/foundation/timer';
10
8
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
11
- import { OffenseType, WANT_TO_SLASH_EVENT } from '@aztec/slasher';
12
- import { getEpochAtSlot, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
13
- import { accumulateCheckpointOutHashes } from '@aztec/stdlib/messaging';
9
+ import { OffenseType, WANT_TO_CLEAR_SLASH_EVENT, WANT_TO_SLASH_EVENT, getOffenseTypeName } from '@aztec/slasher';
10
+ import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
14
11
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
15
12
  import { getTelemetryClient } from '@aztec/telemetry-client';
16
- import { createHASigner } from '@aztec/validator-ha-signer/factory';
13
+ import { createHASigner, createLocalSignerWithProtection, createSignerFromSharedDb } from '@aztec/validator-ha-signer/factory';
17
14
  import { DutyType } from '@aztec/validator-ha-signer/types';
18
15
  import { EventEmitter } from 'events';
19
- import { BlockProposalHandler } from './block_proposal_handler.js';
20
16
  import { ValidationService } from './duties/validation_service.js';
21
17
  import { HAKeyStore } from './key_store/ha_key_store.js';
22
18
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
23
19
  import { ValidatorMetrics } from './metrics.js';
20
+ import { ProposalHandler } from './proposal_handler.js';
24
21
  // We maintain a set of proposers who have proposed invalid blocks.
25
22
  // Just cap the set to avoid unbounded growth.
26
23
  const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
24
+ const MAX_TRACKED_INVALID_PROPOSAL_SLOTS = 1000;
25
+ const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
26
+ const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
27
27
  // What errors from the block proposal handler result in slashing
28
28
  const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
29
29
  'state_mismatch',
30
- 'failed_txs'
30
+ 'failed_txs',
31
+ 'global_variables_mismatch',
32
+ 'invalid_proposal',
33
+ 'parent_block_wrong_slot',
34
+ 'in_hash_mismatch'
31
35
  ];
36
+ const SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT = {
37
+ // enabled
38
+ ['invalid_fee_asset_price_modifier']: true,
39
+ ['checkpoint_header_mismatch']: true,
40
+ // These late mismatches should normally be caught by earlier checks, but if reached after validating the local
41
+ // checkpoint inputs, the proposer-signed payload disagrees with deterministic recomputation.
42
+ ['archive_mismatch']: true,
43
+ ['out_hash_mismatch']: true,
44
+ ['no_blocks_for_slot']: true,
45
+ ['too_many_blocks_in_checkpoint']: true,
46
+ ['checkpoint_validation_failed']: true,
47
+ ['last_block_archive_mismatch']: true,
48
+ // disabled
49
+ ['invalid_signature']: false,
50
+ ['last_block_not_found']: false,
51
+ ['block_fetch_error']: false,
52
+ ['checkpoint_already_published']: false
53
+ };
32
54
  /**
33
55
  * Validator Client
34
56
  */ export class ValidatorClient extends EventEmitter {
35
57
  keyStore;
36
58
  epochCache;
37
59
  p2pClient;
38
- blockProposalHandler;
60
+ proposalHandler;
39
61
  blockSource;
40
62
  checkpointsBuilder;
41
63
  worldState;
42
64
  l1ToL2MessageSource;
43
65
  config;
44
66
  blobClient;
45
- haSigner;
67
+ slashingProtectionSigner;
46
68
  dateProvider;
47
69
  tracer;
48
70
  validationService;
@@ -54,15 +76,21 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
54
76
  /** Tracks the last checkpoint proposal we created. */ lastProposedCheckpoint;
55
77
  lastEpochForCommitteeUpdateLoop;
56
78
  epochCacheUpdateLoop;
79
+ /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */ lastAttestedEpochByAttester;
57
80
  proposersOfInvalidBlocks;
81
+ slotsWithInvalidProposals;
82
+ invalidCheckpointProposalOffenseKeys;
83
+ badAttestationOffenseKeys;
84
+ slotsWithProposalEquivocation;
58
85
  /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */ lastAttestedProposal;
59
- constructor(keyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, haSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
60
- super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.blockProposalHandler = blockProposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.haSigner = haSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.proposersOfInvalidBlocks = new Set();
86
+ constructor(keyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
87
+ super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.proposalHandler = proposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = FifoSet.withLimit(MAX_PROPOSERS_OF_INVALID_BLOCKS), this.slotsWithInvalidProposals = FifoSet.withLimit(MAX_TRACKED_INVALID_PROPOSAL_SLOTS), this.invalidCheckpointProposalOffenseKeys = FifoSet.withLimit(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS), this.badAttestationOffenseKeys = FifoSet.withLimit(MAX_TRACKED_BAD_ATTESTATIONS), this.slotsWithProposalEquivocation = FifoSet.withLimit(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
61
88
  // Create child logger with fisherman prefix if in fisherman mode
62
89
  this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
63
90
  this.tracer = telemetry.getTracer('Validator');
64
91
  this.metrics = new ValidatorMetrics(telemetry);
65
- this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
92
+ this.validationService = new ValidationService(keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
93
+ this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo)=>this.handleInvalidCheckpointProposal(proposal, result, proposalInfo));
66
94
  // Refresh epoch cache every second to trigger alert if participation in committee changes
67
95
  this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
68
96
  const myAddresses = this.getValidatorAddresses();
@@ -96,6 +124,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
96
124
  this.log.trace(`No committee found for slot`);
97
125
  return;
98
126
  }
127
+ this.metrics.setCurrentEpoch(epoch);
99
128
  if (epoch !== this.lastEpochForCommitteeUpdateLoop) {
100
129
  const me = this.getValidatorAddresses();
101
130
  const committeeSet = new Set(committee.map((v)=>v.toString()));
@@ -111,40 +140,65 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
111
140
  this.log.error(`Error updating epoch committee`, err);
112
141
  }
113
142
  }
114
- static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient()) {
143
+ static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, reexecutionTracker, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), slashingProtectionDb) {
115
144
  const metrics = new ValidatorMetrics(telemetry);
116
145
  const blockProposalValidator = new BlockProposalValidator(epochCache, {
117
- txsPermitted: !config.disableTransactions
146
+ txsPermitted: !config.disableTransactions,
147
+ maxTxsPerBlock: config.validateMaxTxsPerBlock,
148
+ maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
149
+ skipSlotValidation: config.skipProposalSlotValidation,
150
+ signatureContext: {
151
+ chainId: config.l1ChainId,
152
+ rollupAddress: config.rollupAddress
153
+ }
118
154
  });
119
- const blockProposalHandler = new BlockProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, metrics, dateProvider, telemetry);
155
+ const proposalHandler = new ProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, blobClient, reexecutionTracker, metrics, dateProvider, telemetry, undefined);
120
156
  const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
121
- let validatorKeyStore = nodeKeystoreAdapter;
122
- let haSigner;
123
- if (config.haSigningEnabled) {
157
+ let slashingProtectionSigner;
158
+ if (slashingProtectionDb) {
159
+ // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
160
+ ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
161
+ telemetryClient: telemetry,
162
+ dateProvider
163
+ }));
164
+ } else if (config.haSigningEnabled) {
165
+ // Multi-node HA mode: use PostgreSQL-backed distributed locking.
124
166
  // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
125
167
  const haConfig = {
126
168
  ...config,
127
169
  maxStuckDutiesAgeMs: config.maxStuckDutiesAgeMs ?? epochCache.getL1Constants().slotDuration * 2 * 1000
128
170
  };
129
- const { signer } = await createHASigner(haConfig, {
171
+ ({ signer: slashingProtectionSigner } = await createHASigner(haConfig, {
130
172
  telemetryClient: telemetry,
131
173
  dateProvider
132
- });
133
- haSigner = signer;
134
- validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, signer);
174
+ }));
175
+ } else {
176
+ // Single-node mode: use LMDB-backed local signing protection.
177
+ // This prevents double-signing if the node crashes and restarts mid-proposal.
178
+ ({ signer: slashingProtectionSigner } = await createLocalSignerWithProtection(config, {
179
+ telemetryClient: telemetry,
180
+ dateProvider
181
+ }));
135
182
  }
136
- const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, haSigner, dateProvider, telemetry);
183
+ const validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
184
+ const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider, telemetry);
137
185
  return validator;
138
186
  }
139
187
  getValidatorAddresses() {
140
188
  return this.keyStore.getAddresses().filter((addr)=>!this.config.disabledValidators.some((disabled)=>disabled.equals(addr)));
141
189
  }
142
- getBlockProposalHandler() {
143
- return this.blockProposalHandler;
190
+ getProposalHandler() {
191
+ return this.proposalHandler;
144
192
  }
145
193
  signWithAddress(addr, msg, context) {
146
194
  return this.keyStore.signTypedDataWithAddress(addr, msg, context);
147
195
  }
196
+ getSignatureContext() {
197
+ return {
198
+ chainId: this.config.l1ChainId,
199
+ rollupAddress: this.config.rollupAddress
200
+ };
201
+ }
148
202
  getCoinbaseForAttestor(attestor) {
149
203
  return this.keyStore.getCoinbaseAddress(attestor);
150
204
  }
@@ -154,25 +208,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
154
208
  getConfig() {
155
209
  return this.config;
156
210
  }
211
+ hasProposalEquivocation(slotNumber) {
212
+ return this.slotsWithProposalEquivocation.has(slotNumber);
213
+ }
214
+ hasInvalidProposals(slotNumber) {
215
+ return this.slotsWithInvalidProposals.has(slotNumber);
216
+ }
157
217
  updateConfig(config) {
158
218
  this.config = {
159
219
  ...this.config,
160
220
  ...config
161
221
  };
222
+ this.proposalHandler.updateConfig(config);
162
223
  }
163
224
  reloadKeystore(newManager) {
164
- if (this.config.haSigningEnabled && !this.haSigner) {
165
- this.log.warn('HA signing is enabled in config but was not initialized at startup. ' + 'Restart the node to enable HA signing.');
166
- } else if (!this.config.haSigningEnabled && this.haSigner) {
167
- this.log.warn('HA signing was disabled via config update but the HA signer is still active. ' + 'Restart the node to fully disable HA signing.');
168
- }
169
225
  const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
170
- if (this.haSigner) {
171
- this.keyStore = new HAKeyStore(newAdapter, this.haSigner);
172
- } else {
173
- this.keyStore = newAdapter;
174
- }
175
- this.validationService = new ValidationService(this.keyStore, this.log.createChild('validation-service'));
226
+ this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
227
+ this.validationService = new ValidationService(this.keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
176
228
  }
177
229
  async start() {
178
230
  if (this.epochCacheUpdateLoop.isRunning()) {
@@ -205,7 +257,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
205
257
  // The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
206
258
  // and processed separately via the block handler above.
207
259
  const checkpointHandler = (checkpoint, proposalSender)=>this.attestToCheckpointProposal(checkpoint, proposalSender);
208
- this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
260
+ this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
209
261
  // Duplicate proposal handler - triggers slashing for equivocation
210
262
  this.p2pClient.registerDuplicateProposalCallback((info)=>{
211
263
  this.handleDuplicateProposal(info);
@@ -214,6 +266,9 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
214
266
  this.p2pClient.registerDuplicateAttestationCallback((info)=>{
215
267
  this.handleDuplicateAttestation(info);
216
268
  });
269
+ this.p2pClient.registerCheckpointAttestationCallback((attestation)=>{
270
+ this.handleCheckpointAttestation(attestation);
271
+ });
217
272
  const myAddresses = this.getValidatorAddresses();
218
273
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
219
274
  await this.p2pClient.addReqRespSubProtocol(ReqRespSubProtocol.AUTH, this.handleAuthRequest.bind(this));
@@ -234,13 +289,12 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
234
289
  this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
235
290
  return false;
236
291
  }
237
- // Ignore proposals from ourselves (may happen in HA setups)
292
+ // Log self-proposals from HA peers (same validator key on different nodes)
238
293
  if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
239
- this.log.warn(`Ignoring block proposal from self for slot ${slotNumber}`, {
294
+ this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
240
295
  proposer: proposer.toString(),
241
296
  slotNumber
242
297
  });
243
- return false;
244
298
  }
245
299
  // Check if we're in the committee (for metrics purposes)
246
300
  const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
@@ -254,14 +308,11 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
254
308
  txHashes: proposal.txHashes.map((t)=>t.toString()),
255
309
  fishermanMode: this.config.fishermanMode || false
256
310
  });
257
- // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
258
- // In fisherman mode, we always reexecute to validate proposals.
259
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
260
- const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute || partOfCommittee && validatorReexecute || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
261
- const validationResult = await this.blockProposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
311
+ // Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
312
+ const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
262
313
  if (!validationResult.isValid) {
263
- this.log.warn(`Block proposal validation failed: ${validationResult.reason}`, proposalInfo);
264
314
  const reason = validationResult.reason || 'unknown';
315
+ this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
265
316
  // Classify failure reason: bad proposal vs node issue
266
317
  const badProposalReasons = [
267
318
  'invalid_proposal',
@@ -276,10 +327,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
276
327
  // Node issues so we can't validate
277
328
  this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
278
329
  }
279
- // Slash invalid block proposals (can happen even when not in committee)
280
- if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) && slashBroadcastedInvalidBlockPenalty > 0n) {
281
- this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
330
+ if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)) {
331
+ this.log.info(`Detected invalid block proposal offense`, {
332
+ ...proposalInfo,
333
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
334
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL)
335
+ });
282
336
  this.slashInvalidBlock(proposal);
337
+ this.markInvalidProposalSlot(proposal.slotNumber);
283
338
  }
284
339
  return false;
285
340
  }
@@ -301,58 +356,50 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
301
356
  * the lastBlock is extracted and processed separately via the block handler.
302
357
  * @returns Checkpoint attestations if valid, undefined otherwise
303
358
  */ async attestToCheckpointProposal(proposal, _proposalSender) {
304
- const slotNumber = proposal.slotNumber;
359
+ const proposalSlotNumber = proposal.slotNumber;
305
360
  const proposer = proposal.getSender();
306
361
  // If escape hatch is open for this slot's epoch, do not attest.
307
- if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
308
- this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
362
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
363
+ this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
309
364
  return undefined;
310
365
  }
311
- // Reject proposals with invalid signatures
312
- if (!proposer) {
313
- this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
366
+ // Early-out for equivocation: refuses if we've already attested to a higher slot.
367
+ if (!this.shouldAttestToSlot(proposalSlotNumber)) {
314
368
  return undefined;
315
369
  }
316
370
  // Ignore proposals from ourselves (may happen in HA setups)
317
- if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
318
- this.log.warn(`Ignoring block proposal from self for slot ${slotNumber}`, {
371
+ if (proposer && this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
372
+ this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
319
373
  proposer: proposer.toString(),
320
- slotNumber
374
+ proposalSlotNumber
321
375
  });
322
376
  return undefined;
323
377
  }
324
- // Validate fee asset price modifier is within allowed range
325
- if (!validateFeeAssetPriceModifier(proposal.feeAssetPriceModifier)) {
326
- this.log.warn(`Received checkpoint proposal with invalid feeAssetPriceModifier ${proposal.feeAssetPriceModifier} for slot ${slotNumber}`);
327
- return undefined;
328
- }
329
- // Check that I have any address in current committee before attesting
330
- const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
378
+ // Check that I have any address in the committee where this checkpoint will land before attesting
379
+ const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
331
380
  const partOfCommittee = inCommittee.length > 0;
332
381
  const proposalInfo = {
333
- slotNumber,
382
+ proposalSlotNumber,
334
383
  archive: proposal.archive.toString(),
335
- proposer: proposer.toString(),
336
- txCount: proposal.txHashes.length
384
+ proposer: proposer?.toString()
337
385
  };
338
- this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
386
+ this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
339
387
  ...proposalInfo,
340
- txHashes: proposal.txHashes.map((t)=>t.toString()),
341
388
  fishermanMode: this.config.fishermanMode || false
342
389
  });
343
- // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
390
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
391
+ // Uses the cached result from the all-nodes callback if available (avoids double validation).
392
+ let checkpointNumber;
344
393
  if (this.config.skipCheckpointProposalValidation) {
345
- this.log.warn(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
394
+ this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
395
+ checkpointNumber = CheckpointNumber(0);
346
396
  } else {
347
- const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
397
+ const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
348
398
  if (!validationResult.isValid) {
349
399
  this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
350
400
  return undefined;
351
401
  }
352
- }
353
- // Upload blobs to filestore if we can (fire and forget)
354
- if (this.blobClient.canUpload()) {
355
- void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
402
+ checkpointNumber = validationResult.checkpointNumber;
356
403
  }
357
404
  // Check that I have any address in current committee before attesting
358
405
  // In fisherman mode, we still create attestations for validation even if not in committee
@@ -361,12 +408,22 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
361
408
  return undefined;
362
409
  }
363
410
  // Provided all of the above checks pass, we can attest to the proposal
364
- this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
411
+ this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`, {
365
412
  ...proposalInfo,
366
413
  inCommittee: partOfCommittee,
367
414
  fishermanMode: this.config.fishermanMode || false
368
415
  });
369
416
  this.metrics.incSuccessfulAttestations(inCommittee.length);
417
+ // Track epoch participation per attester: count each (attester, epoch) pair at most once
418
+ const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
419
+ for (const attester of inCommittee){
420
+ const key = attester.toString();
421
+ const lastEpoch = this.lastAttestedEpochByAttester.get(key);
422
+ if (lastEpoch === undefined || proposalEpoch > lastEpoch) {
423
+ this.lastAttestedEpochByAttester.set(key, proposalEpoch);
424
+ this.metrics.incAttestedEpochCount(attester);
425
+ }
426
+ }
370
427
  // Determine which validators should attest
371
428
  let attestors;
372
429
  if (partOfCommittee) {
@@ -383,13 +440,13 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
383
440
  }
384
441
  if (this.config.fishermanMode) {
385
442
  // bail out early and don't save attestations to the pool in fisherman mode
386
- this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
443
+ this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
387
444
  ...proposalInfo,
388
445
  attestors: attestors.map((a)=>a.toString())
389
446
  });
390
447
  return undefined;
391
448
  }
392
- return await this.createCheckpointAttestationsFromProposal(proposal, attestors);
449
+ return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
393
450
  }
394
451
  /**
395
452
  * Checks if we should attest to a slot based on equivocation prevention rules.
@@ -406,164 +463,24 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
406
463
  }
407
464
  return true;
408
465
  }
409
- async createCheckpointAttestationsFromProposal(proposal, attestors = []) {
466
+ async createCheckpointAttestationsFromProposal(proposal, attestors = [], checkpointNumber) {
410
467
  // Equivocation check: must happen right before signing to minimize the race window
411
468
  if (!this.shouldAttestToSlot(proposal.slotNumber)) {
412
469
  return undefined;
413
470
  }
414
- const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
471
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
415
472
  // Track the proposal we attested to (to prevent equivocation)
416
473
  this.lastAttestedProposal = proposal;
417
474
  await this.p2pClient.addOwnCheckpointAttestations(attestations);
418
475
  return attestations;
419
476
  }
420
477
  /**
421
- * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
422
- * @returns Validation result with isValid flag and reason if invalid.
423
- */ async validateCheckpointProposal(proposal, proposalInfo) {
424
- const slot = proposal.slotNumber;
425
- // Timeout block syncing at the start of the next slot
426
- const config = this.checkpointsBuilder.getConfig();
427
- const nextSlotTimestampSeconds = Number(getTimestampForSlot(SlotNumber(slot + 1), config));
428
- const timeoutSeconds = Math.max(1, nextSlotTimestampSeconds - Math.floor(this.dateProvider.now() / 1000));
429
- // Wait for last block to sync by archive
430
- let lastBlockHeader;
431
- try {
432
- lastBlockHeader = await retryUntil(async ()=>{
433
- await this.blockSource.syncImmediate();
434
- return this.blockSource.getBlockHeaderByArchive(proposal.archive);
435
- }, `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`, timeoutSeconds, 0.5);
436
- } catch (err) {
437
- if (err instanceof TimeoutError) {
438
- this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
439
- return {
440
- isValid: false,
441
- reason: 'last_block_not_found'
442
- };
443
- }
444
- this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
445
- return {
446
- isValid: false,
447
- reason: 'block_fetch_error'
448
- };
449
- }
450
- if (!lastBlockHeader) {
451
- this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
452
- return {
453
- isValid: false,
454
- reason: 'last_block_not_found'
455
- };
456
- }
457
- // Get all full blocks for the slot and checkpoint
458
- const blocks = await this.blockSource.getBlocksForSlot(slot);
459
- if (blocks.length === 0) {
460
- this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
461
- return {
462
- isValid: false,
463
- reason: 'no_blocks_for_slot'
464
- };
465
- }
466
- // Ensure the last block for this slot matches the archive in the checkpoint proposal
467
- if (!blocks.at(-1)?.archive.root.equals(proposal.archive)) {
468
- this.log.warn(`Last block archive mismatch for checkpoint proposal`, proposalInfo);
469
- return {
470
- isValid: false,
471
- reason: 'last_block_archive_mismatch'
472
- };
473
- }
474
- this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
475
- ...proposalInfo,
476
- blockNumbers: blocks.map((b)=>b.number)
477
- });
478
- // Get checkpoint constants from first block
479
- const firstBlock = blocks[0];
480
- const constants = this.extractCheckpointConstants(firstBlock);
481
- const checkpointNumber = firstBlock.checkpointNumber;
482
- // Get L1-to-L2 messages for this checkpoint
483
- const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
484
- // Collect the out hashes of all the checkpoints before this one in the same epoch
485
- const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
486
- const previousCheckpointOutHashes = (await this.blockSource.getCheckpointsDataForEpoch(epoch)).filter((c)=>c.checkpointNumber < checkpointNumber).map((c)=>c.checkpointOutHash);
487
- // Fork world state at the block before the first block
488
- const parentBlockNumber = BlockNumber(firstBlock.number - 1);
489
- const fork = await this.worldState.fork(parentBlockNumber);
490
- try {
491
- // Create checkpoint builder with all existing blocks
492
- const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(checkpointNumber, constants, proposal.feeAssetPriceModifier, l1ToL2Messages, previousCheckpointOutHashes, fork, blocks, this.log.getBindings());
493
- // Complete the checkpoint to get computed values
494
- const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
495
- // Compare checkpoint header with proposal
496
- if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
497
- this.log.warn(`Checkpoint header mismatch`, {
498
- ...proposalInfo,
499
- computed: computedCheckpoint.header.toInspect(),
500
- proposal: proposal.checkpointHeader.toInspect()
501
- });
502
- return {
503
- isValid: false,
504
- reason: 'checkpoint_header_mismatch'
505
- };
506
- }
507
- // Compare archive root with proposal
508
- if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
509
- this.log.warn(`Archive root mismatch`, {
510
- ...proposalInfo,
511
- computed: computedCheckpoint.archive.root.toString(),
512
- proposal: proposal.archive.toString()
513
- });
514
- return {
515
- isValid: false,
516
- reason: 'archive_mismatch'
517
- };
518
- }
519
- // Check that the accumulated epoch out hash matches the value in the proposal.
520
- // The epoch out hash is the accumulated hash of all checkpoint out hashes in the epoch.
521
- const checkpointOutHash = computedCheckpoint.getCheckpointOutHash();
522
- const computedEpochOutHash = accumulateCheckpointOutHashes([
523
- ...previousCheckpointOutHashes,
524
- checkpointOutHash
525
- ]);
526
- const proposalEpochOutHash = proposal.checkpointHeader.epochOutHash;
527
- if (!computedEpochOutHash.equals(proposalEpochOutHash)) {
528
- this.log.warn(`Epoch out hash mismatch`, {
529
- proposalEpochOutHash: proposalEpochOutHash.toString(),
530
- computedEpochOutHash: computedEpochOutHash.toString(),
531
- checkpointOutHash: checkpointOutHash.toString(),
532
- previousCheckpointOutHashes: previousCheckpointOutHashes.map((h)=>h.toString()),
533
- ...proposalInfo
534
- });
535
- return {
536
- isValid: false,
537
- reason: 'out_hash_mismatch'
538
- };
539
- }
540
- this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
541
- return {
542
- isValid: true
543
- };
544
- } finally{
545
- await fork.close();
546
- }
547
- }
548
- /**
549
- * Extract checkpoint global variables from a block.
550
- */ extractCheckpointConstants(block) {
551
- const gv = block.header.globalVariables;
552
- return {
553
- chainId: gv.chainId,
554
- version: gv.version,
555
- slotNumber: gv.slotNumber,
556
- timestamp: gv.timestamp,
557
- coinbase: gv.coinbase,
558
- feeRecipient: gv.feeRecipient,
559
- gasFees: gv.gasFees
560
- };
561
- }
562
- /**
563
478
  * Uploads blobs for a checkpoint to the filestore (fire and forget).
564
479
  */ async uploadBlobsForCheckpoint(proposal, proposalInfo) {
565
480
  try {
566
- const lastBlockHeader = await this.blockSource.getBlockHeaderByArchive(proposal.archive);
481
+ const lastBlockHeader = (await this.blockSource.getBlockData({
482
+ archive: proposal.archive
483
+ }))?.header;
567
484
  if (!lastBlockHeader) {
568
485
  this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
569
486
  return;
@@ -591,11 +508,6 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
591
508
  this.log.warn(`Cannot slash proposal with invalid signature`);
592
509
  return;
593
510
  }
594
- // Trim the set if it's too big.
595
- if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
596
- // remove oldest proposer. `values` is guaranteed to be in insertion order.
597
- this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value);
598
- }
599
511
  this.proposersOfInvalidBlocks.add(proposer.toString());
600
512
  this.emit(WANT_TO_SLASH_EVENT, [
601
513
  {
@@ -606,17 +518,95 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
606
518
  }
607
519
  ]);
608
520
  }
521
+ handleInvalidCheckpointProposal(proposal, result, proposalInfo) {
522
+ if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
523
+ return;
524
+ }
525
+ this.markInvalidProposalSlot(proposal.slotNumber);
526
+ if (this.slashInvalidCheckpointProposal(proposal)) {
527
+ this.log.info(`Detected invalid checkpoint proposal offense`, {
528
+ ...proposalInfo,
529
+ reason: result.reason,
530
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
531
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL)
532
+ });
533
+ }
534
+ }
535
+ slashInvalidCheckpointProposal(proposal) {
536
+ const proposer = proposal.getSender();
537
+ if (!proposer) {
538
+ this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
539
+ slotNumber: proposal.slotNumber,
540
+ archive: proposal.archive.toString()
541
+ });
542
+ return false;
543
+ }
544
+ const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
545
+ const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
546
+ if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
547
+ return false;
548
+ }
549
+ this.emit(WANT_TO_SLASH_EVENT, [
550
+ {
551
+ validator: proposer,
552
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
553
+ offenseType,
554
+ epochOrSlot: BigInt(proposal.slotNumber)
555
+ }
556
+ ]);
557
+ return true;
558
+ }
559
+ markInvalidProposalSlot(slotNumber) {
560
+ this.slotsWithInvalidProposals.add(slotNumber);
561
+ }
562
+ handleCheckpointAttestation(attestation) {
563
+ const slotNumber = attestation.slotNumber;
564
+ if (!this.slotsWithInvalidProposals.has(slotNumber) || this.slotsWithProposalEquivocation.has(slotNumber)) {
565
+ return;
566
+ }
567
+ const attester = attestation.getSender();
568
+ if (!attester) {
569
+ this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
570
+ slotNumber,
571
+ archive: attestation.archive.toString()
572
+ });
573
+ return;
574
+ }
575
+ this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
576
+ }
577
+ slashAttestedToInvalidCheckpointProposal(slotNumber, attester) {
578
+ const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
579
+ if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
580
+ return;
581
+ }
582
+ this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
583
+ attester: attester.toString(),
584
+ slotNumber,
585
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
586
+ offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL)
587
+ });
588
+ this.emit(WANT_TO_SLASH_EVENT, [
589
+ {
590
+ validator: attester,
591
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
592
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
593
+ epochOrSlot: BigInt(slotNumber)
594
+ }
595
+ ]);
596
+ }
609
597
  /**
610
598
  * Handle detection of a duplicate proposal (equivocation).
611
599
  * Emits a slash event when a proposer sends multiple proposals for the same position.
612
600
  */ handleDuplicateProposal(info) {
613
601
  const { slot, proposer, type } = info;
614
- this.log.warn(`Triggering slash event for duplicate ${type} proposal from ${proposer.toString()} at slot ${slot}`, {
602
+ this.slotsWithProposalEquivocation.add(slot);
603
+ this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
615
604
  proposer: proposer.toString(),
616
605
  slot,
617
- type
606
+ type,
607
+ amount: this.config.slashDuplicateProposalPenalty,
608
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL)
618
609
  });
619
- // Emit slash event
620
610
  this.emit(WANT_TO_SLASH_EVENT, [
621
611
  {
622
612
  validator: proposer,
@@ -625,15 +615,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
625
615
  epochOrSlot: BigInt(slot)
626
616
  }
627
617
  ]);
618
+ this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
619
+ {
620
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
621
+ epochOrSlot: BigInt(slot)
622
+ }
623
+ ]);
628
624
  }
629
625
  /**
630
626
  * Handle detection of a duplicate attestation (equivocation).
631
627
  * Emits a slash event when an attester signs attestations for different proposals at the same slot.
632
628
  */ handleDuplicateAttestation(info) {
633
629
  const { slot, attester } = info;
634
- this.log.warn(`Triggering slash event for duplicate attestation from ${attester.toString()} at slot ${slot}`, {
630
+ this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
635
631
  attester: attester.toString(),
636
- slot
632
+ slot,
633
+ amount: this.config.slashDuplicateAttestationPenalty,
634
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION)
637
635
  });
638
636
  this.emit(WANT_TO_SLASH_EVENT, [
639
637
  {
@@ -644,7 +642,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
644
642
  }
645
643
  ]);
646
644
  }
647
- async createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
645
+ async createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
648
646
  // Validate that we're not creating a proposal for an older or equal position
649
647
  if (this.lastProposedBlock) {
650
648
  const lastSlot = this.lastProposedBlock.slotNumber;
@@ -655,14 +653,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
655
653
  }
656
654
  }
657
655
  this.log.info(`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`);
658
- const newProposal = await this.validationService.createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
656
+ const newProposal = await this.validationService.createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
659
657
  ...options,
660
- broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal
658
+ broadcastInvalidBlockProposal: options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal
661
659
  });
662
660
  this.lastProposedBlock = newProposal;
663
661
  return newProposal;
664
662
  }
665
- async createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options = {}) {
663
+ async createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options = {}) {
666
664
  // Validate that we're not creating a proposal for an older or equal slot
667
665
  if (this.lastProposedCheckpoint) {
668
666
  const lastSlot = this.lastProposedCheckpoint.slotNumber;
@@ -672,23 +670,30 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
672
670
  }
673
671
  }
674
672
  this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
675
- const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options);
673
+ const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options);
676
674
  this.lastProposedCheckpoint = newProposal;
675
+ // Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
676
+ // own proposals through `handleCheckpointProposal`, so without this call the proposer's
677
+ // sentinel would see no outcome for slots it proposed and would mis-attribute itself as
678
+ // inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
679
+ // be intentionally corrupted under test-only flags); from the proposer's local-view
680
+ // perspective the work it just completed is valid by definition.
681
+ this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
677
682
  return newProposal;
678
683
  }
679
684
  async broadcastBlockProposal(proposal) {
680
685
  await this.p2pClient.broadcastProposal(proposal);
681
686
  }
682
- async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber) {
683
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
687
+ async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber) {
688
+ return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber);
684
689
  }
685
- async collectOwnAttestations(proposal) {
690
+ async collectOwnAttestations(proposal, checkpointNumber) {
686
691
  const slot = proposal.slotNumber;
687
692
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
688
693
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, {
689
694
  inCommittee
690
695
  });
691
- const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
696
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
692
697
  if (!attestations) {
693
698
  return [];
694
699
  }
@@ -700,7 +705,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
700
705
  });
701
706
  return attestations;
702
707
  }
703
- async collectAttestations(proposal, required, deadline) {
708
+ async collectAttestations(proposal, required, deadline, checkpointNumber) {
704
709
  // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
705
710
  const slot = proposal.slotNumber;
706
711
  this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
@@ -708,28 +713,20 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
708
713
  this.log.error(`Deadline ${deadline.toISOString()} for collecting ${required} attestations for slot ${slot} is in the past`);
709
714
  throw new AttestationTimeoutError(0, required, slot);
710
715
  }
711
- await this.collectOwnAttestations(proposal);
712
- const proposalId = proposal.archive.toString();
716
+ await this.collectOwnAttestations(proposal, checkpointNumber);
717
+ const proposalPayloadHash = proposal.getPayloadHash();
713
718
  const myAddresses = this.getValidatorAddresses();
714
719
  let attestations = [];
715
720
  while(true){
716
- // Filter out attestations with a mismatching archive. This should NOT happen since we have verified
717
- // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
718
- const collectedAttestations = (await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalId)).filter((attestation)=>{
719
- if (!attestation.archive.equals(proposal.archive)) {
720
- this.log.warn(`Received attestation for slot ${slot} with mismatched archive from ${attestation.getSender()?.toString()}`, {
721
- attestationArchive: attestation.archive.toString(),
722
- proposalArchive: proposal.archive.toString()
723
- });
724
- return false;
725
- }
726
- return true;
727
- });
721
+ // The pool already filters by proposal payload hash; if any attestation slips through with a
722
+ // mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
723
+ // events from libp2p_service.
724
+ const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
728
725
  // Log new attestations we collected
729
726
  const oldSenders = attestations.map((attestation)=>attestation.getSender());
730
727
  for (const collected of collectedAttestations){
731
728
  const collectedSender = collected.getSender();
732
- // Skip attestations with invalid signatures
729
+ // Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
733
730
  if (!collectedSender) {
734
731
  this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
735
732
  continue;