@aztec/validator-client 0.0.1-commit.343b43af6 → 0.0.1-commit.350e0a4d

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (42) hide show
  1. package/README.md +21 -21
  2. package/dest/checkpoint_builder.d.ts +10 -7
  3. package/dest/checkpoint_builder.d.ts.map +1 -1
  4. package/dest/checkpoint_builder.js +66 -41
  5. package/dest/config.d.ts +9 -3
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +23 -10
  8. package/dest/duties/validation_service.d.ts +12 -13
  9. package/dest/duties/validation_service.d.ts.map +1 -1
  10. package/dest/duties/validation_service.js +33 -39
  11. package/dest/factory.d.ts +10 -4
  12. package/dest/factory.d.ts.map +1 -1
  13. package/dest/factory.js +18 -6
  14. package/dest/index.d.ts +2 -2
  15. package/dest/index.d.ts.map +1 -1
  16. package/dest/index.js +1 -1
  17. package/dest/key_store/web3signer_key_store.d.ts +10 -2
  18. package/dest/key_store/web3signer_key_store.d.ts.map +1 -1
  19. package/dest/key_store/web3signer_key_store.js +32 -41
  20. package/dest/metrics.d.ts +6 -2
  21. package/dest/metrics.d.ts.map +1 -1
  22. package/dest/metrics.js +12 -0
  23. package/dest/proposal_handler.d.ts +165 -0
  24. package/dest/proposal_handler.d.ts.map +1 -0
  25. package/dest/proposal_handler.js +1207 -0
  26. package/dest/validator.d.ts +36 -22
  27. package/dest/validator.d.ts.map +1 -1
  28. package/dest/validator.js +247 -266
  29. package/package.json +19 -19
  30. package/src/checkpoint_builder.ts +81 -52
  31. package/src/config.ts +31 -12
  32. package/src/duties/validation_service.ts +52 -48
  33. package/src/factory.ts +29 -5
  34. package/src/index.ts +1 -1
  35. package/src/key_store/web3signer_key_store.ts +43 -59
  36. package/src/metrics.ts +19 -1
  37. package/src/proposal_handler.ts +1314 -0
  38. package/src/validator.ts +329 -303
  39. package/dest/block_proposal_handler.d.ts +0 -64
  40. package/dest/block_proposal_handler.d.ts.map +0 -1
  41. package/dest/block_proposal_handler.js +0 -606
  42. package/src/block_proposal_handler.ts +0 -624
package/dest/validator.js CHANGED
@@ -1,42 +1,37 @@
1
1
  import { getBlobsPerL1Block } from '@aztec/blob-lib';
2
- import { validateFeeAssetPriceModifier } from '@aztec/ethereum/contracts';
3
- import { BlockNumber, SlotNumber } from '@aztec/foundation/branded-types';
4
- import { TimeoutError } from '@aztec/foundation/error';
2
+ import { CheckpointNumber } from '@aztec/foundation/branded-types';
3
+ import { FifoSet } from '@aztec/foundation/fifo-set';
5
4
  import { createLogger } from '@aztec/foundation/log';
6
- import { retryUntil } from '@aztec/foundation/retry';
7
5
  import { RunningPromise } from '@aztec/foundation/running-promise';
8
6
  import { sleep } from '@aztec/foundation/sleep';
9
7
  import { DateProvider } from '@aztec/foundation/timer';
10
8
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
11
- import { OffenseType, WANT_TO_SLASH_EVENT } from '@aztec/slasher';
12
- import { validateCheckpoint } from '@aztec/stdlib/checkpoint';
13
- import { getEpochAtSlot, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
14
- import { accumulateCheckpointOutHashes } from '@aztec/stdlib/messaging';
9
+ import { OffenseType, WANT_TO_CLEAR_SLASH_EVENT, WANT_TO_SLASH_EVENT, getOffenseTypeName } from '@aztec/slasher';
10
+ import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
11
+ import { ConsensusTimetable } from '@aztec/stdlib/timetable';
15
12
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
16
13
  import { getTelemetryClient } from '@aztec/telemetry-client';
17
- import { createHASigner, createLocalSignerWithProtection } from '@aztec/validator-ha-signer/factory';
14
+ import { createHASigner, createLocalSignerWithProtection, createSignerFromSharedDb } from '@aztec/validator-ha-signer/factory';
18
15
  import { DutyType } from '@aztec/validator-ha-signer/types';
19
16
  import { EventEmitter } from 'events';
20
- import { BlockProposalHandler } from './block_proposal_handler.js';
17
+ import { DEFAULT_MAX_GOSSIP_CLOCK_DISPARITY_MS } from './config.js';
21
18
  import { ValidationService } from './duties/validation_service.js';
22
19
  import { HAKeyStore } from './key_store/ha_key_store.js';
23
20
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
24
21
  import { ValidatorMetrics } from './metrics.js';
22
+ import { ProposalHandler, SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT, SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT } from './proposal_handler.js';
25
23
  // We maintain a set of proposers who have proposed invalid blocks.
26
24
  // Just cap the set to avoid unbounded growth.
27
25
  const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
28
- // What errors from the block proposal handler result in slashing
29
- const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
30
- 'state_mismatch',
31
- 'failed_txs'
32
- ];
26
+ const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
27
+ const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
33
28
  /**
34
29
  * Validator Client
35
30
  */ export class ValidatorClient extends EventEmitter {
36
31
  keyStore;
37
32
  epochCache;
38
33
  p2pClient;
39
- blockProposalHandler;
34
+ proposalHandler;
40
35
  blockSource;
41
36
  checkpointsBuilder;
42
37
  worldState;
@@ -57,14 +52,18 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
57
52
  epochCacheUpdateLoop;
58
53
  /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */ lastAttestedEpochByAttester;
59
54
  proposersOfInvalidBlocks;
55
+ invalidCheckpointProposalOffenseKeys;
56
+ oversizedProposalOffenseKeys;
57
+ badAttestationOffenseKeys;
60
58
  /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */ lastAttestedProposal;
61
- constructor(keyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
62
- super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.blockProposalHandler = blockProposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = new Set();
59
+ constructor(keyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
60
+ super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.proposalHandler = proposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = FifoSet.withLimit(MAX_PROPOSERS_OF_INVALID_BLOCKS), this.invalidCheckpointProposalOffenseKeys = FifoSet.withLimit(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS), this.oversizedProposalOffenseKeys = FifoSet.withLimit(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS), this.badAttestationOffenseKeys = FifoSet.withLimit(MAX_TRACKED_BAD_ATTESTATIONS);
63
61
  // Create child logger with fisherman prefix if in fisherman mode
64
62
  this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
65
63
  this.tracer = telemetry.getTracer('Validator');
66
64
  this.metrics = new ValidatorMetrics(telemetry);
67
- this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
65
+ this.validationService = new ValidationService(keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
66
+ this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo)=>this.handleInvalidCheckpointProposal(proposal, result, proposalInfo));
68
67
  // Refresh epoch cache every second to trigger alert if participation in committee changes
69
68
  this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
70
69
  const myAddresses = this.getValidatorAddresses();
@@ -114,16 +113,33 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
114
113
  this.log.error(`Error updating epoch committee`, err);
115
114
  }
116
115
  }
117
- static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient()) {
116
+ static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, reexecutionTracker, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), slashingProtectionDb) {
118
117
  const metrics = new ValidatorMetrics(telemetry);
119
- const blockProposalValidator = new BlockProposalValidator(epochCache, {
118
+ const consensusTimetable = new ConsensusTimetable({
119
+ l1Constants: epochCache.getL1Constants(),
120
+ blockDuration: config.blockDurationMs / 1000
121
+ });
122
+ const blockProposalValidator = new BlockProposalValidator(epochCache, consensusTimetable, {
120
123
  txsPermitted: !config.disableTransactions,
121
- maxTxsPerBlock: config.validateMaxTxsPerBlock
124
+ maxTxsPerBlock: config.validateMaxTxsPerBlock,
125
+ maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
126
+ skipSlotValidation: config.skipProposalSlotValidation,
127
+ signatureContext: {
128
+ chainId: config.l1ChainId,
129
+ rollupAddress: config.rollupAddress
130
+ },
131
+ clockDisparityMs: config.maxGossipClockDisparityMs ?? DEFAULT_MAX_GOSSIP_CLOCK_DISPARITY_MS
122
132
  });
123
- const blockProposalHandler = new BlockProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, metrics, dateProvider, telemetry);
133
+ const proposalHandler = new ProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, consensusTimetable, config, blobClient, reexecutionTracker, metrics, dateProvider, telemetry, undefined);
124
134
  const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
125
135
  let slashingProtectionSigner;
126
- if (config.haSigningEnabled) {
136
+ if (slashingProtectionDb) {
137
+ // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
138
+ ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
139
+ telemetryClient: telemetry,
140
+ dateProvider
141
+ }));
142
+ } else if (config.haSigningEnabled) {
127
143
  // Multi-node HA mode: use PostgreSQL-backed distributed locking.
128
144
  // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
129
145
  const haConfig = {
@@ -143,18 +159,24 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
143
159
  }));
144
160
  }
145
161
  const validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
146
- const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider, telemetry);
162
+ const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider, telemetry);
147
163
  return validator;
148
164
  }
149
165
  getValidatorAddresses() {
150
166
  return this.keyStore.getAddresses().filter((addr)=>!this.config.disabledValidators.some((disabled)=>disabled.equals(addr)));
151
167
  }
152
- getBlockProposalHandler() {
153
- return this.blockProposalHandler;
168
+ getProposalHandler() {
169
+ return this.proposalHandler;
154
170
  }
155
171
  signWithAddress(addr, msg, context) {
156
172
  return this.keyStore.signTypedDataWithAddress(addr, msg, context);
157
173
  }
174
+ getSignatureContext() {
175
+ return {
176
+ chainId: this.config.l1ChainId,
177
+ rollupAddress: this.config.rollupAddress
178
+ };
179
+ }
158
180
  getCoinbaseForAttestor(attestor) {
159
181
  return this.keyStore.getCoinbaseAddress(attestor);
160
182
  }
@@ -164,16 +186,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
164
186
  getConfig() {
165
187
  return this.config;
166
188
  }
189
+ hasProposalEquivocation(slotNumber) {
190
+ return this.proposalHandler.hasProposalEquivocation(slotNumber);
191
+ }
192
+ hasInvalidProposals(slotNumber) {
193
+ return this.proposalHandler.hasInvalidProposals(slotNumber);
194
+ }
167
195
  updateConfig(config) {
168
196
  this.config = {
169
197
  ...this.config,
170
198
  ...config
171
199
  };
200
+ this.proposalHandler.updateConfig(config);
172
201
  }
173
202
  reloadKeystore(newManager) {
174
203
  const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
175
204
  this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
176
- this.validationService = new ValidationService(this.keyStore, this.log.createChild('validation-service'));
205
+ this.validationService = new ValidationService(this.keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
177
206
  }
178
207
  async start() {
179
208
  if (this.epochCacheUpdateLoop.isRunning()) {
@@ -206,15 +235,22 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
206
235
  // The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
207
236
  // and processed separately via the block handler above.
208
237
  const checkpointHandler = (checkpoint, proposalSender)=>this.attestToCheckpointProposal(checkpoint, proposalSender);
209
- this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
238
+ this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
210
239
  // Duplicate proposal handler - triggers slashing for equivocation
211
240
  this.p2pClient.registerDuplicateProposalCallback((info)=>{
212
241
  this.handleDuplicateProposal(info);
213
242
  });
243
+ // Oversized proposal handler - triggers slashing for proposals beyond the per-checkpoint block limit
244
+ this.p2pClient.registerOversizedProposalCallback((info)=>{
245
+ this.handleOversizedProposal(info);
246
+ });
214
247
  // Duplicate attestation handler - triggers slashing for attestation equivocation
215
248
  this.p2pClient.registerDuplicateAttestationCallback((info)=>{
216
249
  this.handleDuplicateAttestation(info);
217
250
  });
251
+ this.p2pClient.registerCheckpointAttestationCallback((attestation)=>{
252
+ this.handleCheckpointAttestation(attestation);
253
+ });
218
254
  const myAddresses = this.getValidatorAddresses();
219
255
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
220
256
  await this.p2pClient.addReqRespSubProtocol(ReqRespSubProtocol.AUTH, this.handleAuthRequest.bind(this));
@@ -235,13 +271,12 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
235
271
  this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
236
272
  return false;
237
273
  }
238
- // Ignore proposals from ourselves (may happen in HA setups)
274
+ // Log self-proposals from HA peers (same validator key on different nodes)
239
275
  if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
240
- this.log.debug(`Ignoring block proposal from self for slot ${slotNumber}`, {
276
+ this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
241
277
  proposer: proposer.toString(),
242
278
  slotNumber
243
279
  });
244
- return false;
245
280
  }
246
281
  // Check if we're in the committee (for metrics purposes)
247
282
  const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
@@ -255,11 +290,8 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
255
290
  txHashes: proposal.txHashes.map((t)=>t.toString()),
256
291
  fishermanMode: this.config.fishermanMode || false
257
292
  });
258
- // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
259
- // In fisherman mode, we always reexecute to validate proposals.
260
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
261
- const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute || partOfCommittee && validatorReexecute || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
262
- const validationResult = await this.blockProposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
293
+ // Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
294
+ const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
263
295
  if (!validationResult.isValid) {
264
296
  const reason = validationResult.reason || 'unknown';
265
297
  this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
@@ -277,10 +309,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
277
309
  // Node issues so we can't validate
278
310
  this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
279
311
  }
280
- // Slash invalid block proposals (can happen even when not in committee)
281
- if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) && slashBroadcastedInvalidBlockPenalty > 0n) {
282
- this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
312
+ if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)) {
313
+ this.log.info(`Detected invalid block proposal offense`, {
314
+ ...proposalInfo,
315
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
316
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL)
317
+ });
283
318
  this.slashInvalidBlock(proposal);
319
+ this.markInvalidProposalSlot(proposal.slotNumber);
284
320
  }
285
321
  return false;
286
322
  }
@@ -302,56 +338,50 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
302
338
  * the lastBlock is extracted and processed separately via the block handler.
303
339
  * @returns Checkpoint attestations if valid, undefined otherwise
304
340
  */ async attestToCheckpointProposal(proposal, _proposalSender) {
305
- const slotNumber = proposal.slotNumber;
341
+ const proposalSlotNumber = proposal.slotNumber;
306
342
  const proposer = proposal.getSender();
307
343
  // If escape hatch is open for this slot's epoch, do not attest.
308
- if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
309
- this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
344
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
345
+ this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
310
346
  return undefined;
311
347
  }
312
- // Reject proposals with invalid signatures
313
- if (!proposer) {
314
- this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
348
+ // Early-out for equivocation: refuses if we've already attested to a higher slot.
349
+ if (!this.shouldAttestToSlot(proposalSlotNumber)) {
315
350
  return undefined;
316
351
  }
317
352
  // Ignore proposals from ourselves (may happen in HA setups)
318
- if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
319
- this.log.debug(`Ignoring block proposal from self for slot ${slotNumber}`, {
353
+ if (proposer && this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
354
+ this.log.debug(`Not attesting to block proposal from self for slot ${proposalSlotNumber}`, {
320
355
  proposer: proposer.toString(),
321
- slotNumber
356
+ proposalSlotNumber
322
357
  });
323
358
  return undefined;
324
359
  }
325
- // Validate fee asset price modifier is within allowed range
326
- if (!validateFeeAssetPriceModifier(proposal.feeAssetPriceModifier)) {
327
- this.log.warn(`Received checkpoint proposal with invalid feeAssetPriceModifier ${proposal.feeAssetPriceModifier} for slot ${slotNumber}`);
328
- return undefined;
329
- }
330
- // Check that I have any address in current committee before attesting
331
- const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
360
+ // Check that I have any address in the committee where this checkpoint will land before attesting
361
+ const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
332
362
  const partOfCommittee = inCommittee.length > 0;
333
363
  const proposalInfo = {
334
- slotNumber,
364
+ proposalSlotNumber,
335
365
  archive: proposal.archive.toString(),
336
- proposer: proposer.toString()
366
+ proposer: proposer?.toString()
337
367
  };
338
- this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
368
+ this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
339
369
  ...proposalInfo,
340
370
  fishermanMode: this.config.fishermanMode || false
341
371
  });
342
- // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
372
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
373
+ // Uses the cached result from the all-nodes callback if available (avoids double validation).
374
+ let checkpointNumber;
343
375
  if (this.config.skipCheckpointProposalValidation) {
344
- this.log.warn(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
376
+ this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
377
+ checkpointNumber = CheckpointNumber(0);
345
378
  } else {
346
- const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
379
+ const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
347
380
  if (!validationResult.isValid) {
348
381
  this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
349
382
  return undefined;
350
383
  }
351
- }
352
- // Upload blobs to filestore if we can (fire and forget)
353
- if (this.blobClient.canUpload()) {
354
- void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
384
+ checkpointNumber = validationResult.checkpointNumber;
355
385
  }
356
386
  // Check that I have any address in current committee before attesting
357
387
  // In fisherman mode, we still create attestations for validation even if not in committee
@@ -360,14 +390,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
360
390
  return undefined;
361
391
  }
362
392
  // Provided all of the above checks pass, we can attest to the proposal
363
- this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
393
+ this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`, {
364
394
  ...proposalInfo,
365
395
  inCommittee: partOfCommittee,
366
396
  fishermanMode: this.config.fishermanMode || false
367
397
  });
368
398
  this.metrics.incSuccessfulAttestations(inCommittee.length);
369
399
  // Track epoch participation per attester: count each (attester, epoch) pair at most once
370
- const proposalEpoch = getEpochAtSlot(slotNumber, this.epochCache.getL1Constants());
400
+ const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
371
401
  for (const attester of inCommittee){
372
402
  const key = attester.toString();
373
403
  const lastEpoch = this.lastAttestedEpochByAttester.get(key);
@@ -392,13 +422,13 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
392
422
  }
393
423
  if (this.config.fishermanMode) {
394
424
  // bail out early and don't save attestations to the pool in fisherman mode
395
- this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
425
+ this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
396
426
  ...proposalInfo,
397
427
  attestors: attestors.map((a)=>a.toString())
398
428
  });
399
429
  return undefined;
400
430
  }
401
- return await this.createCheckpointAttestationsFromProposal(proposal, attestors);
431
+ return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
402
432
  }
403
433
  /**
404
434
  * Checks if we should attest to a slot based on equivocation prevention rules.
@@ -415,180 +445,24 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
415
445
  }
416
446
  return true;
417
447
  }
418
- async createCheckpointAttestationsFromProposal(proposal, attestors = []) {
448
+ async createCheckpointAttestationsFromProposal(proposal, attestors = [], checkpointNumber) {
419
449
  // Equivocation check: must happen right before signing to minimize the race window
420
450
  if (!this.shouldAttestToSlot(proposal.slotNumber)) {
421
451
  return undefined;
422
452
  }
423
- const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
453
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
424
454
  // Track the proposal we attested to (to prevent equivocation)
425
455
  this.lastAttestedProposal = proposal;
426
456
  await this.p2pClient.addOwnCheckpointAttestations(attestations);
427
457
  return attestations;
428
458
  }
429
459
  /**
430
- * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
431
- * @returns Validation result with isValid flag and reason if invalid.
432
- */ async validateCheckpointProposal(proposal, proposalInfo) {
433
- const slot = proposal.slotNumber;
434
- // Timeout block syncing at the start of the next slot
435
- const config = this.checkpointsBuilder.getConfig();
436
- const nextSlotTimestampSeconds = Number(getTimestampForSlot(SlotNumber(slot + 1), config));
437
- const timeoutSeconds = Math.max(1, nextSlotTimestampSeconds - Math.floor(this.dateProvider.now() / 1000));
438
- // Wait for last block to sync by archive
439
- let lastBlockHeader;
440
- try {
441
- lastBlockHeader = await retryUntil(async ()=>{
442
- await this.blockSource.syncImmediate();
443
- return this.blockSource.getBlockHeaderByArchive(proposal.archive);
444
- }, `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`, timeoutSeconds, 0.5);
445
- } catch (err) {
446
- if (err instanceof TimeoutError) {
447
- this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
448
- return {
449
- isValid: false,
450
- reason: 'last_block_not_found'
451
- };
452
- }
453
- this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
454
- return {
455
- isValid: false,
456
- reason: 'block_fetch_error'
457
- };
458
- }
459
- if (!lastBlockHeader) {
460
- this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
461
- return {
462
- isValid: false,
463
- reason: 'last_block_not_found'
464
- };
465
- }
466
- // Get all full blocks for the slot and checkpoint
467
- const blocks = await this.blockSource.getBlocksForSlot(slot);
468
- if (blocks.length === 0) {
469
- this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
470
- return {
471
- isValid: false,
472
- reason: 'no_blocks_for_slot'
473
- };
474
- }
475
- // Ensure the last block for this slot matches the archive in the checkpoint proposal
476
- if (!blocks.at(-1)?.archive.root.equals(proposal.archive)) {
477
- this.log.warn(`Last block archive mismatch for checkpoint proposal`, proposalInfo);
478
- return {
479
- isValid: false,
480
- reason: 'last_block_archive_mismatch'
481
- };
482
- }
483
- this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
484
- ...proposalInfo,
485
- blockNumbers: blocks.map((b)=>b.number)
486
- });
487
- // Get checkpoint constants from first block
488
- const firstBlock = blocks[0];
489
- const constants = this.extractCheckpointConstants(firstBlock);
490
- const checkpointNumber = firstBlock.checkpointNumber;
491
- // Get L1-to-L2 messages for this checkpoint
492
- const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
493
- // Collect the out hashes of all the checkpoints before this one in the same epoch
494
- const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
495
- const previousCheckpointOutHashes = (await this.blockSource.getCheckpointsDataForEpoch(epoch)).filter((c)=>c.checkpointNumber < checkpointNumber).map((c)=>c.checkpointOutHash);
496
- // Fork world state at the block before the first block
497
- const parentBlockNumber = BlockNumber(firstBlock.number - 1);
498
- const fork = await this.worldState.fork(parentBlockNumber);
499
- try {
500
- // Create checkpoint builder with all existing blocks
501
- const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(checkpointNumber, constants, proposal.feeAssetPriceModifier, l1ToL2Messages, previousCheckpointOutHashes, fork, blocks, this.log.getBindings());
502
- // Complete the checkpoint to get computed values
503
- const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
504
- // Compare checkpoint header with proposal
505
- if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
506
- this.log.warn(`Checkpoint header mismatch`, {
507
- ...proposalInfo,
508
- computed: computedCheckpoint.header.toInspect(),
509
- proposal: proposal.checkpointHeader.toInspect()
510
- });
511
- return {
512
- isValid: false,
513
- reason: 'checkpoint_header_mismatch'
514
- };
515
- }
516
- // Compare archive root with proposal
517
- if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
518
- this.log.warn(`Archive root mismatch`, {
519
- ...proposalInfo,
520
- computed: computedCheckpoint.archive.root.toString(),
521
- proposal: proposal.archive.toString()
522
- });
523
- return {
524
- isValid: false,
525
- reason: 'archive_mismatch'
526
- };
527
- }
528
- // Check that the accumulated epoch out hash matches the value in the proposal.
529
- // The epoch out hash is the accumulated hash of all checkpoint out hashes in the epoch.
530
- const checkpointOutHash = computedCheckpoint.getCheckpointOutHash();
531
- const computedEpochOutHash = accumulateCheckpointOutHashes([
532
- ...previousCheckpointOutHashes,
533
- checkpointOutHash
534
- ]);
535
- const proposalEpochOutHash = proposal.checkpointHeader.epochOutHash;
536
- if (!computedEpochOutHash.equals(proposalEpochOutHash)) {
537
- this.log.warn(`Epoch out hash mismatch`, {
538
- proposalEpochOutHash: proposalEpochOutHash.toString(),
539
- computedEpochOutHash: computedEpochOutHash.toString(),
540
- checkpointOutHash: checkpointOutHash.toString(),
541
- previousCheckpointOutHashes: previousCheckpointOutHashes.map((h)=>h.toString()),
542
- ...proposalInfo
543
- });
544
- return {
545
- isValid: false,
546
- reason: 'out_hash_mismatch'
547
- };
548
- }
549
- // Final round of validations on the checkpoint, just in case.
550
- try {
551
- validateCheckpoint(computedCheckpoint, {
552
- rollupManaLimit: this.checkpointsBuilder.getConfig().rollupManaLimit,
553
- maxDABlockGas: this.config.validateMaxDABlockGas,
554
- maxL2BlockGas: this.config.validateMaxL2BlockGas,
555
- maxTxsPerBlock: this.config.validateMaxTxsPerBlock,
556
- maxTxsPerCheckpoint: this.config.validateMaxTxsPerCheckpoint
557
- });
558
- } catch (err) {
559
- this.log.warn(`Checkpoint validation failed: ${err}`, proposalInfo);
560
- return {
561
- isValid: false,
562
- reason: 'checkpoint_validation_failed'
563
- };
564
- }
565
- this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
566
- return {
567
- isValid: true
568
- };
569
- } finally{
570
- await fork.close();
571
- }
572
- }
573
- /**
574
- * Extract checkpoint global variables from a block.
575
- */ extractCheckpointConstants(block) {
576
- const gv = block.header.globalVariables;
577
- return {
578
- chainId: gv.chainId,
579
- version: gv.version,
580
- slotNumber: gv.slotNumber,
581
- timestamp: gv.timestamp,
582
- coinbase: gv.coinbase,
583
- feeRecipient: gv.feeRecipient,
584
- gasFees: gv.gasFees
585
- };
586
- }
587
- /**
588
460
  * Uploads blobs for a checkpoint to the filestore (fire and forget).
589
461
  */ async uploadBlobsForCheckpoint(proposal, proposalInfo) {
590
462
  try {
591
- const lastBlockHeader = await this.blockSource.getBlockHeaderByArchive(proposal.archive);
463
+ const lastBlockHeader = (await this.blockSource.getBlockData({
464
+ archive: proposal.archive
465
+ }))?.header;
592
466
  if (!lastBlockHeader) {
593
467
  this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
594
468
  return;
@@ -616,11 +490,6 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
616
490
  this.log.warn(`Cannot slash proposal with invalid signature`);
617
491
  return;
618
492
  }
619
- // Trim the set if it's too big.
620
- if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
621
- // remove oldest proposer. `values` is guaranteed to be in insertion order.
622
- this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value);
623
- }
624
493
  this.proposersOfInvalidBlocks.add(proposer.toString());
625
494
  this.emit(WANT_TO_SLASH_EVENT, [
626
495
  {
@@ -631,17 +500,122 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
631
500
  }
632
501
  ]);
633
502
  }
503
+ handleInvalidCheckpointProposal(proposal, result, proposalInfo) {
504
+ if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
505
+ return;
506
+ }
507
+ // The slot is already marked invalid by the all-nodes checkpoint handler that invokes this callback,
508
+ // so we only emit the proposer slash event here.
509
+ if (this.slashInvalidCheckpointProposal(proposal)) {
510
+ this.log.info(`Detected invalid checkpoint proposal offense`, {
511
+ ...proposalInfo,
512
+ reason: result.reason,
513
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
514
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL)
515
+ });
516
+ }
517
+ }
518
+ slashInvalidCheckpointProposal(proposal) {
519
+ const proposer = proposal.getSender();
520
+ if (!proposer) {
521
+ this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
522
+ slotNumber: proposal.slotNumber,
523
+ archive: proposal.archive.toString()
524
+ });
525
+ return false;
526
+ }
527
+ const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
528
+ const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
529
+ if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
530
+ return false;
531
+ }
532
+ this.emit(WANT_TO_SLASH_EVENT, [
533
+ {
534
+ validator: proposer,
535
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
536
+ offenseType,
537
+ epochOrSlot: BigInt(proposal.slotNumber)
538
+ }
539
+ ]);
540
+ return true;
541
+ }
542
+ markInvalidProposalSlot(slotNumber) {
543
+ this.proposalHandler.markInvalidProposalSlot(slotNumber);
544
+ }
545
+ handleCheckpointAttestation(attestation) {
546
+ const slotNumber = attestation.slotNumber;
547
+ if (!this.proposalHandler.hasInvalidProposals(slotNumber) || this.proposalHandler.hasProposalEquivocation(slotNumber)) {
548
+ return;
549
+ }
550
+ const attester = attestation.getSender();
551
+ if (!attester) {
552
+ this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
553
+ slotNumber,
554
+ archive: attestation.archive.toString()
555
+ });
556
+ return;
557
+ }
558
+ this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
559
+ }
560
+ slashAttestedToInvalidCheckpointProposal(slotNumber, attester) {
561
+ const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
562
+ if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
563
+ return;
564
+ }
565
+ this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
566
+ attester: attester.toString(),
567
+ slotNumber,
568
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
569
+ offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL)
570
+ });
571
+ this.emit(WANT_TO_SLASH_EVENT, [
572
+ {
573
+ validator: attester,
574
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
575
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
576
+ epochOrSlot: BigInt(slotNumber)
577
+ }
578
+ ]);
579
+ }
580
+ /**
581
+ * Handle detection of an oversized block proposal: one whose index within its checkpoint lands at or
582
+ * beyond the consensus per-checkpoint block limit. A single signed proposal at an illegal index is
583
+ * self-contained evidence, so emit an invalid-block-proposal slash event for the proposer, deduped per
584
+ * (proposer, slot) since the p2p layer reports every oversized proposal it stores.
585
+ */ handleOversizedProposal(info) {
586
+ const { slot, proposer } = info;
587
+ const offenseType = OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL;
588
+ if (!this.oversizedProposalOffenseKeys.addIfAbsent(`${proposer.toString()}:${offenseType}:${slot}`)) {
589
+ return;
590
+ }
591
+ this.log.info(`Detected oversized block proposal offense from ${proposer.toString()} at slot ${slot}`, {
592
+ proposer: proposer.toString(),
593
+ slot,
594
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
595
+ offenseType: getOffenseTypeName(offenseType)
596
+ });
597
+ this.emit(WANT_TO_SLASH_EVENT, [
598
+ {
599
+ validator: proposer,
600
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
601
+ offenseType,
602
+ epochOrSlot: BigInt(slot)
603
+ }
604
+ ]);
605
+ }
634
606
  /**
635
607
  * Handle detection of a duplicate proposal (equivocation).
636
608
  * Emits a slash event when a proposer sends multiple proposals for the same position.
637
609
  */ handleDuplicateProposal(info) {
638
610
  const { slot, proposer, type } = info;
639
- this.log.warn(`Triggering slash event for duplicate ${type} proposal from ${proposer.toString()} at slot ${slot}`, {
611
+ this.proposalHandler.markProposalEquivocation(slot);
612
+ this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
640
613
  proposer: proposer.toString(),
641
614
  slot,
642
- type
615
+ type,
616
+ amount: this.config.slashDuplicateProposalPenalty,
617
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL)
643
618
  });
644
- // Emit slash event
645
619
  this.emit(WANT_TO_SLASH_EVENT, [
646
620
  {
647
621
  validator: proposer,
@@ -650,15 +624,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
650
624
  epochOrSlot: BigInt(slot)
651
625
  }
652
626
  ]);
627
+ this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
628
+ {
629
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
630
+ epochOrSlot: BigInt(slot)
631
+ }
632
+ ]);
653
633
  }
654
634
  /**
655
635
  * Handle detection of a duplicate attestation (equivocation).
656
636
  * Emits a slash event when an attester signs attestations for different proposals at the same slot.
657
637
  */ handleDuplicateAttestation(info) {
658
638
  const { slot, attester } = info;
659
- this.log.warn(`Triggering slash event for duplicate attestation from ${attester.toString()} at slot ${slot}`, {
639
+ this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
660
640
  attester: attester.toString(),
661
- slot
641
+ slot,
642
+ amount: this.config.slashDuplicateAttestationPenalty,
643
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION)
662
644
  });
663
645
  this.emit(WANT_TO_SLASH_EVENT, [
664
646
  {
@@ -669,7 +651,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
669
651
  }
670
652
  ]);
671
653
  }
672
- async createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
654
+ async createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
673
655
  // Validate that we're not creating a proposal for an older or equal position
674
656
  if (this.lastProposedBlock) {
675
657
  const lastSlot = this.lastProposedBlock.slotNumber;
@@ -680,14 +662,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
680
662
  }
681
663
  }
682
664
  this.log.info(`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`);
683
- const newProposal = await this.validationService.createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
665
+ const newProposal = await this.validationService.createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
684
666
  ...options,
685
- broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal
667
+ broadcastInvalidBlockProposal: options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal
686
668
  });
687
669
  this.lastProposedBlock = newProposal;
688
670
  return newProposal;
689
671
  }
690
- async createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options = {}) {
672
+ async createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options = {}) {
691
673
  // Validate that we're not creating a proposal for an older or equal slot
692
674
  if (this.lastProposedCheckpoint) {
693
675
  const lastSlot = this.lastProposedCheckpoint.slotNumber;
@@ -697,23 +679,30 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
697
679
  }
698
680
  }
699
681
  this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
700
- const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options);
682
+ const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options);
701
683
  this.lastProposedCheckpoint = newProposal;
684
+ // Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
685
+ // own proposals through `handleCheckpointProposal`, so without this call the proposer's
686
+ // sentinel would see no outcome for slots it proposed and would mis-attribute itself as
687
+ // inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
688
+ // be intentionally corrupted under test-only flags); from the proposer's local-view
689
+ // perspective the work it just completed is valid by definition.
690
+ this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
702
691
  return newProposal;
703
692
  }
704
693
  async broadcastBlockProposal(proposal) {
705
694
  await this.p2pClient.broadcastProposal(proposal);
706
695
  }
707
- async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber) {
708
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
696
+ async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber) {
697
+ return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber);
709
698
  }
710
- async collectOwnAttestations(proposal) {
699
+ async collectOwnAttestations(proposal, checkpointNumber) {
711
700
  const slot = proposal.slotNumber;
712
701
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
713
702
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, {
714
703
  inCommittee
715
704
  });
716
- const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
705
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
717
706
  if (!attestations) {
718
707
  return [];
719
708
  }
@@ -725,7 +714,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
725
714
  });
726
715
  return attestations;
727
716
  }
728
- async collectAttestations(proposal, required, deadline) {
717
+ async collectAttestations(proposal, required, deadline, checkpointNumber) {
729
718
  // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
730
719
  const slot = proposal.slotNumber;
731
720
  this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
@@ -733,28 +722,20 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
733
722
  this.log.error(`Deadline ${deadline.toISOString()} for collecting ${required} attestations for slot ${slot} is in the past`);
734
723
  throw new AttestationTimeoutError(0, required, slot);
735
724
  }
736
- await this.collectOwnAttestations(proposal);
737
- const proposalId = proposal.archive.toString();
725
+ await this.collectOwnAttestations(proposal, checkpointNumber);
726
+ const proposalPayloadHash = proposal.getPayloadHash();
738
727
  const myAddresses = this.getValidatorAddresses();
739
728
  let attestations = [];
740
729
  while(true){
741
- // Filter out attestations with a mismatching archive. This should NOT happen since we have verified
742
- // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
743
- const collectedAttestations = (await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalId)).filter((attestation)=>{
744
- if (!attestation.archive.equals(proposal.archive)) {
745
- this.log.warn(`Received attestation for slot ${slot} with mismatched archive from ${attestation.getSender()?.toString()}`, {
746
- attestationArchive: attestation.archive.toString(),
747
- proposalArchive: proposal.archive.toString()
748
- });
749
- return false;
750
- }
751
- return true;
752
- });
730
+ // The pool already filters by proposal payload hash; if any attestation slips through with a
731
+ // mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
732
+ // events from libp2p_service.
733
+ const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
753
734
  // Log new attestations we collected
754
735
  const oldSenders = attestations.map((attestation)=>attestation.getSender());
755
736
  for (const collected of collectedAttestations){
756
737
  const collectedSender = collected.getSender();
757
- // Skip attestations with invalid signatures
738
+ // Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
758
739
  if (!collectedSender) {
759
740
  this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
760
741
  continue;