@aztec/validator-client 0.0.1-commit.181e2d196 → 0.0.1-commit.189eedb3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (40) hide show
  1. package/README.md +51 -11
  2. package/dest/checkpoint_builder.d.ts +14 -4
  3. package/dest/checkpoint_builder.d.ts.map +1 -1
  4. package/dest/checkpoint_builder.js +97 -29
  5. package/dest/config.d.ts +1 -1
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +33 -7
  8. package/dest/duties/validation_service.d.ts +12 -13
  9. package/dest/duties/validation_service.d.ts.map +1 -1
  10. package/dest/duties/validation_service.js +33 -45
  11. package/dest/factory.d.ts +10 -4
  12. package/dest/factory.d.ts.map +1 -1
  13. package/dest/factory.js +10 -5
  14. package/dest/index.d.ts +2 -2
  15. package/dest/index.d.ts.map +1 -1
  16. package/dest/index.js +1 -1
  17. package/dest/key_store/ha_key_store.js +1 -1
  18. package/dest/metrics.d.ts +6 -2
  19. package/dest/metrics.d.ts.map +1 -1
  20. package/dest/metrics.js +12 -0
  21. package/dest/proposal_handler.d.ts +134 -0
  22. package/dest/proposal_handler.d.ts.map +1 -0
  23. package/dest/proposal_handler.js +1072 -0
  24. package/dest/validator.d.ts +29 -21
  25. package/dest/validator.d.ts.map +1 -1
  26. package/dest/validator.js +248 -264
  27. package/package.json +19 -19
  28. package/src/checkpoint_builder.ts +120 -34
  29. package/src/config.ts +33 -6
  30. package/src/duties/validation_service.ts +52 -54
  31. package/src/factory.ts +20 -4
  32. package/src/index.ts +1 -1
  33. package/src/key_store/ha_key_store.ts +1 -1
  34. package/src/metrics.ts +19 -1
  35. package/src/proposal_handler.ts +1161 -0
  36. package/src/validator.ts +325 -307
  37. package/dest/block_proposal_handler.d.ts +0 -63
  38. package/dest/block_proposal_handler.d.ts.map +0 -1
  39. package/dest/block_proposal_handler.js +0 -532
  40. package/src/block_proposal_handler.ts +0 -535
package/dest/validator.js CHANGED
@@ -1,48 +1,70 @@
1
1
  import { getBlobsPerL1Block } from '@aztec/blob-lib';
2
- import { validateFeeAssetPriceModifier } from '@aztec/ethereum/contracts';
3
- import { BlockNumber, SlotNumber } from '@aztec/foundation/branded-types';
4
- import { TimeoutError } from '@aztec/foundation/error';
2
+ import { CheckpointNumber } from '@aztec/foundation/branded-types';
3
+ import { FifoSet } from '@aztec/foundation/fifo-set';
5
4
  import { createLogger } from '@aztec/foundation/log';
6
- import { retryUntil } from '@aztec/foundation/retry';
7
5
  import { RunningPromise } from '@aztec/foundation/running-promise';
8
6
  import { sleep } from '@aztec/foundation/sleep';
9
7
  import { DateProvider } from '@aztec/foundation/timer';
10
8
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
11
- import { OffenseType, WANT_TO_SLASH_EVENT } from '@aztec/slasher';
12
- import { getEpochAtSlot, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
13
- import { accumulateCheckpointOutHashes } from '@aztec/stdlib/messaging';
9
+ import { OffenseType, WANT_TO_CLEAR_SLASH_EVENT, WANT_TO_SLASH_EVENT, getOffenseTypeName } from '@aztec/slasher';
10
+ import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
14
11
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
15
12
  import { getTelemetryClient } from '@aztec/telemetry-client';
16
- import { createHASigner } from '@aztec/validator-ha-signer/factory';
13
+ import { createHASigner, createLocalSignerWithProtection, createSignerFromSharedDb } from '@aztec/validator-ha-signer/factory';
17
14
  import { DutyType } from '@aztec/validator-ha-signer/types';
18
15
  import { EventEmitter } from 'events';
19
- import { BlockProposalHandler } from './block_proposal_handler.js';
20
16
  import { ValidationService } from './duties/validation_service.js';
21
17
  import { HAKeyStore } from './key_store/ha_key_store.js';
22
18
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
23
19
  import { ValidatorMetrics } from './metrics.js';
20
+ import { ProposalHandler } from './proposal_handler.js';
24
21
  // We maintain a set of proposers who have proposed invalid blocks.
25
22
  // Just cap the set to avoid unbounded growth.
26
23
  const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
24
+ const MAX_TRACKED_INVALID_PROPOSAL_SLOTS = 1000;
25
+ const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
26
+ const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
27
27
  // What errors from the block proposal handler result in slashing
28
28
  const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
29
29
  'state_mismatch',
30
- 'failed_txs'
30
+ 'failed_txs',
31
+ 'global_variables_mismatch',
32
+ 'invalid_proposal',
33
+ 'parent_block_wrong_slot',
34
+ 'in_hash_mismatch'
31
35
  ];
36
+ const SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT = {
37
+ // enabled
38
+ ['invalid_fee_asset_price_modifier']: true,
39
+ ['checkpoint_header_mismatch']: true,
40
+ // These late mismatches should normally be caught by earlier checks, but if reached after validating the local
41
+ // checkpoint inputs, the proposer-signed payload disagrees with deterministic recomputation.
42
+ ['archive_mismatch']: true,
43
+ ['out_hash_mismatch']: true,
44
+ ['no_blocks_for_slot']: true,
45
+ ['too_many_blocks_in_checkpoint']: true,
46
+ ['checkpoint_validation_failed']: true,
47
+ ['last_block_archive_mismatch']: true,
48
+ // disabled
49
+ ['invalid_signature']: false,
50
+ ['last_block_not_found']: false,
51
+ ['block_fetch_error']: false,
52
+ ['checkpoint_already_published']: false
53
+ };
32
54
  /**
33
55
  * Validator Client
34
56
  */ export class ValidatorClient extends EventEmitter {
35
57
  keyStore;
36
58
  epochCache;
37
59
  p2pClient;
38
- blockProposalHandler;
60
+ proposalHandler;
39
61
  blockSource;
40
62
  checkpointsBuilder;
41
63
  worldState;
42
64
  l1ToL2MessageSource;
43
65
  config;
44
66
  blobClient;
45
- haSigner;
67
+ slashingProtectionSigner;
46
68
  dateProvider;
47
69
  tracer;
48
70
  validationService;
@@ -56,14 +78,19 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
56
78
  epochCacheUpdateLoop;
57
79
  /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */ lastAttestedEpochByAttester;
58
80
  proposersOfInvalidBlocks;
81
+ slotsWithInvalidProposals;
82
+ invalidCheckpointProposalOffenseKeys;
83
+ badAttestationOffenseKeys;
84
+ slotsWithProposalEquivocation;
59
85
  /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */ lastAttestedProposal;
60
- constructor(keyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, haSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
61
- super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.blockProposalHandler = blockProposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.haSigner = haSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = new Set();
86
+ constructor(keyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
87
+ super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.proposalHandler = proposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = FifoSet.withLimit(MAX_PROPOSERS_OF_INVALID_BLOCKS), this.slotsWithInvalidProposals = FifoSet.withLimit(MAX_TRACKED_INVALID_PROPOSAL_SLOTS), this.invalidCheckpointProposalOffenseKeys = FifoSet.withLimit(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS), this.badAttestationOffenseKeys = FifoSet.withLimit(MAX_TRACKED_BAD_ATTESTATIONS), this.slotsWithProposalEquivocation = FifoSet.withLimit(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
62
88
  // Create child logger with fisherman prefix if in fisherman mode
63
89
  this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
64
90
  this.tracer = telemetry.getTracer('Validator');
65
91
  this.metrics = new ValidatorMetrics(telemetry);
66
- this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
92
+ this.validationService = new ValidationService(keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
93
+ this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo)=>this.handleInvalidCheckpointProposal(proposal, result, proposalInfo));
67
94
  // Refresh epoch cache every second to trigger alert if participation in committee changes
68
95
  this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
69
96
  const myAddresses = this.getValidatorAddresses();
@@ -113,41 +140,65 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
113
140
  this.log.error(`Error updating epoch committee`, err);
114
141
  }
115
142
  }
116
- static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient()) {
143
+ static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, reexecutionTracker, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), slashingProtectionDb) {
117
144
  const metrics = new ValidatorMetrics(telemetry);
118
145
  const blockProposalValidator = new BlockProposalValidator(epochCache, {
119
146
  txsPermitted: !config.disableTransactions,
120
- maxTxsPerBlock: config.maxTxsPerBlock
147
+ maxTxsPerBlock: config.validateMaxTxsPerBlock,
148
+ maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
149
+ skipSlotValidation: config.skipProposalSlotValidation,
150
+ signatureContext: {
151
+ chainId: config.l1ChainId,
152
+ rollupAddress: config.rollupAddress
153
+ }
121
154
  });
122
- const blockProposalHandler = new BlockProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, metrics, dateProvider, telemetry);
155
+ const proposalHandler = new ProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, blobClient, reexecutionTracker, metrics, dateProvider, telemetry, undefined);
123
156
  const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
124
- let validatorKeyStore = nodeKeystoreAdapter;
125
- let haSigner;
126
- if (config.haSigningEnabled) {
157
+ let slashingProtectionSigner;
158
+ if (slashingProtectionDb) {
159
+ // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
160
+ ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
161
+ telemetryClient: telemetry,
162
+ dateProvider
163
+ }));
164
+ } else if (config.haSigningEnabled) {
165
+ // Multi-node HA mode: use PostgreSQL-backed distributed locking.
127
166
  // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
128
167
  const haConfig = {
129
168
  ...config,
130
169
  maxStuckDutiesAgeMs: config.maxStuckDutiesAgeMs ?? epochCache.getL1Constants().slotDuration * 2 * 1000
131
170
  };
132
- const { signer } = await createHASigner(haConfig, {
171
+ ({ signer: slashingProtectionSigner } = await createHASigner(haConfig, {
133
172
  telemetryClient: telemetry,
134
173
  dateProvider
135
- });
136
- haSigner = signer;
137
- validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, signer);
174
+ }));
175
+ } else {
176
+ // Single-node mode: use LMDB-backed local signing protection.
177
+ // This prevents double-signing if the node crashes and restarts mid-proposal.
178
+ ({ signer: slashingProtectionSigner } = await createLocalSignerWithProtection(config, {
179
+ telemetryClient: telemetry,
180
+ dateProvider
181
+ }));
138
182
  }
139
- const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, haSigner, dateProvider, telemetry);
183
+ const validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
184
+ const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider, telemetry);
140
185
  return validator;
141
186
  }
142
187
  getValidatorAddresses() {
143
188
  return this.keyStore.getAddresses().filter((addr)=>!this.config.disabledValidators.some((disabled)=>disabled.equals(addr)));
144
189
  }
145
- getBlockProposalHandler() {
146
- return this.blockProposalHandler;
190
+ getProposalHandler() {
191
+ return this.proposalHandler;
147
192
  }
148
193
  signWithAddress(addr, msg, context) {
149
194
  return this.keyStore.signTypedDataWithAddress(addr, msg, context);
150
195
  }
196
+ getSignatureContext() {
197
+ return {
198
+ chainId: this.config.l1ChainId,
199
+ rollupAddress: this.config.rollupAddress
200
+ };
201
+ }
151
202
  getCoinbaseForAttestor(attestor) {
152
203
  return this.keyStore.getCoinbaseAddress(attestor);
153
204
  }
@@ -157,25 +208,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
157
208
  getConfig() {
158
209
  return this.config;
159
210
  }
211
+ hasProposalEquivocation(slotNumber) {
212
+ return this.slotsWithProposalEquivocation.has(slotNumber);
213
+ }
214
+ hasInvalidProposals(slotNumber) {
215
+ return this.slotsWithInvalidProposals.has(slotNumber);
216
+ }
160
217
  updateConfig(config) {
161
218
  this.config = {
162
219
  ...this.config,
163
220
  ...config
164
221
  };
222
+ this.proposalHandler.updateConfig(config);
165
223
  }
166
224
  reloadKeystore(newManager) {
167
- if (this.config.haSigningEnabled && !this.haSigner) {
168
- this.log.warn('HA signing is enabled in config but was not initialized at startup. ' + 'Restart the node to enable HA signing.');
169
- } else if (!this.config.haSigningEnabled && this.haSigner) {
170
- this.log.warn('HA signing was disabled via config update but the HA signer is still active. ' + 'Restart the node to fully disable HA signing.');
171
- }
172
225
  const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
173
- if (this.haSigner) {
174
- this.keyStore = new HAKeyStore(newAdapter, this.haSigner);
175
- } else {
176
- this.keyStore = newAdapter;
177
- }
178
- this.validationService = new ValidationService(this.keyStore, this.log.createChild('validation-service'));
226
+ this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
227
+ this.validationService = new ValidationService(this.keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
179
228
  }
180
229
  async start() {
181
230
  if (this.epochCacheUpdateLoop.isRunning()) {
@@ -208,7 +257,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
208
257
  // The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
209
258
  // and processed separately via the block handler above.
210
259
  const checkpointHandler = (checkpoint, proposalSender)=>this.attestToCheckpointProposal(checkpoint, proposalSender);
211
- this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
260
+ this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
212
261
  // Duplicate proposal handler - triggers slashing for equivocation
213
262
  this.p2pClient.registerDuplicateProposalCallback((info)=>{
214
263
  this.handleDuplicateProposal(info);
@@ -217,6 +266,9 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
217
266
  this.p2pClient.registerDuplicateAttestationCallback((info)=>{
218
267
  this.handleDuplicateAttestation(info);
219
268
  });
269
+ this.p2pClient.registerCheckpointAttestationCallback((attestation)=>{
270
+ this.handleCheckpointAttestation(attestation);
271
+ });
220
272
  const myAddresses = this.getValidatorAddresses();
221
273
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
222
274
  await this.p2pClient.addReqRespSubProtocol(ReqRespSubProtocol.AUTH, this.handleAuthRequest.bind(this));
@@ -237,13 +289,12 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
237
289
  this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
238
290
  return false;
239
291
  }
240
- // Ignore proposals from ourselves (may happen in HA setups)
292
+ // Log self-proposals from HA peers (same validator key on different nodes)
241
293
  if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
242
- this.log.warn(`Ignoring block proposal from self for slot ${slotNumber}`, {
294
+ this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
243
295
  proposer: proposer.toString(),
244
296
  slotNumber
245
297
  });
246
- return false;
247
298
  }
248
299
  // Check if we're in the committee (for metrics purposes)
249
300
  const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
@@ -257,14 +308,11 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
257
308
  txHashes: proposal.txHashes.map((t)=>t.toString()),
258
309
  fishermanMode: this.config.fishermanMode || false
259
310
  });
260
- // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
261
- // In fisherman mode, we always reexecute to validate proposals.
262
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
263
- const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute || partOfCommittee && validatorReexecute || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
264
- const validationResult = await this.blockProposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
311
+ // Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
312
+ const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
265
313
  if (!validationResult.isValid) {
266
- this.log.warn(`Block proposal validation failed: ${validationResult.reason}`, proposalInfo);
267
314
  const reason = validationResult.reason || 'unknown';
315
+ this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
268
316
  // Classify failure reason: bad proposal vs node issue
269
317
  const badProposalReasons = [
270
318
  'invalid_proposal',
@@ -279,10 +327,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
279
327
  // Node issues so we can't validate
280
328
  this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
281
329
  }
282
- // Slash invalid block proposals (can happen even when not in committee)
283
- if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) && slashBroadcastedInvalidBlockPenalty > 0n) {
284
- this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
330
+ if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)) {
331
+ this.log.info(`Detected invalid block proposal offense`, {
332
+ ...proposalInfo,
333
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
334
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL)
335
+ });
285
336
  this.slashInvalidBlock(proposal);
337
+ this.markInvalidProposalSlot(proposal.slotNumber);
286
338
  }
287
339
  return false;
288
340
  }
@@ -304,58 +356,50 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
304
356
  * the lastBlock is extracted and processed separately via the block handler.
305
357
  * @returns Checkpoint attestations if valid, undefined otherwise
306
358
  */ async attestToCheckpointProposal(proposal, _proposalSender) {
307
- const slotNumber = proposal.slotNumber;
359
+ const proposalSlotNumber = proposal.slotNumber;
308
360
  const proposer = proposal.getSender();
309
361
  // If escape hatch is open for this slot's epoch, do not attest.
310
- if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
311
- this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
362
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
363
+ this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
312
364
  return undefined;
313
365
  }
314
- // Reject proposals with invalid signatures
315
- if (!proposer) {
316
- this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
366
+ // Early-out for equivocation: refuses if we've already attested to a higher slot.
367
+ if (!this.shouldAttestToSlot(proposalSlotNumber)) {
317
368
  return undefined;
318
369
  }
319
370
  // Ignore proposals from ourselves (may happen in HA setups)
320
- if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
321
- this.log.warn(`Ignoring block proposal from self for slot ${slotNumber}`, {
371
+ if (proposer && this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
372
+ this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
322
373
  proposer: proposer.toString(),
323
- slotNumber
374
+ proposalSlotNumber
324
375
  });
325
376
  return undefined;
326
377
  }
327
- // Validate fee asset price modifier is within allowed range
328
- if (!validateFeeAssetPriceModifier(proposal.feeAssetPriceModifier)) {
329
- this.log.warn(`Received checkpoint proposal with invalid feeAssetPriceModifier ${proposal.feeAssetPriceModifier} for slot ${slotNumber}`);
330
- return undefined;
331
- }
332
- // Check that I have any address in current committee before attesting
333
- const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
378
+ // Check that I have any address in the committee where this checkpoint will land before attesting
379
+ const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
334
380
  const partOfCommittee = inCommittee.length > 0;
335
381
  const proposalInfo = {
336
- slotNumber,
382
+ proposalSlotNumber,
337
383
  archive: proposal.archive.toString(),
338
- proposer: proposer.toString(),
339
- txCount: proposal.txHashes.length
384
+ proposer: proposer?.toString()
340
385
  };
341
- this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
386
+ this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
342
387
  ...proposalInfo,
343
- txHashes: proposal.txHashes.map((t)=>t.toString()),
344
388
  fishermanMode: this.config.fishermanMode || false
345
389
  });
346
- // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
390
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
391
+ // Uses the cached result from the all-nodes callback if available (avoids double validation).
392
+ let checkpointNumber;
347
393
  if (this.config.skipCheckpointProposalValidation) {
348
- this.log.warn(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
394
+ this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
395
+ checkpointNumber = CheckpointNumber(0);
349
396
  } else {
350
- const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
397
+ const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
351
398
  if (!validationResult.isValid) {
352
399
  this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
353
400
  return undefined;
354
401
  }
355
- }
356
- // Upload blobs to filestore if we can (fire and forget)
357
- if (this.blobClient.canUpload()) {
358
- void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
402
+ checkpointNumber = validationResult.checkpointNumber;
359
403
  }
360
404
  // Check that I have any address in current committee before attesting
361
405
  // In fisherman mode, we still create attestations for validation even if not in committee
@@ -364,14 +408,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
364
408
  return undefined;
365
409
  }
366
410
  // Provided all of the above checks pass, we can attest to the proposal
367
- this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
411
+ this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`, {
368
412
  ...proposalInfo,
369
413
  inCommittee: partOfCommittee,
370
414
  fishermanMode: this.config.fishermanMode || false
371
415
  });
372
416
  this.metrics.incSuccessfulAttestations(inCommittee.length);
373
417
  // Track epoch participation per attester: count each (attester, epoch) pair at most once
374
- const proposalEpoch = getEpochAtSlot(slotNumber, this.epochCache.getL1Constants());
418
+ const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
375
419
  for (const attester of inCommittee){
376
420
  const key = attester.toString();
377
421
  const lastEpoch = this.lastAttestedEpochByAttester.get(key);
@@ -396,13 +440,13 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
396
440
  }
397
441
  if (this.config.fishermanMode) {
398
442
  // bail out early and don't save attestations to the pool in fisherman mode
399
- this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
443
+ this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
400
444
  ...proposalInfo,
401
445
  attestors: attestors.map((a)=>a.toString())
402
446
  });
403
447
  return undefined;
404
448
  }
405
- return await this.createCheckpointAttestationsFromProposal(proposal, attestors);
449
+ return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
406
450
  }
407
451
  /**
408
452
  * Checks if we should attest to a slot based on equivocation prevention rules.
@@ -419,164 +463,24 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
419
463
  }
420
464
  return true;
421
465
  }
422
- async createCheckpointAttestationsFromProposal(proposal, attestors = []) {
466
+ async createCheckpointAttestationsFromProposal(proposal, attestors = [], checkpointNumber) {
423
467
  // Equivocation check: must happen right before signing to minimize the race window
424
468
  if (!this.shouldAttestToSlot(proposal.slotNumber)) {
425
469
  return undefined;
426
470
  }
427
- const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
471
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
428
472
  // Track the proposal we attested to (to prevent equivocation)
429
473
  this.lastAttestedProposal = proposal;
430
474
  await this.p2pClient.addOwnCheckpointAttestations(attestations);
431
475
  return attestations;
432
476
  }
433
477
  /**
434
- * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
435
- * @returns Validation result with isValid flag and reason if invalid.
436
- */ async validateCheckpointProposal(proposal, proposalInfo) {
437
- const slot = proposal.slotNumber;
438
- // Timeout block syncing at the start of the next slot
439
- const config = this.checkpointsBuilder.getConfig();
440
- const nextSlotTimestampSeconds = Number(getTimestampForSlot(SlotNumber(slot + 1), config));
441
- const timeoutSeconds = Math.max(1, nextSlotTimestampSeconds - Math.floor(this.dateProvider.now() / 1000));
442
- // Wait for last block to sync by archive
443
- let lastBlockHeader;
444
- try {
445
- lastBlockHeader = await retryUntil(async ()=>{
446
- await this.blockSource.syncImmediate();
447
- return this.blockSource.getBlockHeaderByArchive(proposal.archive);
448
- }, `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`, timeoutSeconds, 0.5);
449
- } catch (err) {
450
- if (err instanceof TimeoutError) {
451
- this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
452
- return {
453
- isValid: false,
454
- reason: 'last_block_not_found'
455
- };
456
- }
457
- this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
458
- return {
459
- isValid: false,
460
- reason: 'block_fetch_error'
461
- };
462
- }
463
- if (!lastBlockHeader) {
464
- this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
465
- return {
466
- isValid: false,
467
- reason: 'last_block_not_found'
468
- };
469
- }
470
- // Get all full blocks for the slot and checkpoint
471
- const blocks = await this.blockSource.getBlocksForSlot(slot);
472
- if (blocks.length === 0) {
473
- this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
474
- return {
475
- isValid: false,
476
- reason: 'no_blocks_for_slot'
477
- };
478
- }
479
- // Ensure the last block for this slot matches the archive in the checkpoint proposal
480
- if (!blocks.at(-1)?.archive.root.equals(proposal.archive)) {
481
- this.log.warn(`Last block archive mismatch for checkpoint proposal`, proposalInfo);
482
- return {
483
- isValid: false,
484
- reason: 'last_block_archive_mismatch'
485
- };
486
- }
487
- this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
488
- ...proposalInfo,
489
- blockNumbers: blocks.map((b)=>b.number)
490
- });
491
- // Get checkpoint constants from first block
492
- const firstBlock = blocks[0];
493
- const constants = this.extractCheckpointConstants(firstBlock);
494
- const checkpointNumber = firstBlock.checkpointNumber;
495
- // Get L1-to-L2 messages for this checkpoint
496
- const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
497
- // Collect the out hashes of all the checkpoints before this one in the same epoch
498
- const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
499
- const previousCheckpointOutHashes = (await this.blockSource.getCheckpointsDataForEpoch(epoch)).filter((c)=>c.checkpointNumber < checkpointNumber).map((c)=>c.checkpointOutHash);
500
- // Fork world state at the block before the first block
501
- const parentBlockNumber = BlockNumber(firstBlock.number - 1);
502
- const fork = await this.worldState.fork(parentBlockNumber);
503
- try {
504
- // Create checkpoint builder with all existing blocks
505
- const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(checkpointNumber, constants, proposal.feeAssetPriceModifier, l1ToL2Messages, previousCheckpointOutHashes, fork, blocks, this.log.getBindings());
506
- // Complete the checkpoint to get computed values
507
- const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
508
- // Compare checkpoint header with proposal
509
- if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
510
- this.log.warn(`Checkpoint header mismatch`, {
511
- ...proposalInfo,
512
- computed: computedCheckpoint.header.toInspect(),
513
- proposal: proposal.checkpointHeader.toInspect()
514
- });
515
- return {
516
- isValid: false,
517
- reason: 'checkpoint_header_mismatch'
518
- };
519
- }
520
- // Compare archive root with proposal
521
- if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
522
- this.log.warn(`Archive root mismatch`, {
523
- ...proposalInfo,
524
- computed: computedCheckpoint.archive.root.toString(),
525
- proposal: proposal.archive.toString()
526
- });
527
- return {
528
- isValid: false,
529
- reason: 'archive_mismatch'
530
- };
531
- }
532
- // Check that the accumulated epoch out hash matches the value in the proposal.
533
- // The epoch out hash is the accumulated hash of all checkpoint out hashes in the epoch.
534
- const checkpointOutHash = computedCheckpoint.getCheckpointOutHash();
535
- const computedEpochOutHash = accumulateCheckpointOutHashes([
536
- ...previousCheckpointOutHashes,
537
- checkpointOutHash
538
- ]);
539
- const proposalEpochOutHash = proposal.checkpointHeader.epochOutHash;
540
- if (!computedEpochOutHash.equals(proposalEpochOutHash)) {
541
- this.log.warn(`Epoch out hash mismatch`, {
542
- proposalEpochOutHash: proposalEpochOutHash.toString(),
543
- computedEpochOutHash: computedEpochOutHash.toString(),
544
- checkpointOutHash: checkpointOutHash.toString(),
545
- previousCheckpointOutHashes: previousCheckpointOutHashes.map((h)=>h.toString()),
546
- ...proposalInfo
547
- });
548
- return {
549
- isValid: false,
550
- reason: 'out_hash_mismatch'
551
- };
552
- }
553
- this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
554
- return {
555
- isValid: true
556
- };
557
- } finally{
558
- await fork.close();
559
- }
560
- }
561
- /**
562
- * Extract checkpoint global variables from a block.
563
- */ extractCheckpointConstants(block) {
564
- const gv = block.header.globalVariables;
565
- return {
566
- chainId: gv.chainId,
567
- version: gv.version,
568
- slotNumber: gv.slotNumber,
569
- timestamp: gv.timestamp,
570
- coinbase: gv.coinbase,
571
- feeRecipient: gv.feeRecipient,
572
- gasFees: gv.gasFees
573
- };
574
- }
575
- /**
576
478
  * Uploads blobs for a checkpoint to the filestore (fire and forget).
577
479
  */ async uploadBlobsForCheckpoint(proposal, proposalInfo) {
578
480
  try {
579
- const lastBlockHeader = await this.blockSource.getBlockHeaderByArchive(proposal.archive);
481
+ const lastBlockHeader = (await this.blockSource.getBlockData({
482
+ archive: proposal.archive
483
+ }))?.header;
580
484
  if (!lastBlockHeader) {
581
485
  this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
582
486
  return;
@@ -604,11 +508,6 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
604
508
  this.log.warn(`Cannot slash proposal with invalid signature`);
605
509
  return;
606
510
  }
607
- // Trim the set if it's too big.
608
- if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
609
- // remove oldest proposer. `values` is guaranteed to be in insertion order.
610
- this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value);
611
- }
612
511
  this.proposersOfInvalidBlocks.add(proposer.toString());
613
512
  this.emit(WANT_TO_SLASH_EVENT, [
614
513
  {
@@ -619,17 +518,95 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
619
518
  }
620
519
  ]);
621
520
  }
521
+ handleInvalidCheckpointProposal(proposal, result, proposalInfo) {
522
+ if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
523
+ return;
524
+ }
525
+ this.markInvalidProposalSlot(proposal.slotNumber);
526
+ if (this.slashInvalidCheckpointProposal(proposal)) {
527
+ this.log.info(`Detected invalid checkpoint proposal offense`, {
528
+ ...proposalInfo,
529
+ reason: result.reason,
530
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
531
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL)
532
+ });
533
+ }
534
+ }
535
+ slashInvalidCheckpointProposal(proposal) {
536
+ const proposer = proposal.getSender();
537
+ if (!proposer) {
538
+ this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
539
+ slotNumber: proposal.slotNumber,
540
+ archive: proposal.archive.toString()
541
+ });
542
+ return false;
543
+ }
544
+ const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
545
+ const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
546
+ if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
547
+ return false;
548
+ }
549
+ this.emit(WANT_TO_SLASH_EVENT, [
550
+ {
551
+ validator: proposer,
552
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
553
+ offenseType,
554
+ epochOrSlot: BigInt(proposal.slotNumber)
555
+ }
556
+ ]);
557
+ return true;
558
+ }
559
+ markInvalidProposalSlot(slotNumber) {
560
+ this.slotsWithInvalidProposals.add(slotNumber);
561
+ }
562
+ handleCheckpointAttestation(attestation) {
563
+ const slotNumber = attestation.slotNumber;
564
+ if (!this.slotsWithInvalidProposals.has(slotNumber) || this.slotsWithProposalEquivocation.has(slotNumber)) {
565
+ return;
566
+ }
567
+ const attester = attestation.getSender();
568
+ if (!attester) {
569
+ this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
570
+ slotNumber,
571
+ archive: attestation.archive.toString()
572
+ });
573
+ return;
574
+ }
575
+ this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
576
+ }
577
+ slashAttestedToInvalidCheckpointProposal(slotNumber, attester) {
578
+ const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
579
+ if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
580
+ return;
581
+ }
582
+ this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
583
+ attester: attester.toString(),
584
+ slotNumber,
585
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
586
+ offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL)
587
+ });
588
+ this.emit(WANT_TO_SLASH_EVENT, [
589
+ {
590
+ validator: attester,
591
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
592
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
593
+ epochOrSlot: BigInt(slotNumber)
594
+ }
595
+ ]);
596
+ }
622
597
  /**
623
598
  * Handle detection of a duplicate proposal (equivocation).
624
599
  * Emits a slash event when a proposer sends multiple proposals for the same position.
625
600
  */ handleDuplicateProposal(info) {
626
601
  const { slot, proposer, type } = info;
627
- this.log.warn(`Triggering slash event for duplicate ${type} proposal from ${proposer.toString()} at slot ${slot}`, {
602
+ this.slotsWithProposalEquivocation.add(slot);
603
+ this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
628
604
  proposer: proposer.toString(),
629
605
  slot,
630
- type
606
+ type,
607
+ amount: this.config.slashDuplicateProposalPenalty,
608
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL)
631
609
  });
632
- // Emit slash event
633
610
  this.emit(WANT_TO_SLASH_EVENT, [
634
611
  {
635
612
  validator: proposer,
@@ -638,15 +615,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
638
615
  epochOrSlot: BigInt(slot)
639
616
  }
640
617
  ]);
618
+ this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
619
+ {
620
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
621
+ epochOrSlot: BigInt(slot)
622
+ }
623
+ ]);
641
624
  }
642
625
  /**
643
626
  * Handle detection of a duplicate attestation (equivocation).
644
627
  * Emits a slash event when an attester signs attestations for different proposals at the same slot.
645
628
  */ handleDuplicateAttestation(info) {
646
629
  const { slot, attester } = info;
647
- this.log.warn(`Triggering slash event for duplicate attestation from ${attester.toString()} at slot ${slot}`, {
630
+ this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
648
631
  attester: attester.toString(),
649
- slot
632
+ slot,
633
+ amount: this.config.slashDuplicateAttestationPenalty,
634
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION)
650
635
  });
651
636
  this.emit(WANT_TO_SLASH_EVENT, [
652
637
  {
@@ -657,7 +642,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
657
642
  }
658
643
  ]);
659
644
  }
660
- async createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
645
+ async createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
661
646
  // Validate that we're not creating a proposal for an older or equal position
662
647
  if (this.lastProposedBlock) {
663
648
  const lastSlot = this.lastProposedBlock.slotNumber;
@@ -668,14 +653,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
668
653
  }
669
654
  }
670
655
  this.log.info(`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`);
671
- const newProposal = await this.validationService.createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
656
+ const newProposal = await this.validationService.createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
672
657
  ...options,
673
- broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal
658
+ broadcastInvalidBlockProposal: options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal
674
659
  });
675
660
  this.lastProposedBlock = newProposal;
676
661
  return newProposal;
677
662
  }
678
- async createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options = {}) {
663
+ async createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options = {}) {
679
664
  // Validate that we're not creating a proposal for an older or equal slot
680
665
  if (this.lastProposedCheckpoint) {
681
666
  const lastSlot = this.lastProposedCheckpoint.slotNumber;
@@ -685,23 +670,30 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
685
670
  }
686
671
  }
687
672
  this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
688
- const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options);
673
+ const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options);
689
674
  this.lastProposedCheckpoint = newProposal;
675
+ // Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
676
+ // own proposals through `handleCheckpointProposal`, so without this call the proposer's
677
+ // sentinel would see no outcome for slots it proposed and would mis-attribute itself as
678
+ // inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
679
+ // be intentionally corrupted under test-only flags); from the proposer's local-view
680
+ // perspective the work it just completed is valid by definition.
681
+ this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
690
682
  return newProposal;
691
683
  }
692
684
  async broadcastBlockProposal(proposal) {
693
685
  await this.p2pClient.broadcastProposal(proposal);
694
686
  }
695
- async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber) {
696
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
687
+ async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber) {
688
+ return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber);
697
689
  }
698
- async collectOwnAttestations(proposal) {
690
+ async collectOwnAttestations(proposal, checkpointNumber) {
699
691
  const slot = proposal.slotNumber;
700
692
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
701
693
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, {
702
694
  inCommittee
703
695
  });
704
- const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
696
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
705
697
  if (!attestations) {
706
698
  return [];
707
699
  }
@@ -713,7 +705,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
713
705
  });
714
706
  return attestations;
715
707
  }
716
- async collectAttestations(proposal, required, deadline) {
708
+ async collectAttestations(proposal, required, deadline, checkpointNumber) {
717
709
  // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
718
710
  const slot = proposal.slotNumber;
719
711
  this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
@@ -721,28 +713,20 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
721
713
  this.log.error(`Deadline ${deadline.toISOString()} for collecting ${required} attestations for slot ${slot} is in the past`);
722
714
  throw new AttestationTimeoutError(0, required, slot);
723
715
  }
724
- await this.collectOwnAttestations(proposal);
725
- const proposalId = proposal.archive.toString();
716
+ await this.collectOwnAttestations(proposal, checkpointNumber);
717
+ const proposalPayloadHash = proposal.getPayloadHash();
726
718
  const myAddresses = this.getValidatorAddresses();
727
719
  let attestations = [];
728
720
  while(true){
729
- // Filter out attestations with a mismatching archive. This should NOT happen since we have verified
730
- // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
731
- const collectedAttestations = (await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalId)).filter((attestation)=>{
732
- if (!attestation.archive.equals(proposal.archive)) {
733
- this.log.warn(`Received attestation for slot ${slot} with mismatched archive from ${attestation.getSender()?.toString()}`, {
734
- attestationArchive: attestation.archive.toString(),
735
- proposalArchive: proposal.archive.toString()
736
- });
737
- return false;
738
- }
739
- return true;
740
- });
721
+ // The pool already filters by proposal payload hash; if any attestation slips through with a
722
+ // mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
723
+ // events from libp2p_service.
724
+ const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
741
725
  // Log new attestations we collected
742
726
  const oldSenders = attestations.map((attestation)=>attestation.getSender());
743
727
  for (const collected of collectedAttestations){
744
728
  const collectedSender = collected.getSender();
745
- // Skip attestations with invalid signatures
729
+ // Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
746
730
  if (!collectedSender) {
747
731
  this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
748
732
  continue;