@aztec/validator-client 0.0.1-commit.179ed20 → 0.0.1-commit.189eedb3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (54) hide show
  1. package/README.md +61 -18
  2. package/dest/checkpoint_builder.d.ts +21 -8
  3. package/dest/checkpoint_builder.d.ts.map +1 -1
  4. package/dest/checkpoint_builder.js +124 -46
  5. package/dest/config.d.ts +1 -1
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +37 -7
  8. package/dest/duties/validation_service.d.ts +12 -13
  9. package/dest/duties/validation_service.d.ts.map +1 -1
  10. package/dest/duties/validation_service.js +33 -45
  11. package/dest/factory.d.ts +10 -4
  12. package/dest/factory.d.ts.map +1 -1
  13. package/dest/factory.js +11 -5
  14. package/dest/index.d.ts +2 -3
  15. package/dest/index.d.ts.map +1 -1
  16. package/dest/index.js +1 -2
  17. package/dest/key_store/ha_key_store.d.ts +1 -1
  18. package/dest/key_store/ha_key_store.d.ts.map +1 -1
  19. package/dest/key_store/ha_key_store.js +3 -3
  20. package/dest/metrics.d.ts +14 -2
  21. package/dest/metrics.d.ts.map +1 -1
  22. package/dest/metrics.js +24 -0
  23. package/dest/proposal_handler.d.ts +134 -0
  24. package/dest/proposal_handler.d.ts.map +1 -0
  25. package/dest/proposal_handler.js +1072 -0
  26. package/dest/validator.d.ts +58 -23
  27. package/dest/validator.d.ts.map +1 -1
  28. package/dest/validator.js +362 -228
  29. package/package.json +19 -19
  30. package/src/checkpoint_builder.ts +142 -39
  31. package/src/config.ts +37 -6
  32. package/src/duties/validation_service.ts +59 -54
  33. package/src/factory.ts +20 -3
  34. package/src/index.ts +1 -2
  35. package/src/key_store/ha_key_store.ts +3 -3
  36. package/src/metrics.ts +37 -1
  37. package/src/proposal_handler.ts +1161 -0
  38. package/src/validator.ts +487 -270
  39. package/dest/block_proposal_handler.d.ts +0 -63
  40. package/dest/block_proposal_handler.d.ts.map +0 -1
  41. package/dest/block_proposal_handler.js +0 -546
  42. package/dest/tx_validator/index.d.ts +0 -3
  43. package/dest/tx_validator/index.d.ts.map +0 -1
  44. package/dest/tx_validator/index.js +0 -2
  45. package/dest/tx_validator/nullifier_cache.d.ts +0 -14
  46. package/dest/tx_validator/nullifier_cache.d.ts.map +0 -1
  47. package/dest/tx_validator/nullifier_cache.js +0 -24
  48. package/dest/tx_validator/tx_validator_factory.d.ts +0 -19
  49. package/dest/tx_validator/tx_validator_factory.d.ts.map +0 -1
  50. package/dest/tx_validator/tx_validator_factory.js +0 -54
  51. package/src/block_proposal_handler.ts +0 -555
  52. package/src/tx_validator/index.ts +0 -2
  53. package/src/tx_validator/nullifier_cache.ts +0 -30
  54. package/src/tx_validator/tx_validator_factory.ts +0 -154
package/src/validator.ts CHANGED
@@ -1,73 +1,111 @@
1
1
  import type { BlobClientInterface } from '@aztec/blob-client/client';
2
2
  import { type Blob, getBlobsPerL1Block } from '@aztec/blob-lib';
3
3
  import type { EpochCache } from '@aztec/epoch-cache';
4
- import {
5
- BlockNumber,
6
- CheckpointNumber,
7
- EpochNumber,
8
- IndexWithinCheckpoint,
9
- SlotNumber,
10
- } from '@aztec/foundation/branded-types';
4
+ import { CheckpointNumber, EpochNumber, IndexWithinCheckpoint, SlotNumber } from '@aztec/foundation/branded-types';
11
5
  import { Fr } from '@aztec/foundation/curves/bn254';
12
- import { TimeoutError } from '@aztec/foundation/error';
13
6
  import type { EthAddress } from '@aztec/foundation/eth-address';
14
7
  import type { Signature } from '@aztec/foundation/eth-signature';
8
+ import { FifoSet } from '@aztec/foundation/fifo-set';
15
9
  import { type LogData, type Logger, createLogger } from '@aztec/foundation/log';
16
- import { retryUntil } from '@aztec/foundation/retry';
17
10
  import { RunningPromise } from '@aztec/foundation/running-promise';
18
11
  import { sleep } from '@aztec/foundation/sleep';
19
12
  import { DateProvider } from '@aztec/foundation/timer';
20
13
  import type { KeystoreManager } from '@aztec/node-keystore';
21
- import type { P2P, PeerId } from '@aztec/p2p';
14
+ import type { DuplicateAttestationInfo, DuplicateProposalInfo, P2P, PeerId } from '@aztec/p2p';
22
15
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
23
- import { OffenseType, WANT_TO_SLASH_EVENT, type Watcher, type WatcherEmitter } from '@aztec/slasher';
16
+ import {
17
+ OffenseType,
18
+ WANT_TO_CLEAR_SLASH_EVENT,
19
+ WANT_TO_SLASH_EVENT,
20
+ type Watcher,
21
+ type WatcherEmitter,
22
+ getOffenseTypeName,
23
+ } from '@aztec/slasher';
24
24
  import type { AztecAddress } from '@aztec/stdlib/aztec-address';
25
- import type { CommitteeAttestationsAndSigners, L2Block, L2BlockSink, L2BlockSource } from '@aztec/stdlib/block';
25
+ import type { CommitteeAttestationsAndSigners, L2BlockSink, L2BlockSource } from '@aztec/stdlib/block';
26
+ import type { CheckpointReexecutionTracker } from '@aztec/stdlib/checkpoint';
26
27
  import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
27
28
  import type {
28
- CreateCheckpointProposalLastBlockData,
29
29
  ITxProvider,
30
30
  Validator,
31
31
  ValidatorClientFullConfig,
32
32
  WorldStateSynchronizer,
33
33
  } from '@aztec/stdlib/interfaces/server';
34
- import { type L1ToL2MessageSource, accumulateCheckpointOutHashes } from '@aztec/stdlib/messaging';
35
- import type {
36
- BlockProposal,
37
- BlockProposalOptions,
38
- CheckpointAttestation,
39
- CheckpointProposalCore,
40
- CheckpointProposalOptions,
34
+ import type { L1ToL2MessageSource } from '@aztec/stdlib/messaging';
35
+ import {
36
+ type BlockProposal,
37
+ type BlockProposalOptions,
38
+ type CheckpointAttestation,
39
+ CheckpointProposal,
40
+ type CheckpointProposalCore,
41
+ type CheckpointProposalOptions,
42
+ type CoordinationSignatureContext,
41
43
  } from '@aztec/stdlib/p2p';
42
- import { CheckpointProposal } from '@aztec/stdlib/p2p';
43
44
  import type { CheckpointHeader } from '@aztec/stdlib/rollup';
44
- import type { BlockHeader, CheckpointGlobalVariables, Tx } from '@aztec/stdlib/tx';
45
+ import type { BlockHeader, Tx } from '@aztec/stdlib/tx';
45
46
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
46
47
  import { type TelemetryClient, type Tracer, getTelemetryClient } from '@aztec/telemetry-client';
47
- import { createHASigner } from '@aztec/validator-ha-signer/factory';
48
- import { DutyType, type SigningContext } from '@aztec/validator-ha-signer/types';
48
+ import {
49
+ createHASigner,
50
+ createLocalSignerWithProtection,
51
+ createSignerFromSharedDb,
52
+ } from '@aztec/validator-ha-signer/factory';
53
+ import { DutyType, type SigningContext, type SlashingProtectionDatabase } from '@aztec/validator-ha-signer/types';
54
+ import type { ValidatorHASigner } from '@aztec/validator-ha-signer/validator-ha-signer';
49
55
 
50
56
  import { EventEmitter } from 'events';
51
57
  import type { TypedDataDefinition } from 'viem';
52
58
 
53
- import { BlockProposalHandler, type BlockProposalValidationFailureReason } from './block_proposal_handler.js';
54
59
  import type { FullNodeCheckpointsBuilder } from './checkpoint_builder.js';
55
60
  import { ValidationService } from './duties/validation_service.js';
56
61
  import { HAKeyStore } from './key_store/ha_key_store.js';
57
62
  import type { ExtendedValidatorKeyStore } from './key_store/interface.js';
58
63
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
59
64
  import { ValidatorMetrics } from './metrics.js';
65
+ import {
66
+ type BlockProposalValidationFailureReason,
67
+ type CheckpointProposalValidationFailureReason,
68
+ type CheckpointProposalValidationFailureResult,
69
+ ProposalHandler,
70
+ } from './proposal_handler.js';
60
71
 
61
72
  // We maintain a set of proposers who have proposed invalid blocks.
62
73
  // Just cap the set to avoid unbounded growth.
63
74
  const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
75
+ const MAX_TRACKED_INVALID_PROPOSAL_SLOTS = 1000;
76
+ const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
77
+ const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
64
78
 
65
79
  // What errors from the block proposal handler result in slashing
66
80
  const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT: BlockProposalValidationFailureReason[] = [
67
81
  'state_mismatch',
68
82
  'failed_txs',
83
+ 'global_variables_mismatch',
84
+ 'invalid_proposal',
85
+ 'parent_block_wrong_slot',
86
+ 'in_hash_mismatch',
69
87
  ];
70
88
 
89
+ const SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT: Record<CheckpointProposalValidationFailureReason, boolean> = {
90
+ // enabled
91
+ ['invalid_fee_asset_price_modifier']: true,
92
+ ['checkpoint_header_mismatch']: true,
93
+ // These late mismatches should normally be caught by earlier checks, but if reached after validating the local
94
+ // checkpoint inputs, the proposer-signed payload disagrees with deterministic recomputation.
95
+ ['archive_mismatch']: true,
96
+ ['out_hash_mismatch']: true,
97
+ ['no_blocks_for_slot']: true,
98
+ ['too_many_blocks_in_checkpoint']: true,
99
+ ['checkpoint_validation_failed']: true,
100
+ ['last_block_archive_mismatch']: true,
101
+
102
+ // disabled
103
+ ['invalid_signature']: false,
104
+ ['last_block_not_found']: false,
105
+ ['block_fetch_error']: false,
106
+ ['checkpoint_already_published']: false,
107
+ };
108
+
71
109
  /**
72
110
  * Validator Client
73
111
  */
@@ -76,29 +114,41 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
76
114
  private validationService: ValidationService;
77
115
  private metrics: ValidatorMetrics;
78
116
  private log: Logger;
79
-
80
117
  // Whether it has already registered handlers on the p2p client
81
118
  private hasRegisteredHandlers = false;
82
119
 
83
- // Used to check if we are sending the same proposal twice
84
- private previousProposal?: BlockProposal;
120
+ /** Tracks the last block proposal we created, to detect duplicate proposal attempts. */
121
+ private lastProposedBlock?: BlockProposal;
122
+
123
+ /** Tracks the last checkpoint proposal we created. */
124
+ private lastProposedCheckpoint?: CheckpointProposal;
85
125
 
86
126
  private lastEpochForCommitteeUpdateLoop: EpochNumber | undefined;
87
127
  private epochCacheUpdateLoop: RunningPromise;
128
+ /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */
129
+ private lastAttestedEpochByAttester: Map<string, EpochNumber> = new Map();
88
130
 
89
- private proposersOfInvalidBlocks: Set<string> = new Set();
131
+ private proposersOfInvalidBlocks = FifoSet.withLimit<string>(MAX_PROPOSERS_OF_INVALID_BLOCKS);
132
+ private slotsWithInvalidProposals = FifoSet.withLimit<SlotNumber>(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
133
+ private invalidCheckpointProposalOffenseKeys = FifoSet.withLimit<string>(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS);
134
+ private badAttestationOffenseKeys = FifoSet.withLimit<string>(MAX_TRACKED_BAD_ATTESTATIONS);
135
+ private slotsWithProposalEquivocation = FifoSet.withLimit<SlotNumber>(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
136
+
137
+ /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */
138
+ private lastAttestedProposal?: CheckpointProposalCore;
90
139
 
91
140
  protected constructor(
92
141
  private keyStore: ExtendedValidatorKeyStore,
93
142
  private epochCache: EpochCache,
94
143
  private p2pClient: P2P,
95
- private blockProposalHandler: BlockProposalHandler,
144
+ private proposalHandler: ProposalHandler,
96
145
  private blockSource: L2BlockSource,
97
146
  private checkpointsBuilder: FullNodeCheckpointsBuilder,
98
147
  private worldState: WorldStateSynchronizer,
99
148
  private l1ToL2MessageSource: L1ToL2MessageSource,
100
149
  private config: ValidatorClientFullConfig,
101
150
  private blobClient: BlobClientInterface,
151
+ private slashingProtectionSigner: ValidatorHASigner,
102
152
  private dateProvider: DateProvider = new DateProvider(),
103
153
  telemetry: TelemetryClient = getTelemetryClient(),
104
154
  log = createLogger('validator'),
@@ -111,11 +161,17 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
111
161
  this.tracer = telemetry.getTracer('Validator');
112
162
  this.metrics = new ValidatorMetrics(telemetry);
113
163
 
114
- this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
164
+ this.validationService = new ValidationService(
165
+ keyStore,
166
+ this.getSignatureContext(),
167
+ this.log.createChild('validation-service'),
168
+ );
169
+ this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo) =>
170
+ this.handleInvalidCheckpointProposal(proposal, result, proposalInfo),
171
+ );
115
172
 
116
173
  // Refresh epoch cache every second to trigger alert if participation in committee changes
117
174
  this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
118
-
119
175
  const myAddresses = this.getValidatorAddresses();
120
176
  this.log.verbose(`Initialized validator with addresses: ${myAddresses.map(a => a.toString()).join(', ')}`);
121
177
  }
@@ -152,6 +208,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
152
208
  this.log.trace(`No committee found for slot`);
153
209
  return;
154
210
  }
211
+ this.metrics.setCurrentEpoch(epoch);
155
212
  if (epoch !== this.lastEpochForCommitteeUpdateLoop) {
156
213
  const me = this.getValidatorAddresses();
157
214
  const committeeSet = new Set(committee.map(v => v.toString()));
@@ -183,14 +240,23 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
183
240
  txProvider: ITxProvider,
184
241
  keyStoreManager: KeystoreManager,
185
242
  blobClient: BlobClientInterface,
243
+ reexecutionTracker: CheckpointReexecutionTracker,
186
244
  dateProvider: DateProvider = new DateProvider(),
187
245
  telemetry: TelemetryClient = getTelemetryClient(),
246
+ slashingProtectionDb?: SlashingProtectionDatabase,
188
247
  ) {
189
248
  const metrics = new ValidatorMetrics(telemetry);
190
249
  const blockProposalValidator = new BlockProposalValidator(epochCache, {
191
250
  txsPermitted: !config.disableTransactions,
251
+ maxTxsPerBlock: config.validateMaxTxsPerBlock,
252
+ maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
253
+ skipSlotValidation: config.skipProposalSlotValidation,
254
+ signatureContext: {
255
+ chainId: config.l1ChainId,
256
+ rollupAddress: config.rollupAddress,
257
+ },
192
258
  });
193
- const blockProposalHandler = new BlockProposalHandler(
259
+ const proposalHandler = new ProposalHandler(
194
260
  checkpointsBuilder,
195
261
  worldState,
196
262
  blockSource,
@@ -199,33 +265,55 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
199
265
  blockProposalValidator,
200
266
  epochCache,
201
267
  config,
268
+ blobClient,
269
+ reexecutionTracker,
202
270
  metrics,
203
271
  dateProvider,
204
272
  telemetry,
273
+ undefined,
205
274
  );
206
275
 
207
- let validatorKeyStore: ExtendedValidatorKeyStore = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
208
- if (config.haSigningEnabled) {
276
+ const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
277
+ let slashingProtectionSigner: ValidatorHASigner;
278
+ if (slashingProtectionDb) {
279
+ // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
280
+ ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
281
+ telemetryClient: telemetry,
282
+ dateProvider,
283
+ }));
284
+ } else if (config.haSigningEnabled) {
285
+ // Multi-node HA mode: use PostgreSQL-backed distributed locking.
209
286
  // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
210
287
  const haConfig = {
211
288
  ...config,
212
289
  maxStuckDutiesAgeMs: config.maxStuckDutiesAgeMs ?? epochCache.getL1Constants().slotDuration * 2 * 1000,
213
290
  };
214
- const { signer } = await createHASigner(haConfig);
215
- validatorKeyStore = new HAKeyStore(validatorKeyStore, signer);
291
+ ({ signer: slashingProtectionSigner } = await createHASigner(haConfig, {
292
+ telemetryClient: telemetry,
293
+ dateProvider,
294
+ }));
295
+ } else {
296
+ // Single-node mode: use LMDB-backed local signing protection.
297
+ // This prevents double-signing if the node crashes and restarts mid-proposal.
298
+ ({ signer: slashingProtectionSigner } = await createLocalSignerWithProtection(config, {
299
+ telemetryClient: telemetry,
300
+ dateProvider,
301
+ }));
216
302
  }
303
+ const validatorKeyStore: ExtendedValidatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
217
304
 
218
305
  const validator = new ValidatorClient(
219
306
  validatorKeyStore,
220
307
  epochCache,
221
308
  p2pClient,
222
- blockProposalHandler,
309
+ proposalHandler,
223
310
  blockSource,
224
311
  checkpointsBuilder,
225
312
  worldState,
226
313
  l1ToL2MessageSource,
227
314
  config,
228
315
  blobClient,
316
+ slashingProtectionSigner,
229
317
  dateProvider,
230
318
  telemetry,
231
319
  );
@@ -239,14 +327,21 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
239
327
  .filter(addr => !this.config.disabledValidators.some(disabled => disabled.equals(addr)));
240
328
  }
241
329
 
242
- public getBlockProposalHandler() {
243
- return this.blockProposalHandler;
330
+ public getProposalHandler() {
331
+ return this.proposalHandler;
244
332
  }
245
333
 
246
334
  public signWithAddress(addr: EthAddress, msg: TypedDataDefinition, context: SigningContext) {
247
335
  return this.keyStore.signTypedDataWithAddress(addr, msg, context);
248
336
  }
249
337
 
338
+ private getSignatureContext(): CoordinationSignatureContext {
339
+ return {
340
+ chainId: this.config.l1ChainId,
341
+ rollupAddress: this.config.rollupAddress,
342
+ };
343
+ }
344
+
250
345
  public getCoinbaseForAttestor(attestor: EthAddress): EthAddress {
251
346
  return this.keyStore.getCoinbaseAddress(attestor);
252
347
  }
@@ -259,8 +354,27 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
259
354
  return this.config;
260
355
  }
261
356
 
357
+ public hasProposalEquivocation(slotNumber: SlotNumber): boolean {
358
+ return this.slotsWithProposalEquivocation.has(slotNumber);
359
+ }
360
+
361
+ public hasInvalidProposals(slotNumber: SlotNumber): boolean {
362
+ return this.slotsWithInvalidProposals.has(slotNumber);
363
+ }
364
+
262
365
  public updateConfig(config: Partial<ValidatorClientFullConfig>) {
263
366
  this.config = { ...this.config, ...config };
367
+ this.proposalHandler.updateConfig(config);
368
+ }
369
+
370
+ public reloadKeystore(newManager: KeystoreManager): void {
371
+ const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
372
+ this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
373
+ this.validationService = new ValidationService(
374
+ this.keyStore,
375
+ this.getSignatureContext(),
376
+ this.log.createChild('validation-service'),
377
+ );
264
378
  }
265
379
 
266
380
  public async start() {
@@ -307,7 +421,21 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
307
421
  checkpoint: CheckpointProposalCore,
308
422
  proposalSender: PeerId,
309
423
  ): Promise<CheckpointAttestation[] | undefined> => this.attestToCheckpointProposal(checkpoint, proposalSender);
310
- this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
424
+ this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
425
+
426
+ // Duplicate proposal handler - triggers slashing for equivocation
427
+ this.p2pClient.registerDuplicateProposalCallback((info: DuplicateProposalInfo) => {
428
+ this.handleDuplicateProposal(info);
429
+ });
430
+
431
+ // Duplicate attestation handler - triggers slashing for attestation equivocation
432
+ this.p2pClient.registerDuplicateAttestationCallback((info: DuplicateAttestationInfo) => {
433
+ this.handleDuplicateAttestation(info);
434
+ });
435
+
436
+ this.p2pClient.registerCheckpointAttestationCallback((attestation: CheckpointAttestation) => {
437
+ this.handleCheckpointAttestation(attestation);
438
+ });
311
439
 
312
440
  const myAddresses = this.getValidatorAddresses();
313
441
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
@@ -336,6 +464,14 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
336
464
  return false;
337
465
  }
338
466
 
467
+ // Log self-proposals from HA peers (same validator key on different nodes)
468
+ if (this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
469
+ this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
470
+ proposer: proposer.toString(),
471
+ slotNumber,
472
+ });
473
+ }
474
+
339
475
  // Check if we're in the committee (for metrics purposes)
340
476
  const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
341
477
  const partOfCommittee = inCommittee.length > 0;
@@ -347,27 +483,14 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
347
483
  fishermanMode: this.config.fishermanMode || false,
348
484
  });
349
485
 
350
- // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
351
- // In fisherman mode, we always reexecute to validate proposals.
352
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } =
353
- this.config;
354
- const shouldReexecute =
355
- fishermanMode ||
356
- (slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute) ||
357
- (partOfCommittee && validatorReexecute) ||
358
- alwaysReexecuteBlockProposals ||
359
- this.blobClient.canUpload();
360
-
361
- const validationResult = await this.blockProposalHandler.handleBlockProposal(
362
- proposal,
363
- proposalSender,
364
- !!shouldReexecute && !escapeHatchOpen,
365
- );
486
+ // Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
487
+ const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
366
488
 
367
489
  if (!validationResult.isValid) {
368
- this.log.warn(`Block proposal validation failed: ${validationResult.reason}`, proposalInfo);
369
-
370
490
  const reason = validationResult.reason || 'unknown';
491
+
492
+ this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
493
+
371
494
  // Classify failure reason: bad proposal vs node issue
372
495
  const badProposalReasons: BlockProposalValidationFailureReason[] = [
373
496
  'invalid_proposal',
@@ -384,15 +507,18 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
384
507
  this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
385
508
  }
386
509
 
387
- // Slash invalid block proposals (can happen even when not in committee)
388
510
  if (
389
511
  !escapeHatchOpen &&
390
512
  validationResult.reason &&
391
- SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) &&
392
- slashBroadcastedInvalidBlockPenalty > 0n
513
+ SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)
393
514
  ) {
394
- this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
515
+ this.log.info(`Detected invalid block proposal offense`, {
516
+ ...proposalInfo,
517
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
518
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL),
519
+ });
395
520
  this.slashInvalidBlock(proposal);
521
+ this.markInvalidProposalSlot(proposal.slotNumber);
396
522
  }
397
523
  return false;
398
524
  }
@@ -422,51 +548,56 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
422
548
  proposal: CheckpointProposalCore,
423
549
  _proposalSender: PeerId,
424
550
  ): Promise<CheckpointAttestation[] | undefined> {
425
- const slotNumber = proposal.slotNumber;
551
+ const proposalSlotNumber = proposal.slotNumber;
426
552
  const proposer = proposal.getSender();
427
553
 
428
554
  // If escape hatch is open for this slot's epoch, do not attest.
429
- if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
430
- this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
555
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
556
+ this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
431
557
  return undefined;
432
558
  }
433
559
 
434
- // Reject proposals with invalid signatures
435
- if (!proposer) {
436
- this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
560
+ // Early-out for equivocation: refuses if we've already attested to a higher slot.
561
+ if (!this.shouldAttestToSlot(proposalSlotNumber)) {
437
562
  return undefined;
438
563
  }
439
564
 
440
- // Check that I have any address in current committee before attesting
441
- const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
565
+ // Ignore proposals from ourselves (may happen in HA setups)
566
+ if (proposer && this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
567
+ this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
568
+ proposer: proposer.toString(),
569
+ proposalSlotNumber,
570
+ });
571
+ return undefined;
572
+ }
573
+
574
+ // Check that I have any address in the committee where this checkpoint will land before attesting
575
+ const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
442
576
  const partOfCommittee = inCommittee.length > 0;
443
577
 
444
578
  const proposalInfo = {
445
- slotNumber,
579
+ proposalSlotNumber,
446
580
  archive: proposal.archive.toString(),
447
- proposer: proposer.toString(),
448
- txCount: proposal.txHashes.length,
581
+ proposer: proposer?.toString(),
449
582
  };
450
- this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
583
+ this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
451
584
  ...proposalInfo,
452
- txHashes: proposal.txHashes.map(t => t.toString()),
453
585
  fishermanMode: this.config.fishermanMode || false,
454
586
  });
455
587
 
456
- // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
588
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
589
+ // Uses the cached result from the all-nodes callback if available (avoids double validation).
590
+ let checkpointNumber: CheckpointNumber;
457
591
  if (this.config.skipCheckpointProposalValidation) {
458
- this.log.warn(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
592
+ this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
593
+ checkpointNumber = CheckpointNumber(0);
459
594
  } else {
460
- const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
595
+ const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
461
596
  if (!validationResult.isValid) {
462
597
  this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
463
598
  return undefined;
464
599
  }
465
- }
466
-
467
- // Upload blobs to filestore if we can (fire and forget)
468
- if (this.blobClient.canUpload()) {
469
- void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
600
+ checkpointNumber = validationResult.checkpointNumber;
470
601
  }
471
602
 
472
603
  // Check that I have any address in current committee before attesting
@@ -477,14 +608,28 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
477
608
  }
478
609
 
479
610
  // Provided all of the above checks pass, we can attest to the proposal
480
- this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
481
- ...proposalInfo,
482
- inCommittee: partOfCommittee,
483
- fishermanMode: this.config.fishermanMode || false,
484
- });
611
+ this.log.info(
612
+ `${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`,
613
+ {
614
+ ...proposalInfo,
615
+ inCommittee: partOfCommittee,
616
+ fishermanMode: this.config.fishermanMode || false,
617
+ },
618
+ );
485
619
 
486
620
  this.metrics.incSuccessfulAttestations(inCommittee.length);
487
621
 
622
+ // Track epoch participation per attester: count each (attester, epoch) pair at most once
623
+ const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
624
+ for (const attester of inCommittee) {
625
+ const key = attester.toString();
626
+ const lastEpoch = this.lastAttestedEpochByAttester.get(key);
627
+ if (lastEpoch === undefined || proposalEpoch > lastEpoch) {
628
+ this.lastAttestedEpochByAttester.set(key, proposalEpoch);
629
+ this.metrics.incAttestedEpochCount(attester);
630
+ }
631
+ }
632
+
488
633
  // Determine which validators should attest
489
634
  let attestors: EthAddress[];
490
635
  if (partOfCommittee) {
@@ -503,174 +648,62 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
503
648
 
504
649
  if (this.config.fishermanMode) {
505
650
  // bail out early and don't save attestations to the pool in fisherman mode
506
- this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
651
+ this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
507
652
  ...proposalInfo,
508
653
  attestors: attestors.map(a => a.toString()),
509
654
  });
510
655
  return undefined;
511
656
  }
512
657
 
513
- return this.createCheckpointAttestationsFromProposal(proposal, attestors);
514
- }
515
-
516
- private async createCheckpointAttestationsFromProposal(
517
- proposal: CheckpointProposalCore,
518
- attestors: EthAddress[] = [],
519
- ): Promise<CheckpointAttestation[]> {
520
- const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
521
- await this.p2pClient.addCheckpointAttestations(attestations);
522
- return attestations;
658
+ return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
523
659
  }
524
660
 
525
661
  /**
526
- * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
527
- * @returns Validation result with isValid flag and reason if invalid.
662
+ * Checks if we should attest to a slot based on equivocation prevention rules.
663
+ * @returns true if we should attest, false if we should skip
528
664
  */
529
- private async validateCheckpointProposal(
530
- proposal: CheckpointProposalCore,
531
- proposalInfo: LogData,
532
- ): Promise<{ isValid: true } | { isValid: false; reason: string }> {
533
- const slot = proposal.slotNumber;
534
- const timeoutSeconds = 10; // TODO(palla/mbps): This should map to the timetable settings
665
+ private shouldAttestToSlot(slotNumber: SlotNumber): boolean {
666
+ // If attestToEquivocatedProposals is true, always allow
667
+ if (this.config.attestToEquivocatedProposals) {
668
+ return true;
669
+ }
535
670
 
536
- // Wait for last block to sync by archive
537
- let lastBlockHeader: BlockHeader | undefined;
538
- try {
539
- lastBlockHeader = await retryUntil(
540
- async () => {
541
- await this.blockSource.syncImmediate();
542
- return this.blockSource.getBlockHeaderByArchive(proposal.archive);
543
- },
544
- `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`,
545
- timeoutSeconds,
546
- 0.5,
671
+ // Check if incoming slot is strictly greater than last attested
672
+ if (this.lastAttestedProposal && slotNumber <= this.lastAttestedProposal.slotNumber) {
673
+ this.log.warn(
674
+ `Refusing to process a proposal for slot ${slotNumber} given we already attested to a proposal for slot ${this.lastAttestedProposal.slotNumber}`,
547
675
  );
548
- } catch (err) {
549
- if (err instanceof TimeoutError) {
550
- this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
551
- return { isValid: false, reason: 'last_block_not_found' };
552
- }
553
- this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
554
- return { isValid: false, reason: 'block_fetch_error' };
676
+ return false;
555
677
  }
556
678
 
557
- if (!lastBlockHeader) {
558
- this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
559
- return { isValid: false, reason: 'last_block_not_found' };
560
- }
679
+ return true;
680
+ }
561
681
 
562
- // Get all full blocks for the slot and checkpoint
563
- const blocks = await this.blockSource.getBlocksForSlot(slot);
564
- if (blocks.length === 0) {
565
- this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
566
- return { isValid: false, reason: 'no_blocks_for_slot' };
682
+ private async createCheckpointAttestationsFromProposal(
683
+ proposal: CheckpointProposalCore,
684
+ attestors: EthAddress[] = [],
685
+ checkpointNumber: CheckpointNumber,
686
+ ): Promise<CheckpointAttestation[] | undefined> {
687
+ // Equivocation check: must happen right before signing to minimize the race window
688
+ if (!this.shouldAttestToSlot(proposal.slotNumber)) {
689
+ return undefined;
567
690
  }
568
691
 
569
- this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
570
- ...proposalInfo,
571
- blockNumbers: blocks.map(b => b.number),
572
- });
573
-
574
- // Get checkpoint constants from first block
575
- const firstBlock = blocks[0];
576
- const constants = this.extractCheckpointConstants(firstBlock);
577
- const checkpointNumber = firstBlock.checkpointNumber;
692
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
578
693
 
579
- // Get L1-to-L2 messages for this checkpoint
580
- const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
694
+ // Track the proposal we attested to (to prevent equivocation)
695
+ this.lastAttestedProposal = proposal;
581
696
 
582
- // Compute the previous checkpoint out hashes for the epoch.
583
- // TODO: There can be a more efficient way to get the previous checkpoint out hashes without having to fetch the
584
- // actual checkpoints and the blocks/txs in them.
585
- const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
586
- const previousCheckpoints = (await this.blockSource.getCheckpointsForEpoch(epoch))
587
- .filter(b => b.number < checkpointNumber)
588
- .sort((a, b) => a.number - b.number);
589
- const previousCheckpointOutHashes = previousCheckpoints.map(c => c.getCheckpointOutHash());
590
-
591
- // Fork world state at the block before the first block
592
- const parentBlockNumber = BlockNumber(firstBlock.number - 1);
593
- const fork = await this.worldState.fork(parentBlockNumber);
594
-
595
- try {
596
- // Create checkpoint builder with all existing blocks
597
- const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(
598
- checkpointNumber,
599
- constants,
600
- l1ToL2Messages,
601
- previousCheckpointOutHashes,
602
- fork,
603
- blocks,
604
- this.log.getBindings(),
605
- );
606
-
607
- // Complete the checkpoint to get computed values
608
- const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
609
-
610
- // Compare checkpoint header with proposal
611
- if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
612
- this.log.warn(`Checkpoint header mismatch`, {
613
- ...proposalInfo,
614
- computed: computedCheckpoint.header.toInspect(),
615
- proposal: proposal.checkpointHeader.toInspect(),
616
- });
617
- return { isValid: false, reason: 'checkpoint_header_mismatch' };
618
- }
619
-
620
- // Compare archive root with proposal
621
- if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
622
- this.log.warn(`Archive root mismatch`, {
623
- ...proposalInfo,
624
- computed: computedCheckpoint.archive.root.toString(),
625
- proposal: proposal.archive.toString(),
626
- });
627
- return { isValid: false, reason: 'archive_mismatch' };
628
- }
629
-
630
- // Check that the accumulated epoch out hash matches the value in the proposal.
631
- // The epoch out hash is the accumulated hash of all checkpoint out hashes in the epoch.
632
- const checkpointOutHash = computedCheckpoint.getCheckpointOutHash();
633
- const computedEpochOutHash = accumulateCheckpointOutHashes([...previousCheckpointOutHashes, checkpointOutHash]);
634
- const proposalEpochOutHash = proposal.checkpointHeader.epochOutHash;
635
- if (!computedEpochOutHash.equals(proposalEpochOutHash)) {
636
- this.log.warn(`Epoch out hash mismatch`, {
637
- proposalEpochOutHash: proposalEpochOutHash.toString(),
638
- computedEpochOutHash: computedEpochOutHash.toString(),
639
- checkpointOutHash: checkpointOutHash.toString(),
640
- previousCheckpointOutHashes: previousCheckpointOutHashes.map(h => h.toString()),
641
- ...proposalInfo,
642
- });
643
- return { isValid: false, reason: 'out_hash_mismatch' };
644
- }
645
-
646
- this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
647
- return { isValid: true };
648
- } finally {
649
- await fork.close();
650
- }
651
- }
652
-
653
- /**
654
- * Extract checkpoint global variables from a block.
655
- */
656
- private extractCheckpointConstants(block: L2Block): CheckpointGlobalVariables {
657
- const gv = block.header.globalVariables;
658
- return {
659
- chainId: gv.chainId,
660
- version: gv.version,
661
- slotNumber: gv.slotNumber,
662
- coinbase: gv.coinbase,
663
- feeRecipient: gv.feeRecipient,
664
- gasFees: gv.gasFees,
665
- };
697
+ await this.p2pClient.addOwnCheckpointAttestations(attestations);
698
+ return attestations;
666
699
  }
667
700
 
668
701
  /**
669
702
  * Uploads blobs for a checkpoint to the filestore (fire and forget).
670
703
  */
671
- private async uploadBlobsForCheckpoint(proposal: CheckpointProposalCore, proposalInfo: LogData): Promise<void> {
704
+ protected async uploadBlobsForCheckpoint(proposal: CheckpointProposalCore, proposalInfo: LogData): Promise<void> {
672
705
  try {
673
- const lastBlockHeader = await this.blockSource.getBlockHeaderByArchive(proposal.archive);
706
+ const lastBlockHeader = (await this.blockSource.getBlockData({ archive: proposal.archive }))?.header;
674
707
  if (!lastBlockHeader) {
675
708
  this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
676
709
  return;
@@ -683,7 +716,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
683
716
  }
684
717
 
685
718
  const blobFields = blocks.flatMap(b => b.toBlobFields());
686
- const blobs: Blob[] = getBlobsPerL1Block(blobFields);
719
+ const blobs: Blob[] = await getBlobsPerL1Block(blobFields);
687
720
  await this.blobClient.sendBlobsToFilestore(blobs);
688
721
  this.log.debug(`Uploaded ${blobs.length} blobs to filestore for checkpoint at slot ${proposal.slotNumber}`, {
689
722
  ...proposalInfo,
@@ -703,12 +736,6 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
703
736
  return;
704
737
  }
705
738
 
706
- // Trim the set if it's too big.
707
- if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
708
- // remove oldest proposer. `values` is guaranteed to be in insertion order.
709
- this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value!);
710
- }
711
-
712
739
  this.proposersOfInvalidBlocks.add(proposer.toString());
713
740
 
714
741
  this.emit(WANT_TO_SLASH_EVENT, [
@@ -721,8 +748,159 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
721
748
  ]);
722
749
  }
723
750
 
751
+ private handleInvalidCheckpointProposal(
752
+ proposal: CheckpointProposalCore,
753
+ result: CheckpointProposalValidationFailureResult,
754
+ proposalInfo: LogData,
755
+ ): void {
756
+ if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
757
+ return;
758
+ }
759
+
760
+ this.markInvalidProposalSlot(proposal.slotNumber);
761
+
762
+ if (this.slashInvalidCheckpointProposal(proposal)) {
763
+ this.log.info(`Detected invalid checkpoint proposal offense`, {
764
+ ...proposalInfo,
765
+ reason: result.reason,
766
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
767
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL),
768
+ });
769
+ }
770
+ }
771
+
772
+ private slashInvalidCheckpointProposal(proposal: CheckpointProposalCore): boolean {
773
+ const proposer = proposal.getSender();
774
+ if (!proposer) {
775
+ this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
776
+ slotNumber: proposal.slotNumber,
777
+ archive: proposal.archive.toString(),
778
+ });
779
+ return false;
780
+ }
781
+
782
+ const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
783
+ const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
784
+ if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
785
+ return false;
786
+ }
787
+
788
+ this.emit(WANT_TO_SLASH_EVENT, [
789
+ {
790
+ validator: proposer,
791
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
792
+ offenseType,
793
+ epochOrSlot: BigInt(proposal.slotNumber),
794
+ },
795
+ ]);
796
+ return true;
797
+ }
798
+
799
+ private markInvalidProposalSlot(slotNumber: SlotNumber): void {
800
+ this.slotsWithInvalidProposals.add(slotNumber);
801
+ }
802
+
803
+ private handleCheckpointAttestation(attestation: CheckpointAttestation): void {
804
+ const slotNumber = attestation.slotNumber;
805
+ if (!this.slotsWithInvalidProposals.has(slotNumber) || this.slotsWithProposalEquivocation.has(slotNumber)) {
806
+ return;
807
+ }
808
+
809
+ const attester = attestation.getSender();
810
+ if (!attester) {
811
+ this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
812
+ slotNumber,
813
+ archive: attestation.archive.toString(),
814
+ });
815
+ return;
816
+ }
817
+
818
+ this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
819
+ }
820
+
821
+ private slashAttestedToInvalidCheckpointProposal(slotNumber: SlotNumber, attester: EthAddress): void {
822
+ const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
823
+ if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
824
+ return;
825
+ }
826
+
827
+ this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
828
+ attester: attester.toString(),
829
+ slotNumber,
830
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
831
+ offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL),
832
+ });
833
+
834
+ this.emit(WANT_TO_SLASH_EVENT, [
835
+ {
836
+ validator: attester,
837
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
838
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
839
+ epochOrSlot: BigInt(slotNumber),
840
+ },
841
+ ]);
842
+ }
843
+
844
+ /**
845
+ * Handle detection of a duplicate proposal (equivocation).
846
+ * Emits a slash event when a proposer sends multiple proposals for the same position.
847
+ */
848
+ private handleDuplicateProposal(info: DuplicateProposalInfo): void {
849
+ const { slot, proposer, type } = info;
850
+ this.slotsWithProposalEquivocation.add(slot);
851
+
852
+ this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
853
+ proposer: proposer.toString(),
854
+ slot,
855
+ type,
856
+ amount: this.config.slashDuplicateProposalPenalty,
857
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL),
858
+ });
859
+
860
+ this.emit(WANT_TO_SLASH_EVENT, [
861
+ {
862
+ validator: proposer,
863
+ amount: this.config.slashDuplicateProposalPenalty,
864
+ offenseType: OffenseType.DUPLICATE_PROPOSAL,
865
+ epochOrSlot: BigInt(slot),
866
+ },
867
+ ]);
868
+
869
+ this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
870
+ {
871
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
872
+ epochOrSlot: BigInt(slot),
873
+ },
874
+ ]);
875
+ }
876
+
877
+ /**
878
+ * Handle detection of a duplicate attestation (equivocation).
879
+ * Emits a slash event when an attester signs attestations for different proposals at the same slot.
880
+ */
881
+ private handleDuplicateAttestation(info: DuplicateAttestationInfo): void {
882
+ const { slot, attester } = info;
883
+
884
+ this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
885
+ attester: attester.toString(),
886
+ slot,
887
+ amount: this.config.slashDuplicateAttestationPenalty,
888
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION),
889
+ });
890
+
891
+ this.emit(WANT_TO_SLASH_EVENT, [
892
+ {
893
+ validator: attester,
894
+ amount: this.config.slashDuplicateAttestationPenalty,
895
+ offenseType: OffenseType.DUPLICATE_ATTESTATION,
896
+ epochOrSlot: BigInt(slot),
897
+ },
898
+ ]);
899
+ }
900
+
724
901
  async createBlockProposal(
725
902
  blockHeader: BlockHeader,
903
+ checkpointNumber: CheckpointNumber,
726
904
  indexWithinCheckpoint: IndexWithinCheckpoint,
727
905
  inHash: Fr,
728
906
  archive: Fr,
@@ -730,17 +908,26 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
730
908
  proposerAddress: EthAddress | undefined,
731
909
  options: BlockProposalOptions = {},
732
910
  ): Promise<BlockProposal> {
733
- // TODO(palla/mbps): Prevent double proposals properly
734
- // if (this.previousProposal?.slotNumber === blockHeader.globalVariables.slotNumber) {
735
- // this.log.verbose(`Already made a proposal for the same slot, skipping proposal`);
736
- // return Promise.resolve(undefined);
737
- // }
911
+ // Validate that we're not creating a proposal for an older or equal position
912
+ if (this.lastProposedBlock) {
913
+ const lastSlot = this.lastProposedBlock.slotNumber;
914
+ const lastIndex = this.lastProposedBlock.indexWithinCheckpoint;
915
+ const newSlot = blockHeader.globalVariables.slotNumber;
916
+
917
+ if (newSlot < lastSlot || (newSlot === lastSlot && indexWithinCheckpoint <= lastIndex)) {
918
+ throw new Error(
919
+ `Cannot create block proposal for slot ${newSlot} index ${indexWithinCheckpoint}: ` +
920
+ `already proposed block for slot ${lastSlot} index ${lastIndex}`,
921
+ );
922
+ }
923
+ }
738
924
 
739
925
  this.log.info(
740
926
  `Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`,
741
927
  );
742
928
  const newProposal = await this.validationService.createBlockProposal(
743
929
  blockHeader,
930
+ checkpointNumber,
744
931
  indexWithinCheckpoint,
745
932
  inHash,
746
933
  archive,
@@ -748,28 +935,55 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
748
935
  proposerAddress,
749
936
  {
750
937
  ...options,
751
- broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal,
938
+ broadcastInvalidBlockProposal:
939
+ options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal,
752
940
  },
753
941
  );
754
- this.previousProposal = newProposal;
942
+ this.lastProposedBlock = newProposal;
755
943
  return newProposal;
756
944
  }
757
945
 
758
946
  async createCheckpointProposal(
759
947
  checkpointHeader: CheckpointHeader,
760
948
  archive: Fr,
761
- lastBlockInfo: CreateCheckpointProposalLastBlockData | undefined,
949
+ checkpointNumber: CheckpointNumber,
950
+ feeAssetPriceModifier: bigint,
951
+ lastBlockProposal: BlockProposal | undefined,
762
952
  proposerAddress: EthAddress | undefined,
763
953
  options: CheckpointProposalOptions = {},
764
954
  ): Promise<CheckpointProposal> {
955
+ // Validate that we're not creating a proposal for an older or equal slot
956
+ if (this.lastProposedCheckpoint) {
957
+ const lastSlot = this.lastProposedCheckpoint.slotNumber;
958
+ const newSlot = checkpointHeader.slotNumber;
959
+
960
+ if (newSlot <= lastSlot) {
961
+ throw new Error(
962
+ `Cannot create checkpoint proposal for slot ${newSlot}: ` +
963
+ `already proposed checkpoint for slot ${lastSlot}`,
964
+ );
965
+ }
966
+ }
967
+
765
968
  this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
766
- return await this.validationService.createCheckpointProposal(
969
+ const newProposal = await this.validationService.createCheckpointProposal(
767
970
  checkpointHeader,
768
971
  archive,
769
- lastBlockInfo,
972
+ checkpointNumber,
973
+ feeAssetPriceModifier,
974
+ lastBlockProposal,
770
975
  proposerAddress,
771
976
  options,
772
977
  );
978
+ this.lastProposedCheckpoint = newProposal;
979
+ // Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
980
+ // own proposals through `handleCheckpointProposal`, so without this call the proposer's
981
+ // sentinel would see no outcome for slots it proposed and would mis-attribute itself as
982
+ // inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
983
+ // be intentionally corrupted under test-only flags); from the proposer's local-view
984
+ // perspective the work it just completed is valid by definition.
985
+ this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
986
+ return newProposal;
773
987
  }
774
988
 
775
989
  async broadcastBlockProposal(proposal: BlockProposal): Promise<void> {
@@ -780,16 +994,28 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
780
994
  attestationsAndSigners: CommitteeAttestationsAndSigners,
781
995
  proposer: EthAddress,
782
996
  slot: SlotNumber,
783
- blockNumber: BlockNumber | CheckpointNumber,
997
+ checkpointNumber: CheckpointNumber,
784
998
  ): Promise<Signature> {
785
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
999
+ return await this.validationService.signAttestationsAndSigners(
1000
+ attestationsAndSigners,
1001
+ proposer,
1002
+ slot,
1003
+ checkpointNumber,
1004
+ );
786
1005
  }
787
1006
 
788
- async collectOwnAttestations(proposal: CheckpointProposal): Promise<CheckpointAttestation[]> {
1007
+ async collectOwnAttestations(
1008
+ proposal: CheckpointProposal,
1009
+ checkpointNumber: CheckpointNumber,
1010
+ ): Promise<CheckpointAttestation[]> {
789
1011
  const slot = proposal.slotNumber;
790
1012
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
791
1013
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, { inCommittee });
792
- const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
1014
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
1015
+
1016
+ if (!attestations) {
1017
+ return [];
1018
+ }
793
1019
 
794
1020
  // We broadcast our own attestations to our peers so, in case our block does not get mined on L1,
795
1021
  // other nodes can see that our validators did attest to this block proposal, and do not slash us
@@ -804,6 +1030,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
804
1030
  proposal: CheckpointProposal,
805
1031
  required: number,
806
1032
  deadline: Date,
1033
+ checkpointNumber: CheckpointNumber,
807
1034
  ): Promise<CheckpointAttestation[]> {
808
1035
  // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
809
1036
  const slot = proposal.slotNumber;
@@ -816,33 +1043,23 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
816
1043
  throw new AttestationTimeoutError(0, required, slot);
817
1044
  }
818
1045
 
819
- await this.collectOwnAttestations(proposal);
1046
+ await this.collectOwnAttestations(proposal, checkpointNumber);
820
1047
 
821
- const proposalId = proposal.archive.toString();
1048
+ const proposalPayloadHash = proposal.getPayloadHash();
822
1049
  const myAddresses = this.getValidatorAddresses();
823
1050
 
824
1051
  let attestations: CheckpointAttestation[] = [];
825
1052
  while (true) {
826
- // Filter out attestations with a mismatching archive. This should NOT happen since we have verified
827
- // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
828
- const collectedAttestations = (await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalId)).filter(
829
- attestation => {
830
- if (!attestation.archive.equals(proposal.archive)) {
831
- this.log.warn(
832
- `Received attestation for slot ${slot} with mismatched archive from ${attestation.getSender()?.toString()}`,
833
- { attestationArchive: attestation.archive.toString(), proposalArchive: proposal.archive.toString() },
834
- );
835
- return false;
836
- }
837
- return true;
838
- },
839
- );
1053
+ // The pool already filters by proposal payload hash; if any attestation slips through with a
1054
+ // mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
1055
+ // events from libp2p_service.
1056
+ const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
840
1057
 
841
1058
  // Log new attestations we collected
842
1059
  const oldSenders = attestations.map(attestation => attestation.getSender());
843
1060
  for (const collected of collectedAttestations) {
844
1061
  const collectedSender = collected.getSender();
845
- // Skip attestations with invalid signatures
1062
+ // Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
846
1063
  if (!collectedSender) {
847
1064
  this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
848
1065
  continue;