@aztec/validator-client 0.0.1-commit.001888fc → 0.0.1-commit.017a351

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/dest/validator.js CHANGED
@@ -1,42 +1,63 @@
1
1
  import { getBlobsPerL1Block } from '@aztec/blob-lib';
2
- import { validateFeeAssetPriceModifier } from '@aztec/ethereum/contracts';
3
- import { BlockNumber, SlotNumber } from '@aztec/foundation/branded-types';
4
- import { TimeoutError } from '@aztec/foundation/error';
2
+ import { CheckpointNumber } from '@aztec/foundation/branded-types';
3
+ import { FifoSet } from '@aztec/foundation/fifo-set';
5
4
  import { createLogger } from '@aztec/foundation/log';
6
- import { retryUntil } from '@aztec/foundation/retry';
7
5
  import { RunningPromise } from '@aztec/foundation/running-promise';
8
6
  import { sleep } from '@aztec/foundation/sleep';
9
7
  import { DateProvider } from '@aztec/foundation/timer';
10
8
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
11
- import { OffenseType, WANT_TO_SLASH_EVENT } from '@aztec/slasher';
12
- import { validateCheckpoint } from '@aztec/stdlib/checkpoint';
13
- import { getEpochAtSlot, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
14
- import { accumulateCheckpointOutHashes } from '@aztec/stdlib/messaging';
9
+ import { OffenseType, WANT_TO_CLEAR_SLASH_EVENT, WANT_TO_SLASH_EVENT, getOffenseTypeName } from '@aztec/slasher';
10
+ import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
15
11
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
16
12
  import { getTelemetryClient } from '@aztec/telemetry-client';
17
- import { createHASigner, createLocalSignerWithProtection } from '@aztec/validator-ha-signer/factory';
13
+ import { createHASigner, createLocalSignerWithProtection, createSignerFromSharedDb } from '@aztec/validator-ha-signer/factory';
18
14
  import { DutyType } from '@aztec/validator-ha-signer/types';
19
15
  import { EventEmitter } from 'events';
20
- import { BlockProposalHandler } from './block_proposal_handler.js';
21
16
  import { ValidationService } from './duties/validation_service.js';
22
17
  import { HAKeyStore } from './key_store/ha_key_store.js';
23
18
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
24
19
  import { ValidatorMetrics } from './metrics.js';
20
+ import { ProposalHandler } from './proposal_handler.js';
25
21
  // We maintain a set of proposers who have proposed invalid blocks.
26
22
  // Just cap the set to avoid unbounded growth.
27
23
  const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
24
+ const MAX_TRACKED_INVALID_PROPOSAL_SLOTS = 1000;
25
+ const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
26
+ const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
28
27
  // What errors from the block proposal handler result in slashing
29
28
  const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
30
29
  'state_mismatch',
31
- 'failed_txs'
30
+ 'failed_txs',
31
+ 'global_variables_mismatch',
32
+ 'invalid_proposal',
33
+ 'parent_block_wrong_slot',
34
+ 'in_hash_mismatch'
32
35
  ];
36
+ const SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT = {
37
+ // enabled
38
+ ['invalid_fee_asset_price_modifier']: true,
39
+ ['checkpoint_header_mismatch']: true,
40
+ // These late mismatches should normally be caught by earlier checks, but if reached after validating the local
41
+ // checkpoint inputs, the proposer-signed payload disagrees with deterministic recomputation.
42
+ ['archive_mismatch']: true,
43
+ ['out_hash_mismatch']: true,
44
+ ['no_blocks_for_slot']: true,
45
+ ['too_many_blocks_in_checkpoint']: true,
46
+ ['checkpoint_validation_failed']: true,
47
+ ['last_block_archive_mismatch']: true,
48
+ // disabled
49
+ ['invalid_signature']: false,
50
+ ['last_block_not_found']: false,
51
+ ['block_fetch_error']: false,
52
+ ['checkpoint_already_published']: false
53
+ };
33
54
  /**
34
55
  * Validator Client
35
56
  */ export class ValidatorClient extends EventEmitter {
36
57
  keyStore;
37
58
  epochCache;
38
59
  p2pClient;
39
- blockProposalHandler;
60
+ proposalHandler;
40
61
  blockSource;
41
62
  checkpointsBuilder;
42
63
  worldState;
@@ -57,14 +78,19 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
57
78
  epochCacheUpdateLoop;
58
79
  /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */ lastAttestedEpochByAttester;
59
80
  proposersOfInvalidBlocks;
81
+ slotsWithInvalidProposals;
82
+ invalidCheckpointProposalOffenseKeys;
83
+ badAttestationOffenseKeys;
84
+ slotsWithProposalEquivocation;
60
85
  /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */ lastAttestedProposal;
61
- constructor(keyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
62
- super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.blockProposalHandler = blockProposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = new Set();
86
+ constructor(keyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
87
+ super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.proposalHandler = proposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = FifoSet.withLimit(MAX_PROPOSERS_OF_INVALID_BLOCKS), this.slotsWithInvalidProposals = FifoSet.withLimit(MAX_TRACKED_INVALID_PROPOSAL_SLOTS), this.invalidCheckpointProposalOffenseKeys = FifoSet.withLimit(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS), this.badAttestationOffenseKeys = FifoSet.withLimit(MAX_TRACKED_BAD_ATTESTATIONS), this.slotsWithProposalEquivocation = FifoSet.withLimit(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
63
88
  // Create child logger with fisherman prefix if in fisherman mode
64
89
  this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
65
90
  this.tracer = telemetry.getTracer('Validator');
66
91
  this.metrics = new ValidatorMetrics(telemetry);
67
- this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
92
+ this.validationService = new ValidationService(keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
93
+ this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo)=>this.handleInvalidCheckpointProposal(proposal, result, proposalInfo));
68
94
  // Refresh epoch cache every second to trigger alert if participation in committee changes
69
95
  this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
70
96
  const myAddresses = this.getValidatorAddresses();
@@ -114,16 +140,28 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
114
140
  this.log.error(`Error updating epoch committee`, err);
115
141
  }
116
142
  }
117
- static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient()) {
143
+ static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, reexecutionTracker, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), slashingProtectionDb) {
118
144
  const metrics = new ValidatorMetrics(telemetry);
119
145
  const blockProposalValidator = new BlockProposalValidator(epochCache, {
120
146
  txsPermitted: !config.disableTransactions,
121
- maxTxsPerBlock: config.validateMaxTxsPerBlock
147
+ maxTxsPerBlock: config.validateMaxTxsPerBlock,
148
+ maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
149
+ skipSlotValidation: config.skipProposalSlotValidation,
150
+ signatureContext: {
151
+ chainId: config.l1ChainId,
152
+ rollupAddress: config.rollupAddress
153
+ }
122
154
  });
123
- const blockProposalHandler = new BlockProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, metrics, dateProvider, telemetry);
155
+ const proposalHandler = new ProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, blobClient, reexecutionTracker, metrics, dateProvider, telemetry, undefined);
124
156
  const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
125
157
  let slashingProtectionSigner;
126
- if (config.haSigningEnabled) {
158
+ if (slashingProtectionDb) {
159
+ // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
160
+ ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
161
+ telemetryClient: telemetry,
162
+ dateProvider
163
+ }));
164
+ } else if (config.haSigningEnabled) {
127
165
  // Multi-node HA mode: use PostgreSQL-backed distributed locking.
128
166
  // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
129
167
  const haConfig = {
@@ -143,18 +181,24 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
143
181
  }));
144
182
  }
145
183
  const validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
146
- const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider, telemetry);
184
+ const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider, telemetry);
147
185
  return validator;
148
186
  }
149
187
  getValidatorAddresses() {
150
188
  return this.keyStore.getAddresses().filter((addr)=>!this.config.disabledValidators.some((disabled)=>disabled.equals(addr)));
151
189
  }
152
- getBlockProposalHandler() {
153
- return this.blockProposalHandler;
190
+ getProposalHandler() {
191
+ return this.proposalHandler;
154
192
  }
155
193
  signWithAddress(addr, msg, context) {
156
194
  return this.keyStore.signTypedDataWithAddress(addr, msg, context);
157
195
  }
196
+ getSignatureContext() {
197
+ return {
198
+ chainId: this.config.l1ChainId,
199
+ rollupAddress: this.config.rollupAddress
200
+ };
201
+ }
158
202
  getCoinbaseForAttestor(attestor) {
159
203
  return this.keyStore.getCoinbaseAddress(attestor);
160
204
  }
@@ -164,16 +208,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
164
208
  getConfig() {
165
209
  return this.config;
166
210
  }
211
+ hasProposalEquivocation(slotNumber) {
212
+ return this.slotsWithProposalEquivocation.has(slotNumber);
213
+ }
214
+ hasInvalidProposals(slotNumber) {
215
+ return this.slotsWithInvalidProposals.has(slotNumber);
216
+ }
167
217
  updateConfig(config) {
168
218
  this.config = {
169
219
  ...this.config,
170
220
  ...config
171
221
  };
222
+ this.proposalHandler.updateConfig(config);
172
223
  }
173
224
  reloadKeystore(newManager) {
174
225
  const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
175
226
  this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
176
- this.validationService = new ValidationService(this.keyStore, this.log.createChild('validation-service'));
227
+ this.validationService = new ValidationService(this.keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
177
228
  }
178
229
  async start() {
179
230
  if (this.epochCacheUpdateLoop.isRunning()) {
@@ -206,7 +257,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
206
257
  // The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
207
258
  // and processed separately via the block handler above.
208
259
  const checkpointHandler = (checkpoint, proposalSender)=>this.attestToCheckpointProposal(checkpoint, proposalSender);
209
- this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
260
+ this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
210
261
  // Duplicate proposal handler - triggers slashing for equivocation
211
262
  this.p2pClient.registerDuplicateProposalCallback((info)=>{
212
263
  this.handleDuplicateProposal(info);
@@ -215,6 +266,9 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
215
266
  this.p2pClient.registerDuplicateAttestationCallback((info)=>{
216
267
  this.handleDuplicateAttestation(info);
217
268
  });
269
+ this.p2pClient.registerCheckpointAttestationCallback((attestation)=>{
270
+ this.handleCheckpointAttestation(attestation);
271
+ });
218
272
  const myAddresses = this.getValidatorAddresses();
219
273
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
220
274
  await this.p2pClient.addReqRespSubProtocol(ReqRespSubProtocol.AUTH, this.handleAuthRequest.bind(this));
@@ -235,13 +289,12 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
235
289
  this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
236
290
  return false;
237
291
  }
238
- // Ignore proposals from ourselves (may happen in HA setups)
292
+ // Log self-proposals from HA peers (same validator key on different nodes)
239
293
  if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
240
- this.log.debug(`Ignoring block proposal from self for slot ${slotNumber}`, {
294
+ this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
241
295
  proposer: proposer.toString(),
242
296
  slotNumber
243
297
  });
244
- return false;
245
298
  }
246
299
  // Check if we're in the committee (for metrics purposes)
247
300
  const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
@@ -255,11 +308,8 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
255
308
  txHashes: proposal.txHashes.map((t)=>t.toString()),
256
309
  fishermanMode: this.config.fishermanMode || false
257
310
  });
258
- // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
259
- // In fisherman mode, we always reexecute to validate proposals.
260
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
261
- const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute || partOfCommittee && validatorReexecute || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
262
- const validationResult = await this.blockProposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
311
+ // Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
312
+ const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
263
313
  if (!validationResult.isValid) {
264
314
  const reason = validationResult.reason || 'unknown';
265
315
  this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
@@ -277,10 +327,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
277
327
  // Node issues so we can't validate
278
328
  this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
279
329
  }
280
- // Slash invalid block proposals (can happen even when not in committee)
281
- if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) && slashBroadcastedInvalidBlockPenalty > 0n) {
282
- this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
330
+ if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)) {
331
+ this.log.info(`Detected invalid block proposal offense`, {
332
+ ...proposalInfo,
333
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
334
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL)
335
+ });
283
336
  this.slashInvalidBlock(proposal);
337
+ this.markInvalidProposalSlot(proposal.slotNumber);
284
338
  }
285
339
  return false;
286
340
  }
@@ -302,56 +356,50 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
302
356
  * the lastBlock is extracted and processed separately via the block handler.
303
357
  * @returns Checkpoint attestations if valid, undefined otherwise
304
358
  */ async attestToCheckpointProposal(proposal, _proposalSender) {
305
- const slotNumber = proposal.slotNumber;
359
+ const proposalSlotNumber = proposal.slotNumber;
306
360
  const proposer = proposal.getSender();
307
361
  // If escape hatch is open for this slot's epoch, do not attest.
308
- if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
309
- this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
362
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
363
+ this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
310
364
  return undefined;
311
365
  }
312
- // Reject proposals with invalid signatures
313
- if (!proposer) {
314
- this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
366
+ // Early-out for equivocation: refuses if we've already attested to a higher slot.
367
+ if (!this.shouldAttestToSlot(proposalSlotNumber)) {
315
368
  return undefined;
316
369
  }
317
370
  // Ignore proposals from ourselves (may happen in HA setups)
318
- if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
319
- this.log.debug(`Ignoring block proposal from self for slot ${slotNumber}`, {
371
+ if (proposer && this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
372
+ this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
320
373
  proposer: proposer.toString(),
321
- slotNumber
374
+ proposalSlotNumber
322
375
  });
323
376
  return undefined;
324
377
  }
325
- // Validate fee asset price modifier is within allowed range
326
- if (!validateFeeAssetPriceModifier(proposal.feeAssetPriceModifier)) {
327
- this.log.warn(`Received checkpoint proposal with invalid feeAssetPriceModifier ${proposal.feeAssetPriceModifier} for slot ${slotNumber}`);
328
- return undefined;
329
- }
330
- // Check that I have any address in current committee before attesting
331
- const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
378
+ // Check that I have any address in the committee where this checkpoint will land before attesting
379
+ const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
332
380
  const partOfCommittee = inCommittee.length > 0;
333
381
  const proposalInfo = {
334
- slotNumber,
382
+ proposalSlotNumber,
335
383
  archive: proposal.archive.toString(),
336
- proposer: proposer.toString()
384
+ proposer: proposer?.toString()
337
385
  };
338
- this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
386
+ this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
339
387
  ...proposalInfo,
340
388
  fishermanMode: this.config.fishermanMode || false
341
389
  });
342
- // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
390
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
391
+ // Uses the cached result from the all-nodes callback if available (avoids double validation).
392
+ let checkpointNumber;
343
393
  if (this.config.skipCheckpointProposalValidation) {
344
- this.log.warn(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
394
+ this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
395
+ checkpointNumber = CheckpointNumber(0);
345
396
  } else {
346
- const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
397
+ const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
347
398
  if (!validationResult.isValid) {
348
399
  this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
349
400
  return undefined;
350
401
  }
351
- }
352
- // Upload blobs to filestore if we can (fire and forget)
353
- if (this.blobClient.canUpload()) {
354
- void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
402
+ checkpointNumber = validationResult.checkpointNumber;
355
403
  }
356
404
  // Check that I have any address in current committee before attesting
357
405
  // In fisherman mode, we still create attestations for validation even if not in committee
@@ -360,14 +408,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
360
408
  return undefined;
361
409
  }
362
410
  // Provided all of the above checks pass, we can attest to the proposal
363
- this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
411
+ this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`, {
364
412
  ...proposalInfo,
365
413
  inCommittee: partOfCommittee,
366
414
  fishermanMode: this.config.fishermanMode || false
367
415
  });
368
416
  this.metrics.incSuccessfulAttestations(inCommittee.length);
369
417
  // Track epoch participation per attester: count each (attester, epoch) pair at most once
370
- const proposalEpoch = getEpochAtSlot(slotNumber, this.epochCache.getL1Constants());
418
+ const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
371
419
  for (const attester of inCommittee){
372
420
  const key = attester.toString();
373
421
  const lastEpoch = this.lastAttestedEpochByAttester.get(key);
@@ -392,13 +440,13 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
392
440
  }
393
441
  if (this.config.fishermanMode) {
394
442
  // bail out early and don't save attestations to the pool in fisherman mode
395
- this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
443
+ this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
396
444
  ...proposalInfo,
397
445
  attestors: attestors.map((a)=>a.toString())
398
446
  });
399
447
  return undefined;
400
448
  }
401
- return await this.createCheckpointAttestationsFromProposal(proposal, attestors);
449
+ return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
402
450
  }
403
451
  /**
404
452
  * Checks if we should attest to a slot based on equivocation prevention rules.
@@ -415,180 +463,24 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
415
463
  }
416
464
  return true;
417
465
  }
418
- async createCheckpointAttestationsFromProposal(proposal, attestors = []) {
466
+ async createCheckpointAttestationsFromProposal(proposal, attestors = [], checkpointNumber) {
419
467
  // Equivocation check: must happen right before signing to minimize the race window
420
468
  if (!this.shouldAttestToSlot(proposal.slotNumber)) {
421
469
  return undefined;
422
470
  }
423
- const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
471
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
424
472
  // Track the proposal we attested to (to prevent equivocation)
425
473
  this.lastAttestedProposal = proposal;
426
474
  await this.p2pClient.addOwnCheckpointAttestations(attestations);
427
475
  return attestations;
428
476
  }
429
477
  /**
430
- * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
431
- * @returns Validation result with isValid flag and reason if invalid.
432
- */ async validateCheckpointProposal(proposal, proposalInfo) {
433
- const slot = proposal.slotNumber;
434
- // Timeout block syncing at the start of the next slot
435
- const config = this.checkpointsBuilder.getConfig();
436
- const nextSlotTimestampSeconds = Number(getTimestampForSlot(SlotNumber(slot + 1), config));
437
- const timeoutSeconds = Math.max(1, nextSlotTimestampSeconds - Math.floor(this.dateProvider.now() / 1000));
438
- // Wait for last block to sync by archive
439
- let lastBlockHeader;
440
- try {
441
- lastBlockHeader = await retryUntil(async ()=>{
442
- await this.blockSource.syncImmediate();
443
- return this.blockSource.getBlockHeaderByArchive(proposal.archive);
444
- }, `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`, timeoutSeconds, 0.5);
445
- } catch (err) {
446
- if (err instanceof TimeoutError) {
447
- this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
448
- return {
449
- isValid: false,
450
- reason: 'last_block_not_found'
451
- };
452
- }
453
- this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
454
- return {
455
- isValid: false,
456
- reason: 'block_fetch_error'
457
- };
458
- }
459
- if (!lastBlockHeader) {
460
- this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
461
- return {
462
- isValid: false,
463
- reason: 'last_block_not_found'
464
- };
465
- }
466
- // Get all full blocks for the slot and checkpoint
467
- const blocks = await this.blockSource.getBlocksForSlot(slot);
468
- if (blocks.length === 0) {
469
- this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
470
- return {
471
- isValid: false,
472
- reason: 'no_blocks_for_slot'
473
- };
474
- }
475
- // Ensure the last block for this slot matches the archive in the checkpoint proposal
476
- if (!blocks.at(-1)?.archive.root.equals(proposal.archive)) {
477
- this.log.warn(`Last block archive mismatch for checkpoint proposal`, proposalInfo);
478
- return {
479
- isValid: false,
480
- reason: 'last_block_archive_mismatch'
481
- };
482
- }
483
- this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
484
- ...proposalInfo,
485
- blockNumbers: blocks.map((b)=>b.number)
486
- });
487
- // Get checkpoint constants from first block
488
- const firstBlock = blocks[0];
489
- const constants = this.extractCheckpointConstants(firstBlock);
490
- const checkpointNumber = firstBlock.checkpointNumber;
491
- // Get L1-to-L2 messages for this checkpoint
492
- const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
493
- // Collect the out hashes of all the checkpoints before this one in the same epoch
494
- const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
495
- const previousCheckpointOutHashes = (await this.blockSource.getCheckpointsDataForEpoch(epoch)).filter((c)=>c.checkpointNumber < checkpointNumber).map((c)=>c.checkpointOutHash);
496
- // Fork world state at the block before the first block
497
- const parentBlockNumber = BlockNumber(firstBlock.number - 1);
498
- const fork = await this.worldState.fork(parentBlockNumber);
499
- try {
500
- // Create checkpoint builder with all existing blocks
501
- const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(checkpointNumber, constants, proposal.feeAssetPriceModifier, l1ToL2Messages, previousCheckpointOutHashes, fork, blocks, this.log.getBindings());
502
- // Complete the checkpoint to get computed values
503
- const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
504
- // Compare checkpoint header with proposal
505
- if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
506
- this.log.warn(`Checkpoint header mismatch`, {
507
- ...proposalInfo,
508
- computed: computedCheckpoint.header.toInspect(),
509
- proposal: proposal.checkpointHeader.toInspect()
510
- });
511
- return {
512
- isValid: false,
513
- reason: 'checkpoint_header_mismatch'
514
- };
515
- }
516
- // Compare archive root with proposal
517
- if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
518
- this.log.warn(`Archive root mismatch`, {
519
- ...proposalInfo,
520
- computed: computedCheckpoint.archive.root.toString(),
521
- proposal: proposal.archive.toString()
522
- });
523
- return {
524
- isValid: false,
525
- reason: 'archive_mismatch'
526
- };
527
- }
528
- // Check that the accumulated epoch out hash matches the value in the proposal.
529
- // The epoch out hash is the accumulated hash of all checkpoint out hashes in the epoch.
530
- const checkpointOutHash = computedCheckpoint.getCheckpointOutHash();
531
- const computedEpochOutHash = accumulateCheckpointOutHashes([
532
- ...previousCheckpointOutHashes,
533
- checkpointOutHash
534
- ]);
535
- const proposalEpochOutHash = proposal.checkpointHeader.epochOutHash;
536
- if (!computedEpochOutHash.equals(proposalEpochOutHash)) {
537
- this.log.warn(`Epoch out hash mismatch`, {
538
- proposalEpochOutHash: proposalEpochOutHash.toString(),
539
- computedEpochOutHash: computedEpochOutHash.toString(),
540
- checkpointOutHash: checkpointOutHash.toString(),
541
- previousCheckpointOutHashes: previousCheckpointOutHashes.map((h)=>h.toString()),
542
- ...proposalInfo
543
- });
544
- return {
545
- isValid: false,
546
- reason: 'out_hash_mismatch'
547
- };
548
- }
549
- // Final round of validations on the checkpoint, just in case.
550
- try {
551
- validateCheckpoint(computedCheckpoint, {
552
- rollupManaLimit: this.checkpointsBuilder.getConfig().rollupManaLimit,
553
- maxDABlockGas: this.config.validateMaxDABlockGas,
554
- maxL2BlockGas: this.config.validateMaxL2BlockGas,
555
- maxTxsPerBlock: this.config.validateMaxTxsPerBlock,
556
- maxTxsPerCheckpoint: this.config.validateMaxTxsPerCheckpoint
557
- });
558
- } catch (err) {
559
- this.log.warn(`Checkpoint validation failed: ${err}`, proposalInfo);
560
- return {
561
- isValid: false,
562
- reason: 'checkpoint_validation_failed'
563
- };
564
- }
565
- this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
566
- return {
567
- isValid: true
568
- };
569
- } finally{
570
- await fork.close();
571
- }
572
- }
573
- /**
574
- * Extract checkpoint global variables from a block.
575
- */ extractCheckpointConstants(block) {
576
- const gv = block.header.globalVariables;
577
- return {
578
- chainId: gv.chainId,
579
- version: gv.version,
580
- slotNumber: gv.slotNumber,
581
- timestamp: gv.timestamp,
582
- coinbase: gv.coinbase,
583
- feeRecipient: gv.feeRecipient,
584
- gasFees: gv.gasFees
585
- };
586
- }
587
- /**
588
478
  * Uploads blobs for a checkpoint to the filestore (fire and forget).
589
479
  */ async uploadBlobsForCheckpoint(proposal, proposalInfo) {
590
480
  try {
591
- const lastBlockHeader = await this.blockSource.getBlockHeaderByArchive(proposal.archive);
481
+ const lastBlockHeader = (await this.blockSource.getBlockData({
482
+ archive: proposal.archive
483
+ }))?.header;
592
484
  if (!lastBlockHeader) {
593
485
  this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
594
486
  return;
@@ -616,11 +508,6 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
616
508
  this.log.warn(`Cannot slash proposal with invalid signature`);
617
509
  return;
618
510
  }
619
- // Trim the set if it's too big.
620
- if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
621
- // remove oldest proposer. `values` is guaranteed to be in insertion order.
622
- this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value);
623
- }
624
511
  this.proposersOfInvalidBlocks.add(proposer.toString());
625
512
  this.emit(WANT_TO_SLASH_EVENT, [
626
513
  {
@@ -631,17 +518,95 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
631
518
  }
632
519
  ]);
633
520
  }
521
+ handleInvalidCheckpointProposal(proposal, result, proposalInfo) {
522
+ if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
523
+ return;
524
+ }
525
+ this.markInvalidProposalSlot(proposal.slotNumber);
526
+ if (this.slashInvalidCheckpointProposal(proposal)) {
527
+ this.log.info(`Detected invalid checkpoint proposal offense`, {
528
+ ...proposalInfo,
529
+ reason: result.reason,
530
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
531
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL)
532
+ });
533
+ }
534
+ }
535
+ slashInvalidCheckpointProposal(proposal) {
536
+ const proposer = proposal.getSender();
537
+ if (!proposer) {
538
+ this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
539
+ slotNumber: proposal.slotNumber,
540
+ archive: proposal.archive.toString()
541
+ });
542
+ return false;
543
+ }
544
+ const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
545
+ const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
546
+ if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
547
+ return false;
548
+ }
549
+ this.emit(WANT_TO_SLASH_EVENT, [
550
+ {
551
+ validator: proposer,
552
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
553
+ offenseType,
554
+ epochOrSlot: BigInt(proposal.slotNumber)
555
+ }
556
+ ]);
557
+ return true;
558
+ }
559
+ markInvalidProposalSlot(slotNumber) {
560
+ this.slotsWithInvalidProposals.add(slotNumber);
561
+ }
562
+ handleCheckpointAttestation(attestation) {
563
+ const slotNumber = attestation.slotNumber;
564
+ if (!this.slotsWithInvalidProposals.has(slotNumber) || this.slotsWithProposalEquivocation.has(slotNumber)) {
565
+ return;
566
+ }
567
+ const attester = attestation.getSender();
568
+ if (!attester) {
569
+ this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
570
+ slotNumber,
571
+ archive: attestation.archive.toString()
572
+ });
573
+ return;
574
+ }
575
+ this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
576
+ }
577
+ slashAttestedToInvalidCheckpointProposal(slotNumber, attester) {
578
+ const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
579
+ if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
580
+ return;
581
+ }
582
+ this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
583
+ attester: attester.toString(),
584
+ slotNumber,
585
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
586
+ offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL)
587
+ });
588
+ this.emit(WANT_TO_SLASH_EVENT, [
589
+ {
590
+ validator: attester,
591
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
592
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
593
+ epochOrSlot: BigInt(slotNumber)
594
+ }
595
+ ]);
596
+ }
634
597
  /**
635
598
  * Handle detection of a duplicate proposal (equivocation).
636
599
  * Emits a slash event when a proposer sends multiple proposals for the same position.
637
600
  */ handleDuplicateProposal(info) {
638
601
  const { slot, proposer, type } = info;
639
- this.log.warn(`Triggering slash event for duplicate ${type} proposal from ${proposer.toString()} at slot ${slot}`, {
602
+ this.slotsWithProposalEquivocation.add(slot);
603
+ this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
640
604
  proposer: proposer.toString(),
641
605
  slot,
642
- type
606
+ type,
607
+ amount: this.config.slashDuplicateProposalPenalty,
608
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL)
643
609
  });
644
- // Emit slash event
645
610
  this.emit(WANT_TO_SLASH_EVENT, [
646
611
  {
647
612
  validator: proposer,
@@ -650,15 +615,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
650
615
  epochOrSlot: BigInt(slot)
651
616
  }
652
617
  ]);
618
+ this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
619
+ {
620
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
621
+ epochOrSlot: BigInt(slot)
622
+ }
623
+ ]);
653
624
  }
654
625
  /**
655
626
  * Handle detection of a duplicate attestation (equivocation).
656
627
  * Emits a slash event when an attester signs attestations for different proposals at the same slot.
657
628
  */ handleDuplicateAttestation(info) {
658
629
  const { slot, attester } = info;
659
- this.log.warn(`Triggering slash event for duplicate attestation from ${attester.toString()} at slot ${slot}`, {
630
+ this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
660
631
  attester: attester.toString(),
661
- slot
632
+ slot,
633
+ amount: this.config.slashDuplicateAttestationPenalty,
634
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION)
662
635
  });
663
636
  this.emit(WANT_TO_SLASH_EVENT, [
664
637
  {
@@ -669,7 +642,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
669
642
  }
670
643
  ]);
671
644
  }
672
- async createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
645
+ async createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
673
646
  // Validate that we're not creating a proposal for an older or equal position
674
647
  if (this.lastProposedBlock) {
675
648
  const lastSlot = this.lastProposedBlock.slotNumber;
@@ -680,14 +653,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
680
653
  }
681
654
  }
682
655
  this.log.info(`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`);
683
- const newProposal = await this.validationService.createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
656
+ const newProposal = await this.validationService.createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
684
657
  ...options,
685
- broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal
658
+ broadcastInvalidBlockProposal: options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal
686
659
  });
687
660
  this.lastProposedBlock = newProposal;
688
661
  return newProposal;
689
662
  }
690
- async createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options = {}) {
663
+ async createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options = {}) {
691
664
  // Validate that we're not creating a proposal for an older or equal slot
692
665
  if (this.lastProposedCheckpoint) {
693
666
  const lastSlot = this.lastProposedCheckpoint.slotNumber;
@@ -697,23 +670,30 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
697
670
  }
698
671
  }
699
672
  this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
700
- const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options);
673
+ const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options);
701
674
  this.lastProposedCheckpoint = newProposal;
675
+ // Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
676
+ // own proposals through `handleCheckpointProposal`, so without this call the proposer's
677
+ // sentinel would see no outcome for slots it proposed and would mis-attribute itself as
678
+ // inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
679
+ // be intentionally corrupted under test-only flags); from the proposer's local-view
680
+ // perspective the work it just completed is valid by definition.
681
+ this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
702
682
  return newProposal;
703
683
  }
704
684
  async broadcastBlockProposal(proposal) {
705
685
  await this.p2pClient.broadcastProposal(proposal);
706
686
  }
707
- async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber) {
708
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
687
+ async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber) {
688
+ return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber);
709
689
  }
710
- async collectOwnAttestations(proposal) {
690
+ async collectOwnAttestations(proposal, checkpointNumber) {
711
691
  const slot = proposal.slotNumber;
712
692
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
713
693
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, {
714
694
  inCommittee
715
695
  });
716
- const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
696
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
717
697
  if (!attestations) {
718
698
  return [];
719
699
  }
@@ -725,7 +705,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
725
705
  });
726
706
  return attestations;
727
707
  }
728
- async collectAttestations(proposal, required, deadline) {
708
+ async collectAttestations(proposal, required, deadline, checkpointNumber) {
729
709
  // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
730
710
  const slot = proposal.slotNumber;
731
711
  this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
@@ -733,28 +713,20 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
733
713
  this.log.error(`Deadline ${deadline.toISOString()} for collecting ${required} attestations for slot ${slot} is in the past`);
734
714
  throw new AttestationTimeoutError(0, required, slot);
735
715
  }
736
- await this.collectOwnAttestations(proposal);
737
- const proposalId = proposal.archive.toString();
716
+ await this.collectOwnAttestations(proposal, checkpointNumber);
717
+ const proposalPayloadHash = proposal.getPayloadHash();
738
718
  const myAddresses = this.getValidatorAddresses();
739
719
  let attestations = [];
740
720
  while(true){
741
- // Filter out attestations with a mismatching archive. This should NOT happen since we have verified
742
- // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
743
- const collectedAttestations = (await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalId)).filter((attestation)=>{
744
- if (!attestation.archive.equals(proposal.archive)) {
745
- this.log.warn(`Received attestation for slot ${slot} with mismatched archive from ${attestation.getSender()?.toString()}`, {
746
- attestationArchive: attestation.archive.toString(),
747
- proposalArchive: proposal.archive.toString()
748
- });
749
- return false;
750
- }
751
- return true;
752
- });
721
+ // The pool already filters by proposal payload hash; if any attestation slips through with a
722
+ // mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
723
+ // events from libp2p_service.
724
+ const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
753
725
  // Log new attestations we collected
754
726
  const oldSenders = attestations.map((attestation)=>attestation.getSender());
755
727
  for (const collected of collectedAttestations){
756
728
  const collectedSender = collected.getSender();
757
- // Skip attestations with invalid signatures
729
+ // Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
758
730
  if (!collectedSender) {
759
731
  this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
760
732
  continue;