@aztec/slasher 5.0.0-private.20260319 → 5.0.0-rc.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (95) hide show
  1. package/README.md +76 -79
  2. package/dest/config.d.ts +1 -1
  3. package/dest/config.d.ts.map +1 -1
  4. package/dest/config.js +28 -28
  5. package/dest/factory/create_facade.d.ts +2 -2
  6. package/dest/factory/create_facade.d.ts.map +1 -1
  7. package/dest/factory/create_facade.js +1 -1
  8. package/dest/factory/create_implementation.d.ts +4 -6
  9. package/dest/factory/create_implementation.d.ts.map +1 -1
  10. package/dest/factory/create_implementation.js +7 -59
  11. package/dest/factory/get_settings.d.ts +4 -4
  12. package/dest/factory/get_settings.d.ts.map +1 -1
  13. package/dest/factory/get_settings.js +3 -3
  14. package/dest/factory/index.d.ts +2 -2
  15. package/dest/factory/index.d.ts.map +1 -1
  16. package/dest/factory/index.js +1 -1
  17. package/dest/generated/slasher-defaults.d.ts +4 -4
  18. package/dest/generated/slasher-defaults.js +4 -4
  19. package/dest/index.d.ts +6 -4
  20. package/dest/index.d.ts.map +1 -1
  21. package/dest/index.js +5 -3
  22. package/dest/metrics.d.ts +7 -0
  23. package/dest/metrics.d.ts.map +1 -0
  24. package/dest/metrics.js +11 -0
  25. package/dest/null_slasher_client.d.ts +3 -4
  26. package/dest/null_slasher_client.d.ts.map +1 -1
  27. package/dest/null_slasher_client.js +1 -4
  28. package/dest/slash_offenses_collector.d.ts +6 -8
  29. package/dest/slash_offenses_collector.d.ts.map +1 -1
  30. package/dest/slash_offenses_collector.js +48 -28
  31. package/dest/slasher_client.d.ts +114 -0
  32. package/dest/slasher_client.d.ts.map +1 -0
  33. package/dest/{tally_slasher_client.js → slasher_client.js} +45 -40
  34. package/dest/slasher_client_facade.d.ts +4 -7
  35. package/dest/slasher_client_facade.d.ts.map +1 -1
  36. package/dest/slasher_client_facade.js +4 -9
  37. package/dest/slasher_client_interface.d.ts +7 -21
  38. package/dest/slasher_client_interface.d.ts.map +1 -1
  39. package/dest/slasher_client_interface.js +1 -4
  40. package/dest/stores/offenses_store.d.ts +12 -12
  41. package/dest/stores/offenses_store.d.ts.map +1 -1
  42. package/dest/stores/offenses_store.js +61 -38
  43. package/dest/watcher.d.ts +8 -1
  44. package/dest/watcher.d.ts.map +1 -1
  45. package/dest/watcher.js +1 -0
  46. package/dest/watchers/attestations_block_watcher.d.ts +26 -13
  47. package/dest/watchers/attestations_block_watcher.d.ts.map +1 -1
  48. package/dest/watchers/attestations_block_watcher.js +76 -61
  49. package/dest/watchers/attested_invalid_proposal_watcher.d.ts +42 -0
  50. package/dest/watchers/attested_invalid_proposal_watcher.d.ts.map +1 -0
  51. package/dest/watchers/attested_invalid_proposal_watcher.js +117 -0
  52. package/dest/watchers/broadcasted_invalid_checkpoint_proposal_watcher.d.ts +38 -0
  53. package/dest/watchers/broadcasted_invalid_checkpoint_proposal_watcher.d.ts.map +1 -0
  54. package/dest/watchers/broadcasted_invalid_checkpoint_proposal_watcher.js +138 -0
  55. package/dest/watchers/checkpoint_equivocation_watcher.d.ts +30 -0
  56. package/dest/watchers/checkpoint_equivocation_watcher.d.ts.map +1 -0
  57. package/dest/watchers/checkpoint_equivocation_watcher.js +69 -0
  58. package/dest/watchers/data_withholding_watcher.d.ts +63 -0
  59. package/dest/watchers/data_withholding_watcher.d.ts.map +1 -0
  60. package/dest/watchers/data_withholding_watcher.js +193 -0
  61. package/package.json +10 -10
  62. package/src/config.ts +33 -28
  63. package/src/factory/create_facade.ts +1 -2
  64. package/src/factory/create_implementation.ts +11 -117
  65. package/src/factory/get_settings.ts +8 -8
  66. package/src/factory/index.ts +1 -1
  67. package/src/generated/slasher-defaults.ts +4 -4
  68. package/src/index.ts +5 -3
  69. package/src/metrics.ts +19 -0
  70. package/src/null_slasher_client.ts +2 -6
  71. package/src/slash_offenses_collector.ts +62 -29
  72. package/src/{tally_slasher_client.ts → slasher_client.ts} +60 -48
  73. package/src/slasher_client_facade.ts +3 -10
  74. package/src/slasher_client_interface.ts +6 -21
  75. package/src/stores/offenses_store.ts +73 -47
  76. package/src/watcher.ts +8 -0
  77. package/src/watchers/attestations_block_watcher.ts +88 -82
  78. package/src/watchers/attested_invalid_proposal_watcher.ts +168 -0
  79. package/src/watchers/broadcasted_invalid_checkpoint_proposal_watcher.ts +192 -0
  80. package/src/watchers/checkpoint_equivocation_watcher.ts +96 -0
  81. package/src/watchers/data_withholding_watcher.ts +225 -0
  82. package/dest/empire_slasher_client.d.ts +0 -190
  83. package/dest/empire_slasher_client.d.ts.map +0 -1
  84. package/dest/empire_slasher_client.js +0 -564
  85. package/dest/stores/payloads_store.d.ts +0 -29
  86. package/dest/stores/payloads_store.d.ts.map +0 -1
  87. package/dest/stores/payloads_store.js +0 -128
  88. package/dest/tally_slasher_client.d.ts +0 -125
  89. package/dest/tally_slasher_client.d.ts.map +0 -1
  90. package/dest/watchers/epoch_prune_watcher.d.ts +0 -39
  91. package/dest/watchers/epoch_prune_watcher.d.ts.map +0 -1
  92. package/dest/watchers/epoch_prune_watcher.js +0 -179
  93. package/src/empire_slasher_client.ts +0 -649
  94. package/src/stores/payloads_store.ts +0 -149
  95. package/src/watchers/epoch_prune_watcher.ts +0 -256
@@ -1,6 +1,6 @@
1
1
  import { EthAddress } from '@aztec/aztec.js/addresses';
2
2
  import type { EpochCache } from '@aztec/epoch-cache';
3
- import { RollupContract, SlasherContract, TallySlashingProposerContract } from '@aztec/ethereum/contracts';
3
+ import { RollupContract, SlasherContract, SlashingProposerContract } from '@aztec/ethereum/contracts';
4
4
  import { maxBigint } from '@aztec/foundation/bigint';
5
5
  import { SlotNumber } from '@aztec/foundation/branded-types';
6
6
  import { compactArray, partition, times } from '@aztec/foundation/collection';
@@ -13,13 +13,15 @@ import {
13
13
  OffenseType,
14
14
  type ProposerSlashAction,
15
15
  type ProposerSlashActionProvider,
16
- type SlashPayloadRound,
17
16
  getEpochsForRound,
17
+ getOffenseTypeName,
18
18
  getSlashConsensusVotesFromOffenses,
19
19
  } from '@aztec/stdlib/slashing';
20
+ import { getTelemetryClient } from '@aztec/telemetry-client';
20
21
 
21
22
  import type { Hex } from 'viem';
22
23
 
24
+ import { SlasherMetrics } from './metrics.js';
23
25
  import {
24
26
  SlashOffensesCollector,
25
27
  type SlashOffensesCollectorConfig,
@@ -30,8 +32,8 @@ import type { SlasherClientInterface } from './slasher_client_interface.js';
30
32
  import type { SlasherOffensesStore } from './stores/offenses_store.js';
31
33
  import type { Watcher } from './watcher.js';
32
34
 
33
- /** Settings used in the tally slasher client, loaded from the L1 contracts during initialization */
34
- export type TallySlasherSettings = Prettify<
35
+ /** Settings used in the slasher client, loaded from the L1 contracts during initialization */
36
+ export type SlasherSettings = Prettify<
35
37
  SlashRoundMonitorSettings &
36
38
  SlashOffensesCollectorSettings & {
37
39
  slashingLifetimeInRounds: number;
@@ -45,14 +47,22 @@ export type TallySlasherSettings = Prettify<
45
47
  }
46
48
  >;
47
49
 
48
- export type TallySlasherClientConfig = SlashOffensesCollectorConfig &
50
+ export type SlasherClientConfig = SlashOffensesCollectorConfig &
49
51
  Pick<
50
52
  SlasherConfig,
51
53
  'slashValidatorsAlways' | 'slashValidatorsNever' | 'slashExecuteRoundsLookBack' | 'slashMaxPayloadSize'
52
54
  >;
53
55
 
56
+ type AlwaysSlashOffense = {
57
+ validator: EthAddress;
58
+ amount: bigint;
59
+ offenseType: OffenseType.UNKNOWN;
60
+ };
61
+
62
+ type SlashVoteOffense = Offense | AlwaysSlashOffense;
63
+
54
64
  /**
55
- * The Tally Slasher client is responsible for managing slashable offenses using
65
+ * The Slasher client is responsible for managing slashable offenses using
56
66
  * the consensus-based slashing model where proposers vote on individual validator offenses.
57
67
  *
58
68
  * The client subscribes to several slash watchers that emit offenses and tracks them. When the slasher is the
@@ -76,22 +86,16 @@ export type TallySlasherClientConfig = SlashOffensesCollectorConfig &
76
86
  * - Validators that reach the quorum threshold are slashed. A vote for slashing N units is also considered
77
87
  * a vote for slashing N-1, N-2, ..., 1 units. The system slashes for the largest amount that reaches quorum.
78
88
  * - The client monitors executable rounds and triggers execution when appropriate.
79
- *
80
- * Differences from Empire model
81
- * - No fixed slash payloads - votes are for individual validator offenses encoded in bytes
82
- * - The L1 contract determines which offenses reach quorum rather than nodes agreeing on a payload
83
- * - Proposers vote directly on which validators to slash and by how much
84
- * - Uses a slash offset to vote on validators from past rounds (e.g., round N votes on round N-2)
85
89
  */
86
- export class TallySlasherClient implements ProposerSlashActionProvider, SlasherClientInterface {
90
+ export class SlasherClient implements ProposerSlashActionProvider, SlasherClientInterface {
87
91
  protected unwatchCallbacks: (() => void)[] = [];
88
92
  protected roundMonitor: SlashRoundMonitor;
89
93
  protected offensesCollector: SlashOffensesCollector;
90
94
 
91
95
  constructor(
92
- private config: TallySlasherClientConfig,
93
- private settings: TallySlasherSettings,
94
- private tallySlashingProposer: TallySlashingProposerContract,
96
+ private config: SlasherClientConfig,
97
+ private settings: SlasherSettings,
98
+ private slashingProposer: SlashingProposerContract,
95
99
  private slasher: SlasherContract,
96
100
  private rollup: RollupContract,
97
101
  watchers: Watcher[],
@@ -99,20 +103,21 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
99
103
  private dateProvider: DateProvider,
100
104
  private offensesStore: SlasherOffensesStore,
101
105
  private log = createLogger('slasher:consensus'),
106
+ private readonly metrics = new SlasherMetrics(getTelemetryClient()),
102
107
  ) {
103
108
  this.roundMonitor = new SlashRoundMonitor(settings, dateProvider);
104
109
  this.offensesCollector = new SlashOffensesCollector(config, settings, watchers, offensesStore);
105
110
  }
106
111
 
107
112
  public async start() {
108
- this.log.debug('Starting Tally Slasher client...');
113
+ this.log.debug('Starting slasher client...');
109
114
 
110
115
  this.roundMonitor.start();
111
116
  await this.offensesCollector.start();
112
117
 
113
118
  // Listen for RoundExecuted events
114
119
  this.unwatchCallbacks.push(
115
- this.tallySlashingProposer.listenToRoundExecuted(
120
+ this.slashingProposer.listenToRoundExecuted(
116
121
  ({ round, slashCount, l1BlockHash }) =>
117
122
  void this.handleRoundExecuted(round, slashCount, l1BlockHash).catch(err =>
118
123
  this.log.error('Error handling round executed', err),
@@ -123,15 +128,13 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
123
128
  // Check for round changes
124
129
  this.unwatchCallbacks.push(this.roundMonitor.listenToNewRound(round => this.handleNewRound(round)));
125
130
 
126
- this.log.info(`Started tally slasher client`);
131
+ this.log.info(`Started slasher client`);
127
132
  return Promise.resolve();
128
133
  }
129
134
 
130
- /**
131
- * Stop the tally slasher client
132
- */
135
+ /** Stop the slasher client */
133
136
  public async stop() {
134
- this.log.debug('Stopping Tally Slasher client...');
137
+ this.log.debug('Stopping slasher client...');
135
138
 
136
139
  for (const unwatchCallback of this.unwatchCallbacks) {
137
140
  unwatchCallback();
@@ -140,7 +143,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
140
143
  this.roundMonitor.stop();
141
144
  await this.offensesCollector.stop();
142
145
 
143
- this.log.info('Tally Slasher client stopped');
146
+ this.log.info('Slasher client stopped');
144
147
  }
145
148
 
146
149
  /** Returns the current config */
@@ -155,12 +158,13 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
155
158
 
156
159
  /** Triggered on a time basis when we enter a new slashing round. Clears expired offenses. */
157
160
  protected async handleNewRound(round: bigint) {
158
- this.log.info(`Starting new tally slashing round ${round}`);
161
+ this.log.info(`Starting new slashing round ${round}`);
159
162
  await this.offensesCollector.handleNewRound(round);
160
163
  }
161
164
 
162
- /** Called when we see a RoundExecuted event on the TallySlashingProposer (just for logging). */
165
+ /** Called when we see a RoundExecuted event on the SlashingProposer (just for logging). */
163
166
  protected async handleRoundExecuted(round: bigint, slashCount: bigint, l1BlockHash: Hex) {
167
+ this.metrics.recordRoundExecuted();
164
168
  const slashes = await this.rollup.getSlashEvents(l1BlockHash);
165
169
  this.log.info(`Slashing round ${round} has been executed with ${slashCount} slashes`, { slashes });
166
170
  }
@@ -240,7 +244,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
240
244
  this.log.debug(`Testing if slashing round ${executableRound} is executable`, logData);
241
245
 
242
246
  try {
243
- const roundInfo = await this.tallySlashingProposer.getRound(executableRound);
247
+ const roundInfo = await this.slashingProposer.getRound(executableRound);
244
248
  logData = { ...logData, roundInfo };
245
249
  if (roundInfo.isExecuted) {
246
250
  this.log.verbose(`Round ${executableRound} has already been executed`, logData);
@@ -254,7 +258,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
254
258
  }
255
259
 
256
260
  // Check if round is ready to execute at the given slot
257
- const isReadyToExecute = await this.tallySlashingProposer.isRoundReadyToExecute(executableRound, slotNumber);
261
+ const isReadyToExecute = await this.slashingProposer.isRoundReadyToExecute(executableRound, slotNumber);
258
262
  if (!isReadyToExecute) {
259
263
  this.log.warn(
260
264
  `Round ${executableRound} is not ready to execute at slot ${slotNumber} according to contract check`,
@@ -264,14 +268,14 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
264
268
  }
265
269
 
266
270
  // Check if the round yields any slashing at all
267
- const { actions: slashActions, committees } = await this.tallySlashingProposer.getTally(executableRound);
271
+ const { actions: slashActions, committees } = await this.slashingProposer.getTally(executableRound);
268
272
  if (slashActions.length === 0) {
269
273
  this.log.verbose(`Round ${executableRound} does not resolve in any slashing`, logData);
270
274
  return undefined;
271
275
  }
272
276
 
273
277
  // Check if the slash payload is vetoed
274
- const payload = await this.tallySlashingProposer.getPayload(executableRound);
278
+ const payload = await this.slashingProposer.getPayload(executableRound);
275
279
  const isVetoed = await this.slasher.isPayloadVetoed(payload.address);
276
280
  if (isVetoed) {
277
281
  this.log.warn(`Round ${executableRound} payload is vetoed (skipping execution)`, {
@@ -318,7 +322,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
318
322
  // Compute offenses to slash, by loading the offenses for this round, adding synthetic offenses
319
323
  // for validators that should always be slashed, and removing the ones that should never be slashed.
320
324
  const offensesForRound = await this.gatherOffensesForRound(currentRound);
321
- const offensesFromAlwaysSlash = (this.config.slashValidatorsAlways ?? []).map(validator => ({
325
+ const offensesFromAlwaysSlash: AlwaysSlashOffense[] = (this.config.slashValidatorsAlways ?? []).map(validator => ({
322
326
  validator,
323
327
  amount: this.settings.slashingAmounts[2],
324
328
  offenseType: OffenseType.UNKNOWN,
@@ -332,7 +336,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
332
336
  slotNumber,
333
337
  currentRound,
334
338
  slashedRound,
335
- offensesToForgive,
339
+ offensesFromAlwaysSlash: offensesFromAlwaysSlash.map(getOffenseLogData),
336
340
  slashValidatorsAlways: this.config.slashValidatorsAlways,
337
341
  });
338
342
  }
@@ -342,7 +346,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
342
346
  slotNumber,
343
347
  currentRound,
344
348
  slashedRound,
345
- offensesToForgive,
349
+ offensesToForgive: offensesToForgive.map(getOffenseLogData),
346
350
  slashValidatorsNever: this.config.slashValidatorsNever,
347
351
  });
348
352
  }
@@ -352,11 +356,11 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
352
356
  return undefined;
353
357
  }
354
358
 
355
- this.log.info(`Voting to slash ${offensesToSlash.length} offenses`, {
359
+ this.log.debug(`Computing slash votes for ${offensesToSlash.length} offenses`, {
356
360
  slotNumber,
357
361
  currentRound,
358
362
  slashedRound,
359
- offensesToSlash,
363
+ offensesToSlash: offensesToSlash.map(getOffenseLogData),
360
364
  });
361
365
 
362
366
  const committees = await this.collectCommitteesActiveDuringRound(slashedRound);
@@ -374,12 +378,20 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
374
378
  slotNumber,
375
379
  currentRound,
376
380
  slashedRound,
377
- offensesToSlash,
381
+ offensesToSlash: offensesToSlash.map(getOffenseLogData),
378
382
  committees,
379
383
  });
380
384
  return undefined;
381
385
  }
382
386
 
387
+ this.log.info(`Voting to slash ${offensesToSlash.length} offenses`, {
388
+ slotNumber,
389
+ slashedRound,
390
+ currentRound,
391
+ votes,
392
+ offensesToSlash: offensesToSlash.map(getOffenseLogData),
393
+ });
394
+
383
395
  this.log.debug(`Computed votes for slashing ${offensesToSlash.length} offenses`, {
384
396
  slashedRound,
385
397
  currentRound,
@@ -405,17 +417,9 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
405
417
  );
406
418
  }
407
419
 
408
- /**
409
- * Get slash payloads is NOT SUPPORTED in tally model
410
- * @throws Error indicating this operation is not supported
411
- */
412
- public getSlashPayloads(): Promise<SlashPayloadRound[]> {
413
- return Promise.reject(new Error('Tally slashing model does not support slash payloads'));
414
- }
415
-
416
420
  /**
417
421
  * Gather offenses to be slashed on a given round.
418
- * In tally slashing, round N slashes validators from round N - slashOffsetInRounds.
422
+ * Round N slashes validators from round N - slashOffsetInRounds.
419
423
  * @param round - The round to get offenses for, defaults to current round
420
424
  * @returns Array of pending offenses for the round with offset applied
421
425
  */
@@ -428,9 +432,9 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
428
432
  return await this.offensesStore.getOffensesForRound(targetRound);
429
433
  }
430
434
 
431
- /** Returns all pending offenses stored */
432
- public getPendingOffenses(): Promise<Offense[]> {
433
- return this.offensesStore.getPendingOffenses();
435
+ /** Returns all offenses stored */
436
+ public getOffenses(): Promise<Offense[]> {
437
+ return this.offensesStore.getOffenses();
434
438
  }
435
439
 
436
440
  /**
@@ -446,3 +450,11 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
446
450
  return round - BigInt(this.settings.slashingOffsetInRounds);
447
451
  }
448
452
  }
453
+
454
+ function getOffenseLogData(offense: SlashVoteOffense) {
455
+ return {
456
+ ...offense,
457
+ validator: offense.validator.toString(),
458
+ offenseType: getOffenseTypeName(offense.offenseType),
459
+ };
460
+ }
@@ -2,13 +2,12 @@ import { EpochCache } from '@aztec/epoch-cache';
2
2
  import { RollupContract } from '@aztec/ethereum/contracts';
3
3
  import type { ViemClient } from '@aztec/ethereum/types';
4
4
  import type { SlotNumber } from '@aztec/foundation/branded-types';
5
- import { EthAddress } from '@aztec/foundation/eth-address';
6
5
  import { createLogger } from '@aztec/foundation/log';
7
6
  import { DateProvider } from '@aztec/foundation/timer';
8
7
  import { AztecLMDBStoreV2 } from '@aztec/kv-store/lmdb-v2';
9
8
  import type { SlasherConfig } from '@aztec/stdlib/interfaces/server';
10
9
  import type { DataStoreConfig } from '@aztec/stdlib/kv-store';
11
- import type { Offense, ProposerSlashAction, SlashPayloadRound } from '@aztec/stdlib/slashing';
10
+ import type { Offense, ProposerSlashAction } from '@aztec/stdlib/slashing';
12
11
 
13
12
  import { createSlasherImplementation } from './factory/create_implementation.js';
14
13
  import type { SlasherClientInterface } from './slasher_client_interface.js';
@@ -27,7 +26,6 @@ export class SlasherClientFacade implements SlasherClientInterface {
27
26
  private config: SlasherConfig & DataStoreConfig & { ethereumSlotDuration: number },
28
27
  private rollup: RollupContract,
29
28
  private l1Client: ViemClient,
30
- private slashFactoryAddress: EthAddress | undefined,
31
29
  private watchers: Watcher[],
32
30
  private epochCache: EpochCache,
33
31
  private dateProvider: DateProvider,
@@ -63,16 +61,12 @@ export class SlasherClientFacade implements SlasherClientInterface {
63
61
  this.watchers.forEach(watcher => watcher.updateConfig?.(config));
64
62
  }
65
63
 
66
- public getSlashPayloads(): Promise<SlashPayloadRound[]> {
67
- return this.client?.getSlashPayloads() ?? Promise.reject(new Error('Slasher client not initialized'));
68
- }
69
-
70
64
  public gatherOffensesForRound(round?: bigint): Promise<Offense[]> {
71
65
  return this.client?.gatherOffensesForRound(round) ?? Promise.reject(new Error('Slasher client not initialized'));
72
66
  }
73
67
 
74
- public getPendingOffenses(): Promise<Offense[]> {
75
- return this.client?.getPendingOffenses() ?? Promise.reject(new Error('Slasher client not initialized'));
68
+ public getOffenses(): Promise<Offense[]> {
69
+ return this.client?.getOffenses() ?? Promise.reject(new Error('Slasher client not initialized'));
76
70
  }
77
71
 
78
72
  public getProposerActions(slotNumber: SlotNumber): Promise<ProposerSlashAction[]> {
@@ -84,7 +78,6 @@ export class SlasherClientFacade implements SlasherClientInterface {
84
78
  this.config,
85
79
  this.rollup,
86
80
  this.l1Client,
87
- this.slashFactoryAddress,
88
81
  this.watchers,
89
82
  this.epochCache,
90
83
  this.dateProvider,
@@ -1,11 +1,8 @@
1
1
  import type { SlotNumber } from '@aztec/foundation/branded-types';
2
2
  import type { SlasherConfig } from '@aztec/stdlib/interfaces/server';
3
- import type { Offense, ProposerSlashAction, SlashPayloadRound } from '@aztec/stdlib/slashing';
3
+ import type { Offense, ProposerSlashAction } from '@aztec/stdlib/slashing';
4
4
 
5
- /**
6
- * Common interface for slasher clients used by the Aztec node.
7
- * Both Empire and Consensus slasher clients implement this interface.
8
- */
5
+ /** Common interface for slasher clients used by the Aztec node. */
9
6
  export interface SlasherClientInterface {
10
7
  /** Start the slasher client */
11
8
  start(): Promise<void>;
@@ -13,25 +10,13 @@ export interface SlasherClientInterface {
13
10
  /** Stop the slasher client */
14
11
  stop(): Promise<void>;
15
12
 
16
- /**
17
- * Get slash payloads for the Empire model.
18
- * The Consensus model should throw an error when this is called.
19
- */
20
- getSlashPayloads(): Promise<SlashPayloadRound[]>;
21
-
22
- /**
23
- * Gather offenses for a given round, defaults to current.
24
- * Used by both Empire and Consensus models.
25
- */
13
+ /** Gather offenses for a given round, defaults to current. */
26
14
  gatherOffensesForRound(round?: bigint): Promise<Offense[]>;
27
15
 
28
- /** Returns all pending offenses */
29
- getPendingOffenses(): Promise<Offense[]>;
16
+ /** Returns all offenses */
17
+ getOffenses(): Promise<Offense[]>;
30
18
 
31
- /**
32
- * Update the configuration.
33
- * Used by both Empire and Consensus models.
34
- */
19
+ /** Update the configuration. */
35
20
  updateConfig(config: Partial<SlasherConfig>): void;
36
21
 
37
22
  /**
@@ -1,5 +1,5 @@
1
1
  import { createLogger } from '@aztec/aztec.js/log';
2
- import type { AztecAsyncKVStore, AztecAsyncMap, AztecAsyncMultiMap, AztecAsyncSet } from '@aztec/kv-store';
2
+ import type { AztecAsyncKVStore, AztecAsyncMap, AztecAsyncMultiMap } from '@aztec/kv-store';
3
3
  import {
4
4
  type Offense,
5
5
  type OffenseIdentifier,
@@ -10,14 +10,15 @@ import {
10
10
 
11
11
  export const SCHEMA_VERSION = 1;
12
12
 
13
+ type ClearOffensesFilter = Pick<Offense, 'offenseType' | 'epochOrSlot'> & {
14
+ validators?: Offense['validator'][];
15
+ };
16
+
13
17
  export class SlasherOffensesStore {
14
18
  /** Map from offense key to offense data */
15
19
  private offenses: AztecAsyncMap<string, Buffer>;
16
20
 
17
- /** Map from offense key to whether the offense has been executed (only used for empire based slashing) */
18
- private offensesSlashed: AztecAsyncSet<string>;
19
-
20
- /** Multimap from round to offense keys (only used for consensus based slashing) */
21
+ /** Multimap from round to offense keys */
21
22
  private roundsOffenses: AztecAsyncMultiMap<string, string>;
22
23
 
23
24
  private log = createLogger('slasher:store:offenses');
@@ -32,18 +33,13 @@ export class SlasherOffensesStore {
32
33
  ) {
33
34
  this.offenses = kvStore.openMap('offenses');
34
35
  this.roundsOffenses = kvStore.openMultiMap('rounds-offenses');
35
- this.offensesSlashed = kvStore.openSet('offenses-slashed');
36
36
  }
37
37
 
38
- /** Returns all offenses not marked as slashed */
39
- public async getPendingOffenses(): Promise<Offense[]> {
38
+ /** Returns all offenses */
39
+ public async getOffenses(): Promise<Offense[]> {
40
40
  const offenses: Offense[] = [];
41
- for await (const [key, buffer] of this.offenses.entriesAsync()) {
42
- if (await this.offensesSlashed.hasAsync(key)) {
43
- continue; // Skip executed offenses
44
- }
45
- const offense = deserializeOffense(buffer);
46
- offenses.push(offense);
41
+ for await (const [, buffer] of this.offenses.entriesAsync()) {
42
+ offenses.push(deserializeOffense(buffer));
47
43
  }
48
44
  return offenses;
49
45
  }
@@ -61,36 +57,68 @@ export class SlasherOffensesStore {
61
57
  return offenses;
62
58
  }
63
59
 
64
- /** Returns whether an offense is pending (ie not marked as slashed) */
65
- public async hasPendingOffense(offense: OffenseIdentifier): Promise<boolean> {
66
- const key = this.getOffenseKey(offense);
67
- return (await this.offenses.getAsync(key)) !== undefined && !(await this.offensesSlashed.hasAsync(key));
68
- }
69
-
70
60
  /** Returns whether we have seen this offense */
71
61
  public async hasOffense(offense: OffenseIdentifier): Promise<boolean> {
72
62
  const key = this.getOffenseKey(offense);
73
63
  return (await this.offenses.getAsync(key)) !== undefined;
74
64
  }
75
65
 
76
- /** Adds a new offense (defaults to pending, but will be slashed if markAsSlashed had been called for it) */
77
- public async addPendingOffense(offense: Offense): Promise<void> {
66
+ /** Adds a new offense. Returns false if the offense is already pending. */
67
+ public async addOffense(offense: Offense): Promise<boolean> {
78
68
  const key = this.getOffenseKey(offense);
79
69
  const round = getRoundForOffense(offense, this.settings);
80
- await this.kvStore.transactionAsync(async () => {
70
+ const added = await this.kvStore.transactionAsync(async () => {
71
+ if ((await this.offenses.getAsync(key)) !== undefined) {
72
+ return false;
73
+ }
74
+
81
75
  await this.offenses.set(key, serializeOffense(offense));
82
76
  await this.roundsOffenses.set(this.getRoundKey(round), key);
77
+ return true;
83
78
  });
84
- this.log.trace(`Adding pending offense ${key} for round ${round}`);
79
+
80
+ if (added) {
81
+ this.log.trace(`Adding pending offense ${key} for round ${round}`);
82
+ }
83
+
84
+ return added;
85
85
  }
86
86
 
87
- /** Marks the given offenses as slashed (regardless of whether they are known or not) */
88
- public async markAsSlashed(offenses: OffenseIdentifier[]): Promise<void> {
89
- await this.kvStore.transactionAsync(async () => {
90
- for (const offense of offenses) {
91
- const key = this.getOffenseKey(offense);
92
- await this.offensesSlashed.add(key);
87
+ /** Removes pending offenses matching the given offense type, epoch/slot, and optional validators. */
88
+ public async clearOffenses(filter: ClearOffensesFilter): Promise<number> {
89
+ return await this.kvStore.transactionAsync(async () => {
90
+ const offensesToClear = new Map<string, Offense>();
91
+
92
+ if (filter.validators && filter.validators.length > 0) {
93
+ for (const validator of filter.validators) {
94
+ const identifier = { validator, offenseType: filter.offenseType, epochOrSlot: filter.epochOrSlot };
95
+ const key = this.getOffenseKey(identifier);
96
+ const buffer = await this.offenses.getAsync(key);
97
+ if (buffer) {
98
+ offensesToClear.set(key, deserializeOffense(buffer));
99
+ }
100
+ }
101
+ } else {
102
+ for await (const [key, buffer] of this.offenses.entriesAsync()) {
103
+ const offense = deserializeOffense(buffer);
104
+ if (offense.offenseType === filter.offenseType && offense.epochOrSlot === filter.epochOrSlot) {
105
+ offensesToClear.set(key, offense);
106
+ }
107
+ }
93
108
  }
109
+
110
+ if (offensesToClear.size === 0) {
111
+ return 0;
112
+ }
113
+
114
+ for (const [key, offense] of offensesToClear) {
115
+ const round = getRoundForOffense(offense, this.settings);
116
+ await this.offenses.delete(key);
117
+ await this.roundsOffenses.deleteValue(this.getRoundKey(round), key);
118
+ this.log.trace(`Cleared pending offense ${key} for round ${round}`);
119
+ }
120
+
121
+ return offensesToClear.size;
94
122
  });
95
123
  }
96
124
 
@@ -106,34 +134,32 @@ export class SlasherOffensesStore {
106
134
  return 0; // Not enough rounds have passed to expire anything
107
135
  }
108
136
 
109
- // Collect expired offenses and rounds
110
- const expiredRoundKeys = new Set<string>();
111
- const expiredOffenseKeys = new Set<string>();
112
- for await (const [roundKey, offenseKey] of this.roundsOffenses.entriesAsync({
113
- end: this.getRoundKey(expiredBefore),
114
- })) {
115
- expiredOffenseKeys.add(offenseKey);
116
- expiredRoundKeys.add(roundKey);
117
- }
137
+ return await this.kvStore.transactionAsync(async () => {
138
+ // Collect expired offenses and rounds
139
+ const expiredRoundKeys = new Set<string>();
140
+ const expiredOffenseKeys = new Set<string>();
141
+ for await (const [roundKey, offenseKey] of this.roundsOffenses.entriesAsync({
142
+ end: this.getRoundKey(expiredBefore),
143
+ })) {
144
+ expiredOffenseKeys.add(offenseKey);
145
+ expiredRoundKeys.add(roundKey);
146
+ }
118
147
 
119
- if (expiredOffenseKeys.size === 0 && expiredRoundKeys.size === 0) {
120
- return 0; // Nothing to clean up
121
- }
148
+ if (expiredOffenseKeys.size === 0 && expiredRoundKeys.size === 0) {
149
+ return 0; // Nothing to clean up
150
+ }
122
151
 
123
- // Remove expired stuff in a transaction
124
- await this.kvStore.transactionAsync(async () => {
125
152
  for (const key of expiredOffenseKeys) {
126
153
  this.log.trace(`Deleting offense ${key}`);
127
154
  await this.offenses.delete(key);
128
- await this.offensesSlashed.delete(key);
129
155
  }
130
156
  for (const roundKey of expiredRoundKeys) {
131
157
  this.log.trace(`Deleting round info for ${roundKey}`);
132
158
  await this.roundsOffenses.delete(roundKey);
133
159
  }
134
- });
135
160
 
136
- return expiredOffenseKeys.size;
161
+ return expiredOffenseKeys.size;
162
+ });
137
163
  }
138
164
 
139
165
  /** Generate a unique key for an offense */
package/src/watcher.ts CHANGED
@@ -5,6 +5,7 @@ import { OffenseType } from '@aztec/stdlib/slashing';
5
5
  import type { SlasherConfig } from './config.js';
6
6
 
7
7
  export const WANT_TO_SLASH_EVENT = 'want-to-slash' as const;
8
+ export const WANT_TO_CLEAR_SLASH_EVENT = 'want-to-clear-slash' as const;
8
9
 
9
10
  export interface WantToSlashArgs {
10
11
  validator: EthAddress;
@@ -13,9 +14,16 @@ export interface WantToSlashArgs {
13
14
  epochOrSlot: bigint; // Epoch number for epoch-based offenses, slot number for slot-based
14
15
  }
15
16
 
17
+ export interface WantToClearSlashArgs {
18
+ offenseType: OffenseType;
19
+ epochOrSlot: bigint; // Epoch number for epoch-based offenses, slot number for slot-based
20
+ validators?: EthAddress[];
21
+ }
22
+
16
23
  // Event map for specific, known events of a watcher
17
24
  export interface WatcherEventMap {
18
25
  [WANT_TO_SLASH_EVENT]: (args: WantToSlashArgs[]) => void;
26
+ [WANT_TO_CLEAR_SLASH_EVENT]: (args: WantToClearSlashArgs[]) => void;
19
27
  }
20
28
 
21
29
  export type WatcherEmitter = TypedEventEmitter<WatcherEventMap>;