@aztec/slasher 0.0.1-commit.d3ec352c → 0.0.1-commit.d58ff9d0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (95) hide show
  1. package/README.md +90 -76
  2. package/dest/config.d.ts +1 -1
  3. package/dest/config.d.ts.map +1 -1
  4. package/dest/config.js +53 -41
  5. package/dest/factory/create_facade.d.ts +5 -4
  6. package/dest/factory/create_facade.d.ts.map +1 -1
  7. package/dest/factory/create_facade.js +26 -3
  8. package/dest/factory/create_implementation.d.ts +7 -8
  9. package/dest/factory/create_implementation.d.ts.map +1 -1
  10. package/dest/factory/create_implementation.js +8 -56
  11. package/dest/factory/get_settings.d.ts +4 -4
  12. package/dest/factory/get_settings.d.ts.map +1 -1
  13. package/dest/factory/get_settings.js +3 -3
  14. package/dest/factory/index.d.ts +2 -2
  15. package/dest/factory/index.d.ts.map +1 -1
  16. package/dest/factory/index.js +1 -1
  17. package/dest/generated/slasher-defaults.d.ts +21 -0
  18. package/dest/generated/slasher-defaults.d.ts.map +1 -0
  19. package/dest/generated/slasher-defaults.js +21 -0
  20. package/dest/index.d.ts +6 -4
  21. package/dest/index.d.ts.map +1 -1
  22. package/dest/index.js +5 -3
  23. package/dest/metrics.d.ts +7 -0
  24. package/dest/metrics.d.ts.map +1 -0
  25. package/dest/metrics.js +11 -0
  26. package/dest/null_slasher_client.d.ts +3 -4
  27. package/dest/null_slasher_client.d.ts.map +1 -1
  28. package/dest/null_slasher_client.js +1 -4
  29. package/dest/slash_offenses_collector.d.ts +10 -9
  30. package/dest/slash_offenses_collector.d.ts.map +1 -1
  31. package/dest/slash_offenses_collector.js +50 -30
  32. package/dest/{tally_slasher_client.d.ts → slasher_client.d.ts} +17 -28
  33. package/dest/slasher_client.d.ts.map +1 -0
  34. package/dest/{tally_slasher_client.js → slasher_client.js} +55 -45
  35. package/dest/slasher_client_facade.d.ts +7 -9
  36. package/dest/slasher_client_facade.d.ts.map +1 -1
  37. package/dest/slasher_client_facade.js +6 -9
  38. package/dest/slasher_client_interface.d.ts +7 -21
  39. package/dest/slasher_client_interface.d.ts.map +1 -1
  40. package/dest/slasher_client_interface.js +1 -4
  41. package/dest/stores/offenses_store.d.ts +12 -12
  42. package/dest/stores/offenses_store.d.ts.map +1 -1
  43. package/dest/stores/offenses_store.js +64 -39
  44. package/dest/watcher.d.ts +8 -1
  45. package/dest/watcher.d.ts.map +1 -1
  46. package/dest/watcher.js +1 -0
  47. package/dest/watchers/attestations_block_watcher.d.ts +29 -15
  48. package/dest/watchers/attestations_block_watcher.d.ts.map +1 -1
  49. package/dest/watchers/attestations_block_watcher.js +90 -69
  50. package/dest/watchers/attested_invalid_proposal_watcher.d.ts +42 -0
  51. package/dest/watchers/attested_invalid_proposal_watcher.d.ts.map +1 -0
  52. package/dest/watchers/attested_invalid_proposal_watcher.js +117 -0
  53. package/dest/watchers/broadcasted_invalid_checkpoint_proposal_watcher.d.ts +38 -0
  54. package/dest/watchers/broadcasted_invalid_checkpoint_proposal_watcher.d.ts.map +1 -0
  55. package/dest/watchers/broadcasted_invalid_checkpoint_proposal_watcher.js +138 -0
  56. package/dest/watchers/checkpoint_equivocation_watcher.d.ts +30 -0
  57. package/dest/watchers/checkpoint_equivocation_watcher.d.ts.map +1 -0
  58. package/dest/watchers/checkpoint_equivocation_watcher.js +69 -0
  59. package/dest/watchers/data_withholding_watcher.d.ts +63 -0
  60. package/dest/watchers/data_withholding_watcher.d.ts.map +1 -0
  61. package/dest/watchers/data_withholding_watcher.js +193 -0
  62. package/package.json +15 -13
  63. package/src/config.ts +61 -41
  64. package/src/factory/create_facade.ts +35 -6
  65. package/src/factory/create_implementation.ts +25 -106
  66. package/src/factory/get_settings.ts +8 -8
  67. package/src/factory/index.ts +1 -1
  68. package/src/generated/slasher-defaults.ts +23 -0
  69. package/src/index.ts +5 -3
  70. package/src/metrics.ts +19 -0
  71. package/src/null_slasher_client.ts +2 -6
  72. package/src/slash_offenses_collector.ts +70 -32
  73. package/src/{tally_slasher_client.ts → slasher_client.ts} +72 -54
  74. package/src/slasher_client_facade.ts +7 -12
  75. package/src/slasher_client_interface.ts +6 -21
  76. package/src/stores/offenses_store.ts +76 -48
  77. package/src/watcher.ts +8 -0
  78. package/src/watchers/attestations_block_watcher.ts +107 -88
  79. package/src/watchers/attested_invalid_proposal_watcher.ts +168 -0
  80. package/src/watchers/broadcasted_invalid_checkpoint_proposal_watcher.ts +192 -0
  81. package/src/watchers/checkpoint_equivocation_watcher.ts +96 -0
  82. package/src/watchers/data_withholding_watcher.ts +225 -0
  83. package/dest/empire_slasher_client.d.ts +0 -190
  84. package/dest/empire_slasher_client.d.ts.map +0 -1
  85. package/dest/empire_slasher_client.js +0 -572
  86. package/dest/stores/payloads_store.d.ts +0 -29
  87. package/dest/stores/payloads_store.d.ts.map +0 -1
  88. package/dest/stores/payloads_store.js +0 -125
  89. package/dest/tally_slasher_client.d.ts.map +0 -1
  90. package/dest/watchers/epoch_prune_watcher.d.ts +0 -37
  91. package/dest/watchers/epoch_prune_watcher.d.ts.map +0 -1
  92. package/dest/watchers/epoch_prune_watcher.js +0 -137
  93. package/src/empire_slasher_client.ts +0 -657
  94. package/src/stores/payloads_store.ts +0 -146
  95. package/src/watchers/epoch_prune_watcher.ts +0 -194
@@ -1,11 +1,10 @@
1
1
  import { EthAddress } from '@aztec/aztec.js/addresses';
2
2
  import type { EpochCache } from '@aztec/epoch-cache';
3
- import { RollupContract, SlasherContract, TallySlashingProposerContract } from '@aztec/ethereum/contracts';
3
+ import { RollupContract, SlasherContract, SlashingProposerContract } from '@aztec/ethereum/contracts';
4
4
  import { maxBigint } from '@aztec/foundation/bigint';
5
5
  import { SlotNumber } from '@aztec/foundation/branded-types';
6
6
  import { compactArray, partition, times } from '@aztec/foundation/collection';
7
7
  import { createLogger } from '@aztec/foundation/log';
8
- import { sleep } from '@aztec/foundation/sleep';
9
8
  import type { DateProvider } from '@aztec/foundation/timer';
10
9
  import type { Prettify } from '@aztec/foundation/types';
11
10
  import type { SlasherConfig } from '@aztec/stdlib/interfaces/server';
@@ -14,13 +13,15 @@ import {
14
13
  OffenseType,
15
14
  type ProposerSlashAction,
16
15
  type ProposerSlashActionProvider,
17
- type SlashPayloadRound,
18
16
  getEpochsForRound,
17
+ getOffenseTypeName,
19
18
  getSlashConsensusVotesFromOffenses,
20
19
  } from '@aztec/stdlib/slashing';
20
+ import { getTelemetryClient } from '@aztec/telemetry-client';
21
21
 
22
22
  import type { Hex } from 'viem';
23
23
 
24
+ import { SlasherMetrics } from './metrics.js';
24
25
  import {
25
26
  SlashOffensesCollector,
26
27
  type SlashOffensesCollectorConfig,
@@ -31,8 +32,8 @@ import type { SlasherClientInterface } from './slasher_client_interface.js';
31
32
  import type { SlasherOffensesStore } from './stores/offenses_store.js';
32
33
  import type { Watcher } from './watcher.js';
33
34
 
34
- /** Settings used in the tally slasher client, loaded from the L1 contracts during initialization */
35
- export type TallySlasherSettings = Prettify<
35
+ /** Settings used in the slasher client, loaded from the L1 contracts during initialization */
36
+ export type SlasherSettings = Prettify<
36
37
  SlashRoundMonitorSettings &
37
38
  SlashOffensesCollectorSettings & {
38
39
  slashingLifetimeInRounds: number;
@@ -46,11 +47,22 @@ export type TallySlasherSettings = Prettify<
46
47
  }
47
48
  >;
48
49
 
49
- export type TallySlasherClientConfig = SlashOffensesCollectorConfig &
50
- Pick<SlasherConfig, 'slashValidatorsAlways' | 'slashValidatorsNever' | 'slashExecuteRoundsLookBack'>;
50
+ export type SlasherClientConfig = SlashOffensesCollectorConfig &
51
+ Pick<
52
+ SlasherConfig,
53
+ 'slashValidatorsAlways' | 'slashValidatorsNever' | 'slashExecuteRoundsLookBack' | 'slashMaxPayloadSize'
54
+ >;
55
+
56
+ type AlwaysSlashOffense = {
57
+ validator: EthAddress;
58
+ amount: bigint;
59
+ offenseType: OffenseType.UNKNOWN;
60
+ };
61
+
62
+ type SlashVoteOffense = Offense | AlwaysSlashOffense;
51
63
 
52
64
  /**
53
- * The Tally Slasher client is responsible for managing slashable offenses using
65
+ * The Slasher client is responsible for managing slashable offenses using
54
66
  * the consensus-based slashing model where proposers vote on individual validator offenses.
55
67
  *
56
68
  * The client subscribes to several slash watchers that emit offenses and tracks them. When the slasher is the
@@ -74,22 +86,16 @@ export type TallySlasherClientConfig = SlashOffensesCollectorConfig &
74
86
  * - Validators that reach the quorum threshold are slashed. A vote for slashing N units is also considered
75
87
  * a vote for slashing N-1, N-2, ..., 1 units. The system slashes for the largest amount that reaches quorum.
76
88
  * - The client monitors executable rounds and triggers execution when appropriate.
77
- *
78
- * Differences from Empire model
79
- * - No fixed slash payloads - votes are for individual validator offenses encoded in bytes
80
- * - The L1 contract determines which offenses reach quorum rather than nodes agreeing on a payload
81
- * - Proposers vote directly on which validators to slash and by how much
82
- * - Uses a slash offset to vote on validators from past rounds (e.g., round N votes on round N-2)
83
89
  */
84
- export class TallySlasherClient implements ProposerSlashActionProvider, SlasherClientInterface {
90
+ export class SlasherClient implements ProposerSlashActionProvider, SlasherClientInterface {
85
91
  protected unwatchCallbacks: (() => void)[] = [];
86
92
  protected roundMonitor: SlashRoundMonitor;
87
93
  protected offensesCollector: SlashOffensesCollector;
88
94
 
89
95
  constructor(
90
- private config: TallySlasherClientConfig,
91
- private settings: TallySlasherSettings,
92
- private tallySlashingProposer: TallySlashingProposerContract,
96
+ private config: SlasherClientConfig,
97
+ private settings: SlasherSettings,
98
+ private slashingProposer: SlashingProposerContract,
93
99
  private slasher: SlasherContract,
94
100
  private rollup: RollupContract,
95
101
  watchers: Watcher[],
@@ -97,20 +103,21 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
97
103
  private dateProvider: DateProvider,
98
104
  private offensesStore: SlasherOffensesStore,
99
105
  private log = createLogger('slasher:consensus'),
106
+ private readonly metrics = new SlasherMetrics(getTelemetryClient()),
100
107
  ) {
101
108
  this.roundMonitor = new SlashRoundMonitor(settings, dateProvider);
102
109
  this.offensesCollector = new SlashOffensesCollector(config, settings, watchers, offensesStore);
103
110
  }
104
111
 
105
112
  public async start() {
106
- this.log.debug('Starting Tally Slasher client...');
113
+ this.log.debug('Starting slasher client...');
107
114
 
108
115
  this.roundMonitor.start();
109
116
  await this.offensesCollector.start();
110
117
 
111
118
  // Listen for RoundExecuted events
112
119
  this.unwatchCallbacks.push(
113
- this.tallySlashingProposer.listenToRoundExecuted(
120
+ this.slashingProposer.listenToRoundExecuted(
114
121
  ({ round, slashCount, l1BlockHash }) =>
115
122
  void this.handleRoundExecuted(round, slashCount, l1BlockHash).catch(err =>
116
123
  this.log.error('Error handling round executed', err),
@@ -121,15 +128,13 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
121
128
  // Check for round changes
122
129
  this.unwatchCallbacks.push(this.roundMonitor.listenToNewRound(round => this.handleNewRound(round)));
123
130
 
124
- this.log.info(`Started tally slasher client`);
131
+ this.log.info(`Started slasher client`);
125
132
  return Promise.resolve();
126
133
  }
127
134
 
128
- /**
129
- * Stop the tally slasher client
130
- */
135
+ /** Stop the slasher client */
131
136
  public async stop() {
132
- this.log.debug('Stopping Tally Slasher client...');
137
+ this.log.debug('Stopping slasher client...');
133
138
 
134
139
  for (const unwatchCallback of this.unwatchCallbacks) {
135
140
  unwatchCallback();
@@ -138,9 +143,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
138
143
  this.roundMonitor.stop();
139
144
  await this.offensesCollector.stop();
140
145
 
141
- // Sleeping to sidestep viem issue with unwatching events
142
- await sleep(2000);
143
- this.log.info('Tally Slasher client stopped');
146
+ this.log.info('Slasher client stopped');
144
147
  }
145
148
 
146
149
  /** Returns the current config */
@@ -155,12 +158,13 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
155
158
 
156
159
  /** Triggered on a time basis when we enter a new slashing round. Clears expired offenses. */
157
160
  protected async handleNewRound(round: bigint) {
158
- this.log.info(`Starting new tally slashing round ${round}`);
161
+ this.log.info(`Starting new slashing round ${round}`);
159
162
  await this.offensesCollector.handleNewRound(round);
160
163
  }
161
164
 
162
- /** Called when we see a RoundExecuted event on the TallySlashingProposer (just for logging). */
165
+ /** Called when we see a RoundExecuted event on the SlashingProposer (just for logging). */
163
166
  protected async handleRoundExecuted(round: bigint, slashCount: bigint, l1BlockHash: Hex) {
167
+ this.metrics.recordRoundExecuted();
164
168
  const slashes = await this.rollup.getSlashEvents(l1BlockHash);
165
169
  this.log.info(`Slashing round ${round} has been executed with ${slashCount} slashes`, { slashes });
166
170
  }
@@ -240,7 +244,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
240
244
  this.log.debug(`Testing if slashing round ${executableRound} is executable`, logData);
241
245
 
242
246
  try {
243
- const roundInfo = await this.tallySlashingProposer.getRound(executableRound);
247
+ const roundInfo = await this.slashingProposer.getRound(executableRound);
244
248
  logData = { ...logData, roundInfo };
245
249
  if (roundInfo.isExecuted) {
246
250
  this.log.verbose(`Round ${executableRound} has already been executed`, logData);
@@ -254,7 +258,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
254
258
  }
255
259
 
256
260
  // Check if round is ready to execute at the given slot
257
- const isReadyToExecute = await this.tallySlashingProposer.isRoundReadyToExecute(executableRound, slotNumber);
261
+ const isReadyToExecute = await this.slashingProposer.isRoundReadyToExecute(executableRound, slotNumber);
258
262
  if (!isReadyToExecute) {
259
263
  this.log.warn(
260
264
  `Round ${executableRound} is not ready to execute at slot ${slotNumber} according to contract check`,
@@ -264,14 +268,14 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
264
268
  }
265
269
 
266
270
  // Check if the round yields any slashing at all
267
- const { actions: slashActions, committees } = await this.tallySlashingProposer.getTally(executableRound);
271
+ const { actions: slashActions, committees } = await this.slashingProposer.getTally(executableRound);
268
272
  if (slashActions.length === 0) {
269
273
  this.log.verbose(`Round ${executableRound} does not resolve in any slashing`, logData);
270
274
  return undefined;
271
275
  }
272
276
 
273
277
  // Check if the slash payload is vetoed
274
- const payload = await this.tallySlashingProposer.getPayload(executableRound);
278
+ const payload = await this.slashingProposer.getPayload(executableRound);
275
279
  const isVetoed = await this.slasher.isPayloadVetoed(payload.address);
276
280
  if (isVetoed) {
277
281
  this.log.warn(`Round ${executableRound} payload is vetoed (skipping execution)`, {
@@ -281,8 +285,12 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
281
285
  return undefined;
282
286
  }
283
287
 
288
+ const slashActionsWithAmounts = slashActions.map(action => ({
289
+ validator: action.validator.toString(),
290
+ slashAmount: action.slashAmount.toString(),
291
+ }));
284
292
  this.log.info(`Round ${executableRound} is ready to execute with ${slashActions.length} slashes`, {
285
- slashActions,
293
+ slashActions: slashActionsWithAmounts,
286
294
  payloadAddress: payload.address.toString(),
287
295
  ...logData,
288
296
  });
@@ -314,7 +322,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
314
322
  // Compute offenses to slash, by loading the offenses for this round, adding synthetic offenses
315
323
  // for validators that should always be slashed, and removing the ones that should never be slashed.
316
324
  const offensesForRound = await this.gatherOffensesForRound(currentRound);
317
- const offensesFromAlwaysSlash = (this.config.slashValidatorsAlways ?? []).map(validator => ({
325
+ const offensesFromAlwaysSlash: AlwaysSlashOffense[] = (this.config.slashValidatorsAlways ?? []).map(validator => ({
318
326
  validator,
319
327
  amount: this.settings.slashingAmounts[2],
320
328
  offenseType: OffenseType.UNKNOWN,
@@ -328,7 +336,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
328
336
  slotNumber,
329
337
  currentRound,
330
338
  slashedRound,
331
- offensesToForgive,
339
+ offensesFromAlwaysSlash: offensesFromAlwaysSlash.map(getOffenseLogData),
332
340
  slashValidatorsAlways: this.config.slashValidatorsAlways,
333
341
  });
334
342
  }
@@ -338,7 +346,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
338
346
  slotNumber,
339
347
  currentRound,
340
348
  slashedRound,
341
- offensesToForgive,
349
+ offensesToForgive: offensesToForgive.map(getOffenseLogData),
342
350
  slashValidatorsNever: this.config.slashValidatorsNever,
343
351
  });
344
352
  }
@@ -348,32 +356,42 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
348
356
  return undefined;
349
357
  }
350
358
 
351
- this.log.info(`Voting to slash ${offensesToSlash.length} offenses`, {
359
+ this.log.debug(`Computing slash votes for ${offensesToSlash.length} offenses`, {
352
360
  slotNumber,
353
361
  currentRound,
354
362
  slashedRound,
355
- offensesToSlash,
363
+ offensesToSlash: offensesToSlash.map(getOffenseLogData),
356
364
  });
357
365
 
358
366
  const committees = await this.collectCommitteesActiveDuringRound(slashedRound);
359
367
  const epochsForCommittees = getEpochsForRound(slashedRound, this.settings);
368
+ const { slashMaxPayloadSize } = this.config;
360
369
  const votes = getSlashConsensusVotesFromOffenses(
361
370
  offensesToSlash,
362
371
  committees,
363
372
  epochsForCommittees.map(e => BigInt(e)),
364
- this.settings,
373
+ { ...this.settings, maxSlashedValidators: slashMaxPayloadSize },
374
+ this.log,
365
375
  );
366
376
  if (votes.every(v => v === 0)) {
367
377
  this.log.warn(`Computed votes for offenses are all zero. Skipping vote.`, {
368
378
  slotNumber,
369
379
  currentRound,
370
380
  slashedRound,
371
- offensesToSlash,
381
+ offensesToSlash: offensesToSlash.map(getOffenseLogData),
372
382
  committees,
373
383
  });
374
384
  return undefined;
375
385
  }
376
386
 
387
+ this.log.info(`Voting to slash ${offensesToSlash.length} offenses`, {
388
+ slotNumber,
389
+ slashedRound,
390
+ currentRound,
391
+ votes,
392
+ offensesToSlash: offensesToSlash.map(getOffenseLogData),
393
+ });
394
+
377
395
  this.log.debug(`Computed votes for slashing ${offensesToSlash.length} offenses`, {
378
396
  slashedRound,
379
397
  currentRound,
@@ -399,17 +417,9 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
399
417
  );
400
418
  }
401
419
 
402
- /**
403
- * Get slash payloads is NOT SUPPORTED in tally model
404
- * @throws Error indicating this operation is not supported
405
- */
406
- public getSlashPayloads(): Promise<SlashPayloadRound[]> {
407
- return Promise.reject(new Error('Tally slashing model does not support slash payloads'));
408
- }
409
-
410
420
  /**
411
421
  * Gather offenses to be slashed on a given round.
412
- * In tally slashing, round N slashes validators from round N - slashOffsetInRounds.
422
+ * Round N slashes validators from round N - slashOffsetInRounds.
413
423
  * @param round - The round to get offenses for, defaults to current round
414
424
  * @returns Array of pending offenses for the round with offset applied
415
425
  */
@@ -422,9 +432,9 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
422
432
  return await this.offensesStore.getOffensesForRound(targetRound);
423
433
  }
424
434
 
425
- /** Returns all pending offenses stored */
426
- public getPendingOffenses(): Promise<Offense[]> {
427
- return this.offensesStore.getPendingOffenses();
435
+ /** Returns all offenses stored */
436
+ public getOffenses(): Promise<Offense[]> {
437
+ return this.offensesStore.getOffenses();
428
438
  }
429
439
 
430
440
  /**
@@ -440,3 +450,11 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
440
450
  return round - BigInt(this.settings.slashingOffsetInRounds);
441
451
  }
442
452
  }
453
+
454
+ function getOffenseLogData(offense: SlashVoteOffense) {
455
+ return {
456
+ ...offense,
457
+ validator: offense.validator.toString(),
458
+ offenseType: getOffenseTypeName(offense.offenseType),
459
+ };
460
+ }
@@ -1,14 +1,13 @@
1
1
  import { EpochCache } from '@aztec/epoch-cache';
2
- import type { ViemClient } from '@aztec/ethereum';
3
2
  import { RollupContract } from '@aztec/ethereum/contracts';
3
+ import type { ViemClient } from '@aztec/ethereum/types';
4
4
  import type { SlotNumber } from '@aztec/foundation/branded-types';
5
- import { EthAddress } from '@aztec/foundation/eth-address';
6
5
  import { createLogger } from '@aztec/foundation/log';
7
6
  import { DateProvider } from '@aztec/foundation/timer';
8
- import type { DataStoreConfig } from '@aztec/kv-store/config';
9
7
  import { AztecLMDBStoreV2 } from '@aztec/kv-store/lmdb-v2';
10
8
  import type { SlasherConfig } from '@aztec/stdlib/interfaces/server';
11
- import type { Offense, ProposerSlashAction, SlashPayloadRound } from '@aztec/stdlib/slashing';
9
+ import type { DataStoreConfig } from '@aztec/stdlib/kv-store';
10
+ import type { Offense, ProposerSlashAction } from '@aztec/stdlib/slashing';
12
11
 
13
12
  import { createSlasherImplementation } from './factory/create_implementation.js';
14
13
  import type { SlasherClientInterface } from './slasher_client_interface.js';
@@ -27,11 +26,11 @@ export class SlasherClientFacade implements SlasherClientInterface {
27
26
  private config: SlasherConfig & DataStoreConfig & { ethereumSlotDuration: number },
28
27
  private rollup: RollupContract,
29
28
  private l1Client: ViemClient,
30
- private slashFactoryAddress: EthAddress | undefined,
31
29
  private watchers: Watcher[],
32
30
  private epochCache: EpochCache,
33
31
  private dateProvider: DateProvider,
34
32
  private kvStore: AztecLMDBStoreV2,
33
+ private rollupRegisteredAtL2Slot: SlotNumber,
35
34
  private logger = createLogger('slasher'),
36
35
  ) {}
37
36
 
@@ -62,16 +61,12 @@ export class SlasherClientFacade implements SlasherClientInterface {
62
61
  this.watchers.forEach(watcher => watcher.updateConfig?.(config));
63
62
  }
64
63
 
65
- public getSlashPayloads(): Promise<SlashPayloadRound[]> {
66
- return this.client?.getSlashPayloads() ?? Promise.reject(new Error('Slasher client not initialized'));
67
- }
68
-
69
64
  public gatherOffensesForRound(round?: bigint): Promise<Offense[]> {
70
65
  return this.client?.gatherOffensesForRound(round) ?? Promise.reject(new Error('Slasher client not initialized'));
71
66
  }
72
67
 
73
- public getPendingOffenses(): Promise<Offense[]> {
74
- return this.client?.getPendingOffenses() ?? Promise.reject(new Error('Slasher client not initialized'));
68
+ public getOffenses(): Promise<Offense[]> {
69
+ return this.client?.getOffenses() ?? Promise.reject(new Error('Slasher client not initialized'));
75
70
  }
76
71
 
77
72
  public getProposerActions(slotNumber: SlotNumber): Promise<ProposerSlashAction[]> {
@@ -83,11 +78,11 @@ export class SlasherClientFacade implements SlasherClientInterface {
83
78
  this.config,
84
79
  this.rollup,
85
80
  this.l1Client,
86
- this.slashFactoryAddress,
87
81
  this.watchers,
88
82
  this.epochCache,
89
83
  this.dateProvider,
90
84
  this.kvStore,
85
+ this.rollupRegisteredAtL2Slot,
91
86
  this.logger,
92
87
  );
93
88
  }
@@ -1,11 +1,8 @@
1
1
  import type { SlotNumber } from '@aztec/foundation/branded-types';
2
2
  import type { SlasherConfig } from '@aztec/stdlib/interfaces/server';
3
- import type { Offense, ProposerSlashAction, SlashPayloadRound } from '@aztec/stdlib/slashing';
3
+ import type { Offense, ProposerSlashAction } from '@aztec/stdlib/slashing';
4
4
 
5
- /**
6
- * Common interface for slasher clients used by the Aztec node.
7
- * Both Empire and Consensus slasher clients implement this interface.
8
- */
5
+ /** Common interface for slasher clients used by the Aztec node. */
9
6
  export interface SlasherClientInterface {
10
7
  /** Start the slasher client */
11
8
  start(): Promise<void>;
@@ -13,25 +10,13 @@ export interface SlasherClientInterface {
13
10
  /** Stop the slasher client */
14
11
  stop(): Promise<void>;
15
12
 
16
- /**
17
- * Get slash payloads for the Empire model.
18
- * The Consensus model should throw an error when this is called.
19
- */
20
- getSlashPayloads(): Promise<SlashPayloadRound[]>;
21
-
22
- /**
23
- * Gather offenses for a given round, defaults to current.
24
- * Used by both Empire and Consensus models.
25
- */
13
+ /** Gather offenses for a given round, defaults to current. */
26
14
  gatherOffensesForRound(round?: bigint): Promise<Offense[]>;
27
15
 
28
- /** Returns all pending offenses */
29
- getPendingOffenses(): Promise<Offense[]>;
16
+ /** Returns all offenses */
17
+ getOffenses(): Promise<Offense[]>;
30
18
 
31
- /**
32
- * Update the configuration.
33
- * Used by both Empire and Consensus models.
34
- */
19
+ /** Update the configuration. */
35
20
  updateConfig(config: Partial<SlasherConfig>): void;
36
21
 
37
22
  /**
@@ -1,5 +1,5 @@
1
1
  import { createLogger } from '@aztec/aztec.js/log';
2
- import type { AztecAsyncKVStore, AztecAsyncMap, AztecAsyncMultiMap, AztecAsyncSet } from '@aztec/kv-store';
2
+ import type { AztecAsyncKVStore, AztecAsyncMap, AztecAsyncMultiMap } from '@aztec/kv-store';
3
3
  import {
4
4
  type Offense,
5
5
  type OffenseIdentifier,
@@ -10,14 +10,15 @@ import {
10
10
 
11
11
  export const SCHEMA_VERSION = 1;
12
12
 
13
+ type ClearOffensesFilter = Pick<Offense, 'offenseType' | 'epochOrSlot'> & {
14
+ validators?: Offense['validator'][];
15
+ };
16
+
13
17
  export class SlasherOffensesStore {
14
18
  /** Map from offense key to offense data */
15
19
  private offenses: AztecAsyncMap<string, Buffer>;
16
20
 
17
- /** Map from offense key to whether the offense has been executed (only used for empire based slashing) */
18
- private offensesSlashed: AztecAsyncSet<string>;
19
-
20
- /** Multimap from round to offense keys (only used for consensus based slashing) */
21
+ /** Multimap from round to offense keys */
21
22
  private roundsOffenses: AztecAsyncMultiMap<string, string>;
22
23
 
23
24
  private log = createLogger('slasher:store:offenses');
@@ -32,18 +33,13 @@ export class SlasherOffensesStore {
32
33
  ) {
33
34
  this.offenses = kvStore.openMap('offenses');
34
35
  this.roundsOffenses = kvStore.openMultiMap('rounds-offenses');
35
- this.offensesSlashed = kvStore.openSet('offenses-slashed');
36
36
  }
37
37
 
38
- /** Returns all offenses not marked as slashed */
39
- public async getPendingOffenses(): Promise<Offense[]> {
38
+ /** Returns all offenses */
39
+ public async getOffenses(): Promise<Offense[]> {
40
40
  const offenses: Offense[] = [];
41
- for await (const [key, buffer] of this.offenses.entriesAsync()) {
42
- if (await this.offensesSlashed.hasAsync(key)) {
43
- continue; // Skip executed offenses
44
- }
45
- const offense = deserializeOffense(buffer);
46
- offenses.push(offense);
41
+ for await (const [, buffer] of this.offenses.entriesAsync()) {
42
+ offenses.push(deserializeOffense(buffer));
47
43
  }
48
44
  return offenses;
49
45
  }
@@ -61,34 +57,68 @@ export class SlasherOffensesStore {
61
57
  return offenses;
62
58
  }
63
59
 
64
- /** Returns whether an offense is pending (ie not marked as slashed) */
65
- public async hasPendingOffense(offense: OffenseIdentifier): Promise<boolean> {
66
- const key = this.getOffenseKey(offense);
67
- return (await this.offenses.getAsync(key)) !== undefined && !(await this.offensesSlashed.hasAsync(key));
68
- }
69
-
70
60
  /** Returns whether we have seen this offense */
71
61
  public async hasOffense(offense: OffenseIdentifier): Promise<boolean> {
72
62
  const key = this.getOffenseKey(offense);
73
63
  return (await this.offenses.getAsync(key)) !== undefined;
74
64
  }
75
65
 
76
- /** Adds a new offense (defaults to pending, but will be slashed if markAsSlashed had been called for it) */
77
- public async addPendingOffense(offense: Offense): Promise<void> {
66
+ /** Adds a new offense. Returns false if the offense is already pending. */
67
+ public async addOffense(offense: Offense): Promise<boolean> {
78
68
  const key = this.getOffenseKey(offense);
79
- await this.offenses.set(key, serializeOffense(offense));
80
69
  const round = getRoundForOffense(offense, this.settings);
81
- await this.roundsOffenses.set(this.getRoundKey(round), key);
82
- this.log.trace(`Adding pending offense ${key} for round ${round}`);
70
+ const added = await this.kvStore.transactionAsync(async () => {
71
+ if ((await this.offenses.getAsync(key)) !== undefined) {
72
+ return false;
73
+ }
74
+
75
+ await this.offenses.set(key, serializeOffense(offense));
76
+ await this.roundsOffenses.set(this.getRoundKey(round), key);
77
+ return true;
78
+ });
79
+
80
+ if (added) {
81
+ this.log.trace(`Adding pending offense ${key} for round ${round}`);
82
+ }
83
+
84
+ return added;
83
85
  }
84
86
 
85
- /** Marks the given offenses as slashed (regardless of whether they are known or not) */
86
- public async markAsSlashed(offenses: OffenseIdentifier[]): Promise<void> {
87
- await this.kvStore.transactionAsync(async () => {
88
- for (const offense of offenses) {
89
- const key = this.getOffenseKey(offense);
90
- await this.offensesSlashed.add(key);
87
+ /** Removes pending offenses matching the given offense type, epoch/slot, and optional validators. */
88
+ public async clearOffenses(filter: ClearOffensesFilter): Promise<number> {
89
+ return await this.kvStore.transactionAsync(async () => {
90
+ const offensesToClear = new Map<string, Offense>();
91
+
92
+ if (filter.validators && filter.validators.length > 0) {
93
+ for (const validator of filter.validators) {
94
+ const identifier = { validator, offenseType: filter.offenseType, epochOrSlot: filter.epochOrSlot };
95
+ const key = this.getOffenseKey(identifier);
96
+ const buffer = await this.offenses.getAsync(key);
97
+ if (buffer) {
98
+ offensesToClear.set(key, deserializeOffense(buffer));
99
+ }
100
+ }
101
+ } else {
102
+ for await (const [key, buffer] of this.offenses.entriesAsync()) {
103
+ const offense = deserializeOffense(buffer);
104
+ if (offense.offenseType === filter.offenseType && offense.epochOrSlot === filter.epochOrSlot) {
105
+ offensesToClear.set(key, offense);
106
+ }
107
+ }
91
108
  }
109
+
110
+ if (offensesToClear.size === 0) {
111
+ return 0;
112
+ }
113
+
114
+ for (const [key, offense] of offensesToClear) {
115
+ const round = getRoundForOffense(offense, this.settings);
116
+ await this.offenses.delete(key);
117
+ await this.roundsOffenses.deleteValue(this.getRoundKey(round), key);
118
+ this.log.trace(`Cleared pending offense ${key} for round ${round}`);
119
+ }
120
+
121
+ return offensesToClear.size;
92
122
  });
93
123
  }
94
124
 
@@ -104,34 +134,32 @@ export class SlasherOffensesStore {
104
134
  return 0; // Not enough rounds have passed to expire anything
105
135
  }
106
136
 
107
- // Collect expired offenses and rounds
108
- const expiredRoundKeys = new Set<string>();
109
- const expiredOffenseKeys = new Set<string>();
110
- for await (const [roundKey, offenseKey] of this.roundsOffenses.entriesAsync({
111
- end: this.getRoundKey(expiredBefore),
112
- })) {
113
- expiredOffenseKeys.add(offenseKey);
114
- expiredRoundKeys.add(roundKey);
115
- }
137
+ return await this.kvStore.transactionAsync(async () => {
138
+ // Collect expired offenses and rounds
139
+ const expiredRoundKeys = new Set<string>();
140
+ const expiredOffenseKeys = new Set<string>();
141
+ for await (const [roundKey, offenseKey] of this.roundsOffenses.entriesAsync({
142
+ end: this.getRoundKey(expiredBefore),
143
+ })) {
144
+ expiredOffenseKeys.add(offenseKey);
145
+ expiredRoundKeys.add(roundKey);
146
+ }
116
147
 
117
- if (expiredOffenseKeys.size === 0 && expiredRoundKeys.size === 0) {
118
- return 0; // Nothing to clean up
119
- }
148
+ if (expiredOffenseKeys.size === 0 && expiredRoundKeys.size === 0) {
149
+ return 0; // Nothing to clean up
150
+ }
120
151
 
121
- // Remove expired stuff in a transaction
122
- await this.kvStore.transactionAsync(async () => {
123
152
  for (const key of expiredOffenseKeys) {
124
153
  this.log.trace(`Deleting offense ${key}`);
125
154
  await this.offenses.delete(key);
126
- await this.offensesSlashed.delete(key);
127
155
  }
128
156
  for (const roundKey of expiredRoundKeys) {
129
157
  this.log.trace(`Deleting round info for ${roundKey}`);
130
158
  await this.roundsOffenses.delete(roundKey);
131
159
  }
132
- });
133
160
 
134
- return expiredOffenseKeys.size;
161
+ return expiredOffenseKeys.size;
162
+ });
135
163
  }
136
164
 
137
165
  /** Generate a unique key for an offense */
package/src/watcher.ts CHANGED
@@ -5,6 +5,7 @@ import { OffenseType } from '@aztec/stdlib/slashing';
5
5
  import type { SlasherConfig } from './config.js';
6
6
 
7
7
  export const WANT_TO_SLASH_EVENT = 'want-to-slash' as const;
8
+ export const WANT_TO_CLEAR_SLASH_EVENT = 'want-to-clear-slash' as const;
8
9
 
9
10
  export interface WantToSlashArgs {
10
11
  validator: EthAddress;
@@ -13,9 +14,16 @@ export interface WantToSlashArgs {
13
14
  epochOrSlot: bigint; // Epoch number for epoch-based offenses, slot number for slot-based
14
15
  }
15
16
 
17
+ export interface WantToClearSlashArgs {
18
+ offenseType: OffenseType;
19
+ epochOrSlot: bigint; // Epoch number for epoch-based offenses, slot number for slot-based
20
+ validators?: EthAddress[];
21
+ }
22
+
16
23
  // Event map for specific, known events of a watcher
17
24
  export interface WatcherEventMap {
18
25
  [WANT_TO_SLASH_EVENT]: (args: WantToSlashArgs[]) => void;
26
+ [WANT_TO_CLEAR_SLASH_EVENT]: (args: WantToClearSlashArgs[]) => void;
19
27
  }
20
28
 
21
29
  export type WatcherEmitter = TypedEventEmitter<WatcherEventMap>;