@aztec/slasher 0.0.1-commit.86469d5 → 0.0.1-commit.8655d4a

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (92) hide show
  1. package/README.md +83 -76
  2. package/dest/config.d.ts +1 -1
  3. package/dest/config.d.ts.map +1 -1
  4. package/dest/config.js +41 -29
  5. package/dest/factory/create_facade.d.ts +3 -3
  6. package/dest/factory/create_facade.d.ts.map +1 -1
  7. package/dest/factory/create_facade.js +25 -2
  8. package/dest/factory/create_implementation.d.ts +6 -7
  9. package/dest/factory/create_implementation.d.ts.map +1 -1
  10. package/dest/factory/create_implementation.js +8 -56
  11. package/dest/factory/get_settings.d.ts +4 -4
  12. package/dest/factory/get_settings.d.ts.map +1 -1
  13. package/dest/factory/get_settings.js +3 -3
  14. package/dest/factory/index.d.ts +2 -2
  15. package/dest/factory/index.d.ts.map +1 -1
  16. package/dest/factory/index.js +1 -1
  17. package/dest/generated/slasher-defaults.d.ts +8 -6
  18. package/dest/generated/slasher-defaults.d.ts.map +1 -1
  19. package/dest/generated/slasher-defaults.js +7 -5
  20. package/dest/index.d.ts +6 -4
  21. package/dest/index.d.ts.map +1 -1
  22. package/dest/index.js +5 -3
  23. package/dest/null_slasher_client.d.ts +3 -4
  24. package/dest/null_slasher_client.d.ts.map +1 -1
  25. package/dest/null_slasher_client.js +1 -4
  26. package/dest/slash_offenses_collector.d.ts +10 -9
  27. package/dest/slash_offenses_collector.d.ts.map +1 -1
  28. package/dest/slash_offenses_collector.js +50 -34
  29. package/dest/slasher_client.d.ts +112 -0
  30. package/dest/slasher_client.d.ts.map +1 -0
  31. package/dest/{tally_slasher_client.js → slasher_client.js} +45 -45
  32. package/dest/slasher_client_facade.d.ts +6 -8
  33. package/dest/slasher_client_facade.d.ts.map +1 -1
  34. package/dest/slasher_client_facade.js +6 -9
  35. package/dest/slasher_client_interface.d.ts +7 -21
  36. package/dest/slasher_client_interface.d.ts.map +1 -1
  37. package/dest/slasher_client_interface.js +1 -4
  38. package/dest/stores/offenses_store.d.ts +12 -12
  39. package/dest/stores/offenses_store.d.ts.map +1 -1
  40. package/dest/stores/offenses_store.js +61 -38
  41. package/dest/watcher.d.ts +8 -1
  42. package/dest/watcher.d.ts.map +1 -1
  43. package/dest/watcher.js +1 -0
  44. package/dest/watchers/attestations_block_watcher.d.ts +26 -13
  45. package/dest/watchers/attestations_block_watcher.d.ts.map +1 -1
  46. package/dest/watchers/attestations_block_watcher.js +76 -61
  47. package/dest/watchers/attested_invalid_proposal_watcher.d.ts +42 -0
  48. package/dest/watchers/attested_invalid_proposal_watcher.d.ts.map +1 -0
  49. package/dest/watchers/attested_invalid_proposal_watcher.js +117 -0
  50. package/dest/watchers/broadcasted_invalid_checkpoint_proposal_watcher.d.ts +38 -0
  51. package/dest/watchers/broadcasted_invalid_checkpoint_proposal_watcher.d.ts.map +1 -0
  52. package/dest/watchers/broadcasted_invalid_checkpoint_proposal_watcher.js +138 -0
  53. package/dest/watchers/checkpoint_equivocation_watcher.d.ts +30 -0
  54. package/dest/watchers/checkpoint_equivocation_watcher.d.ts.map +1 -0
  55. package/dest/watchers/checkpoint_equivocation_watcher.js +69 -0
  56. package/dest/watchers/data_withholding_watcher.d.ts +63 -0
  57. package/dest/watchers/data_withholding_watcher.d.ts.map +1 -0
  58. package/dest/watchers/data_withholding_watcher.js +193 -0
  59. package/package.json +10 -10
  60. package/src/config.ts +48 -29
  61. package/src/factory/create_facade.ts +32 -4
  62. package/src/factory/create_implementation.ts +24 -105
  63. package/src/factory/get_settings.ts +8 -8
  64. package/src/factory/index.ts +1 -1
  65. package/src/generated/slasher-defaults.ts +7 -5
  66. package/src/index.ts +5 -3
  67. package/src/null_slasher_client.ts +2 -6
  68. package/src/slash_offenses_collector.ts +70 -36
  69. package/src/{tally_slasher_client.ts → slasher_client.ts} +63 -54
  70. package/src/slasher_client_facade.ts +6 -11
  71. package/src/slasher_client_interface.ts +6 -21
  72. package/src/stores/offenses_store.ts +73 -47
  73. package/src/watcher.ts +8 -0
  74. package/src/watchers/attestations_block_watcher.ts +88 -82
  75. package/src/watchers/attested_invalid_proposal_watcher.ts +168 -0
  76. package/src/watchers/broadcasted_invalid_checkpoint_proposal_watcher.ts +192 -0
  77. package/src/watchers/checkpoint_equivocation_watcher.ts +96 -0
  78. package/src/watchers/data_withholding_watcher.ts +225 -0
  79. package/dest/empire_slasher_client.d.ts +0 -190
  80. package/dest/empire_slasher_client.d.ts.map +0 -1
  81. package/dest/empire_slasher_client.js +0 -564
  82. package/dest/stores/payloads_store.d.ts +0 -29
  83. package/dest/stores/payloads_store.d.ts.map +0 -1
  84. package/dest/stores/payloads_store.js +0 -128
  85. package/dest/tally_slasher_client.d.ts +0 -125
  86. package/dest/tally_slasher_client.d.ts.map +0 -1
  87. package/dest/watchers/epoch_prune_watcher.d.ts +0 -38
  88. package/dest/watchers/epoch_prune_watcher.d.ts.map +0 -1
  89. package/dest/watchers/epoch_prune_watcher.js +0 -158
  90. package/src/empire_slasher_client.ts +0 -649
  91. package/src/stores/payloads_store.ts +0 -149
  92. package/src/watchers/epoch_prune_watcher.ts +0 -221
@@ -1,15 +1,27 @@
1
+ import type { SlotNumber } from '@aztec/foundation/branded-types';
1
2
  import { createLogger } from '@aztec/foundation/log';
3
+ import { SerialQueue } from '@aztec/foundation/queue';
2
4
  import type { Prettify } from '@aztec/foundation/types';
3
5
  import type { L1RollupConstants } from '@aztec/stdlib/epoch-helpers';
4
6
  import type { SlasherConfig } from '@aztec/stdlib/interfaces/server';
5
- import { type Offense, type OffenseIdentifier, getSlotForOffense } from '@aztec/stdlib/slashing';
7
+ import { type Offense, getOffenseTypeName, getSlotForOffense } from '@aztec/stdlib/slashing';
6
8
 
7
9
  import type { SlasherOffensesStore } from './stores/offenses_store.js';
8
- import { WANT_TO_SLASH_EVENT, type WantToSlashArgs, type Watcher } from './watcher.js';
10
+ import {
11
+ WANT_TO_CLEAR_SLASH_EVENT,
12
+ WANT_TO_SLASH_EVENT,
13
+ type WantToClearSlashArgs,
14
+ type WantToSlashArgs,
15
+ type Watcher,
16
+ } from './watcher.js';
9
17
 
10
18
  export type SlashOffensesCollectorConfig = Prettify<Pick<SlasherConfig, 'slashGracePeriodL2Slots'>>;
11
19
  export type SlashOffensesCollectorSettings = Prettify<
12
- Pick<L1RollupConstants, 'epochDuration'> & { slashingAmounts: [bigint, bigint, bigint] | undefined }
20
+ Pick<L1RollupConstants, 'epochDuration'> & {
21
+ slashingAmounts: [bigint, bigint, bigint] | undefined;
22
+ /** L2 slot at which the rollup was registered as canonical in the Registry. Used to anchor the slash grace period. */
23
+ rollupRegisteredAtL2Slot: SlotNumber;
24
+ }
13
25
  >;
14
26
 
15
27
  /**
@@ -19,6 +31,7 @@ export type SlashOffensesCollectorSettings = Prettify<
19
31
  */
20
32
  export class SlashOffensesCollector {
21
33
  private readonly unwatchCallbacks: (() => void)[] = [];
34
+ private readonly storeMutationQueue = new SerialQueue();
22
35
 
23
36
  constructor(
24
37
  private readonly config: SlashOffensesCollectorConfig,
@@ -30,28 +43,35 @@ export class SlashOffensesCollector {
30
43
 
31
44
  public start() {
32
45
  this.log.debug('Starting SlashOffensesCollector...');
46
+ this.storeMutationQueue.start();
33
47
 
34
- // Subscribe to watchers WANT_TO_SLASH_EVENT
48
+ // Subscribe to watcher slashing events.
35
49
  for (const watcher of this.watchers) {
36
50
  const wantToSlashCallback = (args: WantToSlashArgs[]) =>
37
- void this.handleWantToSlash(args).catch(err => this.log.error('Error handling wantToSlash', err));
51
+ this.enqueueStoreMutation('wantToSlash', () => this.handleWantToSlash(args));
38
52
  watcher.on(WANT_TO_SLASH_EVENT, wantToSlashCallback);
39
53
  this.unwatchCallbacks.push(() => watcher.removeListener(WANT_TO_SLASH_EVENT, wantToSlashCallback));
54
+
55
+ const wantToClearSlashCallback = (args: WantToClearSlashArgs[]) =>
56
+ this.enqueueStoreMutation('wantToClearSlash', () => this.handleWantToClearSlash(args));
57
+ watcher.on(WANT_TO_CLEAR_SLASH_EVENT, wantToClearSlashCallback);
58
+ this.unwatchCallbacks.push(() => watcher.removeListener(WANT_TO_CLEAR_SLASH_EVENT, wantToClearSlashCallback));
40
59
  }
41
60
 
42
61
  this.log.info('Started SlashOffensesCollector');
43
62
  return Promise.resolve();
44
63
  }
45
64
 
46
- public stop() {
65
+ public async stop() {
47
66
  this.log.debug('Stopping SlashOffensesCollector...');
48
67
 
49
68
  for (const unwatchCallback of this.unwatchCallbacks) {
50
69
  unwatchCallback();
51
70
  }
52
71
 
72
+ await this.storeMutationQueue.end();
73
+
53
74
  this.log.info('SlashOffensesCollector stopped');
54
- return Promise.resolve();
55
75
  }
56
76
 
57
77
  /**
@@ -61,36 +81,47 @@ export class SlashOffensesCollector {
61
81
  */
62
82
  public async handleWantToSlash(args: WantToSlashArgs[]) {
63
83
  for (const arg of args) {
64
- const pendingOffense: Offense = {
84
+ const offense: Offense = {
65
85
  validator: arg.validator,
66
86
  amount: arg.amount,
67
87
  offenseType: arg.offenseType,
68
88
  epochOrSlot: arg.epochOrSlot,
69
89
  };
70
90
 
71
- if (this.shouldSkipOffense(pendingOffense)) {
72
- this.log.verbose('Skipping offense during grace period', pendingOffense);
73
- continue;
74
- }
75
-
76
- if (await this.offensesStore.hasOffense(pendingOffense)) {
77
- this.log.debug('Skipping repeated offense', pendingOffense);
91
+ if (this.shouldSkipOffense(offense)) {
92
+ this.log.verbose('Skipping offense during grace period', this.getOffenseLogData(offense));
78
93
  continue;
79
94
  }
80
95
 
81
- if (this.settings.slashingAmounts) {
82
- const minSlash = this.settings.slashingAmounts[0];
83
- if (arg.amount < minSlash) {
84
- this.log.warn(`Offense amount ${arg.amount} is below minimum slashing amount ${minSlash}`);
96
+ const added = await this.offensesStore.addOffense(offense);
97
+ if (added) {
98
+ if (this.settings.slashingAmounts) {
99
+ const minSlash = this.settings.slashingAmounts[0];
100
+ if (arg.amount < minSlash) {
101
+ this.log.warn(
102
+ `Offense amount ${arg.amount} is below minimum slashing amount ${minSlash}`,
103
+ this.getOffenseLogData(offense),
104
+ );
105
+ }
85
106
  }
107
+
108
+ this.log.info(`Adding pending offense for validator ${arg.validator}`, this.getOffenseLogData(offense));
109
+ } else {
110
+ this.log.debug('Skipping repeated offense', this.getOffenseLogData(offense));
86
111
  }
112
+ }
113
+ }
87
114
 
88
- this.log.info(`Adding pending offense for validator ${arg.validator}`, {
89
- ...pendingOffense,
90
- epochOrSlot: pendingOffense.epochOrSlot.toString(),
91
- amount: pendingOffense.amount.toString(),
92
- });
93
- await this.offensesStore.addPendingOffense(pendingOffense);
115
+ public async handleWantToClearSlash(args: WantToClearSlashArgs[]) {
116
+ for (const arg of args) {
117
+ const cleared = await this.offensesStore.clearOffenses(arg);
118
+ if (cleared > 0) {
119
+ this.log.info(`Cleared ${cleared} pending offenses`, {
120
+ offenseType: getOffenseTypeName(arg.offenseType),
121
+ epochOrSlot: arg.epochOrSlot,
122
+ validators: arg.validators?.map(validator => validator.toString()),
123
+ });
124
+ }
94
125
  }
95
126
  }
96
127
 
@@ -105,18 +136,21 @@ export class SlashOffensesCollector {
105
136
  }
106
137
  }
107
138
 
108
- /**
109
- * Marks offenses as slashed (no longer pending)
110
- * @param offenses - The offenses to mark as slashed
111
- */
112
- public markAsSlashed(offenses: OffenseIdentifier[]) {
113
- this.log.verbose(`Marking offenses as slashed`, { offenses });
114
- return this.offensesStore.markAsSlashed(offenses);
115
- }
116
-
117
- /** Returns whether to skip an offense if it happened during the grace period at the beginning of the chain */
139
+ /** Returns whether to skip an offense if it happened during the grace period after the network upgrade */
118
140
  private shouldSkipOffense(offense: Offense): boolean {
119
141
  const offenseSlot = getSlotForOffense(offense, this.settings);
120
- return offenseSlot < this.config.slashGracePeriodL2Slots;
142
+ return offenseSlot < this.settings.rollupRegisteredAtL2Slot + this.config.slashGracePeriodL2Slots;
143
+ }
144
+
145
+ private getOffenseLogData(offense: Offense) {
146
+ return {
147
+ ...offense,
148
+ validator: offense.validator.toString(),
149
+ offenseType: getOffenseTypeName(offense.offenseType),
150
+ };
151
+ }
152
+
153
+ private enqueueStoreMutation(label: string, callback: () => Promise<void>) {
154
+ void this.storeMutationQueue.put(callback).catch(err => this.log.error(`Error handling ${label}`, err));
121
155
  }
122
156
  }
@@ -1,6 +1,6 @@
1
1
  import { EthAddress } from '@aztec/aztec.js/addresses';
2
2
  import type { EpochCache } from '@aztec/epoch-cache';
3
- import { RollupContract, SlasherContract, TallySlashingProposerContract } from '@aztec/ethereum/contracts';
3
+ import { RollupContract, SlasherContract, SlashingProposerContract } from '@aztec/ethereum/contracts';
4
4
  import { maxBigint } from '@aztec/foundation/bigint';
5
5
  import { SlotNumber } from '@aztec/foundation/branded-types';
6
6
  import { compactArray, partition, times } from '@aztec/foundation/collection';
@@ -13,8 +13,8 @@ import {
13
13
  OffenseType,
14
14
  type ProposerSlashAction,
15
15
  type ProposerSlashActionProvider,
16
- type SlashPayloadRound,
17
16
  getEpochsForRound,
17
+ getOffenseTypeName,
18
18
  getSlashConsensusVotesFromOffenses,
19
19
  } from '@aztec/stdlib/slashing';
20
20
 
@@ -30,8 +30,8 @@ import type { SlasherClientInterface } from './slasher_client_interface.js';
30
30
  import type { SlasherOffensesStore } from './stores/offenses_store.js';
31
31
  import type { Watcher } from './watcher.js';
32
32
 
33
- /** Settings used in the tally slasher client, loaded from the L1 contracts during initialization */
34
- export type TallySlasherSettings = Prettify<
33
+ /** Settings used in the slasher client, loaded from the L1 contracts during initialization */
34
+ export type SlasherSettings = Prettify<
35
35
  SlashRoundMonitorSettings &
36
36
  SlashOffensesCollectorSettings & {
37
37
  slashingLifetimeInRounds: number;
@@ -45,11 +45,22 @@ export type TallySlasherSettings = Prettify<
45
45
  }
46
46
  >;
47
47
 
48
- export type TallySlasherClientConfig = SlashOffensesCollectorConfig &
49
- Pick<SlasherConfig, 'slashValidatorsAlways' | 'slashValidatorsNever' | 'slashExecuteRoundsLookBack'>;
48
+ export type SlasherClientConfig = SlashOffensesCollectorConfig &
49
+ Pick<
50
+ SlasherConfig,
51
+ 'slashValidatorsAlways' | 'slashValidatorsNever' | 'slashExecuteRoundsLookBack' | 'slashMaxPayloadSize'
52
+ >;
53
+
54
+ type AlwaysSlashOffense = {
55
+ validator: EthAddress;
56
+ amount: bigint;
57
+ offenseType: OffenseType.UNKNOWN;
58
+ };
59
+
60
+ type SlashVoteOffense = Offense | AlwaysSlashOffense;
50
61
 
51
62
  /**
52
- * The Tally Slasher client is responsible for managing slashable offenses using
63
+ * The Slasher client is responsible for managing slashable offenses using
53
64
  * the consensus-based slashing model where proposers vote on individual validator offenses.
54
65
  *
55
66
  * The client subscribes to several slash watchers that emit offenses and tracks them. When the slasher is the
@@ -73,22 +84,16 @@ export type TallySlasherClientConfig = SlashOffensesCollectorConfig &
73
84
  * - Validators that reach the quorum threshold are slashed. A vote for slashing N units is also considered
74
85
  * a vote for slashing N-1, N-2, ..., 1 units. The system slashes for the largest amount that reaches quorum.
75
86
  * - The client monitors executable rounds and triggers execution when appropriate.
76
- *
77
- * Differences from Empire model
78
- * - No fixed slash payloads - votes are for individual validator offenses encoded in bytes
79
- * - The L1 contract determines which offenses reach quorum rather than nodes agreeing on a payload
80
- * - Proposers vote directly on which validators to slash and by how much
81
- * - Uses a slash offset to vote on validators from past rounds (e.g., round N votes on round N-2)
82
87
  */
83
- export class TallySlasherClient implements ProposerSlashActionProvider, SlasherClientInterface {
88
+ export class SlasherClient implements ProposerSlashActionProvider, SlasherClientInterface {
84
89
  protected unwatchCallbacks: (() => void)[] = [];
85
90
  protected roundMonitor: SlashRoundMonitor;
86
91
  protected offensesCollector: SlashOffensesCollector;
87
92
 
88
93
  constructor(
89
- private config: TallySlasherClientConfig,
90
- private settings: TallySlasherSettings,
91
- private tallySlashingProposer: TallySlashingProposerContract,
94
+ private config: SlasherClientConfig,
95
+ private settings: SlasherSettings,
96
+ private slashingProposer: SlashingProposerContract,
92
97
  private slasher: SlasherContract,
93
98
  private rollup: RollupContract,
94
99
  watchers: Watcher[],
@@ -102,14 +107,14 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
102
107
  }
103
108
 
104
109
  public async start() {
105
- this.log.debug('Starting Tally Slasher client...');
110
+ this.log.debug('Starting slasher client...');
106
111
 
107
112
  this.roundMonitor.start();
108
113
  await this.offensesCollector.start();
109
114
 
110
115
  // Listen for RoundExecuted events
111
116
  this.unwatchCallbacks.push(
112
- this.tallySlashingProposer.listenToRoundExecuted(
117
+ this.slashingProposer.listenToRoundExecuted(
113
118
  ({ round, slashCount, l1BlockHash }) =>
114
119
  void this.handleRoundExecuted(round, slashCount, l1BlockHash).catch(err =>
115
120
  this.log.error('Error handling round executed', err),
@@ -120,15 +125,13 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
120
125
  // Check for round changes
121
126
  this.unwatchCallbacks.push(this.roundMonitor.listenToNewRound(round => this.handleNewRound(round)));
122
127
 
123
- this.log.info(`Started tally slasher client`);
128
+ this.log.info(`Started slasher client`);
124
129
  return Promise.resolve();
125
130
  }
126
131
 
127
- /**
128
- * Stop the tally slasher client
129
- */
132
+ /** Stop the slasher client */
130
133
  public async stop() {
131
- this.log.debug('Stopping Tally Slasher client...');
134
+ this.log.debug('Stopping slasher client...');
132
135
 
133
136
  for (const unwatchCallback of this.unwatchCallbacks) {
134
137
  unwatchCallback();
@@ -137,7 +140,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
137
140
  this.roundMonitor.stop();
138
141
  await this.offensesCollector.stop();
139
142
 
140
- this.log.info('Tally Slasher client stopped');
143
+ this.log.info('Slasher client stopped');
141
144
  }
142
145
 
143
146
  /** Returns the current config */
@@ -152,11 +155,11 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
152
155
 
153
156
  /** Triggered on a time basis when we enter a new slashing round. Clears expired offenses. */
154
157
  protected async handleNewRound(round: bigint) {
155
- this.log.info(`Starting new tally slashing round ${round}`);
158
+ this.log.info(`Starting new slashing round ${round}`);
156
159
  await this.offensesCollector.handleNewRound(round);
157
160
  }
158
161
 
159
- /** Called when we see a RoundExecuted event on the TallySlashingProposer (just for logging). */
162
+ /** Called when we see a RoundExecuted event on the SlashingProposer (just for logging). */
160
163
  protected async handleRoundExecuted(round: bigint, slashCount: bigint, l1BlockHash: Hex) {
161
164
  const slashes = await this.rollup.getSlashEvents(l1BlockHash);
162
165
  this.log.info(`Slashing round ${round} has been executed with ${slashCount} slashes`, { slashes });
@@ -237,7 +240,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
237
240
  this.log.debug(`Testing if slashing round ${executableRound} is executable`, logData);
238
241
 
239
242
  try {
240
- const roundInfo = await this.tallySlashingProposer.getRound(executableRound);
243
+ const roundInfo = await this.slashingProposer.getRound(executableRound);
241
244
  logData = { ...logData, roundInfo };
242
245
  if (roundInfo.isExecuted) {
243
246
  this.log.verbose(`Round ${executableRound} has already been executed`, logData);
@@ -251,7 +254,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
251
254
  }
252
255
 
253
256
  // Check if round is ready to execute at the given slot
254
- const isReadyToExecute = await this.tallySlashingProposer.isRoundReadyToExecute(executableRound, slotNumber);
257
+ const isReadyToExecute = await this.slashingProposer.isRoundReadyToExecute(executableRound, slotNumber);
255
258
  if (!isReadyToExecute) {
256
259
  this.log.warn(
257
260
  `Round ${executableRound} is not ready to execute at slot ${slotNumber} according to contract check`,
@@ -261,14 +264,14 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
261
264
  }
262
265
 
263
266
  // Check if the round yields any slashing at all
264
- const { actions: slashActions, committees } = await this.tallySlashingProposer.getTally(executableRound);
267
+ const { actions: slashActions, committees } = await this.slashingProposer.getTally(executableRound);
265
268
  if (slashActions.length === 0) {
266
269
  this.log.verbose(`Round ${executableRound} does not resolve in any slashing`, logData);
267
270
  return undefined;
268
271
  }
269
272
 
270
273
  // Check if the slash payload is vetoed
271
- const payload = await this.tallySlashingProposer.getPayload(executableRound);
274
+ const payload = await this.slashingProposer.getPayload(executableRound);
272
275
  const isVetoed = await this.slasher.isPayloadVetoed(payload.address);
273
276
  if (isVetoed) {
274
277
  this.log.warn(`Round ${executableRound} payload is vetoed (skipping execution)`, {
@@ -315,7 +318,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
315
318
  // Compute offenses to slash, by loading the offenses for this round, adding synthetic offenses
316
319
  // for validators that should always be slashed, and removing the ones that should never be slashed.
317
320
  const offensesForRound = await this.gatherOffensesForRound(currentRound);
318
- const offensesFromAlwaysSlash = (this.config.slashValidatorsAlways ?? []).map(validator => ({
321
+ const offensesFromAlwaysSlash: AlwaysSlashOffense[] = (this.config.slashValidatorsAlways ?? []).map(validator => ({
319
322
  validator,
320
323
  amount: this.settings.slashingAmounts[2],
321
324
  offenseType: OffenseType.UNKNOWN,
@@ -329,7 +332,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
329
332
  slotNumber,
330
333
  currentRound,
331
334
  slashedRound,
332
- offensesToForgive,
335
+ offensesFromAlwaysSlash: offensesFromAlwaysSlash.map(getOffenseLogData),
333
336
  slashValidatorsAlways: this.config.slashValidatorsAlways,
334
337
  });
335
338
  }
@@ -339,7 +342,7 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
339
342
  slotNumber,
340
343
  currentRound,
341
344
  slashedRound,
342
- offensesToForgive,
345
+ offensesToForgive: offensesToForgive.map(getOffenseLogData),
343
346
  slashValidatorsNever: this.config.slashValidatorsNever,
344
347
  });
345
348
  }
@@ -349,36 +352,42 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
349
352
  return undefined;
350
353
  }
351
354
 
352
- const offensesToSlashLog = offensesToSlash.map(offense => ({
353
- ...offense,
354
- amount: offense.amount.toString(),
355
- }));
356
- this.log.info(`Voting to slash ${offensesToSlash.length} offenses`, {
355
+ this.log.debug(`Computing slash votes for ${offensesToSlash.length} offenses`, {
357
356
  slotNumber,
358
357
  currentRound,
359
358
  slashedRound,
360
- offensesToSlash: offensesToSlashLog,
359
+ offensesToSlash: offensesToSlash.map(getOffenseLogData),
361
360
  });
362
361
 
363
362
  const committees = await this.collectCommitteesActiveDuringRound(slashedRound);
364
363
  const epochsForCommittees = getEpochsForRound(slashedRound, this.settings);
364
+ const { slashMaxPayloadSize } = this.config;
365
365
  const votes = getSlashConsensusVotesFromOffenses(
366
366
  offensesToSlash,
367
367
  committees,
368
368
  epochsForCommittees.map(e => BigInt(e)),
369
- this.settings,
369
+ { ...this.settings, maxSlashedValidators: slashMaxPayloadSize },
370
+ this.log,
370
371
  );
371
372
  if (votes.every(v => v === 0)) {
372
373
  this.log.warn(`Computed votes for offenses are all zero. Skipping vote.`, {
373
374
  slotNumber,
374
375
  currentRound,
375
376
  slashedRound,
376
- offensesToSlash,
377
+ offensesToSlash: offensesToSlash.map(getOffenseLogData),
377
378
  committees,
378
379
  });
379
380
  return undefined;
380
381
  }
381
382
 
383
+ this.log.info(`Voting to slash ${offensesToSlash.length} offenses`, {
384
+ slotNumber,
385
+ slashedRound,
386
+ currentRound,
387
+ votes,
388
+ offensesToSlash: offensesToSlash.map(getOffenseLogData),
389
+ });
390
+
382
391
  this.log.debug(`Computed votes for slashing ${offensesToSlash.length} offenses`, {
383
392
  slashedRound,
384
393
  currentRound,
@@ -404,17 +413,9 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
404
413
  );
405
414
  }
406
415
 
407
- /**
408
- * Get slash payloads is NOT SUPPORTED in tally model
409
- * @throws Error indicating this operation is not supported
410
- */
411
- public getSlashPayloads(): Promise<SlashPayloadRound[]> {
412
- return Promise.reject(new Error('Tally slashing model does not support slash payloads'));
413
- }
414
-
415
416
  /**
416
417
  * Gather offenses to be slashed on a given round.
417
- * In tally slashing, round N slashes validators from round N - slashOffsetInRounds.
418
+ * Round N slashes validators from round N - slashOffsetInRounds.
418
419
  * @param round - The round to get offenses for, defaults to current round
419
420
  * @returns Array of pending offenses for the round with offset applied
420
421
  */
@@ -427,9 +428,9 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
427
428
  return await this.offensesStore.getOffensesForRound(targetRound);
428
429
  }
429
430
 
430
- /** Returns all pending offenses stored */
431
- public getPendingOffenses(): Promise<Offense[]> {
432
- return this.offensesStore.getPendingOffenses();
431
+ /** Returns all offenses stored */
432
+ public getOffenses(): Promise<Offense[]> {
433
+ return this.offensesStore.getOffenses();
433
434
  }
434
435
 
435
436
  /**
@@ -445,3 +446,11 @@ export class TallySlasherClient implements ProposerSlashActionProvider, SlasherC
445
446
  return round - BigInt(this.settings.slashingOffsetInRounds);
446
447
  }
447
448
  }
449
+
450
+ function getOffenseLogData(offense: SlashVoteOffense) {
451
+ return {
452
+ ...offense,
453
+ validator: offense.validator.toString(),
454
+ offenseType: getOffenseTypeName(offense.offenseType),
455
+ };
456
+ }
@@ -2,13 +2,12 @@ import { EpochCache } from '@aztec/epoch-cache';
2
2
  import { RollupContract } from '@aztec/ethereum/contracts';
3
3
  import type { ViemClient } from '@aztec/ethereum/types';
4
4
  import type { SlotNumber } from '@aztec/foundation/branded-types';
5
- import { EthAddress } from '@aztec/foundation/eth-address';
6
5
  import { createLogger } from '@aztec/foundation/log';
7
6
  import { DateProvider } from '@aztec/foundation/timer';
8
- import type { DataStoreConfig } from '@aztec/kv-store/config';
9
7
  import { AztecLMDBStoreV2 } from '@aztec/kv-store/lmdb-v2';
10
8
  import type { SlasherConfig } from '@aztec/stdlib/interfaces/server';
11
- import type { Offense, ProposerSlashAction, SlashPayloadRound } from '@aztec/stdlib/slashing';
9
+ import type { DataStoreConfig } from '@aztec/stdlib/kv-store';
10
+ import type { Offense, ProposerSlashAction } from '@aztec/stdlib/slashing';
12
11
 
13
12
  import { createSlasherImplementation } from './factory/create_implementation.js';
14
13
  import type { SlasherClientInterface } from './slasher_client_interface.js';
@@ -27,11 +26,11 @@ export class SlasherClientFacade implements SlasherClientInterface {
27
26
  private config: SlasherConfig & DataStoreConfig & { ethereumSlotDuration: number },
28
27
  private rollup: RollupContract,
29
28
  private l1Client: ViemClient,
30
- private slashFactoryAddress: EthAddress | undefined,
31
29
  private watchers: Watcher[],
32
30
  private epochCache: EpochCache,
33
31
  private dateProvider: DateProvider,
34
32
  private kvStore: AztecLMDBStoreV2,
33
+ private rollupRegisteredAtL2Slot: SlotNumber,
35
34
  private logger = createLogger('slasher'),
36
35
  ) {}
37
36
 
@@ -62,16 +61,12 @@ export class SlasherClientFacade implements SlasherClientInterface {
62
61
  this.watchers.forEach(watcher => watcher.updateConfig?.(config));
63
62
  }
64
63
 
65
- public getSlashPayloads(): Promise<SlashPayloadRound[]> {
66
- return this.client?.getSlashPayloads() ?? Promise.reject(new Error('Slasher client not initialized'));
67
- }
68
-
69
64
  public gatherOffensesForRound(round?: bigint): Promise<Offense[]> {
70
65
  return this.client?.gatherOffensesForRound(round) ?? Promise.reject(new Error('Slasher client not initialized'));
71
66
  }
72
67
 
73
- public getPendingOffenses(): Promise<Offense[]> {
74
- return this.client?.getPendingOffenses() ?? Promise.reject(new Error('Slasher client not initialized'));
68
+ public getOffenses(): Promise<Offense[]> {
69
+ return this.client?.getOffenses() ?? Promise.reject(new Error('Slasher client not initialized'));
75
70
  }
76
71
 
77
72
  public getProposerActions(slotNumber: SlotNumber): Promise<ProposerSlashAction[]> {
@@ -83,11 +78,11 @@ export class SlasherClientFacade implements SlasherClientInterface {
83
78
  this.config,
84
79
  this.rollup,
85
80
  this.l1Client,
86
- this.slashFactoryAddress,
87
81
  this.watchers,
88
82
  this.epochCache,
89
83
  this.dateProvider,
90
84
  this.kvStore,
85
+ this.rollupRegisteredAtL2Slot,
91
86
  this.logger,
92
87
  );
93
88
  }
@@ -1,11 +1,8 @@
1
1
  import type { SlotNumber } from '@aztec/foundation/branded-types';
2
2
  import type { SlasherConfig } from '@aztec/stdlib/interfaces/server';
3
- import type { Offense, ProposerSlashAction, SlashPayloadRound } from '@aztec/stdlib/slashing';
3
+ import type { Offense, ProposerSlashAction } from '@aztec/stdlib/slashing';
4
4
 
5
- /**
6
- * Common interface for slasher clients used by the Aztec node.
7
- * Both Empire and Consensus slasher clients implement this interface.
8
- */
5
+ /** Common interface for slasher clients used by the Aztec node. */
9
6
  export interface SlasherClientInterface {
10
7
  /** Start the slasher client */
11
8
  start(): Promise<void>;
@@ -13,25 +10,13 @@ export interface SlasherClientInterface {
13
10
  /** Stop the slasher client */
14
11
  stop(): Promise<void>;
15
12
 
16
- /**
17
- * Get slash payloads for the Empire model.
18
- * The Consensus model should throw an error when this is called.
19
- */
20
- getSlashPayloads(): Promise<SlashPayloadRound[]>;
21
-
22
- /**
23
- * Gather offenses for a given round, defaults to current.
24
- * Used by both Empire and Consensus models.
25
- */
13
+ /** Gather offenses for a given round, defaults to current. */
26
14
  gatherOffensesForRound(round?: bigint): Promise<Offense[]>;
27
15
 
28
- /** Returns all pending offenses */
29
- getPendingOffenses(): Promise<Offense[]>;
16
+ /** Returns all offenses */
17
+ getOffenses(): Promise<Offense[]>;
30
18
 
31
- /**
32
- * Update the configuration.
33
- * Used by both Empire and Consensus models.
34
- */
19
+ /** Update the configuration. */
35
20
  updateConfig(config: Partial<SlasherConfig>): void;
36
21
 
37
22
  /**