@aztec/simulator 0.82.0 → 0.82.1

package/dest/public/public_tx_simulator/public_tx_context.js

@@ -14,7 +14,7 @@ import { inspect } from 'util';
 import { AvmPersistableStateManager } from '../avm/index.js';
 import { HintingPublicContractsDB } from '../hinting_db_sources.js';
 import { SideEffectArrayLengths, SideEffectTrace } from '../side_effect_trace.js';
-import { getCallRequestsByPhase, getExecutionRequestsByPhase } from '../utils.js';
+import { getCallRequestsWithCalldataByPhase } from '../utils.js';
 /**
  * The transaction-level context for public execution.
  */ export class PublicTxContext {
@@ -28,9 +28,6 @@ import { getCallRequestsByPhase, getExecutionRequestsByPhase } from '../utils.js
     setupCallRequests;
     appLogicCallRequests;
     teardownCallRequests;
-    setupExecutionRequests;
-    appLogicExecutionRequests;
-    teardownExecutionRequests;
     nonRevertibleAccumulatedDataFromPrivate;
     revertibleAccumulatedDataFromPrivate;
     feePayer;
@@ -42,7 +39,7 @@ import { getCallRequestsByPhase, getExecutionRequestsByPhase } from '../utils.js
     /* Entire transaction execution is done. */ halted;
     /* Where did reverts happen (if at all)? */ revertCode;
     /* What caused a revert (if one occurred)? */ revertReason;
-    constructor(txHash, state, globalVariables, startStateReference, gasSettings, gasUsedByPrivate, gasAllocatedToPublic, setupCallRequests, appLogicCallRequests, teardownCallRequests, setupExecutionRequests, appLogicExecutionRequests, teardownExecutionRequests, nonRevertibleAccumulatedDataFromPrivate, revertibleAccumulatedDataFromPrivate, feePayer, trace, hints){
+    constructor(txHash, state, globalVariables, startStateReference, gasSettings, gasUsedByPrivate, gasAllocatedToPublic, setupCallRequests, appLogicCallRequests, teardownCallRequests, nonRevertibleAccumulatedDataFromPrivate, revertibleAccumulatedDataFromPrivate, feePayer, trace, hints){
         this.txHash = txHash;
         this.state = state;
         this.globalVariables = globalVariables;
@@ -53,9 +50,6 @@ import { getCallRequestsByPhase, getExecutionRequestsByPhase } from '../utils.js
         this.setupCallRequests = setupCallRequests;
         this.appLogicCallRequests = appLogicCallRequests;
         this.teardownCallRequests = teardownCallRequests;
-        this.setupExecutionRequests = setupExecutionRequests;
-        this.appLogicExecutionRequests = appLogicExecutionRequests;
-        this.teardownExecutionRequests = teardownExecutionRequests;
         this.nonRevertibleAccumulatedDataFromPrivate = nonRevertibleAccumulatedDataFromPrivate;
         this.revertibleAccumulatedDataFromPrivate = revertibleAccumulatedDataFromPrivate;
         this.feePayer = feePayer;
@@ -82,7 +76,7 @@ import { getCallRequestsByPhase, getExecutionRequestsByPhase } from '../utils.js
         const gasUsedByPrivate = tx.data.gasUsed;
         // Gas allocated to public is "whatever's left" after private, but with some max applied.
         const gasAllocatedToPublic = applyMaxToAvailableGas(gasSettings.gasLimits.sub(gasUsedByPrivate));
-        return new PublicTxContext(await tx.getTxHash(), new PhaseStateManager(txStateManager), globalVariables, await treesDB.getStateReference(), gasSettings, gasUsedByPrivate, gasAllocatedToPublic, getCallRequestsByPhase(tx, TxExecutionPhase.SETUP), getCallRequestsByPhase(tx, TxExecutionPhase.APP_LOGIC), getCallRequestsByPhase(tx, TxExecutionPhase.TEARDOWN), getExecutionRequestsByPhase(tx, TxExecutionPhase.SETUP), getExecutionRequestsByPhase(tx, TxExecutionPhase.APP_LOGIC), getExecutionRequestsByPhase(tx, TxExecutionPhase.TEARDOWN), tx.data.forPublic.nonRevertibleAccumulatedData, tx.data.forPublic.revertibleAccumulatedData, tx.data.feePayer, trace, hints);
+        return new PublicTxContext(await tx.getTxHash(), new PhaseStateManager(txStateManager), globalVariables, await treesDB.getStateReference(), gasSettings, gasUsedByPrivate, gasAllocatedToPublic, getCallRequestsWithCalldataByPhase(tx, TxExecutionPhase.SETUP), getCallRequestsWithCalldataByPhase(tx, TxExecutionPhase.APP_LOGIC), getCallRequestsWithCalldataByPhase(tx, TxExecutionPhase.TEARDOWN), tx.data.forPublic.nonRevertibleAccumulatedData, tx.data.forPublic.revertibleAccumulatedData, tx.data.feePayer, trace, hints);
     }
     /**
    * Signal that the entire transaction execution is done.
@@ -154,18 +148,6 @@ import { getCallRequestsByPhase, getExecutionRequestsByPhase } from '../utils.js
         }
     }
     /**
-   * Get the call requests for the specified phase (including actual args).
-   */ getExecutionRequestsForPhase(phase) {
-        switch(phase){
-            case TxExecutionPhase.SETUP:
-                return this.setupExecutionRequests;
-            case TxExecutionPhase.APP_LOGIC:
-                return this.appLogicExecutionRequests;
-            case TxExecutionPhase.TEARDOWN:
-                return this.teardownExecutionRequests;
-        }
-    }
-    /**
    * How much gas is left as of the specified phase?
    */ getGasLeftAtPhase(phase) {
         if (phase === TxExecutionPhase.TEARDOWN) {
@@ -239,7 +221,7 @@ import { getCallRequestsByPhase, getExecutionRequestsByPhase } from '../utils.js
         const startTreeSnapshots = new TreeSnapshots(this.startStateReference.l1ToL2MessageTree, this.startStateReference.partial.noteHashTree, this.startStateReference.partial.nullifierTree, this.startStateReference.partial.publicDataTree);
         // Will be patched/padded at the end of this fn
         const endTreeSnapshots = new TreeSnapshots(endStateReference.l1ToL2MessageTree, endStateReference.partial.noteHashTree, endStateReference.partial.nullifierTree, endStateReference.partial.publicDataTree);
-        const avmCircuitPublicInputs = this.trace.toAvmCircuitPublicInputs(this.globalVariables, startTreeSnapshots, /*startGasUsed=*/ this.gasUsedByPrivate, this.gasSettings, this.feePayer, this.setupCallRequests, this.appLogicCallRequests, /*teardownCallRequest=*/ this.teardownCallRequests.length ? this.teardownCallRequests[0] : PublicCallRequest.empty(), endTreeSnapshots, /*endGasUsed=*/ this.getTotalGasUsed(), /*transactionFee=*/ this.getTransactionFeeUnsafe(), /*reverted=*/ !this.revertCode.isOK());
+        const avmCircuitPublicInputs = this.trace.toAvmCircuitPublicInputs(this.globalVariables, startTreeSnapshots, /*startGasUsed=*/ this.gasUsedByPrivate, this.gasSettings, this.feePayer, this.setupCallRequests.map((r)=>r.request), this.appLogicCallRequests.map((r)=>r.request), /*teardownCallRequest=*/ this.teardownCallRequests.length ? this.teardownCallRequests[0].request : PublicCallRequest.empty(), endTreeSnapshots, /*endGasUsed=*/ this.getTotalGasUsed(), /*transactionFee=*/ this.getTransactionFeeUnsafe(), /*reverted=*/ !this.revertCode.isOK());
         const getArrayLengths = (from)=>new PrivateToAvmAccumulatedDataArrayLengths(countAccumulatedItems(from.noteHashes), countAccumulatedItems(from.nullifiers), countAccumulatedItems(from.l2ToL1Msgs));
         const convertAccumulatedData = (from)=>new PrivateToAvmAccumulatedData(from.noteHashes, from.nullifiers, from.l2ToL1Msgs);
         // Temporary overrides as these entries aren't yet populated in trace

package/dest/public/public_tx_simulator/public_tx_simulator.d.ts

@@ -67,8 +67,7 @@ export declare class PublicTxSimulator {
      * Simulate an enqueued public call.
      * @param phase - The current phase of public execution
      * @param context - WILL BE MUTATED. The context of the currently executing public transaction portion
-     * @param callRequest - The enqueued call to execute
-     * @param executionRequest - The execution request (includes args)
+     * @param callRequest - The public function call request, including the calldata.
      * @returns The result of execution.
      */
     private simulateEnqueuedCall;
@@ -81,7 +80,7 @@ export declare class PublicTxSimulator {
      *
      * @param stateManager - The state manager for AvmSimulation
      * @param context - The context of the currently executing public transaction portion
-     * @param executionRequest - The execution request (includes args)
+     * @param callRequest - The public function call request, including the calldata.
      * @param allocatedGas - The gas allocated to the enqueued call
      * @param fnName - The name of the function
      * @returns The result of execution.

package/dest/public/public_tx_simulator/public_tx_simulator.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"public_tx_simulator.d.ts","sourceRoot":"","sources":["../../../src/public/public_tx_simulator/public_tx_simulator.ts"],"names":[],"mappings":"AAKA,OAAO,EAKL,KAAK,iBAAiB,EACtB,KAAK,UAAU,EAChB,MAAM,mBAAmB,CAAC;AAC3B,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAC;AACvD,OAAO,KAAK,EAAO,OAAO,EAAE,MAAM,mBAAmB,CAAC;AAItD,OAAO,EACL,KAAK,eAAe,EACpB,yBAAyB,EAEzB,EAAE,EACF,gBAAgB,EACjB,MAAM,kBAAkB,CAAC;AAC1B,OAAO,EAAc,KAAK,eAAe,EAAE,KAAK,MAAM,EAAiC,MAAM,yBAAyB,CAAC;AAQvH,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AACzD,OAAO,KAAK,EAAE,iBAAiB,EAAE,aAAa,EAAE,MAAM,yBAAyB,CAAC;AAChF,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AAEzD,MAAM,MAAM,cAAc,GAAG;IAC3B,KAAK,EAAE,gBAAgB,CAAC;IACxB,UAAU,EAAE,MAAM,CAAC;IACnB,YAAY,EAAE,yBAAyB,EAAE,CAAC;IAC1C,QAAQ,EAAE,OAAO,CAAC;IAClB,YAAY,CAAC,EAAE,eAAe,CAAC;CAChC,CAAC;AAEF,MAAM,MAAM,cAAc,GAAG;IAC3B,iBAAiB,EAAE,iBAAiB,CAAC;IACrC,+CAA+C;IAC/C,OAAO,EAAE,OAAO,CAAC;IACjB,UAAU,EAAE,UAAU,CAAC;IACvB,4BAA4B;IAC5B,YAAY,CAAC,EAAE,eAAe,CAAC;IAC/B,eAAe,EAAE,cAAc,EAAE,CAAC;CACnC,CAAC;AAEF,qBAAa,iBAAiB;IAM1B,OAAO,CAAC,OAAO;IACf,OAAO,CAAC,WAAW;IACnB,OAAO,CAAC,eAAe;IACvB,OAAO,CAAC,kBAAkB;IAC1B,OAAO,CAAC,kBAAkB;IAT5B,OAAO,EAAE,eAAe,CAAC;IAEzB,OAAO,CAAC,GAAG,CAAS;gBAGV,OAAO,EAAE,aAAa,EACtB,WAAW,EAAE,iBAAiB,EAC9B,eAAe,EAAE,eAAe,EAChC,kBAAkB,GAAE,OAAe,EACnC,kBAAkB,GAAE,OAAe,EAC3C,eAAe,GAAE,eAAsC;IAMzD,IAAI,MAAM,IAAI,MAAM,CAEnB;IACD;;;;OAIG;IACU,QAAQ,CAAC,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC,cAAc,CAAC;IAyFtD;;;;OAIG;YACW,kBAAkB;IAIhC;;;;OAIG;YACW,qBAAqB;IAkBnC;;;;OAIG;YACW,qBAAqB;IAoBnC;;;;;OAKG;YACW,aAAa;IA0C3B;;;;;;;OAOG;YAOW,oBAAoB;IA+ClC;;;;;;;;;;;;;OAaG;YAOW,4BAA4B;IAgD1C;;OAEG;IACU,+BAA+B,CAAC,OAAO,EAAE,eAAe;IAkBrE;;;OAGG;IACU,4BAA4B,CAAC,OAAO,EAAE,eAAe,GAAgB,OAAO,CAAC,OAAO,CAAC;YA+BpF,MAAM;IAgCpB;;OAEG;IACH,OAAO,CAAC,MAAM,CAAC,sBAAsB;CAStC"}
+{"version":3,"file":"public_tx_simulator.d.ts","sourceRoot":"","sources":["../../../src/public/public_tx_simulator/public_tx_simulator.ts"],"names":[],"mappings":"AAKA,OAAO,EAKL,KAAK,iBAAiB,EACtB,KAAK,UAAU,EAChB,MAAM,mBAAmB,CAAC;AAC3B,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAC;AACvD,OAAO,KAAK,EAAO,OAAO,EAAE,MAAM,mBAAmB,CAAC;AAGtD,OAAO,EACL,KAAK,eAAe,EACpB,yBAAyB,EAEzB,EAAE,EACF,gBAAgB,EACjB,MAAM,kBAAkB,CAAC;AAC1B,OAAO,EAAc,KAAK,eAAe,EAAE,KAAK,MAAM,EAAiC,MAAM,yBAAyB,CAAC;AAQvH,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AACzD,OAAO,KAAK,EAAE,iBAAiB,EAAE,aAAa,EAAE,MAAM,yBAAyB,CAAC;AAChF,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AAEzD,MAAM,MAAM,cAAc,GAAG;IAC3B,KAAK,EAAE,gBAAgB,CAAC;IACxB,UAAU,EAAE,MAAM,CAAC;IACnB,YAAY,EAAE,yBAAyB,EAAE,CAAC;IAC1C,QAAQ,EAAE,OAAO,CAAC;IAClB,YAAY,CAAC,EAAE,eAAe,CAAC;CAChC,CAAC;AAEF,MAAM,MAAM,cAAc,GAAG;IAC3B,iBAAiB,EAAE,iBAAiB,CAAC;IACrC,+CAA+C;IAC/C,OAAO,EAAE,OAAO,CAAC;IACjB,UAAU,EAAE,UAAU,CAAC;IACvB,4BAA4B;IAC5B,YAAY,CAAC,EAAE,eAAe,CAAC;IAC/B,eAAe,EAAE,cAAc,EAAE,CAAC;CACnC,CAAC;AAEF,qBAAa,iBAAiB;IAM1B,OAAO,CAAC,OAAO;IACf,OAAO,CAAC,WAAW;IACnB,OAAO,CAAC,eAAe;IACvB,OAAO,CAAC,kBAAkB;IAC1B,OAAO,CAAC,kBAAkB;IAT5B,OAAO,EAAE,eAAe,CAAC;IAEzB,OAAO,CAAC,GAAG,CAAS;gBAGV,OAAO,EAAE,aAAa,EACtB,WAAW,EAAE,iBAAiB,EAC9B,eAAe,EAAE,eAAe,EAChC,kBAAkB,GAAE,OAAe,EACnC,kBAAkB,GAAE,OAAe,EAC3C,eAAe,GAAE,eAAsC;IAMzD,IAAI,MAAM,IAAI,MAAM,CAEnB;IACD;;;;OAIG;IACU,QAAQ,CAAC,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC,cAAc,CAAC;IAyFtD;;;;OAIG;YACW,kBAAkB;IAIhC;;;;OAIG;YACW,qBAAqB;IAkBnC;;;;OAIG;YACW,qBAAqB;IAoBnC;;;;;OAKG;YACW,aAAa;IAuC3B;;;;;;OAMG;YAOW,oBAAoB;IA8ClC;;;;;;;;;;;;;OAaG;YAOW,4BAA4B;IAgD1C;;OAEG;IACU,+BAA+B,CAAC,OAAO,EAAE,eAAe;IAkBrE;;;OAGG;IACU,4BAA4B,CAAC,OAAO,EAAE,eAAe,GAAgB,OAAO,CAAC,OAAO,CAAC;YA+BpF,MAAM;IAgCpB;;OAEG;IACH,OAAO,CAAC,MAAM,CAAC,sBAAsB;CAStC"}

package/dest/public/public_tx_simulator/public_tx_simulator.js

@@ -47,7 +47,7 @@ export class PublicTxSimulator {
         try {
             const startTime = process.hrtime.bigint();
             const txHash = await tx.getTxHash();
-            this.log.debug(`Simulating ${tx.enqueuedPublicFunctionCalls.length} public calls for tx ${txHash}`, {
+            this.log.debug(`Simulating ${tx.publicFunctionCalldata.length} public calls for tx ${txHash}`, {
                 txHash
             });
             const context = await PublicTxContext.create(this.treesDB, this.contractsDB, tx, this.globalVariables, this.doMerkleOperations);
@@ -166,12 +166,10 @@ export class PublicTxSimulator {
    * @returns The phase result.
    */ async simulatePhase(phase, context) {
         const callRequests = context.getCallRequestsForPhase(phase);
-        const executionRequests = context.getExecutionRequestsForPhase(phase);
         this.log.debug(`Processing phase ${TxExecutionPhase[phase]} for tx ${context.txHash}`, {
             txHash: context.txHash.toString(),
             phase: TxExecutionPhase[phase],
-            callRequests: callRequests.length,
-            executionRequests: executionRequests.length
+            callRequests: callRequests.length
         });
         const returnValues = [];
         let reverted = false;
@@ -182,8 +180,7 @@ export class PublicTxSimulator {
                 break;
             }
             const callRequest = callRequests[i];
-            const executionRequest = executionRequests[i];
-            const enqueuedCallResult = await this.simulateEnqueuedCall(phase, context, callRequest, executionRequest);
+            const enqueuedCallResult = await this.simulateEnqueuedCall(phase, context, callRequest);
             returnValues.push(new NestedProcessReturnValues(enqueuedCallResult.output));
             if (enqueuedCallResult.reverted) {
                 reverted = true;
@@ -202,25 +199,24 @@ export class PublicTxSimulator {
    * Simulate an enqueued public call.
    * @param phase - The current phase of public execution
    * @param context - WILL BE MUTATED. The context of the currently executing public transaction portion
-   * @param callRequest - The enqueued call to execute
-   * @param executionRequest - The execution request (includes args)
+   * @param callRequest - The public function call request, including the calldata.
    * @returns The result of execution.
-   */ async simulateEnqueuedCall(phase, context, callRequest, executionRequest) {
+   */ async simulateEnqueuedCall(phase, context, callRequest) {
         const stateManager = context.state.getActiveStateManager();
-        const address = executionRequest.callContext.contractAddress;
-        const fnName = await getPublicFunctionDebugName(this.contractsDB, address, executionRequest.args);
+        const contractAddress = callRequest.request.contractAddress;
+        const fnName = await getPublicFunctionDebugName(this.contractsDB, contractAddress, callRequest.calldata);
         const allocatedGas = context.getGasLeftAtPhase(phase);
         // The reason we need enqueued hints at all (and cannot just use the public inputs) is
         // because they don't have the actual calldata, just the hash of it.
         // If/when we pass the whole TX to C++, we can remove this class of hints.
-        stateManager.traceEnqueuedCall(callRequest);
-        context.hints.enqueuedCalls.push(new AvmEnqueuedCallHint(executionRequest.callContext.msgSender, executionRequest.callContext.contractAddress, executionRequest.args, executionRequest.callContext.isStaticCall));
-        const result = await this.simulateEnqueuedCallInternal(context.state.getActiveStateManager(), executionRequest, allocatedGas, /*transactionFee=*/ context.getTransactionFee(phase), fnName);
+        stateManager.traceEnqueuedCall(callRequest.request);
+        context.hints.enqueuedCalls.push(new AvmEnqueuedCallHint(callRequest.request.msgSender, contractAddress, callRequest.calldata, callRequest.request.isStaticCall));
+        const result = await this.simulateEnqueuedCallInternal(context.state.getActiveStateManager(), callRequest, allocatedGas, /*transactionFee=*/ context.getTransactionFee(phase), fnName);
         const gasUsed = allocatedGas.sub(result.gasLeft); // by enqueued call
         context.consumeGas(phase, gasUsed);
         this.log.debug(`Simulated enqueued public call (${fnName}) consumed ${gasUsed.l2Gas} L2 gas ending with ${result.gasLeft.l2Gas} L2 gas left.`);
         if (result.reverted) {
-            const culprit = `${executionRequest.callContext.contractAddress}:${executionRequest.callContext.functionSelector}`;
+            const culprit = `${contractAddress}:${callRequest.functionSelector}`;
             context.revert(phase, result.revertReason, culprit); // throws if in setup (non-revertible) phase
         }
         return result;
@@ -234,16 +230,16 @@ export class PublicTxSimulator {
    *
    * @param stateManager - The state manager for AvmSimulation
    * @param context - The context of the currently executing public transaction portion
-   * @param executionRequest - The execution request (includes args)
+   * @param callRequest - The public function call request, including the calldata.
    * @param allocatedGas - The gas allocated to the enqueued call
    * @param fnName - The name of the function
    * @returns The result of execution.
-   */ async simulateEnqueuedCallInternal(stateManager, executionRequest, allocatedGas, transactionFee, fnName) {
-        const address = executionRequest.callContext.contractAddress;
-        const sender = executionRequest.callContext.msgSender;
+   */ async simulateEnqueuedCallInternal(stateManager, { request, calldata }, allocatedGas, transactionFee, fnName) {
+        const address = request.contractAddress;
+        const sender = request.msgSender;
         this.log.debug(`Executing enqueued public call to external function ${fnName}@${address} with ${allocatedGas.l2Gas} allocated L2 gas.`);
         const timer = new Timer();
-        const simulator = await AvmSimulator.create(stateManager, address, sender, transactionFee, this.globalVariables, executionRequest.callContext.isStaticCall, executionRequest.args, allocatedGas);
+        const simulator = await AvmSimulator.create(stateManager, address, sender, transactionFee, this.globalVariables, request.isStaticCall, calldata, allocatedGas);
         const avmCallResult = await simulator.execute();
         const result = avmCallResult.finalize();
         this.log.verbose(result.reverted ? `Simulation of enqueued public call ${fnName} reverted with reason ${result.revertReason}.` : `Simulation of enqueued public call ${fnName} completed successfully.`, {
@@ -334,15 +330,15 @@ export class PublicTxSimulator {
     }
 }
 _ts_decorate([
-    trackSpan('PublicTxSimulator.simulateEnqueuedCall', (phase, context, _callRequest, executionRequest)=>({
+    trackSpan('PublicTxSimulator.simulateEnqueuedCall', (phase, context, callRequest)=>({
             [Attributes.TX_HASH]: context.txHash.toString(),
-            [Attributes.TARGET_ADDRESS]: executionRequest.callContext.contractAddress.toString(),
-            [Attributes.SENDER_ADDRESS]: executionRequest.callContext.msgSender.toString(),
+            [Attributes.TARGET_ADDRESS]: callRequest.request.contractAddress.toString(),
+            [Attributes.SENDER_ADDRESS]: callRequest.request.msgSender.toString(),
             [Attributes.SIMULATOR_PHASE]: TxExecutionPhase[phase].toString()
         }))
 ], PublicTxSimulator.prototype, "simulateEnqueuedCall", null);
 _ts_decorate([
-    trackSpan('PublicTxSimulator.simulateEnqueuedCallInternal', (_stateManager, _executionRequest, _allocatedGas, _transactionFee, fnName)=>({
+    trackSpan('PublicTxSimulator.simulateEnqueuedCallInternal', (_stateManager, _callRequest, _allocatedGas, _transactionFee, fnName)=>({
             [Attributes.APP_CIRCUIT_NAME]: fnName
         }))
 ], PublicTxSimulator.prototype, "simulateEnqueuedCallInternal", null);

package/dest/public/utils.d.ts

@@ -1,5 +1,3 @@
-import type { PublicCallRequest } from '@aztec/stdlib/kernel';
-import { type PublicExecutionRequest, type Tx, TxExecutionPhase } from '@aztec/stdlib/tx';
-export declare function getExecutionRequestsByPhase(tx: Tx, phase: TxExecutionPhase): PublicExecutionRequest[];
-export declare function getCallRequestsByPhase(tx: Tx, phase: TxExecutionPhase): PublicCallRequest[];
+import { PublicCallRequestWithCalldata, type Tx, TxExecutionPhase } from '@aztec/stdlib/tx';
+export declare function getCallRequestsWithCalldataByPhase(tx: Tx, phase: TxExecutionPhase): PublicCallRequestWithCalldata[];
 //# sourceMappingURL=utils.d.ts.map

package/dest/public/utils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"utils.d.ts","sourceRoot":"","sources":["../../src/public/utils.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,sBAAsB,CAAC;AAC9D,OAAO,EAAE,KAAK,sBAAsB,EAAE,KAAK,EAAE,EAAE,gBAAgB,EAAE,MAAM,kBAAkB,CAAC;AAE1F,wBAAgB,2BAA2B,CAAC,EAAE,EAAE,EAAE,EAAE,KAAK,EAAE,gBAAgB,GAAG,sBAAsB,EAAE,CAarG;AAED,wBAAgB,sBAAsB,CAAC,EAAE,EAAE,EAAE,EAAE,KAAK,EAAE,gBAAgB,GAAG,iBAAiB,EAAE,CAa3F"}
+{"version":3,"file":"utils.d.ts","sourceRoot":"","sources":["../../src/public/utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,6BAA6B,EAAE,KAAK,EAAE,EAAE,gBAAgB,EAAE,MAAM,kBAAkB,CAAC;AAE5F,wBAAgB,kCAAkC,CAAC,EAAE,EAAE,EAAE,EAAE,KAAK,EAAE,gBAAgB,GAAG,6BAA6B,EAAE,CAanH"}

package/dest/public/utils.js

@@ -1,30 +1,13 @@
 import { TxExecutionPhase } from '@aztec/stdlib/tx';
-export function getExecutionRequestsByPhase(tx, phase) {
+export function getCallRequestsWithCalldataByPhase(tx, phase) {
     switch(phase){
         case TxExecutionPhase.SETUP:
-            return tx.getNonRevertiblePublicExecutionRequests();
+            return tx.getNonRevertiblePublicCallRequestsWithCalldata();
         case TxExecutionPhase.APP_LOGIC:
-            return tx.getRevertiblePublicExecutionRequests();
+            return tx.getRevertiblePublicCallRequestsWithCalldata();
         case TxExecutionPhase.TEARDOWN:
             {
-                const request = tx.getPublicTeardownExecutionRequest();
-                return request ? [
-                    request
-                ] : [];
-            }
-        default:
-            throw new Error(`Unknown phase: ${phase}`);
-    }
-}
-export function getCallRequestsByPhase(tx, phase) {
-    switch(phase){
-        case TxExecutionPhase.SETUP:
-            return tx.data.getNonRevertiblePublicCallRequests();
-        case TxExecutionPhase.APP_LOGIC:
-            return tx.data.getRevertiblePublicCallRequests();
-        case TxExecutionPhase.TEARDOWN:
-            {
-                const request = tx.data.getTeardownPublicCallRequest();
+                const request = tx.getTeardownPublicCallRequestWithCalldata();
                 return request ? [
                     request
                 ] : [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aztec/simulator",
-  "version": "0.82.0",
+  "version": "0.82.1",
   "type": "module",
   "exports": {
     "./server": "./dest/server.js",
@@ -60,16 +60,16 @@
     ]
   },
   "dependencies": {
-    "@aztec/constants": "0.82.0",
-    "@aztec/foundation": "0.82.0",
-    "@aztec/noir-acvm_js": "0.82.0",
-    "@aztec/noir-noirc_abi": "0.82.0",
-    "@aztec/noir-protocol-circuits-types": "0.82.0",
-    "@aztec/noir-types": "0.82.0",
-    "@aztec/protocol-contracts": "0.82.0",
-    "@aztec/stdlib": "0.82.0",
-    "@aztec/telemetry-client": "0.82.0",
-    "@aztec/world-state": "0.82.0",
+    "@aztec/constants": "0.82.1",
+    "@aztec/foundation": "0.82.1",
+    "@aztec/noir-acvm_js": "0.82.1",
+    "@aztec/noir-noirc_abi": "0.82.1",
+    "@aztec/noir-protocol-circuits-types": "0.82.1",
+    "@aztec/noir-types": "0.82.1",
+    "@aztec/protocol-contracts": "0.82.1",
+    "@aztec/stdlib": "0.82.1",
+    "@aztec/telemetry-client": "0.82.1",
+    "@aztec/world-state": "0.82.1",
     "levelup": "^5.1.1",
     "lodash.clonedeep": "^4.5.0",
     "lodash.merge": "^4.6.2",
@@ -77,9 +77,9 @@
     "tslib": "^2.4.0"
   },
   "devDependencies": {
-    "@aztec/kv-store": "0.82.0",
-    "@aztec/merkle-tree": "0.82.0",
-    "@aztec/noir-contracts.js": "0.82.0",
+    "@aztec/kv-store": "0.82.1",
+    "@aztec/merkle-tree": "0.82.1",
+    "@aztec/noir-contracts.js": "0.82.1",
     "@jest/globals": "^29.5.0",
     "@types/jest": "^29.5.0",
     "@types/levelup": "^5.1.3",

package/src/common/debug_fn_name.ts

@@ -10,9 +10,9 @@ export async function getPublicFunctionDebugName(
   calldata: Fr[],
 ): Promise<string> {
   // Public function is dispatched and therefore the target function is passed in the first argument.
-  const targetFunction =
-    calldata[0] !== undefined
-      ? await db.getDebugFunctionName(contractAddress, FunctionSelector.fromField(calldata[0]))
-      : `<calldata[0] undefined> (Contract Address: ${contractAddress})`;
-  return `${targetFunction}`;
+  if (!calldata[0]) {
+    return `<calldata[0] undefined> (Contract Address: ${contractAddress})`;
+  }
+  const selector = FunctionSelector.fromField(calldata[0]);
+  return (await db.getDebugFunctionName(contractAddress, selector)) ?? selector.toString();
 }

package/src/private/acvm/oracle/oracle.ts

@@ -21,9 +21,9 @@ export class Oracle {
   }
 
   // Since the argument is a slice, noir automatically adds a length field to oracle call.
-  async storeInExecutionCache(_length: ACVMField[], values: ACVMField[]): Promise<ACVMField[]> {
-    const hash = await this.typedOracle.storeInExecutionCache(values.map(Fr.fromString));
-    return [toACVMField(hash)];
+  storeInExecutionCache(_length: ACVMField[], values: ACVMField[], [hash]: ACVMField[]): Promise<ACVMField[]> {
+    this.typedOracle.storeInExecutionCache(values.map(Fr.fromString), Fr.fromString(hash));
+    return Promise.resolve([]);
   }
 
   async loadFromExecutionCache([returnsHash]: ACVMField[]): Promise<ACVMField[][]> {
@@ -320,38 +320,34 @@ export class Oracle {
     return [[endSideEffectCounter, returnsHash].map(toACVMField)];
   }
 
-  async enqueuePublicFunctionCall(
+  async notifyEnqueuedPublicFunctionCall(
     [contractAddress]: ACVMField[],
-    [functionSelector]: ACVMField[],
-    [argsHash]: ACVMField[],
+    [calldataHash]: ACVMField[],
     [sideEffectCounter]: ACVMField[],
     [isStaticCall]: ACVMField[],
   ): Promise<ACVMField[]> {
-    const newArgsHash = await this.typedOracle.enqueuePublicFunctionCall(
+    await this.typedOracle.notifyEnqueuedPublicFunctionCall(
       AztecAddress.fromString(contractAddress),
-      FunctionSelector.fromField(Fr.fromString(functionSelector)),
-      Fr.fromString(argsHash),
+      Fr.fromString(calldataHash),
       Fr.fromString(sideEffectCounter).toNumber(),
       Fr.fromString(isStaticCall).toBool(),
     );
-    return [toACVMField(newArgsHash)];
+    return [];
   }
 
-  async setPublicTeardownFunctionCall(
+  async notifySetPublicTeardownFunctionCall(
     [contractAddress]: ACVMField[],
-    [functionSelector]: ACVMField[],
-    [argsHash]: ACVMField[],
+    [calldataHash]: ACVMField[],
     [sideEffectCounter]: ACVMField[],
     [isStaticCall]: ACVMField[],
   ): Promise<ACVMField[]> {
-    const newArgsHash = await this.typedOracle.setPublicTeardownFunctionCall(
+    await this.typedOracle.notifySetPublicTeardownFunctionCall(
       AztecAddress.fromString(contractAddress),
-      FunctionSelector.fromField(Fr.fromString(functionSelector)),
-      Fr.fromString(argsHash),
+      Fr.fromString(calldataHash),
       Fr.fromString(sideEffectCounter).toNumber(),
       Fr.fromString(isStaticCall).toBool(),
     );
-    return [toACVMField(newArgsHash)];
+    return [];
   }
 
   notifySetMinRevertibleSideEffectCounter([minRevertibleSideEffectCounter]: ACVMField[]): Promise<ACVMField[]> {

package/src/private/acvm/oracle/typed_oracle.ts

@@ -47,8 +47,8 @@ export abstract class TypedOracle {
     return Fr.random();
   }
 
-  storeInExecutionCache(_values: Fr[]): Promise<Fr> {
-    return Promise.reject(new OracleMethodNotAvailableError('storeInExecutionCache'));
+  storeInExecutionCache(_values: Fr[], _hash: Fr): void {
+    throw new OracleMethodNotAvailableError('storeInExecutionCache');
   }
 
   loadFromExecutionCache(_hash: Fr): Promise<Fr[]> {
@@ -180,24 +180,22 @@ export abstract class TypedOracle {
     return Promise.reject(new OracleMethodNotAvailableError('callPrivateFunction'));
   }
 
-  enqueuePublicFunctionCall(
+  notifyEnqueuedPublicFunctionCall(
     _targetContractAddress: AztecAddress,
-    _functionSelector: FunctionSelector,
-    _argsHash: Fr,
+    _calldataHash: Fr,
     _sideEffectCounter: number,
     _isStaticCall: boolean,
-  ): Promise<Fr> {
-    return Promise.reject(new OracleMethodNotAvailableError('enqueuePublicFunctionCall'));
+  ): Promise<void> {
+    return Promise.reject(new OracleMethodNotAvailableError('notifyEnqueuedPublicFunctionCall'));
   }
 
-  setPublicTeardownFunctionCall(
+  notifySetPublicTeardownFunctionCall(
     _targetContractAddress: AztecAddress,
-    _functionSelector: FunctionSelector,
-    _argsHash: Fr,
+    _calldataHash: Fr,
     _sideEffectCounter: number,
     _isStaticCall: boolean,
-  ): Promise<Fr> {
-    return Promise.reject(new OracleMethodNotAvailableError('setPublicTeardownFunctionCall'));
+  ): Promise<void> {
+    return Promise.reject(new OracleMethodNotAvailableError('notifySetPublicTeardownFunctionCall'));
   }
 
   notifySetMinRevertibleSideEffectCounter(_minRevertibleSideEffectCounter: number): void {

package/src/private/hashed_values_cache.ts

@@ -28,15 +28,12 @@ export class HashedValuesCache {
    * @param hash - The hash to get the preimage of.
    * @returns The preimage.
    */
-  public getPreimage(hash: Fr): Fr[] {
-    if (hash.equals(Fr.ZERO)) {
+  public getPreimage(hash: Fr): Fr[] | undefined {
+    if (hash.isEmpty()) {
       return [];
+    } else {
+      return this.cache.get(hash.toBigInt());
     }
-    const hashedValues = this.cache.get(hash.toBigInt());
-    if (!hashedValues) {
-      throw new Error(`Preimage for hash ${hash.toString()} not found in cache`);
-    }
-    return hashedValues;
   }
 
   /**
@@ -44,12 +41,7 @@ export class HashedValuesCache {
    * @param values - The values to store.
    * @returns The hash of the values.
    */
-  public async store(values: Fr[]) {
-    if (values.length === 0) {
-      return Fr.ZERO;
-    }
-    const hashedValues = await HashedValues.fromValues(values);
-    this.cache.set(hashedValues.hash.toBigInt(), hashedValues.values);
-    return hashedValues.hash;
+  public store(values: Fr[], hash: Fr) {
+    this.cache.set(hash.toBigInt(), values);
   }
 }

package/src/private/private_execution.ts

@@ -77,8 +77,6 @@ export async function executePrivateFunction(
   const newNotes = privateExecutionOracle.getNewNotes();
   const noteHashNullifierCounterMap = privateExecutionOracle.getNoteHashNullifierCounterMap();
   const nestedExecutions = privateExecutionOracle.getNestedExecutions();
-  const enqueuedPublicFunctionCalls = privateExecutionOracle.getEnqueuedPublicFunctionCalls();
-  const publicTeardownFunctionCall = privateExecutionOracle.getPublicTeardownFunctionCall();
 
   log.debug(`Returning from call to ${contractAddress.toString()}:${functionSelector}`);
 
@@ -92,8 +90,6 @@ export async function executePrivateFunction(
     noteHashNullifierCounterMap,
     rawReturnValues,
     nestedExecutions,
-    enqueuedPublicFunctionCalls,
-    publicTeardownFunctionCall,
     contractClassLogs,
   );
 }