@aztec/simulator 0.0.0-test.1 → 0.0.1-commit.24de95ac

package/dest/public/avm/opcodes/ec_add.js

@@ -1,6 +1,7 @@
 import { Grumpkin } from '@aztec/foundation/crypto';
 import { Point } from '@aztec/foundation/fields';
 import { Field, TypeTag, Uint1 } from '../avm_memory_types.js';
+import { EcAddPointNotOnCurveError } from '../errors.js';
 import { Opcode, OperandType } from '../serialization/instruction_serialization.js';
 import { Addressing } from './addressing_mode.js';
 import { Instruction } from './instruction.js';
@@ -32,7 +33,8 @@ export class EcAdd extends Instruction {
     }
     async execute(context) {
         const memory = context.machineState.memory;
-        context.machineState.consumeGas(this.gasCost());
+        const addressing = Addressing.fromWire(this.indirect);
+        context.machineState.consumeGas(this.baseGasCost(addressing.indirectOperandsCount(), addressing.relativeOperandsCount()));
         const operands = [
             this.p1XOffset,
             this.p1YOffset,
@@ -42,7 +44,6 @@ export class EcAdd extends Instruction {
             this.p2IsInfiniteOffset,
             this.dstOffset
         ];
-        const addressing = Addressing.fromWire(this.indirect, operands.length);
         const [p1XOffset, p1YOffset, p1IsInfiniteOffset, p2XOffset, p2YOffset, p2IsInfiniteOffset, dstOffset] = addressing.resolve(operands, memory);
         memory.checkTags(TypeTag.FIELD, p1XOffset, p1YOffset, p2XOffset, p2YOffset);
         memory.checkTags(TypeTag.UINT1, p1IsInfiniteOffset, p2IsInfiniteOffset);
@@ -51,7 +52,7 @@ export class EcAdd extends Instruction {
         const p1IsInfinite = memory.get(p1IsInfiniteOffset).toNumber() === 1;
         const p1 = new Point(p1X.toFr(), p1Y.toFr(), p1IsInfinite);
         if (!p1.isOnGrumpkin()) {
-            throw new Error(`Point1 is not on the curve`);
+            throw new EcAddPointNotOnCurveError(/*pointIndex=*/ 1, p1);
         }
         const p2X = memory.get(p2XOffset);
         const p2Y = memory.get(p2YOffset);
@@ -59,16 +60,15 @@ export class EcAdd extends Instruction {
         const p2IsInfinite = memory.get(p2IsInfiniteOffset).toNumber() === 1;
         const p2 = new Point(p2X.toFr(), p2Y.toFr(), p2IsInfinite);
         if (!p2.isOnGrumpkin()) {
-            throw new Error(`Point1 is not on the curve`);
+            throw new EcAddPointNotOnCurveError(/*pointIndex=*/ 2, p2);
         }
-        const grumpkin = new Grumpkin();
         let dest;
         if (p1IsInfinite) {
             dest = p2;
         } else if (p2IsInfinite) {
             dest = p1;
         } else {
-            dest = await grumpkin.add(p1, p2);
+            dest = await Grumpkin.add(p1, p2);
         }
         // Important to use setSlice() and not set() in the two following statements as
         // this checks that the offsets lie within memory range.

package/dest/public/avm/opcodes/environment_getters.d.ts

@@ -9,8 +9,8 @@ export declare enum EnvironmentVariable {
     VERSION = 4,
     BLOCKNUMBER = 5,
     TIMESTAMP = 6,
-    FEEPERL2GAS = 7,
-    FEEPERDAGAS = 8,
+    BASEFEEPERL2GAS = 7,
+    BASEFEEPERDAGAS = 8,
     ISSTATICCALL = 9,
     L2GASLEFT = 10,
     DAGASLEFT = 11

package/dest/public/avm/opcodes/environment_getters.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"environment_getters.d.ts","sourceRoot":"","sources":["../../../../src/public/avm/opcodes/environment_getters.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AAGpD,OAAO,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,+CAA+C,CAAC;AAEpF,OAAO,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAC;AAE/C,oBAAY,mBAAmB;IAC7B,OAAO,IAAA;IACP,MAAM,IAAA;IACN,cAAc,IAAA;IACd,OAAO,IAAA;IACP,OAAO,IAAA;IACP,WAAW,IAAA;IACX,SAAS,IAAA;IACT,WAAW,IAAA;IACX,WAAW,IAAA;IACX,YAAY,IAAA;IACZ,SAAS,KAAA;IACT,SAAS,KAAA;CACV;AAiCD,qBAAa,SAAU,SAAQ,WAAW;IAU5B,OAAO,CAAC,QAAQ;IAAU,OAAO,CAAC,SAAS;IAAU,OAAO,CAAC,OAAO;IAThF,gBAAuB,IAAI,EAAE,MAAM,CAAe;IAClD,gBAAuB,MAAM,EAAE,MAAM,CAAuB;IAC5D,MAAM,CAAC,QAAQ,CAAC,YAAY,EAAE,WAAW,EAAE,CAKzC;gBAEkB,QAAQ,EAAE,MAAM,EAAU,SAAS,EAAE,MAAM,EAAU,OAAO,EAAE,MAAM;IAI3E,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;CAczD"}
+{"version":3,"file":"environment_getters.d.ts","sourceRoot":"","sources":["../../../../src/public/avm/opcodes/environment_getters.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AAGpD,OAAO,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,+CAA+C,CAAC;AAEpF,OAAO,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAC;AAE/C,oBAAY,mBAAmB;IAC7B,OAAO,IAAA;IACP,MAAM,IAAA;IACN,cAAc,IAAA;IACd,OAAO,IAAA;IACP,OAAO,IAAA;IACP,WAAW,IAAA;IACX,SAAS,IAAA;IACT,eAAe,IAAA;IACf,eAAe,IAAA;IACf,YAAY,IAAA;IACZ,SAAS,KAAA;IACT,SAAS,KAAA;CACV;AAiCD,qBAAa,SAAU,SAAQ,WAAW;IAWtC,OAAO,CAAC,QAAQ;IAChB,OAAO,CAAC,SAAS;IACjB,OAAO,CAAC,OAAO;IAZjB,gBAAuB,IAAI,EAAE,MAAM,CAAe;IAClD,gBAAuB,MAAM,EAAE,MAAM,CAAuB;IAC5D,MAAM,CAAC,QAAQ,CAAC,YAAY,EAAE,WAAW,EAAE,CAKzC;gBAGQ,QAAQ,EAAE,MAAM,EAChB,SAAS,EAAE,MAAM,EACjB,OAAO,EAAE,MAAM;IAKZ,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;CAezD"}

package/dest/public/avm/opcodes/environment_getters.js

@@ -1,4 +1,4 @@
-import { Field, Uint64 } from '../avm_memory_types.js';
+import { Field, Uint1, Uint32, Uint64, Uint128 } from '../avm_memory_types.js';
 import { InstructionExecutionError } from '../errors.js';
 import { Opcode, OperandType } from '../serialization/instruction_serialization.js';
 import { Addressing } from './addressing_mode.js';
@@ -11,15 +11,15 @@ export var EnvironmentVariable = /*#__PURE__*/ function(EnvironmentVariable) {
     EnvironmentVariable[EnvironmentVariable["VERSION"] = 4] = "VERSION";
     EnvironmentVariable[EnvironmentVariable["BLOCKNUMBER"] = 5] = "BLOCKNUMBER";
     EnvironmentVariable[EnvironmentVariable["TIMESTAMP"] = 6] = "TIMESTAMP";
-    EnvironmentVariable[EnvironmentVariable["FEEPERL2GAS"] = 7] = "FEEPERL2GAS";
-    EnvironmentVariable[EnvironmentVariable["FEEPERDAGAS"] = 8] = "FEEPERDAGAS";
+    EnvironmentVariable[EnvironmentVariable["BASEFEEPERL2GAS"] = 7] = "BASEFEEPERL2GAS";
+    EnvironmentVariable[EnvironmentVariable["BASEFEEPERDAGAS"] = 8] = "BASEFEEPERDAGAS";
     EnvironmentVariable[EnvironmentVariable["ISSTATICCALL"] = 9] = "ISSTATICCALL";
     EnvironmentVariable[EnvironmentVariable["L2GASLEFT"] = 10] = "L2GASLEFT";
     EnvironmentVariable[EnvironmentVariable["DAGASLEFT"] = 11] = "DAGASLEFT";
     return EnvironmentVariable;
 }({});
-function getValue(e, ctx) {
-    switch(e){
+function getValue(varEnum, ctx) {
+    switch(varEnum){
         case 0:
             return new Field(ctx.environment.address.toField());
         case 1:
@@ -31,21 +31,21 @@ function getValue(e, ctx) {
         case 4:
             return new Field(ctx.environment.globals.version);
         case 5:
-            return new Field(ctx.environment.globals.blockNumber);
+            return new Uint32(ctx.environment.globals.blockNumber);
         case 6:
-            return new Uint64(ctx.environment.globals.timestamp.toBigInt());
+            return new Uint64(ctx.environment.globals.timestamp);
         case 7:
-            return new Field(ctx.environment.globals.gasFees.feePerL2Gas);
+            return new Uint128(ctx.environment.globals.gasFees.feePerL2Gas);
         case 8:
-            return new Field(ctx.environment.globals.gasFees.feePerDaGas);
+            return new Uint128(ctx.environment.globals.gasFees.feePerDaGas);
         case 9:
-            return new Field(ctx.environment.isStaticCall ? 1 : 0);
+            return new Uint1(ctx.environment.isStaticCall ? 1 : 0);
         case 10:
-            return new Field(ctx.machineState.l2GasLeft);
+            return new Uint32(ctx.machineState.l2GasLeft);
         case 11:
-            return new Field(ctx.machineState.daGasLeft);
+            return new Uint32(ctx.machineState.daGasLeft);
         default:
-            throw new Error(`Unknown environment variable ${e}`);
+            throw new InstructionExecutionError(`Invalid GETENVVAR var enum ${varEnum}`);
     }
 }
 export class GetEnvVar extends Instruction {
@@ -65,15 +65,13 @@ export class GetEnvVar extends Instruction {
     }
     async execute(context) {
         const memory = context.machineState.memory;
-        context.machineState.consumeGas(this.gasCost());
-        if (!(this.varEnum in EnvironmentVariable)) {
-            throw new InstructionExecutionError(`Invalid GETENVVAR var enum ${this.varEnum}`);
-        }
+        const addressing = Addressing.fromWire(this.indirect);
+        context.machineState.consumeGas(this.baseGasCost(addressing.indirectOperandsCount(), addressing.relativeOperandsCount()));
         const operands = [
             this.dstOffset
         ];
-        const addressing = Addressing.fromWire(this.indirect, operands.length);
         const [dstOffset] = addressing.resolve(operands, memory);
-        memory.set(dstOffset, getValue(this.varEnum, context));
+        const value = getValue(this.varEnum, context);
+        memory.set(dstOffset, value);
     }
 }

package/dest/public/avm/opcodes/external_calls.d.ts

@@ -3,12 +3,13 @@ import { Opcode, OperandType } from '../serialization/instruction_serialization.
 import { Instruction } from './instruction.js';
 declare abstract class ExternalCall extends Instruction {
     private indirect;
-    private gasOffset;
+    private l2GasOffset;
+    private daGasOffset;
     private addrOffset;
-    private argsOffset;
     private argsSizeOffset;
+    private argsOffset;
     static readonly wireFormat: OperandType[];
-    constructor(indirect: number, gasOffset: number, addrOffset: number, argsOffset: number, argsSizeOffset: number);
+    constructor(indirect: number, l2GasOffset: number, daGasOffset: number, addrOffset: number, argsSizeOffset: number, argsOffset: number);
     execute(context: AvmContext): Promise<void>;
     abstract get type(): 'CALL' | 'STATICCALL';
 }
@@ -33,24 +34,24 @@ export declare class SuccessCopy extends Instruction {
 }
 export declare class Return extends Instruction {
     private indirect;
-    private returnOffset;
     private returnSizeOffset;
+    private returnOffset;
     static type: string;
     static readonly opcode: Opcode;
     static readonly wireFormat: OperandType[];
-    constructor(indirect: number, returnOffset: number, returnSizeOffset: number);
+    constructor(indirect: number, returnSizeOffset: number, returnOffset: number);
     execute(context: AvmContext): Promise<void>;
     handlesPC(): boolean;
 }
 export declare class Revert extends Instruction {
     private indirect;
-    private returnOffset;
     private retSizeOffset;
+    private returnOffset;
     static type: string;
     static readonly opcode: Opcode;
     static readonly wireFormat8: OperandType[];
     static readonly wireFormat16: OperandType[];
-    constructor(indirect: number, returnOffset: number, retSizeOffset: number);
+    constructor(indirect: number, retSizeOffset: number, returnOffset: number);
     execute(context: AvmContext): Promise<void>;
     handlesPC(): boolean;
 }

package/dest/public/avm/opcodes/external_calls.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"external_calls.d.ts","sourceRoot":"","sources":["../../../../src/public/avm/opcodes/external_calls.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AAGpD,OAAO,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,+CAA+C,CAAC;AAEpF,OAAO,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAC;AAE/C,uBAAe,YAAa,SAAQ,WAAW;IAY3C,OAAO,CAAC,QAAQ;IAChB,OAAO,CAAC,SAAS;IACjB,OAAO,CAAC,UAAU;IAClB,OAAO,CAAC,UAAU;IAClB,OAAO,CAAC,cAAc;IAdxB,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAOvC;gBAGQ,QAAQ,EAAE,MAAM,EAChB,SAAS,EAAE,MAAM,EACjB,UAAU,EAAE,MAAM,EAClB,UAAU,EAAE,MAAM,EAClB,cAAc,EAAE,MAAM;IAKnB,OAAO,CAAC,OAAO,EAAE,UAAU;IAmExC,aAA6B,IAAI,IAAI,MAAM,GAAG,YAAY,CAAC;CAC5D;AAED,qBAAa,IAAK,SAAQ,YAAY;IACpC,MAAM,CAAC,IAAI,SAAmB;IAC9B,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAe;IAE7C,IAAW,IAAI,WAEd;CACF;AAED,qBAAa,UAAW,SAAQ,YAAY;IAC1C,MAAM,CAAC,IAAI,eAAyB;IACpC,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAqB;IAEnD,IAAW,IAAI,iBAEd;CACF;AAED,qBAAa,WAAY,SAAQ,WAAW;IAU9B,OAAO,CAAC,QAAQ;IAAU,OAAO,CAAC,SAAS;IATvD,MAAM,CAAC,IAAI,EAAE,MAAM,CAAiB;IACpC,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAsB;IAEpD,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAIvC;gBAEkB,QAAQ,EAAE,MAAM,EAAU,SAAS,EAAE,MAAM;IAIlD,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;CAazD;AAED,qBAAa,MAAO,SAAQ,WAAW;IAWzB,OAAO,CAAC,QAAQ;IAAU,OAAO,CAAC,YAAY;IAAU,OAAO,CAAC,gBAAgB;IAV5F,MAAM,CAAC,IAAI,EAAE,MAAM,CAAY;IAC/B,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAiB;IAE/C,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAKvC;gBAEkB,QAAQ,EAAE,MAAM,EAAU,YAAY,EAAE,MAAM,EAAU,gBAAgB,EAAE,MAAM;IAIvF,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;IAgBxC,SAAS,IAAI,OAAO;CAGrC;AAED,qBAAa,MAAO,SAAQ,WAAW;IAiBzB,OAAO,CAAC,QAAQ;IAAU,OAAO,CAAC,YAAY;IAAU,OAAO,CAAC,aAAa;IAhBzF,MAAM,CAAC,IAAI,EAAE,MAAM,CAAY;IAC/B,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAmB;IAEjD,MAAM,CAAC,QAAQ,CAAC,WAAW,EAAE,WAAW,EAAE,CAKxC;IACF,MAAM,CAAC,QAAQ,CAAC,YAAY,EAAE,WAAW,EAAE,CAKzC;gBAEkB,QAAQ,EAAE,MAAM,EAAU,YAAY,EAAE,MAAM,EAAU,aAAa,EAAE,MAAM;IAIpF,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;IAiBxC,SAAS,IAAI,OAAO;CAGrC"}
+{"version":3,"file":"external_calls.d.ts","sourceRoot":"","sources":["../../../../src/public/avm/opcodes/external_calls.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AAGpD,OAAO,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,+CAA+C,CAAC;AAEpF,OAAO,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAC;AAE/C,uBAAe,YAAa,SAAQ,WAAW;IAa3C,OAAO,CAAC,QAAQ;IAChB,OAAO,CAAC,WAAW;IACnB,OAAO,CAAC,WAAW;IACnB,OAAO,CAAC,UAAU;IAClB,OAAO,CAAC,cAAc;IACtB,OAAO,CAAC,UAAU;IAhBpB,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAQvC;gBAGQ,QAAQ,EAAE,MAAM,EAChB,WAAW,EAAE,MAAM,EACnB,WAAW,EAAE,MAAM,EACnB,UAAU,EAAE,MAAM,EAClB,cAAc,EAAE,MAAM,EACtB,UAAU,EAAE,MAAM;IAKf,OAAO,CAAC,OAAO,EAAE,UAAU;IA4ExC,aAA6B,IAAI,IAAI,MAAM,GAAG,YAAY,CAAC;CAC5D;AAED,qBAAa,IAAK,SAAQ,YAAY;IACpC,MAAM,CAAC,IAAI,EAAG,MAAM,CAAU;IAC9B,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAe;IAE7C,IAAW,IAAI,WAEd;CACF;AAED,qBAAa,UAAW,SAAQ,YAAY;IAC1C,MAAM,CAAC,IAAI,EAAG,YAAY,CAAU;IACpC,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAqB;IAEnD,IAAW,IAAI,iBAEd;CACF;AAED,qBAAa,WAAY,SAAQ,WAAW;IAWxC,OAAO,CAAC,QAAQ;IAChB,OAAO,CAAC,SAAS;IAXnB,MAAM,CAAC,IAAI,EAAE,MAAM,CAAiB;IACpC,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAsB;IAEpD,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAIvC;gBAGQ,QAAQ,EAAE,MAAM,EAChB,SAAS,EAAE,MAAM;IAKd,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;CAiBzD;AAED,qBAAa,MAAO,SAAQ,WAAW;IAYnC,OAAO,CAAC,QAAQ;IAChB,OAAO,CAAC,gBAAgB;IACxB,OAAO,CAAC,YAAY;IAbtB,MAAM,CAAC,IAAI,EAAE,MAAM,CAAY;IAC/B,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAiB;IAE/C,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAKvC;gBAGQ,QAAQ,EAAE,MAAM,EAChB,gBAAgB,EAAE,MAAM,EACxB,YAAY,EAAE,MAAM;IAKjB,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;IAmBxC,SAAS,IAAI,OAAO;CAGrC;AAED,qBAAa,MAAO,SAAQ,WAAW;IAkBnC,OAAO,CAAC,QAAQ;IAChB,OAAO,CAAC,aAAa;IACrB,OAAO,CAAC,YAAY;IAnBtB,MAAM,CAAC,IAAI,EAAE,MAAM,CAAY;IAC/B,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAmB;IAEjD,MAAM,CAAC,QAAQ,CAAC,WAAW,EAAE,WAAW,EAAE,CAKxC;IACF,MAAM,CAAC,QAAQ,CAAC,YAAY,EAAE,WAAW,EAAE,CAKzC;gBAGQ,QAAQ,EAAE,MAAM,EAChB,aAAa,EAAE,MAAM,EACrB,YAAY,EAAE,MAAM;IAKjB,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;IAoBxC,SAAS,IAAI,OAAO;CAGrC"}

package/dest/public/avm/opcodes/external_calls.js

@@ -4,49 +4,51 @@ import { Addressing } from './addressing_mode.js';
 import { Instruction } from './instruction.js';
 class ExternalCall extends Instruction {
     indirect;
-    gasOffset;
+    l2GasOffset;
+    daGasOffset;
     addrOffset;
-    argsOffset;
     argsSizeOffset;
+    argsOffset;
     // Informs (de)serialization. See Instruction.deserialize.
     static wireFormat = [
         OperandType.UINT8,
-        OperandType.UINT8,
+        OperandType.UINT16,
+        OperandType.UINT16,
         OperandType.UINT16,
         OperandType.UINT16,
         OperandType.UINT16,
         OperandType.UINT16
     ];
-    constructor(indirect, gasOffset, addrOffset, argsOffset, argsSizeOffset){
-        super(), this.indirect = indirect, this.gasOffset = gasOffset, this.addrOffset = addrOffset, this.argsOffset = argsOffset, this.argsSizeOffset = argsSizeOffset;
+    constructor(indirect, l2GasOffset, daGasOffset, addrOffset, argsSizeOffset, argsOffset){
+        super(), this.indirect = indirect, this.l2GasOffset = l2GasOffset, this.daGasOffset = daGasOffset, this.addrOffset = addrOffset, this.argsSizeOffset = argsSizeOffset, this.argsOffset = argsOffset;
     }
     async execute(context) {
         const memory = context.machineState.memory;
+        const addressing = Addressing.fromWire(this.indirect);
+        context.machineState.consumeGas(this.baseGasCost(addressing.indirectOperandsCount(), addressing.relativeOperandsCount()));
         const operands = [
-            this.gasOffset,
+            this.l2GasOffset,
+            this.daGasOffset,
             this.addrOffset,
-            this.argsOffset,
-            this.argsSizeOffset
+            this.argsSizeOffset,
+            this.argsOffset
         ];
-        const addressing = Addressing.fromWire(this.indirect, operands.length);
-        const [gasOffset, addrOffset, argsOffset, argsSizeOffset] = addressing.resolve(operands, memory);
-        memory.checkTags(TypeTag.FIELD, gasOffset, gasOffset + 1);
+        const [l2GasOffset, daGasOffset, addrOffset, argsSizeOffset, argsOffset] = addressing.resolve(operands, memory);
+        memory.checkTags(TypeTag.UINT32, l2GasOffset);
+        memory.checkTags(TypeTag.UINT32, daGasOffset);
         memory.checkTag(TypeTag.FIELD, addrOffset);
         memory.checkTag(TypeTag.UINT32, argsSizeOffset);
         const calldataSize = memory.get(argsSizeOffset).toNumber();
         const calldata = memory.getSlice(argsOffset, calldataSize).map((f)=>f.toFr());
-        memory.checkTagsRange(TypeTag.FIELD, argsOffset, calldataSize);
         const callAddress = memory.getAs(addrOffset);
         // If we are already in a static call, we propagate the environment.
         const callType = context.environment.isStaticCall ? 'STATICCALL' : this.type;
-        // First we consume the gas for this operation.
-        context.machineState.consumeGas(this.gasCost(calldataSize));
-        // Then we consume the gas allocated for the nested call. The excess will be refunded later.
+        // We consume the gas allocated for the nested call. The excess will be refunded later.
         // Gas allocation is capped by the amount of gas left in the current context.
         // We have to do some dancing here because the gas allocation is a field,
         // but in the machine state we track gas as a number.
-        const allocatedL2Gas = Number(BigIntMin(memory.get(gasOffset).toBigInt(), BigInt(context.machineState.l2GasLeft)));
-        const allocatedDaGas = Number(BigIntMin(memory.get(gasOffset + 1).toBigInt(), BigInt(context.machineState.daGasLeft)));
+        const allocatedL2Gas = Number(BigIntMin(memory.get(l2GasOffset).toBigInt(), BigInt(context.machineState.l2GasLeft)));
+        const allocatedDaGas = Number(BigIntMin(memory.get(daGasOffset).toBigInt(), BigInt(context.machineState.daGasLeft)));
         const allocatedGas = {
             l2Gas: allocatedL2Gas,
             daGas: allocatedDaGas
@@ -62,6 +64,8 @@ class ExternalCall extends Instruction {
         context.machineState.nestedReturndata = fullReturnData;
         // Track the success status directly
         context.machineState.nestedCallSuccess = success;
+        // Account for all instructions executed in the nested call
+        context.machineState.instrCounter += nestedCallResults.totalInstructions;
         // If the nested call reverted, we try to save the reason and the revert data.
         // This will be used by the caller to try to reconstruct the call stack.
         // This is only a heuristic and may not always work. It is intended to work
@@ -113,10 +117,11 @@ export class SuccessCopy extends Instruction {
     }
     async execute(context) {
         const memory = context.machineState.memory;
+        const addressing = Addressing.fromWire(this.indirect);
+        context.machineState.consumeGas(this.baseGasCost(addressing.indirectOperandsCount(), addressing.relativeOperandsCount()));
         const operands = [
             this.dstOffset
         ];
-        const addressing = Addressing.fromWire(this.indirect, operands.length);
         const [dstOffset] = addressing.resolve(operands, memory);
         // Use the direct success tracking property
         const success = context.machineState.nestedCallSuccess;
@@ -126,8 +131,8 @@ export class SuccessCopy extends Instruction {
 }
 export class Return extends Instruction {
     indirect;
-    returnOffset;
     returnSizeOffset;
+    returnOffset;
     static type = 'RETURN';
     static opcode = Opcode.RETURN;
     // Informs (de)serialization. See Instruction.deserialize.
@@ -137,20 +142,20 @@ export class Return extends Instruction {
         OperandType.UINT16,
         OperandType.UINT16
     ];
-    constructor(indirect, returnOffset, returnSizeOffset){
-        super(), this.indirect = indirect, this.returnOffset = returnOffset, this.returnSizeOffset = returnSizeOffset;
+    constructor(indirect, returnSizeOffset, returnOffset){
+        super(), this.indirect = indirect, this.returnSizeOffset = returnSizeOffset, this.returnOffset = returnOffset;
     }
     async execute(context) {
         const memory = context.machineState.memory;
+        const addressing = Addressing.fromWire(this.indirect);
+        context.machineState.consumeGas(this.baseGasCost(addressing.indirectOperandsCount(), addressing.relativeOperandsCount()));
         const operands = [
-            this.returnOffset,
-            this.returnSizeOffset
+            this.returnSizeOffset,
+            this.returnOffset
         ];
-        const addressing = Addressing.fromWire(this.indirect, operands.length);
-        const [returnOffset, returnSizeOffset] = addressing.resolve(operands, memory);
+        const [returnSizeOffset, returnOffset] = addressing.resolve(operands, memory);
         memory.checkTag(TypeTag.UINT32, returnSizeOffset);
         const returnSize = memory.get(returnSizeOffset).toNumber();
-        context.machineState.consumeGas(this.gasCost(returnSize));
         const output = memory.getSlice(returnOffset, returnSize).map((word)=>word.toFr());
         context.machineState.return(output);
     }
@@ -160,8 +165,8 @@ export class Return extends Instruction {
 }
 export class Revert extends Instruction {
     indirect;
-    returnOffset;
     retSizeOffset;
+    returnOffset;
     static type = 'REVERT';
     static opcode = Opcode.REVERT_8;
     static wireFormat8 = [
@@ -176,20 +181,20 @@ export class Revert extends Instruction {
         OperandType.UINT16,
         OperandType.UINT16
     ];
-    constructor(indirect, returnOffset, retSizeOffset){
-        super(), this.indirect = indirect, this.returnOffset = returnOffset, this.retSizeOffset = retSizeOffset;
+    constructor(indirect, retSizeOffset, returnOffset){
+        super(), this.indirect = indirect, this.retSizeOffset = retSizeOffset, this.returnOffset = returnOffset;
     }
     async execute(context) {
         const memory = context.machineState.memory;
+        const addressing = Addressing.fromWire(this.indirect);
+        context.machineState.consumeGas(this.baseGasCost(addressing.indirectOperandsCount(), addressing.relativeOperandsCount()));
         const operands = [
-            this.returnOffset,
-            this.retSizeOffset
+            this.retSizeOffset,
+            this.returnOffset
         ];
-        const addressing = Addressing.fromWire(this.indirect, operands.length);
-        const [returnOffset, retSizeOffset] = addressing.resolve(operands, memory);
+        const [retSizeOffset, returnOffset] = addressing.resolve(operands, memory);
         memory.checkTag(TypeTag.UINT32, retSizeOffset);
         const retSize = memory.get(retSizeOffset).toNumber();
-        context.machineState.consumeGas(this.gasCost(retSize));
         const output = memory.getSlice(returnOffset, retSize).map((word)=>word.toFr());
         context.machineState.revert(output);
     }

package/dest/public/avm/opcodes/hashing.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"hashing.d.ts","sourceRoot":"","sources":["../../../../src/public/avm/opcodes/hashing.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AAEpD,OAAO,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,+CAA+C,CAAC;AAEpF,OAAO,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAC;AAE/C,qBAAa,SAAU,SAAQ,WAAW;IAa5B,OAAO,CAAC,QAAQ;IAAU,OAAO,CAAC,gBAAgB;IAAU,OAAO,CAAC,iBAAiB;IAZjG,MAAM,CAAC,IAAI,EAAE,MAAM,CAAe;IAClC,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAoB;IAClD,MAAM,CAAC,QAAQ,CAAC,SAAS,KAAK;IAG9B,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAKvC;gBAEkB,QAAQ,EAAE,MAAM,EAAU,gBAAgB,EAAE,MAAM,EAAU,iBAAiB,EAAE,MAAM;IAI5F,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;CAiBzD;AAED,qBAAa,WAAY,SAAQ,WAAW;IAY9B,OAAO,CAAC,QAAQ;IAAU,OAAO,CAAC,SAAS;IAAU,OAAO,CAAC,WAAW;IAXpF,MAAM,CAAC,IAAI,EAAE,MAAM,CAAiB;IACpC,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAsB;IAGpD,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAKvC;gBAEkB,QAAQ,EAAE,MAAM,EAAU,SAAS,EAAE,MAAM,EAAU,WAAW,EAAE,MAAM;IAK/E,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;CAgBzD;AAED,qBAAa,iBAAkB,SAAQ,WAAW;IAc9C,OAAO,CAAC,QAAQ;IAChB,OAAO,CAAC,YAAY;IACpB,OAAO,CAAC,WAAW;IACnB,OAAO,CAAC,YAAY;IAhBtB,MAAM,CAAC,IAAI,EAAE,MAAM,CAAuB;IAC1C,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAA4B;IAG1D,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAMvC;gBAGQ,QAAQ,EAAE,MAAM,EAChB,YAAY,EAAE,MAAM,EACpB,WAAW,EAAE,MAAM,EACnB,YAAY,EAAE,MAAM;IAKjB,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;CAuBzD"}
+{"version":3,"file":"hashing.d.ts","sourceRoot":"","sources":["../../../../src/public/avm/opcodes/hashing.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AAEpD,OAAO,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,+CAA+C,CAAC;AAEpF,OAAO,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAC;AAE/C,qBAAa,SAAU,SAAQ,WAAW;IActC,OAAO,CAAC,QAAQ;IAChB,OAAO,CAAC,gBAAgB;IACxB,OAAO,CAAC,iBAAiB;IAf3B,MAAM,CAAC,IAAI,EAAE,MAAM,CAAe;IAClC,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAoB;IAClD,MAAM,CAAC,QAAQ,CAAC,SAAS,KAAK;IAG9B,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAKvC;gBAGQ,QAAQ,EAAE,MAAM,EAChB,gBAAgB,EAAE,MAAM,EACxB,iBAAiB,EAAE,MAAM;IAKtB,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;CAqBzD;AAED,qBAAa,WAAY,SAAQ,WAAW;IAaxC,OAAO,CAAC,QAAQ;IAChB,OAAO,CAAC,SAAS;IACjB,OAAO,CAAC,WAAW;IAdrB,MAAM,CAAC,IAAI,EAAE,MAAM,CAAiB;IACpC,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAsB;IAGpD,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAKvC;gBAGQ,QAAQ,EAAE,MAAM,EAChB,SAAS,EAAE,MAAM,EACjB,WAAW,EAAE,MAAM;IAMhB,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;CAoBzD;AAED,qBAAa,iBAAkB,SAAQ,WAAW;IAc9C,OAAO,CAAC,QAAQ;IAChB,OAAO,CAAC,YAAY;IACpB,OAAO,CAAC,WAAW;IACnB,OAAO,CAAC,YAAY;IAhBtB,MAAM,CAAC,IAAI,EAAE,MAAM,CAAuB;IAC1C,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,MAAM,CAA4B;IAG1D,MAAM,CAAC,QAAQ,CAAC,UAAU,EAAE,WAAW,EAAE,CAMvC;gBAGQ,QAAQ,EAAE,MAAM,EAChB,YAAY,EAAE,MAAM,EACpB,WAAW,EAAE,MAAM,EACnB,YAAY,EAAE,MAAM;IAKjB,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;CA2BzD"}

package/dest/public/avm/opcodes/hashing.js

@@ -22,12 +22,12 @@ export class Poseidon2 extends Instruction {
     }
     async execute(context) {
         const memory = context.machineState.memory;
-        context.machineState.consumeGas(this.gasCost());
+        const addressing = Addressing.fromWire(this.indirect);
+        context.machineState.consumeGas(this.baseGasCost(addressing.indirectOperandsCount(), addressing.relativeOperandsCount()));
         const operands = [
             this.inputStateOffset,
             this.outputStateOffset
         ];
-        const addressing = Addressing.fromWire(this.indirect, operands.length);
         const [inputOffset, outputOffset] = addressing.resolve(operands, memory);
         const inputState = memory.getSlice(inputOffset, Poseidon2.stateSize);
         memory.checkTagsRange(TypeTag.FIELD, inputOffset, Poseidon2.stateSize);
@@ -55,13 +55,13 @@ export class KeccakF1600 extends Instruction {
     async execute(context) {
         const inputSize = 25;
         const memory = context.machineState.memory;
+        const addressing = Addressing.fromWire(this.indirect);
+        context.machineState.consumeGas(this.baseGasCost(addressing.indirectOperandsCount(), addressing.relativeOperandsCount()));
         const operands = [
             this.dstOffset,
             this.inputOffset
         ];
-        const addressing = Addressing.fromWire(this.indirect, operands.length);
         const [dstOffset, inputOffset] = addressing.resolve(operands, memory);
-        context.machineState.consumeGas(this.gasCost());
         const stateData = memory.getSlice(inputOffset, inputSize).map((word)=>word.toBigInt());
         memory.checkTagsRange(TypeTag.UINT64, inputOffset, inputSize);
         const updatedState = keccakf1600(stateData);
@@ -91,15 +91,15 @@ export class Sha256Compression extends Instruction {
         const STATE_SIZE = 8;
         const INPUTS_SIZE = 16;
         const memory = context.machineState.memory;
+        const addressing = Addressing.fromWire(this.indirect);
+        context.machineState.consumeGas(this.baseGasCost(addressing.indirectOperandsCount(), addressing.relativeOperandsCount()));
         const operands = [
             this.outputOffset,
             this.stateOffset,
             this.inputsOffset
         ];
-        const addressing = Addressing.fromWire(this.indirect, operands.length);
         const [outputOffset, stateOffset, inputsOffset] = addressing.resolve(operands, memory);
         // Note: size of output is same as size of state
-        context.machineState.consumeGas(this.gasCost());
         const inputs = Uint32Array.from(memory.getSlice(inputsOffset, INPUTS_SIZE).map((word)=>word.toNumber()));
         const state = Uint32Array.from(memory.getSlice(stateOffset, STATE_SIZE).map((word)=>word.toNumber()));
         memory.checkTagsRange(TypeTag.UINT32, inputsOffset, INPUTS_SIZE);

package/dest/public/avm/opcodes/instruction.d.ts

@@ -1,9 +1,7 @@
-/// <reference types="node" resolution-mode="require"/>
-/// <reference types="node" resolution-mode="require"/>
+import type { Bufferable } from '@aztec/foundation/serialize';
 import type { AvmContext } from '../avm_context.js';
 import { type Gas } from '../avm_gas.js';
 import type { BufferCursor } from '../serialization/buffer_cursor.js';
-import type { Serializable } from '../serialization/bytecode_serialization.js';
 import { Opcode, type OperandType } from '../serialization/instruction_serialization.js';
 type InstructionConstructor = {
     new (...args: any[]): Instruction;
@@ -29,18 +27,18 @@ export declare abstract class Instruction {
      * @returns Thee string representation.
      */
     toString(): string;
-    static deserialize(this: InstructionConstructor & {
+    static fromBuffer(this: InstructionConstructor & {
         wireFormat: OperandType[];
         as: any;
     }, buf: BufferCursor | Buffer): Instruction;
-    serialize(): Buffer;
+    toBuffer(): Buffer;
     /**
      * Returns a new instruction instance that can be serialized with the given opcode and wire format.
      * @param opcode The opcode of the instruction.
      * @param wireFormat The wire format of the instruction.
      * @returns The new instruction instance.
      */
-    as(opcode: Opcode, wireFormat: OperandType[]): Instruction & Serializable;
+    as(opcode: Opcode, wireFormat: OperandType[]): Instruction & Bufferable;
     /**
      * Returns a new instruction class that can be deserialized with the given opcode and wire format.
      * @param opcode The opcode of the instruction.
@@ -48,13 +46,19 @@ export declare abstract class Instruction {
      * @returns The new instruction class.
      */
     static as(this: InstructionConstructor, wireFormat: OperandType[]): InstructionConstructor & {
-        deserialize: (buf: BufferCursor | Buffer) => Instruction;
+        fromBuffer: (buf: BufferCursor | Buffer) => Instruction;
     };
     /**
-     * Computes gas cost for the instruction based on its base cost and memory operations.
-     * @returns Gas cost.
+     * Returns the base gas cost for the instruction.
+     * @returns The base gas cost.
      */
-    protected gasCost(dynMultiplier?: number): Gas;
+    protected baseGasCost(indirectOperandsCount: number, relativeOperandsCount: number): Gas;
+    /**
+     * Computes the dynamic gas cost for the instruction
+     * @param dynMultiplier - The multiplier for the dynamic gas cost.
+     * @returns The dynamic gas cost.
+     */
+    protected dynamicGasCost(dynMultiplier?: number): Gas;
     /**
      * Returns the stringified type of the instruction.
      * Instruction sub-classes should have a static `type` property.

package/dest/public/avm/opcodes/instruction.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"instruction.d.ts","sourceRoot":"","sources":["../../../../src/public/avm/opcodes/instruction.ts"],"names":[],"mappings":";;AAEA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AACpD,OAAO,EAAE,KAAK,GAAG,EAAqD,MAAM,eAAe,CAAC;AAC5F,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,mCAAmC,CAAC;AACtE,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,4CAA4C,CAAC;AAC/E,OAAO,EAAE,MAAM,EAAE,KAAK,WAAW,EAA4B,MAAM,+CAA+C,CAAC;AAEnH,KAAK,sBAAsB,GAAG;IAC5B,KAAK,GAAG,IAAI,EAAE,GAAG,EAAE,GAAG,WAAW,CAAC;CACnC,CAAC;AAEF;;;GAGG;AACH,8BAAsB,WAAW;IAC/B;;;;OAIG;aACa,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;IAE3D;;OAEG;IACI,SAAS,IAAI,OAAO;IAI3B;;;;OAIG;IACI,QAAQ,IAAI,MAAM;WAUX,WAAW,CACvB,IAAI,EAAE,sBAAsB,GAAG;QAAE,UAAU,EAAE,WAAW,EAAE,CAAC;QAAC,EAAE,EAAE,GAAG,CAAA;KAAE,EACrE,GAAG,EAAE,YAAY,GAAG,MAAM,GACzB,WAAW;IAKP,SAAS,IAAI,MAAM;IAO1B;;;;;OAKG;IACI,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,UAAU,EAAE,WAAW,EAAE,GAAG,WAAW,GAAG,YAAY;IAShF;;;;;OAKG;WACW,EAAE,CAAC,IAAI,EAAE,sBAAsB,EAAE,UAAU,EAAE,WAAW,EAAE;2BAEjD,YAAY,GAAG,MAAM,KAAG,WAAW;;IAQ1D;;;OAGG;IACH,SAAS,CAAC,OAAO,CAAC,aAAa,GAAE,MAAU,GAAG,GAAG;IAMjD;;;OAGG;IACH,IAAW,IAAI,IAAI,MAAM,CAMxB;IAED;;;OAGG;IACH,IAAW,MAAM,IAAI,MAAM,CAM1B;CACF"}
+{"version":3,"file":"instruction.d.ts","sourceRoot":"","sources":["../../../../src/public/avm/opcodes/instruction.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAI9D,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AACpD,OAAO,EAAE,KAAK,GAAG,EAA4E,MAAM,eAAe,CAAC;AACnH,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,mCAAmC,CAAC;AACtE,OAAO,EAAE,MAAM,EAAE,KAAK,WAAW,EAA4B,MAAM,+CAA+C,CAAC;AAEnH,KAAK,sBAAsB,GAAG;IAC5B,KAAK,GAAG,IAAI,EAAE,GAAG,EAAE,GAAG,WAAW,CAAC;CACnC,CAAC;AAEF;;;GAGG;AACH,8BAAsB,WAAW;IAC/B;;;;OAIG;aACa,OAAO,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC;IAE3D;;OAEG;IACI,SAAS,IAAI,OAAO;IAI3B;;;;OAIG;IACI,QAAQ,IAAI,MAAM;WAYX,UAAU,CACtB,IAAI,EAAE,sBAAsB,GAAG;QAAE,UAAU,EAAE,WAAW,EAAE,CAAC;QAAC,EAAE,EAAE,GAAG,CAAA;KAAE,EACrE,GAAG,EAAE,YAAY,GAAG,MAAM,GACzB,WAAW;IAKP,QAAQ,IAAI,MAAM;IAOzB;;;;;OAKG;IACI,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,UAAU,EAAE,WAAW,EAAE,GAAG,WAAW,GAAG,UAAU;IAS9E;;;;;OAKG;WACW,EAAE,CAAC,IAAI,EAAE,sBAAsB,EAAE,UAAU,EAAE,WAAW,EAAE;0BAElD,YAAY,GAAG,MAAM,KAAG,WAAW;;IAQzD;;;OAGG;IACH,SAAS,CAAC,WAAW,CAAC,qBAAqB,EAAE,MAAM,EAAE,qBAAqB,EAAE,MAAM,GAAG,GAAG;IAIxF;;;;OAIG;IACH,SAAS,CAAC,cAAc,CAAC,aAAa,GAAE,MAAU,GAAG,GAAG;IAIxD;;;OAGG;IACH,IAAW,IAAI,IAAI,MAAM,CAIxB;IAED;;;OAGG;IACH,IAAW,MAAM,IAAI,MAAM,CAQ1B;CACF"}

package/dest/public/avm/opcodes/instruction.js

@@ -1,5 +1,5 @@
 import { strict as assert } from 'assert';
-import { getBaseGasCost, getDynamicGasCost, mulGas, sumGas } from '../avm_gas.js';
+import { computeAddressingCost, getBaseGasCost, getDynamicGasCost, mulGas, sumGas } from '../avm_gas.js';
 import { Opcode, deserialize, serializeAs } from '../serialization/instruction_serialization.js';
 /**
  * Parent class for all AVM instructions.
@@ -15,6 +15,8 @@ import { Opcode, deserialize, serializeAs } from '../serialization/instruction_s
    * the instruction sub-class name all of its flags and operands.
    * @returns Thee string representation.
    */ toString() {
+        // Note: we could have this be the actual wire opcode if `bytecode_serialization.ts` were to
+        // pass it into the class' static `Instruction.as(this, wireFormat)` method.
         let instructionStr = this.constructor.name + ': ';
         // assumes that all properties are flags or operands
         for (const prop of Object.getOwnPropertyNames(this)){
@@ -23,15 +25,15 @@ import { Opcode, deserialize, serializeAs } from '../serialization/instruction_s
         return instructionStr;
     }
     // Default deserialization which uses Class.opcode and Class.wireFormat.
-    static deserialize(buf) {
-        return this.as(this.wireFormat).deserialize(buf);
+    static fromBuffer(buf) {
+        return this.as(this.wireFormat).fromBuffer(buf);
     }
     // Default serialization which uses Class.opcode and Class.wireFormat.
-    serialize() {
+    toBuffer() {
         const klass = this.constructor;
         assert(klass.opcode !== undefined && klass.opcode !== null);
         assert(klass.wireFormat !== undefined && klass.wireFormat !== null);
-        return this.as(klass.opcode, klass.wireFormat).serialize();
+        return this.as(klass.opcode, klass.wireFormat).toBuffer();
     }
     /**
    * Returns a new instruction instance that can be serialized with the given opcode and wire format.
@@ -39,7 +41,7 @@ import { Opcode, deserialize, serializeAs } from '../serialization/instruction_s
    * @param wireFormat The wire format of the instruction.
    * @returns The new instruction instance.
    */ as(opcode, wireFormat) {
-        return Object.defineProperty(this, 'serialize', {
+        return Object.defineProperty(this, 'toBuffer', {
             value: ()=>{
                 return serializeAs(wireFormat, opcode, this);
             },
@@ -53,7 +55,7 @@ import { Opcode, deserialize, serializeAs } from '../serialization/instruction_s
    * @returns The new instruction class.
    */ static as(wireFormat) {
         return Object.assign(this, {
-            deserialize: (buf)=>{
+            fromBuffer: (buf)=>{
                 const res = deserialize(buf, wireFormat);
                 const args = res.slice(1); // Remove opcode.
                 return new this(...args);
@@ -61,21 +63,24 @@ import { Opcode, deserialize, serializeAs } from '../serialization/instruction_s
         });
     }
     /**
-   * Computes gas cost for the instruction based on its base cost and memory operations.
-   * @returns Gas cost.
-   */ gasCost(dynMultiplier = 0) {
-        const baseGasCost = getBaseGasCost(this.opcode);
-        const dynGasCost = mulGas(getDynamicGasCost(this.opcode), dynMultiplier);
-        return sumGas(baseGasCost, dynGasCost);
+   * Returns the base gas cost for the instruction.
+   * @returns The base gas cost.
+   */ baseGasCost(indirectOperandsCount, relativeOperandsCount) {
+        return sumGas(getBaseGasCost(this.opcode), computeAddressingCost(indirectOperandsCount, relativeOperandsCount));
+    }
+    /**
+   * Computes the dynamic gas cost for the instruction
+   * @param dynMultiplier - The multiplier for the dynamic gas cost.
+   * @returns The dynamic gas cost.
+   */ dynamicGasCost(dynMultiplier = 0) {
+        return mulGas(getDynamicGasCost(this.opcode), dynMultiplier);
     }
     /**
    * Returns the stringified type of the instruction.
    * Instruction sub-classes should have a static `type` property.
    */ get type() {
         const type = 'type' in this.constructor && this.constructor.type;
-        if (!type) {
-            throw new Error(`Instruction class ${this.constructor.name} does not have a static 'type' property defined.`);
-        }
+        assert(!!type, `Instruction class ${this.constructor.name} does not have a static 'type' property defined.`);
         return type;
     }
     /**
@@ -83,9 +88,8 @@ import { Opcode, deserialize, serializeAs } from '../serialization/instruction_s
    * Instruction sub-classes should have a static `opcode` property.
    */ get opcode() {
         const opcode = 'opcode' in this.constructor ? this.constructor.opcode : undefined;
-        if (opcode === undefined || Opcode[opcode] === undefined) {
-            throw new Error(`Instruction class ${this.constructor.name} does not have a static 'opcode' property defined.`);
-        }
+        assert(opcode !== undefined, `Instruction class ${this.constructor.name} does not have a static 'opcode' property defined.`);
+        assert(Opcode[opcode] !== undefined, `Invalid opcode ${opcode} for instruction class ${this.constructor.name}.`);
         return opcode;
     }
 }

package/dest/public/avm/opcodes/memory.d.ts

@@ -42,13 +42,13 @@ export declare class Mov extends Instruction {
 }
 export declare class CalldataCopy extends Instruction {
     private indirect;
-    private cdStartOffset;
     private copySizeOffset;
+    private cdStartOffset;
     private dstOffset;
     static readonly type: string;
     static readonly opcode: Opcode;
     static readonly wireFormat: OperandType[];
-    constructor(indirect: number, cdStartOffset: number, copySizeOffset: number, dstOffset: number);
+    constructor(indirect: number, copySizeOffset: number, cdStartOffset: number, dstOffset: number);
     execute(context: AvmContext): Promise<void>;
 }
 export declare class ReturndataSize extends Instruction {
@@ -62,13 +62,13 @@ export declare class ReturndataSize extends Instruction {
 }
 export declare class ReturndataCopy extends Instruction {
     private indirect;
-    private rdStartOffset;
     private copySizeOffset;
+    private rdStartOffset;
     private dstOffset;
     static readonly type: string;
     static readonly opcode: Opcode;
     static readonly wireFormat: OperandType[];
-    constructor(indirect: number, rdStartOffset: number, copySizeOffset: number, dstOffset: number);
+    constructor(indirect: number, copySizeOffset: number, rdStartOffset: number, dstOffset: number);
     execute(context: AvmContext): Promise<void>;
 }
 //# sourceMappingURL=memory.d.ts.map