@aztec/sequencer-client 0.0.1-commit.f504929 → 0.0.1-commit.f650c0a5c

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (59) hide show
  1. package/dest/client/sequencer-client.d.ts +4 -1
  2. package/dest/client/sequencer-client.d.ts.map +1 -1
  3. package/dest/client/sequencer-client.js +46 -27
  4. package/dest/config.d.ts +25 -5
  5. package/dest/config.d.ts.map +1 -1
  6. package/dest/config.js +21 -12
  7. package/dest/global_variable_builder/global_builder.d.ts +15 -9
  8. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  9. package/dest/global_variable_builder/global_builder.js +29 -25
  10. package/dest/global_variable_builder/index.d.ts +2 -2
  11. package/dest/global_variable_builder/index.d.ts.map +1 -1
  12. package/dest/publisher/config.d.ts +13 -1
  13. package/dest/publisher/config.d.ts.map +1 -1
  14. package/dest/publisher/config.js +17 -2
  15. package/dest/publisher/sequencer-publisher-factory.d.ts +3 -5
  16. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  17. package/dest/publisher/sequencer-publisher-factory.js +2 -3
  18. package/dest/publisher/sequencer-publisher.d.ts +58 -32
  19. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  20. package/dest/publisher/sequencer-publisher.js +132 -89
  21. package/dest/sequencer/checkpoint_proposal_job.d.ts +36 -9
  22. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  23. package/dest/sequencer/checkpoint_proposal_job.js +302 -180
  24. package/dest/sequencer/checkpoint_voter.d.ts +1 -2
  25. package/dest/sequencer/checkpoint_voter.d.ts.map +1 -1
  26. package/dest/sequencer/checkpoint_voter.js +2 -5
  27. package/dest/sequencer/events.d.ts +2 -1
  28. package/dest/sequencer/events.d.ts.map +1 -1
  29. package/dest/sequencer/metrics.d.ts +5 -1
  30. package/dest/sequencer/metrics.d.ts.map +1 -1
  31. package/dest/sequencer/metrics.js +11 -0
  32. package/dest/sequencer/sequencer.d.ts +23 -10
  33. package/dest/sequencer/sequencer.d.ts.map +1 -1
  34. package/dest/sequencer/sequencer.js +130 -71
  35. package/dest/sequencer/timetable.d.ts +7 -3
  36. package/dest/sequencer/timetable.d.ts.map +1 -1
  37. package/dest/sequencer/timetable.js +21 -12
  38. package/dest/sequencer/types.d.ts +2 -2
  39. package/dest/sequencer/types.d.ts.map +1 -1
  40. package/dest/test/mock_checkpoint_builder.d.ts +7 -9
  41. package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
  42. package/dest/test/mock_checkpoint_builder.js +39 -30
  43. package/package.json +27 -28
  44. package/src/client/sequencer-client.ts +56 -28
  45. package/src/config.ts +28 -14
  46. package/src/global_variable_builder/global_builder.ts +37 -26
  47. package/src/global_variable_builder/index.ts +1 -1
  48. package/src/publisher/config.ts +32 -0
  49. package/src/publisher/sequencer-publisher-factory.ts +3 -6
  50. package/src/publisher/sequencer-publisher.ts +205 -127
  51. package/src/sequencer/README.md +81 -12
  52. package/src/sequencer/checkpoint_proposal_job.ts +385 -199
  53. package/src/sequencer/checkpoint_voter.ts +1 -12
  54. package/src/sequencer/events.ts +1 -1
  55. package/src/sequencer/metrics.ts +14 -0
  56. package/src/sequencer/sequencer.ts +186 -80
  57. package/src/sequencer/timetable.ts +26 -15
  58. package/src/sequencer/types.ts +1 -1
  59. package/src/test/mock_checkpoint_builder.ts +51 -48
@@ -436,20 +436,21 @@ function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
436
436
  return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
437
437
  }
438
438
  var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _initProto;
439
- import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
440
- import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
441
- import { BlockNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
439
+ import { RollupContract } from '@aztec/ethereum/contracts';
440
+ import { BlockNumber, CheckpointNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
442
441
  import { randomInt } from '@aztec/foundation/crypto/random';
443
442
  import { flipSignature, generateRecoverableSignature, generateUnrecoverableSignature } from '@aztec/foundation/crypto/secp256k1-signer';
443
+ import { Signature } from '@aztec/foundation/eth-signature';
444
444
  import { filter } from '@aztec/foundation/iterator';
445
445
  import { createLogger } from '@aztec/foundation/log';
446
446
  import { sleep, sleepUntil } from '@aztec/foundation/sleep';
447
447
  import { Timer } from '@aztec/foundation/timer';
448
448
  import { isErrorClass, unfreeze } from '@aztec/foundation/types';
449
449
  import { CommitteeAttestationsAndSigners, MaliciousCommitteeAttestationsAndSigners } from '@aztec/stdlib/block';
450
- import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
450
+ import { validateCheckpoint } from '@aztec/stdlib/checkpoint';
451
+ import { computeQuorum, getSlotStartBuildTimestamp, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
451
452
  import { Gas } from '@aztec/stdlib/gas';
452
- import { NoValidTxsError } from '@aztec/stdlib/interfaces/server';
453
+ import { InsufficientValidTxsError } from '@aztec/stdlib/interfaces/server';
453
454
  import { computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
454
455
  import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
455
456
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
@@ -463,7 +464,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
463
464
  return {
464
465
  // nullish operator needed for tests
465
466
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
466
- [Attributes.SLOT_NUMBER]: this.slot
467
+ [Attributes.SLOT_NUMBER]: this.targetSlot
467
468
  };
468
469
  }), _dec2 = trackSpan('CheckpointProposalJob.buildBlocksForCheckpoint'), _dec3 = trackSpan('CheckpointProposalJob.waitUntilNextSubslot'), _dec4 = trackSpan('CheckpointProposalJob.buildSingleBlock'), _dec5 = trackSpan('CheckpointProposalJob.waitForMinTxs'), _dec6 = trackSpan('CheckpointProposalJob.waitForAttestations'), _dec7 = trackSpan('CheckpointProposalJob.waitUntilTimeInSlot');
469
470
  /**
@@ -472,8 +473,9 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
472
473
  * as well as enqueueing votes for slashing and governance proposals. This class is created from
473
474
  * the Sequencer once the check for being the proposer for the slot has succeeded.
474
475
  */ export class CheckpointProposalJob {
475
- epoch;
476
- slot;
476
+ slotNow;
477
+ targetSlot;
478
+ targetEpoch;
477
479
  checkpointNumber;
478
480
  syncedToBlockNumber;
479
481
  proposer;
@@ -498,6 +500,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
498
500
  eventEmitter;
499
501
  setStateFn;
500
502
  tracer;
503
+ proposedCheckpointData;
501
504
  static{
502
505
  ({ e: [_initProto] } = _apply_decs_2203_r(this, [
503
506
  [
@@ -543,10 +546,13 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
543
546
  ], []));
544
547
  }
545
548
  log;
546
- constructor(epoch, slot, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
547
- proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, eventEmitter, setStateFn, tracer, bindings){
548
- this.epoch = epoch;
549
- this.slot = slot;
549
+ /** Tracks the fire-and-forget L1 submission promise so it can be awaited during shutdown. */ pendingL1Submission;
550
+ /** Fee header override computed during proposeCheckpoint, reused in enqueueCheckpointForSubmission. */ computedForceProposedFeeHeader;
551
+ constructor(slotNow, targetSlot, targetEpoch, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
552
+ proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, eventEmitter, setStateFn, tracer, bindings, proposedCheckpointData){
553
+ this.slotNow = slotNow;
554
+ this.targetSlot = targetSlot;
555
+ this.targetEpoch = targetEpoch;
550
556
  this.checkpointNumber = checkpointNumber;
551
557
  this.syncedToBlockNumber = syncedToBlockNumber;
552
558
  this.proposer = proposer;
@@ -571,22 +577,31 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
571
577
  this.eventEmitter = eventEmitter;
572
578
  this.setStateFn = setStateFn;
573
579
  this.tracer = tracer;
580
+ this.proposedCheckpointData = proposedCheckpointData;
574
581
  _initProto(this);
575
582
  this.log = createLogger('sequencer:checkpoint-proposal', {
576
583
  ...bindings,
577
- instanceId: `slot-${slot}`
584
+ instanceId: `slot-${this.slotNow}`
578
585
  });
579
586
  }
587
+ /** Awaits the pending L1 submission if one is in progress. Call during shutdown. */ async awaitPendingSubmission() {
588
+ this.log.info('Awaiting pending L1 payload submission');
589
+ await this.pendingL1Submission;
590
+ }
580
591
  /**
581
592
  * Executes the checkpoint proposal job.
582
- * Returns the published checkpoint if successful, undefined otherwise.
593
+ * Builds blocks, collects attestations, enqueues requests, and schedules L1 submission as a
594
+ * background task so the work loop can return to IDLE immediately.
595
+ * Returns the built checkpoint if successful, undefined otherwise.
583
596
  */ async execute() {
584
597
  // Enqueue governance and slashing votes (returns promises that will be awaited later)
585
598
  // In fisherman mode, we simulate slashing but don't actually publish to L1
586
599
  // These are constant for the whole slot, so we only enqueue them once
587
- const votesPromises = new CheckpointVoter(this.slot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
588
- // Build and propose the checkpoint. This will enqueue the request on the publisher if a checkpoint is built.
589
- const checkpoint = await this.proposeCheckpoint();
600
+ const votesPromises = new CheckpointVoter(this.targetSlot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
601
+ // Build and propose the checkpoint. Builds blocks, broadcasts, collects attestations, and signs.
602
+ // Does NOT enqueue to L1 yet — that happens after the pipeline sleep.
603
+ const proposalResult = await this.proposeCheckpoint();
604
+ const checkpoint = proposalResult?.checkpoint;
590
605
  // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
591
606
  await Promise.all(votesPromises);
592
607
  if (checkpoint) {
@@ -597,24 +612,71 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
597
612
  await this.handleCheckpointEndAsFisherman(checkpoint);
598
613
  return;
599
614
  }
600
- // Then send everything to L1
601
- const l1Response = await this.publisher.sendRequests();
602
- const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
603
- if (proposedAction) {
604
- this.eventEmitter.emit('checkpoint-published', {
605
- checkpoint: this.checkpointNumber,
606
- slot: this.slot
607
- });
608
- const coinbase = checkpoint?.header.coinbase;
609
- await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
610
- return checkpoint;
611
- } else if (checkpoint) {
612
- this.eventEmitter.emit('checkpoint-publish-failed', {
613
- ...l1Response,
614
- slot: this.slot
615
- });
616
- return undefined;
615
+ // Enqueue the checkpoint for L1 submission
616
+ if (proposalResult) {
617
+ try {
618
+ await this.enqueueCheckpointForSubmission(proposalResult);
619
+ } catch (err) {
620
+ this.log.error(`Failed to enqueue checkpoint for L1 submission at slot ${this.targetSlot}`, err);
621
+ // Continue to sendRequestsAt so votes are still sent
622
+ }
617
623
  }
624
+ // Compute the earliest time to submit: pipeline slot start when pipelining, now otherwise.
625
+ const submitAfter = this.epochCache.isProposerPipeliningEnabled() ? new Date(Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) * 1000) : new Date(this.dateProvider.now());
626
+ // Schedule L1 submission in the background so the work loop returns immediately.
627
+ // The publisher will sleep until submitAfter, then send the bundled requests.
628
+ // The promise is stored so it can be awaited during shutdown.
629
+ this.pendingL1Submission = this.publisher.sendRequestsAt(submitAfter).then(async (l1Response)=>{
630
+ const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
631
+ if (proposedAction) {
632
+ this.eventEmitter.emit('checkpoint-published', {
633
+ checkpoint: this.checkpointNumber,
634
+ slot: this.targetSlot
635
+ });
636
+ const coinbase = checkpoint?.header.coinbase;
637
+ await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
638
+ } else if (checkpoint) {
639
+ this.eventEmitter.emit('checkpoint-publish-failed', {
640
+ ...l1Response,
641
+ slot: this.targetSlot
642
+ });
643
+ if (this.epochCache.isProposerPipeliningEnabled()) {
644
+ this.metrics.recordPipelineDiscard();
645
+ }
646
+ }
647
+ }).catch((err)=>{
648
+ this.log.error(`Background L1 submission failed for slot ${this.targetSlot}`, err);
649
+ if (checkpoint) {
650
+ this.eventEmitter.emit('checkpoint-publish-failed', {
651
+ slot: this.targetSlot
652
+ });
653
+ if (this.epochCache.isProposerPipeliningEnabled()) {
654
+ this.metrics.recordPipelineDiscard();
655
+ }
656
+ }
657
+ });
658
+ // Return the built checkpoint immediately — the work loop is now unblocked
659
+ return checkpoint;
660
+ }
661
+ /** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */ async enqueueCheckpointForSubmission(result) {
662
+ const { checkpoint, attestations, attestationsSignature } = result;
663
+ this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.targetSlot);
664
+ const aztecSlotDuration = this.l1Constants.slotDuration;
665
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
666
+ const txTimeoutAt = new Date((submissionSlotStart + aztecSlotDuration) * 1000);
667
+ // If we have been configured to potentially skip publishing checkpoint then roll the dice here
668
+ if (this.config.skipPublishingCheckpointsPercent !== undefined && this.config.skipPublishingCheckpointsPercent > 0) {
669
+ const roll = Math.max(0, randomInt(100));
670
+ if (roll < this.config.skipPublishingCheckpointsPercent) {
671
+ this.log.warn(`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${roll}`);
672
+ return;
673
+ }
674
+ }
675
+ await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
676
+ txTimeoutAt,
677
+ forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
678
+ forceProposedFeeHeader: this.computedForceProposedFeeHeader
679
+ });
618
680
  }
619
681
  async proposeCheckpoint() {
620
682
  try {
@@ -628,19 +690,37 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
628
690
  const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
629
691
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
630
692
  // Start the checkpoint
631
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.slot);
632
- this.metrics.incOpenSlot(this.slot, this.proposer?.toString() ?? 'unknown');
693
+ this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.targetSlot);
694
+ this.log.info(`Starting checkpoint proposal`, {
695
+ buildSlot: this.slotNow,
696
+ submissionSlot: this.targetSlot,
697
+ pipelining: this.epochCache.isProposerPipeliningEnabled(),
698
+ proposer: this.proposer?.toString(),
699
+ coinbase: coinbase.toString()
700
+ });
701
+ this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
633
702
  // Enqueues checkpoint invalidation (constant for the whole slot)
634
703
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
635
704
  this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
636
705
  }
637
- // Create checkpoint builder for the slot
638
- const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.slot);
706
+ // Create checkpoint builder for the slot.
707
+ // When pipelining, force the proposed checkpoint number and fee header to our parent so the
708
+ // fee computation sees the same chain tip that L1 will see once the previous pipelined checkpoint lands.
709
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
710
+ const parentCheckpointNumber = isPipelining ? CheckpointNumber(this.checkpointNumber - 1) : undefined;
711
+ // Compute the parent's fee header override when pipelining
712
+ if (isPipelining && this.proposedCheckpointData) {
713
+ this.computedForceProposedFeeHeader = await this.computeForceProposedFeeHeader(parentCheckpointNumber);
714
+ }
715
+ const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.targetSlot, {
716
+ forcePendingCheckpointNumber: parentCheckpointNumber,
717
+ forceProposedFeeHeader: this.computedForceProposedFeeHeader
718
+ });
639
719
  // Collect L1 to L2 messages for the checkpoint and compute their hash
640
720
  const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(this.checkpointNumber);
641
721
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
642
722
  // Collect the out hashes of all the checkpoints before this one in the same epoch
643
- const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.epoch)).filter((c)=>c.checkpointNumber < this.checkpointNumber).map((c)=>c.checkpointOutHash);
723
+ const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.targetEpoch)).filter((c)=>c.checkpointNumber < this.checkpointNumber).map((c)=>c.checkpointOutHash);
644
724
  // Get the fee asset price modifier from the oracle
645
725
  const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier();
646
726
  const fork = _ts_add_disposable_resource(env, await this.worldState.fork(this.syncedToBlockNumber, {
@@ -675,18 +755,18 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
675
755
  throw err;
676
756
  }
677
757
  if (blocksInCheckpoint.length === 0) {
678
- this.log.warn(`No blocks were built for slot ${this.slot}`, {
679
- slot: this.slot
758
+ this.log.warn(`No blocks were built for slot ${this.targetSlot}`, {
759
+ slot: this.targetSlot
680
760
  });
681
761
  this.eventEmitter.emit('checkpoint-empty', {
682
- slot: this.slot
762
+ slot: this.targetSlot
683
763
  });
684
764
  return undefined;
685
765
  }
686
766
  const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
687
767
  if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
688
768
  this.log.warn(`Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`, {
689
- slot: this.slot,
769
+ slot: this.targetSlot,
690
770
  blocksBuilt: blocksInCheckpoint.length,
691
771
  minBlocksForCheckpoint
692
772
  });
@@ -694,31 +774,45 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
694
774
  }
695
775
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
696
776
  // broadcasted yet, and wait to collect the committee attestations.
697
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
777
+ this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.targetSlot);
698
778
  const checkpoint = await checkpointBuilder.completeCheckpoint();
779
+ // Final validation: per-block limits are only checked if the operator set them explicitly.
780
+ // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
781
+ try {
782
+ validateCheckpoint(checkpoint, {
783
+ rollupManaLimit: this.l1Constants.rollupManaLimit,
784
+ maxL2BlockGas: this.config.maxL2BlockGas,
785
+ maxDABlockGas: this.config.maxDABlockGas,
786
+ maxTxsPerBlock: this.config.maxTxsPerBlock,
787
+ maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint
788
+ });
789
+ } catch (err) {
790
+ this.log.error(`Built an invalid checkpoint at slot ${this.slotNow} (skipping proposal)`, err, {
791
+ checkpoint: checkpoint.header.toInspect()
792
+ });
793
+ return undefined;
794
+ }
699
795
  // Record checkpoint-level build metrics
700
796
  this.metrics.recordCheckpointBuild(checkpointBuildTimer.ms(), blocksInCheckpoint.length, checkpoint.getStats().txCount, Number(checkpoint.header.totalManaUsed.toBigInt()));
701
797
  // Do not collect attestations nor publish to L1 in fisherman mode
702
798
  if (this.config.fishermanMode) {
703
- this.log.info(`Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
704
- slot: this.slot,
799
+ this.log.info(`Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
800
+ slot: this.targetSlot,
705
801
  checkpoint: checkpoint.header.toInspect(),
706
802
  blocksBuilt: blocksInCheckpoint.length
707
803
  });
708
804
  this.metrics.recordCheckpointSuccess();
709
- return checkpoint;
805
+ return {
806
+ checkpoint,
807
+ attestations: CommitteeAttestationsAndSigners.empty(),
808
+ attestationsSignature: Signature.empty()
809
+ };
710
810
  }
711
- // Include the block pending broadcast in the checkpoint proposal if any
712
- const lastBlock = blockPendingBroadcast && {
713
- blockHeader: blockPendingBroadcast.block.header,
714
- indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
715
- txs: blockPendingBroadcast.txs
716
- };
717
811
  // Create the checkpoint proposal and broadcast it
718
- const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, feeAssetPriceModifier, lastBlock, this.proposer, checkpointProposalOptions);
812
+ const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, feeAssetPriceModifier, blockPendingBroadcast, this.proposer, checkpointProposalOptions);
719
813
  const blockProposedAt = this.dateProvider.now();
720
814
  await this.p2pClient.broadcastCheckpointProposal(proposal);
721
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
815
+ this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.targetSlot);
722
816
  const attestations = await this.waitForAttestations(proposal);
723
817
  const blockAttestedAt = this.dateProvider.now();
724
818
  this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
@@ -726,7 +820,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
726
820
  const signer = this.proposer ?? this.publisher.getSenderAddress();
727
821
  let attestationsSignature;
728
822
  try {
729
- attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.slot, this.checkpointNumber);
823
+ attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.targetSlot, this.checkpointNumber);
730
824
  } catch (err) {
731
825
  // We shouldn't really get here since we yield to another HA node
732
826
  // as soon as we see these errors when creating block or checkpoint proposals.
@@ -735,24 +829,12 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
735
829
  }
736
830
  throw err;
737
831
  }
738
- // Enqueue publishing the checkpoint to L1
739
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
740
- const aztecSlotDuration = this.l1Constants.slotDuration;
741
- const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
742
- const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
743
- // If we have been configured to potentially skip publishing checkpoint then roll the dice here
744
- if (this.config.skipPublishingCheckpointsPercent !== undefined && this.config.skipPublishingCheckpointsPercent > 0) {
745
- const result = Math.max(0, randomInt(100));
746
- if (result < this.config.skipPublishingCheckpointsPercent) {
747
- this.log.warn(`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${result}`);
748
- return checkpoint;
749
- }
750
- }
751
- await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
752
- txTimeoutAt,
753
- forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber
754
- });
755
- return checkpoint;
832
+ // Return the result for the caller to enqueue after the pipeline sleep
833
+ return {
834
+ checkpoint,
835
+ attestations,
836
+ attestationsSignature
837
+ };
756
838
  } catch (e) {
757
839
  env.error = e;
758
840
  env.hasError = true;
@@ -765,7 +847,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
765
847
  // swallow this error. It's already been logged by a function deeper in the stack
766
848
  return undefined;
767
849
  }
768
- this.log.error(`Error building checkpoint at slot ${this.slot}`, err);
850
+ this.log.error(`Error building checkpoint at slot ${this.targetSlot}`, err);
769
851
  return undefined;
770
852
  }
771
853
  }
@@ -775,8 +857,6 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
775
857
  const blocksInCheckpoint = [];
776
858
  const txHashesAlreadyIncluded = new Set();
777
859
  const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
778
- // Remaining blob fields available for blocks (checkpoint end marker already subtracted)
779
- let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
780
860
  // Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
781
861
  let blockPendingBroadcast = undefined;
782
862
  while(true){
@@ -787,7 +867,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
787
867
  const timingInfo = this.timetable.canStartNextBlock(secondsIntoSlot);
788
868
  if (!timingInfo.canStart) {
789
869
  this.log.debug(`Not enough time left in slot to start another block`, {
790
- slot: this.slot,
870
+ slot: this.targetSlot,
791
871
  blocksBuilt,
792
872
  secondsIntoSlot
793
873
  });
@@ -802,68 +882,57 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
802
882
  buildDeadline: timingInfo.deadline ? new Date((this.getSlotStartBuildTimestamp() + timingInfo.deadline) * 1000) : undefined,
803
883
  blockNumber,
804
884
  indexWithinCheckpoint,
805
- txHashesAlreadyIncluded,
806
- remainingBlobFields
885
+ txHashesAlreadyIncluded
807
886
  });
808
- // TODO(palla/mbps): Review these conditions. We may want to keep trying in some scenarios.
809
- if (!buildResult && timingInfo.isLastBlock) {
810
- break;
811
- } else if (!buildResult && timingInfo.deadline !== undefined) {
812
- // But if there is still time for more blocks, wait until the next subslot and try again
887
+ // If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
888
+ if ('failure' in buildResult) {
889
+ // If this was the last subslot, or we're running with a single block per slot, we're done
890
+ if (timingInfo.isLastBlock || timingInfo.deadline === undefined) {
891
+ break;
892
+ }
893
+ // Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
813
894
  await this.waitUntilNextSubslot(timingInfo.deadline);
814
895
  continue;
815
- } else if (!buildResult) {
816
- break;
817
- } else if ('error' in buildResult) {
818
- // If there was an error building the block, just exit the loop and give up the rest of the slot
896
+ }
897
+ // If there was an error building the block, we just exit the loop and give up the rest of the slot.
898
+ // We don't want to risk building more blocks if something went wrong.
899
+ if ('error' in buildResult) {
819
900
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
820
- this.log.warn(`Halting block building for slot ${this.slot}`, {
821
- slot: this.slot,
901
+ this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
902
+ slot: this.targetSlot,
822
903
  blocksBuilt,
823
904
  error: buildResult.error
824
905
  });
825
906
  }
826
907
  break;
827
908
  }
828
- const { block, usedTxs, remainingBlobFields: newRemainingBlobFields } = buildResult;
909
+ const { block, usedTxs } = buildResult;
829
910
  blocksInCheckpoint.push(block);
830
- // Update remaining blob fields for the next block
831
- remainingBlobFields = newRemainingBlobFields;
832
- // Sync the proposed block to the archiver to make it available
833
- // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
834
- // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
835
- // Fire and forget - don't block the critical path, but log errors
836
- this.syncProposedBlockToArchiver(block).catch((err)=>{
837
- this.log.error(`Failed to sync proposed block ${block.number} to archiver`, {
838
- blockNumber: block.number,
839
- err
840
- });
841
- });
842
911
  usedTxs.forEach((tx)=>txHashesAlreadyIncluded.add(tx.txHash.toString()));
843
- // If this is the last block, exit the loop now so we start collecting attestations
912
+ // Sign the block proposal. This will throw if HA signing fails.
913
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, blockProposalOptions);
914
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
915
+ // so we avoid polluting our archive with a block that would fail.
916
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
917
+ // If this throws, we abort the entire checkpoint.
918
+ await this.syncProposedBlockToArchiver(block);
919
+ // If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
844
920
  if (timingInfo.isLastBlock) {
845
- this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
846
- slot: this.slot,
921
+ this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
922
+ slot: this.targetSlot,
847
923
  blockNumber,
848
924
  blocksBuilt
849
925
  });
850
- blockPendingBroadcast = {
851
- block,
852
- txs: usedTxs
853
- };
926
+ blockPendingBroadcast = proposal;
854
927
  break;
855
928
  }
856
- // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
857
- // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
858
- if (!this.config.fishermanMode) {
859
- const proposal = await this.validatorClient.createBlockProposal(block.header, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
860
- await this.p2pClient.broadcastProposal(proposal);
861
- }
929
+ // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
930
+ proposal && await this.p2pClient.broadcastProposal(proposal);
862
931
  // Wait until the next block's start time
863
932
  await this.waitUntilNextSubslot(timingInfo.deadline);
864
933
  }
865
- this.log.verbose(`Block building loop completed for slot ${this.slot}`, {
866
- slot: this.slot,
934
+ this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
935
+ slot: this.targetSlot,
867
936
  blocksBuilt: blocksInCheckpoint.length
868
937
  });
869
938
  return {
@@ -871,82 +940,92 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
871
940
  blockPendingBroadcast
872
941
  };
873
942
  }
943
+ /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */ createBlockProposal(block, inHash, usedTxs, blockProposalOptions) {
944
+ if (this.config.fishermanMode) {
945
+ this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
946
+ return Promise.resolve(undefined);
947
+ }
948
+ return this.validatorClient.createBlockProposal(block.header, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
949
+ }
874
950
  /** Sleeps until it is time to produce the next block in the slot */ async waitUntilNextSubslot(nextSubslotStart) {
875
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
951
+ this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.targetSlot);
876
952
  this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
877
- slot: this.slot
953
+ slot: this.targetSlot
878
954
  });
879
955
  await this.waitUntilTimeInSlot(nextSubslotStart);
880
956
  }
881
957
  /** Builds a single block. Called from the main block building loop. */ async buildSingleBlock(checkpointBuilder, opts) {
882
- const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded, remainingBlobFields } = opts;
883
- this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`, {
958
+ const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } = opts;
959
+ this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`, {
884
960
  ...checkpointBuilder.getConstantData(),
885
961
  ...opts
886
962
  });
887
963
  try {
888
964
  // Wait until we have enough txs to build the block
889
- const minTxs = this.config.minTxsPerBlock;
890
- const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
965
+ const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
891
966
  if (!canStartBuilding) {
892
- this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`, {
967
+ this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (got ${availableTxs} txs but needs ${minTxs})`, {
893
968
  blockNumber,
894
- slot: this.slot,
969
+ slot: this.targetSlot,
895
970
  indexWithinCheckpoint
896
971
  });
897
972
  this.eventEmitter.emit('block-tx-count-check-failed', {
898
973
  minTxs,
899
974
  availableTxs,
900
- slot: this.slot
975
+ slot: this.targetSlot
901
976
  });
902
977
  this.metrics.recordBlockProposalFailed('insufficient_txs');
903
- return undefined;
978
+ return {
979
+ failure: 'insufficient-txs'
980
+ };
904
981
  }
905
982
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
906
983
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
907
984
  const pendingTxs = filter(this.p2pClient.iterateEligiblePendingTxs(), (tx)=>!txHashesAlreadyIncluded.has(tx.txHash.toString()));
908
- this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`, {
909
- slot: this.slot,
985
+ this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot} with ${availableTxs} available txs`, {
986
+ slot: this.targetSlot,
910
987
  blockNumber,
911
988
  indexWithinCheckpoint
912
989
  });
913
- this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
914
- // Calculate blob fields limit for txs (remaining capacity - this block's end overhead)
915
- const blockEndOverhead = getNumBlockEndBlobFields(indexWithinCheckpoint === 0);
916
- const maxBlobFieldsForTxs = remainingBlobFields - blockEndOverhead;
990
+ this.setStateFn(SequencerState.CREATING_BLOCK, this.targetSlot);
991
+ // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
992
+ // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
993
+ // minValidTxs is passed into the builder so it can reject the block *before* updating state.
994
+ const minValidTxs = forceCreate ? 0 : this.config.minValidTxsPerBlock ?? minTxs;
917
995
  const blockBuilderOptions = {
918
996
  maxTransactions: this.config.maxTxsPerBlock,
919
- maxBlockSize: this.config.maxBlockSizeInBytes,
920
- maxBlockGas: new Gas(this.config.maxDABlockGas, this.config.maxL2BlockGas),
921
- maxBlobFields: maxBlobFieldsForTxs,
922
- deadline: buildDeadline
997
+ maxBlockGas: this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity) : undefined,
998
+ deadline: buildDeadline,
999
+ isBuildingProposal: true,
1000
+ minValidTxs,
1001
+ maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
1002
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier
923
1003
  };
924
- // Actually build the block by executing txs
1004
+ // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
1005
+ // if the number of successfully processed txs is below minValidTxs, ensuring state is not
1006
+ // updated for blocks that will be discarded.
925
1007
  const buildResult = await this.buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
926
1008
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
927
1009
  await this.dropFailedTxsFromP2P(buildResult.failedTxs);
928
- // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
929
- // too long, then we may not get to minTxsPerBlock after executing public functions.
930
- const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
931
- const numTxs = buildResult.status === 'no-valid-txs' ? 0 : buildResult.numTxs;
932
- if (buildResult.status === 'no-valid-txs' || !forceCreate && numTxs < minValidTxs) {
933
- this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed`, {
934
- slot: this.slot,
1010
+ if (buildResult.status === 'insufficient-valid-txs') {
1011
+ this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`, {
1012
+ slot: this.targetSlot,
935
1013
  blockNumber,
936
- numTxs,
1014
+ numTxs: buildResult.processedCount,
937
1015
  indexWithinCheckpoint,
938
- minValidTxs,
939
- buildResult: buildResult.status
1016
+ minValidTxs
940
1017
  });
941
1018
  this.eventEmitter.emit('block-build-failed', {
942
1019
  reason: `Insufficient valid txs`,
943
- slot: this.slot
1020
+ slot: this.targetSlot
944
1021
  });
945
1022
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
946
- return undefined;
1023
+ return {
1024
+ failure: 'insufficient-valid-txs'
1025
+ };
947
1026
  }
948
1027
  // Block creation succeeded, emit stats and metrics
949
- const { publicGas, block, publicProcessorDuration, usedTxs, usedTxBlobFields, blockBuildDuration } = buildResult;
1028
+ const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
950
1029
  const blockStats = {
951
1030
  eventName: 'l2-block-built',
952
1031
  duration: blockBuildDuration,
@@ -955,31 +1034,33 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
955
1034
  };
956
1035
  const blockHash = await block.hash();
957
1036
  const txHashes = block.body.txEffects.map((tx)=>tx.txHash);
958
- const manaPerSec = publicGas.l2Gas / (blockBuildDuration / 1000);
959
- this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`, {
1037
+ const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
1038
+ this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`, {
960
1039
  blockHash,
961
1040
  txHashes,
962
1041
  manaPerSec,
963
1042
  ...blockStats
964
1043
  });
1044
+ // `slot` is the target/submission slot (may be one ahead when pipelining),
1045
+ // `buildSlot` is the wall-clock slot during which the block was actually built.
965
1046
  this.eventEmitter.emit('block-proposed', {
966
1047
  blockNumber: block.number,
967
- slot: this.slot
1048
+ slot: this.targetSlot,
1049
+ buildSlot: this.slotNow
968
1050
  });
969
- this.metrics.recordBuiltBlock(blockBuildDuration, publicGas.l2Gas);
1051
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe());
970
1052
  return {
971
1053
  block,
972
- usedTxs,
973
- remainingBlobFields: maxBlobFieldsForTxs - usedTxBlobFields
1054
+ usedTxs
974
1055
  };
975
1056
  } catch (err) {
976
1057
  this.eventEmitter.emit('block-build-failed', {
977
1058
  reason: err.message,
978
- slot: this.slot
1059
+ slot: this.targetSlot
979
1060
  });
980
1061
  this.log.error(`Error building block`, err, {
981
1062
  blockNumber,
982
- slot: this.slot
1063
+ slot: this.targetSlot
983
1064
  });
984
1065
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
985
1066
  this.metrics.recordFailedBlock();
@@ -988,7 +1069,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
988
1069
  };
989
1070
  }
990
1071
  }
991
- /** Uses the checkpoint builder to build a block, catching specific txs */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
1072
+ /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
992
1073
  try {
993
1074
  const workTimer = new Timer();
994
1075
  const result = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
@@ -999,10 +1080,11 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
999
1080
  status: 'success'
1000
1081
  };
1001
1082
  } catch (err) {
1002
- if (isErrorClass(err, NoValidTxsError)) {
1083
+ if (isErrorClass(err, InsufficientValidTxsError)) {
1003
1084
  return {
1004
1085
  failedTxs: err.failedTxs,
1005
- status: 'no-valid-txs'
1086
+ processedCount: err.processedCount,
1087
+ status: 'insufficient-valid-txs'
1006
1088
  };
1007
1089
  }
1008
1090
  throw err;
@@ -1021,14 +1103,15 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1021
1103
  if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
1022
1104
  return {
1023
1105
  canStartBuilding: false,
1024
- availableTxs: availableTxs
1106
+ availableTxs,
1107
+ minTxs
1025
1108
  };
1026
1109
  }
1027
1110
  // Wait a bit before checking again
1028
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.slot);
1029
- this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (have ${availableTxs} but need ${minTxs})`, {
1111
+ this.setStateFn(SequencerState.WAITING_FOR_TXS, this.targetSlot);
1112
+ this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (have ${availableTxs} but need ${minTxs})`, {
1030
1113
  blockNumber,
1031
- slot: this.slot,
1114
+ slot: this.targetSlot,
1032
1115
  indexWithinCheckpoint
1033
1116
  });
1034
1117
  await this.waitForTxsPollingInterval();
@@ -1036,7 +1119,8 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1036
1119
  }
1037
1120
  return {
1038
1121
  canStartBuilding: true,
1039
- availableTxs
1122
+ availableTxs,
1123
+ minTxs
1040
1124
  };
1041
1125
  }
1042
1126
  /**
@@ -1059,7 +1143,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1059
1143
  committee
1060
1144
  });
1061
1145
  }
1062
- const numberOfRequiredAttestations = Math.floor(committee.length * 2 / 3) + 1;
1146
+ const numberOfRequiredAttestations = computeQuorum(committee.length);
1063
1147
  if (this.config.skipCollectingAttestations) {
1064
1148
  this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
1065
1149
  const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
@@ -1164,8 +1248,12 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1164
1248
  * Adds the proposed block to the archiver so it's available via P2P.
1165
1249
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
1166
1250
  * would never receive its own block without this explicit sync.
1251
+ *
1252
+ * In fisherman mode we skip this push: the fisherman builds blocks locally for validation
1253
+ * and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
1254
+ * whenever the real proposer's block arrives from L1.
1167
1255
  */ async syncProposedBlockToArchiver(block) {
1168
- if (this.config.skipPushProposedBlocksToArchiver !== false) {
1256
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
1169
1257
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
1170
1258
  blockNumber: block.number,
1171
1259
  slot: block.header.globalVariables.slotNumber
@@ -1181,16 +1269,16 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1181
1269
  /** Runs fee analysis and logs checkpoint outcome as fisherman */ async handleCheckpointEndAsFisherman(checkpoint) {
1182
1270
  // Perform L1 fee analysis before clearing requests
1183
1271
  // The callback is invoked asynchronously after the next block is mined
1184
- const feeAnalysis = await this.publisher.analyzeL1Fees(this.slot, (analysis)=>this.metrics.recordFishermanFeeAnalysis(analysis));
1272
+ const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, (analysis)=>this.metrics.recordFishermanFeeAnalysis(analysis));
1185
1273
  if (checkpoint) {
1186
- this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.slot}`, {
1274
+ this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
1187
1275
  ...checkpoint.toCheckpointInfo(),
1188
1276
  ...checkpoint.getStats(),
1189
1277
  feeAnalysisId: feeAnalysis?.id
1190
1278
  });
1191
1279
  } else {
1192
- this.log.warn(`Validation block building FAILED for slot ${this.slot}`, {
1193
- slot: this.slot,
1280
+ this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
1281
+ slot: this.targetSlot,
1194
1282
  feeAnalysisId: feeAnalysis?.id
1195
1283
  });
1196
1284
  this.metrics.recordCheckpointProposalFailed('block_build_failed');
@@ -1201,15 +1289,15 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1201
1289
  * Helper to handle HA double-signing errors. Returns true if the error was handled (caller should yield).
1202
1290
  */ handleHASigningError(err, errorContext) {
1203
1291
  if (err instanceof DutyAlreadySignedError) {
1204
- this.log.info(`${errorContext} for slot ${this.slot} already signed by another HA node, yielding`, {
1205
- slot: this.slot,
1292
+ this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
1293
+ slot: this.targetSlot,
1206
1294
  signedByNode: err.signedByNode
1207
1295
  });
1208
1296
  return true;
1209
1297
  }
1210
1298
  if (err instanceof SlashingProtectionError) {
1211
- this.log.info(`${errorContext} for slot ${this.slot} blocked by slashing protection, yielding`, {
1212
- slot: this.slot,
1299
+ this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
1300
+ slot: this.targetSlot,
1213
1301
  existingMessageHash: err.existingMessageHash,
1214
1302
  attemptedMessageHash: err.attemptedMessageHash
1215
1303
  });
@@ -1217,6 +1305,40 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1217
1305
  }
1218
1306
  return false;
1219
1307
  }
1308
+ /**
1309
+ * In times of congestion we need to simulate using the correct fee header override for the previous block
1310
+ * We calculate the correct fee header values.
1311
+ *
1312
+ * If we are in block 1, or the checkpoint we are querying does not exist, we return undefined. However
1313
+ * If we are pipelining - where this function is called, the grandparentCheckpointNumber should always exist
1314
+ * @param parentCheckpointNumber
1315
+ * @returns
1316
+ */ async computeForceProposedFeeHeader(parentCheckpointNumber) {
1317
+ if (!this.proposedCheckpointData) {
1318
+ return undefined;
1319
+ }
1320
+ const rollup = this.publisher.rollupContract;
1321
+ const grandparentCheckpointNumber = CheckpointNumber(this.checkpointNumber - 2);
1322
+ try {
1323
+ const [grandparentCheckpoint, manaTarget] = await Promise.all([
1324
+ rollup.getCheckpoint(grandparentCheckpointNumber),
1325
+ rollup.getManaTarget()
1326
+ ]);
1327
+ if (!grandparentCheckpoint || !grandparentCheckpoint.feeHeader) {
1328
+ this.log.error(`Grandparent checkpoint or its feeHeader is undefined for checkpointNumber=${grandparentCheckpointNumber.toString()}`);
1329
+ return undefined;
1330
+ } else {
1331
+ const parentFeeHeader = RollupContract.computeChildFeeHeader(grandparentCheckpoint.feeHeader, this.proposedCheckpointData.totalManaUsed, this.proposedCheckpointData.feeAssetPriceModifier, manaTarget);
1332
+ return {
1333
+ checkpointNumber: parentCheckpointNumber,
1334
+ feeHeader: parentFeeHeader
1335
+ };
1336
+ }
1337
+ } catch (err) {
1338
+ this.log.error(`Failed to fetch grandparent checkpoint or mana target for checkpointNumber=${grandparentCheckpointNumber.toString()}: ${err}`);
1339
+ return undefined;
1340
+ }
1341
+ }
1220
1342
  /** Waits until a specific time within the current slot */ async waitUntilTimeInSlot(targetSecondsIntoSlot) {
1221
1343
  const slotStartTimestamp = this.getSlotStartBuildTimestamp();
1222
1344
  const targetTimestamp = slotStartTimestamp + targetSecondsIntoSlot;
@@ -1226,7 +1348,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1226
1348
  await sleep(TXS_POLLING_MS);
1227
1349
  }
1228
1350
  getSlotStartBuildTimestamp() {
1229
- return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
1351
+ return getSlotStartBuildTimestamp(this.slotNow, this.l1Constants);
1230
1352
  }
1231
1353
  getSecondsIntoSlot() {
1232
1354
  const slotStartTimestamp = this.getSlotStartBuildTimestamp();