@aztec/sequencer-client 0.0.1-commit.f504929 → 0.0.1-commit.f5a9928

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (117) hide show
  1. package/README.md +283 -21
  2. package/dest/client/sequencer-client.d.ts +23 -5
  3. package/dest/client/sequencer-client.d.ts.map +1 -1
  4. package/dest/client/sequencer-client.js +63 -36
  5. package/dest/config.d.ts +32 -3
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +81 -31
  8. package/dest/global_variable_builder/fee_predictor.d.ts +37 -0
  9. package/dest/global_variable_builder/fee_predictor.d.ts.map +1 -0
  10. package/dest/global_variable_builder/fee_predictor.js +138 -0
  11. package/dest/global_variable_builder/fee_provider.d.ts +21 -0
  12. package/dest/global_variable_builder/fee_provider.d.ts.map +1 -0
  13. package/dest/global_variable_builder/fee_provider.js +80 -0
  14. package/dest/global_variable_builder/global_builder.d.ts +13 -26
  15. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  16. package/dest/global_variable_builder/global_builder.js +9 -66
  17. package/dest/global_variable_builder/index.d.ts +4 -2
  18. package/dest/global_variable_builder/index.d.ts.map +1 -1
  19. package/dest/global_variable_builder/index.js +2 -0
  20. package/dest/publisher/config.d.ts +19 -3
  21. package/dest/publisher/config.d.ts.map +1 -1
  22. package/dest/publisher/config.js +30 -5
  23. package/dest/publisher/l1_to_l2_messaging.d.ts +21 -0
  24. package/dest/publisher/l1_to_l2_messaging.d.ts.map +1 -0
  25. package/dest/publisher/l1_to_l2_messaging.js +70 -0
  26. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +3 -4
  27. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -1
  28. package/dest/publisher/sequencer-bundle-simulator.d.ts +96 -0
  29. package/dest/publisher/sequencer-bundle-simulator.d.ts.map +1 -0
  30. package/dest/publisher/sequencer-bundle-simulator.js +198 -0
  31. package/dest/publisher/sequencer-publisher-factory.d.ts +3 -5
  32. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  33. package/dest/publisher/sequencer-publisher-factory.js +2 -3
  34. package/dest/publisher/sequencer-publisher.d.ts +91 -69
  35. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  36. package/dest/publisher/sequencer-publisher.js +445 -535
  37. package/dest/publisher/write_json.d.ts +11 -0
  38. package/dest/publisher/write_json.d.ts.map +1 -0
  39. package/dest/publisher/write_json.js +57 -0
  40. package/dest/sequencer/automine/automine_factory.d.ts +56 -0
  41. package/dest/sequencer/automine/automine_factory.d.ts.map +1 -0
  42. package/dest/sequencer/automine/automine_factory.js +85 -0
  43. package/dest/sequencer/automine/automine_sequencer.d.ts +189 -0
  44. package/dest/sequencer/automine/automine_sequencer.d.ts.map +1 -0
  45. package/dest/sequencer/automine/automine_sequencer.js +696 -0
  46. package/dest/sequencer/automine/index.d.ts +3 -0
  47. package/dest/sequencer/automine/index.d.ts.map +1 -0
  48. package/dest/sequencer/automine/index.js +2 -0
  49. package/dest/sequencer/checkpoint_proposal_job.d.ts +75 -19
  50. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  51. package/dest/sequencer/checkpoint_proposal_job.js +831 -256
  52. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts +34 -0
  53. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts.map +1 -0
  54. package/dest/sequencer/checkpoint_proposal_job_metrics.js +72 -0
  55. package/dest/sequencer/checkpoint_voter.d.ts +1 -2
  56. package/dest/sequencer/checkpoint_voter.d.ts.map +1 -1
  57. package/dest/sequencer/checkpoint_voter.js +2 -5
  58. package/dest/sequencer/errors.d.ts +1 -8
  59. package/dest/sequencer/errors.d.ts.map +1 -1
  60. package/dest/sequencer/errors.js +0 -9
  61. package/dest/sequencer/events.d.ts +62 -5
  62. package/dest/sequencer/events.d.ts.map +1 -1
  63. package/dest/sequencer/metrics.d.ts +14 -11
  64. package/dest/sequencer/metrics.d.ts.map +1 -1
  65. package/dest/sequencer/metrics.js +45 -20
  66. package/dest/sequencer/requests_tracker.d.ts +22 -0
  67. package/dest/sequencer/requests_tracker.d.ts.map +1 -0
  68. package/dest/sequencer/requests_tracker.js +33 -0
  69. package/dest/sequencer/sequencer.d.ts +166 -39
  70. package/dest/sequencer/sequencer.d.ts.map +1 -1
  71. package/dest/sequencer/sequencer.js +616 -198
  72. package/dest/sequencer/types.d.ts +2 -2
  73. package/dest/sequencer/types.d.ts.map +1 -1
  74. package/dest/test/index.d.ts +3 -3
  75. package/dest/test/index.d.ts.map +1 -1
  76. package/dest/test/mock_checkpoint_builder.d.ts +7 -9
  77. package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
  78. package/dest/test/mock_checkpoint_builder.js +39 -30
  79. package/dest/test/utils.d.ts +15 -1
  80. package/dest/test/utils.d.ts.map +1 -1
  81. package/dest/test/utils.js +25 -7
  82. package/package.json +28 -28
  83. package/src/client/sequencer-client.ts +90 -45
  84. package/src/config.ts +98 -31
  85. package/src/global_variable_builder/README.md +44 -0
  86. package/src/global_variable_builder/fee_predictor.ts +182 -0
  87. package/src/global_variable_builder/fee_provider.ts +97 -0
  88. package/src/global_variable_builder/global_builder.ts +19 -88
  89. package/src/global_variable_builder/index.ts +3 -1
  90. package/src/publisher/config.ts +62 -7
  91. package/src/publisher/l1_to_l2_messaging.ts +85 -0
  92. package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +3 -1
  93. package/src/publisher/sequencer-bundle-simulator.ts +254 -0
  94. package/src/publisher/sequencer-publisher-factory.ts +3 -6
  95. package/src/publisher/sequencer-publisher.ts +510 -584
  96. package/src/publisher/write_json.ts +78 -0
  97. package/src/sequencer/automine/README.md +60 -0
  98. package/src/sequencer/automine/automine_factory.ts +152 -0
  99. package/src/sequencer/automine/automine_sequencer.ts +800 -0
  100. package/src/sequencer/automine/index.ts +6 -0
  101. package/src/sequencer/checkpoint_proposal_job.ts +993 -294
  102. package/src/sequencer/checkpoint_proposal_job_metrics.ts +128 -0
  103. package/src/sequencer/checkpoint_voter.ts +1 -12
  104. package/src/sequencer/errors.ts +0 -15
  105. package/src/sequencer/events.ts +66 -5
  106. package/src/sequencer/metrics.ts +63 -25
  107. package/src/sequencer/requests_tracker.ts +43 -0
  108. package/src/sequencer/sequencer.ts +720 -220
  109. package/src/sequencer/types.ts +1 -1
  110. package/src/test/index.ts +2 -2
  111. package/src/test/mock_checkpoint_builder.ts +51 -48
  112. package/src/test/utils.ts +61 -10
  113. package/dest/sequencer/timetable.d.ts +0 -87
  114. package/dest/sequencer/timetable.d.ts.map +0 -1
  115. package/dest/sequencer/timetable.js +0 -223
  116. package/src/sequencer/README.md +0 -531
  117. package/src/sequencer/timetable.ts +0 -283
@@ -1,6 +1,5 @@
1
- import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
2
- import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
3
- import type { EpochCache } from '@aztec/epoch-cache';
1
+ import { type EpochCache, PROPOSER_PIPELINING_SLOT_OFFSET } from '@aztec/epoch-cache';
2
+ import type { SimulationOverridesPlan } from '@aztec/ethereum/contracts';
4
3
  import {
5
4
  BlockNumber,
6
5
  CheckpointNumber,
@@ -15,11 +14,12 @@ import {
15
14
  generateUnrecoverableSignature,
16
15
  } from '@aztec/foundation/crypto/secp256k1-signer';
17
16
  import { Fr } from '@aztec/foundation/curves/bn254';
17
+ import { InterruptError, TimeoutError } from '@aztec/foundation/error';
18
18
  import { EthAddress } from '@aztec/foundation/eth-address';
19
19
  import { Signature } from '@aztec/foundation/eth-signature';
20
20
  import { filter } from '@aztec/foundation/iterator';
21
21
  import { type Logger, type LoggerBindings, createLogger } from '@aztec/foundation/log';
22
- import { sleep, sleepUntil } from '@aztec/foundation/sleep';
22
+ import { InterruptibleSleep } from '@aztec/foundation/sleep';
23
23
  import { type DateProvider, Timer } from '@aztec/foundation/timer';
24
24
  import { type TypedEventEmitter, isErrorClass, unfreeze } from '@aztec/foundation/types';
25
25
  import type { P2P } from '@aztec/p2p';
@@ -31,20 +31,37 @@ import {
31
31
  type L2BlockSink,
32
32
  type L2BlockSource,
33
33
  MaliciousCommitteeAttestationsAndSigners,
34
+ MaliciousYParityCommitteeAttestationsAndSigners,
35
+ type ProposedCheckpointSink,
36
+ type ValidateCheckpointResult,
34
37
  } from '@aztec/stdlib/block';
35
- import type { Checkpoint } from '@aztec/stdlib/checkpoint';
36
- import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
38
+ import {
39
+ type Checkpoint,
40
+ type ProposedCheckpointData,
41
+ buildCheckpointSimulationOverridesPlan,
42
+ getPreviousCheckpointOutHashes,
43
+ validateCheckpoint,
44
+ } from '@aztec/stdlib/checkpoint';
45
+ import { computeQuorum, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
37
46
  import { Gas } from '@aztec/stdlib/gas';
38
47
  import {
39
- NoValidTxsError,
40
- type PublicProcessorLimits,
48
+ type BlockBuilderOptions,
49
+ InsufficientValidTxsError,
41
50
  type ResolvedSequencerConfig,
42
51
  type WorldStateSynchronizer,
43
52
  } from '@aztec/stdlib/interfaces/server';
44
53
  import { type L1ToL2MessageSource, computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
45
- import type { BlockProposalOptions, CheckpointProposal, CheckpointProposalOptions } from '@aztec/stdlib/p2p';
54
+ import type {
55
+ BlockProposal,
56
+ BlockProposalOptions,
57
+ CheckpointAttestation,
58
+ CheckpointProposal,
59
+ CheckpointProposalOptions,
60
+ CoordinationSignatureContext,
61
+ } from '@aztec/stdlib/p2p';
46
62
  import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
47
63
  import type { L2BlockBuiltStats } from '@aztec/stdlib/stats';
64
+ import type { ProposerTimetable } from '@aztec/stdlib/timetable';
48
65
  import { type FailedTx, Tx } from '@aztec/stdlib/tx';
49
66
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
50
67
  import { Attributes, type Traceable, type Tracer, trackSpan } from '@aztec/telemetry-client';
@@ -53,16 +70,32 @@ import { DutyAlreadySignedError, SlashingProtectionError } from '@aztec/validato
53
70
 
54
71
  import type { GlobalVariableBuilder } from '../global_variable_builder/global_builder.js';
55
72
  import type { InvalidateCheckpointRequest, SequencerPublisher } from '../publisher/sequencer-publisher.js';
73
+ import type { CheckpointProposalJobMetricsRecorder } from './checkpoint_proposal_job_metrics.js';
56
74
  import { CheckpointVoter } from './checkpoint_voter.js';
57
75
  import { SequencerInterruptedError } from './errors.js';
58
76
  import type { SequencerEvents } from './events.js';
59
77
  import type { SequencerMetrics } from './metrics.js';
60
- import type { SequencerTimetable } from './timetable.js';
78
+ import type { RequestsTracker } from './requests_tracker.js';
61
79
  import type { SequencerRollupConstants } from './types.js';
62
80
  import { SequencerState } from './utils.js';
63
81
 
64
82
  /** How much time to sleep while waiting for min transactions to accumulate for a block */
65
83
  const TXS_POLLING_MS = 500;
84
+ const ARCHIVER_SYNC_POLLING_MS = 200;
85
+
86
+ /** Result from proposeCheckpoint when a checkpoint was successfully built and broadcast. */
87
+ type CheckpointProposalBroadcast = {
88
+ checkpoint: Checkpoint;
89
+ proposal: CheckpointProposal;
90
+ blockProposedAt: number;
91
+ };
92
+
93
+ /** Result after attestation collection and signing, ready for L1 submission. */
94
+ type CheckpointProposalResult = {
95
+ checkpoint: Checkpoint;
96
+ attestations: CommitteeAttestationsAndSigners;
97
+ attestationsSignature: Signature;
98
+ };
66
99
 
67
100
  /**
68
101
  * Handles the execution of a checkpoint proposal after the initial preparation phase.
@@ -72,12 +105,29 @@ const TXS_POLLING_MS = 500;
72
105
  */
73
106
  export class CheckpointProposalJob implements Traceable {
74
107
  protected readonly log: Logger;
108
+ private readonly checkpointEventLog: Logger;
109
+
110
+ private readonly interruptibleSleep = new InterruptibleSleep();
111
+ private interrupted = false;
112
+
113
+ /**
114
+ * Chain state overrides built once per slot in proposeCheckpoint after the checkpoint is
115
+ * complete. Carries the pending parent override (archive + slot + fee header) for pipelining,
116
+ * or the invalidation pending override when rolling back. Consumed by
117
+ * publisher.validateCheckpointHeader before broadcast.
118
+ */
119
+ private checkpointSimulationOverridesPlan?: SimulationOverridesPlan;
120
+
121
+ private getSignatureContext(): CoordinationSignatureContext {
122
+ return this.signatureContext;
123
+ }
75
124
 
76
125
  constructor(
77
- private readonly epoch: EpochNumber,
78
- private readonly slot: SlotNumber,
126
+ private readonly targetSlot: SlotNumber,
127
+ private readonly targetEpoch: EpochNumber,
79
128
  private readonly checkpointNumber: CheckpointNumber,
80
129
  private readonly syncedToBlockNumber: BlockNumber,
130
+ private readonly checkpointedCheckpointNumber: CheckpointNumber,
81
131
  // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
82
132
  private readonly proposer: EthAddress | undefined,
83
133
  private readonly publisher: SequencerPublisher,
@@ -90,25 +140,89 @@ export class CheckpointProposalJob implements Traceable {
90
140
  private readonly l1ToL2MessageSource: L1ToL2MessageSource,
91
141
  private readonly l2BlockSource: L2BlockSource,
92
142
  private readonly checkpointsBuilder: FullNodeCheckpointsBuilder,
93
- private readonly blockSink: L2BlockSink,
143
+ private readonly blockSink: L2BlockSink & ProposedCheckpointSink,
94
144
  private readonly l1Constants: SequencerRollupConstants,
145
+ private readonly signatureContext: CoordinationSignatureContext,
95
146
  protected config: ResolvedSequencerConfig,
96
- protected timetable: SequencerTimetable,
147
+ protected timetable: ProposerTimetable,
97
148
  private readonly slasherClient: SlasherClientInterface | undefined,
98
149
  private readonly epochCache: EpochCache,
99
150
  private readonly dateProvider: DateProvider,
100
151
  private readonly metrics: SequencerMetrics,
101
- private readonly eventEmitter: TypedEventEmitter<SequencerEvents>,
102
- private readonly setStateFn: (state: SequencerState, slot?: SlotNumber) => void,
152
+ private readonly checkpointMetrics: CheckpointProposalJobMetricsRecorder,
153
+ protected readonly eventEmitter: TypedEventEmitter<SequencerEvents>,
154
+ // Shared with the owning sequencer, which drains it during shutdown; the fire-and-forget L1
155
+ // submission this job backgrounds is tracked here rather than in a job-local tracker.
156
+ protected readonly pendingRequests: RequestsTracker,
157
+ private readonly setStateFn: (state: SequencerState, slot: SlotNumber) => void,
103
158
  public readonly tracer: Tracer,
104
159
  bindings?: LoggerBindings,
160
+ private readonly proposedCheckpointData?: ProposedCheckpointData,
105
161
  ) {
106
- this.log = createLogger('sequencer:checkpoint-proposal', { ...bindings, instanceId: `slot-${slot}` });
162
+ this.log = createLogger('sequencer:checkpoint-proposal', {
163
+ ...bindings,
164
+ instanceId: `slot-${this.getBuildSlot()}`,
165
+ });
166
+ this.checkpointEventLog = createLogger('sequencer:checkpoint-events', {
167
+ ...bindings,
168
+ instanceId: `slot-${this.getBuildSlot()}`,
169
+ });
170
+ }
171
+
172
+ /**
173
+ * The wall-clock slot during which this job builds, i.e. the slot one before {@link targetSlot} under
174
+ * proposer pipelining. Also the slot of the parent checkpoint this job builds on top of.
175
+ */
176
+ private getBuildSlot(): SlotNumber {
177
+ return SlotNumber(this.targetSlot - PROPOSER_PIPELINING_SLOT_OFFSET);
178
+ }
179
+
180
+ /**
181
+ * Sets the sequencer state for this job, reporting the target slot the checkpoint is being proposed for
182
+ * (not the wall-clock build slot). The slot is informational on the event payload/metrics; the job knows
183
+ * its own target slot, so callers only pass the state.
184
+ */
185
+ private setState(state: SequencerState): void {
186
+ this.setStateFn(state, this.targetSlot);
187
+ }
188
+
189
+ /** Interrupts job-owned waits, including the publisher's send-at-slot sleep, so shutdown can finish. */
190
+ public interrupt(): void {
191
+ this.interrupted = true;
192
+ this.interruptibleSleep.interrupt(true);
193
+ this.publisher.interrupt();
194
+ }
195
+
196
+ private async awaitInterruptibleSleep(ms: number): Promise<void> {
197
+ if (this.interrupted) {
198
+ throw new SequencerInterruptedError();
199
+ }
200
+ if (ms <= 0) {
201
+ return;
202
+ }
203
+ try {
204
+ await this.interruptibleSleep.sleep(ms);
205
+ } catch (err) {
206
+ if (err instanceof InterruptError) {
207
+ throw new SequencerInterruptedError();
208
+ }
209
+ throw err;
210
+ }
211
+ }
212
+
213
+ private logCheckpointEvent(eventName: string, message: string, fields: Record<string, unknown>): void {
214
+ this.checkpointEventLog.debug(message, {
215
+ eventName: `sequencer-checkpoint-${eventName}`,
216
+ ...fields,
217
+ });
107
218
  }
108
219
 
109
220
  /**
110
221
  * Executes the checkpoint proposal job.
111
- * Returns the published checkpoint if successful, undefined otherwise.
222
+ * Builds blocks, assembles checkpoint, and broadcasts the proposal (blocking).
223
+ * Attestation collection, signing, and L1 submission are backgrounded so the
224
+ * work loop can return to IDLE immediately for consecutive slot proposals.
225
+ * Returns the built checkpoint if successful, undefined otherwise.
112
226
  */
113
227
  @trackSpan('CheckpointProposalJob.execute')
114
228
  public async execute(): Promise<Checkpoint | undefined> {
@@ -116,7 +230,7 @@ export class CheckpointProposalJob implements Traceable {
116
230
  // In fisherman mode, we simulate slashing but don't actually publish to L1
117
231
  // These are constant for the whole slot, so we only enqueue them once
118
232
  const votesPromises = new CheckpointVoter(
119
- this.slot,
233
+ this.targetSlot,
120
234
  this.publisher,
121
235
  this.attestorAddress,
122
236
  this.validatorClient,
@@ -127,33 +241,309 @@ export class CheckpointProposalJob implements Traceable {
127
241
  this.log,
128
242
  ).enqueueVotes();
129
243
 
130
- // Build and propose the checkpoint. This will enqueue the request on the publisher if a checkpoint is built.
131
- const checkpoint = await this.proposeCheckpoint();
132
-
133
- // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
134
- await Promise.all(votesPromises);
135
-
136
- if (checkpoint) {
137
- this.metrics.recordCheckpointProposalSuccess();
244
+ // Build blocks, assemble checkpoint, and broadcast proposal (BLOCKING).
245
+ // Returns after broadcast — attestation collection is deferred.
246
+ const broadcast = await this.proposeCheckpoint();
247
+
248
+ if (!broadcast) {
249
+ await Promise.all(votesPromises);
250
+ // Still submit votes even without a checkpoint.
251
+ // Under proposer pipelining, vote-offenses signatures are EIP-712-bound to `targetSlot`
252
+ // (the pipelined slot in which the multicall is expected to mine). Submitting at the
253
+ // wall-clock time would let the multicall mine in a different L2 slot, causing
254
+ // signature verification to fail silently inside Multicall3. Delay submission to the
255
+ // start of `targetSlot` so the tx mines in the slot the vote was signed for.
256
+ if (!this.config.fishermanMode) {
257
+ this.pendingRequests.trackRequest(this.publisher.sendRequestsAt(this.targetSlot), () => this.interrupt());
258
+ }
259
+ return undefined;
138
260
  }
139
261
 
262
+ const { checkpoint } = broadcast;
263
+ this.metrics.recordCheckpointProposalSuccess();
264
+
140
265
  // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
141
266
  if (this.config.fishermanMode) {
142
267
  await this.handleCheckpointEndAsFisherman(checkpoint);
143
- return;
268
+ return checkpoint;
144
269
  }
145
270
 
146
- // Then send everything to L1
147
- const l1Response = await this.publisher.sendRequests();
148
- const proposedAction = l1Response?.successfulActions.find(a => a === 'propose');
149
- if (proposedAction) {
150
- this.eventEmitter.emit('checkpoint-published', { checkpoint: this.checkpointNumber, slot: this.slot });
151
- const coinbase = checkpoint?.header.coinbase;
152
- await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
153
- return checkpoint;
154
- } else if (checkpoint) {
155
- this.eventEmitter.emit('checkpoint-publish-failed', { ...l1Response, slot: this.slot });
156
- return undefined;
271
+ // Background the attestation signing → L1 pipeline so the work loop is unblocked
272
+ this.pendingRequests.trackRequest(this.waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises), () =>
273
+ this.interrupt(),
274
+ );
275
+
276
+ // Return the built checkpoint immediately — the work loop is now unblocked
277
+ return checkpoint;
278
+ }
279
+
280
+ /**
281
+ * Background pipeline: collects attestations, signs them, enqueues the checkpoint, and submits to L1.
282
+ * Runs as a fire-and-forget task tracked in the sequencer's shared tracker so the work loop is unblocked.
283
+ */
284
+ private async waitForAttestationsAndEnqueueSubmissionAsync(
285
+ broadcast: CheckpointProposalBroadcast,
286
+ votesPromises: Promise<unknown>[],
287
+ ): Promise<void> {
288
+ const { checkpoint } = broadcast;
289
+
290
+ try {
291
+ // Wait for all votes actions, enqueued at the beginning, to resolve
292
+ await Promise.all(votesPromises);
293
+
294
+ // Try to collect attestations from the committee
295
+ const signedAttestations = await this.getSignedCommitteeAttestations(broadcast);
296
+
297
+ // Wait for the previous checkpoint to land on L1 before submitting, so we can check it
298
+ // matches the proposed checkpoint we used as parent, and has valid attestations.
299
+ if (signedAttestations && (await this.waitForValidParentCheckpointOnL1())) {
300
+ await this.enqueueCheckpointForSubmission({ checkpoint, ...signedAttestations });
301
+ }
302
+
303
+ // If we failed to collect attestations, at least check if we need to issue an invalidation
304
+ if (!signedAttestations && (await this.waitForSyncedL2SlotNumber(this.getBuildSlot()))) {
305
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
306
+ if (!validationStatus.valid) {
307
+ this.log.warn(
308
+ `Checkpoint ${validationStatus.checkpoint.checkpointNumber} has invalid attestations, enqueuing invalidation in spite of attestation collection failure`,
309
+ { checkpoint: validationStatus.checkpoint, reason: validationStatus.reason },
310
+ );
311
+ await this.enqueueInvalidation(validationStatus);
312
+ }
313
+ }
314
+
315
+ // Send whatever was enqueued: votes + (propose | invalidation | nothing).
316
+ const l1Response = await this.publisher.sendRequestsAt(this.targetSlot);
317
+ const proposedAction = l1Response?.successfulActions.find(a => a === 'propose');
318
+ if (proposedAction) {
319
+ this.logCheckpointEvent('published', `Checkpoint published for slot ${this.targetSlot}`, {
320
+ slot: this.targetSlot,
321
+ checkpointNumber: this.checkpointNumber,
322
+ successfulActions: l1Response?.successfulActions,
323
+ sentActions: l1Response?.sentActions,
324
+ });
325
+ this.eventEmitter.emit('checkpoint-published', { checkpoint: this.checkpointNumber, slot: this.targetSlot });
326
+ const coinbase = checkpoint.header.coinbase;
327
+ await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
328
+ } else {
329
+ this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, {
330
+ slot: this.targetSlot,
331
+ checkpointNumber: this.checkpointNumber,
332
+ successfulActions: l1Response?.successfulActions,
333
+ failedActions: l1Response?.failedActions,
334
+ sentActions: l1Response?.sentActions,
335
+ expiredActions: l1Response?.expiredActions,
336
+ reason: 'propose_action_not_successful',
337
+ });
338
+ this.log.warn(`Checkpoint publish failed for slot ${this.targetSlot}`, {
339
+ slot: this.targetSlot,
340
+ checkpointNumber: this.checkpointNumber,
341
+ successfulActions: l1Response?.successfulActions,
342
+ failedActions: l1Response?.failedActions,
343
+ sentActions: l1Response?.sentActions,
344
+ expiredActions: l1Response?.expiredActions,
345
+ reason: 'propose_action_not_successful',
346
+ });
347
+ this.eventEmitter.emit('checkpoint-publish-failed', { ...l1Response, slot: this.targetSlot });
348
+ this.metrics.recordPipelineDiscard();
349
+ }
350
+ } catch (err) {
351
+ if (err instanceof SequencerInterruptedError) {
352
+ return;
353
+ }
354
+ this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, {
355
+ slot: this.targetSlot,
356
+ checkpointNumber: this.checkpointNumber,
357
+ reason: err instanceof Error ? err.message : String(err),
358
+ });
359
+ this.log.error(`Background attestation/L1 pipeline failed for slot ${this.targetSlot}`, err, {
360
+ slot: this.targetSlot,
361
+ checkpointNumber: this.checkpointNumber,
362
+ reason: err instanceof Error ? err.message : String(err),
363
+ });
364
+ this.eventEmitter.emit('checkpoint-publish-failed', { slot: this.targetSlot });
365
+ this.metrics.recordPipelineDiscard();
366
+ }
367
+ }
368
+
369
+ /** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */
370
+ private async enqueueCheckpointForSubmission(result: CheckpointProposalResult): Promise<void> {
371
+ const { checkpoint, attestations, attestationsSignature } = result;
372
+
373
+ this.setState(SequencerState.PUBLISHING_CHECKPOINT);
374
+ // Latest L1 block the propose can still land in for the target slot: the last Ethereum block inside
375
+ // the target slot (`target_slot_start + S - E`). This is one ethereum slot later than
376
+ // `attestation_deadline` (= last_ethereum_block_in_target_slot - E), which bounds when validators must
377
+ // have signed, not when the proposer must have sent. Using the attestation deadline here is too tight:
378
+ // attestations are collected up to (and, when not enforcing, past) it, so the propose tx would be
379
+ // enqueued already expired and time out before it can mine.
380
+ const lastL1BlockInTargetSlot =
381
+ Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) +
382
+ this.l1Constants.slotDuration -
383
+ this.l1Constants.ethereumSlotDuration;
384
+ const txTimeoutAt = new Date(lastL1BlockInTargetSlot * 1000);
385
+
386
+ // If we have been configured to potentially skip publishing checkpoint then roll the dice here
387
+ if (
388
+ this.config.skipPublishingCheckpointsPercent !== undefined &&
389
+ this.config.skipPublishingCheckpointsPercent > 0
390
+ ) {
391
+ const roll = Math.max(0, randomInt(100));
392
+ if (roll < this.config.skipPublishingCheckpointsPercent) {
393
+ this.log.warn(
394
+ `Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${roll}`,
395
+ );
396
+ return;
397
+ }
398
+ }
399
+
400
+ await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, { txTimeoutAt });
401
+ }
402
+
403
+ /**
404
+ * Wait until the archiver syncs past the given L2 slot number.
405
+ * The deadline is the end of `this.targetSlot`, beyond which any pipelined work would miss its
406
+ * L1 submission window and is no longer useful.
407
+ */
408
+ private async waitForSyncedL2SlotNumber(waitForSlot: SlotNumber): Promise<boolean> {
409
+ const targetSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
410
+ const targetSlotEndMs = (targetSlotStart + this.l1Constants.slotDuration) * 1000;
411
+ const syncDelayTolerance = this.l1Constants.ethereumSlotDuration * 2 * 1000;
412
+ const timeoutSeconds = Math.max(0.1, (targetSlotEndMs + syncDelayTolerance - this.dateProvider.now()) / 1000);
413
+
414
+ try {
415
+ const timer = new Timer();
416
+ while (true) {
417
+ const syncedSlot = await this.l2BlockSource.getSyncedL2SlotNumber();
418
+ if (syncedSlot !== undefined && syncedSlot >= waitForSlot) {
419
+ return true;
420
+ }
421
+ if (timeoutSeconds && timer.s() > timeoutSeconds) {
422
+ throw new TimeoutError(`Timeout awaiting archiver sync past slot ${waitForSlot}`);
423
+ }
424
+ await this.awaitInterruptibleSleep(ARCHIVER_SYNC_POLLING_MS);
425
+ }
426
+ } catch (err) {
427
+ if (err instanceof SequencerInterruptedError) {
428
+ throw err;
429
+ }
430
+ this.log.warn(
431
+ `Archiver did not sync L1 past slot ${waitForSlot} before slot ${this.targetSlot} expired, discarding pipelined work`,
432
+ { checkpointNumber: this.checkpointNumber },
433
+ );
434
+ this.emitPipelinedCheckpointDiscarded('archiver-sync-timeout');
435
+ return false;
436
+ }
437
+ }
438
+
439
+ /**
440
+ * Waits for the parent checkpoint to land on L1 before submitting a pipelined checkpoint.
441
+ * Polls until the archiver has synced L1 past the parent's slot, then verifies:
442
+ * - If we built on a proposed parent: it must have landed on L1 with matching hash and valid attestations.
443
+ * - If we built without a proposed parent: no new checkpoint must have appeared for that slot.
444
+ * If the parent has invalid attestations, enqueues an invalidation. Returns whether to proceed with the proposal.
445
+ */
446
+ protected async waitForValidParentCheckpointOnL1(): Promise<boolean> {
447
+ if (this.config.skipWaitForValidParentCheckpointOnL1) {
448
+ this.log.warn(`Skipping waitForValidParentCheckpointOnL1 due to test configuration`, {
449
+ checkpointNumber: this.checkpointNumber,
450
+ });
451
+ return true;
452
+ }
453
+
454
+ const parentCheckpointNumber = CheckpointNumber(this.checkpointNumber - 1);
455
+
456
+ // Wait until archiver has synced L1 past the parent's slot (the build slot, one before targetSlot)
457
+ if (!(await this.waitForSyncedL2SlotNumber(this.getBuildSlot()))) {
458
+ return false;
459
+ }
460
+
461
+ const tips = await this.l2BlockSource.getL2Tips();
462
+ const checkpointedNumber = tips.checkpointed.checkpoint.number;
463
+
464
+ // We built on top of a proposed checkpoint. Verify it landed on L1 as expected.
465
+ if (this.proposedCheckpointData) {
466
+ // After syncing from L1 we see the chain tip has invalid attestations. This means the parent checkpoint was posted
467
+ // with invalid attestations, or it built on top of something with invalid attestations and didnt invalidate them.
468
+ // Either way, we thought our parent would be valid, so we have to throw away our work. But at least we'll try and
469
+ // invalidate on L1 so we clean up the chain for the next proposer. And we'll slash them, but that's handled elsewhere.
470
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
471
+ if (!validationStatus.valid) {
472
+ this.log.warn(
473
+ `Parent checkpoint ${parentCheckpointNumber} has invalid attestations, discarding pipelined work`,
474
+ { checkpointNumber: this.checkpointNumber, reason: validationStatus.reason },
475
+ );
476
+ this.emitPipelinedCheckpointDiscarded('parent-invalid-attestations');
477
+ await this.enqueueInvalidation(validationStatus);
478
+ return false;
479
+ }
480
+
481
+ // The pending chain is valid. But did the parent checkpoint land on L1 at all?
482
+ if (checkpointedNumber < parentCheckpointNumber) {
483
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} did not land on L1, discarding pipelined work`, {
484
+ checkpointNumber: this.checkpointNumber,
485
+ checkpointedNumber,
486
+ });
487
+ this.emitPipelinedCheckpointDiscarded('parent-not-on-l1');
488
+ return false;
489
+ }
490
+
491
+ // It landed. But is it the one we were expecting?
492
+ const expectedHash = this.proposedCheckpointData.header.hash().toString();
493
+ if (tips.checkpointed.checkpoint.hash !== expectedHash) {
494
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} hash mismatch on L1, discarding pipelined work`, {
495
+ checkpointNumber: this.checkpointNumber,
496
+ expectedHash,
497
+ actualHash: tips.checkpointed.checkpoint.hash,
498
+ });
499
+ this.emitPipelinedCheckpointDiscarded('parent-hash-mismatch');
500
+ return false;
501
+ }
502
+
503
+ return true;
504
+ } else {
505
+ // We didn't see a proposed checkpoint at build time, so we built on checkpointed parent from two slots ago.
506
+ // But if a new checkpoint for the previous slot appeared on L1 in the meantime, our checkpoint assumed the wrong parent,
507
+ // so we have to discard our work. This can happen if we're somehow cut off from p2p and fail to see the checkpoint
508
+ // proposal for the previous slot.
509
+ if (checkpointedNumber > parentCheckpointNumber) {
510
+ this.log.warn(
511
+ `Unexpected checkpoint ${checkpointedNumber} landed on L1 after we built on top of parent ${parentCheckpointNumber}, discarding pipelined work`,
512
+ { checkpointNumber: this.checkpointNumber, checkpointedNumber },
513
+ );
514
+ this.emitPipelinedCheckpointDiscarded('unexpected-parent-appeared');
515
+ return false;
516
+ }
517
+
518
+ return true;
519
+ }
520
+ }
521
+
522
+ /** Emits the pipelined-checkpoint-discarded event and records the metric. */
523
+ private emitPipelinedCheckpointDiscarded(reason: string): void {
524
+ this.metrics.recordPipelineParentCheckpointMismatch(reason);
525
+ this.eventEmitter.emit('pipelined-checkpoint-discarded', {
526
+ slot: this.targetSlot,
527
+ checkpointNumber: this.checkpointNumber,
528
+ reason,
529
+ });
530
+ }
531
+
532
+ /** Simulates and enqueues an invalidation request for the invalid parent checkpoint. */
533
+ private async enqueueInvalidation(validationStatus: ValidateCheckpointResult): Promise<void> {
534
+ if (this.config.skipInvalidateBlockAsProposer) {
535
+ this.log.warn(`Skipping checkpoint invalidation as proposer due to test configuration`);
536
+ return;
537
+ }
538
+ const invalidateRequest = await this.publisher.simulateInvalidateCheckpoint(validationStatus);
539
+ if (invalidateRequest) {
540
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
541
+ const txTimeoutAt = new Date((submissionSlotStart + this.l1Constants.slotDuration) * 1000);
542
+ this.publisher.enqueueInvalidateCheckpoint(invalidateRequest, { txTimeoutAt });
543
+ } else {
544
+ this.log.info(`Invalidation simulation returned undefined, checkpoint may have been removed already`, {
545
+ checkpointNumber: this.checkpointNumber,
546
+ });
157
547
  }
158
548
  }
159
549
 
@@ -161,42 +551,89 @@ export class CheckpointProposalJob implements Traceable {
161
551
  return {
162
552
  // nullish operator needed for tests
163
553
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
164
- [Attributes.SLOT_NUMBER]: this.slot,
554
+ [Attributes.SLOT_NUMBER]: this.targetSlot,
165
555
  };
166
556
  })
167
- private async proposeCheckpoint(): Promise<Checkpoint | undefined> {
557
+ private async proposeCheckpoint(): Promise<CheckpointProposalBroadcast | undefined> {
168
558
  try {
559
+ const now = this.dateProvider.now();
560
+ if (this.proposedCheckpointData) {
561
+ // Measure against the wall-clock slot whose build window we are currently using.
562
+ // In pipelining mode `targetSlot` is intentionally one slot ahead, which makes the
563
+ // target-slot boundary a full slot away from the actual build start time.
564
+ const slotBoundaryMs = Number(getTimestampForSlot(this.getBuildSlot(), this.l1Constants)) * 1000;
565
+ this.checkpointMetrics.recordPipelinedCheckpointBuildStartOffsetFromSlotBoundary(now - slotBoundaryMs);
566
+ }
567
+ this.checkpointMetrics.startCheckpointTiming(now);
568
+
169
569
  // Get operator configured coinbase and fee recipient for this attestor
170
570
  const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
171
571
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
172
572
 
173
573
  // Start the checkpoint
174
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.slot);
175
- this.metrics.incOpenSlot(this.slot, this.proposer?.toString() ?? 'unknown');
574
+ this.setState(SequencerState.INITIALIZING_CHECKPOINT);
575
+ this.logCheckpointEvent('slot-started', `Starting checkpoint proposal for slot ${this.targetSlot}`, {
576
+ buildSlot: this.getBuildSlot(),
577
+ submissionSlot: this.targetSlot,
578
+ slot: this.targetSlot,
579
+ checkpointNumber: this.checkpointNumber,
580
+ proposer: this.proposer?.toString(),
581
+ attestorAddress: this.attestorAddress.toString(),
582
+ publisherAddress: this.publisher.getSenderAddress().toString(),
583
+ coinbase: coinbase.toString(),
584
+ });
585
+ this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
176
586
 
177
587
  // Enqueues checkpoint invalidation (constant for the whole slot)
178
588
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
179
589
  this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
180
590
  }
181
591
 
182
- // Create checkpoint builder for the slot
592
+ // Build the simulation plan for this slot. When pipelining, this overrides L1's view of
593
+ // pending/archive/fee-header to "as if the proposed parent had landed", so both the
594
+ // mana-min-fee simulation (in the globals builder) and the pre-broadcast
595
+ // validateCheckpointHeader see the chain tip the eventual L1 send will see.
596
+ this.checkpointSimulationOverridesPlan = await buildCheckpointSimulationOverridesPlan({
597
+ checkpointNumber: this.checkpointNumber,
598
+ proposedCheckpointData: this.proposedCheckpointData,
599
+ invalidateToPendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
600
+ checkpointedCheckpointNumber: this.checkpointedCheckpointNumber,
601
+ rollup: this.publisher.rollupContract,
602
+ signatureContext: this.signatureContext,
603
+ log: this.log,
604
+ });
605
+
183
606
  const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(
184
607
  coinbase,
185
608
  feeRecipient,
186
- this.slot,
609
+ this.targetSlot,
610
+ this.checkpointSimulationOverridesPlan,
187
611
  );
188
612
 
189
613
  // Collect L1 to L2 messages for the checkpoint and compute their hash
190
614
  const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(this.checkpointNumber);
191
615
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
192
616
 
193
- // Collect the out hashes of all the checkpoints before this one in the same epoch
194
- const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.epoch))
195
- .filter(c => c.checkpointNumber < this.checkpointNumber)
196
- .map(c => c.checkpointOutHash);
617
+ // Collect the out hashes of all the checkpoints before this one in the same epoch.
618
+ // Under pipelining the parent checkpoint may not be on L1 yet at build time, so the helper
619
+ // splices in the parent's checkpointOutHash from the locally-known proposed checkpoint so
620
+ // the resulting `epochOutHash` matches what validators (and L1) compute once the parent
621
+ // lands on L1.
622
+ const previousCheckpointOutHashes = await getPreviousCheckpointOutHashes({
623
+ blockSource: this.l2BlockSource,
624
+ epoch: this.targetEpoch,
625
+ checkpointNumber: this.checkpointNumber,
626
+ l1Constants: this.epochCache.getL1Constants(),
627
+ pipeliningEnabled: true,
628
+ proposedCheckpointData: this.proposedCheckpointData,
629
+ log: this.log,
630
+ });
197
631
 
198
- // Get the fee asset price modifier from the oracle
199
- const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier();
632
+ // Anchor the modifier to the predicted parent fee header: L1 will apply it against
633
+ // that, not against the latest published checkpoint (which lags by one under pipelining).
634
+ const predictedParentEthPerFeeAssetE12 =
635
+ this.checkpointSimulationOverridesPlan?.pendingCheckpointState?.feeHeader?.ethPerFeeAsset;
636
+ const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier(predictedParentEthPerFeeAssetE12);
200
637
 
201
638
  // Create a long-lived forked world state for the checkpoint builder
202
639
  await using fork = await this.worldState.fork(this.syncedToBlockNumber, { closeDelayMs: 12_000 });
@@ -220,11 +657,12 @@ export class CheckpointProposalJob implements Traceable {
220
657
 
221
658
  const checkpointProposalOptions: CheckpointProposalOptions = {
222
659
  publishFullTxs: !!this.config.publishTxsWithProposals,
223
- broadcastInvalidCheckpointProposal: this.config.broadcastInvalidBlockProposal,
660
+ broadcastInvalidCheckpointProposal:
661
+ this.config.broadcastInvalidCheckpointProposalOnly || this.config.broadcastInvalidBlockProposal,
224
662
  };
225
663
 
226
664
  let blocksInCheckpoint: L2Block[] = [];
227
- let blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined = undefined;
665
+ let blockPendingBroadcast: BlockProposal | undefined = undefined;
228
666
  const checkpointBuildTimer = new Timer();
229
667
 
230
668
  try {
@@ -248,126 +686,170 @@ export class CheckpointProposalJob implements Traceable {
248
686
  }
249
687
 
250
688
  if (blocksInCheckpoint.length === 0) {
251
- this.log.warn(`No blocks were built for slot ${this.slot}`, { slot: this.slot });
252
- this.eventEmitter.emit('checkpoint-empty', { slot: this.slot });
689
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
690
+ slot: this.targetSlot,
691
+ checkpointNumber: this.checkpointNumber,
692
+ reason: 'no_blocks_built',
693
+ });
694
+ this.log.warn(`No blocks were built for slot ${this.targetSlot}`, {
695
+ slot: this.targetSlot,
696
+ checkpointNumber: this.checkpointNumber,
697
+ reason: 'no_blocks_built',
698
+ });
699
+ this.eventEmitter.emit('checkpoint-empty', { slot: this.targetSlot });
253
700
  return undefined;
254
701
  }
255
702
 
256
703
  const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
257
704
  if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
705
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
706
+ slot: this.targetSlot,
707
+ checkpointNumber: this.checkpointNumber,
708
+ blocksBuilt: blocksInCheckpoint.length,
709
+ minBlocksForCheckpoint,
710
+ reason: 'min_blocks_not_met',
711
+ });
258
712
  this.log.warn(
259
713
  `Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`,
260
- { slot: this.slot, blocksBuilt: blocksInCheckpoint.length, minBlocksForCheckpoint },
714
+ {
715
+ slot: this.targetSlot,
716
+ checkpointNumber: this.checkpointNumber,
717
+ blocksBuilt: blocksInCheckpoint.length,
718
+ minBlocksForCheckpoint,
719
+ reason: 'min_blocks_not_met',
720
+ },
261
721
  );
262
722
  return undefined;
263
723
  }
264
724
 
265
725
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
266
726
  // broadcasted yet, and wait to collect the committee attestations.
267
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
727
+ this.setState(SequencerState.ASSEMBLING_CHECKPOINT);
268
728
  const checkpoint = await checkpointBuilder.completeCheckpoint();
269
729
 
730
+ // Final validation: per-block limits are only checked if the operator set them explicitly.
731
+ // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
732
+ try {
733
+ validateCheckpoint(checkpoint, {
734
+ rollupManaLimit: this.l1Constants.rollupManaLimit,
735
+ maxL2BlockGas: this.config.maxL2BlockGas,
736
+ maxDABlockGas: this.config.maxDABlockGas,
737
+ maxTxsPerBlock: this.config.maxTxsPerBlock,
738
+ maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint,
739
+ });
740
+ } catch (err) {
741
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
742
+ slot: this.targetSlot,
743
+ checkpointNumber: this.checkpointNumber,
744
+ blocksBuilt: blocksInCheckpoint.length,
745
+ reason: 'invalid_checkpoint',
746
+ checkpoint: checkpoint.header.toInspect(),
747
+ });
748
+ this.log.error(`Built an invalid checkpoint at slot ${this.targetSlot} (skipping proposal)`, err, {
749
+ slot: this.targetSlot,
750
+ checkpointNumber: this.checkpointNumber,
751
+ blocksBuilt: blocksInCheckpoint.length,
752
+ reason: 'invalid_checkpoint',
753
+ checkpoint: checkpoint.header.toInspect(),
754
+ });
755
+ return undefined;
756
+ }
757
+
270
758
  // Record checkpoint-level build metrics
271
- this.metrics.recordCheckpointBuild(
759
+ this.checkpointMetrics.recordCheckpointBuild(
272
760
  checkpointBuildTimer.ms(),
273
761
  blocksInCheckpoint.length,
274
762
  checkpoint.getStats().txCount,
275
763
  Number(checkpoint.header.totalManaUsed.toBigInt()),
276
764
  );
765
+ this.logCheckpointEvent('built', `Checkpoint built for slot ${this.targetSlot}`, {
766
+ slot: this.targetSlot,
767
+ buildSlot: this.getBuildSlot(),
768
+ checkpointNumber: this.checkpointNumber,
769
+ proposer: this.proposer?.toString(),
770
+ attestorAddress: this.attestorAddress.toString(),
771
+ publisherAddress: this.publisher.getSenderAddress().toString(),
772
+ blocksBuilt: blocksInCheckpoint.length,
773
+ txCount: checkpoint.getStats().txCount,
774
+ totalMana: Number(checkpoint.header.totalManaUsed.toBigInt()),
775
+ });
277
776
 
278
- // Do not collect attestations nor publish to L1 in fisherman mode
777
+ // In fisherman mode, return the checkpoint without broadcasting or collecting attestations
279
778
  if (this.config.fishermanMode) {
280
779
  this.log.info(
281
- `Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` +
780
+ `Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` +
282
781
  `Skipping proposal in fisherman mode.`,
283
782
  {
284
- slot: this.slot,
783
+ slot: this.targetSlot,
285
784
  checkpoint: checkpoint.header.toInspect(),
286
785
  blocksBuilt: blocksInCheckpoint.length,
287
786
  },
288
787
  );
289
788
  this.metrics.recordCheckpointSuccess();
290
- return checkpoint;
789
+ // Return a broadcast result with a dummy proposal — fisherman mode skips attestation collection
790
+ return { checkpoint, proposal: undefined!, blockProposedAt: this.dateProvider.now() };
291
791
  }
292
792
 
293
- // Include the block pending broadcast in the checkpoint proposal if any
294
- const lastBlock = blockPendingBroadcast && {
295
- blockHeader: blockPendingBroadcast.block.header,
296
- indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
297
- txs: blockPendingBroadcast.txs,
298
- };
793
+ // Validate the header against L1 state before broadcasting.
794
+ // If this fails the slot is aborted before any gossip work; state drift between here
795
+ // and the eventual L1 send is caught by the bundle simulate at send time.
796
+ try {
797
+ await this.publisher.validateCheckpointHeader(checkpoint.header, this.checkpointSimulationOverridesPlan);
798
+ } catch (err) {
799
+ this.log.error(`Pre-broadcast header validation failed for slot ${this.targetSlot}; aborting`, err, {
800
+ slot: this.targetSlot,
801
+ checkpointNumber: this.checkpointNumber,
802
+ });
803
+ this.metrics.recordCheckpointProposalFailed('header_validation_failed');
804
+ this.eventEmitter.emit('header-validation-failed', {
805
+ slot: this.targetSlot,
806
+ checkpointNumber: this.checkpointNumber,
807
+ reason: err instanceof Error ? err.message : String(err),
808
+ });
809
+ return undefined;
810
+ }
299
811
 
300
812
  // Create the checkpoint proposal and broadcast it
301
813
  const proposal = await this.validatorClient.createCheckpointProposal(
302
814
  checkpoint.header,
303
815
  checkpoint.archive.root,
816
+ this.checkpointNumber,
304
817
  feeAssetPriceModifier,
305
- lastBlock,
818
+ blockPendingBroadcast,
306
819
  this.proposer,
307
820
  checkpointProposalOptions,
308
821
  );
309
822
 
310
- const blockProposedAt = this.dateProvider.now();
311
- await this.p2pClient.broadcastCheckpointProposal(proposal);
312
-
313
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
314
- const attestations = await this.waitForAttestations(proposal);
315
- const blockAttestedAt = this.dateProvider.now();
316
-
317
- this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
318
-
319
- // Proposer must sign over the attestations before pushing them to L1
320
- const signer = this.proposer ?? this.publisher.getSenderAddress();
321
- let attestationsSignature: Signature;
322
- try {
323
- attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
324
- attestations,
325
- signer,
326
- this.slot,
327
- this.checkpointNumber,
328
- );
329
- } catch (err) {
330
- // We shouldn't really get here since we yield to another HA node
331
- // as soon as we see these errors when creating block or checkpoint proposals.
332
- if (this.handleHASigningError(err, 'Attestations signature')) {
333
- return undefined;
334
- }
335
- throw err;
336
- }
337
-
338
- // Enqueue publishing the checkpoint to L1
339
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
340
- const aztecSlotDuration = this.l1Constants.slotDuration;
341
- const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
342
- const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
823
+ // Advance our own optimistic proposed-checkpoint tip locally before gossiping. Gossipsub
824
+ // doesn't echo our own messages back, so this is how the proposer makes its own proposed
825
+ // checkpoint visible for pipelining the next slot. Built from local checkpoint data — never
826
+ // from the broadcast proposal archive, which may be deliberately corrupted under test flags.
827
+ // Fail closed: if this throws, the outer catch aborts the slot before gossiping.
828
+ await this.syncProposedCheckpointToArchiver(checkpoint, blocksInCheckpoint.length, feeAssetPriceModifier);
343
829
 
344
- // If we have been configured to potentially skip publishing checkpoint then roll the dice here
345
- if (
346
- this.config.skipPublishingCheckpointsPercent !== undefined &&
347
- this.config.skipPublishingCheckpointsPercent > 0
348
- ) {
349
- const result = Math.max(0, randomInt(100));
350
- if (result < this.config.skipPublishingCheckpointsPercent) {
351
- this.log.warn(
352
- `Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${result}`,
353
- );
354
- return checkpoint;
830
+ const blockProposedAt = this.dateProvider.now();
831
+ if (this.config.skipBroadcastCheckpointProposal) {
832
+ // Test-only: suppress the CheckpointProposal so peers never see a proposed checkpoint for
833
+ // this slot, but still broadcast the held last block standalone so peers' archivers ingest
834
+ // it as a proposed-but-uncheckpointed tip — the exact orphan-block state that
835
+ // pruneOrphanProposedBlocks / checkSync must handle.
836
+ if (blockPendingBroadcast && !this.config.skipBroadcastProposals) {
837
+ await this.p2pClient.broadcastProposal(blockPendingBroadcast);
355
838
  }
839
+ } else if (!this.config.skipBroadcastProposals) {
840
+ await this.p2pClient.broadcastCheckpointProposal(proposal);
841
+ this.checkpointMetrics.noteCheckpointBroadcast(this.dateProvider.now());
356
842
  }
357
843
 
358
- await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
359
- txTimeoutAt,
360
- forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
361
- });
362
-
363
- return checkpoint;
844
+ // Return immediately after broadcast — attestation collection happens in the background
845
+ return { checkpoint, proposal, blockProposedAt };
364
846
  } catch (err) {
365
847
  if (err && (err instanceof DutyAlreadySignedError || err instanceof SlashingProtectionError)) {
366
848
  // swallow this error. It's already been logged by a function deeper in the stack
367
849
  return undefined;
368
850
  }
369
851
 
370
- this.log.error(`Error building checkpoint at slot ${this.slot}`, err);
852
+ this.log.error(`Error building checkpoint at slot ${this.targetSlot}`, err);
371
853
  return undefined;
372
854
  }
373
855
  }
@@ -383,31 +865,37 @@ export class CheckpointProposalJob implements Traceable {
383
865
  blockProposalOptions: BlockProposalOptions,
384
866
  ): Promise<{
385
867
  blocksInCheckpoint: L2Block[];
386
- blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined;
868
+ blockPendingBroadcast: BlockProposal | undefined;
387
869
  }> {
388
870
  const blocksInCheckpoint: L2Block[] = [];
389
871
  const txHashesAlreadyIncluded = new Set<string>();
390
872
  const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
391
873
 
392
- // Remaining blob fields available for blocks (checkpoint end marker already subtracted)
393
- let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
394
-
395
874
  // Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
396
- let blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined = undefined;
875
+ let blockPendingBroadcast: BlockProposal | undefined = undefined;
397
876
 
398
877
  while (true) {
399
878
  const blocksBuilt = blocksInCheckpoint.length;
400
879
  const indexWithinCheckpoint = IndexWithinCheckpoint(blocksBuilt);
401
880
  const blockNumber = BlockNumber(initialBlockNumber + blocksBuilt);
402
881
 
403
- const secondsIntoSlot = this.getSecondsIntoSlot();
404
- const timingInfo = this.timetable.canStartNextBlock(secondsIntoSlot);
882
+ if (blocksBuilt >= this.config.maxBlocksPerCheckpoint) {
883
+ this.log.debug(`Reached max blocks per checkpoint`, {
884
+ slot: this.targetSlot,
885
+ blocksBuilt,
886
+ maxBlocksPerCheckpoint: this.config.maxBlocksPerCheckpoint,
887
+ });
888
+ break;
889
+ }
890
+
891
+ const nowSeconds = this.dateProvider.now() / 1000;
892
+ const timingInfo = this.timetable.selectNextSubslot(this.targetSlot, nowSeconds);
405
893
 
406
894
  if (!timingInfo.canStart) {
407
895
  this.log.debug(`Not enough time left in slot to start another block`, {
408
- slot: this.slot,
896
+ slot: this.targetSlot,
409
897
  blocksBuilt,
410
- secondsIntoSlot,
898
+ nowSeconds,
411
899
  });
412
900
  break;
413
901
  }
@@ -417,32 +905,29 @@ export class CheckpointProposalJob implements Traceable {
417
905
  blockTimestamp: timestamp,
418
906
  // Create an empty block if we haven't already and this is the last one
419
907
  forceCreate: timingInfo.isLastBlock && blocksBuilt === 0 && this.config.buildCheckpointIfEmpty,
420
- // Build deadline is only set if we are enforcing the timetable
421
- buildDeadline: timingInfo.deadline
422
- ? new Date((this.getSlotStartBuildTimestamp() + timingInfo.deadline) * 1000)
423
- : undefined,
908
+ buildDeadline: new Date(timingInfo.deadline * 1000),
424
909
  blockNumber,
425
910
  indexWithinCheckpoint,
426
911
  txHashesAlreadyIncluded,
427
- remainingBlobFields,
428
912
  });
429
913
 
430
- // TODO(palla/mbps): Review these conditions. We may want to keep trying in some scenarios.
431
- if (!buildResult && timingInfo.isLastBlock) {
432
- // If no block was produced due to not enough txs and this was the last subslot, exit
433
- break;
434
- } else if (!buildResult && timingInfo.deadline !== undefined) {
435
- // But if there is still time for more blocks, wait until the next subslot and try again
914
+ // If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
915
+ if ('failure' in buildResult) {
916
+ // If this was the last subslot, we're done.
917
+ if (timingInfo.isLastBlock) {
918
+ break;
919
+ }
920
+ // Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
436
921
  await this.waitUntilNextSubslot(timingInfo.deadline);
437
922
  continue;
438
- } else if (!buildResult) {
439
- // Exit if there is no possibility of building more blocks
440
- break;
441
- } else if ('error' in buildResult) {
442
- // If there was an error building the block, just exit the loop and give up the rest of the slot
923
+ }
924
+
925
+ // If there was an error building the block, we just exit the loop and give up the rest of the slot.
926
+ // We don't want to risk building more blocks if something went wrong.
927
+ if ('error' in buildResult) {
443
928
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
444
- this.log.warn(`Halting block building for slot ${this.slot}`, {
445
- slot: this.slot,
929
+ this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
930
+ slot: this.targetSlot,
446
931
  blocksBuilt,
447
932
  error: buildResult.error,
448
933
  });
@@ -450,45 +935,43 @@ export class CheckpointProposalJob implements Traceable {
450
935
  break;
451
936
  }
452
937
 
453
- const { block, usedTxs, remainingBlobFields: newRemainingBlobFields } = buildResult;
454
- blocksInCheckpoint.push(block);
938
+ const { block, usedTxs } = buildResult;
939
+ this.checkpointMetrics.noteCheckpointBlockBuilt(this.dateProvider.now(), {
940
+ isFirstBlock: blocksBuilt === 0,
941
+ isLastBlock: timingInfo.isLastBlock,
942
+ });
455
943
 
456
- // Update remaining blob fields for the next block
457
- remainingBlobFields = newRemainingBlobFields;
944
+ blocksInCheckpoint.push(block);
945
+ usedTxs.forEach(tx => txHashesAlreadyIncluded.add(tx.txHash.toString()));
458
946
 
459
- // Sync the proposed block to the archiver to make it available
460
- // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
461
- // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
462
- // Fire and forget - don't block the critical path, but log errors
463
- this.syncProposedBlockToArchiver(block).catch(err => {
464
- this.log.error(`Failed to sync proposed block ${block.number} to archiver`, { blockNumber: block.number, err });
947
+ // Sign the block proposal. This will throw if HA signing fails.
948
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, {
949
+ ...blockProposalOptions,
950
+ broadcastInvalidBlockProposal:
951
+ blockProposalOptions.broadcastInvalidBlockProposal ||
952
+ block.indexWithinCheckpoint === this.config.invalidBlockProposalIndexWithinCheckpoint,
465
953
  });
466
954
 
467
- usedTxs.forEach(tx => txHashesAlreadyIncluded.add(tx.txHash.toString()));
955
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
956
+ // so we avoid polluting our archive with a block that would fail.
957
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
958
+ // If this throws, we abort the entire checkpoint.
959
+ await this.syncProposedBlockToArchiver(block);
468
960
 
469
- // If this is the last block, exit the loop now so we start collecting attestations
961
+ // If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
470
962
  if (timingInfo.isLastBlock) {
471
- this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
472
- slot: this.slot,
963
+ this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
964
+ slot: this.targetSlot,
473
965
  blockNumber,
474
966
  blocksBuilt,
475
967
  });
476
- blockPendingBroadcast = { block, txs: usedTxs };
968
+
969
+ blockPendingBroadcast = proposal;
477
970
  break;
478
971
  }
479
972
 
480
- // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
481
- // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
482
- if (!this.config.fishermanMode) {
483
- const proposal = await this.validatorClient.createBlockProposal(
484
- block.header,
485
- block.indexWithinCheckpoint,
486
- inHash,
487
- block.archive.root,
488
- usedTxs,
489
- this.proposer,
490
- blockProposalOptions,
491
- );
973
+ // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
974
+ if (proposal && !this.config.skipBroadcastProposals) {
492
975
  await this.p2pClient.broadcastProposal(proposal);
493
976
  }
494
977
 
@@ -496,20 +979,48 @@ export class CheckpointProposalJob implements Traceable {
496
979
  await this.waitUntilNextSubslot(timingInfo.deadline);
497
980
  }
498
981
 
499
- this.log.verbose(`Block building loop completed for slot ${this.slot}`, {
500
- slot: this.slot,
982
+ this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
983
+ slot: this.targetSlot,
501
984
  blocksBuilt: blocksInCheckpoint.length,
502
985
  });
503
986
 
504
987
  return { blocksInCheckpoint, blockPendingBroadcast };
505
988
  }
506
989
 
507
- /** Sleeps until it is time to produce the next block in the slot */
990
+ /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */
991
+ private createBlockProposal(
992
+ block: L2Block,
993
+ inHash: Fr,
994
+ usedTxs: Tx[],
995
+ blockProposalOptions: BlockProposalOptions,
996
+ ): Promise<BlockProposal | undefined> {
997
+ if (this.config.fishermanMode) {
998
+ this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
999
+ return Promise.resolve(undefined);
1000
+ }
1001
+ return this.validatorClient.createBlockProposal(
1002
+ block.header,
1003
+ this.checkpointNumber,
1004
+ block.indexWithinCheckpoint,
1005
+ inHash,
1006
+ block.archive.root,
1007
+ usedTxs,
1008
+ this.proposer,
1009
+ blockProposalOptions,
1010
+ );
1011
+ }
1012
+
1013
+ /**
1014
+ * Sleeps until it is time to produce the next block in the slot.
1015
+ * @param nextSubslotStart - Absolute wall-clock timestamp in seconds of the previous sub-slot deadline.
1016
+ */
508
1017
  @trackSpan('CheckpointProposalJob.waitUntilNextSubslot')
509
- private async waitUntilNextSubslot(nextSubslotStart: number) {
510
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
511
- this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, { slot: this.slot });
512
- await this.waitUntilTimeInSlot(nextSubslotStart);
1018
+ protected async waitUntilNextSubslot(nextSubslotStart: number) {
1019
+ this.setState(SequencerState.WAITING_UNTIL_NEXT_BLOCK);
1020
+ this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s`, {
1021
+ slot: this.targetSlot,
1022
+ });
1023
+ await this.awaitInterruptibleSleep(Math.max(0, nextSubslotStart * 1000 - this.dateProvider.now()));
513
1024
  }
514
1025
 
515
1026
  /** Builds a single block. Called from the main block building loop. */
@@ -523,64 +1034,87 @@ export class CheckpointProposalJob implements Traceable {
523
1034
  indexWithinCheckpoint: IndexWithinCheckpoint;
524
1035
  buildDeadline: Date | undefined;
525
1036
  txHashesAlreadyIncluded: Set<string>;
526
- remainingBlobFields: number;
527
1037
  },
528
- ): Promise<{ block: L2Block; usedTxs: Tx[]; remainingBlobFields: number } | { error: Error } | undefined> {
529
- const {
530
- blockTimestamp,
531
- forceCreate,
532
- blockNumber,
533
- indexWithinCheckpoint,
534
- buildDeadline,
535
- txHashesAlreadyIncluded,
536
- remainingBlobFields,
537
- } = opts;
1038
+ ): Promise<
1039
+ { block: L2Block; usedTxs: Tx[] } | { failure: 'insufficient-txs' | 'insufficient-valid-txs' } | { error: Error }
1040
+ > {
1041
+ const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } =
1042
+ opts;
538
1043
 
539
1044
  this.log.verbose(
540
- `Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`,
1045
+ `Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`,
541
1046
  { ...checkpointBuilder.getConstantData(), ...opts },
542
1047
  );
543
1048
 
544
1049
  try {
545
1050
  // Wait until we have enough txs to build the block
546
- const minTxs = this.config.minTxsPerBlock;
547
- const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
1051
+ const { canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
548
1052
  if (!canStartBuilding) {
549
- this.log.warn(
550
- `Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`,
551
- { blockNumber, slot: this.slot, indexWithinCheckpoint },
1053
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1054
+ reason: 'insufficient_txs',
1055
+ blockNumber,
1056
+ slot: this.targetSlot,
1057
+ checkpointNumber: this.checkpointNumber,
1058
+ indexWithinCheckpoint,
1059
+ minTxs,
1060
+ });
1061
+ this.log.verbose(
1062
+ `Not enough age-eligible txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (needs ${minTxs} eligible)`,
1063
+ {
1064
+ reason: 'insufficient_txs',
1065
+ blockNumber,
1066
+ slot: this.targetSlot,
1067
+ checkpointNumber: this.checkpointNumber,
1068
+ indexWithinCheckpoint,
1069
+ minTxs,
1070
+ },
552
1071
  );
553
- this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, availableTxs, slot: this.slot });
1072
+ this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, slot: this.targetSlot });
554
1073
  this.metrics.recordBlockProposalFailed('insufficient_txs');
555
- return undefined;
1074
+ return { failure: 'insufficient-txs' };
556
1075
  }
557
1076
 
558
1077
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
559
1078
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
1079
+ // Block building only executes txs, so we skip loading their proofs unless these same tx objects get attached
1080
+ // to the broadcasted proposals via publishTxsWithProposals.
560
1081
  const pendingTxs = filter(
561
- this.p2pClient.iterateEligiblePendingTxs(),
1082
+ this.p2pClient.iterateEligiblePendingTxs({ includeProof: !!this.config.publishTxsWithProposals }),
562
1083
  tx => !txHashesAlreadyIncluded.has(tx.txHash.toString()),
563
1084
  );
564
1085
 
565
- this.log.debug(
566
- `Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`,
567
- { slot: this.slot, blockNumber, indexWithinCheckpoint },
568
- );
569
- this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
570
-
571
- // Calculate blob fields limit for txs (remaining capacity - this block's end overhead)
572
- const blockEndOverhead = getNumBlockEndBlobFields(indexWithinCheckpoint === 0);
573
- const maxBlobFieldsForTxs = remainingBlobFields - blockEndOverhead;
574
-
575
- const blockBuilderOptions: PublicProcessorLimits = {
1086
+ this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot}`, {
1087
+ slot: this.targetSlot,
1088
+ blockNumber,
1089
+ indexWithinCheckpoint,
1090
+ });
1091
+ this.setState(SequencerState.CREATING_BLOCK);
1092
+
1093
+ // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
1094
+ // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
1095
+ // minValidTxs is passed into the builder so it can reject the block *before* updating state.
1096
+ // Only the first block of a checkpoint may be empty, since this allows a checkpoint to be created
1097
+ // even if there are no transactions. If an empty block appears after the first, it can't be proven
1098
+ // (there is no rollup circuit shaped to allow this), so the floor for minValidTxs is 1.
1099
+ const configuredMinValidTxs = forceCreate ? 0 : (this.config.minValidTxsPerBlock ?? minTxs);
1100
+ const minValidTxs = indexWithinCheckpoint > 0 ? Math.max(configuredMinValidTxs, 1) : configuredMinValidTxs;
1101
+ const blockBuilderOptions: BlockBuilderOptions = {
576
1102
  maxTransactions: this.config.maxTxsPerBlock,
577
- maxBlockSize: this.config.maxBlockSizeInBytes,
578
- maxBlockGas: new Gas(this.config.maxDABlockGas, this.config.maxL2BlockGas),
579
- maxBlobFields: maxBlobFieldsForTxs,
1103
+ maxBlockGas:
1104
+ this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined
1105
+ ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity)
1106
+ : undefined,
580
1107
  deadline: buildDeadline,
1108
+ isBuildingProposal: true,
1109
+ minValidTxs,
1110
+ maxBlocksPerCheckpoint: this.timetable.getMaxBlocksPerCheckpoint(),
1111
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier,
1112
+ perBlockDAAllocationMultiplier: this.config.perBlockDAAllocationMultiplier,
581
1113
  };
582
1114
 
583
- // Actually build the block by executing txs
1115
+ // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
1116
+ // if the number of successfully processed txs is below minValidTxs, ensuring state is not
1117
+ // updated for blocks that will be discarded.
584
1118
  const buildResult = await this.buildSingleBlockWithCheckpointBuilder(
585
1119
  checkpointBuilder,
586
1120
  pendingTxs,
@@ -592,22 +1126,38 @@ export class CheckpointProposalJob implements Traceable {
592
1126
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
593
1127
  await this.dropFailedTxsFromP2P(buildResult.failedTxs);
594
1128
 
595
- // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
596
- // too long, then we may not get to minTxsPerBlock after executing public functions.
597
- const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
598
- const numTxs = buildResult.status === 'no-valid-txs' ? 0 : buildResult.numTxs;
599
- if (buildResult.status === 'no-valid-txs' || (!forceCreate && numTxs < minValidTxs)) {
1129
+ if (buildResult.status === 'insufficient-valid-txs') {
1130
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1131
+ reason: 'insufficient_valid_txs',
1132
+ slot: this.targetSlot,
1133
+ checkpointNumber: this.checkpointNumber,
1134
+ blockNumber,
1135
+ numTxs: buildResult.processedCount,
1136
+ indexWithinCheckpoint,
1137
+ minValidTxs,
1138
+ });
600
1139
  this.log.warn(
601
- `Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed`,
602
- { slot: this.slot, blockNumber, numTxs, indexWithinCheckpoint, minValidTxs, buildResult: buildResult.status },
1140
+ `Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`,
1141
+ {
1142
+ reason: 'insufficient_valid_txs',
1143
+ slot: this.targetSlot,
1144
+ checkpointNumber: this.checkpointNumber,
1145
+ blockNumber,
1146
+ numTxs: buildResult.processedCount,
1147
+ indexWithinCheckpoint,
1148
+ minValidTxs,
1149
+ },
603
1150
  );
604
- this.eventEmitter.emit('block-build-failed', { reason: `Insufficient valid txs`, slot: this.slot });
1151
+ this.eventEmitter.emit('block-build-failed', {
1152
+ reason: `Insufficient valid txs`,
1153
+ slot: this.targetSlot,
1154
+ });
605
1155
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
606
- return undefined;
1156
+ return { failure: 'insufficient-valid-txs' };
607
1157
  }
608
1158
 
609
1159
  // Block creation succeeded, emit stats and metrics
610
- const { publicGas, block, publicProcessorDuration, usedTxs, usedTxBlobFields, blockBuildDuration } = buildResult;
1160
+ const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
611
1161
 
612
1162
  const blockStats = {
613
1163
  eventName: 'l2-block-built',
@@ -618,33 +1168,56 @@ export class CheckpointProposalJob implements Traceable {
618
1168
 
619
1169
  const blockHash = await block.hash();
620
1170
  const txHashes = block.body.txEffects.map(tx => tx.txHash);
621
- const manaPerSec = publicGas.l2Gas / (blockBuildDuration / 1000);
1171
+ const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
622
1172
 
623
1173
  this.log.info(
624
- `Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`,
1174
+ `Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`,
625
1175
  { blockHash, txHashes, manaPerSec, ...blockStats },
626
1176
  );
627
1177
 
628
- this.eventEmitter.emit('block-proposed', { blockNumber: block.number, slot: this.slot });
629
- this.metrics.recordBuiltBlock(blockBuildDuration, publicGas.l2Gas);
1178
+ // `slot` is the target/submission slot (may be one ahead when pipelining),
1179
+ // `buildSlot` is the wall-clock slot during which the block was actually built.
1180
+ this.eventEmitter.emit('block-proposed', {
1181
+ blockNumber: block.number,
1182
+ blockHash,
1183
+ checkpointNumber: this.checkpointNumber,
1184
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1185
+ slot: this.targetSlot,
1186
+ buildSlot: this.getBuildSlot(),
1187
+ });
1188
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe(), this.targetSlot);
630
1189
 
631
- return { block, usedTxs, remainingBlobFields: maxBlobFieldsForTxs - usedTxBlobFields };
1190
+ return { block, usedTxs };
632
1191
  } catch (err: any) {
633
- this.eventEmitter.emit('block-build-failed', { reason: err.message, slot: this.slot });
634
- this.log.error(`Error building block`, err, { blockNumber, slot: this.slot });
1192
+ this.eventEmitter.emit('block-build-failed', {
1193
+ reason: err.message,
1194
+ slot: this.targetSlot,
1195
+ });
1196
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1197
+ reason: err instanceof Error ? err.message : String(err),
1198
+ slot: this.targetSlot,
1199
+ checkpointNumber: this.checkpointNumber,
1200
+ blockNumber,
1201
+ });
1202
+ this.log.error(`Error building block`, err, {
1203
+ reason: err instanceof Error ? err.message : String(err),
1204
+ slot: this.targetSlot,
1205
+ checkpointNumber: this.checkpointNumber,
1206
+ blockNumber,
1207
+ });
635
1208
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
636
1209
  this.metrics.recordFailedBlock();
637
1210
  return { error: err };
638
1211
  }
639
1212
  }
640
1213
 
641
- /** Uses the checkpoint builder to build a block, catching specific txs */
1214
+ /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */
642
1215
  private async buildSingleBlockWithCheckpointBuilder(
643
1216
  checkpointBuilder: CheckpointBuilder,
644
1217
  pendingTxs: AsyncIterable<Tx>,
645
1218
  blockNumber: BlockNumber,
646
1219
  blockTimestamp: bigint,
647
- blockBuilderOptions: PublicProcessorLimits,
1220
+ blockBuilderOptions: BlockBuilderOptions,
648
1221
  ) {
649
1222
  try {
650
1223
  const workTimer = new Timer();
@@ -652,8 +1225,12 @@ export class CheckpointProposalJob implements Traceable {
652
1225
  const blockBuildDuration = workTimer.ms();
653
1226
  return { ...result, blockBuildDuration, status: 'success' as const };
654
1227
  } catch (err: unknown) {
655
- if (isErrorClass(err, NoValidTxsError)) {
656
- return { failedTxs: err.failedTxs, status: 'no-valid-txs' as const };
1228
+ if (isErrorClass(err, InsufficientValidTxsError)) {
1229
+ return {
1230
+ failedTxs: err.failedTxs,
1231
+ processedCount: err.processedCount,
1232
+ status: 'insufficient-valid-txs' as const,
1233
+ };
657
1234
  }
658
1235
  throw err;
659
1236
  }
@@ -666,37 +1243,66 @@ export class CheckpointProposalJob implements Traceable {
666
1243
  blockNumber: BlockNumber;
667
1244
  indexWithinCheckpoint: IndexWithinCheckpoint;
668
1245
  buildDeadline: Date | undefined;
669
- }): Promise<{ canStartBuilding: boolean; availableTxs: number }> {
1246
+ }): Promise<{ canStartBuilding: boolean; minTxs: number }> {
670
1247
  const { indexWithinCheckpoint, blockNumber, buildDeadline, forceCreate } = opts;
671
1248
 
672
1249
  // We only allow a block with 0 txs in the first block of the checkpoint
673
1250
  const minTxs = indexWithinCheckpoint > 0 && this.config.minTxsPerBlock === 0 ? 1 : this.config.minTxsPerBlock;
674
1251
 
675
- // Deadline is undefined if we are not enforcing the timetable, meaning we'll exit immediately when out of time
1252
+ // Latest time to keep waiting for txs: wait_for_txs_deadline = block_build_deadline(k) - min_block_duration.
676
1253
  const startBuildingDeadline = buildDeadline
677
- ? new Date(buildDeadline.getTime() - this.timetable.minExecutionTime * 1000)
1254
+ ? new Date(buildDeadline.getTime() - this.timetable.minBlockDuration * 1000)
678
1255
  : undefined;
679
1256
 
680
- let availableTxs = await this.p2pClient.getPendingTxCount();
681
-
682
- while (!forceCreate && availableTxs < minTxs) {
1257
+ // Gate on age-eligible txs so we don't start building on txs the builder would then filter out for being
1258
+ // too fresh. hasEligiblePendingTxs early-exits once minTxs are eligible instead of counting the whole pool.
1259
+ while (!forceCreate && !(await this.p2pClient.hasEligiblePendingTxs(minTxs))) {
683
1260
  // If we're past deadline, or we have no deadline, give up
684
1261
  const now = this.dateProvider.nowAsDate();
685
1262
  if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
686
- return { canStartBuilding: false, availableTxs: availableTxs };
1263
+ return { canStartBuilding: false, minTxs };
687
1264
  }
688
1265
 
689
1266
  // Wait a bit before checking again
690
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.slot);
1267
+ this.setState(SequencerState.WAITING_FOR_TXS);
691
1268
  this.log.verbose(
692
- `Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (have ${availableTxs} but need ${minTxs})`,
693
- { blockNumber, slot: this.slot, indexWithinCheckpoint },
1269
+ `Waiting for ${minTxs} age-eligible txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot}`,
1270
+ { blockNumber, slot: this.targetSlot, indexWithinCheckpoint, minTxs },
694
1271
  );
695
1272
  await this.waitForTxsPollingInterval();
696
- availableTxs = await this.p2pClient.getPendingTxCount();
697
1273
  }
698
1274
 
699
- return { canStartBuilding: true, availableTxs };
1275
+ return { canStartBuilding: true, minTxs };
1276
+ }
1277
+
1278
+ private async getSignedCommitteeAttestations(
1279
+ broadcast: CheckpointProposalBroadcast,
1280
+ ): Promise<{ attestations: CommitteeAttestationsAndSigners; attestationsSignature: Signature } | undefined> {
1281
+ const { proposal, blockProposedAt } = broadcast;
1282
+ this.setState(SequencerState.COLLECTING_ATTESTATIONS);
1283
+ const attestations = await this.waitForAttestations(proposal);
1284
+ if (!attestations) {
1285
+ return undefined;
1286
+ }
1287
+ this.checkpointMetrics.recordCheckpointAttestationDelay(this.dateProvider.now() - blockProposedAt);
1288
+
1289
+ // Proposer must sign over the attestations before pushing them to L1
1290
+ const signer = this.proposer ?? this.publisher.getSenderAddress();
1291
+ try {
1292
+ const attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
1293
+ attestations,
1294
+ signer,
1295
+ this.targetSlot,
1296
+ this.checkpointNumber,
1297
+ );
1298
+ return { attestations, attestationsSignature };
1299
+ } catch (err) {
1300
+ if (this.handleHASigningError(err, 'Attestations signature')) {
1301
+ return;
1302
+ }
1303
+ this.log.error(`Error signing attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
1304
+ return undefined;
1305
+ }
700
1306
  }
701
1307
 
702
1308
  /**
@@ -704,10 +1310,12 @@ export class CheckpointProposalJob implements Traceable {
704
1310
  * This is run after all blocks for the checkpoint have been built.
705
1311
  */
706
1312
  @trackSpan('CheckpointProposalJob.waitForAttestations')
707
- private async waitForAttestations(proposal: CheckpointProposal): Promise<CommitteeAttestationsAndSigners> {
1313
+ private async waitForAttestations(
1314
+ proposal: CheckpointProposal,
1315
+ ): Promise<CommitteeAttestationsAndSigners | undefined> {
708
1316
  if (this.config.fishermanMode) {
709
1317
  this.log.debug('Skipping attestation collection in fisherman mode');
710
- return CommitteeAttestationsAndSigners.empty();
1318
+ return CommitteeAttestationsAndSigners.empty(this.getSignatureContext());
711
1319
  }
712
1320
 
713
1321
  const slotNumber = proposal.slotNumber;
@@ -717,25 +1325,33 @@ export class CheckpointProposalJob implements Traceable {
717
1325
  throw new Error('No committee when collecting attestations');
718
1326
  } else if (committee.length === 0) {
719
1327
  this.log.verbose(`Attesting committee is empty`);
720
- return CommitteeAttestationsAndSigners.empty();
1328
+ return CommitteeAttestationsAndSigners.empty(this.getSignatureContext());
721
1329
  } else {
722
1330
  this.log.debug(`Attesting committee length is ${committee.length}`, { committee });
723
1331
  }
724
1332
 
725
- const numberOfRequiredAttestations = Math.floor((committee.length * 2) / 3) + 1;
1333
+ const numberOfRequiredAttestations = computeQuorum(committee.length);
726
1334
 
727
1335
  if (this.config.skipCollectingAttestations) {
728
1336
  this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
729
- const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
730
- return new CommitteeAttestationsAndSigners(orderAttestations(attestations ?? [], committee));
1337
+ const attestations = await this.validatorClient?.collectOwnAttestations(proposal, this.checkpointNumber);
1338
+ this.logCheckpointAttestations('collected', committee, attestations ?? [], numberOfRequiredAttestations, {
1339
+ reason: 'collect_own_only',
1340
+ });
1341
+ return new CommitteeAttestationsAndSigners(
1342
+ orderAttestations(attestations ?? [], committee),
1343
+ this.getSignatureContext(),
1344
+ );
731
1345
  }
732
1346
 
733
- const attestationTimeAllowed = this.config.enforceTimeTable
734
- ? this.timetable.getMaxAllowedTime(SequencerState.PUBLISHING_CHECKPOINT)!
735
- : this.l1Constants.slotDuration;
736
- const attestationDeadline = new Date((this.getSlotStartBuildTimestamp() + attestationTimeAllowed) * 1000);
1347
+ // Hard attestation-collection cutoff = the single consensus attestation_deadline (target_slot_start + S - 2E).
1348
+ const attestationDeadlineSeconds = this.timetable.getAttestationDeadline(this.targetSlot);
1349
+ const attestationDeadline = new Date(attestationDeadlineSeconds * 1000);
737
1350
 
738
- this.metrics.recordRequiredAttestations(numberOfRequiredAttestations, attestationTimeAllowed);
1351
+ this.metrics.recordRequiredAttestations(
1352
+ numberOfRequiredAttestations,
1353
+ Math.max(0, attestationDeadline.getTime() - this.dateProvider.now()),
1354
+ );
739
1355
 
740
1356
  const collectAttestationsTimer = new Timer();
741
1357
  let collectedAttestationsCount: number = 0;
@@ -744,6 +1360,7 @@ export class CheckpointProposalJob implements Traceable {
744
1360
  proposal,
745
1361
  numberOfRequiredAttestations,
746
1362
  attestationDeadline,
1363
+ this.checkpointNumber,
747
1364
  );
748
1365
 
749
1366
  collectedAttestationsCount = attestations.length;
@@ -762,28 +1379,71 @@ export class CheckpointProposalJob implements Traceable {
762
1379
 
763
1380
  // Rollup contract requires that the signatures are provided in the order of the committee
764
1381
  const sorted = orderAttestations(trimmed, committee);
1382
+ this.logCheckpointAttestations('collected', committee, attestations, numberOfRequiredAttestations, {
1383
+ submittedCount: trimmed.length,
1384
+ });
765
1385
 
766
1386
  // Manipulate the attestations if we've been configured to do so
767
1387
  if (
768
1388
  this.config.injectFakeAttestation ||
769
1389
  this.config.injectHighSValueAttestation ||
770
1390
  this.config.injectUnrecoverableSignatureAttestation ||
1391
+ this.config.injectYParityAttestation ||
771
1392
  this.config.shuffleAttestationOrdering
772
1393
  ) {
773
1394
  return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
774
1395
  }
775
1396
 
776
- return new CommitteeAttestationsAndSigners(sorted);
1397
+ return new CommitteeAttestationsAndSigners(sorted, this.getSignatureContext());
777
1398
  } catch (err) {
778
1399
  if (err && err instanceof AttestationTimeoutError) {
779
1400
  collectedAttestationsCount = err.collectedCount;
1401
+ this.logCheckpointAttestations('failed', committee, undefined, numberOfRequiredAttestations, {
1402
+ collectedCount: collectedAttestationsCount,
1403
+ reason: 'timeout',
1404
+ });
1405
+ this.log.error(
1406
+ `Timeout while waiting for attestations for checkpoint proposal at slot ${proposal.slotNumber} (collected ${collectedAttestationsCount}/${numberOfRequiredAttestations})`,
1407
+ err,
1408
+ );
1409
+ } else {
1410
+ this.logCheckpointAttestations('failed', committee, undefined, numberOfRequiredAttestations, {
1411
+ collectedCount: collectedAttestationsCount,
1412
+ reason: err instanceof Error ? err.message : String(err),
1413
+ });
1414
+ this.log.error(`Error collecting attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
780
1415
  }
781
- throw err;
1416
+ return undefined;
782
1417
  } finally {
783
1418
  this.metrics.recordCollectedAttestations(collectedAttestationsCount, collectAttestationsTimer.ms());
784
1419
  }
785
1420
  }
786
1421
 
1422
+ private logCheckpointAttestations(
1423
+ status: 'collected' | 'failed',
1424
+ committee: EthAddress[],
1425
+ attestations: CheckpointAttestation[] | undefined,
1426
+ requiredAttestations: number,
1427
+ opts: { collectedCount?: number; submittedCount?: number; reason?: string } = {},
1428
+ ) {
1429
+ const signedValidators =
1430
+ attestations
1431
+ ?.map(attestation => attestation.getSender()?.toString())
1432
+ .filter((address): address is `0x${string}` => address !== undefined) ?? [];
1433
+ const collectedCount = opts.collectedCount ?? new Set(signedValidators).size;
1434
+ const missingValidatorCount = status === 'failed' ? Math.max(0, requiredAttestations - collectedCount) : undefined;
1435
+ this.logCheckpointEvent(`attestations-${status}`, `Checkpoint attestations ${status} for slot ${this.targetSlot}`, {
1436
+ slot: this.targetSlot,
1437
+ checkpointNumber: this.checkpointNumber,
1438
+ committeeSize: committee.length,
1439
+ requiredAttestations,
1440
+ collectedAttestations: collectedCount,
1441
+ ...(opts.submittedCount !== undefined && { submittedAttestations: opts.submittedCount }),
1442
+ ...(missingValidatorCount !== undefined && { missingValidatorCount }),
1443
+ ...(opts.reason !== undefined && { reason: opts.reason }),
1444
+ });
1445
+ }
1446
+
787
1447
  /** Breaks the attestations before publishing based on attack configs */
788
1448
  private manipulateAttestations(
789
1449
  slotNumber: SlotNumber,
@@ -827,7 +1487,20 @@ export class CheckpointProposalJob implements Traceable {
827
1487
  unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
828
1488
  }
829
1489
  }
830
- return new CommitteeAttestationsAndSigners(attestations);
1490
+ return new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext());
1491
+ }
1492
+
1493
+ if (this.config.injectYParityAttestation) {
1494
+ // Force every non-proposer signed slot's recovery byte to yParity (v ∈ {0, 1}) form in the packed L1
1495
+ // tuple, after packAttestations has canonicalized it. The proposer's own slot is left canonical so
1496
+ // propose() still passes verifyProposer. Models a malicious proposer landing a checkpoint L1 accepts
1497
+ // but that can never be proven (ECDSA.recover rejects v ∉ {27, 28}).
1498
+ this.log.warn(`Injecting yParity attestations in checkpoint for slot ${slotNumber} (proposer #${proposerIndex})`);
1499
+ return new MaliciousYParityCommitteeAttestationsAndSigners(
1500
+ attestations,
1501
+ proposerIndex,
1502
+ this.getSignatureContext(),
1503
+ );
831
1504
  }
832
1505
 
833
1506
  if (this.config.shuffleAttestationOrdering) {
@@ -849,11 +1522,11 @@ export class CheckpointProposalJob implements Traceable {
849
1522
  [shuffled[i], shuffled[j]] = [shuffled[j], shuffled[i]];
850
1523
  }
851
1524
 
852
- const signers = new CommitteeAttestationsAndSigners(attestations).getSigners();
853
- return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers);
1525
+ const signers = new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext()).getSigners();
1526
+ return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers, this.getSignatureContext());
854
1527
  }
855
1528
 
856
- return new CommitteeAttestationsAndSigners(attestations);
1529
+ return new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext());
857
1530
  }
858
1531
 
859
1532
  private async dropFailedTxsFromP2P(failedTxs: FailedTx[]) {
@@ -862,7 +1535,11 @@ export class CheckpointProposalJob implements Traceable {
862
1535
  }
863
1536
  const failedTxData = failedTxs.map(fail => fail.tx);
864
1537
  const failedTxHashes = failedTxData.map(tx => tx.getTxHash());
865
- this.log.verbose(`Dropping failed txs ${failedTxHashes.join(', ')}`);
1538
+ const failures = failedTxs.map(fail => ({ txHash: fail.tx.getTxHash().toString(), reason: fail.error.message }));
1539
+ this.log.warn(
1540
+ `Dropping ${failedTxs.length} txs from mempool due to failures during block building for slot ${this.targetSlot}`,
1541
+ { slot: this.targetSlot, checkpointNumber: this.checkpointNumber, failures },
1542
+ );
866
1543
  await this.p2pClient.handleFailedExecution(failedTxHashes);
867
1544
  }
868
1545
 
@@ -870,9 +1547,13 @@ export class CheckpointProposalJob implements Traceable {
870
1547
  * Adds the proposed block to the archiver so it's available via P2P.
871
1548
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
872
1549
  * would never receive its own block without this explicit sync.
1550
+ *
1551
+ * In fisherman mode we skip this push: the fisherman builds blocks locally for validation
1552
+ * and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
1553
+ * whenever the real proposer's block arrives from L1.
873
1554
  */
874
1555
  private async syncProposedBlockToArchiver(block: L2Block): Promise<void> {
875
- if (this.config.skipPushProposedBlocksToArchiver !== false) {
1556
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
876
1557
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
877
1558
  blockNumber: block.number,
878
1559
  slot: block.header.globalVariables.slotNumber,
@@ -886,23 +1567,58 @@ export class CheckpointProposalJob implements Traceable {
886
1567
  await this.blockSink.addBlock(block);
887
1568
  }
888
1569
 
1570
+ /**
1571
+ * Adds the proposed checkpoint to the archiver so the proposer's optimistic proposed-checkpoint
1572
+ * tip advances locally. Gossip doesn't echo our own messages back, so without this the proposer
1573
+ * would never see its own proposed checkpoint and couldn't pipeline the next slot.
1574
+ *
1575
+ * Skipped whenever proposed blocks aren't pushed (`skipPushProposedBlocksToArchiver`, fisherman
1576
+ * mode): the archiver derives the checkpoint archive from its stored blocks, so without them the
1577
+ * push would fail. All blocks were already added (and awaited) during block building, so this
1578
+ * needs no retry — they are guaranteed present by the time we get here.
1579
+ */
1580
+ private async syncProposedCheckpointToArchiver(
1581
+ checkpoint: Checkpoint,
1582
+ blockCount: number,
1583
+ feeAssetPriceModifier: bigint,
1584
+ ): Promise<void> {
1585
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
1586
+ return;
1587
+ }
1588
+ const startBlock = BlockNumber(this.syncedToBlockNumber + 1);
1589
+ this.log.debug(`Syncing proposed checkpoint ${this.checkpointNumber} to archiver`, {
1590
+ checkpointNumber: this.checkpointNumber,
1591
+ slot: this.targetSlot,
1592
+ startBlock,
1593
+ blockCount,
1594
+ });
1595
+ await this.blockSink.addProposedCheckpoint({
1596
+ header: checkpoint.header,
1597
+ checkpointNumber: this.checkpointNumber,
1598
+ startBlock,
1599
+ blockCount,
1600
+ totalManaUsed: checkpoint.header.totalManaUsed.toBigInt(),
1601
+ feeAssetPriceModifier,
1602
+ });
1603
+ }
1604
+
889
1605
  /** Runs fee analysis and logs checkpoint outcome as fisherman */
890
1606
  private async handleCheckpointEndAsFisherman(checkpoint: Checkpoint | undefined) {
891
1607
  // Perform L1 fee analysis before clearing requests
892
1608
  // The callback is invoked asynchronously after the next block is mined
893
- const feeAnalysis = await this.publisher.analyzeL1Fees(this.slot, analysis =>
1609
+ const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, analysis =>
894
1610
  this.metrics.recordFishermanFeeAnalysis(analysis),
895
1611
  );
896
1612
 
897
1613
  if (checkpoint) {
898
- this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.slot}`, {
1614
+ this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
899
1615
  ...checkpoint.toCheckpointInfo(),
900
1616
  ...checkpoint.getStats(),
901
1617
  feeAnalysisId: feeAnalysis?.id,
902
1618
  });
903
1619
  } else {
904
- this.log.warn(`Validation block building FAILED for slot ${this.slot}`, {
905
- slot: this.slot,
1620
+ this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
1621
+ slot: this.targetSlot,
906
1622
  feeAnalysisId: feeAnalysis?.id,
907
1623
  });
908
1624
  this.metrics.recordCheckpointProposalFailed('block_build_failed');
@@ -916,15 +1632,15 @@ export class CheckpointProposalJob implements Traceable {
916
1632
  */
917
1633
  private handleHASigningError(err: any, errorContext: string): boolean {
918
1634
  if (err instanceof DutyAlreadySignedError) {
919
- this.log.info(`${errorContext} for slot ${this.slot} already signed by another HA node, yielding`, {
920
- slot: this.slot,
1635
+ this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
1636
+ slot: this.targetSlot,
921
1637
  signedByNode: err.signedByNode,
922
1638
  });
923
1639
  return true;
924
1640
  }
925
1641
  if (err instanceof SlashingProtectionError) {
926
- this.log.info(`${errorContext} for slot ${this.slot} blocked by slashing protection, yielding`, {
927
- slot: this.slot,
1642
+ this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
1643
+ slot: this.targetSlot,
928
1644
  existingMessageHash: err.existingMessageHash,
929
1645
  attemptedMessageHash: err.attemptedMessageHash,
930
1646
  });
@@ -933,26 +1649,9 @@ export class CheckpointProposalJob implements Traceable {
933
1649
  return false;
934
1650
  }
935
1651
 
936
- /** Waits until a specific time within the current slot */
937
- @trackSpan('CheckpointProposalJob.waitUntilTimeInSlot')
938
- protected async waitUntilTimeInSlot(targetSecondsIntoSlot: number): Promise<void> {
939
- const slotStartTimestamp = this.getSlotStartBuildTimestamp();
940
- const targetTimestamp = slotStartTimestamp + targetSecondsIntoSlot;
941
- await sleepUntil(new Date(targetTimestamp * 1000), this.dateProvider.nowAsDate());
942
- }
943
-
944
1652
  /** Waits the polling interval for transactions. Extracted for test overriding. */
945
1653
  protected async waitForTxsPollingInterval(): Promise<void> {
946
- await sleep(TXS_POLLING_MS);
947
- }
948
-
949
- private getSlotStartBuildTimestamp(): number {
950
- return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
951
- }
952
-
953
- private getSecondsIntoSlot(): number {
954
- const slotStartTimestamp = this.getSlotStartBuildTimestamp();
955
- return Number((this.dateProvider.now() / 1000 - slotStartTimestamp).toFixed(3));
1654
+ await this.awaitInterruptibleSleep(TXS_POLLING_MS);
956
1655
  }
957
1656
 
958
1657
  public getPublisher() {