@aztec/sequencer-client 0.0.1-commit.e3c1de76 → 0.0.1-commit.e588bc7e5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (84) hide show
  1. package/dest/client/sequencer-client.d.ts +15 -7
  2. package/dest/client/sequencer-client.d.ts.map +1 -1
  3. package/dest/client/sequencer-client.js +60 -26
  4. package/dest/config.d.ts +26 -7
  5. package/dest/config.d.ts.map +1 -1
  6. package/dest/config.js +47 -28
  7. package/dest/global_variable_builder/global_builder.d.ts +15 -11
  8. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  9. package/dest/global_variable_builder/global_builder.js +29 -25
  10. package/dest/global_variable_builder/index.d.ts +2 -2
  11. package/dest/global_variable_builder/index.d.ts.map +1 -1
  12. package/dest/publisher/config.d.ts +47 -17
  13. package/dest/publisher/config.d.ts.map +1 -1
  14. package/dest/publisher/config.js +121 -42
  15. package/dest/publisher/index.d.ts +2 -1
  16. package/dest/publisher/index.d.ts.map +1 -1
  17. package/dest/publisher/l1_tx_failed_store/factory.d.ts +11 -0
  18. package/dest/publisher/l1_tx_failed_store/factory.d.ts.map +1 -0
  19. package/dest/publisher/l1_tx_failed_store/factory.js +22 -0
  20. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +59 -0
  21. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -0
  22. package/dest/publisher/l1_tx_failed_store/failed_tx_store.js +1 -0
  23. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts +15 -0
  24. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts.map +1 -0
  25. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.js +34 -0
  26. package/dest/publisher/l1_tx_failed_store/index.d.ts +4 -0
  27. package/dest/publisher/l1_tx_failed_store/index.d.ts.map +1 -0
  28. package/dest/publisher/l1_tx_failed_store/index.js +2 -0
  29. package/dest/publisher/sequencer-publisher-factory.d.ts +11 -3
  30. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  31. package/dest/publisher/sequencer-publisher-factory.js +27 -2
  32. package/dest/publisher/sequencer-publisher.d.ts +76 -30
  33. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  34. package/dest/publisher/sequencer-publisher.js +396 -71
  35. package/dest/sequencer/checkpoint_proposal_job.d.ts +39 -8
  36. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  37. package/dest/sequencer/checkpoint_proposal_job.js +368 -196
  38. package/dest/sequencer/checkpoint_voter.d.ts +1 -2
  39. package/dest/sequencer/checkpoint_voter.d.ts.map +1 -1
  40. package/dest/sequencer/checkpoint_voter.js +2 -5
  41. package/dest/sequencer/events.d.ts +2 -1
  42. package/dest/sequencer/events.d.ts.map +1 -1
  43. package/dest/sequencer/metrics.d.ts +21 -5
  44. package/dest/sequencer/metrics.d.ts.map +1 -1
  45. package/dest/sequencer/metrics.js +97 -15
  46. package/dest/sequencer/sequencer.d.ts +42 -17
  47. package/dest/sequencer/sequencer.d.ts.map +1 -1
  48. package/dest/sequencer/sequencer.js +147 -89
  49. package/dest/sequencer/timetable.d.ts +4 -6
  50. package/dest/sequencer/timetable.d.ts.map +1 -1
  51. package/dest/sequencer/timetable.js +7 -11
  52. package/dest/sequencer/types.d.ts +2 -2
  53. package/dest/sequencer/types.d.ts.map +1 -1
  54. package/dest/test/index.d.ts +3 -5
  55. package/dest/test/index.d.ts.map +1 -1
  56. package/dest/test/mock_checkpoint_builder.d.ts +11 -11
  57. package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
  58. package/dest/test/mock_checkpoint_builder.js +45 -34
  59. package/dest/test/utils.d.ts +3 -3
  60. package/dest/test/utils.d.ts.map +1 -1
  61. package/dest/test/utils.js +5 -4
  62. package/package.json +27 -28
  63. package/src/client/sequencer-client.ts +76 -23
  64. package/src/config.ts +65 -38
  65. package/src/global_variable_builder/global_builder.ts +38 -27
  66. package/src/global_variable_builder/index.ts +1 -1
  67. package/src/publisher/config.ts +153 -43
  68. package/src/publisher/index.ts +3 -0
  69. package/src/publisher/l1_tx_failed_store/factory.ts +32 -0
  70. package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +55 -0
  71. package/src/publisher/l1_tx_failed_store/file_store_failed_tx_store.ts +46 -0
  72. package/src/publisher/l1_tx_failed_store/index.ts +3 -0
  73. package/src/publisher/sequencer-publisher-factory.ts +38 -6
  74. package/src/publisher/sequencer-publisher.ts +442 -95
  75. package/src/sequencer/checkpoint_proposal_job.ts +481 -202
  76. package/src/sequencer/checkpoint_voter.ts +1 -12
  77. package/src/sequencer/events.ts +1 -1
  78. package/src/sequencer/metrics.ts +106 -18
  79. package/src/sequencer/sequencer.ts +212 -105
  80. package/src/sequencer/timetable.ts +13 -12
  81. package/src/sequencer/types.ts +1 -1
  82. package/src/test/index.ts +2 -4
  83. package/src/test/mock_checkpoint_builder.ts +63 -49
  84. package/src/test/utils.ts +5 -2
@@ -436,10 +436,10 @@ function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
436
436
  return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
437
437
  }
438
438
  var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _initProto;
439
- import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
440
- import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
441
- import { BlockNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
439
+ import { RollupContract } from '@aztec/ethereum/contracts';
440
+ import { BlockNumber, CheckpointNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
442
441
  import { randomInt } from '@aztec/foundation/crypto/random';
442
+ import { flipSignature, generateRecoverableSignature, generateUnrecoverableSignature } from '@aztec/foundation/crypto/secp256k1-signer';
443
443
  import { Signature } from '@aztec/foundation/eth-signature';
444
444
  import { filter } from '@aztec/foundation/iterator';
445
445
  import { createLogger } from '@aztec/foundation/log';
@@ -447,11 +447,12 @@ import { sleep, sleepUntil } from '@aztec/foundation/sleep';
447
447
  import { Timer } from '@aztec/foundation/timer';
448
448
  import { isErrorClass, unfreeze } from '@aztec/foundation/types';
449
449
  import { CommitteeAttestationsAndSigners, MaliciousCommitteeAttestationsAndSigners } from '@aztec/stdlib/block';
450
- import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
450
+ import { validateCheckpoint } from '@aztec/stdlib/checkpoint';
451
+ import { computeQuorum, getSlotStartBuildTimestamp, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
451
452
  import { Gas } from '@aztec/stdlib/gas';
452
- import { NoValidTxsError } from '@aztec/stdlib/interfaces/server';
453
+ import { InsufficientValidTxsError } from '@aztec/stdlib/interfaces/server';
453
454
  import { computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
454
- import { orderAttestations } from '@aztec/stdlib/p2p';
455
+ import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
455
456
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
456
457
  import { Attributes, trackSpan } from '@aztec/telemetry-client';
457
458
  import { DutyAlreadySignedError, SlashingProtectionError } from '@aztec/validator-ha-signer/errors';
@@ -463,7 +464,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
463
464
  return {
464
465
  // nullish operator needed for tests
465
466
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
466
- [Attributes.SLOT_NUMBER]: this.slot
467
+ [Attributes.SLOT_NUMBER]: this.targetSlot
467
468
  };
468
469
  }), _dec2 = trackSpan('CheckpointProposalJob.buildBlocksForCheckpoint'), _dec3 = trackSpan('CheckpointProposalJob.waitUntilNextSubslot'), _dec4 = trackSpan('CheckpointProposalJob.buildSingleBlock'), _dec5 = trackSpan('CheckpointProposalJob.waitForMinTxs'), _dec6 = trackSpan('CheckpointProposalJob.waitForAttestations'), _dec7 = trackSpan('CheckpointProposalJob.waitUntilTimeInSlot');
469
470
  /**
@@ -472,8 +473,9 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
472
473
  * as well as enqueueing votes for slashing and governance proposals. This class is created from
473
474
  * the Sequencer once the check for being the proposer for the slot has succeeded.
474
475
  */ export class CheckpointProposalJob {
475
- epoch;
476
- slot;
476
+ slotNow;
477
+ targetSlot;
478
+ targetEpoch;
477
479
  checkpointNumber;
478
480
  syncedToBlockNumber;
479
481
  proposer;
@@ -498,6 +500,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
498
500
  eventEmitter;
499
501
  setStateFn;
500
502
  tracer;
503
+ proposedCheckpointData;
501
504
  static{
502
505
  ({ e: [_initProto] } = _apply_decs_2203_r(this, [
503
506
  [
@@ -543,10 +546,13 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
543
546
  ], []));
544
547
  }
545
548
  log;
546
- constructor(epoch, slot, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
547
- proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, eventEmitter, setStateFn, tracer, bindings){
548
- this.epoch = epoch;
549
- this.slot = slot;
549
+ /** Tracks the fire-and-forget L1 submission promise so it can be awaited during shutdown. */ pendingL1Submission;
550
+ /** Fee header override computed during proposeCheckpoint, reused in enqueueCheckpointForSubmission. */ computedForceProposedFeeHeader;
551
+ constructor(slotNow, targetSlot, targetEpoch, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
552
+ proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, eventEmitter, setStateFn, tracer, bindings, proposedCheckpointData){
553
+ this.slotNow = slotNow;
554
+ this.targetSlot = targetSlot;
555
+ this.targetEpoch = targetEpoch;
550
556
  this.checkpointNumber = checkpointNumber;
551
557
  this.syncedToBlockNumber = syncedToBlockNumber;
552
558
  this.proposer = proposer;
@@ -571,50 +577,107 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
571
577
  this.eventEmitter = eventEmitter;
572
578
  this.setStateFn = setStateFn;
573
579
  this.tracer = tracer;
580
+ this.proposedCheckpointData = proposedCheckpointData;
574
581
  _initProto(this);
575
582
  this.log = createLogger('sequencer:checkpoint-proposal', {
576
583
  ...bindings,
577
- instanceId: `slot-${slot}`
584
+ instanceId: `slot-${this.slotNow}`
578
585
  });
579
586
  }
587
+ /** Awaits the pending L1 submission if one is in progress. Call during shutdown. */ async awaitPendingSubmission() {
588
+ this.log.info('Awaiting pending L1 payload submission');
589
+ await this.pendingL1Submission;
590
+ }
580
591
  /**
581
592
  * Executes the checkpoint proposal job.
582
- * Returns the published checkpoint if successful, undefined otherwise.
593
+ * Builds blocks, collects attestations, enqueues requests, and schedules L1 submission as a
594
+ * background task so the work loop can return to IDLE immediately.
595
+ * Returns the built checkpoint if successful, undefined otherwise.
583
596
  */ async execute() {
584
597
  // Enqueue governance and slashing votes (returns promises that will be awaited later)
585
598
  // In fisherman mode, we simulate slashing but don't actually publish to L1
586
599
  // These are constant for the whole slot, so we only enqueue them once
587
- const votesPromises = new CheckpointVoter(this.slot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
588
- // Build and propose the checkpoint. This will enqueue the request on the publisher if a checkpoint is built.
589
- const checkpoint = await this.proposeCheckpoint();
600
+ const votesPromises = new CheckpointVoter(this.targetSlot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
601
+ // Build and propose the checkpoint. Builds blocks, broadcasts, collects attestations, and signs.
602
+ // Does NOT enqueue to L1 yet — that happens after the pipeline sleep.
603
+ const proposalResult = await this.proposeCheckpoint();
604
+ const checkpoint = proposalResult?.checkpoint;
590
605
  // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
591
606
  await Promise.all(votesPromises);
592
607
  if (checkpoint) {
593
- this.metrics.recordBlockProposalSuccess();
608
+ this.metrics.recordCheckpointProposalSuccess();
594
609
  }
595
610
  // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
596
611
  if (this.config.fishermanMode) {
597
612
  await this.handleCheckpointEndAsFisherman(checkpoint);
598
613
  return;
599
614
  }
600
- // Then send everything to L1
601
- const l1Response = await this.publisher.sendRequests();
602
- const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
603
- if (proposedAction) {
604
- this.eventEmitter.emit('checkpoint-published', {
605
- checkpoint: this.checkpointNumber,
606
- slot: this.slot
607
- });
608
- const coinbase = checkpoint?.header.coinbase;
609
- await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
610
- return checkpoint;
611
- } else if (checkpoint) {
612
- this.eventEmitter.emit('checkpoint-publish-failed', {
613
- ...l1Response,
614
- slot: this.slot
615
- });
616
- return undefined;
615
+ // Enqueue the checkpoint for L1 submission
616
+ if (proposalResult) {
617
+ try {
618
+ await this.enqueueCheckpointForSubmission(proposalResult);
619
+ } catch (err) {
620
+ this.log.error(`Failed to enqueue checkpoint for L1 submission at slot ${this.targetSlot}`, err);
621
+ // Continue to sendRequestsAt so votes are still sent
622
+ }
617
623
  }
624
+ // Compute the earliest time to submit: pipeline slot start when pipelining, now otherwise.
625
+ const submitAfter = this.epochCache.isProposerPipeliningEnabled() ? new Date(Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) * 1000) : new Date(this.dateProvider.now());
626
+ // TODO(https://github.com/AztecProtocol/aztec-packages/pull/21250): should discard the pending submission if a reorg occurs underneath
627
+ // Schedule L1 submission in the background so the work loop returns immediately.
628
+ // The publisher will sleep until submitAfter, then send the bundled requests.
629
+ // The promise is stored so it can be awaited during shutdown.
630
+ this.pendingL1Submission = this.publisher.sendRequestsAt(submitAfter).then(async (l1Response)=>{
631
+ const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
632
+ if (proposedAction) {
633
+ this.eventEmitter.emit('checkpoint-published', {
634
+ checkpoint: this.checkpointNumber,
635
+ slot: this.targetSlot
636
+ });
637
+ const coinbase = checkpoint?.header.coinbase;
638
+ await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
639
+ } else if (checkpoint) {
640
+ this.eventEmitter.emit('checkpoint-publish-failed', {
641
+ ...l1Response,
642
+ slot: this.targetSlot
643
+ });
644
+ if (this.epochCache.isProposerPipeliningEnabled()) {
645
+ this.metrics.recordPipelineDiscard();
646
+ }
647
+ }
648
+ }).catch((err)=>{
649
+ this.log.error(`Background L1 submission failed for slot ${this.targetSlot}`, err);
650
+ if (checkpoint) {
651
+ this.eventEmitter.emit('checkpoint-publish-failed', {
652
+ slot: this.targetSlot
653
+ });
654
+ if (this.epochCache.isProposerPipeliningEnabled()) {
655
+ this.metrics.recordPipelineDiscard();
656
+ }
657
+ }
658
+ });
659
+ // Return the built checkpoint immediately — the work loop is now unblocked
660
+ return checkpoint;
661
+ }
662
+ /** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */ async enqueueCheckpointForSubmission(result) {
663
+ const { checkpoint, attestations, attestationsSignature } = result;
664
+ this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.targetSlot);
665
+ const aztecSlotDuration = this.l1Constants.slotDuration;
666
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
667
+ const txTimeoutAt = new Date((submissionSlotStart + aztecSlotDuration) * 1000);
668
+ // If we have been configured to potentially skip publishing checkpoint then roll the dice here
669
+ if (this.config.skipPublishingCheckpointsPercent !== undefined && this.config.skipPublishingCheckpointsPercent > 0) {
670
+ const roll = Math.max(0, randomInt(100));
671
+ if (roll < this.config.skipPublishingCheckpointsPercent) {
672
+ this.log.warn(`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${roll}`);
673
+ return;
674
+ }
675
+ }
676
+ await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
677
+ txTimeoutAt,
678
+ forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
679
+ forceProposedFeeHeader: this.computedForceProposedFeeHeader
680
+ });
618
681
  }
619
682
  async proposeCheckpoint() {
620
683
  try {
@@ -628,25 +691,44 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
628
691
  const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
629
692
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
630
693
  // Start the checkpoint
631
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.slot);
632
- this.metrics.incOpenSlot(this.slot, this.proposer?.toString() ?? 'unknown');
694
+ this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.targetSlot);
695
+ this.log.info(`Starting checkpoint proposal`, {
696
+ buildSlot: this.slotNow,
697
+ submissionSlot: this.targetSlot,
698
+ pipelining: this.epochCache.isProposerPipeliningEnabled(),
699
+ proposer: this.proposer?.toString(),
700
+ coinbase: coinbase.toString()
701
+ });
702
+ this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
633
703
  // Enqueues checkpoint invalidation (constant for the whole slot)
634
704
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
635
705
  this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
636
706
  }
637
- // Create checkpoint builder for the slot
638
- const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.slot);
707
+ // Create checkpoint builder for the slot.
708
+ // When pipelining, force the proposed checkpoint number and fee header to our parent so the
709
+ // fee computation sees the same chain tip that L1 will see once the previous pipelined checkpoint lands.
710
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
711
+ const parentCheckpointNumber = isPipelining ? CheckpointNumber(this.checkpointNumber - 1) : undefined;
712
+ // Compute the parent's fee header override when pipelining
713
+ if (isPipelining && this.proposedCheckpointData) {
714
+ this.computedForceProposedFeeHeader = await this.computeForceProposedFeeHeader(parentCheckpointNumber);
715
+ }
716
+ const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.targetSlot, {
717
+ forcePendingCheckpointNumber: parentCheckpointNumber,
718
+ forceProposedFeeHeader: this.computedForceProposedFeeHeader
719
+ });
639
720
  // Collect L1 to L2 messages for the checkpoint and compute their hash
640
721
  const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(this.checkpointNumber);
641
722
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
642
723
  // Collect the out hashes of all the checkpoints before this one in the same epoch
643
- const previousCheckpoints = (await this.l2BlockSource.getCheckpointsForEpoch(this.epoch)).filter((c)=>c.number < this.checkpointNumber);
644
- const previousCheckpointOutHashes = previousCheckpoints.map((c)=>c.getCheckpointOutHash());
724
+ const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.targetEpoch)).filter((c)=>c.checkpointNumber < this.checkpointNumber).map((c)=>c.checkpointOutHash);
725
+ // Get the fee asset price modifier from the oracle
726
+ const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier();
645
727
  const fork = _ts_add_disposable_resource(env, await this.worldState.fork(this.syncedToBlockNumber, {
646
728
  closeDelayMs: 12_000
647
- }), false);
729
+ }), true);
648
730
  // Create checkpoint builder for the entire slot
649
- const checkpointBuilder = await this.checkpointsBuilder.startCheckpoint(this.checkpointNumber, checkpointGlobalVariables, l1ToL2Messages, previousCheckpointOutHashes, fork, this.log.getBindings());
731
+ const checkpointBuilder = await this.checkpointsBuilder.startCheckpoint(this.checkpointNumber, checkpointGlobalVariables, feeAssetPriceModifier, l1ToL2Messages, previousCheckpointOutHashes, fork, this.log.getBindings());
650
732
  // Options for the validator client when creating block and checkpoint proposals
651
733
  const blockProposalOptions = {
652
734
  publishFullTxs: !!this.config.publishTxsWithProposals,
@@ -658,6 +740,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
658
740
  };
659
741
  let blocksInCheckpoint = [];
660
742
  let blockPendingBroadcast = undefined;
743
+ const checkpointBuildTimer = new Timer();
661
744
  try {
662
745
  // Main loop: build blocks for the checkpoint
663
746
  const result = await this.buildBlocksForCheckpoint(checkpointBuilder, checkpointGlobalVariables.timestamp, inHash, blockProposalOptions);
@@ -667,45 +750,64 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
667
750
  // These errors are expected in HA mode, so we yield and let another HA node handle the slot
668
751
  // The only distinction between the 2 errors is SlashingProtectionError throws when the payload is different,
669
752
  // which is normal for block building (may have picked different txs)
670
- if (err instanceof DutyAlreadySignedError) {
671
- this.log.info(`Checkpoint proposal for slot ${this.slot} already signed by another HA node, yielding`, {
672
- slot: this.slot,
673
- signedByNode: err.signedByNode
674
- });
675
- return undefined;
676
- }
677
- if (err instanceof SlashingProtectionError) {
678
- this.log.info(`Checkpoint proposal for slot ${this.slot} blocked by slashing protection, yielding`, {
679
- slot: this.slot,
680
- existingMessageHash: err.existingMessageHash,
681
- attemptedMessageHash: err.attemptedMessageHash
682
- });
753
+ if (this.handleHASigningError(err, 'Block proposal')) {
683
754
  return undefined;
684
755
  }
685
756
  throw err;
686
757
  }
687
758
  if (blocksInCheckpoint.length === 0) {
688
- this.log.warn(`No blocks were built for slot ${this.slot}`, {
689
- slot: this.slot
759
+ this.log.warn(`No blocks were built for slot ${this.targetSlot}`, {
760
+ slot: this.targetSlot
690
761
  });
691
762
  this.eventEmitter.emit('checkpoint-empty', {
692
- slot: this.slot
763
+ slot: this.targetSlot
764
+ });
765
+ return undefined;
766
+ }
767
+ const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
768
+ if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
769
+ this.log.warn(`Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`, {
770
+ slot: this.targetSlot,
771
+ blocksBuilt: blocksInCheckpoint.length,
772
+ minBlocksForCheckpoint
693
773
  });
694
774
  return undefined;
695
775
  }
696
776
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
697
777
  // broadcasted yet, and wait to collect the committee attestations.
698
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
778
+ this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.targetSlot);
699
779
  const checkpoint = await checkpointBuilder.completeCheckpoint();
780
+ // Final validation: per-block limits are only checked if the operator set them explicitly.
781
+ // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
782
+ try {
783
+ validateCheckpoint(checkpoint, {
784
+ rollupManaLimit: this.l1Constants.rollupManaLimit,
785
+ maxL2BlockGas: this.config.maxL2BlockGas,
786
+ maxDABlockGas: this.config.maxDABlockGas,
787
+ maxTxsPerBlock: this.config.maxTxsPerBlock,
788
+ maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint
789
+ });
790
+ } catch (err) {
791
+ this.log.error(`Built an invalid checkpoint at slot ${this.slotNow} (skipping proposal)`, err, {
792
+ checkpoint: checkpoint.header.toInspect()
793
+ });
794
+ return undefined;
795
+ }
796
+ // Record checkpoint-level build metrics
797
+ this.metrics.recordCheckpointBuild(checkpointBuildTimer.ms(), blocksInCheckpoint.length, checkpoint.getStats().txCount, Number(checkpoint.header.totalManaUsed.toBigInt()));
700
798
  // Do not collect attestations nor publish to L1 in fisherman mode
701
799
  if (this.config.fishermanMode) {
702
- this.log.info(`Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
703
- slot: this.slot,
800
+ this.log.info(`Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
801
+ slot: this.targetSlot,
704
802
  checkpoint: checkpoint.header.toInspect(),
705
803
  blocksBuilt: blocksInCheckpoint.length
706
804
  });
707
805
  this.metrics.recordCheckpointSuccess();
708
- return checkpoint;
806
+ return {
807
+ checkpoint,
808
+ attestations: CommitteeAttestationsAndSigners.empty(),
809
+ attestationsSignature: Signature.empty()
810
+ };
709
811
  }
710
812
  // Include the block pending broadcast in the checkpoint proposal if any
711
813
  const lastBlock = blockPendingBroadcast && {
@@ -714,10 +816,10 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
714
816
  txs: blockPendingBroadcast.txs
715
817
  };
716
818
  // Create the checkpoint proposal and broadcast it
717
- const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, lastBlock, this.proposer, checkpointProposalOptions);
819
+ const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, feeAssetPriceModifier, lastBlock, this.proposer, checkpointProposalOptions);
718
820
  const blockProposedAt = this.dateProvider.now();
719
821
  await this.p2pClient.broadcastCheckpointProposal(proposal);
720
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
822
+ this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.targetSlot);
721
823
  const attestations = await this.waitForAttestations(proposal);
722
824
  const blockAttestedAt = this.dateProvider.now();
723
825
  this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
@@ -725,49 +827,34 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
725
827
  const signer = this.proposer ?? this.publisher.getSenderAddress();
726
828
  let attestationsSignature;
727
829
  try {
728
- attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.slot, this.checkpointNumber);
830
+ attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.targetSlot, this.checkpointNumber);
729
831
  } catch (err) {
730
832
  // We shouldn't really get here since we yield to another HA node
731
- // as soon as we see these errors when creating block proposals.
732
- if (err instanceof DutyAlreadySignedError) {
733
- this.log.info(`Attestations signature for slot ${this.slot} already signed by another HA node, yielding`, {
734
- slot: this.slot,
735
- signedByNode: err.signedByNode
736
- });
737
- return undefined;
738
- }
739
- if (err instanceof SlashingProtectionError) {
740
- this.log.info(`Attestations signature for slot ${this.slot} blocked by slashing protection, yielding`, {
741
- slot: this.slot,
742
- existingMessageHash: err.existingMessageHash,
743
- attemptedMessageHash: err.attemptedMessageHash
744
- });
833
+ // as soon as we see these errors when creating block or checkpoint proposals.
834
+ if (this.handleHASigningError(err, 'Attestations signature')) {
745
835
  return undefined;
746
836
  }
747
837
  throw err;
748
838
  }
749
- // Enqueue publishing the checkpoint to L1
750
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
751
- const aztecSlotDuration = this.l1Constants.slotDuration;
752
- const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
753
- const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
754
- await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
755
- txTimeoutAt,
756
- forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber
757
- });
758
- return checkpoint;
839
+ // Return the result for the caller to enqueue after the pipeline sleep
840
+ return {
841
+ checkpoint,
842
+ attestations,
843
+ attestationsSignature
844
+ };
759
845
  } catch (e) {
760
846
  env.error = e;
761
847
  env.hasError = true;
762
848
  } finally{
763
- _ts_dispose_resources(env);
849
+ const result = _ts_dispose_resources(env);
850
+ if (result) await result;
764
851
  }
765
852
  } catch (err) {
766
853
  if (err && (err instanceof DutyAlreadySignedError || err instanceof SlashingProtectionError)) {
767
854
  // swallow this error. It's already been logged by a function deeper in the stack
768
855
  return undefined;
769
856
  }
770
- this.log.error(`Error building checkpoint at slot ${this.slot}`, err);
857
+ this.log.error(`Error building checkpoint at slot ${this.targetSlot}`, err);
771
858
  return undefined;
772
859
  }
773
860
  }
@@ -777,8 +864,6 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
777
864
  const blocksInCheckpoint = [];
778
865
  const txHashesAlreadyIncluded = new Set();
779
866
  const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
780
- // Remaining blob fields available for blocks (checkpoint end marker already subtracted)
781
- let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
782
867
  // Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
783
868
  let blockPendingBroadcast = undefined;
784
869
  while(true){
@@ -789,7 +874,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
789
874
  const timingInfo = this.timetable.canStartNextBlock(secondsIntoSlot);
790
875
  if (!timingInfo.canStart) {
791
876
  this.log.debug(`Not enough time left in slot to start another block`, {
792
- slot: this.slot,
877
+ slot: this.targetSlot,
793
878
  blocksBuilt,
794
879
  secondsIntoSlot
795
880
  });
@@ -804,8 +889,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
804
889
  buildDeadline: timingInfo.deadline ? new Date((this.getSlotStartBuildTimestamp() + timingInfo.deadline) * 1000) : undefined,
805
890
  blockNumber,
806
891
  indexWithinCheckpoint,
807
- txHashesAlreadyIncluded,
808
- remainingBlobFields
892
+ txHashesAlreadyIncluded
809
893
  });
810
894
  // TODO(palla/mbps): Review these conditions. We may want to keep trying in some scenarios.
811
895
  if (!buildResult && timingInfo.isLastBlock) {
@@ -819,33 +903,23 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
819
903
  } else if ('error' in buildResult) {
820
904
  // If there was an error building the block, just exit the loop and give up the rest of the slot
821
905
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
822
- this.log.warn(`Halting block building for slot ${this.slot}`, {
823
- slot: this.slot,
906
+ this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
907
+ slot: this.targetSlot,
824
908
  blocksBuilt,
825
909
  error: buildResult.error
826
910
  });
827
911
  }
828
912
  break;
829
913
  }
830
- const { block, usedTxs, remainingBlobFields: newRemainingBlobFields } = buildResult;
914
+ const { block, usedTxs } = buildResult;
831
915
  blocksInCheckpoint.push(block);
832
- // Update remaining blob fields for the next block
833
- remainingBlobFields = newRemainingBlobFields;
834
- // Sync the proposed block to the archiver to make it available
835
- // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
836
- // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
837
- // Fire and forget - don't block the critical path, but log errors
838
- this.syncProposedBlockToArchiver(block).catch((err)=>{
839
- this.log.error(`Failed to sync proposed block ${block.number} to archiver`, {
840
- blockNumber: block.number,
841
- err
842
- });
843
- });
844
916
  usedTxs.forEach((tx)=>txHashesAlreadyIncluded.add(tx.txHash.toString()));
845
- // If this is the last block, exit the loop now so we start collecting attestations
917
+ // If this is the last block, sync it to the archiver and exit the loop
918
+ // so we can build the checkpoint and start collecting attestations.
846
919
  if (timingInfo.isLastBlock) {
847
- this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
848
- slot: this.slot,
920
+ await this.syncProposedBlockToArchiver(block);
921
+ this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
922
+ slot: this.targetSlot,
849
923
  blockNumber,
850
924
  blocksBuilt
851
925
  });
@@ -855,17 +929,22 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
855
929
  };
856
930
  break;
857
931
  }
858
- // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
859
- // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
860
- if (!this.config.fishermanMode) {
861
- const proposal = await this.validatorClient.createBlockProposal(block.header, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
862
- await this.p2pClient.broadcastProposal(proposal);
863
- }
932
+ // Broadcast the block proposal (unless we're in fisherman mode) unless the block is the last one,
933
+ // in which case we'll broadcast it along with the checkpoint at the end of the loop.
934
+ // Note that we only send the block to the archiver if we manage to create the proposal, so if there's
935
+ // a HA error we don't pollute our archiver with a block that won't make it to the chain.
936
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, blockProposalOptions);
937
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal.
938
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
939
+ // If this throws, we abort the entire checkpoint.
940
+ await this.syncProposedBlockToArchiver(block);
941
+ // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
942
+ proposal && await this.p2pClient.broadcastProposal(proposal);
864
943
  // Wait until the next block's start time
865
944
  await this.waitUntilNextSubslot(timingInfo.deadline);
866
945
  }
867
- this.log.verbose(`Block building loop completed for slot ${this.slot}`, {
868
- slot: this.slot,
946
+ this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
947
+ slot: this.targetSlot,
869
948
  blocksBuilt: blocksInCheckpoint.length
870
949
  });
871
950
  return {
@@ -873,82 +952,88 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
873
952
  blockPendingBroadcast
874
953
  };
875
954
  }
955
+ /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */ createBlockProposal(block, inHash, usedTxs, blockProposalOptions) {
956
+ if (this.config.fishermanMode) {
957
+ this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
958
+ return Promise.resolve(undefined);
959
+ }
960
+ return this.validatorClient.createBlockProposal(block.header, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
961
+ }
876
962
  /** Sleeps until it is time to produce the next block in the slot */ async waitUntilNextSubslot(nextSubslotStart) {
877
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
963
+ this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.targetSlot);
878
964
  this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
879
- slot: this.slot
965
+ slot: this.targetSlot
880
966
  });
881
967
  await this.waitUntilTimeInSlot(nextSubslotStart);
882
968
  }
883
969
  /** Builds a single block. Called from the main block building loop. */ async buildSingleBlock(checkpointBuilder, opts) {
884
- const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded, remainingBlobFields } = opts;
885
- this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`, {
970
+ const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } = opts;
971
+ this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`, {
886
972
  ...checkpointBuilder.getConstantData(),
887
973
  ...opts
888
974
  });
889
975
  try {
890
976
  // Wait until we have enough txs to build the block
891
- const minTxs = this.config.minTxsPerBlock;
892
- const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
977
+ const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
893
978
  if (!canStartBuilding) {
894
- this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`, {
979
+ this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (got ${availableTxs} txs but needs ${minTxs})`, {
895
980
  blockNumber,
896
- slot: this.slot,
981
+ slot: this.targetSlot,
897
982
  indexWithinCheckpoint
898
983
  });
899
984
  this.eventEmitter.emit('block-tx-count-check-failed', {
900
985
  minTxs,
901
986
  availableTxs,
902
- slot: this.slot
987
+ slot: this.targetSlot
903
988
  });
904
989
  this.metrics.recordBlockProposalFailed('insufficient_txs');
905
990
  return undefined;
906
991
  }
907
992
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
908
993
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
909
- const pendingTxs = filter(this.p2pClient.iteratePendingTxs(), (tx)=>!txHashesAlreadyIncluded.has(tx.txHash.toString()));
910
- this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`, {
911
- slot: this.slot,
994
+ const pendingTxs = filter(this.p2pClient.iterateEligiblePendingTxs(), (tx)=>!txHashesAlreadyIncluded.has(tx.txHash.toString()));
995
+ this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot} with ${availableTxs} available txs`, {
996
+ slot: this.targetSlot,
912
997
  blockNumber,
913
998
  indexWithinCheckpoint
914
999
  });
915
- this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
916
- // Calculate blob fields limit for txs (remaining capacity - this block's end overhead)
917
- const blockEndOverhead = getNumBlockEndBlobFields(indexWithinCheckpoint === 0);
918
- const maxBlobFieldsForTxs = remainingBlobFields - blockEndOverhead;
1000
+ this.setStateFn(SequencerState.CREATING_BLOCK, this.targetSlot);
1001
+ // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
1002
+ // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
1003
+ // minValidTxs is passed into the builder so it can reject the block *before* updating state.
1004
+ const minValidTxs = forceCreate ? 0 : this.config.minValidTxsPerBlock ?? minTxs;
919
1005
  const blockBuilderOptions = {
920
1006
  maxTransactions: this.config.maxTxsPerBlock,
921
- maxBlockSize: this.config.maxBlockSizeInBytes,
922
- maxBlockGas: new Gas(this.config.maxDABlockGas, this.config.maxL2BlockGas),
923
- maxBlobFields: maxBlobFieldsForTxs,
924
- deadline: buildDeadline
1007
+ maxBlockGas: this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity) : undefined,
1008
+ deadline: buildDeadline,
1009
+ isBuildingProposal: true,
1010
+ minValidTxs,
1011
+ maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
1012
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier
925
1013
  };
926
- // Actually build the block by executing txs
1014
+ // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
1015
+ // if the number of successfully processed txs is below minValidTxs, ensuring state is not
1016
+ // updated for blocks that will be discarded.
927
1017
  const buildResult = await this.buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
928
1018
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
929
1019
  await this.dropFailedTxsFromP2P(buildResult.failedTxs);
930
- // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
931
- // too long, then we may not get to minTxsPerBlock after executing public functions.
932
- const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
933
- const numTxs = buildResult.status === 'no-valid-txs' ? 0 : buildResult.numTxs;
934
- if (buildResult.status === 'no-valid-txs' || !forceCreate && numTxs < minValidTxs) {
935
- this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed`, {
936
- slot: this.slot,
1020
+ if (buildResult.status === 'insufficient-valid-txs') {
1021
+ this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`, {
1022
+ slot: this.targetSlot,
937
1023
  blockNumber,
938
- numTxs,
1024
+ numTxs: buildResult.processedCount,
939
1025
  indexWithinCheckpoint,
940
- minValidTxs,
941
- buildResult: buildResult.status
1026
+ minValidTxs
942
1027
  });
943
1028
  this.eventEmitter.emit('block-build-failed', {
944
1029
  reason: `Insufficient valid txs`,
945
- slot: this.slot
1030
+ slot: this.targetSlot
946
1031
  });
947
1032
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
948
1033
  return undefined;
949
1034
  }
950
1035
  // Block creation succeeded, emit stats and metrics
951
- const { publicGas, block, publicProcessorDuration, usedTxs, usedTxBlobFields, blockBuildDuration } = buildResult;
1036
+ const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
952
1037
  const blockStats = {
953
1038
  eventName: 'l2-block-built',
954
1039
  duration: blockBuildDuration,
@@ -957,31 +1042,33 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
957
1042
  };
958
1043
  const blockHash = await block.hash();
959
1044
  const txHashes = block.body.txEffects.map((tx)=>tx.txHash);
960
- const manaPerSec = publicGas.l2Gas / (blockBuildDuration / 1000);
961
- this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`, {
1045
+ const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
1046
+ this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`, {
962
1047
  blockHash,
963
1048
  txHashes,
964
1049
  manaPerSec,
965
1050
  ...blockStats
966
1051
  });
1052
+ // `slot` is the target/submission slot (may be one ahead when pipelining),
1053
+ // `buildSlot` is the wall-clock slot during which the block was actually built.
967
1054
  this.eventEmitter.emit('block-proposed', {
968
1055
  blockNumber: block.number,
969
- slot: this.slot
1056
+ slot: this.targetSlot,
1057
+ buildSlot: this.slotNow
970
1058
  });
971
- this.metrics.recordBuiltBlock(blockBuildDuration, publicGas.l2Gas);
1059
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe());
972
1060
  return {
973
1061
  block,
974
- usedTxs,
975
- remainingBlobFields: maxBlobFieldsForTxs - usedTxBlobFields
1062
+ usedTxs
976
1063
  };
977
1064
  } catch (err) {
978
1065
  this.eventEmitter.emit('block-build-failed', {
979
1066
  reason: err.message,
980
- slot: this.slot
1067
+ slot: this.targetSlot
981
1068
  });
982
1069
  this.log.error(`Error building block`, err, {
983
1070
  blockNumber,
984
- slot: this.slot
1071
+ slot: this.targetSlot
985
1072
  });
986
1073
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
987
1074
  this.metrics.recordFailedBlock();
@@ -990,7 +1077,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
990
1077
  };
991
1078
  }
992
1079
  }
993
- /** Uses the checkpoint builder to build a block, catching specific txs */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
1080
+ /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
994
1081
  try {
995
1082
  const workTimer = new Timer();
996
1083
  const result = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
@@ -1001,10 +1088,11 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1001
1088
  status: 'success'
1002
1089
  };
1003
1090
  } catch (err) {
1004
- if (isErrorClass(err, NoValidTxsError)) {
1091
+ if (isErrorClass(err, InsufficientValidTxsError)) {
1005
1092
  return {
1006
1093
  failedTxs: err.failedTxs,
1007
- status: 'no-valid-txs'
1094
+ processedCount: err.processedCount,
1095
+ status: 'insufficient-valid-txs'
1008
1096
  };
1009
1097
  }
1010
1098
  throw err;
@@ -1023,22 +1111,24 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1023
1111
  if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
1024
1112
  return {
1025
1113
  canStartBuilding: false,
1026
- availableTxs: availableTxs
1114
+ availableTxs,
1115
+ minTxs
1027
1116
  };
1028
1117
  }
1029
1118
  // Wait a bit before checking again
1030
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.slot);
1031
- this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (have ${availableTxs} but need ${minTxs})`, {
1119
+ this.setStateFn(SequencerState.WAITING_FOR_TXS, this.targetSlot);
1120
+ this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (have ${availableTxs} but need ${minTxs})`, {
1032
1121
  blockNumber,
1033
- slot: this.slot,
1122
+ slot: this.targetSlot,
1034
1123
  indexWithinCheckpoint
1035
1124
  });
1036
- await sleep(TXS_POLLING_MS);
1125
+ await this.waitForTxsPollingInterval();
1037
1126
  availableTxs = await this.p2pClient.getPendingTxCount();
1038
1127
  }
1039
1128
  return {
1040
1129
  canStartBuilding: true,
1041
- availableTxs
1130
+ availableTxs,
1131
+ minTxs
1042
1132
  };
1043
1133
  }
1044
1134
  /**
@@ -1061,7 +1151,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1061
1151
  committee
1062
1152
  });
1063
1153
  }
1064
- const numberOfRequiredAttestations = Math.floor(committee.length * 2 / 3) + 1;
1154
+ const numberOfRequiredAttestations = computeQuorum(committee.length);
1065
1155
  if (this.config.skipCollectingAttestations) {
1066
1156
  this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
1067
1157
  const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
@@ -1075,10 +1165,16 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1075
1165
  try {
1076
1166
  const attestations = await this.validatorClient.collectAttestations(proposal, numberOfRequiredAttestations, attestationDeadline);
1077
1167
  collectedAttestationsCount = attestations.length;
1168
+ // Trim attestations to minimum required to save L1 calldata gas
1169
+ const localAddresses = this.validatorClient.getValidatorAddresses();
1170
+ const trimmed = trimAttestations(attestations, numberOfRequiredAttestations, this.attestorAddress, localAddresses);
1171
+ if (trimmed.length < attestations.length) {
1172
+ this.log.debug(`Trimmed attestations from ${attestations.length} to ${trimmed.length} for L1 submission`);
1173
+ }
1078
1174
  // Rollup contract requires that the signatures are provided in the order of the committee
1079
- const sorted = orderAttestations(attestations, committee);
1175
+ const sorted = orderAttestations(trimmed, committee);
1080
1176
  // Manipulate the attestations if we've been configured to do so
1081
- if (this.config.injectFakeAttestation || this.config.shuffleAttestationOrdering) {
1177
+ if (this.config.injectFakeAttestation || this.config.injectHighSValueAttestation || this.config.injectUnrecoverableSignatureAttestation || this.config.shuffleAttestationOrdering) {
1082
1178
  return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
1083
1179
  }
1084
1180
  return new CommitteeAttestationsAndSigners(sorted);
@@ -1095,7 +1191,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1095
1191
  // Compute the proposer index in the committee, since we dont want to tweak it.
1096
1192
  // Otherwise, the L1 rollup contract will reject the block outright.
1097
1193
  const proposerIndex = Number(this.epochCache.computeProposerIndex(slotNumber, epoch, seed, BigInt(committee.length)));
1098
- if (this.config.injectFakeAttestation) {
1194
+ if (this.config.injectFakeAttestation || this.config.injectHighSValueAttestation || this.config.injectUnrecoverableSignatureAttestation) {
1099
1195
  // Find non-empty attestations that are not from the proposer
1100
1196
  const nonProposerIndices = [];
1101
1197
  for(let i = 0; i < attestations.length; i++){
@@ -1105,8 +1201,16 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1105
1201
  }
1106
1202
  if (nonProposerIndices.length > 0) {
1107
1203
  const targetIndex = nonProposerIndices[randomInt(nonProposerIndices.length)];
1108
- this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1109
- unfreeze(attestations[targetIndex]).signature = Signature.random();
1204
+ if (this.config.injectHighSValueAttestation) {
1205
+ this.log.warn(`Injecting high-s value attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1206
+ unfreeze(attestations[targetIndex]).signature = flipSignature(attestations[targetIndex].signature);
1207
+ } else if (this.config.injectUnrecoverableSignatureAttestation) {
1208
+ this.log.warn(`Injecting unrecoverable signature attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1209
+ unfreeze(attestations[targetIndex]).signature = generateUnrecoverableSignature();
1210
+ } else {
1211
+ this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1212
+ unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
1213
+ }
1110
1214
  }
1111
1215
  return new CommitteeAttestationsAndSigners(attestations);
1112
1216
  }
@@ -1115,14 +1219,25 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1115
1219
  const shuffled = [
1116
1220
  ...attestations
1117
1221
  ];
1118
- const [i, j] = [
1119
- (proposerIndex + 1) % shuffled.length,
1120
- (proposerIndex + 2) % shuffled.length
1121
- ];
1122
- const valueI = shuffled[i];
1123
- const valueJ = shuffled[j];
1124
- shuffled[i] = valueJ;
1125
- shuffled[j] = valueI;
1222
+ // Find two non-proposer positions that both have non-empty signatures to swap.
1223
+ // This ensures the bitmap doesn't change, so the MaliciousCommitteeAttestationsAndSigners
1224
+ // signers array stays correctly aligned with L1's committee reconstruction.
1225
+ const swappable = [];
1226
+ for(let k = 0; k < shuffled.length; k++){
1227
+ if (!shuffled[k].signature.isEmpty() && k !== proposerIndex) {
1228
+ swappable.push(k);
1229
+ }
1230
+ }
1231
+ if (swappable.length >= 2) {
1232
+ const [i, j] = [
1233
+ swappable[0],
1234
+ swappable[1]
1235
+ ];
1236
+ [shuffled[i], shuffled[j]] = [
1237
+ shuffled[j],
1238
+ shuffled[i]
1239
+ ];
1240
+ }
1126
1241
  const signers = new CommitteeAttestationsAndSigners(attestations).getSigners();
1127
1242
  return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers);
1128
1243
  }
@@ -1135,14 +1250,14 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1135
1250
  const failedTxData = failedTxs.map((fail)=>fail.tx);
1136
1251
  const failedTxHashes = failedTxData.map((tx)=>tx.getTxHash());
1137
1252
  this.log.verbose(`Dropping failed txs ${failedTxHashes.join(', ')}`);
1138
- await this.p2pClient.deleteTxs(failedTxHashes);
1253
+ await this.p2pClient.handleFailedExecution(failedTxHashes);
1139
1254
  }
1140
1255
  /**
1141
1256
  * Adds the proposed block to the archiver so it's available via P2P.
1142
1257
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
1143
1258
  * would never receive its own block without this explicit sync.
1144
1259
  */ async syncProposedBlockToArchiver(block) {
1145
- if (this.config.skipPushProposedBlocksToArchiver !== false) {
1260
+ if (this.config.skipPushProposedBlocksToArchiver) {
1146
1261
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
1147
1262
  blockNumber: block.number,
1148
1263
  slot: block.header.globalVariables.slotNumber
@@ -1158,29 +1273,86 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1158
1273
  /** Runs fee analysis and logs checkpoint outcome as fisherman */ async handleCheckpointEndAsFisherman(checkpoint) {
1159
1274
  // Perform L1 fee analysis before clearing requests
1160
1275
  // The callback is invoked asynchronously after the next block is mined
1161
- const feeAnalysis = await this.publisher.analyzeL1Fees(this.slot, (analysis)=>this.metrics.recordFishermanFeeAnalysis(analysis));
1276
+ const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, (analysis)=>this.metrics.recordFishermanFeeAnalysis(analysis));
1162
1277
  if (checkpoint) {
1163
- this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.slot}`, {
1278
+ this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
1164
1279
  ...checkpoint.toCheckpointInfo(),
1165
1280
  ...checkpoint.getStats(),
1166
1281
  feeAnalysisId: feeAnalysis?.id
1167
1282
  });
1168
1283
  } else {
1169
- this.log.warn(`Validation block building FAILED for slot ${this.slot}`, {
1170
- slot: this.slot,
1284
+ this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
1285
+ slot: this.targetSlot,
1171
1286
  feeAnalysisId: feeAnalysis?.id
1172
1287
  });
1173
- this.metrics.recordBlockProposalFailed('block_build_failed');
1288
+ this.metrics.recordCheckpointProposalFailed('block_build_failed');
1174
1289
  }
1175
1290
  this.publisher.clearPendingRequests();
1176
1291
  }
1292
+ /**
1293
+ * Helper to handle HA double-signing errors. Returns true if the error was handled (caller should yield).
1294
+ */ handleHASigningError(err, errorContext) {
1295
+ if (err instanceof DutyAlreadySignedError) {
1296
+ this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
1297
+ slot: this.targetSlot,
1298
+ signedByNode: err.signedByNode
1299
+ });
1300
+ return true;
1301
+ }
1302
+ if (err instanceof SlashingProtectionError) {
1303
+ this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
1304
+ slot: this.targetSlot,
1305
+ existingMessageHash: err.existingMessageHash,
1306
+ attemptedMessageHash: err.attemptedMessageHash
1307
+ });
1308
+ return true;
1309
+ }
1310
+ return false;
1311
+ }
1312
+ /**
1313
+ * In times of congestion we need to simulate using the correct fee header override for the previous block
1314
+ * We calculate the correct fee header values.
1315
+ *
1316
+ * If we are in block 1, or the checkpoint we are querying does not exist, we return undefined. However
1317
+ * If we are pipelining - where this function is called, the grandparentCheckpointNumber should always exist
1318
+ * @param parentCheckpointNumber
1319
+ * @returns
1320
+ */ async computeForceProposedFeeHeader(parentCheckpointNumber) {
1321
+ if (!this.proposedCheckpointData) {
1322
+ return undefined;
1323
+ }
1324
+ const rollup = this.publisher.rollupContract;
1325
+ const grandparentCheckpointNumber = CheckpointNumber(this.checkpointNumber - 2);
1326
+ try {
1327
+ const [grandparentCheckpoint, manaTarget] = await Promise.all([
1328
+ rollup.getCheckpoint(grandparentCheckpointNumber),
1329
+ rollup.getManaTarget()
1330
+ ]);
1331
+ if (!grandparentCheckpoint || !grandparentCheckpoint.feeHeader) {
1332
+ this.log.error(`Grandparent checkpoint or its feeHeader is undefined for checkpointNumber=${grandparentCheckpointNumber.toString()}`);
1333
+ return undefined;
1334
+ } else {
1335
+ const parentFeeHeader = RollupContract.computeChildFeeHeader(grandparentCheckpoint.feeHeader, this.proposedCheckpointData.totalManaUsed, this.proposedCheckpointData.feeAssetPriceModifier, manaTarget);
1336
+ return {
1337
+ checkpointNumber: parentCheckpointNumber,
1338
+ feeHeader: parentFeeHeader
1339
+ };
1340
+ }
1341
+ } catch (err) {
1342
+ this.log.error(`Failed to fetch grandparent checkpoint or mana target for checkpointNumber=${grandparentCheckpointNumber.toString()}: ${err}`);
1343
+ return undefined;
1344
+ }
1345
+ }
1177
1346
  /** Waits until a specific time within the current slot */ async waitUntilTimeInSlot(targetSecondsIntoSlot) {
1178
1347
  const slotStartTimestamp = this.getSlotStartBuildTimestamp();
1179
1348
  const targetTimestamp = slotStartTimestamp + targetSecondsIntoSlot;
1180
1349
  await sleepUntil(new Date(targetTimestamp * 1000), this.dateProvider.nowAsDate());
1181
1350
  }
1351
+ /** Waits the polling interval for transactions. Extracted for test overriding. */ async waitForTxsPollingInterval() {
1352
+ await sleep(TXS_POLLING_MS);
1353
+ }
1182
1354
  getSlotStartBuildTimestamp() {
1183
- return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
1355
+ return getSlotStartBuildTimestamp(this.slotNow, this.l1Constants);
1184
1356
  }
1185
1357
  getSecondsIntoSlot() {
1186
1358
  const slotStartTimestamp = this.getSlotStartBuildTimestamp();