@aztec/sequencer-client 0.0.1-commit.e3c1de76 → 0.0.1-commit.e57c76e

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (125) hide show
  1. package/README.md +281 -21
  2. package/dest/client/sequencer-client.d.ts +19 -9
  3. package/dest/client/sequencer-client.d.ts.map +1 -1
  4. package/dest/client/sequencer-client.js +65 -32
  5. package/dest/config.d.ts +28 -6
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +76 -37
  8. package/dest/global_variable_builder/fee_predictor.d.ts +37 -0
  9. package/dest/global_variable_builder/fee_predictor.d.ts.map +1 -0
  10. package/dest/global_variable_builder/fee_predictor.js +128 -0
  11. package/dest/global_variable_builder/fee_provider.d.ts +21 -0
  12. package/dest/global_variable_builder/fee_provider.d.ts.map +1 -0
  13. package/dest/global_variable_builder/fee_provider.js +58 -0
  14. package/dest/global_variable_builder/global_builder.d.ts +14 -16
  15. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  16. package/dest/global_variable_builder/global_builder.js +16 -50
  17. package/dest/global_variable_builder/index.d.ts +4 -2
  18. package/dest/global_variable_builder/index.d.ts.map +1 -1
  19. package/dest/global_variable_builder/index.js +2 -0
  20. package/dest/index.d.ts +2 -2
  21. package/dest/index.d.ts.map +1 -1
  22. package/dest/index.js +1 -1
  23. package/dest/publisher/config.d.ts +47 -17
  24. package/dest/publisher/config.d.ts.map +1 -1
  25. package/dest/publisher/config.js +121 -42
  26. package/dest/publisher/index.d.ts +2 -1
  27. package/dest/publisher/index.d.ts.map +1 -1
  28. package/dest/publisher/l1_tx_failed_store/factory.d.ts +11 -0
  29. package/dest/publisher/l1_tx_failed_store/factory.d.ts.map +1 -0
  30. package/dest/publisher/l1_tx_failed_store/factory.js +22 -0
  31. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +58 -0
  32. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -0
  33. package/dest/publisher/l1_tx_failed_store/failed_tx_store.js +1 -0
  34. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts +15 -0
  35. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts.map +1 -0
  36. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.js +34 -0
  37. package/dest/publisher/l1_tx_failed_store/index.d.ts +4 -0
  38. package/dest/publisher/l1_tx_failed_store/index.d.ts.map +1 -0
  39. package/dest/publisher/l1_tx_failed_store/index.js +2 -0
  40. package/dest/publisher/sequencer-bundle-simulator.d.ts +96 -0
  41. package/dest/publisher/sequencer-bundle-simulator.d.ts.map +1 -0
  42. package/dest/publisher/sequencer-bundle-simulator.js +198 -0
  43. package/dest/publisher/sequencer-publisher-factory.d.ts +11 -5
  44. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  45. package/dest/publisher/sequencer-publisher-factory.js +27 -3
  46. package/dest/publisher/sequencer-publisher.d.ts +94 -67
  47. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  48. package/dest/publisher/sequencer-publisher.js +439 -378
  49. package/dest/sequencer/automine/automine_factory.d.ts +54 -0
  50. package/dest/sequencer/automine/automine_factory.d.ts.map +1 -0
  51. package/dest/sequencer/automine/automine_factory.js +84 -0
  52. package/dest/sequencer/automine/automine_sequencer.d.ts +151 -0
  53. package/dest/sequencer/automine/automine_sequencer.d.ts.map +1 -0
  54. package/dest/sequencer/automine/automine_sequencer.js +509 -0
  55. package/dest/sequencer/chain_state_overrides.d.ts +61 -0
  56. package/dest/sequencer/chain_state_overrides.d.ts.map +1 -0
  57. package/dest/sequencer/chain_state_overrides.js +98 -0
  58. package/dest/sequencer/checkpoint_proposal_job.d.ts +65 -11
  59. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  60. package/dest/sequencer/checkpoint_proposal_job.js +849 -249
  61. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts +34 -0
  62. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts.map +1 -0
  63. package/dest/sequencer/checkpoint_proposal_job_metrics.js +72 -0
  64. package/dest/sequencer/checkpoint_voter.d.ts +1 -2
  65. package/dest/sequencer/checkpoint_voter.d.ts.map +1 -1
  66. package/dest/sequencer/checkpoint_voter.js +2 -5
  67. package/dest/sequencer/events.d.ts +48 -2
  68. package/dest/sequencer/events.d.ts.map +1 -1
  69. package/dest/sequencer/index.d.ts +3 -1
  70. package/dest/sequencer/index.d.ts.map +1 -1
  71. package/dest/sequencer/index.js +2 -0
  72. package/dest/sequencer/metrics.d.ts +23 -8
  73. package/dest/sequencer/metrics.d.ts.map +1 -1
  74. package/dest/sequencer/metrics.js +117 -21
  75. package/dest/sequencer/sequencer.d.ts +85 -22
  76. package/dest/sequencer/sequencer.d.ts.map +1 -1
  77. package/dest/sequencer/sequencer.js +380 -137
  78. package/dest/sequencer/timetable.d.ts +14 -6
  79. package/dest/sequencer/timetable.d.ts.map +1 -1
  80. package/dest/sequencer/timetable.js +47 -46
  81. package/dest/sequencer/types.d.ts +2 -2
  82. package/dest/sequencer/types.d.ts.map +1 -1
  83. package/dest/test/index.d.ts +3 -5
  84. package/dest/test/index.d.ts.map +1 -1
  85. package/dest/test/mock_checkpoint_builder.d.ts +11 -11
  86. package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
  87. package/dest/test/mock_checkpoint_builder.js +45 -34
  88. package/dest/test/utils.d.ts +3 -3
  89. package/dest/test/utils.d.ts.map +1 -1
  90. package/dest/test/utils.js +10 -8
  91. package/package.json +27 -28
  92. package/src/client/sequencer-client.ts +91 -35
  93. package/src/config.ts +98 -46
  94. package/src/global_variable_builder/README.md +44 -0
  95. package/src/global_variable_builder/fee_predictor.ts +172 -0
  96. package/src/global_variable_builder/fee_provider.ts +75 -0
  97. package/src/global_variable_builder/global_builder.ts +26 -63
  98. package/src/global_variable_builder/index.ts +3 -1
  99. package/src/index.ts +10 -1
  100. package/src/publisher/config.ts +157 -45
  101. package/src/publisher/index.ts +3 -0
  102. package/src/publisher/l1_tx_failed_store/factory.ts +32 -0
  103. package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +57 -0
  104. package/src/publisher/l1_tx_failed_store/file_store_failed_tx_store.ts +46 -0
  105. package/src/publisher/l1_tx_failed_store/index.ts +3 -0
  106. package/src/publisher/sequencer-bundle-simulator.ts +254 -0
  107. package/src/publisher/sequencer-publisher-factory.ts +38 -9
  108. package/src/publisher/sequencer-publisher.ts +532 -469
  109. package/src/sequencer/README.md +162 -450
  110. package/src/sequencer/automine/README.md +46 -0
  111. package/src/sequencer/automine/automine_factory.ts +145 -0
  112. package/src/sequencer/automine/automine_sequencer.ts +595 -0
  113. package/src/sequencer/chain_state_overrides.ts +162 -0
  114. package/src/sequencer/checkpoint_proposal_job.ts +1026 -268
  115. package/src/sequencer/checkpoint_proposal_job_metrics.ts +128 -0
  116. package/src/sequencer/checkpoint_voter.ts +1 -12
  117. package/src/sequencer/events.ts +51 -2
  118. package/src/sequencer/index.ts +2 -0
  119. package/src/sequencer/metrics.ts +132 -25
  120. package/src/sequencer/sequencer.ts +470 -156
  121. package/src/sequencer/timetable.ts +62 -56
  122. package/src/sequencer/types.ts +1 -1
  123. package/src/test/index.ts +2 -4
  124. package/src/test/mock_checkpoint_builder.ts +63 -49
  125. package/src/test/utils.ts +31 -10
@@ -1,6 +1,5 @@
1
- import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
2
- import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
3
1
  import type { EpochCache } from '@aztec/epoch-cache';
2
+ import type { SimulationOverridesPlan } from '@aztec/ethereum/contracts';
4
3
  import {
5
4
  BlockNumber,
6
5
  CheckpointNumber,
@@ -9,12 +8,18 @@ import {
9
8
  SlotNumber,
10
9
  } from '@aztec/foundation/branded-types';
11
10
  import { randomInt } from '@aztec/foundation/crypto/random';
11
+ import {
12
+ flipSignature,
13
+ generateRecoverableSignature,
14
+ generateUnrecoverableSignature,
15
+ } from '@aztec/foundation/crypto/secp256k1-signer';
12
16
  import { Fr } from '@aztec/foundation/curves/bn254';
17
+ import { InterruptError, TimeoutError } from '@aztec/foundation/error';
13
18
  import { EthAddress } from '@aztec/foundation/eth-address';
14
19
  import { Signature } from '@aztec/foundation/eth-signature';
15
20
  import { filter } from '@aztec/foundation/iterator';
16
21
  import { type Logger, type LoggerBindings, createLogger } from '@aztec/foundation/log';
17
- import { sleep, sleepUntil } from '@aztec/foundation/sleep';
22
+ import { InterruptibleSleep } from '@aztec/foundation/sleep';
18
23
  import { type DateProvider, Timer } from '@aztec/foundation/timer';
19
24
  import { type TypedEventEmitter, isErrorClass, unfreeze } from '@aztec/foundation/types';
20
25
  import type { P2P } from '@aztec/p2p';
@@ -26,19 +31,33 @@ import {
26
31
  type L2BlockSink,
27
32
  type L2BlockSource,
28
33
  MaliciousCommitteeAttestationsAndSigners,
34
+ type ProposedCheckpointSink,
35
+ type ValidateCheckpointResult,
29
36
  } from '@aztec/stdlib/block';
30
- import type { Checkpoint } from '@aztec/stdlib/checkpoint';
31
- import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
37
+ import {
38
+ type Checkpoint,
39
+ type ProposedCheckpointData,
40
+ getPreviousCheckpointOutHashes,
41
+ validateCheckpoint,
42
+ } from '@aztec/stdlib/checkpoint';
43
+ import { computeQuorum, getSlotStartBuildTimestamp, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
32
44
  import { Gas } from '@aztec/stdlib/gas';
33
45
  import {
34
- NoValidTxsError,
35
- type PublicProcessorLimits,
46
+ type BlockBuilderOptions,
47
+ InsufficientValidTxsError,
36
48
  type ResolvedSequencerConfig,
37
49
  type WorldStateSynchronizer,
38
50
  } from '@aztec/stdlib/interfaces/server';
39
51
  import { type L1ToL2MessageSource, computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
40
- import type { BlockProposalOptions, CheckpointProposal, CheckpointProposalOptions } from '@aztec/stdlib/p2p';
41
- import { orderAttestations } from '@aztec/stdlib/p2p';
52
+ import type {
53
+ BlockProposal,
54
+ BlockProposalOptions,
55
+ CheckpointAttestation,
56
+ CheckpointProposal,
57
+ CheckpointProposalOptions,
58
+ CoordinationSignatureContext,
59
+ } from '@aztec/stdlib/p2p';
60
+ import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
42
61
  import type { L2BlockBuiltStats } from '@aztec/stdlib/stats';
43
62
  import { type FailedTx, Tx } from '@aztec/stdlib/tx';
44
63
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
@@ -48,6 +67,8 @@ import { DutyAlreadySignedError, SlashingProtectionError } from '@aztec/validato
48
67
 
49
68
  import type { GlobalVariableBuilder } from '../global_variable_builder/global_builder.js';
50
69
  import type { InvalidateCheckpointRequest, SequencerPublisher } from '../publisher/sequencer-publisher.js';
70
+ import { buildCheckpointSimulationOverridesPlan } from './chain_state_overrides.js';
71
+ import type { CheckpointProposalJobMetricsRecorder } from './checkpoint_proposal_job_metrics.js';
51
72
  import { CheckpointVoter } from './checkpoint_voter.js';
52
73
  import { SequencerInterruptedError } from './errors.js';
53
74
  import type { SequencerEvents } from './events.js';
@@ -58,6 +79,21 @@ import { SequencerState } from './utils.js';
58
79
 
59
80
  /** How much time to sleep while waiting for min transactions to accumulate for a block */
60
81
  const TXS_POLLING_MS = 500;
82
+ const ARCHIVER_SYNC_POLLING_MS = 200;
83
+
84
+ /** Result from proposeCheckpoint when a checkpoint was successfully built and broadcast. */
85
+ type CheckpointProposalBroadcast = {
86
+ checkpoint: Checkpoint;
87
+ proposal: CheckpointProposal;
88
+ blockProposedAt: number;
89
+ };
90
+
91
+ /** Result after attestation collection and signing, ready for L1 submission. */
92
+ type CheckpointProposalResult = {
93
+ checkpoint: Checkpoint;
94
+ attestations: CommitteeAttestationsAndSigners;
95
+ attestationsSignature: Signature;
96
+ };
61
97
 
62
98
  /**
63
99
  * Handles the execution of a checkpoint proposal after the initial preparation phase.
@@ -67,12 +103,32 @@ const TXS_POLLING_MS = 500;
67
103
  */
68
104
  export class CheckpointProposalJob implements Traceable {
69
105
  protected readonly log: Logger;
106
+ private readonly checkpointEventLog: Logger;
107
+
108
+ /** Tracks the fire-and-forget L1 submission promise so it can be awaited during shutdown. */
109
+ private pendingL1Submission: Promise<void> | undefined;
110
+ private readonly interruptibleSleep = new InterruptibleSleep();
111
+ private interrupted = false;
112
+
113
+ /**
114
+ * Chain state overrides built once per slot in proposeCheckpoint after the checkpoint is
115
+ * complete. Carries the pending parent override (archive + slot + fee header) for pipelining,
116
+ * or the invalidation pending override when rolling back. Consumed by
117
+ * publisher.validateBlockHeader before broadcast.
118
+ */
119
+ private checkpointSimulationOverridesPlan?: SimulationOverridesPlan;
120
+
121
+ private getSignatureContext(): CoordinationSignatureContext {
122
+ return this.signatureContext;
123
+ }
70
124
 
71
125
  constructor(
72
- private readonly epoch: EpochNumber,
73
- private readonly slot: SlotNumber,
126
+ private readonly slotNow: SlotNumber,
127
+ private readonly targetSlot: SlotNumber,
128
+ private readonly targetEpoch: EpochNumber,
74
129
  private readonly checkpointNumber: CheckpointNumber,
75
130
  private readonly syncedToBlockNumber: BlockNumber,
131
+ private readonly checkpointedCheckpointNumber: CheckpointNumber,
76
132
  // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
77
133
  private readonly proposer: EthAddress | undefined,
78
134
  private readonly publisher: SequencerPublisher,
@@ -85,25 +141,74 @@ export class CheckpointProposalJob implements Traceable {
85
141
  private readonly l1ToL2MessageSource: L1ToL2MessageSource,
86
142
  private readonly l2BlockSource: L2BlockSource,
87
143
  private readonly checkpointsBuilder: FullNodeCheckpointsBuilder,
88
- private readonly blockSink: L2BlockSink,
144
+ private readonly blockSink: L2BlockSink & ProposedCheckpointSink,
89
145
  private readonly l1Constants: SequencerRollupConstants,
146
+ private readonly signatureContext: CoordinationSignatureContext,
90
147
  protected config: ResolvedSequencerConfig,
91
148
  protected timetable: SequencerTimetable,
92
149
  private readonly slasherClient: SlasherClientInterface | undefined,
93
150
  private readonly epochCache: EpochCache,
94
151
  private readonly dateProvider: DateProvider,
95
152
  private readonly metrics: SequencerMetrics,
96
- private readonly eventEmitter: TypedEventEmitter<SequencerEvents>,
97
- private readonly setStateFn: (state: SequencerState, slot?: SlotNumber) => void,
153
+ private readonly checkpointMetrics: CheckpointProposalJobMetricsRecorder,
154
+ protected readonly eventEmitter: TypedEventEmitter<SequencerEvents>,
155
+ private readonly setStateFn: (state: SequencerState, slot?: SlotNumber, timeReferenceSlot?: SlotNumber) => void,
98
156
  public readonly tracer: Tracer,
99
157
  bindings?: LoggerBindings,
158
+ private readonly proposedCheckpointData?: ProposedCheckpointData,
100
159
  ) {
101
- this.log = createLogger('sequencer:checkpoint-proposal', { ...bindings, instanceId: `slot-${slot}` });
160
+ this.log = createLogger('sequencer:checkpoint-proposal', {
161
+ ...bindings,
162
+ instanceId: `slot-${this.slotNow}`,
163
+ });
164
+ this.checkpointEventLog = createLogger('sequencer:checkpoint-events', {
165
+ ...bindings,
166
+ instanceId: `slot-${this.slotNow}`,
167
+ });
168
+ }
169
+
170
+ /** Awaits the pending L1 submission if one is in progress. Call during shutdown. */
171
+ public async awaitPendingSubmission(): Promise<void> {
172
+ this.log.info('Awaiting pending L1 payload submission');
173
+ await this.pendingL1Submission;
174
+ }
175
+
176
+ /** Interrupts job-owned waits so shutdown can finish. */
177
+ public interrupt(): void {
178
+ this.interrupted = true;
179
+ this.interruptibleSleep.interrupt(true);
180
+ }
181
+
182
+ private async awaitInterruptibleSleep(ms: number): Promise<void> {
183
+ if (this.interrupted) {
184
+ throw new SequencerInterruptedError();
185
+ }
186
+ if (ms <= 0) {
187
+ return;
188
+ }
189
+ try {
190
+ await this.interruptibleSleep.sleep(ms);
191
+ } catch (err) {
192
+ if (err instanceof InterruptError) {
193
+ throw new SequencerInterruptedError();
194
+ }
195
+ throw err;
196
+ }
197
+ }
198
+
199
+ private logCheckpointEvent(eventName: string, message: string, fields: Record<string, unknown>): void {
200
+ this.checkpointEventLog.debug(message, {
201
+ eventName: `sequencer-checkpoint-${eventName}`,
202
+ ...fields,
203
+ });
102
204
  }
103
205
 
104
206
  /**
105
207
  * Executes the checkpoint proposal job.
106
- * Returns the published checkpoint if successful, undefined otherwise.
208
+ * Builds blocks, assembles checkpoint, and broadcasts the proposal (blocking).
209
+ * Attestation collection, signing, and L1 submission are backgrounded so the
210
+ * work loop can return to IDLE immediately for consecutive slot proposals.
211
+ * Returns the built checkpoint if successful, undefined otherwise.
107
212
  */
108
213
  @trackSpan('CheckpointProposalJob.execute')
109
214
  public async execute(): Promise<Checkpoint | undefined> {
@@ -111,7 +216,7 @@ export class CheckpointProposalJob implements Traceable {
111
216
  // In fisherman mode, we simulate slashing but don't actually publish to L1
112
217
  // These are constant for the whole slot, so we only enqueue them once
113
218
  const votesPromises = new CheckpointVoter(
114
- this.slot,
219
+ this.targetSlot,
115
220
  this.publisher,
116
221
  this.attestorAddress,
117
222
  this.validatorClient,
@@ -122,33 +227,302 @@ export class CheckpointProposalJob implements Traceable {
122
227
  this.log,
123
228
  ).enqueueVotes();
124
229
 
125
- // Build and propose the checkpoint. This will enqueue the request on the publisher if a checkpoint is built.
126
- const checkpoint = await this.proposeCheckpoint();
127
-
128
- // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
129
- await Promise.all(votesPromises);
130
-
131
- if (checkpoint) {
132
- this.metrics.recordBlockProposalSuccess();
230
+ // Build blocks, assemble checkpoint, and broadcast proposal (BLOCKING).
231
+ // Returns after broadcast — attestation collection is deferred.
232
+ const broadcast = await this.proposeCheckpoint();
233
+
234
+ if (!broadcast) {
235
+ await Promise.all(votesPromises);
236
+ // Still submit votes even without a checkpoint.
237
+ // Under proposer pipelining, vote-offenses signatures are EIP-712-bound to `targetSlot`
238
+ // (the pipelined slot in which the multicall is expected to mine). Submitting at the
239
+ // wall-clock time would let the multicall mine in a different L2 slot, causing
240
+ // signature verification to fail silently inside Multicall3. Delay submission to the
241
+ // start of `targetSlot` so the tx mines in the slot the vote was signed for.
242
+ if (!this.config.fishermanMode) {
243
+ this.pendingL1Submission = this.publisher.sendRequestsAt(this.targetSlot).then(() => {});
244
+ }
245
+ return undefined;
133
246
  }
134
247
 
248
+ const { checkpoint } = broadcast;
249
+ this.metrics.recordCheckpointProposalSuccess();
250
+
135
251
  // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
136
252
  if (this.config.fishermanMode) {
137
253
  await this.handleCheckpointEndAsFisherman(checkpoint);
138
- return;
254
+ return checkpoint;
139
255
  }
140
256
 
141
- // Then send everything to L1
142
- const l1Response = await this.publisher.sendRequests();
143
- const proposedAction = l1Response?.successfulActions.find(a => a === 'propose');
144
- if (proposedAction) {
145
- this.eventEmitter.emit('checkpoint-published', { checkpoint: this.checkpointNumber, slot: this.slot });
146
- const coinbase = checkpoint?.header.coinbase;
147
- await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
148
- return checkpoint;
149
- } else if (checkpoint) {
150
- this.eventEmitter.emit('checkpoint-publish-failed', { ...l1Response, slot: this.slot });
151
- return undefined;
257
+ // Background the attestation signing → L1 pipeline so the work loop is unblocked
258
+ this.pendingL1Submission = this.waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises);
259
+
260
+ // Return the built checkpoint immediately — the work loop is now unblocked
261
+ return checkpoint;
262
+ }
263
+
264
+ /**
265
+ * Background pipeline: collects attestations, signs them, enqueues the checkpoint, and submits to L1.
266
+ * Runs as a fire-and-forget task stored in `pendingL1Submission` so the work loop is unblocked.
267
+ */
268
+ private async waitForAttestationsAndEnqueueSubmissionAsync(
269
+ broadcast: CheckpointProposalBroadcast,
270
+ votesPromises: Promise<unknown>[],
271
+ ): Promise<void> {
272
+ const { checkpoint } = broadcast;
273
+
274
+ try {
275
+ // Wait for all votes actions, enqueued at the beginning, to resolve
276
+ await Promise.all(votesPromises);
277
+
278
+ // Try to collect attestations from the committee
279
+ const signedAttestations = await this.getSignedCommitteeAttestations(broadcast);
280
+
281
+ // Wait for the previous checkpoint to land on L1 before submitting, so we can check it
282
+ // matches the proposed checkpoint we used as parent, and has valid attestations.
283
+ if (signedAttestations && (await this.waitForValidParentCheckpointOnL1())) {
284
+ await this.enqueueCheckpointForSubmission({ checkpoint, ...signedAttestations });
285
+ }
286
+
287
+ // If we failed to collect attestations, at least check if we need to issue an invalidation
288
+ if (!signedAttestations && (await this.waitForSyncedL2SlotNumber(this.slotNow))) {
289
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
290
+ if (!validationStatus.valid) {
291
+ this.log.warn(
292
+ `Checkpoint ${validationStatus.checkpoint.checkpointNumber} has invalid attestations, enqueuing invalidation in spite of attestation collection failure`,
293
+ { checkpoint: validationStatus.checkpoint, reason: validationStatus.reason },
294
+ );
295
+ await this.enqueueInvalidation(validationStatus);
296
+ }
297
+ }
298
+
299
+ // Send whatever was enqueued: votes + (propose | invalidation | nothing).
300
+ const l1Response = await this.publisher.sendRequestsAt(this.targetSlot);
301
+ const proposedAction = l1Response?.successfulActions.find(a => a === 'propose');
302
+ if (proposedAction) {
303
+ this.logCheckpointEvent('published', `Checkpoint published for slot ${this.targetSlot}`, {
304
+ slot: this.targetSlot,
305
+ checkpointNumber: this.checkpointNumber,
306
+ successfulActions: l1Response?.successfulActions,
307
+ sentActions: l1Response?.sentActions,
308
+ });
309
+ this.eventEmitter.emit('checkpoint-published', { checkpoint: this.checkpointNumber, slot: this.targetSlot });
310
+ const coinbase = checkpoint.header.coinbase;
311
+ await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
312
+ } else {
313
+ this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, {
314
+ slot: this.targetSlot,
315
+ checkpointNumber: this.checkpointNumber,
316
+ successfulActions: l1Response?.successfulActions,
317
+ failedActions: l1Response?.failedActions,
318
+ sentActions: l1Response?.sentActions,
319
+ expiredActions: l1Response?.expiredActions,
320
+ reason: 'propose_action_not_successful',
321
+ });
322
+ this.log.warn(`Checkpoint publish failed for slot ${this.targetSlot}`, {
323
+ slot: this.targetSlot,
324
+ checkpointNumber: this.checkpointNumber,
325
+ successfulActions: l1Response?.successfulActions,
326
+ failedActions: l1Response?.failedActions,
327
+ sentActions: l1Response?.sentActions,
328
+ expiredActions: l1Response?.expiredActions,
329
+ reason: 'propose_action_not_successful',
330
+ });
331
+ this.eventEmitter.emit('checkpoint-publish-failed', { ...l1Response, slot: this.targetSlot });
332
+ this.metrics.recordPipelineDiscard();
333
+ }
334
+ } catch (err) {
335
+ if (err instanceof SequencerInterruptedError) {
336
+ return;
337
+ }
338
+ this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, {
339
+ slot: this.targetSlot,
340
+ checkpointNumber: this.checkpointNumber,
341
+ reason: err instanceof Error ? err.message : String(err),
342
+ });
343
+ this.log.error(`Background attestation/L1 pipeline failed for slot ${this.targetSlot}`, err, {
344
+ slot: this.targetSlot,
345
+ checkpointNumber: this.checkpointNumber,
346
+ reason: err instanceof Error ? err.message : String(err),
347
+ });
348
+ this.eventEmitter.emit('checkpoint-publish-failed', { slot: this.targetSlot });
349
+ this.metrics.recordPipelineDiscard();
350
+ }
351
+ }
352
+
353
+ /** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */
354
+ private async enqueueCheckpointForSubmission(result: CheckpointProposalResult): Promise<void> {
355
+ const { checkpoint, attestations, attestationsSignature } = result;
356
+
357
+ // Build-frame deadlines are measured against `slotNow`; observers still see `targetSlot`.
358
+ this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.targetSlot, this.slotNow);
359
+ const aztecSlotDuration = this.l1Constants.slotDuration;
360
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
361
+ const txTimeoutAt = new Date((submissionSlotStart + aztecSlotDuration) * 1000);
362
+
363
+ // If we have been configured to potentially skip publishing checkpoint then roll the dice here
364
+ if (
365
+ this.config.skipPublishingCheckpointsPercent !== undefined &&
366
+ this.config.skipPublishingCheckpointsPercent > 0
367
+ ) {
368
+ const roll = Math.max(0, randomInt(100));
369
+ if (roll < this.config.skipPublishingCheckpointsPercent) {
370
+ this.log.warn(
371
+ `Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${roll}`,
372
+ );
373
+ return;
374
+ }
375
+ }
376
+
377
+ await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
378
+ txTimeoutAt,
379
+ });
380
+ }
381
+
382
+ /**
383
+ * Wait until the archiver syncs past the given L2 slot number.
384
+ * The deadline is the end of `this.targetSlot`, beyond which any pipelined work would miss its
385
+ * L1 submission window and is no longer useful.
386
+ */
387
+ private async waitForSyncedL2SlotNumber(waitForSlot: SlotNumber): Promise<boolean> {
388
+ const targetSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
389
+ const targetSlotEndMs = (targetSlotStart + this.l1Constants.slotDuration) * 1000;
390
+ const syncDelayTolerance = this.l1Constants.ethereumSlotDuration * 2 * 1000;
391
+ const timeoutSeconds = Math.max(0.1, (targetSlotEndMs + syncDelayTolerance - this.dateProvider.now()) / 1000);
392
+
393
+ try {
394
+ const timer = new Timer();
395
+ while (true) {
396
+ const syncedSlot = await this.l2BlockSource.getSyncedL2SlotNumber();
397
+ if (syncedSlot !== undefined && syncedSlot >= waitForSlot) {
398
+ return true;
399
+ }
400
+ if (timeoutSeconds && timer.s() > timeoutSeconds) {
401
+ throw new TimeoutError(`Timeout awaiting archiver sync past slot ${waitForSlot}`);
402
+ }
403
+ await this.awaitInterruptibleSleep(ARCHIVER_SYNC_POLLING_MS);
404
+ }
405
+ } catch (err) {
406
+ if (err instanceof SequencerInterruptedError) {
407
+ throw err;
408
+ }
409
+ this.log.warn(
410
+ `Archiver did not sync L1 past slot ${waitForSlot} before slot ${this.targetSlot} expired, discarding pipelined work`,
411
+ { checkpointNumber: this.checkpointNumber },
412
+ );
413
+ this.emitPipelinedCheckpointDiscarded('archiver-sync-timeout');
414
+ return false;
415
+ }
416
+ }
417
+
418
+ /**
419
+ * Waits for the parent checkpoint to land on L1 before submitting a pipelined checkpoint.
420
+ * Polls until the archiver has synced L1 past the parent's slot, then verifies:
421
+ * - If we built on a proposed parent: it must have landed on L1 with matching hash and valid attestations.
422
+ * - If we built without a proposed parent: no new checkpoint must have appeared for that slot.
423
+ * If the parent has invalid attestations, enqueues an invalidation. Returns whether to proceed with the proposal.
424
+ */
425
+ protected async waitForValidParentCheckpointOnL1(): Promise<boolean> {
426
+ if (this.config.skipWaitForValidParentCheckpointOnL1) {
427
+ this.log.warn(`Skipping waitForValidParentCheckpointOnL1 due to test configuration`, {
428
+ checkpointNumber: this.checkpointNumber,
429
+ });
430
+ return true;
431
+ }
432
+
433
+ const parentCheckpointNumber = CheckpointNumber(this.checkpointNumber - 1);
434
+
435
+ // Wait until archiver has synced L1 past the parent's slot (slotNow)
436
+ if (!(await this.waitForSyncedL2SlotNumber(this.slotNow))) {
437
+ return false;
438
+ }
439
+
440
+ const tips = await this.l2BlockSource.getL2Tips();
441
+ const checkpointedNumber = tips.checkpointed.checkpoint.number;
442
+
443
+ // We built on top of a proposed checkpoint. Verify it landed on L1 as expected.
444
+ if (this.proposedCheckpointData) {
445
+ // After syncing from L1 we see the chain tip has invalid attestations. This means the parent checkpoint was posted
446
+ // with invalid attestations, or it built on top of something with invalid attestations and didnt invalidate them.
447
+ // Either way, we thought our parent would be valid, so we have to throw away our work. But at least we'll try and
448
+ // invalidate on L1 so we clean up the chain for the next proposer. And we'll slash them, but that's handled elsewhere.
449
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
450
+ if (!validationStatus.valid) {
451
+ this.log.warn(
452
+ `Parent checkpoint ${parentCheckpointNumber} has invalid attestations, discarding pipelined work`,
453
+ { checkpointNumber: this.checkpointNumber, reason: validationStatus.reason },
454
+ );
455
+ this.emitPipelinedCheckpointDiscarded('parent-invalid-attestations');
456
+ await this.enqueueInvalidation(validationStatus);
457
+ return false;
458
+ }
459
+
460
+ // The pending chain is valid. But did the parent checkpoint land on L1 at all?
461
+ if (checkpointedNumber < parentCheckpointNumber) {
462
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} did not land on L1, discarding pipelined work`, {
463
+ checkpointNumber: this.checkpointNumber,
464
+ checkpointedNumber,
465
+ });
466
+ this.emitPipelinedCheckpointDiscarded('parent-not-on-l1');
467
+ return false;
468
+ }
469
+
470
+ // It landed. But is it the one we were expecting?
471
+ const expectedHash = this.proposedCheckpointData.header.hash().toString();
472
+ if (tips.checkpointed.checkpoint.hash !== expectedHash) {
473
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} hash mismatch on L1, discarding pipelined work`, {
474
+ checkpointNumber: this.checkpointNumber,
475
+ expectedHash,
476
+ actualHash: tips.checkpointed.checkpoint.hash,
477
+ });
478
+ this.emitPipelinedCheckpointDiscarded('parent-hash-mismatch');
479
+ return false;
480
+ }
481
+
482
+ return true;
483
+ } else {
484
+ // We didn't see a proposed checkpoint at build time, so we built on checkpointed parent from two slots ago.
485
+ // But if a new checkpoint for the previous slot appeared on L1 in the meantime, our checkpoint assumed the wrong parent,
486
+ // so we have to discard our work. This can happen if we're somehow cut off from p2p and fail to see the checkpoint
487
+ // proposal for the previous slot.
488
+ if (checkpointedNumber > parentCheckpointNumber) {
489
+ this.log.warn(
490
+ `Unexpected checkpoint ${checkpointedNumber} landed on L1 after we built on top of parent ${parentCheckpointNumber}, discarding pipelined work`,
491
+ { checkpointNumber: this.checkpointNumber, checkpointedNumber },
492
+ );
493
+ this.emitPipelinedCheckpointDiscarded('unexpected-parent-appeared');
494
+ return false;
495
+ }
496
+
497
+ return true;
498
+ }
499
+ }
500
+
501
+ /** Emits the pipelined-checkpoint-discarded event and records the metric. */
502
+ private emitPipelinedCheckpointDiscarded(reason: string): void {
503
+ this.metrics.recordPipelineParentCheckpointMismatch(reason);
504
+ this.eventEmitter.emit('pipelined-checkpoint-discarded', {
505
+ slot: this.targetSlot,
506
+ checkpointNumber: this.checkpointNumber,
507
+ reason,
508
+ });
509
+ }
510
+
511
+ /** Simulates and enqueues an invalidation request for the invalid parent checkpoint. */
512
+ private async enqueueInvalidation(validationStatus: ValidateCheckpointResult): Promise<void> {
513
+ if (this.config.skipInvalidateBlockAsProposer) {
514
+ this.log.warn(`Skipping checkpoint invalidation as proposer due to test configuration`);
515
+ return;
516
+ }
517
+ const invalidateRequest = await this.publisher.simulateInvalidateCheckpoint(validationStatus);
518
+ if (invalidateRequest) {
519
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
520
+ const txTimeoutAt = new Date((submissionSlotStart + this.l1Constants.slotDuration) * 1000);
521
+ this.publisher.enqueueInvalidateCheckpoint(invalidateRequest, { txTimeoutAt });
522
+ } else {
523
+ this.log.info(`Invalidation simulation returned undefined, checkpoint may have been removed already`, {
524
+ checkpointNumber: this.checkpointNumber,
525
+ });
152
526
  }
153
527
  }
154
528
 
@@ -156,48 +530,98 @@ export class CheckpointProposalJob implements Traceable {
156
530
  return {
157
531
  // nullish operator needed for tests
158
532
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
159
- [Attributes.SLOT_NUMBER]: this.slot,
533
+ [Attributes.SLOT_NUMBER]: this.targetSlot,
160
534
  };
161
535
  })
162
- private async proposeCheckpoint(): Promise<Checkpoint | undefined> {
536
+ private async proposeCheckpoint(): Promise<CheckpointProposalBroadcast | undefined> {
163
537
  try {
538
+ const now = this.dateProvider.now();
539
+ if (this.proposedCheckpointData) {
540
+ // Measure against the wall-clock slot whose build window we are currently using.
541
+ // In pipelining mode `targetSlot` is intentionally one slot ahead, which makes the
542
+ // target-slot boundary a full slot away from the actual build start time.
543
+ const slotBoundaryMs = Number(getTimestampForSlot(this.slotNow, this.l1Constants)) * 1000;
544
+ this.checkpointMetrics.recordPipelinedCheckpointBuildStartOffsetFromSlotBoundary(now - slotBoundaryMs);
545
+ }
546
+ this.checkpointMetrics.startCheckpointTiming(now);
547
+
164
548
  // Get operator configured coinbase and fee recipient for this attestor
165
549
  const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
166
550
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
167
551
 
168
552
  // Start the checkpoint
169
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.slot);
170
- this.metrics.incOpenSlot(this.slot, this.proposer?.toString() ?? 'unknown');
553
+ this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.targetSlot, this.slotNow);
554
+ this.logCheckpointEvent('slot-started', `Starting checkpoint proposal for slot ${this.targetSlot}`, {
555
+ buildSlot: this.slotNow,
556
+ submissionSlot: this.targetSlot,
557
+ slot: this.targetSlot,
558
+ checkpointNumber: this.checkpointNumber,
559
+ proposer: this.proposer?.toString(),
560
+ attestorAddress: this.attestorAddress.toString(),
561
+ publisherAddress: this.publisher.getSenderAddress().toString(),
562
+ coinbase: coinbase.toString(),
563
+ });
564
+ this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
171
565
 
172
566
  // Enqueues checkpoint invalidation (constant for the whole slot)
173
567
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
174
568
  this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
175
569
  }
176
570
 
177
- // Create checkpoint builder for the slot
571
+ // Build the simulation plan for this slot. When pipelining, this overrides L1's view of
572
+ // pending/archive/fee-header to "as if the proposed parent had landed", so both the
573
+ // mana-min-fee simulation (in the globals builder) and the pre-broadcast
574
+ // validateBlockHeader see the chain tip the eventual L1 send will see.
575
+ this.checkpointSimulationOverridesPlan = await buildCheckpointSimulationOverridesPlan({
576
+ checkpointNumber: this.checkpointNumber,
577
+ proposedCheckpointData: this.proposedCheckpointData,
578
+ invalidateToPendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
579
+ checkpointedCheckpointNumber: this.checkpointedCheckpointNumber,
580
+ rollup: this.publisher.rollupContract,
581
+ signatureContext: this.signatureContext,
582
+ log: this.log,
583
+ });
584
+
178
585
  const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(
179
586
  coinbase,
180
587
  feeRecipient,
181
- this.slot,
588
+ this.targetSlot,
589
+ this.checkpointSimulationOverridesPlan,
182
590
  );
183
591
 
184
592
  // Collect L1 to L2 messages for the checkpoint and compute their hash
185
593
  const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(this.checkpointNumber);
186
594
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
187
595
 
188
- // Collect the out hashes of all the checkpoints before this one in the same epoch
189
- const previousCheckpoints = (await this.l2BlockSource.getCheckpointsForEpoch(this.epoch)).filter(
190
- c => c.number < this.checkpointNumber,
191
- );
192
- const previousCheckpointOutHashes = previousCheckpoints.map(c => c.getCheckpointOutHash());
596
+ // Collect the out hashes of all the checkpoints before this one in the same epoch.
597
+ // Under pipelining the parent checkpoint may not be on L1 yet at build time, so the helper
598
+ // splices in the parent's checkpointOutHash from the locally-known proposed checkpoint so
599
+ // the resulting `epochOutHash` matches what validators (and L1) compute once the parent
600
+ // lands on L1.
601
+ const previousCheckpointOutHashes = await getPreviousCheckpointOutHashes({
602
+ blockSource: this.l2BlockSource,
603
+ epoch: this.targetEpoch,
604
+ checkpointNumber: this.checkpointNumber,
605
+ l1Constants: this.epochCache.getL1Constants(),
606
+ pipeliningEnabled: true,
607
+ proposedCheckpointData: this.proposedCheckpointData,
608
+ log: this.log,
609
+ });
610
+
611
+ // Anchor the modifier to the predicted parent fee header: L1 will apply it against
612
+ // that, not against the latest published checkpoint (which lags by one under pipelining).
613
+ const predictedParentEthPerFeeAssetE12 =
614
+ this.checkpointSimulationOverridesPlan?.pendingCheckpointState?.feeHeader?.ethPerFeeAsset;
615
+ const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier(predictedParentEthPerFeeAssetE12);
193
616
 
194
617
  // Create a long-lived forked world state for the checkpoint builder
195
- using fork = await this.worldState.fork(this.syncedToBlockNumber, { closeDelayMs: 12_000 });
618
+ await using fork = await this.worldState.fork(this.syncedToBlockNumber, { closeDelayMs: 12_000 });
196
619
 
197
620
  // Create checkpoint builder for the entire slot
198
621
  const checkpointBuilder = await this.checkpointsBuilder.startCheckpoint(
199
622
  this.checkpointNumber,
200
623
  checkpointGlobalVariables,
624
+ feeAssetPriceModifier,
201
625
  l1ToL2Messages,
202
626
  previousCheckpointOutHashes,
203
627
  fork,
@@ -212,11 +636,13 @@ export class CheckpointProposalJob implements Traceable {
212
636
 
213
637
  const checkpointProposalOptions: CheckpointProposalOptions = {
214
638
  publishFullTxs: !!this.config.publishTxsWithProposals,
215
- broadcastInvalidCheckpointProposal: this.config.broadcastInvalidBlockProposal,
639
+ broadcastInvalidCheckpointProposal:
640
+ this.config.broadcastInvalidCheckpointProposalOnly || this.config.broadcastInvalidBlockProposal,
216
641
  };
217
642
 
218
643
  let blocksInCheckpoint: L2Block[] = [];
219
- let blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined = undefined;
644
+ let blockPendingBroadcast: BlockProposal | undefined = undefined;
645
+ const checkpointBuildTimer = new Timer();
220
646
 
221
647
  try {
222
648
  // Main loop: build blocks for the checkpoint
@@ -232,124 +658,177 @@ export class CheckpointProposalJob implements Traceable {
232
658
  // These errors are expected in HA mode, so we yield and let another HA node handle the slot
233
659
  // The only distinction between the 2 errors is SlashingProtectionError throws when the payload is different,
234
660
  // which is normal for block building (may have picked different txs)
235
- if (err instanceof DutyAlreadySignedError) {
236
- this.log.info(`Checkpoint proposal for slot ${this.slot} already signed by another HA node, yielding`, {
237
- slot: this.slot,
238
- signedByNode: err.signedByNode,
239
- });
240
- return undefined;
241
- }
242
- if (err instanceof SlashingProtectionError) {
243
- this.log.info(`Checkpoint proposal for slot ${this.slot} blocked by slashing protection, yielding`, {
244
- slot: this.slot,
245
- existingMessageHash: err.existingMessageHash,
246
- attemptedMessageHash: err.attemptedMessageHash,
247
- });
661
+ if (this.handleHASigningError(err, 'Block proposal')) {
248
662
  return undefined;
249
663
  }
250
664
  throw err;
251
665
  }
252
666
 
253
667
  if (blocksInCheckpoint.length === 0) {
254
- this.log.warn(`No blocks were built for slot ${this.slot}`, { slot: this.slot });
255
- this.eventEmitter.emit('checkpoint-empty', { slot: this.slot });
668
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
669
+ slot: this.targetSlot,
670
+ checkpointNumber: this.checkpointNumber,
671
+ reason: 'no_blocks_built',
672
+ });
673
+ this.log.warn(`No blocks were built for slot ${this.targetSlot}`, {
674
+ slot: this.targetSlot,
675
+ checkpointNumber: this.checkpointNumber,
676
+ reason: 'no_blocks_built',
677
+ });
678
+ this.eventEmitter.emit('checkpoint-empty', { slot: this.targetSlot });
679
+ return undefined;
680
+ }
681
+
682
+ const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
683
+ if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
684
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
685
+ slot: this.targetSlot,
686
+ checkpointNumber: this.checkpointNumber,
687
+ blocksBuilt: blocksInCheckpoint.length,
688
+ minBlocksForCheckpoint,
689
+ reason: 'min_blocks_not_met',
690
+ });
691
+ this.log.warn(
692
+ `Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`,
693
+ {
694
+ slot: this.targetSlot,
695
+ checkpointNumber: this.checkpointNumber,
696
+ blocksBuilt: blocksInCheckpoint.length,
697
+ minBlocksForCheckpoint,
698
+ reason: 'min_blocks_not_met',
699
+ },
700
+ );
256
701
  return undefined;
257
702
  }
258
703
 
259
704
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
260
705
  // broadcasted yet, and wait to collect the committee attestations.
261
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
706
+ this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.targetSlot, this.slotNow);
262
707
  const checkpoint = await checkpointBuilder.completeCheckpoint();
263
708
 
264
- // Do not collect attestations nor publish to L1 in fisherman mode
709
+ // Final validation: per-block limits are only checked if the operator set them explicitly.
710
+ // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
711
+ try {
712
+ validateCheckpoint(checkpoint, {
713
+ rollupManaLimit: this.l1Constants.rollupManaLimit,
714
+ maxL2BlockGas: this.config.maxL2BlockGas,
715
+ maxDABlockGas: this.config.maxDABlockGas,
716
+ maxTxsPerBlock: this.config.maxTxsPerBlock,
717
+ maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint,
718
+ });
719
+ } catch (err) {
720
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
721
+ slot: this.targetSlot,
722
+ checkpointNumber: this.checkpointNumber,
723
+ blocksBuilt: blocksInCheckpoint.length,
724
+ reason: 'invalid_checkpoint',
725
+ checkpoint: checkpoint.header.toInspect(),
726
+ });
727
+ this.log.error(`Built an invalid checkpoint at slot ${this.slotNow} (skipping proposal)`, err, {
728
+ slot: this.targetSlot,
729
+ checkpointNumber: this.checkpointNumber,
730
+ blocksBuilt: blocksInCheckpoint.length,
731
+ reason: 'invalid_checkpoint',
732
+ checkpoint: checkpoint.header.toInspect(),
733
+ });
734
+ return undefined;
735
+ }
736
+
737
+ // Record checkpoint-level build metrics
738
+ this.checkpointMetrics.recordCheckpointBuild(
739
+ checkpointBuildTimer.ms(),
740
+ blocksInCheckpoint.length,
741
+ checkpoint.getStats().txCount,
742
+ Number(checkpoint.header.totalManaUsed.toBigInt()),
743
+ );
744
+ this.logCheckpointEvent('built', `Checkpoint built for slot ${this.targetSlot}`, {
745
+ slot: this.targetSlot,
746
+ buildSlot: this.slotNow,
747
+ checkpointNumber: this.checkpointNumber,
748
+ proposer: this.proposer?.toString(),
749
+ attestorAddress: this.attestorAddress.toString(),
750
+ publisherAddress: this.publisher.getSenderAddress().toString(),
751
+ blocksBuilt: blocksInCheckpoint.length,
752
+ txCount: checkpoint.getStats().txCount,
753
+ totalMana: Number(checkpoint.header.totalManaUsed.toBigInt()),
754
+ });
755
+
756
+ // In fisherman mode, return the checkpoint without broadcasting or collecting attestations
265
757
  if (this.config.fishermanMode) {
266
758
  this.log.info(
267
- `Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` +
759
+ `Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` +
268
760
  `Skipping proposal in fisherman mode.`,
269
761
  {
270
- slot: this.slot,
762
+ slot: this.targetSlot,
271
763
  checkpoint: checkpoint.header.toInspect(),
272
764
  blocksBuilt: blocksInCheckpoint.length,
273
765
  },
274
766
  );
275
767
  this.metrics.recordCheckpointSuccess();
276
- return checkpoint;
768
+ // Return a broadcast result with a dummy proposal — fisherman mode skips attestation collection
769
+ return { checkpoint, proposal: undefined!, blockProposedAt: this.dateProvider.now() };
277
770
  }
278
771
 
279
- // Include the block pending broadcast in the checkpoint proposal if any
280
- const lastBlock = blockPendingBroadcast && {
281
- blockHeader: blockPendingBroadcast.block.header,
282
- indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
283
- txs: blockPendingBroadcast.txs,
284
- };
772
+ // Validate the header against L1 state before broadcasting.
773
+ // If this fails the slot is aborted before any gossip work; state drift between here
774
+ // and the eventual L1 send is caught by the bundle simulate at send time.
775
+ try {
776
+ await this.publisher.validateBlockHeader(checkpoint.header, this.checkpointSimulationOverridesPlan);
777
+ } catch (err) {
778
+ this.log.error(`Pre-broadcast header validation failed for slot ${this.targetSlot}; aborting`, err, {
779
+ slot: this.targetSlot,
780
+ checkpointNumber: this.checkpointNumber,
781
+ });
782
+ this.metrics.recordCheckpointProposalFailed('header_validation_failed');
783
+ this.eventEmitter.emit('header-validation-failed', {
784
+ slot: this.targetSlot,
785
+ checkpointNumber: this.checkpointNumber,
786
+ reason: err instanceof Error ? err.message : String(err),
787
+ });
788
+ return undefined;
789
+ }
285
790
 
286
791
  // Create the checkpoint proposal and broadcast it
287
792
  const proposal = await this.validatorClient.createCheckpointProposal(
288
793
  checkpoint.header,
289
794
  checkpoint.archive.root,
290
- lastBlock,
795
+ this.checkpointNumber,
796
+ feeAssetPriceModifier,
797
+ blockPendingBroadcast,
291
798
  this.proposer,
292
799
  checkpointProposalOptions,
293
800
  );
294
801
 
295
- const blockProposedAt = this.dateProvider.now();
296
- await this.p2pClient.broadcastCheckpointProposal(proposal);
297
-
298
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
299
- const attestations = await this.waitForAttestations(proposal);
300
- const blockAttestedAt = this.dateProvider.now();
802
+ // Advance our own optimistic proposed-checkpoint tip locally before gossiping. Gossipsub
803
+ // doesn't echo our own messages back, so this is how the proposer makes its own proposed
804
+ // checkpoint visible for pipelining the next slot. Built from local checkpoint data — never
805
+ // from the broadcast proposal archive, which may be deliberately corrupted under test flags.
806
+ // Fail closed: if this throws, the outer catch aborts the slot before gossiping.
807
+ await this.syncProposedCheckpointToArchiver(checkpoint, blocksInCheckpoint.length, feeAssetPriceModifier);
301
808
 
302
- this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
303
-
304
- // Proposer must sign over the attestations before pushing them to L1
305
- const signer = this.proposer ?? this.publisher.getSenderAddress();
306
- let attestationsSignature: Signature;
307
- try {
308
- attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
309
- attestations,
310
- signer,
311
- this.slot,
312
- this.checkpointNumber,
313
- );
314
- } catch (err) {
315
- // We shouldn't really get here since we yield to another HA node
316
- // as soon as we see these errors when creating block proposals.
317
- if (err instanceof DutyAlreadySignedError) {
318
- this.log.info(`Attestations signature for slot ${this.slot} already signed by another HA node, yielding`, {
319
- slot: this.slot,
320
- signedByNode: err.signedByNode,
321
- });
322
- return undefined;
323
- }
324
- if (err instanceof SlashingProtectionError) {
325
- this.log.info(`Attestations signature for slot ${this.slot} blocked by slashing protection, yielding`, {
326
- slot: this.slot,
327
- existingMessageHash: err.existingMessageHash,
328
- attemptedMessageHash: err.attemptedMessageHash,
329
- });
330
- return undefined;
809
+ const blockProposedAt = this.dateProvider.now();
810
+ if (this.config.skipBroadcastCheckpointProposal) {
811
+ // Test-only: suppress the CheckpointProposal so peers never see a proposed checkpoint for
812
+ // this slot, but still broadcast the held last block standalone so peers' archivers ingest
813
+ // it as a proposed-but-uncheckpointed tip — the exact orphan-block state that
814
+ // pruneOrphanProposedBlocks / checkSync must handle.
815
+ if (blockPendingBroadcast && !this.config.skipBroadcastProposals) {
816
+ await this.p2pClient.broadcastProposal(blockPendingBroadcast);
331
817
  }
332
- throw err;
818
+ } else if (!this.config.skipBroadcastProposals) {
819
+ await this.p2pClient.broadcastCheckpointProposal(proposal);
820
+ this.checkpointMetrics.noteCheckpointBroadcast(this.dateProvider.now());
333
821
  }
334
822
 
335
- // Enqueue publishing the checkpoint to L1
336
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
337
- const aztecSlotDuration = this.l1Constants.slotDuration;
338
- const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
339
- const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
340
- await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
341
- txTimeoutAt,
342
- forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
343
- });
344
-
345
- return checkpoint;
823
+ // Return immediately after broadcast attestation collection happens in the background
824
+ return { checkpoint, proposal, blockProposedAt };
346
825
  } catch (err) {
347
826
  if (err && (err instanceof DutyAlreadySignedError || err instanceof SlashingProtectionError)) {
348
827
  // swallow this error. It's already been logged by a function deeper in the stack
349
828
  return undefined;
350
829
  }
351
830
 
352
- this.log.error(`Error building checkpoint at slot ${this.slot}`, err);
831
+ this.log.error(`Error building checkpoint at slot ${this.targetSlot}`, err);
353
832
  return undefined;
354
833
  }
355
834
  }
@@ -365,29 +844,35 @@ export class CheckpointProposalJob implements Traceable {
365
844
  blockProposalOptions: BlockProposalOptions,
366
845
  ): Promise<{
367
846
  blocksInCheckpoint: L2Block[];
368
- blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined;
847
+ blockPendingBroadcast: BlockProposal | undefined;
369
848
  }> {
370
849
  const blocksInCheckpoint: L2Block[] = [];
371
850
  const txHashesAlreadyIncluded = new Set<string>();
372
851
  const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
373
852
 
374
- // Remaining blob fields available for blocks (checkpoint end marker already subtracted)
375
- let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
376
-
377
853
  // Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
378
- let blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined = undefined;
854
+ let blockPendingBroadcast: BlockProposal | undefined = undefined;
379
855
 
380
856
  while (true) {
381
857
  const blocksBuilt = blocksInCheckpoint.length;
382
858
  const indexWithinCheckpoint = IndexWithinCheckpoint(blocksBuilt);
383
859
  const blockNumber = BlockNumber(initialBlockNumber + blocksBuilt);
384
860
 
861
+ if (blocksBuilt >= this.config.maxBlocksPerCheckpoint) {
862
+ this.log.debug(`Reached max blocks per checkpoint`, {
863
+ slot: this.targetSlot,
864
+ blocksBuilt,
865
+ maxBlocksPerCheckpoint: this.config.maxBlocksPerCheckpoint,
866
+ });
867
+ break;
868
+ }
869
+
385
870
  const secondsIntoSlot = this.getSecondsIntoSlot();
386
871
  const timingInfo = this.timetable.canStartNextBlock(secondsIntoSlot);
387
872
 
388
873
  if (!timingInfo.canStart) {
389
874
  this.log.debug(`Not enough time left in slot to start another block`, {
390
- slot: this.slot,
875
+ slot: this.targetSlot,
391
876
  blocksBuilt,
392
877
  secondsIntoSlot,
393
878
  });
@@ -406,25 +891,25 @@ export class CheckpointProposalJob implements Traceable {
406
891
  blockNumber,
407
892
  indexWithinCheckpoint,
408
893
  txHashesAlreadyIncluded,
409
- remainingBlobFields,
410
894
  });
411
895
 
412
- // TODO(palla/mbps): Review these conditions. We may want to keep trying in some scenarios.
413
- if (!buildResult && timingInfo.isLastBlock) {
414
- // If no block was produced due to not enough txs and this was the last subslot, exit
415
- break;
416
- } else if (!buildResult && timingInfo.deadline !== undefined) {
417
- // But if there is still time for more blocks, wait until the next subslot and try again
896
+ // If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
897
+ if ('failure' in buildResult) {
898
+ // If this was the last subslot, or we're running with a single block per slot, we're done
899
+ if (timingInfo.isLastBlock || timingInfo.deadline === undefined) {
900
+ break;
901
+ }
902
+ // Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
418
903
  await this.waitUntilNextSubslot(timingInfo.deadline);
419
904
  continue;
420
- } else if (!buildResult) {
421
- // Exit if there is no possibility of building more blocks
422
- break;
423
- } else if ('error' in buildResult) {
424
- // If there was an error building the block, just exit the loop and give up the rest of the slot
905
+ }
906
+
907
+ // If there was an error building the block, we just exit the loop and give up the rest of the slot.
908
+ // We don't want to risk building more blocks if something went wrong.
909
+ if ('error' in buildResult) {
425
910
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
426
- this.log.warn(`Halting block building for slot ${this.slot}`, {
427
- slot: this.slot,
911
+ this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
912
+ slot: this.targetSlot,
428
913
  blocksBuilt,
429
914
  error: buildResult.error,
430
915
  });
@@ -432,45 +917,43 @@ export class CheckpointProposalJob implements Traceable {
432
917
  break;
433
918
  }
434
919
 
435
- const { block, usedTxs, remainingBlobFields: newRemainingBlobFields } = buildResult;
436
- blocksInCheckpoint.push(block);
920
+ const { block, usedTxs } = buildResult;
921
+ this.checkpointMetrics.noteCheckpointBlockBuilt(this.dateProvider.now(), {
922
+ isFirstBlock: blocksBuilt === 0,
923
+ isLastBlock: timingInfo.isLastBlock,
924
+ });
437
925
 
438
- // Update remaining blob fields for the next block
439
- remainingBlobFields = newRemainingBlobFields;
926
+ blocksInCheckpoint.push(block);
927
+ usedTxs.forEach(tx => txHashesAlreadyIncluded.add(tx.txHash.toString()));
440
928
 
441
- // Sync the proposed block to the archiver to make it available
442
- // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
443
- // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
444
- // Fire and forget - don't block the critical path, but log errors
445
- this.syncProposedBlockToArchiver(block).catch(err => {
446
- this.log.error(`Failed to sync proposed block ${block.number} to archiver`, { blockNumber: block.number, err });
929
+ // Sign the block proposal. This will throw if HA signing fails.
930
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, {
931
+ ...blockProposalOptions,
932
+ broadcastInvalidBlockProposal:
933
+ blockProposalOptions.broadcastInvalidBlockProposal ||
934
+ block.indexWithinCheckpoint === this.config.invalidBlockProposalIndexWithinCheckpoint,
447
935
  });
448
936
 
449
- usedTxs.forEach(tx => txHashesAlreadyIncluded.add(tx.txHash.toString()));
937
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
938
+ // so we avoid polluting our archive with a block that would fail.
939
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
940
+ // If this throws, we abort the entire checkpoint.
941
+ await this.syncProposedBlockToArchiver(block);
450
942
 
451
- // If this is the last block, exit the loop now so we start collecting attestations
943
+ // If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
452
944
  if (timingInfo.isLastBlock) {
453
- this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
454
- slot: this.slot,
945
+ this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
946
+ slot: this.targetSlot,
455
947
  blockNumber,
456
948
  blocksBuilt,
457
949
  });
458
- blockPendingBroadcast = { block, txs: usedTxs };
950
+
951
+ blockPendingBroadcast = proposal;
459
952
  break;
460
953
  }
461
954
 
462
- // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
463
- // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
464
- if (!this.config.fishermanMode) {
465
- const proposal = await this.validatorClient.createBlockProposal(
466
- block.header,
467
- block.indexWithinCheckpoint,
468
- inHash,
469
- block.archive.root,
470
- usedTxs,
471
- this.proposer,
472
- blockProposalOptions,
473
- );
955
+ // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
956
+ if (proposal && !this.config.skipBroadcastProposals) {
474
957
  await this.p2pClient.broadcastProposal(proposal);
475
958
  }
476
959
 
@@ -478,19 +961,44 @@ export class CheckpointProposalJob implements Traceable {
478
961
  await this.waitUntilNextSubslot(timingInfo.deadline);
479
962
  }
480
963
 
481
- this.log.verbose(`Block building loop completed for slot ${this.slot}`, {
482
- slot: this.slot,
964
+ this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
965
+ slot: this.targetSlot,
483
966
  blocksBuilt: blocksInCheckpoint.length,
484
967
  });
485
968
 
486
969
  return { blocksInCheckpoint, blockPendingBroadcast };
487
970
  }
488
971
 
972
+ /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */
973
+ private createBlockProposal(
974
+ block: L2Block,
975
+ inHash: Fr,
976
+ usedTxs: Tx[],
977
+ blockProposalOptions: BlockProposalOptions,
978
+ ): Promise<BlockProposal | undefined> {
979
+ if (this.config.fishermanMode) {
980
+ this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
981
+ return Promise.resolve(undefined);
982
+ }
983
+ return this.validatorClient.createBlockProposal(
984
+ block.header,
985
+ this.checkpointNumber,
986
+ block.indexWithinCheckpoint,
987
+ inHash,
988
+ block.archive.root,
989
+ usedTxs,
990
+ this.proposer,
991
+ blockProposalOptions,
992
+ );
993
+ }
994
+
489
995
  /** Sleeps until it is time to produce the next block in the slot */
490
996
  @trackSpan('CheckpointProposalJob.waitUntilNextSubslot')
491
997
  private async waitUntilNextSubslot(nextSubslotStart: number) {
492
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
493
- this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, { slot: this.slot });
998
+ this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.targetSlot, this.slotNow);
999
+ this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
1000
+ slot: this.targetSlot,
1001
+ });
494
1002
  await this.waitUntilTimeInSlot(nextSubslotStart);
495
1003
  }
496
1004
 
@@ -505,64 +1013,81 @@ export class CheckpointProposalJob implements Traceable {
505
1013
  indexWithinCheckpoint: IndexWithinCheckpoint;
506
1014
  buildDeadline: Date | undefined;
507
1015
  txHashesAlreadyIncluded: Set<string>;
508
- remainingBlobFields: number;
509
1016
  },
510
- ): Promise<{ block: L2Block; usedTxs: Tx[]; remainingBlobFields: number } | { error: Error } | undefined> {
511
- const {
512
- blockTimestamp,
513
- forceCreate,
514
- blockNumber,
515
- indexWithinCheckpoint,
516
- buildDeadline,
517
- txHashesAlreadyIncluded,
518
- remainingBlobFields,
519
- } = opts;
1017
+ ): Promise<
1018
+ { block: L2Block; usedTxs: Tx[] } | { failure: 'insufficient-txs' | 'insufficient-valid-txs' } | { error: Error }
1019
+ > {
1020
+ const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } =
1021
+ opts;
520
1022
 
521
1023
  this.log.verbose(
522
- `Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`,
1024
+ `Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`,
523
1025
  { ...checkpointBuilder.getConstantData(), ...opts },
524
1026
  );
525
1027
 
526
1028
  try {
527
1029
  // Wait until we have enough txs to build the block
528
- const minTxs = this.config.minTxsPerBlock;
529
- const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
1030
+ const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
530
1031
  if (!canStartBuilding) {
1032
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1033
+ reason: 'insufficient_txs',
1034
+ blockNumber,
1035
+ slot: this.targetSlot,
1036
+ checkpointNumber: this.checkpointNumber,
1037
+ indexWithinCheckpoint,
1038
+ availableTxs,
1039
+ minTxs,
1040
+ });
531
1041
  this.log.warn(
532
- `Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`,
533
- { blockNumber, slot: this.slot, indexWithinCheckpoint },
1042
+ `Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (got ${availableTxs} txs but needs ${minTxs})`,
1043
+ {
1044
+ reason: 'insufficient_txs',
1045
+ blockNumber,
1046
+ slot: this.targetSlot,
1047
+ checkpointNumber: this.checkpointNumber,
1048
+ indexWithinCheckpoint,
1049
+ availableTxs,
1050
+ minTxs,
1051
+ },
534
1052
  );
535
- this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, availableTxs, slot: this.slot });
1053
+ this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, availableTxs, slot: this.targetSlot });
536
1054
  this.metrics.recordBlockProposalFailed('insufficient_txs');
537
- return undefined;
1055
+ return { failure: 'insufficient-txs' };
538
1056
  }
539
1057
 
540
1058
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
541
1059
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
542
1060
  const pendingTxs = filter(
543
- this.p2pClient.iteratePendingTxs(),
1061
+ this.p2pClient.iterateEligiblePendingTxs(),
544
1062
  tx => !txHashesAlreadyIncluded.has(tx.txHash.toString()),
545
1063
  );
546
1064
 
547
1065
  this.log.debug(
548
- `Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`,
549
- { slot: this.slot, blockNumber, indexWithinCheckpoint },
1066
+ `Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot} with ${availableTxs} available txs`,
1067
+ { slot: this.targetSlot, blockNumber, indexWithinCheckpoint },
550
1068
  );
551
- this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
552
-
553
- // Calculate blob fields limit for txs (remaining capacity - this block's end overhead)
554
- const blockEndOverhead = getNumBlockEndBlobFields(indexWithinCheckpoint === 0);
555
- const maxBlobFieldsForTxs = remainingBlobFields - blockEndOverhead;
1069
+ this.setStateFn(SequencerState.CREATING_BLOCK, this.targetSlot, this.slotNow);
556
1070
 
557
- const blockBuilderOptions: PublicProcessorLimits = {
1071
+ // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
1072
+ // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
1073
+ // minValidTxs is passed into the builder so it can reject the block *before* updating state.
1074
+ const minValidTxs = forceCreate ? 0 : (this.config.minValidTxsPerBlock ?? minTxs);
1075
+ const blockBuilderOptions: BlockBuilderOptions = {
558
1076
  maxTransactions: this.config.maxTxsPerBlock,
559
- maxBlockSize: this.config.maxBlockSizeInBytes,
560
- maxBlockGas: new Gas(this.config.maxDABlockGas, this.config.maxL2BlockGas),
561
- maxBlobFields: maxBlobFieldsForTxs,
1077
+ maxBlockGas:
1078
+ this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined
1079
+ ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity)
1080
+ : undefined,
562
1081
  deadline: buildDeadline,
1082
+ isBuildingProposal: true,
1083
+ minValidTxs,
1084
+ maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
1085
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier,
563
1086
  };
564
1087
 
565
- // Actually build the block by executing txs
1088
+ // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
1089
+ // if the number of successfully processed txs is below minValidTxs, ensuring state is not
1090
+ // updated for blocks that will be discarded.
566
1091
  const buildResult = await this.buildSingleBlockWithCheckpointBuilder(
567
1092
  checkpointBuilder,
568
1093
  pendingTxs,
@@ -574,22 +1099,38 @@ export class CheckpointProposalJob implements Traceable {
574
1099
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
575
1100
  await this.dropFailedTxsFromP2P(buildResult.failedTxs);
576
1101
 
577
- // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
578
- // too long, then we may not get to minTxsPerBlock after executing public functions.
579
- const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
580
- const numTxs = buildResult.status === 'no-valid-txs' ? 0 : buildResult.numTxs;
581
- if (buildResult.status === 'no-valid-txs' || (!forceCreate && numTxs < minValidTxs)) {
1102
+ if (buildResult.status === 'insufficient-valid-txs') {
1103
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1104
+ reason: 'insufficient_valid_txs',
1105
+ slot: this.targetSlot,
1106
+ checkpointNumber: this.checkpointNumber,
1107
+ blockNumber,
1108
+ numTxs: buildResult.processedCount,
1109
+ indexWithinCheckpoint,
1110
+ minValidTxs,
1111
+ });
582
1112
  this.log.warn(
583
- `Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed`,
584
- { slot: this.slot, blockNumber, numTxs, indexWithinCheckpoint, minValidTxs, buildResult: buildResult.status },
1113
+ `Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`,
1114
+ {
1115
+ reason: 'insufficient_valid_txs',
1116
+ slot: this.targetSlot,
1117
+ checkpointNumber: this.checkpointNumber,
1118
+ blockNumber,
1119
+ numTxs: buildResult.processedCount,
1120
+ indexWithinCheckpoint,
1121
+ minValidTxs,
1122
+ },
585
1123
  );
586
- this.eventEmitter.emit('block-build-failed', { reason: `Insufficient valid txs`, slot: this.slot });
1124
+ this.eventEmitter.emit('block-build-failed', {
1125
+ reason: `Insufficient valid txs`,
1126
+ slot: this.targetSlot,
1127
+ });
587
1128
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
588
- return undefined;
1129
+ return { failure: 'insufficient-valid-txs' };
589
1130
  }
590
1131
 
591
1132
  // Block creation succeeded, emit stats and metrics
592
- const { publicGas, block, publicProcessorDuration, usedTxs, usedTxBlobFields, blockBuildDuration } = buildResult;
1133
+ const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
593
1134
 
594
1135
  const blockStats = {
595
1136
  eventName: 'l2-block-built',
@@ -600,33 +1141,56 @@ export class CheckpointProposalJob implements Traceable {
600
1141
 
601
1142
  const blockHash = await block.hash();
602
1143
  const txHashes = block.body.txEffects.map(tx => tx.txHash);
603
- const manaPerSec = publicGas.l2Gas / (blockBuildDuration / 1000);
1144
+ const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
604
1145
 
605
1146
  this.log.info(
606
- `Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`,
1147
+ `Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`,
607
1148
  { blockHash, txHashes, manaPerSec, ...blockStats },
608
1149
  );
609
1150
 
610
- this.eventEmitter.emit('block-proposed', { blockNumber: block.number, slot: this.slot });
611
- this.metrics.recordBuiltBlock(blockBuildDuration, publicGas.l2Gas);
1151
+ // `slot` is the target/submission slot (may be one ahead when pipelining),
1152
+ // `buildSlot` is the wall-clock slot during which the block was actually built.
1153
+ this.eventEmitter.emit('block-proposed', {
1154
+ blockNumber: block.number,
1155
+ blockHash,
1156
+ checkpointNumber: this.checkpointNumber,
1157
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1158
+ slot: this.targetSlot,
1159
+ buildSlot: this.slotNow,
1160
+ });
1161
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe(), this.targetSlot);
612
1162
 
613
- return { block, usedTxs, remainingBlobFields: maxBlobFieldsForTxs - usedTxBlobFields };
1163
+ return { block, usedTxs };
614
1164
  } catch (err: any) {
615
- this.eventEmitter.emit('block-build-failed', { reason: err.message, slot: this.slot });
616
- this.log.error(`Error building block`, err, { blockNumber, slot: this.slot });
1165
+ this.eventEmitter.emit('block-build-failed', {
1166
+ reason: err.message,
1167
+ slot: this.targetSlot,
1168
+ });
1169
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1170
+ reason: err instanceof Error ? err.message : String(err),
1171
+ slot: this.targetSlot,
1172
+ checkpointNumber: this.checkpointNumber,
1173
+ blockNumber,
1174
+ });
1175
+ this.log.error(`Error building block`, err, {
1176
+ reason: err instanceof Error ? err.message : String(err),
1177
+ slot: this.targetSlot,
1178
+ checkpointNumber: this.checkpointNumber,
1179
+ blockNumber,
1180
+ });
617
1181
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
618
1182
  this.metrics.recordFailedBlock();
619
1183
  return { error: err };
620
1184
  }
621
1185
  }
622
1186
 
623
- /** Uses the checkpoint builder to build a block, catching specific txs */
1187
+ /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */
624
1188
  private async buildSingleBlockWithCheckpointBuilder(
625
1189
  checkpointBuilder: CheckpointBuilder,
626
1190
  pendingTxs: AsyncIterable<Tx>,
627
1191
  blockNumber: BlockNumber,
628
1192
  blockTimestamp: bigint,
629
- blockBuilderOptions: PublicProcessorLimits,
1193
+ blockBuilderOptions: BlockBuilderOptions,
630
1194
  ) {
631
1195
  try {
632
1196
  const workTimer = new Timer();
@@ -634,8 +1198,12 @@ export class CheckpointProposalJob implements Traceable {
634
1198
  const blockBuildDuration = workTimer.ms();
635
1199
  return { ...result, blockBuildDuration, status: 'success' as const };
636
1200
  } catch (err: unknown) {
637
- if (isErrorClass(err, NoValidTxsError)) {
638
- return { failedTxs: err.failedTxs, status: 'no-valid-txs' as const };
1201
+ if (isErrorClass(err, InsufficientValidTxsError)) {
1202
+ return {
1203
+ failedTxs: err.failedTxs,
1204
+ processedCount: err.processedCount,
1205
+ status: 'insufficient-valid-txs' as const,
1206
+ };
639
1207
  }
640
1208
  throw err;
641
1209
  }
@@ -648,7 +1216,7 @@ export class CheckpointProposalJob implements Traceable {
648
1216
  blockNumber: BlockNumber;
649
1217
  indexWithinCheckpoint: IndexWithinCheckpoint;
650
1218
  buildDeadline: Date | undefined;
651
- }): Promise<{ canStartBuilding: boolean; availableTxs: number }> {
1219
+ }): Promise<{ canStartBuilding: boolean; availableTxs: number; minTxs: number }> {
652
1220
  const { indexWithinCheckpoint, blockNumber, buildDeadline, forceCreate } = opts;
653
1221
 
654
1222
  // We only allow a block with 0 txs in the first block of the checkpoint
@@ -665,20 +1233,50 @@ export class CheckpointProposalJob implements Traceable {
665
1233
  // If we're past deadline, or we have no deadline, give up
666
1234
  const now = this.dateProvider.nowAsDate();
667
1235
  if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
668
- return { canStartBuilding: false, availableTxs: availableTxs };
1236
+ return { canStartBuilding: false, availableTxs, minTxs };
669
1237
  }
670
1238
 
671
1239
  // Wait a bit before checking again
672
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.slot);
1240
+ this.setStateFn(SequencerState.WAITING_FOR_TXS, this.targetSlot, this.slotNow);
673
1241
  this.log.verbose(
674
- `Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (have ${availableTxs} but need ${minTxs})`,
675
- { blockNumber, slot: this.slot, indexWithinCheckpoint },
1242
+ `Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (have ${availableTxs} but need ${minTxs})`,
1243
+ { blockNumber, slot: this.targetSlot, indexWithinCheckpoint },
676
1244
  );
677
- await sleep(TXS_POLLING_MS);
1245
+ await this.waitForTxsPollingInterval();
678
1246
  availableTxs = await this.p2pClient.getPendingTxCount();
679
1247
  }
680
1248
 
681
- return { canStartBuilding: true, availableTxs };
1249
+ return { canStartBuilding: true, availableTxs, minTxs };
1250
+ }
1251
+
1252
+ private async getSignedCommitteeAttestations(
1253
+ broadcast: CheckpointProposalBroadcast,
1254
+ ): Promise<{ attestations: CommitteeAttestationsAndSigners; attestationsSignature: Signature } | undefined> {
1255
+ const { proposal, blockProposedAt } = broadcast;
1256
+ this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.targetSlot, this.slotNow);
1257
+ const attestations = await this.waitForAttestations(proposal);
1258
+ if (!attestations) {
1259
+ return undefined;
1260
+ }
1261
+ this.checkpointMetrics.recordCheckpointAttestationDelay(this.dateProvider.now() - blockProposedAt);
1262
+
1263
+ // Proposer must sign over the attestations before pushing them to L1
1264
+ const signer = this.proposer ?? this.publisher.getSenderAddress();
1265
+ try {
1266
+ const attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
1267
+ attestations,
1268
+ signer,
1269
+ this.targetSlot,
1270
+ this.checkpointNumber,
1271
+ );
1272
+ return { attestations, attestationsSignature };
1273
+ } catch (err) {
1274
+ if (this.handleHASigningError(err, 'Attestations signature')) {
1275
+ return;
1276
+ }
1277
+ this.log.error(`Error signing attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
1278
+ return undefined;
1279
+ }
682
1280
  }
683
1281
 
684
1282
  /**
@@ -686,10 +1284,12 @@ export class CheckpointProposalJob implements Traceable {
686
1284
  * This is run after all blocks for the checkpoint have been built.
687
1285
  */
688
1286
  @trackSpan('CheckpointProposalJob.waitForAttestations')
689
- private async waitForAttestations(proposal: CheckpointProposal): Promise<CommitteeAttestationsAndSigners> {
1287
+ private async waitForAttestations(
1288
+ proposal: CheckpointProposal,
1289
+ ): Promise<CommitteeAttestationsAndSigners | undefined> {
690
1290
  if (this.config.fishermanMode) {
691
1291
  this.log.debug('Skipping attestation collection in fisherman mode');
692
- return CommitteeAttestationsAndSigners.empty();
1292
+ return CommitteeAttestationsAndSigners.empty(this.getSignatureContext());
693
1293
  }
694
1294
 
695
1295
  const slotNumber = proposal.slotNumber;
@@ -699,21 +1299,27 @@ export class CheckpointProposalJob implements Traceable {
699
1299
  throw new Error('No committee when collecting attestations');
700
1300
  } else if (committee.length === 0) {
701
1301
  this.log.verbose(`Attesting committee is empty`);
702
- return CommitteeAttestationsAndSigners.empty();
1302
+ return CommitteeAttestationsAndSigners.empty(this.getSignatureContext());
703
1303
  } else {
704
1304
  this.log.debug(`Attesting committee length is ${committee.length}`, { committee });
705
1305
  }
706
1306
 
707
- const numberOfRequiredAttestations = Math.floor((committee.length * 2) / 3) + 1;
1307
+ const numberOfRequiredAttestations = computeQuorum(committee.length);
708
1308
 
709
1309
  if (this.config.skipCollectingAttestations) {
710
1310
  this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
711
- const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
712
- return new CommitteeAttestationsAndSigners(orderAttestations(attestations ?? [], committee));
1311
+ const attestations = await this.validatorClient?.collectOwnAttestations(proposal, this.checkpointNumber);
1312
+ this.logCheckpointAttestations('collected', committee, attestations ?? [], numberOfRequiredAttestations, {
1313
+ reason: 'collect_own_only',
1314
+ });
1315
+ return new CommitteeAttestationsAndSigners(
1316
+ orderAttestations(attestations ?? [], committee),
1317
+ this.getSignatureContext(),
1318
+ );
713
1319
  }
714
1320
 
715
1321
  const attestationTimeAllowed = this.config.enforceTimeTable
716
- ? this.timetable.getMaxAllowedTime(SequencerState.PUBLISHING_CHECKPOINT)!
1322
+ ? this.timetable.getCheckpointAttestationDeadline()
717
1323
  : this.l1Constants.slotDuration;
718
1324
  const attestationDeadline = new Date((this.getSlotStartBuildTimestamp() + attestationTimeAllowed) * 1000);
719
1325
 
@@ -726,29 +1332,89 @@ export class CheckpointProposalJob implements Traceable {
726
1332
  proposal,
727
1333
  numberOfRequiredAttestations,
728
1334
  attestationDeadline,
1335
+ this.checkpointNumber,
729
1336
  );
730
1337
 
731
1338
  collectedAttestationsCount = attestations.length;
732
1339
 
1340
+ // Trim attestations to minimum required to save L1 calldata gas
1341
+ const localAddresses = this.validatorClient.getValidatorAddresses();
1342
+ const trimmed = trimAttestations(
1343
+ attestations,
1344
+ numberOfRequiredAttestations,
1345
+ this.attestorAddress,
1346
+ localAddresses,
1347
+ );
1348
+ if (trimmed.length < attestations.length) {
1349
+ this.log.debug(`Trimmed attestations from ${attestations.length} to ${trimmed.length} for L1 submission`);
1350
+ }
1351
+
733
1352
  // Rollup contract requires that the signatures are provided in the order of the committee
734
- const sorted = orderAttestations(attestations, committee);
1353
+ const sorted = orderAttestations(trimmed, committee);
1354
+ this.logCheckpointAttestations('collected', committee, attestations, numberOfRequiredAttestations, {
1355
+ submittedCount: trimmed.length,
1356
+ });
735
1357
 
736
1358
  // Manipulate the attestations if we've been configured to do so
737
- if (this.config.injectFakeAttestation || this.config.shuffleAttestationOrdering) {
1359
+ if (
1360
+ this.config.injectFakeAttestation ||
1361
+ this.config.injectHighSValueAttestation ||
1362
+ this.config.injectUnrecoverableSignatureAttestation ||
1363
+ this.config.shuffleAttestationOrdering
1364
+ ) {
738
1365
  return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
739
1366
  }
740
1367
 
741
- return new CommitteeAttestationsAndSigners(sorted);
1368
+ return new CommitteeAttestationsAndSigners(sorted, this.getSignatureContext());
742
1369
  } catch (err) {
743
1370
  if (err && err instanceof AttestationTimeoutError) {
744
1371
  collectedAttestationsCount = err.collectedCount;
1372
+ this.logCheckpointAttestations('failed', committee, undefined, numberOfRequiredAttestations, {
1373
+ collectedCount: collectedAttestationsCount,
1374
+ reason: 'timeout',
1375
+ });
1376
+ this.log.error(
1377
+ `Timeout while waiting for attestations for checkpoint proposal at slot ${proposal.slotNumber} (collected ${collectedAttestationsCount}/${numberOfRequiredAttestations})`,
1378
+ err,
1379
+ );
1380
+ } else {
1381
+ this.logCheckpointAttestations('failed', committee, undefined, numberOfRequiredAttestations, {
1382
+ collectedCount: collectedAttestationsCount,
1383
+ reason: err instanceof Error ? err.message : String(err),
1384
+ });
1385
+ this.log.error(`Error collecting attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
745
1386
  }
746
- throw err;
1387
+ return undefined;
747
1388
  } finally {
748
1389
  this.metrics.recordCollectedAttestations(collectedAttestationsCount, collectAttestationsTimer.ms());
749
1390
  }
750
1391
  }
751
1392
 
1393
+ private logCheckpointAttestations(
1394
+ status: 'collected' | 'failed',
1395
+ committee: EthAddress[],
1396
+ attestations: CheckpointAttestation[] | undefined,
1397
+ requiredAttestations: number,
1398
+ opts: { collectedCount?: number; submittedCount?: number; reason?: string } = {},
1399
+ ) {
1400
+ const signedValidators =
1401
+ attestations
1402
+ ?.map(attestation => attestation.getSender()?.toString())
1403
+ .filter((address): address is `0x${string}` => address !== undefined) ?? [];
1404
+ const collectedCount = opts.collectedCount ?? new Set(signedValidators).size;
1405
+ const missingValidatorCount = status === 'failed' ? Math.max(0, requiredAttestations - collectedCount) : undefined;
1406
+ this.logCheckpointEvent(`attestations-${status}`, `Checkpoint attestations ${status} for slot ${this.targetSlot}`, {
1407
+ slot: this.targetSlot,
1408
+ checkpointNumber: this.checkpointNumber,
1409
+ committeeSize: committee.length,
1410
+ requiredAttestations,
1411
+ collectedAttestations: collectedCount,
1412
+ ...(opts.submittedCount !== undefined && { submittedAttestations: opts.submittedCount }),
1413
+ ...(missingValidatorCount !== undefined && { missingValidatorCount }),
1414
+ ...(opts.reason !== undefined && { reason: opts.reason }),
1415
+ });
1416
+ }
1417
+
752
1418
  /** Breaks the attestations before publishing based on attack configs */
753
1419
  private manipulateAttestations(
754
1420
  slotNumber: SlotNumber,
@@ -763,7 +1429,11 @@ export class CheckpointProposalJob implements Traceable {
763
1429
  this.epochCache.computeProposerIndex(slotNumber, epoch, seed, BigInt(committee.length)),
764
1430
  );
765
1431
 
766
- if (this.config.injectFakeAttestation) {
1432
+ if (
1433
+ this.config.injectFakeAttestation ||
1434
+ this.config.injectHighSValueAttestation ||
1435
+ this.config.injectUnrecoverableSignatureAttestation
1436
+ ) {
767
1437
  // Find non-empty attestations that are not from the proposer
768
1438
  const nonProposerIndices: number[] = [];
769
1439
  for (let i = 0; i < attestations.length; i++) {
@@ -773,27 +1443,48 @@ export class CheckpointProposalJob implements Traceable {
773
1443
  }
774
1444
  if (nonProposerIndices.length > 0) {
775
1445
  const targetIndex = nonProposerIndices[randomInt(nonProposerIndices.length)];
776
- this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
777
- unfreeze(attestations[targetIndex]).signature = Signature.random();
1446
+ if (this.config.injectHighSValueAttestation) {
1447
+ this.log.warn(
1448
+ `Injecting high-s value attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`,
1449
+ );
1450
+ unfreeze(attestations[targetIndex]).signature = flipSignature(attestations[targetIndex].signature);
1451
+ } else if (this.config.injectUnrecoverableSignatureAttestation) {
1452
+ this.log.warn(
1453
+ `Injecting unrecoverable signature attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`,
1454
+ );
1455
+ unfreeze(attestations[targetIndex]).signature = generateUnrecoverableSignature();
1456
+ } else {
1457
+ this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1458
+ unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
1459
+ }
778
1460
  }
779
- return new CommitteeAttestationsAndSigners(attestations);
1461
+ return new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext());
780
1462
  }
781
1463
 
782
1464
  if (this.config.shuffleAttestationOrdering) {
783
1465
  this.log.warn(`Shuffling attestation ordering in checkpoint for slot ${slotNumber} (proposer #${proposerIndex})`);
784
1466
 
785
1467
  const shuffled = [...attestations];
786
- const [i, j] = [(proposerIndex + 1) % shuffled.length, (proposerIndex + 2) % shuffled.length];
787
- const valueI = shuffled[i];
788
- const valueJ = shuffled[j];
789
- shuffled[i] = valueJ;
790
- shuffled[j] = valueI;
791
1468
 
792
- const signers = new CommitteeAttestationsAndSigners(attestations).getSigners();
793
- return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers);
1469
+ // Find two non-proposer positions that both have non-empty signatures to swap.
1470
+ // This ensures the bitmap doesn't change, so the MaliciousCommitteeAttestationsAndSigners
1471
+ // signers array stays correctly aligned with L1's committee reconstruction.
1472
+ const swappable: number[] = [];
1473
+ for (let k = 0; k < shuffled.length; k++) {
1474
+ if (!shuffled[k].signature.isEmpty() && k !== proposerIndex) {
1475
+ swappable.push(k);
1476
+ }
1477
+ }
1478
+ if (swappable.length >= 2) {
1479
+ const [i, j] = [swappable[0], swappable[1]];
1480
+ [shuffled[i], shuffled[j]] = [shuffled[j], shuffled[i]];
1481
+ }
1482
+
1483
+ const signers = new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext()).getSigners();
1484
+ return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers, this.getSignatureContext());
794
1485
  }
795
1486
 
796
- return new CommitteeAttestationsAndSigners(attestations);
1487
+ return new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext());
797
1488
  }
798
1489
 
799
1490
  private async dropFailedTxsFromP2P(failedTxs: FailedTx[]) {
@@ -803,16 +1494,20 @@ export class CheckpointProposalJob implements Traceable {
803
1494
  const failedTxData = failedTxs.map(fail => fail.tx);
804
1495
  const failedTxHashes = failedTxData.map(tx => tx.getTxHash());
805
1496
  this.log.verbose(`Dropping failed txs ${failedTxHashes.join(', ')}`);
806
- await this.p2pClient.deleteTxs(failedTxHashes);
1497
+ await this.p2pClient.handleFailedExecution(failedTxHashes);
807
1498
  }
808
1499
 
809
1500
  /**
810
1501
  * Adds the proposed block to the archiver so it's available via P2P.
811
1502
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
812
1503
  * would never receive its own block without this explicit sync.
1504
+ *
1505
+ * In fisherman mode we skip this push: the fisherman builds blocks locally for validation
1506
+ * and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
1507
+ * whenever the real proposer's block arrives from L1.
813
1508
  */
814
1509
  private async syncProposedBlockToArchiver(block: L2Block): Promise<void> {
815
- if (this.config.skipPushProposedBlocksToArchiver !== false) {
1510
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
816
1511
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
817
1512
  blockNumber: block.number,
818
1513
  slot: block.header.globalVariables.slotNumber,
@@ -826,41 +1521,104 @@ export class CheckpointProposalJob implements Traceable {
826
1521
  await this.blockSink.addBlock(block);
827
1522
  }
828
1523
 
1524
+ /**
1525
+ * Adds the proposed checkpoint to the archiver so the proposer's optimistic proposed-checkpoint
1526
+ * tip advances locally. Gossip doesn't echo our own messages back, so without this the proposer
1527
+ * would never see its own proposed checkpoint and couldn't pipeline the next slot.
1528
+ *
1529
+ * Skipped whenever proposed blocks aren't pushed (`skipPushProposedBlocksToArchiver`, fisherman
1530
+ * mode): the archiver derives the checkpoint archive from its stored blocks, so without them the
1531
+ * push would fail. All blocks were already added (and awaited) during block building, so this
1532
+ * needs no retry — they are guaranteed present by the time we get here.
1533
+ */
1534
+ private async syncProposedCheckpointToArchiver(
1535
+ checkpoint: Checkpoint,
1536
+ blockCount: number,
1537
+ feeAssetPriceModifier: bigint,
1538
+ ): Promise<void> {
1539
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
1540
+ return;
1541
+ }
1542
+ const startBlock = BlockNumber(this.syncedToBlockNumber + 1);
1543
+ this.log.debug(`Syncing proposed checkpoint ${this.checkpointNumber} to archiver`, {
1544
+ checkpointNumber: this.checkpointNumber,
1545
+ slot: this.targetSlot,
1546
+ startBlock,
1547
+ blockCount,
1548
+ });
1549
+ await this.blockSink.addProposedCheckpoint({
1550
+ header: checkpoint.header,
1551
+ checkpointNumber: this.checkpointNumber,
1552
+ startBlock,
1553
+ blockCount,
1554
+ totalManaUsed: checkpoint.header.totalManaUsed.toBigInt(),
1555
+ feeAssetPriceModifier,
1556
+ });
1557
+ }
1558
+
829
1559
  /** Runs fee analysis and logs checkpoint outcome as fisherman */
830
1560
  private async handleCheckpointEndAsFisherman(checkpoint: Checkpoint | undefined) {
831
1561
  // Perform L1 fee analysis before clearing requests
832
1562
  // The callback is invoked asynchronously after the next block is mined
833
- const feeAnalysis = await this.publisher.analyzeL1Fees(this.slot, analysis =>
1563
+ const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, analysis =>
834
1564
  this.metrics.recordFishermanFeeAnalysis(analysis),
835
1565
  );
836
1566
 
837
1567
  if (checkpoint) {
838
- this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.slot}`, {
1568
+ this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
839
1569
  ...checkpoint.toCheckpointInfo(),
840
1570
  ...checkpoint.getStats(),
841
1571
  feeAnalysisId: feeAnalysis?.id,
842
1572
  });
843
1573
  } else {
844
- this.log.warn(`Validation block building FAILED for slot ${this.slot}`, {
845
- slot: this.slot,
1574
+ this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
1575
+ slot: this.targetSlot,
846
1576
  feeAnalysisId: feeAnalysis?.id,
847
1577
  });
848
- this.metrics.recordBlockProposalFailed('block_build_failed');
1578
+ this.metrics.recordCheckpointProposalFailed('block_build_failed');
849
1579
  }
850
1580
 
851
1581
  this.publisher.clearPendingRequests();
852
1582
  }
853
1583
 
1584
+ /**
1585
+ * Helper to handle HA double-signing errors. Returns true if the error was handled (caller should yield).
1586
+ */
1587
+ private handleHASigningError(err: any, errorContext: string): boolean {
1588
+ if (err instanceof DutyAlreadySignedError) {
1589
+ this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
1590
+ slot: this.targetSlot,
1591
+ signedByNode: err.signedByNode,
1592
+ });
1593
+ return true;
1594
+ }
1595
+ if (err instanceof SlashingProtectionError) {
1596
+ this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
1597
+ slot: this.targetSlot,
1598
+ existingMessageHash: err.existingMessageHash,
1599
+ attemptedMessageHash: err.attemptedMessageHash,
1600
+ });
1601
+ return true;
1602
+ }
1603
+ return false;
1604
+ }
1605
+
854
1606
  /** Waits until a specific time within the current slot */
855
1607
  @trackSpan('CheckpointProposalJob.waitUntilTimeInSlot')
856
1608
  protected async waitUntilTimeInSlot(targetSecondsIntoSlot: number): Promise<void> {
857
1609
  const slotStartTimestamp = this.getSlotStartBuildTimestamp();
858
1610
  const targetTimestamp = slotStartTimestamp + targetSecondsIntoSlot;
859
- await sleepUntil(new Date(targetTimestamp * 1000), this.dateProvider.nowAsDate());
1611
+ const delayMs = targetTimestamp * 1000 - this.dateProvider.nowAsDate().getTime();
1612
+ await this.awaitInterruptibleSleep(delayMs);
1613
+ }
1614
+
1615
+ /** Pause between mempool polls in waitForMinTxs. Extracted for test overriding. */
1616
+ protected async waitForTxsPollingInterval(): Promise<void> {
1617
+ await this.awaitInterruptibleSleep(TXS_POLLING_MS);
860
1618
  }
861
1619
 
862
1620
  private getSlotStartBuildTimestamp(): number {
863
- return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
1621
+ return getSlotStartBuildTimestamp(this.slotNow, this.l1Constants);
864
1622
  }
865
1623
 
866
1624
  private getSecondsIntoSlot(): number {