@aztec/sequencer-client 0.0.1-commit.d6f2b3f94 → 0.0.1-commit.d939eb5aa

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (103) hide show
  1. package/dest/client/sequencer-client.d.ts +17 -7
  2. package/dest/client/sequencer-client.d.ts.map +1 -1
  3. package/dest/client/sequencer-client.js +63 -30
  4. package/dest/config.d.ts +26 -6
  5. package/dest/config.d.ts.map +1 -1
  6. package/dest/config.js +49 -29
  7. package/dest/global_variable_builder/fee_predictor.d.ts +37 -0
  8. package/dest/global_variable_builder/fee_predictor.d.ts.map +1 -0
  9. package/dest/global_variable_builder/fee_predictor.js +128 -0
  10. package/dest/global_variable_builder/fee_provider.d.ts +21 -0
  11. package/dest/global_variable_builder/fee_provider.d.ts.map +1 -0
  12. package/dest/global_variable_builder/fee_provider.js +58 -0
  13. package/dest/global_variable_builder/global_builder.d.ts +15 -16
  14. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  15. package/dest/global_variable_builder/global_builder.js +16 -50
  16. package/dest/global_variable_builder/index.d.ts +4 -2
  17. package/dest/global_variable_builder/index.d.ts.map +1 -1
  18. package/dest/global_variable_builder/index.js +2 -0
  19. package/dest/publisher/config.d.ts +47 -17
  20. package/dest/publisher/config.d.ts.map +1 -1
  21. package/dest/publisher/config.js +121 -42
  22. package/dest/publisher/index.d.ts +2 -1
  23. package/dest/publisher/index.d.ts.map +1 -1
  24. package/dest/publisher/l1_tx_failed_store/factory.d.ts +11 -0
  25. package/dest/publisher/l1_tx_failed_store/factory.d.ts.map +1 -0
  26. package/dest/publisher/l1_tx_failed_store/factory.js +22 -0
  27. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +58 -0
  28. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -0
  29. package/dest/publisher/l1_tx_failed_store/failed_tx_store.js +1 -0
  30. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts +15 -0
  31. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts.map +1 -0
  32. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.js +34 -0
  33. package/dest/publisher/l1_tx_failed_store/index.d.ts +4 -0
  34. package/dest/publisher/l1_tx_failed_store/index.d.ts.map +1 -0
  35. package/dest/publisher/l1_tx_failed_store/index.js +2 -0
  36. package/dest/publisher/sequencer-publisher-factory.d.ts +11 -5
  37. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  38. package/dest/publisher/sequencer-publisher-factory.js +27 -3
  39. package/dest/publisher/sequencer-publisher.d.ts +75 -48
  40. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  41. package/dest/publisher/sequencer-publisher.js +432 -139
  42. package/dest/sequencer/chain_state_overrides.d.ts +25 -0
  43. package/dest/sequencer/chain_state_overrides.d.ts.map +1 -0
  44. package/dest/sequencer/chain_state_overrides.js +39 -0
  45. package/dest/sequencer/checkpoint_proposal_job.d.ts +26 -9
  46. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  47. package/dest/sequencer/checkpoint_proposal_job.js +376 -212
  48. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts +34 -0
  49. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts.map +1 -0
  50. package/dest/sequencer/checkpoint_proposal_job_metrics.js +72 -0
  51. package/dest/sequencer/checkpoint_voter.d.ts +1 -2
  52. package/dest/sequencer/checkpoint_voter.d.ts.map +1 -1
  53. package/dest/sequencer/checkpoint_voter.js +2 -5
  54. package/dest/sequencer/events.d.ts +2 -1
  55. package/dest/sequencer/events.d.ts.map +1 -1
  56. package/dest/sequencer/metrics.d.ts +19 -8
  57. package/dest/sequencer/metrics.d.ts.map +1 -1
  58. package/dest/sequencer/metrics.js +95 -21
  59. package/dest/sequencer/sequencer.d.ts +43 -17
  60. package/dest/sequencer/sequencer.d.ts.map +1 -1
  61. package/dest/sequencer/sequencer.js +158 -97
  62. package/dest/sequencer/timetable.d.ts +17 -3
  63. package/dest/sequencer/timetable.d.ts.map +1 -1
  64. package/dest/sequencer/timetable.js +51 -43
  65. package/dest/sequencer/types.d.ts +2 -2
  66. package/dest/sequencer/types.d.ts.map +1 -1
  67. package/dest/test/index.d.ts +3 -5
  68. package/dest/test/index.d.ts.map +1 -1
  69. package/dest/test/mock_checkpoint_builder.d.ts +11 -11
  70. package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
  71. package/dest/test/mock_checkpoint_builder.js +45 -34
  72. package/dest/test/utils.d.ts +3 -3
  73. package/dest/test/utils.d.ts.map +1 -1
  74. package/dest/test/utils.js +5 -4
  75. package/package.json +27 -28
  76. package/src/client/sequencer-client.ts +81 -30
  77. package/src/config.ts +61 -35
  78. package/src/global_variable_builder/README.md +44 -0
  79. package/src/global_variable_builder/fee_predictor.ts +172 -0
  80. package/src/global_variable_builder/fee_provider.ts +75 -0
  81. package/src/global_variable_builder/global_builder.ts +27 -63
  82. package/src/global_variable_builder/index.ts +3 -1
  83. package/src/publisher/config.ts +157 -45
  84. package/src/publisher/index.ts +3 -0
  85. package/src/publisher/l1_tx_failed_store/factory.ts +32 -0
  86. package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +57 -0
  87. package/src/publisher/l1_tx_failed_store/file_store_failed_tx_store.ts +46 -0
  88. package/src/publisher/l1_tx_failed_store/index.ts +3 -0
  89. package/src/publisher/sequencer-publisher-factory.ts +38 -9
  90. package/src/publisher/sequencer-publisher.ts +499 -198
  91. package/src/sequencer/README.md +83 -13
  92. package/src/sequencer/chain_state_overrides.ts +87 -0
  93. package/src/sequencer/checkpoint_proposal_job.ts +492 -232
  94. package/src/sequencer/checkpoint_proposal_job_metrics.ts +128 -0
  95. package/src/sequencer/checkpoint_voter.ts +1 -12
  96. package/src/sequencer/events.ts +1 -1
  97. package/src/sequencer/metrics.ts +104 -26
  98. package/src/sequencer/sequencer.ts +227 -109
  99. package/src/sequencer/timetable.ts +64 -52
  100. package/src/sequencer/types.ts +1 -1
  101. package/src/test/index.ts +2 -4
  102. package/src/test/mock_checkpoint_builder.ts +63 -49
  103. package/src/test/utils.ts +5 -2
@@ -1,6 +1,5 @@
1
- import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
2
- import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
3
1
  import type { EpochCache } from '@aztec/epoch-cache';
2
+ import type { SimulationOverridesPlan } from '@aztec/ethereum/contracts';
4
3
  import {
5
4
  BlockNumber,
6
5
  CheckpointNumber,
@@ -9,6 +8,11 @@ import {
9
8
  SlotNumber,
10
9
  } from '@aztec/foundation/branded-types';
11
10
  import { randomInt } from '@aztec/foundation/crypto/random';
11
+ import {
12
+ flipSignature,
13
+ generateRecoverableSignature,
14
+ generateUnrecoverableSignature,
15
+ } from '@aztec/foundation/crypto/secp256k1-signer';
12
16
  import { Fr } from '@aztec/foundation/curves/bn254';
13
17
  import { EthAddress } from '@aztec/foundation/eth-address';
14
18
  import { Signature } from '@aztec/foundation/eth-signature';
@@ -27,18 +31,23 @@ import {
27
31
  type L2BlockSource,
28
32
  MaliciousCommitteeAttestationsAndSigners,
29
33
  } from '@aztec/stdlib/block';
30
- import type { Checkpoint } from '@aztec/stdlib/checkpoint';
31
- import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
34
+ import { type Checkpoint, type ProposedCheckpointData, validateCheckpoint } from '@aztec/stdlib/checkpoint';
35
+ import { computeQuorum, getSlotStartBuildTimestamp, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
32
36
  import { Gas } from '@aztec/stdlib/gas';
33
37
  import {
34
- NoValidTxsError,
35
- type PublicProcessorLimits,
38
+ type BlockBuilderOptions,
39
+ InsufficientValidTxsError,
36
40
  type ResolvedSequencerConfig,
37
41
  type WorldStateSynchronizer,
38
42
  } from '@aztec/stdlib/interfaces/server';
39
43
  import { type L1ToL2MessageSource, computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
40
- import type { BlockProposalOptions, CheckpointProposal, CheckpointProposalOptions } from '@aztec/stdlib/p2p';
41
- import { orderAttestations } from '@aztec/stdlib/p2p';
44
+ import type {
45
+ BlockProposal,
46
+ BlockProposalOptions,
47
+ CheckpointProposal,
48
+ CheckpointProposalOptions,
49
+ } from '@aztec/stdlib/p2p';
50
+ import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
42
51
  import type { L2BlockBuiltStats } from '@aztec/stdlib/stats';
43
52
  import { type FailedTx, Tx } from '@aztec/stdlib/tx';
44
53
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
@@ -48,6 +57,11 @@ import { DutyAlreadySignedError, SlashingProtectionError } from '@aztec/validato
48
57
 
49
58
  import type { GlobalVariableBuilder } from '../global_variable_builder/global_builder.js';
50
59
  import type { InvalidateCheckpointRequest, SequencerPublisher } from '../publisher/sequencer-publisher.js';
60
+ import {
61
+ buildPipelinedParentSimulationOverridesPlan,
62
+ buildSubmissionSimulationOverridesPlan,
63
+ } from './chain_state_overrides.js';
64
+ import type { CheckpointProposalJobMetricsRecorder } from './checkpoint_proposal_job_metrics.js';
51
65
  import { CheckpointVoter } from './checkpoint_voter.js';
52
66
  import { SequencerInterruptedError } from './errors.js';
53
67
  import type { SequencerEvents } from './events.js';
@@ -59,6 +73,20 @@ import { SequencerState } from './utils.js';
59
73
  /** How much time to sleep while waiting for min transactions to accumulate for a block */
60
74
  const TXS_POLLING_MS = 500;
61
75
 
76
+ /** Result from proposeCheckpoint when a checkpoint was successfully built and broadcast. */
77
+ type CheckpointProposalBroadcast = {
78
+ checkpoint: Checkpoint;
79
+ proposal: CheckpointProposal;
80
+ blockProposedAt: number;
81
+ };
82
+
83
+ /** Result after attestation collection and signing, ready for L1 submission. */
84
+ type CheckpointProposalResult = {
85
+ checkpoint: Checkpoint;
86
+ attestations: CommitteeAttestationsAndSigners;
87
+ attestationsSignature: Signature;
88
+ };
89
+
62
90
  /**
63
91
  * Handles the execution of a checkpoint proposal after the initial preparation phase.
64
92
  * This includes building blocks, collecting attestations, and publishing the checkpoint to L1,
@@ -68,9 +96,16 @@ const TXS_POLLING_MS = 500;
68
96
  export class CheckpointProposalJob implements Traceable {
69
97
  protected readonly log: Logger;
70
98
 
99
+ /** Tracks the fire-and-forget L1 submission promise so it can be awaited during shutdown. */
100
+ private pendingL1Submission: Promise<void> | undefined;
101
+
102
+ /** Pipelined parent chain state used while building and later submitting this checkpoint. */
103
+ private pipelinedParentSimulationOverridesPlan?: SimulationOverridesPlan;
104
+
71
105
  constructor(
72
- private readonly epoch: EpochNumber,
73
- private readonly slot: SlotNumber,
106
+ private readonly slotNow: SlotNumber,
107
+ private readonly targetSlot: SlotNumber,
108
+ private readonly targetEpoch: EpochNumber,
74
109
  private readonly checkpointNumber: CheckpointNumber,
75
110
  private readonly syncedToBlockNumber: BlockNumber,
76
111
  // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
@@ -93,17 +128,31 @@ export class CheckpointProposalJob implements Traceable {
93
128
  private readonly epochCache: EpochCache,
94
129
  private readonly dateProvider: DateProvider,
95
130
  private readonly metrics: SequencerMetrics,
131
+ private readonly checkpointMetrics: CheckpointProposalJobMetricsRecorder,
96
132
  private readonly eventEmitter: TypedEventEmitter<SequencerEvents>,
97
133
  private readonly setStateFn: (state: SequencerState, slot?: SlotNumber) => void,
98
134
  public readonly tracer: Tracer,
99
135
  bindings?: LoggerBindings,
136
+ private readonly proposedCheckpointData?: ProposedCheckpointData,
100
137
  ) {
101
- this.log = createLogger('sequencer:checkpoint-proposal', { ...bindings, instanceId: `slot-${slot}` });
138
+ this.log = createLogger('sequencer:checkpoint-proposal', {
139
+ ...bindings,
140
+ instanceId: `slot-${this.slotNow}`,
141
+ });
142
+ }
143
+
144
+ /** Awaits the pending L1 submission if one is in progress. Call during shutdown. */
145
+ public async awaitPendingSubmission(): Promise<void> {
146
+ this.log.info('Awaiting pending L1 payload submission');
147
+ await this.pendingL1Submission;
102
148
  }
103
149
 
104
150
  /**
105
151
  * Executes the checkpoint proposal job.
106
- * Returns the published checkpoint if successful, undefined otherwise.
152
+ * Builds blocks, assembles checkpoint, and broadcasts the proposal (blocking).
153
+ * Attestation collection, signing, and L1 submission are backgrounded so the
154
+ * work loop can return to IDLE immediately for consecutive slot proposals.
155
+ * Returns the built checkpoint if successful, undefined otherwise.
107
156
  */
108
157
  @trackSpan('CheckpointProposalJob.execute')
109
158
  public async execute(): Promise<Checkpoint | undefined> {
@@ -111,7 +160,7 @@ export class CheckpointProposalJob implements Traceable {
111
160
  // In fisherman mode, we simulate slashing but don't actually publish to L1
112
161
  // These are constant for the whole slot, so we only enqueue them once
113
162
  const votesPromises = new CheckpointVoter(
114
- this.slot,
163
+ this.targetSlot,
115
164
  this.publisher,
116
165
  this.attestorAddress,
117
166
  this.validatorClient,
@@ -122,63 +171,195 @@ export class CheckpointProposalJob implements Traceable {
122
171
  this.log,
123
172
  ).enqueueVotes();
124
173
 
125
- // Build and propose the checkpoint. This will enqueue the request on the publisher if a checkpoint is built.
126
- const checkpoint = await this.proposeCheckpoint();
127
-
128
- // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
129
- await Promise.all(votesPromises);
174
+ // Build blocks, assemble checkpoint, and broadcast proposal (BLOCKING).
175
+ // Returns after broadcast — attestation collection is deferred.
176
+ const broadcast = await this.proposeCheckpoint();
130
177
 
131
- if (checkpoint) {
132
- this.metrics.recordBlockProposalSuccess();
178
+ if (!broadcast) {
179
+ await Promise.all(votesPromises);
180
+ // Still submit votes even without a checkpoint
181
+ if (!this.config.fishermanMode) {
182
+ this.pendingL1Submission = this.publisher.sendRequestsAt(this.dateProvider.nowAsDate()).then(() => {});
183
+ }
184
+ return undefined;
133
185
  }
134
186
 
187
+ const { checkpoint } = broadcast;
188
+ this.metrics.recordCheckpointProposalSuccess();
189
+
135
190
  // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
136
191
  if (this.config.fishermanMode) {
137
192
  await this.handleCheckpointEndAsFisherman(checkpoint);
138
- return;
193
+ return checkpoint;
139
194
  }
140
195
 
141
- // Then send everything to L1
142
- const l1Response = await this.publisher.sendRequests();
143
- const proposedAction = l1Response?.successfulActions.find(a => a === 'propose');
144
- if (proposedAction) {
145
- this.eventEmitter.emit('checkpoint-published', { checkpoint: this.checkpointNumber, slot: this.slot });
146
- const coinbase = checkpoint?.header.coinbase;
147
- await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
148
- return checkpoint;
149
- } else if (checkpoint) {
150
- this.eventEmitter.emit('checkpoint-publish-failed', { ...l1Response, slot: this.slot });
151
- return undefined;
196
+ // Background the attestation signing → L1 pipeline so the work loop is unblocked
197
+ this.pendingL1Submission = this.waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises);
198
+
199
+ // Return the built checkpoint immediately — the work loop is now unblocked
200
+ return checkpoint;
201
+ }
202
+
203
+ /**
204
+ * Background pipeline: collects attestations, signs them, enqueues the checkpoint, and submits to L1.
205
+ * Runs as a fire-and-forget task stored in `pendingL1Submission` so the work loop is unblocked.
206
+ */
207
+ private async waitForAttestationsAndEnqueueSubmissionAsync(
208
+ broadcast: CheckpointProposalBroadcast,
209
+ votesPromises: Promise<unknown>[],
210
+ ): Promise<void> {
211
+ const { checkpoint, proposal, blockProposedAt } = broadcast;
212
+ try {
213
+ await Promise.all(votesPromises);
214
+
215
+ this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.targetSlot);
216
+ const attestations = await this.waitForAttestations(proposal);
217
+
218
+ this.checkpointMetrics.recordCheckpointAttestationDelay(this.dateProvider.now() - blockProposedAt);
219
+
220
+ // Proposer must sign over the attestations before pushing them to L1
221
+ const signer = this.proposer ?? this.publisher.getSenderAddress();
222
+ let attestationsSignature: Signature;
223
+ try {
224
+ attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
225
+ attestations,
226
+ signer,
227
+ this.targetSlot,
228
+ this.checkpointNumber,
229
+ );
230
+ } catch (err) {
231
+ if (this.handleHASigningError(err, 'Attestations signature')) {
232
+ return;
233
+ }
234
+ throw err;
235
+ }
236
+
237
+ // Enqueue the checkpoint for L1 submission
238
+ await this.enqueueCheckpointForSubmission({ checkpoint, attestations, attestationsSignature });
239
+
240
+ // Compute the earliest time to submit: pipeline slot start when pipelining, now otherwise.
241
+ const submitAfter = this.epochCache.isProposerPipeliningEnabled()
242
+ ? new Date(Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) * 1000)
243
+ : new Date(this.dateProvider.now());
244
+
245
+ const l1Response = await this.publisher.sendRequestsAt(submitAfter);
246
+ const proposedAction = l1Response?.successfulActions.find(a => a === 'propose');
247
+ if (proposedAction) {
248
+ this.eventEmitter.emit('checkpoint-published', { checkpoint: this.checkpointNumber, slot: this.targetSlot });
249
+ const coinbase = checkpoint.header.coinbase;
250
+ await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
251
+ } else {
252
+ this.eventEmitter.emit('checkpoint-publish-failed', { ...l1Response, slot: this.targetSlot });
253
+ if (this.epochCache.isProposerPipeliningEnabled()) {
254
+ this.metrics.recordPipelineDiscard();
255
+ }
256
+ }
257
+ } catch (err) {
258
+ if (err instanceof SequencerInterruptedError) {
259
+ return;
260
+ }
261
+ this.log.error(`Background attestation/L1 pipeline failed for slot ${this.targetSlot}`, err);
262
+ this.eventEmitter.emit('checkpoint-publish-failed', { slot: this.targetSlot });
263
+ if (this.epochCache.isProposerPipeliningEnabled()) {
264
+ this.metrics.recordPipelineDiscard();
265
+ }
152
266
  }
153
267
  }
154
268
 
269
+ /** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */
270
+ private async enqueueCheckpointForSubmission(result: CheckpointProposalResult): Promise<void> {
271
+ const { checkpoint, attestations, attestationsSignature } = result;
272
+
273
+ this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.targetSlot);
274
+ const aztecSlotDuration = this.l1Constants.slotDuration;
275
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
276
+ const txTimeoutAt = new Date((submissionSlotStart + aztecSlotDuration) * 1000);
277
+
278
+ // If we have been configured to potentially skip publishing checkpoint then roll the dice here
279
+ if (
280
+ this.config.skipPublishingCheckpointsPercent !== undefined &&
281
+ this.config.skipPublishingCheckpointsPercent > 0
282
+ ) {
283
+ const roll = Math.max(0, randomInt(100));
284
+ if (roll < this.config.skipPublishingCheckpointsPercent) {
285
+ this.log.warn(
286
+ `Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${roll}`,
287
+ );
288
+ return;
289
+ }
290
+ }
291
+
292
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
293
+ const submissionSimulationOverridesPlan = buildSubmissionSimulationOverridesPlan({
294
+ pipelinedParentPlan: this.pipelinedParentSimulationOverridesPlan,
295
+ invalidateToPendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
296
+ lastArchiveRoot: checkpoint.header.lastArchiveRoot,
297
+ pipeliningEnabled: isPipelining,
298
+ });
299
+
300
+ await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
301
+ txTimeoutAt,
302
+ ...(submissionSimulationOverridesPlan ? { simulationOverridesPlan: submissionSimulationOverridesPlan } : {}),
303
+ });
304
+ }
305
+
155
306
  @trackSpan('CheckpointProposalJob.proposeCheckpoint', function () {
156
307
  return {
157
308
  // nullish operator needed for tests
158
309
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
159
- [Attributes.SLOT_NUMBER]: this.slot,
310
+ [Attributes.SLOT_NUMBER]: this.targetSlot,
160
311
  };
161
312
  })
162
- private async proposeCheckpoint(): Promise<Checkpoint | undefined> {
313
+ private async proposeCheckpoint(): Promise<CheckpointProposalBroadcast | undefined> {
163
314
  try {
315
+ const now = this.dateProvider.now();
316
+ if (this.epochCache.isProposerPipeliningEnabled() && this.proposedCheckpointData) {
317
+ // Measure against the wall-clock slot whose build window we are currently using.
318
+ // In pipelining mode `targetSlot` is intentionally one slot ahead, which makes the
319
+ // target-slot boundary a full slot away from the actual build start time.
320
+ const slotBoundaryMs = Number(getTimestampForSlot(this.slotNow, this.l1Constants)) * 1000;
321
+ this.checkpointMetrics.recordPipelinedCheckpointBuildStartOffsetFromSlotBoundary(now - slotBoundaryMs);
322
+ }
323
+ this.checkpointMetrics.startCheckpointTiming(now);
324
+
164
325
  // Get operator configured coinbase and fee recipient for this attestor
165
326
  const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
166
327
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
167
328
 
168
329
  // Start the checkpoint
169
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.slot);
170
- this.metrics.incOpenSlot(this.slot, this.proposer?.toString() ?? 'unknown');
330
+ this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.targetSlot);
331
+ this.log.info(`Starting checkpoint proposal`, {
332
+ buildSlot: this.slotNow,
333
+ submissionSlot: this.targetSlot,
334
+ pipelining: this.epochCache.isProposerPipeliningEnabled(),
335
+ proposer: this.proposer?.toString(),
336
+ coinbase: coinbase.toString(),
337
+ });
338
+ this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
171
339
 
172
340
  // Enqueues checkpoint invalidation (constant for the whole slot)
173
341
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
174
342
  this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
175
343
  }
176
344
 
177
- // Create checkpoint builder for the slot
345
+ // Create checkpoint builder for the slot.
346
+ // When pipelining, force the proposed checkpoint number and fee header to our parent so the
347
+ // fee computation sees the same chain tip that L1 will see once the previous pipelined checkpoint lands.
348
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
349
+ this.pipelinedParentSimulationOverridesPlan = isPipelining
350
+ ? await buildPipelinedParentSimulationOverridesPlan({
351
+ checkpointNumber: this.checkpointNumber,
352
+ proposedCheckpointData: this.proposedCheckpointData,
353
+ rollup: this.publisher.rollupContract,
354
+ log: this.log,
355
+ })
356
+ : undefined;
357
+
178
358
  const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(
179
359
  coinbase,
180
360
  feeRecipient,
181
- this.slot,
361
+ this.targetSlot,
362
+ this.pipelinedParentSimulationOverridesPlan,
182
363
  );
183
364
 
184
365
  // Collect L1 to L2 messages for the checkpoint and compute their hash
@@ -186,18 +367,21 @@ export class CheckpointProposalJob implements Traceable {
186
367
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
187
368
 
188
369
  // Collect the out hashes of all the checkpoints before this one in the same epoch
189
- const previousCheckpoints = (await this.l2BlockSource.getCheckpointsForEpoch(this.epoch)).filter(
190
- c => c.number < this.checkpointNumber,
191
- );
192
- const previousCheckpointOutHashes = previousCheckpoints.map(c => c.getCheckpointOutHash());
370
+ const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.targetEpoch))
371
+ .filter(c => c.checkpointNumber < this.checkpointNumber)
372
+ .map(c => c.checkpointOutHash);
373
+
374
+ // Get the fee asset price modifier from the oracle
375
+ const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier();
193
376
 
194
377
  // Create a long-lived forked world state for the checkpoint builder
195
- using fork = await this.worldState.fork(this.syncedToBlockNumber, { closeDelayMs: 12_000 });
378
+ await using fork = await this.worldState.fork(this.syncedToBlockNumber, { closeDelayMs: 12_000 });
196
379
 
197
380
  // Create checkpoint builder for the entire slot
198
381
  const checkpointBuilder = await this.checkpointsBuilder.startCheckpoint(
199
382
  this.checkpointNumber,
200
383
  checkpointGlobalVariables,
384
+ feeAssetPriceModifier,
201
385
  l1ToL2Messages,
202
386
  previousCheckpointOutHashes,
203
387
  fork,
@@ -216,7 +400,8 @@ export class CheckpointProposalJob implements Traceable {
216
400
  };
217
401
 
218
402
  let blocksInCheckpoint: L2Block[] = [];
219
- let blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined = undefined;
403
+ let blockPendingBroadcast: BlockProposal | undefined = undefined;
404
+ const checkpointBuildTimer = new Timer();
220
405
 
221
406
  try {
222
407
  // Main loop: build blocks for the checkpoint
@@ -239,93 +424,90 @@ export class CheckpointProposalJob implements Traceable {
239
424
  }
240
425
 
241
426
  if (blocksInCheckpoint.length === 0) {
242
- this.log.warn(`No blocks were built for slot ${this.slot}`, { slot: this.slot });
243
- this.eventEmitter.emit('checkpoint-empty', { slot: this.slot });
427
+ this.log.warn(`No blocks were built for slot ${this.targetSlot}`, { slot: this.targetSlot });
428
+ this.eventEmitter.emit('checkpoint-empty', { slot: this.targetSlot });
429
+ return undefined;
430
+ }
431
+
432
+ const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
433
+ if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
434
+ this.log.warn(
435
+ `Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`,
436
+ { slot: this.targetSlot, blocksBuilt: blocksInCheckpoint.length, minBlocksForCheckpoint },
437
+ );
244
438
  return undefined;
245
439
  }
246
440
 
247
441
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
248
442
  // broadcasted yet, and wait to collect the committee attestations.
249
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
443
+ this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.targetSlot);
250
444
  const checkpoint = await checkpointBuilder.completeCheckpoint();
251
445
 
252
- // Do not collect attestations nor publish to L1 in fisherman mode
446
+ // Final validation: per-block limits are only checked if the operator set them explicitly.
447
+ // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
448
+ try {
449
+ validateCheckpoint(checkpoint, {
450
+ rollupManaLimit: this.l1Constants.rollupManaLimit,
451
+ maxL2BlockGas: this.config.maxL2BlockGas,
452
+ maxDABlockGas: this.config.maxDABlockGas,
453
+ maxTxsPerBlock: this.config.maxTxsPerBlock,
454
+ maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint,
455
+ });
456
+ } catch (err) {
457
+ this.log.error(`Built an invalid checkpoint at slot ${this.slotNow} (skipping proposal)`, err, {
458
+ checkpoint: checkpoint.header.toInspect(),
459
+ });
460
+ return undefined;
461
+ }
462
+
463
+ // Record checkpoint-level build metrics
464
+ this.checkpointMetrics.recordCheckpointBuild(
465
+ checkpointBuildTimer.ms(),
466
+ blocksInCheckpoint.length,
467
+ checkpoint.getStats().txCount,
468
+ Number(checkpoint.header.totalManaUsed.toBigInt()),
469
+ );
470
+
471
+ // In fisherman mode, return the checkpoint without broadcasting or collecting attestations
253
472
  if (this.config.fishermanMode) {
254
473
  this.log.info(
255
- `Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` +
474
+ `Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` +
256
475
  `Skipping proposal in fisherman mode.`,
257
476
  {
258
- slot: this.slot,
477
+ slot: this.targetSlot,
259
478
  checkpoint: checkpoint.header.toInspect(),
260
479
  blocksBuilt: blocksInCheckpoint.length,
261
480
  },
262
481
  );
263
482
  this.metrics.recordCheckpointSuccess();
264
- return checkpoint;
483
+ // Return a broadcast result with a dummy proposal — fisherman mode skips attestation collection
484
+ return { checkpoint, proposal: undefined!, blockProposedAt: this.dateProvider.now() };
265
485
  }
266
486
 
267
- // Include the block pending broadcast in the checkpoint proposal if any
268
- const lastBlock = blockPendingBroadcast && {
269
- blockHeader: blockPendingBroadcast.block.header,
270
- indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
271
- txs: blockPendingBroadcast.txs,
272
- };
273
-
274
487
  // Create the checkpoint proposal and broadcast it
275
488
  const proposal = await this.validatorClient.createCheckpointProposal(
276
489
  checkpoint.header,
277
490
  checkpoint.archive.root,
278
- lastBlock,
491
+ this.checkpointNumber,
492
+ feeAssetPriceModifier,
493
+ blockPendingBroadcast,
279
494
  this.proposer,
280
495
  checkpointProposalOptions,
281
496
  );
282
497
 
283
498
  const blockProposedAt = this.dateProvider.now();
284
499
  await this.p2pClient.broadcastCheckpointProposal(proposal);
500
+ this.checkpointMetrics.noteCheckpointBroadcast(this.dateProvider.now());
285
501
 
286
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
287
- const attestations = await this.waitForAttestations(proposal);
288
- const blockAttestedAt = this.dateProvider.now();
289
-
290
- this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
291
-
292
- // Proposer must sign over the attestations before pushing them to L1
293
- const signer = this.proposer ?? this.publisher.getSenderAddress();
294
- let attestationsSignature: Signature;
295
- try {
296
- attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
297
- attestations,
298
- signer,
299
- this.slot,
300
- this.checkpointNumber,
301
- );
302
- } catch (err) {
303
- // We shouldn't really get here since we yield to another HA node
304
- // as soon as we see these errors when creating block or checkpoint proposals.
305
- if (this.handleHASigningError(err, 'Attestations signature')) {
306
- return undefined;
307
- }
308
- throw err;
309
- }
310
-
311
- // Enqueue publishing the checkpoint to L1
312
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
313
- const aztecSlotDuration = this.l1Constants.slotDuration;
314
- const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
315
- const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
316
- await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
317
- txTimeoutAt,
318
- forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
319
- });
320
-
321
- return checkpoint;
502
+ // Return immediately after broadcast — attestation collection happens in the background
503
+ return { checkpoint, proposal, blockProposedAt };
322
504
  } catch (err) {
323
505
  if (err && (err instanceof DutyAlreadySignedError || err instanceof SlashingProtectionError)) {
324
506
  // swallow this error. It's already been logged by a function deeper in the stack
325
507
  return undefined;
326
508
  }
327
509
 
328
- this.log.error(`Error building checkpoint at slot ${this.slot}`, err);
510
+ this.log.error(`Error building checkpoint at slot ${this.targetSlot}`, err);
329
511
  return undefined;
330
512
  }
331
513
  }
@@ -341,17 +523,14 @@ export class CheckpointProposalJob implements Traceable {
341
523
  blockProposalOptions: BlockProposalOptions,
342
524
  ): Promise<{
343
525
  blocksInCheckpoint: L2Block[];
344
- blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined;
526
+ blockPendingBroadcast: BlockProposal | undefined;
345
527
  }> {
346
528
  const blocksInCheckpoint: L2Block[] = [];
347
529
  const txHashesAlreadyIncluded = new Set<string>();
348
530
  const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
349
531
 
350
- // Remaining blob fields available for blocks (checkpoint end marker already subtracted)
351
- let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
352
-
353
532
  // Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
354
- let blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined = undefined;
533
+ let blockPendingBroadcast: BlockProposal | undefined = undefined;
355
534
 
356
535
  while (true) {
357
536
  const blocksBuilt = blocksInCheckpoint.length;
@@ -363,7 +542,7 @@ export class CheckpointProposalJob implements Traceable {
363
542
 
364
543
  if (!timingInfo.canStart) {
365
544
  this.log.debug(`Not enough time left in slot to start another block`, {
366
- slot: this.slot,
545
+ slot: this.targetSlot,
367
546
  blocksBuilt,
368
547
  secondsIntoSlot,
369
548
  });
@@ -382,25 +561,25 @@ export class CheckpointProposalJob implements Traceable {
382
561
  blockNumber,
383
562
  indexWithinCheckpoint,
384
563
  txHashesAlreadyIncluded,
385
- remainingBlobFields,
386
564
  });
387
565
 
388
- // TODO(palla/mbps): Review these conditions. We may want to keep trying in some scenarios.
389
- if (!buildResult && timingInfo.isLastBlock) {
390
- // If no block was produced due to not enough txs and this was the last subslot, exit
391
- break;
392
- } else if (!buildResult && timingInfo.deadline !== undefined) {
393
- // But if there is still time for more blocks, wait until the next subslot and try again
566
+ // If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
567
+ if ('failure' in buildResult) {
568
+ // If this was the last subslot, or we're running with a single block per slot, we're done
569
+ if (timingInfo.isLastBlock || timingInfo.deadline === undefined) {
570
+ break;
571
+ }
572
+ // Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
394
573
  await this.waitUntilNextSubslot(timingInfo.deadline);
395
574
  continue;
396
- } else if (!buildResult) {
397
- // Exit if there is no possibility of building more blocks
398
- break;
399
- } else if ('error' in buildResult) {
400
- // If there was an error building the block, just exit the loop and give up the rest of the slot
575
+ }
576
+
577
+ // If there was an error building the block, we just exit the loop and give up the rest of the slot.
578
+ // We don't want to risk building more blocks if something went wrong.
579
+ if ('error' in buildResult) {
401
580
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
402
- this.log.warn(`Halting block building for slot ${this.slot}`, {
403
- slot: this.slot,
581
+ this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
582
+ slot: this.targetSlot,
404
583
  blocksBuilt,
405
584
  error: buildResult.error,
406
585
  });
@@ -408,65 +587,81 @@ export class CheckpointProposalJob implements Traceable {
408
587
  break;
409
588
  }
410
589
 
411
- const { block, usedTxs, remainingBlobFields: newRemainingBlobFields } = buildResult;
412
- blocksInCheckpoint.push(block);
413
-
414
- // Update remaining blob fields for the next block
415
- remainingBlobFields = newRemainingBlobFields;
416
-
417
- // Sync the proposed block to the archiver to make it available
418
- // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
419
- // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
420
- // Fire and forget - don't block the critical path, but log errors
421
- this.syncProposedBlockToArchiver(block).catch(err => {
422
- this.log.error(`Failed to sync proposed block ${block.number} to archiver`, { blockNumber: block.number, err });
590
+ const { block, usedTxs } = buildResult;
591
+ this.checkpointMetrics.noteCheckpointBlockBuilt(this.dateProvider.now(), {
592
+ isFirstBlock: blocksBuilt === 0,
593
+ isLastBlock: timingInfo.isLastBlock,
423
594
  });
424
595
 
596
+ blocksInCheckpoint.push(block);
425
597
  usedTxs.forEach(tx => txHashesAlreadyIncluded.add(tx.txHash.toString()));
426
598
 
427
- // If this is the last block, exit the loop now so we start collecting attestations
599
+ // Sign the block proposal. This will throw if HA signing fails.
600
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, blockProposalOptions);
601
+
602
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
603
+ // so we avoid polluting our archive with a block that would fail.
604
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
605
+ // If this throws, we abort the entire checkpoint.
606
+ await this.syncProposedBlockToArchiver(block);
607
+
608
+ // If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
428
609
  if (timingInfo.isLastBlock) {
429
- this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
430
- slot: this.slot,
610
+ this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
611
+ slot: this.targetSlot,
431
612
  blockNumber,
432
613
  blocksBuilt,
433
614
  });
434
- blockPendingBroadcast = { block, txs: usedTxs };
615
+
616
+ blockPendingBroadcast = proposal;
435
617
  break;
436
618
  }
437
619
 
438
- // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
439
- // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
440
- if (!this.config.fishermanMode) {
441
- const proposal = await this.validatorClient.createBlockProposal(
442
- block.header,
443
- block.indexWithinCheckpoint,
444
- inHash,
445
- block.archive.root,
446
- usedTxs,
447
- this.proposer,
448
- blockProposalOptions,
449
- );
450
- await this.p2pClient.broadcastProposal(proposal);
451
- }
620
+ // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
621
+ proposal && (await this.p2pClient.broadcastProposal(proposal));
452
622
 
453
623
  // Wait until the next block's start time
454
624
  await this.waitUntilNextSubslot(timingInfo.deadline);
455
625
  }
456
626
 
457
- this.log.verbose(`Block building loop completed for slot ${this.slot}`, {
458
- slot: this.slot,
627
+ this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
628
+ slot: this.targetSlot,
459
629
  blocksBuilt: blocksInCheckpoint.length,
460
630
  });
461
631
 
462
632
  return { blocksInCheckpoint, blockPendingBroadcast };
463
633
  }
464
634
 
635
+ /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */
636
+ private createBlockProposal(
637
+ block: L2Block,
638
+ inHash: Fr,
639
+ usedTxs: Tx[],
640
+ blockProposalOptions: BlockProposalOptions,
641
+ ): Promise<BlockProposal | undefined> {
642
+ if (this.config.fishermanMode) {
643
+ this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
644
+ return Promise.resolve(undefined);
645
+ }
646
+ return this.validatorClient.createBlockProposal(
647
+ block.header,
648
+ this.checkpointNumber,
649
+ block.indexWithinCheckpoint,
650
+ inHash,
651
+ block.archive.root,
652
+ usedTxs,
653
+ this.proposer,
654
+ blockProposalOptions,
655
+ );
656
+ }
657
+
465
658
  /** Sleeps until it is time to produce the next block in the slot */
466
659
  @trackSpan('CheckpointProposalJob.waitUntilNextSubslot')
467
660
  private async waitUntilNextSubslot(nextSubslotStart: number) {
468
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
469
- this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, { slot: this.slot });
661
+ this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.targetSlot);
662
+ this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
663
+ slot: this.targetSlot,
664
+ });
470
665
  await this.waitUntilTimeInSlot(nextSubslotStart);
471
666
  }
472
667
 
@@ -481,64 +676,64 @@ export class CheckpointProposalJob implements Traceable {
481
676
  indexWithinCheckpoint: IndexWithinCheckpoint;
482
677
  buildDeadline: Date | undefined;
483
678
  txHashesAlreadyIncluded: Set<string>;
484
- remainingBlobFields: number;
485
679
  },
486
- ): Promise<{ block: L2Block; usedTxs: Tx[]; remainingBlobFields: number } | { error: Error } | undefined> {
487
- const {
488
- blockTimestamp,
489
- forceCreate,
490
- blockNumber,
491
- indexWithinCheckpoint,
492
- buildDeadline,
493
- txHashesAlreadyIncluded,
494
- remainingBlobFields,
495
- } = opts;
680
+ ): Promise<
681
+ { block: L2Block; usedTxs: Tx[] } | { failure: 'insufficient-txs' | 'insufficient-valid-txs' } | { error: Error }
682
+ > {
683
+ const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } =
684
+ opts;
496
685
 
497
686
  this.log.verbose(
498
- `Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`,
687
+ `Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`,
499
688
  { ...checkpointBuilder.getConstantData(), ...opts },
500
689
  );
501
690
 
502
691
  try {
503
692
  // Wait until we have enough txs to build the block
504
- const minTxs = this.config.minTxsPerBlock;
505
- const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
693
+ const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
506
694
  if (!canStartBuilding) {
507
695
  this.log.warn(
508
- `Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`,
509
- { blockNumber, slot: this.slot, indexWithinCheckpoint },
696
+ `Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (got ${availableTxs} txs but needs ${minTxs})`,
697
+ { blockNumber, slot: this.targetSlot, indexWithinCheckpoint },
510
698
  );
511
- this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, availableTxs, slot: this.slot });
699
+ this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, availableTxs, slot: this.targetSlot });
512
700
  this.metrics.recordBlockProposalFailed('insufficient_txs');
513
- return undefined;
701
+ return { failure: 'insufficient-txs' };
514
702
  }
515
703
 
516
704
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
517
705
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
518
706
  const pendingTxs = filter(
519
- this.p2pClient.iteratePendingTxs(),
707
+ this.p2pClient.iterateEligiblePendingTxs(),
520
708
  tx => !txHashesAlreadyIncluded.has(tx.txHash.toString()),
521
709
  );
522
710
 
523
711
  this.log.debug(
524
- `Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`,
525
- { slot: this.slot, blockNumber, indexWithinCheckpoint },
712
+ `Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot} with ${availableTxs} available txs`,
713
+ { slot: this.targetSlot, blockNumber, indexWithinCheckpoint },
526
714
  );
527
- this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
715
+ this.setStateFn(SequencerState.CREATING_BLOCK, this.targetSlot);
528
716
 
529
- // Calculate blob fields limit for txs (remaining capacity - this block's end overhead)
530
- const blockEndOverhead = getNumBlockEndBlobFields(indexWithinCheckpoint === 0);
531
- const maxBlobFieldsForTxs = remainingBlobFields - blockEndOverhead;
532
-
533
- const blockBuilderOptions: PublicProcessorLimits = {
717
+ // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
718
+ // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
719
+ // minValidTxs is passed into the builder so it can reject the block *before* updating state.
720
+ const minValidTxs = forceCreate ? 0 : (this.config.minValidTxsPerBlock ?? minTxs);
721
+ const blockBuilderOptions: BlockBuilderOptions = {
534
722
  maxTransactions: this.config.maxTxsPerBlock,
535
- maxBlockSize: this.config.maxBlockSizeInBytes,
536
- maxBlockGas: new Gas(this.config.maxDABlockGas, this.config.maxL2BlockGas),
537
- maxBlobFields: maxBlobFieldsForTxs,
723
+ maxBlockGas:
724
+ this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined
725
+ ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity)
726
+ : undefined,
538
727
  deadline: buildDeadline,
728
+ isBuildingProposal: true,
729
+ minValidTxs,
730
+ maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
731
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier,
539
732
  };
540
733
 
541
- // Actually build the block by executing txs
734
+ // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
735
+ // if the number of successfully processed txs is below minValidTxs, ensuring state is not
736
+ // updated for blocks that will be discarded.
542
737
  const buildResult = await this.buildSingleBlockWithCheckpointBuilder(
543
738
  checkpointBuilder,
544
739
  pendingTxs,
@@ -550,22 +745,27 @@ export class CheckpointProposalJob implements Traceable {
550
745
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
551
746
  await this.dropFailedTxsFromP2P(buildResult.failedTxs);
552
747
 
553
- // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
554
- // too long, then we may not get to minTxsPerBlock after executing public functions.
555
- const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
556
- const numTxs = buildResult.status === 'no-valid-txs' ? 0 : buildResult.numTxs;
557
- if (buildResult.status === 'no-valid-txs' || (!forceCreate && numTxs < minValidTxs)) {
748
+ if (buildResult.status === 'insufficient-valid-txs') {
558
749
  this.log.warn(
559
- `Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed`,
560
- { slot: this.slot, blockNumber, numTxs, indexWithinCheckpoint, minValidTxs, buildResult: buildResult.status },
750
+ `Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`,
751
+ {
752
+ slot: this.targetSlot,
753
+ blockNumber,
754
+ numTxs: buildResult.processedCount,
755
+ indexWithinCheckpoint,
756
+ minValidTxs,
757
+ },
561
758
  );
562
- this.eventEmitter.emit('block-build-failed', { reason: `Insufficient valid txs`, slot: this.slot });
759
+ this.eventEmitter.emit('block-build-failed', {
760
+ reason: `Insufficient valid txs`,
761
+ slot: this.targetSlot,
762
+ });
563
763
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
564
- return undefined;
764
+ return { failure: 'insufficient-valid-txs' };
565
765
  }
566
766
 
567
767
  // Block creation succeeded, emit stats and metrics
568
- const { publicGas, block, publicProcessorDuration, usedTxs, usedTxBlobFields, blockBuildDuration } = buildResult;
768
+ const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
569
769
 
570
770
  const blockStats = {
571
771
  eventName: 'l2-block-built',
@@ -576,33 +776,42 @@ export class CheckpointProposalJob implements Traceable {
576
776
 
577
777
  const blockHash = await block.hash();
578
778
  const txHashes = block.body.txEffects.map(tx => tx.txHash);
579
- const manaPerSec = publicGas.l2Gas / (blockBuildDuration / 1000);
779
+ const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
580
780
 
581
781
  this.log.info(
582
- `Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`,
782
+ `Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`,
583
783
  { blockHash, txHashes, manaPerSec, ...blockStats },
584
784
  );
585
785
 
586
- this.eventEmitter.emit('block-proposed', { blockNumber: block.number, slot: this.slot });
587
- this.metrics.recordBuiltBlock(blockBuildDuration, publicGas.l2Gas);
786
+ // `slot` is the target/submission slot (may be one ahead when pipelining),
787
+ // `buildSlot` is the wall-clock slot during which the block was actually built.
788
+ this.eventEmitter.emit('block-proposed', {
789
+ blockNumber: block.number,
790
+ slot: this.targetSlot,
791
+ buildSlot: this.slotNow,
792
+ });
793
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe(), this.targetSlot);
588
794
 
589
- return { block, usedTxs, remainingBlobFields: maxBlobFieldsForTxs - usedTxBlobFields };
795
+ return { block, usedTxs };
590
796
  } catch (err: any) {
591
- this.eventEmitter.emit('block-build-failed', { reason: err.message, slot: this.slot });
592
- this.log.error(`Error building block`, err, { blockNumber, slot: this.slot });
797
+ this.eventEmitter.emit('block-build-failed', {
798
+ reason: err.message,
799
+ slot: this.targetSlot,
800
+ });
801
+ this.log.error(`Error building block`, err, { blockNumber, slot: this.targetSlot });
593
802
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
594
803
  this.metrics.recordFailedBlock();
595
804
  return { error: err };
596
805
  }
597
806
  }
598
807
 
599
- /** Uses the checkpoint builder to build a block, catching specific txs */
808
+ /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */
600
809
  private async buildSingleBlockWithCheckpointBuilder(
601
810
  checkpointBuilder: CheckpointBuilder,
602
811
  pendingTxs: AsyncIterable<Tx>,
603
812
  blockNumber: BlockNumber,
604
813
  blockTimestamp: bigint,
605
- blockBuilderOptions: PublicProcessorLimits,
814
+ blockBuilderOptions: BlockBuilderOptions,
606
815
  ) {
607
816
  try {
608
817
  const workTimer = new Timer();
@@ -610,8 +819,12 @@ export class CheckpointProposalJob implements Traceable {
610
819
  const blockBuildDuration = workTimer.ms();
611
820
  return { ...result, blockBuildDuration, status: 'success' as const };
612
821
  } catch (err: unknown) {
613
- if (isErrorClass(err, NoValidTxsError)) {
614
- return { failedTxs: err.failedTxs, status: 'no-valid-txs' as const };
822
+ if (isErrorClass(err, InsufficientValidTxsError)) {
823
+ return {
824
+ failedTxs: err.failedTxs,
825
+ processedCount: err.processedCount,
826
+ status: 'insufficient-valid-txs' as const,
827
+ };
615
828
  }
616
829
  throw err;
617
830
  }
@@ -624,7 +837,7 @@ export class CheckpointProposalJob implements Traceable {
624
837
  blockNumber: BlockNumber;
625
838
  indexWithinCheckpoint: IndexWithinCheckpoint;
626
839
  buildDeadline: Date | undefined;
627
- }): Promise<{ canStartBuilding: boolean; availableTxs: number }> {
840
+ }): Promise<{ canStartBuilding: boolean; availableTxs: number; minTxs: number }> {
628
841
  const { indexWithinCheckpoint, blockNumber, buildDeadline, forceCreate } = opts;
629
842
 
630
843
  // We only allow a block with 0 txs in the first block of the checkpoint
@@ -641,20 +854,20 @@ export class CheckpointProposalJob implements Traceable {
641
854
  // If we're past deadline, or we have no deadline, give up
642
855
  const now = this.dateProvider.nowAsDate();
643
856
  if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
644
- return { canStartBuilding: false, availableTxs: availableTxs };
857
+ return { canStartBuilding: false, availableTxs, minTxs };
645
858
  }
646
859
 
647
860
  // Wait a bit before checking again
648
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.slot);
861
+ this.setStateFn(SequencerState.WAITING_FOR_TXS, this.targetSlot);
649
862
  this.log.verbose(
650
- `Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (have ${availableTxs} but need ${minTxs})`,
651
- { blockNumber, slot: this.slot, indexWithinCheckpoint },
863
+ `Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (have ${availableTxs} but need ${minTxs})`,
864
+ { blockNumber, slot: this.targetSlot, indexWithinCheckpoint },
652
865
  );
653
866
  await this.waitForTxsPollingInterval();
654
867
  availableTxs = await this.p2pClient.getPendingTxCount();
655
868
  }
656
869
 
657
- return { canStartBuilding: true, availableTxs };
870
+ return { canStartBuilding: true, availableTxs, minTxs };
658
871
  }
659
872
 
660
873
  /**
@@ -680,16 +893,16 @@ export class CheckpointProposalJob implements Traceable {
680
893
  this.log.debug(`Attesting committee length is ${committee.length}`, { committee });
681
894
  }
682
895
 
683
- const numberOfRequiredAttestations = Math.floor((committee.length * 2) / 3) + 1;
896
+ const numberOfRequiredAttestations = computeQuorum(committee.length);
684
897
 
685
898
  if (this.config.skipCollectingAttestations) {
686
899
  this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
687
- const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
900
+ const attestations = await this.validatorClient?.collectOwnAttestations(proposal, this.checkpointNumber);
688
901
  return new CommitteeAttestationsAndSigners(orderAttestations(attestations ?? [], committee));
689
902
  }
690
903
 
691
904
  const attestationTimeAllowed = this.config.enforceTimeTable
692
- ? this.timetable.getMaxAllowedTime(SequencerState.PUBLISHING_CHECKPOINT)!
905
+ ? this.timetable.getCheckpointAttestationDeadline()
693
906
  : this.l1Constants.slotDuration;
694
907
  const attestationDeadline = new Date((this.getSlotStartBuildTimestamp() + attestationTimeAllowed) * 1000);
695
908
 
@@ -702,15 +915,33 @@ export class CheckpointProposalJob implements Traceable {
702
915
  proposal,
703
916
  numberOfRequiredAttestations,
704
917
  attestationDeadline,
918
+ this.checkpointNumber,
705
919
  );
706
920
 
707
921
  collectedAttestationsCount = attestations.length;
708
922
 
923
+ // Trim attestations to minimum required to save L1 calldata gas
924
+ const localAddresses = this.validatorClient.getValidatorAddresses();
925
+ const trimmed = trimAttestations(
926
+ attestations,
927
+ numberOfRequiredAttestations,
928
+ this.attestorAddress,
929
+ localAddresses,
930
+ );
931
+ if (trimmed.length < attestations.length) {
932
+ this.log.debug(`Trimmed attestations from ${attestations.length} to ${trimmed.length} for L1 submission`);
933
+ }
934
+
709
935
  // Rollup contract requires that the signatures are provided in the order of the committee
710
- const sorted = orderAttestations(attestations, committee);
936
+ const sorted = orderAttestations(trimmed, committee);
711
937
 
712
938
  // Manipulate the attestations if we've been configured to do so
713
- if (this.config.injectFakeAttestation || this.config.shuffleAttestationOrdering) {
939
+ if (
940
+ this.config.injectFakeAttestation ||
941
+ this.config.injectHighSValueAttestation ||
942
+ this.config.injectUnrecoverableSignatureAttestation ||
943
+ this.config.shuffleAttestationOrdering
944
+ ) {
714
945
  return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
715
946
  }
716
947
 
@@ -739,7 +970,11 @@ export class CheckpointProposalJob implements Traceable {
739
970
  this.epochCache.computeProposerIndex(slotNumber, epoch, seed, BigInt(committee.length)),
740
971
  );
741
972
 
742
- if (this.config.injectFakeAttestation) {
973
+ if (
974
+ this.config.injectFakeAttestation ||
975
+ this.config.injectHighSValueAttestation ||
976
+ this.config.injectUnrecoverableSignatureAttestation
977
+ ) {
743
978
  // Find non-empty attestations that are not from the proposer
744
979
  const nonProposerIndices: number[] = [];
745
980
  for (let i = 0; i < attestations.length; i++) {
@@ -749,8 +984,20 @@ export class CheckpointProposalJob implements Traceable {
749
984
  }
750
985
  if (nonProposerIndices.length > 0) {
751
986
  const targetIndex = nonProposerIndices[randomInt(nonProposerIndices.length)];
752
- this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
753
- unfreeze(attestations[targetIndex]).signature = Signature.random();
987
+ if (this.config.injectHighSValueAttestation) {
988
+ this.log.warn(
989
+ `Injecting high-s value attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`,
990
+ );
991
+ unfreeze(attestations[targetIndex]).signature = flipSignature(attestations[targetIndex].signature);
992
+ } else if (this.config.injectUnrecoverableSignatureAttestation) {
993
+ this.log.warn(
994
+ `Injecting unrecoverable signature attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`,
995
+ );
996
+ unfreeze(attestations[targetIndex]).signature = generateUnrecoverableSignature();
997
+ } else {
998
+ this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
999
+ unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
1000
+ }
754
1001
  }
755
1002
  return new CommitteeAttestationsAndSigners(attestations);
756
1003
  }
@@ -759,11 +1006,20 @@ export class CheckpointProposalJob implements Traceable {
759
1006
  this.log.warn(`Shuffling attestation ordering in checkpoint for slot ${slotNumber} (proposer #${proposerIndex})`);
760
1007
 
761
1008
  const shuffled = [...attestations];
762
- const [i, j] = [(proposerIndex + 1) % shuffled.length, (proposerIndex + 2) % shuffled.length];
763
- const valueI = shuffled[i];
764
- const valueJ = shuffled[j];
765
- shuffled[i] = valueJ;
766
- shuffled[j] = valueI;
1009
+
1010
+ // Find two non-proposer positions that both have non-empty signatures to swap.
1011
+ // This ensures the bitmap doesn't change, so the MaliciousCommitteeAttestationsAndSigners
1012
+ // signers array stays correctly aligned with L1's committee reconstruction.
1013
+ const swappable: number[] = [];
1014
+ for (let k = 0; k < shuffled.length; k++) {
1015
+ if (!shuffled[k].signature.isEmpty() && k !== proposerIndex) {
1016
+ swappable.push(k);
1017
+ }
1018
+ }
1019
+ if (swappable.length >= 2) {
1020
+ const [i, j] = [swappable[0], swappable[1]];
1021
+ [shuffled[i], shuffled[j]] = [shuffled[j], shuffled[i]];
1022
+ }
767
1023
 
768
1024
  const signers = new CommitteeAttestationsAndSigners(attestations).getSigners();
769
1025
  return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers);
@@ -786,9 +1042,13 @@ export class CheckpointProposalJob implements Traceable {
786
1042
  * Adds the proposed block to the archiver so it's available via P2P.
787
1043
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
788
1044
  * would never receive its own block without this explicit sync.
1045
+ *
1046
+ * In fisherman mode we skip this push: the fisherman builds blocks locally for validation
1047
+ * and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
1048
+ * whenever the real proposer's block arrives from L1.
789
1049
  */
790
1050
  private async syncProposedBlockToArchiver(block: L2Block): Promise<void> {
791
- if (this.config.skipPushProposedBlocksToArchiver !== false) {
1051
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
792
1052
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
793
1053
  blockNumber: block.number,
794
1054
  slot: block.header.globalVariables.slotNumber,
@@ -806,22 +1066,22 @@ export class CheckpointProposalJob implements Traceable {
806
1066
  private async handleCheckpointEndAsFisherman(checkpoint: Checkpoint | undefined) {
807
1067
  // Perform L1 fee analysis before clearing requests
808
1068
  // The callback is invoked asynchronously after the next block is mined
809
- const feeAnalysis = await this.publisher.analyzeL1Fees(this.slot, analysis =>
1069
+ const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, analysis =>
810
1070
  this.metrics.recordFishermanFeeAnalysis(analysis),
811
1071
  );
812
1072
 
813
1073
  if (checkpoint) {
814
- this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.slot}`, {
1074
+ this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
815
1075
  ...checkpoint.toCheckpointInfo(),
816
1076
  ...checkpoint.getStats(),
817
1077
  feeAnalysisId: feeAnalysis?.id,
818
1078
  });
819
1079
  } else {
820
- this.log.warn(`Validation block building FAILED for slot ${this.slot}`, {
821
- slot: this.slot,
1080
+ this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
1081
+ slot: this.targetSlot,
822
1082
  feeAnalysisId: feeAnalysis?.id,
823
1083
  });
824
- this.metrics.recordBlockProposalFailed('block_build_failed');
1084
+ this.metrics.recordCheckpointProposalFailed('block_build_failed');
825
1085
  }
826
1086
 
827
1087
  this.publisher.clearPendingRequests();
@@ -832,15 +1092,15 @@ export class CheckpointProposalJob implements Traceable {
832
1092
  */
833
1093
  private handleHASigningError(err: any, errorContext: string): boolean {
834
1094
  if (err instanceof DutyAlreadySignedError) {
835
- this.log.info(`${errorContext} for slot ${this.slot} already signed by another HA node, yielding`, {
836
- slot: this.slot,
1095
+ this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
1096
+ slot: this.targetSlot,
837
1097
  signedByNode: err.signedByNode,
838
1098
  });
839
1099
  return true;
840
1100
  }
841
1101
  if (err instanceof SlashingProtectionError) {
842
- this.log.info(`${errorContext} for slot ${this.slot} blocked by slashing protection, yielding`, {
843
- slot: this.slot,
1102
+ this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
1103
+ slot: this.targetSlot,
844
1104
  existingMessageHash: err.existingMessageHash,
845
1105
  attemptedMessageHash: err.attemptedMessageHash,
846
1106
  });
@@ -863,7 +1123,7 @@ export class CheckpointProposalJob implements Traceable {
863
1123
  }
864
1124
 
865
1125
  private getSlotStartBuildTimestamp(): number {
866
- return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
1126
+ return getSlotStartBuildTimestamp(this.slotNow, this.l1Constants);
867
1127
  }
868
1128
 
869
1129
  private getSecondsIntoSlot(): number {