@aztec/sequencer-client 0.0.1-commit.b1c78909e → 0.0.1-commit.b2a5d0dd1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (76) hide show
  1. package/dest/client/sequencer-client.d.ts +6 -12
  2. package/dest/client/sequencer-client.d.ts.map +1 -1
  3. package/dest/client/sequencer-client.js +30 -80
  4. package/dest/config.d.ts +4 -3
  5. package/dest/config.d.ts.map +1 -1
  6. package/dest/config.js +17 -13
  7. package/dest/global_variable_builder/fee_predictor.d.ts +37 -0
  8. package/dest/global_variable_builder/fee_predictor.d.ts.map +1 -0
  9. package/dest/global_variable_builder/fee_predictor.js +128 -0
  10. package/dest/global_variable_builder/fee_provider.d.ts +21 -0
  11. package/dest/global_variable_builder/fee_provider.d.ts.map +1 -0
  12. package/dest/global_variable_builder/fee_provider.js +58 -0
  13. package/dest/global_variable_builder/global_builder.d.ts +15 -14
  14. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  15. package/dest/global_variable_builder/global_builder.js +16 -50
  16. package/dest/global_variable_builder/index.d.ts +4 -2
  17. package/dest/global_variable_builder/index.d.ts.map +1 -1
  18. package/dest/global_variable_builder/index.js +2 -0
  19. package/dest/publisher/config.d.ts +13 -1
  20. package/dest/publisher/config.d.ts.map +1 -1
  21. package/dest/publisher/config.js +19 -4
  22. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +3 -4
  23. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -1
  24. package/dest/publisher/sequencer-publisher-factory.d.ts +3 -5
  25. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  26. package/dest/publisher/sequencer-publisher-factory.js +2 -3
  27. package/dest/publisher/sequencer-publisher.d.ts +51 -43
  28. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  29. package/dest/publisher/sequencer-publisher.js +135 -111
  30. package/dest/sequencer/chain_state_overrides.d.ts +25 -0
  31. package/dest/sequencer/chain_state_overrides.d.ts.map +1 -0
  32. package/dest/sequencer/chain_state_overrides.js +39 -0
  33. package/dest/sequencer/checkpoint_proposal_job.d.ts +40 -8
  34. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  35. package/dest/sequencer/checkpoint_proposal_job.js +441 -183
  36. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts +34 -0
  37. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts.map +1 -0
  38. package/dest/sequencer/checkpoint_proposal_job_metrics.js +72 -0
  39. package/dest/sequencer/checkpoint_voter.d.ts +1 -2
  40. package/dest/sequencer/checkpoint_voter.d.ts.map +1 -1
  41. package/dest/sequencer/checkpoint_voter.js +2 -5
  42. package/dest/sequencer/events.d.ts +7 -1
  43. package/dest/sequencer/events.d.ts.map +1 -1
  44. package/dest/sequencer/metrics.d.ts +11 -10
  45. package/dest/sequencer/metrics.d.ts.map +1 -1
  46. package/dest/sequencer/metrics.js +38 -20
  47. package/dest/sequencer/sequencer.d.ts +21 -6
  48. package/dest/sequencer/sequencer.d.ts.map +1 -1
  49. package/dest/sequencer/sequencer.js +125 -60
  50. package/dest/sequencer/timetable.d.ts +14 -1
  51. package/dest/sequencer/timetable.d.ts.map +1 -1
  52. package/dest/sequencer/timetable.js +45 -36
  53. package/dest/test/mock_checkpoint_builder.d.ts +4 -4
  54. package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
  55. package/package.json +27 -28
  56. package/src/client/sequencer-client.ts +42 -108
  57. package/src/config.ts +20 -12
  58. package/src/global_variable_builder/README.md +44 -0
  59. package/src/global_variable_builder/fee_predictor.ts +172 -0
  60. package/src/global_variable_builder/fee_provider.ts +75 -0
  61. package/src/global_variable_builder/global_builder.ts +26 -62
  62. package/src/global_variable_builder/index.ts +3 -1
  63. package/src/publisher/config.ts +38 -4
  64. package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +3 -1
  65. package/src/publisher/sequencer-publisher-factory.ts +3 -6
  66. package/src/publisher/sequencer-publisher.ts +202 -158
  67. package/src/sequencer/README.md +83 -13
  68. package/src/sequencer/chain_state_overrides.ts +87 -0
  69. package/src/sequencer/checkpoint_proposal_job.ts +558 -204
  70. package/src/sequencer/checkpoint_proposal_job_metrics.ts +128 -0
  71. package/src/sequencer/checkpoint_voter.ts +1 -12
  72. package/src/sequencer/events.ts +6 -1
  73. package/src/sequencer/metrics.ts +49 -25
  74. package/src/sequencer/sequencer.ts +185 -66
  75. package/src/sequencer/timetable.ts +57 -45
  76. package/src/test/mock_checkpoint_builder.ts +3 -3
@@ -436,24 +436,26 @@ function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
436
436
  return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
437
437
  }
438
438
  var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _initProto;
439
- import { BlockNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
439
+ import { BlockNumber, CheckpointNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
440
440
  import { randomInt } from '@aztec/foundation/crypto/random';
441
441
  import { flipSignature, generateRecoverableSignature, generateUnrecoverableSignature } from '@aztec/foundation/crypto/secp256k1-signer';
442
442
  import { filter } from '@aztec/foundation/iterator';
443
443
  import { createLogger } from '@aztec/foundation/log';
444
+ import { retryUntil } from '@aztec/foundation/retry';
444
445
  import { sleep, sleepUntil } from '@aztec/foundation/sleep';
445
446
  import { Timer } from '@aztec/foundation/timer';
446
447
  import { isErrorClass, unfreeze } from '@aztec/foundation/types';
447
448
  import { CommitteeAttestationsAndSigners, MaliciousCommitteeAttestationsAndSigners } from '@aztec/stdlib/block';
448
449
  import { validateCheckpoint } from '@aztec/stdlib/checkpoint';
449
- import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
450
+ import { computeQuorum, getSlotStartBuildTimestamp, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
450
451
  import { Gas } from '@aztec/stdlib/gas';
451
- import { NoValidTxsError } from '@aztec/stdlib/interfaces/server';
452
+ import { InsufficientValidTxsError } from '@aztec/stdlib/interfaces/server';
452
453
  import { computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
453
454
  import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
454
455
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
455
456
  import { Attributes, trackSpan } from '@aztec/telemetry-client';
456
457
  import { DutyAlreadySignedError, SlashingProtectionError } from '@aztec/validator-ha-signer/errors';
458
+ import { buildPipelinedParentSimulationOverridesPlan, buildSubmissionSimulationOverridesPlan } from './chain_state_overrides.js';
457
459
  import { CheckpointVoter } from './checkpoint_voter.js';
458
460
  import { SequencerInterruptedError } from './errors.js';
459
461
  import { SequencerState } from './utils.js';
@@ -462,7 +464,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
462
464
  return {
463
465
  // nullish operator needed for tests
464
466
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
465
- [Attributes.SLOT_NUMBER]: this.slot
467
+ [Attributes.SLOT_NUMBER]: this.targetSlot
466
468
  };
467
469
  }), _dec2 = trackSpan('CheckpointProposalJob.buildBlocksForCheckpoint'), _dec3 = trackSpan('CheckpointProposalJob.waitUntilNextSubslot'), _dec4 = trackSpan('CheckpointProposalJob.buildSingleBlock'), _dec5 = trackSpan('CheckpointProposalJob.waitForMinTxs'), _dec6 = trackSpan('CheckpointProposalJob.waitForAttestations'), _dec7 = trackSpan('CheckpointProposalJob.waitUntilTimeInSlot');
468
470
  /**
@@ -471,8 +473,9 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
471
473
  * as well as enqueueing votes for slashing and governance proposals. This class is created from
472
474
  * the Sequencer once the check for being the proposer for the slot has succeeded.
473
475
  */ export class CheckpointProposalJob {
474
- epoch;
475
- slot;
476
+ slotNow;
477
+ targetSlot;
478
+ targetEpoch;
476
479
  checkpointNumber;
477
480
  syncedToBlockNumber;
478
481
  proposer;
@@ -494,9 +497,11 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
494
497
  epochCache;
495
498
  dateProvider;
496
499
  metrics;
500
+ checkpointMetrics;
497
501
  eventEmitter;
498
502
  setStateFn;
499
503
  tracer;
504
+ proposedCheckpointData;
500
505
  static{
501
506
  ({ e: [_initProto] } = _apply_decs_2203_r(this, [
502
507
  [
@@ -542,10 +547,13 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
542
547
  ], []));
543
548
  }
544
549
  log;
545
- constructor(epoch, slot, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
546
- proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, eventEmitter, setStateFn, tracer, bindings){
547
- this.epoch = epoch;
548
- this.slot = slot;
550
+ /** Tracks the fire-and-forget L1 submission promise so it can be awaited during shutdown. */ pendingL1Submission;
551
+ /** Pipelined parent chain state used while building and later submitting this checkpoint. */ pipelinedParentSimulationOverridesPlan;
552
+ constructor(slotNow, targetSlot, targetEpoch, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
553
+ proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, checkpointMetrics, eventEmitter, setStateFn, tracer, bindings, proposedCheckpointData){
554
+ this.slotNow = slotNow;
555
+ this.targetSlot = targetSlot;
556
+ this.targetEpoch = targetEpoch;
549
557
  this.checkpointNumber = checkpointNumber;
550
558
  this.syncedToBlockNumber = syncedToBlockNumber;
551
559
  this.proposer = proposer;
@@ -567,52 +575,261 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
567
575
  this.epochCache = epochCache;
568
576
  this.dateProvider = dateProvider;
569
577
  this.metrics = metrics;
578
+ this.checkpointMetrics = checkpointMetrics;
570
579
  this.eventEmitter = eventEmitter;
571
580
  this.setStateFn = setStateFn;
572
581
  this.tracer = tracer;
582
+ this.proposedCheckpointData = proposedCheckpointData;
573
583
  _initProto(this);
574
584
  this.log = createLogger('sequencer:checkpoint-proposal', {
575
585
  ...bindings,
576
- instanceId: `slot-${slot}`
586
+ instanceId: `slot-${this.slotNow}`
577
587
  });
578
588
  }
589
+ /** Awaits the pending L1 submission if one is in progress. Call during shutdown. */ async awaitPendingSubmission() {
590
+ this.log.info('Awaiting pending L1 payload submission');
591
+ await this.pendingL1Submission;
592
+ }
579
593
  /**
580
594
  * Executes the checkpoint proposal job.
581
- * Returns the published checkpoint if successful, undefined otherwise.
595
+ * Builds blocks, assembles checkpoint, and broadcasts the proposal (blocking).
596
+ * Attestation collection, signing, and L1 submission are backgrounded so the
597
+ * work loop can return to IDLE immediately for consecutive slot proposals.
598
+ * Returns the built checkpoint if successful, undefined otherwise.
582
599
  */ async execute() {
583
600
  // Enqueue governance and slashing votes (returns promises that will be awaited later)
584
601
  // In fisherman mode, we simulate slashing but don't actually publish to L1
585
602
  // These are constant for the whole slot, so we only enqueue them once
586
- const votesPromises = new CheckpointVoter(this.slot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
587
- // Build and propose the checkpoint. This will enqueue the request on the publisher if a checkpoint is built.
588
- const checkpoint = await this.proposeCheckpoint();
589
- // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
590
- await Promise.all(votesPromises);
591
- if (checkpoint) {
592
- this.metrics.recordCheckpointProposalSuccess();
603
+ const votesPromises = new CheckpointVoter(this.targetSlot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
604
+ // Build blocks, assemble checkpoint, and broadcast proposal (BLOCKING).
605
+ // Returns after broadcast — attestation collection is deferred.
606
+ const broadcast = await this.proposeCheckpoint();
607
+ if (!broadcast) {
608
+ await Promise.all(votesPromises);
609
+ // Still submit votes even without a checkpoint
610
+ if (!this.config.fishermanMode) {
611
+ this.pendingL1Submission = this.publisher.sendRequestsAt(this.dateProvider.nowAsDate()).then(()=>{});
612
+ }
613
+ return undefined;
593
614
  }
615
+ const { checkpoint } = broadcast;
616
+ this.metrics.recordCheckpointProposalSuccess();
594
617
  // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
595
618
  if (this.config.fishermanMode) {
596
619
  await this.handleCheckpointEndAsFisherman(checkpoint);
620
+ return checkpoint;
621
+ }
622
+ // Background the attestation → signing → L1 pipeline so the work loop is unblocked
623
+ this.pendingL1Submission = this.waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises);
624
+ // Return the built checkpoint immediately — the work loop is now unblocked
625
+ return checkpoint;
626
+ }
627
+ /**
628
+ * Background pipeline: collects attestations, signs them, enqueues the checkpoint, and submits to L1.
629
+ * Runs as a fire-and-forget task stored in `pendingL1Submission` so the work loop is unblocked.
630
+ */ async waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises) {
631
+ const { checkpoint } = broadcast;
632
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
633
+ try {
634
+ // Wait for all votes actions, enqueued at the beginning, to resolve
635
+ await Promise.all(votesPromises);
636
+ // Try to collect attestations from the committee
637
+ const signedAttestations = await this.getSignedCommitteeAttestations(broadcast);
638
+ // If pipelining, wait for the previous checkpoint to land on L1 before submitting,
639
+ // so we can check it matches the proposed checkpoint we used as parent, and has valid attestations.
640
+ if (signedAttestations && (!isPipelining || await this.waitForValidParentCheckpointOnL1())) {
641
+ await this.enqueueCheckpointForSubmission({
642
+ checkpoint,
643
+ ...signedAttestations
644
+ });
645
+ }
646
+ // If we failed to collect attestations, at least check if we need to issue an invalidation
647
+ // Note that if we are not pipelining, we enqueued the invalidation at the beginning
648
+ if (!signedAttestations && isPipelining && await this.waitForSyncedL2SlotNumber(this.slotNow)) {
649
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
650
+ if (!validationStatus.valid) {
651
+ this.log.warn(`Checkpoint ${validationStatus.checkpoint.checkpointNumber} has invalid attestations, enqueuing invalidation in spite of attestation collection failure`, {
652
+ checkpoint: validationStatus.checkpoint,
653
+ reason: validationStatus.reason
654
+ });
655
+ await this.enqueueInvalidation(validationStatus);
656
+ }
657
+ }
658
+ // Send whatever was enqueued: votes + (propose | invalidation | nothing).
659
+ // Compute the earliest time to submit: pipeline slot start when pipelining, now otherwise.
660
+ const submitAfter = isPipelining ? new Date(Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) * 1000) : new Date(this.dateProvider.now());
661
+ const l1Response = await this.publisher.sendRequestsAt(submitAfter);
662
+ const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
663
+ if (proposedAction) {
664
+ this.eventEmitter.emit('checkpoint-published', {
665
+ checkpoint: this.checkpointNumber,
666
+ slot: this.targetSlot
667
+ });
668
+ const coinbase = checkpoint.header.coinbase;
669
+ await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
670
+ } else {
671
+ this.eventEmitter.emit('checkpoint-publish-failed', {
672
+ ...l1Response,
673
+ slot: this.targetSlot
674
+ });
675
+ if (isPipelining) {
676
+ this.metrics.recordPipelineDiscard();
677
+ }
678
+ }
679
+ } catch (err) {
680
+ if (err instanceof SequencerInterruptedError) {
681
+ return;
682
+ }
683
+ this.log.error(`Background attestation/L1 pipeline failed for slot ${this.targetSlot}`, err);
684
+ this.eventEmitter.emit('checkpoint-publish-failed', {
685
+ slot: this.targetSlot
686
+ });
687
+ if (isPipelining) {
688
+ this.metrics.recordPipelineDiscard();
689
+ }
690
+ }
691
+ }
692
+ /** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */ async enqueueCheckpointForSubmission(result) {
693
+ const { checkpoint, attestations, attestationsSignature } = result;
694
+ this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.targetSlot);
695
+ const aztecSlotDuration = this.l1Constants.slotDuration;
696
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
697
+ const txTimeoutAt = new Date((submissionSlotStart + aztecSlotDuration) * 1000);
698
+ // If we have been configured to potentially skip publishing checkpoint then roll the dice here
699
+ if (this.config.skipPublishingCheckpointsPercent !== undefined && this.config.skipPublishingCheckpointsPercent > 0) {
700
+ const roll = Math.max(0, randomInt(100));
701
+ if (roll < this.config.skipPublishingCheckpointsPercent) {
702
+ this.log.warn(`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${roll}`);
703
+ return;
704
+ }
705
+ }
706
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
707
+ const submissionSimulationOverridesPlan = buildSubmissionSimulationOverridesPlan({
708
+ pipelinedParentPlan: this.pipelinedParentSimulationOverridesPlan,
709
+ invalidateToPendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
710
+ lastArchiveRoot: checkpoint.header.lastArchiveRoot,
711
+ pipeliningEnabled: isPipelining
712
+ });
713
+ await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
714
+ txTimeoutAt,
715
+ ...submissionSimulationOverridesPlan ? {
716
+ simulationOverridesPlan: submissionSimulationOverridesPlan
717
+ } : {}
718
+ });
719
+ }
720
+ /**
721
+ * Wait until the archiver syncs past the given L2 slot number.
722
+ * The deadline is the end of `this.targetSlot`, beyond which any pipelined work would miss its
723
+ * L1 submission window and is no longer useful.
724
+ */ async waitForSyncedL2SlotNumber(waitForSlot) {
725
+ const targetSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
726
+ const targetSlotEndMs = (targetSlotStart + this.l1Constants.slotDuration) * 1000;
727
+ const syncDelayTolerance = this.l1Constants.ethereumSlotDuration * 2 * 1000;
728
+ const timeoutSeconds = Math.max(0.1, (targetSlotEndMs + syncDelayTolerance - this.dateProvider.now()) / 1000);
729
+ try {
730
+ return await retryUntil(async ()=>{
731
+ const syncedSlot = await this.l2BlockSource.getSyncedL2SlotNumber();
732
+ return syncedSlot !== undefined && syncedSlot >= waitForSlot;
733
+ }, `archiver sync past slot ${waitForSlot}`, timeoutSeconds, 0.2);
734
+ } catch {
735
+ this.log.warn(`Archiver did not sync L1 past slot ${waitForSlot} before slot ${this.targetSlot} expired, discarding pipelined work`, {
736
+ checkpointNumber: this.checkpointNumber
737
+ });
738
+ this.emitPipelinedCheckpointDiscarded('archiver-sync-timeout');
739
+ return false;
740
+ }
741
+ }
742
+ /**
743
+ * Waits for the parent checkpoint to land on L1 before submitting a pipelined checkpoint.
744
+ * Polls until the archiver has synced L1 past the parent's slot, then verifies:
745
+ * - If we built on a proposed parent: it must have landed on L1 with matching hash and valid attestations.
746
+ * - If we built without a proposed parent: no new checkpoint must have appeared for that slot.
747
+ * If the parent has invalid attestations, enqueues an invalidation. Returns whether to proceed with the proposal.
748
+ */ async waitForValidParentCheckpointOnL1() {
749
+ const parentCheckpointNumber = CheckpointNumber(this.checkpointNumber - 1);
750
+ // Wait until archiver has synced L1 past the parent's slot (slotNow)
751
+ if (!await this.waitForSyncedL2SlotNumber(this.slotNow)) {
752
+ return false;
753
+ }
754
+ const tips = await this.l2BlockSource.getL2Tips();
755
+ const checkpointedNumber = tips.checkpointed.checkpoint.number;
756
+ // We built on top of a proposed checkpoint. Verify it landed on L1 as expected.
757
+ if (this.proposedCheckpointData) {
758
+ // After syncing from L1 we see the chain tip has invalid attestations. This means the parent checkpoint was posted
759
+ // with invalid attestations, or it built on top of something with invalid attestations and didnt invalidate them.
760
+ // Either way, we thought our parent would be valid, so we have to throw away our work. But at least we'll try and
761
+ // invalidate on L1 so we clean up the chain for the next proposer. And we'll slash them, but that's handled elsewhere.
762
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
763
+ if (!validationStatus.valid) {
764
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} has invalid attestations, discarding pipelined work`, {
765
+ checkpointNumber: this.checkpointNumber,
766
+ reason: validationStatus.reason
767
+ });
768
+ this.emitPipelinedCheckpointDiscarded('parent-invalid-attestations');
769
+ await this.enqueueInvalidation(validationStatus);
770
+ return false;
771
+ }
772
+ // The pending chain is valid. But did the parent checkpoint land on L1 at all?
773
+ if (checkpointedNumber < parentCheckpointNumber) {
774
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} did not land on L1, discarding pipelined work`, {
775
+ checkpointNumber: this.checkpointNumber,
776
+ checkpointedNumber
777
+ });
778
+ this.emitPipelinedCheckpointDiscarded('parent-not-on-l1');
779
+ return false;
780
+ }
781
+ // It landed. But is it the one we were expecting?
782
+ const expectedHash = this.proposedCheckpointData.header.hash().toString();
783
+ if (tips.checkpointed.checkpoint.hash !== expectedHash) {
784
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} hash mismatch on L1, discarding pipelined work`, {
785
+ checkpointNumber: this.checkpointNumber,
786
+ expectedHash,
787
+ actualHash: tips.checkpointed.checkpoint.hash
788
+ });
789
+ this.emitPipelinedCheckpointDiscarded('parent-hash-mismatch');
790
+ return false;
791
+ }
792
+ return true;
793
+ } else {
794
+ // We didn't see a proposed checkpoint at build time, so we built on checkpointed parent from two slots ago.
795
+ // But if a new checkpoint for the previous slot appeared on L1 in the meantime, our checkpoint assumed the wrong parent,
796
+ // so we have to discard our work. This can happen if we're somehow cut off from p2p and fail to see the checkpoint
797
+ // proposal for the previous slot.
798
+ if (checkpointedNumber > parentCheckpointNumber) {
799
+ this.log.warn(`Unexpected checkpoint ${checkpointedNumber} landed on L1 after we built on top of parent ${parentCheckpointNumber}, discarding pipelined work`, {
800
+ checkpointNumber: this.checkpointNumber,
801
+ checkpointedNumber
802
+ });
803
+ this.emitPipelinedCheckpointDiscarded('unexpected-parent-appeared');
804
+ return false;
805
+ }
806
+ return true;
807
+ }
808
+ }
809
+ /** Emits the pipelined-checkpoint-discarded event and records the metric. */ emitPipelinedCheckpointDiscarded(reason) {
810
+ this.metrics.recordPipelineParentCheckpointMismatch(reason);
811
+ this.eventEmitter.emit('pipelined-checkpoint-discarded', {
812
+ slot: this.targetSlot,
813
+ checkpointNumber: this.checkpointNumber,
814
+ reason
815
+ });
816
+ }
817
+ /** Simulates and enqueues an invalidation request for the invalid parent checkpoint. */ async enqueueInvalidation(validationStatus) {
818
+ if (this.config.skipInvalidateBlockAsProposer) {
819
+ this.log.warn(`Skipping checkpoint invalidation as proposer due to test configuration`);
597
820
  return;
598
821
  }
599
- // Then send everything to L1
600
- const l1Response = await this.publisher.sendRequests();
601
- const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
602
- if (proposedAction) {
603
- this.eventEmitter.emit('checkpoint-published', {
604
- checkpoint: this.checkpointNumber,
605
- slot: this.slot
822
+ const invalidateRequest = await this.publisher.simulateInvalidateCheckpoint(validationStatus);
823
+ if (invalidateRequest) {
824
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
825
+ const txTimeoutAt = new Date((submissionSlotStart + this.l1Constants.slotDuration) * 1000);
826
+ this.publisher.enqueueInvalidateCheckpoint(invalidateRequest, {
827
+ txTimeoutAt
606
828
  });
607
- const coinbase = checkpoint?.header.coinbase;
608
- await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
609
- return checkpoint;
610
- } else if (checkpoint) {
611
- this.eventEmitter.emit('checkpoint-publish-failed', {
612
- ...l1Response,
613
- slot: this.slot
829
+ } else {
830
+ this.log.info(`Invalidation simulation returned undefined, checkpoint may have been removed already`, {
831
+ checkpointNumber: this.checkpointNumber
614
832
  });
615
- return undefined;
616
833
  }
617
834
  }
618
835
  async proposeCheckpoint() {
@@ -623,23 +840,48 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
623
840
  hasError: false
624
841
  };
625
842
  try {
843
+ const now = this.dateProvider.now();
844
+ if (this.epochCache.isProposerPipeliningEnabled() && this.proposedCheckpointData) {
845
+ // Measure against the wall-clock slot whose build window we are currently using.
846
+ // In pipelining mode `targetSlot` is intentionally one slot ahead, which makes the
847
+ // target-slot boundary a full slot away from the actual build start time.
848
+ const slotBoundaryMs = Number(getTimestampForSlot(this.slotNow, this.l1Constants)) * 1000;
849
+ this.checkpointMetrics.recordPipelinedCheckpointBuildStartOffsetFromSlotBoundary(now - slotBoundaryMs);
850
+ }
851
+ this.checkpointMetrics.startCheckpointTiming(now);
626
852
  // Get operator configured coinbase and fee recipient for this attestor
627
853
  const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
628
854
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
629
855
  // Start the checkpoint
630
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.slot);
631
- this.metrics.incOpenSlot(this.slot, this.proposer?.toString() ?? 'unknown');
856
+ this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.targetSlot);
857
+ this.log.info(`Starting checkpoint proposal`, {
858
+ buildSlot: this.slotNow,
859
+ submissionSlot: this.targetSlot,
860
+ pipelining: this.epochCache.isProposerPipeliningEnabled(),
861
+ proposer: this.proposer?.toString(),
862
+ coinbase: coinbase.toString()
863
+ });
864
+ this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
632
865
  // Enqueues checkpoint invalidation (constant for the whole slot)
633
866
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
634
867
  this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
635
868
  }
636
- // Create checkpoint builder for the slot
637
- const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.slot);
869
+ // Create checkpoint builder for the slot.
870
+ // When pipelining, force the proposed checkpoint number and fee header to our parent so the
871
+ // fee computation sees the same chain tip that L1 will see once the previous pipelined checkpoint lands.
872
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
873
+ this.pipelinedParentSimulationOverridesPlan = isPipelining ? await buildPipelinedParentSimulationOverridesPlan({
874
+ checkpointNumber: this.checkpointNumber,
875
+ proposedCheckpointData: this.proposedCheckpointData,
876
+ rollup: this.publisher.rollupContract,
877
+ log: this.log
878
+ }) : undefined;
879
+ const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.targetSlot, this.pipelinedParentSimulationOverridesPlan);
638
880
  // Collect L1 to L2 messages for the checkpoint and compute their hash
639
881
  const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(this.checkpointNumber);
640
882
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
641
883
  // Collect the out hashes of all the checkpoints before this one in the same epoch
642
- const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.epoch)).filter((c)=>c.checkpointNumber < this.checkpointNumber).map((c)=>c.checkpointOutHash);
884
+ const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.targetEpoch)).filter((c)=>c.checkpointNumber < this.checkpointNumber).map((c)=>c.checkpointOutHash);
643
885
  // Get the fee asset price modifier from the oracle
644
886
  const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier();
645
887
  const fork = _ts_add_disposable_resource(env, await this.worldState.fork(this.syncedToBlockNumber, {
@@ -674,18 +916,18 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
674
916
  throw err;
675
917
  }
676
918
  if (blocksInCheckpoint.length === 0) {
677
- this.log.warn(`No blocks were built for slot ${this.slot}`, {
678
- slot: this.slot
919
+ this.log.warn(`No blocks were built for slot ${this.targetSlot}`, {
920
+ slot: this.targetSlot
679
921
  });
680
922
  this.eventEmitter.emit('checkpoint-empty', {
681
- slot: this.slot
923
+ slot: this.targetSlot
682
924
  });
683
925
  return undefined;
684
926
  }
685
927
  const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
686
928
  if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
687
929
  this.log.warn(`Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`, {
688
- slot: this.slot,
930
+ slot: this.targetSlot,
689
931
  blocksBuilt: blocksInCheckpoint.length,
690
932
  minBlocksForCheckpoint
691
933
  });
@@ -693,9 +935,10 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
693
935
  }
694
936
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
695
937
  // broadcasted yet, and wait to collect the committee attestations.
696
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
938
+ this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.targetSlot);
697
939
  const checkpoint = await checkpointBuilder.completeCheckpoint();
698
- // Final validation round for the checkpoint before we propose it, just for safety
940
+ // Final validation: per-block limits are only checked if the operator set them explicitly.
941
+ // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
699
942
  try {
700
943
  validateCheckpoint(checkpoint, {
701
944
  rollupManaLimit: this.l1Constants.rollupManaLimit,
@@ -705,68 +948,39 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
705
948
  maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint
706
949
  });
707
950
  } catch (err) {
708
- this.log.error(`Built an invalid checkpoint at slot ${this.slot} (skipping proposal)`, err, {
951
+ this.log.error(`Built an invalid checkpoint at slot ${this.slotNow} (skipping proposal)`, err, {
709
952
  checkpoint: checkpoint.header.toInspect()
710
953
  });
711
954
  return undefined;
712
955
  }
713
956
  // Record checkpoint-level build metrics
714
- this.metrics.recordCheckpointBuild(checkpointBuildTimer.ms(), blocksInCheckpoint.length, checkpoint.getStats().txCount, Number(checkpoint.header.totalManaUsed.toBigInt()));
715
- // Do not collect attestations nor publish to L1 in fisherman mode
957
+ this.checkpointMetrics.recordCheckpointBuild(checkpointBuildTimer.ms(), blocksInCheckpoint.length, checkpoint.getStats().txCount, Number(checkpoint.header.totalManaUsed.toBigInt()));
958
+ // In fisherman mode, return the checkpoint without broadcasting or collecting attestations
716
959
  if (this.config.fishermanMode) {
717
- this.log.info(`Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
718
- slot: this.slot,
960
+ this.log.info(`Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
961
+ slot: this.targetSlot,
719
962
  checkpoint: checkpoint.header.toInspect(),
720
963
  blocksBuilt: blocksInCheckpoint.length
721
964
  });
722
965
  this.metrics.recordCheckpointSuccess();
723
- return checkpoint;
966
+ // Return a broadcast result with a dummy proposal — fisherman mode skips attestation collection
967
+ return {
968
+ checkpoint,
969
+ proposal: undefined,
970
+ blockProposedAt: this.dateProvider.now()
971
+ };
724
972
  }
725
- // Include the block pending broadcast in the checkpoint proposal if any
726
- const lastBlock = blockPendingBroadcast && {
727
- blockHeader: blockPendingBroadcast.block.header,
728
- indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
729
- txs: blockPendingBroadcast.txs
730
- };
731
973
  // Create the checkpoint proposal and broadcast it
732
- const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, feeAssetPriceModifier, lastBlock, this.proposer, checkpointProposalOptions);
974
+ const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, this.checkpointNumber, feeAssetPriceModifier, blockPendingBroadcast, this.proposer, checkpointProposalOptions);
733
975
  const blockProposedAt = this.dateProvider.now();
734
976
  await this.p2pClient.broadcastCheckpointProposal(proposal);
735
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
736
- const attestations = await this.waitForAttestations(proposal);
737
- const blockAttestedAt = this.dateProvider.now();
738
- this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
739
- // Proposer must sign over the attestations before pushing them to L1
740
- const signer = this.proposer ?? this.publisher.getSenderAddress();
741
- let attestationsSignature;
742
- try {
743
- attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.slot, this.checkpointNumber);
744
- } catch (err) {
745
- // We shouldn't really get here since we yield to another HA node
746
- // as soon as we see these errors when creating block or checkpoint proposals.
747
- if (this.handleHASigningError(err, 'Attestations signature')) {
748
- return undefined;
749
- }
750
- throw err;
751
- }
752
- // Enqueue publishing the checkpoint to L1
753
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
754
- const aztecSlotDuration = this.l1Constants.slotDuration;
755
- const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
756
- const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
757
- // If we have been configured to potentially skip publishing checkpoint then roll the dice here
758
- if (this.config.skipPublishingCheckpointsPercent !== undefined && this.config.skipPublishingCheckpointsPercent > 0) {
759
- const result = Math.max(0, randomInt(100));
760
- if (result < this.config.skipPublishingCheckpointsPercent) {
761
- this.log.warn(`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${result}`);
762
- return checkpoint;
763
- }
764
- }
765
- await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
766
- txTimeoutAt,
767
- forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber
768
- });
769
- return checkpoint;
977
+ this.checkpointMetrics.noteCheckpointBroadcast(this.dateProvider.now());
978
+ // Return immediately after broadcast — attestation collection happens in the background
979
+ return {
980
+ checkpoint,
981
+ proposal,
982
+ blockProposedAt
983
+ };
770
984
  } catch (e) {
771
985
  env.error = e;
772
986
  env.hasError = true;
@@ -779,7 +993,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
779
993
  // swallow this error. It's already been logged by a function deeper in the stack
780
994
  return undefined;
781
995
  }
782
- this.log.error(`Error building checkpoint at slot ${this.slot}`, err);
996
+ this.log.error(`Error building checkpoint at slot ${this.targetSlot}`, err);
783
997
  return undefined;
784
998
  }
785
999
  }
@@ -799,7 +1013,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
799
1013
  const timingInfo = this.timetable.canStartNextBlock(secondsIntoSlot);
800
1014
  if (!timingInfo.canStart) {
801
1015
  this.log.debug(`Not enough time left in slot to start another block`, {
802
- slot: this.slot,
1016
+ slot: this.targetSlot,
803
1017
  blocksBuilt,
804
1018
  secondsIntoSlot
805
1019
  });
@@ -816,20 +1030,22 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
816
1030
  indexWithinCheckpoint,
817
1031
  txHashesAlreadyIncluded
818
1032
  });
819
- // TODO(palla/mbps): Review these conditions. We may want to keep trying in some scenarios.
820
- if (!buildResult && timingInfo.isLastBlock) {
821
- break;
822
- } else if (!buildResult && timingInfo.deadline !== undefined) {
823
- // But if there is still time for more blocks, wait until the next subslot and try again
1033
+ // If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
1034
+ if ('failure' in buildResult) {
1035
+ // If this was the last subslot, or we're running with a single block per slot, we're done
1036
+ if (timingInfo.isLastBlock || timingInfo.deadline === undefined) {
1037
+ break;
1038
+ }
1039
+ // Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
824
1040
  await this.waitUntilNextSubslot(timingInfo.deadline);
825
1041
  continue;
826
- } else if (!buildResult) {
827
- break;
828
- } else if ('error' in buildResult) {
829
- // If there was an error building the block, just exit the loop and give up the rest of the slot
1042
+ }
1043
+ // If there was an error building the block, we just exit the loop and give up the rest of the slot.
1044
+ // We don't want to risk building more blocks if something went wrong.
1045
+ if ('error' in buildResult) {
830
1046
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
831
- this.log.warn(`Halting block building for slot ${this.slot}`, {
832
- slot: this.slot,
1047
+ this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
1048
+ slot: this.targetSlot,
833
1049
  blocksBuilt,
834
1050
  error: buildResult.error
835
1051
  });
@@ -837,42 +1053,36 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
837
1053
  break;
838
1054
  }
839
1055
  const { block, usedTxs } = buildResult;
840
- blocksInCheckpoint.push(block);
841
- // Sync the proposed block to the archiver to make it available
842
- // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
843
- // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
844
- // Fire and forget - don't block the critical path, but log errors
845
- this.syncProposedBlockToArchiver(block).catch((err)=>{
846
- this.log.error(`Failed to sync proposed block ${block.number} to archiver`, {
847
- blockNumber: block.number,
848
- err
849
- });
1056
+ this.checkpointMetrics.noteCheckpointBlockBuilt(this.dateProvider.now(), {
1057
+ isFirstBlock: blocksBuilt === 0,
1058
+ isLastBlock: timingInfo.isLastBlock
850
1059
  });
1060
+ blocksInCheckpoint.push(block);
851
1061
  usedTxs.forEach((tx)=>txHashesAlreadyIncluded.add(tx.txHash.toString()));
852
- // If this is the last block, exit the loop now so we start collecting attestations
1062
+ // Sign the block proposal. This will throw if HA signing fails.
1063
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, blockProposalOptions);
1064
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
1065
+ // so we avoid polluting our archive with a block that would fail.
1066
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
1067
+ // If this throws, we abort the entire checkpoint.
1068
+ await this.syncProposedBlockToArchiver(block);
1069
+ // If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
853
1070
  if (timingInfo.isLastBlock) {
854
- this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
855
- slot: this.slot,
1071
+ this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
1072
+ slot: this.targetSlot,
856
1073
  blockNumber,
857
1074
  blocksBuilt
858
1075
  });
859
- blockPendingBroadcast = {
860
- block,
861
- txs: usedTxs
862
- };
1076
+ blockPendingBroadcast = proposal;
863
1077
  break;
864
1078
  }
865
- // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
866
- // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
867
- if (!this.config.fishermanMode) {
868
- const proposal = await this.validatorClient.createBlockProposal(block.header, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
869
- await this.p2pClient.broadcastProposal(proposal);
870
- }
1079
+ // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
1080
+ proposal && await this.p2pClient.broadcastProposal(proposal);
871
1081
  // Wait until the next block's start time
872
1082
  await this.waitUntilNextSubslot(timingInfo.deadline);
873
1083
  }
874
- this.log.verbose(`Block building loop completed for slot ${this.slot}`, {
875
- slot: this.slot,
1084
+ this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
1085
+ slot: this.targetSlot,
876
1086
  blocksBuilt: blocksInCheckpoint.length
877
1087
  });
878
1088
  return {
@@ -880,16 +1090,23 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
880
1090
  blockPendingBroadcast
881
1091
  };
882
1092
  }
1093
+ /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */ createBlockProposal(block, inHash, usedTxs, blockProposalOptions) {
1094
+ if (this.config.fishermanMode) {
1095
+ this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
1096
+ return Promise.resolve(undefined);
1097
+ }
1098
+ return this.validatorClient.createBlockProposal(block.header, this.checkpointNumber, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
1099
+ }
883
1100
  /** Sleeps until it is time to produce the next block in the slot */ async waitUntilNextSubslot(nextSubslotStart) {
884
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
1101
+ this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.targetSlot);
885
1102
  this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
886
- slot: this.slot
1103
+ slot: this.targetSlot
887
1104
  });
888
1105
  await this.waitUntilTimeInSlot(nextSubslotStart);
889
1106
  }
890
1107
  /** Builds a single block. Called from the main block building loop. */ async buildSingleBlock(checkpointBuilder, opts) {
891
1108
  const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } = opts;
892
- this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`, {
1109
+ this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`, {
893
1110
  ...checkpointBuilder.getConstantData(),
894
1111
  ...opts
895
1112
  });
@@ -897,62 +1114,68 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
897
1114
  // Wait until we have enough txs to build the block
898
1115
  const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
899
1116
  if (!canStartBuilding) {
900
- this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`, {
1117
+ this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (got ${availableTxs} txs but needs ${minTxs})`, {
901
1118
  blockNumber,
902
- slot: this.slot,
1119
+ slot: this.targetSlot,
903
1120
  indexWithinCheckpoint
904
1121
  });
905
1122
  this.eventEmitter.emit('block-tx-count-check-failed', {
906
1123
  minTxs,
907
1124
  availableTxs,
908
- slot: this.slot
1125
+ slot: this.targetSlot
909
1126
  });
910
1127
  this.metrics.recordBlockProposalFailed('insufficient_txs');
911
- return undefined;
1128
+ return {
1129
+ failure: 'insufficient-txs'
1130
+ };
912
1131
  }
913
1132
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
914
1133
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
915
1134
  const pendingTxs = filter(this.p2pClient.iterateEligiblePendingTxs(), (tx)=>!txHashesAlreadyIncluded.has(tx.txHash.toString()));
916
- this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`, {
917
- slot: this.slot,
1135
+ this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot} with ${availableTxs} available txs`, {
1136
+ slot: this.targetSlot,
918
1137
  blockNumber,
919
1138
  indexWithinCheckpoint
920
1139
  });
921
- this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
922
- // Per-block limits derived at startup by computeBlockLimits(), further capped
1140
+ this.setStateFn(SequencerState.CREATING_BLOCK, this.targetSlot);
1141
+ // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
923
1142
  // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
1143
+ // minValidTxs is passed into the builder so it can reject the block *before* updating state.
1144
+ const minValidTxs = forceCreate ? 0 : this.config.minValidTxsPerBlock ?? minTxs;
924
1145
  const blockBuilderOptions = {
925
1146
  maxTransactions: this.config.maxTxsPerBlock,
926
1147
  maxBlockGas: this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity) : undefined,
927
1148
  deadline: buildDeadline,
928
- isBuildingProposal: true
1149
+ isBuildingProposal: true,
1150
+ minValidTxs,
1151
+ maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
1152
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier
929
1153
  };
930
- // Actually build the block by executing txs
1154
+ // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
1155
+ // if the number of successfully processed txs is below minValidTxs, ensuring state is not
1156
+ // updated for blocks that will be discarded.
931
1157
  const buildResult = await this.buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
932
1158
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
933
1159
  await this.dropFailedTxsFromP2P(buildResult.failedTxs);
934
- // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
935
- // too long, then we may not get to minTxsPerBlock after executing public functions.
936
- const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
937
- const numTxs = buildResult.status === 'no-valid-txs' ? 0 : buildResult.numTxs;
938
- if (buildResult.status === 'no-valid-txs' || !forceCreate && numTxs < minValidTxs) {
939
- this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed`, {
940
- slot: this.slot,
1160
+ if (buildResult.status === 'insufficient-valid-txs') {
1161
+ this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`, {
1162
+ slot: this.targetSlot,
941
1163
  blockNumber,
942
- numTxs,
1164
+ numTxs: buildResult.processedCount,
943
1165
  indexWithinCheckpoint,
944
- minValidTxs,
945
- buildResult: buildResult.status
1166
+ minValidTxs
946
1167
  });
947
1168
  this.eventEmitter.emit('block-build-failed', {
948
1169
  reason: `Insufficient valid txs`,
949
- slot: this.slot
1170
+ slot: this.targetSlot
950
1171
  });
951
1172
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
952
- return undefined;
1173
+ return {
1174
+ failure: 'insufficient-valid-txs'
1175
+ };
953
1176
  }
954
1177
  // Block creation succeeded, emit stats and metrics
955
- const { block, publicProcessorDuration, usedTxs, blockBuildDuration } = buildResult;
1178
+ const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
956
1179
  const blockStats = {
957
1180
  eventName: 'l2-block-built',
958
1181
  duration: blockBuildDuration,
@@ -962,17 +1185,20 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
962
1185
  const blockHash = await block.hash();
963
1186
  const txHashes = block.body.txEffects.map((tx)=>tx.txHash);
964
1187
  const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
965
- this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`, {
1188
+ this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`, {
966
1189
  blockHash,
967
1190
  txHashes,
968
1191
  manaPerSec,
969
1192
  ...blockStats
970
1193
  });
1194
+ // `slot` is the target/submission slot (may be one ahead when pipelining),
1195
+ // `buildSlot` is the wall-clock slot during which the block was actually built.
971
1196
  this.eventEmitter.emit('block-proposed', {
972
1197
  blockNumber: block.number,
973
- slot: this.slot
1198
+ slot: this.targetSlot,
1199
+ buildSlot: this.slotNow
974
1200
  });
975
- this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe());
1201
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe(), this.targetSlot);
976
1202
  return {
977
1203
  block,
978
1204
  usedTxs
@@ -980,11 +1206,11 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
980
1206
  } catch (err) {
981
1207
  this.eventEmitter.emit('block-build-failed', {
982
1208
  reason: err.message,
983
- slot: this.slot
1209
+ slot: this.targetSlot
984
1210
  });
985
1211
  this.log.error(`Error building block`, err, {
986
1212
  blockNumber,
987
- slot: this.slot
1213
+ slot: this.targetSlot
988
1214
  });
989
1215
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
990
1216
  this.metrics.recordFailedBlock();
@@ -993,7 +1219,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
993
1219
  };
994
1220
  }
995
1221
  }
996
- /** Uses the checkpoint builder to build a block, catching specific txs */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
1222
+ /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
997
1223
  try {
998
1224
  const workTimer = new Timer();
999
1225
  const result = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
@@ -1004,10 +1230,11 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1004
1230
  status: 'success'
1005
1231
  };
1006
1232
  } catch (err) {
1007
- if (isErrorClass(err, NoValidTxsError)) {
1233
+ if (isErrorClass(err, InsufficientValidTxsError)) {
1008
1234
  return {
1009
1235
  failedTxs: err.failedTxs,
1010
- status: 'no-valid-txs'
1236
+ processedCount: err.processedCount,
1237
+ status: 'insufficient-valid-txs'
1011
1238
  };
1012
1239
  }
1013
1240
  throw err;
@@ -1031,10 +1258,10 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1031
1258
  };
1032
1259
  }
1033
1260
  // Wait a bit before checking again
1034
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.slot);
1035
- this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (have ${availableTxs} but need ${minTxs})`, {
1261
+ this.setStateFn(SequencerState.WAITING_FOR_TXS, this.targetSlot);
1262
+ this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (have ${availableTxs} but need ${minTxs})`, {
1036
1263
  blockNumber,
1037
- slot: this.slot,
1264
+ slot: this.targetSlot,
1038
1265
  indexWithinCheckpoint
1039
1266
  });
1040
1267
  await this.waitForTxsPollingInterval();
@@ -1046,6 +1273,30 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1046
1273
  minTxs
1047
1274
  };
1048
1275
  }
1276
+ async getSignedCommitteeAttestations(broadcast) {
1277
+ const { proposal, blockProposedAt } = broadcast;
1278
+ this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.targetSlot);
1279
+ const attestations = await this.waitForAttestations(proposal);
1280
+ if (!attestations) {
1281
+ return undefined;
1282
+ }
1283
+ this.checkpointMetrics.recordCheckpointAttestationDelay(this.dateProvider.now() - blockProposedAt);
1284
+ // Proposer must sign over the attestations before pushing them to L1
1285
+ const signer = this.proposer ?? this.publisher.getSenderAddress();
1286
+ try {
1287
+ const attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.targetSlot, this.checkpointNumber);
1288
+ return {
1289
+ attestations,
1290
+ attestationsSignature
1291
+ };
1292
+ } catch (err) {
1293
+ if (this.handleHASigningError(err, 'Attestations signature')) {
1294
+ return;
1295
+ }
1296
+ this.log.error(`Error signing attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
1297
+ return undefined;
1298
+ }
1299
+ }
1049
1300
  /**
1050
1301
  * Waits for enough attestations to be collected via p2p.
1051
1302
  * This is run after all blocks for the checkpoint have been built.
@@ -1066,19 +1317,19 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1066
1317
  committee
1067
1318
  });
1068
1319
  }
1069
- const numberOfRequiredAttestations = Math.floor(committee.length * 2 / 3) + 1;
1320
+ const numberOfRequiredAttestations = computeQuorum(committee.length);
1070
1321
  if (this.config.skipCollectingAttestations) {
1071
1322
  this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
1072
- const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
1323
+ const attestations = await this.validatorClient?.collectOwnAttestations(proposal, this.checkpointNumber);
1073
1324
  return new CommitteeAttestationsAndSigners(orderAttestations(attestations ?? [], committee));
1074
1325
  }
1075
- const attestationTimeAllowed = this.config.enforceTimeTable ? this.timetable.getMaxAllowedTime(SequencerState.PUBLISHING_CHECKPOINT) : this.l1Constants.slotDuration;
1326
+ const attestationTimeAllowed = this.config.enforceTimeTable ? this.timetable.getCheckpointAttestationDeadline() : this.l1Constants.slotDuration;
1076
1327
  const attestationDeadline = new Date((this.getSlotStartBuildTimestamp() + attestationTimeAllowed) * 1000);
1077
1328
  this.metrics.recordRequiredAttestations(numberOfRequiredAttestations, attestationTimeAllowed);
1078
1329
  const collectAttestationsTimer = new Timer();
1079
1330
  let collectedAttestationsCount = 0;
1080
1331
  try {
1081
- const attestations = await this.validatorClient.collectAttestations(proposal, numberOfRequiredAttestations, attestationDeadline);
1332
+ const attestations = await this.validatorClient.collectAttestations(proposal, numberOfRequiredAttestations, attestationDeadline, this.checkpointNumber);
1082
1333
  collectedAttestationsCount = attestations.length;
1083
1334
  // Trim attestations to minimum required to save L1 calldata gas
1084
1335
  const localAddresses = this.validatorClient.getValidatorAddresses();
@@ -1096,8 +1347,11 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1096
1347
  } catch (err) {
1097
1348
  if (err && err instanceof AttestationTimeoutError) {
1098
1349
  collectedAttestationsCount = err.collectedCount;
1350
+ this.log.error(`Timeout while waiting for attestations for checkpoint proposal at slot ${proposal.slotNumber} (collected ${collectedAttestationsCount}/${numberOfRequiredAttestations})`, err);
1351
+ } else {
1352
+ this.log.error(`Error collecting attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
1099
1353
  }
1100
- throw err;
1354
+ return undefined;
1101
1355
  } finally{
1102
1356
  this.metrics.recordCollectedAttestations(collectedAttestationsCount, collectAttestationsTimer.ms());
1103
1357
  }
@@ -1171,8 +1425,12 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1171
1425
  * Adds the proposed block to the archiver so it's available via P2P.
1172
1426
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
1173
1427
  * would never receive its own block without this explicit sync.
1428
+ *
1429
+ * In fisherman mode we skip this push: the fisherman builds blocks locally for validation
1430
+ * and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
1431
+ * whenever the real proposer's block arrives from L1.
1174
1432
  */ async syncProposedBlockToArchiver(block) {
1175
- if (this.config.skipPushProposedBlocksToArchiver !== false) {
1433
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
1176
1434
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
1177
1435
  blockNumber: block.number,
1178
1436
  slot: block.header.globalVariables.slotNumber
@@ -1188,16 +1446,16 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1188
1446
  /** Runs fee analysis and logs checkpoint outcome as fisherman */ async handleCheckpointEndAsFisherman(checkpoint) {
1189
1447
  // Perform L1 fee analysis before clearing requests
1190
1448
  // The callback is invoked asynchronously after the next block is mined
1191
- const feeAnalysis = await this.publisher.analyzeL1Fees(this.slot, (analysis)=>this.metrics.recordFishermanFeeAnalysis(analysis));
1449
+ const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, (analysis)=>this.metrics.recordFishermanFeeAnalysis(analysis));
1192
1450
  if (checkpoint) {
1193
- this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.slot}`, {
1451
+ this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
1194
1452
  ...checkpoint.toCheckpointInfo(),
1195
1453
  ...checkpoint.getStats(),
1196
1454
  feeAnalysisId: feeAnalysis?.id
1197
1455
  });
1198
1456
  } else {
1199
- this.log.warn(`Validation block building FAILED for slot ${this.slot}`, {
1200
- slot: this.slot,
1457
+ this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
1458
+ slot: this.targetSlot,
1201
1459
  feeAnalysisId: feeAnalysis?.id
1202
1460
  });
1203
1461
  this.metrics.recordCheckpointProposalFailed('block_build_failed');
@@ -1208,15 +1466,15 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1208
1466
  * Helper to handle HA double-signing errors. Returns true if the error was handled (caller should yield).
1209
1467
  */ handleHASigningError(err, errorContext) {
1210
1468
  if (err instanceof DutyAlreadySignedError) {
1211
- this.log.info(`${errorContext} for slot ${this.slot} already signed by another HA node, yielding`, {
1212
- slot: this.slot,
1469
+ this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
1470
+ slot: this.targetSlot,
1213
1471
  signedByNode: err.signedByNode
1214
1472
  });
1215
1473
  return true;
1216
1474
  }
1217
1475
  if (err instanceof SlashingProtectionError) {
1218
- this.log.info(`${errorContext} for slot ${this.slot} blocked by slashing protection, yielding`, {
1219
- slot: this.slot,
1476
+ this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
1477
+ slot: this.targetSlot,
1220
1478
  existingMessageHash: err.existingMessageHash,
1221
1479
  attemptedMessageHash: err.attemptedMessageHash
1222
1480
  });
@@ -1233,7 +1491,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1233
1491
  await sleep(TXS_POLLING_MS);
1234
1492
  }
1235
1493
  getSlotStartBuildTimestamp() {
1236
- return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
1494
+ return getSlotStartBuildTimestamp(this.slotNow, this.l1Constants);
1237
1495
  }
1238
1496
  getSecondsIntoSlot() {
1239
1497
  const slotStartTimestamp = this.getSlotStartBuildTimestamp();