@aztec/sequencer-client 0.0.1-commit.934299a21 → 0.0.1-commit.949a33fd8
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dest/client/sequencer-client.d.ts +6 -1
- package/dest/client/sequencer-client.d.ts.map +1 -1
- package/dest/client/sequencer-client.js +49 -27
- package/dest/config.d.ts +25 -5
- package/dest/config.d.ts.map +1 -1
- package/dest/config.js +41 -26
- package/dest/global_variable_builder/fee_predictor.d.ts +37 -0
- package/dest/global_variable_builder/fee_predictor.d.ts.map +1 -0
- package/dest/global_variable_builder/fee_predictor.js +128 -0
- package/dest/global_variable_builder/fee_provider.d.ts +21 -0
- package/dest/global_variable_builder/fee_provider.d.ts.map +1 -0
- package/dest/global_variable_builder/fee_provider.js +58 -0
- package/dest/global_variable_builder/global_builder.d.ts +15 -14
- package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
- package/dest/global_variable_builder/global_builder.js +16 -50
- package/dest/global_variable_builder/index.d.ts +4 -2
- package/dest/global_variable_builder/index.d.ts.map +1 -1
- package/dest/global_variable_builder/index.js +2 -0
- package/dest/publisher/config.d.ts +13 -1
- package/dest/publisher/config.d.ts.map +1 -1
- package/dest/publisher/config.js +19 -4
- package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +3 -4
- package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -1
- package/dest/publisher/sequencer-publisher-factory.d.ts +3 -5
- package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
- package/dest/publisher/sequencer-publisher-factory.js +16 -3
- package/dest/publisher/sequencer-publisher.d.ts +55 -43
- package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
- package/dest/publisher/sequencer-publisher.js +182 -118
- package/dest/sequencer/chain_state_overrides.d.ts +25 -0
- package/dest/sequencer/chain_state_overrides.d.ts.map +1 -0
- package/dest/sequencer/chain_state_overrides.js +39 -0
- package/dest/sequencer/checkpoint_proposal_job.d.ts +46 -10
- package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
- package/dest/sequencer/checkpoint_proposal_job.js +671 -225
- package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts +34 -0
- package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts.map +1 -0
- package/dest/sequencer/checkpoint_proposal_job_metrics.js +72 -0
- package/dest/sequencer/checkpoint_voter.d.ts +1 -2
- package/dest/sequencer/checkpoint_voter.d.ts.map +1 -1
- package/dest/sequencer/checkpoint_voter.js +2 -5
- package/dest/sequencer/events.d.ts +7 -1
- package/dest/sequencer/events.d.ts.map +1 -1
- package/dest/sequencer/metrics.d.ts +13 -10
- package/dest/sequencer/metrics.d.ts.map +1 -1
- package/dest/sequencer/metrics.js +45 -20
- package/dest/sequencer/sequencer.d.ts +38 -13
- package/dest/sequencer/sequencer.d.ts.map +1 -1
- package/dest/sequencer/sequencer.js +167 -79
- package/dest/sequencer/timetable.d.ts +17 -3
- package/dest/sequencer/timetable.d.ts.map +1 -1
- package/dest/sequencer/timetable.js +51 -43
- package/dest/sequencer/types.d.ts +2 -2
- package/dest/sequencer/types.d.ts.map +1 -1
- package/dest/test/mock_checkpoint_builder.d.ts +7 -9
- package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
- package/dest/test/mock_checkpoint_builder.js +39 -30
- package/dest/test/utils.d.ts +1 -1
- package/dest/test/utils.d.ts.map +1 -1
- package/dest/test/utils.js +7 -6
- package/package.json +27 -28
- package/src/client/sequencer-client.ts +61 -28
- package/src/config.ts +49 -27
- package/src/global_variable_builder/README.md +44 -0
- package/src/global_variable_builder/fee_predictor.ts +172 -0
- package/src/global_variable_builder/fee_provider.ts +75 -0
- package/src/global_variable_builder/global_builder.ts +26 -62
- package/src/global_variable_builder/index.ts +3 -1
- package/src/publisher/config.ts +38 -4
- package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +3 -1
- package/src/publisher/sequencer-publisher-factory.ts +18 -6
- package/src/publisher/sequencer-publisher.ts +265 -171
- package/src/sequencer/README.md +82 -13
- package/src/sequencer/chain_state_overrides.ts +87 -0
- package/src/sequencer/checkpoint_proposal_job.ts +823 -251
- package/src/sequencer/checkpoint_proposal_job_metrics.ts +128 -0
- package/src/sequencer/checkpoint_voter.ts +1 -12
- package/src/sequencer/events.ts +6 -1
- package/src/sequencer/metrics.ts +57 -24
- package/src/sequencer/sequencer.ts +233 -88
- package/src/sequencer/timetable.ts +64 -52
- package/src/sequencer/types.ts +1 -1
- package/src/test/mock_checkpoint_builder.ts +51 -48
- package/src/test/utils.ts +28 -10
|
@@ -1,6 +1,5 @@
|
|
|
1
|
-
import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
|
|
2
|
-
import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
|
|
3
1
|
import type { EpochCache } from '@aztec/epoch-cache';
|
|
2
|
+
import type { SimulationOverridesPlan } from '@aztec/ethereum/contracts';
|
|
4
3
|
import {
|
|
5
4
|
BlockNumber,
|
|
6
5
|
CheckpointNumber,
|
|
@@ -9,11 +8,17 @@ import {
|
|
|
9
8
|
SlotNumber,
|
|
10
9
|
} from '@aztec/foundation/branded-types';
|
|
11
10
|
import { randomInt } from '@aztec/foundation/crypto/random';
|
|
11
|
+
import {
|
|
12
|
+
flipSignature,
|
|
13
|
+
generateRecoverableSignature,
|
|
14
|
+
generateUnrecoverableSignature,
|
|
15
|
+
} from '@aztec/foundation/crypto/secp256k1-signer';
|
|
12
16
|
import { Fr } from '@aztec/foundation/curves/bn254';
|
|
13
17
|
import { EthAddress } from '@aztec/foundation/eth-address';
|
|
14
18
|
import { Signature } from '@aztec/foundation/eth-signature';
|
|
15
19
|
import { filter } from '@aztec/foundation/iterator';
|
|
16
20
|
import { type Logger, type LoggerBindings, createLogger } from '@aztec/foundation/log';
|
|
21
|
+
import { retryUntil } from '@aztec/foundation/retry';
|
|
17
22
|
import { sleep, sleepUntil } from '@aztec/foundation/sleep';
|
|
18
23
|
import { type DateProvider, Timer } from '@aztec/foundation/timer';
|
|
19
24
|
import { type TypedEventEmitter, isErrorClass, unfreeze } from '@aztec/foundation/types';
|
|
@@ -26,18 +31,26 @@ import {
|
|
|
26
31
|
type L2BlockSink,
|
|
27
32
|
type L2BlockSource,
|
|
28
33
|
MaliciousCommitteeAttestationsAndSigners,
|
|
34
|
+
type ValidateCheckpointResult,
|
|
29
35
|
} from '@aztec/stdlib/block';
|
|
30
|
-
import type
|
|
31
|
-
import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
|
|
36
|
+
import { type Checkpoint, type ProposedCheckpointData, validateCheckpoint } from '@aztec/stdlib/checkpoint';
|
|
37
|
+
import { computeQuorum, getSlotStartBuildTimestamp, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
|
|
32
38
|
import { Gas } from '@aztec/stdlib/gas';
|
|
33
39
|
import {
|
|
34
|
-
|
|
35
|
-
|
|
40
|
+
type BlockBuilderOptions,
|
|
41
|
+
InsufficientValidTxsError,
|
|
36
42
|
type ResolvedSequencerConfig,
|
|
37
43
|
type WorldStateSynchronizer,
|
|
38
44
|
} from '@aztec/stdlib/interfaces/server';
|
|
39
45
|
import { type L1ToL2MessageSource, computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
|
|
40
|
-
import type {
|
|
46
|
+
import type {
|
|
47
|
+
BlockProposal,
|
|
48
|
+
BlockProposalOptions,
|
|
49
|
+
CheckpointAttestation,
|
|
50
|
+
CheckpointProposal,
|
|
51
|
+
CheckpointProposalOptions,
|
|
52
|
+
CoordinationSignatureContext,
|
|
53
|
+
} from '@aztec/stdlib/p2p';
|
|
41
54
|
import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
|
|
42
55
|
import type { L2BlockBuiltStats } from '@aztec/stdlib/stats';
|
|
43
56
|
import { type FailedTx, Tx } from '@aztec/stdlib/tx';
|
|
@@ -48,6 +61,11 @@ import { DutyAlreadySignedError, SlashingProtectionError } from '@aztec/validato
|
|
|
48
61
|
|
|
49
62
|
import type { GlobalVariableBuilder } from '../global_variable_builder/global_builder.js';
|
|
50
63
|
import type { InvalidateCheckpointRequest, SequencerPublisher } from '../publisher/sequencer-publisher.js';
|
|
64
|
+
import {
|
|
65
|
+
buildPipelinedParentSimulationOverridesPlan,
|
|
66
|
+
buildSubmissionSimulationOverridesPlan,
|
|
67
|
+
} from './chain_state_overrides.js';
|
|
68
|
+
import type { CheckpointProposalJobMetricsRecorder } from './checkpoint_proposal_job_metrics.js';
|
|
51
69
|
import { CheckpointVoter } from './checkpoint_voter.js';
|
|
52
70
|
import { SequencerInterruptedError } from './errors.js';
|
|
53
71
|
import type { SequencerEvents } from './events.js';
|
|
@@ -59,6 +77,20 @@ import { SequencerState } from './utils.js';
|
|
|
59
77
|
/** How much time to sleep while waiting for min transactions to accumulate for a block */
|
|
60
78
|
const TXS_POLLING_MS = 500;
|
|
61
79
|
|
|
80
|
+
/** Result from proposeCheckpoint when a checkpoint was successfully built and broadcast. */
|
|
81
|
+
type CheckpointProposalBroadcast = {
|
|
82
|
+
checkpoint: Checkpoint;
|
|
83
|
+
proposal: CheckpointProposal;
|
|
84
|
+
blockProposedAt: number;
|
|
85
|
+
};
|
|
86
|
+
|
|
87
|
+
/** Result after attestation collection and signing, ready for L1 submission. */
|
|
88
|
+
type CheckpointProposalResult = {
|
|
89
|
+
checkpoint: Checkpoint;
|
|
90
|
+
attestations: CommitteeAttestationsAndSigners;
|
|
91
|
+
attestationsSignature: Signature;
|
|
92
|
+
};
|
|
93
|
+
|
|
62
94
|
/**
|
|
63
95
|
* Handles the execution of a checkpoint proposal after the initial preparation phase.
|
|
64
96
|
* This includes building blocks, collecting attestations, and publishing the checkpoint to L1,
|
|
@@ -67,10 +99,22 @@ const TXS_POLLING_MS = 500;
|
|
|
67
99
|
*/
|
|
68
100
|
export class CheckpointProposalJob implements Traceable {
|
|
69
101
|
protected readonly log: Logger;
|
|
102
|
+
private readonly checkpointEventLog: Logger;
|
|
103
|
+
|
|
104
|
+
/** Tracks the fire-and-forget L1 submission promise so it can be awaited during shutdown. */
|
|
105
|
+
private pendingL1Submission: Promise<void> | undefined;
|
|
106
|
+
|
|
107
|
+
/** Pipelined parent chain state used while building and later submitting this checkpoint. */
|
|
108
|
+
private pipelinedParentSimulationOverridesPlan?: SimulationOverridesPlan;
|
|
109
|
+
|
|
110
|
+
private getSignatureContext(): CoordinationSignatureContext {
|
|
111
|
+
return this.signatureContext;
|
|
112
|
+
}
|
|
70
113
|
|
|
71
114
|
constructor(
|
|
72
|
-
private readonly
|
|
73
|
-
private readonly
|
|
115
|
+
private readonly slotNow: SlotNumber,
|
|
116
|
+
private readonly targetSlot: SlotNumber,
|
|
117
|
+
private readonly targetEpoch: EpochNumber,
|
|
74
118
|
private readonly checkpointNumber: CheckpointNumber,
|
|
75
119
|
private readonly syncedToBlockNumber: BlockNumber,
|
|
76
120
|
// TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
|
|
@@ -87,23 +131,49 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
87
131
|
private readonly checkpointsBuilder: FullNodeCheckpointsBuilder,
|
|
88
132
|
private readonly blockSink: L2BlockSink,
|
|
89
133
|
private readonly l1Constants: SequencerRollupConstants,
|
|
134
|
+
private readonly signatureContext: CoordinationSignatureContext,
|
|
90
135
|
protected config: ResolvedSequencerConfig,
|
|
91
136
|
protected timetable: SequencerTimetable,
|
|
92
137
|
private readonly slasherClient: SlasherClientInterface | undefined,
|
|
93
138
|
private readonly epochCache: EpochCache,
|
|
94
139
|
private readonly dateProvider: DateProvider,
|
|
95
140
|
private readonly metrics: SequencerMetrics,
|
|
96
|
-
private readonly
|
|
141
|
+
private readonly checkpointMetrics: CheckpointProposalJobMetricsRecorder,
|
|
142
|
+
protected readonly eventEmitter: TypedEventEmitter<SequencerEvents>,
|
|
97
143
|
private readonly setStateFn: (state: SequencerState, slot?: SlotNumber) => void,
|
|
98
144
|
public readonly tracer: Tracer,
|
|
99
145
|
bindings?: LoggerBindings,
|
|
146
|
+
private readonly proposedCheckpointData?: ProposedCheckpointData,
|
|
100
147
|
) {
|
|
101
|
-
this.log = createLogger('sequencer:checkpoint-proposal', {
|
|
148
|
+
this.log = createLogger('sequencer:checkpoint-proposal', {
|
|
149
|
+
...bindings,
|
|
150
|
+
instanceId: `slot-${this.slotNow}`,
|
|
151
|
+
});
|
|
152
|
+
this.checkpointEventLog = createLogger('sequencer:checkpoint-events', {
|
|
153
|
+
...bindings,
|
|
154
|
+
instanceId: `slot-${this.slotNow}`,
|
|
155
|
+
});
|
|
156
|
+
}
|
|
157
|
+
|
|
158
|
+
/** Awaits the pending L1 submission if one is in progress. Call during shutdown. */
|
|
159
|
+
public async awaitPendingSubmission(): Promise<void> {
|
|
160
|
+
this.log.info('Awaiting pending L1 payload submission');
|
|
161
|
+
await this.pendingL1Submission;
|
|
162
|
+
}
|
|
163
|
+
|
|
164
|
+
private logCheckpointEvent(eventName: string, message: string, fields: Record<string, unknown>): void {
|
|
165
|
+
this.checkpointEventLog.debug(message, {
|
|
166
|
+
eventName: `sequencer-checkpoint-${eventName}`,
|
|
167
|
+
...fields,
|
|
168
|
+
});
|
|
102
169
|
}
|
|
103
170
|
|
|
104
171
|
/**
|
|
105
172
|
* Executes the checkpoint proposal job.
|
|
106
|
-
*
|
|
173
|
+
* Builds blocks, assembles checkpoint, and broadcasts the proposal (blocking).
|
|
174
|
+
* Attestation collection, signing, and L1 submission are backgrounded so the
|
|
175
|
+
* work loop can return to IDLE immediately for consecutive slot proposals.
|
|
176
|
+
* Returns the built checkpoint if successful, undefined otherwise.
|
|
107
177
|
*/
|
|
108
178
|
@trackSpan('CheckpointProposalJob.execute')
|
|
109
179
|
public async execute(): Promise<Checkpoint | undefined> {
|
|
@@ -111,7 +181,7 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
111
181
|
// In fisherman mode, we simulate slashing but don't actually publish to L1
|
|
112
182
|
// These are constant for the whole slot, so we only enqueue them once
|
|
113
183
|
const votesPromises = new CheckpointVoter(
|
|
114
|
-
this.
|
|
184
|
+
this.targetSlot,
|
|
115
185
|
this.publisher,
|
|
116
186
|
this.attestorAddress,
|
|
117
187
|
this.validatorClient,
|
|
@@ -122,33 +192,304 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
122
192
|
this.log,
|
|
123
193
|
).enqueueVotes();
|
|
124
194
|
|
|
125
|
-
// Build
|
|
126
|
-
|
|
195
|
+
// Build blocks, assemble checkpoint, and broadcast proposal (BLOCKING).
|
|
196
|
+
// Returns after broadcast — attestation collection is deferred.
|
|
197
|
+
const broadcast = await this.proposeCheckpoint();
|
|
127
198
|
|
|
128
|
-
|
|
129
|
-
|
|
130
|
-
|
|
131
|
-
|
|
132
|
-
|
|
199
|
+
if (!broadcast) {
|
|
200
|
+
await Promise.all(votesPromises);
|
|
201
|
+
// Still submit votes even without a checkpoint
|
|
202
|
+
if (!this.config.fishermanMode) {
|
|
203
|
+
this.pendingL1Submission = this.publisher.sendRequestsAt(this.dateProvider.nowAsDate()).then(() => {});
|
|
204
|
+
}
|
|
205
|
+
return undefined;
|
|
133
206
|
}
|
|
134
207
|
|
|
208
|
+
const { checkpoint } = broadcast;
|
|
209
|
+
this.metrics.recordCheckpointProposalSuccess();
|
|
210
|
+
|
|
135
211
|
// Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
|
|
136
212
|
if (this.config.fishermanMode) {
|
|
137
213
|
await this.handleCheckpointEndAsFisherman(checkpoint);
|
|
138
|
-
return;
|
|
214
|
+
return checkpoint;
|
|
139
215
|
}
|
|
140
216
|
|
|
141
|
-
//
|
|
142
|
-
|
|
143
|
-
|
|
144
|
-
|
|
145
|
-
|
|
146
|
-
|
|
147
|
-
|
|
148
|
-
|
|
149
|
-
|
|
150
|
-
|
|
151
|
-
|
|
217
|
+
// Background the attestation → signing → L1 pipeline so the work loop is unblocked
|
|
218
|
+
this.pendingL1Submission = this.waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises);
|
|
219
|
+
|
|
220
|
+
// Return the built checkpoint immediately — the work loop is now unblocked
|
|
221
|
+
return checkpoint;
|
|
222
|
+
}
|
|
223
|
+
|
|
224
|
+
/**
|
|
225
|
+
* Background pipeline: collects attestations, signs them, enqueues the checkpoint, and submits to L1.
|
|
226
|
+
* Runs as a fire-and-forget task stored in `pendingL1Submission` so the work loop is unblocked.
|
|
227
|
+
*/
|
|
228
|
+
private async waitForAttestationsAndEnqueueSubmissionAsync(
|
|
229
|
+
broadcast: CheckpointProposalBroadcast,
|
|
230
|
+
votesPromises: Promise<unknown>[],
|
|
231
|
+
): Promise<void> {
|
|
232
|
+
const { checkpoint } = broadcast;
|
|
233
|
+
const isPipelining = this.epochCache.isProposerPipeliningEnabled();
|
|
234
|
+
|
|
235
|
+
try {
|
|
236
|
+
// Wait for all votes actions, enqueued at the beginning, to resolve
|
|
237
|
+
await Promise.all(votesPromises);
|
|
238
|
+
|
|
239
|
+
// Try to collect attestations from the committee
|
|
240
|
+
const signedAttestations = await this.getSignedCommitteeAttestations(broadcast);
|
|
241
|
+
|
|
242
|
+
// If pipelining, wait for the previous checkpoint to land on L1 before submitting,
|
|
243
|
+
// so we can check it matches the proposed checkpoint we used as parent, and has valid attestations.
|
|
244
|
+
if (signedAttestations && (!isPipelining || (await this.waitForValidParentCheckpointOnL1()))) {
|
|
245
|
+
await this.enqueueCheckpointForSubmission({ checkpoint, ...signedAttestations });
|
|
246
|
+
}
|
|
247
|
+
|
|
248
|
+
// If we failed to collect attestations, at least check if we need to issue an invalidation
|
|
249
|
+
// Note that if we are not pipelining, we enqueued the invalidation at the beginning
|
|
250
|
+
if (!signedAttestations && isPipelining && (await this.waitForSyncedL2SlotNumber(this.slotNow))) {
|
|
251
|
+
const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
|
|
252
|
+
if (!validationStatus.valid) {
|
|
253
|
+
this.log.warn(
|
|
254
|
+
`Checkpoint ${validationStatus.checkpoint.checkpointNumber} has invalid attestations, enqueuing invalidation in spite of attestation collection failure`,
|
|
255
|
+
{ checkpoint: validationStatus.checkpoint, reason: validationStatus.reason },
|
|
256
|
+
);
|
|
257
|
+
await this.enqueueInvalidation(validationStatus);
|
|
258
|
+
}
|
|
259
|
+
}
|
|
260
|
+
|
|
261
|
+
// Send whatever was enqueued: votes + (propose | invalidation | nothing).
|
|
262
|
+
// Compute the earliest time to submit: pipeline slot start when pipelining, now otherwise.
|
|
263
|
+
const submitAfter = isPipelining
|
|
264
|
+
? new Date(Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) * 1000)
|
|
265
|
+
: new Date(this.dateProvider.now());
|
|
266
|
+
|
|
267
|
+
const l1Response = await this.publisher.sendRequestsAt(submitAfter);
|
|
268
|
+
const proposedAction = l1Response?.successfulActions.find(a => a === 'propose');
|
|
269
|
+
if (proposedAction) {
|
|
270
|
+
this.logCheckpointEvent('published', `Checkpoint published for slot ${this.targetSlot}`, {
|
|
271
|
+
slot: this.targetSlot,
|
|
272
|
+
checkpointNumber: this.checkpointNumber,
|
|
273
|
+
successfulActions: l1Response?.successfulActions,
|
|
274
|
+
sentActions: l1Response?.sentActions,
|
|
275
|
+
});
|
|
276
|
+
this.eventEmitter.emit('checkpoint-published', { checkpoint: this.checkpointNumber, slot: this.targetSlot });
|
|
277
|
+
const coinbase = checkpoint.header.coinbase;
|
|
278
|
+
await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
|
|
279
|
+
} else {
|
|
280
|
+
this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, {
|
|
281
|
+
slot: this.targetSlot,
|
|
282
|
+
checkpointNumber: this.checkpointNumber,
|
|
283
|
+
successfulActions: l1Response?.successfulActions,
|
|
284
|
+
failedActions: l1Response?.failedActions,
|
|
285
|
+
sentActions: l1Response?.sentActions,
|
|
286
|
+
expiredActions: l1Response?.expiredActions,
|
|
287
|
+
reason: 'propose_action_not_successful',
|
|
288
|
+
});
|
|
289
|
+
this.log.warn(`Checkpoint publish failed for slot ${this.targetSlot}`, {
|
|
290
|
+
slot: this.targetSlot,
|
|
291
|
+
checkpointNumber: this.checkpointNumber,
|
|
292
|
+
successfulActions: l1Response?.successfulActions,
|
|
293
|
+
failedActions: l1Response?.failedActions,
|
|
294
|
+
sentActions: l1Response?.sentActions,
|
|
295
|
+
expiredActions: l1Response?.expiredActions,
|
|
296
|
+
reason: 'propose_action_not_successful',
|
|
297
|
+
});
|
|
298
|
+
this.eventEmitter.emit('checkpoint-publish-failed', { ...l1Response, slot: this.targetSlot });
|
|
299
|
+
if (isPipelining) {
|
|
300
|
+
this.metrics.recordPipelineDiscard();
|
|
301
|
+
}
|
|
302
|
+
}
|
|
303
|
+
} catch (err) {
|
|
304
|
+
if (err instanceof SequencerInterruptedError) {
|
|
305
|
+
return;
|
|
306
|
+
}
|
|
307
|
+
this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, {
|
|
308
|
+
slot: this.targetSlot,
|
|
309
|
+
checkpointNumber: this.checkpointNumber,
|
|
310
|
+
reason: err instanceof Error ? err.message : String(err),
|
|
311
|
+
});
|
|
312
|
+
this.log.error(`Background attestation/L1 pipeline failed for slot ${this.targetSlot}`, err, {
|
|
313
|
+
slot: this.targetSlot,
|
|
314
|
+
checkpointNumber: this.checkpointNumber,
|
|
315
|
+
reason: err instanceof Error ? err.message : String(err),
|
|
316
|
+
});
|
|
317
|
+
this.eventEmitter.emit('checkpoint-publish-failed', { slot: this.targetSlot });
|
|
318
|
+
if (isPipelining) {
|
|
319
|
+
this.metrics.recordPipelineDiscard();
|
|
320
|
+
}
|
|
321
|
+
}
|
|
322
|
+
}
|
|
323
|
+
|
|
324
|
+
/** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */
|
|
325
|
+
private async enqueueCheckpointForSubmission(result: CheckpointProposalResult): Promise<void> {
|
|
326
|
+
const { checkpoint, attestations, attestationsSignature } = result;
|
|
327
|
+
|
|
328
|
+
this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.targetSlot);
|
|
329
|
+
const aztecSlotDuration = this.l1Constants.slotDuration;
|
|
330
|
+
const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
|
|
331
|
+
const txTimeoutAt = new Date((submissionSlotStart + aztecSlotDuration) * 1000);
|
|
332
|
+
|
|
333
|
+
// If we have been configured to potentially skip publishing checkpoint then roll the dice here
|
|
334
|
+
if (
|
|
335
|
+
this.config.skipPublishingCheckpointsPercent !== undefined &&
|
|
336
|
+
this.config.skipPublishingCheckpointsPercent > 0
|
|
337
|
+
) {
|
|
338
|
+
const roll = Math.max(0, randomInt(100));
|
|
339
|
+
if (roll < this.config.skipPublishingCheckpointsPercent) {
|
|
340
|
+
this.log.warn(
|
|
341
|
+
`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${roll}`,
|
|
342
|
+
);
|
|
343
|
+
return;
|
|
344
|
+
}
|
|
345
|
+
}
|
|
346
|
+
|
|
347
|
+
const isPipelining = this.epochCache.isProposerPipeliningEnabled();
|
|
348
|
+
const submissionSimulationOverridesPlan = buildSubmissionSimulationOverridesPlan({
|
|
349
|
+
pipelinedParentPlan: this.pipelinedParentSimulationOverridesPlan,
|
|
350
|
+
invalidateToPendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
|
|
351
|
+
lastArchiveRoot: checkpoint.header.lastArchiveRoot,
|
|
352
|
+
pipeliningEnabled: isPipelining,
|
|
353
|
+
});
|
|
354
|
+
|
|
355
|
+
await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
|
|
356
|
+
txTimeoutAt,
|
|
357
|
+
...(submissionSimulationOverridesPlan ? { simulationOverridesPlan: submissionSimulationOverridesPlan } : {}),
|
|
358
|
+
});
|
|
359
|
+
}
|
|
360
|
+
|
|
361
|
+
/**
|
|
362
|
+
* Wait until the archiver syncs past the given L2 slot number.
|
|
363
|
+
* The deadline is the end of `this.targetSlot`, beyond which any pipelined work would miss its
|
|
364
|
+
* L1 submission window and is no longer useful.
|
|
365
|
+
*/
|
|
366
|
+
private async waitForSyncedL2SlotNumber(waitForSlot: SlotNumber): Promise<boolean> {
|
|
367
|
+
const targetSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
|
|
368
|
+
const targetSlotEndMs = (targetSlotStart + this.l1Constants.slotDuration) * 1000;
|
|
369
|
+
const syncDelayTolerance = this.l1Constants.ethereumSlotDuration * 2 * 1000;
|
|
370
|
+
const timeoutSeconds = Math.max(0.1, (targetSlotEndMs + syncDelayTolerance - this.dateProvider.now()) / 1000);
|
|
371
|
+
|
|
372
|
+
try {
|
|
373
|
+
return await retryUntil(
|
|
374
|
+
async () => {
|
|
375
|
+
const syncedSlot = await this.l2BlockSource.getSyncedL2SlotNumber();
|
|
376
|
+
return syncedSlot !== undefined && syncedSlot >= waitForSlot;
|
|
377
|
+
},
|
|
378
|
+
`archiver sync past slot ${waitForSlot}`,
|
|
379
|
+
timeoutSeconds,
|
|
380
|
+
0.2,
|
|
381
|
+
);
|
|
382
|
+
} catch {
|
|
383
|
+
this.log.warn(
|
|
384
|
+
`Archiver did not sync L1 past slot ${waitForSlot} before slot ${this.targetSlot} expired, discarding pipelined work`,
|
|
385
|
+
{ checkpointNumber: this.checkpointNumber },
|
|
386
|
+
);
|
|
387
|
+
this.emitPipelinedCheckpointDiscarded('archiver-sync-timeout');
|
|
388
|
+
return false;
|
|
389
|
+
}
|
|
390
|
+
}
|
|
391
|
+
|
|
392
|
+
/**
|
|
393
|
+
* Waits for the parent checkpoint to land on L1 before submitting a pipelined checkpoint.
|
|
394
|
+
* Polls until the archiver has synced L1 past the parent's slot, then verifies:
|
|
395
|
+
* - If we built on a proposed parent: it must have landed on L1 with matching hash and valid attestations.
|
|
396
|
+
* - If we built without a proposed parent: no new checkpoint must have appeared for that slot.
|
|
397
|
+
* If the parent has invalid attestations, enqueues an invalidation. Returns whether to proceed with the proposal.
|
|
398
|
+
*/
|
|
399
|
+
protected async waitForValidParentCheckpointOnL1(): Promise<boolean> {
|
|
400
|
+
const parentCheckpointNumber = CheckpointNumber(this.checkpointNumber - 1);
|
|
401
|
+
|
|
402
|
+
// Wait until archiver has synced L1 past the parent's slot (slotNow)
|
|
403
|
+
if (!(await this.waitForSyncedL2SlotNumber(this.slotNow))) {
|
|
404
|
+
return false;
|
|
405
|
+
}
|
|
406
|
+
|
|
407
|
+
const tips = await this.l2BlockSource.getL2Tips();
|
|
408
|
+
const checkpointedNumber = tips.checkpointed.checkpoint.number;
|
|
409
|
+
|
|
410
|
+
// We built on top of a proposed checkpoint. Verify it landed on L1 as expected.
|
|
411
|
+
if (this.proposedCheckpointData) {
|
|
412
|
+
// After syncing from L1 we see the chain tip has invalid attestations. This means the parent checkpoint was posted
|
|
413
|
+
// with invalid attestations, or it built on top of something with invalid attestations and didnt invalidate them.
|
|
414
|
+
// Either way, we thought our parent would be valid, so we have to throw away our work. But at least we'll try and
|
|
415
|
+
// invalidate on L1 so we clean up the chain for the next proposer. And we'll slash them, but that's handled elsewhere.
|
|
416
|
+
const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
|
|
417
|
+
if (!validationStatus.valid) {
|
|
418
|
+
this.log.warn(
|
|
419
|
+
`Parent checkpoint ${parentCheckpointNumber} has invalid attestations, discarding pipelined work`,
|
|
420
|
+
{ checkpointNumber: this.checkpointNumber, reason: validationStatus.reason },
|
|
421
|
+
);
|
|
422
|
+
this.emitPipelinedCheckpointDiscarded('parent-invalid-attestations');
|
|
423
|
+
await this.enqueueInvalidation(validationStatus);
|
|
424
|
+
return false;
|
|
425
|
+
}
|
|
426
|
+
|
|
427
|
+
// The pending chain is valid. But did the parent checkpoint land on L1 at all?
|
|
428
|
+
if (checkpointedNumber < parentCheckpointNumber) {
|
|
429
|
+
this.log.warn(`Parent checkpoint ${parentCheckpointNumber} did not land on L1, discarding pipelined work`, {
|
|
430
|
+
checkpointNumber: this.checkpointNumber,
|
|
431
|
+
checkpointedNumber,
|
|
432
|
+
});
|
|
433
|
+
this.emitPipelinedCheckpointDiscarded('parent-not-on-l1');
|
|
434
|
+
return false;
|
|
435
|
+
}
|
|
436
|
+
|
|
437
|
+
// It landed. But is it the one we were expecting?
|
|
438
|
+
const expectedHash = this.proposedCheckpointData.header.hash().toString();
|
|
439
|
+
if (tips.checkpointed.checkpoint.hash !== expectedHash) {
|
|
440
|
+
this.log.warn(`Parent checkpoint ${parentCheckpointNumber} hash mismatch on L1, discarding pipelined work`, {
|
|
441
|
+
checkpointNumber: this.checkpointNumber,
|
|
442
|
+
expectedHash,
|
|
443
|
+
actualHash: tips.checkpointed.checkpoint.hash,
|
|
444
|
+
});
|
|
445
|
+
this.emitPipelinedCheckpointDiscarded('parent-hash-mismatch');
|
|
446
|
+
return false;
|
|
447
|
+
}
|
|
448
|
+
|
|
449
|
+
return true;
|
|
450
|
+
} else {
|
|
451
|
+
// We didn't see a proposed checkpoint at build time, so we built on checkpointed parent from two slots ago.
|
|
452
|
+
// But if a new checkpoint for the previous slot appeared on L1 in the meantime, our checkpoint assumed the wrong parent,
|
|
453
|
+
// so we have to discard our work. This can happen if we're somehow cut off from p2p and fail to see the checkpoint
|
|
454
|
+
// proposal for the previous slot.
|
|
455
|
+
if (checkpointedNumber > parentCheckpointNumber) {
|
|
456
|
+
this.log.warn(
|
|
457
|
+
`Unexpected checkpoint ${checkpointedNumber} landed on L1 after we built on top of parent ${parentCheckpointNumber}, discarding pipelined work`,
|
|
458
|
+
{ checkpointNumber: this.checkpointNumber, checkpointedNumber },
|
|
459
|
+
);
|
|
460
|
+
this.emitPipelinedCheckpointDiscarded('unexpected-parent-appeared');
|
|
461
|
+
return false;
|
|
462
|
+
}
|
|
463
|
+
|
|
464
|
+
return true;
|
|
465
|
+
}
|
|
466
|
+
}
|
|
467
|
+
|
|
468
|
+
/** Emits the pipelined-checkpoint-discarded event and records the metric. */
|
|
469
|
+
private emitPipelinedCheckpointDiscarded(reason: string): void {
|
|
470
|
+
this.metrics.recordPipelineParentCheckpointMismatch(reason);
|
|
471
|
+
this.eventEmitter.emit('pipelined-checkpoint-discarded', {
|
|
472
|
+
slot: this.targetSlot,
|
|
473
|
+
checkpointNumber: this.checkpointNumber,
|
|
474
|
+
reason,
|
|
475
|
+
});
|
|
476
|
+
}
|
|
477
|
+
|
|
478
|
+
/** Simulates and enqueues an invalidation request for the invalid parent checkpoint. */
|
|
479
|
+
private async enqueueInvalidation(validationStatus: ValidateCheckpointResult): Promise<void> {
|
|
480
|
+
if (this.config.skipInvalidateBlockAsProposer) {
|
|
481
|
+
this.log.warn(`Skipping checkpoint invalidation as proposer due to test configuration`);
|
|
482
|
+
return;
|
|
483
|
+
}
|
|
484
|
+
const invalidateRequest = await this.publisher.simulateInvalidateCheckpoint(validationStatus);
|
|
485
|
+
if (invalidateRequest) {
|
|
486
|
+
const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
|
|
487
|
+
const txTimeoutAt = new Date((submissionSlotStart + this.l1Constants.slotDuration) * 1000);
|
|
488
|
+
this.publisher.enqueueInvalidateCheckpoint(invalidateRequest, { txTimeoutAt });
|
|
489
|
+
} else {
|
|
490
|
+
this.log.info(`Invalidation simulation returned undefined, checkpoint may have been removed already`, {
|
|
491
|
+
checkpointNumber: this.checkpointNumber,
|
|
492
|
+
});
|
|
152
493
|
}
|
|
153
494
|
}
|
|
154
495
|
|
|
@@ -156,29 +497,63 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
156
497
|
return {
|
|
157
498
|
// nullish operator needed for tests
|
|
158
499
|
[Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
|
|
159
|
-
[Attributes.SLOT_NUMBER]: this.
|
|
500
|
+
[Attributes.SLOT_NUMBER]: this.targetSlot,
|
|
160
501
|
};
|
|
161
502
|
})
|
|
162
|
-
private async proposeCheckpoint(): Promise<
|
|
503
|
+
private async proposeCheckpoint(): Promise<CheckpointProposalBroadcast | undefined> {
|
|
163
504
|
try {
|
|
505
|
+
const now = this.dateProvider.now();
|
|
506
|
+
if (this.epochCache.isProposerPipeliningEnabled() && this.proposedCheckpointData) {
|
|
507
|
+
// Measure against the wall-clock slot whose build window we are currently using.
|
|
508
|
+
// In pipelining mode `targetSlot` is intentionally one slot ahead, which makes the
|
|
509
|
+
// target-slot boundary a full slot away from the actual build start time.
|
|
510
|
+
const slotBoundaryMs = Number(getTimestampForSlot(this.slotNow, this.l1Constants)) * 1000;
|
|
511
|
+
this.checkpointMetrics.recordPipelinedCheckpointBuildStartOffsetFromSlotBoundary(now - slotBoundaryMs);
|
|
512
|
+
}
|
|
513
|
+
this.checkpointMetrics.startCheckpointTiming(now);
|
|
514
|
+
|
|
164
515
|
// Get operator configured coinbase and fee recipient for this attestor
|
|
165
516
|
const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
|
|
166
517
|
const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
|
|
167
518
|
|
|
168
519
|
// Start the checkpoint
|
|
169
|
-
this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.
|
|
170
|
-
this.
|
|
520
|
+
this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.targetSlot);
|
|
521
|
+
this.logCheckpointEvent('slot-started', `Starting checkpoint proposal for slot ${this.targetSlot}`, {
|
|
522
|
+
buildSlot: this.slotNow,
|
|
523
|
+
submissionSlot: this.targetSlot,
|
|
524
|
+
slot: this.targetSlot,
|
|
525
|
+
checkpointNumber: this.checkpointNumber,
|
|
526
|
+
pipelining: this.epochCache.isProposerPipeliningEnabled(),
|
|
527
|
+
proposer: this.proposer?.toString(),
|
|
528
|
+
attestorAddress: this.attestorAddress.toString(),
|
|
529
|
+
publisherAddress: this.publisher.getSenderAddress().toString(),
|
|
530
|
+
coinbase: coinbase.toString(),
|
|
531
|
+
});
|
|
532
|
+
this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
|
|
171
533
|
|
|
172
534
|
// Enqueues checkpoint invalidation (constant for the whole slot)
|
|
173
535
|
if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
|
|
174
536
|
this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
|
|
175
537
|
}
|
|
176
538
|
|
|
177
|
-
// Create checkpoint builder for the slot
|
|
539
|
+
// Create checkpoint builder for the slot.
|
|
540
|
+
// When pipelining, force the proposed checkpoint number and fee header to our parent so the
|
|
541
|
+
// fee computation sees the same chain tip that L1 will see once the previous pipelined checkpoint lands.
|
|
542
|
+
const isPipelining = this.epochCache.isProposerPipeliningEnabled();
|
|
543
|
+
this.pipelinedParentSimulationOverridesPlan = isPipelining
|
|
544
|
+
? await buildPipelinedParentSimulationOverridesPlan({
|
|
545
|
+
checkpointNumber: this.checkpointNumber,
|
|
546
|
+
proposedCheckpointData: this.proposedCheckpointData,
|
|
547
|
+
rollup: this.publisher.rollupContract,
|
|
548
|
+
log: this.log,
|
|
549
|
+
})
|
|
550
|
+
: undefined;
|
|
551
|
+
|
|
178
552
|
const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(
|
|
179
553
|
coinbase,
|
|
180
554
|
feeRecipient,
|
|
181
|
-
this.
|
|
555
|
+
this.targetSlot,
|
|
556
|
+
this.pipelinedParentSimulationOverridesPlan,
|
|
182
557
|
);
|
|
183
558
|
|
|
184
559
|
// Collect L1 to L2 messages for the checkpoint and compute their hash
|
|
@@ -186,7 +561,7 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
186
561
|
const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
|
|
187
562
|
|
|
188
563
|
// Collect the out hashes of all the checkpoints before this one in the same epoch
|
|
189
|
-
const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.
|
|
564
|
+
const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.targetEpoch))
|
|
190
565
|
.filter(c => c.checkpointNumber < this.checkpointNumber)
|
|
191
566
|
.map(c => c.checkpointOutHash);
|
|
192
567
|
|
|
@@ -219,7 +594,7 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
219
594
|
};
|
|
220
595
|
|
|
221
596
|
let blocksInCheckpoint: L2Block[] = [];
|
|
222
|
-
let blockPendingBroadcast:
|
|
597
|
+
let blockPendingBroadcast: BlockProposal | undefined = undefined;
|
|
223
598
|
const checkpointBuildTimer = new Timer();
|
|
224
599
|
|
|
225
600
|
try {
|
|
@@ -243,126 +618,136 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
243
618
|
}
|
|
244
619
|
|
|
245
620
|
if (blocksInCheckpoint.length === 0) {
|
|
246
|
-
this.
|
|
247
|
-
|
|
621
|
+
this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
|
|
622
|
+
slot: this.targetSlot,
|
|
623
|
+
checkpointNumber: this.checkpointNumber,
|
|
624
|
+
reason: 'no_blocks_built',
|
|
625
|
+
});
|
|
626
|
+
this.log.warn(`No blocks were built for slot ${this.targetSlot}`, {
|
|
627
|
+
slot: this.targetSlot,
|
|
628
|
+
checkpointNumber: this.checkpointNumber,
|
|
629
|
+
reason: 'no_blocks_built',
|
|
630
|
+
});
|
|
631
|
+
this.eventEmitter.emit('checkpoint-empty', { slot: this.targetSlot });
|
|
248
632
|
return undefined;
|
|
249
633
|
}
|
|
250
634
|
|
|
251
635
|
const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
|
|
252
636
|
if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
|
|
637
|
+
this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
|
|
638
|
+
slot: this.targetSlot,
|
|
639
|
+
checkpointNumber: this.checkpointNumber,
|
|
640
|
+
blocksBuilt: blocksInCheckpoint.length,
|
|
641
|
+
minBlocksForCheckpoint,
|
|
642
|
+
reason: 'min_blocks_not_met',
|
|
643
|
+
});
|
|
253
644
|
this.log.warn(
|
|
254
645
|
`Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`,
|
|
255
|
-
{
|
|
646
|
+
{
|
|
647
|
+
slot: this.targetSlot,
|
|
648
|
+
checkpointNumber: this.checkpointNumber,
|
|
649
|
+
blocksBuilt: blocksInCheckpoint.length,
|
|
650
|
+
minBlocksForCheckpoint,
|
|
651
|
+
reason: 'min_blocks_not_met',
|
|
652
|
+
},
|
|
256
653
|
);
|
|
257
654
|
return undefined;
|
|
258
655
|
}
|
|
259
656
|
|
|
260
657
|
// Assemble and broadcast the checkpoint proposal, including the last block that was not
|
|
261
658
|
// broadcasted yet, and wait to collect the committee attestations.
|
|
262
|
-
this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.
|
|
659
|
+
this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.targetSlot);
|
|
263
660
|
const checkpoint = await checkpointBuilder.completeCheckpoint();
|
|
264
661
|
|
|
662
|
+
// Final validation: per-block limits are only checked if the operator set them explicitly.
|
|
663
|
+
// Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
|
|
664
|
+
try {
|
|
665
|
+
validateCheckpoint(checkpoint, {
|
|
666
|
+
rollupManaLimit: this.l1Constants.rollupManaLimit,
|
|
667
|
+
maxL2BlockGas: this.config.maxL2BlockGas,
|
|
668
|
+
maxDABlockGas: this.config.maxDABlockGas,
|
|
669
|
+
maxTxsPerBlock: this.config.maxTxsPerBlock,
|
|
670
|
+
maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint,
|
|
671
|
+
});
|
|
672
|
+
} catch (err) {
|
|
673
|
+
this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
|
|
674
|
+
slot: this.targetSlot,
|
|
675
|
+
checkpointNumber: this.checkpointNumber,
|
|
676
|
+
blocksBuilt: blocksInCheckpoint.length,
|
|
677
|
+
reason: 'invalid_checkpoint',
|
|
678
|
+
checkpoint: checkpoint.header.toInspect(),
|
|
679
|
+
});
|
|
680
|
+
this.log.error(`Built an invalid checkpoint at slot ${this.slotNow} (skipping proposal)`, err, {
|
|
681
|
+
slot: this.targetSlot,
|
|
682
|
+
checkpointNumber: this.checkpointNumber,
|
|
683
|
+
blocksBuilt: blocksInCheckpoint.length,
|
|
684
|
+
reason: 'invalid_checkpoint',
|
|
685
|
+
checkpoint: checkpoint.header.toInspect(),
|
|
686
|
+
});
|
|
687
|
+
return undefined;
|
|
688
|
+
}
|
|
689
|
+
|
|
265
690
|
// Record checkpoint-level build metrics
|
|
266
|
-
this.
|
|
691
|
+
this.checkpointMetrics.recordCheckpointBuild(
|
|
267
692
|
checkpointBuildTimer.ms(),
|
|
268
693
|
blocksInCheckpoint.length,
|
|
269
694
|
checkpoint.getStats().txCount,
|
|
270
695
|
Number(checkpoint.header.totalManaUsed.toBigInt()),
|
|
271
696
|
);
|
|
697
|
+
this.logCheckpointEvent('built', `Checkpoint built for slot ${this.targetSlot}`, {
|
|
698
|
+
slot: this.targetSlot,
|
|
699
|
+
buildSlot: this.slotNow,
|
|
700
|
+
checkpointNumber: this.checkpointNumber,
|
|
701
|
+
proposer: this.proposer?.toString(),
|
|
702
|
+
attestorAddress: this.attestorAddress.toString(),
|
|
703
|
+
publisherAddress: this.publisher.getSenderAddress().toString(),
|
|
704
|
+
blocksBuilt: blocksInCheckpoint.length,
|
|
705
|
+
txCount: checkpoint.getStats().txCount,
|
|
706
|
+
totalMana: Number(checkpoint.header.totalManaUsed.toBigInt()),
|
|
707
|
+
});
|
|
272
708
|
|
|
273
|
-
//
|
|
709
|
+
// In fisherman mode, return the checkpoint without broadcasting or collecting attestations
|
|
274
710
|
if (this.config.fishermanMode) {
|
|
275
711
|
this.log.info(
|
|
276
|
-
`Built checkpoint for slot ${this.
|
|
712
|
+
`Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` +
|
|
277
713
|
`Skipping proposal in fisherman mode.`,
|
|
278
714
|
{
|
|
279
|
-
slot: this.
|
|
715
|
+
slot: this.targetSlot,
|
|
280
716
|
checkpoint: checkpoint.header.toInspect(),
|
|
281
717
|
blocksBuilt: blocksInCheckpoint.length,
|
|
282
718
|
},
|
|
283
719
|
);
|
|
284
720
|
this.metrics.recordCheckpointSuccess();
|
|
285
|
-
|
|
721
|
+
// Return a broadcast result with a dummy proposal — fisherman mode skips attestation collection
|
|
722
|
+
return { checkpoint, proposal: undefined!, blockProposedAt: this.dateProvider.now() };
|
|
286
723
|
}
|
|
287
724
|
|
|
288
|
-
// Include the block pending broadcast in the checkpoint proposal if any
|
|
289
|
-
const lastBlock = blockPendingBroadcast && {
|
|
290
|
-
blockHeader: blockPendingBroadcast.block.header,
|
|
291
|
-
indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
|
|
292
|
-
txs: blockPendingBroadcast.txs,
|
|
293
|
-
};
|
|
294
|
-
|
|
295
725
|
// Create the checkpoint proposal and broadcast it
|
|
296
726
|
const proposal = await this.validatorClient.createCheckpointProposal(
|
|
297
727
|
checkpoint.header,
|
|
298
728
|
checkpoint.archive.root,
|
|
729
|
+
this.checkpointNumber,
|
|
299
730
|
feeAssetPriceModifier,
|
|
300
|
-
|
|
731
|
+
blockPendingBroadcast,
|
|
301
732
|
this.proposer,
|
|
302
733
|
checkpointProposalOptions,
|
|
303
734
|
);
|
|
304
735
|
|
|
305
736
|
const blockProposedAt = this.dateProvider.now();
|
|
306
|
-
|
|
307
|
-
|
|
308
|
-
|
|
309
|
-
const attestations = await this.waitForAttestations(proposal);
|
|
310
|
-
const blockAttestedAt = this.dateProvider.now();
|
|
311
|
-
|
|
312
|
-
this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
|
|
313
|
-
|
|
314
|
-
// Proposer must sign over the attestations before pushing them to L1
|
|
315
|
-
const signer = this.proposer ?? this.publisher.getSenderAddress();
|
|
316
|
-
let attestationsSignature: Signature;
|
|
317
|
-
try {
|
|
318
|
-
attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
|
|
319
|
-
attestations,
|
|
320
|
-
signer,
|
|
321
|
-
this.slot,
|
|
322
|
-
this.checkpointNumber,
|
|
323
|
-
);
|
|
324
|
-
} catch (err) {
|
|
325
|
-
// We shouldn't really get here since we yield to another HA node
|
|
326
|
-
// as soon as we see these errors when creating block or checkpoint proposals.
|
|
327
|
-
if (this.handleHASigningError(err, 'Attestations signature')) {
|
|
328
|
-
return undefined;
|
|
329
|
-
}
|
|
330
|
-
throw err;
|
|
331
|
-
}
|
|
332
|
-
|
|
333
|
-
// Enqueue publishing the checkpoint to L1
|
|
334
|
-
this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
|
|
335
|
-
const aztecSlotDuration = this.l1Constants.slotDuration;
|
|
336
|
-
const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
|
|
337
|
-
const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
|
|
338
|
-
|
|
339
|
-
// If we have been configured to potentially skip publishing checkpoint then roll the dice here
|
|
340
|
-
if (
|
|
341
|
-
this.config.skipPublishingCheckpointsPercent !== undefined &&
|
|
342
|
-
this.config.skipPublishingCheckpointsPercent > 0
|
|
343
|
-
) {
|
|
344
|
-
const result = Math.max(0, randomInt(100));
|
|
345
|
-
if (result < this.config.skipPublishingCheckpointsPercent) {
|
|
346
|
-
this.log.warn(
|
|
347
|
-
`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${result}`,
|
|
348
|
-
);
|
|
349
|
-
return checkpoint;
|
|
350
|
-
}
|
|
737
|
+
if (!this.config.skipBroadcastProposals) {
|
|
738
|
+
await this.p2pClient.broadcastCheckpointProposal(proposal);
|
|
739
|
+
this.checkpointMetrics.noteCheckpointBroadcast(this.dateProvider.now());
|
|
351
740
|
}
|
|
352
741
|
|
|
353
|
-
|
|
354
|
-
|
|
355
|
-
forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
|
|
356
|
-
});
|
|
357
|
-
|
|
358
|
-
return checkpoint;
|
|
742
|
+
// Return immediately after broadcast — attestation collection happens in the background
|
|
743
|
+
return { checkpoint, proposal, blockProposedAt };
|
|
359
744
|
} catch (err) {
|
|
360
745
|
if (err && (err instanceof DutyAlreadySignedError || err instanceof SlashingProtectionError)) {
|
|
361
746
|
// swallow this error. It's already been logged by a function deeper in the stack
|
|
362
747
|
return undefined;
|
|
363
748
|
}
|
|
364
749
|
|
|
365
|
-
this.log.error(`Error building checkpoint at slot ${this.
|
|
750
|
+
this.log.error(`Error building checkpoint at slot ${this.targetSlot}`, err);
|
|
366
751
|
return undefined;
|
|
367
752
|
}
|
|
368
753
|
}
|
|
@@ -378,17 +763,14 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
378
763
|
blockProposalOptions: BlockProposalOptions,
|
|
379
764
|
): Promise<{
|
|
380
765
|
blocksInCheckpoint: L2Block[];
|
|
381
|
-
blockPendingBroadcast:
|
|
766
|
+
blockPendingBroadcast: BlockProposal | undefined;
|
|
382
767
|
}> {
|
|
383
768
|
const blocksInCheckpoint: L2Block[] = [];
|
|
384
769
|
const txHashesAlreadyIncluded = new Set<string>();
|
|
385
770
|
const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
|
|
386
771
|
|
|
387
|
-
// Remaining blob fields available for blocks (checkpoint end marker already subtracted)
|
|
388
|
-
let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
|
|
389
|
-
|
|
390
772
|
// Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
|
|
391
|
-
let blockPendingBroadcast:
|
|
773
|
+
let blockPendingBroadcast: BlockProposal | undefined = undefined;
|
|
392
774
|
|
|
393
775
|
while (true) {
|
|
394
776
|
const blocksBuilt = blocksInCheckpoint.length;
|
|
@@ -400,7 +782,7 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
400
782
|
|
|
401
783
|
if (!timingInfo.canStart) {
|
|
402
784
|
this.log.debug(`Not enough time left in slot to start another block`, {
|
|
403
|
-
slot: this.
|
|
785
|
+
slot: this.targetSlot,
|
|
404
786
|
blocksBuilt,
|
|
405
787
|
secondsIntoSlot,
|
|
406
788
|
});
|
|
@@ -419,25 +801,25 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
419
801
|
blockNumber,
|
|
420
802
|
indexWithinCheckpoint,
|
|
421
803
|
txHashesAlreadyIncluded,
|
|
422
|
-
remainingBlobFields,
|
|
423
804
|
});
|
|
424
805
|
|
|
425
|
-
//
|
|
426
|
-
if (
|
|
427
|
-
// If
|
|
428
|
-
|
|
429
|
-
|
|
430
|
-
|
|
806
|
+
// If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
|
|
807
|
+
if ('failure' in buildResult) {
|
|
808
|
+
// If this was the last subslot, or we're running with a single block per slot, we're done
|
|
809
|
+
if (timingInfo.isLastBlock || timingInfo.deadline === undefined) {
|
|
810
|
+
break;
|
|
811
|
+
}
|
|
812
|
+
// Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
|
|
431
813
|
await this.waitUntilNextSubslot(timingInfo.deadline);
|
|
432
814
|
continue;
|
|
433
|
-
}
|
|
434
|
-
|
|
435
|
-
|
|
436
|
-
|
|
437
|
-
|
|
815
|
+
}
|
|
816
|
+
|
|
817
|
+
// If there was an error building the block, we just exit the loop and give up the rest of the slot.
|
|
818
|
+
// We don't want to risk building more blocks if something went wrong.
|
|
819
|
+
if ('error' in buildResult) {
|
|
438
820
|
if (!(buildResult.error instanceof SequencerInterruptedError)) {
|
|
439
|
-
this.log.warn(`Halting block building for slot ${this.
|
|
440
|
-
slot: this.
|
|
821
|
+
this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
|
|
822
|
+
slot: this.targetSlot,
|
|
441
823
|
blocksBuilt,
|
|
442
824
|
error: buildResult.error,
|
|
443
825
|
});
|
|
@@ -445,45 +827,38 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
445
827
|
break;
|
|
446
828
|
}
|
|
447
829
|
|
|
448
|
-
const { block, usedTxs
|
|
449
|
-
|
|
450
|
-
|
|
451
|
-
|
|
452
|
-
remainingBlobFields = newRemainingBlobFields;
|
|
453
|
-
|
|
454
|
-
// Sync the proposed block to the archiver to make it available
|
|
455
|
-
// Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
|
|
456
|
-
// Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
|
|
457
|
-
// Fire and forget - don't block the critical path, but log errors
|
|
458
|
-
this.syncProposedBlockToArchiver(block).catch(err => {
|
|
459
|
-
this.log.error(`Failed to sync proposed block ${block.number} to archiver`, { blockNumber: block.number, err });
|
|
830
|
+
const { block, usedTxs } = buildResult;
|
|
831
|
+
this.checkpointMetrics.noteCheckpointBlockBuilt(this.dateProvider.now(), {
|
|
832
|
+
isFirstBlock: blocksBuilt === 0,
|
|
833
|
+
isLastBlock: timingInfo.isLastBlock,
|
|
460
834
|
});
|
|
461
835
|
|
|
836
|
+
blocksInCheckpoint.push(block);
|
|
462
837
|
usedTxs.forEach(tx => txHashesAlreadyIncluded.add(tx.txHash.toString()));
|
|
463
838
|
|
|
464
|
-
//
|
|
839
|
+
// Sign the block proposal. This will throw if HA signing fails.
|
|
840
|
+
const proposal = await this.createBlockProposal(block, inHash, usedTxs, blockProposalOptions);
|
|
841
|
+
|
|
842
|
+
// Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
|
|
843
|
+
// so we avoid polluting our archive with a block that would fail.
|
|
844
|
+
// We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
|
|
845
|
+
// If this throws, we abort the entire checkpoint.
|
|
846
|
+
await this.syncProposedBlockToArchiver(block);
|
|
847
|
+
|
|
848
|
+
// If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
|
|
465
849
|
if (timingInfo.isLastBlock) {
|
|
466
|
-
this.log.verbose(`Completed final block ${blockNumber} for slot ${this.
|
|
467
|
-
slot: this.
|
|
850
|
+
this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
|
|
851
|
+
slot: this.targetSlot,
|
|
468
852
|
blockNumber,
|
|
469
853
|
blocksBuilt,
|
|
470
854
|
});
|
|
471
|
-
|
|
855
|
+
|
|
856
|
+
blockPendingBroadcast = proposal;
|
|
472
857
|
break;
|
|
473
858
|
}
|
|
474
859
|
|
|
475
|
-
//
|
|
476
|
-
|
|
477
|
-
if (!this.config.fishermanMode) {
|
|
478
|
-
const proposal = await this.validatorClient.createBlockProposal(
|
|
479
|
-
block.header,
|
|
480
|
-
block.indexWithinCheckpoint,
|
|
481
|
-
inHash,
|
|
482
|
-
block.archive.root,
|
|
483
|
-
usedTxs,
|
|
484
|
-
this.proposer,
|
|
485
|
-
blockProposalOptions,
|
|
486
|
-
);
|
|
860
|
+
// Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
|
|
861
|
+
if (proposal && !this.config.skipBroadcastProposals) {
|
|
487
862
|
await this.p2pClient.broadcastProposal(proposal);
|
|
488
863
|
}
|
|
489
864
|
|
|
@@ -491,19 +866,44 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
491
866
|
await this.waitUntilNextSubslot(timingInfo.deadline);
|
|
492
867
|
}
|
|
493
868
|
|
|
494
|
-
this.log.verbose(`Block building loop completed for slot ${this.
|
|
495
|
-
slot: this.
|
|
869
|
+
this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
|
|
870
|
+
slot: this.targetSlot,
|
|
496
871
|
blocksBuilt: blocksInCheckpoint.length,
|
|
497
872
|
});
|
|
498
873
|
|
|
499
874
|
return { blocksInCheckpoint, blockPendingBroadcast };
|
|
500
875
|
}
|
|
501
876
|
|
|
877
|
+
/** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */
|
|
878
|
+
private createBlockProposal(
|
|
879
|
+
block: L2Block,
|
|
880
|
+
inHash: Fr,
|
|
881
|
+
usedTxs: Tx[],
|
|
882
|
+
blockProposalOptions: BlockProposalOptions,
|
|
883
|
+
): Promise<BlockProposal | undefined> {
|
|
884
|
+
if (this.config.fishermanMode) {
|
|
885
|
+
this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
|
|
886
|
+
return Promise.resolve(undefined);
|
|
887
|
+
}
|
|
888
|
+
return this.validatorClient.createBlockProposal(
|
|
889
|
+
block.header,
|
|
890
|
+
this.checkpointNumber,
|
|
891
|
+
block.indexWithinCheckpoint,
|
|
892
|
+
inHash,
|
|
893
|
+
block.archive.root,
|
|
894
|
+
usedTxs,
|
|
895
|
+
this.proposer,
|
|
896
|
+
blockProposalOptions,
|
|
897
|
+
);
|
|
898
|
+
}
|
|
899
|
+
|
|
502
900
|
/** Sleeps until it is time to produce the next block in the slot */
|
|
503
901
|
@trackSpan('CheckpointProposalJob.waitUntilNextSubslot')
|
|
504
902
|
private async waitUntilNextSubslot(nextSubslotStart: number) {
|
|
505
|
-
this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.
|
|
506
|
-
this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
|
|
903
|
+
this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.targetSlot);
|
|
904
|
+
this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
|
|
905
|
+
slot: this.targetSlot,
|
|
906
|
+
});
|
|
507
907
|
await this.waitUntilTimeInSlot(nextSubslotStart);
|
|
508
908
|
}
|
|
509
909
|
|
|
@@ -518,36 +918,46 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
518
918
|
indexWithinCheckpoint: IndexWithinCheckpoint;
|
|
519
919
|
buildDeadline: Date | undefined;
|
|
520
920
|
txHashesAlreadyIncluded: Set<string>;
|
|
521
|
-
remainingBlobFields: number;
|
|
522
921
|
},
|
|
523
|
-
): Promise<
|
|
524
|
-
|
|
525
|
-
|
|
526
|
-
|
|
527
|
-
|
|
528
|
-
indexWithinCheckpoint,
|
|
529
|
-
buildDeadline,
|
|
530
|
-
txHashesAlreadyIncluded,
|
|
531
|
-
remainingBlobFields,
|
|
532
|
-
} = opts;
|
|
922
|
+
): Promise<
|
|
923
|
+
{ block: L2Block; usedTxs: Tx[] } | { failure: 'insufficient-txs' | 'insufficient-valid-txs' } | { error: Error }
|
|
924
|
+
> {
|
|
925
|
+
const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } =
|
|
926
|
+
opts;
|
|
533
927
|
|
|
534
928
|
this.log.verbose(
|
|
535
|
-
`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.
|
|
929
|
+
`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`,
|
|
536
930
|
{ ...checkpointBuilder.getConstantData(), ...opts },
|
|
537
931
|
);
|
|
538
932
|
|
|
539
933
|
try {
|
|
540
934
|
// Wait until we have enough txs to build the block
|
|
541
|
-
const minTxs = this.
|
|
542
|
-
const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
|
|
935
|
+
const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
|
|
543
936
|
if (!canStartBuilding) {
|
|
937
|
+
this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
|
|
938
|
+
reason: 'insufficient_txs',
|
|
939
|
+
blockNumber,
|
|
940
|
+
slot: this.targetSlot,
|
|
941
|
+
checkpointNumber: this.checkpointNumber,
|
|
942
|
+
indexWithinCheckpoint,
|
|
943
|
+
availableTxs,
|
|
944
|
+
minTxs,
|
|
945
|
+
});
|
|
544
946
|
this.log.warn(
|
|
545
|
-
`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.
|
|
546
|
-
{
|
|
947
|
+
`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (got ${availableTxs} txs but needs ${minTxs})`,
|
|
948
|
+
{
|
|
949
|
+
reason: 'insufficient_txs',
|
|
950
|
+
blockNumber,
|
|
951
|
+
slot: this.targetSlot,
|
|
952
|
+
checkpointNumber: this.checkpointNumber,
|
|
953
|
+
indexWithinCheckpoint,
|
|
954
|
+
availableTxs,
|
|
955
|
+
minTxs,
|
|
956
|
+
},
|
|
547
957
|
);
|
|
548
|
-
this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, availableTxs, slot: this.
|
|
958
|
+
this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, availableTxs, slot: this.targetSlot });
|
|
549
959
|
this.metrics.recordBlockProposalFailed('insufficient_txs');
|
|
550
|
-
return
|
|
960
|
+
return { failure: 'insufficient-txs' };
|
|
551
961
|
}
|
|
552
962
|
|
|
553
963
|
// Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
|
|
@@ -558,24 +968,31 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
558
968
|
);
|
|
559
969
|
|
|
560
970
|
this.log.debug(
|
|
561
|
-
`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.
|
|
562
|
-
{ slot: this.
|
|
971
|
+
`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot} with ${availableTxs} available txs`,
|
|
972
|
+
{ slot: this.targetSlot, blockNumber, indexWithinCheckpoint },
|
|
563
973
|
);
|
|
564
|
-
this.setStateFn(SequencerState.CREATING_BLOCK, this.
|
|
974
|
+
this.setStateFn(SequencerState.CREATING_BLOCK, this.targetSlot);
|
|
565
975
|
|
|
566
|
-
//
|
|
567
|
-
|
|
568
|
-
|
|
569
|
-
|
|
570
|
-
const blockBuilderOptions:
|
|
976
|
+
// Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
|
|
977
|
+
// by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
|
|
978
|
+
// minValidTxs is passed into the builder so it can reject the block *before* updating state.
|
|
979
|
+
const minValidTxs = forceCreate ? 0 : (this.config.minValidTxsPerBlock ?? minTxs);
|
|
980
|
+
const blockBuilderOptions: BlockBuilderOptions = {
|
|
571
981
|
maxTransactions: this.config.maxTxsPerBlock,
|
|
572
|
-
|
|
573
|
-
|
|
574
|
-
|
|
982
|
+
maxBlockGas:
|
|
983
|
+
this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined
|
|
984
|
+
? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity)
|
|
985
|
+
: undefined,
|
|
575
986
|
deadline: buildDeadline,
|
|
987
|
+
isBuildingProposal: true,
|
|
988
|
+
minValidTxs,
|
|
989
|
+
maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
|
|
990
|
+
perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier,
|
|
576
991
|
};
|
|
577
992
|
|
|
578
|
-
// Actually build the block by executing txs
|
|
993
|
+
// Actually build the block by executing txs. The builder throws InsufficientValidTxsError
|
|
994
|
+
// if the number of successfully processed txs is below minValidTxs, ensuring state is not
|
|
995
|
+
// updated for blocks that will be discarded.
|
|
579
996
|
const buildResult = await this.buildSingleBlockWithCheckpointBuilder(
|
|
580
997
|
checkpointBuilder,
|
|
581
998
|
pendingTxs,
|
|
@@ -587,22 +1004,38 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
587
1004
|
// If any txs failed during execution, drop them from the mempool so we don't pick them up again
|
|
588
1005
|
await this.dropFailedTxsFromP2P(buildResult.failedTxs);
|
|
589
1006
|
|
|
590
|
-
|
|
591
|
-
|
|
592
|
-
|
|
593
|
-
|
|
594
|
-
|
|
1007
|
+
if (buildResult.status === 'insufficient-valid-txs') {
|
|
1008
|
+
this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
|
|
1009
|
+
reason: 'insufficient_valid_txs',
|
|
1010
|
+
slot: this.targetSlot,
|
|
1011
|
+
checkpointNumber: this.checkpointNumber,
|
|
1012
|
+
blockNumber,
|
|
1013
|
+
numTxs: buildResult.processedCount,
|
|
1014
|
+
indexWithinCheckpoint,
|
|
1015
|
+
minValidTxs,
|
|
1016
|
+
});
|
|
595
1017
|
this.log.warn(
|
|
596
|
-
`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.
|
|
597
|
-
{
|
|
1018
|
+
`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`,
|
|
1019
|
+
{
|
|
1020
|
+
reason: 'insufficient_valid_txs',
|
|
1021
|
+
slot: this.targetSlot,
|
|
1022
|
+
checkpointNumber: this.checkpointNumber,
|
|
1023
|
+
blockNumber,
|
|
1024
|
+
numTxs: buildResult.processedCount,
|
|
1025
|
+
indexWithinCheckpoint,
|
|
1026
|
+
minValidTxs,
|
|
1027
|
+
},
|
|
598
1028
|
);
|
|
599
|
-
this.eventEmitter.emit('block-build-failed', {
|
|
1029
|
+
this.eventEmitter.emit('block-build-failed', {
|
|
1030
|
+
reason: `Insufficient valid txs`,
|
|
1031
|
+
slot: this.targetSlot,
|
|
1032
|
+
});
|
|
600
1033
|
this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
|
|
601
|
-
return
|
|
1034
|
+
return { failure: 'insufficient-valid-txs' };
|
|
602
1035
|
}
|
|
603
1036
|
|
|
604
1037
|
// Block creation succeeded, emit stats and metrics
|
|
605
|
-
const {
|
|
1038
|
+
const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
|
|
606
1039
|
|
|
607
1040
|
const blockStats = {
|
|
608
1041
|
eventName: 'l2-block-built',
|
|
@@ -613,33 +1046,53 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
613
1046
|
|
|
614
1047
|
const blockHash = await block.hash();
|
|
615
1048
|
const txHashes = block.body.txEffects.map(tx => tx.txHash);
|
|
616
|
-
const manaPerSec =
|
|
1049
|
+
const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
|
|
617
1050
|
|
|
618
1051
|
this.log.info(
|
|
619
|
-
`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.
|
|
1052
|
+
`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`,
|
|
620
1053
|
{ blockHash, txHashes, manaPerSec, ...blockStats },
|
|
621
1054
|
);
|
|
622
1055
|
|
|
623
|
-
|
|
624
|
-
|
|
1056
|
+
// `slot` is the target/submission slot (may be one ahead when pipelining),
|
|
1057
|
+
// `buildSlot` is the wall-clock slot during which the block was actually built.
|
|
1058
|
+
this.eventEmitter.emit('block-proposed', {
|
|
1059
|
+
blockNumber: block.number,
|
|
1060
|
+
slot: this.targetSlot,
|
|
1061
|
+
buildSlot: this.slotNow,
|
|
1062
|
+
});
|
|
1063
|
+
this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe(), this.targetSlot);
|
|
625
1064
|
|
|
626
|
-
return { block, usedTxs
|
|
1065
|
+
return { block, usedTxs };
|
|
627
1066
|
} catch (err: any) {
|
|
628
|
-
this.eventEmitter.emit('block-build-failed', {
|
|
629
|
-
|
|
1067
|
+
this.eventEmitter.emit('block-build-failed', {
|
|
1068
|
+
reason: err.message,
|
|
1069
|
+
slot: this.targetSlot,
|
|
1070
|
+
});
|
|
1071
|
+
this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
|
|
1072
|
+
reason: err instanceof Error ? err.message : String(err),
|
|
1073
|
+
slot: this.targetSlot,
|
|
1074
|
+
checkpointNumber: this.checkpointNumber,
|
|
1075
|
+
blockNumber,
|
|
1076
|
+
});
|
|
1077
|
+
this.log.error(`Error building block`, err, {
|
|
1078
|
+
reason: err instanceof Error ? err.message : String(err),
|
|
1079
|
+
slot: this.targetSlot,
|
|
1080
|
+
checkpointNumber: this.checkpointNumber,
|
|
1081
|
+
blockNumber,
|
|
1082
|
+
});
|
|
630
1083
|
this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
|
|
631
1084
|
this.metrics.recordFailedBlock();
|
|
632
1085
|
return { error: err };
|
|
633
1086
|
}
|
|
634
1087
|
}
|
|
635
1088
|
|
|
636
|
-
/** Uses the checkpoint builder to build a block, catching
|
|
1089
|
+
/** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */
|
|
637
1090
|
private async buildSingleBlockWithCheckpointBuilder(
|
|
638
1091
|
checkpointBuilder: CheckpointBuilder,
|
|
639
1092
|
pendingTxs: AsyncIterable<Tx>,
|
|
640
1093
|
blockNumber: BlockNumber,
|
|
641
1094
|
blockTimestamp: bigint,
|
|
642
|
-
blockBuilderOptions:
|
|
1095
|
+
blockBuilderOptions: BlockBuilderOptions,
|
|
643
1096
|
) {
|
|
644
1097
|
try {
|
|
645
1098
|
const workTimer = new Timer();
|
|
@@ -647,8 +1100,12 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
647
1100
|
const blockBuildDuration = workTimer.ms();
|
|
648
1101
|
return { ...result, blockBuildDuration, status: 'success' as const };
|
|
649
1102
|
} catch (err: unknown) {
|
|
650
|
-
if (isErrorClass(err,
|
|
651
|
-
return {
|
|
1103
|
+
if (isErrorClass(err, InsufficientValidTxsError)) {
|
|
1104
|
+
return {
|
|
1105
|
+
failedTxs: err.failedTxs,
|
|
1106
|
+
processedCount: err.processedCount,
|
|
1107
|
+
status: 'insufficient-valid-txs' as const,
|
|
1108
|
+
};
|
|
652
1109
|
}
|
|
653
1110
|
throw err;
|
|
654
1111
|
}
|
|
@@ -661,7 +1118,7 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
661
1118
|
blockNumber: BlockNumber;
|
|
662
1119
|
indexWithinCheckpoint: IndexWithinCheckpoint;
|
|
663
1120
|
buildDeadline: Date | undefined;
|
|
664
|
-
}): Promise<{ canStartBuilding: boolean; availableTxs: number }> {
|
|
1121
|
+
}): Promise<{ canStartBuilding: boolean; availableTxs: number; minTxs: number }> {
|
|
665
1122
|
const { indexWithinCheckpoint, blockNumber, buildDeadline, forceCreate } = opts;
|
|
666
1123
|
|
|
667
1124
|
// We only allow a block with 0 txs in the first block of the checkpoint
|
|
@@ -678,20 +1135,50 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
678
1135
|
// If we're past deadline, or we have no deadline, give up
|
|
679
1136
|
const now = this.dateProvider.nowAsDate();
|
|
680
1137
|
if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
|
|
681
|
-
return { canStartBuilding: false, availableTxs
|
|
1138
|
+
return { canStartBuilding: false, availableTxs, minTxs };
|
|
682
1139
|
}
|
|
683
1140
|
|
|
684
1141
|
// Wait a bit before checking again
|
|
685
|
-
this.setStateFn(SequencerState.WAITING_FOR_TXS, this.
|
|
1142
|
+
this.setStateFn(SequencerState.WAITING_FOR_TXS, this.targetSlot);
|
|
686
1143
|
this.log.verbose(
|
|
687
|
-
`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.
|
|
688
|
-
{ blockNumber, slot: this.
|
|
1144
|
+
`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (have ${availableTxs} but need ${minTxs})`,
|
|
1145
|
+
{ blockNumber, slot: this.targetSlot, indexWithinCheckpoint },
|
|
689
1146
|
);
|
|
690
1147
|
await this.waitForTxsPollingInterval();
|
|
691
1148
|
availableTxs = await this.p2pClient.getPendingTxCount();
|
|
692
1149
|
}
|
|
693
1150
|
|
|
694
|
-
return { canStartBuilding: true, availableTxs };
|
|
1151
|
+
return { canStartBuilding: true, availableTxs, minTxs };
|
|
1152
|
+
}
|
|
1153
|
+
|
|
1154
|
+
private async getSignedCommitteeAttestations(
|
|
1155
|
+
broadcast: CheckpointProposalBroadcast,
|
|
1156
|
+
): Promise<{ attestations: CommitteeAttestationsAndSigners; attestationsSignature: Signature } | undefined> {
|
|
1157
|
+
const { proposal, blockProposedAt } = broadcast;
|
|
1158
|
+
this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.targetSlot);
|
|
1159
|
+
const attestations = await this.waitForAttestations(proposal);
|
|
1160
|
+
if (!attestations) {
|
|
1161
|
+
return undefined;
|
|
1162
|
+
}
|
|
1163
|
+
this.checkpointMetrics.recordCheckpointAttestationDelay(this.dateProvider.now() - blockProposedAt);
|
|
1164
|
+
|
|
1165
|
+
// Proposer must sign over the attestations before pushing them to L1
|
|
1166
|
+
const signer = this.proposer ?? this.publisher.getSenderAddress();
|
|
1167
|
+
try {
|
|
1168
|
+
const attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
|
|
1169
|
+
attestations,
|
|
1170
|
+
signer,
|
|
1171
|
+
this.targetSlot,
|
|
1172
|
+
this.checkpointNumber,
|
|
1173
|
+
);
|
|
1174
|
+
return { attestations, attestationsSignature };
|
|
1175
|
+
} catch (err) {
|
|
1176
|
+
if (this.handleHASigningError(err, 'Attestations signature')) {
|
|
1177
|
+
return;
|
|
1178
|
+
}
|
|
1179
|
+
this.log.error(`Error signing attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
|
|
1180
|
+
return undefined;
|
|
1181
|
+
}
|
|
695
1182
|
}
|
|
696
1183
|
|
|
697
1184
|
/**
|
|
@@ -699,10 +1186,12 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
699
1186
|
* This is run after all blocks for the checkpoint have been built.
|
|
700
1187
|
*/
|
|
701
1188
|
@trackSpan('CheckpointProposalJob.waitForAttestations')
|
|
702
|
-
private async waitForAttestations(
|
|
1189
|
+
private async waitForAttestations(
|
|
1190
|
+
proposal: CheckpointProposal,
|
|
1191
|
+
): Promise<CommitteeAttestationsAndSigners | undefined> {
|
|
703
1192
|
if (this.config.fishermanMode) {
|
|
704
1193
|
this.log.debug('Skipping attestation collection in fisherman mode');
|
|
705
|
-
return CommitteeAttestationsAndSigners.empty();
|
|
1194
|
+
return CommitteeAttestationsAndSigners.empty(this.getSignatureContext());
|
|
706
1195
|
}
|
|
707
1196
|
|
|
708
1197
|
const slotNumber = proposal.slotNumber;
|
|
@@ -712,21 +1201,27 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
712
1201
|
throw new Error('No committee when collecting attestations');
|
|
713
1202
|
} else if (committee.length === 0) {
|
|
714
1203
|
this.log.verbose(`Attesting committee is empty`);
|
|
715
|
-
return CommitteeAttestationsAndSigners.empty();
|
|
1204
|
+
return CommitteeAttestationsAndSigners.empty(this.getSignatureContext());
|
|
716
1205
|
} else {
|
|
717
1206
|
this.log.debug(`Attesting committee length is ${committee.length}`, { committee });
|
|
718
1207
|
}
|
|
719
1208
|
|
|
720
|
-
const numberOfRequiredAttestations =
|
|
1209
|
+
const numberOfRequiredAttestations = computeQuorum(committee.length);
|
|
721
1210
|
|
|
722
1211
|
if (this.config.skipCollectingAttestations) {
|
|
723
1212
|
this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
|
|
724
|
-
const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
|
|
725
|
-
|
|
1213
|
+
const attestations = await this.validatorClient?.collectOwnAttestations(proposal, this.checkpointNumber);
|
|
1214
|
+
this.logCheckpointAttestations('collected', committee, attestations ?? [], numberOfRequiredAttestations, {
|
|
1215
|
+
reason: 'collect_own_only',
|
|
1216
|
+
});
|
|
1217
|
+
return new CommitteeAttestationsAndSigners(
|
|
1218
|
+
orderAttestations(attestations ?? [], committee),
|
|
1219
|
+
this.getSignatureContext(),
|
|
1220
|
+
);
|
|
726
1221
|
}
|
|
727
1222
|
|
|
728
1223
|
const attestationTimeAllowed = this.config.enforceTimeTable
|
|
729
|
-
? this.timetable.
|
|
1224
|
+
? this.timetable.getCheckpointAttestationDeadline()
|
|
730
1225
|
: this.l1Constants.slotDuration;
|
|
731
1226
|
const attestationDeadline = new Date((this.getSlotStartBuildTimestamp() + attestationTimeAllowed) * 1000);
|
|
732
1227
|
|
|
@@ -739,6 +1234,7 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
739
1234
|
proposal,
|
|
740
1235
|
numberOfRequiredAttestations,
|
|
741
1236
|
attestationDeadline,
|
|
1237
|
+
this.checkpointNumber,
|
|
742
1238
|
);
|
|
743
1239
|
|
|
744
1240
|
collectedAttestationsCount = attestations.length;
|
|
@@ -757,23 +1253,70 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
757
1253
|
|
|
758
1254
|
// Rollup contract requires that the signatures are provided in the order of the committee
|
|
759
1255
|
const sorted = orderAttestations(trimmed, committee);
|
|
1256
|
+
this.logCheckpointAttestations('collected', committee, attestations, numberOfRequiredAttestations, {
|
|
1257
|
+
submittedCount: trimmed.length,
|
|
1258
|
+
});
|
|
760
1259
|
|
|
761
1260
|
// Manipulate the attestations if we've been configured to do so
|
|
762
|
-
if (
|
|
1261
|
+
if (
|
|
1262
|
+
this.config.injectFakeAttestation ||
|
|
1263
|
+
this.config.injectHighSValueAttestation ||
|
|
1264
|
+
this.config.injectUnrecoverableSignatureAttestation ||
|
|
1265
|
+
this.config.shuffleAttestationOrdering
|
|
1266
|
+
) {
|
|
763
1267
|
return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
|
|
764
1268
|
}
|
|
765
1269
|
|
|
766
|
-
return new CommitteeAttestationsAndSigners(sorted);
|
|
1270
|
+
return new CommitteeAttestationsAndSigners(sorted, this.getSignatureContext());
|
|
767
1271
|
} catch (err) {
|
|
768
1272
|
if (err && err instanceof AttestationTimeoutError) {
|
|
769
1273
|
collectedAttestationsCount = err.collectedCount;
|
|
1274
|
+
this.logCheckpointAttestations('failed', committee, undefined, numberOfRequiredAttestations, {
|
|
1275
|
+
collectedCount: collectedAttestationsCount,
|
|
1276
|
+
reason: 'timeout',
|
|
1277
|
+
});
|
|
1278
|
+
this.log.error(
|
|
1279
|
+
`Timeout while waiting for attestations for checkpoint proposal at slot ${proposal.slotNumber} (collected ${collectedAttestationsCount}/${numberOfRequiredAttestations})`,
|
|
1280
|
+
err,
|
|
1281
|
+
);
|
|
1282
|
+
} else {
|
|
1283
|
+
this.logCheckpointAttestations('failed', committee, undefined, numberOfRequiredAttestations, {
|
|
1284
|
+
collectedCount: collectedAttestationsCount,
|
|
1285
|
+
reason: err instanceof Error ? err.message : String(err),
|
|
1286
|
+
});
|
|
1287
|
+
this.log.error(`Error collecting attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
|
|
770
1288
|
}
|
|
771
|
-
|
|
1289
|
+
return undefined;
|
|
772
1290
|
} finally {
|
|
773
1291
|
this.metrics.recordCollectedAttestations(collectedAttestationsCount, collectAttestationsTimer.ms());
|
|
774
1292
|
}
|
|
775
1293
|
}
|
|
776
1294
|
|
|
1295
|
+
private logCheckpointAttestations(
|
|
1296
|
+
status: 'collected' | 'failed',
|
|
1297
|
+
committee: EthAddress[],
|
|
1298
|
+
attestations: CheckpointAttestation[] | undefined,
|
|
1299
|
+
requiredAttestations: number,
|
|
1300
|
+
opts: { collectedCount?: number; submittedCount?: number; reason?: string } = {},
|
|
1301
|
+
) {
|
|
1302
|
+
const signedValidators =
|
|
1303
|
+
attestations
|
|
1304
|
+
?.map(attestation => attestation.getSender()?.toString())
|
|
1305
|
+
.filter((address): address is `0x${string}` => address !== undefined) ?? [];
|
|
1306
|
+
const collectedCount = opts.collectedCount ?? new Set(signedValidators).size;
|
|
1307
|
+
const missingValidatorCount = status === 'failed' ? Math.max(0, requiredAttestations - collectedCount) : undefined;
|
|
1308
|
+
this.logCheckpointEvent(`attestations-${status}`, `Checkpoint attestations ${status} for slot ${this.targetSlot}`, {
|
|
1309
|
+
slot: this.targetSlot,
|
|
1310
|
+
checkpointNumber: this.checkpointNumber,
|
|
1311
|
+
committeeSize: committee.length,
|
|
1312
|
+
requiredAttestations,
|
|
1313
|
+
collectedAttestations: collectedCount,
|
|
1314
|
+
...(opts.submittedCount !== undefined && { submittedAttestations: opts.submittedCount }),
|
|
1315
|
+
...(missingValidatorCount !== undefined && { missingValidatorCount }),
|
|
1316
|
+
...(opts.reason !== undefined && { reason: opts.reason }),
|
|
1317
|
+
});
|
|
1318
|
+
}
|
|
1319
|
+
|
|
777
1320
|
/** Breaks the attestations before publishing based on attack configs */
|
|
778
1321
|
private manipulateAttestations(
|
|
779
1322
|
slotNumber: SlotNumber,
|
|
@@ -788,7 +1331,11 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
788
1331
|
this.epochCache.computeProposerIndex(slotNumber, epoch, seed, BigInt(committee.length)),
|
|
789
1332
|
);
|
|
790
1333
|
|
|
791
|
-
if (
|
|
1334
|
+
if (
|
|
1335
|
+
this.config.injectFakeAttestation ||
|
|
1336
|
+
this.config.injectHighSValueAttestation ||
|
|
1337
|
+
this.config.injectUnrecoverableSignatureAttestation
|
|
1338
|
+
) {
|
|
792
1339
|
// Find non-empty attestations that are not from the proposer
|
|
793
1340
|
const nonProposerIndices: number[] = [];
|
|
794
1341
|
for (let i = 0; i < attestations.length; i++) {
|
|
@@ -798,27 +1345,48 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
798
1345
|
}
|
|
799
1346
|
if (nonProposerIndices.length > 0) {
|
|
800
1347
|
const targetIndex = nonProposerIndices[randomInt(nonProposerIndices.length)];
|
|
801
|
-
this.
|
|
802
|
-
|
|
1348
|
+
if (this.config.injectHighSValueAttestation) {
|
|
1349
|
+
this.log.warn(
|
|
1350
|
+
`Injecting high-s value attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`,
|
|
1351
|
+
);
|
|
1352
|
+
unfreeze(attestations[targetIndex]).signature = flipSignature(attestations[targetIndex].signature);
|
|
1353
|
+
} else if (this.config.injectUnrecoverableSignatureAttestation) {
|
|
1354
|
+
this.log.warn(
|
|
1355
|
+
`Injecting unrecoverable signature attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`,
|
|
1356
|
+
);
|
|
1357
|
+
unfreeze(attestations[targetIndex]).signature = generateUnrecoverableSignature();
|
|
1358
|
+
} else {
|
|
1359
|
+
this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
|
|
1360
|
+
unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
|
|
1361
|
+
}
|
|
803
1362
|
}
|
|
804
|
-
return new CommitteeAttestationsAndSigners(attestations);
|
|
1363
|
+
return new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext());
|
|
805
1364
|
}
|
|
806
1365
|
|
|
807
1366
|
if (this.config.shuffleAttestationOrdering) {
|
|
808
1367
|
this.log.warn(`Shuffling attestation ordering in checkpoint for slot ${slotNumber} (proposer #${proposerIndex})`);
|
|
809
1368
|
|
|
810
1369
|
const shuffled = [...attestations];
|
|
811
|
-
|
|
812
|
-
|
|
813
|
-
|
|
814
|
-
|
|
815
|
-
|
|
816
|
-
|
|
817
|
-
|
|
818
|
-
|
|
1370
|
+
|
|
1371
|
+
// Find two non-proposer positions that both have non-empty signatures to swap.
|
|
1372
|
+
// This ensures the bitmap doesn't change, so the MaliciousCommitteeAttestationsAndSigners
|
|
1373
|
+
// signers array stays correctly aligned with L1's committee reconstruction.
|
|
1374
|
+
const swappable: number[] = [];
|
|
1375
|
+
for (let k = 0; k < shuffled.length; k++) {
|
|
1376
|
+
if (!shuffled[k].signature.isEmpty() && k !== proposerIndex) {
|
|
1377
|
+
swappable.push(k);
|
|
1378
|
+
}
|
|
1379
|
+
}
|
|
1380
|
+
if (swappable.length >= 2) {
|
|
1381
|
+
const [i, j] = [swappable[0], swappable[1]];
|
|
1382
|
+
[shuffled[i], shuffled[j]] = [shuffled[j], shuffled[i]];
|
|
1383
|
+
}
|
|
1384
|
+
|
|
1385
|
+
const signers = new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext()).getSigners();
|
|
1386
|
+
return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers, this.getSignatureContext());
|
|
819
1387
|
}
|
|
820
1388
|
|
|
821
|
-
return new CommitteeAttestationsAndSigners(attestations);
|
|
1389
|
+
return new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext());
|
|
822
1390
|
}
|
|
823
1391
|
|
|
824
1392
|
private async dropFailedTxsFromP2P(failedTxs: FailedTx[]) {
|
|
@@ -835,9 +1403,13 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
835
1403
|
* Adds the proposed block to the archiver so it's available via P2P.
|
|
836
1404
|
* Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
|
|
837
1405
|
* would never receive its own block without this explicit sync.
|
|
1406
|
+
*
|
|
1407
|
+
* In fisherman mode we skip this push: the fisherman builds blocks locally for validation
|
|
1408
|
+
* and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
|
|
1409
|
+
* whenever the real proposer's block arrives from L1.
|
|
838
1410
|
*/
|
|
839
1411
|
private async syncProposedBlockToArchiver(block: L2Block): Promise<void> {
|
|
840
|
-
if (this.config.skipPushProposedBlocksToArchiver
|
|
1412
|
+
if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
|
|
841
1413
|
this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
|
|
842
1414
|
blockNumber: block.number,
|
|
843
1415
|
slot: block.header.globalVariables.slotNumber,
|
|
@@ -855,19 +1427,19 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
855
1427
|
private async handleCheckpointEndAsFisherman(checkpoint: Checkpoint | undefined) {
|
|
856
1428
|
// Perform L1 fee analysis before clearing requests
|
|
857
1429
|
// The callback is invoked asynchronously after the next block is mined
|
|
858
|
-
const feeAnalysis = await this.publisher.analyzeL1Fees(this.
|
|
1430
|
+
const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, analysis =>
|
|
859
1431
|
this.metrics.recordFishermanFeeAnalysis(analysis),
|
|
860
1432
|
);
|
|
861
1433
|
|
|
862
1434
|
if (checkpoint) {
|
|
863
|
-
this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.
|
|
1435
|
+
this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
|
|
864
1436
|
...checkpoint.toCheckpointInfo(),
|
|
865
1437
|
...checkpoint.getStats(),
|
|
866
1438
|
feeAnalysisId: feeAnalysis?.id,
|
|
867
1439
|
});
|
|
868
1440
|
} else {
|
|
869
|
-
this.log.warn(`Validation block building FAILED for slot ${this.
|
|
870
|
-
slot: this.
|
|
1441
|
+
this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
|
|
1442
|
+
slot: this.targetSlot,
|
|
871
1443
|
feeAnalysisId: feeAnalysis?.id,
|
|
872
1444
|
});
|
|
873
1445
|
this.metrics.recordCheckpointProposalFailed('block_build_failed');
|
|
@@ -881,15 +1453,15 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
881
1453
|
*/
|
|
882
1454
|
private handleHASigningError(err: any, errorContext: string): boolean {
|
|
883
1455
|
if (err instanceof DutyAlreadySignedError) {
|
|
884
|
-
this.log.info(`${errorContext} for slot ${this.
|
|
885
|
-
slot: this.
|
|
1456
|
+
this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
|
|
1457
|
+
slot: this.targetSlot,
|
|
886
1458
|
signedByNode: err.signedByNode,
|
|
887
1459
|
});
|
|
888
1460
|
return true;
|
|
889
1461
|
}
|
|
890
1462
|
if (err instanceof SlashingProtectionError) {
|
|
891
|
-
this.log.info(`${errorContext} for slot ${this.
|
|
892
|
-
slot: this.
|
|
1463
|
+
this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
|
|
1464
|
+
slot: this.targetSlot,
|
|
893
1465
|
existingMessageHash: err.existingMessageHash,
|
|
894
1466
|
attemptedMessageHash: err.attemptedMessageHash,
|
|
895
1467
|
});
|
|
@@ -912,7 +1484,7 @@ export class CheckpointProposalJob implements Traceable {
|
|
|
912
1484
|
}
|
|
913
1485
|
|
|
914
1486
|
private getSlotStartBuildTimestamp(): number {
|
|
915
|
-
return getSlotStartBuildTimestamp(this.
|
|
1487
|
+
return getSlotStartBuildTimestamp(this.slotNow, this.l1Constants);
|
|
916
1488
|
}
|
|
917
1489
|
|
|
918
1490
|
private getSecondsIntoSlot(): number {
|