@aztec/sequencer-client 0.0.1-commit.42ee6df9b → 0.0.1-commit.431c48d

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (109) hide show
  1. package/README.md +283 -21
  2. package/dest/client/sequencer-client.d.ts +20 -5
  3. package/dest/client/sequencer-client.d.ts.map +1 -1
  4. package/dest/client/sequencer-client.js +26 -22
  5. package/dest/config.d.ts +13 -4
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +67 -26
  8. package/dest/global_variable_builder/fee_predictor.d.ts +37 -0
  9. package/dest/global_variable_builder/fee_predictor.d.ts.map +1 -0
  10. package/dest/global_variable_builder/fee_predictor.js +138 -0
  11. package/dest/global_variable_builder/fee_provider.d.ts +21 -0
  12. package/dest/global_variable_builder/fee_provider.d.ts.map +1 -0
  13. package/dest/global_variable_builder/fee_provider.js +80 -0
  14. package/dest/global_variable_builder/global_builder.d.ts +7 -26
  15. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  16. package/dest/global_variable_builder/global_builder.js +6 -67
  17. package/dest/global_variable_builder/index.d.ts +3 -1
  18. package/dest/global_variable_builder/index.d.ts.map +1 -1
  19. package/dest/global_variable_builder/index.js +2 -0
  20. package/dest/publisher/config.d.ts +7 -3
  21. package/dest/publisher/config.d.ts.map +1 -1
  22. package/dest/publisher/config.js +13 -3
  23. package/dest/publisher/l1_to_l2_messaging.d.ts +21 -0
  24. package/dest/publisher/l1_to_l2_messaging.d.ts.map +1 -0
  25. package/dest/publisher/l1_to_l2_messaging.js +70 -0
  26. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +3 -4
  27. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -1
  28. package/dest/publisher/sequencer-bundle-simulator.d.ts +96 -0
  29. package/dest/publisher/sequencer-bundle-simulator.d.ts.map +1 -0
  30. package/dest/publisher/sequencer-bundle-simulator.js +198 -0
  31. package/dest/publisher/sequencer-publisher-factory.d.ts +1 -3
  32. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  33. package/dest/publisher/sequencer-publisher-factory.js +0 -1
  34. package/dest/publisher/sequencer-publisher.d.ts +65 -70
  35. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  36. package/dest/publisher/sequencer-publisher.js +413 -559
  37. package/dest/publisher/write_json.d.ts +11 -0
  38. package/dest/publisher/write_json.d.ts.map +1 -0
  39. package/dest/publisher/write_json.js +57 -0
  40. package/dest/sequencer/automine/automine_factory.d.ts +56 -0
  41. package/dest/sequencer/automine/automine_factory.d.ts.map +1 -0
  42. package/dest/sequencer/automine/automine_factory.js +85 -0
  43. package/dest/sequencer/automine/automine_sequencer.d.ts +189 -0
  44. package/dest/sequencer/automine/automine_sequencer.d.ts.map +1 -0
  45. package/dest/sequencer/automine/automine_sequencer.js +696 -0
  46. package/dest/sequencer/automine/index.d.ts +3 -0
  47. package/dest/sequencer/automine/index.d.ts.map +1 -0
  48. package/dest/sequencer/automine/index.js +2 -0
  49. package/dest/sequencer/checkpoint_proposal_job.d.ts +67 -36
  50. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  51. package/dest/sequencer/checkpoint_proposal_job.js +705 -256
  52. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts +34 -0
  53. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts.map +1 -0
  54. package/dest/sequencer/checkpoint_proposal_job_metrics.js +72 -0
  55. package/dest/sequencer/errors.d.ts +1 -8
  56. package/dest/sequencer/errors.d.ts.map +1 -1
  57. package/dest/sequencer/errors.js +0 -9
  58. package/dest/sequencer/events.d.ts +61 -5
  59. package/dest/sequencer/events.d.ts.map +1 -1
  60. package/dest/sequencer/metrics.d.ts +10 -11
  61. package/dest/sequencer/metrics.d.ts.map +1 -1
  62. package/dest/sequencer/metrics.js +34 -20
  63. package/dest/sequencer/requests_tracker.d.ts +22 -0
  64. package/dest/sequencer/requests_tracker.d.ts.map +1 -0
  65. package/dest/sequencer/requests_tracker.js +33 -0
  66. package/dest/sequencer/sequencer.d.ts +147 -33
  67. package/dest/sequencer/sequencer.d.ts.map +1 -1
  68. package/dest/sequencer/sequencer.js +543 -180
  69. package/dest/sequencer/types.d.ts +2 -2
  70. package/dest/sequencer/types.d.ts.map +1 -1
  71. package/dest/test/index.d.ts +3 -3
  72. package/dest/test/index.d.ts.map +1 -1
  73. package/dest/test/utils.d.ts +15 -1
  74. package/dest/test/utils.d.ts.map +1 -1
  75. package/dest/test/utils.js +25 -7
  76. package/package.json +28 -27
  77. package/src/client/sequencer-client.ts +37 -27
  78. package/src/config.ts +79 -26
  79. package/src/global_variable_builder/README.md +44 -0
  80. package/src/global_variable_builder/fee_predictor.ts +182 -0
  81. package/src/global_variable_builder/fee_provider.ts +97 -0
  82. package/src/global_variable_builder/global_builder.ts +11 -91
  83. package/src/global_variable_builder/index.ts +2 -0
  84. package/src/publisher/config.ts +30 -7
  85. package/src/publisher/l1_to_l2_messaging.ts +85 -0
  86. package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +3 -1
  87. package/src/publisher/sequencer-bundle-simulator.ts +254 -0
  88. package/src/publisher/sequencer-publisher-factory.ts +0 -3
  89. package/src/publisher/sequencer-publisher.ts +458 -622
  90. package/src/publisher/write_json.ts +78 -0
  91. package/src/sequencer/automine/README.md +60 -0
  92. package/src/sequencer/automine/automine_factory.ts +152 -0
  93. package/src/sequencer/automine/automine_sequencer.ts +800 -0
  94. package/src/sequencer/automine/index.ts +6 -0
  95. package/src/sequencer/checkpoint_proposal_job.ts +823 -316
  96. package/src/sequencer/checkpoint_proposal_job_metrics.ts +128 -0
  97. package/src/sequencer/errors.ts +0 -15
  98. package/src/sequencer/events.ts +66 -5
  99. package/src/sequencer/metrics.ts +49 -25
  100. package/src/sequencer/requests_tracker.ts +43 -0
  101. package/src/sequencer/sequencer.ts +607 -206
  102. package/src/sequencer/types.ts +1 -1
  103. package/src/test/index.ts +2 -2
  104. package/src/test/utils.ts +61 -10
  105. package/dest/sequencer/timetable.d.ts +0 -88
  106. package/dest/sequencer/timetable.d.ts.map +0 -1
  107. package/dest/sequencer/timetable.js +0 -222
  108. package/src/sequencer/README.md +0 -531
  109. package/src/sequencer/timetable.ts +0 -283
@@ -435,20 +435,20 @@ function applyDecs2203RFactory() {
435
435
  function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
436
436
  return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
437
437
  }
438
- var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _initProto;
439
- import { RollupContract } from '@aztec/ethereum/contracts';
440
- import { BlockNumber, CheckpointNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
438
+ var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _initProto;
439
+ import { PROPOSER_PIPELINING_SLOT_OFFSET } from '@aztec/epoch-cache';
440
+ import { BlockNumber, CheckpointNumber, IndexWithinCheckpoint, SlotNumber } from '@aztec/foundation/branded-types';
441
441
  import { randomInt } from '@aztec/foundation/crypto/random';
442
442
  import { flipSignature, generateRecoverableSignature, generateUnrecoverableSignature } from '@aztec/foundation/crypto/secp256k1-signer';
443
- import { Signature } from '@aztec/foundation/eth-signature';
443
+ import { InterruptError, TimeoutError } from '@aztec/foundation/error';
444
444
  import { filter } from '@aztec/foundation/iterator';
445
445
  import { createLogger } from '@aztec/foundation/log';
446
- import { sleep, sleepUntil } from '@aztec/foundation/sleep';
446
+ import { InterruptibleSleep } from '@aztec/foundation/sleep';
447
447
  import { Timer } from '@aztec/foundation/timer';
448
448
  import { isErrorClass, unfreeze } from '@aztec/foundation/types';
449
- import { CommitteeAttestationsAndSigners, MaliciousCommitteeAttestationsAndSigners } from '@aztec/stdlib/block';
450
- import { validateCheckpoint } from '@aztec/stdlib/checkpoint';
451
- import { computeQuorum, getSlotStartBuildTimestamp, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
449
+ import { CommitteeAttestationsAndSigners, MaliciousCommitteeAttestationsAndSigners, MaliciousYParityCommitteeAttestationsAndSigners } from '@aztec/stdlib/block';
450
+ import { buildCheckpointSimulationOverridesPlan, getPreviousCheckpointOutHashes, validateCheckpoint } from '@aztec/stdlib/checkpoint';
451
+ import { computeQuorum, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
452
452
  import { Gas } from '@aztec/stdlib/gas';
453
453
  import { InsufficientValidTxsError } from '@aztec/stdlib/interfaces/server';
454
454
  import { computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
@@ -460,24 +460,25 @@ import { CheckpointVoter } from './checkpoint_voter.js';
460
460
  import { SequencerInterruptedError } from './errors.js';
461
461
  import { SequencerState } from './utils.js';
462
462
  /** How much time to sleep while waiting for min transactions to accumulate for a block */ const TXS_POLLING_MS = 500;
463
+ const ARCHIVER_SYNC_POLLING_MS = 200;
463
464
  _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('CheckpointProposalJob.proposeCheckpoint', function() {
464
465
  return {
465
466
  // nullish operator needed for tests
466
467
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
467
468
  [Attributes.SLOT_NUMBER]: this.targetSlot
468
469
  };
469
- }), _dec2 = trackSpan('CheckpointProposalJob.buildBlocksForCheckpoint'), _dec3 = trackSpan('CheckpointProposalJob.waitUntilNextSubslot'), _dec4 = trackSpan('CheckpointProposalJob.buildSingleBlock'), _dec5 = trackSpan('CheckpointProposalJob.waitForMinTxs'), _dec6 = trackSpan('CheckpointProposalJob.waitForAttestations'), _dec7 = trackSpan('CheckpointProposalJob.waitUntilTimeInSlot');
470
+ }), _dec2 = trackSpan('CheckpointProposalJob.buildBlocksForCheckpoint'), _dec3 = trackSpan('CheckpointProposalJob.waitUntilNextSubslot'), _dec4 = trackSpan('CheckpointProposalJob.buildSingleBlock'), _dec5 = trackSpan('CheckpointProposalJob.waitForMinTxs'), _dec6 = trackSpan('CheckpointProposalJob.waitForAttestations');
470
471
  /**
471
472
  * Handles the execution of a checkpoint proposal after the initial preparation phase.
472
473
  * This includes building blocks, collecting attestations, and publishing the checkpoint to L1,
473
474
  * as well as enqueueing votes for slashing and governance proposals. This class is created from
474
475
  * the Sequencer once the check for being the proposer for the slot has succeeded.
475
476
  */ export class CheckpointProposalJob {
476
- slotNow;
477
477
  targetSlot;
478
478
  targetEpoch;
479
479
  checkpointNumber;
480
480
  syncedToBlockNumber;
481
+ checkpointedCheckpointNumber;
481
482
  proposer;
482
483
  publisher;
483
484
  attestorAddress;
@@ -491,13 +492,16 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
491
492
  checkpointsBuilder;
492
493
  blockSink;
493
494
  l1Constants;
495
+ signatureContext;
494
496
  config;
495
497
  timetable;
496
498
  slasherClient;
497
499
  epochCache;
498
500
  dateProvider;
499
501
  metrics;
502
+ checkpointMetrics;
500
503
  eventEmitter;
504
+ pendingRequests;
501
505
  setStateFn;
502
506
  tracer;
503
507
  proposedCheckpointData;
@@ -537,24 +541,31 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
537
541
  _dec6,
538
542
  2,
539
543
  "waitForAttestations"
540
- ],
541
- [
542
- _dec7,
543
- 2,
544
- "waitUntilTimeInSlot"
545
544
  ]
546
545
  ], []));
547
546
  }
548
547
  log;
549
- /** Tracks the fire-and-forget L1 submission promise so it can be awaited during shutdown. */ pendingL1Submission;
550
- /** Fee header override computed during proposeCheckpoint, reused in enqueueCheckpointForSubmission. */ computedForceProposedFeeHeader;
551
- constructor(slotNow, targetSlot, targetEpoch, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
552
- proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, eventEmitter, setStateFn, tracer, bindings, proposedCheckpointData){
553
- this.slotNow = slotNow;
548
+ checkpointEventLog;
549
+ interruptibleSleep;
550
+ interrupted;
551
+ /**
552
+ * Chain state overrides built once per slot in proposeCheckpoint after the checkpoint is
553
+ * complete. Carries the pending parent override (archive + slot + fee header) for pipelining,
554
+ * or the invalidation pending override when rolling back. Consumed by
555
+ * publisher.validateCheckpointHeader before broadcast.
556
+ */ checkpointSimulationOverridesPlan;
557
+ getSignatureContext() {
558
+ return this.signatureContext;
559
+ }
560
+ constructor(targetSlot, targetEpoch, checkpointNumber, syncedToBlockNumber, checkpointedCheckpointNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
561
+ proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, signatureContext, config, timetable, slasherClient, epochCache, dateProvider, metrics, checkpointMetrics, eventEmitter, // Shared with the owning sequencer, which drains it during shutdown; the fire-and-forget L1
562
+ // submission this job backgrounds is tracked here rather than in a job-local tracker.
563
+ pendingRequests, setStateFn, tracer, bindings, proposedCheckpointData){
554
564
  this.targetSlot = targetSlot;
555
565
  this.targetEpoch = targetEpoch;
556
566
  this.checkpointNumber = checkpointNumber;
557
567
  this.syncedToBlockNumber = syncedToBlockNumber;
568
+ this.checkpointedCheckpointNumber = checkpointedCheckpointNumber;
558
569
  this.proposer = proposer;
559
570
  this.publisher = publisher;
560
571
  this.attestorAddress = attestorAddress;
@@ -568,103 +579,210 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
568
579
  this.checkpointsBuilder = checkpointsBuilder;
569
580
  this.blockSink = blockSink;
570
581
  this.l1Constants = l1Constants;
582
+ this.signatureContext = signatureContext;
571
583
  this.config = config;
572
584
  this.timetable = timetable;
573
585
  this.slasherClient = slasherClient;
574
586
  this.epochCache = epochCache;
575
587
  this.dateProvider = dateProvider;
576
588
  this.metrics = metrics;
589
+ this.checkpointMetrics = checkpointMetrics;
577
590
  this.eventEmitter = eventEmitter;
591
+ this.pendingRequests = pendingRequests;
578
592
  this.setStateFn = setStateFn;
579
593
  this.tracer = tracer;
580
594
  this.proposedCheckpointData = proposedCheckpointData;
581
- _initProto(this);
595
+ this.interruptibleSleep = (_initProto(this), new InterruptibleSleep());
596
+ this.interrupted = false;
582
597
  this.log = createLogger('sequencer:checkpoint-proposal', {
583
598
  ...bindings,
584
- instanceId: `slot-${this.slotNow}`
599
+ instanceId: `slot-${this.getBuildSlot()}`
600
+ });
601
+ this.checkpointEventLog = createLogger('sequencer:checkpoint-events', {
602
+ ...bindings,
603
+ instanceId: `slot-${this.getBuildSlot()}`
585
604
  });
586
605
  }
587
- /** Awaits the pending L1 submission if one is in progress. Call during shutdown. */ async awaitPendingSubmission() {
588
- this.log.info('Awaiting pending L1 payload submission');
589
- await this.pendingL1Submission;
606
+ /**
607
+ * The wall-clock slot during which this job builds, i.e. the slot one before {@link targetSlot} under
608
+ * proposer pipelining. Also the slot of the parent checkpoint this job builds on top of.
609
+ */ getBuildSlot() {
610
+ return SlotNumber(this.targetSlot - PROPOSER_PIPELINING_SLOT_OFFSET);
611
+ }
612
+ /**
613
+ * Sets the sequencer state for this job, reporting the target slot the checkpoint is being proposed for
614
+ * (not the wall-clock build slot). The slot is informational on the event payload/metrics; the job knows
615
+ * its own target slot, so callers only pass the state.
616
+ */ setState(state) {
617
+ this.setStateFn(state, this.targetSlot);
618
+ }
619
+ /** Interrupts job-owned waits, including the publisher's send-at-slot sleep, so shutdown can finish. */ interrupt() {
620
+ this.interrupted = true;
621
+ this.interruptibleSleep.interrupt(true);
622
+ this.publisher.interrupt();
623
+ }
624
+ async awaitInterruptibleSleep(ms) {
625
+ if (this.interrupted) {
626
+ throw new SequencerInterruptedError();
627
+ }
628
+ if (ms <= 0) {
629
+ return;
630
+ }
631
+ try {
632
+ await this.interruptibleSleep.sleep(ms);
633
+ } catch (err) {
634
+ if (err instanceof InterruptError) {
635
+ throw new SequencerInterruptedError();
636
+ }
637
+ throw err;
638
+ }
639
+ }
640
+ logCheckpointEvent(eventName, message, fields) {
641
+ this.checkpointEventLog.debug(message, {
642
+ eventName: `sequencer-checkpoint-${eventName}`,
643
+ ...fields
644
+ });
590
645
  }
591
646
  /**
592
647
  * Executes the checkpoint proposal job.
593
- * Builds blocks, collects attestations, enqueues requests, and schedules L1 submission as a
594
- * background task so the work loop can return to IDLE immediately.
648
+ * Builds blocks, assembles checkpoint, and broadcasts the proposal (blocking).
649
+ * Attestation collection, signing, and L1 submission are backgrounded so the
650
+ * work loop can return to IDLE immediately for consecutive slot proposals.
595
651
  * Returns the built checkpoint if successful, undefined otherwise.
596
652
  */ async execute() {
597
653
  // Enqueue governance and slashing votes (returns promises that will be awaited later)
598
654
  // In fisherman mode, we simulate slashing but don't actually publish to L1
599
655
  // These are constant for the whole slot, so we only enqueue them once
600
656
  const votesPromises = new CheckpointVoter(this.targetSlot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
601
- // Build and propose the checkpoint. Builds blocks, broadcasts, collects attestations, and signs.
602
- // Does NOT enqueue to L1 yet that happens after the pipeline sleep.
603
- const proposalResult = await this.proposeCheckpoint();
604
- const checkpoint = proposalResult?.checkpoint;
605
- // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
606
- await Promise.all(votesPromises);
607
- if (checkpoint) {
608
- this.metrics.recordCheckpointProposalSuccess();
657
+ // Build blocks, assemble checkpoint, and broadcast proposal (BLOCKING).
658
+ // Returns after broadcastattestation collection is deferred.
659
+ const broadcast = await this.proposeCheckpoint();
660
+ if (!broadcast) {
661
+ await Promise.all(votesPromises);
662
+ // Still submit votes even without a checkpoint.
663
+ // Under proposer pipelining, vote-offenses signatures are EIP-712-bound to `targetSlot`
664
+ // (the pipelined slot in which the multicall is expected to mine). Submitting at the
665
+ // wall-clock time would let the multicall mine in a different L2 slot, causing
666
+ // signature verification to fail silently inside Multicall3. Delay submission to the
667
+ // start of `targetSlot` so the tx mines in the slot the vote was signed for.
668
+ if (!this.config.fishermanMode) {
669
+ this.pendingRequests.trackRequest(this.publisher.sendRequestsAt(this.targetSlot), ()=>this.interrupt());
670
+ }
671
+ return undefined;
609
672
  }
673
+ const { checkpoint } = broadcast;
674
+ this.metrics.recordCheckpointProposalSuccess();
610
675
  // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
611
676
  if (this.config.fishermanMode) {
612
677
  await this.handleCheckpointEndAsFisherman(checkpoint);
613
- return;
678
+ return checkpoint;
614
679
  }
615
- // Enqueue the checkpoint for L1 submission
616
- if (proposalResult) {
617
- try {
618
- await this.enqueueCheckpointForSubmission(proposalResult);
619
- } catch (err) {
620
- this.log.error(`Failed to enqueue checkpoint for L1 submission at slot ${this.targetSlot}`, err);
621
- // Continue to sendRequestsAt so votes are still sent
680
+ // Background the attestation signing → L1 pipeline so the work loop is unblocked
681
+ this.pendingRequests.trackRequest(this.waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises), ()=>this.interrupt());
682
+ // Return the built checkpoint immediately — the work loop is now unblocked
683
+ return checkpoint;
684
+ }
685
+ /**
686
+ * Background pipeline: collects attestations, signs them, enqueues the checkpoint, and submits to L1.
687
+ * Runs as a fire-and-forget task tracked in the sequencer's shared tracker so the work loop is unblocked.
688
+ */ async waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises) {
689
+ const { checkpoint } = broadcast;
690
+ try {
691
+ // Wait for all votes actions, enqueued at the beginning, to resolve
692
+ await Promise.all(votesPromises);
693
+ // Try to collect attestations from the committee
694
+ const signedAttestations = await this.getSignedCommitteeAttestations(broadcast);
695
+ // Wait for the previous checkpoint to land on L1 before submitting, so we can check it
696
+ // matches the proposed checkpoint we used as parent, and has valid attestations.
697
+ if (signedAttestations && await this.waitForValidParentCheckpointOnL1()) {
698
+ await this.enqueueCheckpointForSubmission({
699
+ checkpoint,
700
+ ...signedAttestations
701
+ });
622
702
  }
623
- }
624
- // Compute the earliest time to submit: pipeline slot start when pipelining, now otherwise.
625
- const submitAfter = this.epochCache.isProposerPipeliningEnabled() ? new Date(Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) * 1000) : new Date(this.dateProvider.now());
626
- // TODO(https://github.com/AztecProtocol/aztec-packages/pull/21250): should discard the pending submission if a reorg occurs underneath
627
- // Schedule L1 submission in the background so the work loop returns immediately.
628
- // The publisher will sleep until submitAfter, then send the bundled requests.
629
- // The promise is stored so it can be awaited during shutdown.
630
- this.pendingL1Submission = this.publisher.sendRequestsAt(submitAfter).then(async (l1Response)=>{
703
+ // If we failed to collect attestations, at least check if we need to issue an invalidation
704
+ if (!signedAttestations && await this.waitForSyncedL2SlotNumber(this.getBuildSlot())) {
705
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
706
+ if (!validationStatus.valid) {
707
+ this.log.warn(`Checkpoint ${validationStatus.checkpoint.checkpointNumber} has invalid attestations, enqueuing invalidation in spite of attestation collection failure`, {
708
+ checkpoint: validationStatus.checkpoint,
709
+ reason: validationStatus.reason
710
+ });
711
+ await this.enqueueInvalidation(validationStatus);
712
+ }
713
+ }
714
+ // Send whatever was enqueued: votes + (propose | invalidation | nothing).
715
+ const l1Response = await this.publisher.sendRequestsAt(this.targetSlot);
631
716
  const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
632
717
  if (proposedAction) {
718
+ this.logCheckpointEvent('published', `Checkpoint published for slot ${this.targetSlot}`, {
719
+ slot: this.targetSlot,
720
+ checkpointNumber: this.checkpointNumber,
721
+ successfulActions: l1Response?.successfulActions,
722
+ sentActions: l1Response?.sentActions
723
+ });
633
724
  this.eventEmitter.emit('checkpoint-published', {
634
725
  checkpoint: this.checkpointNumber,
635
726
  slot: this.targetSlot
636
727
  });
637
- const coinbase = checkpoint?.header.coinbase;
728
+ const coinbase = checkpoint.header.coinbase;
638
729
  await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
639
- } else if (checkpoint) {
730
+ } else {
731
+ this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, {
732
+ slot: this.targetSlot,
733
+ checkpointNumber: this.checkpointNumber,
734
+ successfulActions: l1Response?.successfulActions,
735
+ failedActions: l1Response?.failedActions,
736
+ sentActions: l1Response?.sentActions,
737
+ expiredActions: l1Response?.expiredActions,
738
+ reason: 'propose_action_not_successful'
739
+ });
740
+ this.log.warn(`Checkpoint publish failed for slot ${this.targetSlot}`, {
741
+ slot: this.targetSlot,
742
+ checkpointNumber: this.checkpointNumber,
743
+ successfulActions: l1Response?.successfulActions,
744
+ failedActions: l1Response?.failedActions,
745
+ sentActions: l1Response?.sentActions,
746
+ expiredActions: l1Response?.expiredActions,
747
+ reason: 'propose_action_not_successful'
748
+ });
640
749
  this.eventEmitter.emit('checkpoint-publish-failed', {
641
750
  ...l1Response,
642
751
  slot: this.targetSlot
643
752
  });
644
- if (this.epochCache.isProposerPipeliningEnabled()) {
645
- this.metrics.recordPipelineDiscard();
646
- }
753
+ this.metrics.recordPipelineDiscard();
647
754
  }
648
- }).catch((err)=>{
649
- this.log.error(`Background L1 submission failed for slot ${this.targetSlot}`, err);
650
- if (checkpoint) {
651
- this.eventEmitter.emit('checkpoint-publish-failed', {
652
- slot: this.targetSlot
653
- });
654
- if (this.epochCache.isProposerPipeliningEnabled()) {
655
- this.metrics.recordPipelineDiscard();
656
- }
755
+ } catch (err) {
756
+ if (err instanceof SequencerInterruptedError) {
757
+ return;
657
758
  }
658
- });
659
- // Return the built checkpoint immediately — the work loop is now unblocked
660
- return checkpoint;
759
+ this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, {
760
+ slot: this.targetSlot,
761
+ checkpointNumber: this.checkpointNumber,
762
+ reason: err instanceof Error ? err.message : String(err)
763
+ });
764
+ this.log.error(`Background attestation/L1 pipeline failed for slot ${this.targetSlot}`, err, {
765
+ slot: this.targetSlot,
766
+ checkpointNumber: this.checkpointNumber,
767
+ reason: err instanceof Error ? err.message : String(err)
768
+ });
769
+ this.eventEmitter.emit('checkpoint-publish-failed', {
770
+ slot: this.targetSlot
771
+ });
772
+ this.metrics.recordPipelineDiscard();
773
+ }
661
774
  }
662
775
  /** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */ async enqueueCheckpointForSubmission(result) {
663
776
  const { checkpoint, attestations, attestationsSignature } = result;
664
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.targetSlot);
665
- const aztecSlotDuration = this.l1Constants.slotDuration;
666
- const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
667
- const txTimeoutAt = new Date((submissionSlotStart + aztecSlotDuration) * 1000);
777
+ this.setState(SequencerState.PUBLISHING_CHECKPOINT);
778
+ // Latest L1 block the propose can still land in for the target slot: the last Ethereum block inside
779
+ // the target slot (`target_slot_start + S - E`). This is one ethereum slot later than
780
+ // `attestation_deadline` (= last_ethereum_block_in_target_slot - E), which bounds when validators must
781
+ // have signed, not when the proposer must have sent. Using the attestation deadline here is too tight:
782
+ // attestations are collected up to (and, when not enforcing, past) it, so the propose tx would be
783
+ // enqueued already expired and time out before it can mine.
784
+ const lastL1BlockInTargetSlot = Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) + this.l1Constants.slotDuration - this.l1Constants.ethereumSlotDuration;
785
+ const txTimeoutAt = new Date(lastL1BlockInTargetSlot * 1000);
668
786
  // If we have been configured to potentially skip publishing checkpoint then roll the dice here
669
787
  if (this.config.skipPublishingCheckpointsPercent !== undefined && this.config.skipPublishingCheckpointsPercent > 0) {
670
788
  const roll = Math.max(0, randomInt(100));
@@ -674,11 +792,140 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
674
792
  }
675
793
  }
676
794
  await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
677
- txTimeoutAt,
678
- forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
679
- forceProposedFeeHeader: this.computedForceProposedFeeHeader
795
+ txTimeoutAt
796
+ });
797
+ }
798
+ /**
799
+ * Wait until the archiver syncs past the given L2 slot number.
800
+ * The deadline is the end of `this.targetSlot`, beyond which any pipelined work would miss its
801
+ * L1 submission window and is no longer useful.
802
+ */ async waitForSyncedL2SlotNumber(waitForSlot) {
803
+ const targetSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
804
+ const targetSlotEndMs = (targetSlotStart + this.l1Constants.slotDuration) * 1000;
805
+ const syncDelayTolerance = this.l1Constants.ethereumSlotDuration * 2 * 1000;
806
+ const timeoutSeconds = Math.max(0.1, (targetSlotEndMs + syncDelayTolerance - this.dateProvider.now()) / 1000);
807
+ try {
808
+ const timer = new Timer();
809
+ while(true){
810
+ const syncedSlot = await this.l2BlockSource.getSyncedL2SlotNumber();
811
+ if (syncedSlot !== undefined && syncedSlot >= waitForSlot) {
812
+ return true;
813
+ }
814
+ if (timeoutSeconds && timer.s() > timeoutSeconds) {
815
+ throw new TimeoutError(`Timeout awaiting archiver sync past slot ${waitForSlot}`);
816
+ }
817
+ await this.awaitInterruptibleSleep(ARCHIVER_SYNC_POLLING_MS);
818
+ }
819
+ } catch (err) {
820
+ if (err instanceof SequencerInterruptedError) {
821
+ throw err;
822
+ }
823
+ this.log.warn(`Archiver did not sync L1 past slot ${waitForSlot} before slot ${this.targetSlot} expired, discarding pipelined work`, {
824
+ checkpointNumber: this.checkpointNumber
825
+ });
826
+ this.emitPipelinedCheckpointDiscarded('archiver-sync-timeout');
827
+ return false;
828
+ }
829
+ }
830
+ /**
831
+ * Waits for the parent checkpoint to land on L1 before submitting a pipelined checkpoint.
832
+ * Polls until the archiver has synced L1 past the parent's slot, then verifies:
833
+ * - If we built on a proposed parent: it must have landed on L1 with matching hash and valid attestations.
834
+ * - If we built without a proposed parent: no new checkpoint must have appeared for that slot.
835
+ * If the parent has invalid attestations, enqueues an invalidation. Returns whether to proceed with the proposal.
836
+ */ async waitForValidParentCheckpointOnL1() {
837
+ if (this.config.skipWaitForValidParentCheckpointOnL1) {
838
+ this.log.warn(`Skipping waitForValidParentCheckpointOnL1 due to test configuration`, {
839
+ checkpointNumber: this.checkpointNumber
840
+ });
841
+ return true;
842
+ }
843
+ const parentCheckpointNumber = CheckpointNumber(this.checkpointNumber - 1);
844
+ // Wait until archiver has synced L1 past the parent's slot (the build slot, one before targetSlot)
845
+ if (!await this.waitForSyncedL2SlotNumber(this.getBuildSlot())) {
846
+ return false;
847
+ }
848
+ const tips = await this.l2BlockSource.getL2Tips();
849
+ const checkpointedNumber = tips.checkpointed.checkpoint.number;
850
+ // We built on top of a proposed checkpoint. Verify it landed on L1 as expected.
851
+ if (this.proposedCheckpointData) {
852
+ // After syncing from L1 we see the chain tip has invalid attestations. This means the parent checkpoint was posted
853
+ // with invalid attestations, or it built on top of something with invalid attestations and didnt invalidate them.
854
+ // Either way, we thought our parent would be valid, so we have to throw away our work. But at least we'll try and
855
+ // invalidate on L1 so we clean up the chain for the next proposer. And we'll slash them, but that's handled elsewhere.
856
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
857
+ if (!validationStatus.valid) {
858
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} has invalid attestations, discarding pipelined work`, {
859
+ checkpointNumber: this.checkpointNumber,
860
+ reason: validationStatus.reason
861
+ });
862
+ this.emitPipelinedCheckpointDiscarded('parent-invalid-attestations');
863
+ await this.enqueueInvalidation(validationStatus);
864
+ return false;
865
+ }
866
+ // The pending chain is valid. But did the parent checkpoint land on L1 at all?
867
+ if (checkpointedNumber < parentCheckpointNumber) {
868
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} did not land on L1, discarding pipelined work`, {
869
+ checkpointNumber: this.checkpointNumber,
870
+ checkpointedNumber
871
+ });
872
+ this.emitPipelinedCheckpointDiscarded('parent-not-on-l1');
873
+ return false;
874
+ }
875
+ // It landed. But is it the one we were expecting?
876
+ const expectedHash = this.proposedCheckpointData.header.hash().toString();
877
+ if (tips.checkpointed.checkpoint.hash !== expectedHash) {
878
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} hash mismatch on L1, discarding pipelined work`, {
879
+ checkpointNumber: this.checkpointNumber,
880
+ expectedHash,
881
+ actualHash: tips.checkpointed.checkpoint.hash
882
+ });
883
+ this.emitPipelinedCheckpointDiscarded('parent-hash-mismatch');
884
+ return false;
885
+ }
886
+ return true;
887
+ } else {
888
+ // We didn't see a proposed checkpoint at build time, so we built on checkpointed parent from two slots ago.
889
+ // But if a new checkpoint for the previous slot appeared on L1 in the meantime, our checkpoint assumed the wrong parent,
890
+ // so we have to discard our work. This can happen if we're somehow cut off from p2p and fail to see the checkpoint
891
+ // proposal for the previous slot.
892
+ if (checkpointedNumber > parentCheckpointNumber) {
893
+ this.log.warn(`Unexpected checkpoint ${checkpointedNumber} landed on L1 after we built on top of parent ${parentCheckpointNumber}, discarding pipelined work`, {
894
+ checkpointNumber: this.checkpointNumber,
895
+ checkpointedNumber
896
+ });
897
+ this.emitPipelinedCheckpointDiscarded('unexpected-parent-appeared');
898
+ return false;
899
+ }
900
+ return true;
901
+ }
902
+ }
903
+ /** Emits the pipelined-checkpoint-discarded event and records the metric. */ emitPipelinedCheckpointDiscarded(reason) {
904
+ this.metrics.recordPipelineParentCheckpointMismatch(reason);
905
+ this.eventEmitter.emit('pipelined-checkpoint-discarded', {
906
+ slot: this.targetSlot,
907
+ checkpointNumber: this.checkpointNumber,
908
+ reason
680
909
  });
681
910
  }
911
+ /** Simulates and enqueues an invalidation request for the invalid parent checkpoint. */ async enqueueInvalidation(validationStatus) {
912
+ if (this.config.skipInvalidateBlockAsProposer) {
913
+ this.log.warn(`Skipping checkpoint invalidation as proposer due to test configuration`);
914
+ return;
915
+ }
916
+ const invalidateRequest = await this.publisher.simulateInvalidateCheckpoint(validationStatus);
917
+ if (invalidateRequest) {
918
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
919
+ const txTimeoutAt = new Date((submissionSlotStart + this.l1Constants.slotDuration) * 1000);
920
+ this.publisher.enqueueInvalidateCheckpoint(invalidateRequest, {
921
+ txTimeoutAt
922
+ });
923
+ } else {
924
+ this.log.info(`Invalidation simulation returned undefined, checkpoint may have been removed already`, {
925
+ checkpointNumber: this.checkpointNumber
926
+ });
927
+ }
928
+ }
682
929
  async proposeCheckpoint() {
683
930
  try {
684
931
  const env = {
@@ -687,16 +934,28 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
687
934
  hasError: false
688
935
  };
689
936
  try {
937
+ const now = this.dateProvider.now();
938
+ if (this.proposedCheckpointData) {
939
+ // Measure against the wall-clock slot whose build window we are currently using.
940
+ // In pipelining mode `targetSlot` is intentionally one slot ahead, which makes the
941
+ // target-slot boundary a full slot away from the actual build start time.
942
+ const slotBoundaryMs = Number(getTimestampForSlot(this.getBuildSlot(), this.l1Constants)) * 1000;
943
+ this.checkpointMetrics.recordPipelinedCheckpointBuildStartOffsetFromSlotBoundary(now - slotBoundaryMs);
944
+ }
945
+ this.checkpointMetrics.startCheckpointTiming(now);
690
946
  // Get operator configured coinbase and fee recipient for this attestor
691
947
  const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
692
948
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
693
949
  // Start the checkpoint
694
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.targetSlot);
695
- this.log.info(`Starting checkpoint proposal`, {
696
- buildSlot: this.slotNow,
950
+ this.setState(SequencerState.INITIALIZING_CHECKPOINT);
951
+ this.logCheckpointEvent('slot-started', `Starting checkpoint proposal for slot ${this.targetSlot}`, {
952
+ buildSlot: this.getBuildSlot(),
697
953
  submissionSlot: this.targetSlot,
698
- pipelining: this.epochCache.isProposerPipeliningEnabled(),
954
+ slot: this.targetSlot,
955
+ checkpointNumber: this.checkpointNumber,
699
956
  proposer: this.proposer?.toString(),
957
+ attestorAddress: this.attestorAddress.toString(),
958
+ publisherAddress: this.publisher.getSenderAddress().toString(),
700
959
  coinbase: coinbase.toString()
701
960
  });
702
961
  this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
@@ -704,26 +963,41 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
704
963
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
705
964
  this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
706
965
  }
707
- // Create checkpoint builder for the slot.
708
- // When pipelining, force the proposed checkpoint number and fee header to our parent so the
709
- // fee computation sees the same chain tip that L1 will see once the previous pipelined checkpoint lands.
710
- const isPipelining = this.epochCache.isProposerPipeliningEnabled();
711
- const parentCheckpointNumber = isPipelining ? CheckpointNumber(this.checkpointNumber - 1) : undefined;
712
- // Compute the parent's fee header override when pipelining
713
- if (isPipelining && this.proposedCheckpointData) {
714
- this.computedForceProposedFeeHeader = await this.computeForceProposedFeeHeader(parentCheckpointNumber);
715
- }
716
- const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.targetSlot, {
717
- forcePendingCheckpointNumber: parentCheckpointNumber,
718
- forceProposedFeeHeader: this.computedForceProposedFeeHeader
966
+ // Build the simulation plan for this slot. When pipelining, this overrides L1's view of
967
+ // pending/archive/fee-header to "as if the proposed parent had landed", so both the
968
+ // mana-min-fee simulation (in the globals builder) and the pre-broadcast
969
+ // validateCheckpointHeader see the chain tip the eventual L1 send will see.
970
+ this.checkpointSimulationOverridesPlan = await buildCheckpointSimulationOverridesPlan({
971
+ checkpointNumber: this.checkpointNumber,
972
+ proposedCheckpointData: this.proposedCheckpointData,
973
+ invalidateToPendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
974
+ checkpointedCheckpointNumber: this.checkpointedCheckpointNumber,
975
+ rollup: this.publisher.rollupContract,
976
+ signatureContext: this.signatureContext,
977
+ log: this.log
719
978
  });
979
+ const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.targetSlot, this.checkpointSimulationOverridesPlan);
720
980
  // Collect L1 to L2 messages for the checkpoint and compute their hash
721
981
  const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(this.checkpointNumber);
722
982
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
723
- // Collect the out hashes of all the checkpoints before this one in the same epoch
724
- const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.targetEpoch)).filter((c)=>c.checkpointNumber < this.checkpointNumber).map((c)=>c.checkpointOutHash);
725
- // Get the fee asset price modifier from the oracle
726
- const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier();
983
+ // Collect the out hashes of all the checkpoints before this one in the same epoch.
984
+ // Under pipelining the parent checkpoint may not be on L1 yet at build time, so the helper
985
+ // splices in the parent's checkpointOutHash from the locally-known proposed checkpoint so
986
+ // the resulting `epochOutHash` matches what validators (and L1) compute once the parent
987
+ // lands on L1.
988
+ const previousCheckpointOutHashes = await getPreviousCheckpointOutHashes({
989
+ blockSource: this.l2BlockSource,
990
+ epoch: this.targetEpoch,
991
+ checkpointNumber: this.checkpointNumber,
992
+ l1Constants: this.epochCache.getL1Constants(),
993
+ pipeliningEnabled: true,
994
+ proposedCheckpointData: this.proposedCheckpointData,
995
+ log: this.log
996
+ });
997
+ // Anchor the modifier to the predicted parent fee header: L1 will apply it against
998
+ // that, not against the latest published checkpoint (which lags by one under pipelining).
999
+ const predictedParentEthPerFeeAssetE12 = this.checkpointSimulationOverridesPlan?.pendingCheckpointState?.feeHeader?.ethPerFeeAsset;
1000
+ const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier(predictedParentEthPerFeeAssetE12);
727
1001
  const fork = _ts_add_disposable_resource(env, await this.worldState.fork(this.syncedToBlockNumber, {
728
1002
  closeDelayMs: 12_000
729
1003
  }), true);
@@ -736,7 +1010,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
736
1010
  };
737
1011
  const checkpointProposalOptions = {
738
1012
  publishFullTxs: !!this.config.publishTxsWithProposals,
739
- broadcastInvalidCheckpointProposal: this.config.broadcastInvalidBlockProposal
1013
+ broadcastInvalidCheckpointProposal: this.config.broadcastInvalidCheckpointProposalOnly || this.config.broadcastInvalidBlockProposal
740
1014
  };
741
1015
  let blocksInCheckpoint = [];
742
1016
  let blockPendingBroadcast = undefined;
@@ -756,8 +1030,15 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
756
1030
  throw err;
757
1031
  }
758
1032
  if (blocksInCheckpoint.length === 0) {
1033
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
1034
+ slot: this.targetSlot,
1035
+ checkpointNumber: this.checkpointNumber,
1036
+ reason: 'no_blocks_built'
1037
+ });
759
1038
  this.log.warn(`No blocks were built for slot ${this.targetSlot}`, {
760
- slot: this.targetSlot
1039
+ slot: this.targetSlot,
1040
+ checkpointNumber: this.checkpointNumber,
1041
+ reason: 'no_blocks_built'
761
1042
  });
762
1043
  this.eventEmitter.emit('checkpoint-empty', {
763
1044
  slot: this.targetSlot
@@ -766,16 +1047,25 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
766
1047
  }
767
1048
  const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
768
1049
  if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
1050
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
1051
+ slot: this.targetSlot,
1052
+ checkpointNumber: this.checkpointNumber,
1053
+ blocksBuilt: blocksInCheckpoint.length,
1054
+ minBlocksForCheckpoint,
1055
+ reason: 'min_blocks_not_met'
1056
+ });
769
1057
  this.log.warn(`Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`, {
770
1058
  slot: this.targetSlot,
1059
+ checkpointNumber: this.checkpointNumber,
771
1060
  blocksBuilt: blocksInCheckpoint.length,
772
- minBlocksForCheckpoint
1061
+ minBlocksForCheckpoint,
1062
+ reason: 'min_blocks_not_met'
773
1063
  });
774
1064
  return undefined;
775
1065
  }
776
1066
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
777
1067
  // broadcasted yet, and wait to collect the committee attestations.
778
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.targetSlot);
1068
+ this.setState(SequencerState.ASSEMBLING_CHECKPOINT);
779
1069
  const checkpoint = await checkpointBuilder.completeCheckpoint();
780
1070
  // Final validation: per-block limits are only checked if the operator set them explicitly.
781
1071
  // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
@@ -788,14 +1078,36 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
788
1078
  maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint
789
1079
  });
790
1080
  } catch (err) {
791
- this.log.error(`Built an invalid checkpoint at slot ${this.slotNow} (skipping proposal)`, err, {
1081
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
1082
+ slot: this.targetSlot,
1083
+ checkpointNumber: this.checkpointNumber,
1084
+ blocksBuilt: blocksInCheckpoint.length,
1085
+ reason: 'invalid_checkpoint',
1086
+ checkpoint: checkpoint.header.toInspect()
1087
+ });
1088
+ this.log.error(`Built an invalid checkpoint at slot ${this.targetSlot} (skipping proposal)`, err, {
1089
+ slot: this.targetSlot,
1090
+ checkpointNumber: this.checkpointNumber,
1091
+ blocksBuilt: blocksInCheckpoint.length,
1092
+ reason: 'invalid_checkpoint',
792
1093
  checkpoint: checkpoint.header.toInspect()
793
1094
  });
794
1095
  return undefined;
795
1096
  }
796
1097
  // Record checkpoint-level build metrics
797
- this.metrics.recordCheckpointBuild(checkpointBuildTimer.ms(), blocksInCheckpoint.length, checkpoint.getStats().txCount, Number(checkpoint.header.totalManaUsed.toBigInt()));
798
- // Do not collect attestations nor publish to L1 in fisherman mode
1098
+ this.checkpointMetrics.recordCheckpointBuild(checkpointBuildTimer.ms(), blocksInCheckpoint.length, checkpoint.getStats().txCount, Number(checkpoint.header.totalManaUsed.toBigInt()));
1099
+ this.logCheckpointEvent('built', `Checkpoint built for slot ${this.targetSlot}`, {
1100
+ slot: this.targetSlot,
1101
+ buildSlot: this.getBuildSlot(),
1102
+ checkpointNumber: this.checkpointNumber,
1103
+ proposer: this.proposer?.toString(),
1104
+ attestorAddress: this.attestorAddress.toString(),
1105
+ publisherAddress: this.publisher.getSenderAddress().toString(),
1106
+ blocksBuilt: blocksInCheckpoint.length,
1107
+ txCount: checkpoint.getStats().txCount,
1108
+ totalMana: Number(checkpoint.header.totalManaUsed.toBigInt())
1109
+ });
1110
+ // In fisherman mode, return the checkpoint without broadcasting or collecting attestations
799
1111
  if (this.config.fishermanMode) {
800
1112
  this.log.info(`Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
801
1113
  slot: this.targetSlot,
@@ -803,44 +1115,57 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
803
1115
  blocksBuilt: blocksInCheckpoint.length
804
1116
  });
805
1117
  this.metrics.recordCheckpointSuccess();
1118
+ // Return a broadcast result with a dummy proposal — fisherman mode skips attestation collection
806
1119
  return {
807
1120
  checkpoint,
808
- attestations: CommitteeAttestationsAndSigners.empty(),
809
- attestationsSignature: Signature.empty()
1121
+ proposal: undefined,
1122
+ blockProposedAt: this.dateProvider.now()
810
1123
  };
811
1124
  }
812
- // Include the block pending broadcast in the checkpoint proposal if any
813
- const lastBlock = blockPendingBroadcast && {
814
- blockHeader: blockPendingBroadcast.block.header,
815
- indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
816
- txs: blockPendingBroadcast.txs
817
- };
818
- // Create the checkpoint proposal and broadcast it
819
- const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, feeAssetPriceModifier, lastBlock, this.proposer, checkpointProposalOptions);
820
- const blockProposedAt = this.dateProvider.now();
821
- await this.p2pClient.broadcastCheckpointProposal(proposal);
822
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.targetSlot);
823
- const attestations = await this.waitForAttestations(proposal);
824
- const blockAttestedAt = this.dateProvider.now();
825
- this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
826
- // Proposer must sign over the attestations before pushing them to L1
827
- const signer = this.proposer ?? this.publisher.getSenderAddress();
828
- let attestationsSignature;
1125
+ // Validate the header against L1 state before broadcasting.
1126
+ // If this fails the slot is aborted before any gossip work; state drift between here
1127
+ // and the eventual L1 send is caught by the bundle simulate at send time.
829
1128
  try {
830
- attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.targetSlot, this.checkpointNumber);
1129
+ await this.publisher.validateCheckpointHeader(checkpoint.header, this.checkpointSimulationOverridesPlan);
831
1130
  } catch (err) {
832
- // We shouldn't really get here since we yield to another HA node
833
- // as soon as we see these errors when creating block or checkpoint proposals.
834
- if (this.handleHASigningError(err, 'Attestations signature')) {
835
- return undefined;
1131
+ this.log.error(`Pre-broadcast header validation failed for slot ${this.targetSlot}; aborting`, err, {
1132
+ slot: this.targetSlot,
1133
+ checkpointNumber: this.checkpointNumber
1134
+ });
1135
+ this.metrics.recordCheckpointProposalFailed('header_validation_failed');
1136
+ this.eventEmitter.emit('header-validation-failed', {
1137
+ slot: this.targetSlot,
1138
+ checkpointNumber: this.checkpointNumber,
1139
+ reason: err instanceof Error ? err.message : String(err)
1140
+ });
1141
+ return undefined;
1142
+ }
1143
+ // Create the checkpoint proposal and broadcast it
1144
+ const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, this.checkpointNumber, feeAssetPriceModifier, blockPendingBroadcast, this.proposer, checkpointProposalOptions);
1145
+ // Advance our own optimistic proposed-checkpoint tip locally before gossiping. Gossipsub
1146
+ // doesn't echo our own messages back, so this is how the proposer makes its own proposed
1147
+ // checkpoint visible for pipelining the next slot. Built from local checkpoint data — never
1148
+ // from the broadcast proposal archive, which may be deliberately corrupted under test flags.
1149
+ // Fail closed: if this throws, the outer catch aborts the slot before gossiping.
1150
+ await this.syncProposedCheckpointToArchiver(checkpoint, blocksInCheckpoint.length, feeAssetPriceModifier);
1151
+ const blockProposedAt = this.dateProvider.now();
1152
+ if (this.config.skipBroadcastCheckpointProposal) {
1153
+ // Test-only: suppress the CheckpointProposal so peers never see a proposed checkpoint for
1154
+ // this slot, but still broadcast the held last block standalone so peers' archivers ingest
1155
+ // it as a proposed-but-uncheckpointed tip — the exact orphan-block state that
1156
+ // pruneOrphanProposedBlocks / checkSync must handle.
1157
+ if (blockPendingBroadcast && !this.config.skipBroadcastProposals) {
1158
+ await this.p2pClient.broadcastProposal(blockPendingBroadcast);
836
1159
  }
837
- throw err;
1160
+ } else if (!this.config.skipBroadcastProposals) {
1161
+ await this.p2pClient.broadcastCheckpointProposal(proposal);
1162
+ this.checkpointMetrics.noteCheckpointBroadcast(this.dateProvider.now());
838
1163
  }
839
- // Return the result for the caller to enqueue after the pipeline sleep
1164
+ // Return immediately after broadcast attestation collection happens in the background
840
1165
  return {
841
1166
  checkpoint,
842
- attestations,
843
- attestationsSignature
1167
+ proposal,
1168
+ blockProposedAt
844
1169
  };
845
1170
  } catch (e) {
846
1171
  env.error = e;
@@ -870,13 +1195,21 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
870
1195
  const blocksBuilt = blocksInCheckpoint.length;
871
1196
  const indexWithinCheckpoint = IndexWithinCheckpoint(blocksBuilt);
872
1197
  const blockNumber = BlockNumber(initialBlockNumber + blocksBuilt);
873
- const secondsIntoSlot = this.getSecondsIntoSlot();
874
- const timingInfo = this.timetable.canStartNextBlock(secondsIntoSlot);
1198
+ if (blocksBuilt >= this.config.maxBlocksPerCheckpoint) {
1199
+ this.log.debug(`Reached max blocks per checkpoint`, {
1200
+ slot: this.targetSlot,
1201
+ blocksBuilt,
1202
+ maxBlocksPerCheckpoint: this.config.maxBlocksPerCheckpoint
1203
+ });
1204
+ break;
1205
+ }
1206
+ const nowSeconds = this.dateProvider.now() / 1000;
1207
+ const timingInfo = this.timetable.selectNextSubslot(this.targetSlot, nowSeconds);
875
1208
  if (!timingInfo.canStart) {
876
1209
  this.log.debug(`Not enough time left in slot to start another block`, {
877
1210
  slot: this.targetSlot,
878
1211
  blocksBuilt,
879
- secondsIntoSlot
1212
+ nowSeconds
880
1213
  });
881
1214
  break;
882
1215
  }
@@ -885,23 +1218,24 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
885
1218
  blockTimestamp: timestamp,
886
1219
  // Create an empty block if we haven't already and this is the last one
887
1220
  forceCreate: timingInfo.isLastBlock && blocksBuilt === 0 && this.config.buildCheckpointIfEmpty,
888
- // Build deadline is only set if we are enforcing the timetable
889
- buildDeadline: timingInfo.deadline ? new Date((this.getSlotStartBuildTimestamp() + timingInfo.deadline) * 1000) : undefined,
1221
+ buildDeadline: new Date(timingInfo.deadline * 1000),
890
1222
  blockNumber,
891
1223
  indexWithinCheckpoint,
892
1224
  txHashesAlreadyIncluded
893
1225
  });
894
- // TODO(palla/mbps): Review these conditions. We may want to keep trying in some scenarios.
895
- if (!buildResult && timingInfo.isLastBlock) {
896
- break;
897
- } else if (!buildResult && timingInfo.deadline !== undefined) {
898
- // But if there is still time for more blocks, wait until the next subslot and try again
1226
+ // If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
1227
+ if ('failure' in buildResult) {
1228
+ // If this was the last subslot, we're done.
1229
+ if (timingInfo.isLastBlock) {
1230
+ break;
1231
+ }
1232
+ // Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
899
1233
  await this.waitUntilNextSubslot(timingInfo.deadline);
900
1234
  continue;
901
- } else if (!buildResult) {
902
- break;
903
- } else if ('error' in buildResult) {
904
- // If there was an error building the block, just exit the loop and give up the rest of the slot
1235
+ }
1236
+ // If there was an error building the block, we just exit the loop and give up the rest of the slot.
1237
+ // We don't want to risk building more blocks if something went wrong.
1238
+ if ('error' in buildResult) {
905
1239
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
906
1240
  this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
907
1241
  slot: this.targetSlot,
@@ -912,34 +1246,36 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
912
1246
  break;
913
1247
  }
914
1248
  const { block, usedTxs } = buildResult;
1249
+ this.checkpointMetrics.noteCheckpointBlockBuilt(this.dateProvider.now(), {
1250
+ isFirstBlock: blocksBuilt === 0,
1251
+ isLastBlock: timingInfo.isLastBlock
1252
+ });
915
1253
  blocksInCheckpoint.push(block);
916
1254
  usedTxs.forEach((tx)=>txHashesAlreadyIncluded.add(tx.txHash.toString()));
917
- // If this is the last block, sync it to the archiver and exit the loop
918
- // so we can build the checkpoint and start collecting attestations.
1255
+ // Sign the block proposal. This will throw if HA signing fails.
1256
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, {
1257
+ ...blockProposalOptions,
1258
+ broadcastInvalidBlockProposal: blockProposalOptions.broadcastInvalidBlockProposal || block.indexWithinCheckpoint === this.config.invalidBlockProposalIndexWithinCheckpoint
1259
+ });
1260
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
1261
+ // so we avoid polluting our archive with a block that would fail.
1262
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
1263
+ // If this throws, we abort the entire checkpoint.
1264
+ await this.syncProposedBlockToArchiver(block);
1265
+ // If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
919
1266
  if (timingInfo.isLastBlock) {
920
- await this.syncProposedBlockToArchiver(block);
921
1267
  this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
922
1268
  slot: this.targetSlot,
923
1269
  blockNumber,
924
1270
  blocksBuilt
925
1271
  });
926
- blockPendingBroadcast = {
927
- block,
928
- txs: usedTxs
929
- };
1272
+ blockPendingBroadcast = proposal;
930
1273
  break;
931
1274
  }
932
- // Broadcast the block proposal (unless we're in fisherman mode) unless the block is the last one,
933
- // in which case we'll broadcast it along with the checkpoint at the end of the loop.
934
- // Note that we only send the block to the archiver if we manage to create the proposal, so if there's
935
- // a HA error we don't pollute our archiver with a block that won't make it to the chain.
936
- const proposal = await this.createBlockProposal(block, inHash, usedTxs, blockProposalOptions);
937
- // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal.
938
- // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
939
- // If this throws, we abort the entire checkpoint.
940
- await this.syncProposedBlockToArchiver(block);
941
1275
  // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
942
- proposal && await this.p2pClient.broadcastProposal(proposal);
1276
+ if (proposal && !this.config.skipBroadcastProposals) {
1277
+ await this.p2pClient.broadcastProposal(proposal);
1278
+ }
943
1279
  // Wait until the next block's start time
944
1280
  await this.waitUntilNextSubslot(timingInfo.deadline);
945
1281
  }
@@ -957,14 +1293,17 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
957
1293
  this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
958
1294
  return Promise.resolve(undefined);
959
1295
  }
960
- return this.validatorClient.createBlockProposal(block.header, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
1296
+ return this.validatorClient.createBlockProposal(block.header, this.checkpointNumber, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
961
1297
  }
962
- /** Sleeps until it is time to produce the next block in the slot */ async waitUntilNextSubslot(nextSubslotStart) {
963
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.targetSlot);
964
- this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
1298
+ /**
1299
+ * Sleeps until it is time to produce the next block in the slot.
1300
+ * @param nextSubslotStart - Absolute wall-clock timestamp in seconds of the previous sub-slot deadline.
1301
+ */ async waitUntilNextSubslot(nextSubslotStart) {
1302
+ this.setState(SequencerState.WAITING_UNTIL_NEXT_BLOCK);
1303
+ this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s`, {
965
1304
  slot: this.targetSlot
966
1305
  });
967
- await this.waitUntilTimeInSlot(nextSubslotStart);
1306
+ await this.awaitInterruptibleSleep(Math.max(0, nextSubslotStart * 1000 - this.dateProvider.now()));
968
1307
  }
969
1308
  /** Builds a single block. Called from the main block building loop. */ async buildSingleBlock(checkpointBuilder, opts) {
970
1309
  const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } = opts;
@@ -974,42 +1313,63 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
974
1313
  });
975
1314
  try {
976
1315
  // Wait until we have enough txs to build the block
977
- const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
1316
+ const { canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
978
1317
  if (!canStartBuilding) {
979
- this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (got ${availableTxs} txs but needs ${minTxs})`, {
1318
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1319
+ reason: 'insufficient_txs',
980
1320
  blockNumber,
981
1321
  slot: this.targetSlot,
982
- indexWithinCheckpoint
1322
+ checkpointNumber: this.checkpointNumber,
1323
+ indexWithinCheckpoint,
1324
+ minTxs
1325
+ });
1326
+ this.log.verbose(`Not enough age-eligible txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (needs ${minTxs} eligible)`, {
1327
+ reason: 'insufficient_txs',
1328
+ blockNumber,
1329
+ slot: this.targetSlot,
1330
+ checkpointNumber: this.checkpointNumber,
1331
+ indexWithinCheckpoint,
1332
+ minTxs
983
1333
  });
984
1334
  this.eventEmitter.emit('block-tx-count-check-failed', {
985
1335
  minTxs,
986
- availableTxs,
987
1336
  slot: this.targetSlot
988
1337
  });
989
1338
  this.metrics.recordBlockProposalFailed('insufficient_txs');
990
- return undefined;
1339
+ return {
1340
+ failure: 'insufficient-txs'
1341
+ };
991
1342
  }
992
1343
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
993
1344
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
994
- const pendingTxs = filter(this.p2pClient.iterateEligiblePendingTxs(), (tx)=>!txHashesAlreadyIncluded.has(tx.txHash.toString()));
995
- this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot} with ${availableTxs} available txs`, {
1345
+ // Block building only executes txs, so we skip loading their proofs unless these same tx objects get attached
1346
+ // to the broadcasted proposals via publishTxsWithProposals.
1347
+ const pendingTxs = filter(this.p2pClient.iterateEligiblePendingTxs({
1348
+ includeProof: !!this.config.publishTxsWithProposals
1349
+ }), (tx)=>!txHashesAlreadyIncluded.has(tx.txHash.toString()));
1350
+ this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot}`, {
996
1351
  slot: this.targetSlot,
997
1352
  blockNumber,
998
1353
  indexWithinCheckpoint
999
1354
  });
1000
- this.setStateFn(SequencerState.CREATING_BLOCK, this.targetSlot);
1355
+ this.setState(SequencerState.CREATING_BLOCK);
1001
1356
  // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
1002
1357
  // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
1003
1358
  // minValidTxs is passed into the builder so it can reject the block *before* updating state.
1004
- const minValidTxs = forceCreate ? 0 : this.config.minValidTxsPerBlock ?? minTxs;
1359
+ // Only the first block of a checkpoint may be empty, since this allows a checkpoint to be created
1360
+ // even if there are no transactions. If an empty block appears after the first, it can't be proven
1361
+ // (there is no rollup circuit shaped to allow this), so the floor for minValidTxs is 1.
1362
+ const configuredMinValidTxs = forceCreate ? 0 : this.config.minValidTxsPerBlock ?? minTxs;
1363
+ const minValidTxs = indexWithinCheckpoint > 0 ? Math.max(configuredMinValidTxs, 1) : configuredMinValidTxs;
1005
1364
  const blockBuilderOptions = {
1006
1365
  maxTransactions: this.config.maxTxsPerBlock,
1007
1366
  maxBlockGas: this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity) : undefined,
1008
1367
  deadline: buildDeadline,
1009
1368
  isBuildingProposal: true,
1010
1369
  minValidTxs,
1011
- maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
1012
- perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier
1370
+ maxBlocksPerCheckpoint: this.timetable.getMaxBlocksPerCheckpoint(),
1371
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier,
1372
+ perBlockDAAllocationMultiplier: this.config.perBlockDAAllocationMultiplier
1013
1373
  };
1014
1374
  // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
1015
1375
  // if the number of successfully processed txs is below minValidTxs, ensuring state is not
@@ -1018,8 +1378,19 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1018
1378
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
1019
1379
  await this.dropFailedTxsFromP2P(buildResult.failedTxs);
1020
1380
  if (buildResult.status === 'insufficient-valid-txs') {
1381
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1382
+ reason: 'insufficient_valid_txs',
1383
+ slot: this.targetSlot,
1384
+ checkpointNumber: this.checkpointNumber,
1385
+ blockNumber,
1386
+ numTxs: buildResult.processedCount,
1387
+ indexWithinCheckpoint,
1388
+ minValidTxs
1389
+ });
1021
1390
  this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`, {
1391
+ reason: 'insufficient_valid_txs',
1022
1392
  slot: this.targetSlot,
1393
+ checkpointNumber: this.checkpointNumber,
1023
1394
  blockNumber,
1024
1395
  numTxs: buildResult.processedCount,
1025
1396
  indexWithinCheckpoint,
@@ -1030,7 +1401,9 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1030
1401
  slot: this.targetSlot
1031
1402
  });
1032
1403
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
1033
- return undefined;
1404
+ return {
1405
+ failure: 'insufficient-valid-txs'
1406
+ };
1034
1407
  }
1035
1408
  // Block creation succeeded, emit stats and metrics
1036
1409
  const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
@@ -1053,10 +1426,13 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1053
1426
  // `buildSlot` is the wall-clock slot during which the block was actually built.
1054
1427
  this.eventEmitter.emit('block-proposed', {
1055
1428
  blockNumber: block.number,
1429
+ blockHash,
1430
+ checkpointNumber: this.checkpointNumber,
1431
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1056
1432
  slot: this.targetSlot,
1057
- buildSlot: this.slotNow
1433
+ buildSlot: this.getBuildSlot()
1058
1434
  });
1059
- this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe());
1435
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe(), this.targetSlot);
1060
1436
  return {
1061
1437
  block,
1062
1438
  usedTxs
@@ -1066,9 +1442,17 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1066
1442
  reason: err.message,
1067
1443
  slot: this.targetSlot
1068
1444
  });
1445
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1446
+ reason: err instanceof Error ? err.message : String(err),
1447
+ slot: this.targetSlot,
1448
+ checkpointNumber: this.checkpointNumber,
1449
+ blockNumber
1450
+ });
1069
1451
  this.log.error(`Error building block`, err, {
1070
- blockNumber,
1071
- slot: this.targetSlot
1452
+ reason: err instanceof Error ? err.message : String(err),
1453
+ slot: this.targetSlot,
1454
+ checkpointNumber: this.checkpointNumber,
1455
+ blockNumber
1072
1456
  });
1073
1457
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
1074
1458
  this.metrics.recordFailedBlock();
@@ -1102,42 +1486,65 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1102
1486
  const { indexWithinCheckpoint, blockNumber, buildDeadline, forceCreate } = opts;
1103
1487
  // We only allow a block with 0 txs in the first block of the checkpoint
1104
1488
  const minTxs = indexWithinCheckpoint > 0 && this.config.minTxsPerBlock === 0 ? 1 : this.config.minTxsPerBlock;
1105
- // Deadline is undefined if we are not enforcing the timetable, meaning we'll exit immediately when out of time
1106
- const startBuildingDeadline = buildDeadline ? new Date(buildDeadline.getTime() - this.timetable.minExecutionTime * 1000) : undefined;
1107
- let availableTxs = await this.p2pClient.getPendingTxCount();
1108
- while(!forceCreate && availableTxs < minTxs){
1489
+ // Latest time to keep waiting for txs: wait_for_txs_deadline = block_build_deadline(k) - min_block_duration.
1490
+ const startBuildingDeadline = buildDeadline ? new Date(buildDeadline.getTime() - this.timetable.minBlockDuration * 1000) : undefined;
1491
+ // Gate on age-eligible txs so we don't start building on txs the builder would then filter out for being
1492
+ // too fresh. hasEligiblePendingTxs early-exits once minTxs are eligible instead of counting the whole pool.
1493
+ while(!forceCreate && !await this.p2pClient.hasEligiblePendingTxs(minTxs)){
1109
1494
  // If we're past deadline, or we have no deadline, give up
1110
1495
  const now = this.dateProvider.nowAsDate();
1111
1496
  if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
1112
1497
  return {
1113
1498
  canStartBuilding: false,
1114
- availableTxs,
1115
1499
  minTxs
1116
1500
  };
1117
1501
  }
1118
1502
  // Wait a bit before checking again
1119
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.targetSlot);
1120
- this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (have ${availableTxs} but need ${minTxs})`, {
1503
+ this.setState(SequencerState.WAITING_FOR_TXS);
1504
+ this.log.verbose(`Waiting for ${minTxs} age-eligible txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot}`, {
1121
1505
  blockNumber,
1122
1506
  slot: this.targetSlot,
1123
- indexWithinCheckpoint
1507
+ indexWithinCheckpoint,
1508
+ minTxs
1124
1509
  });
1125
1510
  await this.waitForTxsPollingInterval();
1126
- availableTxs = await this.p2pClient.getPendingTxCount();
1127
1511
  }
1128
1512
  return {
1129
1513
  canStartBuilding: true,
1130
- availableTxs,
1131
1514
  minTxs
1132
1515
  };
1133
1516
  }
1517
+ async getSignedCommitteeAttestations(broadcast) {
1518
+ const { proposal, blockProposedAt } = broadcast;
1519
+ this.setState(SequencerState.COLLECTING_ATTESTATIONS);
1520
+ const attestations = await this.waitForAttestations(proposal);
1521
+ if (!attestations) {
1522
+ return undefined;
1523
+ }
1524
+ this.checkpointMetrics.recordCheckpointAttestationDelay(this.dateProvider.now() - blockProposedAt);
1525
+ // Proposer must sign over the attestations before pushing them to L1
1526
+ const signer = this.proposer ?? this.publisher.getSenderAddress();
1527
+ try {
1528
+ const attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.targetSlot, this.checkpointNumber);
1529
+ return {
1530
+ attestations,
1531
+ attestationsSignature
1532
+ };
1533
+ } catch (err) {
1534
+ if (this.handleHASigningError(err, 'Attestations signature')) {
1535
+ return;
1536
+ }
1537
+ this.log.error(`Error signing attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
1538
+ return undefined;
1539
+ }
1540
+ }
1134
1541
  /**
1135
1542
  * Waits for enough attestations to be collected via p2p.
1136
1543
  * This is run after all blocks for the checkpoint have been built.
1137
1544
  */ async waitForAttestations(proposal) {
1138
1545
  if (this.config.fishermanMode) {
1139
1546
  this.log.debug('Skipping attestation collection in fisherman mode');
1140
- return CommitteeAttestationsAndSigners.empty();
1547
+ return CommitteeAttestationsAndSigners.empty(this.getSignatureContext());
1141
1548
  }
1142
1549
  const slotNumber = proposal.slotNumber;
1143
1550
  const { committee, seed, epoch } = await this.epochCache.getCommittee(slotNumber);
@@ -1145,7 +1552,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1145
1552
  throw new Error('No committee when collecting attestations');
1146
1553
  } else if (committee.length === 0) {
1147
1554
  this.log.verbose(`Attesting committee is empty`);
1148
- return CommitteeAttestationsAndSigners.empty();
1555
+ return CommitteeAttestationsAndSigners.empty(this.getSignatureContext());
1149
1556
  } else {
1150
1557
  this.log.debug(`Attesting committee length is ${committee.length}`, {
1151
1558
  committee
@@ -1154,16 +1561,20 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1154
1561
  const numberOfRequiredAttestations = computeQuorum(committee.length);
1155
1562
  if (this.config.skipCollectingAttestations) {
1156
1563
  this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
1157
- const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
1158
- return new CommitteeAttestationsAndSigners(orderAttestations(attestations ?? [], committee));
1564
+ const attestations = await this.validatorClient?.collectOwnAttestations(proposal, this.checkpointNumber);
1565
+ this.logCheckpointAttestations('collected', committee, attestations ?? [], numberOfRequiredAttestations, {
1566
+ reason: 'collect_own_only'
1567
+ });
1568
+ return new CommitteeAttestationsAndSigners(orderAttestations(attestations ?? [], committee), this.getSignatureContext());
1159
1569
  }
1160
- const attestationTimeAllowed = this.config.enforceTimeTable ? this.timetable.getMaxAllowedTime(SequencerState.PUBLISHING_CHECKPOINT) : this.l1Constants.slotDuration;
1161
- const attestationDeadline = new Date((this.getSlotStartBuildTimestamp() + attestationTimeAllowed) * 1000);
1162
- this.metrics.recordRequiredAttestations(numberOfRequiredAttestations, attestationTimeAllowed);
1570
+ // Hard attestation-collection cutoff = the single consensus attestation_deadline (target_slot_start + S - 2E).
1571
+ const attestationDeadlineSeconds = this.timetable.getAttestationDeadline(this.targetSlot);
1572
+ const attestationDeadline = new Date(attestationDeadlineSeconds * 1000);
1573
+ this.metrics.recordRequiredAttestations(numberOfRequiredAttestations, Math.max(0, attestationDeadline.getTime() - this.dateProvider.now()));
1163
1574
  const collectAttestationsTimer = new Timer();
1164
1575
  let collectedAttestationsCount = 0;
1165
1576
  try {
1166
- const attestations = await this.validatorClient.collectAttestations(proposal, numberOfRequiredAttestations, attestationDeadline);
1577
+ const attestations = await this.validatorClient.collectAttestations(proposal, numberOfRequiredAttestations, attestationDeadline, this.checkpointNumber);
1167
1578
  collectedAttestationsCount = attestations.length;
1168
1579
  // Trim attestations to minimum required to save L1 calldata gas
1169
1580
  const localAddresses = this.validatorClient.getValidatorAddresses();
@@ -1173,20 +1584,55 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1173
1584
  }
1174
1585
  // Rollup contract requires that the signatures are provided in the order of the committee
1175
1586
  const sorted = orderAttestations(trimmed, committee);
1587
+ this.logCheckpointAttestations('collected', committee, attestations, numberOfRequiredAttestations, {
1588
+ submittedCount: trimmed.length
1589
+ });
1176
1590
  // Manipulate the attestations if we've been configured to do so
1177
- if (this.config.injectFakeAttestation || this.config.injectHighSValueAttestation || this.config.injectUnrecoverableSignatureAttestation || this.config.shuffleAttestationOrdering) {
1591
+ if (this.config.injectFakeAttestation || this.config.injectHighSValueAttestation || this.config.injectUnrecoverableSignatureAttestation || this.config.injectYParityAttestation || this.config.shuffleAttestationOrdering) {
1178
1592
  return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
1179
1593
  }
1180
- return new CommitteeAttestationsAndSigners(sorted);
1594
+ return new CommitteeAttestationsAndSigners(sorted, this.getSignatureContext());
1181
1595
  } catch (err) {
1182
1596
  if (err && err instanceof AttestationTimeoutError) {
1183
1597
  collectedAttestationsCount = err.collectedCount;
1598
+ this.logCheckpointAttestations('failed', committee, undefined, numberOfRequiredAttestations, {
1599
+ collectedCount: collectedAttestationsCount,
1600
+ reason: 'timeout'
1601
+ });
1602
+ this.log.error(`Timeout while waiting for attestations for checkpoint proposal at slot ${proposal.slotNumber} (collected ${collectedAttestationsCount}/${numberOfRequiredAttestations})`, err);
1603
+ } else {
1604
+ this.logCheckpointAttestations('failed', committee, undefined, numberOfRequiredAttestations, {
1605
+ collectedCount: collectedAttestationsCount,
1606
+ reason: err instanceof Error ? err.message : String(err)
1607
+ });
1608
+ this.log.error(`Error collecting attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
1184
1609
  }
1185
- throw err;
1610
+ return undefined;
1186
1611
  } finally{
1187
1612
  this.metrics.recordCollectedAttestations(collectedAttestationsCount, collectAttestationsTimer.ms());
1188
1613
  }
1189
1614
  }
1615
+ logCheckpointAttestations(status, committee, attestations, requiredAttestations, opts = {}) {
1616
+ const signedValidators = attestations?.map((attestation)=>attestation.getSender()?.toString()).filter((address)=>address !== undefined) ?? [];
1617
+ const collectedCount = opts.collectedCount ?? new Set(signedValidators).size;
1618
+ const missingValidatorCount = status === 'failed' ? Math.max(0, requiredAttestations - collectedCount) : undefined;
1619
+ this.logCheckpointEvent(`attestations-${status}`, `Checkpoint attestations ${status} for slot ${this.targetSlot}`, {
1620
+ slot: this.targetSlot,
1621
+ checkpointNumber: this.checkpointNumber,
1622
+ committeeSize: committee.length,
1623
+ requiredAttestations,
1624
+ collectedAttestations: collectedCount,
1625
+ ...opts.submittedCount !== undefined && {
1626
+ submittedAttestations: opts.submittedCount
1627
+ },
1628
+ ...missingValidatorCount !== undefined && {
1629
+ missingValidatorCount
1630
+ },
1631
+ ...opts.reason !== undefined && {
1632
+ reason: opts.reason
1633
+ }
1634
+ });
1635
+ }
1190
1636
  /** Breaks the attestations before publishing based on attack configs */ manipulateAttestations(slotNumber, epoch, seed, committee, attestations) {
1191
1637
  // Compute the proposer index in the committee, since we dont want to tweak it.
1192
1638
  // Otherwise, the L1 rollup contract will reject the block outright.
@@ -1212,7 +1658,15 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1212
1658
  unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
1213
1659
  }
1214
1660
  }
1215
- return new CommitteeAttestationsAndSigners(attestations);
1661
+ return new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext());
1662
+ }
1663
+ if (this.config.injectYParityAttestation) {
1664
+ // Force every non-proposer signed slot's recovery byte to yParity (v ∈ {0, 1}) form in the packed L1
1665
+ // tuple, after packAttestations has canonicalized it. The proposer's own slot is left canonical so
1666
+ // propose() still passes verifyProposer. Models a malicious proposer landing a checkpoint L1 accepts
1667
+ // but that can never be proven (ECDSA.recover rejects v ∉ {27, 28}).
1668
+ this.log.warn(`Injecting yParity attestations in checkpoint for slot ${slotNumber} (proposer #${proposerIndex})`);
1669
+ return new MaliciousYParityCommitteeAttestationsAndSigners(attestations, proposerIndex, this.getSignatureContext());
1216
1670
  }
1217
1671
  if (this.config.shuffleAttestationOrdering) {
1218
1672
  this.log.warn(`Shuffling attestation ordering in checkpoint for slot ${slotNumber} (proposer #${proposerIndex})`);
@@ -1238,10 +1692,10 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1238
1692
  shuffled[i]
1239
1693
  ];
1240
1694
  }
1241
- const signers = new CommitteeAttestationsAndSigners(attestations).getSigners();
1242
- return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers);
1695
+ const signers = new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext()).getSigners();
1696
+ return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers, this.getSignatureContext());
1243
1697
  }
1244
- return new CommitteeAttestationsAndSigners(attestations);
1698
+ return new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext());
1245
1699
  }
1246
1700
  async dropFailedTxsFromP2P(failedTxs) {
1247
1701
  if (failedTxs.length === 0) {
@@ -1249,15 +1703,27 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1249
1703
  }
1250
1704
  const failedTxData = failedTxs.map((fail)=>fail.tx);
1251
1705
  const failedTxHashes = failedTxData.map((tx)=>tx.getTxHash());
1252
- this.log.verbose(`Dropping failed txs ${failedTxHashes.join(', ')}`);
1706
+ const failures = failedTxs.map((fail)=>({
1707
+ txHash: fail.tx.getTxHash().toString(),
1708
+ reason: fail.error.message
1709
+ }));
1710
+ this.log.warn(`Dropping ${failedTxs.length} txs from mempool due to failures during block building for slot ${this.targetSlot}`, {
1711
+ slot: this.targetSlot,
1712
+ checkpointNumber: this.checkpointNumber,
1713
+ failures
1714
+ });
1253
1715
  await this.p2pClient.handleFailedExecution(failedTxHashes);
1254
1716
  }
1255
1717
  /**
1256
1718
  * Adds the proposed block to the archiver so it's available via P2P.
1257
1719
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
1258
1720
  * would never receive its own block without this explicit sync.
1721
+ *
1722
+ * In fisherman mode we skip this push: the fisherman builds blocks locally for validation
1723
+ * and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
1724
+ * whenever the real proposer's block arrives from L1.
1259
1725
  */ async syncProposedBlockToArchiver(block) {
1260
- if (this.config.skipPushProposedBlocksToArchiver) {
1726
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
1261
1727
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
1262
1728
  blockNumber: block.number,
1263
1729
  slot: block.header.globalVariables.slotNumber
@@ -1270,6 +1736,35 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1270
1736
  });
1271
1737
  await this.blockSink.addBlock(block);
1272
1738
  }
1739
+ /**
1740
+ * Adds the proposed checkpoint to the archiver so the proposer's optimistic proposed-checkpoint
1741
+ * tip advances locally. Gossip doesn't echo our own messages back, so without this the proposer
1742
+ * would never see its own proposed checkpoint and couldn't pipeline the next slot.
1743
+ *
1744
+ * Skipped whenever proposed blocks aren't pushed (`skipPushProposedBlocksToArchiver`, fisherman
1745
+ * mode): the archiver derives the checkpoint archive from its stored blocks, so without them the
1746
+ * push would fail. All blocks were already added (and awaited) during block building, so this
1747
+ * needs no retry — they are guaranteed present by the time we get here.
1748
+ */ async syncProposedCheckpointToArchiver(checkpoint, blockCount, feeAssetPriceModifier) {
1749
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
1750
+ return;
1751
+ }
1752
+ const startBlock = BlockNumber(this.syncedToBlockNumber + 1);
1753
+ this.log.debug(`Syncing proposed checkpoint ${this.checkpointNumber} to archiver`, {
1754
+ checkpointNumber: this.checkpointNumber,
1755
+ slot: this.targetSlot,
1756
+ startBlock,
1757
+ blockCount
1758
+ });
1759
+ await this.blockSink.addProposedCheckpoint({
1760
+ header: checkpoint.header,
1761
+ checkpointNumber: this.checkpointNumber,
1762
+ startBlock,
1763
+ blockCount,
1764
+ totalManaUsed: checkpoint.header.totalManaUsed.toBigInt(),
1765
+ feeAssetPriceModifier
1766
+ });
1767
+ }
1273
1768
  /** Runs fee analysis and logs checkpoint outcome as fisherman */ async handleCheckpointEndAsFisherman(checkpoint) {
1274
1769
  // Perform L1 fee analysis before clearing requests
1275
1770
  // The callback is invoked asynchronously after the next block is mined
@@ -1309,54 +1804,8 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1309
1804
  }
1310
1805
  return false;
1311
1806
  }
1312
- /**
1313
- * In times of congestion we need to simulate using the correct fee header override for the previous block
1314
- * We calculate the correct fee header values.
1315
- *
1316
- * If we are in block 1, or the checkpoint we are querying does not exist, we return undefined. However
1317
- * If we are pipelining - where this function is called, the grandparentCheckpointNumber should always exist
1318
- * @param parentCheckpointNumber
1319
- * @returns
1320
- */ async computeForceProposedFeeHeader(parentCheckpointNumber) {
1321
- if (!this.proposedCheckpointData) {
1322
- return undefined;
1323
- }
1324
- const rollup = this.publisher.rollupContract;
1325
- const grandparentCheckpointNumber = CheckpointNumber(this.checkpointNumber - 2);
1326
- try {
1327
- const [grandparentCheckpoint, manaTarget] = await Promise.all([
1328
- rollup.getCheckpoint(grandparentCheckpointNumber),
1329
- rollup.getManaTarget()
1330
- ]);
1331
- if (!grandparentCheckpoint || !grandparentCheckpoint.feeHeader) {
1332
- this.log.error(`Grandparent checkpoint or its feeHeader is undefined for checkpointNumber=${grandparentCheckpointNumber.toString()}`);
1333
- return undefined;
1334
- } else {
1335
- const parentFeeHeader = RollupContract.computeChildFeeHeader(grandparentCheckpoint.feeHeader, this.proposedCheckpointData.totalManaUsed, this.proposedCheckpointData.feeAssetPriceModifier, manaTarget);
1336
- return {
1337
- checkpointNumber: parentCheckpointNumber,
1338
- feeHeader: parentFeeHeader
1339
- };
1340
- }
1341
- } catch (err) {
1342
- this.log.error(`Failed to fetch grandparent checkpoint or mana target for checkpointNumber=${grandparentCheckpointNumber.toString()}: ${err}`);
1343
- return undefined;
1344
- }
1345
- }
1346
- /** Waits until a specific time within the current slot */ async waitUntilTimeInSlot(targetSecondsIntoSlot) {
1347
- const slotStartTimestamp = this.getSlotStartBuildTimestamp();
1348
- const targetTimestamp = slotStartTimestamp + targetSecondsIntoSlot;
1349
- await sleepUntil(new Date(targetTimestamp * 1000), this.dateProvider.nowAsDate());
1350
- }
1351
1807
  /** Waits the polling interval for transactions. Extracted for test overriding. */ async waitForTxsPollingInterval() {
1352
- await sleep(TXS_POLLING_MS);
1353
- }
1354
- getSlotStartBuildTimestamp() {
1355
- return getSlotStartBuildTimestamp(this.slotNow, this.l1Constants);
1356
- }
1357
- getSecondsIntoSlot() {
1358
- const slotStartTimestamp = this.getSlotStartBuildTimestamp();
1359
- return Number((this.dateProvider.now() / 1000 - slotStartTimestamp).toFixed(3));
1808
+ await this.awaitInterruptibleSleep(TXS_POLLING_MS);
1360
1809
  }
1361
1810
  getPublisher() {
1362
1811
  return this.publisher;