@aztec/sequencer-client 0.0.1-commit.358457c → 0.0.1-commit.3750d92a7

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (80) hide show
  1. package/dest/client/sequencer-client.d.ts +6 -1
  2. package/dest/client/sequencer-client.d.ts.map +1 -1
  3. package/dest/client/sequencer-client.js +49 -27
  4. package/dest/config.d.ts +25 -5
  5. package/dest/config.d.ts.map +1 -1
  6. package/dest/config.js +36 -25
  7. package/dest/global_variable_builder/fee_predictor.d.ts +37 -0
  8. package/dest/global_variable_builder/fee_predictor.d.ts.map +1 -0
  9. package/dest/global_variable_builder/fee_predictor.js +128 -0
  10. package/dest/global_variable_builder/fee_provider.d.ts +21 -0
  11. package/dest/global_variable_builder/fee_provider.d.ts.map +1 -0
  12. package/dest/global_variable_builder/fee_provider.js +58 -0
  13. package/dest/global_variable_builder/global_builder.d.ts +15 -14
  14. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  15. package/dest/global_variable_builder/global_builder.js +16 -50
  16. package/dest/global_variable_builder/index.d.ts +4 -2
  17. package/dest/global_variable_builder/index.d.ts.map +1 -1
  18. package/dest/global_variable_builder/index.js +2 -0
  19. package/dest/publisher/config.d.ts +13 -1
  20. package/dest/publisher/config.d.ts.map +1 -1
  21. package/dest/publisher/config.js +19 -4
  22. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +3 -4
  23. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -1
  24. package/dest/publisher/sequencer-publisher-factory.d.ts +3 -5
  25. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  26. package/dest/publisher/sequencer-publisher-factory.js +16 -3
  27. package/dest/publisher/sequencer-publisher.d.ts +55 -43
  28. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  29. package/dest/publisher/sequencer-publisher.js +180 -116
  30. package/dest/sequencer/chain_state_overrides.d.ts +25 -0
  31. package/dest/sequencer/chain_state_overrides.d.ts.map +1 -0
  32. package/dest/sequencer/chain_state_overrides.js +39 -0
  33. package/dest/sequencer/checkpoint_proposal_job.d.ts +26 -9
  34. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  35. package/dest/sequencer/checkpoint_proposal_job.js +350 -214
  36. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts +34 -0
  37. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts.map +1 -0
  38. package/dest/sequencer/checkpoint_proposal_job_metrics.js +72 -0
  39. package/dest/sequencer/checkpoint_voter.d.ts +1 -2
  40. package/dest/sequencer/checkpoint_voter.d.ts.map +1 -1
  41. package/dest/sequencer/checkpoint_voter.js +2 -5
  42. package/dest/sequencer/events.d.ts +2 -1
  43. package/dest/sequencer/events.d.ts.map +1 -1
  44. package/dest/sequencer/metrics.d.ts +9 -10
  45. package/dest/sequencer/metrics.d.ts.map +1 -1
  46. package/dest/sequencer/metrics.js +23 -20
  47. package/dest/sequencer/sequencer.d.ts +29 -11
  48. package/dest/sequencer/sequencer.d.ts.map +1 -1
  49. package/dest/sequencer/sequencer.js +137 -74
  50. package/dest/sequencer/timetable.d.ts +17 -3
  51. package/dest/sequencer/timetable.d.ts.map +1 -1
  52. package/dest/sequencer/timetable.js +51 -43
  53. package/dest/sequencer/types.d.ts +2 -2
  54. package/dest/sequencer/types.d.ts.map +1 -1
  55. package/dest/test/mock_checkpoint_builder.d.ts +7 -9
  56. package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
  57. package/dest/test/mock_checkpoint_builder.js +39 -30
  58. package/package.json +27 -28
  59. package/src/client/sequencer-client.ts +61 -28
  60. package/src/config.ts +44 -27
  61. package/src/global_variable_builder/README.md +44 -0
  62. package/src/global_variable_builder/fee_predictor.ts +172 -0
  63. package/src/global_variable_builder/fee_provider.ts +75 -0
  64. package/src/global_variable_builder/global_builder.ts +26 -62
  65. package/src/global_variable_builder/index.ts +3 -1
  66. package/src/publisher/config.ts +38 -4
  67. package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +3 -1
  68. package/src/publisher/sequencer-publisher-factory.ts +18 -6
  69. package/src/publisher/sequencer-publisher.ts +263 -167
  70. package/src/sequencer/README.md +83 -13
  71. package/src/sequencer/chain_state_overrides.ts +87 -0
  72. package/src/sequencer/checkpoint_proposal_job.ts +452 -241
  73. package/src/sequencer/checkpoint_proposal_job_metrics.ts +128 -0
  74. package/src/sequencer/checkpoint_voter.ts +1 -12
  75. package/src/sequencer/events.ts +1 -1
  76. package/src/sequencer/metrics.ts +29 -25
  77. package/src/sequencer/sequencer.ts +198 -81
  78. package/src/sequencer/timetable.ts +64 -52
  79. package/src/sequencer/types.ts +1 -1
  80. package/src/test/mock_checkpoint_builder.ts +51 -48
@@ -436,25 +436,25 @@ function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
436
436
  return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
437
437
  }
438
438
  var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _initProto;
439
- import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
440
- import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
441
439
  import { BlockNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
442
440
  import { randomInt } from '@aztec/foundation/crypto/random';
443
- import { Signature } from '@aztec/foundation/eth-signature';
441
+ import { flipSignature, generateRecoverableSignature, generateUnrecoverableSignature } from '@aztec/foundation/crypto/secp256k1-signer';
444
442
  import { filter } from '@aztec/foundation/iterator';
445
443
  import { createLogger } from '@aztec/foundation/log';
446
444
  import { sleep, sleepUntil } from '@aztec/foundation/sleep';
447
445
  import { Timer } from '@aztec/foundation/timer';
448
446
  import { isErrorClass, unfreeze } from '@aztec/foundation/types';
449
447
  import { CommitteeAttestationsAndSigners, MaliciousCommitteeAttestationsAndSigners } from '@aztec/stdlib/block';
450
- import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
448
+ import { validateCheckpoint } from '@aztec/stdlib/checkpoint';
449
+ import { computeQuorum, getSlotStartBuildTimestamp, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
451
450
  import { Gas } from '@aztec/stdlib/gas';
452
- import { NoValidTxsError } from '@aztec/stdlib/interfaces/server';
451
+ import { InsufficientValidTxsError } from '@aztec/stdlib/interfaces/server';
453
452
  import { computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
454
453
  import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
455
454
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
456
455
  import { Attributes, trackSpan } from '@aztec/telemetry-client';
457
456
  import { DutyAlreadySignedError, SlashingProtectionError } from '@aztec/validator-ha-signer/errors';
457
+ import { buildPipelinedParentSimulationOverridesPlan, buildSubmissionSimulationOverridesPlan } from './chain_state_overrides.js';
458
458
  import { CheckpointVoter } from './checkpoint_voter.js';
459
459
  import { SequencerInterruptedError } from './errors.js';
460
460
  import { SequencerState } from './utils.js';
@@ -463,7 +463,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
463
463
  return {
464
464
  // nullish operator needed for tests
465
465
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
466
- [Attributes.SLOT_NUMBER]: this.slot
466
+ [Attributes.SLOT_NUMBER]: this.targetSlot
467
467
  };
468
468
  }), _dec2 = trackSpan('CheckpointProposalJob.buildBlocksForCheckpoint'), _dec3 = trackSpan('CheckpointProposalJob.waitUntilNextSubslot'), _dec4 = trackSpan('CheckpointProposalJob.buildSingleBlock'), _dec5 = trackSpan('CheckpointProposalJob.waitForMinTxs'), _dec6 = trackSpan('CheckpointProposalJob.waitForAttestations'), _dec7 = trackSpan('CheckpointProposalJob.waitUntilTimeInSlot');
469
469
  /**
@@ -472,8 +472,9 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
472
472
  * as well as enqueueing votes for slashing and governance proposals. This class is created from
473
473
  * the Sequencer once the check for being the proposer for the slot has succeeded.
474
474
  */ export class CheckpointProposalJob {
475
- epoch;
476
- slot;
475
+ slotNow;
476
+ targetSlot;
477
+ targetEpoch;
477
478
  checkpointNumber;
478
479
  syncedToBlockNumber;
479
480
  proposer;
@@ -495,9 +496,11 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
495
496
  epochCache;
496
497
  dateProvider;
497
498
  metrics;
499
+ checkpointMetrics;
498
500
  eventEmitter;
499
501
  setStateFn;
500
502
  tracer;
503
+ proposedCheckpointData;
501
504
  static{
502
505
  ({ e: [_initProto] } = _apply_decs_2203_r(this, [
503
506
  [
@@ -543,10 +546,13 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
543
546
  ], []));
544
547
  }
545
548
  log;
546
- constructor(epoch, slot, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
547
- proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, eventEmitter, setStateFn, tracer, bindings){
548
- this.epoch = epoch;
549
- this.slot = slot;
549
+ /** Tracks the fire-and-forget L1 submission promise so it can be awaited during shutdown. */ pendingL1Submission;
550
+ /** Pipelined parent chain state used while building and later submitting this checkpoint. */ pipelinedParentSimulationOverridesPlan;
551
+ constructor(slotNow, targetSlot, targetEpoch, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
552
+ proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, checkpointMetrics, eventEmitter, setStateFn, tracer, bindings, proposedCheckpointData){
553
+ this.slotNow = slotNow;
554
+ this.targetSlot = targetSlot;
555
+ this.targetEpoch = targetEpoch;
550
556
  this.checkpointNumber = checkpointNumber;
551
557
  this.syncedToBlockNumber = syncedToBlockNumber;
552
558
  this.proposer = proposer;
@@ -568,53 +574,142 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
568
574
  this.epochCache = epochCache;
569
575
  this.dateProvider = dateProvider;
570
576
  this.metrics = metrics;
577
+ this.checkpointMetrics = checkpointMetrics;
571
578
  this.eventEmitter = eventEmitter;
572
579
  this.setStateFn = setStateFn;
573
580
  this.tracer = tracer;
581
+ this.proposedCheckpointData = proposedCheckpointData;
574
582
  _initProto(this);
575
583
  this.log = createLogger('sequencer:checkpoint-proposal', {
576
584
  ...bindings,
577
- instanceId: `slot-${slot}`
585
+ instanceId: `slot-${this.slotNow}`
578
586
  });
579
587
  }
588
+ /** Awaits the pending L1 submission if one is in progress. Call during shutdown. */ async awaitPendingSubmission() {
589
+ this.log.info('Awaiting pending L1 payload submission');
590
+ await this.pendingL1Submission;
591
+ }
580
592
  /**
581
593
  * Executes the checkpoint proposal job.
582
- * Returns the published checkpoint if successful, undefined otherwise.
594
+ * Builds blocks, assembles checkpoint, and broadcasts the proposal (blocking).
595
+ * Attestation collection, signing, and L1 submission are backgrounded so the
596
+ * work loop can return to IDLE immediately for consecutive slot proposals.
597
+ * Returns the built checkpoint if successful, undefined otherwise.
583
598
  */ async execute() {
584
599
  // Enqueue governance and slashing votes (returns promises that will be awaited later)
585
600
  // In fisherman mode, we simulate slashing but don't actually publish to L1
586
601
  // These are constant for the whole slot, so we only enqueue them once
587
- const votesPromises = new CheckpointVoter(this.slot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
588
- // Build and propose the checkpoint. This will enqueue the request on the publisher if a checkpoint is built.
589
- const checkpoint = await this.proposeCheckpoint();
590
- // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
591
- await Promise.all(votesPromises);
592
- if (checkpoint) {
593
- this.metrics.recordCheckpointProposalSuccess();
602
+ const votesPromises = new CheckpointVoter(this.targetSlot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
603
+ // Build blocks, assemble checkpoint, and broadcast proposal (BLOCKING).
604
+ // Returns after broadcast — attestation collection is deferred.
605
+ const broadcast = await this.proposeCheckpoint();
606
+ if (!broadcast) {
607
+ await Promise.all(votesPromises);
608
+ // Still submit votes even without a checkpoint
609
+ if (!this.config.fishermanMode) {
610
+ this.pendingL1Submission = this.publisher.sendRequestsAt(this.dateProvider.nowAsDate()).then(()=>{});
611
+ }
612
+ return undefined;
594
613
  }
614
+ const { checkpoint } = broadcast;
615
+ this.metrics.recordCheckpointProposalSuccess();
595
616
  // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
596
617
  if (this.config.fishermanMode) {
597
618
  await this.handleCheckpointEndAsFisherman(checkpoint);
598
- return;
619
+ return checkpoint;
599
620
  }
600
- // Then send everything to L1
601
- const l1Response = await this.publisher.sendRequests();
602
- const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
603
- if (proposedAction) {
604
- this.eventEmitter.emit('checkpoint-published', {
605
- checkpoint: this.checkpointNumber,
606
- slot: this.slot
621
+ // Background the attestation signing → L1 pipeline so the work loop is unblocked
622
+ this.pendingL1Submission = this.waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises);
623
+ // Return the built checkpoint immediately — the work loop is now unblocked
624
+ return checkpoint;
625
+ }
626
+ /**
627
+ * Background pipeline: collects attestations, signs them, enqueues the checkpoint, and submits to L1.
628
+ * Runs as a fire-and-forget task stored in `pendingL1Submission` so the work loop is unblocked.
629
+ */ async waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises) {
630
+ const { checkpoint, proposal, blockProposedAt } = broadcast;
631
+ try {
632
+ await Promise.all(votesPromises);
633
+ this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.targetSlot);
634
+ const attestations = await this.waitForAttestations(proposal);
635
+ this.checkpointMetrics.recordCheckpointAttestationDelay(this.dateProvider.now() - blockProposedAt);
636
+ // Proposer must sign over the attestations before pushing them to L1
637
+ const signer = this.proposer ?? this.publisher.getSenderAddress();
638
+ let attestationsSignature;
639
+ try {
640
+ attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.targetSlot, this.checkpointNumber);
641
+ } catch (err) {
642
+ if (this.handleHASigningError(err, 'Attestations signature')) {
643
+ return;
644
+ }
645
+ throw err;
646
+ }
647
+ // Enqueue the checkpoint for L1 submission
648
+ await this.enqueueCheckpointForSubmission({
649
+ checkpoint,
650
+ attestations,
651
+ attestationsSignature
607
652
  });
608
- const coinbase = checkpoint?.header.coinbase;
609
- await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
610
- return checkpoint;
611
- } else if (checkpoint) {
653
+ // Compute the earliest time to submit: pipeline slot start when pipelining, now otherwise.
654
+ const submitAfter = this.epochCache.isProposerPipeliningEnabled() ? new Date(Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) * 1000) : new Date(this.dateProvider.now());
655
+ const l1Response = await this.publisher.sendRequestsAt(submitAfter);
656
+ const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
657
+ if (proposedAction) {
658
+ this.eventEmitter.emit('checkpoint-published', {
659
+ checkpoint: this.checkpointNumber,
660
+ slot: this.targetSlot
661
+ });
662
+ const coinbase = checkpoint.header.coinbase;
663
+ await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
664
+ } else {
665
+ this.eventEmitter.emit('checkpoint-publish-failed', {
666
+ ...l1Response,
667
+ slot: this.targetSlot
668
+ });
669
+ if (this.epochCache.isProposerPipeliningEnabled()) {
670
+ this.metrics.recordPipelineDiscard();
671
+ }
672
+ }
673
+ } catch (err) {
674
+ if (err instanceof SequencerInterruptedError) {
675
+ return;
676
+ }
677
+ this.log.error(`Background attestation/L1 pipeline failed for slot ${this.targetSlot}`, err);
612
678
  this.eventEmitter.emit('checkpoint-publish-failed', {
613
- ...l1Response,
614
- slot: this.slot
679
+ slot: this.targetSlot
615
680
  });
616
- return undefined;
681
+ if (this.epochCache.isProposerPipeliningEnabled()) {
682
+ this.metrics.recordPipelineDiscard();
683
+ }
684
+ }
685
+ }
686
+ /** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */ async enqueueCheckpointForSubmission(result) {
687
+ const { checkpoint, attestations, attestationsSignature } = result;
688
+ this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.targetSlot);
689
+ const aztecSlotDuration = this.l1Constants.slotDuration;
690
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
691
+ const txTimeoutAt = new Date((submissionSlotStart + aztecSlotDuration) * 1000);
692
+ // If we have been configured to potentially skip publishing checkpoint then roll the dice here
693
+ if (this.config.skipPublishingCheckpointsPercent !== undefined && this.config.skipPublishingCheckpointsPercent > 0) {
694
+ const roll = Math.max(0, randomInt(100));
695
+ if (roll < this.config.skipPublishingCheckpointsPercent) {
696
+ this.log.warn(`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${roll}`);
697
+ return;
698
+ }
617
699
  }
700
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
701
+ const submissionSimulationOverridesPlan = buildSubmissionSimulationOverridesPlan({
702
+ pipelinedParentPlan: this.pipelinedParentSimulationOverridesPlan,
703
+ invalidateToPendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
704
+ lastArchiveRoot: checkpoint.header.lastArchiveRoot,
705
+ pipeliningEnabled: isPipelining
706
+ });
707
+ await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
708
+ txTimeoutAt,
709
+ ...submissionSimulationOverridesPlan ? {
710
+ simulationOverridesPlan: submissionSimulationOverridesPlan
711
+ } : {}
712
+ });
618
713
  }
619
714
  async proposeCheckpoint() {
620
715
  try {
@@ -624,23 +719,48 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
624
719
  hasError: false
625
720
  };
626
721
  try {
722
+ const now = this.dateProvider.now();
723
+ if (this.epochCache.isProposerPipeliningEnabled() && this.proposedCheckpointData) {
724
+ // Measure against the wall-clock slot whose build window we are currently using.
725
+ // In pipelining mode `targetSlot` is intentionally one slot ahead, which makes the
726
+ // target-slot boundary a full slot away from the actual build start time.
727
+ const slotBoundaryMs = Number(getTimestampForSlot(this.slotNow, this.l1Constants)) * 1000;
728
+ this.checkpointMetrics.recordPipelinedCheckpointBuildStartOffsetFromSlotBoundary(now - slotBoundaryMs);
729
+ }
730
+ this.checkpointMetrics.startCheckpointTiming(now);
627
731
  // Get operator configured coinbase and fee recipient for this attestor
628
732
  const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
629
733
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
630
734
  // Start the checkpoint
631
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.slot);
632
- this.metrics.incOpenSlot(this.slot, this.proposer?.toString() ?? 'unknown');
735
+ this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.targetSlot);
736
+ this.log.info(`Starting checkpoint proposal`, {
737
+ buildSlot: this.slotNow,
738
+ submissionSlot: this.targetSlot,
739
+ pipelining: this.epochCache.isProposerPipeliningEnabled(),
740
+ proposer: this.proposer?.toString(),
741
+ coinbase: coinbase.toString()
742
+ });
743
+ this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
633
744
  // Enqueues checkpoint invalidation (constant for the whole slot)
634
745
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
635
746
  this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
636
747
  }
637
- // Create checkpoint builder for the slot
638
- const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.slot);
748
+ // Create checkpoint builder for the slot.
749
+ // When pipelining, force the proposed checkpoint number and fee header to our parent so the
750
+ // fee computation sees the same chain tip that L1 will see once the previous pipelined checkpoint lands.
751
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
752
+ this.pipelinedParentSimulationOverridesPlan = isPipelining ? await buildPipelinedParentSimulationOverridesPlan({
753
+ checkpointNumber: this.checkpointNumber,
754
+ proposedCheckpointData: this.proposedCheckpointData,
755
+ rollup: this.publisher.rollupContract,
756
+ log: this.log
757
+ }) : undefined;
758
+ const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.targetSlot, this.pipelinedParentSimulationOverridesPlan);
639
759
  // Collect L1 to L2 messages for the checkpoint and compute their hash
640
760
  const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(this.checkpointNumber);
641
761
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
642
762
  // Collect the out hashes of all the checkpoints before this one in the same epoch
643
- const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.epoch)).filter((c)=>c.checkpointNumber < this.checkpointNumber).map((c)=>c.checkpointOutHash);
763
+ const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.targetEpoch)).filter((c)=>c.checkpointNumber < this.checkpointNumber).map((c)=>c.checkpointOutHash);
644
764
  // Get the fee asset price modifier from the oracle
645
765
  const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier();
646
766
  const fork = _ts_add_disposable_resource(env, await this.worldState.fork(this.syncedToBlockNumber, {
@@ -675,18 +795,18 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
675
795
  throw err;
676
796
  }
677
797
  if (blocksInCheckpoint.length === 0) {
678
- this.log.warn(`No blocks were built for slot ${this.slot}`, {
679
- slot: this.slot
798
+ this.log.warn(`No blocks were built for slot ${this.targetSlot}`, {
799
+ slot: this.targetSlot
680
800
  });
681
801
  this.eventEmitter.emit('checkpoint-empty', {
682
- slot: this.slot
802
+ slot: this.targetSlot
683
803
  });
684
804
  return undefined;
685
805
  }
686
806
  const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
687
807
  if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
688
808
  this.log.warn(`Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`, {
689
- slot: this.slot,
809
+ slot: this.targetSlot,
690
810
  blocksBuilt: blocksInCheckpoint.length,
691
811
  minBlocksForCheckpoint
692
812
  });
@@ -694,65 +814,52 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
694
814
  }
695
815
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
696
816
  // broadcasted yet, and wait to collect the committee attestations.
697
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
817
+ this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.targetSlot);
698
818
  const checkpoint = await checkpointBuilder.completeCheckpoint();
819
+ // Final validation: per-block limits are only checked if the operator set them explicitly.
820
+ // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
821
+ try {
822
+ validateCheckpoint(checkpoint, {
823
+ rollupManaLimit: this.l1Constants.rollupManaLimit,
824
+ maxL2BlockGas: this.config.maxL2BlockGas,
825
+ maxDABlockGas: this.config.maxDABlockGas,
826
+ maxTxsPerBlock: this.config.maxTxsPerBlock,
827
+ maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint
828
+ });
829
+ } catch (err) {
830
+ this.log.error(`Built an invalid checkpoint at slot ${this.slotNow} (skipping proposal)`, err, {
831
+ checkpoint: checkpoint.header.toInspect()
832
+ });
833
+ return undefined;
834
+ }
699
835
  // Record checkpoint-level build metrics
700
- this.metrics.recordCheckpointBuild(checkpointBuildTimer.ms(), blocksInCheckpoint.length, checkpoint.getStats().txCount, Number(checkpoint.header.totalManaUsed.toBigInt()));
701
- // Do not collect attestations nor publish to L1 in fisherman mode
836
+ this.checkpointMetrics.recordCheckpointBuild(checkpointBuildTimer.ms(), blocksInCheckpoint.length, checkpoint.getStats().txCount, Number(checkpoint.header.totalManaUsed.toBigInt()));
837
+ // In fisherman mode, return the checkpoint without broadcasting or collecting attestations
702
838
  if (this.config.fishermanMode) {
703
- this.log.info(`Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
704
- slot: this.slot,
839
+ this.log.info(`Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
840
+ slot: this.targetSlot,
705
841
  checkpoint: checkpoint.header.toInspect(),
706
842
  blocksBuilt: blocksInCheckpoint.length
707
843
  });
708
844
  this.metrics.recordCheckpointSuccess();
709
- return checkpoint;
845
+ // Return a broadcast result with a dummy proposal — fisherman mode skips attestation collection
846
+ return {
847
+ checkpoint,
848
+ proposal: undefined,
849
+ blockProposedAt: this.dateProvider.now()
850
+ };
710
851
  }
711
- // Include the block pending broadcast in the checkpoint proposal if any
712
- const lastBlock = blockPendingBroadcast && {
713
- blockHeader: blockPendingBroadcast.block.header,
714
- indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
715
- txs: blockPendingBroadcast.txs
716
- };
717
852
  // Create the checkpoint proposal and broadcast it
718
- const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, feeAssetPriceModifier, lastBlock, this.proposer, checkpointProposalOptions);
853
+ const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, this.checkpointNumber, feeAssetPriceModifier, blockPendingBroadcast, this.proposer, checkpointProposalOptions);
719
854
  const blockProposedAt = this.dateProvider.now();
720
855
  await this.p2pClient.broadcastCheckpointProposal(proposal);
721
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
722
- const attestations = await this.waitForAttestations(proposal);
723
- const blockAttestedAt = this.dateProvider.now();
724
- this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
725
- // Proposer must sign over the attestations before pushing them to L1
726
- const signer = this.proposer ?? this.publisher.getSenderAddress();
727
- let attestationsSignature;
728
- try {
729
- attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.slot, this.checkpointNumber);
730
- } catch (err) {
731
- // We shouldn't really get here since we yield to another HA node
732
- // as soon as we see these errors when creating block or checkpoint proposals.
733
- if (this.handleHASigningError(err, 'Attestations signature')) {
734
- return undefined;
735
- }
736
- throw err;
737
- }
738
- // Enqueue publishing the checkpoint to L1
739
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
740
- const aztecSlotDuration = this.l1Constants.slotDuration;
741
- const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
742
- const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
743
- // If we have been configured to potentially skip publishing checkpoint then roll the dice here
744
- if (this.config.skipPublishingCheckpointsPercent !== undefined && this.config.skipPublishingCheckpointsPercent > 0) {
745
- const result = Math.max(0, randomInt(100));
746
- if (result < this.config.skipPublishingCheckpointsPercent) {
747
- this.log.warn(`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${result}`);
748
- return checkpoint;
749
- }
750
- }
751
- await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
752
- txTimeoutAt,
753
- forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber
754
- });
755
- return checkpoint;
856
+ this.checkpointMetrics.noteCheckpointBroadcast(this.dateProvider.now());
857
+ // Return immediately after broadcast — attestation collection happens in the background
858
+ return {
859
+ checkpoint,
860
+ proposal,
861
+ blockProposedAt
862
+ };
756
863
  } catch (e) {
757
864
  env.error = e;
758
865
  env.hasError = true;
@@ -765,7 +872,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
765
872
  // swallow this error. It's already been logged by a function deeper in the stack
766
873
  return undefined;
767
874
  }
768
- this.log.error(`Error building checkpoint at slot ${this.slot}`, err);
875
+ this.log.error(`Error building checkpoint at slot ${this.targetSlot}`, err);
769
876
  return undefined;
770
877
  }
771
878
  }
@@ -775,8 +882,6 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
775
882
  const blocksInCheckpoint = [];
776
883
  const txHashesAlreadyIncluded = new Set();
777
884
  const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
778
- // Remaining blob fields available for blocks (checkpoint end marker already subtracted)
779
- let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
780
885
  // Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
781
886
  let blockPendingBroadcast = undefined;
782
887
  while(true){
@@ -787,7 +892,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
787
892
  const timingInfo = this.timetable.canStartNextBlock(secondsIntoSlot);
788
893
  if (!timingInfo.canStart) {
789
894
  this.log.debug(`Not enough time left in slot to start another block`, {
790
- slot: this.slot,
895
+ slot: this.targetSlot,
791
896
  blocksBuilt,
792
897
  secondsIntoSlot
793
898
  });
@@ -802,68 +907,61 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
802
907
  buildDeadline: timingInfo.deadline ? new Date((this.getSlotStartBuildTimestamp() + timingInfo.deadline) * 1000) : undefined,
803
908
  blockNumber,
804
909
  indexWithinCheckpoint,
805
- txHashesAlreadyIncluded,
806
- remainingBlobFields
910
+ txHashesAlreadyIncluded
807
911
  });
808
- // TODO(palla/mbps): Review these conditions. We may want to keep trying in some scenarios.
809
- if (!buildResult && timingInfo.isLastBlock) {
810
- break;
811
- } else if (!buildResult && timingInfo.deadline !== undefined) {
812
- // But if there is still time for more blocks, wait until the next subslot and try again
912
+ // If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
913
+ if ('failure' in buildResult) {
914
+ // If this was the last subslot, or we're running with a single block per slot, we're done
915
+ if (timingInfo.isLastBlock || timingInfo.deadline === undefined) {
916
+ break;
917
+ }
918
+ // Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
813
919
  await this.waitUntilNextSubslot(timingInfo.deadline);
814
920
  continue;
815
- } else if (!buildResult) {
816
- break;
817
- } else if ('error' in buildResult) {
818
- // If there was an error building the block, just exit the loop and give up the rest of the slot
921
+ }
922
+ // If there was an error building the block, we just exit the loop and give up the rest of the slot.
923
+ // We don't want to risk building more blocks if something went wrong.
924
+ if ('error' in buildResult) {
819
925
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
820
- this.log.warn(`Halting block building for slot ${this.slot}`, {
821
- slot: this.slot,
926
+ this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
927
+ slot: this.targetSlot,
822
928
  blocksBuilt,
823
929
  error: buildResult.error
824
930
  });
825
931
  }
826
932
  break;
827
933
  }
828
- const { block, usedTxs, remainingBlobFields: newRemainingBlobFields } = buildResult;
829
- blocksInCheckpoint.push(block);
830
- // Update remaining blob fields for the next block
831
- remainingBlobFields = newRemainingBlobFields;
832
- // Sync the proposed block to the archiver to make it available
833
- // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
834
- // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
835
- // Fire and forget - don't block the critical path, but log errors
836
- this.syncProposedBlockToArchiver(block).catch((err)=>{
837
- this.log.error(`Failed to sync proposed block ${block.number} to archiver`, {
838
- blockNumber: block.number,
839
- err
840
- });
934
+ const { block, usedTxs } = buildResult;
935
+ this.checkpointMetrics.noteCheckpointBlockBuilt(this.dateProvider.now(), {
936
+ isFirstBlock: blocksBuilt === 0,
937
+ isLastBlock: timingInfo.isLastBlock
841
938
  });
939
+ blocksInCheckpoint.push(block);
842
940
  usedTxs.forEach((tx)=>txHashesAlreadyIncluded.add(tx.txHash.toString()));
843
- // If this is the last block, exit the loop now so we start collecting attestations
941
+ // Sign the block proposal. This will throw if HA signing fails.
942
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, blockProposalOptions);
943
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
944
+ // so we avoid polluting our archive with a block that would fail.
945
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
946
+ // If this throws, we abort the entire checkpoint.
947
+ await this.syncProposedBlockToArchiver(block);
948
+ // If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
844
949
  if (timingInfo.isLastBlock) {
845
- this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
846
- slot: this.slot,
950
+ this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
951
+ slot: this.targetSlot,
847
952
  blockNumber,
848
953
  blocksBuilt
849
954
  });
850
- blockPendingBroadcast = {
851
- block,
852
- txs: usedTxs
853
- };
955
+ blockPendingBroadcast = proposal;
854
956
  break;
855
957
  }
856
- // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
857
- // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
858
- if (!this.config.fishermanMode) {
859
- const proposal = await this.validatorClient.createBlockProposal(block.header, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
860
- await this.p2pClient.broadcastProposal(proposal);
861
- }
958
+ // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
959
+ proposal && await this.p2pClient.broadcastProposal(proposal);
862
960
  // Wait until the next block's start time
863
961
  await this.waitUntilNextSubslot(timingInfo.deadline);
864
962
  }
865
- this.log.verbose(`Block building loop completed for slot ${this.slot}`, {
866
- slot: this.slot,
963
+ this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
964
+ slot: this.targetSlot,
867
965
  blocksBuilt: blocksInCheckpoint.length
868
966
  });
869
967
  return {
@@ -871,82 +969,92 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
871
969
  blockPendingBroadcast
872
970
  };
873
971
  }
972
+ /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */ createBlockProposal(block, inHash, usedTxs, blockProposalOptions) {
973
+ if (this.config.fishermanMode) {
974
+ this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
975
+ return Promise.resolve(undefined);
976
+ }
977
+ return this.validatorClient.createBlockProposal(block.header, this.checkpointNumber, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
978
+ }
874
979
  /** Sleeps until it is time to produce the next block in the slot */ async waitUntilNextSubslot(nextSubslotStart) {
875
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
980
+ this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.targetSlot);
876
981
  this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
877
- slot: this.slot
982
+ slot: this.targetSlot
878
983
  });
879
984
  await this.waitUntilTimeInSlot(nextSubslotStart);
880
985
  }
881
986
  /** Builds a single block. Called from the main block building loop. */ async buildSingleBlock(checkpointBuilder, opts) {
882
- const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded, remainingBlobFields } = opts;
883
- this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`, {
987
+ const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } = opts;
988
+ this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`, {
884
989
  ...checkpointBuilder.getConstantData(),
885
990
  ...opts
886
991
  });
887
992
  try {
888
993
  // Wait until we have enough txs to build the block
889
- const minTxs = this.config.minTxsPerBlock;
890
- const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
994
+ const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
891
995
  if (!canStartBuilding) {
892
- this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`, {
996
+ this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (got ${availableTxs} txs but needs ${minTxs})`, {
893
997
  blockNumber,
894
- slot: this.slot,
998
+ slot: this.targetSlot,
895
999
  indexWithinCheckpoint
896
1000
  });
897
1001
  this.eventEmitter.emit('block-tx-count-check-failed', {
898
1002
  minTxs,
899
1003
  availableTxs,
900
- slot: this.slot
1004
+ slot: this.targetSlot
901
1005
  });
902
1006
  this.metrics.recordBlockProposalFailed('insufficient_txs');
903
- return undefined;
1007
+ return {
1008
+ failure: 'insufficient-txs'
1009
+ };
904
1010
  }
905
1011
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
906
1012
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
907
1013
  const pendingTxs = filter(this.p2pClient.iterateEligiblePendingTxs(), (tx)=>!txHashesAlreadyIncluded.has(tx.txHash.toString()));
908
- this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`, {
909
- slot: this.slot,
1014
+ this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot} with ${availableTxs} available txs`, {
1015
+ slot: this.targetSlot,
910
1016
  blockNumber,
911
1017
  indexWithinCheckpoint
912
1018
  });
913
- this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
914
- // Calculate blob fields limit for txs (remaining capacity - this block's end overhead)
915
- const blockEndOverhead = getNumBlockEndBlobFields(indexWithinCheckpoint === 0);
916
- const maxBlobFieldsForTxs = remainingBlobFields - blockEndOverhead;
1019
+ this.setStateFn(SequencerState.CREATING_BLOCK, this.targetSlot);
1020
+ // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
1021
+ // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
1022
+ // minValidTxs is passed into the builder so it can reject the block *before* updating state.
1023
+ const minValidTxs = forceCreate ? 0 : this.config.minValidTxsPerBlock ?? minTxs;
917
1024
  const blockBuilderOptions = {
918
1025
  maxTransactions: this.config.maxTxsPerBlock,
919
- maxBlockSize: this.config.maxBlockSizeInBytes,
920
- maxBlockGas: new Gas(this.config.maxDABlockGas, this.config.maxL2BlockGas),
921
- maxBlobFields: maxBlobFieldsForTxs,
922
- deadline: buildDeadline
1026
+ maxBlockGas: this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity) : undefined,
1027
+ deadline: buildDeadline,
1028
+ isBuildingProposal: true,
1029
+ minValidTxs,
1030
+ maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
1031
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier
923
1032
  };
924
- // Actually build the block by executing txs
1033
+ // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
1034
+ // if the number of successfully processed txs is below minValidTxs, ensuring state is not
1035
+ // updated for blocks that will be discarded.
925
1036
  const buildResult = await this.buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
926
1037
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
927
1038
  await this.dropFailedTxsFromP2P(buildResult.failedTxs);
928
- // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
929
- // too long, then we may not get to minTxsPerBlock after executing public functions.
930
- const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
931
- const numTxs = buildResult.status === 'no-valid-txs' ? 0 : buildResult.numTxs;
932
- if (buildResult.status === 'no-valid-txs' || !forceCreate && numTxs < minValidTxs) {
933
- this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed`, {
934
- slot: this.slot,
1039
+ if (buildResult.status === 'insufficient-valid-txs') {
1040
+ this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`, {
1041
+ slot: this.targetSlot,
935
1042
  blockNumber,
936
- numTxs,
1043
+ numTxs: buildResult.processedCount,
937
1044
  indexWithinCheckpoint,
938
- minValidTxs,
939
- buildResult: buildResult.status
1045
+ minValidTxs
940
1046
  });
941
1047
  this.eventEmitter.emit('block-build-failed', {
942
1048
  reason: `Insufficient valid txs`,
943
- slot: this.slot
1049
+ slot: this.targetSlot
944
1050
  });
945
1051
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
946
- return undefined;
1052
+ return {
1053
+ failure: 'insufficient-valid-txs'
1054
+ };
947
1055
  }
948
1056
  // Block creation succeeded, emit stats and metrics
949
- const { publicGas, block, publicProcessorDuration, usedTxs, usedTxBlobFields, blockBuildDuration } = buildResult;
1057
+ const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
950
1058
  const blockStats = {
951
1059
  eventName: 'l2-block-built',
952
1060
  duration: blockBuildDuration,
@@ -955,31 +1063,33 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
955
1063
  };
956
1064
  const blockHash = await block.hash();
957
1065
  const txHashes = block.body.txEffects.map((tx)=>tx.txHash);
958
- const manaPerSec = publicGas.l2Gas / (blockBuildDuration / 1000);
959
- this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`, {
1066
+ const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
1067
+ this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`, {
960
1068
  blockHash,
961
1069
  txHashes,
962
1070
  manaPerSec,
963
1071
  ...blockStats
964
1072
  });
1073
+ // `slot` is the target/submission slot (may be one ahead when pipelining),
1074
+ // `buildSlot` is the wall-clock slot during which the block was actually built.
965
1075
  this.eventEmitter.emit('block-proposed', {
966
1076
  blockNumber: block.number,
967
- slot: this.slot
1077
+ slot: this.targetSlot,
1078
+ buildSlot: this.slotNow
968
1079
  });
969
- this.metrics.recordBuiltBlock(blockBuildDuration, publicGas.l2Gas);
1080
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe(), this.targetSlot);
970
1081
  return {
971
1082
  block,
972
- usedTxs,
973
- remainingBlobFields: maxBlobFieldsForTxs - usedTxBlobFields
1083
+ usedTxs
974
1084
  };
975
1085
  } catch (err) {
976
1086
  this.eventEmitter.emit('block-build-failed', {
977
1087
  reason: err.message,
978
- slot: this.slot
1088
+ slot: this.targetSlot
979
1089
  });
980
1090
  this.log.error(`Error building block`, err, {
981
1091
  blockNumber,
982
- slot: this.slot
1092
+ slot: this.targetSlot
983
1093
  });
984
1094
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
985
1095
  this.metrics.recordFailedBlock();
@@ -988,7 +1098,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
988
1098
  };
989
1099
  }
990
1100
  }
991
- /** Uses the checkpoint builder to build a block, catching specific txs */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
1101
+ /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
992
1102
  try {
993
1103
  const workTimer = new Timer();
994
1104
  const result = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
@@ -999,10 +1109,11 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
999
1109
  status: 'success'
1000
1110
  };
1001
1111
  } catch (err) {
1002
- if (isErrorClass(err, NoValidTxsError)) {
1112
+ if (isErrorClass(err, InsufficientValidTxsError)) {
1003
1113
  return {
1004
1114
  failedTxs: err.failedTxs,
1005
- status: 'no-valid-txs'
1115
+ processedCount: err.processedCount,
1116
+ status: 'insufficient-valid-txs'
1006
1117
  };
1007
1118
  }
1008
1119
  throw err;
@@ -1021,14 +1132,15 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1021
1132
  if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
1022
1133
  return {
1023
1134
  canStartBuilding: false,
1024
- availableTxs: availableTxs
1135
+ availableTxs,
1136
+ minTxs
1025
1137
  };
1026
1138
  }
1027
1139
  // Wait a bit before checking again
1028
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.slot);
1029
- this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (have ${availableTxs} but need ${minTxs})`, {
1140
+ this.setStateFn(SequencerState.WAITING_FOR_TXS, this.targetSlot);
1141
+ this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (have ${availableTxs} but need ${minTxs})`, {
1030
1142
  blockNumber,
1031
- slot: this.slot,
1143
+ slot: this.targetSlot,
1032
1144
  indexWithinCheckpoint
1033
1145
  });
1034
1146
  await this.waitForTxsPollingInterval();
@@ -1036,7 +1148,8 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1036
1148
  }
1037
1149
  return {
1038
1150
  canStartBuilding: true,
1039
- availableTxs
1151
+ availableTxs,
1152
+ minTxs
1040
1153
  };
1041
1154
  }
1042
1155
  /**
@@ -1059,19 +1172,19 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1059
1172
  committee
1060
1173
  });
1061
1174
  }
1062
- const numberOfRequiredAttestations = Math.floor(committee.length * 2 / 3) + 1;
1175
+ const numberOfRequiredAttestations = computeQuorum(committee.length);
1063
1176
  if (this.config.skipCollectingAttestations) {
1064
1177
  this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
1065
- const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
1178
+ const attestations = await this.validatorClient?.collectOwnAttestations(proposal, this.checkpointNumber);
1066
1179
  return new CommitteeAttestationsAndSigners(orderAttestations(attestations ?? [], committee));
1067
1180
  }
1068
- const attestationTimeAllowed = this.config.enforceTimeTable ? this.timetable.getMaxAllowedTime(SequencerState.PUBLISHING_CHECKPOINT) : this.l1Constants.slotDuration;
1181
+ const attestationTimeAllowed = this.config.enforceTimeTable ? this.timetable.getCheckpointAttestationDeadline() : this.l1Constants.slotDuration;
1069
1182
  const attestationDeadline = new Date((this.getSlotStartBuildTimestamp() + attestationTimeAllowed) * 1000);
1070
1183
  this.metrics.recordRequiredAttestations(numberOfRequiredAttestations, attestationTimeAllowed);
1071
1184
  const collectAttestationsTimer = new Timer();
1072
1185
  let collectedAttestationsCount = 0;
1073
1186
  try {
1074
- const attestations = await this.validatorClient.collectAttestations(proposal, numberOfRequiredAttestations, attestationDeadline);
1187
+ const attestations = await this.validatorClient.collectAttestations(proposal, numberOfRequiredAttestations, attestationDeadline, this.checkpointNumber);
1075
1188
  collectedAttestationsCount = attestations.length;
1076
1189
  // Trim attestations to minimum required to save L1 calldata gas
1077
1190
  const localAddresses = this.validatorClient.getValidatorAddresses();
@@ -1082,7 +1195,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1082
1195
  // Rollup contract requires that the signatures are provided in the order of the committee
1083
1196
  const sorted = orderAttestations(trimmed, committee);
1084
1197
  // Manipulate the attestations if we've been configured to do so
1085
- if (this.config.injectFakeAttestation || this.config.shuffleAttestationOrdering) {
1198
+ if (this.config.injectFakeAttestation || this.config.injectHighSValueAttestation || this.config.injectUnrecoverableSignatureAttestation || this.config.shuffleAttestationOrdering) {
1086
1199
  return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
1087
1200
  }
1088
1201
  return new CommitteeAttestationsAndSigners(sorted);
@@ -1099,7 +1212,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1099
1212
  // Compute the proposer index in the committee, since we dont want to tweak it.
1100
1213
  // Otherwise, the L1 rollup contract will reject the block outright.
1101
1214
  const proposerIndex = Number(this.epochCache.computeProposerIndex(slotNumber, epoch, seed, BigInt(committee.length)));
1102
- if (this.config.injectFakeAttestation) {
1215
+ if (this.config.injectFakeAttestation || this.config.injectHighSValueAttestation || this.config.injectUnrecoverableSignatureAttestation) {
1103
1216
  // Find non-empty attestations that are not from the proposer
1104
1217
  const nonProposerIndices = [];
1105
1218
  for(let i = 0; i < attestations.length; i++){
@@ -1109,8 +1222,16 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1109
1222
  }
1110
1223
  if (nonProposerIndices.length > 0) {
1111
1224
  const targetIndex = nonProposerIndices[randomInt(nonProposerIndices.length)];
1112
- this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1113
- unfreeze(attestations[targetIndex]).signature = Signature.random();
1225
+ if (this.config.injectHighSValueAttestation) {
1226
+ this.log.warn(`Injecting high-s value attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1227
+ unfreeze(attestations[targetIndex]).signature = flipSignature(attestations[targetIndex].signature);
1228
+ } else if (this.config.injectUnrecoverableSignatureAttestation) {
1229
+ this.log.warn(`Injecting unrecoverable signature attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1230
+ unfreeze(attestations[targetIndex]).signature = generateUnrecoverableSignature();
1231
+ } else {
1232
+ this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1233
+ unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
1234
+ }
1114
1235
  }
1115
1236
  return new CommitteeAttestationsAndSigners(attestations);
1116
1237
  }
@@ -1119,14 +1240,25 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1119
1240
  const shuffled = [
1120
1241
  ...attestations
1121
1242
  ];
1122
- const [i, j] = [
1123
- (proposerIndex + 1) % shuffled.length,
1124
- (proposerIndex + 2) % shuffled.length
1125
- ];
1126
- const valueI = shuffled[i];
1127
- const valueJ = shuffled[j];
1128
- shuffled[i] = valueJ;
1129
- shuffled[j] = valueI;
1243
+ // Find two non-proposer positions that both have non-empty signatures to swap.
1244
+ // This ensures the bitmap doesn't change, so the MaliciousCommitteeAttestationsAndSigners
1245
+ // signers array stays correctly aligned with L1's committee reconstruction.
1246
+ const swappable = [];
1247
+ for(let k = 0; k < shuffled.length; k++){
1248
+ if (!shuffled[k].signature.isEmpty() && k !== proposerIndex) {
1249
+ swappable.push(k);
1250
+ }
1251
+ }
1252
+ if (swappable.length >= 2) {
1253
+ const [i, j] = [
1254
+ swappable[0],
1255
+ swappable[1]
1256
+ ];
1257
+ [shuffled[i], shuffled[j]] = [
1258
+ shuffled[j],
1259
+ shuffled[i]
1260
+ ];
1261
+ }
1130
1262
  const signers = new CommitteeAttestationsAndSigners(attestations).getSigners();
1131
1263
  return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers);
1132
1264
  }
@@ -1145,8 +1277,12 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1145
1277
  * Adds the proposed block to the archiver so it's available via P2P.
1146
1278
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
1147
1279
  * would never receive its own block without this explicit sync.
1280
+ *
1281
+ * In fisherman mode we skip this push: the fisherman builds blocks locally for validation
1282
+ * and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
1283
+ * whenever the real proposer's block arrives from L1.
1148
1284
  */ async syncProposedBlockToArchiver(block) {
1149
- if (this.config.skipPushProposedBlocksToArchiver !== false) {
1285
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
1150
1286
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
1151
1287
  blockNumber: block.number,
1152
1288
  slot: block.header.globalVariables.slotNumber
@@ -1162,16 +1298,16 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1162
1298
  /** Runs fee analysis and logs checkpoint outcome as fisherman */ async handleCheckpointEndAsFisherman(checkpoint) {
1163
1299
  // Perform L1 fee analysis before clearing requests
1164
1300
  // The callback is invoked asynchronously after the next block is mined
1165
- const feeAnalysis = await this.publisher.analyzeL1Fees(this.slot, (analysis)=>this.metrics.recordFishermanFeeAnalysis(analysis));
1301
+ const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, (analysis)=>this.metrics.recordFishermanFeeAnalysis(analysis));
1166
1302
  if (checkpoint) {
1167
- this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.slot}`, {
1303
+ this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
1168
1304
  ...checkpoint.toCheckpointInfo(),
1169
1305
  ...checkpoint.getStats(),
1170
1306
  feeAnalysisId: feeAnalysis?.id
1171
1307
  });
1172
1308
  } else {
1173
- this.log.warn(`Validation block building FAILED for slot ${this.slot}`, {
1174
- slot: this.slot,
1309
+ this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
1310
+ slot: this.targetSlot,
1175
1311
  feeAnalysisId: feeAnalysis?.id
1176
1312
  });
1177
1313
  this.metrics.recordCheckpointProposalFailed('block_build_failed');
@@ -1182,15 +1318,15 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1182
1318
  * Helper to handle HA double-signing errors. Returns true if the error was handled (caller should yield).
1183
1319
  */ handleHASigningError(err, errorContext) {
1184
1320
  if (err instanceof DutyAlreadySignedError) {
1185
- this.log.info(`${errorContext} for slot ${this.slot} already signed by another HA node, yielding`, {
1186
- slot: this.slot,
1321
+ this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
1322
+ slot: this.targetSlot,
1187
1323
  signedByNode: err.signedByNode
1188
1324
  });
1189
1325
  return true;
1190
1326
  }
1191
1327
  if (err instanceof SlashingProtectionError) {
1192
- this.log.info(`${errorContext} for slot ${this.slot} blocked by slashing protection, yielding`, {
1193
- slot: this.slot,
1328
+ this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
1329
+ slot: this.targetSlot,
1194
1330
  existingMessageHash: err.existingMessageHash,
1195
1331
  attemptedMessageHash: err.attemptedMessageHash
1196
1332
  });
@@ -1207,7 +1343,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1207
1343
  await sleep(TXS_POLLING_MS);
1208
1344
  }
1209
1345
  getSlotStartBuildTimestamp() {
1210
- return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
1346
+ return getSlotStartBuildTimestamp(this.slotNow, this.l1Constants);
1211
1347
  }
1212
1348
  getSecondsIntoSlot() {
1213
1349
  const slotStartTimestamp = this.getSlotStartBuildTimestamp();