@aztec/sequencer-client 0.0.1-commit.3469e52 → 0.0.1-commit.35158ae7e

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (84) hide show
  1. package/dest/client/sequencer-client.d.ts +15 -7
  2. package/dest/client/sequencer-client.d.ts.map +1 -1
  3. package/dest/client/sequencer-client.js +60 -26
  4. package/dest/config.d.ts +26 -7
  5. package/dest/config.d.ts.map +1 -1
  6. package/dest/config.js +47 -30
  7. package/dest/global_variable_builder/global_builder.d.ts +14 -10
  8. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  9. package/dest/global_variable_builder/global_builder.js +24 -23
  10. package/dest/global_variable_builder/index.d.ts +2 -2
  11. package/dest/global_variable_builder/index.d.ts.map +1 -1
  12. package/dest/publisher/config.d.ts +47 -17
  13. package/dest/publisher/config.d.ts.map +1 -1
  14. package/dest/publisher/config.js +121 -42
  15. package/dest/publisher/index.d.ts +2 -1
  16. package/dest/publisher/index.d.ts.map +1 -1
  17. package/dest/publisher/l1_tx_failed_store/factory.d.ts +11 -0
  18. package/dest/publisher/l1_tx_failed_store/factory.d.ts.map +1 -0
  19. package/dest/publisher/l1_tx_failed_store/factory.js +22 -0
  20. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +59 -0
  21. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -0
  22. package/dest/publisher/l1_tx_failed_store/failed_tx_store.js +1 -0
  23. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts +15 -0
  24. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts.map +1 -0
  25. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.js +34 -0
  26. package/dest/publisher/l1_tx_failed_store/index.d.ts +4 -0
  27. package/dest/publisher/l1_tx_failed_store/index.d.ts.map +1 -0
  28. package/dest/publisher/l1_tx_failed_store/index.js +2 -0
  29. package/dest/publisher/sequencer-publisher-factory.d.ts +11 -3
  30. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  31. package/dest/publisher/sequencer-publisher-factory.js +27 -2
  32. package/dest/publisher/sequencer-publisher-metrics.d.ts +1 -1
  33. package/dest/publisher/sequencer-publisher-metrics.d.ts.map +1 -1
  34. package/dest/publisher/sequencer-publisher-metrics.js +12 -4
  35. package/dest/publisher/sequencer-publisher.d.ts +33 -10
  36. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  37. package/dest/publisher/sequencer-publisher.js +374 -57
  38. package/dest/sequencer/checkpoint_proposal_job.d.ts +41 -12
  39. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  40. package/dest/sequencer/checkpoint_proposal_job.js +295 -165
  41. package/dest/sequencer/events.d.ts +2 -1
  42. package/dest/sequencer/events.d.ts.map +1 -1
  43. package/dest/sequencer/metrics.d.ts +21 -5
  44. package/dest/sequencer/metrics.d.ts.map +1 -1
  45. package/dest/sequencer/metrics.js +122 -30
  46. package/dest/sequencer/sequencer.d.ts +30 -15
  47. package/dest/sequencer/sequencer.d.ts.map +1 -1
  48. package/dest/sequencer/sequencer.js +95 -82
  49. package/dest/sequencer/timetable.d.ts +4 -6
  50. package/dest/sequencer/timetable.d.ts.map +1 -1
  51. package/dest/sequencer/timetable.js +7 -11
  52. package/dest/sequencer/types.d.ts +2 -2
  53. package/dest/sequencer/types.d.ts.map +1 -1
  54. package/dest/test/index.d.ts +3 -5
  55. package/dest/test/index.d.ts.map +1 -1
  56. package/dest/test/mock_checkpoint_builder.d.ts +18 -15
  57. package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
  58. package/dest/test/mock_checkpoint_builder.js +63 -40
  59. package/dest/test/utils.d.ts +8 -8
  60. package/dest/test/utils.d.ts.map +1 -1
  61. package/dest/test/utils.js +10 -9
  62. package/package.json +27 -28
  63. package/src/client/sequencer-client.ts +76 -23
  64. package/src/config.ts +66 -41
  65. package/src/global_variable_builder/global_builder.ts +25 -26
  66. package/src/global_variable_builder/index.ts +1 -1
  67. package/src/publisher/config.ts +153 -43
  68. package/src/publisher/index.ts +3 -0
  69. package/src/publisher/l1_tx_failed_store/factory.ts +32 -0
  70. package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +55 -0
  71. package/src/publisher/l1_tx_failed_store/file_store_failed_tx_store.ts +46 -0
  72. package/src/publisher/l1_tx_failed_store/index.ts +3 -0
  73. package/src/publisher/sequencer-publisher-factory.ts +38 -6
  74. package/src/publisher/sequencer-publisher-metrics.ts +7 -3
  75. package/src/publisher/sequencer-publisher.ts +376 -70
  76. package/src/sequencer/checkpoint_proposal_job.ts +409 -201
  77. package/src/sequencer/events.ts +1 -1
  78. package/src/sequencer/metrics.ts +138 -32
  79. package/src/sequencer/sequencer.ts +132 -95
  80. package/src/sequencer/timetable.ts +13 -12
  81. package/src/sequencer/types.ts +1 -1
  82. package/src/test/index.ts +2 -4
  83. package/src/test/mock_checkpoint_builder.ts +93 -65
  84. package/src/test/utils.ts +22 -13
@@ -1,37 +1,52 @@
1
- import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
2
- import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
3
1
  import type { EpochCache } from '@aztec/epoch-cache';
4
- import { BlockNumber, CheckpointNumber, EpochNumber, SlotNumber } from '@aztec/foundation/branded-types';
2
+ import {
3
+ BlockNumber,
4
+ CheckpointNumber,
5
+ EpochNumber,
6
+ IndexWithinCheckpoint,
7
+ SlotNumber,
8
+ } from '@aztec/foundation/branded-types';
5
9
  import { randomInt } from '@aztec/foundation/crypto/random';
10
+ import {
11
+ flipSignature,
12
+ generateRecoverableSignature,
13
+ generateUnrecoverableSignature,
14
+ } from '@aztec/foundation/crypto/secp256k1-signer';
6
15
  import { Fr } from '@aztec/foundation/curves/bn254';
7
16
  import { EthAddress } from '@aztec/foundation/eth-address';
8
17
  import { Signature } from '@aztec/foundation/eth-signature';
9
18
  import { filter } from '@aztec/foundation/iterator';
10
- import type { Logger } from '@aztec/foundation/log';
19
+ import { type Logger, type LoggerBindings, createLogger } from '@aztec/foundation/log';
11
20
  import { sleep, sleepUntil } from '@aztec/foundation/sleep';
12
21
  import { type DateProvider, Timer } from '@aztec/foundation/timer';
13
- import { type TypedEventEmitter, unfreeze } from '@aztec/foundation/types';
22
+ import { type TypedEventEmitter, isErrorClass, unfreeze } from '@aztec/foundation/types';
14
23
  import type { P2P } from '@aztec/p2p';
15
24
  import type { SlasherClientInterface } from '@aztec/slasher';
16
25
  import {
17
26
  CommitteeAttestation,
18
27
  CommitteeAttestationsAndSigners,
19
- L2BlockNew,
28
+ L2Block,
20
29
  type L2BlockSink,
21
30
  type L2BlockSource,
22
31
  MaliciousCommitteeAttestationsAndSigners,
23
32
  } from '@aztec/stdlib/block';
24
- import type { Checkpoint } from '@aztec/stdlib/checkpoint';
25
- import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
33
+ import { type Checkpoint, validateCheckpoint } from '@aztec/stdlib/checkpoint';
34
+ import { getSlotStartBuildTimestamp, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
26
35
  import { Gas } from '@aztec/stdlib/gas';
27
- import type {
28
- PublicProcessorLimits,
29
- ResolvedSequencerConfig,
30
- WorldStateSynchronizer,
36
+ import {
37
+ type BlockBuilderOptions,
38
+ InsufficientValidTxsError,
39
+ type ResolvedSequencerConfig,
40
+ type WorldStateSynchronizer,
31
41
  } from '@aztec/stdlib/interfaces/server';
32
42
  import { type L1ToL2MessageSource, computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
33
- import type { BlockProposalOptions, CheckpointProposal, CheckpointProposalOptions } from '@aztec/stdlib/p2p';
34
- import { orderAttestations } from '@aztec/stdlib/p2p';
43
+ import type {
44
+ BlockProposal,
45
+ BlockProposalOptions,
46
+ CheckpointProposal,
47
+ CheckpointProposalOptions,
48
+ } from '@aztec/stdlib/p2p';
49
+ import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
35
50
  import type { L2BlockBuiltStats } from '@aztec/stdlib/stats';
36
51
  import { type FailedTx, Tx } from '@aztec/stdlib/tx';
37
52
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
@@ -59,9 +74,13 @@ const TXS_POLLING_MS = 500;
59
74
  * the Sequencer once the check for being the proposer for the slot has succeeded.
60
75
  */
61
76
  export class CheckpointProposalJob implements Traceable {
77
+ protected readonly log: Logger;
78
+
62
79
  constructor(
63
- private readonly epoch: EpochNumber,
64
- private readonly slot: SlotNumber,
80
+ private readonly slotNow: SlotNumber,
81
+ private readonly targetSlot: SlotNumber,
82
+ private readonly epochNow: EpochNumber,
83
+ private readonly targetEpoch: EpochNumber,
65
84
  private readonly checkpointNumber: CheckpointNumber,
66
85
  private readonly syncedToBlockNumber: BlockNumber,
67
86
  // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
@@ -86,9 +105,24 @@ export class CheckpointProposalJob implements Traceable {
86
105
  private readonly metrics: SequencerMetrics,
87
106
  private readonly eventEmitter: TypedEventEmitter<SequencerEvents>,
88
107
  private readonly setStateFn: (state: SequencerState, slot?: SlotNumber) => void,
89
- protected readonly log: Logger,
90
108
  public readonly tracer: Tracer,
91
- ) {}
109
+ bindings?: LoggerBindings,
110
+ ) {
111
+ this.log = createLogger('sequencer:checkpoint-proposal', {
112
+ ...bindings,
113
+ instanceId: `slot-${this.slotNow}`,
114
+ });
115
+ }
116
+
117
+ /** The wall-clock slot during which the proposer builds. */
118
+ private get slot(): SlotNumber {
119
+ return this.slotNow;
120
+ }
121
+
122
+ /** The wall-clock epoch. */
123
+ private get epoch(): EpochNumber {
124
+ return this.epochNow;
125
+ }
92
126
 
93
127
  /**
94
128
  * Executes the checkpoint proposal job.
@@ -100,7 +134,7 @@ export class CheckpointProposalJob implements Traceable {
100
134
  // In fisherman mode, we simulate slashing but don't actually publish to L1
101
135
  // These are constant for the whole slot, so we only enqueue them once
102
136
  const votesPromises = new CheckpointVoter(
103
- this.slot,
137
+ this.targetSlot,
104
138
  this.publisher,
105
139
  this.attestorAddress,
106
140
  this.validatorClient,
@@ -118,7 +152,7 @@ export class CheckpointProposalJob implements Traceable {
118
152
  await Promise.all(votesPromises);
119
153
 
120
154
  if (checkpoint) {
121
- this.metrics.recordBlockProposalSuccess();
155
+ this.metrics.recordCheckpointProposalSuccess();
122
156
  }
123
157
 
124
158
  // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
@@ -127,6 +161,29 @@ export class CheckpointProposalJob implements Traceable {
127
161
  return;
128
162
  }
129
163
 
164
+ // If pipelining, wait until the submission slot so L1 recognizes the pipelined proposer
165
+ if (this.epochCache.isProposerPipeliningEnabled()) {
166
+ const submissionSlotTimestamp =
167
+ getTimestampForSlot(this.targetSlot, this.l1Constants) - BigInt(this.l1Constants.ethereumSlotDuration);
168
+ this.log.info(`Waiting until submission slot ${this.targetSlot} for L1 submission`, {
169
+ slot: this.slot,
170
+ submissionSlot: this.targetSlot,
171
+ submissionSlotTimestamp,
172
+ });
173
+ await sleepUntil(new Date(Number(submissionSlotTimestamp) * 1000), this.dateProvider.nowAsDate());
174
+
175
+ // After waking, verify the parent checkpoint wasn't pruned during the sleep.
176
+ // We check L1's pending tip directly instead of canProposeAt, which also validates the proposer
177
+ // identity and would fail because the timestamp resolves to a different slot's proposer.
178
+ const l1Tips = await this.publisher.rollupContract.getTips();
179
+ if (l1Tips.pending < this.checkpointNumber - 1) {
180
+ this.log.warn(
181
+ `Parent checkpoint was pruned during pipelining sleep (L1 pending=${l1Tips.pending}, expected>=${this.checkpointNumber - 1}), skipping L1 submission for checkpoint ${this.checkpointNumber}`,
182
+ );
183
+ return undefined;
184
+ }
185
+ }
186
+
130
187
  // Then send everything to L1
131
188
  const l1Response = await this.publisher.sendRequests();
132
189
  const proposedAction = l1Response?.successfulActions.find(a => a === 'propose');
@@ -145,7 +202,7 @@ export class CheckpointProposalJob implements Traceable {
145
202
  return {
146
203
  // nullish operator needed for tests
147
204
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
148
- [Attributes.SLOT_NUMBER]: this.slot,
205
+ [Attributes.SLOT_NUMBER]: this.targetSlot,
149
206
  };
150
207
  })
151
208
  private async proposeCheckpoint(): Promise<Checkpoint | undefined> {
@@ -155,8 +212,15 @@ export class CheckpointProposalJob implements Traceable {
155
212
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
156
213
 
157
214
  // Start the checkpoint
158
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.slot);
159
- this.metrics.incOpenSlot(this.slot, this.proposer?.toString() ?? 'unknown');
215
+ this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.targetSlot);
216
+ this.log.info(`Starting checkpoint proposal`, {
217
+ buildSlot: this.slot,
218
+ submissionSlot: this.targetSlot,
219
+ pipelining: this.epochCache.isProposerPipeliningEnabled(),
220
+ proposer: this.proposer?.toString(),
221
+ coinbase: coinbase.toString(),
222
+ });
223
+ this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
160
224
 
161
225
  // Enqueues checkpoint invalidation (constant for the whole slot)
162
226
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
@@ -167,7 +231,7 @@ export class CheckpointProposalJob implements Traceable {
167
231
  const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(
168
232
  coinbase,
169
233
  feeRecipient,
170
- this.slot,
234
+ this.targetSlot,
171
235
  );
172
236
 
173
237
  // Collect L1 to L2 messages for the checkpoint and compute their hash
@@ -175,21 +239,25 @@ export class CheckpointProposalJob implements Traceable {
175
239
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
176
240
 
177
241
  // Collect the out hashes of all the checkpoints before this one in the same epoch
178
- const previousCheckpoints = (await this.l2BlockSource.getCheckpointsForEpoch(this.epoch)).filter(
179
- c => c.number < this.checkpointNumber,
180
- );
181
- const previousCheckpointOutHashes = previousCheckpoints.map(c => c.getCheckpointOutHash());
242
+ const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.targetEpoch))
243
+ .filter(c => c.checkpointNumber < this.checkpointNumber)
244
+ .map(c => c.checkpointOutHash);
245
+
246
+ // Get the fee asset price modifier from the oracle
247
+ const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier();
182
248
 
183
249
  // Create a long-lived forked world state for the checkpoint builder
184
- using fork = await this.worldState.fork(this.syncedToBlockNumber, { closeDelayMs: 12_000 });
250
+ await using fork = await this.worldState.fork(this.syncedToBlockNumber, { closeDelayMs: 12_000 });
185
251
 
186
252
  // Create checkpoint builder for the entire slot
187
253
  const checkpointBuilder = await this.checkpointsBuilder.startCheckpoint(
188
254
  this.checkpointNumber,
189
255
  checkpointGlobalVariables,
256
+ feeAssetPriceModifier,
190
257
  l1ToL2Messages,
191
258
  previousCheckpointOutHashes,
192
259
  fork,
260
+ this.log.getBindings(),
193
261
  );
194
262
 
195
263
  // Options for the validator client when creating block and checkpoint proposals
@@ -203,8 +271,9 @@ export class CheckpointProposalJob implements Traceable {
203
271
  broadcastInvalidCheckpointProposal: this.config.broadcastInvalidBlockProposal,
204
272
  };
205
273
 
206
- let blocksInCheckpoint: L2BlockNew[] = [];
207
- let blockPendingBroadcast: { block: L2BlockNew; txs: Tx[] } | undefined = undefined;
274
+ let blocksInCheckpoint: L2Block[] = [];
275
+ let blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined = undefined;
276
+ const checkpointBuildTimer = new Timer();
208
277
 
209
278
  try {
210
279
  // Main loop: build blocks for the checkpoint
@@ -220,42 +289,64 @@ export class CheckpointProposalJob implements Traceable {
220
289
  // These errors are expected in HA mode, so we yield and let another HA node handle the slot
221
290
  // The only distinction between the 2 errors is SlashingProtectionError throws when the payload is different,
222
291
  // which is normal for block building (may have picked different txs)
223
- if (err instanceof DutyAlreadySignedError) {
224
- this.log.info(`Checkpoint proposal for slot ${this.slot} already signed by another HA node, yielding`, {
225
- slot: this.slot,
226
- signedByNode: err.signedByNode,
227
- });
228
- return undefined;
229
- }
230
- if (err instanceof SlashingProtectionError) {
231
- this.log.info(`Checkpoint proposal for slot ${this.slot} blocked by slashing protection, yielding`, {
232
- slot: this.slot,
233
- existingMessageHash: err.existingMessageHash,
234
- attemptedMessageHash: err.attemptedMessageHash,
235
- });
292
+ if (this.handleHASigningError(err, 'Block proposal')) {
236
293
  return undefined;
237
294
  }
238
295
  throw err;
239
296
  }
240
297
 
241
298
  if (blocksInCheckpoint.length === 0) {
242
- this.log.warn(`No blocks were built for slot ${this.slot}`, { slot: this.slot });
243
- this.eventEmitter.emit('checkpoint-empty', { slot: this.slot });
299
+ this.log.warn(`No blocks were built for slot ${this.targetSlot}`, { slot: this.targetSlot });
300
+ this.eventEmitter.emit('checkpoint-empty', { slot: this.targetSlot });
301
+ return undefined;
302
+ }
303
+
304
+ const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
305
+ if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
306
+ this.log.warn(
307
+ `Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`,
308
+ { slot: this.targetSlot, blocksBuilt: blocksInCheckpoint.length, minBlocksForCheckpoint },
309
+ );
244
310
  return undefined;
245
311
  }
246
312
 
247
313
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
248
314
  // broadcasted yet, and wait to collect the committee attestations.
249
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
315
+ this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.targetSlot);
250
316
  const checkpoint = await checkpointBuilder.completeCheckpoint();
251
317
 
318
+ // Final validation: per-block limits are only checked if the operator set them explicitly.
319
+ // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
320
+ try {
321
+ validateCheckpoint(checkpoint, {
322
+ rollupManaLimit: this.l1Constants.rollupManaLimit,
323
+ maxL2BlockGas: this.config.maxL2BlockGas,
324
+ maxDABlockGas: this.config.maxDABlockGas,
325
+ maxTxsPerBlock: this.config.maxTxsPerBlock,
326
+ maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint,
327
+ });
328
+ } catch (err) {
329
+ this.log.error(`Built an invalid checkpoint at slot ${this.slot} (skipping proposal)`, err, {
330
+ checkpoint: checkpoint.header.toInspect(),
331
+ });
332
+ return undefined;
333
+ }
334
+
335
+ // Record checkpoint-level build metrics
336
+ this.metrics.recordCheckpointBuild(
337
+ checkpointBuildTimer.ms(),
338
+ blocksInCheckpoint.length,
339
+ checkpoint.getStats().txCount,
340
+ Number(checkpoint.header.totalManaUsed.toBigInt()),
341
+ );
342
+
252
343
  // Do not collect attestations nor publish to L1 in fisherman mode
253
344
  if (this.config.fishermanMode) {
254
345
  this.log.info(
255
- `Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` +
346
+ `Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` +
256
347
  `Skipping proposal in fisherman mode.`,
257
348
  {
258
- slot: this.slot,
349
+ slot: this.targetSlot,
259
350
  checkpoint: checkpoint.header.toInspect(),
260
351
  blocksBuilt: blocksInCheckpoint.length,
261
352
  },
@@ -275,6 +366,7 @@ export class CheckpointProposalJob implements Traceable {
275
366
  const proposal = await this.validatorClient.createCheckpointProposal(
276
367
  checkpoint.header,
277
368
  checkpoint.archive.root,
369
+ feeAssetPriceModifier,
278
370
  lastBlock,
279
371
  this.proposer,
280
372
  checkpointProposalOptions,
@@ -283,7 +375,7 @@ export class CheckpointProposalJob implements Traceable {
283
375
  const blockProposedAt = this.dateProvider.now();
284
376
  await this.p2pClient.broadcastCheckpointProposal(proposal);
285
377
 
286
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
378
+ this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.targetSlot);
287
379
  const attestations = await this.waitForAttestations(proposal);
288
380
  const blockAttestedAt = this.dateProvider.now();
289
381
 
@@ -296,35 +388,38 @@ export class CheckpointProposalJob implements Traceable {
296
388
  attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
297
389
  attestations,
298
390
  signer,
299
- this.slot,
391
+ this.targetSlot,
300
392
  this.checkpointNumber,
301
393
  );
302
394
  } catch (err) {
303
395
  // We shouldn't really get here since we yield to another HA node
304
- // as soon as we see these errors when creating block proposals.
305
- if (err instanceof DutyAlreadySignedError) {
306
- this.log.info(`Attestations signature for slot ${this.slot} already signed by another HA node, yielding`, {
307
- slot: this.slot,
308
- signedByNode: err.signedByNode,
309
- });
310
- return undefined;
311
- }
312
- if (err instanceof SlashingProtectionError) {
313
- this.log.info(`Attestations signature for slot ${this.slot} blocked by slashing protection, yielding`, {
314
- slot: this.slot,
315
- existingMessageHash: err.existingMessageHash,
316
- attemptedMessageHash: err.attemptedMessageHash,
317
- });
396
+ // as soon as we see these errors when creating block or checkpoint proposals.
397
+ if (this.handleHASigningError(err, 'Attestations signature')) {
318
398
  return undefined;
319
399
  }
320
400
  throw err;
321
401
  }
322
402
 
323
403
  // Enqueue publishing the checkpoint to L1
324
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
404
+ this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.targetSlot);
325
405
  const aztecSlotDuration = this.l1Constants.slotDuration;
326
- const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
327
- const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
406
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
407
+ const txTimeoutAt = new Date((submissionSlotStart + aztecSlotDuration) * 1000);
408
+
409
+ // If we have been configured to potentially skip publishing checkpoint then roll the dice here
410
+ if (
411
+ this.config.skipPublishingCheckpointsPercent !== undefined &&
412
+ this.config.skipPublishingCheckpointsPercent > 0
413
+ ) {
414
+ const result = Math.max(0, randomInt(100));
415
+ if (result < this.config.skipPublishingCheckpointsPercent) {
416
+ this.log.warn(
417
+ `Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${result}`,
418
+ );
419
+ return checkpoint;
420
+ }
421
+ }
422
+
328
423
  await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
329
424
  txTimeoutAt,
330
425
  forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
@@ -352,22 +447,19 @@ export class CheckpointProposalJob implements Traceable {
352
447
  inHash: Fr,
353
448
  blockProposalOptions: BlockProposalOptions,
354
449
  ): Promise<{
355
- blocksInCheckpoint: L2BlockNew[];
356
- blockPendingBroadcast: { block: L2BlockNew; txs: Tx[] } | undefined;
450
+ blocksInCheckpoint: L2Block[];
451
+ blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined;
357
452
  }> {
358
- const blocksInCheckpoint: L2BlockNew[] = [];
453
+ const blocksInCheckpoint: L2Block[] = [];
359
454
  const txHashesAlreadyIncluded = new Set<string>();
360
455
  const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
361
456
 
362
- // Remaining blob fields available for blocks (checkpoint end marker already subtracted)
363
- let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
364
-
365
457
  // Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
366
- let blockPendingBroadcast: { block: L2BlockNew; txs: Tx[] } | undefined = undefined;
458
+ let blockPendingBroadcast: { block: L2Block; txs: Tx[] } | undefined = undefined;
367
459
 
368
460
  while (true) {
369
461
  const blocksBuilt = blocksInCheckpoint.length;
370
- const indexWithinCheckpoint = blocksBuilt;
462
+ const indexWithinCheckpoint = IndexWithinCheckpoint(blocksBuilt);
371
463
  const blockNumber = BlockNumber(initialBlockNumber + blocksBuilt);
372
464
 
373
465
  const secondsIntoSlot = this.getSecondsIntoSlot();
@@ -375,7 +467,7 @@ export class CheckpointProposalJob implements Traceable {
375
467
 
376
468
  if (!timingInfo.canStart) {
377
469
  this.log.debug(`Not enough time left in slot to start another block`, {
378
- slot: this.slot,
470
+ slot: this.targetSlot,
379
471
  blocksBuilt,
380
472
  secondsIntoSlot,
381
473
  });
@@ -394,9 +486,9 @@ export class CheckpointProposalJob implements Traceable {
394
486
  blockNumber,
395
487
  indexWithinCheckpoint,
396
488
  txHashesAlreadyIncluded,
397
- remainingBlobFields,
398
489
  });
399
490
 
491
+ // TODO(palla/mbps): Review these conditions. We may want to keep trying in some scenarios.
400
492
  if (!buildResult && timingInfo.isLastBlock) {
401
493
  // If no block was produced due to not enough txs and this was the last subslot, exit
402
494
  break;
@@ -410,8 +502,8 @@ export class CheckpointProposalJob implements Traceable {
410
502
  } else if ('error' in buildResult) {
411
503
  // If there was an error building the block, just exit the loop and give up the rest of the slot
412
504
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
413
- this.log.warn(`Halting block building for slot ${this.slot}`, {
414
- slot: this.slot,
505
+ this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
506
+ slot: this.targetSlot,
415
507
  blocksBuilt,
416
508
  error: buildResult.error,
417
509
  });
@@ -419,21 +511,16 @@ export class CheckpointProposalJob implements Traceable {
419
511
  break;
420
512
  }
421
513
 
422
- const { block, usedTxs, remainingBlobFields: newRemainingBlobFields } = buildResult;
514
+ const { block, usedTxs } = buildResult;
423
515
  blocksInCheckpoint.push(block);
516
+ usedTxs.forEach(tx => txHashesAlreadyIncluded.add(tx.txHash.toString()));
424
517
 
425
- // Update remaining blob fields for the next block
426
- remainingBlobFields = newRemainingBlobFields;
427
-
428
- // Sync the proposed block to the archiver to make it available
429
- // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
430
- // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
431
- await this.syncProposedBlockToArchiver(block);
432
-
433
- // If this is the last block, exit the loop now so we start collecting attestations
518
+ // If this is the last block, sync it to the archiver and exit the loop
519
+ // so we can build the checkpoint and start collecting attestations.
434
520
  if (timingInfo.isLastBlock) {
435
- this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
436
- slot: this.slot,
521
+ await this.syncProposedBlockToArchiver(block);
522
+ this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
523
+ slot: this.targetSlot,
437
524
  blockNumber,
438
525
  blocksBuilt,
439
526
  });
@@ -441,80 +528,94 @@ export class CheckpointProposalJob implements Traceable {
441
528
  break;
442
529
  }
443
530
 
444
- // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
445
- // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
446
- if (!this.config.fishermanMode) {
447
- const proposal = await this.validatorClient.createBlockProposal(
448
- block.header,
449
- block.indexWithinCheckpoint,
450
- inHash,
451
- block.archive.root,
452
- usedTxs,
453
- this.proposer,
454
- blockProposalOptions,
455
- );
456
- await this.p2pClient.broadcastProposal(proposal);
457
- }
531
+ // Broadcast the block proposal (unless we're in fisherman mode) unless the block is the last one,
532
+ // in which case we'll broadcast it along with the checkpoint at the end of the loop.
533
+ // Note that we only send the block to the archiver if we manage to create the proposal, so if there's
534
+ // a HA error we don't pollute our archiver with a block that won't make it to the chain.
535
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, blockProposalOptions);
536
+
537
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal.
538
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
539
+ // If this throws, we abort the entire checkpoint.
540
+ await this.syncProposedBlockToArchiver(block);
541
+
542
+ // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
543
+ proposal && (await this.p2pClient.broadcastProposal(proposal));
458
544
 
459
545
  // Wait until the next block's start time
460
546
  await this.waitUntilNextSubslot(timingInfo.deadline);
461
547
  }
462
548
 
463
- this.log.verbose(`Block building loop completed for slot ${this.slot}`, {
464
- slot: this.slot,
549
+ this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
550
+ slot: this.targetSlot,
465
551
  blocksBuilt: blocksInCheckpoint.length,
466
552
  });
467
553
 
468
554
  return { blocksInCheckpoint, blockPendingBroadcast };
469
555
  }
470
556
 
557
+ /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */
558
+ private createBlockProposal(
559
+ block: L2Block,
560
+ inHash: Fr,
561
+ usedTxs: Tx[],
562
+ blockProposalOptions: BlockProposalOptions,
563
+ ): Promise<BlockProposal | undefined> {
564
+ if (this.config.fishermanMode) {
565
+ this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
566
+ return Promise.resolve(undefined);
567
+ }
568
+ return this.validatorClient.createBlockProposal(
569
+ block.header,
570
+ block.indexWithinCheckpoint,
571
+ inHash,
572
+ block.archive.root,
573
+ usedTxs,
574
+ this.proposer,
575
+ blockProposalOptions,
576
+ );
577
+ }
578
+
471
579
  /** Sleeps until it is time to produce the next block in the slot */
472
580
  @trackSpan('CheckpointProposalJob.waitUntilNextSubslot')
473
581
  private async waitUntilNextSubslot(nextSubslotStart: number) {
474
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
475
- this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, { slot: this.slot });
582
+ this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.targetSlot);
583
+ this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
584
+ slot: this.targetSlot,
585
+ });
476
586
  await this.waitUntilTimeInSlot(nextSubslotStart);
477
587
  }
478
588
 
479
589
  /** Builds a single block. Called from the main block building loop. */
480
590
  @trackSpan('CheckpointProposalJob.buildSingleBlock')
481
- private async buildSingleBlock(
591
+ protected async buildSingleBlock(
482
592
  checkpointBuilder: CheckpointBuilder,
483
593
  opts: {
484
594
  forceCreate?: boolean;
485
595
  blockTimestamp: bigint;
486
596
  blockNumber: BlockNumber;
487
- indexWithinCheckpoint: number;
597
+ indexWithinCheckpoint: IndexWithinCheckpoint;
488
598
  buildDeadline: Date | undefined;
489
599
  txHashesAlreadyIncluded: Set<string>;
490
- remainingBlobFields: number;
491
600
  },
492
- ): Promise<{ block: L2BlockNew; usedTxs: Tx[]; remainingBlobFields: number } | { error: Error } | undefined> {
493
- const {
494
- blockTimestamp,
495
- forceCreate,
496
- blockNumber,
497
- indexWithinCheckpoint,
498
- buildDeadline,
499
- txHashesAlreadyIncluded,
500
- remainingBlobFields,
501
- } = opts;
601
+ ): Promise<{ block: L2Block; usedTxs: Tx[] } | { error: Error } | undefined> {
602
+ const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } =
603
+ opts;
502
604
 
503
605
  this.log.verbose(
504
- `Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`,
606
+ `Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`,
505
607
  { ...checkpointBuilder.getConstantData(), ...opts },
506
608
  );
507
609
 
508
610
  try {
509
611
  // Wait until we have enough txs to build the block
510
- const minTxs = this.config.minTxsPerBlock;
511
- const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
612
+ const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
512
613
  if (!canStartBuilding) {
513
614
  this.log.warn(
514
- `Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`,
515
- { blockNumber, slot: this.slot, indexWithinCheckpoint },
615
+ `Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (got ${availableTxs} txs but needs ${minTxs})`,
616
+ { blockNumber, slot: this.targetSlot, indexWithinCheckpoint },
516
617
  );
517
- this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, availableTxs, slot: this.slot });
618
+ this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, availableTxs, slot: this.targetSlot });
518
619
  this.metrics.recordBlockProposalFailed('insufficient_txs');
519
620
  return undefined;
520
621
  }
@@ -522,104 +623,143 @@ export class CheckpointProposalJob implements Traceable {
522
623
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
523
624
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
524
625
  const pendingTxs = filter(
525
- this.p2pClient.iteratePendingTxs(),
626
+ this.p2pClient.iterateEligiblePendingTxs(),
526
627
  tx => !txHashesAlreadyIncluded.has(tx.txHash.toString()),
527
628
  );
528
629
 
529
630
  this.log.debug(
530
- `Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`,
531
- { slot: this.slot, blockNumber, indexWithinCheckpoint },
631
+ `Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot} with ${availableTxs} available txs`,
632
+ { slot: this.targetSlot, blockNumber, indexWithinCheckpoint },
532
633
  );
533
- this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
534
-
535
- // Calculate blob fields limit for txs (remaining capacity - this block's end overhead)
536
- const blockEndOverhead = getNumBlockEndBlobFields(indexWithinCheckpoint === 0);
537
- const maxBlobFieldsForTxs = remainingBlobFields - blockEndOverhead;
634
+ this.setStateFn(SequencerState.CREATING_BLOCK, this.targetSlot);
538
635
 
539
- const blockBuilderOptions: PublicProcessorLimits = {
636
+ // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
637
+ // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
638
+ // minValidTxs is passed into the builder so it can reject the block *before* updating state.
639
+ const minValidTxs = forceCreate ? 0 : (this.config.minValidTxsPerBlock ?? minTxs);
640
+ const blockBuilderOptions: BlockBuilderOptions = {
540
641
  maxTransactions: this.config.maxTxsPerBlock,
541
- maxBlockSize: this.config.maxBlockSizeInBytes,
542
- maxBlockGas: new Gas(this.config.maxDABlockGas, this.config.maxL2BlockGas),
543
- maxBlobFields: maxBlobFieldsForTxs,
642
+ maxBlockGas:
643
+ this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined
644
+ ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity)
645
+ : undefined,
544
646
  deadline: buildDeadline,
647
+ isBuildingProposal: true,
648
+ minValidTxs,
649
+ maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
650
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier,
545
651
  };
546
652
 
547
- // Actually build the block by executing txs
548
- const workTimer = new Timer();
549
- const {
550
- publicGas,
551
- block,
552
- publicProcessorDuration,
553
- numTxs,
554
- blockBuildingTimer,
555
- usedTxs,
556
- failedTxs,
557
- usedTxBlobFields,
558
- } = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
559
- const blockBuildDuration = workTimer.ms();
653
+ // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
654
+ // if the number of successfully processed txs is below minValidTxs, ensuring state is not
655
+ // updated for blocks that will be discarded.
656
+ const buildResult = await this.buildSingleBlockWithCheckpointBuilder(
657
+ checkpointBuilder,
658
+ pendingTxs,
659
+ blockNumber,
660
+ blockTimestamp,
661
+ blockBuilderOptions,
662
+ );
560
663
 
561
664
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
562
- await this.dropFailedTxsFromP2P(failedTxs);
665
+ await this.dropFailedTxsFromP2P(buildResult.failedTxs);
563
666
 
564
- // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
565
- // too long, then we may not get to minTxsPerBlock after executing public functions.
566
- const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
567
- if (!forceCreate && numTxs < minValidTxs) {
667
+ if (buildResult.status === 'insufficient-valid-txs') {
568
668
  this.log.warn(
569
- `Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed (got ${numTxs} but required ${minValidTxs})`,
570
- { slot: this.slot, blockNumber, numTxs, indexWithinCheckpoint },
669
+ `Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`,
670
+ {
671
+ slot: this.targetSlot,
672
+ blockNumber,
673
+ numTxs: buildResult.processedCount,
674
+ indexWithinCheckpoint,
675
+ minValidTxs,
676
+ },
571
677
  );
572
- this.eventEmitter.emit('block-tx-count-check-failed', {
573
- minTxs: minValidTxs,
574
- availableTxs: numTxs,
575
- slot: this.slot,
678
+ this.eventEmitter.emit('block-build-failed', {
679
+ reason: `Insufficient valid txs`,
680
+ slot: this.targetSlot,
576
681
  });
577
682
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
578
683
  return undefined;
579
684
  }
580
685
 
581
686
  // Block creation succeeded, emit stats and metrics
687
+ const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
688
+
582
689
  const blockStats = {
583
690
  eventName: 'l2-block-built',
584
691
  duration: blockBuildDuration,
585
692
  publicProcessDuration: publicProcessorDuration,
586
- rollupCircuitsDuration: blockBuildingTimer.ms(),
587
693
  ...block.getStats(),
588
694
  } satisfies L2BlockBuiltStats;
589
695
 
590
696
  const blockHash = await block.hash();
591
697
  const txHashes = block.body.txEffects.map(tx => tx.txHash);
592
- const manaPerSec = publicGas.l2Gas / (blockBuildDuration / 1000);
698
+ const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
593
699
 
594
700
  this.log.info(
595
- `Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`,
701
+ `Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`,
596
702
  { blockHash, txHashes, manaPerSec, ...blockStats },
597
703
  );
598
704
 
599
- this.eventEmitter.emit('block-proposed', { blockNumber: block.number, slot: this.slot });
600
- this.metrics.recordBuiltBlock(blockBuildDuration, publicGas.l2Gas);
705
+ this.eventEmitter.emit('block-proposed', {
706
+ blockNumber: block.number,
707
+ slot: this.targetSlot,
708
+ buildSlot: this.slotNow,
709
+ });
710
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe());
601
711
 
602
- return { block, usedTxs, remainingBlobFields: maxBlobFieldsForTxs - usedTxBlobFields };
712
+ return { block, usedTxs };
603
713
  } catch (err: any) {
604
- this.eventEmitter.emit('block-build-failed', { reason: err.message, slot: this.slot });
605
- this.log.error(`Error building block`, err, { blockNumber, slot: this.slot });
714
+ this.eventEmitter.emit('block-build-failed', {
715
+ reason: err.message,
716
+ slot: this.targetSlot,
717
+ });
718
+ this.log.error(`Error building block`, err, { blockNumber, slot: this.targetSlot });
606
719
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
607
720
  this.metrics.recordFailedBlock();
608
721
  return { error: err };
609
722
  }
610
723
  }
611
724
 
725
+ /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */
726
+ private async buildSingleBlockWithCheckpointBuilder(
727
+ checkpointBuilder: CheckpointBuilder,
728
+ pendingTxs: AsyncIterable<Tx>,
729
+ blockNumber: BlockNumber,
730
+ blockTimestamp: bigint,
731
+ blockBuilderOptions: BlockBuilderOptions,
732
+ ) {
733
+ try {
734
+ const workTimer = new Timer();
735
+ const result = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
736
+ const blockBuildDuration = workTimer.ms();
737
+ return { ...result, blockBuildDuration, status: 'success' as const };
738
+ } catch (err: unknown) {
739
+ if (isErrorClass(err, InsufficientValidTxsError)) {
740
+ return {
741
+ failedTxs: err.failedTxs,
742
+ processedCount: err.processedCount,
743
+ status: 'insufficient-valid-txs' as const,
744
+ };
745
+ }
746
+ throw err;
747
+ }
748
+ }
749
+
612
750
  /** Waits until minTxs are available on the pool for building a block. */
613
751
  @trackSpan('CheckpointProposalJob.waitForMinTxs')
614
752
  private async waitForMinTxs(opts: {
615
753
  forceCreate?: boolean;
616
754
  blockNumber: BlockNumber;
617
- indexWithinCheckpoint: number;
755
+ indexWithinCheckpoint: IndexWithinCheckpoint;
618
756
  buildDeadline: Date | undefined;
619
- }): Promise<{ canStartBuilding: boolean; availableTxs: number }> {
620
- const minTxs = this.config.minTxsPerBlock;
757
+ }): Promise<{ canStartBuilding: boolean; availableTxs: number; minTxs: number }> {
621
758
  const { indexWithinCheckpoint, blockNumber, buildDeadline, forceCreate } = opts;
622
759
 
760
+ // We only allow a block with 0 txs in the first block of the checkpoint
761
+ const minTxs = indexWithinCheckpoint > 0 && this.config.minTxsPerBlock === 0 ? 1 : this.config.minTxsPerBlock;
762
+
623
763
  // Deadline is undefined if we are not enforcing the timetable, meaning we'll exit immediately when out of time
624
764
  const startBuildingDeadline = buildDeadline
625
765
  ? new Date(buildDeadline.getTime() - this.timetable.minExecutionTime * 1000)
@@ -631,20 +771,20 @@ export class CheckpointProposalJob implements Traceable {
631
771
  // If we're past deadline, or we have no deadline, give up
632
772
  const now = this.dateProvider.nowAsDate();
633
773
  if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
634
- return { canStartBuilding: false, availableTxs: availableTxs };
774
+ return { canStartBuilding: false, availableTxs, minTxs };
635
775
  }
636
776
 
637
777
  // Wait a bit before checking again
638
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.slot);
778
+ this.setStateFn(SequencerState.WAITING_FOR_TXS, this.targetSlot);
639
779
  this.log.verbose(
640
- `Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (have ${availableTxs} but need ${minTxs})`,
641
- { blockNumber, slot: this.slot, indexWithinCheckpoint },
780
+ `Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (have ${availableTxs} but need ${minTxs})`,
781
+ { blockNumber, slot: this.targetSlot, indexWithinCheckpoint },
642
782
  );
643
- await sleep(TXS_POLLING_MS);
783
+ await this.waitForTxsPollingInterval();
644
784
  availableTxs = await this.p2pClient.getPendingTxCount();
645
785
  }
646
786
 
647
- return { canStartBuilding: true, availableTxs };
787
+ return { canStartBuilding: true, availableTxs, minTxs };
648
788
  }
649
789
 
650
790
  /**
@@ -681,7 +821,7 @@ export class CheckpointProposalJob implements Traceable {
681
821
  const attestationTimeAllowed = this.config.enforceTimeTable
682
822
  ? this.timetable.getMaxAllowedTime(SequencerState.PUBLISHING_CHECKPOINT)!
683
823
  : this.l1Constants.slotDuration;
684
- const attestationDeadline = new Date(this.dateProvider.now() + attestationTimeAllowed * 1000);
824
+ const attestationDeadline = new Date((this.getSlotStartBuildTimestamp() + attestationTimeAllowed) * 1000);
685
825
 
686
826
  this.metrics.recordRequiredAttestations(numberOfRequiredAttestations, attestationTimeAllowed);
687
827
 
@@ -696,11 +836,28 @@ export class CheckpointProposalJob implements Traceable {
696
836
 
697
837
  collectedAttestationsCount = attestations.length;
698
838
 
839
+ // Trim attestations to minimum required to save L1 calldata gas
840
+ const localAddresses = this.validatorClient.getValidatorAddresses();
841
+ const trimmed = trimAttestations(
842
+ attestations,
843
+ numberOfRequiredAttestations,
844
+ this.attestorAddress,
845
+ localAddresses,
846
+ );
847
+ if (trimmed.length < attestations.length) {
848
+ this.log.debug(`Trimmed attestations from ${attestations.length} to ${trimmed.length} for L1 submission`);
849
+ }
850
+
699
851
  // Rollup contract requires that the signatures are provided in the order of the committee
700
- const sorted = orderAttestations(attestations, committee);
852
+ const sorted = orderAttestations(trimmed, committee);
701
853
 
702
854
  // Manipulate the attestations if we've been configured to do so
703
- if (this.config.injectFakeAttestation || this.config.shuffleAttestationOrdering) {
855
+ if (
856
+ this.config.injectFakeAttestation ||
857
+ this.config.injectHighSValueAttestation ||
858
+ this.config.injectUnrecoverableSignatureAttestation ||
859
+ this.config.shuffleAttestationOrdering
860
+ ) {
704
861
  return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
705
862
  }
706
863
 
@@ -729,7 +886,11 @@ export class CheckpointProposalJob implements Traceable {
729
886
  this.epochCache.computeProposerIndex(slotNumber, epoch, seed, BigInt(committee.length)),
730
887
  );
731
888
 
732
- if (this.config.injectFakeAttestation) {
889
+ if (
890
+ this.config.injectFakeAttestation ||
891
+ this.config.injectHighSValueAttestation ||
892
+ this.config.injectUnrecoverableSignatureAttestation
893
+ ) {
733
894
  // Find non-empty attestations that are not from the proposer
734
895
  const nonProposerIndices: number[] = [];
735
896
  for (let i = 0; i < attestations.length; i++) {
@@ -739,8 +900,20 @@ export class CheckpointProposalJob implements Traceable {
739
900
  }
740
901
  if (nonProposerIndices.length > 0) {
741
902
  const targetIndex = nonProposerIndices[randomInt(nonProposerIndices.length)];
742
- this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
743
- unfreeze(attestations[targetIndex]).signature = Signature.random();
903
+ if (this.config.injectHighSValueAttestation) {
904
+ this.log.warn(
905
+ `Injecting high-s value attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`,
906
+ );
907
+ unfreeze(attestations[targetIndex]).signature = flipSignature(attestations[targetIndex].signature);
908
+ } else if (this.config.injectUnrecoverableSignatureAttestation) {
909
+ this.log.warn(
910
+ `Injecting unrecoverable signature attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`,
911
+ );
912
+ unfreeze(attestations[targetIndex]).signature = generateUnrecoverableSignature();
913
+ } else {
914
+ this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
915
+ unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
916
+ }
744
917
  }
745
918
  return new CommitteeAttestationsAndSigners(attestations);
746
919
  }
@@ -749,11 +922,20 @@ export class CheckpointProposalJob implements Traceable {
749
922
  this.log.warn(`Shuffling attestation ordering in checkpoint for slot ${slotNumber} (proposer #${proposerIndex})`);
750
923
 
751
924
  const shuffled = [...attestations];
752
- const [i, j] = [(proposerIndex + 1) % shuffled.length, (proposerIndex + 2) % shuffled.length];
753
- const valueI = shuffled[i];
754
- const valueJ = shuffled[j];
755
- shuffled[i] = valueJ;
756
- shuffled[j] = valueI;
925
+
926
+ // Find two non-proposer positions that both have non-empty signatures to swap.
927
+ // This ensures the bitmap doesn't change, so the MaliciousCommitteeAttestationsAndSigners
928
+ // signers array stays correctly aligned with L1's committee reconstruction.
929
+ const swappable: number[] = [];
930
+ for (let k = 0; k < shuffled.length; k++) {
931
+ if (!shuffled[k].signature.isEmpty() && k !== proposerIndex) {
932
+ swappable.push(k);
933
+ }
934
+ }
935
+ if (swappable.length >= 2) {
936
+ const [i, j] = [swappable[0], swappable[1]];
937
+ [shuffled[i], shuffled[j]] = [shuffled[j], shuffled[i]];
938
+ }
757
939
 
758
940
  const signers = new CommitteeAttestationsAndSigners(attestations).getSigners();
759
941
  return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers);
@@ -769,7 +951,7 @@ export class CheckpointProposalJob implements Traceable {
769
951
  const failedTxData = failedTxs.map(fail => fail.tx);
770
952
  const failedTxHashes = failedTxData.map(tx => tx.getTxHash());
771
953
  this.log.verbose(`Dropping failed txs ${failedTxHashes.join(', ')}`);
772
- await this.p2pClient.deleteTxs(failedTxHashes);
954
+ await this.p2pClient.handleFailedExecution(failedTxHashes);
773
955
  }
774
956
 
775
957
  /**
@@ -777,8 +959,7 @@ export class CheckpointProposalJob implements Traceable {
777
959
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
778
960
  * would never receive its own block without this explicit sync.
779
961
  */
780
- private async syncProposedBlockToArchiver(block: L2BlockNew): Promise<void> {
781
- // TODO(palla/mbps): Change default to false once block sync is stable.
962
+ private async syncProposedBlockToArchiver(block: L2Block): Promise<void> {
782
963
  if (this.config.skipPushProposedBlocksToArchiver !== false) {
783
964
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
784
965
  blockNumber: block.number,
@@ -797,27 +978,49 @@ export class CheckpointProposalJob implements Traceable {
797
978
  private async handleCheckpointEndAsFisherman(checkpoint: Checkpoint | undefined) {
798
979
  // Perform L1 fee analysis before clearing requests
799
980
  // The callback is invoked asynchronously after the next block is mined
800
- const feeAnalysis = await this.publisher.analyzeL1Fees(this.slot, analysis =>
981
+ const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, analysis =>
801
982
  this.metrics.recordFishermanFeeAnalysis(analysis),
802
983
  );
803
984
 
804
985
  if (checkpoint) {
805
- this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.slot}`, {
986
+ this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
806
987
  ...checkpoint.toCheckpointInfo(),
807
988
  ...checkpoint.getStats(),
808
989
  feeAnalysisId: feeAnalysis?.id,
809
990
  });
810
991
  } else {
811
- this.log.warn(`Validation block building FAILED for slot ${this.slot}`, {
812
- slot: this.slot,
992
+ this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
993
+ slot: this.targetSlot,
813
994
  feeAnalysisId: feeAnalysis?.id,
814
995
  });
815
- this.metrics.recordBlockProposalFailed('block_build_failed');
996
+ this.metrics.recordCheckpointProposalFailed('block_build_failed');
816
997
  }
817
998
 
818
999
  this.publisher.clearPendingRequests();
819
1000
  }
820
1001
 
1002
+ /**
1003
+ * Helper to handle HA double-signing errors. Returns true if the error was handled (caller should yield).
1004
+ */
1005
+ private handleHASigningError(err: any, errorContext: string): boolean {
1006
+ if (err instanceof DutyAlreadySignedError) {
1007
+ this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
1008
+ slot: this.targetSlot,
1009
+ signedByNode: err.signedByNode,
1010
+ });
1011
+ return true;
1012
+ }
1013
+ if (err instanceof SlashingProtectionError) {
1014
+ this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
1015
+ slot: this.targetSlot,
1016
+ existingMessageHash: err.existingMessageHash,
1017
+ attemptedMessageHash: err.attemptedMessageHash,
1018
+ });
1019
+ return true;
1020
+ }
1021
+ return false;
1022
+ }
1023
+
821
1024
  /** Waits until a specific time within the current slot */
822
1025
  @trackSpan('CheckpointProposalJob.waitUntilTimeInSlot')
823
1026
  protected async waitUntilTimeInSlot(targetSecondsIntoSlot: number): Promise<void> {
@@ -826,6 +1029,11 @@ export class CheckpointProposalJob implements Traceable {
826
1029
  await sleepUntil(new Date(targetTimestamp * 1000), this.dateProvider.nowAsDate());
827
1030
  }
828
1031
 
1032
+ /** Waits the polling interval for transactions. Extracted for test overriding. */
1033
+ protected async waitForTxsPollingInterval(): Promise<void> {
1034
+ await sleep(TXS_POLLING_MS);
1035
+ }
1036
+
829
1037
  private getSlotStartBuildTimestamp(): number {
830
1038
  return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
831
1039
  }