@aztec/sequencer-client 0.0.1-commit.3469e52 → 0.0.1-commit.350e0a4d

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (133) hide show
  1. package/README.md +281 -21
  2. package/dest/client/sequencer-client.d.ts +34 -11
  3. package/dest/client/sequencer-client.d.ts.map +1 -1
  4. package/dest/client/sequencer-client.js +77 -39
  5. package/dest/config.d.ts +32 -6
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +94 -48
  8. package/dest/global_variable_builder/fee_predictor.d.ts +37 -0
  9. package/dest/global_variable_builder/fee_predictor.d.ts.map +1 -0
  10. package/dest/global_variable_builder/fee_predictor.js +138 -0
  11. package/dest/global_variable_builder/fee_provider.d.ts +21 -0
  12. package/dest/global_variable_builder/fee_provider.d.ts.map +1 -0
  13. package/dest/global_variable_builder/fee_provider.js +80 -0
  14. package/dest/global_variable_builder/global_builder.d.ts +13 -28
  15. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  16. package/dest/global_variable_builder/global_builder.js +9 -66
  17. package/dest/global_variable_builder/index.d.ts +4 -2
  18. package/dest/global_variable_builder/index.d.ts.map +1 -1
  19. package/dest/global_variable_builder/index.js +2 -0
  20. package/dest/publisher/config.d.ts +51 -17
  21. package/dest/publisher/config.d.ts.map +1 -1
  22. package/dest/publisher/config.js +131 -42
  23. package/dest/publisher/index.d.ts +2 -1
  24. package/dest/publisher/index.d.ts.map +1 -1
  25. package/dest/publisher/l1_to_l2_messaging.d.ts +21 -0
  26. package/dest/publisher/l1_to_l2_messaging.d.ts.map +1 -0
  27. package/dest/publisher/l1_to_l2_messaging.js +70 -0
  28. package/dest/publisher/l1_tx_failed_store/factory.d.ts +11 -0
  29. package/dest/publisher/l1_tx_failed_store/factory.d.ts.map +1 -0
  30. package/dest/publisher/l1_tx_failed_store/factory.js +22 -0
  31. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +98 -0
  32. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -0
  33. package/dest/publisher/l1_tx_failed_store/failed_tx_store.js +68 -0
  34. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts +15 -0
  35. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts.map +1 -0
  36. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.js +36 -0
  37. package/dest/publisher/l1_tx_failed_store/index.d.ts +4 -0
  38. package/dest/publisher/l1_tx_failed_store/index.d.ts.map +1 -0
  39. package/dest/publisher/l1_tx_failed_store/index.js +3 -0
  40. package/dest/publisher/sequencer-bundle-simulator.d.ts +96 -0
  41. package/dest/publisher/sequencer-bundle-simulator.d.ts.map +1 -0
  42. package/dest/publisher/sequencer-bundle-simulator.js +198 -0
  43. package/dest/publisher/sequencer-publisher-factory.d.ts +11 -5
  44. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  45. package/dest/publisher/sequencer-publisher-factory.js +27 -3
  46. package/dest/publisher/sequencer-publisher-metrics.d.ts +1 -1
  47. package/dest/publisher/sequencer-publisher-metrics.d.ts.map +1 -1
  48. package/dest/publisher/sequencer-publisher-metrics.js +12 -4
  49. package/dest/publisher/sequencer-publisher.d.ts +122 -68
  50. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  51. package/dest/publisher/sequencer-publisher.js +750 -364
  52. package/dest/publisher/write_json.d.ts +11 -0
  53. package/dest/publisher/write_json.d.ts.map +1 -0
  54. package/dest/publisher/write_json.js +57 -0
  55. package/dest/sequencer/automine/automine_factory.d.ts +56 -0
  56. package/dest/sequencer/automine/automine_factory.d.ts.map +1 -0
  57. package/dest/sequencer/automine/automine_factory.js +85 -0
  58. package/dest/sequencer/automine/automine_sequencer.d.ts +189 -0
  59. package/dest/sequencer/automine/automine_sequencer.d.ts.map +1 -0
  60. package/dest/sequencer/automine/automine_sequencer.js +690 -0
  61. package/dest/sequencer/automine/index.d.ts +3 -0
  62. package/dest/sequencer/automine/index.d.ts.map +1 -0
  63. package/dest/sequencer/automine/index.js +2 -0
  64. package/dest/sequencer/checkpoint_proposal_job.d.ts +101 -22
  65. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  66. package/dest/sequencer/checkpoint_proposal_job.js +922 -280
  67. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts +34 -0
  68. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts.map +1 -0
  69. package/dest/sequencer/checkpoint_proposal_job_metrics.js +72 -0
  70. package/dest/sequencer/checkpoint_voter.d.ts +1 -2
  71. package/dest/sequencer/checkpoint_voter.d.ts.map +1 -1
  72. package/dest/sequencer/checkpoint_voter.js +2 -5
  73. package/dest/sequencer/events.d.ts +62 -5
  74. package/dest/sequencer/events.d.ts.map +1 -1
  75. package/dest/sequencer/metrics.d.ts +23 -8
  76. package/dest/sequencer/metrics.d.ts.map +1 -1
  77. package/dest/sequencer/metrics.js +142 -36
  78. package/dest/sequencer/requests_tracker.d.ts +22 -0
  79. package/dest/sequencer/requests_tracker.d.ts.map +1 -0
  80. package/dest/sequencer/requests_tracker.js +33 -0
  81. package/dest/sequencer/sequencer.d.ts +181 -44
  82. package/dest/sequencer/sequencer.d.ts.map +1 -1
  83. package/dest/sequencer/sequencer.js +614 -216
  84. package/dest/sequencer/types.d.ts +2 -2
  85. package/dest/sequencer/types.d.ts.map +1 -1
  86. package/dest/test/index.d.ts +5 -7
  87. package/dest/test/index.d.ts.map +1 -1
  88. package/dest/test/mock_checkpoint_builder.d.ts +18 -15
  89. package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
  90. package/dest/test/mock_checkpoint_builder.js +63 -40
  91. package/dest/test/utils.d.ts +22 -8
  92. package/dest/test/utils.d.ts.map +1 -1
  93. package/dest/test/utils.js +33 -14
  94. package/package.json +30 -29
  95. package/src/client/sequencer-client.ts +110 -47
  96. package/src/config.ts +121 -58
  97. package/src/global_variable_builder/README.md +44 -0
  98. package/src/global_variable_builder/fee_predictor.ts +182 -0
  99. package/src/global_variable_builder/fee_provider.ts +97 -0
  100. package/src/global_variable_builder/global_builder.ts +20 -89
  101. package/src/global_variable_builder/index.ts +3 -1
  102. package/src/publisher/config.ts +173 -40
  103. package/src/publisher/index.ts +3 -0
  104. package/src/publisher/l1_to_l2_messaging.ts +85 -0
  105. package/src/publisher/l1_tx_failed_store/factory.ts +32 -0
  106. package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +164 -0
  107. package/src/publisher/l1_tx_failed_store/file_store_failed_tx_store.ts +47 -0
  108. package/src/publisher/l1_tx_failed_store/index.ts +3 -0
  109. package/src/publisher/sequencer-bundle-simulator.ts +254 -0
  110. package/src/publisher/sequencer-publisher-factory.ts +38 -9
  111. package/src/publisher/sequencer-publisher-metrics.ts +7 -3
  112. package/src/publisher/sequencer-publisher.ts +854 -461
  113. package/src/publisher/write_json.ts +78 -0
  114. package/src/sequencer/README.md +162 -450
  115. package/src/sequencer/automine/README.md +60 -0
  116. package/src/sequencer/automine/automine_factory.ts +152 -0
  117. package/src/sequencer/automine/automine_sequencer.ts +796 -0
  118. package/src/sequencer/automine/index.ts +6 -0
  119. package/src/sequencer/checkpoint_proposal_job.ts +1139 -328
  120. package/src/sequencer/checkpoint_proposal_job_metrics.ts +128 -0
  121. package/src/sequencer/checkpoint_voter.ts +1 -12
  122. package/src/sequencer/events.ts +66 -5
  123. package/src/sequencer/metrics.ts +164 -39
  124. package/src/sequencer/requests_tracker.ts +43 -0
  125. package/src/sequencer/sequencer.ts +729 -242
  126. package/src/sequencer/types.ts +1 -1
  127. package/src/test/index.ts +4 -6
  128. package/src/test/mock_checkpoint_builder.ts +93 -65
  129. package/src/test/utils.ts +81 -21
  130. package/dest/sequencer/timetable.d.ts +0 -90
  131. package/dest/sequencer/timetable.d.ts.map +0 -1
  132. package/dest/sequencer/timetable.js +0 -226
  133. package/src/sequencer/timetable.ts +0 -282
@@ -1,38 +1,67 @@
1
- import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
2
- import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
3
- import type { EpochCache } from '@aztec/epoch-cache';
4
- import { BlockNumber, CheckpointNumber, EpochNumber, SlotNumber } from '@aztec/foundation/branded-types';
1
+ import { type EpochCache, PROPOSER_PIPELINING_SLOT_OFFSET } from '@aztec/epoch-cache';
2
+ import type { SimulationOverridesPlan } from '@aztec/ethereum/contracts';
3
+ import {
4
+ BlockNumber,
5
+ CheckpointNumber,
6
+ EpochNumber,
7
+ IndexWithinCheckpoint,
8
+ SlotNumber,
9
+ } from '@aztec/foundation/branded-types';
5
10
  import { randomInt } from '@aztec/foundation/crypto/random';
11
+ import {
12
+ flipSignature,
13
+ generateRecoverableSignature,
14
+ generateUnrecoverableSignature,
15
+ } from '@aztec/foundation/crypto/secp256k1-signer';
6
16
  import { Fr } from '@aztec/foundation/curves/bn254';
17
+ import { InterruptError, TimeoutError } from '@aztec/foundation/error';
7
18
  import { EthAddress } from '@aztec/foundation/eth-address';
8
19
  import { Signature } from '@aztec/foundation/eth-signature';
9
20
  import { filter } from '@aztec/foundation/iterator';
10
- import type { Logger } from '@aztec/foundation/log';
11
- import { sleep, sleepUntil } from '@aztec/foundation/sleep';
21
+ import { type Logger, type LoggerBindings, createLogger } from '@aztec/foundation/log';
22
+ import { InterruptibleSleep } from '@aztec/foundation/sleep';
12
23
  import { type DateProvider, Timer } from '@aztec/foundation/timer';
13
- import { type TypedEventEmitter, unfreeze } from '@aztec/foundation/types';
24
+ import { type TypedEventEmitter, isErrorClass, unfreeze } from '@aztec/foundation/types';
14
25
  import type { P2P } from '@aztec/p2p';
15
26
  import type { SlasherClientInterface } from '@aztec/slasher';
16
27
  import {
17
28
  CommitteeAttestation,
18
29
  CommitteeAttestationsAndSigners,
19
- L2BlockNew,
30
+ L2Block,
20
31
  type L2BlockSink,
21
32
  type L2BlockSource,
22
33
  MaliciousCommitteeAttestationsAndSigners,
34
+ MaliciousYParityCommitteeAttestationsAndSigners,
35
+ type ProposedCheckpointSink,
36
+ type ValidateCheckpointResult,
23
37
  } from '@aztec/stdlib/block';
24
- import type { Checkpoint } from '@aztec/stdlib/checkpoint';
25
- import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
38
+ import {
39
+ type Checkpoint,
40
+ type ProposedCheckpointData,
41
+ buildCheckpointSimulationOverridesPlan,
42
+ getPreviousCheckpointOutHashes,
43
+ validateCheckpoint,
44
+ } from '@aztec/stdlib/checkpoint';
45
+ import { computeQuorum, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
26
46
  import { Gas } from '@aztec/stdlib/gas';
27
- import type {
28
- PublicProcessorLimits,
29
- ResolvedSequencerConfig,
30
- WorldStateSynchronizer,
47
+ import {
48
+ type BlockBuilderOptions,
49
+ InsufficientValidTxsError,
50
+ type ResolvedSequencerConfig,
51
+ type WorldStateSynchronizer,
31
52
  } from '@aztec/stdlib/interfaces/server';
32
53
  import { type L1ToL2MessageSource, computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
33
- import type { BlockProposalOptions, CheckpointProposal, CheckpointProposalOptions } from '@aztec/stdlib/p2p';
34
- import { orderAttestations } from '@aztec/stdlib/p2p';
54
+ import type {
55
+ BlockProposal,
56
+ BlockProposalOptions,
57
+ CheckpointAttestation,
58
+ CheckpointProposal,
59
+ CheckpointProposalOptions,
60
+ CoordinationSignatureContext,
61
+ } from '@aztec/stdlib/p2p';
62
+ import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
35
63
  import type { L2BlockBuiltStats } from '@aztec/stdlib/stats';
64
+ import type { ProposerTimetable } from '@aztec/stdlib/timetable';
36
65
  import { type FailedTx, Tx } from '@aztec/stdlib/tx';
37
66
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
38
67
  import { Attributes, type Traceable, type Tracer, trackSpan } from '@aztec/telemetry-client';
@@ -41,16 +70,32 @@ import { DutyAlreadySignedError, SlashingProtectionError } from '@aztec/validato
41
70
 
42
71
  import type { GlobalVariableBuilder } from '../global_variable_builder/global_builder.js';
43
72
  import type { InvalidateCheckpointRequest, SequencerPublisher } from '../publisher/sequencer-publisher.js';
73
+ import type { CheckpointProposalJobMetricsRecorder } from './checkpoint_proposal_job_metrics.js';
44
74
  import { CheckpointVoter } from './checkpoint_voter.js';
45
75
  import { SequencerInterruptedError } from './errors.js';
46
76
  import type { SequencerEvents } from './events.js';
47
77
  import type { SequencerMetrics } from './metrics.js';
48
- import type { SequencerTimetable } from './timetable.js';
78
+ import type { RequestsTracker } from './requests_tracker.js';
49
79
  import type { SequencerRollupConstants } from './types.js';
50
80
  import { SequencerState } from './utils.js';
51
81
 
52
82
  /** How much time to sleep while waiting for min transactions to accumulate for a block */
53
83
  const TXS_POLLING_MS = 500;
84
+ const ARCHIVER_SYNC_POLLING_MS = 200;
85
+
86
+ /** Result from proposeCheckpoint when a checkpoint was successfully built and broadcast. */
87
+ type CheckpointProposalBroadcast = {
88
+ checkpoint: Checkpoint;
89
+ proposal: CheckpointProposal;
90
+ blockProposedAt: number;
91
+ };
92
+
93
+ /** Result after attestation collection and signing, ready for L1 submission. */
94
+ type CheckpointProposalResult = {
95
+ checkpoint: Checkpoint;
96
+ attestations: CommitteeAttestationsAndSigners;
97
+ attestationsSignature: Signature;
98
+ };
54
99
 
55
100
  /**
56
101
  * Handles the execution of a checkpoint proposal after the initial preparation phase.
@@ -59,11 +104,30 @@ const TXS_POLLING_MS = 500;
59
104
  * the Sequencer once the check for being the proposer for the slot has succeeded.
60
105
  */
61
106
  export class CheckpointProposalJob implements Traceable {
107
+ protected readonly log: Logger;
108
+ private readonly checkpointEventLog: Logger;
109
+
110
+ private readonly interruptibleSleep = new InterruptibleSleep();
111
+ private interrupted = false;
112
+
113
+ /**
114
+ * Chain state overrides built once per slot in proposeCheckpoint after the checkpoint is
115
+ * complete. Carries the pending parent override (archive + slot + fee header) for pipelining,
116
+ * or the invalidation pending override when rolling back. Consumed by
117
+ * publisher.validateBlockHeader before broadcast.
118
+ */
119
+ private checkpointSimulationOverridesPlan?: SimulationOverridesPlan;
120
+
121
+ private getSignatureContext(): CoordinationSignatureContext {
122
+ return this.signatureContext;
123
+ }
124
+
62
125
  constructor(
63
- private readonly epoch: EpochNumber,
64
- private readonly slot: SlotNumber,
126
+ private readonly targetSlot: SlotNumber,
127
+ private readonly targetEpoch: EpochNumber,
65
128
  private readonly checkpointNumber: CheckpointNumber,
66
129
  private readonly syncedToBlockNumber: BlockNumber,
130
+ private readonly checkpointedCheckpointNumber: CheckpointNumber,
67
131
  // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
68
132
  private readonly proposer: EthAddress | undefined,
69
133
  private readonly publisher: SequencerPublisher,
@@ -76,23 +140,89 @@ export class CheckpointProposalJob implements Traceable {
76
140
  private readonly l1ToL2MessageSource: L1ToL2MessageSource,
77
141
  private readonly l2BlockSource: L2BlockSource,
78
142
  private readonly checkpointsBuilder: FullNodeCheckpointsBuilder,
79
- private readonly blockSink: L2BlockSink,
143
+ private readonly blockSink: L2BlockSink & ProposedCheckpointSink,
80
144
  private readonly l1Constants: SequencerRollupConstants,
145
+ private readonly signatureContext: CoordinationSignatureContext,
81
146
  protected config: ResolvedSequencerConfig,
82
- protected timetable: SequencerTimetable,
147
+ protected timetable: ProposerTimetable,
83
148
  private readonly slasherClient: SlasherClientInterface | undefined,
84
149
  private readonly epochCache: EpochCache,
85
150
  private readonly dateProvider: DateProvider,
86
151
  private readonly metrics: SequencerMetrics,
87
- private readonly eventEmitter: TypedEventEmitter<SequencerEvents>,
88
- private readonly setStateFn: (state: SequencerState, slot?: SlotNumber) => void,
89
- protected readonly log: Logger,
152
+ private readonly checkpointMetrics: CheckpointProposalJobMetricsRecorder,
153
+ protected readonly eventEmitter: TypedEventEmitter<SequencerEvents>,
154
+ // Shared with the owning sequencer, which drains it during shutdown; the fire-and-forget L1
155
+ // submission this job backgrounds is tracked here rather than in a job-local tracker.
156
+ protected readonly pendingRequests: RequestsTracker,
157
+ private readonly setStateFn: (state: SequencerState, slot: SlotNumber) => void,
90
158
  public readonly tracer: Tracer,
91
- ) {}
159
+ bindings?: LoggerBindings,
160
+ private readonly proposedCheckpointData?: ProposedCheckpointData,
161
+ ) {
162
+ this.log = createLogger('sequencer:checkpoint-proposal', {
163
+ ...bindings,
164
+ instanceId: `slot-${this.getBuildSlot()}`,
165
+ });
166
+ this.checkpointEventLog = createLogger('sequencer:checkpoint-events', {
167
+ ...bindings,
168
+ instanceId: `slot-${this.getBuildSlot()}`,
169
+ });
170
+ }
171
+
172
+ /**
173
+ * The wall-clock slot during which this job builds, i.e. the slot one before {@link targetSlot} under
174
+ * proposer pipelining. Also the slot of the parent checkpoint this job builds on top of.
175
+ */
176
+ private getBuildSlot(): SlotNumber {
177
+ return SlotNumber(this.targetSlot - PROPOSER_PIPELINING_SLOT_OFFSET);
178
+ }
179
+
180
+ /**
181
+ * Sets the sequencer state for this job, reporting the target slot the checkpoint is being proposed for
182
+ * (not the wall-clock build slot). The slot is informational on the event payload/metrics; the job knows
183
+ * its own target slot, so callers only pass the state.
184
+ */
185
+ private setState(state: SequencerState): void {
186
+ this.setStateFn(state, this.targetSlot);
187
+ }
188
+
189
+ /** Interrupts job-owned waits, including the publisher's send-at-slot sleep, so shutdown can finish. */
190
+ public interrupt(): void {
191
+ this.interrupted = true;
192
+ this.interruptibleSleep.interrupt(true);
193
+ this.publisher.interrupt();
194
+ }
195
+
196
+ private async awaitInterruptibleSleep(ms: number): Promise<void> {
197
+ if (this.interrupted) {
198
+ throw new SequencerInterruptedError();
199
+ }
200
+ if (ms <= 0) {
201
+ return;
202
+ }
203
+ try {
204
+ await this.interruptibleSleep.sleep(ms);
205
+ } catch (err) {
206
+ if (err instanceof InterruptError) {
207
+ throw new SequencerInterruptedError();
208
+ }
209
+ throw err;
210
+ }
211
+ }
212
+
213
+ private logCheckpointEvent(eventName: string, message: string, fields: Record<string, unknown>): void {
214
+ this.checkpointEventLog.debug(message, {
215
+ eventName: `sequencer-checkpoint-${eventName}`,
216
+ ...fields,
217
+ });
218
+ }
92
219
 
93
220
  /**
94
221
  * Executes the checkpoint proposal job.
95
- * Returns the published checkpoint if successful, undefined otherwise.
222
+ * Builds blocks, assembles checkpoint, and broadcasts the proposal (blocking).
223
+ * Attestation collection, signing, and L1 submission are backgrounded so the
224
+ * work loop can return to IDLE immediately for consecutive slot proposals.
225
+ * Returns the built checkpoint if successful, undefined otherwise.
96
226
  */
97
227
  @trackSpan('CheckpointProposalJob.execute')
98
228
  public async execute(): Promise<Checkpoint | undefined> {
@@ -100,7 +230,7 @@ export class CheckpointProposalJob implements Traceable {
100
230
  // In fisherman mode, we simulate slashing but don't actually publish to L1
101
231
  // These are constant for the whole slot, so we only enqueue them once
102
232
  const votesPromises = new CheckpointVoter(
103
- this.slot,
233
+ this.targetSlot,
104
234
  this.publisher,
105
235
  this.attestorAddress,
106
236
  this.validatorClient,
@@ -111,33 +241,309 @@ export class CheckpointProposalJob implements Traceable {
111
241
  this.log,
112
242
  ).enqueueVotes();
113
243
 
114
- // Build and propose the checkpoint. This will enqueue the request on the publisher if a checkpoint is built.
115
- const checkpoint = await this.proposeCheckpoint();
116
-
117
- // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
118
- await Promise.all(votesPromises);
119
-
120
- if (checkpoint) {
121
- this.metrics.recordBlockProposalSuccess();
244
+ // Build blocks, assemble checkpoint, and broadcast proposal (BLOCKING).
245
+ // Returns after broadcast — attestation collection is deferred.
246
+ const broadcast = await this.proposeCheckpoint();
247
+
248
+ if (!broadcast) {
249
+ await Promise.all(votesPromises);
250
+ // Still submit votes even without a checkpoint.
251
+ // Under proposer pipelining, vote-offenses signatures are EIP-712-bound to `targetSlot`
252
+ // (the pipelined slot in which the multicall is expected to mine). Submitting at the
253
+ // wall-clock time would let the multicall mine in a different L2 slot, causing
254
+ // signature verification to fail silently inside Multicall3. Delay submission to the
255
+ // start of `targetSlot` so the tx mines in the slot the vote was signed for.
256
+ if (!this.config.fishermanMode) {
257
+ this.pendingRequests.trackRequest(this.publisher.sendRequestsAt(this.targetSlot), () => this.interrupt());
258
+ }
259
+ return undefined;
122
260
  }
123
261
 
262
+ const { checkpoint } = broadcast;
263
+ this.metrics.recordCheckpointProposalSuccess();
264
+
124
265
  // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
125
266
  if (this.config.fishermanMode) {
126
267
  await this.handleCheckpointEndAsFisherman(checkpoint);
127
- return;
268
+ return checkpoint;
128
269
  }
129
270
 
130
- // Then send everything to L1
131
- const l1Response = await this.publisher.sendRequests();
132
- const proposedAction = l1Response?.successfulActions.find(a => a === 'propose');
133
- if (proposedAction) {
134
- this.eventEmitter.emit('checkpoint-published', { checkpoint: this.checkpointNumber, slot: this.slot });
135
- const coinbase = checkpoint?.header.coinbase;
136
- await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
137
- return checkpoint;
138
- } else if (checkpoint) {
139
- this.eventEmitter.emit('checkpoint-publish-failed', { ...l1Response, slot: this.slot });
140
- return undefined;
271
+ // Background the attestation signing → L1 pipeline so the work loop is unblocked
272
+ this.pendingRequests.trackRequest(this.waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises), () =>
273
+ this.interrupt(),
274
+ );
275
+
276
+ // Return the built checkpoint immediately — the work loop is now unblocked
277
+ return checkpoint;
278
+ }
279
+
280
+ /**
281
+ * Background pipeline: collects attestations, signs them, enqueues the checkpoint, and submits to L1.
282
+ * Runs as a fire-and-forget task tracked in the sequencer's shared tracker so the work loop is unblocked.
283
+ */
284
+ private async waitForAttestationsAndEnqueueSubmissionAsync(
285
+ broadcast: CheckpointProposalBroadcast,
286
+ votesPromises: Promise<unknown>[],
287
+ ): Promise<void> {
288
+ const { checkpoint } = broadcast;
289
+
290
+ try {
291
+ // Wait for all votes actions, enqueued at the beginning, to resolve
292
+ await Promise.all(votesPromises);
293
+
294
+ // Try to collect attestations from the committee
295
+ const signedAttestations = await this.getSignedCommitteeAttestations(broadcast);
296
+
297
+ // Wait for the previous checkpoint to land on L1 before submitting, so we can check it
298
+ // matches the proposed checkpoint we used as parent, and has valid attestations.
299
+ if (signedAttestations && (await this.waitForValidParentCheckpointOnL1())) {
300
+ await this.enqueueCheckpointForSubmission({ checkpoint, ...signedAttestations });
301
+ }
302
+
303
+ // If we failed to collect attestations, at least check if we need to issue an invalidation
304
+ if (!signedAttestations && (await this.waitForSyncedL2SlotNumber(this.getBuildSlot()))) {
305
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
306
+ if (!validationStatus.valid) {
307
+ this.log.warn(
308
+ `Checkpoint ${validationStatus.checkpoint.checkpointNumber} has invalid attestations, enqueuing invalidation in spite of attestation collection failure`,
309
+ { checkpoint: validationStatus.checkpoint, reason: validationStatus.reason },
310
+ );
311
+ await this.enqueueInvalidation(validationStatus);
312
+ }
313
+ }
314
+
315
+ // Send whatever was enqueued: votes + (propose | invalidation | nothing).
316
+ const l1Response = await this.publisher.sendRequestsAt(this.targetSlot);
317
+ const proposedAction = l1Response?.successfulActions.find(a => a === 'propose');
318
+ if (proposedAction) {
319
+ this.logCheckpointEvent('published', `Checkpoint published for slot ${this.targetSlot}`, {
320
+ slot: this.targetSlot,
321
+ checkpointNumber: this.checkpointNumber,
322
+ successfulActions: l1Response?.successfulActions,
323
+ sentActions: l1Response?.sentActions,
324
+ });
325
+ this.eventEmitter.emit('checkpoint-published', { checkpoint: this.checkpointNumber, slot: this.targetSlot });
326
+ const coinbase = checkpoint.header.coinbase;
327
+ await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
328
+ } else {
329
+ this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, {
330
+ slot: this.targetSlot,
331
+ checkpointNumber: this.checkpointNumber,
332
+ successfulActions: l1Response?.successfulActions,
333
+ failedActions: l1Response?.failedActions,
334
+ sentActions: l1Response?.sentActions,
335
+ expiredActions: l1Response?.expiredActions,
336
+ reason: 'propose_action_not_successful',
337
+ });
338
+ this.log.warn(`Checkpoint publish failed for slot ${this.targetSlot}`, {
339
+ slot: this.targetSlot,
340
+ checkpointNumber: this.checkpointNumber,
341
+ successfulActions: l1Response?.successfulActions,
342
+ failedActions: l1Response?.failedActions,
343
+ sentActions: l1Response?.sentActions,
344
+ expiredActions: l1Response?.expiredActions,
345
+ reason: 'propose_action_not_successful',
346
+ });
347
+ this.eventEmitter.emit('checkpoint-publish-failed', { ...l1Response, slot: this.targetSlot });
348
+ this.metrics.recordPipelineDiscard();
349
+ }
350
+ } catch (err) {
351
+ if (err instanceof SequencerInterruptedError) {
352
+ return;
353
+ }
354
+ this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, {
355
+ slot: this.targetSlot,
356
+ checkpointNumber: this.checkpointNumber,
357
+ reason: err instanceof Error ? err.message : String(err),
358
+ });
359
+ this.log.error(`Background attestation/L1 pipeline failed for slot ${this.targetSlot}`, err, {
360
+ slot: this.targetSlot,
361
+ checkpointNumber: this.checkpointNumber,
362
+ reason: err instanceof Error ? err.message : String(err),
363
+ });
364
+ this.eventEmitter.emit('checkpoint-publish-failed', { slot: this.targetSlot });
365
+ this.metrics.recordPipelineDiscard();
366
+ }
367
+ }
368
+
369
+ /** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */
370
+ private async enqueueCheckpointForSubmission(result: CheckpointProposalResult): Promise<void> {
371
+ const { checkpoint, attestations, attestationsSignature } = result;
372
+
373
+ this.setState(SequencerState.PUBLISHING_CHECKPOINT);
374
+ // Latest L1 block the propose can still land in for the target slot: the last Ethereum block inside
375
+ // the target slot (`target_slot_start + S - E`). This is one ethereum slot later than
376
+ // `attestation_deadline` (= last_ethereum_block_in_target_slot - E), which bounds when validators must
377
+ // have signed, not when the proposer must have sent. Using the attestation deadline here is too tight:
378
+ // attestations are collected up to (and, when not enforcing, past) it, so the propose tx would be
379
+ // enqueued already expired and time out before it can mine.
380
+ const lastL1BlockInTargetSlot =
381
+ Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) +
382
+ this.l1Constants.slotDuration -
383
+ this.l1Constants.ethereumSlotDuration;
384
+ const txTimeoutAt = new Date(lastL1BlockInTargetSlot * 1000);
385
+
386
+ // If we have been configured to potentially skip publishing checkpoint then roll the dice here
387
+ if (
388
+ this.config.skipPublishingCheckpointsPercent !== undefined &&
389
+ this.config.skipPublishingCheckpointsPercent > 0
390
+ ) {
391
+ const roll = Math.max(0, randomInt(100));
392
+ if (roll < this.config.skipPublishingCheckpointsPercent) {
393
+ this.log.warn(
394
+ `Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${roll}`,
395
+ );
396
+ return;
397
+ }
398
+ }
399
+
400
+ await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, { txTimeoutAt });
401
+ }
402
+
403
+ /**
404
+ * Wait until the archiver syncs past the given L2 slot number.
405
+ * The deadline is the end of `this.targetSlot`, beyond which any pipelined work would miss its
406
+ * L1 submission window and is no longer useful.
407
+ */
408
+ private async waitForSyncedL2SlotNumber(waitForSlot: SlotNumber): Promise<boolean> {
409
+ const targetSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
410
+ const targetSlotEndMs = (targetSlotStart + this.l1Constants.slotDuration) * 1000;
411
+ const syncDelayTolerance = this.l1Constants.ethereumSlotDuration * 2 * 1000;
412
+ const timeoutSeconds = Math.max(0.1, (targetSlotEndMs + syncDelayTolerance - this.dateProvider.now()) / 1000);
413
+
414
+ try {
415
+ const timer = new Timer();
416
+ while (true) {
417
+ const syncedSlot = await this.l2BlockSource.getSyncedL2SlotNumber();
418
+ if (syncedSlot !== undefined && syncedSlot >= waitForSlot) {
419
+ return true;
420
+ }
421
+ if (timeoutSeconds && timer.s() > timeoutSeconds) {
422
+ throw new TimeoutError(`Timeout awaiting archiver sync past slot ${waitForSlot}`);
423
+ }
424
+ await this.awaitInterruptibleSleep(ARCHIVER_SYNC_POLLING_MS);
425
+ }
426
+ } catch (err) {
427
+ if (err instanceof SequencerInterruptedError) {
428
+ throw err;
429
+ }
430
+ this.log.warn(
431
+ `Archiver did not sync L1 past slot ${waitForSlot} before slot ${this.targetSlot} expired, discarding pipelined work`,
432
+ { checkpointNumber: this.checkpointNumber },
433
+ );
434
+ this.emitPipelinedCheckpointDiscarded('archiver-sync-timeout');
435
+ return false;
436
+ }
437
+ }
438
+
439
+ /**
440
+ * Waits for the parent checkpoint to land on L1 before submitting a pipelined checkpoint.
441
+ * Polls until the archiver has synced L1 past the parent's slot, then verifies:
442
+ * - If we built on a proposed parent: it must have landed on L1 with matching hash and valid attestations.
443
+ * - If we built without a proposed parent: no new checkpoint must have appeared for that slot.
444
+ * If the parent has invalid attestations, enqueues an invalidation. Returns whether to proceed with the proposal.
445
+ */
446
+ protected async waitForValidParentCheckpointOnL1(): Promise<boolean> {
447
+ if (this.config.skipWaitForValidParentCheckpointOnL1) {
448
+ this.log.warn(`Skipping waitForValidParentCheckpointOnL1 due to test configuration`, {
449
+ checkpointNumber: this.checkpointNumber,
450
+ });
451
+ return true;
452
+ }
453
+
454
+ const parentCheckpointNumber = CheckpointNumber(this.checkpointNumber - 1);
455
+
456
+ // Wait until archiver has synced L1 past the parent's slot (the build slot, one before targetSlot)
457
+ if (!(await this.waitForSyncedL2SlotNumber(this.getBuildSlot()))) {
458
+ return false;
459
+ }
460
+
461
+ const tips = await this.l2BlockSource.getL2Tips();
462
+ const checkpointedNumber = tips.checkpointed.checkpoint.number;
463
+
464
+ // We built on top of a proposed checkpoint. Verify it landed on L1 as expected.
465
+ if (this.proposedCheckpointData) {
466
+ // After syncing from L1 we see the chain tip has invalid attestations. This means the parent checkpoint was posted
467
+ // with invalid attestations, or it built on top of something with invalid attestations and didnt invalidate them.
468
+ // Either way, we thought our parent would be valid, so we have to throw away our work. But at least we'll try and
469
+ // invalidate on L1 so we clean up the chain for the next proposer. And we'll slash them, but that's handled elsewhere.
470
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
471
+ if (!validationStatus.valid) {
472
+ this.log.warn(
473
+ `Parent checkpoint ${parentCheckpointNumber} has invalid attestations, discarding pipelined work`,
474
+ { checkpointNumber: this.checkpointNumber, reason: validationStatus.reason },
475
+ );
476
+ this.emitPipelinedCheckpointDiscarded('parent-invalid-attestations');
477
+ await this.enqueueInvalidation(validationStatus);
478
+ return false;
479
+ }
480
+
481
+ // The pending chain is valid. But did the parent checkpoint land on L1 at all?
482
+ if (checkpointedNumber < parentCheckpointNumber) {
483
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} did not land on L1, discarding pipelined work`, {
484
+ checkpointNumber: this.checkpointNumber,
485
+ checkpointedNumber,
486
+ });
487
+ this.emitPipelinedCheckpointDiscarded('parent-not-on-l1');
488
+ return false;
489
+ }
490
+
491
+ // It landed. But is it the one we were expecting?
492
+ const expectedHash = this.proposedCheckpointData.header.hash().toString();
493
+ if (tips.checkpointed.checkpoint.hash !== expectedHash) {
494
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} hash mismatch on L1, discarding pipelined work`, {
495
+ checkpointNumber: this.checkpointNumber,
496
+ expectedHash,
497
+ actualHash: tips.checkpointed.checkpoint.hash,
498
+ });
499
+ this.emitPipelinedCheckpointDiscarded('parent-hash-mismatch');
500
+ return false;
501
+ }
502
+
503
+ return true;
504
+ } else {
505
+ // We didn't see a proposed checkpoint at build time, so we built on checkpointed parent from two slots ago.
506
+ // But if a new checkpoint for the previous slot appeared on L1 in the meantime, our checkpoint assumed the wrong parent,
507
+ // so we have to discard our work. This can happen if we're somehow cut off from p2p and fail to see the checkpoint
508
+ // proposal for the previous slot.
509
+ if (checkpointedNumber > parentCheckpointNumber) {
510
+ this.log.warn(
511
+ `Unexpected checkpoint ${checkpointedNumber} landed on L1 after we built on top of parent ${parentCheckpointNumber}, discarding pipelined work`,
512
+ { checkpointNumber: this.checkpointNumber, checkpointedNumber },
513
+ );
514
+ this.emitPipelinedCheckpointDiscarded('unexpected-parent-appeared');
515
+ return false;
516
+ }
517
+
518
+ return true;
519
+ }
520
+ }
521
+
522
+ /** Emits the pipelined-checkpoint-discarded event and records the metric. */
523
+ private emitPipelinedCheckpointDiscarded(reason: string): void {
524
+ this.metrics.recordPipelineParentCheckpointMismatch(reason);
525
+ this.eventEmitter.emit('pipelined-checkpoint-discarded', {
526
+ slot: this.targetSlot,
527
+ checkpointNumber: this.checkpointNumber,
528
+ reason,
529
+ });
530
+ }
531
+
532
+ /** Simulates and enqueues an invalidation request for the invalid parent checkpoint. */
533
+ private async enqueueInvalidation(validationStatus: ValidateCheckpointResult): Promise<void> {
534
+ if (this.config.skipInvalidateBlockAsProposer) {
535
+ this.log.warn(`Skipping checkpoint invalidation as proposer due to test configuration`);
536
+ return;
537
+ }
538
+ const invalidateRequest = await this.publisher.simulateInvalidateCheckpoint(validationStatus);
539
+ if (invalidateRequest) {
540
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
541
+ const txTimeoutAt = new Date((submissionSlotStart + this.l1Constants.slotDuration) * 1000);
542
+ this.publisher.enqueueInvalidateCheckpoint(invalidateRequest, { txTimeoutAt });
543
+ } else {
544
+ this.log.info(`Invalidation simulation returned undefined, checkpoint may have been removed already`, {
545
+ checkpointNumber: this.checkpointNumber,
546
+ });
141
547
  }
142
548
  }
143
549
 
@@ -145,51 +551,102 @@ export class CheckpointProposalJob implements Traceable {
145
551
  return {
146
552
  // nullish operator needed for tests
147
553
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
148
- [Attributes.SLOT_NUMBER]: this.slot,
554
+ [Attributes.SLOT_NUMBER]: this.targetSlot,
149
555
  };
150
556
  })
151
- private async proposeCheckpoint(): Promise<Checkpoint | undefined> {
557
+ private async proposeCheckpoint(): Promise<CheckpointProposalBroadcast | undefined> {
152
558
  try {
559
+ const now = this.dateProvider.now();
560
+ if (this.proposedCheckpointData) {
561
+ // Measure against the wall-clock slot whose build window we are currently using.
562
+ // In pipelining mode `targetSlot` is intentionally one slot ahead, which makes the
563
+ // target-slot boundary a full slot away from the actual build start time.
564
+ const slotBoundaryMs = Number(getTimestampForSlot(this.getBuildSlot(), this.l1Constants)) * 1000;
565
+ this.checkpointMetrics.recordPipelinedCheckpointBuildStartOffsetFromSlotBoundary(now - slotBoundaryMs);
566
+ }
567
+ this.checkpointMetrics.startCheckpointTiming(now);
568
+
153
569
  // Get operator configured coinbase and fee recipient for this attestor
154
570
  const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
155
571
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
156
572
 
157
573
  // Start the checkpoint
158
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.slot);
159
- this.metrics.incOpenSlot(this.slot, this.proposer?.toString() ?? 'unknown');
574
+ this.setState(SequencerState.INITIALIZING_CHECKPOINT);
575
+ this.logCheckpointEvent('slot-started', `Starting checkpoint proposal for slot ${this.targetSlot}`, {
576
+ buildSlot: this.getBuildSlot(),
577
+ submissionSlot: this.targetSlot,
578
+ slot: this.targetSlot,
579
+ checkpointNumber: this.checkpointNumber,
580
+ proposer: this.proposer?.toString(),
581
+ attestorAddress: this.attestorAddress.toString(),
582
+ publisherAddress: this.publisher.getSenderAddress().toString(),
583
+ coinbase: coinbase.toString(),
584
+ });
585
+ this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
160
586
 
161
587
  // Enqueues checkpoint invalidation (constant for the whole slot)
162
588
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
163
589
  this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
164
590
  }
165
591
 
166
- // Create checkpoint builder for the slot
592
+ // Build the simulation plan for this slot. When pipelining, this overrides L1's view of
593
+ // pending/archive/fee-header to "as if the proposed parent had landed", so both the
594
+ // mana-min-fee simulation (in the globals builder) and the pre-broadcast
595
+ // validateBlockHeader see the chain tip the eventual L1 send will see.
596
+ this.checkpointSimulationOverridesPlan = await buildCheckpointSimulationOverridesPlan({
597
+ checkpointNumber: this.checkpointNumber,
598
+ proposedCheckpointData: this.proposedCheckpointData,
599
+ invalidateToPendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
600
+ checkpointedCheckpointNumber: this.checkpointedCheckpointNumber,
601
+ rollup: this.publisher.rollupContract,
602
+ signatureContext: this.signatureContext,
603
+ log: this.log,
604
+ });
605
+
167
606
  const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(
168
607
  coinbase,
169
608
  feeRecipient,
170
- this.slot,
609
+ this.targetSlot,
610
+ this.checkpointSimulationOverridesPlan,
171
611
  );
172
612
 
173
613
  // Collect L1 to L2 messages for the checkpoint and compute their hash
174
614
  const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(this.checkpointNumber);
175
615
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
176
616
 
177
- // Collect the out hashes of all the checkpoints before this one in the same epoch
178
- const previousCheckpoints = (await this.l2BlockSource.getCheckpointsForEpoch(this.epoch)).filter(
179
- c => c.number < this.checkpointNumber,
180
- );
181
- const previousCheckpointOutHashes = previousCheckpoints.map(c => c.getCheckpointOutHash());
617
+ // Collect the out hashes of all the checkpoints before this one in the same epoch.
618
+ // Under pipelining the parent checkpoint may not be on L1 yet at build time, so the helper
619
+ // splices in the parent's checkpointOutHash from the locally-known proposed checkpoint so
620
+ // the resulting `epochOutHash` matches what validators (and L1) compute once the parent
621
+ // lands on L1.
622
+ const previousCheckpointOutHashes = await getPreviousCheckpointOutHashes({
623
+ blockSource: this.l2BlockSource,
624
+ epoch: this.targetEpoch,
625
+ checkpointNumber: this.checkpointNumber,
626
+ l1Constants: this.epochCache.getL1Constants(),
627
+ pipeliningEnabled: true,
628
+ proposedCheckpointData: this.proposedCheckpointData,
629
+ log: this.log,
630
+ });
631
+
632
+ // Anchor the modifier to the predicted parent fee header: L1 will apply it against
633
+ // that, not against the latest published checkpoint (which lags by one under pipelining).
634
+ const predictedParentEthPerFeeAssetE12 =
635
+ this.checkpointSimulationOverridesPlan?.pendingCheckpointState?.feeHeader?.ethPerFeeAsset;
636
+ const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier(predictedParentEthPerFeeAssetE12);
182
637
 
183
638
  // Create a long-lived forked world state for the checkpoint builder
184
- using fork = await this.worldState.fork(this.syncedToBlockNumber, { closeDelayMs: 12_000 });
639
+ await using fork = await this.worldState.fork(this.syncedToBlockNumber, { closeDelayMs: 12_000 });
185
640
 
186
641
  // Create checkpoint builder for the entire slot
187
642
  const checkpointBuilder = await this.checkpointsBuilder.startCheckpoint(
188
643
  this.checkpointNumber,
189
644
  checkpointGlobalVariables,
645
+ feeAssetPriceModifier,
190
646
  l1ToL2Messages,
191
647
  previousCheckpointOutHashes,
192
648
  fork,
649
+ this.log.getBindings(),
193
650
  );
194
651
 
195
652
  // Options for the validator client when creating block and checkpoint proposals
@@ -200,11 +657,13 @@ export class CheckpointProposalJob implements Traceable {
200
657
 
201
658
  const checkpointProposalOptions: CheckpointProposalOptions = {
202
659
  publishFullTxs: !!this.config.publishTxsWithProposals,
203
- broadcastInvalidCheckpointProposal: this.config.broadcastInvalidBlockProposal,
660
+ broadcastInvalidCheckpointProposal:
661
+ this.config.broadcastInvalidCheckpointProposalOnly || this.config.broadcastInvalidBlockProposal,
204
662
  };
205
663
 
206
- let blocksInCheckpoint: L2BlockNew[] = [];
207
- let blockPendingBroadcast: { block: L2BlockNew; txs: Tx[] } | undefined = undefined;
664
+ let blocksInCheckpoint: L2Block[] = [];
665
+ let blockPendingBroadcast: BlockProposal | undefined = undefined;
666
+ const checkpointBuildTimer = new Timer();
208
667
 
209
668
  try {
210
669
  // Main loop: build blocks for the checkpoint
@@ -220,124 +679,177 @@ export class CheckpointProposalJob implements Traceable {
220
679
  // These errors are expected in HA mode, so we yield and let another HA node handle the slot
221
680
  // The only distinction between the 2 errors is SlashingProtectionError throws when the payload is different,
222
681
  // which is normal for block building (may have picked different txs)
223
- if (err instanceof DutyAlreadySignedError) {
224
- this.log.info(`Checkpoint proposal for slot ${this.slot} already signed by another HA node, yielding`, {
225
- slot: this.slot,
226
- signedByNode: err.signedByNode,
227
- });
228
- return undefined;
229
- }
230
- if (err instanceof SlashingProtectionError) {
231
- this.log.info(`Checkpoint proposal for slot ${this.slot} blocked by slashing protection, yielding`, {
232
- slot: this.slot,
233
- existingMessageHash: err.existingMessageHash,
234
- attemptedMessageHash: err.attemptedMessageHash,
235
- });
682
+ if (this.handleHASigningError(err, 'Block proposal')) {
236
683
  return undefined;
237
684
  }
238
685
  throw err;
239
686
  }
240
687
 
241
688
  if (blocksInCheckpoint.length === 0) {
242
- this.log.warn(`No blocks were built for slot ${this.slot}`, { slot: this.slot });
243
- this.eventEmitter.emit('checkpoint-empty', { slot: this.slot });
689
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
690
+ slot: this.targetSlot,
691
+ checkpointNumber: this.checkpointNumber,
692
+ reason: 'no_blocks_built',
693
+ });
694
+ this.log.warn(`No blocks were built for slot ${this.targetSlot}`, {
695
+ slot: this.targetSlot,
696
+ checkpointNumber: this.checkpointNumber,
697
+ reason: 'no_blocks_built',
698
+ });
699
+ this.eventEmitter.emit('checkpoint-empty', { slot: this.targetSlot });
700
+ return undefined;
701
+ }
702
+
703
+ const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
704
+ if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
705
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
706
+ slot: this.targetSlot,
707
+ checkpointNumber: this.checkpointNumber,
708
+ blocksBuilt: blocksInCheckpoint.length,
709
+ minBlocksForCheckpoint,
710
+ reason: 'min_blocks_not_met',
711
+ });
712
+ this.log.warn(
713
+ `Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`,
714
+ {
715
+ slot: this.targetSlot,
716
+ checkpointNumber: this.checkpointNumber,
717
+ blocksBuilt: blocksInCheckpoint.length,
718
+ minBlocksForCheckpoint,
719
+ reason: 'min_blocks_not_met',
720
+ },
721
+ );
244
722
  return undefined;
245
723
  }
246
724
 
247
725
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
248
726
  // broadcasted yet, and wait to collect the committee attestations.
249
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
727
+ this.setState(SequencerState.ASSEMBLING_CHECKPOINT);
250
728
  const checkpoint = await checkpointBuilder.completeCheckpoint();
251
729
 
252
- // Do not collect attestations nor publish to L1 in fisherman mode
730
+ // Final validation: per-block limits are only checked if the operator set them explicitly.
731
+ // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
732
+ try {
733
+ validateCheckpoint(checkpoint, {
734
+ rollupManaLimit: this.l1Constants.rollupManaLimit,
735
+ maxL2BlockGas: this.config.maxL2BlockGas,
736
+ maxDABlockGas: this.config.maxDABlockGas,
737
+ maxTxsPerBlock: this.config.maxTxsPerBlock,
738
+ maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint,
739
+ });
740
+ } catch (err) {
741
+ this.logCheckpointEvent('build-failed', `Checkpoint build failed for slot ${this.targetSlot}`, {
742
+ slot: this.targetSlot,
743
+ checkpointNumber: this.checkpointNumber,
744
+ blocksBuilt: blocksInCheckpoint.length,
745
+ reason: 'invalid_checkpoint',
746
+ checkpoint: checkpoint.header.toInspect(),
747
+ });
748
+ this.log.error(`Built an invalid checkpoint at slot ${this.targetSlot} (skipping proposal)`, err, {
749
+ slot: this.targetSlot,
750
+ checkpointNumber: this.checkpointNumber,
751
+ blocksBuilt: blocksInCheckpoint.length,
752
+ reason: 'invalid_checkpoint',
753
+ checkpoint: checkpoint.header.toInspect(),
754
+ });
755
+ return undefined;
756
+ }
757
+
758
+ // Record checkpoint-level build metrics
759
+ this.checkpointMetrics.recordCheckpointBuild(
760
+ checkpointBuildTimer.ms(),
761
+ blocksInCheckpoint.length,
762
+ checkpoint.getStats().txCount,
763
+ Number(checkpoint.header.totalManaUsed.toBigInt()),
764
+ );
765
+ this.logCheckpointEvent('built', `Checkpoint built for slot ${this.targetSlot}`, {
766
+ slot: this.targetSlot,
767
+ buildSlot: this.getBuildSlot(),
768
+ checkpointNumber: this.checkpointNumber,
769
+ proposer: this.proposer?.toString(),
770
+ attestorAddress: this.attestorAddress.toString(),
771
+ publisherAddress: this.publisher.getSenderAddress().toString(),
772
+ blocksBuilt: blocksInCheckpoint.length,
773
+ txCount: checkpoint.getStats().txCount,
774
+ totalMana: Number(checkpoint.header.totalManaUsed.toBigInt()),
775
+ });
776
+
777
+ // In fisherman mode, return the checkpoint without broadcasting or collecting attestations
253
778
  if (this.config.fishermanMode) {
254
779
  this.log.info(
255
- `Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` +
780
+ `Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` +
256
781
  `Skipping proposal in fisherman mode.`,
257
782
  {
258
- slot: this.slot,
783
+ slot: this.targetSlot,
259
784
  checkpoint: checkpoint.header.toInspect(),
260
785
  blocksBuilt: blocksInCheckpoint.length,
261
786
  },
262
787
  );
263
788
  this.metrics.recordCheckpointSuccess();
264
- return checkpoint;
789
+ // Return a broadcast result with a dummy proposal — fisherman mode skips attestation collection
790
+ return { checkpoint, proposal: undefined!, blockProposedAt: this.dateProvider.now() };
265
791
  }
266
792
 
267
- // Include the block pending broadcast in the checkpoint proposal if any
268
- const lastBlock = blockPendingBroadcast && {
269
- blockHeader: blockPendingBroadcast.block.header,
270
- indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
271
- txs: blockPendingBroadcast.txs,
272
- };
793
+ // Validate the header against L1 state before broadcasting.
794
+ // If this fails the slot is aborted before any gossip work; state drift between here
795
+ // and the eventual L1 send is caught by the bundle simulate at send time.
796
+ try {
797
+ await this.publisher.validateBlockHeader(checkpoint.header, this.checkpointSimulationOverridesPlan);
798
+ } catch (err) {
799
+ this.log.error(`Pre-broadcast header validation failed for slot ${this.targetSlot}; aborting`, err, {
800
+ slot: this.targetSlot,
801
+ checkpointNumber: this.checkpointNumber,
802
+ });
803
+ this.metrics.recordCheckpointProposalFailed('header_validation_failed');
804
+ this.eventEmitter.emit('header-validation-failed', {
805
+ slot: this.targetSlot,
806
+ checkpointNumber: this.checkpointNumber,
807
+ reason: err instanceof Error ? err.message : String(err),
808
+ });
809
+ return undefined;
810
+ }
273
811
 
274
812
  // Create the checkpoint proposal and broadcast it
275
813
  const proposal = await this.validatorClient.createCheckpointProposal(
276
814
  checkpoint.header,
277
815
  checkpoint.archive.root,
278
- lastBlock,
816
+ this.checkpointNumber,
817
+ feeAssetPriceModifier,
818
+ blockPendingBroadcast,
279
819
  this.proposer,
280
820
  checkpointProposalOptions,
281
821
  );
282
822
 
283
- const blockProposedAt = this.dateProvider.now();
284
- await this.p2pClient.broadcastCheckpointProposal(proposal);
285
-
286
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
287
- const attestations = await this.waitForAttestations(proposal);
288
- const blockAttestedAt = this.dateProvider.now();
823
+ // Advance our own optimistic proposed-checkpoint tip locally before gossiping. Gossipsub
824
+ // doesn't echo our own messages back, so this is how the proposer makes its own proposed
825
+ // checkpoint visible for pipelining the next slot. Built from local checkpoint data — never
826
+ // from the broadcast proposal archive, which may be deliberately corrupted under test flags.
827
+ // Fail closed: if this throws, the outer catch aborts the slot before gossiping.
828
+ await this.syncProposedCheckpointToArchiver(checkpoint, blocksInCheckpoint.length, feeAssetPriceModifier);
289
829
 
290
- this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
291
-
292
- // Proposer must sign over the attestations before pushing them to L1
293
- const signer = this.proposer ?? this.publisher.getSenderAddress();
294
- let attestationsSignature: Signature;
295
- try {
296
- attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
297
- attestations,
298
- signer,
299
- this.slot,
300
- this.checkpointNumber,
301
- );
302
- } catch (err) {
303
- // We shouldn't really get here since we yield to another HA node
304
- // as soon as we see these errors when creating block proposals.
305
- if (err instanceof DutyAlreadySignedError) {
306
- this.log.info(`Attestations signature for slot ${this.slot} already signed by another HA node, yielding`, {
307
- slot: this.slot,
308
- signedByNode: err.signedByNode,
309
- });
310
- return undefined;
311
- }
312
- if (err instanceof SlashingProtectionError) {
313
- this.log.info(`Attestations signature for slot ${this.slot} blocked by slashing protection, yielding`, {
314
- slot: this.slot,
315
- existingMessageHash: err.existingMessageHash,
316
- attemptedMessageHash: err.attemptedMessageHash,
317
- });
318
- return undefined;
830
+ const blockProposedAt = this.dateProvider.now();
831
+ if (this.config.skipBroadcastCheckpointProposal) {
832
+ // Test-only: suppress the CheckpointProposal so peers never see a proposed checkpoint for
833
+ // this slot, but still broadcast the held last block standalone so peers' archivers ingest
834
+ // it as a proposed-but-uncheckpointed tip — the exact orphan-block state that
835
+ // pruneOrphanProposedBlocks / checkSync must handle.
836
+ if (blockPendingBroadcast && !this.config.skipBroadcastProposals) {
837
+ await this.p2pClient.broadcastProposal(blockPendingBroadcast);
319
838
  }
320
- throw err;
839
+ } else if (!this.config.skipBroadcastProposals) {
840
+ await this.p2pClient.broadcastCheckpointProposal(proposal);
841
+ this.checkpointMetrics.noteCheckpointBroadcast(this.dateProvider.now());
321
842
  }
322
843
 
323
- // Enqueue publishing the checkpoint to L1
324
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
325
- const aztecSlotDuration = this.l1Constants.slotDuration;
326
- const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
327
- const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
328
- await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
329
- txTimeoutAt,
330
- forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
331
- });
332
-
333
- return checkpoint;
844
+ // Return immediately after broadcast attestation collection happens in the background
845
+ return { checkpoint, proposal, blockProposedAt };
334
846
  } catch (err) {
335
847
  if (err && (err instanceof DutyAlreadySignedError || err instanceof SlashingProtectionError)) {
336
848
  // swallow this error. It's already been logged by a function deeper in the stack
337
849
  return undefined;
338
850
  }
339
851
 
340
- this.log.error(`Error building checkpoint at slot ${this.slot}`, err);
852
+ this.log.error(`Error building checkpoint at slot ${this.targetSlot}`, err);
341
853
  return undefined;
342
854
  }
343
855
  }
@@ -352,32 +864,38 @@ export class CheckpointProposalJob implements Traceable {
352
864
  inHash: Fr,
353
865
  blockProposalOptions: BlockProposalOptions,
354
866
  ): Promise<{
355
- blocksInCheckpoint: L2BlockNew[];
356
- blockPendingBroadcast: { block: L2BlockNew; txs: Tx[] } | undefined;
867
+ blocksInCheckpoint: L2Block[];
868
+ blockPendingBroadcast: BlockProposal | undefined;
357
869
  }> {
358
- const blocksInCheckpoint: L2BlockNew[] = [];
870
+ const blocksInCheckpoint: L2Block[] = [];
359
871
  const txHashesAlreadyIncluded = new Set<string>();
360
872
  const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
361
873
 
362
- // Remaining blob fields available for blocks (checkpoint end marker already subtracted)
363
- let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
364
-
365
874
  // Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
366
- let blockPendingBroadcast: { block: L2BlockNew; txs: Tx[] } | undefined = undefined;
875
+ let blockPendingBroadcast: BlockProposal | undefined = undefined;
367
876
 
368
877
  while (true) {
369
878
  const blocksBuilt = blocksInCheckpoint.length;
370
- const indexWithinCheckpoint = blocksBuilt;
879
+ const indexWithinCheckpoint = IndexWithinCheckpoint(blocksBuilt);
371
880
  const blockNumber = BlockNumber(initialBlockNumber + blocksBuilt);
372
881
 
373
- const secondsIntoSlot = this.getSecondsIntoSlot();
374
- const timingInfo = this.timetable.canStartNextBlock(secondsIntoSlot);
882
+ if (blocksBuilt >= this.config.maxBlocksPerCheckpoint) {
883
+ this.log.debug(`Reached max blocks per checkpoint`, {
884
+ slot: this.targetSlot,
885
+ blocksBuilt,
886
+ maxBlocksPerCheckpoint: this.config.maxBlocksPerCheckpoint,
887
+ });
888
+ break;
889
+ }
890
+
891
+ const nowSeconds = this.dateProvider.now() / 1000;
892
+ const timingInfo = this.timetable.selectNextSubslot(this.targetSlot, nowSeconds);
375
893
 
376
894
  if (!timingInfo.canStart) {
377
895
  this.log.debug(`Not enough time left in slot to start another block`, {
378
- slot: this.slot,
896
+ slot: this.targetSlot,
379
897
  blocksBuilt,
380
- secondsIntoSlot,
898
+ nowSeconds,
381
899
  });
382
900
  break;
383
901
  }
@@ -387,31 +905,29 @@ export class CheckpointProposalJob implements Traceable {
387
905
  blockTimestamp: timestamp,
388
906
  // Create an empty block if we haven't already and this is the last one
389
907
  forceCreate: timingInfo.isLastBlock && blocksBuilt === 0 && this.config.buildCheckpointIfEmpty,
390
- // Build deadline is only set if we are enforcing the timetable
391
- buildDeadline: timingInfo.deadline
392
- ? new Date((this.getSlotStartBuildTimestamp() + timingInfo.deadline) * 1000)
393
- : undefined,
908
+ buildDeadline: new Date(timingInfo.deadline * 1000),
394
909
  blockNumber,
395
910
  indexWithinCheckpoint,
396
911
  txHashesAlreadyIncluded,
397
- remainingBlobFields,
398
912
  });
399
913
 
400
- if (!buildResult && timingInfo.isLastBlock) {
401
- // If no block was produced due to not enough txs and this was the last subslot, exit
402
- break;
403
- } else if (!buildResult && timingInfo.deadline !== undefined) {
404
- // But if there is still time for more blocks, wait until the next subslot and try again
914
+ // If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
915
+ if ('failure' in buildResult) {
916
+ // If this was the last subslot, we're done.
917
+ if (timingInfo.isLastBlock) {
918
+ break;
919
+ }
920
+ // Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
405
921
  await this.waitUntilNextSubslot(timingInfo.deadline);
406
922
  continue;
407
- } else if (!buildResult) {
408
- // Exit if there is no possibility of building more blocks
409
- break;
410
- } else if ('error' in buildResult) {
411
- // If there was an error building the block, just exit the loop and give up the rest of the slot
923
+ }
924
+
925
+ // If there was an error building the block, we just exit the loop and give up the rest of the slot.
926
+ // We don't want to risk building more blocks if something went wrong.
927
+ if ('error' in buildResult) {
412
928
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
413
- this.log.warn(`Halting block building for slot ${this.slot}`, {
414
- slot: this.slot,
929
+ this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
930
+ slot: this.targetSlot,
415
931
  blocksBuilt,
416
932
  error: buildResult.error,
417
933
  });
@@ -419,40 +935,43 @@ export class CheckpointProposalJob implements Traceable {
419
935
  break;
420
936
  }
421
937
 
422
- const { block, usedTxs, remainingBlobFields: newRemainingBlobFields } = buildResult;
423
- blocksInCheckpoint.push(block);
938
+ const { block, usedTxs } = buildResult;
939
+ this.checkpointMetrics.noteCheckpointBlockBuilt(this.dateProvider.now(), {
940
+ isFirstBlock: blocksBuilt === 0,
941
+ isLastBlock: timingInfo.isLastBlock,
942
+ });
424
943
 
425
- // Update remaining blob fields for the next block
426
- remainingBlobFields = newRemainingBlobFields;
944
+ blocksInCheckpoint.push(block);
945
+ usedTxs.forEach(tx => txHashesAlreadyIncluded.add(tx.txHash.toString()));
946
+
947
+ // Sign the block proposal. This will throw if HA signing fails.
948
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, {
949
+ ...blockProposalOptions,
950
+ broadcastInvalidBlockProposal:
951
+ blockProposalOptions.broadcastInvalidBlockProposal ||
952
+ block.indexWithinCheckpoint === this.config.invalidBlockProposalIndexWithinCheckpoint,
953
+ });
427
954
 
428
- // Sync the proposed block to the archiver to make it available
429
- // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
430
- // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
955
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
956
+ // so we avoid polluting our archive with a block that would fail.
957
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
958
+ // If this throws, we abort the entire checkpoint.
431
959
  await this.syncProposedBlockToArchiver(block);
432
960
 
433
- // If this is the last block, exit the loop now so we start collecting attestations
961
+ // If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
434
962
  if (timingInfo.isLastBlock) {
435
- this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
436
- slot: this.slot,
963
+ this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
964
+ slot: this.targetSlot,
437
965
  blockNumber,
438
966
  blocksBuilt,
439
967
  });
440
- blockPendingBroadcast = { block, txs: usedTxs };
968
+
969
+ blockPendingBroadcast = proposal;
441
970
  break;
442
971
  }
443
972
 
444
- // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
445
- // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
446
- if (!this.config.fishermanMode) {
447
- const proposal = await this.validatorClient.createBlockProposal(
448
- block.header,
449
- block.indexWithinCheckpoint,
450
- inHash,
451
- block.archive.root,
452
- usedTxs,
453
- this.proposer,
454
- blockProposalOptions,
455
- );
973
+ // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
974
+ if (proposal && !this.config.skipBroadcastProposals) {
456
975
  await this.p2pClient.broadcastProposal(proposal);
457
976
  }
458
977
 
@@ -460,191 +979,326 @@ export class CheckpointProposalJob implements Traceable {
460
979
  await this.waitUntilNextSubslot(timingInfo.deadline);
461
980
  }
462
981
 
463
- this.log.verbose(`Block building loop completed for slot ${this.slot}`, {
464
- slot: this.slot,
982
+ this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
983
+ slot: this.targetSlot,
465
984
  blocksBuilt: blocksInCheckpoint.length,
466
985
  });
467
986
 
468
987
  return { blocksInCheckpoint, blockPendingBroadcast };
469
988
  }
470
989
 
471
- /** Sleeps until it is time to produce the next block in the slot */
990
+ /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */
991
+ private createBlockProposal(
992
+ block: L2Block,
993
+ inHash: Fr,
994
+ usedTxs: Tx[],
995
+ blockProposalOptions: BlockProposalOptions,
996
+ ): Promise<BlockProposal | undefined> {
997
+ if (this.config.fishermanMode) {
998
+ this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
999
+ return Promise.resolve(undefined);
1000
+ }
1001
+ return this.validatorClient.createBlockProposal(
1002
+ block.header,
1003
+ this.checkpointNumber,
1004
+ block.indexWithinCheckpoint,
1005
+ inHash,
1006
+ block.archive.root,
1007
+ usedTxs,
1008
+ this.proposer,
1009
+ blockProposalOptions,
1010
+ );
1011
+ }
1012
+
1013
+ /**
1014
+ * Sleeps until it is time to produce the next block in the slot.
1015
+ * @param nextSubslotStart - Absolute wall-clock timestamp in seconds of the previous sub-slot deadline.
1016
+ */
472
1017
  @trackSpan('CheckpointProposalJob.waitUntilNextSubslot')
473
- private async waitUntilNextSubslot(nextSubslotStart: number) {
474
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
475
- this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, { slot: this.slot });
476
- await this.waitUntilTimeInSlot(nextSubslotStart);
1018
+ protected async waitUntilNextSubslot(nextSubslotStart: number) {
1019
+ this.setState(SequencerState.WAITING_UNTIL_NEXT_BLOCK);
1020
+ this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s`, {
1021
+ slot: this.targetSlot,
1022
+ });
1023
+ await this.awaitInterruptibleSleep(Math.max(0, nextSubslotStart * 1000 - this.dateProvider.now()));
477
1024
  }
478
1025
 
479
1026
  /** Builds a single block. Called from the main block building loop. */
480
1027
  @trackSpan('CheckpointProposalJob.buildSingleBlock')
481
- private async buildSingleBlock(
1028
+ protected async buildSingleBlock(
482
1029
  checkpointBuilder: CheckpointBuilder,
483
1030
  opts: {
484
1031
  forceCreate?: boolean;
485
1032
  blockTimestamp: bigint;
486
1033
  blockNumber: BlockNumber;
487
- indexWithinCheckpoint: number;
1034
+ indexWithinCheckpoint: IndexWithinCheckpoint;
488
1035
  buildDeadline: Date | undefined;
489
1036
  txHashesAlreadyIncluded: Set<string>;
490
- remainingBlobFields: number;
491
1037
  },
492
- ): Promise<{ block: L2BlockNew; usedTxs: Tx[]; remainingBlobFields: number } | { error: Error } | undefined> {
493
- const {
494
- blockTimestamp,
495
- forceCreate,
496
- blockNumber,
497
- indexWithinCheckpoint,
498
- buildDeadline,
499
- txHashesAlreadyIncluded,
500
- remainingBlobFields,
501
- } = opts;
1038
+ ): Promise<
1039
+ { block: L2Block; usedTxs: Tx[] } | { failure: 'insufficient-txs' | 'insufficient-valid-txs' } | { error: Error }
1040
+ > {
1041
+ const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } =
1042
+ opts;
502
1043
 
503
1044
  this.log.verbose(
504
- `Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`,
1045
+ `Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`,
505
1046
  { ...checkpointBuilder.getConstantData(), ...opts },
506
1047
  );
507
1048
 
508
1049
  try {
509
1050
  // Wait until we have enough txs to build the block
510
- const minTxs = this.config.minTxsPerBlock;
511
- const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
1051
+ const { canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
512
1052
  if (!canStartBuilding) {
513
- this.log.warn(
514
- `Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`,
515
- { blockNumber, slot: this.slot, indexWithinCheckpoint },
1053
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1054
+ reason: 'insufficient_txs',
1055
+ blockNumber,
1056
+ slot: this.targetSlot,
1057
+ checkpointNumber: this.checkpointNumber,
1058
+ indexWithinCheckpoint,
1059
+ minTxs,
1060
+ });
1061
+ this.log.verbose(
1062
+ `Not enough age-eligible txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (needs ${minTxs} eligible)`,
1063
+ {
1064
+ reason: 'insufficient_txs',
1065
+ blockNumber,
1066
+ slot: this.targetSlot,
1067
+ checkpointNumber: this.checkpointNumber,
1068
+ indexWithinCheckpoint,
1069
+ minTxs,
1070
+ },
516
1071
  );
517
- this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, availableTxs, slot: this.slot });
1072
+ this.eventEmitter.emit('block-tx-count-check-failed', { minTxs, slot: this.targetSlot });
518
1073
  this.metrics.recordBlockProposalFailed('insufficient_txs');
519
- return undefined;
1074
+ return { failure: 'insufficient-txs' };
520
1075
  }
521
1076
 
522
1077
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
523
1078
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
1079
+ // Block building only executes txs, so we skip loading their proofs unless these same tx objects get attached
1080
+ // to the broadcasted proposals via publishTxsWithProposals.
524
1081
  const pendingTxs = filter(
525
- this.p2pClient.iteratePendingTxs(),
1082
+ this.p2pClient.iterateEligiblePendingTxs({ includeProof: !!this.config.publishTxsWithProposals }),
526
1083
  tx => !txHashesAlreadyIncluded.has(tx.txHash.toString()),
527
1084
  );
528
1085
 
529
- this.log.debug(
530
- `Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`,
531
- { slot: this.slot, blockNumber, indexWithinCheckpoint },
532
- );
533
- this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
534
-
535
- // Calculate blob fields limit for txs (remaining capacity - this block's end overhead)
536
- const blockEndOverhead = getNumBlockEndBlobFields(indexWithinCheckpoint === 0);
537
- const maxBlobFieldsForTxs = remainingBlobFields - blockEndOverhead;
1086
+ this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot}`, {
1087
+ slot: this.targetSlot,
1088
+ blockNumber,
1089
+ indexWithinCheckpoint,
1090
+ });
1091
+ this.setState(SequencerState.CREATING_BLOCK);
538
1092
 
539
- const blockBuilderOptions: PublicProcessorLimits = {
1093
+ // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
1094
+ // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
1095
+ // minValidTxs is passed into the builder so it can reject the block *before* updating state.
1096
+ const minValidTxs = forceCreate ? 0 : (this.config.minValidTxsPerBlock ?? minTxs);
1097
+ const blockBuilderOptions: BlockBuilderOptions = {
540
1098
  maxTransactions: this.config.maxTxsPerBlock,
541
- maxBlockSize: this.config.maxBlockSizeInBytes,
542
- maxBlockGas: new Gas(this.config.maxDABlockGas, this.config.maxL2BlockGas),
543
- maxBlobFields: maxBlobFieldsForTxs,
1099
+ maxBlockGas:
1100
+ this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined
1101
+ ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity)
1102
+ : undefined,
544
1103
  deadline: buildDeadline,
1104
+ isBuildingProposal: true,
1105
+ minValidTxs,
1106
+ maxBlocksPerCheckpoint: this.timetable.getMaxBlocksPerCheckpoint(),
1107
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier,
1108
+ perBlockDAAllocationMultiplier: this.config.perBlockDAAllocationMultiplier,
545
1109
  };
546
1110
 
547
- // Actually build the block by executing txs
548
- const workTimer = new Timer();
549
- const {
550
- publicGas,
551
- block,
552
- publicProcessorDuration,
553
- numTxs,
554
- blockBuildingTimer,
555
- usedTxs,
556
- failedTxs,
557
- usedTxBlobFields,
558
- } = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
559
- const blockBuildDuration = workTimer.ms();
1111
+ // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
1112
+ // if the number of successfully processed txs is below minValidTxs, ensuring state is not
1113
+ // updated for blocks that will be discarded.
1114
+ const buildResult = await this.buildSingleBlockWithCheckpointBuilder(
1115
+ checkpointBuilder,
1116
+ pendingTxs,
1117
+ blockNumber,
1118
+ blockTimestamp,
1119
+ blockBuilderOptions,
1120
+ );
560
1121
 
561
1122
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
562
- await this.dropFailedTxsFromP2P(failedTxs);
1123
+ await this.dropFailedTxsFromP2P(buildResult.failedTxs);
563
1124
 
564
- // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
565
- // too long, then we may not get to minTxsPerBlock after executing public functions.
566
- const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
567
- if (!forceCreate && numTxs < minValidTxs) {
1125
+ if (buildResult.status === 'insufficient-valid-txs') {
1126
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1127
+ reason: 'insufficient_valid_txs',
1128
+ slot: this.targetSlot,
1129
+ checkpointNumber: this.checkpointNumber,
1130
+ blockNumber,
1131
+ numTxs: buildResult.processedCount,
1132
+ indexWithinCheckpoint,
1133
+ minValidTxs,
1134
+ });
568
1135
  this.log.warn(
569
- `Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed (got ${numTxs} but required ${minValidTxs})`,
570
- { slot: this.slot, blockNumber, numTxs, indexWithinCheckpoint },
1136
+ `Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`,
1137
+ {
1138
+ reason: 'insufficient_valid_txs',
1139
+ slot: this.targetSlot,
1140
+ checkpointNumber: this.checkpointNumber,
1141
+ blockNumber,
1142
+ numTxs: buildResult.processedCount,
1143
+ indexWithinCheckpoint,
1144
+ minValidTxs,
1145
+ },
571
1146
  );
572
- this.eventEmitter.emit('block-tx-count-check-failed', {
573
- minTxs: minValidTxs,
574
- availableTxs: numTxs,
575
- slot: this.slot,
1147
+ this.eventEmitter.emit('block-build-failed', {
1148
+ reason: `Insufficient valid txs`,
1149
+ slot: this.targetSlot,
576
1150
  });
577
1151
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
578
- return undefined;
1152
+ return { failure: 'insufficient-valid-txs' };
579
1153
  }
580
1154
 
581
1155
  // Block creation succeeded, emit stats and metrics
1156
+ const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
1157
+
582
1158
  const blockStats = {
583
1159
  eventName: 'l2-block-built',
584
1160
  duration: blockBuildDuration,
585
1161
  publicProcessDuration: publicProcessorDuration,
586
- rollupCircuitsDuration: blockBuildingTimer.ms(),
587
1162
  ...block.getStats(),
588
1163
  } satisfies L2BlockBuiltStats;
589
1164
 
590
1165
  const blockHash = await block.hash();
591
1166
  const txHashes = block.body.txEffects.map(tx => tx.txHash);
592
- const manaPerSec = publicGas.l2Gas / (blockBuildDuration / 1000);
1167
+ const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
593
1168
 
594
1169
  this.log.info(
595
- `Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`,
1170
+ `Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`,
596
1171
  { blockHash, txHashes, manaPerSec, ...blockStats },
597
1172
  );
598
1173
 
599
- this.eventEmitter.emit('block-proposed', { blockNumber: block.number, slot: this.slot });
600
- this.metrics.recordBuiltBlock(blockBuildDuration, publicGas.l2Gas);
1174
+ // `slot` is the target/submission slot (may be one ahead when pipelining),
1175
+ // `buildSlot` is the wall-clock slot during which the block was actually built.
1176
+ this.eventEmitter.emit('block-proposed', {
1177
+ blockNumber: block.number,
1178
+ blockHash,
1179
+ checkpointNumber: this.checkpointNumber,
1180
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1181
+ slot: this.targetSlot,
1182
+ buildSlot: this.getBuildSlot(),
1183
+ });
1184
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe(), this.targetSlot);
601
1185
 
602
- return { block, usedTxs, remainingBlobFields: maxBlobFieldsForTxs - usedTxBlobFields };
1186
+ return { block, usedTxs };
603
1187
  } catch (err: any) {
604
- this.eventEmitter.emit('block-build-failed', { reason: err.message, slot: this.slot });
605
- this.log.error(`Error building block`, err, { blockNumber, slot: this.slot });
1188
+ this.eventEmitter.emit('block-build-failed', {
1189
+ reason: err.message,
1190
+ slot: this.targetSlot,
1191
+ });
1192
+ this.logCheckpointEvent('block-build-failed', `Block build failed for slot ${this.targetSlot}`, {
1193
+ reason: err instanceof Error ? err.message : String(err),
1194
+ slot: this.targetSlot,
1195
+ checkpointNumber: this.checkpointNumber,
1196
+ blockNumber,
1197
+ });
1198
+ this.log.error(`Error building block`, err, {
1199
+ reason: err instanceof Error ? err.message : String(err),
1200
+ slot: this.targetSlot,
1201
+ checkpointNumber: this.checkpointNumber,
1202
+ blockNumber,
1203
+ });
606
1204
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
607
1205
  this.metrics.recordFailedBlock();
608
1206
  return { error: err };
609
1207
  }
610
1208
  }
611
1209
 
1210
+ /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */
1211
+ private async buildSingleBlockWithCheckpointBuilder(
1212
+ checkpointBuilder: CheckpointBuilder,
1213
+ pendingTxs: AsyncIterable<Tx>,
1214
+ blockNumber: BlockNumber,
1215
+ blockTimestamp: bigint,
1216
+ blockBuilderOptions: BlockBuilderOptions,
1217
+ ) {
1218
+ try {
1219
+ const workTimer = new Timer();
1220
+ const result = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
1221
+ const blockBuildDuration = workTimer.ms();
1222
+ return { ...result, blockBuildDuration, status: 'success' as const };
1223
+ } catch (err: unknown) {
1224
+ if (isErrorClass(err, InsufficientValidTxsError)) {
1225
+ return {
1226
+ failedTxs: err.failedTxs,
1227
+ processedCount: err.processedCount,
1228
+ status: 'insufficient-valid-txs' as const,
1229
+ };
1230
+ }
1231
+ throw err;
1232
+ }
1233
+ }
1234
+
612
1235
  /** Waits until minTxs are available on the pool for building a block. */
613
1236
  @trackSpan('CheckpointProposalJob.waitForMinTxs')
614
1237
  private async waitForMinTxs(opts: {
615
1238
  forceCreate?: boolean;
616
1239
  blockNumber: BlockNumber;
617
- indexWithinCheckpoint: number;
1240
+ indexWithinCheckpoint: IndexWithinCheckpoint;
618
1241
  buildDeadline: Date | undefined;
619
- }): Promise<{ canStartBuilding: boolean; availableTxs: number }> {
620
- const minTxs = this.config.minTxsPerBlock;
1242
+ }): Promise<{ canStartBuilding: boolean; minTxs: number }> {
621
1243
  const { indexWithinCheckpoint, blockNumber, buildDeadline, forceCreate } = opts;
622
1244
 
623
- // Deadline is undefined if we are not enforcing the timetable, meaning we'll exit immediately when out of time
1245
+ // We only allow a block with 0 txs in the first block of the checkpoint
1246
+ const minTxs = indexWithinCheckpoint > 0 && this.config.minTxsPerBlock === 0 ? 1 : this.config.minTxsPerBlock;
1247
+
1248
+ // Latest time to keep waiting for txs: wait_for_txs_deadline = block_build_deadline(k) - min_block_duration.
624
1249
  const startBuildingDeadline = buildDeadline
625
- ? new Date(buildDeadline.getTime() - this.timetable.minExecutionTime * 1000)
1250
+ ? new Date(buildDeadline.getTime() - this.timetable.minBlockDuration * 1000)
626
1251
  : undefined;
627
1252
 
628
- let availableTxs = await this.p2pClient.getPendingTxCount();
629
-
630
- while (!forceCreate && availableTxs < minTxs) {
1253
+ // Gate on age-eligible txs so we don't start building on txs the builder would then filter out for being
1254
+ // too fresh. hasEligiblePendingTxs early-exits once minTxs are eligible instead of counting the whole pool.
1255
+ while (!forceCreate && !(await this.p2pClient.hasEligiblePendingTxs(minTxs))) {
631
1256
  // If we're past deadline, or we have no deadline, give up
632
1257
  const now = this.dateProvider.nowAsDate();
633
1258
  if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
634
- return { canStartBuilding: false, availableTxs: availableTxs };
1259
+ return { canStartBuilding: false, minTxs };
635
1260
  }
636
1261
 
637
1262
  // Wait a bit before checking again
638
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.slot);
1263
+ this.setState(SequencerState.WAITING_FOR_TXS);
639
1264
  this.log.verbose(
640
- `Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (have ${availableTxs} but need ${minTxs})`,
641
- { blockNumber, slot: this.slot, indexWithinCheckpoint },
1265
+ `Waiting for ${minTxs} age-eligible txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot}`,
1266
+ { blockNumber, slot: this.targetSlot, indexWithinCheckpoint, minTxs },
642
1267
  );
643
- await sleep(TXS_POLLING_MS);
644
- availableTxs = await this.p2pClient.getPendingTxCount();
1268
+ await this.waitForTxsPollingInterval();
645
1269
  }
646
1270
 
647
- return { canStartBuilding: true, availableTxs };
1271
+ return { canStartBuilding: true, minTxs };
1272
+ }
1273
+
1274
+ private async getSignedCommitteeAttestations(
1275
+ broadcast: CheckpointProposalBroadcast,
1276
+ ): Promise<{ attestations: CommitteeAttestationsAndSigners; attestationsSignature: Signature } | undefined> {
1277
+ const { proposal, blockProposedAt } = broadcast;
1278
+ this.setState(SequencerState.COLLECTING_ATTESTATIONS);
1279
+ const attestations = await this.waitForAttestations(proposal);
1280
+ if (!attestations) {
1281
+ return undefined;
1282
+ }
1283
+ this.checkpointMetrics.recordCheckpointAttestationDelay(this.dateProvider.now() - blockProposedAt);
1284
+
1285
+ // Proposer must sign over the attestations before pushing them to L1
1286
+ const signer = this.proposer ?? this.publisher.getSenderAddress();
1287
+ try {
1288
+ const attestationsSignature = await this.validatorClient.signAttestationsAndSigners(
1289
+ attestations,
1290
+ signer,
1291
+ this.targetSlot,
1292
+ this.checkpointNumber,
1293
+ );
1294
+ return { attestations, attestationsSignature };
1295
+ } catch (err) {
1296
+ if (this.handleHASigningError(err, 'Attestations signature')) {
1297
+ return;
1298
+ }
1299
+ this.log.error(`Error signing attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
1300
+ return undefined;
1301
+ }
648
1302
  }
649
1303
 
650
1304
  /**
@@ -652,10 +1306,12 @@ export class CheckpointProposalJob implements Traceable {
652
1306
  * This is run after all blocks for the checkpoint have been built.
653
1307
  */
654
1308
  @trackSpan('CheckpointProposalJob.waitForAttestations')
655
- private async waitForAttestations(proposal: CheckpointProposal): Promise<CommitteeAttestationsAndSigners> {
1309
+ private async waitForAttestations(
1310
+ proposal: CheckpointProposal,
1311
+ ): Promise<CommitteeAttestationsAndSigners | undefined> {
656
1312
  if (this.config.fishermanMode) {
657
1313
  this.log.debug('Skipping attestation collection in fisherman mode');
658
- return CommitteeAttestationsAndSigners.empty();
1314
+ return CommitteeAttestationsAndSigners.empty(this.getSignatureContext());
659
1315
  }
660
1316
 
661
1317
  const slotNumber = proposal.slotNumber;
@@ -665,25 +1321,33 @@ export class CheckpointProposalJob implements Traceable {
665
1321
  throw new Error('No committee when collecting attestations');
666
1322
  } else if (committee.length === 0) {
667
1323
  this.log.verbose(`Attesting committee is empty`);
668
- return CommitteeAttestationsAndSigners.empty();
1324
+ return CommitteeAttestationsAndSigners.empty(this.getSignatureContext());
669
1325
  } else {
670
1326
  this.log.debug(`Attesting committee length is ${committee.length}`, { committee });
671
1327
  }
672
1328
 
673
- const numberOfRequiredAttestations = Math.floor((committee.length * 2) / 3) + 1;
1329
+ const numberOfRequiredAttestations = computeQuorum(committee.length);
674
1330
 
675
1331
  if (this.config.skipCollectingAttestations) {
676
1332
  this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
677
- const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
678
- return new CommitteeAttestationsAndSigners(orderAttestations(attestations ?? [], committee));
1333
+ const attestations = await this.validatorClient?.collectOwnAttestations(proposal, this.checkpointNumber);
1334
+ this.logCheckpointAttestations('collected', committee, attestations ?? [], numberOfRequiredAttestations, {
1335
+ reason: 'collect_own_only',
1336
+ });
1337
+ return new CommitteeAttestationsAndSigners(
1338
+ orderAttestations(attestations ?? [], committee),
1339
+ this.getSignatureContext(),
1340
+ );
679
1341
  }
680
1342
 
681
- const attestationTimeAllowed = this.config.enforceTimeTable
682
- ? this.timetable.getMaxAllowedTime(SequencerState.PUBLISHING_CHECKPOINT)!
683
- : this.l1Constants.slotDuration;
684
- const attestationDeadline = new Date(this.dateProvider.now() + attestationTimeAllowed * 1000);
1343
+ // Hard attestation-collection cutoff = the single consensus attestation_deadline (target_slot_start + S - 2E).
1344
+ const attestationDeadlineSeconds = this.timetable.getAttestationDeadline(this.targetSlot);
1345
+ const attestationDeadline = new Date(attestationDeadlineSeconds * 1000);
685
1346
 
686
- this.metrics.recordRequiredAttestations(numberOfRequiredAttestations, attestationTimeAllowed);
1347
+ this.metrics.recordRequiredAttestations(
1348
+ numberOfRequiredAttestations,
1349
+ Math.max(0, attestationDeadline.getTime() - this.dateProvider.now()),
1350
+ );
687
1351
 
688
1352
  const collectAttestationsTimer = new Timer();
689
1353
  let collectedAttestationsCount: number = 0;
@@ -692,29 +1356,90 @@ export class CheckpointProposalJob implements Traceable {
692
1356
  proposal,
693
1357
  numberOfRequiredAttestations,
694
1358
  attestationDeadline,
1359
+ this.checkpointNumber,
695
1360
  );
696
1361
 
697
1362
  collectedAttestationsCount = attestations.length;
698
1363
 
1364
+ // Trim attestations to minimum required to save L1 calldata gas
1365
+ const localAddresses = this.validatorClient.getValidatorAddresses();
1366
+ const trimmed = trimAttestations(
1367
+ attestations,
1368
+ numberOfRequiredAttestations,
1369
+ this.attestorAddress,
1370
+ localAddresses,
1371
+ );
1372
+ if (trimmed.length < attestations.length) {
1373
+ this.log.debug(`Trimmed attestations from ${attestations.length} to ${trimmed.length} for L1 submission`);
1374
+ }
1375
+
699
1376
  // Rollup contract requires that the signatures are provided in the order of the committee
700
- const sorted = orderAttestations(attestations, committee);
1377
+ const sorted = orderAttestations(trimmed, committee);
1378
+ this.logCheckpointAttestations('collected', committee, attestations, numberOfRequiredAttestations, {
1379
+ submittedCount: trimmed.length,
1380
+ });
701
1381
 
702
1382
  // Manipulate the attestations if we've been configured to do so
703
- if (this.config.injectFakeAttestation || this.config.shuffleAttestationOrdering) {
1383
+ if (
1384
+ this.config.injectFakeAttestation ||
1385
+ this.config.injectHighSValueAttestation ||
1386
+ this.config.injectUnrecoverableSignatureAttestation ||
1387
+ this.config.injectYParityAttestation ||
1388
+ this.config.shuffleAttestationOrdering
1389
+ ) {
704
1390
  return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
705
1391
  }
706
1392
 
707
- return new CommitteeAttestationsAndSigners(sorted);
1393
+ return new CommitteeAttestationsAndSigners(sorted, this.getSignatureContext());
708
1394
  } catch (err) {
709
1395
  if (err && err instanceof AttestationTimeoutError) {
710
1396
  collectedAttestationsCount = err.collectedCount;
1397
+ this.logCheckpointAttestations('failed', committee, undefined, numberOfRequiredAttestations, {
1398
+ collectedCount: collectedAttestationsCount,
1399
+ reason: 'timeout',
1400
+ });
1401
+ this.log.error(
1402
+ `Timeout while waiting for attestations for checkpoint proposal at slot ${proposal.slotNumber} (collected ${collectedAttestationsCount}/${numberOfRequiredAttestations})`,
1403
+ err,
1404
+ );
1405
+ } else {
1406
+ this.logCheckpointAttestations('failed', committee, undefined, numberOfRequiredAttestations, {
1407
+ collectedCount: collectedAttestationsCount,
1408
+ reason: err instanceof Error ? err.message : String(err),
1409
+ });
1410
+ this.log.error(`Error collecting attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
711
1411
  }
712
- throw err;
1412
+ return undefined;
713
1413
  } finally {
714
1414
  this.metrics.recordCollectedAttestations(collectedAttestationsCount, collectAttestationsTimer.ms());
715
1415
  }
716
1416
  }
717
1417
 
1418
+ private logCheckpointAttestations(
1419
+ status: 'collected' | 'failed',
1420
+ committee: EthAddress[],
1421
+ attestations: CheckpointAttestation[] | undefined,
1422
+ requiredAttestations: number,
1423
+ opts: { collectedCount?: number; submittedCount?: number; reason?: string } = {},
1424
+ ) {
1425
+ const signedValidators =
1426
+ attestations
1427
+ ?.map(attestation => attestation.getSender()?.toString())
1428
+ .filter((address): address is `0x${string}` => address !== undefined) ?? [];
1429
+ const collectedCount = opts.collectedCount ?? new Set(signedValidators).size;
1430
+ const missingValidatorCount = status === 'failed' ? Math.max(0, requiredAttestations - collectedCount) : undefined;
1431
+ this.logCheckpointEvent(`attestations-${status}`, `Checkpoint attestations ${status} for slot ${this.targetSlot}`, {
1432
+ slot: this.targetSlot,
1433
+ checkpointNumber: this.checkpointNumber,
1434
+ committeeSize: committee.length,
1435
+ requiredAttestations,
1436
+ collectedAttestations: collectedCount,
1437
+ ...(opts.submittedCount !== undefined && { submittedAttestations: opts.submittedCount }),
1438
+ ...(missingValidatorCount !== undefined && { missingValidatorCount }),
1439
+ ...(opts.reason !== undefined && { reason: opts.reason }),
1440
+ });
1441
+ }
1442
+
718
1443
  /** Breaks the attestations before publishing based on attack configs */
719
1444
  private manipulateAttestations(
720
1445
  slotNumber: SlotNumber,
@@ -729,7 +1454,11 @@ export class CheckpointProposalJob implements Traceable {
729
1454
  this.epochCache.computeProposerIndex(slotNumber, epoch, seed, BigInt(committee.length)),
730
1455
  );
731
1456
 
732
- if (this.config.injectFakeAttestation) {
1457
+ if (
1458
+ this.config.injectFakeAttestation ||
1459
+ this.config.injectHighSValueAttestation ||
1460
+ this.config.injectUnrecoverableSignatureAttestation
1461
+ ) {
733
1462
  // Find non-empty attestations that are not from the proposer
734
1463
  const nonProposerIndices: number[] = [];
735
1464
  for (let i = 0; i < attestations.length; i++) {
@@ -739,27 +1468,61 @@ export class CheckpointProposalJob implements Traceable {
739
1468
  }
740
1469
  if (nonProposerIndices.length > 0) {
741
1470
  const targetIndex = nonProposerIndices[randomInt(nonProposerIndices.length)];
742
- this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
743
- unfreeze(attestations[targetIndex]).signature = Signature.random();
1471
+ if (this.config.injectHighSValueAttestation) {
1472
+ this.log.warn(
1473
+ `Injecting high-s value attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`,
1474
+ );
1475
+ unfreeze(attestations[targetIndex]).signature = flipSignature(attestations[targetIndex].signature);
1476
+ } else if (this.config.injectUnrecoverableSignatureAttestation) {
1477
+ this.log.warn(
1478
+ `Injecting unrecoverable signature attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`,
1479
+ );
1480
+ unfreeze(attestations[targetIndex]).signature = generateUnrecoverableSignature();
1481
+ } else {
1482
+ this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1483
+ unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
1484
+ }
744
1485
  }
745
- return new CommitteeAttestationsAndSigners(attestations);
1486
+ return new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext());
1487
+ }
1488
+
1489
+ if (this.config.injectYParityAttestation) {
1490
+ // Force every non-proposer signed slot's recovery byte to yParity (v ∈ {0, 1}) form in the packed L1
1491
+ // tuple, after packAttestations has canonicalized it. The proposer's own slot is left canonical so
1492
+ // propose() still passes verifyProposer. Models a malicious proposer landing a checkpoint L1 accepts
1493
+ // but that can never be proven (ECDSA.recover rejects v ∉ {27, 28}).
1494
+ this.log.warn(`Injecting yParity attestations in checkpoint for slot ${slotNumber} (proposer #${proposerIndex})`);
1495
+ return new MaliciousYParityCommitteeAttestationsAndSigners(
1496
+ attestations,
1497
+ proposerIndex,
1498
+ this.getSignatureContext(),
1499
+ );
746
1500
  }
747
1501
 
748
1502
  if (this.config.shuffleAttestationOrdering) {
749
1503
  this.log.warn(`Shuffling attestation ordering in checkpoint for slot ${slotNumber} (proposer #${proposerIndex})`);
750
1504
 
751
1505
  const shuffled = [...attestations];
752
- const [i, j] = [(proposerIndex + 1) % shuffled.length, (proposerIndex + 2) % shuffled.length];
753
- const valueI = shuffled[i];
754
- const valueJ = shuffled[j];
755
- shuffled[i] = valueJ;
756
- shuffled[j] = valueI;
757
1506
 
758
- const signers = new CommitteeAttestationsAndSigners(attestations).getSigners();
759
- return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers);
1507
+ // Find two non-proposer positions that both have non-empty signatures to swap.
1508
+ // This ensures the bitmap doesn't change, so the MaliciousCommitteeAttestationsAndSigners
1509
+ // signers array stays correctly aligned with L1's committee reconstruction.
1510
+ const swappable: number[] = [];
1511
+ for (let k = 0; k < shuffled.length; k++) {
1512
+ if (!shuffled[k].signature.isEmpty() && k !== proposerIndex) {
1513
+ swappable.push(k);
1514
+ }
1515
+ }
1516
+ if (swappable.length >= 2) {
1517
+ const [i, j] = [swappable[0], swappable[1]];
1518
+ [shuffled[i], shuffled[j]] = [shuffled[j], shuffled[i]];
1519
+ }
1520
+
1521
+ const signers = new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext()).getSigners();
1522
+ return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers, this.getSignatureContext());
760
1523
  }
761
1524
 
762
- return new CommitteeAttestationsAndSigners(attestations);
1525
+ return new CommitteeAttestationsAndSigners(attestations, this.getSignatureContext());
763
1526
  }
764
1527
 
765
1528
  private async dropFailedTxsFromP2P(failedTxs: FailedTx[]) {
@@ -769,17 +1532,20 @@ export class CheckpointProposalJob implements Traceable {
769
1532
  const failedTxData = failedTxs.map(fail => fail.tx);
770
1533
  const failedTxHashes = failedTxData.map(tx => tx.getTxHash());
771
1534
  this.log.verbose(`Dropping failed txs ${failedTxHashes.join(', ')}`);
772
- await this.p2pClient.deleteTxs(failedTxHashes);
1535
+ await this.p2pClient.handleFailedExecution(failedTxHashes);
773
1536
  }
774
1537
 
775
1538
  /**
776
1539
  * Adds the proposed block to the archiver so it's available via P2P.
777
1540
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
778
1541
  * would never receive its own block without this explicit sync.
1542
+ *
1543
+ * In fisherman mode we skip this push: the fisherman builds blocks locally for validation
1544
+ * and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
1545
+ * whenever the real proposer's block arrives from L1.
779
1546
  */
780
- private async syncProposedBlockToArchiver(block: L2BlockNew): Promise<void> {
781
- // TODO(palla/mbps): Change default to false once block sync is stable.
782
- if (this.config.skipPushProposedBlocksToArchiver !== false) {
1547
+ private async syncProposedBlockToArchiver(block: L2Block): Promise<void> {
1548
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
783
1549
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
784
1550
  blockNumber: block.number,
785
1551
  slot: block.header.globalVariables.slotNumber,
@@ -793,46 +1559,91 @@ export class CheckpointProposalJob implements Traceable {
793
1559
  await this.blockSink.addBlock(block);
794
1560
  }
795
1561
 
1562
+ /**
1563
+ * Adds the proposed checkpoint to the archiver so the proposer's optimistic proposed-checkpoint
1564
+ * tip advances locally. Gossip doesn't echo our own messages back, so without this the proposer
1565
+ * would never see its own proposed checkpoint and couldn't pipeline the next slot.
1566
+ *
1567
+ * Skipped whenever proposed blocks aren't pushed (`skipPushProposedBlocksToArchiver`, fisherman
1568
+ * mode): the archiver derives the checkpoint archive from its stored blocks, so without them the
1569
+ * push would fail. All blocks were already added (and awaited) during block building, so this
1570
+ * needs no retry — they are guaranteed present by the time we get here.
1571
+ */
1572
+ private async syncProposedCheckpointToArchiver(
1573
+ checkpoint: Checkpoint,
1574
+ blockCount: number,
1575
+ feeAssetPriceModifier: bigint,
1576
+ ): Promise<void> {
1577
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
1578
+ return;
1579
+ }
1580
+ const startBlock = BlockNumber(this.syncedToBlockNumber + 1);
1581
+ this.log.debug(`Syncing proposed checkpoint ${this.checkpointNumber} to archiver`, {
1582
+ checkpointNumber: this.checkpointNumber,
1583
+ slot: this.targetSlot,
1584
+ startBlock,
1585
+ blockCount,
1586
+ });
1587
+ await this.blockSink.addProposedCheckpoint({
1588
+ header: checkpoint.header,
1589
+ checkpointNumber: this.checkpointNumber,
1590
+ startBlock,
1591
+ blockCount,
1592
+ totalManaUsed: checkpoint.header.totalManaUsed.toBigInt(),
1593
+ feeAssetPriceModifier,
1594
+ });
1595
+ }
1596
+
796
1597
  /** Runs fee analysis and logs checkpoint outcome as fisherman */
797
1598
  private async handleCheckpointEndAsFisherman(checkpoint: Checkpoint | undefined) {
798
1599
  // Perform L1 fee analysis before clearing requests
799
1600
  // The callback is invoked asynchronously after the next block is mined
800
- const feeAnalysis = await this.publisher.analyzeL1Fees(this.slot, analysis =>
1601
+ const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, analysis =>
801
1602
  this.metrics.recordFishermanFeeAnalysis(analysis),
802
1603
  );
803
1604
 
804
1605
  if (checkpoint) {
805
- this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.slot}`, {
1606
+ this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
806
1607
  ...checkpoint.toCheckpointInfo(),
807
1608
  ...checkpoint.getStats(),
808
1609
  feeAnalysisId: feeAnalysis?.id,
809
1610
  });
810
1611
  } else {
811
- this.log.warn(`Validation block building FAILED for slot ${this.slot}`, {
812
- slot: this.slot,
1612
+ this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
1613
+ slot: this.targetSlot,
813
1614
  feeAnalysisId: feeAnalysis?.id,
814
1615
  });
815
- this.metrics.recordBlockProposalFailed('block_build_failed');
1616
+ this.metrics.recordCheckpointProposalFailed('block_build_failed');
816
1617
  }
817
1618
 
818
1619
  this.publisher.clearPendingRequests();
819
1620
  }
820
1621
 
821
- /** Waits until a specific time within the current slot */
822
- @trackSpan('CheckpointProposalJob.waitUntilTimeInSlot')
823
- protected async waitUntilTimeInSlot(targetSecondsIntoSlot: number): Promise<void> {
824
- const slotStartTimestamp = this.getSlotStartBuildTimestamp();
825
- const targetTimestamp = slotStartTimestamp + targetSecondsIntoSlot;
826
- await sleepUntil(new Date(targetTimestamp * 1000), this.dateProvider.nowAsDate());
827
- }
828
-
829
- private getSlotStartBuildTimestamp(): number {
830
- return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
1622
+ /**
1623
+ * Helper to handle HA double-signing errors. Returns true if the error was handled (caller should yield).
1624
+ */
1625
+ private handleHASigningError(err: any, errorContext: string): boolean {
1626
+ if (err instanceof DutyAlreadySignedError) {
1627
+ this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
1628
+ slot: this.targetSlot,
1629
+ signedByNode: err.signedByNode,
1630
+ });
1631
+ return true;
1632
+ }
1633
+ if (err instanceof SlashingProtectionError) {
1634
+ this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
1635
+ slot: this.targetSlot,
1636
+ existingMessageHash: err.existingMessageHash,
1637
+ attemptedMessageHash: err.attemptedMessageHash,
1638
+ });
1639
+ return true;
1640
+ }
1641
+ return false;
831
1642
  }
832
1643
 
833
- private getSecondsIntoSlot(): number {
834
- const slotStartTimestamp = this.getSlotStartBuildTimestamp();
835
- return Number((this.dateProvider.now() / 1000 - slotStartTimestamp).toFixed(3));
1644
+ /** Waits the polling interval for transactions. Extracted for test overriding. */
1645
+ protected async waitForTxsPollingInterval(): Promise<void> {
1646
+ await this.awaitInterruptibleSleep(TXS_POLLING_MS);
836
1647
  }
837
1648
 
838
1649
  public getPublisher() {