@aztec/pxe 0.0.1-commit.fff30aa → 0.0.1-dev

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (162) hide show
  1. package/dest/bin/check_oracle_version.js +1 -1
  2. package/dest/block_synchronizer/block_synchronizer.d.ts +5 -3
  3. package/dest/block_synchronizer/block_synchronizer.d.ts.map +1 -1
  4. package/dest/block_synchronizer/block_synchronizer.js +10 -2
  5. package/dest/config/package_info.js +1 -1
  6. package/dest/contract_function_simulator/contract_function_simulator.d.ts +4 -1
  7. package/dest/contract_function_simulator/contract_function_simulator.d.ts.map +1 -1
  8. package/dest/contract_function_simulator/contract_function_simulator.js +18 -10
  9. package/dest/contract_function_simulator/oracle/interfaces.d.ts +5 -2
  10. package/dest/contract_function_simulator/oracle/interfaces.d.ts.map +1 -1
  11. package/dest/contract_function_simulator/oracle/oracle.d.ts +4 -1
  12. package/dest/contract_function_simulator/oracle/oracle.d.ts.map +1 -1
  13. package/dest/contract_function_simulator/oracle/oracle.js +53 -1
  14. package/dest/contract_function_simulator/oracle/private_execution_oracle.d.ts +10 -14
  15. package/dest/contract_function_simulator/oracle/private_execution_oracle.d.ts.map +1 -1
  16. package/dest/contract_function_simulator/oracle/private_execution_oracle.js +16 -14
  17. package/dest/contract_function_simulator/oracle/utility_execution_oracle.d.ts +19 -2
  18. package/dest/contract_function_simulator/oracle/utility_execution_oracle.d.ts.map +1 -1
  19. package/dest/contract_function_simulator/oracle/utility_execution_oracle.js +108 -5
  20. package/dest/contract_sync/contract_sync_service.d.ts +2 -1
  21. package/dest/contract_sync/contract_sync_service.d.ts.map +1 -1
  22. package/dest/contract_sync/contract_sync_service.js +41 -7
  23. package/dest/contract_sync/helpers.d.ts +2 -3
  24. package/dest/contract_sync/helpers.d.ts.map +1 -1
  25. package/dest/contract_sync/helpers.js +12 -19
  26. package/dest/entrypoints/client/bundle/utils.d.ts +1 -1
  27. package/dest/entrypoints/client/bundle/utils.d.ts.map +1 -1
  28. package/dest/entrypoints/client/bundle/utils.js +2 -1
  29. package/dest/entrypoints/client/lazy/utils.d.ts +1 -1
  30. package/dest/entrypoints/client/lazy/utils.d.ts.map +1 -1
  31. package/dest/entrypoints/client/lazy/utils.js +2 -1
  32. package/dest/entrypoints/pxe_creation_options.d.ts +4 -1
  33. package/dest/entrypoints/pxe_creation_options.d.ts.map +1 -1
  34. package/dest/entrypoints/server/index.d.ts +2 -1
  35. package/dest/entrypoints/server/index.d.ts.map +1 -1
  36. package/dest/entrypoints/server/index.js +1 -0
  37. package/dest/entrypoints/server/utils.d.ts +1 -1
  38. package/dest/entrypoints/server/utils.d.ts.map +1 -1
  39. package/dest/entrypoints/server/utils.js +2 -1
  40. package/dest/events/event_service.d.ts +13 -5
  41. package/dest/events/event_service.d.ts.map +1 -1
  42. package/dest/events/event_service.js +28 -7
  43. package/dest/hooks/authorize_utility_call.d.ts +37 -0
  44. package/dest/hooks/authorize_utility_call.d.ts.map +1 -0
  45. package/dest/hooks/authorize_utility_call.js +4 -0
  46. package/dest/hooks/execution_hooks.d.ts +42 -0
  47. package/dest/hooks/execution_hooks.d.ts.map +1 -0
  48. package/dest/hooks/execution_hooks.js +9 -0
  49. package/dest/hooks/index.d.ts +4 -0
  50. package/dest/hooks/index.d.ts.map +1 -0
  51. package/dest/hooks/index.js +1 -0
  52. package/dest/logs/log_service.d.ts +1 -1
  53. package/dest/logs/log_service.d.ts.map +1 -1
  54. package/dest/logs/log_service.js +20 -35
  55. package/dest/messages/message_context_service.d.ts +1 -1
  56. package/dest/messages/message_context_service.d.ts.map +1 -1
  57. package/dest/messages/message_context_service.js +12 -10
  58. package/dest/notes/note_service.d.ts +25 -3
  59. package/dest/notes/note_service.d.ts.map +1 -1
  60. package/dest/notes/note_service.js +80 -65
  61. package/dest/oracle_version.d.ts +2 -2
  62. package/dest/oracle_version.js +2 -2
  63. package/dest/private_kernel/private_kernel_execution_prover.d.ts +2 -1
  64. package/dest/private_kernel/private_kernel_execution_prover.d.ts.map +1 -1
  65. package/dest/private_kernel/private_kernel_execution_prover.js +18 -4
  66. package/dest/private_kernel/private_kernel_oracle.d.ts +1 -1
  67. package/dest/private_kernel/private_kernel_oracle.d.ts.map +1 -1
  68. package/dest/private_kernel/private_kernel_oracle.js +7 -2
  69. package/dest/pxe.d.ts +20 -5
  70. package/dest/pxe.d.ts.map +1 -1
  71. package/dest/pxe.js +61 -59
  72. package/dest/storage/backwards_compatibility_tests/kv_store_snapshot.d.ts +42 -0
  73. package/dest/storage/backwards_compatibility_tests/kv_store_snapshot.d.ts.map +1 -0
  74. package/dest/storage/backwards_compatibility_tests/kv_store_snapshot.js +93 -0
  75. package/dest/storage/backwards_compatibility_tests/schema_tests.d.ts +15 -0
  76. package/dest/storage/backwards_compatibility_tests/schema_tests.d.ts.map +1 -0
  77. package/dest/storage/backwards_compatibility_tests/schema_tests.js +588 -0
  78. package/dest/storage/backwards_compatibility_tests/store_spy.d.ts +19 -0
  79. package/dest/storage/backwards_compatibility_tests/store_spy.d.ts.map +1 -0
  80. package/dest/storage/backwards_compatibility_tests/store_spy.js +63 -0
  81. package/dest/storage/open_pxe_stores.d.ts +31 -0
  82. package/dest/storage/open_pxe_stores.d.ts.map +1 -0
  83. package/dest/storage/open_pxe_stores.js +26 -0
  84. package/dest/tagging/get_all_logs_by_tags.d.ts +1 -1
  85. package/dest/tagging/get_all_logs_by_tags.d.ts.map +1 -1
  86. package/dest/tagging/get_all_logs_by_tags.js +3 -0
  87. package/dest/tagging/index.d.ts +4 -3
  88. package/dest/tagging/index.d.ts.map +1 -1
  89. package/dest/tagging/index.js +3 -2
  90. package/dest/tagging/persist_sender_tagging_index_ranges.d.ts +29 -0
  91. package/dest/tagging/persist_sender_tagging_index_ranges.d.ts.map +1 -0
  92. package/dest/tagging/persist_sender_tagging_index_ranges.js +42 -0
  93. package/dest/tagging/recipient_sync/sync_tagged_private_logs.d.ts +56 -0
  94. package/dest/tagging/recipient_sync/sync_tagged_private_logs.d.ts.map +1 -0
  95. package/dest/tagging/recipient_sync/sync_tagged_private_logs.js +158 -0
  96. package/dest/tagging/reconcile_tagging_index_ranges.d.ts +36 -0
  97. package/dest/tagging/reconcile_tagging_index_ranges.d.ts.map +1 -0
  98. package/dest/tagging/reconcile_tagging_index_ranges.js +74 -0
  99. package/dest/tagging/sender_sync/sync_sender_tagging_indexes.d.ts +1 -1
  100. package/dest/tagging/sender_sync/sync_sender_tagging_indexes.d.ts.map +1 -1
  101. package/dest/tagging/sender_sync/sync_sender_tagging_indexes.js +19 -8
  102. package/dest/tagging/sender_sync/utils/get_status_change_of_pending.d.ts +11 -6
  103. package/dest/tagging/sender_sync/utils/get_status_change_of_pending.d.ts.map +1 -1
  104. package/dest/tagging/sender_sync/utils/get_status_change_of_pending.js +21 -0
  105. package/package.json +17 -16
  106. package/src/bin/check_oracle_version.ts +1 -1
  107. package/src/block_synchronizer/block_synchronizer.ts +11 -3
  108. package/src/config/package_info.ts +1 -1
  109. package/src/contract_function_simulator/contract_function_simulator.ts +32 -9
  110. package/src/contract_function_simulator/oracle/interfaces.ts +12 -1
  111. package/src/contract_function_simulator/oracle/oracle.ts +73 -1
  112. package/src/contract_function_simulator/oracle/private_execution_oracle.ts +25 -21
  113. package/src/contract_function_simulator/oracle/utility_execution_oracle.ts +165 -29
  114. package/src/contract_sync/contract_sync_service.ts +55 -23
  115. package/src/contract_sync/helpers.ts +11 -23
  116. package/src/entrypoints/client/bundle/utils.ts +1 -0
  117. package/src/entrypoints/client/lazy/utils.ts +1 -0
  118. package/src/entrypoints/pxe_creation_options.ts +4 -0
  119. package/src/entrypoints/server/index.ts +1 -0
  120. package/src/entrypoints/server/utils.ts +1 -0
  121. package/src/events/event_service.ts +52 -17
  122. package/src/hooks/authorize_utility_call.ts +40 -0
  123. package/src/hooks/execution_hooks.ts +48 -0
  124. package/src/hooks/index.ts +7 -0
  125. package/src/logs/log_service.ts +46 -71
  126. package/src/messages/message_context_service.ts +25 -24
  127. package/src/notes/note_service.ts +115 -91
  128. package/src/oracle_version.ts +2 -2
  129. package/src/private_kernel/private_kernel_execution_prover.ts +29 -3
  130. package/src/private_kernel/private_kernel_oracle.ts +15 -5
  131. package/src/pxe.ts +116 -53
  132. package/src/storage/backwards_compatibility_tests/__snapshots__/AddressStore.json +22 -0
  133. package/src/storage/backwards_compatibility_tests/__snapshots__/AnchorBlockStore.json +3 -0
  134. package/src/storage/backwards_compatibility_tests/__snapshots__/CapsuleStore.json +16 -0
  135. package/src/storage/backwards_compatibility_tests/__snapshots__/ContractStore.json +28 -0
  136. package/src/storage/backwards_compatibility_tests/__snapshots__/KeyStore.json +52 -0
  137. package/src/storage/backwards_compatibility_tests/__snapshots__/L2TipsKVStore.json +42 -0
  138. package/src/storage/backwards_compatibility_tests/__snapshots__/NoteStore.json +36 -0
  139. package/src/storage/backwards_compatibility_tests/__snapshots__/PrivateEventStore.json +44 -0
  140. package/src/storage/backwards_compatibility_tests/__snapshots__/RecipientTaggingStore.json +18 -0
  141. package/src/storage/backwards_compatibility_tests/__snapshots__/SenderAddressBookStore.json +16 -0
  142. package/src/storage/backwards_compatibility_tests/__snapshots__/SenderTaggingStore.json +22 -0
  143. package/src/storage/backwards_compatibility_tests/__snapshots__/opened_stores.json +97 -0
  144. package/src/storage/backwards_compatibility_tests/kv_store_snapshot.ts +122 -0
  145. package/src/storage/backwards_compatibility_tests/schema_tests.ts +707 -0
  146. package/src/storage/backwards_compatibility_tests/store_spy.ts +73 -0
  147. package/src/storage/open_pxe_stores.ts +47 -0
  148. package/src/tagging/get_all_logs_by_tags.ts +4 -0
  149. package/src/tagging/index.ts +3 -2
  150. package/src/tagging/persist_sender_tagging_index_ranges.ts +57 -0
  151. package/src/tagging/recipient_sync/sync_tagged_private_logs.ts +236 -0
  152. package/src/tagging/reconcile_tagging_index_ranges.ts +102 -0
  153. package/src/tagging/sender_sync/sync_sender_tagging_indexes.ts +33 -10
  154. package/src/tagging/sender_sync/utils/get_status_change_of_pending.ts +23 -8
  155. package/dest/tagging/recipient_sync/load_private_logs_for_sender_recipient_pair.d.ts +0 -14
  156. package/dest/tagging/recipient_sync/load_private_logs_for_sender_recipient_pair.d.ts.map +0 -1
  157. package/dest/tagging/recipient_sync/load_private_logs_for_sender_recipient_pair.js +0 -85
  158. package/dest/tagging/recipient_sync/utils/load_logs_for_range.d.ts +0 -14
  159. package/dest/tagging/recipient_sync/utils/load_logs_for_range.d.ts.map +0 -1
  160. package/dest/tagging/recipient_sync/utils/load_logs_for_range.js +0 -33
  161. package/src/tagging/recipient_sync/load_private_logs_for_sender_recipient_pair.ts +0 -130
  162. package/src/tagging/recipient_sync/utils/load_logs_for_range.ts +0 -44
@@ -0,0 +1,40 @@
1
+ import type { Fr } from '@aztec/foundation/curves/bn254';
2
+ import type { FunctionSelector } from '@aztec/stdlib/abi';
3
+ import type { AztecAddress } from '@aztec/stdlib/aztec-address';
4
+
5
+ /** Information about a cross-contract utility call that requires authorization. */
6
+ export type UtilityCallAuthorizationRequest = {
7
+ /** The contract requesting the cross-contract call. */
8
+ caller: AztecAddress;
9
+ /** The target contract being called. */
10
+ target: AztecAddress;
11
+ /** The function selector being invoked on the target. */
12
+ functionSelector: FunctionSelector;
13
+ /** The name of the function being called, if known from the contract artifact. */
14
+ functionName?: string;
15
+ /** The serialized arguments passed to the function. */
16
+ args: Fr[];
17
+ /** Whether the call originates from a private or utility execution context. */
18
+ callerContext: 'private' | 'utility';
19
+ };
20
+
21
+ /** Authorization was granted. */
22
+ type Authorized = { authorized: true };
23
+
24
+ /** Authorization was denied. */
25
+ type Denied = {
26
+ authorized: false;
27
+ /** Reason for denial, included in the error message. */
28
+ reason?: string;
29
+ };
30
+
31
+ /** Result of an authorization hook evaluation. */
32
+ export type UtilityCallAuthorizationResponse = Authorized | Denied;
33
+
34
+ /**
35
+ * Hook called when a utility function attempts a cross-contract call.
36
+ * Returns a response indicating whether the call is authorized and an optional denial reason.
37
+ */
38
+ export type AuthorizeUtilityCall = (
39
+ request: UtilityCallAuthorizationRequest,
40
+ ) => Promise<UtilityCallAuthorizationResponse>;
@@ -0,0 +1,48 @@
1
+ import type { AuthorizeUtilityCall } from './authorize_utility_call.js';
2
+
3
+ /**
4
+ * Hooks that PXE invokes during client-side simulation to gate operations that the protocol
5
+ * does not restrict on its own. They give the wallet a chance to apply custom policies (e.g.
6
+ * prompting the user, consulting a dynamic allowlist, or inspecting call arguments) before the
7
+ * execution proceeds.
8
+ *
9
+ * For example, {@link authorizeUtilityCall} is called whenever a utility function makes a
10
+ * cross-contract call. A call made by a malicious contract could leak private information, so the
11
+ * hook lets the wallet decide, per-call, whether to allow it. A static allowlist would not work
12
+ * here because neither the app nor the wallet can predict ahead of time which contracts will be
13
+ * invoked during execution.
14
+ *
15
+ * Note: hooks are unrelated to authentication witnesses (authwits). Authwits are an on-chain
16
+ * mechanism where a contract verifies that a caller was authorized by a specific account; hooks
17
+ * are a client-side PXE concern that gates execution before it proceeds.
18
+ *
19
+ * @example
20
+ * ```ts
21
+ * const pxe = await PXE.create({
22
+ * // ...
23
+ * hooks: {
24
+ * authorizeUtilityCall: async (req) => {
25
+ * // Allow calls to a known helper contract, deny everything else.
26
+ * return req.target.equals(trustedHelper)
27
+ * ? { authorized: true }
28
+ * : { authorized: false, reason: 'Unknown target' };
29
+ * },
30
+ * },
31
+ * });
32
+ * ```
33
+ */
34
+ export interface ExecutionHooks {
35
+ /** Called when a contract attempts a cross-contract utility call. */
36
+ authorizeUtilityCall: AuthorizeUtilityCall;
37
+ }
38
+
39
+ /**
40
+ * Builds an {@link ExecutionHooks} from individually-constructed hook callbacks. Returns `undefined`
41
+ * when every field is absent, so callers can unconditionally pass the result as `hooks`.
42
+ */
43
+ export function composeHooks(partial: Partial<ExecutionHooks>): ExecutionHooks | undefined {
44
+ if (Object.values(partial).every(v => v === undefined)) {
45
+ return undefined;
46
+ }
47
+ return partial as ExecutionHooks;
48
+ }
@@ -0,0 +1,7 @@
1
+ export type {
2
+ AuthorizeUtilityCall,
3
+ UtilityCallAuthorizationRequest,
4
+ UtilityCallAuthorizationResponse,
5
+ } from './authorize_utility_call.js';
6
+ export type { ExecutionHooks } from './execution_hooks.js';
7
+ export { composeHooks } from './execution_hooks.js';
@@ -3,7 +3,12 @@ import type { KeyStore } from '@aztec/key-store';
3
3
  import { AztecAddress } from '@aztec/stdlib/aztec-address';
4
4
  import type { L2TipsProvider } from '@aztec/stdlib/block';
5
5
  import type { AztecNode } from '@aztec/stdlib/interfaces/server';
6
- import { ExtendedDirectionalAppTaggingSecret, PendingTaggedLog, SiloedTag, Tag } from '@aztec/stdlib/logs';
6
+ import {
7
+ ExtendedDirectionalAppTaggingSecret,
8
+ PendingTaggedLog,
9
+ SiloedTag,
10
+ type TxScopedL2Log,
11
+ } from '@aztec/stdlib/logs';
7
12
  import type { BlockHeader } from '@aztec/stdlib/tx';
8
13
 
9
14
  import type { LogRetrievalRequest } from '../contract_function_simulator/noir-structs/log_retrieval_request.js';
@@ -14,7 +19,7 @@ import type { SenderAddressBookStore } from '../storage/tagging_store/sender_add
14
19
  import {
15
20
  getAllPrivateLogsByTags,
16
21
  getAllPublicLogsByTagsFromContract,
17
- loadPrivateLogsForSenderRecipientPair,
22
+ syncTaggedPrivateLogs,
18
23
  } from '../tagging/index.js';
19
24
 
20
25
  export class LogService {
@@ -44,62 +49,46 @@ export class LogService {
44
49
  }
45
50
  }
46
51
 
47
- return await Promise.all(
48
- logRetrievalRequests.map(async request => {
49
- const [publicLog, privateLog] = await Promise.all([
50
- this.#getPublicLogByTag(request.tag, request.contractAddress),
51
- this.#getPrivateLogByTag(await SiloedTag.computeFromTagAndApp(request.tag, request.contractAddress)),
52
- ]);
53
-
54
- if (publicLog !== null && privateLog !== null) {
55
- this.log.warn(
56
- `Found both a public and private log for tag ${request.tag} from contract ${request.contractAddress}. This may indicate a contract bug. Returning the public log.`,
57
- );
58
- }
59
-
60
- return publicLog ?? privateLog;
61
- }),
62
- );
63
- }
52
+ if (logRetrievalRequests.length === 0) {
53
+ return [];
54
+ }
64
55
 
65
- async #getPublicLogByTag(tag: Tag, contractAddress: AztecAddress): Promise<LogRetrievalResponse | null> {
66
56
  const anchorBlockHash = await this.anchorBlockHeader.hash();
67
- const allLogsPerTag = await getAllPublicLogsByTagsFromContract(
68
- this.aztecNode,
69
- contractAddress,
70
- [tag],
71
- anchorBlockHash,
57
+ const tags = logRetrievalRequests.map(r => r.tag);
58
+ const siloedTags = await Promise.all(
59
+ logRetrievalRequests.map(r => SiloedTag.computeFromTagAndApp(r.tag, r.contractAddress)),
72
60
  );
73
- const logsForTag = allLogsPerTag[0];
74
61
 
75
- if (logsForTag.length === 0) {
76
- return null;
77
- } else if (logsForTag.length > 1) {
78
- this.log.warn(
79
- `Expected at most 1 public log for tag ${tag} and contract ${contractAddress.toString()}, got ${logsForTag.length}. This may indicate a contract bug. Returning the first log.`,
62
+ const [allPublicLogsPerTag, allPrivateLogsPerTag] = await Promise.all([
63
+ getAllPublicLogsByTagsFromContract(this.aztecNode, contractAddress, tags, anchorBlockHash),
64
+ getAllPrivateLogsByTags(this.aztecNode, siloedTags, anchorBlockHash),
65
+ ]);
66
+
67
+ return logRetrievalRequests.map((request, i) => {
68
+ const publicLog = this.#extractSingleLog(
69
+ allPublicLogsPerTag[i],
70
+ `public log for tag ${request.tag} and contract ${request.contractAddress.toString()}`,
80
71
  );
81
- }
72
+ const privateLog = this.#extractSingleLog(allPrivateLogsPerTag[i], `private log for tag ${siloedTags[i]}`);
82
73
 
83
- const scopedLog = logsForTag[0];
74
+ if (publicLog !== null && privateLog !== null) {
75
+ this.log.warn(
76
+ `Found both a public and private log for tag ${request.tag} from contract ${request.contractAddress}. This may indicate a contract bug. Returning the public log.`,
77
+ );
78
+ }
84
79
 
85
- return new LogRetrievalResponse(
86
- scopedLog.logData.slice(1), // Skip the tag
87
- scopedLog.txHash,
88
- scopedLog.noteHashes,
89
- scopedLog.firstNullifier,
90
- );
80
+ return publicLog ?? privateLog;
81
+ });
91
82
  }
92
83
 
93
- async #getPrivateLogByTag(siloedTag: SiloedTag): Promise<LogRetrievalResponse | null> {
94
- const anchorBlockHash = await this.anchorBlockHeader.hash();
95
- const allLogsPerTag = await getAllPrivateLogsByTags(this.aztecNode, [siloedTag], anchorBlockHash);
96
- const logsForTag = allLogsPerTag[0];
97
-
84
+ #extractSingleLog(logsForTag: TxScopedL2Log[], description: string): LogRetrievalResponse | null {
98
85
  if (logsForTag.length === 0) {
99
86
  return null;
100
- } else if (logsForTag.length > 1) {
87
+ }
88
+
89
+ if (logsForTag.length > 1) {
101
90
  this.log.warn(
102
- `Expected at most 1 private log for tag ${siloedTag}, got ${logsForTag.length}. This may indicate a contract bug. Returning the first log.`,
91
+ `Expected at most 1 ${description}, got ${logsForTag.length}. This may indicate a contract bug. Returning the first log.`,
103
92
  );
104
93
  }
105
94
 
@@ -116,37 +105,23 @@ export class LogService {
116
105
  public async fetchTaggedLogs(contractAddress: AztecAddress, recipient: AztecAddress): Promise<PendingTaggedLog[]> {
117
106
  this.log.verbose(`Fetching tagged logs for ${contractAddress.toString()}`);
118
107
 
119
- // We only load logs from block up to and including the anchor block number
120
- const anchorBlockNumber = this.anchorBlockHeader.getBlockNumber();
121
- const anchorBlockHash = await this.anchorBlockHeader.hash();
122
-
123
108
  const l2Tips = await this.l2TipsStore.getL2Tips();
124
- const currentTimestamp = this.anchorBlockHeader.globalVariables.timestamp;
125
109
  // Get all secrets for this recipient (one per sender)
126
110
  const secrets = await this.#getSecretsForSenders(contractAddress, recipient);
127
111
 
128
- // Load logs for all sender-recipient pairs in parallel
129
- const logArrays = await Promise.all(
130
- secrets.map(secret =>
131
- loadPrivateLogsForSenderRecipientPair(
132
- secret,
133
- this.aztecNode,
134
- this.recipientTaggingStore,
135
- anchorBlockNumber,
136
- anchorBlockHash,
137
- currentTimestamp,
138
- l2Tips.finalized.block.number,
139
- this.jobId,
140
- ),
141
- ),
112
+ const logs = await syncTaggedPrivateLogs(
113
+ secrets,
114
+ this.aztecNode,
115
+ this.recipientTaggingStore,
116
+ this.anchorBlockHeader,
117
+ l2Tips.finalized.block.number,
118
+ this.jobId,
142
119
  );
143
120
 
144
- return logArrays
145
- .flat()
146
- .map(
147
- scopedLog =>
148
- new PendingTaggedLog(scopedLog.logData, scopedLog.txHash, scopedLog.noteHashes, scopedLog.firstNullifier),
149
- );
121
+ return logs.map(
122
+ scopedLog =>
123
+ new PendingTaggedLog(scopedLog.logData, scopedLog.txHash, scopedLog.noteHashes, scopedLog.firstNullifier),
124
+ );
150
125
  }
151
126
 
152
127
  async #getSecretsForSenders(
@@ -1,7 +1,8 @@
1
+ import { uniqueBy } from '@aztec/foundation/collection';
1
2
  import { Fr } from '@aztec/foundation/curves/bn254';
2
3
  import type { AztecNode } from '@aztec/stdlib/interfaces/server';
3
4
  import { MessageContext } from '@aztec/stdlib/logs';
4
- import { TxHash } from '@aztec/stdlib/tx';
5
+ import { type IndexedTxEffect, TxHash } from '@aztec/stdlib/tx';
5
6
 
6
7
  /** Resolves transaction hashes into the context needed to process messages. */
7
8
  export class MessageContextService {
@@ -14,31 +15,31 @@ export class MessageContextService {
14
15
  * process messages that originated from that transaction. Returns `null` for tx hashes that are zero, not yet
15
16
  * available, or in blocks beyond the anchor block.
16
17
  */
17
- getMessageContextsByTxHash(txHashes: Fr[], anchorBlockNumber: number): Promise<(MessageContext | null)[]> {
18
- // TODO: optimize, we might be hitting the node to get the same txHash repeatedly
19
- return Promise.all(
20
- txHashes.map(async txHashField => {
21
- // A zero tx hash indicates a tx-less offchain message (e.g. one not tied to any onchain transaction).
22
- // These messages don't have a transaction context to resolve, so we return null.
23
- if (txHashField.isZero()) {
24
- return null;
25
- }
18
+ async getMessageContextsByTxHash(txHashes: Fr[], anchorBlockNumber: number): Promise<(MessageContext | null)[]> {
19
+ const nonZeroTxHashes = txHashes.filter(h => !h.isZero()).map(h => TxHash.fromField(h));
20
+ const uniqueTxHashes = uniqueBy(nonZeroTxHashes, h => h.toString());
21
+ const fetched = await Promise.all(uniqueTxHashes.map(h => this.aztecNode.getTxEffect(h)));
22
+ const txEffects = new Map(
23
+ uniqueTxHashes
24
+ .map((h, i): [string, IndexedTxEffect | undefined] => [h.toString(), fetched[i]])
25
+ .filter((entry): entry is [string, IndexedTxEffect] => entry[1] !== undefined),
26
+ );
26
27
 
27
- const txHash = TxHash.fromField(txHashField);
28
- const txEffect = await this.aztecNode.getTxEffect(txHash);
29
- if (!txEffect || txEffect.l2BlockNumber > anchorBlockNumber) {
30
- return null;
31
- }
28
+ return txHashes.map(txHashField => {
29
+ const txHash = TxHash.fromField(txHashField);
30
+ const txEffect = txEffects.get(txHash.toString());
31
+ if (!txEffect || txEffect.l2BlockNumber > anchorBlockNumber) {
32
+ return null;
33
+ }
32
34
 
33
- // Every tx has at least one nullifier (the first nullifier derived from the tx hash). Hitting this condition
34
- // would mean a buggy node, but since we need to access data.nullifiers[0], the defensive check does no harm.
35
- const data = txEffect.data;
36
- if (data.nullifiers.length === 0) {
37
- throw new Error(`Tx effect for ${txHash} has no nullifiers`);
38
- }
35
+ // Every tx has at least one nullifier (the first nullifier derived from the tx hash). Hitting this condition
36
+ // would mean a buggy node, but since we need to access data.nullifiers[0], the defensive check does no harm.
37
+ const data = txEffect.data;
38
+ if (data.nullifiers.length === 0) {
39
+ throw new Error(`Tx effect for ${txHash} has no nullifiers`);
40
+ }
39
41
 
40
- return new MessageContext(data.txHash, data.noteHashes, data.nullifiers[0]);
41
- }),
42
- );
42
+ return new MessageContext(data.txHash, data.noteHashes, data.nullifiers[0]);
43
+ });
43
44
  }
44
45
  }
@@ -1,12 +1,14 @@
1
+ import { chunk } from '@aztec/foundation/collection';
1
2
  import { Fr } from '@aztec/foundation/curves/bn254';
2
3
  import type { AztecAddress } from '@aztec/stdlib/aztec-address';
3
- import type { DataInBlock } from '@aztec/stdlib/block';
4
+ import { BlockHash, type DataInBlock } from '@aztec/stdlib/block';
4
5
  import { computeUniqueNoteHash, siloNoteHash, siloNullifier } from '@aztec/stdlib/hash';
5
6
  import { type AztecNode, MAX_RPC_LEN } from '@aztec/stdlib/interfaces/client';
6
7
  import { Note, NoteDao, NoteStatus } from '@aztec/stdlib/note';
7
8
  import { MerkleTreeId } from '@aztec/stdlib/trees';
8
- import type { BlockHeader, TxHash } from '@aztec/stdlib/tx';
9
+ import type { BlockHeader, IndexedTxEffect } from '@aztec/stdlib/tx';
9
10
 
11
+ import type { NoteValidationRequest } from '../contract_function_simulator/noir-structs/note_validation_request.js';
10
12
  import type { NoteStore } from '../storage/note_store/note_store.js';
11
13
 
12
14
  export class NoteService {
@@ -80,24 +82,7 @@ export class NoteService {
80
82
  }
81
83
 
82
84
  const nullifiersToCheck = contractNotes.map(note => note.siloedNullifier);
83
- const nullifierBatches = nullifiersToCheck.reduce(
84
- (acc, nullifier) => {
85
- if (acc[acc.length - 1].length < MAX_RPC_LEN) {
86
- acc[acc.length - 1].push(nullifier);
87
- } else {
88
- acc.push([nullifier]);
89
- }
90
- return acc;
91
- },
92
- [[]] as Fr[][],
93
- );
94
- const nullifierIndexes = (
95
- await Promise.all(
96
- nullifierBatches.map(batch =>
97
- this.aztecNode.findLeavesIndexes(anchorBlockHash, MerkleTreeId.NULLIFIER_TREE, batch),
98
- ),
99
- )
100
- ).flat();
85
+ const nullifierIndexes = await this.#findNullifierIndexes(anchorBlockHash, nullifiersToCheck);
101
86
 
102
87
  const foundNullifiers = nullifiersToCheck
103
88
  .map((nullifier, i) => {
@@ -110,30 +95,34 @@ export class NoteService {
110
95
  await this.noteStore.applyNullifiers(foundNullifiers, this.jobId);
111
96
  }
112
97
 
113
- public async validateAndStoreNote(
114
- contractAddress: AztecAddress,
115
- owner: AztecAddress,
116
- storageSlot: Fr,
117
- randomness: Fr,
118
- noteNonce: Fr,
119
- content: Fr[],
120
- noteHash: Fr,
121
- nullifier: Fr,
122
- txHash: TxHash,
98
+ /**
99
+ * Validates and stores a batch of notes against pre-fetched tx effects.
100
+ *
101
+ * For each request we must verify that:
102
+ * - the note actually exists in the corresponding tx effect (and thus in the note hash tree), and
103
+ * - the note has not already been nullified.
104
+ *
105
+ * Failing to do either would result in circuits getting either non-existent notes and failing to produce inclusion
106
+ * proofs for them, or getting nullified notes and producing duplicate nullifiers, both of which are catastrophic
107
+ * failure modes.
108
+ *
109
+ * Note that adding a note and removing it is *not* equivalent to never adding it in the first place. A nullifier
110
+ * emitted in a block that comes after note creation might result in the note being de-nullified by a chain reorg,
111
+ * so we must store both the note hash and nullifier block information.
112
+ *
113
+ * @param requests - The notes to validate and store.
114
+ * @param scope - The scope under which the notes are being stored.
115
+ * @param txEffects - Pre-fetched tx effects keyed by `TxHash.toString()`. Must contain entries for every request's
116
+ * txHash; missing entries are treated as a node bug and cause an error.
117
+ */
118
+ public async validateAndStoreNotes(
119
+ requests: NoteValidationRequest[],
123
120
  scope: AztecAddress,
121
+ txEffects: Map<string, IndexedTxEffect>,
124
122
  ): Promise<void> {
125
- // We are going to store the new note in the NoteStore, which will let us later return it via `getNotes`.
126
- // There's two things we need to check before we do this however:
127
- // - we must make sure the note does actually exist in the note hash tree
128
- // - we need to check if the note has already been nullified
129
- //
130
- // Failing to do either of the above would result in circuits getting either non-existent notes and failing to
131
- // produce inclusion proofs for them, or getting nullified notes and producing duplicate nullifiers, both of which
132
- // are catastrophic failure modes.
133
- //
134
- // Note that adding a note and removing it is *not* equivalent to never adding it in the first place. A nullifier
135
- // emitted in a block that comes after note creation might result in the note being de-nullified by a chain reorg,
136
- // so we must store both the note hash and nullifier block information.
123
+ if (requests.length === 0) {
124
+ return;
125
+ }
137
126
 
138
127
  // We avoid making node queries at 'latest' since we don't want to process notes or nullifiers that only exist ahead
139
128
  // in time of the locally synced state.
@@ -146,61 +135,96 @@ export class NoteService {
146
135
 
147
136
  // By computing siloed and unique note hashes ourselves we prevent contracts from interfering with the note storage
148
137
  // of other contracts, which would constitute a security breach.
149
- const uniqueNoteHash = await computeUniqueNoteHash(noteNonce, await siloNoteHash(contractAddress, noteHash));
150
- const siloedNullifier = await siloNullifier(contractAddress, nullifier);
151
-
152
- const [txEffect, [nullifierIndex]] = await Promise.all([
153
- this.aztecNode.getTxEffect(txHash),
154
- this.aztecNode.findLeavesIndexes(anchorBlockHash, MerkleTreeId.NULLIFIER_TREE, [siloedNullifier]),
155
- ]);
156
- if (!txEffect) {
157
- // We error out instead of just logging a warning and skipping the note because this would indicate a bug. This
158
- // is because the node has already served info about this tx either when obtaining the log (TxScopedL2Log contain
159
- // tx info) or when getting metadata for the offchain message (before the message got passed to `process_log`).
160
- throw new Error(`Could not find tx effect for tx hash ${txHash} when processing a note.`);
161
- }
138
+ const computed = await Promise.all(
139
+ requests.map(async ({ contractAddress, noteHash, nullifier, noteNonce }) => {
140
+ const [siloedNoteHash, siloedNullifier] = await Promise.all([
141
+ siloNoteHash(contractAddress, noteHash),
142
+ siloNullifier(contractAddress, nullifier),
143
+ ]);
144
+ const uniqueNoteHash = await computeUniqueNoteHash(noteNonce, siloedNoteHash);
145
+ return { uniqueNoteHash, siloedNullifier };
146
+ }),
147
+ );
162
148
 
163
- if (txEffect.l2BlockNumber > anchorBlockNumber) {
164
- // If the message was delivered onchain, this would indicate a bug: log sync should never load logs from blocks
165
- // newer than the anchor block. If the note came via an offchain message, it would likely also be a bug, since we
166
- // sync a new anchor block before calling `process_message`. For this not to be a bug, the message would need to
167
- // come from a newer block than the anchor served by the node, implying the node isn't properly synced.
168
- // We therefore error out here rather than assuming the offchain message was constructed by a malicious
169
- // sender with the intention of bricking recipient's PXE (if we assumed that we would just ignore the message).
170
- throw new Error(
171
- `Obtained a newer tx effect for ${txHash} for a note validation request than the anchor block ${anchorBlockNumber}. This is a bug as we should not ever be processing a note from a newer block than the anchor block.`,
149
+ const nullifierIndexes = await this.#findNullifierIndexes(
150
+ anchorBlockHash,
151
+ computed.map(c => c.siloedNullifier),
152
+ );
153
+
154
+ const noteDaos: NoteDao[] = [];
155
+ const foundNullifiers: DataInBlock<Fr>[] = [];
156
+
157
+ for (let i = 0; i < requests.length; i++) {
158
+ const { contractAddress, owner, storageSlot, randomness, noteNonce, content, noteHash, txHash } = requests[i];
159
+ const { uniqueNoteHash, siloedNullifier } = computed[i];
160
+ const nullifierIndex = nullifierIndexes[i];
161
+
162
+ const txEffect = txEffects.get(txHash.toString());
163
+ if (!txEffect) {
164
+ // We error out instead of just logging a warning and skipping the note because this would indicate a bug. This
165
+ // is because the node has already served info about this tx either when obtaining the log (TxScopedL2Log
166
+ // contain tx info) or when getting metadata for the offchain message (before the message got passed to
167
+ // `process_log`).
168
+ throw new Error(`Could not find tx effect for tx hash ${txHash} when processing a note.`);
169
+ }
170
+
171
+ if (txEffect.l2BlockNumber > anchorBlockNumber) {
172
+ // If the message was delivered onchain, this would indicate a bug: log sync should never load logs from blocks
173
+ // newer than the anchor block. If the note came via an offchain message, it would likely also be a bug, since
174
+ // we sync a new anchor block before calling `process_message`. For this not to be a bug, the message would
175
+ // need to come from a newer block than the anchor served by the node, implying the node isn't properly synced.
176
+ // We therefore error out here rather than assuming the offchain message was constructed by a malicious
177
+ // sender with the intention of bricking recipient's PXE (if we assumed that we would just ignore the message).
178
+ throw new Error(
179
+ `Obtained a newer tx effect for ${txHash} for a note validation request than the anchor block ${anchorBlockNumber}. This is a bug as we should not ever be processing a note from a newer block than the anchor block.`,
180
+ );
181
+ }
182
+
183
+ // Find the index of the note hash in the noteHashes array to determine note ordering within the tx
184
+ const noteIndexInTx = txEffect.data.noteHashes.findIndex(nh => nh.equals(uniqueNoteHash));
185
+ if (noteIndexInTx === -1) {
186
+ // Similar to the comment above - we error out as this would indicate a bug in nonce discovery.
187
+ throw new Error(`Note hash ${noteHash} (uniqued as ${uniqueNoteHash}) is not present in tx ${txHash}`);
188
+ }
189
+
190
+ noteDaos.push(
191
+ new NoteDao(
192
+ new Note(content),
193
+ contractAddress,
194
+ owner,
195
+ storageSlot,
196
+ randomness,
197
+ noteNonce,
198
+ noteHash,
199
+ siloedNullifier,
200
+ txHash,
201
+ txEffect.l2BlockNumber,
202
+ txEffect.l2BlockHash.toString(),
203
+ txEffect.txIndexInBlock,
204
+ noteIndexInTx,
205
+ ),
172
206
  );
173
- }
174
207
 
175
- // Find the index of the note hash in the noteHashes array to determine note ordering within the tx
176
- const noteIndexInTx = txEffect.data.noteHashes.findIndex(nh => nh.equals(uniqueNoteHash));
177
- if (noteIndexInTx === -1) {
178
- // Similar to the comment above - we error out as this would indicate a bug in nonce discovery.
179
- throw new Error(`Note hash ${noteHash} (uniqued as ${uniqueNoteHash}) is not present in tx ${txHash}`);
208
+ if (nullifierIndex !== undefined) {
209
+ // We found a nullifier index which implies that the note has already been nullified.
210
+ const { data: _, ...blockHashAndNum } = nullifierIndex;
211
+ foundNullifiers.push({ data: siloedNullifier, ...blockHashAndNum });
212
+ }
180
213
  }
181
214
 
182
- const noteDao = new NoteDao(
183
- new Note(content),
184
- contractAddress,
185
- owner,
186
- storageSlot,
187
- randomness,
188
- noteNonce,
189
- noteHash,
190
- siloedNullifier,
191
- txHash,
192
- txEffect.l2BlockNumber,
193
- txEffect.l2BlockHash.toString(),
194
- txEffect.txIndexInBlock,
195
- noteIndexInTx,
196
- );
197
-
198
- await this.noteStore.addNotes([noteDao], scope, this.jobId);
215
+ await this.noteStore.addNotes(noteDaos, scope, this.jobId);
199
216
 
200
- if (nullifierIndex !== undefined) {
201
- // We found nullifier index which implies that the note has already been nullified.
202
- const { data: _, ...blockHashAndNum } = nullifierIndex;
203
- await this.noteStore.applyNullifiers([{ data: siloedNullifier, ...blockHashAndNum }], this.jobId);
217
+ if (foundNullifiers.length > 0) {
218
+ await this.noteStore.applyNullifiers(foundNullifiers, this.jobId);
204
219
  }
205
220
  }
221
+
222
+ async #findNullifierIndexes(anchorBlockHash: BlockHash, siloedNullifiers: Fr[]) {
223
+ const batches = chunk(siloedNullifiers, MAX_RPC_LEN);
224
+ return (
225
+ await Promise.all(
226
+ batches.map(batch => this.aztecNode.findLeavesIndexes(anchorBlockHash, MerkleTreeId.NULLIFIER_TREE, batch)),
227
+ )
228
+ ).flat();
229
+ }
206
230
  }
@@ -11,7 +11,7 @@
11
11
  /// if AZTEC_NR_MINOR > PXE_MINOR because if a contract is updated to use a newer Aztec.nr dependency without actually
12
12
  /// using any of the new oracles then there is no reason to throw.
13
13
  export const ORACLE_VERSION_MAJOR = 22;
14
- export const ORACLE_VERSION_MINOR = 1;
14
+ export const ORACLE_VERSION_MINOR = 3;
15
15
 
16
16
  /// This hash is computed from the Oracle interface and is used to detect when that interface changes. When it does,
17
17
  /// you need to either:
@@ -19,4 +19,4 @@ export const ORACLE_VERSION_MINOR = 1;
19
19
  /// - increment only `ORACLE_VERSION_MINOR` if the change is additive (a new oracle was added).
20
20
  ///
21
21
  /// These constants must be kept in sync between this file and `noir-projects/aztec-nr/aztec/src/oracle/version.nr`.
22
- export const ORACLE_INTERFACE_HASH = 'efafa0db2cc1f94e26d794d0079c8f71115261df0c3d0fa8cb5b64f17a12db92';
22
+ export const ORACLE_INTERFACE_HASH = '0649632102f27d1411749e46733b96103eaac948914d328afc4b90d3bf6e5af5';