@aztec/pxe 0.0.1-commit.2448fdb → 0.0.1-commit.2606882

package/src/tagging/recipient_sync/sync_tagged_private_logs.ts

@@ -0,0 +1,240 @@
+import { BlockNumber } from '@aztec/foundation/branded-types';
+import { isDefined } from '@aztec/foundation/types';
+import type { BlockHash } from '@aztec/stdlib/block';
+import type { AztecNode } from '@aztec/stdlib/interfaces/client';
+import type { AppTaggingSecret, LogResult } from '@aztec/stdlib/logs';
+import { SiloedTag } from '@aztec/stdlib/logs';
+import type { BlockHeader } from '@aztec/stdlib/tx';
+
+import type { RecipientTaggingStore } from '../../storage/tagging_store/recipient_tagging_store.js';
+import { UNFINALIZED_TAGGING_INDEXES_WINDOW_LEN } from '../constants.js';
+import { getAllPrivateLogsByTags } from '../get_all_logs_by_tags.js';
+import { findHighestIndexes } from './utils/find_highest_indexes.js';
+
+/**
+ * Fetches and syncs tagged private logs for multiple sender-recipient pairs, batching tag queries across all secrets
+ * into shared RPC calls.
+ *
+ * # Explanation of how the algorithm works
+ *
+ * For each secret we sync logs that correspond to the tagging index range
+ * (highestAgedIndex, highestFinalizedIndex + WINDOW_LEN]
+ *
+ * highestAgedIndex is the highest index that was used in a tx that is included in a block at least
+ *                  `MAX_TX_LIFETIME` seconds ago.
+ * highestFinalizedIndex is the highest index that was used in a tx that is included in a finalized block.
+ *
+ * "(" denotes an open end of the range - the index is not included in the range.
+ * "]" denotes a closed end of the range - the index is included in the range.
+ *
+ * ## Explanation of highestAgedIndex
+ *
+ * highestAgedIndex is chosen such that for all tagging indexes `i <= highestAgedIndex` we know that no new logs can
+ * ever appear.
+ *
+ * This relies on the "maximum inclusion timestamp" rule enforced by the kernel and rollup circuits:
+ * - a transaction's maximum inclusion timestamp is at most `MAX_TX_LIFETIME` seconds after
+ *   the timestamp of its anchor block; and
+ * - a rollup only includes transactions whose inclusion timestamp is >= the L2 block's timestamp.
+ *
+ * Suppose some device used index `I` in a transaction anchored to block `B_N` at time `N`, and that block is now at
+ * least `MAX_TX_LIFETIME` seconds in the past. Then there is no possibility of any *other* device
+ * trying to use an index <= `I` while anchoring to a *newer* block than `B_N` because if we were anchoring to
+ * a newer block than `B_N` then we would already have seen the log with index `I` and hence the device would have
+ * chosen a larger index.
+ *    If that *other* device would anchor to a block older than `B_N` then that tx could never be included in a block
+ * because it would already have been expired.
+ *
+ * Therefore, once we see that index `I` has been used in a block that is at least `MAX_TX_LIFETIME`
+ * seconds old, we can safely stop syncing logs for all indexes <= `I` and set highestAgedIndex = `I`.
+ *
+ * ## Explanation of the upper bound `highestFinalizedIndex + WINDOW_LEN`
+ *
+ * When a sender chooses a tagging index, they will select an index that is at most `WINDOW_LEN` greater than
+ * the highest finalized index. If that index was already used, they will throw an error. For this reason we
+ * don't have to look further than `highestFinalizedIndex + WINDOW_LEN`.
+ *
+ * ## Batching across secrets
+ *
+ * Instead of running one RPC call per secret, we merge tags from all pending secrets into a single flat array,
+ * make one batched `getAllPrivateLogsByTags` call (which internally chunks at MAX_RPC_LEN), then split results
+ * back per secret using tracked offsets. Only secrets whose window advanced are kept for the next iteration.
+ */
+export async function syncTaggedPrivateLogs(
+  secrets: AppTaggingSecret[],
+  aztecNode: AztecNode,
+  taggingStore: RecipientTaggingStore,
+  anchorBlockHeader: BlockHeader,
+  finalizedBlockNumber: BlockNumber,
+  jobId: string,
+): Promise<LogResult[]> {
+  if (secrets.length === 0) {
+    return [];
+  }
+
+  const anchorBlockNumber = anchorBlockHeader.getBlockNumber();
+  const anchorBlockHash = await anchorBlockHeader.hash();
+  const currentTimestamp = anchorBlockHeader.globalVariables.timestamp;
+
+  // Read stored indexes from the db and compute the initial [start, end) range for each secret
+  let pending = await getIndexRangesForSecrets(secrets, taggingStore, jobId);
+  const allLogs: LogResult[] = [];
+
+  while (pending.length > 0) {
+    // Compute tags for all pending secrets and fetch logs in batched RPC calls
+    const logsPerSecret = await fetchLogsForSecrets(pending, aztecNode, anchorBlockNumber, anchorBlockHash);
+
+    const nextRound = await Promise.all(
+      pending.map(async (pendingSecret, i) => {
+        const logsFoundWithSecret = logsPerSecret[i];
+        if (logsFoundWithSecret.length === 0) {
+          // No logs found, no need to update indexes or advance window.
+          return undefined;
+        }
+
+        allLogs.push(...logsFoundWithSecret.map(({ log }) => log));
+
+        // Persist new indexes. If the finalized index moved forward, the window advances
+        // and we need another round for this secret.
+        return await updateIndexesAndAdvanceWindow(
+          pendingSecret,
+          logsFoundWithSecret,
+          taggingStore,
+          currentTimestamp,
+          finalizedBlockNumber,
+          jobId,
+        );
+      }),
+    );
+
+    pending = nextRound.filter(isDefined);
+  }
+
+  return allLogs;
+}
+
+/** Reads stored indexes for each secret and computes the initial index range to query. */
+function getIndexRangesForSecrets(
+  secrets: AppTaggingSecret[],
+  taggingStore: RecipientTaggingStore,
+  jobId: string,
+): Promise<PendingSecret[]> {
+  return Promise.all(
+    secrets.map(async secret => {
+      const [currentHighestAgedIndex, currentHighestFinalizedIndex] = await Promise.all([
+        taggingStore.getHighestAgedIndex(secret, jobId),
+        taggingStore.getHighestFinalizedIndex(secret, jobId),
+      ]);
+
+      const start = currentHighestAgedIndex === undefined ? 0 : currentHighestAgedIndex + 1;
+      const end = (currentHighestFinalizedIndex ?? 0) + UNFINALIZED_TAGGING_INDEXES_WINDOW_LEN + 1;
+
+      return { secret, start, end };
+    }),
+  );
+}
+
+/**
+ * Computes siloed tags for all pending secrets' index ranges, fetches logs in one batched RPC call,
+ * and returns the results grouped back per secret.
+ */
+async function fetchLogsForSecrets(
+  pending: PendingSecret[],
+  aztecNode: AztecNode,
+  anchorBlockNumber: BlockNumber,
+  anchorBlockHash: BlockHash,
+): Promise<LogWithIndex[][]> {
+  // Determine the index range for each secret
+  const indexesPerSecret = pending.map(({ start, end }) => Array.from({ length: end - start }, (_, i) => start + i));
+
+  // Compute siloed tags for all indexes
+  const tagsPerSecret = await Promise.all(
+    pending.map(({ secret }, i) =>
+      Promise.all(indexesPerSecret[i].map(index => SiloedTag.compute({ extendedSecret: secret, index }))),
+    ),
+  );
+
+  const allTags = tagsPerSecret.flat();
+
+  // getAllPrivateLogsByTags handles MAX_RPC_LEN chunking internally. Recipient sync builds `PendingTaggedLog` from
+  // each log's note hashes and first nullifier, so we opt into effects. The `toBlock` cap (anchor block + 1,
+  // exclusive) tells the node to skip any logs in blocks past the anchor — the same guard previously enforced
+  // by an in-memory filter on the response.
+  const allResults = await getAllPrivateLogsByTags(aztecNode, allTags, anchorBlockHash, {
+    includeEffects: true,
+    toBlock: BlockNumber(anchorBlockNumber + 1),
+  });
+
+  // Split flat results back per secret using the known lengths
+  const logsPerSecret: LogWithIndex[][] = [];
+  let offset = 0;
+  for (const indexes of indexesPerSecret) {
+    const logsForSecret: LogWithIndex[] = [];
+    for (let i = 0; i < indexes.length; i++) {
+      for (const log of allResults[offset + i]) {
+        logsForSecret.push({ log, taggingIndex: indexes[i] });
+      }
+    }
+    logsPerSecret.push(logsForSecret);
+    offset += indexes.length;
+  }
+
+  return logsPerSecret;
+}
+
+/**
+ * Processes a single secret's fetched logs: updates stored indexes and returns a new PendingSecret
+ * if the window needs to advance, or undefined if this secret is done.
+ */
+async function updateIndexesAndAdvanceWindow(
+  pending: PendingSecret,
+  logsWithIndexes: LogWithIndex[],
+  taggingStore: RecipientTaggingStore,
+  currentTimestamp: bigint,
+  finalizedBlockNumber: BlockNumber,
+  jobId: string,
+): Promise<PendingSecret | undefined> {
+  const { highestAgedIndex, highestFinalizedIndex } = findHighestIndexes(
+    logsWithIndexes,
+    currentTimestamp,
+    finalizedBlockNumber,
+  );
+
+  // Store updates in data provider and update local variables
+  if (highestAgedIndex !== undefined) {
+    await taggingStore.updateHighestAgedIndex(pending.secret, highestAgedIndex, jobId);
+  }
+
+  if (highestFinalizedIndex === undefined) {
+    // We have not found a new highest finalized index, so there is no need to move the window forward.
+    return undefined;
+  }
+
+  if (highestAgedIndex !== undefined && highestAgedIndex > highestFinalizedIndex) {
+    // This is just a sanity check as this should never happen.
+    throw new Error(
+      `Highest aged index (${highestAgedIndex}) must not exceed highest finalized index (${highestFinalizedIndex})`,
+    );
+  }
+
+  await taggingStore.updateHighestFinalizedIndex(pending.secret, highestFinalizedIndex, jobId);
+
+  // For the next iteration we want to look only at indexes for which we have not yet fetched logs while
+  // ensuring that we do not look further than WINDOW_LEN ahead of the highest finalized index.
+  return {
+    secret: pending.secret,
+    start: pending.end,
+    end: highestFinalizedIndex + UNFINALIZED_TAGGING_INDEXES_WINDOW_LEN + 1,
+  };
+}
+
+type PendingSecret = {
+  secret: AppTaggingSecret;
+  start: number;
+  end: number;
+};
+
+type LogWithIndex = {
+  log: LogResult;
+  taggingIndex: number;
+};

package/src/tagging/recipient_sync/utils/find_highest_indexes.ts

@@ -1,11 +1,11 @@
 import { MAX_TX_LIFETIME } from '@aztec/constants';
-import type { TxScopedL2Log } from '@aztec/stdlib/logs';
+import type { LogResult } from '@aztec/stdlib/logs';
 
 /**
  * Finds the highest aged and the highest finalized tagging indexes.
  */
 export function findHighestIndexes(
-  privateLogsWithIndexes: Array<{ log: TxScopedL2Log; taggingIndex: number }>,
+  privateLogsWithIndexes: Array<{ log: LogResult; taggingIndex: number }>,
   currentTimestamp: bigint,
   finalizedBlockNumber: number,
 ): { highestAgedIndex: number | undefined; highestFinalizedIndex: number | undefined } {

package/src/tagging/reconcile_tagging_index_ranges.ts

@@ -0,0 +1,102 @@
+import { type AppTaggingSecret, SiloedTag, type TaggingIndexRange } from '@aztec/stdlib/logs';
+
+/**
+ * Reconciles tagging index ranges recorded by the PXE during private execution against the set of siloed tags whose
+ * private logs survived to the final kernel output.
+ *
+ * Each input range is the contiguous `[lowestIndex, highestIndex]` set of indexes that the tagging index cache
+ * reserved for a given tagging secret while a tx was being executed. The kernel may then squash some of those logs
+ * (e.g. when a note is created and nullified within the same tx, taking its log with it), so the actual on-chain
+ * footprint can be a strict subset of what was reserved.
+ *
+ * For each input range, this function shrinks `[lowestIndex, highestIndex]` so that both bounds correspond to indexes
+ * that actually survived, trimming any dropped indices at the front or the back. It is possible that some interior
+ * indexes were also dropped, leaving gaps between the lowest and highest indices, but we ignore those and accept the
+ * resulting inefficiency rather than complicate the tagging model with one in which transactions may use interleaved
+ * indices.
+ *
+ * Trimming tailing indices (e.g. `highestIndex`) is highly useful as it lets us reuse those indices in future
+ * transactions. Trimming indices at the front (e.g. `lowestIndex`) is not as impactful since we will not ever use a
+ * tagging index if a larger one exists (same as with gaps), but it does help in both making the consistency check
+ * between database and transaction effects cheaper (as there's fewer logs to test) and making the database more
+ * accurately reflect reality.
+ *
+ * Ranges with no surviving indexes are dropped from the output entirely.
+ *
+ * Example scenario:
+ *   - used indexes 3 to 7, kerel squashed indexes 3, 5, and 7:
+ *      - range: [3, 7]
+ *      - survived: set(3, 5, 7)
+ *      - output: [4, 6]  (trimmed from both ends, gap at 5 is tolerated)
+ *
+ * @param ranges - The tagging index ranges as recorded during private execution (pre-squash).
+ * @param survivingTags - The set of siloed tag values (as strings) of private logs that survived kernel squashing.
+ * @returns The reconciled ranges, with bounds tightened to surviving indexes and fully-squashed ranges removed.
+ */
+export async function reconcileTaggingIndexRangesAgainstSurvivingTags(
+  ranges: TaggingIndexRange[],
+  survivingTags: Set<string>,
+): Promise<TaggingIndexRange[]> {
+  const reconciled: TaggingIndexRange[] = [];
+
+  for (const range of ranges) {
+    const newLowestIndex = await findFirstSurvivingIndex(
+      range.extendedSecret,
+      range.lowestIndex,
+      range.highestIndex,
+      survivingTags,
+    );
+    if (newLowestIndex === undefined) {
+      // No index in this range corresponds to a surviving log: the entire range was squashed.
+      continue;
+    }
+
+    // newLowestIndex is itself a survivor, so the backward scan is guaranteed to find at least that index.
+    const newHighestIndex = await findLastSurvivingIndex(
+      range.extendedSecret,
+      newLowestIndex,
+      range.highestIndex,
+      survivingTags,
+    );
+
+    reconciled.push({
+      extendedSecret: range.extendedSecret,
+      lowestIndex: newLowestIndex,
+      highestIndex: newHighestIndex!,
+    });
+  }
+
+  return reconciled;
+}
+
+/** Scans `[start, end]` ascending and returns the first index whose siloed tag is in `survivingTags`. */
+async function findFirstSurvivingIndex(
+  secret: AppTaggingSecret,
+  start: number,
+  end: number,
+  survivingTags: Set<string>,
+): Promise<number | undefined> {
+  for (let index = start; index <= end; index++) {
+    const tag = await SiloedTag.compute({ extendedSecret: secret, index });
+    if (survivingTags.has(tag.value.toString())) {
+      return index;
+    }
+  }
+  return undefined;
+}
+
+/** Scans `[start, end]` descending and returns the first index whose siloed tag is in `survivingTags`. */
+async function findLastSurvivingIndex(
+  secret: AppTaggingSecret,
+  start: number,
+  end: number,
+  survivingTags: Set<string>,
+): Promise<number | undefined> {
+  for (let index = end; index >= start; index--) {
+    const tag = await SiloedTag.compute({ extendedSecret: secret, index });
+    if (survivingTags.has(tag.value.toString())) {
+      return index;
+    }
+  }
+  return undefined;
+}

package/src/tagging/sender_sync/sync_sender_tagging_indexes.ts

@@ -1,17 +1,20 @@
 import type { BlockHash } from '@aztec/stdlib/block';
 import type { AztecNode } from '@aztec/stdlib/interfaces/server';
-import type { ExtendedDirectionalAppTaggingSecret } from '@aztec/stdlib/logs';
+import type { AppTaggingSecret } from '@aztec/stdlib/logs';
 
 import type { SenderTaggingStore } from '../../storage/tagging_store/sender_tagging_store.js';
 import { UNFINALIZED_TAGGING_INDEXES_WINDOW_LEN } from '../constants.js';
-import { getStatusChangeOfPending } from './utils/get_status_change_of_pending.js';
+import {
+  EMPTY_STATUS_CHANGE,
+  getStatusChangeOfPending,
+  mergeStatusChanges,
+} from './utils/get_status_change_of_pending.js';
 import { loadAndStoreNewTaggingIndexes } from './utils/load_and_store_new_tagging_indexes.js';
 
 /**
  * Syncs tagging indexes. This function needs to be called whenever a private log is being sent.
  *
- * @param secret - The secret that's unique for (sender, recipient, app) tuple while the direction of
- * sender -> recipient matters.
+ * @param secret - The sender-side tagging `AppTaggingSecret`.
  * @remarks When syncing the indexes as sender we don't care about the log contents - we only care about the highest
  * pending and highest finalized indexes as that guides the next index choice when sending a log. The next index choice
  * is simply the highest pending index plus one (or finalized if pending is undefined).
@@ -19,7 +22,7 @@ import { loadAndStoreNewTaggingIndexes } from './utils/load_and_store_new_taggin
  * updates its status accordingly.
  */
 export async function syncSenderTaggingIndexes(
-  secret: ExtendedDirectionalAppTaggingSecret,
+  secret: AppTaggingSecret,
   aztecNode: AztecNode,
   taggingStore: SenderTaggingStore,
   anchorBlockHash: BlockHash,
@@ -52,36 +55,55 @@ export async function syncSenderTaggingIndexes(
   let newFinalizedIndex = undefined;
 
   while (true) {
-    // Load and store indexes for the current window. These indexes may already exist in the database if txs using
-    // them were previously sent from this PXE. Any duplicates are handled by the tagging data provider.
-    await loadAndStoreNewTaggingIndexes(secret, start, end, aztecNode, taggingStore, anchorBlockHash, jobId);
+    // Pending tx hashes already in the store for this window (from prior syncs or txs this PXE itself sent).
+    // Reading these before issuing any RPC lets us fetch their receipts in parallel with the logs query below.
+    const knownPendingTxHashes = await taggingStore.getTxHashesOfPendingIndexes(secret, start, end, jobId);
 
-    // Retrieve all indexes within the current window from storage and update their status accordingly.
-    const pendingTxHashes = await taggingStore.getTxHashesOfPendingIndexes(secret, start, end, jobId);
-    if (pendingTxHashes.length === 0) {
+    // Fire the logs query and the known-pending receipts query in parallel
+    const [, statusOfKnown] = await Promise.all([
+      loadAndStoreNewTaggingIndexes(secret, start, end, aztecNode, taggingStore, anchorBlockHash, jobId),
+      knownPendingTxHashes.length > 0
+        ? getStatusChangeOfPending(knownPendingTxHashes, aztecNode)
+        : Promise.resolve(EMPTY_STATUS_CHANGE),
+    ]);
+
+    // Re-read pending tx hashes after the logs query writes any newly-discovered ones to the store.
+    const allPendingTxHashes = await taggingStore.getTxHashesOfPendingIndexes(secret, start, end, jobId);
+    if (allPendingTxHashes.length === 0) {
       break;
     }
 
-    const { txHashesToFinalize, txHashesToDrop, txHashesWithExecutionReverted } = await getStatusChangeOfPending(
-      pendingTxHashes,
-      aztecNode,
+    // Receipts for pending tx hashes that the logs query just surfaced still need a sequential follow-up call.
+    // `storePendingIndexes` is idempotent on (secret, txHash), so a re-discovered hash stays classified as known
+    // and is not re-fetched here.
+    const knownSet = new Set(knownPendingTxHashes.map(h => h.toString()));
+    const newPendingTxHashes = allPendingTxHashes.filter(h => !knownSet.has(h.toString()));
+
+    const statusOfNew =
+      newPendingTxHashes.length > 0
+        ? await getStatusChangeOfPending(newPendingTxHashes, aztecNode)
+        : EMPTY_STATUS_CHANGE;
+
+    const { txHashesToFinalize, txHashesToDrop, txHashesWithExecutionReverted } = mergeStatusChanges(
+      statusOfKnown,
+      statusOfNew,
     );
 
     await taggingStore.dropPendingIndexes(txHashesToDrop, jobId);
     await taggingStore.finalizePendingIndexes(txHashesToFinalize, jobId);
 
     if (txHashesWithExecutionReverted.length > 0) {
-      const indexedTxEffects = await Promise.all(
-        txHashesWithExecutionReverted.map(txHash => aztecNode.getTxEffect(txHash)),
+      const receipts = await Promise.all(
+        txHashesWithExecutionReverted.map(txHash => aztecNode.getTxReceipt(txHash, { includeTxEffect: true })),
       );
-      for (const indexedTxEffect of indexedTxEffects) {
-        if (indexedTxEffect === undefined) {
+      for (const receipt of receipts) {
+        if (!receipt.isMined() || !receipt.txEffect) {
           throw new Error(
             'TxEffect not found for execution-reverted tx. This is either a bug or a reorg has occurred.',
           );
         }
 
-        await taggingStore.finalizePendingIndexesOfAPartiallyRevertedTx(indexedTxEffect.data, jobId);
+        await taggingStore.finalizePendingIndexesOfAPartiallyRevertedTx(receipt.txEffect, jobId);
       }
     }
 

package/src/tagging/sender_sync/utils/get_status_change_of_pending.ts

@@ -1,18 +1,33 @@
 import type { AztecNode } from '@aztec/stdlib/interfaces/server';
 import { TxHash, TxStatus } from '@aztec/stdlib/tx';
 
+/** Classification of a batch of pending tx hashes by the status change implied by their receipts. */
+export type StatusChange = {
+  txHashesToFinalize: TxHash[];
+  txHashesToDrop: TxHash[];
+  txHashesWithExecutionReverted: TxHash[];
+};
+
+export const EMPTY_STATUS_CHANGE: StatusChange = {
+  txHashesToFinalize: [],
+  txHashesToDrop: [],
+  txHashesWithExecutionReverted: [],
+};
+
+/** Concatenates two status changes field-by-field. */
+export function mergeStatusChanges(a: StatusChange, b: StatusChange): StatusChange {
+  return {
+    txHashesToFinalize: [...a.txHashesToFinalize, ...b.txHashesToFinalize],
+    txHashesToDrop: [...a.txHashesToDrop, ...b.txHashesToDrop],
+    txHashesWithExecutionReverted: [...a.txHashesWithExecutionReverted, ...b.txHashesWithExecutionReverted],
+  };
+}
+
 /**
  * Based on receipts obtained from `aztecNode` returns which pending transactions changed their status to finalized,
  * dropped, or execution-reverted (but mined).
  */
-export async function getStatusChangeOfPending(
-  pending: TxHash[],
-  aztecNode: AztecNode,
-): Promise<{
-  txHashesToFinalize: TxHash[];
-  txHashesToDrop: TxHash[];
-  txHashesWithExecutionReverted: TxHash[];
-}> {
+export async function getStatusChangeOfPending(pending: TxHash[], aztecNode: AztecNode): Promise<StatusChange> {
   // Get receipts for all pending tx hashes.
   const receipts = await Promise.all(pending.map(pendingTxHash => aztecNode.getTxReceipt(pendingTxHash)));
 

package/src/tagging/sender_sync/utils/load_and_store_new_tagging_indexes.ts

@@ -1,7 +1,6 @@
 import type { BlockHash } from '@aztec/stdlib/block';
 import type { AztecNode } from '@aztec/stdlib/interfaces/server';
-import type { ExtendedDirectionalAppTaggingSecret } from '@aztec/stdlib/logs';
-import { SiloedTag } from '@aztec/stdlib/logs';
+import { type AppTaggingSecret, SiloedTag } from '@aztec/stdlib/logs';
 import { TxHash } from '@aztec/stdlib/tx';
 
 import type { SenderTaggingStore } from '../../../storage/tagging_store/sender_tagging_store.js';
@@ -11,7 +10,7 @@ import { getAllPrivateLogsByTags } from '../../get_all_logs_by_tags.js';
  * Loads tagging indexes from the Aztec node and stores them in the tagging data provider.
  * @remarks This function is one of two places by which a pending index can get to the tagging data provider. The other
  * place is when a tx is being sent from this PXE.
- * @param extendedSecret - The extended directional app tagging secret that's unique for (sender, recipient, app) tuple.
+ * @param extendedSecret - The app tagging secret whose indexes are being synced.
  * @param start - The starting index (inclusive) of the window to process.
  * @param end - The ending index (exclusive) of the window to process.
  * @param aztecNode - The Aztec node instance to query for logs.
@@ -21,7 +20,7 @@ import { getAllPrivateLogsByTags } from '../../get_all_logs_by_tags.js';
  * preserving way.
  */
 export async function loadAndStoreNewTaggingIndexes(
-  extendedSecret: ExtendedDirectionalAppTaggingSecret,
+  extendedSecret: AppTaggingSecret,
   start: number,
   end: number,
   aztecNode: AztecNode,
@@ -53,7 +52,7 @@ async function getTxsContainingTags(
   anchorBlockHash: BlockHash,
 ): Promise<TxHash[][]> {
   // We use the utility function below to retrieve all logs for the tags across all pages, so we don't need to handle
-  // pagination here.
+  // pagination here. Sender sync only needs `txHash` from each log, so we leave `includeEffects` off.
   const allLogs = await getAllPrivateLogsByTags(aztecNode, tags, anchorBlockHash);
   return allLogs.map(logs => logs.map(log => log.txHash));
 }

package/dest/contract_function_simulator/oracle/legacy_oracle_mappings.d.ts

@@ -1,9 +0,0 @@
-import type { ACIRCallback } from '@aztec/simulator/client';
-import type { Oracle } from './oracle.js';
-/**
- * Builds legacy oracle name callbacks for pinned protocol contracts whose artifacts are committed and cannot be
- * changed.
- * TODO(F-416): Remove these aliases on v5 when protocol contracts are redeployed.
- */
-export declare function buildLegacyOracleCallbacks(oracle: Oracle): ACIRCallback;
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoibGVnYWN5X29yYWNsZV9tYXBwaW5ncy5kLnRzIiwic291cmNlUm9vdCI6IiIsInNvdXJjZXMiOlsiLi4vLi4vLi4vc3JjL2NvbnRyYWN0X2Z1bmN0aW9uX3NpbXVsYXRvci9vcmFjbGUvbGVnYWN5X29yYWNsZV9tYXBwaW5ncy50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFDQSxPQUFPLEtBQUssRUFBRSxZQUFZLEVBQWEsTUFBTSx5QkFBeUIsQ0FBQztBQUd2RSxPQUFPLEtBQUssRUFBRSxNQUFNLEVBQUUsTUFBTSxhQUFhLENBQUM7QUFFMUM7Ozs7R0FJRztBQUNILHdCQUFnQiwwQkFBMEIsQ0FBQyxNQUFNLEVBQUUsTUFBTSxHQUFHLFlBQVksQ0E0RnZFIn0=

package/dest/contract_function_simulator/oracle/legacy_oracle_mappings.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"legacy_oracle_mappings.d.ts","sourceRoot":"","sources":["../../../src/contract_function_simulator/oracle/legacy_oracle_mappings.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,YAAY,EAAa,MAAM,yBAAyB,CAAC;AAGvE,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,aAAa,CAAC;AAE1C;;;;GAIG;AACH,wBAAgB,0BAA0B,CAAC,MAAM,EAAE,MAAM,GAAG,YAAY,CA4FvE"}

package/dest/contract_function_simulator/oracle/legacy_oracle_mappings.js

@@ -1,47 +0,0 @@
-import { toACVMField } from '@aztec/simulator/client';
-import { AztecAddress } from '@aztec/stdlib/aztec-address';
-/**
- * Builds legacy oracle name callbacks for pinned protocol contracts whose artifacts are committed and cannot be
- * changed.
- * TODO(F-416): Remove these aliases on v5 when protocol contracts are redeployed.
- */ export function buildLegacyOracleCallbacks(oracle) {
-    // If you are about to add a new mapping ensure that the old oracle name is different from the new one - this can
-    // commonly occur when only the args are getting modified.
-    return {
-        // Simple prefix renames (privateXxx/utilityXxx → aztec_prv_/aztec_utl_)
-        utilityLog: (level, message, _ignoredFieldsSize, fields)=>oracle.aztec_utl_log(level, message, _ignoredFieldsSize, fields),
-        utilityAssertCompatibleOracleVersion: (version)=>oracle.aztec_utl_assertCompatibleOracleVersionV2(version, [
-                toACVMField(0)
-            ]),
-        // Old 1-arg oracle before minor/major split. Maps to V2 with minor=0.
-        // eslint-disable-next-line camelcase
-        aztec_utl_assertCompatibleOracleVersion: (version)=>oracle.aztec_utl_assertCompatibleOracleVersionV2(version, [
-                toACVMField(0)
-            ]),
-        utilityLoadCapsule: (contractAddress, slot, tSize)=>oracle.aztec_utl_getCapsule(contractAddress, slot, tSize, [
-                toACVMField(AztecAddress.ZERO)
-            ]),
-        privateStoreInExecutionCache: (values, hash)=>oracle.aztec_prv_setHashPreimage(values, hash),
-        privateLoadFromExecutionCache: (returnsHash)=>oracle.aztec_prv_getHashPreimage(returnsHash),
-        privateCallPrivateFunction: (contractAddress, functionSelector, argsHash, sideEffectCounter, isStaticCall)=>oracle.aztec_prv_callPrivateFunction(contractAddress, functionSelector, argsHash, sideEffectCounter, isStaticCall),
-        privateIsNullifierPending: (innerNullifier, contractAddress)=>oracle.aztec_prv_isNullifierPending(innerNullifier, contractAddress),
-        privateNotifyCreatedNullifier: (innerNullifier)=>oracle.aztec_prv_notifyCreatedNullifier(innerNullifier),
-        privateNotifyCreatedContractClassLog: (contractAddress, message, length, counter)=>oracle.aztec_prv_notifyCreatedContractClassLog(contractAddress, message, length, counter),
-        utilityGetUtilityContext: ()=>oracle.aztec_utl_getUtilityContext(),
-        utilityStorageRead: (blockHash, contractAddress, startStorageSlot, numberOfElements)=>oracle.aztec_utl_getFromPublicStorage(blockHash, contractAddress, startStorageSlot, numberOfElements),
-        utilityStoreCapsule: (contractAddress, slot, capsule)=>oracle.aztec_utl_setCapsule(contractAddress, slot, capsule, [
-                toACVMField(AztecAddress.ZERO)
-            ]),
-        utilityCopyCapsule: (contractAddress, srcSlot, dstSlot, numEntries)=>oracle.aztec_utl_copyCapsule(contractAddress, srcSlot, dstSlot, numEntries, [
-                toACVMField(AztecAddress.ZERO)
-            ]),
-        utilityDeleteCapsule: (contractAddress, slot)=>oracle.aztec_utl_deleteCapsule(contractAddress, slot, [
-                toACVMField(AztecAddress.ZERO)
-            ]),
-        utilityGetL1ToL2MembershipWitness: (contractAddress, messageHash, secret)=>oracle.aztec_utl_getL1ToL2MembershipWitness(contractAddress, messageHash, secret),
-        // Renames (same signature, different oracle name)
-        privateNotifySetMinRevertibleSideEffectCounter: (counter)=>oracle.aztec_prv_notifyRevertiblePhaseStart(counter),
-        // Signature changes: old 4-param oracles → new 1-param validatePublicCalldata
-        privateNotifyEnqueuedPublicFunctionCall: (_contractAddress, calldataHash, _sideEffectCounter, _isStaticCall)=>oracle.aztec_prv_assertValidPublicCalldata(calldataHash)
-    };
-}

package/dest/tagging/recipient_sync/load_private_logs_for_sender_recipient_pair.d.ts

@@ -1,14 +0,0 @@
-import type { BlockNumber } from '@aztec/foundation/branded-types';
-import type { BlockHash } from '@aztec/stdlib/block';
-import type { AztecNode } from '@aztec/stdlib/interfaces/client';
-import type { ExtendedDirectionalAppTaggingSecret, TxScopedL2Log } from '@aztec/stdlib/logs';
-import type { RecipientTaggingStore } from '../../storage/tagging_store/recipient_tagging_store.js';
-/**
- * Loads private logs for the app-sender-recipient triplet defined by `secret` and updates the highest aged and
- * finalized indexes in the db. At most load logs from blocks up to and including `anchorBlockNumber`.
- *
- * @dev This function can be safely executed "in parallel" for other sender-recipient pairs because the data in
- * in the tagging data provider is indexed by the secret and hence completely disjoint.
- */
-export declare function loadPrivateLogsForSenderRecipientPair(secret: ExtendedDirectionalAppTaggingSecret, aztecNode: AztecNode, taggingStore: RecipientTaggingStore, anchorBlockNumber: BlockNumber, anchorBlockHash: BlockHash, currentTimestamp: bigint, finalizedBlockNumber: BlockNumber, jobId: string): Promise<TxScopedL2Log[]>;
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoibG9hZF9wcml2YXRlX2xvZ3NfZm9yX3NlbmRlcl9yZWNpcGllbnRfcGFpci5kLnRzIiwic291cmNlUm9vdCI6IiIsInNvdXJjZXMiOlsiLi4vLi4vLi4vc3JjL3RhZ2dpbmcvcmVjaXBpZW50X3N5bmMvbG9hZF9wcml2YXRlX2xvZ3NfZm9yX3NlbmRlcl9yZWNpcGllbnRfcGFpci50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEtBQUssRUFBRSxXQUFXLEVBQUUsTUFBTSxpQ0FBaUMsQ0FBQztBQUNuRSxPQUFPLEtBQUssRUFBRSxTQUFTLEVBQUUsTUFBTSxxQkFBcUIsQ0FBQztBQUNyRCxPQUFPLEtBQUssRUFBRSxTQUFTLEVBQUUsTUFBTSxpQ0FBaUMsQ0FBQztBQUNqRSxPQUFPLEtBQUssRUFBRSxtQ0FBbUMsRUFBRSxhQUFhLEVBQUUsTUFBTSxvQkFBb0IsQ0FBQztBQUU3RixPQUFPLEtBQUssRUFBRSxxQkFBcUIsRUFBRSxNQUFNLHdEQUF3RCxDQUFDO0FBS3BHOzs7Ozs7R0FNRztBQUNILHdCQUFzQixxQ0FBcUMsQ0FDekQsTUFBTSxFQUFFLG1DQUFtQyxFQUMzQyxTQUFTLEVBQUUsU0FBUyxFQUNwQixZQUFZLEVBQUUscUJBQXFCLEVBQ25DLGlCQUFpQixFQUFFLFdBQVcsRUFDOUIsZUFBZSxFQUFFLFNBQVMsRUFDMUIsZ0JBQWdCLEVBQUUsTUFBTSxFQUN4QixvQkFBb0IsRUFBRSxXQUFXLEVBQ2pDLEtBQUssRUFBRSxNQUFNLEdBQ1osT0FBTyxDQUFDLGFBQWEsRUFBRSxDQUFDLENBdUcxQiJ9

package/dest/tagging/recipient_sync/load_private_logs_for_sender_recipient_pair.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"load_private_logs_for_sender_recipient_pair.d.ts","sourceRoot":"","sources":["../../../src/tagging/recipient_sync/load_private_logs_for_sender_recipient_pair.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,iCAAiC,CAAC;AACnE,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,qBAAqB,CAAC;AACrD,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,iCAAiC,CAAC;AACjE,OAAO,KAAK,EAAE,mCAAmC,EAAE,aAAa,EAAE,MAAM,oBAAoB,CAAC;AAE7F,OAAO,KAAK,EAAE,qBAAqB,EAAE,MAAM,wDAAwD,CAAC;AAKpG;;;;;;GAMG;AACH,wBAAsB,qCAAqC,CACzD,MAAM,EAAE,mCAAmC,EAC3C,SAAS,EAAE,SAAS,EACpB,YAAY,EAAE,qBAAqB,EACnC,iBAAiB,EAAE,WAAW,EAC9B,eAAe,EAAE,SAAS,EAC1B,gBAAgB,EAAE,MAAM,EACxB,oBAAoB,EAAE,WAAW,EACjC,KAAK,EAAE,MAAM,GACZ,OAAO,CAAC,aAAa,EAAE,CAAC,CAuG1B"}