@aztec/p2p 0.0.1-commit.f1df4d2 → 0.0.1-commit.f224bb98b

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (394) hide show
  1. package/dest/client/factory.d.ts +11 -11
  2. package/dest/client/factory.d.ts.map +1 -1
  3. package/dest/client/factory.js +45 -15
  4. package/dest/client/interface.d.ts +46 -33
  5. package/dest/client/interface.d.ts.map +1 -1
  6. package/dest/client/p2p_client.d.ts +39 -51
  7. package/dest/client/p2p_client.d.ts.map +1 -1
  8. package/dest/client/p2p_client.js +151 -224
  9. package/dest/client/test/tx_proposal_collector/proposal_tx_collector_worker.js +7 -8
  10. package/dest/config.d.ts +49 -18
  11. package/dest/config.d.ts.map +1 -1
  12. package/dest/config.js +92 -38
  13. package/dest/errors/tx-pool.error.d.ts +8 -0
  14. package/dest/errors/tx-pool.error.d.ts.map +1 -0
  15. package/dest/errors/tx-pool.error.js +9 -0
  16. package/dest/index.d.ts +2 -1
  17. package/dest/index.d.ts.map +1 -1
  18. package/dest/index.js +1 -0
  19. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts +104 -88
  20. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts.map +1 -1
  21. package/dest/mem_pools/attestation_pool/attestation_pool.js +445 -3
  22. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.d.ts +2 -2
  23. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.d.ts.map +1 -1
  24. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.js +353 -87
  25. package/dest/mem_pools/attestation_pool/index.d.ts +2 -3
  26. package/dest/mem_pools/attestation_pool/index.d.ts.map +1 -1
  27. package/dest/mem_pools/attestation_pool/index.js +1 -2
  28. package/dest/mem_pools/attestation_pool/mocks.d.ts +2 -2
  29. package/dest/mem_pools/attestation_pool/mocks.d.ts.map +1 -1
  30. package/dest/mem_pools/attestation_pool/mocks.js +2 -2
  31. package/dest/mem_pools/index.d.ts +3 -2
  32. package/dest/mem_pools/index.d.ts.map +1 -1
  33. package/dest/mem_pools/index.js +1 -1
  34. package/dest/mem_pools/instrumentation.d.ts +4 -2
  35. package/dest/mem_pools/instrumentation.d.ts.map +1 -1
  36. package/dest/mem_pools/instrumentation.js +16 -14
  37. package/dest/mem_pools/interface.d.ts +5 -5
  38. package/dest/mem_pools/interface.d.ts.map +1 -1
  39. package/dest/mem_pools/tx_pool/eviction/invalid_txs_after_mining_rule.js +3 -3
  40. package/dest/mem_pools/tx_pool/priority.d.ts +2 -2
  41. package/dest/mem_pools/tx_pool/priority.d.ts.map +1 -1
  42. package/dest/mem_pools/tx_pool/priority.js +4 -3
  43. package/dest/mem_pools/tx_pool/tx_pool_test_suite.d.ts +1 -1
  44. package/dest/mem_pools/tx_pool/tx_pool_test_suite.d.ts.map +1 -1
  45. package/dest/mem_pools/tx_pool/tx_pool_test_suite.js +3 -1
  46. package/dest/mem_pools/tx_pool_v2/archive/index.d.ts +2 -0
  47. package/dest/mem_pools/tx_pool_v2/archive/index.d.ts.map +1 -0
  48. package/dest/mem_pools/tx_pool_v2/archive/index.js +1 -0
  49. package/dest/mem_pools/tx_pool_v2/archive/tx_archive.d.ts +43 -0
  50. package/dest/mem_pools/tx_pool_v2/archive/tx_archive.d.ts.map +1 -0
  51. package/dest/mem_pools/tx_pool_v2/archive/tx_archive.js +103 -0
  52. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts +104 -0
  53. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts.map +1 -0
  54. package/dest/mem_pools/tx_pool_v2/deleted_pool.js +251 -0
  55. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.d.ts +47 -0
  56. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.d.ts.map +1 -0
  57. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.js +128 -0
  58. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.d.ts +17 -0
  59. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.d.ts.map +1 -0
  60. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.js +93 -0
  61. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.d.ts +19 -0
  62. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.d.ts.map +1 -0
  63. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.js +97 -0
  64. package/dest/mem_pools/tx_pool_v2/eviction/index.d.ts +10 -0
  65. package/dest/mem_pools/tx_pool_v2/eviction/index.d.ts.map +1 -0
  66. package/dest/mem_pools/tx_pool_v2/eviction/index.js +11 -0
  67. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.d.ts +180 -0
  68. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.d.ts.map +1 -0
  69. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.js +25 -0
  70. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.d.ts +15 -0
  71. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.d.ts.map +1 -0
  72. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.js +65 -0
  73. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.d.ts +17 -0
  74. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.d.ts.map +1 -0
  75. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.js +93 -0
  76. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts +16 -0
  77. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts.map +1 -0
  78. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.js +78 -0
  79. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.d.ts +20 -0
  80. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.d.ts.map +1 -0
  81. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.js +75 -0
  82. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.d.ts +15 -0
  83. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.d.ts.map +1 -0
  84. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.js +19 -0
  85. package/dest/mem_pools/tx_pool_v2/index.d.ts +6 -0
  86. package/dest/mem_pools/tx_pool_v2/index.d.ts.map +1 -0
  87. package/dest/mem_pools/tx_pool_v2/index.js +5 -0
  88. package/dest/mem_pools/tx_pool_v2/instrumentation.d.ts +15 -0
  89. package/dest/mem_pools/tx_pool_v2/instrumentation.d.ts.map +1 -0
  90. package/dest/mem_pools/tx_pool_v2/instrumentation.js +43 -0
  91. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts +213 -0
  92. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts.map +1 -0
  93. package/dest/mem_pools/tx_pool_v2/interfaces.js +10 -0
  94. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts +127 -0
  95. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts.map +1 -0
  96. package/dest/mem_pools/tx_pool_v2/tx_metadata.js +210 -0
  97. package/dest/mem_pools/tx_pool_v2/tx_pool_bench_metrics.d.ts +26 -0
  98. package/dest/mem_pools/tx_pool_v2/tx_pool_bench_metrics.d.ts.map +1 -0
  99. package/dest/mem_pools/tx_pool_v2/tx_pool_bench_metrics.js +70 -0
  100. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts +108 -0
  101. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts.map +1 -0
  102. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.js +337 -0
  103. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts +60 -0
  104. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts.map +1 -0
  105. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.js +164 -0
  106. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts +78 -0
  107. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts.map +1 -0
  108. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.js +916 -0
  109. package/dest/msg_validators/attestation_validator/fisherman_attestation_validator.d.ts +3 -3
  110. package/dest/msg_validators/attestation_validator/fisherman_attestation_validator.d.ts.map +1 -1
  111. package/dest/msg_validators/proposal_validator/block_proposal_validator.d.ts +6 -4
  112. package/dest/msg_validators/proposal_validator/block_proposal_validator.d.ts.map +1 -1
  113. package/dest/msg_validators/proposal_validator/block_proposal_validator.js +10 -2
  114. package/dest/msg_validators/proposal_validator/checkpoint_proposal_validator.d.ts +6 -4
  115. package/dest/msg_validators/proposal_validator/checkpoint_proposal_validator.d.ts.map +1 -1
  116. package/dest/msg_validators/proposal_validator/checkpoint_proposal_validator.js +16 -2
  117. package/dest/msg_validators/proposal_validator/proposal_validator.d.ts +13 -8
  118. package/dest/msg_validators/proposal_validator/proposal_validator.d.ts.map +1 -1
  119. package/dest/msg_validators/proposal_validator/proposal_validator.js +48 -36
  120. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts +4 -4
  121. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts.map +1 -1
  122. package/dest/msg_validators/tx_validator/aggregate_tx_validator.js +3 -3
  123. package/dest/msg_validators/tx_validator/allowed_public_setup.d.ts +2 -1
  124. package/dest/msg_validators/tx_validator/allowed_public_setup.d.ts.map +1 -1
  125. package/dest/msg_validators/tx_validator/allowed_public_setup.js +24 -20
  126. package/dest/msg_validators/tx_validator/allowed_setup_helpers.d.ts +17 -0
  127. package/dest/msg_validators/tx_validator/allowed_setup_helpers.d.ts.map +1 -0
  128. package/dest/msg_validators/tx_validator/allowed_setup_helpers.js +24 -0
  129. package/dest/msg_validators/tx_validator/block_header_validator.d.ts +16 -3
  130. package/dest/msg_validators/tx_validator/block_header_validator.d.ts.map +1 -1
  131. package/dest/msg_validators/tx_validator/block_header_validator.js +1 -1
  132. package/dest/msg_validators/tx_validator/double_spend_validator.d.ts +13 -3
  133. package/dest/msg_validators/tx_validator/double_spend_validator.d.ts.map +1 -1
  134. package/dest/msg_validators/tx_validator/double_spend_validator.js +4 -4
  135. package/dest/msg_validators/tx_validator/factory.d.ts +125 -6
  136. package/dest/msg_validators/tx_validator/factory.d.ts.map +1 -1
  137. package/dest/msg_validators/tx_validator/factory.js +226 -58
  138. package/dest/msg_validators/tx_validator/fee_payer_balance.d.ts +1 -1
  139. package/dest/msg_validators/tx_validator/fee_payer_balance.d.ts.map +1 -1
  140. package/dest/msg_validators/tx_validator/fee_payer_balance.js +6 -2
  141. package/dest/msg_validators/tx_validator/gas_validator.d.ts +67 -3
  142. package/dest/msg_validators/tx_validator/gas_validator.d.ts.map +1 -1
  143. package/dest/msg_validators/tx_validator/gas_validator.js +104 -37
  144. package/dest/msg_validators/tx_validator/index.d.ts +3 -1
  145. package/dest/msg_validators/tx_validator/index.d.ts.map +1 -1
  146. package/dest/msg_validators/tx_validator/index.js +2 -0
  147. package/dest/msg_validators/tx_validator/metadata_validator.d.ts +1 -1
  148. package/dest/msg_validators/tx_validator/metadata_validator.d.ts.map +1 -1
  149. package/dest/msg_validators/tx_validator/metadata_validator.js +4 -4
  150. package/dest/msg_validators/tx_validator/nullifier_cache.d.ts +14 -0
  151. package/dest/msg_validators/tx_validator/nullifier_cache.d.ts.map +1 -0
  152. package/dest/msg_validators/tx_validator/nullifier_cache.js +24 -0
  153. package/dest/msg_validators/tx_validator/phases_validator.d.ts +2 -2
  154. package/dest/msg_validators/tx_validator/phases_validator.d.ts.map +1 -1
  155. package/dest/msg_validators/tx_validator/phases_validator.js +44 -23
  156. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts +20 -4
  157. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts.map +1 -1
  158. package/dest/msg_validators/tx_validator/timestamp_validator.js +6 -6
  159. package/dest/services/dummy_service.d.ts +13 -5
  160. package/dest/services/dummy_service.d.ts.map +1 -1
  161. package/dest/services/dummy_service.js +10 -4
  162. package/dest/services/encoding.d.ts +3 -3
  163. package/dest/services/encoding.d.ts.map +1 -1
  164. package/dest/services/encoding.js +11 -10
  165. package/dest/services/gossipsub/index.d.ts +3 -0
  166. package/dest/services/gossipsub/index.d.ts.map +1 -0
  167. package/dest/services/gossipsub/index.js +2 -0
  168. package/dest/services/gossipsub/scoring.d.ts +21 -3
  169. package/dest/services/gossipsub/scoring.d.ts.map +1 -1
  170. package/dest/services/gossipsub/scoring.js +24 -7
  171. package/dest/services/gossipsub/topic_score_params.d.ts +173 -0
  172. package/dest/services/gossipsub/topic_score_params.d.ts.map +1 -0
  173. package/dest/services/gossipsub/topic_score_params.js +346 -0
  174. package/dest/services/libp2p/libp2p_service.d.ts +94 -42
  175. package/dest/services/libp2p/libp2p_service.d.ts.map +1 -1
  176. package/dest/services/libp2p/libp2p_service.js +463 -350
  177. package/dest/services/peer-manager/metrics.d.ts +3 -1
  178. package/dest/services/peer-manager/metrics.d.ts.map +1 -1
  179. package/dest/services/peer-manager/metrics.js +6 -0
  180. package/dest/services/peer-manager/peer_manager.d.ts +1 -1
  181. package/dest/services/peer-manager/peer_manager.d.ts.map +1 -1
  182. package/dest/services/peer-manager/peer_manager.js +2 -1
  183. package/dest/services/peer-manager/peer_scoring.d.ts +1 -1
  184. package/dest/services/peer-manager/peer_scoring.d.ts.map +1 -1
  185. package/dest/services/peer-manager/peer_scoring.js +25 -2
  186. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts +6 -5
  187. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts.map +1 -1
  188. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.js +26 -53
  189. package/dest/services/reqresp/batch-tx-requester/interface.d.ts +2 -6
  190. package/dest/services/reqresp/batch-tx-requester/interface.d.ts.map +1 -1
  191. package/dest/services/reqresp/batch-tx-requester/missing_txs.d.ts +10 -13
  192. package/dest/services/reqresp/batch-tx-requester/missing_txs.d.ts.map +1 -1
  193. package/dest/services/reqresp/batch-tx-requester/missing_txs.js +25 -46
  194. package/dest/services/reqresp/batch-tx-requester/peer_collection.d.ts +17 -11
  195. package/dest/services/reqresp/batch-tx-requester/peer_collection.d.ts.map +1 -1
  196. package/dest/services/reqresp/batch-tx-requester/peer_collection.js +49 -15
  197. package/dest/services/reqresp/batch-tx-requester/tx_validator.js +2 -2
  198. package/dest/services/reqresp/interface.d.ts +10 -1
  199. package/dest/services/reqresp/interface.d.ts.map +1 -1
  200. package/dest/services/reqresp/interface.js +15 -1
  201. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.d.ts +7 -5
  202. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.d.ts.map +1 -1
  203. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.js +16 -11
  204. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.d.ts +21 -10
  205. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.d.ts.map +1 -1
  206. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.js +27 -11
  207. package/dest/services/reqresp/protocols/tx.d.ts +7 -1
  208. package/dest/services/reqresp/protocols/tx.d.ts.map +1 -1
  209. package/dest/services/reqresp/protocols/tx.js +20 -0
  210. package/dest/services/reqresp/reqresp.d.ts +1 -1
  211. package/dest/services/reqresp/reqresp.d.ts.map +1 -1
  212. package/dest/services/reqresp/reqresp.js +13 -5
  213. package/dest/services/service.d.ts +39 -3
  214. package/dest/services/service.d.ts.map +1 -1
  215. package/dest/services/tx_collection/config.d.ts +22 -4
  216. package/dest/services/tx_collection/config.d.ts.map +1 -1
  217. package/dest/services/tx_collection/config.js +49 -3
  218. package/dest/services/tx_collection/fast_tx_collection.d.ts +6 -5
  219. package/dest/services/tx_collection/fast_tx_collection.d.ts.map +1 -1
  220. package/dest/services/tx_collection/fast_tx_collection.js +64 -48
  221. package/dest/services/tx_collection/file_store_tx_collection.d.ts +53 -0
  222. package/dest/services/tx_collection/file_store_tx_collection.d.ts.map +1 -0
  223. package/dest/services/tx_collection/file_store_tx_collection.js +167 -0
  224. package/dest/services/tx_collection/file_store_tx_source.d.ts +37 -0
  225. package/dest/services/tx_collection/file_store_tx_source.d.ts.map +1 -0
  226. package/dest/services/tx_collection/file_store_tx_source.js +90 -0
  227. package/dest/services/tx_collection/index.d.ts +3 -2
  228. package/dest/services/tx_collection/index.d.ts.map +1 -1
  229. package/dest/services/tx_collection/index.js +1 -0
  230. package/dest/services/tx_collection/instrumentation.d.ts +1 -1
  231. package/dest/services/tx_collection/instrumentation.d.ts.map +1 -1
  232. package/dest/services/tx_collection/instrumentation.js +2 -1
  233. package/dest/services/tx_collection/missing_txs_tracker.d.ts +32 -0
  234. package/dest/services/tx_collection/missing_txs_tracker.d.ts.map +1 -0
  235. package/dest/services/tx_collection/missing_txs_tracker.js +27 -0
  236. package/dest/services/tx_collection/proposal_tx_collector.d.ts +15 -14
  237. package/dest/services/tx_collection/proposal_tx_collector.d.ts.map +1 -1
  238. package/dest/services/tx_collection/proposal_tx_collector.js +6 -6
  239. package/dest/services/tx_collection/slow_tx_collection.d.ts +7 -3
  240. package/dest/services/tx_collection/slow_tx_collection.d.ts.map +1 -1
  241. package/dest/services/tx_collection/slow_tx_collection.js +60 -26
  242. package/dest/services/tx_collection/tx_collection.d.ts +23 -10
  243. package/dest/services/tx_collection/tx_collection.d.ts.map +1 -1
  244. package/dest/services/tx_collection/tx_collection.js +75 -3
  245. package/dest/services/tx_collection/tx_collection_sink.d.ts +18 -8
  246. package/dest/services/tx_collection/tx_collection_sink.d.ts.map +1 -1
  247. package/dest/services/tx_collection/tx_collection_sink.js +26 -29
  248. package/dest/services/tx_collection/tx_source.d.ts +8 -3
  249. package/dest/services/tx_collection/tx_source.d.ts.map +1 -1
  250. package/dest/services/tx_collection/tx_source.js +19 -2
  251. package/dest/services/tx_file_store/config.d.ts +1 -3
  252. package/dest/services/tx_file_store/config.d.ts.map +1 -1
  253. package/dest/services/tx_file_store/config.js +0 -4
  254. package/dest/services/tx_file_store/tx_file_store.d.ts +4 -3
  255. package/dest/services/tx_file_store/tx_file_store.d.ts.map +1 -1
  256. package/dest/services/tx_file_store/tx_file_store.js +9 -6
  257. package/dest/services/tx_provider.d.ts +4 -4
  258. package/dest/services/tx_provider.d.ts.map +1 -1
  259. package/dest/services/tx_provider.js +9 -8
  260. package/dest/test-helpers/make-test-p2p-clients.d.ts +7 -8
  261. package/dest/test-helpers/make-test-p2p-clients.d.ts.map +1 -1
  262. package/dest/test-helpers/make-test-p2p-clients.js +1 -2
  263. package/dest/test-helpers/mock-pubsub.d.ts +30 -4
  264. package/dest/test-helpers/mock-pubsub.d.ts.map +1 -1
  265. package/dest/test-helpers/mock-pubsub.js +105 -4
  266. package/dest/test-helpers/reqresp-nodes.d.ts +2 -3
  267. package/dest/test-helpers/reqresp-nodes.d.ts.map +1 -1
  268. package/dest/test-helpers/reqresp-nodes.js +4 -3
  269. package/dest/test-helpers/testbench-utils.d.ts +43 -38
  270. package/dest/test-helpers/testbench-utils.d.ts.map +1 -1
  271. package/dest/test-helpers/testbench-utils.js +129 -59
  272. package/dest/testbench/p2p_client_testbench_worker.d.ts +2 -2
  273. package/dest/testbench/p2p_client_testbench_worker.d.ts.map +1 -1
  274. package/dest/testbench/p2p_client_testbench_worker.js +17 -16
  275. package/dest/testbench/worker_client_manager.d.ts +3 -1
  276. package/dest/testbench/worker_client_manager.d.ts.map +1 -1
  277. package/dest/testbench/worker_client_manager.js +6 -2
  278. package/dest/util.d.ts +3 -3
  279. package/dest/util.d.ts.map +1 -1
  280. package/package.json +14 -14
  281. package/src/client/factory.ts +82 -28
  282. package/src/client/interface.ts +56 -34
  283. package/src/client/p2p_client.ts +181 -269
  284. package/src/client/test/tx_proposal_collector/proposal_tx_collector_worker.ts +21 -12
  285. package/src/config.ts +141 -44
  286. package/src/errors/tx-pool.error.ts +12 -0
  287. package/src/index.ts +1 -0
  288. package/src/mem_pools/attestation_pool/attestation_pool.ts +497 -91
  289. package/src/mem_pools/attestation_pool/attestation_pool_test_suite.ts +442 -102
  290. package/src/mem_pools/attestation_pool/index.ts +9 -2
  291. package/src/mem_pools/attestation_pool/mocks.ts +2 -1
  292. package/src/mem_pools/index.ts +4 -1
  293. package/src/mem_pools/instrumentation.ts +17 -13
  294. package/src/mem_pools/interface.ts +4 -4
  295. package/src/mem_pools/tx_pool/README.md +1 -1
  296. package/src/mem_pools/tx_pool/eviction/invalid_txs_after_mining_rule.ts +3 -3
  297. package/src/mem_pools/tx_pool/priority.ts +6 -3
  298. package/src/mem_pools/tx_pool/tx_pool_test_suite.ts +3 -1
  299. package/src/mem_pools/tx_pool_v2/README.md +283 -0
  300. package/src/mem_pools/tx_pool_v2/archive/index.ts +1 -0
  301. package/src/mem_pools/tx_pool_v2/archive/tx_archive.ts +120 -0
  302. package/src/mem_pools/tx_pool_v2/deleted_pool.ts +321 -0
  303. package/src/mem_pools/tx_pool_v2/eviction/eviction_manager.ts +160 -0
  304. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.ts +121 -0
  305. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.ts +125 -0
  306. package/src/mem_pools/tx_pool_v2/eviction/index.ts +27 -0
  307. package/src/mem_pools/tx_pool_v2/eviction/interfaces.ts +219 -0
  308. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.ts +74 -0
  309. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.ts +101 -0
  310. package/src/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.ts +91 -0
  311. package/src/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.ts +99 -0
  312. package/src/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.ts +32 -0
  313. package/src/mem_pools/tx_pool_v2/index.ts +12 -0
  314. package/src/mem_pools/tx_pool_v2/instrumentation.ts +69 -0
  315. package/src/mem_pools/tx_pool_v2/interfaces.ts +245 -0
  316. package/src/mem_pools/tx_pool_v2/tx_metadata.ts +327 -0
  317. package/src/mem_pools/tx_pool_v2/tx_pool_bench_metrics.ts +77 -0
  318. package/src/mem_pools/tx_pool_v2/tx_pool_indices.ts +430 -0
  319. package/src/mem_pools/tx_pool_v2/tx_pool_v2.ts +226 -0
  320. package/src/mem_pools/tx_pool_v2/tx_pool_v2_impl.ts +1097 -0
  321. package/src/msg_validators/attestation_validator/fisherman_attestation_validator.ts +2 -2
  322. package/src/msg_validators/proposal_validator/block_proposal_validator.ts +14 -4
  323. package/src/msg_validators/proposal_validator/checkpoint_proposal_validator.ts +20 -7
  324. package/src/msg_validators/proposal_validator/proposal_validator.ts +63 -40
  325. package/src/msg_validators/tx_validator/README.md +115 -0
  326. package/src/msg_validators/tx_validator/aggregate_tx_validator.ts +5 -5
  327. package/src/msg_validators/tx_validator/allowed_public_setup.ts +22 -27
  328. package/src/msg_validators/tx_validator/allowed_setup_helpers.ts +31 -0
  329. package/src/msg_validators/tx_validator/block_header_validator.ts +15 -3
  330. package/src/msg_validators/tx_validator/double_spend_validator.ts +11 -6
  331. package/src/msg_validators/tx_validator/factory.ts +366 -77
  332. package/src/msg_validators/tx_validator/fee_payer_balance.ts +6 -2
  333. package/src/msg_validators/tx_validator/gas_validator.ts +123 -27
  334. package/src/msg_validators/tx_validator/index.ts +2 -0
  335. package/src/msg_validators/tx_validator/metadata_validator.ts +12 -4
  336. package/src/msg_validators/tx_validator/nullifier_cache.ts +30 -0
  337. package/src/msg_validators/tx_validator/phases_validator.ts +51 -26
  338. package/src/msg_validators/tx_validator/timestamp_validator.ts +23 -18
  339. package/src/services/dummy_service.ts +18 -6
  340. package/src/services/encoding.ts +9 -9
  341. package/src/services/gossipsub/README.md +641 -0
  342. package/src/services/gossipsub/index.ts +2 -0
  343. package/src/services/gossipsub/scoring.ts +29 -5
  344. package/src/services/gossipsub/topic_score_params.ts +487 -0
  345. package/src/services/libp2p/libp2p_service.ts +488 -372
  346. package/src/services/peer-manager/metrics.ts +7 -0
  347. package/src/services/peer-manager/peer_manager.ts +2 -1
  348. package/src/services/peer-manager/peer_scoring.ts +25 -0
  349. package/src/services/reqresp/batch-tx-requester/README.md +7 -7
  350. package/src/services/reqresp/batch-tx-requester/batch_tx_requester.ts +31 -59
  351. package/src/services/reqresp/batch-tx-requester/interface.ts +1 -5
  352. package/src/services/reqresp/batch-tx-requester/missing_txs.ts +23 -71
  353. package/src/services/reqresp/batch-tx-requester/peer_collection.ts +63 -24
  354. package/src/services/reqresp/batch-tx-requester/tx_validator.ts +2 -2
  355. package/src/services/reqresp/interface.ts +26 -1
  356. package/src/services/reqresp/protocols/block_txs/block_txs_handler.ts +23 -14
  357. package/src/services/reqresp/protocols/block_txs/block_txs_reqresp.ts +38 -15
  358. package/src/services/reqresp/protocols/tx.ts +22 -0
  359. package/src/services/reqresp/reqresp.ts +16 -4
  360. package/src/services/service.ts +51 -2
  361. package/src/services/tx_collection/config.ts +74 -6
  362. package/src/services/tx_collection/fast_tx_collection.ts +74 -51
  363. package/src/services/tx_collection/file_store_tx_collection.ts +202 -0
  364. package/src/services/tx_collection/file_store_tx_source.ts +117 -0
  365. package/src/services/tx_collection/index.ts +2 -1
  366. package/src/services/tx_collection/instrumentation.ts +7 -1
  367. package/src/services/tx_collection/missing_txs_tracker.ts +52 -0
  368. package/src/services/tx_collection/proposal_tx_collector.ts +20 -21
  369. package/src/services/tx_collection/slow_tx_collection.ts +66 -33
  370. package/src/services/tx_collection/tx_collection.ts +113 -16
  371. package/src/services/tx_collection/tx_collection_sink.ts +30 -34
  372. package/src/services/tx_collection/tx_source.ts +22 -3
  373. package/src/services/tx_file_store/config.ts +0 -6
  374. package/src/services/tx_file_store/tx_file_store.ts +10 -8
  375. package/src/services/tx_provider.ts +10 -9
  376. package/src/test-helpers/make-test-p2p-clients.ts +4 -6
  377. package/src/test-helpers/mock-pubsub.ts +146 -9
  378. package/src/test-helpers/reqresp-nodes.ts +5 -7
  379. package/src/test-helpers/testbench-utils.ts +128 -71
  380. package/src/testbench/p2p_client_testbench_worker.ts +26 -22
  381. package/src/testbench/worker_client_manager.ts +13 -5
  382. package/src/util.ts +8 -2
  383. package/dest/mem_pools/attestation_pool/kv_attestation_pool.d.ts +0 -40
  384. package/dest/mem_pools/attestation_pool/kv_attestation_pool.d.ts.map +0 -1
  385. package/dest/mem_pools/attestation_pool/kv_attestation_pool.js +0 -218
  386. package/dest/mem_pools/attestation_pool/memory_attestation_pool.d.ts +0 -31
  387. package/dest/mem_pools/attestation_pool/memory_attestation_pool.d.ts.map +0 -1
  388. package/dest/mem_pools/attestation_pool/memory_attestation_pool.js +0 -180
  389. package/dest/msg_validators/proposal_validator/proposal_validator_test_suite.d.ts +0 -23
  390. package/dest/msg_validators/proposal_validator/proposal_validator_test_suite.d.ts.map +0 -1
  391. package/dest/msg_validators/proposal_validator/proposal_validator_test_suite.js +0 -212
  392. package/src/mem_pools/attestation_pool/kv_attestation_pool.ts +0 -320
  393. package/src/mem_pools/attestation_pool/memory_attestation_pool.ts +0 -264
  394. package/src/msg_validators/proposal_validator/proposal_validator_test_suite.ts +0 -230
@@ -1,6 +1,6 @@
1
1
  import type { EpochCacheInterface } from '@aztec/epoch-cache';
2
- import { BlockNumber } from '@aztec/foundation/branded-types';
3
- import { randomInt } from '@aztec/foundation/crypto/random';
2
+ import { BlockNumber, type SlotNumber } from '@aztec/foundation/branded-types';
3
+ import { maxBy } from '@aztec/foundation/collection';
4
4
  import { Fr } from '@aztec/foundation/curves/bn254';
5
5
  import { type Logger, createLibp2pComponentLogger, createLogger } from '@aztec/foundation/log';
6
6
  import { RunningPromise } from '@aztec/foundation/running-promise';
@@ -17,13 +17,13 @@ import {
17
17
  CheckpointProposal,
18
18
  type CheckpointProposalCore,
19
19
  type Gossipable,
20
- P2PClientType,
21
20
  P2PMessage,
22
21
  type ValidationResult as P2PValidationResult,
23
22
  PeerErrorSeverity,
23
+ PeerErrorSeverityByHarshness,
24
24
  TopicType,
25
25
  createTopicString,
26
- getTopicsForClientAndConfig,
26
+ getTopicsForConfig,
27
27
  metricsTopicStrToLabels,
28
28
  } from '@aztec/stdlib/p2p';
29
29
  import { MerkleTreeId } from '@aztec/stdlib/trees';
@@ -45,7 +45,7 @@ import {
45
45
  type GossipsubMessage,
46
46
  gossipsub,
47
47
  } from '@chainsafe/libp2p-gossipsub';
48
- import { createPeerScoreParams, createTopicScoreParams } from '@chainsafe/libp2p-gossipsub/score';
48
+ import { createPeerScoreParams } from '@chainsafe/libp2p-gossipsub/score';
49
49
  import { SignaturePolicy } from '@chainsafe/libp2p-gossipsub/types';
50
50
  import { noise } from '@chainsafe/libp2p-noise';
51
51
  import { yamux } from '@chainsafe/libp2p-yamux';
@@ -59,35 +59,40 @@ import { ENR } from '@nethermindeth/enr';
59
59
  import { createLibp2p } from 'libp2p';
60
60
 
61
61
  import type { P2PConfig } from '../../config.js';
62
- import { ProposalSlotCapExceededError } from '../../errors/attestation-pool.error.js';
63
62
  import type { MemPools } from '../../mem_pools/interface.js';
64
63
  import {
65
64
  BlockProposalValidator,
66
65
  CheckpointAttestationValidator,
67
66
  CheckpointProposalValidator,
67
+ DoubleSpendTxValidator,
68
68
  FishermanAttestationValidator,
69
+ getDefaultAllowedSetupFunctions,
69
70
  } from '../../msg_validators/index.js';
70
71
  import { MessageSeenValidator } from '../../msg_validators/msg_seen_validator/msg_seen_validator.js';
71
- import { getDefaultAllowedSetupFunctions } from '../../msg_validators/tx_validator/allowed_public_setup.js';
72
72
  import {
73
- type MessageValidator,
74
- createTxMessageValidators,
75
- createTxReqRespValidator,
73
+ type TransactionValidator,
74
+ createFirstStageTxValidationsForGossipedTransactions,
75
+ createSecondStageTxValidationsForGossipedTransactions,
76
+ createTxValidatorForBlockProposalReceivedTxs,
77
+ createTxValidatorForReqResponseReceivedTxs,
76
78
  } from '../../msg_validators/tx_validator/factory.js';
77
- import { DoubleSpendTxValidator } from '../../msg_validators/tx_validator/index.js';
78
79
  import { GossipSubEvent } from '../../types/index.js';
79
80
  import { type PubSubLibp2p, convertToMultiaddr } from '../../util.js';
80
81
  import { getVersions } from '../../versioning.js';
81
82
  import { AztecDatastore } from '../data_store.js';
82
83
  import { DiscV5Service } from '../discv5/discV5_service.js';
83
84
  import { SnappyTransform, fastMsgIdFn, getMsgIdFn, msgIdToStrFn } from '../encoding.js';
84
- import { gossipScoreThresholds } from '../gossipsub/scoring.js';
85
+ import { APP_SPECIFIC_WEIGHT, gossipScoreThresholds } from '../gossipsub/scoring.js';
86
+ import { createAllTopicScoreParams } from '../gossipsub/topic_score_params.js';
85
87
  import type { PeerManagerInterface } from '../peer-manager/interface.js';
86
88
  import { PeerManager } from '../peer-manager/peer_manager.js';
87
89
  import { PeerScoring } from '../peer-manager/peer_scoring.js';
88
90
  import type { BatchTxRequesterLibP2PService } from '../reqresp/batch-tx-requester/interface.js';
89
91
  import type { P2PReqRespConfig } from '../reqresp/config.js';
90
92
  import {
93
+ AuthRequest,
94
+ BlockTxsRequest,
95
+ BlockTxsResponse,
91
96
  DEFAULT_SUB_PROTOCOL_VALIDATORS,
92
97
  type ReqRespInterface,
93
98
  type ReqRespResponse,
@@ -95,25 +100,21 @@ import {
95
100
  type ReqRespSubProtocolHandler,
96
101
  type ReqRespSubProtocolHandlers,
97
102
  type ReqRespSubProtocolValidators,
103
+ StatusMessage,
98
104
  type SubProtocolMap,
99
105
  ValidationError,
100
- } from '../reqresp/interface.js';
101
- import { reqRespBlockTxsHandler } from '../reqresp/protocols/block_txs/block_txs_handler.js';
102
- import { reqGoodbyeHandler } from '../reqresp/protocols/goodbye.js';
103
- import {
104
- AuthRequest,
105
- BlockTxsRequest,
106
- BlockTxsResponse,
107
- StatusMessage,
108
106
  pingHandler,
107
+ reqGoodbyeHandler,
109
108
  reqRespBlockHandler,
109
+ reqRespBlockTxsHandler,
110
110
  reqRespStatusHandler,
111
111
  reqRespTxHandler,
112
- } from '../reqresp/protocols/index.js';
112
+ } from '../reqresp/index.js';
113
113
  import { ReqResp } from '../reqresp/reqresp.js';
114
114
  import type {
115
115
  P2PBlockReceivedCallback,
116
116
  P2PCheckpointReceivedCallback,
117
+ P2PDuplicateAttestationCallback,
117
118
  P2PService,
118
119
  PeerDiscoveryService,
119
120
  } from '../service.js';
@@ -128,14 +129,14 @@ interface ValidationResult {
128
129
  type ValidationOutcome = { allPassed: true } | { allPassed: false; failure: ValidationResult };
129
130
 
130
131
  // REFACTOR: Unify with the type above
131
- type ReceivedMessageValidationResult<T> =
132
- | { obj: T; result: Exclude<TopicValidatorResult, TopicValidatorResult.Reject> }
133
- | { obj?: undefined; result: TopicValidatorResult.Reject };
132
+ type ReceivedMessageValidationResult<T, M = undefined> =
133
+ | { obj: T; result: Exclude<TopicValidatorResult, TopicValidatorResult.Reject>; metadata?: M }
134
+ | { obj?: T; result: TopicValidatorResult.Reject; metadata?: M };
134
135
 
135
136
  /**
136
137
  * Lib P2P implementation of the P2PService interface.
137
138
  */
138
- export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends WithTracer implements P2PService {
139
+ export class LibP2PService extends WithTracer implements P2PService {
139
140
  private discoveryRunningPromise?: RunningPromise;
140
141
  private msgIdSeenValidators: Record<TopicType, MessageSeenValidator> = {} as Record<TopicType, MessageSeenValidator>;
141
142
 
@@ -149,6 +150,16 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
149
150
 
150
151
  private feesCache: { blockNumber: BlockNumber; gasFees: GasFees } | undefined;
151
152
 
153
+ /** Callback invoked when a duplicate proposal is detected (triggers slashing). */
154
+ private duplicateProposalCallback?: (info: {
155
+ slot: SlotNumber;
156
+ proposer: EthAddress;
157
+ type: 'checkpoint' | 'block';
158
+ }) => void;
159
+
160
+ /** Callback invoked when a duplicate attestation is detected (triggers slashing). */
161
+ private duplicateAttestationCallback?: P2PDuplicateAttestationCallback;
162
+
152
163
  /**
153
164
  * Callback for when a block is received from a peer.
154
165
  * @param block - The block received from the peer.
@@ -172,14 +183,13 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
172
183
  protected logger: Logger;
173
184
 
174
185
  constructor(
175
- private clientType: T,
176
186
  private config: P2PConfig,
177
187
  protected node: PubSubLibp2p,
178
188
  private peerDiscoveryService: PeerDiscoveryService,
179
189
  private reqresp: ReqRespInterface,
180
- private peerManager: PeerManagerInterface,
190
+ protected peerManager: PeerManagerInterface,
181
191
  protected mempools: MemPools,
182
- private archiver: L2BlockSource & ContractDataSource,
192
+ protected archiver: L2BlockSource & ContractDataSource,
183
193
  private epochCache: EpochCacheInterface,
184
194
  private proofVerifier: ClientProtocolCircuitVerifier,
185
195
  private worldStateSynchronizer: WorldStateSynchronizer,
@@ -214,10 +224,12 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
214
224
  this.protocolVersion,
215
225
  );
216
226
 
217
- this.blockProposalValidator = new BlockProposalValidator(epochCache, { txsPermitted: !config.disableTransactions });
218
- this.checkpointProposalValidator = new CheckpointProposalValidator(epochCache, {
227
+ const proposalValidatorOpts = {
219
228
  txsPermitted: !config.disableTransactions,
220
- });
229
+ maxTxsPerBlock: config.validateMaxTxsPerBlock,
230
+ };
231
+ this.blockProposalValidator = new BlockProposalValidator(epochCache, proposalValidatorOpts);
232
+ this.checkpointProposalValidator = new CheckpointProposalValidator(epochCache, proposalValidatorOpts);
221
233
  this.checkpointAttestationValidator = config.fishermanMode
222
234
  ? new FishermanAttestationValidator(epochCache, mempools.attestationPool, telemetry)
223
235
  : new CheckpointAttestationValidator(epochCache);
@@ -225,11 +237,11 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
225
237
  this.gossipSubEventHandler = this.handleGossipSubEvent.bind(this);
226
238
 
227
239
  this.blockReceivedCallback = async (block: BlockProposal): Promise<boolean> => {
228
- this.logger.debug(
229
- `Handler not yet registered: Block received callback not set. Received block for slot ${block.slotNumber} from peer.`,
240
+ this.logger.warn(
241
+ `Handler for block received not yet registered on P2P service. Received block ${block.blockNumber} for slot ${block.slotNumber} from peer.`,
230
242
  { p2pMessageIdentifier: await block.p2pMessageLoggingIdentifier() },
231
243
  );
232
- return false;
244
+ return true;
233
245
  };
234
246
 
235
247
  this.checkpointReceivedCallback = (
@@ -252,8 +264,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
252
264
  * @param txPool - The transaction pool to be accessed by the service.
253
265
  * @returns The new service.
254
266
  */
255
- public static async new<T extends P2PClientType>(
256
- clientType: T,
267
+ public static async new(
257
268
  config: P2PConfig,
258
269
  peerId: PeerId,
259
270
  deps: {
@@ -305,11 +316,6 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
305
316
  const versions = getVersions(config);
306
317
  const protocolVersion = compressComponentVersions(versions);
307
318
 
308
- const txTopic = createTopicString(TopicType.tx, protocolVersion);
309
- const blockProposalTopic = createTopicString(TopicType.block_proposal, protocolVersion);
310
- const checkpointProposalTopic = createTopicString(TopicType.checkpoint_proposal, protocolVersion);
311
- const checkpointAttestationTopic = createTopicString(TopicType.checkpoint_attestation, protocolVersion);
312
-
313
319
  const preferredPeersEnrs: ENR[] = config.preferredPeers.map(enr => ENR.decodeTxt(enr));
314
320
  const directPeers = (
315
321
  await Promise.all(
@@ -329,6 +335,16 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
329
335
 
330
336
  const announceTcpMultiaddr = config.p2pIp ? [convertToMultiaddr(config.p2pIp, p2pPort, 'tcp')] : [];
331
337
 
338
+ // Create dynamic topic score params based on network configuration
339
+ const l1Constants = epochCache.getL1Constants();
340
+ const topicScoreParams = createAllTopicScoreParams(protocolVersion, {
341
+ slotDurationMs: l1Constants.slotDuration * 1000,
342
+ heartbeatIntervalMs: config.gossipsubInterval,
343
+ targetCommitteeSize: l1Constants.targetCommitteeSize,
344
+ blockDurationMs: config.blockDurationMs,
345
+ expectedBlockProposalsPerSlot: config.expectedBlockProposalsPerSlot,
346
+ });
347
+
332
348
  const node = await createLibp2p({
333
349
  start: false,
334
350
  peerId,
@@ -424,28 +440,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
424
440
  scoreParams: createPeerScoreParams({
425
441
  // IPColocation factor can be disabled for local testing - default to -5
426
442
  IPColocationFactorWeight: config.debugDisableColocationPenalty ? 0 : -5.0,
427
- topics: {
428
- [txTopic]: createTopicScoreParams({
429
- topicWeight: 1,
430
- invalidMessageDeliveriesWeight: -20,
431
- invalidMessageDeliveriesDecay: 0.5,
432
- }),
433
- [blockProposalTopic]: createTopicScoreParams({
434
- topicWeight: 1,
435
- invalidMessageDeliveriesWeight: -20,
436
- invalidMessageDeliveriesDecay: 0.5,
437
- }),
438
- [checkpointProposalTopic]: createTopicScoreParams({
439
- topicWeight: 1,
440
- invalidMessageDeliveriesWeight: -20,
441
- invalidMessageDeliveriesDecay: 0.5,
442
- }),
443
- [checkpointAttestationTopic]: createTopicScoreParams({
444
- topicWeight: 1,
445
- invalidMessageDeliveriesWeight: -20,
446
- invalidMessageDeliveriesDecay: 0.5,
447
- }),
448
- },
443
+ topics: topicScoreParams,
449
444
  }),
450
445
  }) as (components: GossipSubComponents) => GossipSub,
451
446
  components: (components: { connectionManager: ConnectionManager }) => ({
@@ -471,13 +466,16 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
471
466
  epochCache,
472
467
  );
473
468
 
474
- // Update gossipsub score params
475
- node.services.pubsub.score.params.appSpecificWeight = 10;
469
+ // Configure application-specific scoring for gossipsub.
470
+ // The weight scales app score to align with gossipsub thresholds:
471
+ // - Disconnect (-50) × 10 = -500 = gossipThreshold (stops receiving gossip)
472
+ // - Ban (-100) × 10 = -1000 = publishThreshold (cannot publish)
473
+ // Note: positive topic scores can offset penalties, so alignment is best-effort.
474
+ node.services.pubsub.score.params.appSpecificWeight = APP_SPECIFIC_WEIGHT;
476
475
  node.services.pubsub.score.params.appSpecificScore = (peerId: string) =>
477
476
  peerManager.shouldDisableP2PGossip(peerId) ? -Infinity : peerManager.getPeerScore(peerId);
478
477
 
479
478
  return new LibP2PService(
480
- clientType,
481
479
  config,
482
480
  node,
483
481
  peerDiscoveryService,
@@ -524,7 +522,11 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
524
522
  };
525
523
 
526
524
  if (!this.config.disableTransactions) {
527
- const blockTxsHandler = reqRespBlockTxsHandler(this.mempools.attestationPool, this.mempools.txPool);
525
+ const blockTxsHandler = reqRespBlockTxsHandler(
526
+ this.mempools.attestationPool,
527
+ this.archiver,
528
+ this.mempools.txPool,
529
+ );
528
530
  requestResponseHandlers[ReqRespSubProtocol.BLOCK_TXS] = blockTxsHandler.bind(this);
529
531
  }
530
532
 
@@ -547,7 +549,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
547
549
  await this.node.start();
548
550
 
549
551
  // Subscribe to standard GossipSub topics by default
550
- for (const topic of getTopicsForClientAndConfig(this.clientType, this.config.disableTransactions)) {
552
+ for (const topic of getTopicsForConfig(this.config.disableTransactions)) {
551
553
  this.subscribeToTopic(this.topicStrings[topic]);
552
554
  }
553
555
 
@@ -613,6 +615,10 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
613
615
  return this.peerManager.getPeers(includePending);
614
616
  }
615
617
 
618
+ public getGossipMeshPeerCount(topicType: TopicType): number {
619
+ return this.node.services.pubsub.getMeshPeers(this.topicStrings[topicType]).length;
620
+ }
621
+
616
622
  private handleGossipSubEvent(e: CustomEvent<GossipsubMessage>) {
617
623
  this.logger.trace(`Received PUBSUB message.`);
618
624
 
@@ -665,6 +671,25 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
665
671
  this.checkpointReceivedCallback = callback;
666
672
  }
667
673
 
674
+ /**
675
+ * Registers a callback to be invoked when a duplicate proposal is detected.
676
+ * This callback is triggered on the first duplicate (when count goes from 1 to 2).
677
+ */
678
+ public registerDuplicateProposalCallback(
679
+ callback: (info: { slot: SlotNumber; proposer: EthAddress; type: 'checkpoint' | 'block' }) => void,
680
+ ): void {
681
+ this.duplicateProposalCallback = callback;
682
+ }
683
+
684
+ /**
685
+ * Registers a callback to be invoked when a duplicate attestation is detected.
686
+ * A validator signing attestations for different proposals at the same slot.
687
+ * This callback is triggered on the first duplicate (when count goes from 1 to 2).
688
+ */
689
+ public registerDuplicateAttestationCallback(callback: P2PDuplicateAttestationCallback): void {
690
+ this.duplicateAttestationCallback = callback;
691
+ }
692
+
668
693
  /**
669
694
  * Subscribes to a topic.
670
695
  * @param topic - The topic to subscribe to.
@@ -729,6 +754,9 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
729
754
  if (!validator || !validator.addMessage(msgId)) {
730
755
  this.instrumentation.incMessagePrevalidationStatus(false, topicType);
731
756
  this.node.services.pubsub.reportMessageValidationResult(msgId, source.toString(), TopicValidatorResult.Ignore);
757
+ if (topicType === TopicType.tx) {
758
+ this.logger.verbose(`Ignoring already-seen tx gossip message`, { msgId, source: source.toString() });
759
+ }
732
760
  return { result: false, topicType };
733
761
  }
734
762
 
@@ -793,9 +821,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
793
821
  if (msg.topic === this.topicStrings[TopicType.tx]) {
794
822
  await this.handleGossipedTx(p2pMessage.payload, msgId, source);
795
823
  } else if (msg.topic === this.topicStrings[TopicType.checkpoint_attestation]) {
796
- if (this.clientType === P2PClientType.Full) {
797
- await this.processCheckpointAttestationFromPeer(p2pMessage.payload, msgId, source);
798
- }
824
+ await this.processCheckpointAttestationFromPeer(p2pMessage.payload, msgId, source);
799
825
  } else if (msg.topic === this.topicStrings[TopicType.block_proposal]) {
800
826
  await this.processBlockFromPeer(p2pMessage.payload, msgId, source);
801
827
  } else if (msg.topic === this.topicStrings[TopicType.checkpoint_proposal]) {
@@ -851,13 +877,13 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
851
877
  return;
852
878
  }
853
879
 
854
- protected async validateReceivedMessage<T>(
855
- validationFunc: () => Promise<ReceivedMessageValidationResult<T>>,
880
+ protected async validateReceivedMessage<T, M = undefined>(
881
+ validationFunc: () => Promise<ReceivedMessageValidationResult<T, M>>,
856
882
  msgId: string,
857
883
  source: PeerId,
858
884
  topicType: TopicType,
859
- ): Promise<ReceivedMessageValidationResult<T>> {
860
- let resultAndObj: ReceivedMessageValidationResult<T> = { result: TopicValidatorResult.Reject };
885
+ ): Promise<ReceivedMessageValidationResult<T, M>> {
886
+ let resultAndObj: ReceivedMessageValidationResult<T, M> = { result: TopicValidatorResult.Reject };
861
887
  const timer = new Timer();
862
888
  try {
863
889
  resultAndObj = await validationFunc();
@@ -881,21 +907,76 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
881
907
  protected async handleGossipedTx(payloadData: Buffer, msgId: string, source: PeerId) {
882
908
  const validationFunc: () => Promise<ReceivedMessageValidationResult<Tx>> = async () => {
883
909
  const tx = Tx.fromBuffer(payloadData);
884
- const isValid = await this.validatePropagatedTx(tx, source);
885
- const exists = isValid && (await this.mempools.txPool.hasTx(tx.getTxHash()));
886
910
 
887
- this.logger.trace(`Validate propagated tx`, {
888
- isValid,
889
- exists,
911
+ const currentBlockNumber = await this.archiver.getBlockNumber();
912
+ const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
913
+
914
+ // Stage 1: fast validators (metadata, data, timestamps, double-spend, gas, phases, block header)
915
+ const firstStageValidators = await this.createFirstStageMessageValidators(currentBlockNumber, nextSlotTimestamp);
916
+ const firstStageOutcome = await this.runValidations(tx, firstStageValidators);
917
+ if (!firstStageOutcome.allPassed) {
918
+ const { name } = firstStageOutcome.failure;
919
+ let { severity } = firstStageOutcome.failure;
920
+
921
+ // Double spend validator has a special case handler. We perform more detailed examination
922
+ // as to how recently the nullifier was entered into the tree and if the transaction should
923
+ // have 'known' the nullifier existed. This determines the severity of the penalty applied to the peer.
924
+ if (name === 'doubleSpendValidator') {
925
+ const txBlockNumber = BlockNumber(currentBlockNumber + 1);
926
+ severity = await this.handleDoubleSpendFailure(tx, txBlockNumber);
927
+ }
928
+
929
+ this.logger.verbose(`Rejecting gossiped tx ${tx.getTxHash().toString()}: stage 1 validation failed`, {
930
+ validator: name,
931
+ severity,
932
+ source: source.toString(),
933
+ });
934
+ this.peerManager.penalizePeer(source, severity);
935
+ return { result: TopicValidatorResult.Reject };
936
+ }
937
+
938
+ // Pool pre-check: see if the pool would accept this tx before doing expensive proof verification
939
+ const canAdd = await this.mempools.txPool.canAddPendingTx(tx);
940
+ if (canAdd === 'ignored') {
941
+ this.logger.verbose(`Ignoring gossiped tx ${tx.getTxHash().toString()}: pool pre-check returned ignored`, {
942
+ source: source.toString(),
943
+ });
944
+ return { result: TopicValidatorResult.Ignore, obj: tx };
945
+ }
946
+
947
+ // Stage 2: expensive proof verification
948
+ const secondStageValidators = this.createSecondStageMessageValidators();
949
+ const secondStageOutcome = await this.runValidations(tx, secondStageValidators);
950
+ if (!secondStageOutcome.allPassed) {
951
+ const { severity, name } = secondStageOutcome.failure;
952
+ this.logger.verbose(`Rejecting gossiped tx ${tx.getTxHash().toString()}: stage 2 validation failed`, {
953
+ validator: name,
954
+ severity,
955
+ source: source.toString(),
956
+ });
957
+ this.peerManager.penalizePeer(source, severity);
958
+ return { result: TopicValidatorResult.Reject };
959
+ }
960
+
961
+ // Pool add: persist the tx
962
+ const txHash = tx.getTxHash();
963
+ const addResult = await this.mempools.txPool.addPendingTxs([tx], { source: 'gossip' });
964
+
965
+ const wasAccepted = addResult.accepted.some(h => h.equals(txHash));
966
+ const wasIgnored = addResult.ignored.some(h => h.equals(txHash));
967
+
968
+ this.logger.verbose(`Validate propagated tx ${txHash.toString()}`, {
969
+ wasAccepted,
970
+ wasIgnored,
890
971
  [Attributes.P2P_ID]: source.toString(),
891
972
  });
892
973
 
893
- if (!isValid) {
894
- return { result: TopicValidatorResult.Reject };
895
- } else if (exists) {
974
+ if (wasAccepted) {
975
+ return { result: TopicValidatorResult.Accept, obj: tx };
976
+ } else if (wasIgnored) {
896
977
  return { result: TopicValidatorResult.Ignore, obj: tx };
897
978
  } else {
898
- return { result: TopicValidatorResult.Accept, obj: tx };
979
+ return { result: TopicValidatorResult.Reject };
899
980
  }
900
981
  };
901
982
 
@@ -904,6 +985,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
904
985
  return;
905
986
  }
906
987
 
988
+ // Tx was accepted into pool and will be propagated - just log and record metrics
907
989
  const txHash = tx.getTxHash();
908
990
  const txHashString = txHash.toString();
909
991
  this.logger.verbose(`Received tx ${txHashString} from external peer ${source.toString()} via gossip`, {
@@ -911,13 +993,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
911
993
  txHash: txHashString,
912
994
  });
913
995
 
914
- if (this.config.dropTransactions && randomInt(1000) < this.config.dropTransactionsProbability * 1000) {
915
- this.logger.warn(`Intentionally dropping tx ${txHashString} (probability rule)`);
916
- return;
917
- }
918
-
919
996
  this.instrumentation.incrementTxReceived(1);
920
- await this.mempools.txPool.addTxs([tx]);
921
997
  }
922
998
 
923
999
  /**
@@ -929,47 +1005,8 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
929
1005
  msgId: string,
930
1006
  source: PeerId,
931
1007
  ): Promise<void> {
932
- const validationFunc: () => Promise<ReceivedMessageValidationResult<CheckpointAttestation>> = async () => {
933
- const attestation = CheckpointAttestation.fromBuffer(payloadData);
934
- const pool = this.mempools.attestationPool;
935
- const validationResult = await this.validateCheckpointAttestation(source, attestation);
936
- const isValid = validationResult.result === 'accept';
937
- const exists = isValid && (await pool.hasCheckpointAttestation(attestation));
938
-
939
- let canAdd = true;
940
- if (isValid && !exists) {
941
- const slot = attestation.payload.header.slotNumber;
942
- const { committee } = await this.epochCache.getCommittee(slot);
943
- const committeeSize = committee?.length ?? 0;
944
- canAdd = await pool.canAddCheckpointAttestation(attestation, committeeSize);
945
- }
946
-
947
- this.logger.trace(`Validate propagated checkpoint attestation`, {
948
- isValid,
949
- exists,
950
- canAdd,
951
- [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber.toString(),
952
- [Attributes.P2P_ID]: source.toString(),
953
- });
954
-
955
- if (validationResult.result === 'reject') {
956
- return { result: TopicValidatorResult.Reject };
957
- } else if (validationResult.result === 'ignore' || exists) {
958
- return { result: TopicValidatorResult.Ignore, obj: attestation };
959
- } else if (!canAdd) {
960
- this.logger.warn(`Dropping checkpoint attestation due to per-(slot, proposalId) attestation cap`, {
961
- slot: attestation.payload.header.slotNumber.toString(),
962
- archive: attestation.archive.toString(),
963
- source: source.toString(),
964
- });
965
- return { result: TopicValidatorResult.Ignore, obj: attestation };
966
- } else {
967
- return { result: TopicValidatorResult.Accept, obj: attestation };
968
- }
969
- };
970
-
971
1008
  const { result, obj: attestation } = await this.validateReceivedMessage<CheckpointAttestation>(
972
- validationFunc,
1009
+ () => this.validateAndStoreCheckpointAttestation(source, CheckpointAttestation.fromBuffer(payloadData)),
973
1010
  msgId,
974
1011
  source,
975
1012
  TopicType.checkpoint_attestation,
@@ -979,8 +1016,8 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
979
1016
  return;
980
1017
  }
981
1018
 
982
- this.logger.debug(
983
- `Received checkpoint attestation for slot ${attestation.slotNumber} from external peer ${source.toString()}`,
1019
+ this.logger.verbose(
1020
+ `Received valid checkpoint attestation for slot ${attestation.slotNumber} from external peer ${source.toString()}`,
984
1021
  {
985
1022
  p2pMessageIdentifier: await attestation.p2pMessageLoggingIdentifier(),
986
1023
  slot: attestation.slotNumber,
@@ -988,60 +1025,167 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
988
1025
  source: source.toString(),
989
1026
  },
990
1027
  );
991
-
992
- await this.mempools.attestationPool.addCheckpointAttestations([attestation]);
993
1028
  }
994
1029
 
995
- private async processBlockFromPeer(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
996
- const validationFunc: () => Promise<ReceivedMessageValidationResult<BlockProposal>> = async () => {
997
- const block = BlockProposal.fromBuffer(payloadData);
998
- const validationResult = await this.validateBlockProposal(source, block);
999
- const isValid = validationResult.result === 'accept';
1000
- const pool = this.mempools.attestationPool;
1001
-
1002
- const exists = isValid && (await pool.hasBlockProposal(block));
1003
- const canAdd = isValid && (await pool.canAddProposal(block));
1004
-
1005
- this.logger.trace(`Validate propagated block proposal`, {
1006
- isValid,
1007
- exists,
1008
- canAdd,
1009
- [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
1010
- [Attributes.P2P_ID]: source.toString(),
1030
+ /** Validates a checkpoint attestation and adds it to the pool. Penalizes the peer if validation fails. */
1031
+ @trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId, attestation) => ({
1032
+ [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber.toString(),
1033
+ }))
1034
+ protected async validateAndStoreCheckpointAttestation(
1035
+ peerId: PeerId,
1036
+ attestation: CheckpointAttestation,
1037
+ ): Promise<ReceivedMessageValidationResult<CheckpointAttestation>> {
1038
+ const validationResult = await this.checkpointAttestationValidator.validate(attestation);
1039
+
1040
+ if (validationResult.result === 'reject') {
1041
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1042
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1043
+ return { result: TopicValidatorResult.Reject };
1044
+ }
1045
+
1046
+ if (validationResult.result === 'ignore') {
1047
+ return { result: TopicValidatorResult.Ignore, obj: attestation };
1048
+ }
1049
+
1050
+ // Try to add the attestation: this handles existence check, cap check, and adding in one call
1051
+ // count is the number of attestations by this signer for this slot (for duplicate detection)
1052
+ const slot = attestation.payload.header.slotNumber;
1053
+ const { added, alreadyExists, count } =
1054
+ await this.mempools.attestationPool.tryAddCheckpointAttestation(attestation);
1055
+
1056
+ this.logger.trace(`Validate propagated checkpoint attestation`, {
1057
+ added,
1058
+ alreadyExists,
1059
+ count,
1060
+ [Attributes.SLOT_NUMBER]: slot.toString(),
1061
+ [Attributes.P2P_ID]: peerId.toString(),
1062
+ });
1063
+
1064
+ // Exact same attestation received, no need to re-broadcast
1065
+ if (alreadyExists) {
1066
+ return { result: TopicValidatorResult.Ignore, obj: attestation };
1067
+ }
1068
+
1069
+ // Could not add (cap reached for signer), no need to re-broadcast
1070
+ if (!added) {
1071
+ this.logger.warn(`Dropping checkpoint attestation due to cap`, {
1072
+ slot: slot.toString(),
1073
+ archive: attestation.archive.toString(),
1074
+ source: peerId.toString(),
1075
+ attester: attestation.getSender()?.toString(),
1076
+ count,
1011
1077
  });
1078
+ return { result: TopicValidatorResult.Ignore, obj: attestation };
1079
+ }
1012
1080
 
1013
- if (validationResult.result === 'reject') {
1014
- return { result: TopicValidatorResult.Reject };
1015
- } else if (validationResult.result === 'ignore' || exists) {
1016
- return { result: TopicValidatorResult.Ignore, obj: block };
1017
- } else if (!canAdd) {
1018
- this.peerManager.penalizePeer(source, PeerErrorSeverity.MidToleranceError);
1019
- this.logger.warn(`Penalizing peer for block proposal exceeding per-slot cap`, {
1020
- slot: block.slotNumber.toString(),
1021
- archive: block.archive.toString(),
1022
- source: source.toString(),
1081
+ // Check if this is a duplicate attestation (signer attested to a different proposal at the same slot)
1082
+ // count is the number of attestations by this signer for this slot
1083
+ if (count === 2) {
1084
+ const attester = attestation.getSender();
1085
+ if (attester) {
1086
+ this.logger.warn(`Detected duplicate attestation (equivocation) at slot ${slot}`, {
1087
+ slot: slot.toString(),
1088
+ archive: attestation.archive.toString(),
1089
+ source: peerId.toString(),
1090
+ attester: attester.toString(),
1023
1091
  });
1024
- return { result: TopicValidatorResult.Reject };
1025
- } else {
1026
- return { result: TopicValidatorResult.Accept, obj: block };
1092
+ this.duplicateAttestationCallback?.({ slot, attester });
1027
1093
  }
1028
- };
1094
+ }
1095
+
1096
+ // Attestation was added successfully - accept it so other nodes can also detect the equivocation
1097
+ return { result: TopicValidatorResult.Accept, obj: attestation };
1098
+ }
1029
1099
 
1030
- const { result, obj: block } = await this.validateReceivedMessage<BlockProposal>(
1031
- validationFunc,
1100
+ protected async processBlockFromPeer(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1101
+ const {
1102
+ result,
1103
+ obj: block,
1104
+ metadata: { isEquivocated } = {},
1105
+ } = await this.validateReceivedMessage<BlockProposal, { isEquivocated: boolean }>(
1106
+ () => this.validateAndStoreBlockProposal(source, BlockProposal.fromBuffer(payloadData)),
1032
1107
  msgId,
1033
1108
  source,
1034
1109
  TopicType.block_proposal,
1035
1110
  );
1036
1111
 
1037
- if (!result || !block) {
1112
+ // If not accepted or equivocated, return
1113
+ if (result !== TopicValidatorResult.Accept || !block || isEquivocated) {
1038
1114
  return;
1039
1115
  }
1040
1116
 
1041
1117
  await this.processValidBlockProposal(block, source);
1042
1118
  }
1043
1119
 
1044
- // REVIEW: callback pattern https://github.com/AztecProtocol/aztec-packages/issues/7963
1120
+ /** Validates a block proposal. Triggers a penalization to the peer that sent it if invalid. Adds to the mempool if valid. */
1121
+ @trackSpan('Libp2pService.validateAndStoreBlockProposal', (_peerId, block) => ({
1122
+ [Attributes.BLOCK_NUMBER]: block.blockNumber.toString(),
1123
+ [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
1124
+ }))
1125
+ protected async validateAndStoreBlockProposal(
1126
+ peerId: PeerId,
1127
+ block: BlockProposal,
1128
+ ): Promise<ReceivedMessageValidationResult<BlockProposal, { isEquivocated: boolean }>> {
1129
+ const validationResult = await this.blockProposalValidator.validate(block);
1130
+
1131
+ if (validationResult.result === 'reject') {
1132
+ this.logger.warn(`Penalizing peer ${peerId} for block proposal validation failure`);
1133
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1134
+ return { result: TopicValidatorResult.Reject };
1135
+ }
1136
+
1137
+ if (validationResult.result === 'ignore') {
1138
+ return { result: TopicValidatorResult.Ignore, obj: block };
1139
+ }
1140
+
1141
+ // Try to add the proposal: this handles existence check, cap check, and adding in one call
1142
+ const { added, alreadyExists, count } = await this.mempools.attestationPool.tryAddBlockProposal(block);
1143
+ const isEquivocated = count !== undefined && count > 1;
1144
+
1145
+ // Duplicate proposal received, no need to re-broadcast
1146
+ if (alreadyExists) {
1147
+ this.logger.debug(`Ignoring duplicate block proposal received`, {
1148
+ ...block.toBlockInfo(),
1149
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1150
+ proposer: block.getSender()?.toString(),
1151
+ source: peerId.toString(),
1152
+ });
1153
+ return { result: TopicValidatorResult.Ignore, obj: block, metadata: { isEquivocated } };
1154
+ }
1155
+
1156
+ // Too many blocks received for this slot and index, penalize peer and do not re-broadcast
1157
+ if (!added) {
1158
+ this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
1159
+ this.logger.warn(`Penalizing peer for block proposal exceeding per-position cap`, {
1160
+ ...block.toBlockInfo(),
1161
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1162
+ count,
1163
+ proposer: block.getSender()?.toString(),
1164
+ source: peerId.toString(),
1165
+ });
1166
+ return { result: TopicValidatorResult.Reject, metadata: { isEquivocated } };
1167
+ }
1168
+
1169
+ // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
1170
+ // and do re-broadcast it so other nodes in the network know to slash the proposer
1171
+ if (isEquivocated) {
1172
+ const proposer = block.getSender();
1173
+ this.logger.warn(`Detected duplicate block proposal (equivocation) at slot ${block.slotNumber}`, {
1174
+ ...block.toBlockInfo(),
1175
+ source: peerId.toString(),
1176
+ proposer: proposer?.toString(),
1177
+ });
1178
+ // Invoke the duplicate callback on the first duplicate spotted only
1179
+ if (proposer && count === 2) {
1180
+ this.duplicateProposalCallback?.({ slot: block.slotNumber, proposer, type: 'block' });
1181
+ }
1182
+ return { result: TopicValidatorResult.Accept, obj: block, metadata: { isEquivocated } };
1183
+ }
1184
+
1185
+ // Otherwise, we're good to go!
1186
+ return { result: TopicValidatorResult.Accept, obj: block };
1187
+ }
1188
+
1045
1189
  // REFACTOR(palla): This method should be moved to the p2p_client or to a separate component,
1046
1190
  // should not be here as it does not deal with p2p networking.
1047
1191
  @trackSpan('Libp2pService.processValidBlockProposal', async block => ({
@@ -1049,7 +1193,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1049
1193
  [Attributes.BLOCK_ARCHIVE]: block.archive.toString(),
1050
1194
  [Attributes.P2P_ID]: await block.p2pMessageLoggingIdentifier().then(i => i.toString()),
1051
1195
  }))
1052
- private async processValidBlockProposal(block: BlockProposal, sender: PeerId) {
1196
+ protected async processValidBlockProposal(block: BlockProposal, sender: PeerId) {
1053
1197
  const slot = block.slotNumber;
1054
1198
  this.logger.verbose(`Received block proposal for slot ${slot} from external peer ${sender.toString()}.`, {
1055
1199
  p2pMessageIdentifier: await block.p2pMessageLoggingIdentifier(),
@@ -1057,30 +1201,14 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1057
1201
  ...block.toBlockInfo(),
1058
1202
  });
1059
1203
 
1060
- // Attempt to add proposal
1061
- try {
1062
- await this.mempools.attestationPool.addBlockProposal(block);
1063
- } catch (err: unknown) {
1064
- // Drop proposals if we hit per-slot cap in the attestation pool; rethrow unknown errors
1065
- if (err instanceof ProposalSlotCapExceededError) {
1066
- this.logger.warn(`Dropping block proposal due to per-slot proposal cap`, {
1067
- slot: String(slot),
1068
- archive: block.archive.toString(),
1069
- error: (err as Error).message,
1070
- });
1071
- return;
1072
- }
1073
- throw err;
1074
- }
1075
-
1076
- // Mark the txs in this proposal as non-evictable
1077
- await this.mempools.txPool.markTxsAsNonEvictable(block.txHashes);
1204
+ // Mark the txs in this proposal as protected
1205
+ await this.mempools.txPool.protectTxs(block.txHashes, block.blockHeader);
1078
1206
 
1079
1207
  // Call the block received callback to validate the proposal.
1080
1208
  // Note: Validators do NOT attest to individual blocks, only to checkpoint proposals.
1081
1209
  const isValid = await this.blockReceivedCallback(block, sender);
1082
1210
  if (!isValid) {
1083
- this.logger.warn(`Block proposal validation failed for block ${block.blockNumber}`, block.toBlockInfo());
1211
+ this.logger.info(`Block proposal validation failed for block ${block.blockNumber}`, block.toBlockInfo());
1084
1212
  }
1085
1213
  }
1086
1214
 
@@ -1088,67 +1216,145 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1088
1216
  * Handle a gossiped checkpoint proposal.
1089
1217
  * Validates and processes the checkpoint proposal, then triggers the callback for attestation.
1090
1218
  */
1091
- private async handleGossipedCheckpointProposal(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1092
- // TODO(palla/mbps): This pattern is repeated across multiple message handlers, consider abstracting it.
1093
- const validationFunc: () => Promise<ReceivedMessageValidationResult<CheckpointProposal>> = async () => {
1094
- const checkpoint = CheckpointProposal.fromBuffer(payloadData);
1095
- const validationResult = await this.validateCheckpointProposal(source, checkpoint);
1096
- const isValid = validationResult.result === 'accept';
1097
- const pool = this.mempools.attestationPool;
1098
-
1099
- const exists = isValid && (await pool.hasCheckpointProposal(checkpoint));
1100
- const canAdd = isValid && (await pool.canAddCheckpointProposal(checkpoint));
1101
-
1102
- this.logger.trace(`Validate propagated checkpoint proposal`, {
1103
- isValid,
1104
- exists,
1105
- canAdd,
1219
+ protected async handleGossipedCheckpointProposal(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1220
+ const {
1221
+ result,
1222
+ obj: checkpoint,
1223
+ metadata: { isEquivocated, processBlock } = {},
1224
+ } = await this.validateReceivedMessage<CheckpointProposal, { isEquivocated: boolean; processBlock: boolean }>(
1225
+ () => this.validateAndStoreCheckpointProposal(source, CheckpointProposal.fromBuffer(payloadData)),
1226
+ msgId,
1227
+ source,
1228
+ TopicType.checkpoint_proposal,
1229
+ );
1230
+
1231
+ // If the checkpoint contained a valid last block, we process it even if the checkpoint itself is to be rejected
1232
+ // TODO(palla/mbps): Is this ok? Should we be considering a block from a checkpoint that was equivocated?
1233
+ if (processBlock && checkpoint?.getBlockProposal()) {
1234
+ await this.processValidBlockProposal(checkpoint.getBlockProposal()!, source);
1235
+ }
1236
+
1237
+ if (result !== TopicValidatorResult.Accept || !checkpoint || isEquivocated) {
1238
+ return;
1239
+ }
1240
+
1241
+ await this.processValidCheckpointProposal(checkpoint.toCore(), source);
1242
+ }
1243
+
1244
+ /**
1245
+ * Validates a checkpoint proposal. Penalizes peer if validation fails. Adds the checkpoint and
1246
+ * its last block (if present) to the mempool if valid. Triggers equivocation detection on both.
1247
+ */
1248
+ @trackSpan('Libp2pService.validateAndStoreCheckpointProposal', (_peerId, checkpoint) => ({
1249
+ [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1250
+ }))
1251
+ protected async validateAndStoreCheckpointProposal(
1252
+ peerId: PeerId,
1253
+ checkpoint: CheckpointProposal,
1254
+ ): Promise<ReceivedMessageValidationResult<CheckpointProposal, { isEquivocated: boolean; processBlock: boolean }>> {
1255
+ const validationResult = await this.checkpointProposalValidator.validate(checkpoint);
1256
+
1257
+ if (validationResult.result === 'reject') {
1258
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
1259
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1260
+ return { result: TopicValidatorResult.Reject };
1261
+ }
1262
+
1263
+ if (validationResult.result === 'ignore') {
1264
+ return { result: TopicValidatorResult.Ignore, obj: checkpoint };
1265
+ }
1266
+
1267
+ // Extract and try to add the block proposal first if present
1268
+ const blockProposal = checkpoint.getBlockProposal();
1269
+ let processBlock = false;
1270
+ if (blockProposal) {
1271
+ this.logger.debug(`Validating block proposal from propagated checkpoint`, {
1106
1272
  [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1107
- [Attributes.P2P_ID]: source.toString(),
1273
+ [Attributes.P2P_ID]: peerId.toString(),
1108
1274
  });
1109
-
1110
- if (validationResult.result === 'reject') {
1111
- return { result: TopicValidatorResult.Reject };
1112
- } else if (validationResult.result === 'ignore' || exists) {
1113
- return { result: TopicValidatorResult.Ignore, obj: checkpoint };
1114
- } else if (!canAdd) {
1115
- this.peerManager.penalizePeer(source, PeerErrorSeverity.MidToleranceError);
1116
- this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
1117
- slot: checkpoint.slotNumber.toString(),
1118
- archive: checkpoint.archive.toString(),
1119
- source: source.toString(),
1275
+ const {
1276
+ result,
1277
+ obj,
1278
+ metadata: { isEquivocated } = {},
1279
+ } = await this.validateAndStoreBlockProposal(peerId, blockProposal);
1280
+ if (result === TopicValidatorResult.Reject || !obj || isEquivocated) {
1281
+ this.logger.debug(`Rejecting checkpoint due to invalid last block proposal`, {
1282
+ [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1283
+ [Attributes.P2P_ID]: peerId.toString(),
1284
+ isEquivocated,
1285
+ result,
1120
1286
  });
1121
1287
  return { result: TopicValidatorResult.Reject };
1122
- } else {
1123
- return { result: TopicValidatorResult.Accept, obj: checkpoint };
1288
+ } else if (result === TopicValidatorResult.Accept && obj && !isEquivocated) {
1289
+ processBlock = true;
1124
1290
  }
1125
- };
1291
+ }
1126
1292
 
1127
- const { result, obj: checkpoint } = await this.validateReceivedMessage<CheckpointProposal>(
1128
- validationFunc,
1129
- msgId,
1130
- source,
1131
- TopicType.checkpoint_proposal,
1132
- );
1293
+ // Try to add the checkpoint proposal core: this handles existence check, cap check, and adding in one call
1294
+ const checkpointCore = checkpoint.toCore();
1295
+ const tryAddResult = await this.mempools.attestationPool.tryAddCheckpointProposal(checkpointCore);
1296
+ const { added, alreadyExists, count } = tryAddResult;
1297
+ const isEquivocated = count !== undefined && count > 1;
1298
+
1299
+ // Duplicate proposal received, do not re-broadcast
1300
+ if (alreadyExists) {
1301
+ this.logger.debug(`Ignoring duplicate checkpoint proposal received`, {
1302
+ ...checkpoint.toCheckpointInfo(),
1303
+ source: peerId.toString(),
1304
+ });
1305
+ return {
1306
+ result: TopicValidatorResult.Ignore,
1307
+ obj: checkpoint,
1308
+ metadata: { isEquivocated, processBlock },
1309
+ };
1310
+ }
1133
1311
 
1134
- if (result !== TopicValidatorResult.Accept || !checkpoint) {
1135
- return;
1312
+ // Too many checkpoint proposals received for this slot, penalize peer and do not re-broadcast
1313
+ // Note: We still return the checkpoint obj so the lastBlock can be processed if valid
1314
+ if (!added) {
1315
+ this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
1316
+ this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
1317
+ ...checkpoint.toCheckpointInfo(),
1318
+ count,
1319
+ source: peerId.toString(),
1320
+ });
1321
+ return { result: TopicValidatorResult.Reject, obj: checkpoint, metadata: { isEquivocated, processBlock } };
1322
+ }
1323
+
1324
+ // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
1325
+ // and do re-broadcast it so other nodes in the network know to slash the proposer
1326
+ if (isEquivocated) {
1327
+ const proposer = checkpoint.getSender();
1328
+ this.logger.warn(`Detected duplicate checkpoint proposal (equivocation) at slot ${checkpoint.slotNumber}`, {
1329
+ ...checkpoint.toCheckpointInfo(),
1330
+ source: peerId.toString(),
1331
+ proposer: proposer?.toString(),
1332
+ });
1333
+ // Invoke the duplicate callback on the first duplicate spotted only
1334
+ if (proposer && count === 2) {
1335
+ this.duplicateProposalCallback?.({ slot: checkpoint.slotNumber, proposer, type: 'checkpoint' });
1336
+ }
1337
+ return {
1338
+ result: TopicValidatorResult.Accept,
1339
+ obj: checkpoint,
1340
+ metadata: { isEquivocated, processBlock },
1341
+ };
1136
1342
  }
1137
1343
 
1138
- await this.processValidCheckpointProposal(checkpoint, source);
1344
+ // Otherwise, we're good to go!
1345
+ return { result: TopicValidatorResult.Accept, obj: checkpoint, metadata: { processBlock, isEquivocated } };
1139
1346
  }
1140
1347
 
1141
1348
  /**
1142
1349
  * Process a validated checkpoint proposal.
1143
- * Extracts and processes the last block proposal (if present) first, then processes the checkpoint.
1144
- * The block callback is invoked before the checkpoint callback.
1350
+ * Note: The proposal was already added to the pool by tryAddCheckpointProposal in handleGossipedCheckpointProposal.
1145
1351
  */
1146
1352
  @trackSpan('Libp2pService.processValidCheckpointProposal', async checkpoint => ({
1147
1353
  [Attributes.SLOT_NUMBER]: checkpoint.slotNumber,
1148
1354
  [Attributes.BLOCK_ARCHIVE]: checkpoint.archive.toString(),
1149
1355
  [Attributes.P2P_ID]: await checkpoint.p2pMessageLoggingIdentifier().then(i => i.toString()),
1150
1356
  }))
1151
- private async processValidCheckpointProposal(checkpoint: CheckpointProposal, sender: PeerId) {
1357
+ protected async processValidCheckpointProposal(checkpoint: CheckpointProposalCore, sender: PeerId) {
1152
1358
  const slot = checkpoint.slotNumber;
1153
1359
  this.logger.verbose(`Received checkpoint proposal for slot ${slot} from external peer ${sender.toString()}.`, {
1154
1360
  p2pMessageIdentifier: await checkpoint.p2pMessageLoggingIdentifier(),
@@ -1157,37 +1363,12 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1157
1363
  source: sender.toString(),
1158
1364
  });
1159
1365
 
1160
- // Extract block proposal before adding to pool (pool stores them separately)
1161
- const blockProposal = checkpoint.getBlockProposal();
1162
-
1163
- // Add proposal to the pool (this extracts and stores block proposal separately)
1164
- await this.mempools.attestationPool.addCheckpointProposal(checkpoint);
1165
-
1166
- // Mark txs as non-evictable if present (from the last block)
1167
- if (checkpoint.txHashes.length > 0) {
1168
- await this.mempools.txPool.markTxsAsNonEvictable(checkpoint.txHashes);
1169
- }
1170
-
1171
- // If there was a last block proposal, invoke the block callback first for validation.
1172
- // Note: The block proposal is already stored in the pool by addCheckpointProposal.
1173
- if (blockProposal) {
1174
- const isValid = await this.blockReceivedCallback(blockProposal, sender);
1175
- if (!isValid) {
1176
- this.logger.warn(`Block proposal from checkpoint failed validation`, {
1177
- slot: slot.toString(),
1178
- archive: checkpoint.archive.toString(),
1179
- blockNumber: blockProposal.blockNumber.toString(),
1180
- });
1181
- return;
1182
- }
1183
- }
1184
-
1185
1366
  // Call the checkpoint received callback with the core version (without lastBlock)
1186
1367
  // to validate and potentially generate attestations
1187
- const attestations = await this.checkpointReceivedCallback(checkpoint.toCore(), sender);
1368
+ const attestations = await this.checkpointReceivedCallback(checkpoint, sender);
1188
1369
  if (attestations && attestations.length > 0) {
1189
1370
  // If the callback returned attestations, add them to the pool and propagate them
1190
- await this.mempools.attestationPool.addCheckpointAttestations(attestations);
1371
+ await this.mempools.attestationPool.addOwnCheckpointAttestations(attestations);
1191
1372
  for (const attestation of attestations) {
1192
1373
  await this.propagate(attestation);
1193
1374
  }
@@ -1216,7 +1397,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1216
1397
  @trackSpan('Libp2pService.validateRequestedBlockTxs', request => ({
1217
1398
  [Attributes.BLOCK_ARCHIVE]: request.archiveRoot.toString(),
1218
1399
  }))
1219
- private async validateRequestedBlockTxs(
1400
+ protected async validateRequestedBlockTxs(
1220
1401
  request: BlockTxsRequest,
1221
1402
  response: BlockTxsResponse,
1222
1403
  peerId: PeerId,
@@ -1346,7 +1527,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1346
1527
  @trackSpan('Libp2pService.validateRequestedBlock', (requestedBlockNumber, _responseBlock) => ({
1347
1528
  [Attributes.BLOCK_NUMBER]: requestedBlockNumber.toString(),
1348
1529
  }))
1349
- private async validateRequestedBlock(
1530
+ protected async validateRequestedBlock(
1350
1531
  requestedBlockNumber: Fr,
1351
1532
  responseBlock: L2Block,
1352
1533
  peerId: PeerId,
@@ -1379,7 +1560,12 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1379
1560
  }
1380
1561
  }
1381
1562
 
1382
- private async validateRequestedTx(tx: Tx, peerId: PeerId, txValidator: TxValidator, requested?: Set<`0x${string}`>) {
1563
+ protected async validateRequestedTx(
1564
+ tx: Tx,
1565
+ peerId: PeerId,
1566
+ txValidator: TxValidator,
1567
+ requested?: Set<`0x${string}`>,
1568
+ ) {
1383
1569
  const penalize = (severity: PeerErrorSeverity) => this.peerManager.penalizePeer(peerId, severity);
1384
1570
  if (requested && !requested.has(tx.getTxHash().toString())) {
1385
1571
  penalize(PeerErrorSeverity.MidToleranceError);
@@ -1393,44 +1579,13 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1393
1579
  }
1394
1580
  }
1395
1581
 
1396
- private createRequestedTxValidator(): TxValidator {
1397
- return createTxReqRespValidator(this.proofVerifier, {
1582
+ protected createRequestedTxValidator(): TxValidator {
1583
+ return createTxValidatorForReqResponseReceivedTxs(this.proofVerifier, {
1398
1584
  l1ChainId: this.config.l1ChainId,
1399
1585
  rollupVersion: this.config.rollupVersion,
1400
1586
  });
1401
1587
  }
1402
1588
 
1403
- @trackSpan('Libp2pService.validatePropagatedTx', tx => ({
1404
- [Attributes.TX_HASH]: tx.getTxHash().toString(),
1405
- }))
1406
- private async validatePropagatedTx(tx: Tx, peerId: PeerId): Promise<boolean> {
1407
- const currentBlockNumber = await this.archiver.getBlockNumber();
1408
-
1409
- // We accept transactions if they are not expired by the next slot (checked based on the IncludeByTimestamp field)
1410
- const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
1411
- const messageValidators = await this.createMessageValidators(currentBlockNumber, nextSlotTimestamp);
1412
-
1413
- for (const validator of messageValidators) {
1414
- const outcome = await this.runValidations(tx, validator);
1415
-
1416
- if (outcome.allPassed) {
1417
- continue;
1418
- }
1419
- const { name } = outcome.failure;
1420
- let { severity } = outcome.failure;
1421
-
1422
- // Double spend validator has a special case handler
1423
- if (name === 'doubleSpendValidator') {
1424
- const txBlockNumber = BlockNumber(currentBlockNumber + 1); // tx is expected to be in the next block
1425
- severity = await this.handleDoubleSpendFailure(tx, txBlockNumber);
1426
- }
1427
-
1428
- this.peerManager.penalizePeer(peerId, severity);
1429
- return false;
1430
- }
1431
- return true;
1432
- }
1433
-
1434
1589
  private async getGasFees(blockNumber: BlockNumber): Promise<GasFees> {
1435
1590
  if (blockNumber === this.feesCache?.blockNumber) {
1436
1591
  return this.feesCache.gasFees;
@@ -1458,60 +1613,62 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1458
1613
  };
1459
1614
  }
1460
1615
 
1461
- public async validate(txs: Tx[]): Promise<void> {
1462
- const currentBlockNumber = await this.archiver.getBlockNumber();
1463
-
1464
- // We accept transactions if they are not expired by the next slot (checked based on the IncludeByTimestamp field)
1465
- const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
1466
- const messageValidators = await this.createMessageValidators(currentBlockNumber, nextSlotTimestamp);
1616
+ public async validateTxsReceivedInBlockProposal(txs: Tx[]): Promise<void> {
1617
+ const validator = createTxValidatorForBlockProposalReceivedTxs(
1618
+ this.proofVerifier,
1619
+ { l1ChainId: this.config.l1ChainId, rollupVersion: this.config.rollupVersion },
1620
+ this.logger.getBindings(),
1621
+ );
1467
1622
 
1468
- await Promise.all(
1623
+ const results = await Promise.all(
1469
1624
  txs.map(async tx => {
1470
- for (const validator of messageValidators) {
1471
- const outcome = await this.runValidations(tx, validator);
1472
- if (!outcome.allPassed) {
1473
- throw new Error('Invalid tx detected', { cause: { outcome } });
1474
- }
1475
- }
1625
+ const result = await validator.validateTx(tx);
1626
+ return result.result !== 'invalid';
1476
1627
  }),
1477
1628
  );
1629
+ if (results.some(value => value === false)) {
1630
+ throw new Error('Invalid tx detected');
1631
+ }
1478
1632
  }
1479
1633
 
1480
- /**
1481
- * Create message validators for the given block number and timestamp.
1482
- *
1483
- * Each validator is a pair of a validator and a severity.
1484
- * If a validator fails, the peer is penalized with the severity of the validator.
1485
- *
1486
- * @param currentBlockNumber - The current synced block number.
1487
- * @param nextSlotTimestamp - The timestamp of the next slot (used to validate txs are not expired).
1488
- * @returns The message validators.
1489
- */
1490
- private async createMessageValidators(
1634
+ /** Creates the first stage (fast) validators for gossiped transactions. */
1635
+ protected async createFirstStageMessageValidators(
1491
1636
  currentBlockNumber: BlockNumber,
1492
1637
  nextSlotTimestamp: UInt64,
1493
- ): Promise<Record<string, MessageValidator>[]> {
1638
+ ): Promise<Record<string, TransactionValidator>> {
1494
1639
  const gasFees = await this.getGasFees(currentBlockNumber);
1495
- const allowedInSetup = this.config.txPublicSetupAllowList ?? (await getDefaultAllowedSetupFunctions());
1496
-
1497
- const blockNumberInWhichTheTxIsConsideredToBeIncluded = BlockNumber(currentBlockNumber + 1);
1498
-
1499
- return createTxMessageValidators(
1640
+ const allowedInSetup = [
1641
+ ...(await getDefaultAllowedSetupFunctions()),
1642
+ ...(this.config.txPublicSetupAllowListExtend ?? []),
1643
+ ];
1644
+ const blockNumber = BlockNumber(currentBlockNumber + 1);
1645
+ const l1Constants = await this.archiver.getL1Constants();
1646
+
1647
+ return createFirstStageTxValidationsForGossipedTransactions(
1500
1648
  nextSlotTimestamp,
1501
- blockNumberInWhichTheTxIsConsideredToBeIncluded,
1649
+ blockNumber,
1502
1650
  this.worldStateSynchronizer,
1503
1651
  gasFees,
1504
1652
  this.config.l1ChainId,
1505
1653
  this.config.rollupVersion,
1506
1654
  protocolContractsHash,
1507
1655
  this.archiver,
1508
- this.proofVerifier,
1509
1656
  !this.config.disableTransactions,
1510
1657
  allowedInSetup,
1511
1658
  this.logger.getBindings(),
1659
+ {
1660
+ rollupManaLimit: l1Constants.rollupManaLimit,
1661
+ maxBlockL2Gas: this.config.validateMaxL2BlockGas,
1662
+ maxBlockDAGas: this.config.validateMaxDABlockGas,
1663
+ },
1512
1664
  );
1513
1665
  }
1514
1666
 
1667
+ /** Creates the second stage (expensive proof verification) validators for gossiped transactions. */
1668
+ protected createSecondStageMessageValidators(): Record<string, TransactionValidator> {
1669
+ return createSecondStageTxValidationsForGossipedTransactions(this.proofVerifier, this.logger.getBindings());
1670
+ }
1671
+
1515
1672
  /**
1516
1673
  * Run validations on a tx.
1517
1674
  * @param tx - The tx to validate.
@@ -1520,7 +1677,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1520
1677
  */
1521
1678
  private async runValidations(
1522
1679
  tx: Tx,
1523
- messageValidators: Record<string, MessageValidator>,
1680
+ messageValidators: Record<string, TransactionValidator>,
1524
1681
  ): Promise<ValidationOutcome> {
1525
1682
  const validationPromises = Object.entries(messageValidators).map(async ([name, { validator, severity }]) => {
1526
1683
  const { result } = await validator.validateTx(tx);
@@ -1529,8 +1686,10 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1529
1686
 
1530
1687
  // A promise that resolves when all validations have been run
1531
1688
  const allValidations = await Promise.all(validationPromises);
1532
- const failed = allValidations.find(x => !x.isValid);
1533
- if (failed) {
1689
+ const failures = allValidations.filter(x => !x.isValid);
1690
+ if (failures.length > 0) {
1691
+ // Pick the most severe failure (lowest tolerance = harshest penalty)
1692
+ const failed = maxBy(failures, f => PeerErrorSeverityByHarshness.indexOf(f.severity))!;
1534
1693
  return {
1535
1694
  allPassed: false,
1536
1695
  failure: {
@@ -1601,50 +1760,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1601
1760
  const result = await this.checkpointAttestationValidator.validate(attestation);
1602
1761
 
1603
1762
  if (result.result === 'reject') {
1604
- this.logger.debug(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1605
- this.peerManager.penalizePeer(peerId, result.severity);
1606
- }
1607
-
1608
- return result;
1609
- }
1610
-
1611
- /**
1612
- * Validate a block proposal.
1613
- *
1614
- * @param block - The block proposal to validate.
1615
- * @returns True if the block proposal is valid, false otherwise.
1616
- */
1617
- @trackSpan('Libp2pService.validateBlockProposal', (_peerId, block) => ({
1618
- [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
1619
- }))
1620
- public async validateBlockProposal(peerId: PeerId, block: BlockProposal): Promise<P2PValidationResult> {
1621
- const result = await this.blockProposalValidator.validate(block);
1622
-
1623
- if (result.result === 'reject') {
1624
- this.logger.debug(`Penalizing peer ${peerId} for block proposal validation failure`);
1625
- this.peerManager.penalizePeer(peerId, result.severity);
1626
- }
1627
-
1628
- return result;
1629
- }
1630
-
1631
- /**
1632
- * Validate a checkpoint proposal.
1633
- *
1634
- * @param checkpoint - The checkpoint proposal to validate.
1635
- * @returns True if the checkpoint proposal is valid, false otherwise.
1636
- */
1637
- @trackSpan('Libp2pService.validateCheckpointProposal', (_peerId, checkpoint) => ({
1638
- [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1639
- }))
1640
- public async validateCheckpointProposal(
1641
- peerId: PeerId,
1642
- checkpoint: CheckpointProposal,
1643
- ): Promise<P2PValidationResult> {
1644
- const result = await this.checkpointProposalValidator.validate(checkpoint);
1645
-
1646
- if (result.result === 'reject') {
1647
- this.logger.debug(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
1763
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1648
1764
  this.peerManager.penalizePeer(peerId, result.severity);
1649
1765
  }
1650
1766