@aztec/p2p 0.0.1-commit.e2b2873ed → 0.0.1-commit.e304674f1

package/dest/services/libp2p/libp2p_service.js

@@ -370,14 +370,15 @@ function applyDecs2203RFactory() {
 function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
     return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
 }
-var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _dec8, _dec9, _initProto;
+var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _initProto;
 import { BlockNumber } from '@aztec/foundation/branded-types';
+import { maxBy } from '@aztec/foundation/collection';
 import { createLibp2pComponentLogger, createLogger } from '@aztec/foundation/log';
 import { RunningPromise } from '@aztec/foundation/running-promise';
 import { Timer } from '@aztec/foundation/timer';
 import { protocolContractsHash } from '@aztec/protocol-contracts';
 import { GasFees } from '@aztec/stdlib/gas';
-import { BlockProposal, CheckpointAttestation, CheckpointProposal, P2PClientType, P2PMessage, PeerErrorSeverity, TopicType, createTopicString, getTopicsForClientAndConfig, metricsTopicStrToLabels } from '@aztec/stdlib/p2p';
+import { BlockProposal, CheckpointAttestation, CheckpointProposal, P2PMessage, PeerErrorSeverity, PeerErrorSeverityByHarshness, TopicType, createTopicString, getTopicsForConfig, metricsTopicStrToLabels } from '@aztec/stdlib/p2p';
 import { MerkleTreeId } from '@aztec/stdlib/trees';
 import { Tx } from '@aztec/stdlib/tx';
 import { compressComponentVersions } from '@aztec/stdlib/versioning';
@@ -394,9 +395,10 @@ import { mplex } from '@libp2p/mplex';
 import { tcp } from '@libp2p/tcp';
 import { ENR } from '@nethermindeth/enr';
 import { createLibp2p } from 'libp2p';
+import { CheckpointProposalReceivedCallbackNotRegisteredError } from '../../errors/p2p-service.error.js';
 import { BlockProposalValidator, CheckpointAttestationValidator, CheckpointProposalValidator, DoubleSpendTxValidator, FishermanAttestationValidator, getDefaultAllowedSetupFunctions } from '../../msg_validators/index.js';
 import { MessageSeenValidator } from '../../msg_validators/msg_seen_validator/msg_seen_validator.js';
-import { createTxMessageValidators, createTxReqRespValidator } from '../../msg_validators/tx_validator/factory.js';
+import { createFirstStageTxValidationsForGossipedTransactions, createSecondStageTxValidationsForGossipedTransactions, createTxValidatorForBlockProposalReceivedTxs, createTxValidatorForReqResponseReceivedTxs } from '../../msg_validators/tx_validator/factory.js';
 import { GossipSubEvent } from '../../types/index.js';
 import { convertToMultiaddr } from '../../util.js';
 import { getVersions } from '../../versioning.js';
@@ -407,8 +409,7 @@ import { APP_SPECIFIC_WEIGHT, gossipScoreThresholds } from '../gossipsub/scoring
 import { createAllTopicScoreParams } from '../gossipsub/topic_score_params.js';
 import { PeerManager } from '../peer-manager/peer_manager.js';
 import { PeerScoring } from '../peer-manager/peer_scoring.js';
-import { DEFAULT_SUB_PROTOCOL_VALIDATORS, ReqRespSubProtocol, ValidationError } from '../reqresp/index.js';
-import { pingHandler, reqGoodbyeHandler, reqRespBlockHandler, reqRespBlockTxsHandler, reqRespStatusHandler, reqRespTxHandler } from '../reqresp/index.js';
+import { DEFAULT_SUB_PROTOCOL_VALIDATORS, ReqRespSubProtocol, ValidationError, pingHandler, reqGoodbyeHandler, reqRespBlockTxsHandler, reqRespStatusHandler, reqRespTxHandler } from '../reqresp/index.js';
 import { ReqResp } from '../reqresp/reqresp.js';
 import { P2PInstrumentation } from './instrumentation.js';
 _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId, attestation)=>({
@@ -430,19 +431,10 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         [Attributes.BLOCK_ARCHIVE]: request.archiveRoot.toString()
     })), _dec6 = trackSpan('Libp2pService.validateRequestedTx', (requestedTxHash, _responseTx)=>({
         [Attributes.TX_HASH]: requestedTxHash.toString()
-    })), _dec7 = trackSpan('Libp2pService.validateRequestedBlock', (requestedBlockNumber, _responseBlock)=>({
-        [Attributes.BLOCK_NUMBER]: requestedBlockNumber.toString()
-    })), _dec8 = trackSpan('Libp2pService.validatePropagatedTx', (tx)=>({
-        [Attributes.TX_HASH]: tx.getTxHash().toString()
-    })), _dec9 = trackSpan('Libp2pService.validateCheckpointAttestation', async (_, attestation)=>({
-        [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber,
-        [Attributes.BLOCK_ARCHIVE]: attestation.archive.toString(),
-        [Attributes.P2P_ID]: await attestation.p2pMessageLoggingIdentifier().then((i)=>i.toString())
     }));
 /**
  * Lib P2P implementation of the P2PService interface.
  */ export class LibP2PService extends WithTracer {
-    clientType;
     config;
     node;
     peerDiscoveryService;
@@ -489,21 +481,6 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
                 _dec6,
                 2,
                 "validateRequestedTxs"
-            ],
-            [
-                _dec7,
-                2,
-                "validateRequestedBlock"
-            ],
-            [
-                _dec8,
-                2,
-                "validatePropagatedTx"
-            ],
-            [
-                _dec9,
-                2,
-                "validateCheckpointAttestation"
             ]
         ], []));
     }
@@ -527,13 +504,18 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
    * Callback for when a checkpoint proposal is received from a peer.
    * @param checkpoint - The checkpoint proposal received from the peer.
    * @returns The attestations for the checkpoint, if any.
-   */ checkpointReceivedCallback;
+   */ allNodesCheckpointReceivedCallback;
+    /**
+   * Callback for when a checkpoint proposal is received - specifically for validators - from a peer.
+   * @param checkpoint - The checkpoint proposal received from the peer.
+   * @returns The attestations for the checkpoint, if any.
+   */ validatorCheckpointReceivedCallback;
     gossipSubEventHandler;
     instrumentation;
     telemetry;
     logger;
-    constructor(clientType, config, node, peerDiscoveryService, reqresp, peerManager, mempools, archiver, epochCache, proofVerifier, worldStateSynchronizer, telemetry, logger = createLogger('p2p:libp2p_service')){
-        super(telemetry, 'LibP2PService'), this.clientType = clientType, this.config = config, this.node = node, this.peerDiscoveryService = peerDiscoveryService, this.reqresp = reqresp, this.peerManager = peerManager, this.mempools = mempools, this.archiver = archiver, this.epochCache = epochCache, this.proofVerifier = proofVerifier, this.worldStateSynchronizer = worldStateSynchronizer, this.msgIdSeenValidators = (_initProto(this), {}), this.protocolVersion = '', this.topicStrings = {};
+    constructor(config, node, peerDiscoveryService, reqresp, peerManager, mempools, archiver, epochCache, proofVerifier, worldStateSynchronizer, telemetry, logger = createLogger('p2p:libp2p_service')){
+        super(telemetry, 'LibP2PService'), this.config = config, this.node = node, this.peerDiscoveryService = peerDiscoveryService, this.reqresp = reqresp, this.peerManager = peerManager, this.mempools = mempools, this.archiver = archiver, this.epochCache = epochCache, this.proofVerifier = proofVerifier, this.worldStateSynchronizer = worldStateSynchronizer, this.msgIdSeenValidators = (_initProto(this), {}), this.protocolVersion = '', this.topicStrings = {};
         this.telemetry = telemetry;
         // Create child logger with fisherman prefix if in fisherman mode
         this.logger = config.fishermanMode ? logger.createChild('[FISHERMAN]') : logger;
@@ -549,22 +531,24 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         this.topicStrings[TopicType.block_proposal] = createTopicString(TopicType.block_proposal, this.protocolVersion);
         this.topicStrings[TopicType.checkpoint_proposal] = createTopicString(TopicType.checkpoint_proposal, this.protocolVersion);
         this.topicStrings[TopicType.checkpoint_attestation] = createTopicString(TopicType.checkpoint_attestation, this.protocolVersion);
-        this.blockProposalValidator = new BlockProposalValidator(epochCache, {
-            txsPermitted: !config.disableTransactions
-        });
-        this.checkpointProposalValidator = new CheckpointProposalValidator(epochCache, {
-            txsPermitted: !config.disableTransactions
-        });
+        const proposalValidatorOpts = {
+            txsPermitted: !config.disableTransactions,
+            maxTxsPerBlock: config.validateMaxTxsPerBlock ?? config.validateMaxTxsPerCheckpoint
+        };
+        this.blockProposalValidator = new BlockProposalValidator(epochCache, proposalValidatorOpts);
+        this.checkpointProposalValidator = new CheckpointProposalValidator(epochCache, proposalValidatorOpts);
         this.checkpointAttestationValidator = config.fishermanMode ? new FishermanAttestationValidator(epochCache, mempools.attestationPool, telemetry) : new CheckpointAttestationValidator(epochCache);
         this.gossipSubEventHandler = this.handleGossipSubEvent.bind(this);
         this.blockReceivedCallback = async (block)=>{
-            this.logger.debug(`Handler not yet registered: Block received callback not set. Received block for slot ${block.slotNumber} from peer.`, {
+            this.logger.warn(`Handler for block received not yet registered on P2P service. Received block ${block.blockNumber} for slot ${block.slotNumber} from peer.`, {
                 p2pMessageIdentifier: await block.p2pMessageLoggingIdentifier()
             });
-            return false;
+            return true;
         };
-        this.checkpointReceivedCallback = (checkpoint)=>{
-            this.logger.debug(`Handler not yet registered: Checkpoint received callback not set. Received checkpoint for slot ${checkpoint.slotNumber} from peer.`);
+        this.allNodesCheckpointReceivedCallback = (_checkpoint)=>{
+            throw new CheckpointProposalReceivedCallbackNotRegisteredError();
+        };
+        this.validatorCheckpointReceivedCallback = (_checkpoint)=>{
             return Promise.resolve(undefined);
         };
     }
@@ -576,7 +560,7 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
    * @param config - The configuration to use when creating the service.
    * @param txPool - The transaction pool to be accessed by the service.
    * @returns The new service.
-   */ static async new(clientType, config, peerId, deps) {
+   */ static async new(config, peerId, deps) {
         const { worldStateSynchronizer, epochCache, l2BlockSource, mempools, proofVerifier, peerStore, telemetry, logger, packageVersion } = deps;
         const { p2pPort, maxPeerCount, listenAddress } = config;
         const bindAddrTcp = convertToMultiaddr(listenAddress, p2pPort, 'tcp');
@@ -619,7 +603,8 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
             slotDurationMs: l1Constants.slotDuration * 1000,
             heartbeatIntervalMs: config.gossipsubInterval,
             targetCommitteeSize: l1Constants.targetCommitteeSize,
-            blockDurationMs: config.blockDurationMs
+            blockDurationMs: config.blockDurationMs,
+            expectedBlockProposalsPerSlot: config.expectedBlockProposalsPerSlot
         });
         const node = await createLibp2p({
             start: false,
@@ -740,7 +725,7 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         // Note: positive topic scores can offset penalties, so alignment is best-effort.
         node.services.pubsub.score.params.appSpecificWeight = APP_SPECIFIC_WEIGHT;
         node.services.pubsub.score.params.appSpecificScore = (peerId)=>peerManager.shouldDisableP2PGossip(peerId) ? -Infinity : peerManager.getPeerScore(peerId);
-        return new LibP2PService(clientType, config, node, peerDiscoveryService, reqresp, peerManager, mempools, l2BlockSource, epochCache, proofVerifier, worldStateSynchronizer, telemetry, logger);
+        return new LibP2PService(config, node, peerDiscoveryService, reqresp, peerManager, mempools, l2BlockSource, epochCache, proofVerifier, worldStateSynchronizer, telemetry, logger);
     }
     /**
    * Starts the LibP2P service.
@@ -759,13 +744,11 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         // Create request response protocol handlers
         const txHandler = reqRespTxHandler(this.mempools);
         const goodbyeHandler = reqGoodbyeHandler(this.peerManager);
-        const blockHandler = reqRespBlockHandler(this.archiver);
         const statusHandler = reqRespStatusHandler(this.protocolVersion, this.worldStateSynchronizer, this.logger);
         const requestResponseHandlers = {
             [ReqRespSubProtocol.PING]: pingHandler,
             [ReqRespSubProtocol.STATUS]: statusHandler.bind(this),
-            [ReqRespSubProtocol.GOODBYE]: goodbyeHandler.bind(this),
-            [ReqRespSubProtocol.BLOCK]: blockHandler.bind(this)
+            [ReqRespSubProtocol.GOODBYE]: goodbyeHandler.bind(this)
         };
         if (!this.config.disableTransactions) {
             const blockTxsHandler = reqRespBlockTxsHandler(this.mempools.attestationPool, this.archiver, this.mempools.txPool);
@@ -778,14 +761,13 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         const reqrespSubProtocolValidators = {
             ...DEFAULT_SUB_PROTOCOL_VALIDATORS,
             [ReqRespSubProtocol.TX]: this.validateRequestedTxs.bind(this),
-            [ReqRespSubProtocol.BLOCK_TXS]: this.validateRequestedBlockTxs.bind(this),
-            [ReqRespSubProtocol.BLOCK]: this.validateRequestedBlock.bind(this)
+            [ReqRespSubProtocol.BLOCK_TXS]: this.validateRequestedBlockTxs.bind(this)
         };
         await this.peerManager.initializePeers();
         await this.reqresp.start(requestResponseHandlers, reqrespSubProtocolValidators);
         await this.node.start();
         // Subscribe to standard GossipSub topics by default
-        for (const topic of getTopicsForClientAndConfig(this.clientType, this.config.disableTransactions)){
+        for (const topic of getTopicsForConfig(this.config.disableTransactions)){
             this.subscribeToTopic(this.topicStrings[topic]);
         }
         // add GossipSub listener
@@ -833,6 +815,9 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
     getPeers(includePending) {
         return this.peerManager.getPeers(includePending);
     }
+    getGossipMeshPeerCount(topicType) {
+        return this.node.services.pubsub.getMeshPeers(this.topicStrings[topicType]).length;
+    }
     handleGossipSubEvent(e) {
         this.logger.trace(`Received PUBSUB message.`);
         const safeJob = async ()=>{
@@ -864,8 +849,14 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
     registerBlockReceivedCallback(callback) {
         this.blockReceivedCallback = callback;
     }
-    registerCheckpointReceivedCallback(callback) {
-        this.checkpointReceivedCallback = callback;
+    registerValidatorCheckpointReceivedCallback(callback) {
+        this.validatorCheckpointReceivedCallback = callback;
+    }
+    registerAllNodesCheckpointReceivedCallback(callback) {
+        this.allNodesCheckpointReceivedCallback = callback;
+    }
+    async notifyOwnCheckpointProposal(checkpoint) {
+        await this.allNodesCheckpointReceivedCallback(checkpoint, this.node.peerId);
     }
     /**
    * Registers a callback to be invoked when a duplicate proposal is detected.
@@ -931,6 +922,12 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         if (!validator || !validator.addMessage(msgId)) {
             this.instrumentation.incMessagePrevalidationStatus(false, topicType);
             this.node.services.pubsub.reportMessageValidationResult(msgId, source.toString(), TopicValidatorResult.Ignore);
+            if (topicType === TopicType.tx) {
+                this.logger.verbose(`Ignoring already-seen tx gossip message`, {
+                    msgId,
+                    source: source.toString()
+                });
+            }
             return {
                 result: false,
                 topicType
@@ -991,9 +988,7 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
             if (msg.topic === this.topicStrings[TopicType.tx]) {
                 await this.handleGossipedTx(p2pMessage.payload, msgId, source);
             } else if (msg.topic === this.topicStrings[TopicType.checkpoint_attestation]) {
-                if (this.clientType === P2PClientType.Full) {
-                    await this.processCheckpointAttestationFromPeer(p2pMessage.payload, msgId, source);
-                }
+                await this.processCheckpointAttestationFromPeer(p2pMessage.payload, msgId, source);
             } else if (msg.topic === this.topicStrings[TopicType.block_proposal]) {
                 await this.processBlockFromPeer(p2pMessage.payload, msgId, source);
             } else if (msg.topic === this.topicStrings[TopicType.checkpoint_proposal]) {
@@ -1038,39 +1033,119 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         return;
     }
     async validateReceivedMessage(validationFunc, msgId, source, topicType) {
+        // Default to reject result with a penalty if validation function throws an error
         let resultAndObj = {
-            result: TopicValidatorResult.Reject
+            result: TopicValidatorResult.Reject,
+            severity: PeerErrorSeverity.MidToleranceError
         };
         const timer = new Timer();
         try {
             resultAndObj = await validationFunc();
         } catch (err) {
-            this.peerManager.penalizePeer(source, PeerErrorSeverity.LowToleranceError);
-            this.logger.error(`Error deserializing and validating gossipsub message`, err, {
+            this.logger.error(`Error validating gossipsub message`, err, {
                 msgId,
                 source: source.toString(),
                 topicType
             });
         }
         if (resultAndObj.result === TopicValidatorResult.Accept) {
+            this.logger.debug(`Message ${topicType} accepted by validator`, {
+                msgId,
+                source: source.toString(),
+                topicType
+            });
             this.instrumentation.recordMessageValidation(topicType, timer);
+        } else if (resultAndObj.result === TopicValidatorResult.Reject) {
+            this.logger.warn(`Message ${topicType} rejected by validator with severity ${resultAndObj.severity}`, {
+                msgId,
+                source: source.toString(),
+                topicType,
+                severity: resultAndObj.severity
+            });
+            this.peerManager.penalizePeer(source, resultAndObj.severity);
+        } else {
+            this.logger.trace(`Message ${topicType} ignored by validator`, {
+                msgId,
+                source: source.toString(),
+                topicType
+            });
         }
         this.node.services.pubsub.reportMessageValidationResult(msgId, source.toString(), resultAndObj.result);
         return resultAndObj;
     }
+    tryDeserialize(deserializeFunc, msgId, source) {
+        try {
+            return deserializeFunc();
+        } catch (err) {
+            this.logger.warn(`Failed to deserialize gossipsub message from buffer`, {
+                err,
+                msgId,
+                source: source.toString()
+            });
+            return undefined;
+        }
+    }
     async handleGossipedTx(payloadData, msgId, source) {
         const validationFunc = async ()=>{
-            const tx = Tx.fromBuffer(payloadData);
-            const isValid = await this.validatePropagatedTx(tx, source);
-            if (!isValid) {
-                this.logger.trace(`Rejecting invalid propagated tx`, {
-                    [Attributes.P2P_ID]: source.toString()
+            const tx = this.tryDeserialize(()=>Tx.fromBuffer(payloadData), msgId, source);
+            if (!tx) {
+                return {
+                    result: TopicValidatorResult.Reject,
+                    severity: PeerErrorSeverity.LowToleranceError
+                };
+            }
+            const currentBlockNumber = await this.archiver.getBlockNumber();
+            const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
+            // Stage 1: fast validators (metadata, data, timestamps, double-spend, gas, phases, block header)
+            const firstStageValidators = await this.createFirstStageMessageValidators(currentBlockNumber, nextSlotTimestamp);
+            const firstStageOutcome = await this.runValidations(tx, firstStageValidators);
+            if (!firstStageOutcome.allPassed) {
+                const { name } = firstStageOutcome.failure;
+                let { severity } = firstStageOutcome.failure;
+                // Double spend validator has a special case handler. We perform more detailed examination
+                // as to how recently the nullifier was entered into the tree and if the transaction should
+                // have 'known' the nullifier existed. This determines the severity of the penalty applied to the peer.
+                if (name === 'doubleSpendValidator') {
+                    const txBlockNumber = BlockNumber(currentBlockNumber + 1);
+                    severity = await this.handleDoubleSpendFailure(tx, txBlockNumber);
+                }
+                this.logger.verbose(`Rejecting gossiped tx ${tx.getTxHash().toString()}: stage 1 validation failed`, {
+                    validator: name,
+                    severity,
+                    source: source.toString()
+                });
+                return {
+                    result: TopicValidatorResult.Reject,
+                    severity
+                };
+            }
+            // Pool pre-check: see if the pool would accept this tx before doing expensive proof verification
+            const canAdd = await this.mempools.txPool.canAddPendingTx(tx);
+            if (canAdd === 'ignored') {
+                this.logger.verbose(`Ignoring gossiped tx ${tx.getTxHash().toString()}: pool pre-check returned ignored`, {
+                    source: source.toString()
                 });
                 return {
-                    result: TopicValidatorResult.Reject
+                    result: TopicValidatorResult.Ignore,
+                    obj: tx
                 };
             }
-            // Propagate only on pool acceptance
+            // Stage 2: expensive proof verification
+            const secondStageValidators = this.createSecondStageMessageValidators();
+            const secondStageOutcome = await this.runValidations(tx, secondStageValidators);
+            if (!secondStageOutcome.allPassed) {
+                const { severity, name } = secondStageOutcome.failure;
+                this.logger.verbose(`Rejecting gossiped tx ${tx.getTxHash().toString()}: stage 2 validation failed`, {
+                    validator: name,
+                    severity,
+                    source: source.toString()
+                });
+                return {
+                    result: TopicValidatorResult.Reject,
+                    severity
+                };
+            }
+            // Pool add: persist the tx
             const txHash = tx.getTxHash();
             const addResult = await this.mempools.txPool.addPendingTxs([
                 tx
@@ -1079,8 +1154,7 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
             });
             const wasAccepted = addResult.accepted.some((h)=>h.equals(txHash));
             const wasIgnored = addResult.ignored.some((h)=>h.equals(txHash));
-            this.logger.trace(`Validate propagated tx`, {
-                isValid,
+            this.logger.verbose(`Validate propagated tx ${txHash.toString()}`, {
                 wasAccepted,
                 wasIgnored,
                 [Attributes.P2P_ID]: source.toString()
@@ -1096,8 +1170,13 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
                     obj: tx
                 };
             } else {
+                this.logger.warn(`Gossiped tx ${txHash.toString()} unexpectedly rejected by pool`, {
+                    source: source.toString(),
+                    txHash: txHash.toString()
+                });
                 return {
-                    result: TopicValidatorResult.Reject
+                    result: TopicValidatorResult.Reject,
+                    severity: PeerErrorSeverity.HighToleranceError
                 };
             }
         };
@@ -1118,7 +1197,16 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
    * Process a checkpoint attestation from a peer.
    * Validates the attestation and adds it to the pool.
    */ async processCheckpointAttestationFromPeer(payloadData, msgId, source) {
-        const { result, obj: attestation } = await this.validateReceivedMessage(()=>this.validateAndStoreCheckpointAttestation(source, CheckpointAttestation.fromBuffer(payloadData)), msgId, source, TopicType.checkpoint_attestation);
+        const { result, obj: attestation } = await this.validateReceivedMessage(()=>{
+            const attestation = this.tryDeserialize(()=>CheckpointAttestation.fromBuffer(payloadData), msgId, source);
+            if (!attestation) {
+                return Promise.resolve({
+                    result: TopicValidatorResult.Reject,
+                    severity: PeerErrorSeverity.LowToleranceError
+                });
+            }
+            return this.validateAndStoreCheckpointAttestation(source, attestation);
+        }, msgId, source, TopicType.checkpoint_attestation);
         if (result !== TopicValidatorResult.Accept || !attestation) {
             return;
         }
@@ -1133,9 +1221,9 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         const validationResult = await this.checkpointAttestationValidator.validate(attestation);
         if (validationResult.result === 'reject') {
             this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
-            this.peerManager.penalizePeer(peerId, validationResult.severity);
             return {
-                result: TopicValidatorResult.Reject
+                result: TopicValidatorResult.Reject,
+                severity: validationResult.severity
             };
         }
         if (validationResult.result === 'ignore') {
@@ -1162,9 +1250,9 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
                 obj: attestation
             };
         }
-        // Could not add (cap reached for signer), no need to re-broadcast
+        // Could not add (cap reached for signer), penalize and do not re-broadcast
         if (!added) {
-            this.logger.warn(`Dropping checkpoint attestation due to cap`, {
+            this.logger.warn(`Rejecting checkpoint attestation due to cap`, {
                 slot: slot.toString(),
                 archive: attestation.archive.toString(),
                 source: peerId.toString(),
@@ -1172,8 +1260,8 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
                 count
             });
             return {
-                result: TopicValidatorResult.Ignore,
-                obj: attestation
+                result: TopicValidatorResult.Reject,
+                severity: PeerErrorSeverity.HighToleranceError
             };
         }
         // Check if this is a duplicate attestation (signer attested to a different proposal at the same slot)
@@ -1211,9 +1299,9 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         const validationResult = await this.blockProposalValidator.validate(block);
         if (validationResult.result === 'reject') {
             this.logger.warn(`Penalizing peer ${peerId} for block proposal validation failure`);
-            this.peerManager.penalizePeer(peerId, validationResult.severity);
             return {
-                result: TopicValidatorResult.Reject
+                result: TopicValidatorResult.Reject,
+                severity: validationResult.severity
             };
         }
         if (validationResult.result === 'ignore') {
@@ -1243,7 +1331,6 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         }
         // Too many blocks received for this slot and index, penalize peer and do not re-broadcast
         if (!added) {
-            this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
             this.logger.warn(`Penalizing peer for block proposal exceeding per-position cap`, {
                 ...block.toBlockInfo(),
                 indexWithinCheckpoint: block.indexWithinCheckpoint,
@@ -1255,7 +1342,8 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
                 result: TopicValidatorResult.Reject,
                 metadata: {
                     isEquivocated
-                }
+                },
+                severity: PeerErrorSeverity.HighToleranceError
             };
         }
         // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
@@ -1304,7 +1392,7 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         // Note: Validators do NOT attest to individual blocks, only to checkpoint proposals.
         const isValid = await this.blockReceivedCallback(block, sender);
         if (!isValid) {
-            this.logger.warn(`Block proposal validation failed for block ${block.blockNumber}`, block.toBlockInfo());
+            this.logger.info(`Block proposal validation failed for block ${block.blockNumber}`, block.toBlockInfo());
         }
     }
     /**
@@ -1329,9 +1417,9 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         const validationResult = await this.checkpointProposalValidator.validate(checkpoint);
         if (validationResult.result === 'reject') {
             this.logger.warn(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
-            this.peerManager.penalizePeer(peerId, validationResult.severity);
             return {
-                result: TopicValidatorResult.Reject
+                result: TopicValidatorResult.Reject,
+                severity: validationResult.severity
             };
         }
         if (validationResult.result === 'ignore') {
@@ -1348,18 +1436,20 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
                 [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
                 [Attributes.P2P_ID]: peerId.toString()
             });
-            const { result, obj, metadata: { isEquivocated } = {} } = await this.validateAndStoreBlockProposal(peerId, blockProposal);
-            if (result === TopicValidatorResult.Reject || !obj || isEquivocated) {
+            const blockProposalResult = await this.validateAndStoreBlockProposal(peerId, blockProposal);
+            const { obj, metadata: { isEquivocated } = {} } = blockProposalResult;
+            if (blockProposalResult.result === TopicValidatorResult.Reject || !obj || isEquivocated) {
                 this.logger.debug(`Rejecting checkpoint due to invalid last block proposal`, {
                     [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
                     [Attributes.P2P_ID]: peerId.toString(),
                     isEquivocated,
-                    result
+                    result: blockProposalResult.result
                 });
                 return {
-                    result: TopicValidatorResult.Reject
+                    result: TopicValidatorResult.Reject,
+                    severity: 'severity' in blockProposalResult ? blockProposalResult.severity : PeerErrorSeverity.MidToleranceError
                 };
-            } else if (result === TopicValidatorResult.Accept && obj && !isEquivocated) {
+            } else if (blockProposalResult.result === TopicValidatorResult.Accept && obj && !isEquivocated) {
                 processBlock = true;
             }
         }
@@ -1386,7 +1476,6 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         // Too many checkpoint proposals received for this slot, penalize peer and do not re-broadcast
         // Note: We still return the checkpoint obj so the lastBlock can be processed if valid
         if (!added) {
-            this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
             this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
                 ...checkpoint.toCheckpointInfo(),
                 count,
@@ -1398,7 +1487,8 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
                 metadata: {
                     isEquivocated,
                     processBlock
-                }
+                },
+                severity: PeerErrorSeverity.HighToleranceError
             };
         }
         // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
@@ -1448,9 +1538,10 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
             archive: checkpoint.archive.toString(),
             source: sender.toString()
         });
+        await this.allNodesCheckpointReceivedCallback(checkpoint, sender);
         // Call the checkpoint received callback with the core version (without lastBlock)
         // to validate and potentially generate attestations
-        const attestations = await this.checkpointReceivedCallback(checkpoint, sender);
+        const attestations = await this.validatorCheckpointReceivedCallback(checkpoint, sender);
         if (attestations && attestations.length > 0) {
             // If the callback returned attestations, add them to the pool and propagate them
             await this.mempools.attestationPool.addOwnCheckpointAttestations(attestations);
@@ -1570,45 +1661,6 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
             return false;
         }
     }
-    /**
-   * Validates a BLOCK response.
-   *
-   * If a local copy exists, enforces hash equality. If missing, rejects (no penalty) since the hash cannot be verified.
-   * Penalizes on block number mismatch or hash mismatch.
-   *
-   * @param requestedBlockNumber - The requested block number.
-   * @param responseBlock - The block returned by the peer.
-   * @param peerId - The peer that returned the block.
-   * @returns True if the response is valid, false otherwise.
-   */ async validateRequestedBlock(requestedBlockNumber, responseBlock, peerId) {
-        try {
-            const reqNum = Number(requestedBlockNumber.toString());
-            if (responseBlock.number !== reqNum) {
-                this.peerManager.penalizePeer(peerId, PeerErrorSeverity.LowToleranceError);
-                return false;
-            }
-            const local = await this.archiver.getBlock(BlockNumber(reqNum));
-            if (!local) {
-                // We are missing the local block; we cannot verify the hash yet. Reject without penalizing.
-                // TODO: Consider extending this validator to accept an expected hash or
-                // performing quorum-based checks when using P2P syncing prior to L1 sync.
-                this.logger.warn(`Local block ${reqNum} not found; rejecting BLOCK response without hash verification`);
-                return false;
-            }
-            const [localHash, respHash] = await Promise.all([
-                local.hash(),
-                responseBlock.hash()
-            ]);
-            if (!localHash.equals(respHash)) {
-                this.peerManager.penalizePeer(peerId, PeerErrorSeverity.MidToleranceError);
-                return false;
-            }
-            return true;
-        } catch (e) {
-            this.logger.warn(`Error validating requested block`, e);
-            return false;
-        }
-    }
     async validateRequestedTx(tx, peerId, txValidator, requested) {
         const penalize = (severity)=>this.peerManager.penalizePeer(peerId, severity);
         if (requested && !requested.has(tx.getTxHash().toString())) {
@@ -1622,33 +1674,11 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         }
     }
     createRequestedTxValidator() {
-        return createTxReqRespValidator(this.proofVerifier, {
+        return createTxValidatorForReqResponseReceivedTxs(this.proofVerifier, {
             l1ChainId: this.config.l1ChainId,
             rollupVersion: this.config.rollupVersion
         });
     }
-    async validatePropagatedTx(tx, peerId) {
-        const currentBlockNumber = await this.archiver.getBlockNumber();
-        // We accept transactions if they are not expired by the next slot (checked based on the IncludeByTimestamp field)
-        const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
-        const messageValidators = await this.createMessageValidators(currentBlockNumber, nextSlotTimestamp);
-        for (const validator of messageValidators){
-            const outcome = await this.runValidations(tx, validator);
-            if (outcome.allPassed) {
-                continue;
-            }
-            const { name } = outcome.failure;
-            let { severity } = outcome.failure;
-            // Double spend validator has a special case handler
-            if (name === 'doubleSpendValidator') {
-                const txBlockNumber = BlockNumber(currentBlockNumber + 1); // tx is expected to be in the next block
-                severity = await this.handleDoubleSpendFailure(tx, txBlockNumber);
-            }
-            this.peerManager.penalizePeer(peerId, severity);
-            return false;
-        }
-        return true;
-    }
     async getGasFees(blockNumber) {
         if (blockNumber === this.feesCache?.blockNumber) {
             return this.feesCache.gasFees;
@@ -1675,38 +1705,35 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
             peerScoring: this.peerManager
         };
     }
-    async validate(txs) {
-        const currentBlockNumber = await this.archiver.getBlockNumber();
-        // We accept transactions if they are not expired by the next slot (checked based on the IncludeByTimestamp field)
-        const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
-        const messageValidators = await this.createMessageValidators(currentBlockNumber, nextSlotTimestamp);
-        await Promise.all(txs.map(async (tx)=>{
-            for (const validator of messageValidators){
-                const outcome = await this.runValidations(tx, validator);
-                if (!outcome.allPassed) {
-                    throw new Error('Invalid tx detected', {
-                        cause: {
-                            outcome
-                        }
-                    });
-                }
-            }
+    async validateTxsReceivedInBlockProposal(txs) {
+        const validator = createTxValidatorForBlockProposalReceivedTxs(this.proofVerifier, {
+            l1ChainId: this.config.l1ChainId,
+            rollupVersion: this.config.rollupVersion
+        }, this.logger.getBindings());
+        const results = await Promise.all(txs.map(async (tx)=>{
+            const result = await validator.validateTx(tx);
+            return result.result !== 'invalid';
         }));
+        if (results.some((value)=>value === false)) {
+            throw new Error('Invalid tx detected');
+        }
     }
-    /**
-   * Create message validators for the given block number and timestamp.
-   *
-   * Each validator is a pair of a validator and a severity.
-   * If a validator fails, the peer is penalized with the severity of the validator.
-   *
-   * @param currentBlockNumber - The current synced block number.
-   * @param nextSlotTimestamp - The timestamp of the next slot (used to validate txs are not expired).
-   * @returns The message validators.
-   */ async createMessageValidators(currentBlockNumber, nextSlotTimestamp) {
+    /** Creates the first stage (fast) validators for gossiped transactions. */ async createFirstStageMessageValidators(currentBlockNumber, nextSlotTimestamp) {
         const gasFees = await this.getGasFees(currentBlockNumber);
-        const allowedInSetup = this.config.txPublicSetupAllowList ?? await getDefaultAllowedSetupFunctions();
-        const blockNumberInWhichTheTxIsConsideredToBeIncluded = BlockNumber(currentBlockNumber + 1);
-        return createTxMessageValidators(nextSlotTimestamp, blockNumberInWhichTheTxIsConsideredToBeIncluded, this.worldStateSynchronizer, gasFees, this.config.l1ChainId, this.config.rollupVersion, protocolContractsHash, this.archiver, this.proofVerifier, !this.config.disableTransactions, allowedInSetup, this.logger.getBindings());
+        const allowedInSetup = [
+            ...await getDefaultAllowedSetupFunctions(),
+            ...this.config.txPublicSetupAllowListExtend ?? []
+        ];
+        const blockNumber = BlockNumber(currentBlockNumber + 1);
+        const l1Constants = await this.archiver.getL1Constants();
+        return createFirstStageTxValidationsForGossipedTransactions(nextSlotTimestamp, blockNumber, this.worldStateSynchronizer, gasFees, this.config.l1ChainId, this.config.rollupVersion, protocolContractsHash, this.archiver, !this.config.disableTransactions, allowedInSetup, this.logger.getBindings(), {
+            rollupManaLimit: l1Constants.rollupManaLimit,
+            maxBlockL2Gas: this.config.validateMaxL2BlockGas,
+            maxBlockDAGas: this.config.validateMaxDABlockGas
+        });
+    }
+    /** Creates the second stage (expensive proof verification) validators for gossiped transactions. */ createSecondStageMessageValidators() {
+        return createSecondStageTxValidationsForGossipedTransactions(this.proofVerifier, this.logger.getBindings());
     }
     /**
    * Run validations on a tx.
@@ -1724,8 +1751,10 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         });
         // A promise that resolves when all validations have been run
         const allValidations = await Promise.all(validationPromises);
-        const failed = allValidations.find((x)=>!x.isValid);
-        if (failed) {
+        const failures = allValidations.filter((x)=>!x.isValid);
+        if (failures.length > 0) {
+            // Pick the most severe failure (lowest tolerance = harshest penalty)
+            const failed = maxBy(failures, (f)=>PeerErrorSeverityByHarshness.indexOf(f.severity));
             return {
                 allPassed: false,
                 failure: {
@@ -1772,19 +1801,6 @@ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId
         }
         return PeerErrorSeverity.HighToleranceError;
     }
-    /**
-   * Validate a checkpoint attestation.
-   *
-   * @param attestation - The checkpoint attestation to validate.
-   * @returns True if the checkpoint attestation is valid, false otherwise.
-   */ async validateCheckpointAttestation(peerId, attestation) {
-        const result = await this.checkpointAttestationValidator.validate(attestation);
-        if (result.result === 'reject') {
-            this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
-            this.peerManager.penalizePeer(peerId, result.severity);
-        }
-        return result;
-    }
     getPeerScore(peerId) {
         return this.node.services.pubsub.score.score(peerId.toString());
     }