@aztec/p2p 0.0.1-commit.cd76b27 → 0.0.1-commit.ce4f8c4f2

package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.js

@@ -23,6 +23,7 @@ import { TxPoolIndices } from './tx_pool_indices.js';
     #l2BlockSource;
     #worldStateSynchronizer;
     #createTxValidator;
+    #checkAllowedSetupCalls;
     // === In-Memory Indices ===
     #indices = new TxPoolIndices();
     // === Config & Services ===
@@ -41,6 +42,7 @@ import { TxPoolIndices } from './tx_pool_indices.js';
         this.#l2BlockSource = deps.l2BlockSource;
         this.#worldStateSynchronizer = deps.worldStateSynchronizer;
         this.#createTxValidator = deps.createTxValidator;
+        this.#checkAllowedSetupCalls = deps.checkAllowedSetupCalls;
         this.#config = {
             ...DEFAULT_TX_POOL_V2_CONFIG,
             ...config
@@ -128,9 +130,32 @@ import { TxPoolIndices } from './tx_pool_indices.js';
         const rejected = [];
         const errors = new Map();
         const acceptedPending = new Set();
+        // Phase 1: Pre-compute all throwable I/O outside the transaction.
+        // If any pre-computation throws, the entire call fails before mutations happen.
+        const precomputed = new Map();
+        const validator = await this.#createTxValidator();
+        for (const tx of txs){
+            const txHash = tx.getTxHash();
+            const txHashStr = txHash.toString();
+            const meta = await buildTxMetaData(tx);
+            const minedBlockId = await this.#getMinedBlockId(txHash);
+            // Validate non-mined txs (mined and pre-protected txs bypass validation inside the transaction)
+            let isValid = true;
+            if (!minedBlockId) {
+                isValid = await this.#validateMeta(meta, validator);
+            }
+            precomputed.set(txHashStr, {
+                meta,
+                minedBlockId,
+                isValid
+            });
+        }
+        // Phase 2: Apply mutations inside the transaction using only pre-computed results,
+        // in-memory reads, and buffered DB writes. Nothing here can throw an unhandled exception.
         const poolAccess = this.#createPreAddPoolAccess();
         const preAddContext = opts.feeComparisonOnly !== undefined ? {
-            feeComparisonOnly: opts.feeComparisonOnly
+            feeComparisonOnly: opts.feeComparisonOnly,
+            priceBumpPercentage: this.#config.priceBumpPercentage
         } : undefined;
         await this.#store.transactionAsync(async ()=>{
             for (const tx of txs){
@@ -141,33 +166,41 @@ import { TxPoolIndices } from './tx_pool_indices.js';
                     ignored.push(txHash);
                     continue;
                 }
-                // Check mined status first (applies to all paths)
-                const minedBlockId = await this.#getMinedBlockId(txHash);
+                const { meta, minedBlockId, isValid } = precomputed.get(txHashStr);
                 const preProtectedSlot = this.#indices.getProtectionSlot(txHashStr);
                 if (minedBlockId) {
                     // Already mined - add directly (protection already set if pre-protected)
                     await this.#addTx(tx, {
                         mined: minedBlockId
-                    }, opts);
+                    }, opts, meta);
                     accepted.push(txHash);
                 } else if (preProtectedSlot !== undefined) {
                     // Pre-protected and not mined - add as protected (bypass validation)
                     await this.#addTx(tx, {
                         protected: preProtectedSlot
-                    }, opts);
+                    }, opts, meta);
                     accepted.push(txHash);
+                } else if (!isValid) {
+                    // Failed pre-computed validation
+                    rejected.push(txHash);
                 } else {
-                    // Regular pending tx - validate and run pre-add rules
-                    const result = await this.#tryAddRegularPendingTx(tx, opts, poolAccess, acceptedPending, ignored, errors, preAddContext);
+                    // Regular pending tx - run pre-add rules using pre-computed metadata
+                    const result = await this.#tryAddRegularPendingTx(tx, meta, opts, poolAccess, acceptedPending, ignored, errors, preAddContext);
                     if (result.status === 'accepted') {
                         acceptedPending.add(txHashStr);
-                    } else if (result.status === 'rejected') {
-                        rejected.push(txHash);
                     } else {
                         ignored.push(txHash);
                     }
                 }
             }
+            // Run post-add eviction rules for pending txs (inside transaction for atomicity)
+            if (acceptedPending.size > 0) {
+                const feePayers = Array.from(acceptedPending).map((txHash)=>this.#indices.getMetadata(txHash).feePayer);
+                const uniqueFeePayers = new Set(feePayers);
+                await this.#evictionManager.evictAfterNewTxs(Array.from(acceptedPending), [
+                    ...uniqueFeePayers
+                ]);
+            }
         });
         // Build final accepted list for pending txs (excludes intra-batch evictions)
         for (const txHashStr of acceptedPending){
@@ -180,14 +213,6 @@ import { TxPoolIndices } from './tx_pool_indices.js';
         if (rejected.length > 0) {
             this.#instrumentation.recordRejected(rejected.length);
         }
-        // Run post-add eviction rules for pending txs
-        if (acceptedPending.size > 0) {
-            const feePayers = Array.from(acceptedPending).map((txHash)=>this.#indices.getMetadata(txHash).feePayer);
-            const uniqueFeePayers = new Set(feePayers);
-            await this.#evictionManager.evictAfterNewTxs(Array.from(acceptedPending), [
-                ...uniqueFeePayers
-            ]);
-        }
         return {
             accepted,
             ignored,
@@ -197,18 +222,10 @@ import { TxPoolIndices } from './tx_pool_indices.js';
             } : {}
         };
     }
-    /** Validates and adds a regular pending tx. Returns status. */ async #tryAddRegularPendingTx(tx, opts, poolAccess, acceptedPending, ignored, errors, preAddContext) {
-        const txHash = tx.getTxHash();
-        const txHashStr = txHash.toString();
-        // Build metadata and validate using metadata
-        const meta = await buildTxMetaData(tx);
-        if (!await this.#validateMeta(meta)) {
-            return {
-                status: 'rejected'
-            };
-        }
+    /** Adds a validated pending tx, running pre-add rules and evicting conflicts. */ async #tryAddRegularPendingTx(tx, precomputedMeta, opts, poolAccess, acceptedPending, ignored, errors, preAddContext) {
+        const txHashStr = tx.getTxHash().toString();
         // Run pre-add rules
-        const preAddResult = await this.#evictionManager.runPreAddRules(meta, poolAccess, preAddContext);
+        const preAddResult = await this.#evictionManager.runPreAddRules(precomputedMeta, poolAccess, preAddContext);
         if (preAddResult.shouldIgnore) {
             this.#log.debug(`Ignoring tx ${txHashStr}: ${preAddResult.reason?.message ?? 'unknown reason'}`);
             if (preAddResult.reason && preAddResult.reason.code !== TxPoolRejectionCode.INTERNAL_ERROR) {
@@ -246,8 +263,15 @@ import { TxPoolIndices } from './tx_pool_indices.js';
                 }
             }
         }
+        // Randomly drop the transaction for testing purposes (report as accepted so it propagates)
+        if (this.#config.dropTransactionsProbability > 0 && Math.random() < this.#config.dropTransactionsProbability) {
+            this.#log.debug(`Dropping tx ${txHashStr} (simulated drop for testing)`);
+            return {
+                status: 'accepted'
+            };
+        }
         // Add the transaction
-        await this.#addTx(tx, 'pending', opts);
+        await this.#addTx(tx, 'pending', opts, precomputedMeta);
         return {
             status: 'accepted'
         };
@@ -256,38 +280,44 @@ import { TxPoolIndices } from './tx_pool_indices.js';
         const txHashStr = tx.getTxHash().toString();
         // Check if already in pool
         if (this.#indices.has(txHashStr)) {
+            this.#log.verbose(`canAddPendingTx: tx ${txHashStr} already in pool`);
             return 'ignored';
         }
-        // Build metadata and validate using metadata
+        // Build metadata and check pre-add rules
         const meta = await buildTxMetaData(tx);
-        const validationResult = await this.#validateMeta(meta, undefined, 'can add pending');
-        if (validationResult !== true) {
-            return 'rejected';
-        }
-        // Use pre-add rules
         const poolAccess = this.#createPreAddPoolAccess();
         const preAddResult = await this.#evictionManager.runPreAddRules(meta, poolAccess);
-        return preAddResult.shouldIgnore ? 'ignored' : 'accepted';
+        if (preAddResult.shouldIgnore) {
+            this.#log.verbose(`canAddPendingTx: tx ${txHashStr} ignored by pre-add rule`, {
+                reason: preAddResult.reason?.message ?? 'no reason provided'
+            });
+            return 'ignored';
+        }
+        return 'accepted';
     }
     async addProtectedTxs(txs, block, opts) {
         const slotNumber = block.globalVariables.slotNumber;
+        // Precompute setup-call allow-list flags outside the store transaction
+        const allowedFlags = await Promise.all(txs.map((tx)=>this.#checkAllowedSetupCalls(tx)));
         await this.#store.transactionAsync(async ()=>{
-            for (const tx of txs){
+            for(let i = 0; i < txs.length; i++){
+                const tx = txs[i];
                 const txHash = tx.getTxHash();
                 const txHashStr = txHash.toString();
                 const isNew = !this.#indices.has(txHashStr);
                 const minedBlockId = await this.#getMinedBlockId(txHash);
                 if (isNew) {
+                    const meta = await buildTxMetaData(tx, allowedFlags[i]);
                     // New tx - add as mined or protected (callback emitted by #addTx)
                     if (minedBlockId) {
                         await this.#addTx(tx, {
                             mined: minedBlockId
-                        }, opts);
+                        }, opts, meta);
                         this.#indices.setProtection(txHashStr, slotNumber);
                     } else {
                         await this.#addTx(tx, {
                             protected: slotNumber
-                        }, opts);
+                        }, opts, meta);
                     }
                 } else {
                     // Existing tx - update protection and mined status
@@ -305,34 +335,36 @@ import { TxPoolIndices } from './tx_pool_indices.js';
         const missing = [];
         let softDeletedHits = 0;
         let missingPreviouslyEvicted = 0;
-        for (const txHash of txHashes){
-            const txHashStr = txHash.toString();
-            if (this.#indices.has(txHashStr)) {
-                // Update protection for existing tx
-                this.#indices.updateProtection(txHashStr, slotNumber);
-            } else if (this.#deletedPool.isSoftDeleted(txHashStr)) {
-                // Resurrect soft-deleted tx as protected
-                const buffer = await this.#txsDB.getAsync(txHashStr);
-                if (buffer) {
-                    const tx = Tx.fromBuffer(buffer);
-                    await this.#addTx(tx, {
-                        protected: slotNumber
-                    });
-                    softDeletedHits++;
+        await this.#store.transactionAsync(async ()=>{
+            for (const txHash of txHashes){
+                const txHashStr = txHash.toString();
+                if (this.#indices.has(txHashStr)) {
+                    // Update protection for existing tx
+                    this.#indices.updateProtection(txHashStr, slotNumber);
+                } else if (this.#deletedPool.isSoftDeleted(txHashStr)) {
+                    // Resurrect soft-deleted tx as protected
+                    const buffer = await this.#txsDB.getAsync(txHashStr);
+                    if (buffer) {
+                        const tx = Tx.fromBuffer(buffer);
+                        await this.#addTx(tx, {
+                            protected: slotNumber
+                        });
+                        softDeletedHits++;
+                    } else {
+                        // Data missing despite soft-delete flag — treat as truly missing
+                        this.#indices.setProtection(txHashStr, slotNumber);
+                        missing.push(txHash);
+                    }
                 } else {
-                    // Data missing despite soft-delete flag — treat as truly missing
+                    // Truly missing — pre-record protection for tx we don't have yet
                     this.#indices.setProtection(txHashStr, slotNumber);
                     missing.push(txHash);
-                }
-            } else {
-                // Truly missing — pre-record protection for tx we don't have yet
-                this.#indices.setProtection(txHashStr, slotNumber);
-                missing.push(txHash);
-                if (this.#evictedTxHashes.has(txHashStr)) {
-                    missingPreviouslyEvicted++;
+                    if (this.#evictedTxHashes.has(txHashStr)) {
+                        missingPreviouslyEvicted++;
+                    }
                 }
             }
-        }
+        });
         // Record metrics
         if (softDeletedHits > 0) {
             this.#instrumentation.recordSoftDeletedHits(softDeletedHits);
@@ -383,44 +415,51 @@ import { TxPoolIndices } from './tx_pool_indices.js';
                 found.push(meta);
             }
         }
-        // Step 4: Mark txs as mined (only those we have in the pool)
-        for (const meta of found){
-            this.#indices.markAsMined(meta, blockId);
-            await this.#deletedPool.clearIfMinedHigher(meta.txHash, blockId.number);
+        await this.#store.transactionAsync(async ()=>{
+            // Step 4: Mark txs as mined (only those we have in the pool)
+            for (const meta of found){
+                this.#indices.markAsMined(meta, blockId);
+                await this.#deletedPool.clearIfMinedHigher(meta.txHash, blockId.number);
+            }
+            // Step 5: Run post-event eviction rules (inside transaction for atomicity)
+            await this.#evictionManager.evictAfterNewBlock(block.header, nullifiers, feePayers);
+        });
+        if (found.length > 0) {
+            this.#callbacks.onTxsMined(found.map((m)=>m.txHash));
         }
-        // Step 5: Run eviction rules (remove pending txs with conflicting nullifiers/expired timestamps)
-        await this.#evictionManager.evictAfterNewBlock(block.header, nullifiers, feePayers);
         this.#log.info(`Marked ${found.length} txs as mined in block ${blockId.number}`);
     }
     async prepareForSlot(slotNumber) {
-        // Step 0: Clean up slot-deleted txs from previous slots
-        await this.#deletedPool.cleanupSlotDeleted(slotNumber);
-        // Step 1: Find expired protected txs
-        const expiredProtected = this.#indices.findExpiredProtectedTxs(slotNumber);
-        // Step 2: Clear protection for all expired entries (including those without metadata)
-        this.#indices.clearProtection(expiredProtected);
-        // Step 3: Filter to only txs that have metadata and are not mined
-        const txsToRestore = this.#indices.filterRestorable(expiredProtected);
-        if (txsToRestore.length === 0) {
-            this.#log.debug(`Preparing for slot ${slotNumber}, no txs to unprotect`);
-            return;
-        }
-        this.#log.info(`Preparing for slot ${slotNumber}: unprotecting ${txsToRestore.length} txs`);
-        // Step 4: Validate for pending pool
-        const { valid, invalid } = await this.#revalidateMetadata(txsToRestore, 'during prepareForSlot');
-        // Step 5: Resolve nullifier conflicts and add winners to pending indices
-        const { added, toEvict } = this.#applyNullifierConflictResolution(valid);
-        // Step 6: Delete invalid txs and evict conflict losers
-        await this.#deleteTxsBatch(invalid);
-        await this.#evictTxs(toEvict, 'NullifierConflict');
-        // Step 7: Run eviction rules (enforce pool size limit)
-        if (added.length > 0) {
-            const feePayers = added.map((meta)=>meta.feePayer);
-            const uniqueFeePayers = new Set(feePayers);
-            await this.#evictionManager.evictAfterNewTxs(added.map((m)=>m.txHash), [
-                ...uniqueFeePayers
-            ]);
-        }
+        await this.#store.transactionAsync(async ()=>{
+            // Step 0: Clean up slot-deleted txs from previous slots
+            await this.#deletedPool.cleanupSlotDeleted(slotNumber);
+            // Step 1: Find expired protected txs
+            const expiredProtected = this.#indices.findExpiredProtectedTxs(slotNumber);
+            // Step 2: Clear protection for all expired entries (including those without metadata)
+            this.#indices.clearProtection(expiredProtected);
+            // Step 3: Filter to only txs that have metadata and are not mined
+            const txsToRestore = this.#indices.filterRestorable(expiredProtected);
+            if (txsToRestore.length === 0) {
+                this.#log.debug(`Preparing for slot ${slotNumber}, no txs to unprotect`);
+                return;
+            }
+            this.#log.info(`Preparing for slot ${slotNumber}: unprotecting ${txsToRestore.length} txs`);
+            // Step 4: Validate for pending pool
+            const { valid, invalid } = await this.#revalidateMetadata(txsToRestore, 'during prepareForSlot');
+            // Step 5: Resolve nullifier conflicts and add winners to pending indices
+            const { added, toEvict } = this.#applyNullifierConflictResolution(valid);
+            // Step 6: Delete invalid txs and evict conflict losers
+            await this.#deleteTxsBatch(invalid);
+            await this.#evictTxs(toEvict, 'NullifierConflict');
+            // Step 7: Run eviction rules (enforce pool size limit)
+            if (added.length > 0) {
+                const feePayers = added.map((meta)=>meta.feePayer);
+                const uniqueFeePayers = new Set(feePayers);
+                await this.#evictionManager.evictAfterNewTxs(added.map((m)=>m.txHash), [
+                    ...uniqueFeePayers
+                ]);
+            }
+        });
     }
     async handlePrunedBlocks(latestBlock, options) {
         // Step 1: Find transactions mined after the prune point
@@ -430,45 +469,48 @@ import { TxPoolIndices } from './tx_pool_indices.js';
             return;
         }
         this.#log.info(`Handling prune to block ${latestBlock.number}: un-mining ${txsToUnmine.length} txs`);
-        // Step 2: Mark ALL un-mined txs with their original mined block number
-        // This ensures they get soft-deleted if removed later, and only hard-deleted
-        // when their original mined block is finalized
-        await this.#deletedPool.markFromPrunedBlock(txsToUnmine.map((m)=>({
-                txHash: m.txHash,
-                minedAtBlock: BlockNumber(m.minedL2BlockId.number)
-            })));
-        // Step 3: Unmine - clear mined status from metadata
-        for (const meta of txsToUnmine){
-            this.#indices.markAsUnmined(meta);
-        }
-        // If deleteAllTxs is set (epoch prune), delete all un-mined txs and return early
-        if (options?.deleteAllTxs) {
-            const allTxHashes = txsToUnmine.map((m)=>m.txHash);
-            await this.#deleteTxsBatch(allTxHashes);
-            this.#log.info(`Handled prune to block ${latestBlock.number} with deleteAllTxs: deleted ${allTxHashes.length} txs`);
-            return;
-        }
-        // Step 4: Filter out protected txs (they'll be handled by prepareForSlot)
-        const unprotectedTxs = this.#indices.filterUnprotected(txsToUnmine);
-        // Step 5: Validate for pending pool
-        const { valid, invalid } = await this.#revalidateMetadata(unprotectedTxs, 'during handlePrunedBlocks');
-        // Step 6: Resolve nullifier conflicts and add winners to pending indices
-        const { toEvict } = this.#applyNullifierConflictResolution(valid);
-        // Step 7: Delete invalid txs and evict conflict losers
-        await this.#deleteTxsBatch(invalid);
-        await this.#evictTxs(toEvict, 'NullifierConflict');
-        this.#log.info(`Handled prune to block ${latestBlock.number}: ${valid.length} txs restored to pending, ${invalid.length} invalid, ${toEvict.length} evicted due to nullifier conflicts`, {
-            txHashesRestored: valid.map((m)=>m.txHash),
-            txHashesInvalid: invalid,
-            txHashesEvicted: toEvict
+        await this.#store.transactionAsync(async ()=>{
+            // Step 2: Mark ALL un-mined txs with their original mined block number
+            // This ensures they get soft-deleted if removed later, and only hard-deleted
+            // when their original mined block is finalized
+            await this.#deletedPool.markFromPrunedBlock(txsToUnmine.map((m)=>({
+                    txHash: m.txHash,
+                    minedAtBlock: BlockNumber(m.minedL2BlockId.number)
+                })));
+            // Step 3: Unmine - clear mined status from metadata
+            for (const meta of txsToUnmine){
+                this.#indices.markAsUnmined(meta);
+            }
+            // If deleteAllTxs is set (epoch prune), delete all un-mined txs and return early
+            if (options?.deleteAllTxs) {
+                const allTxHashes = txsToUnmine.map((m)=>m.txHash);
+                await this.#deleteTxsBatch(allTxHashes);
+                this.#log.info(`Handled prune to block ${latestBlock.number} with deleteAllTxs: deleted ${allTxHashes.length} txs`);
+                return;
+            }
+            // Step 4: Filter out protected txs (they'll be handled by prepareForSlot)
+            const unprotectedTxs = this.#indices.filterUnprotected(txsToUnmine);
+            // Step 5: Validate for pending pool
+            const { valid, invalid } = await this.#revalidateMetadata(unprotectedTxs, 'during handlePrunedBlocks');
+            // Step 6: Resolve nullifier conflicts and add winners to pending indices
+            const { toEvict } = this.#applyNullifierConflictResolution(valid);
+            // Step 7: Delete invalid txs and evict conflict losers
+            await this.#deleteTxsBatch(invalid);
+            await this.#evictTxs(toEvict, 'NullifierConflict');
+            this.#log.info(`Handled prune to block ${latestBlock.number}: ${valid.length} txs restored to pending, ${invalid.length} invalid, ${toEvict.length} evicted due to nullifier conflicts`, {
+                txHashesRestored: valid.map((m)=>m.txHash),
+                txHashesInvalid: invalid,
+                txHashesEvicted: toEvict
+            });
+            // Step 8: Run eviction rules for ALL pending txs (not just restored ones)
+            // This handles cases like existing pending txs with invalid fee payer balances
+            await this.#evictionManager.evictAfterChainPrune(latestBlock.number);
         });
-        // Step 8: Run eviction rules for ALL pending txs (not just restored ones)
-        // This handles cases like existing pending txs with invalid fee payer balances
-        await this.#evictionManager.evictAfterChainPrune(latestBlock.number);
     }
     async handleFailedExecution(txHashes) {
-        // Delete failed txs
-        await this.#deleteTxsBatch(txHashes.map((h)=>h.toString()));
+        await this.#store.transactionAsync(async ()=>{
+            await this.#deleteTxsBatch(txHashes.map((h)=>h.toString()));
+        });
         this.#log.info(`Deleted ${txHashes.length} failed txs`, {
             txHashes: txHashes.map((h)=>h.toString())
         });
@@ -477,24 +519,26 @@ import { TxPoolIndices } from './tx_pool_indices.js';
         const blockNumber = block.globalVariables.blockNumber;
         // Step 1: Find mined txs at or before finalized block
         const minedTxsToFinalize = this.#indices.findTxsMinedAtOrBefore(blockNumber);
-        // Step 2: Collect mined txs for archiving (before deletion)
-        const txsToArchive = [];
-        if (this.#archive.isEnabled()) {
-            for (const txHashStr of minedTxsToFinalize){
-                const buffer = await this.#txsDB.getAsync(txHashStr);
-                if (buffer) {
-                    txsToArchive.push(Tx.fromBuffer(buffer));
+        await this.#store.transactionAsync(async ()=>{
+            // Step 2: Collect mined txs for archiving (before deletion)
+            const txsToArchive = [];
+            if (this.#archive.isEnabled()) {
+                for (const txHashStr of minedTxsToFinalize){
+                    const buffer = await this.#txsDB.getAsync(txHashStr);
+                    if (buffer) {
+                        txsToArchive.push(Tx.fromBuffer(buffer));
+                    }
                 }
             }
-        }
-        // Step 3: Delete mined txs from active pool
-        await this.#deleteTxsBatch(minedTxsToFinalize);
-        // Step 4: Finalize soft-deleted txs
-        await this.#deletedPool.finalizeBlock(blockNumber);
-        // Step 5: Archive mined txs
-        if (txsToArchive.length > 0) {
-            await this.#archive.archiveTxs(txsToArchive);
-        }
+            // Step 3: Delete mined txs from active pool
+            await this.#deleteTxsBatch(minedTxsToFinalize);
+            // Step 4: Finalize soft-deleted txs
+            await this.#deletedPool.finalizeBlock(blockNumber);
+            // Step 5: Archive mined txs
+            if (txsToArchive.length > 0) {
+                await this.#archive.archiveTxs(txsToArchive);
+            }
+        });
         if (minedTxsToFinalize.length > 0) {
             this.#log.info(`Finalized ${minedTxsToFinalize.length} mined txs from blocks up to ${blockNumber}`, {
                 txHashes: minedTxsToFinalize
@@ -610,9 +654,9 @@ import { TxPoolIndices } from './tx_pool_indices.js';
     /**
    * Adds a new transaction to the pool with the specified state.
    * Emits onTxsAdded callback immediately after DB write.
-   */ async #addTx(tx, state, opts = {}) {
+   */ async #addTx(tx, state, opts = {}, precomputedMeta) {
         const txHashStr = tx.getTxHash().toString();
-        const meta = await buildTxMetaData(tx);
+        const meta = precomputedMeta ?? await buildTxMetaData(tx);
         meta.receivedAt = this.#dateProvider.now();
         await this.#txsDB.set(txHashStr, tx.toBuffer());
         await this.#deletedPool.clearSoftDeleted(txHashStr);
@@ -767,7 +811,8 @@ import { TxPoolIndices } from './tx_pool_indices.js';
             }
             try {
                 const tx = Tx.fromBuffer(buffer);
-                const meta = await buildTxMetaData(tx);
+                const allowedSetupCalls = await this.#checkAllowedSetupCalls(tx);
+                const meta = await buildTxMetaData(tx, allowedSetupCalls);
                 loaded.push({
                     tx,
                     meta

package/dest/msg_validators/attestation_validator/attestation_validator.d.ts

@@ -7,4 +7,4 @@ export declare class CheckpointAttestationValidator implements P2PValidator<Chec
     constructor(epochCache: EpochCacheInterface);
     validate(message: CheckpointAttestation): Promise<ValidationResult>;
 }
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYXR0ZXN0YXRpb25fdmFsaWRhdG9yLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi9zcmMvbXNnX3ZhbGlkYXRvcnMvYXR0ZXN0YXRpb25fdmFsaWRhdG9yL2F0dGVzdGF0aW9uX3ZhbGlkYXRvci50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEtBQUssRUFBRSxtQkFBbUIsRUFBRSxNQUFNLG9CQUFvQixDQUFDO0FBRTlELE9BQU8sRUFBRSxLQUFLLE1BQU0sRUFBZ0IsTUFBTSx1QkFBdUIsQ0FBQztBQUNsRSxPQUFPLEVBQ0wsS0FBSyxxQkFBcUIsRUFDMUIsS0FBSyxZQUFZLEVBRWpCLEtBQUssZ0JBQWdCLEVBQ3RCLE1BQU0sbUJBQW1CLENBQUM7QUFJM0IscUJBQWEsOEJBQStCLFlBQVcsWUFBWSxDQUFDLHFCQUFxQixDQUFDO0lBQ3hGLFNBQVMsQ0FBQyxVQUFVLEVBQUUsbUJBQW1CLENBQUM7SUFDMUMsU0FBUyxDQUFDLE1BQU0sRUFBRSxNQUFNLENBQUM7SUFFekIsWUFBWSxVQUFVLEVBQUUsbUJBQW1CLEVBRzFDO0lBRUssUUFBUSxDQUFDLE9BQU8sRUFBRSxxQkFBcUIsR0FBRyxPQUFPLENBQUMsZ0JBQWdCLENBQUMsQ0E2RHhFO0NBQ0YifQ==
+//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYXR0ZXN0YXRpb25fdmFsaWRhdG9yLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi9zcmMvbXNnX3ZhbGlkYXRvcnMvYXR0ZXN0YXRpb25fdmFsaWRhdG9yL2F0dGVzdGF0aW9uX3ZhbGlkYXRvci50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEtBQUssRUFBRSxtQkFBbUIsRUFBRSxNQUFNLG9CQUFvQixDQUFDO0FBRTlELE9BQU8sRUFBRSxLQUFLLE1BQU0sRUFBZ0IsTUFBTSx1QkFBdUIsQ0FBQztBQUNsRSxPQUFPLEVBQ0wsS0FBSyxxQkFBcUIsRUFDMUIsS0FBSyxZQUFZLEVBRWpCLEtBQUssZ0JBQWdCLEVBQ3RCLE1BQU0sbUJBQW1CLENBQUM7QUFJM0IscUJBQWEsOEJBQStCLFlBQVcsWUFBWSxDQUFDLHFCQUFxQixDQUFDO0lBQ3hGLFNBQVMsQ0FBQyxVQUFVLEVBQUUsbUJBQW1CLENBQUM7SUFDMUMsU0FBUyxDQUFDLE1BQU0sRUFBRSxNQUFNLENBQUM7SUFFekIsWUFBWSxVQUFVLEVBQUUsbUJBQW1CLEVBRzFDO0lBRUssUUFBUSxDQUFDLE9BQU8sRUFBRSxxQkFBcUIsR0FBRyxPQUFPLENBQUMsZ0JBQWdCLENBQUMsQ0E4RHhFO0NBQ0YifQ==

package/dest/msg_validators/attestation_validator/attestation_validator.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"attestation_validator.d.ts","sourceRoot":"","sources":["../../../src/msg_validators/attestation_validator/attestation_validator.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,oBAAoB,CAAC;AAE9D,OAAO,EAAE,KAAK,MAAM,EAAgB,MAAM,uBAAuB,CAAC;AAClE,OAAO,EACL,KAAK,qBAAqB,EAC1B,KAAK,YAAY,EAEjB,KAAK,gBAAgB,EACtB,MAAM,mBAAmB,CAAC;AAI3B,qBAAa,8BAA+B,YAAW,YAAY,CAAC,qBAAqB,CAAC;IACxF,SAAS,CAAC,UAAU,EAAE,mBAAmB,CAAC;IAC1C,SAAS,CAAC,MAAM,EAAE,MAAM,CAAC;IAEzB,YAAY,UAAU,EAAE,mBAAmB,EAG1C;IAEK,QAAQ,CAAC,OAAO,EAAE,qBAAqB,GAAG,OAAO,CAAC,gBAAgB,CAAC,CA6DxE;CACF"}
+{"version":3,"file":"attestation_validator.d.ts","sourceRoot":"","sources":["../../../src/msg_validators/attestation_validator/attestation_validator.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,oBAAoB,CAAC;AAE9D,OAAO,EAAE,KAAK,MAAM,EAAgB,MAAM,uBAAuB,CAAC;AAClE,OAAO,EACL,KAAK,qBAAqB,EAC1B,KAAK,YAAY,EAEjB,KAAK,gBAAgB,EACtB,MAAM,mBAAmB,CAAC;AAI3B,qBAAa,8BAA+B,YAAW,YAAY,CAAC,qBAAqB,CAAC;IACxF,SAAS,CAAC,UAAU,EAAE,mBAAmB,CAAC;IAC1C,SAAS,CAAC,MAAM,EAAE,MAAM,CAAC;IAEzB,YAAY,UAAU,EAAE,mBAAmB,EAG1C;IAEK,QAAQ,CAAC,OAAO,EAAE,qBAAqB,GAAG,OAAO,CAAC,gBAAgB,CAAC,CA8DxE;CACF"}

package/dest/msg_validators/attestation_validator/attestation_validator.js

@@ -12,11 +12,12 @@ export class CheckpointAttestationValidator {
     async validate(message) {
         const slotNumber = message.payload.header.slotNumber;
         try {
-            const { currentSlot, nextSlot } = this.epochCache.getCurrentAndNextSlot();
-            if (slotNumber !== currentSlot && slotNumber !== nextSlot) {
+            // Use target slots since proposals target pipeline slots (slot + 1 when pipelining)
+            const { targetSlot, nextSlot } = this.epochCache.getTargetAndNextSlot();
+            if (slotNumber !== targetSlot && slotNumber !== nextSlot) {
                 // Check if message is for previous slot and within clock tolerance
-                if (!isWithinClockTolerance(slotNumber, currentSlot, this.epochCache)) {
-                    this.logger.warn(`Checkpoint attestation slot ${slotNumber} is not current (${currentSlot}) or next (${nextSlot}) slot`);
+                if (!isWithinClockTolerance(slotNumber, targetSlot, this.epochCache)) {
+                    this.logger.warn(`Checkpoint attestation slot ${slotNumber} is not current (${targetSlot}) or next (${nextSlot}) slot`);
                     return {
                         result: 'reject',
                         severity: PeerErrorSeverity.HighToleranceError

package/dest/msg_validators/clock_tolerance.d.ts

@@ -18,4 +18,4 @@ export declare const MAXIMUM_GOSSIP_CLOCK_DISPARITY_MS = 500;
  * @returns true if the message is for the previous slot AND we're within the clock tolerance window
  */
 export declare function isWithinClockTolerance(messageSlot: SlotNumber, currentSlot: SlotNumber, epochCache: EpochCacheInterface): boolean;
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiY2xvY2tfdG9sZXJhbmNlLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi9zcmMvbXNnX3ZhbGlkYXRvcnMvY2xvY2tfdG9sZXJhbmNlLnRzIl0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiJBQUFBLE9BQU8sS0FBSyxFQUFFLG1CQUFtQixFQUFFLE1BQU0sb0JBQW9CLENBQUM7QUFDOUQsT0FBTyxFQUFFLFVBQVUsRUFBRSxNQUFNLGlDQUFpQyxDQUFDO0FBRTdEOzs7Ozs7O0dBT0c7QUFDSCxlQUFPLE1BQU0saUNBQWlDLE1BQU0sQ0FBQztBQUVyRDs7Ozs7OztHQU9HO0FBQ0gsd0JBQWdCLHNCQUFzQixDQUNwQyxXQUFXLEVBQUUsVUFBVSxFQUN2QixXQUFXLEVBQUUsVUFBVSxFQUN2QixVQUFVLEVBQUUsbUJBQW1CLEdBQzlCLE9BQU8sQ0F5QlQifQ==
+//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiY2xvY2tfdG9sZXJhbmNlLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi9zcmMvbXNnX3ZhbGlkYXRvcnMvY2xvY2tfdG9sZXJhbmNlLnRzIl0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiJBQUFBLE9BQU8sS0FBSyxFQUFFLG1CQUFtQixFQUFFLE1BQU0sb0JBQW9CLENBQUM7QUFDOUQsT0FBTyxFQUFFLFVBQVUsRUFBRSxNQUFNLGlDQUFpQyxDQUFDO0FBRTdEOzs7Ozs7O0dBT0c7QUFDSCxlQUFPLE1BQU0saUNBQWlDLE1BQU0sQ0FBQztBQUVyRDs7Ozs7OztHQU9HO0FBQ0gsd0JBQWdCLHNCQUFzQixDQUNwQyxXQUFXLEVBQUUsVUFBVSxFQUN2QixXQUFXLEVBQUUsVUFBVSxFQUN2QixVQUFVLEVBQUUsbUJBQW1CLEdBQzlCLE9BQU8sQ0EwQlQifQ==

package/dest/msg_validators/clock_tolerance.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"clock_tolerance.d.ts","sourceRoot":"","sources":["../../src/msg_validators/clock_tolerance.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,oBAAoB,CAAC;AAC9D,OAAO,EAAE,UAAU,EAAE,MAAM,iCAAiC,CAAC;AAE7D;;;;;;;GAOG;AACH,eAAO,MAAM,iCAAiC,MAAM,CAAC;AAErD;;;;;;;GAOG;AACH,wBAAgB,sBAAsB,CACpC,WAAW,EAAE,UAAU,EACvB,WAAW,EAAE,UAAU,EACvB,UAAU,EAAE,mBAAmB,GAC9B,OAAO,CAyBT"}
+{"version":3,"file":"clock_tolerance.d.ts","sourceRoot":"","sources":["../../src/msg_validators/clock_tolerance.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,oBAAoB,CAAC;AAC9D,OAAO,EAAE,UAAU,EAAE,MAAM,iCAAiC,CAAC;AAE7D;;;;;;;GAOG;AACH,eAAO,MAAM,iCAAiC,MAAM,CAAC;AAErD;;;;;;;GAOG;AACH,wBAAgB,sBAAsB,CACpC,WAAW,EAAE,UAAU,EACvB,WAAW,EAAE,UAAU,EACvB,UAAU,EAAE,mBAAmB,GAC9B,OAAO,CA0BT"}

package/dest/msg_validators/clock_tolerance.js

@@ -25,9 +25,10 @@ import { SlotNumber } from '@aztec/foundation/branded-types';
         return false;
     }
     // Check how far we are into the current slot (in milliseconds)
-    const { ts: slotStartTs, nowMs, slot } = epochCache.getEpochAndSlotNow();
-    // Sanity check: ensure the epoch cache's current slot matches the expected current slot
-    if (slot !== currentSlot) {
+    const { ts: slotStartTs, nowMs } = epochCache.getEpochAndSlotNow();
+    const targetSlot = epochCache.getTargetSlot();
+    // Sanity check: ensure the epoch cache's target slot matches the expected current slot
+    if (targetSlot !== currentSlot) {
         return false;
     }
     // ts is in seconds, convert to ms; nowMs is already in milliseconds

package/dest/msg_validators/proposal_validator/block_proposal_validator.d.ts

@@ -1,9 +1,11 @@
 import type { EpochCacheInterface } from '@aztec/epoch-cache';
-import type { BlockProposal, P2PValidator } from '@aztec/stdlib/p2p';
-import { ProposalValidator } from '../proposal_validator/proposal_validator.js';
-export declare class BlockProposalValidator extends ProposalValidator<BlockProposal> implements P2PValidator<BlockProposal> {
+import type { BlockProposal, P2PValidator, ValidationResult } from '@aztec/stdlib/p2p';
+export declare class BlockProposalValidator implements P2PValidator<BlockProposal> {
+    private proposalValidator;
     constructor(epochCache: EpochCacheInterface, opts: {
         txsPermitted: boolean;
+        maxTxsPerBlock?: number;
     });
+    validate(proposal: BlockProposal): Promise<ValidationResult>;
 }
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYmxvY2tfcHJvcG9zYWxfdmFsaWRhdG9yLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi9zcmMvbXNnX3ZhbGlkYXRvcnMvcHJvcG9zYWxfdmFsaWRhdG9yL2Jsb2NrX3Byb3Bvc2FsX3ZhbGlkYXRvci50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEtBQUssRUFBRSxtQkFBbUIsRUFBRSxNQUFNLG9CQUFvQixDQUFDO0FBQzlELE9BQU8sS0FBSyxFQUFFLGFBQWEsRUFBRSxZQUFZLEVBQUUsTUFBTSxtQkFBbUIsQ0FBQztBQUVyRSxPQUFPLEVBQUUsaUJBQWlCLEVBQUUsTUFBTSw2Q0FBNkMsQ0FBQztBQUVoRixxQkFBYSxzQkFBdUIsU0FBUSxpQkFBaUIsQ0FBQyxhQUFhLENBQUUsWUFBVyxZQUFZLENBQUMsYUFBYSxDQUFDO0lBQ2pILFlBQVksVUFBVSxFQUFFLG1CQUFtQixFQUFFLElBQUksRUFBRTtRQUFFLFlBQVksRUFBRSxPQUFPLENBQUE7S0FBRSxFQUUzRTtDQUNGIn0=
+//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYmxvY2tfcHJvcG9zYWxfdmFsaWRhdG9yLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi9zcmMvbXNnX3ZhbGlkYXRvcnMvcHJvcG9zYWxfdmFsaWRhdG9yL2Jsb2NrX3Byb3Bvc2FsX3ZhbGlkYXRvci50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEtBQUssRUFBRSxtQkFBbUIsRUFBRSxNQUFNLG9CQUFvQixDQUFDO0FBQzlELE9BQU8sS0FBSyxFQUFFLGFBQWEsRUFBRSxZQUFZLEVBQUUsZ0JBQWdCLEVBQUUsTUFBTSxtQkFBbUIsQ0FBQztBQUl2RixxQkFBYSxzQkFBdUIsWUFBVyxZQUFZLENBQUMsYUFBYSxDQUFDO0lBQ3hFLE9BQU8sQ0FBQyxpQkFBaUIsQ0FBb0I7SUFFN0MsWUFBWSxVQUFVLEVBQUUsbUJBQW1CLEVBQUUsSUFBSSxFQUFFO1FBQUUsWUFBWSxFQUFFLE9BQU8sQ0FBQztRQUFDLGNBQWMsQ0FBQyxFQUFFLE1BQU0sQ0FBQTtLQUFFLEVBRXBHO0lBRUssUUFBUSxDQUFDLFFBQVEsRUFBRSxhQUFhLEdBQUcsT0FBTyxDQUFDLGdCQUFnQixDQUFDLENBTWpFO0NBQ0YifQ==

package/dest/msg_validators/proposal_validator/block_proposal_validator.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"block_proposal_validator.d.ts","sourceRoot":"","sources":["../../../src/msg_validators/proposal_validator/block_proposal_validator.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,oBAAoB,CAAC;AAC9D,OAAO,KAAK,EAAE,aAAa,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAC;AAErE,OAAO,EAAE,iBAAiB,EAAE,MAAM,6CAA6C,CAAC;AAEhF,qBAAa,sBAAuB,SAAQ,iBAAiB,CAAC,aAAa,CAAE,YAAW,YAAY,CAAC,aAAa,CAAC;IACjH,YAAY,UAAU,EAAE,mBAAmB,EAAE,IAAI,EAAE;QAAE,YAAY,EAAE,OAAO,CAAA;KAAE,EAE3E;CACF"}
+{"version":3,"file":"block_proposal_validator.d.ts","sourceRoot":"","sources":["../../../src/msg_validators/proposal_validator/block_proposal_validator.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,oBAAoB,CAAC;AAC9D,OAAO,KAAK,EAAE,aAAa,EAAE,YAAY,EAAE,gBAAgB,EAAE,MAAM,mBAAmB,CAAC;AAIvF,qBAAa,sBAAuB,YAAW,YAAY,CAAC,aAAa,CAAC;IACxE,OAAO,CAAC,iBAAiB,CAAoB;IAE7C,YAAY,UAAU,EAAE,mBAAmB,EAAE,IAAI,EAAE;QAAE,YAAY,EAAE,OAAO,CAAC;QAAC,cAAc,CAAC,EAAE,MAAM,CAAA;KAAE,EAEpG;IAEK,QAAQ,CAAC,QAAQ,EAAE,aAAa,GAAG,OAAO,CAAC,gBAAgB,CAAC,CAMjE;CACF"}

package/dest/msg_validators/proposal_validator/block_proposal_validator.js

@@ -1,6 +1,14 @@
 import { ProposalValidator } from '../proposal_validator/proposal_validator.js';
-export class BlockProposalValidator extends ProposalValidator {
+export class BlockProposalValidator {
+    proposalValidator;
     constructor(epochCache, opts){
-        super(epochCache, opts, 'p2p:block_proposal_validator');
+        this.proposalValidator = new ProposalValidator(epochCache, opts, 'p2p:block_proposal_validator');
+    }
+    async validate(proposal) {
+        const headerResult = await this.proposalValidator.validate(proposal);
+        if (headerResult.result !== 'accept') {
+            return headerResult;
+        }
+        return this.proposalValidator.validateTxs(proposal);
     }
 }