@aztec/p2p 0.0.1-commit.6d63667d → 0.0.1-commit.733c4a3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (315) hide show
  1. package/dest/client/factory.d.ts +7 -6
  2. package/dest/client/factory.d.ts.map +1 -1
  3. package/dest/client/factory.js +35 -11
  4. package/dest/client/interface.d.ts +45 -32
  5. package/dest/client/interface.d.ts.map +1 -1
  6. package/dest/client/p2p_client.d.ts +38 -50
  7. package/dest/client/p2p_client.d.ts.map +1 -1
  8. package/dest/client/p2p_client.js +145 -200
  9. package/dest/client/test/tx_proposal_collector/proposal_tx_collector_worker.js +6 -6
  10. package/dest/config.d.ts +24 -8
  11. package/dest/config.d.ts.map +1 -1
  12. package/dest/config.js +16 -6
  13. package/dest/errors/tx-pool.error.d.ts +8 -0
  14. package/dest/errors/tx-pool.error.d.ts.map +1 -0
  15. package/dest/errors/tx-pool.error.js +9 -0
  16. package/dest/index.d.ts +2 -1
  17. package/dest/index.d.ts.map +1 -1
  18. package/dest/index.js +1 -0
  19. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts +104 -88
  20. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts.map +1 -1
  21. package/dest/mem_pools/attestation_pool/attestation_pool.js +441 -3
  22. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.d.ts +2 -2
  23. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.d.ts.map +1 -1
  24. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.js +353 -87
  25. package/dest/mem_pools/attestation_pool/index.d.ts +2 -3
  26. package/dest/mem_pools/attestation_pool/index.d.ts.map +1 -1
  27. package/dest/mem_pools/attestation_pool/index.js +1 -2
  28. package/dest/mem_pools/attestation_pool/mocks.d.ts +2 -2
  29. package/dest/mem_pools/attestation_pool/mocks.d.ts.map +1 -1
  30. package/dest/mem_pools/attestation_pool/mocks.js +2 -2
  31. package/dest/mem_pools/index.d.ts +3 -2
  32. package/dest/mem_pools/index.d.ts.map +1 -1
  33. package/dest/mem_pools/index.js +1 -1
  34. package/dest/mem_pools/interface.d.ts +5 -5
  35. package/dest/mem_pools/interface.d.ts.map +1 -1
  36. package/dest/mem_pools/tx_pool/eviction/invalid_txs_after_mining_rule.js +3 -3
  37. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts +104 -0
  38. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts.map +1 -0
  39. package/dest/mem_pools/tx_pool_v2/deleted_pool.js +251 -0
  40. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.d.ts +3 -3
  41. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.d.ts.map +1 -1
  42. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.js +18 -9
  43. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.d.ts +1 -1
  44. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.d.ts.map +1 -1
  45. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.js +5 -2
  46. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.d.ts +3 -3
  47. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.d.ts.map +1 -1
  48. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.js +10 -4
  49. package/dest/mem_pools/tx_pool_v2/eviction/index.d.ts +2 -2
  50. package/dest/mem_pools/tx_pool_v2/eviction/index.d.ts.map +1 -1
  51. package/dest/mem_pools/tx_pool_v2/eviction/index.js +1 -1
  52. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.d.ts +48 -5
  53. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.d.ts.map +1 -1
  54. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.js +8 -0
  55. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.js +7 -5
  56. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.js +7 -5
  57. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts +2 -2
  58. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts.map +1 -1
  59. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.js +14 -6
  60. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.d.ts +4 -4
  61. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.d.ts.map +1 -1
  62. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.js +14 -4
  63. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.d.ts +3 -3
  64. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.d.ts.map +1 -1
  65. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.js +2 -2
  66. package/dest/mem_pools/tx_pool_v2/index.d.ts +2 -1
  67. package/dest/mem_pools/tx_pool_v2/index.d.ts.map +1 -1
  68. package/dest/mem_pools/tx_pool_v2/index.js +1 -0
  69. package/dest/mem_pools/tx_pool_v2/instrumentation.d.ts +15 -0
  70. package/dest/mem_pools/tx_pool_v2/instrumentation.d.ts.map +1 -0
  71. package/dest/mem_pools/tx_pool_v2/instrumentation.js +43 -0
  72. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts +22 -8
  73. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts.map +1 -1
  74. package/dest/mem_pools/tx_pool_v2/interfaces.js +4 -1
  75. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts +39 -5
  76. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts.map +1 -1
  77. package/dest/mem_pools/tx_pool_v2/tx_metadata.js +74 -5
  78. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts +12 -3
  79. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts.map +1 -1
  80. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.js +27 -4
  81. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts +9 -4
  82. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts.map +1 -1
  83. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.js +11 -6
  84. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts +13 -5
  85. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts.map +1 -1
  86. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.js +312 -169
  87. package/dest/msg_validators/attestation_validator/fisherman_attestation_validator.d.ts +3 -3
  88. package/dest/msg_validators/attestation_validator/fisherman_attestation_validator.d.ts.map +1 -1
  89. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts +4 -4
  90. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts.map +1 -1
  91. package/dest/msg_validators/tx_validator/aggregate_tx_validator.js +3 -3
  92. package/dest/msg_validators/tx_validator/block_header_validator.d.ts +16 -3
  93. package/dest/msg_validators/tx_validator/block_header_validator.d.ts.map +1 -1
  94. package/dest/msg_validators/tx_validator/block_header_validator.js +1 -1
  95. package/dest/msg_validators/tx_validator/double_spend_validator.d.ts +13 -3
  96. package/dest/msg_validators/tx_validator/double_spend_validator.d.ts.map +1 -1
  97. package/dest/msg_validators/tx_validator/double_spend_validator.js +4 -4
  98. package/dest/msg_validators/tx_validator/factory.d.ts +114 -6
  99. package/dest/msg_validators/tx_validator/factory.d.ts.map +1 -1
  100. package/dest/msg_validators/tx_validator/factory.js +219 -58
  101. package/dest/msg_validators/tx_validator/gas_validator.d.ts +58 -3
  102. package/dest/msg_validators/tx_validator/gas_validator.d.ts.map +1 -1
  103. package/dest/msg_validators/tx_validator/gas_validator.js +73 -36
  104. package/dest/msg_validators/tx_validator/index.d.ts +2 -1
  105. package/dest/msg_validators/tx_validator/index.d.ts.map +1 -1
  106. package/dest/msg_validators/tx_validator/index.js +1 -0
  107. package/dest/msg_validators/tx_validator/nullifier_cache.d.ts +14 -0
  108. package/dest/msg_validators/tx_validator/nullifier_cache.d.ts.map +1 -0
  109. package/dest/msg_validators/tx_validator/nullifier_cache.js +24 -0
  110. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts +20 -4
  111. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts.map +1 -1
  112. package/dest/msg_validators/tx_validator/timestamp_validator.js +6 -6
  113. package/dest/services/dummy_service.d.ts +13 -5
  114. package/dest/services/dummy_service.d.ts.map +1 -1
  115. package/dest/services/dummy_service.js +10 -4
  116. package/dest/services/encoding.d.ts +2 -2
  117. package/dest/services/encoding.d.ts.map +1 -1
  118. package/dest/services/encoding.js +4 -3
  119. package/dest/services/gossipsub/index.d.ts +3 -0
  120. package/dest/services/gossipsub/index.d.ts.map +1 -0
  121. package/dest/services/gossipsub/index.js +2 -0
  122. package/dest/services/gossipsub/scoring.d.ts +21 -3
  123. package/dest/services/gossipsub/scoring.d.ts.map +1 -1
  124. package/dest/services/gossipsub/scoring.js +24 -7
  125. package/dest/services/gossipsub/topic_score_params.d.ts +173 -0
  126. package/dest/services/gossipsub/topic_score_params.d.ts.map +1 -0
  127. package/dest/services/gossipsub/topic_score_params.js +346 -0
  128. package/dest/services/libp2p/libp2p_service.d.ts +91 -38
  129. package/dest/services/libp2p/libp2p_service.d.ts.map +1 -1
  130. package/dest/services/libp2p/libp2p_service.js +411 -321
  131. package/dest/services/peer-manager/peer_scoring.d.ts +1 -1
  132. package/dest/services/peer-manager/peer_scoring.d.ts.map +1 -1
  133. package/dest/services/peer-manager/peer_scoring.js +25 -2
  134. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts +4 -3
  135. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts.map +1 -1
  136. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.js +19 -46
  137. package/dest/services/reqresp/batch-tx-requester/interface.d.ts +2 -6
  138. package/dest/services/reqresp/batch-tx-requester/interface.d.ts.map +1 -1
  139. package/dest/services/reqresp/batch-tx-requester/missing_txs.d.ts +10 -13
  140. package/dest/services/reqresp/batch-tx-requester/missing_txs.d.ts.map +1 -1
  141. package/dest/services/reqresp/batch-tx-requester/missing_txs.js +25 -46
  142. package/dest/services/reqresp/batch-tx-requester/peer_collection.d.ts +17 -11
  143. package/dest/services/reqresp/batch-tx-requester/peer_collection.d.ts.map +1 -1
  144. package/dest/services/reqresp/batch-tx-requester/peer_collection.js +49 -15
  145. package/dest/services/reqresp/batch-tx-requester/tx_validator.js +2 -2
  146. package/dest/services/reqresp/interface.d.ts +10 -1
  147. package/dest/services/reqresp/interface.d.ts.map +1 -1
  148. package/dest/services/reqresp/interface.js +15 -1
  149. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.d.ts +4 -3
  150. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.d.ts.map +1 -1
  151. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.d.ts +7 -1
  152. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.d.ts.map +1 -1
  153. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.js +15 -0
  154. package/dest/services/reqresp/protocols/tx.d.ts +7 -1
  155. package/dest/services/reqresp/protocols/tx.d.ts.map +1 -1
  156. package/dest/services/reqresp/protocols/tx.js +20 -0
  157. package/dest/services/reqresp/reqresp.d.ts +1 -1
  158. package/dest/services/reqresp/reqresp.d.ts.map +1 -1
  159. package/dest/services/reqresp/reqresp.js +11 -4
  160. package/dest/services/service.d.ts +39 -3
  161. package/dest/services/service.d.ts.map +1 -1
  162. package/dest/services/tx_collection/config.d.ts +19 -1
  163. package/dest/services/tx_collection/config.d.ts.map +1 -1
  164. package/dest/services/tx_collection/config.js +46 -0
  165. package/dest/services/tx_collection/fast_tx_collection.d.ts +3 -1
  166. package/dest/services/tx_collection/fast_tx_collection.d.ts.map +1 -1
  167. package/dest/services/tx_collection/fast_tx_collection.js +56 -36
  168. package/dest/services/tx_collection/file_store_tx_collection.d.ts +53 -0
  169. package/dest/services/tx_collection/file_store_tx_collection.d.ts.map +1 -0
  170. package/dest/services/tx_collection/file_store_tx_collection.js +167 -0
  171. package/dest/services/tx_collection/file_store_tx_source.d.ts +37 -0
  172. package/dest/services/tx_collection/file_store_tx_source.d.ts.map +1 -0
  173. package/dest/services/tx_collection/file_store_tx_source.js +90 -0
  174. package/dest/services/tx_collection/index.d.ts +2 -1
  175. package/dest/services/tx_collection/index.d.ts.map +1 -1
  176. package/dest/services/tx_collection/index.js +1 -0
  177. package/dest/services/tx_collection/instrumentation.d.ts +1 -1
  178. package/dest/services/tx_collection/instrumentation.d.ts.map +1 -1
  179. package/dest/services/tx_collection/instrumentation.js +2 -1
  180. package/dest/services/tx_collection/missing_txs_tracker.d.ts +32 -0
  181. package/dest/services/tx_collection/missing_txs_tracker.d.ts.map +1 -0
  182. package/dest/services/tx_collection/missing_txs_tracker.js +27 -0
  183. package/dest/services/tx_collection/proposal_tx_collector.d.ts +7 -6
  184. package/dest/services/tx_collection/proposal_tx_collector.d.ts.map +1 -1
  185. package/dest/services/tx_collection/proposal_tx_collector.js +5 -4
  186. package/dest/services/tx_collection/slow_tx_collection.d.ts +7 -3
  187. package/dest/services/tx_collection/slow_tx_collection.d.ts.map +1 -1
  188. package/dest/services/tx_collection/slow_tx_collection.js +60 -26
  189. package/dest/services/tx_collection/tx_collection.d.ts +23 -10
  190. package/dest/services/tx_collection/tx_collection.d.ts.map +1 -1
  191. package/dest/services/tx_collection/tx_collection.js +75 -3
  192. package/dest/services/tx_collection/tx_collection_sink.d.ts +18 -8
  193. package/dest/services/tx_collection/tx_collection_sink.d.ts.map +1 -1
  194. package/dest/services/tx_collection/tx_collection_sink.js +26 -29
  195. package/dest/services/tx_collection/tx_source.d.ts +8 -3
  196. package/dest/services/tx_collection/tx_source.d.ts.map +1 -1
  197. package/dest/services/tx_collection/tx_source.js +19 -2
  198. package/dest/services/tx_file_store/config.d.ts +1 -3
  199. package/dest/services/tx_file_store/config.d.ts.map +1 -1
  200. package/dest/services/tx_file_store/config.js +0 -4
  201. package/dest/services/tx_file_store/tx_file_store.d.ts +4 -3
  202. package/dest/services/tx_file_store/tx_file_store.d.ts.map +1 -1
  203. package/dest/services/tx_file_store/tx_file_store.js +9 -6
  204. package/dest/services/tx_provider.d.ts +4 -4
  205. package/dest/services/tx_provider.d.ts.map +1 -1
  206. package/dest/services/tx_provider.js +9 -8
  207. package/dest/test-helpers/make-test-p2p-clients.d.ts +3 -3
  208. package/dest/test-helpers/make-test-p2p-clients.d.ts.map +1 -1
  209. package/dest/test-helpers/mock-pubsub.d.ts +29 -2
  210. package/dest/test-helpers/mock-pubsub.d.ts.map +1 -1
  211. package/dest/test-helpers/mock-pubsub.js +103 -2
  212. package/dest/test-helpers/reqresp-nodes.d.ts +1 -1
  213. package/dest/test-helpers/reqresp-nodes.d.ts.map +1 -1
  214. package/dest/test-helpers/reqresp-nodes.js +2 -1
  215. package/dest/test-helpers/testbench-utils.d.ts +43 -38
  216. package/dest/test-helpers/testbench-utils.d.ts.map +1 -1
  217. package/dest/test-helpers/testbench-utils.js +128 -59
  218. package/dest/testbench/p2p_client_testbench_worker.d.ts +2 -2
  219. package/dest/testbench/p2p_client_testbench_worker.d.ts.map +1 -1
  220. package/dest/testbench/p2p_client_testbench_worker.js +10 -10
  221. package/dest/util.d.ts +2 -2
  222. package/dest/util.d.ts.map +1 -1
  223. package/package.json +14 -14
  224. package/src/client/factory.ts +66 -14
  225. package/src/client/interface.ts +61 -33
  226. package/src/client/p2p_client.ts +179 -236
  227. package/src/client/test/tx_proposal_collector/proposal_tx_collector_worker.ts +19 -9
  228. package/src/config.ts +35 -11
  229. package/src/errors/tx-pool.error.ts +12 -0
  230. package/src/index.ts +1 -0
  231. package/src/mem_pools/attestation_pool/attestation_pool.ts +496 -91
  232. package/src/mem_pools/attestation_pool/attestation_pool_test_suite.ts +442 -102
  233. package/src/mem_pools/attestation_pool/index.ts +9 -2
  234. package/src/mem_pools/attestation_pool/mocks.ts +2 -1
  235. package/src/mem_pools/index.ts +4 -1
  236. package/src/mem_pools/interface.ts +4 -4
  237. package/src/mem_pools/tx_pool/README.md +1 -1
  238. package/src/mem_pools/tx_pool/eviction/invalid_txs_after_mining_rule.ts +3 -3
  239. package/src/mem_pools/tx_pool_v2/README.md +76 -10
  240. package/src/mem_pools/tx_pool_v2/deleted_pool.ts +321 -0
  241. package/src/mem_pools/tx_pool_v2/eviction/eviction_manager.ts +21 -8
  242. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.ts +5 -2
  243. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.ts +15 -4
  244. package/src/mem_pools/tx_pool_v2/eviction/index.ts +4 -0
  245. package/src/mem_pools/tx_pool_v2/eviction/interfaces.ts +49 -4
  246. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.ts +5 -5
  247. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.ts +5 -5
  248. package/src/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.ts +14 -9
  249. package/src/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.ts +24 -6
  250. package/src/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.ts +3 -3
  251. package/src/mem_pools/tx_pool_v2/index.ts +1 -0
  252. package/src/mem_pools/tx_pool_v2/instrumentation.ts +69 -0
  253. package/src/mem_pools/tx_pool_v2/interfaces.ts +23 -8
  254. package/src/mem_pools/tx_pool_v2/tx_metadata.ts +103 -9
  255. package/src/mem_pools/tx_pool_v2/tx_pool_indices.ts +32 -5
  256. package/src/mem_pools/tx_pool_v2/tx_pool_v2.ts +18 -7
  257. package/src/mem_pools/tx_pool_v2/tx_pool_v2_impl.ts +347 -166
  258. package/src/msg_validators/attestation_validator/fisherman_attestation_validator.ts +2 -2
  259. package/src/msg_validators/tx_validator/README.md +115 -0
  260. package/src/msg_validators/tx_validator/aggregate_tx_validator.ts +5 -5
  261. package/src/msg_validators/tx_validator/block_header_validator.ts +15 -3
  262. package/src/msg_validators/tx_validator/double_spend_validator.ts +11 -6
  263. package/src/msg_validators/tx_validator/factory.ts +353 -77
  264. package/src/msg_validators/tx_validator/gas_validator.ts +90 -27
  265. package/src/msg_validators/tx_validator/index.ts +1 -0
  266. package/src/msg_validators/tx_validator/nullifier_cache.ts +30 -0
  267. package/src/msg_validators/tx_validator/timestamp_validator.ts +23 -18
  268. package/src/services/dummy_service.ts +18 -6
  269. package/src/services/encoding.ts +4 -3
  270. package/src/services/gossipsub/README.md +641 -0
  271. package/src/services/gossipsub/index.ts +2 -0
  272. package/src/services/gossipsub/scoring.ts +29 -5
  273. package/src/services/gossipsub/topic_score_params.ts +487 -0
  274. package/src/services/libp2p/libp2p_service.ts +431 -344
  275. package/src/services/peer-manager/peer_scoring.ts +25 -0
  276. package/src/services/reqresp/batch-tx-requester/batch_tx_requester.ts +20 -48
  277. package/src/services/reqresp/batch-tx-requester/interface.ts +1 -5
  278. package/src/services/reqresp/batch-tx-requester/missing_txs.ts +23 -71
  279. package/src/services/reqresp/batch-tx-requester/peer_collection.ts +63 -24
  280. package/src/services/reqresp/batch-tx-requester/tx_validator.ts +2 -2
  281. package/src/services/reqresp/interface.ts +26 -1
  282. package/src/services/reqresp/protocols/block_txs/block_txs_handler.ts +4 -3
  283. package/src/services/reqresp/protocols/block_txs/block_txs_reqresp.ts +17 -0
  284. package/src/services/reqresp/protocols/tx.ts +22 -0
  285. package/src/services/reqresp/reqresp.ts +13 -3
  286. package/src/services/service.ts +51 -2
  287. package/src/services/tx_collection/config.ts +68 -0
  288. package/src/services/tx_collection/fast_tx_collection.ts +65 -32
  289. package/src/services/tx_collection/file_store_tx_collection.ts +202 -0
  290. package/src/services/tx_collection/file_store_tx_source.ts +117 -0
  291. package/src/services/tx_collection/index.ts +1 -0
  292. package/src/services/tx_collection/instrumentation.ts +7 -1
  293. package/src/services/tx_collection/missing_txs_tracker.ts +52 -0
  294. package/src/services/tx_collection/proposal_tx_collector.ts +8 -7
  295. package/src/services/tx_collection/slow_tx_collection.ts +66 -33
  296. package/src/services/tx_collection/tx_collection.ts +113 -16
  297. package/src/services/tx_collection/tx_collection_sink.ts +30 -34
  298. package/src/services/tx_collection/tx_source.ts +22 -3
  299. package/src/services/tx_file_store/config.ts +0 -6
  300. package/src/services/tx_file_store/tx_file_store.ts +10 -8
  301. package/src/services/tx_provider.ts +10 -9
  302. package/src/test-helpers/make-test-p2p-clients.ts +3 -3
  303. package/src/test-helpers/mock-pubsub.ts +143 -3
  304. package/src/test-helpers/reqresp-nodes.ts +2 -1
  305. package/src/test-helpers/testbench-utils.ts +127 -71
  306. package/src/testbench/p2p_client_testbench_worker.ts +22 -15
  307. package/src/util.ts +7 -1
  308. package/dest/mem_pools/attestation_pool/kv_attestation_pool.d.ts +0 -40
  309. package/dest/mem_pools/attestation_pool/kv_attestation_pool.d.ts.map +0 -1
  310. package/dest/mem_pools/attestation_pool/kv_attestation_pool.js +0 -218
  311. package/dest/mem_pools/attestation_pool/memory_attestation_pool.d.ts +0 -31
  312. package/dest/mem_pools/attestation_pool/memory_attestation_pool.d.ts.map +0 -1
  313. package/dest/mem_pools/attestation_pool/memory_attestation_pool.js +0 -180
  314. package/src/mem_pools/attestation_pool/kv_attestation_pool.ts +0 -320
  315. package/src/mem_pools/attestation_pool/memory_attestation_pool.ts +0 -264
@@ -1,6 +1,5 @@
1
1
  import type { EpochCacheInterface } from '@aztec/epoch-cache';
2
- import { BlockNumber } from '@aztec/foundation/branded-types';
3
- import { randomInt } from '@aztec/foundation/crypto/random';
2
+ import { BlockNumber, type SlotNumber } from '@aztec/foundation/branded-types';
4
3
  import { Fr } from '@aztec/foundation/curves/bn254';
5
4
  import { type Logger, createLibp2pComponentLogger, createLogger } from '@aztec/foundation/log';
6
5
  import { RunningPromise } from '@aztec/foundation/running-promise';
@@ -45,7 +44,7 @@ import {
45
44
  type GossipsubMessage,
46
45
  gossipsub,
47
46
  } from '@chainsafe/libp2p-gossipsub';
48
- import { createPeerScoreParams, createTopicScoreParams } from '@chainsafe/libp2p-gossipsub/score';
47
+ import { createPeerScoreParams } from '@chainsafe/libp2p-gossipsub/score';
49
48
  import { SignaturePolicy } from '@chainsafe/libp2p-gossipsub/types';
50
49
  import { noise } from '@chainsafe/libp2p-noise';
51
50
  import { yamux } from '@chainsafe/libp2p-yamux';
@@ -59,8 +58,7 @@ import { ENR } from '@nethermindeth/enr';
59
58
  import { createLibp2p } from 'libp2p';
60
59
 
61
60
  import type { P2PConfig } from '../../config.js';
62
- import { ProposalSlotCapExceededError } from '../../errors/attestation-pool.error.js';
63
- import type { MemPools } from '../../mem_pools/index.js';
61
+ import type { MemPools } from '../../mem_pools/interface.js';
64
62
  import {
65
63
  BlockProposalValidator,
66
64
  CheckpointAttestationValidator,
@@ -71,9 +69,11 @@ import {
71
69
  } from '../../msg_validators/index.js';
72
70
  import { MessageSeenValidator } from '../../msg_validators/msg_seen_validator/msg_seen_validator.js';
73
71
  import {
74
- type MessageValidator,
75
- createTxMessageValidators,
76
- createTxReqRespValidator,
72
+ type TransactionValidator,
73
+ createFirstStageTxValidationsForGossipedTransactions,
74
+ createSecondStageTxValidationsForGossipedTransactions,
75
+ createTxValidatorForBlockProposalReceivedTxs,
76
+ createTxValidatorForReqResponseReceivedTxs,
77
77
  } from '../../msg_validators/tx_validator/factory.js';
78
78
  import { GossipSubEvent } from '../../types/index.js';
79
79
  import { type PubSubLibp2p, convertToMultiaddr } from '../../util.js';
@@ -81,13 +81,17 @@ import { getVersions } from '../../versioning.js';
81
81
  import { AztecDatastore } from '../data_store.js';
82
82
  import { DiscV5Service } from '../discv5/discV5_service.js';
83
83
  import { SnappyTransform, fastMsgIdFn, getMsgIdFn, msgIdToStrFn } from '../encoding.js';
84
- import { gossipScoreThresholds } from '../gossipsub/scoring.js';
84
+ import { APP_SPECIFIC_WEIGHT, gossipScoreThresholds } from '../gossipsub/scoring.js';
85
+ import { createAllTopicScoreParams } from '../gossipsub/topic_score_params.js';
85
86
  import type { PeerManagerInterface } from '../peer-manager/interface.js';
86
87
  import { PeerManager } from '../peer-manager/peer_manager.js';
87
88
  import { PeerScoring } from '../peer-manager/peer_scoring.js';
88
89
  import type { BatchTxRequesterLibP2PService } from '../reqresp/batch-tx-requester/interface.js';
89
90
  import type { P2PReqRespConfig } from '../reqresp/config.js';
90
91
  import {
92
+ AuthRequest,
93
+ BlockTxsRequest,
94
+ BlockTxsResponse,
91
95
  DEFAULT_SUB_PROTOCOL_VALIDATORS,
92
96
  type ReqRespInterface,
93
97
  type ReqRespResponse,
@@ -95,14 +99,9 @@ import {
95
99
  type ReqRespSubProtocolHandler,
96
100
  type ReqRespSubProtocolHandlers,
97
101
  type ReqRespSubProtocolValidators,
102
+ StatusMessage,
98
103
  type SubProtocolMap,
99
104
  ValidationError,
100
- } from '../reqresp/index.js';
101
- import {
102
- AuthRequest,
103
- BlockTxsRequest,
104
- BlockTxsResponse,
105
- StatusMessage,
106
105
  pingHandler,
107
106
  reqGoodbyeHandler,
108
107
  reqRespBlockHandler,
@@ -114,6 +113,7 @@ import { ReqResp } from '../reqresp/reqresp.js';
114
113
  import type {
115
114
  P2PBlockReceivedCallback,
116
115
  P2PCheckpointReceivedCallback,
116
+ P2PDuplicateAttestationCallback,
117
117
  P2PService,
118
118
  PeerDiscoveryService,
119
119
  } from '../service.js';
@@ -128,9 +128,9 @@ interface ValidationResult {
128
128
  type ValidationOutcome = { allPassed: true } | { allPassed: false; failure: ValidationResult };
129
129
 
130
130
  // REFACTOR: Unify with the type above
131
- type ReceivedMessageValidationResult<T> =
132
- | { obj: T; result: Exclude<TopicValidatorResult, TopicValidatorResult.Reject> }
133
- | { obj?: undefined; result: TopicValidatorResult.Reject };
131
+ type ReceivedMessageValidationResult<T, M = undefined> =
132
+ | { obj: T; result: Exclude<TopicValidatorResult, TopicValidatorResult.Reject>; metadata?: M }
133
+ | { obj?: T; result: TopicValidatorResult.Reject; metadata?: M };
134
134
 
135
135
  /**
136
136
  * Lib P2P implementation of the P2PService interface.
@@ -149,6 +149,16 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
149
149
 
150
150
  private feesCache: { blockNumber: BlockNumber; gasFees: GasFees } | undefined;
151
151
 
152
+ /** Callback invoked when a duplicate proposal is detected (triggers slashing). */
153
+ private duplicateProposalCallback?: (info: {
154
+ slot: SlotNumber;
155
+ proposer: EthAddress;
156
+ type: 'checkpoint' | 'block';
157
+ }) => void;
158
+
159
+ /** Callback invoked when a duplicate attestation is detected (triggers slashing). */
160
+ private duplicateAttestationCallback?: P2PDuplicateAttestationCallback;
161
+
152
162
  /**
153
163
  * Callback for when a block is received from a peer.
154
164
  * @param block - The block received from the peer.
@@ -177,9 +187,9 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
177
187
  protected node: PubSubLibp2p,
178
188
  private peerDiscoveryService: PeerDiscoveryService,
179
189
  private reqresp: ReqRespInterface,
180
- private peerManager: PeerManagerInterface,
190
+ protected peerManager: PeerManagerInterface,
181
191
  protected mempools: MemPools,
182
- private archiver: L2BlockSource & ContractDataSource,
192
+ protected archiver: L2BlockSource & ContractDataSource,
183
193
  private epochCache: EpochCacheInterface,
184
194
  private proofVerifier: ClientProtocolCircuitVerifier,
185
195
  private worldStateSynchronizer: WorldStateSynchronizer,
@@ -305,11 +315,6 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
305
315
  const versions = getVersions(config);
306
316
  const protocolVersion = compressComponentVersions(versions);
307
317
 
308
- const txTopic = createTopicString(TopicType.tx, protocolVersion);
309
- const blockProposalTopic = createTopicString(TopicType.block_proposal, protocolVersion);
310
- const checkpointProposalTopic = createTopicString(TopicType.checkpoint_proposal, protocolVersion);
311
- const checkpointAttestationTopic = createTopicString(TopicType.checkpoint_attestation, protocolVersion);
312
-
313
318
  const preferredPeersEnrs: ENR[] = config.preferredPeers.map(enr => ENR.decodeTxt(enr));
314
319
  const directPeers = (
315
320
  await Promise.all(
@@ -329,6 +334,16 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
329
334
 
330
335
  const announceTcpMultiaddr = config.p2pIp ? [convertToMultiaddr(config.p2pIp, p2pPort, 'tcp')] : [];
331
336
 
337
+ // Create dynamic topic score params based on network configuration
338
+ const l1Constants = epochCache.getL1Constants();
339
+ const topicScoreParams = createAllTopicScoreParams(protocolVersion, {
340
+ slotDurationMs: l1Constants.slotDuration * 1000,
341
+ heartbeatIntervalMs: config.gossipsubInterval,
342
+ targetCommitteeSize: l1Constants.targetCommitteeSize,
343
+ blockDurationMs: config.blockDurationMs,
344
+ expectedBlockProposalsPerSlot: config.expectedBlockProposalsPerSlot,
345
+ });
346
+
332
347
  const node = await createLibp2p({
333
348
  start: false,
334
349
  peerId,
@@ -424,28 +439,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
424
439
  scoreParams: createPeerScoreParams({
425
440
  // IPColocation factor can be disabled for local testing - default to -5
426
441
  IPColocationFactorWeight: config.debugDisableColocationPenalty ? 0 : -5.0,
427
- topics: {
428
- [txTopic]: createTopicScoreParams({
429
- topicWeight: 1,
430
- invalidMessageDeliveriesWeight: -20,
431
- invalidMessageDeliveriesDecay: 0.5,
432
- }),
433
- [blockProposalTopic]: createTopicScoreParams({
434
- topicWeight: 1,
435
- invalidMessageDeliveriesWeight: -20,
436
- invalidMessageDeliveriesDecay: 0.5,
437
- }),
438
- [checkpointProposalTopic]: createTopicScoreParams({
439
- topicWeight: 1,
440
- invalidMessageDeliveriesWeight: -20,
441
- invalidMessageDeliveriesDecay: 0.5,
442
- }),
443
- [checkpointAttestationTopic]: createTopicScoreParams({
444
- topicWeight: 1,
445
- invalidMessageDeliveriesWeight: -20,
446
- invalidMessageDeliveriesDecay: 0.5,
447
- }),
448
- },
442
+ topics: topicScoreParams,
449
443
  }),
450
444
  }) as (components: GossipSubComponents) => GossipSub,
451
445
  components: (components: { connectionManager: ConnectionManager }) => ({
@@ -471,8 +465,12 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
471
465
  epochCache,
472
466
  );
473
467
 
474
- // Update gossipsub score params
475
- node.services.pubsub.score.params.appSpecificWeight = 10;
468
+ // Configure application-specific scoring for gossipsub.
469
+ // The weight scales app score to align with gossipsub thresholds:
470
+ // - Disconnect (-50) × 10 = -500 = gossipThreshold (stops receiving gossip)
471
+ // - Ban (-100) × 10 = -1000 = publishThreshold (cannot publish)
472
+ // Note: positive topic scores can offset penalties, so alignment is best-effort.
473
+ node.services.pubsub.score.params.appSpecificWeight = APP_SPECIFIC_WEIGHT;
476
474
  node.services.pubsub.score.params.appSpecificScore = (peerId: string) =>
477
475
  peerManager.shouldDisableP2PGossip(peerId) ? -Infinity : peerManager.getPeerScore(peerId);
478
476
 
@@ -617,6 +615,10 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
617
615
  return this.peerManager.getPeers(includePending);
618
616
  }
619
617
 
618
+ public getGossipMeshPeerCount(topicType: TopicType): number {
619
+ return this.node.services.pubsub.getMeshPeers(this.topicStrings[topicType]).length;
620
+ }
621
+
620
622
  private handleGossipSubEvent(e: CustomEvent<GossipsubMessage>) {
621
623
  this.logger.trace(`Received PUBSUB message.`);
622
624
 
@@ -669,6 +671,25 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
669
671
  this.checkpointReceivedCallback = callback;
670
672
  }
671
673
 
674
+ /**
675
+ * Registers a callback to be invoked when a duplicate proposal is detected.
676
+ * This callback is triggered on the first duplicate (when count goes from 1 to 2).
677
+ */
678
+ public registerDuplicateProposalCallback(
679
+ callback: (info: { slot: SlotNumber; proposer: EthAddress; type: 'checkpoint' | 'block' }) => void,
680
+ ): void {
681
+ this.duplicateProposalCallback = callback;
682
+ }
683
+
684
+ /**
685
+ * Registers a callback to be invoked when a duplicate attestation is detected.
686
+ * A validator signing attestations for different proposals at the same slot.
687
+ * This callback is triggered on the first duplicate (when count goes from 1 to 2).
688
+ */
689
+ public registerDuplicateAttestationCallback(callback: P2PDuplicateAttestationCallback): void {
690
+ this.duplicateAttestationCallback = callback;
691
+ }
692
+
672
693
  /**
673
694
  * Subscribes to a topic.
674
695
  * @param topic - The topic to subscribe to.
@@ -855,13 +876,13 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
855
876
  return;
856
877
  }
857
878
 
858
- protected async validateReceivedMessage<T>(
859
- validationFunc: () => Promise<ReceivedMessageValidationResult<T>>,
879
+ protected async validateReceivedMessage<T, M = undefined>(
880
+ validationFunc: () => Promise<ReceivedMessageValidationResult<T, M>>,
860
881
  msgId: string,
861
882
  source: PeerId,
862
883
  topicType: TopicType,
863
- ): Promise<ReceivedMessageValidationResult<T>> {
864
- let resultAndObj: ReceivedMessageValidationResult<T> = { result: TopicValidatorResult.Reject };
884
+ ): Promise<ReceivedMessageValidationResult<T, M>> {
885
+ let resultAndObj: ReceivedMessageValidationResult<T, M> = { result: TopicValidatorResult.Reject };
865
886
  const timer = new Timer();
866
887
  try {
867
888
  resultAndObj = await validationFunc();
@@ -885,21 +906,63 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
885
906
  protected async handleGossipedTx(payloadData: Buffer, msgId: string, source: PeerId) {
886
907
  const validationFunc: () => Promise<ReceivedMessageValidationResult<Tx>> = async () => {
887
908
  const tx = Tx.fromBuffer(payloadData);
888
- const isValid = await this.validatePropagatedTx(tx, source);
889
- const exists = isValid && (await this.mempools.txPool.hasTx(tx.getTxHash()));
909
+
910
+ const currentBlockNumber = await this.archiver.getBlockNumber();
911
+ const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
912
+
913
+ // Stage 1: fast validators (metadata, data, timestamps, double-spend, gas, phases, block header)
914
+ const firstStageValidators = await this.createFirstStageMessageValidators(currentBlockNumber, nextSlotTimestamp);
915
+ const firstStageOutcome = await this.runValidations(tx, firstStageValidators);
916
+ if (!firstStageOutcome.allPassed) {
917
+ const { name } = firstStageOutcome.failure;
918
+ let { severity } = firstStageOutcome.failure;
919
+
920
+ // Double spend validator has a special case handler. We perform more detailed examination
921
+ // as to how recently the nullifier was entered into the tree and if the transaction should
922
+ // have 'known' the nullifier existed. This determines the severity of the penalty applied to the peer.
923
+ if (name === 'doubleSpendValidator') {
924
+ const txBlockNumber = BlockNumber(currentBlockNumber + 1);
925
+ severity = await this.handleDoubleSpendFailure(tx, txBlockNumber);
926
+ }
927
+
928
+ this.peerManager.penalizePeer(source, severity);
929
+ return { result: TopicValidatorResult.Reject };
930
+ }
931
+
932
+ // Pool pre-check: see if the pool would accept this tx before doing expensive proof verification
933
+ const canAdd = await this.mempools.txPool.canAddPendingTx(tx);
934
+ if (canAdd === 'ignored') {
935
+ return { result: TopicValidatorResult.Ignore, obj: tx };
936
+ }
937
+
938
+ // Stage 2: expensive proof verification
939
+ const secondStageValidators = this.createSecondStageMessageValidators();
940
+ const secondStageOutcome = await this.runValidations(tx, secondStageValidators);
941
+ if (!secondStageOutcome.allPassed) {
942
+ const { severity } = secondStageOutcome.failure;
943
+ this.peerManager.penalizePeer(source, severity);
944
+ return { result: TopicValidatorResult.Reject };
945
+ }
946
+
947
+ // Pool add: persist the tx
948
+ const txHash = tx.getTxHash();
949
+ const addResult = await this.mempools.txPool.addPendingTxs([tx], { source: 'gossip' });
950
+
951
+ const wasAccepted = addResult.accepted.some(h => h.equals(txHash));
952
+ const wasIgnored = addResult.ignored.some(h => h.equals(txHash));
890
953
 
891
954
  this.logger.trace(`Validate propagated tx`, {
892
- isValid,
893
- exists,
955
+ wasAccepted,
956
+ wasIgnored,
894
957
  [Attributes.P2P_ID]: source.toString(),
895
958
  });
896
959
 
897
- if (!isValid) {
898
- return { result: TopicValidatorResult.Reject };
899
- } else if (exists) {
960
+ if (wasAccepted) {
961
+ return { result: TopicValidatorResult.Accept, obj: tx };
962
+ } else if (wasIgnored) {
900
963
  return { result: TopicValidatorResult.Ignore, obj: tx };
901
964
  } else {
902
- return { result: TopicValidatorResult.Accept, obj: tx };
965
+ return { result: TopicValidatorResult.Reject };
903
966
  }
904
967
  };
905
968
 
@@ -908,6 +971,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
908
971
  return;
909
972
  }
910
973
 
974
+ // Tx was accepted into pool and will be propagated - just log and record metrics
911
975
  const txHash = tx.getTxHash();
912
976
  const txHashString = txHash.toString();
913
977
  this.logger.verbose(`Received tx ${txHashString} from external peer ${source.toString()} via gossip`, {
@@ -915,13 +979,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
915
979
  txHash: txHashString,
916
980
  });
917
981
 
918
- if (this.config.dropTransactions && randomInt(1000) < this.config.dropTransactionsProbability * 1000) {
919
- this.logger.warn(`Intentionally dropping tx ${txHashString} (probability rule)`);
920
- return;
921
- }
922
-
923
982
  this.instrumentation.incrementTxReceived(1);
924
- await this.mempools.txPool.addTxs([tx]);
925
983
  }
926
984
 
927
985
  /**
@@ -933,47 +991,8 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
933
991
  msgId: string,
934
992
  source: PeerId,
935
993
  ): Promise<void> {
936
- const validationFunc: () => Promise<ReceivedMessageValidationResult<CheckpointAttestation>> = async () => {
937
- const attestation = CheckpointAttestation.fromBuffer(payloadData);
938
- const pool = this.mempools.attestationPool;
939
- const validationResult = await this.validateCheckpointAttestation(source, attestation);
940
- const isValid = validationResult.result === 'accept';
941
- const exists = isValid && (await pool.hasCheckpointAttestation(attestation));
942
-
943
- let canAdd = true;
944
- if (isValid && !exists) {
945
- const slot = attestation.payload.header.slotNumber;
946
- const { committee } = await this.epochCache.getCommittee(slot);
947
- const committeeSize = committee?.length ?? 0;
948
- canAdd = await pool.canAddCheckpointAttestation(attestation, committeeSize);
949
- }
950
-
951
- this.logger.trace(`Validate propagated checkpoint attestation`, {
952
- isValid,
953
- exists,
954
- canAdd,
955
- [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber.toString(),
956
- [Attributes.P2P_ID]: source.toString(),
957
- });
958
-
959
- if (validationResult.result === 'reject') {
960
- return { result: TopicValidatorResult.Reject };
961
- } else if (validationResult.result === 'ignore' || exists) {
962
- return { result: TopicValidatorResult.Ignore, obj: attestation };
963
- } else if (!canAdd) {
964
- this.logger.warn(`Dropping checkpoint attestation due to per-(slot, proposalId) attestation cap`, {
965
- slot: attestation.payload.header.slotNumber.toString(),
966
- archive: attestation.archive.toString(),
967
- source: source.toString(),
968
- });
969
- return { result: TopicValidatorResult.Ignore, obj: attestation };
970
- } else {
971
- return { result: TopicValidatorResult.Accept, obj: attestation };
972
- }
973
- };
974
-
975
994
  const { result, obj: attestation } = await this.validateReceivedMessage<CheckpointAttestation>(
976
- validationFunc,
995
+ () => this.validateAndStoreCheckpointAttestation(source, CheckpointAttestation.fromBuffer(payloadData)),
977
996
  msgId,
978
997
  source,
979
998
  TopicType.checkpoint_attestation,
@@ -983,8 +1002,8 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
983
1002
  return;
984
1003
  }
985
1004
 
986
- this.logger.debug(
987
- `Received checkpoint attestation for slot ${attestation.slotNumber} from external peer ${source.toString()}`,
1005
+ this.logger.verbose(
1006
+ `Received valid checkpoint attestation for slot ${attestation.slotNumber} from external peer ${source.toString()}`,
988
1007
  {
989
1008
  p2pMessageIdentifier: await attestation.p2pMessageLoggingIdentifier(),
990
1009
  slot: attestation.slotNumber,
@@ -992,60 +1011,167 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
992
1011
  source: source.toString(),
993
1012
  },
994
1013
  );
995
-
996
- await this.mempools.attestationPool.addCheckpointAttestations([attestation]);
997
1014
  }
998
1015
 
999
- private async processBlockFromPeer(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1000
- const validationFunc: () => Promise<ReceivedMessageValidationResult<BlockProposal>> = async () => {
1001
- const block = BlockProposal.fromBuffer(payloadData);
1002
- const validationResult = await this.validateBlockProposal(source, block);
1003
- const isValid = validationResult.result === 'accept';
1004
- const pool = this.mempools.attestationPool;
1005
-
1006
- const exists = isValid && (await pool.hasBlockProposal(block));
1007
- const canAdd = isValid && (await pool.canAddProposal(block));
1008
-
1009
- this.logger.trace(`Validate propagated block proposal`, {
1010
- isValid,
1011
- exists,
1012
- canAdd,
1013
- [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
1014
- [Attributes.P2P_ID]: source.toString(),
1016
+ /** Validates a checkpoint attestation and adds it to the pool. Penalizes the peer if validation fails. */
1017
+ @trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId, attestation) => ({
1018
+ [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber.toString(),
1019
+ }))
1020
+ protected async validateAndStoreCheckpointAttestation(
1021
+ peerId: PeerId,
1022
+ attestation: CheckpointAttestation,
1023
+ ): Promise<ReceivedMessageValidationResult<CheckpointAttestation>> {
1024
+ const validationResult = await this.checkpointAttestationValidator.validate(attestation);
1025
+
1026
+ if (validationResult.result === 'reject') {
1027
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1028
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1029
+ return { result: TopicValidatorResult.Reject };
1030
+ }
1031
+
1032
+ if (validationResult.result === 'ignore') {
1033
+ return { result: TopicValidatorResult.Ignore, obj: attestation };
1034
+ }
1035
+
1036
+ // Try to add the attestation: this handles existence check, cap check, and adding in one call
1037
+ // count is the number of attestations by this signer for this slot (for duplicate detection)
1038
+ const slot = attestation.payload.header.slotNumber;
1039
+ const { added, alreadyExists, count } =
1040
+ await this.mempools.attestationPool.tryAddCheckpointAttestation(attestation);
1041
+
1042
+ this.logger.trace(`Validate propagated checkpoint attestation`, {
1043
+ added,
1044
+ alreadyExists,
1045
+ count,
1046
+ [Attributes.SLOT_NUMBER]: slot.toString(),
1047
+ [Attributes.P2P_ID]: peerId.toString(),
1048
+ });
1049
+
1050
+ // Exact same attestation received, no need to re-broadcast
1051
+ if (alreadyExists) {
1052
+ return { result: TopicValidatorResult.Ignore, obj: attestation };
1053
+ }
1054
+
1055
+ // Could not add (cap reached for signer), no need to re-broadcast
1056
+ if (!added) {
1057
+ this.logger.warn(`Dropping checkpoint attestation due to cap`, {
1058
+ slot: slot.toString(),
1059
+ archive: attestation.archive.toString(),
1060
+ source: peerId.toString(),
1061
+ attester: attestation.getSender()?.toString(),
1062
+ count,
1015
1063
  });
1064
+ return { result: TopicValidatorResult.Ignore, obj: attestation };
1065
+ }
1016
1066
 
1017
- if (validationResult.result === 'reject') {
1018
- return { result: TopicValidatorResult.Reject };
1019
- } else if (validationResult.result === 'ignore' || exists) {
1020
- return { result: TopicValidatorResult.Ignore, obj: block };
1021
- } else if (!canAdd) {
1022
- this.peerManager.penalizePeer(source, PeerErrorSeverity.MidToleranceError);
1023
- this.logger.warn(`Penalizing peer for block proposal exceeding per-slot cap`, {
1024
- slot: block.slotNumber.toString(),
1025
- archive: block.archive.toString(),
1026
- source: source.toString(),
1067
+ // Check if this is a duplicate attestation (signer attested to a different proposal at the same slot)
1068
+ // count is the number of attestations by this signer for this slot
1069
+ if (count === 2) {
1070
+ const attester = attestation.getSender();
1071
+ if (attester) {
1072
+ this.logger.warn(`Detected duplicate attestation (equivocation) at slot ${slot}`, {
1073
+ slot: slot.toString(),
1074
+ archive: attestation.archive.toString(),
1075
+ source: peerId.toString(),
1076
+ attester: attester.toString(),
1027
1077
  });
1028
- return { result: TopicValidatorResult.Reject };
1029
- } else {
1030
- return { result: TopicValidatorResult.Accept, obj: block };
1078
+ this.duplicateAttestationCallback?.({ slot, attester });
1031
1079
  }
1032
- };
1080
+ }
1081
+
1082
+ // Attestation was added successfully - accept it so other nodes can also detect the equivocation
1083
+ return { result: TopicValidatorResult.Accept, obj: attestation };
1084
+ }
1033
1085
 
1034
- const { result, obj: block } = await this.validateReceivedMessage<BlockProposal>(
1035
- validationFunc,
1086
+ protected async processBlockFromPeer(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1087
+ const {
1088
+ result,
1089
+ obj: block,
1090
+ metadata: { isEquivocated } = {},
1091
+ } = await this.validateReceivedMessage<BlockProposal, { isEquivocated: boolean }>(
1092
+ () => this.validateAndStoreBlockProposal(source, BlockProposal.fromBuffer(payloadData)),
1036
1093
  msgId,
1037
1094
  source,
1038
1095
  TopicType.block_proposal,
1039
1096
  );
1040
1097
 
1041
- if (!result || !block) {
1098
+ // If not accepted or equivocated, return
1099
+ if (result !== TopicValidatorResult.Accept || !block || isEquivocated) {
1042
1100
  return;
1043
1101
  }
1044
1102
 
1045
1103
  await this.processValidBlockProposal(block, source);
1046
1104
  }
1047
1105
 
1048
- // REVIEW: callback pattern https://github.com/AztecProtocol/aztec-packages/issues/7963
1106
+ /** Validates a block proposal. Triggers a penalization to the peer that sent it if invalid. Adds to the mempool if valid. */
1107
+ @trackSpan('Libp2pService.validateAndStoreBlockProposal', (_peerId, block) => ({
1108
+ [Attributes.BLOCK_NUMBER]: block.blockNumber.toString(),
1109
+ [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
1110
+ }))
1111
+ protected async validateAndStoreBlockProposal(
1112
+ peerId: PeerId,
1113
+ block: BlockProposal,
1114
+ ): Promise<ReceivedMessageValidationResult<BlockProposal, { isEquivocated: boolean }>> {
1115
+ const validationResult = await this.blockProposalValidator.validate(block);
1116
+
1117
+ if (validationResult.result === 'reject') {
1118
+ this.logger.warn(`Penalizing peer ${peerId} for block proposal validation failure`);
1119
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1120
+ return { result: TopicValidatorResult.Reject };
1121
+ }
1122
+
1123
+ if (validationResult.result === 'ignore') {
1124
+ return { result: TopicValidatorResult.Ignore, obj: block };
1125
+ }
1126
+
1127
+ // Try to add the proposal: this handles existence check, cap check, and adding in one call
1128
+ const { added, alreadyExists, count } = await this.mempools.attestationPool.tryAddBlockProposal(block);
1129
+ const isEquivocated = count !== undefined && count > 1;
1130
+
1131
+ // Duplicate proposal received, no need to re-broadcast
1132
+ if (alreadyExists) {
1133
+ this.logger.debug(`Ignoring duplicate block proposal received`, {
1134
+ ...block.toBlockInfo(),
1135
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1136
+ proposer: block.getSender()?.toString(),
1137
+ source: peerId.toString(),
1138
+ });
1139
+ return { result: TopicValidatorResult.Ignore, obj: block, metadata: { isEquivocated } };
1140
+ }
1141
+
1142
+ // Too many blocks received for this slot and index, penalize peer and do not re-broadcast
1143
+ if (!added) {
1144
+ this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
1145
+ this.logger.warn(`Penalizing peer for block proposal exceeding per-position cap`, {
1146
+ ...block.toBlockInfo(),
1147
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1148
+ count,
1149
+ proposer: block.getSender()?.toString(),
1150
+ source: peerId.toString(),
1151
+ });
1152
+ return { result: TopicValidatorResult.Reject, metadata: { isEquivocated } };
1153
+ }
1154
+
1155
+ // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
1156
+ // and do re-broadcast it so other nodes in the network know to slash the proposer
1157
+ if (isEquivocated) {
1158
+ const proposer = block.getSender();
1159
+ this.logger.warn(`Detected duplicate block proposal (equivocation) at slot ${block.slotNumber}`, {
1160
+ ...block.toBlockInfo(),
1161
+ source: peerId.toString(),
1162
+ proposer: proposer?.toString(),
1163
+ });
1164
+ // Invoke the duplicate callback on the first duplicate spotted only
1165
+ if (proposer && count === 2) {
1166
+ this.duplicateProposalCallback?.({ slot: block.slotNumber, proposer, type: 'block' });
1167
+ }
1168
+ return { result: TopicValidatorResult.Accept, obj: block, metadata: { isEquivocated } };
1169
+ }
1170
+
1171
+ // Otherwise, we're good to go!
1172
+ return { result: TopicValidatorResult.Accept, obj: block };
1173
+ }
1174
+
1049
1175
  // REFACTOR(palla): This method should be moved to the p2p_client or to a separate component,
1050
1176
  // should not be here as it does not deal with p2p networking.
1051
1177
  @trackSpan('Libp2pService.processValidBlockProposal', async block => ({
@@ -1053,7 +1179,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1053
1179
  [Attributes.BLOCK_ARCHIVE]: block.archive.toString(),
1054
1180
  [Attributes.P2P_ID]: await block.p2pMessageLoggingIdentifier().then(i => i.toString()),
1055
1181
  }))
1056
- private async processValidBlockProposal(block: BlockProposal, sender: PeerId) {
1182
+ protected async processValidBlockProposal(block: BlockProposal, sender: PeerId) {
1057
1183
  const slot = block.slotNumber;
1058
1184
  this.logger.verbose(`Received block proposal for slot ${slot} from external peer ${sender.toString()}.`, {
1059
1185
  p2pMessageIdentifier: await block.p2pMessageLoggingIdentifier(),
@@ -1061,24 +1187,8 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1061
1187
  ...block.toBlockInfo(),
1062
1188
  });
1063
1189
 
1064
- // Attempt to add proposal
1065
- try {
1066
- await this.mempools.attestationPool.addBlockProposal(block);
1067
- } catch (err: unknown) {
1068
- // Drop proposals if we hit per-slot cap in the attestation pool; rethrow unknown errors
1069
- if (err instanceof ProposalSlotCapExceededError) {
1070
- this.logger.warn(`Dropping block proposal due to per-slot proposal cap`, {
1071
- slot: String(slot),
1072
- archive: block.archive.toString(),
1073
- error: (err as Error).message,
1074
- });
1075
- return;
1076
- }
1077
- throw err;
1078
- }
1079
-
1080
- // Mark the txs in this proposal as non-evictable
1081
- await this.mempools.txPool.markTxsAsNonEvictable(block.txHashes);
1190
+ // Mark the txs in this proposal as protected
1191
+ await this.mempools.txPool.protectTxs(block.txHashes, block.blockHeader);
1082
1192
 
1083
1193
  // Call the block received callback to validate the proposal.
1084
1194
  // Note: Validators do NOT attest to individual blocks, only to checkpoint proposals.
@@ -1092,67 +1202,145 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1092
1202
  * Handle a gossiped checkpoint proposal.
1093
1203
  * Validates and processes the checkpoint proposal, then triggers the callback for attestation.
1094
1204
  */
1095
- private async handleGossipedCheckpointProposal(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1096
- // TODO(palla/mbps): This pattern is repeated across multiple message handlers, consider abstracting it.
1097
- const validationFunc: () => Promise<ReceivedMessageValidationResult<CheckpointProposal>> = async () => {
1098
- const checkpoint = CheckpointProposal.fromBuffer(payloadData);
1099
- const validationResult = await this.validateCheckpointProposal(source, checkpoint);
1100
- const isValid = validationResult.result === 'accept';
1101
- const pool = this.mempools.attestationPool;
1102
-
1103
- const exists = isValid && (await pool.hasCheckpointProposal(checkpoint));
1104
- const canAdd = isValid && (await pool.canAddCheckpointProposal(checkpoint));
1105
-
1106
- this.logger.trace(`Validate propagated checkpoint proposal`, {
1107
- isValid,
1108
- exists,
1109
- canAdd,
1205
+ protected async handleGossipedCheckpointProposal(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1206
+ const {
1207
+ result,
1208
+ obj: checkpoint,
1209
+ metadata: { isEquivocated, processBlock } = {},
1210
+ } = await this.validateReceivedMessage<CheckpointProposal, { isEquivocated: boolean; processBlock: boolean }>(
1211
+ () => this.validateAndStoreCheckpointProposal(source, CheckpointProposal.fromBuffer(payloadData)),
1212
+ msgId,
1213
+ source,
1214
+ TopicType.checkpoint_proposal,
1215
+ );
1216
+
1217
+ // If the checkpoint contained a valid last block, we process it even if the checkpoint itself is to be rejected
1218
+ // TODO(palla/mbps): Is this ok? Should we be considering a block from a checkpoint that was equivocated?
1219
+ if (processBlock && checkpoint?.getBlockProposal()) {
1220
+ await this.processValidBlockProposal(checkpoint.getBlockProposal()!, source);
1221
+ }
1222
+
1223
+ if (result !== TopicValidatorResult.Accept || !checkpoint || isEquivocated) {
1224
+ return;
1225
+ }
1226
+
1227
+ await this.processValidCheckpointProposal(checkpoint.toCore(), source);
1228
+ }
1229
+
1230
+ /**
1231
+ * Validates a checkpoint proposal. Penalizes peer if validation fails. Adds the checkpoint and
1232
+ * its last block (if present) to the mempool if valid. Triggers equivocation detection on both.
1233
+ */
1234
+ @trackSpan('Libp2pService.validateAndStoreCheckpointProposal', (_peerId, checkpoint) => ({
1235
+ [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1236
+ }))
1237
+ protected async validateAndStoreCheckpointProposal(
1238
+ peerId: PeerId,
1239
+ checkpoint: CheckpointProposal,
1240
+ ): Promise<ReceivedMessageValidationResult<CheckpointProposal, { isEquivocated: boolean; processBlock: boolean }>> {
1241
+ const validationResult = await this.checkpointProposalValidator.validate(checkpoint);
1242
+
1243
+ if (validationResult.result === 'reject') {
1244
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
1245
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1246
+ return { result: TopicValidatorResult.Reject };
1247
+ }
1248
+
1249
+ if (validationResult.result === 'ignore') {
1250
+ return { result: TopicValidatorResult.Ignore, obj: checkpoint };
1251
+ }
1252
+
1253
+ // Extract and try to add the block proposal first if present
1254
+ const blockProposal = checkpoint.getBlockProposal();
1255
+ let processBlock = false;
1256
+ if (blockProposal) {
1257
+ this.logger.debug(`Validating block proposal from propagated checkpoint`, {
1110
1258
  [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1111
- [Attributes.P2P_ID]: source.toString(),
1259
+ [Attributes.P2P_ID]: peerId.toString(),
1112
1260
  });
1113
-
1114
- if (validationResult.result === 'reject') {
1115
- return { result: TopicValidatorResult.Reject };
1116
- } else if (validationResult.result === 'ignore' || exists) {
1117
- return { result: TopicValidatorResult.Ignore, obj: checkpoint };
1118
- } else if (!canAdd) {
1119
- this.peerManager.penalizePeer(source, PeerErrorSeverity.MidToleranceError);
1120
- this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
1121
- slot: checkpoint.slotNumber.toString(),
1122
- archive: checkpoint.archive.toString(),
1123
- source: source.toString(),
1261
+ const {
1262
+ result,
1263
+ obj,
1264
+ metadata: { isEquivocated } = {},
1265
+ } = await this.validateAndStoreBlockProposal(peerId, blockProposal);
1266
+ if (result === TopicValidatorResult.Reject || !obj || isEquivocated) {
1267
+ this.logger.debug(`Rejecting checkpoint due to invalid last block proposal`, {
1268
+ [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1269
+ [Attributes.P2P_ID]: peerId.toString(),
1270
+ isEquivocated,
1271
+ result,
1124
1272
  });
1125
1273
  return { result: TopicValidatorResult.Reject };
1126
- } else {
1127
- return { result: TopicValidatorResult.Accept, obj: checkpoint };
1274
+ } else if (result === TopicValidatorResult.Accept && obj && !isEquivocated) {
1275
+ processBlock = true;
1128
1276
  }
1129
- };
1277
+ }
1130
1278
 
1131
- const { result, obj: checkpoint } = await this.validateReceivedMessage<CheckpointProposal>(
1132
- validationFunc,
1133
- msgId,
1134
- source,
1135
- TopicType.checkpoint_proposal,
1136
- );
1279
+ // Try to add the checkpoint proposal core: this handles existence check, cap check, and adding in one call
1280
+ const checkpointCore = checkpoint.toCore();
1281
+ const tryAddResult = await this.mempools.attestationPool.tryAddCheckpointProposal(checkpointCore);
1282
+ const { added, alreadyExists, count } = tryAddResult;
1283
+ const isEquivocated = count !== undefined && count > 1;
1284
+
1285
+ // Duplicate proposal received, do not re-broadcast
1286
+ if (alreadyExists) {
1287
+ this.logger.debug(`Ignoring duplicate checkpoint proposal received`, {
1288
+ ...checkpoint.toCheckpointInfo(),
1289
+ source: peerId.toString(),
1290
+ });
1291
+ return {
1292
+ result: TopicValidatorResult.Ignore,
1293
+ obj: checkpoint,
1294
+ metadata: { isEquivocated, processBlock },
1295
+ };
1296
+ }
1137
1297
 
1138
- if (result !== TopicValidatorResult.Accept || !checkpoint) {
1139
- return;
1298
+ // Too many checkpoint proposals received for this slot, penalize peer and do not re-broadcast
1299
+ // Note: We still return the checkpoint obj so the lastBlock can be processed if valid
1300
+ if (!added) {
1301
+ this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
1302
+ this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
1303
+ ...checkpoint.toCheckpointInfo(),
1304
+ count,
1305
+ source: peerId.toString(),
1306
+ });
1307
+ return { result: TopicValidatorResult.Reject, obj: checkpoint, metadata: { isEquivocated, processBlock } };
1308
+ }
1309
+
1310
+ // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
1311
+ // and do re-broadcast it so other nodes in the network know to slash the proposer
1312
+ if (isEquivocated) {
1313
+ const proposer = checkpoint.getSender();
1314
+ this.logger.warn(`Detected duplicate checkpoint proposal (equivocation) at slot ${checkpoint.slotNumber}`, {
1315
+ ...checkpoint.toCheckpointInfo(),
1316
+ source: peerId.toString(),
1317
+ proposer: proposer?.toString(),
1318
+ });
1319
+ // Invoke the duplicate callback on the first duplicate spotted only
1320
+ if (proposer && count === 2) {
1321
+ this.duplicateProposalCallback?.({ slot: checkpoint.slotNumber, proposer, type: 'checkpoint' });
1322
+ }
1323
+ return {
1324
+ result: TopicValidatorResult.Accept,
1325
+ obj: checkpoint,
1326
+ metadata: { isEquivocated, processBlock },
1327
+ };
1140
1328
  }
1141
1329
 
1142
- await this.processValidCheckpointProposal(checkpoint, source);
1330
+ // Otherwise, we're good to go!
1331
+ return { result: TopicValidatorResult.Accept, obj: checkpoint, metadata: { processBlock, isEquivocated } };
1143
1332
  }
1144
1333
 
1145
1334
  /**
1146
1335
  * Process a validated checkpoint proposal.
1147
- * Extracts and processes the last block proposal (if present) first, then processes the checkpoint.
1148
- * The block callback is invoked before the checkpoint callback.
1336
+ * Note: The proposal was already added to the pool by tryAddCheckpointProposal in handleGossipedCheckpointProposal.
1149
1337
  */
1150
1338
  @trackSpan('Libp2pService.processValidCheckpointProposal', async checkpoint => ({
1151
1339
  [Attributes.SLOT_NUMBER]: checkpoint.slotNumber,
1152
1340
  [Attributes.BLOCK_ARCHIVE]: checkpoint.archive.toString(),
1153
1341
  [Attributes.P2P_ID]: await checkpoint.p2pMessageLoggingIdentifier().then(i => i.toString()),
1154
1342
  }))
1155
- private async processValidCheckpointProposal(checkpoint: CheckpointProposal, sender: PeerId) {
1343
+ protected async processValidCheckpointProposal(checkpoint: CheckpointProposalCore, sender: PeerId) {
1156
1344
  const slot = checkpoint.slotNumber;
1157
1345
  this.logger.verbose(`Received checkpoint proposal for slot ${slot} from external peer ${sender.toString()}.`, {
1158
1346
  p2pMessageIdentifier: await checkpoint.p2pMessageLoggingIdentifier(),
@@ -1161,37 +1349,12 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1161
1349
  source: sender.toString(),
1162
1350
  });
1163
1351
 
1164
- // Extract block proposal before adding to pool (pool stores them separately)
1165
- const blockProposal = checkpoint.getBlockProposal();
1166
-
1167
- // Add proposal to the pool (this extracts and stores block proposal separately)
1168
- await this.mempools.attestationPool.addCheckpointProposal(checkpoint);
1169
-
1170
- // Mark txs as non-evictable if present (from the last block)
1171
- if (checkpoint.txHashes.length > 0) {
1172
- await this.mempools.txPool.markTxsAsNonEvictable(checkpoint.txHashes);
1173
- }
1174
-
1175
- // If there was a last block proposal, invoke the block callback first for validation.
1176
- // Note: The block proposal is already stored in the pool by addCheckpointProposal.
1177
- if (blockProposal) {
1178
- const isValid = await this.blockReceivedCallback(blockProposal, sender);
1179
- if (!isValid) {
1180
- this.logger.warn(`Block proposal from checkpoint failed validation`, {
1181
- slot: slot.toString(),
1182
- archive: checkpoint.archive.toString(),
1183
- blockNumber: blockProposal.blockNumber.toString(),
1184
- });
1185
- return;
1186
- }
1187
- }
1188
-
1189
1352
  // Call the checkpoint received callback with the core version (without lastBlock)
1190
1353
  // to validate and potentially generate attestations
1191
- const attestations = await this.checkpointReceivedCallback(checkpoint.toCore(), sender);
1354
+ const attestations = await this.checkpointReceivedCallback(checkpoint, sender);
1192
1355
  if (attestations && attestations.length > 0) {
1193
1356
  // If the callback returned attestations, add them to the pool and propagate them
1194
- await this.mempools.attestationPool.addCheckpointAttestations(attestations);
1357
+ await this.mempools.attestationPool.addOwnCheckpointAttestations(attestations);
1195
1358
  for (const attestation of attestations) {
1196
1359
  await this.propagate(attestation);
1197
1360
  }
@@ -1220,7 +1383,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1220
1383
  @trackSpan('Libp2pService.validateRequestedBlockTxs', request => ({
1221
1384
  [Attributes.BLOCK_ARCHIVE]: request.archiveRoot.toString(),
1222
1385
  }))
1223
- private async validateRequestedBlockTxs(
1386
+ protected async validateRequestedBlockTxs(
1224
1387
  request: BlockTxsRequest,
1225
1388
  response: BlockTxsResponse,
1226
1389
  peerId: PeerId,
@@ -1350,7 +1513,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1350
1513
  @trackSpan('Libp2pService.validateRequestedBlock', (requestedBlockNumber, _responseBlock) => ({
1351
1514
  [Attributes.BLOCK_NUMBER]: requestedBlockNumber.toString(),
1352
1515
  }))
1353
- private async validateRequestedBlock(
1516
+ protected async validateRequestedBlock(
1354
1517
  requestedBlockNumber: Fr,
1355
1518
  responseBlock: L2Block,
1356
1519
  peerId: PeerId,
@@ -1383,7 +1546,12 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1383
1546
  }
1384
1547
  }
1385
1548
 
1386
- private async validateRequestedTx(tx: Tx, peerId: PeerId, txValidator: TxValidator, requested?: Set<`0x${string}`>) {
1549
+ protected async validateRequestedTx(
1550
+ tx: Tx,
1551
+ peerId: PeerId,
1552
+ txValidator: TxValidator,
1553
+ requested?: Set<`0x${string}`>,
1554
+ ) {
1387
1555
  const penalize = (severity: PeerErrorSeverity) => this.peerManager.penalizePeer(peerId, severity);
1388
1556
  if (requested && !requested.has(tx.getTxHash().toString())) {
1389
1557
  penalize(PeerErrorSeverity.MidToleranceError);
@@ -1397,44 +1565,13 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1397
1565
  }
1398
1566
  }
1399
1567
 
1400
- private createRequestedTxValidator(): TxValidator {
1401
- return createTxReqRespValidator(this.proofVerifier, {
1568
+ protected createRequestedTxValidator(): TxValidator {
1569
+ return createTxValidatorForReqResponseReceivedTxs(this.proofVerifier, {
1402
1570
  l1ChainId: this.config.l1ChainId,
1403
1571
  rollupVersion: this.config.rollupVersion,
1404
1572
  });
1405
1573
  }
1406
1574
 
1407
- @trackSpan('Libp2pService.validatePropagatedTx', tx => ({
1408
- [Attributes.TX_HASH]: tx.getTxHash().toString(),
1409
- }))
1410
- private async validatePropagatedTx(tx: Tx, peerId: PeerId): Promise<boolean> {
1411
- const currentBlockNumber = await this.archiver.getBlockNumber();
1412
-
1413
- // We accept transactions if they are not expired by the next slot (checked based on the IncludeByTimestamp field)
1414
- const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
1415
- const messageValidators = await this.createMessageValidators(currentBlockNumber, nextSlotTimestamp);
1416
-
1417
- for (const validator of messageValidators) {
1418
- const outcome = await this.runValidations(tx, validator);
1419
-
1420
- if (outcome.allPassed) {
1421
- continue;
1422
- }
1423
- const { name } = outcome.failure;
1424
- let { severity } = outcome.failure;
1425
-
1426
- // Double spend validator has a special case handler
1427
- if (name === 'doubleSpendValidator') {
1428
- const txBlockNumber = BlockNumber(currentBlockNumber + 1); // tx is expected to be in the next block
1429
- severity = await this.handleDoubleSpendFailure(tx, txBlockNumber);
1430
- }
1431
-
1432
- this.peerManager.penalizePeer(peerId, severity);
1433
- return false;
1434
- }
1435
- return true;
1436
- }
1437
-
1438
1575
  private async getGasFees(blockNumber: BlockNumber): Promise<GasFees> {
1439
1576
  if (blockNumber === this.feesCache?.blockNumber) {
1440
1577
  return this.feesCache.gasFees;
@@ -1462,60 +1599,53 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1462
1599
  };
1463
1600
  }
1464
1601
 
1465
- public async validate(txs: Tx[]): Promise<void> {
1466
- const currentBlockNumber = await this.archiver.getBlockNumber();
1467
-
1468
- // We accept transactions if they are not expired by the next slot (checked based on the IncludeByTimestamp field)
1469
- const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
1470
- const messageValidators = await this.createMessageValidators(currentBlockNumber, nextSlotTimestamp);
1602
+ public async validateTxsReceivedInBlockProposal(txs: Tx[]): Promise<void> {
1603
+ const validator = createTxValidatorForBlockProposalReceivedTxs(
1604
+ this.proofVerifier,
1605
+ { l1ChainId: this.config.l1ChainId, rollupVersion: this.config.rollupVersion },
1606
+ this.logger.getBindings(),
1607
+ );
1471
1608
 
1472
- await Promise.all(
1609
+ const results = await Promise.all(
1473
1610
  txs.map(async tx => {
1474
- for (const validator of messageValidators) {
1475
- const outcome = await this.runValidations(tx, validator);
1476
- if (!outcome.allPassed) {
1477
- throw new Error('Invalid tx detected', { cause: { outcome } });
1478
- }
1479
- }
1611
+ const result = await validator.validateTx(tx);
1612
+ return result.result !== 'invalid';
1480
1613
  }),
1481
1614
  );
1615
+ if (results.some(value => value === false)) {
1616
+ throw new Error('Invalid tx detected');
1617
+ }
1482
1618
  }
1483
1619
 
1484
- /**
1485
- * Create message validators for the given block number and timestamp.
1486
- *
1487
- * Each validator is a pair of a validator and a severity.
1488
- * If a validator fails, the peer is penalized with the severity of the validator.
1489
- *
1490
- * @param currentBlockNumber - The current synced block number.
1491
- * @param nextSlotTimestamp - The timestamp of the next slot (used to validate txs are not expired).
1492
- * @returns The message validators.
1493
- */
1494
- private async createMessageValidators(
1620
+ /** Creates the first stage (fast) validators for gossiped transactions. */
1621
+ protected async createFirstStageMessageValidators(
1495
1622
  currentBlockNumber: BlockNumber,
1496
1623
  nextSlotTimestamp: UInt64,
1497
- ): Promise<Record<string, MessageValidator>[]> {
1624
+ ): Promise<Record<string, TransactionValidator>> {
1498
1625
  const gasFees = await this.getGasFees(currentBlockNumber);
1499
1626
  const allowedInSetup = this.config.txPublicSetupAllowList ?? (await getDefaultAllowedSetupFunctions());
1627
+ const blockNumber = BlockNumber(currentBlockNumber + 1);
1500
1628
 
1501
- const blockNumberInWhichTheTxIsConsideredToBeIncluded = BlockNumber(currentBlockNumber + 1);
1502
-
1503
- return createTxMessageValidators(
1629
+ return createFirstStageTxValidationsForGossipedTransactions(
1504
1630
  nextSlotTimestamp,
1505
- blockNumberInWhichTheTxIsConsideredToBeIncluded,
1631
+ blockNumber,
1506
1632
  this.worldStateSynchronizer,
1507
1633
  gasFees,
1508
1634
  this.config.l1ChainId,
1509
1635
  this.config.rollupVersion,
1510
1636
  protocolContractsHash,
1511
1637
  this.archiver,
1512
- this.proofVerifier,
1513
1638
  !this.config.disableTransactions,
1514
1639
  allowedInSetup,
1515
1640
  this.logger.getBindings(),
1516
1641
  );
1517
1642
  }
1518
1643
 
1644
+ /** Creates the second stage (expensive proof verification) validators for gossiped transactions. */
1645
+ protected createSecondStageMessageValidators(): Record<string, TransactionValidator> {
1646
+ return createSecondStageTxValidationsForGossipedTransactions(this.proofVerifier, this.logger.getBindings());
1647
+ }
1648
+
1519
1649
  /**
1520
1650
  * Run validations on a tx.
1521
1651
  * @param tx - The tx to validate.
@@ -1524,7 +1654,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1524
1654
  */
1525
1655
  private async runValidations(
1526
1656
  tx: Tx,
1527
- messageValidators: Record<string, MessageValidator>,
1657
+ messageValidators: Record<string, TransactionValidator>,
1528
1658
  ): Promise<ValidationOutcome> {
1529
1659
  const validationPromises = Object.entries(messageValidators).map(async ([name, { validator, severity }]) => {
1530
1660
  const { result } = await validator.validateTx(tx);
@@ -1605,50 +1735,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1605
1735
  const result = await this.checkpointAttestationValidator.validate(attestation);
1606
1736
 
1607
1737
  if (result.result === 'reject') {
1608
- this.logger.debug(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1609
- this.peerManager.penalizePeer(peerId, result.severity);
1610
- }
1611
-
1612
- return result;
1613
- }
1614
-
1615
- /**
1616
- * Validate a block proposal.
1617
- *
1618
- * @param block - The block proposal to validate.
1619
- * @returns True if the block proposal is valid, false otherwise.
1620
- */
1621
- @trackSpan('Libp2pService.validateBlockProposal', (_peerId, block) => ({
1622
- [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
1623
- }))
1624
- public async validateBlockProposal(peerId: PeerId, block: BlockProposal): Promise<P2PValidationResult> {
1625
- const result = await this.blockProposalValidator.validate(block);
1626
-
1627
- if (result.result === 'reject') {
1628
- this.logger.debug(`Penalizing peer ${peerId} for block proposal validation failure`);
1629
- this.peerManager.penalizePeer(peerId, result.severity);
1630
- }
1631
-
1632
- return result;
1633
- }
1634
-
1635
- /**
1636
- * Validate a checkpoint proposal.
1637
- *
1638
- * @param checkpoint - The checkpoint proposal to validate.
1639
- * @returns True if the checkpoint proposal is valid, false otherwise.
1640
- */
1641
- @trackSpan('Libp2pService.validateCheckpointProposal', (_peerId, checkpoint) => ({
1642
- [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1643
- }))
1644
- public async validateCheckpointProposal(
1645
- peerId: PeerId,
1646
- checkpoint: CheckpointProposal,
1647
- ): Promise<P2PValidationResult> {
1648
- const result = await this.checkpointProposalValidator.validate(checkpoint);
1649
-
1650
- if (result.result === 'reject') {
1651
- this.logger.debug(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
1738
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1652
1739
  this.peerManager.penalizePeer(peerId, result.severity);
1653
1740
  }
1654
1741