@aztec/p2p 0.0.1-commit.43597cc1 → 0.0.1-commit.4ad48494d

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (185) hide show
  1. package/dest/client/factory.d.ts +3 -3
  2. package/dest/client/factory.d.ts.map +1 -1
  3. package/dest/client/factory.js +42 -8
  4. package/dest/client/interface.d.ts +30 -15
  5. package/dest/client/interface.d.ts.map +1 -1
  6. package/dest/client/p2p_client.d.ts +33 -35
  7. package/dest/client/p2p_client.d.ts.map +1 -1
  8. package/dest/client/p2p_client.js +107 -137
  9. package/dest/config.d.ts +19 -2
  10. package/dest/config.d.ts.map +1 -1
  11. package/dest/config.js +14 -0
  12. package/dest/index.d.ts +2 -1
  13. package/dest/index.d.ts.map +1 -1
  14. package/dest/index.js +1 -0
  15. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts +21 -12
  16. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts.map +1 -1
  17. package/dest/mem_pools/attestation_pool/attestation_pool.js +67 -37
  18. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.d.ts +1 -1
  19. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.d.ts.map +1 -1
  20. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.js +53 -53
  21. package/dest/mem_pools/attestation_pool/index.d.ts +2 -2
  22. package/dest/mem_pools/attestation_pool/index.d.ts.map +1 -1
  23. package/dest/mem_pools/attestation_pool/index.js +1 -1
  24. package/dest/mem_pools/index.d.ts +2 -1
  25. package/dest/mem_pools/index.d.ts.map +1 -1
  26. package/dest/mem_pools/interface.d.ts +3 -3
  27. package/dest/mem_pools/interface.d.ts.map +1 -1
  28. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts +102 -0
  29. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts.map +1 -0
  30. package/dest/mem_pools/tx_pool_v2/deleted_pool.js +242 -0
  31. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.d.ts +1 -1
  32. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.d.ts.map +1 -1
  33. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.js +3 -0
  34. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.js +3 -1
  35. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.js +3 -1
  36. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts +1 -1
  37. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts.map +1 -1
  38. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.js +3 -1
  39. package/dest/mem_pools/tx_pool_v2/index.d.ts +2 -1
  40. package/dest/mem_pools/tx_pool_v2/index.d.ts.map +1 -1
  41. package/dest/mem_pools/tx_pool_v2/index.js +1 -0
  42. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts +7 -3
  43. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts.map +1 -1
  44. package/dest/mem_pools/tx_pool_v2/interfaces.js +2 -1
  45. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts +27 -3
  46. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts.map +1 -1
  47. package/dest/mem_pools/tx_pool_v2/tx_metadata.js +37 -4
  48. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts +8 -2
  49. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts.map +1 -1
  50. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.js +15 -2
  51. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts +4 -2
  52. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts.map +1 -1
  53. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.js +6 -2
  54. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts +4 -2
  55. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts.map +1 -1
  56. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.js +110 -78
  57. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts +3 -3
  58. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts.map +1 -1
  59. package/dest/msg_validators/tx_validator/block_header_validator.d.ts +16 -3
  60. package/dest/msg_validators/tx_validator/block_header_validator.d.ts.map +1 -1
  61. package/dest/msg_validators/tx_validator/block_header_validator.js +1 -1
  62. package/dest/msg_validators/tx_validator/double_spend_validator.d.ts +13 -3
  63. package/dest/msg_validators/tx_validator/double_spend_validator.d.ts.map +1 -1
  64. package/dest/msg_validators/tx_validator/double_spend_validator.js +4 -4
  65. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts +20 -4
  66. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts.map +1 -1
  67. package/dest/msg_validators/tx_validator/timestamp_validator.js +2 -2
  68. package/dest/services/dummy_service.d.ts +6 -2
  69. package/dest/services/dummy_service.d.ts.map +1 -1
  70. package/dest/services/dummy_service.js +3 -0
  71. package/dest/services/encoding.d.ts +2 -2
  72. package/dest/services/encoding.d.ts.map +1 -1
  73. package/dest/services/encoding.js +2 -2
  74. package/dest/services/libp2p/libp2p_service.d.ts +11 -3
  75. package/dest/services/libp2p/libp2p_service.d.ts.map +1 -1
  76. package/dest/services/libp2p/libp2p_service.js +71 -35
  77. package/dest/services/reqresp/interface.d.ts +10 -1
  78. package/dest/services/reqresp/interface.d.ts.map +1 -1
  79. package/dest/services/reqresp/interface.js +15 -1
  80. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.d.ts +3 -3
  81. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.d.ts.map +1 -1
  82. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.d.ts +7 -1
  83. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.d.ts.map +1 -1
  84. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.js +15 -0
  85. package/dest/services/reqresp/protocols/tx.d.ts +7 -1
  86. package/dest/services/reqresp/protocols/tx.d.ts.map +1 -1
  87. package/dest/services/reqresp/protocols/tx.js +20 -0
  88. package/dest/services/reqresp/reqresp.d.ts +1 -1
  89. package/dest/services/reqresp/reqresp.d.ts.map +1 -1
  90. package/dest/services/reqresp/reqresp.js +11 -4
  91. package/dest/services/service.d.ts +18 -1
  92. package/dest/services/service.d.ts.map +1 -1
  93. package/dest/services/tx_collection/config.d.ts +19 -1
  94. package/dest/services/tx_collection/config.d.ts.map +1 -1
  95. package/dest/services/tx_collection/config.js +46 -0
  96. package/dest/services/tx_collection/fast_tx_collection.d.ts +3 -1
  97. package/dest/services/tx_collection/fast_tx_collection.d.ts.map +1 -1
  98. package/dest/services/tx_collection/fast_tx_collection.js +17 -3
  99. package/dest/services/tx_collection/file_store_tx_collection.d.ts +53 -0
  100. package/dest/services/tx_collection/file_store_tx_collection.d.ts.map +1 -0
  101. package/dest/services/tx_collection/file_store_tx_collection.js +165 -0
  102. package/dest/services/tx_collection/file_store_tx_source.d.ts +28 -0
  103. package/dest/services/tx_collection/file_store_tx_source.d.ts.map +1 -0
  104. package/dest/services/tx_collection/file_store_tx_source.js +59 -0
  105. package/dest/services/tx_collection/index.d.ts +2 -1
  106. package/dest/services/tx_collection/index.d.ts.map +1 -1
  107. package/dest/services/tx_collection/index.js +1 -0
  108. package/dest/services/tx_collection/slow_tx_collection.d.ts +6 -2
  109. package/dest/services/tx_collection/slow_tx_collection.d.ts.map +1 -1
  110. package/dest/services/tx_collection/slow_tx_collection.js +55 -23
  111. package/dest/services/tx_collection/tx_collection.d.ts +19 -7
  112. package/dest/services/tx_collection/tx_collection.d.ts.map +1 -1
  113. package/dest/services/tx_collection/tx_collection.js +75 -3
  114. package/dest/services/tx_collection/tx_collection_sink.d.ts +15 -6
  115. package/dest/services/tx_collection/tx_collection_sink.d.ts.map +1 -1
  116. package/dest/services/tx_collection/tx_collection_sink.js +13 -7
  117. package/dest/services/tx_file_store/config.d.ts +1 -3
  118. package/dest/services/tx_file_store/config.d.ts.map +1 -1
  119. package/dest/services/tx_file_store/config.js +0 -4
  120. package/dest/services/tx_file_store/tx_file_store.d.ts +4 -3
  121. package/dest/services/tx_file_store/tx_file_store.d.ts.map +1 -1
  122. package/dest/services/tx_file_store/tx_file_store.js +8 -5
  123. package/dest/services/tx_provider.d.ts +3 -3
  124. package/dest/services/tx_provider.d.ts.map +1 -1
  125. package/dest/services/tx_provider.js +5 -4
  126. package/dest/test-helpers/make-test-p2p-clients.d.ts +3 -3
  127. package/dest/test-helpers/make-test-p2p-clients.d.ts.map +1 -1
  128. package/dest/test-helpers/mock-pubsub.d.ts +27 -1
  129. package/dest/test-helpers/mock-pubsub.d.ts.map +1 -1
  130. package/dest/test-helpers/mock-pubsub.js +97 -2
  131. package/dest/test-helpers/testbench-utils.d.ts +32 -24
  132. package/dest/test-helpers/testbench-utils.d.ts.map +1 -1
  133. package/dest/test-helpers/testbench-utils.js +93 -35
  134. package/dest/testbench/p2p_client_testbench_worker.js +1 -1
  135. package/package.json +14 -14
  136. package/src/client/factory.ts +78 -9
  137. package/src/client/interface.ts +32 -13
  138. package/src/client/p2p_client.ts +135 -157
  139. package/src/config.ts +24 -0
  140. package/src/index.ts +1 -0
  141. package/src/mem_pools/attestation_pool/attestation_pool.ts +95 -44
  142. package/src/mem_pools/attestation_pool/attestation_pool_test_suite.ts +57 -53
  143. package/src/mem_pools/attestation_pool/index.ts +3 -3
  144. package/src/mem_pools/index.ts +3 -0
  145. package/src/mem_pools/interface.ts +2 -2
  146. package/src/mem_pools/tx_pool_v2/README.md +75 -9
  147. package/src/mem_pools/tx_pool_v2/deleted_pool.ts +310 -0
  148. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.ts +3 -0
  149. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.ts +1 -1
  150. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.ts +1 -1
  151. package/src/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.ts +3 -1
  152. package/src/mem_pools/tx_pool_v2/index.ts +1 -0
  153. package/src/mem_pools/tx_pool_v2/interfaces.ts +8 -2
  154. package/src/mem_pools/tx_pool_v2/tx_metadata.ts +55 -5
  155. package/src/mem_pools/tx_pool_v2/tx_pool_indices.ts +18 -2
  156. package/src/mem_pools/tx_pool_v2/tx_pool_v2.ts +7 -1
  157. package/src/mem_pools/tx_pool_v2/tx_pool_v2_impl.ts +122 -80
  158. package/src/msg_validators/tx_validator/aggregate_tx_validator.ts +2 -2
  159. package/src/msg_validators/tx_validator/block_header_validator.ts +15 -3
  160. package/src/msg_validators/tx_validator/double_spend_validator.ts +11 -6
  161. package/src/msg_validators/tx_validator/timestamp_validator.ts +19 -14
  162. package/src/services/dummy_service.ts +6 -0
  163. package/src/services/encoding.ts +2 -2
  164. package/src/services/libp2p/libp2p_service.ts +70 -37
  165. package/src/services/reqresp/interface.ts +26 -1
  166. package/src/services/reqresp/protocols/block_txs/block_txs_handler.ts +2 -2
  167. package/src/services/reqresp/protocols/block_txs/block_txs_reqresp.ts +17 -0
  168. package/src/services/reqresp/protocols/tx.ts +22 -0
  169. package/src/services/reqresp/reqresp.ts +13 -3
  170. package/src/services/service.ts +20 -0
  171. package/src/services/tx_collection/config.ts +68 -0
  172. package/src/services/tx_collection/fast_tx_collection.ts +14 -2
  173. package/src/services/tx_collection/file_store_tx_collection.ts +198 -0
  174. package/src/services/tx_collection/file_store_tx_source.ts +73 -0
  175. package/src/services/tx_collection/index.ts +1 -0
  176. package/src/services/tx_collection/slow_tx_collection.ts +64 -30
  177. package/src/services/tx_collection/tx_collection.ts +109 -13
  178. package/src/services/tx_collection/tx_collection_sink.ts +17 -7
  179. package/src/services/tx_file_store/config.ts +0 -6
  180. package/src/services/tx_file_store/tx_file_store.ts +9 -7
  181. package/src/services/tx_provider.ts +8 -7
  182. package/src/test-helpers/make-test-p2p-clients.ts +3 -3
  183. package/src/test-helpers/mock-pubsub.ts +133 -3
  184. package/src/test-helpers/testbench-utils.ts +108 -40
  185. package/src/testbench/p2p_client_testbench_worker.ts +1 -1
@@ -1,12 +1,15 @@
1
1
  import { GENESIS_BLOCK_HEADER_HASH } from '@aztec/constants';
2
+ import type { EpochCacheInterface } from '@aztec/epoch-cache';
2
3
  import { BlockNumber, SlotNumber } from '@aztec/foundation/branded-types';
3
4
  import { createLogger } from '@aztec/foundation/log';
5
+ import { RunningPromise } from '@aztec/foundation/promise';
4
6
  import { DateProvider } from '@aztec/foundation/timer';
5
7
  import type { AztecAsyncKVStore, AztecAsyncSingleton } from '@aztec/kv-store';
6
8
  import { L2TipsKVStore } from '@aztec/kv-store/stores';
7
9
  import {
8
10
  type EthAddress,
9
11
  type L2Block,
12
+ type L2BlockId,
10
13
  type L2BlockSource,
11
14
  L2BlockStream,
12
15
  type L2BlockStreamEvent,
@@ -22,7 +25,7 @@ import {
22
25
  type CheckpointProposal,
23
26
  type P2PClientType,
24
27
  } from '@aztec/stdlib/p2p';
25
- import type { Tx, TxHash } from '@aztec/stdlib/tx';
28
+ import type { BlockHeader, Tx, TxHash } from '@aztec/stdlib/tx';
26
29
  import { Attributes, type TelemetryClient, WithTracer, getTelemetryClient, trackSpan } from '@aztec/telemetry-client';
27
30
 
28
31
  import type { PeerId } from '@libp2p/interface';
@@ -31,7 +34,7 @@ import type { ENR } from '@nethermindeth/enr';
31
34
  import { type P2PConfig, getP2PDefaultConfig } from '../config.js';
32
35
  import type { AttestationPoolApi } from '../mem_pools/attestation_pool/attestation_pool.js';
33
36
  import type { MemPools } from '../mem_pools/interface.js';
34
- import type { TxPool } from '../mem_pools/tx_pool/index.js';
37
+ import type { TxPoolV2 } from '../mem_pools/tx_pool_v2/interfaces.js';
35
38
  import type { AuthRequest, StatusMessage } from '../services/index.js';
36
39
  import {
37
40
  ReqRespSubProtocol,
@@ -40,6 +43,7 @@ import {
40
43
  } from '../services/reqresp/interface.js';
41
44
  import { chunkTxHashesRequest } from '../services/reqresp/protocols/tx.js';
42
45
  import type {
46
+ DuplicateAttestationInfo,
43
47
  DuplicateProposalInfo,
44
48
  P2PBlockReceivedCallback,
45
49
  P2PCheckpointReceivedCallback,
@@ -70,7 +74,7 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
70
74
  private l2Tips: L2TipsStore;
71
75
  private synchedLatestSlot: AztecAsyncSingleton<bigint>;
72
76
 
73
- private txPool: TxPool;
77
+ private txPool: TxPoolV2;
74
78
  private attestationPool: AttestationPoolApi;
75
79
 
76
80
  private config: P2PConfig;
@@ -81,14 +85,12 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
81
85
 
82
86
  private validatorAddresses: EthAddress[] = [];
83
87
 
84
- /**
85
- * In-memory P2P client constructor.
86
- * @param store - The client's instance of the KV store.
87
- * @param l2BlockSource - P2P client's source for fetching existing blocks.
88
- * @param txPool - The client's instance of a transaction pool. Defaults to in-memory implementation.
89
- * @param p2pService - The concrete instance of p2p networking to use.
90
- * @param log - A logger.
91
- */
88
+ /** Tracks the last slot for which we called prepareForSlot */
89
+ private lastSlotProcessed: SlotNumber = SlotNumber.ZERO;
90
+
91
+ /** Polls for slot changes and calls prepareForSlot on the tx pool */
92
+ private slotMonitor: RunningPromise | undefined;
93
+
92
94
  constructor(
93
95
  _clientType: T,
94
96
  private store: AztecAsyncKVStore,
@@ -97,6 +99,7 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
97
99
  private p2pService: P2PService,
98
100
  private txCollection: TxCollection,
99
101
  private txFileStore: TxFileStore | undefined,
102
+ private epochCache: EpochCacheInterface,
100
103
  config: Partial<P2PConfig> = {},
101
104
  private _dateProvider: DateProvider = new DateProvider(),
102
105
  private telemetry: TelemetryClient = getTelemetryClient(),
@@ -166,10 +169,9 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
166
169
  return this.l2Tips.getL2BlockHash(number);
167
170
  }
168
171
 
169
- public updateP2PConfig(config: Partial<P2PConfig>): Promise<void> {
170
- this.txPool.updateConfig(config);
172
+ public async updateP2PConfig(config: Partial<P2PConfig>): Promise<void> {
173
+ await this.txPool.updateConfig(config);
171
174
  this.p2pService.updateConfig(config);
172
- return Promise.resolve();
173
175
  }
174
176
 
175
177
  public getL2Tips(): Promise<L2Tips> {
@@ -198,7 +200,7 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
198
200
  break;
199
201
  case 'chain-pruned':
200
202
  this.txCollection.stopCollectingForBlocksAfter(event.block.number);
201
- await this.handlePruneL2Blocks(event.block.number);
203
+ await this.handlePruneL2Blocks(event.block);
202
204
  break;
203
205
  case 'chain-checkpointed':
204
206
  break;
@@ -214,7 +216,6 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
214
216
  }
215
217
 
216
218
  #assertIsReady() {
217
- // this.log.info('Checking if p2p client is ready, current state: ', this.currentState);
218
219
  if (!this.isReady()) {
219
220
  throw new Error('P2P client not ready');
220
221
  }
@@ -232,6 +233,9 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
232
233
  return this.syncPromise;
233
234
  }
234
235
 
236
+ // Start the tx pool first, as it needs to hydrate state from persistence
237
+ await this.txPool.start();
238
+
235
239
  // get the current latest block numbers
236
240
  const latestBlockNumbers = await this.l2BlockSource.getL2Tips();
237
241
  this.latestBlockNumberAtStart = latestBlockNumbers.proposed.number;
@@ -282,6 +286,15 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
282
286
  this.blockStream!.start();
283
287
  await this.txCollection.start();
284
288
  this.txFileStore?.start();
289
+
290
+ // Start slot monitor to call prepareForSlot when the slot changes
291
+ this.slotMonitor = new RunningPromise(
292
+ () => this.maybeCallPrepareForSlot(),
293
+ this.log,
294
+ this.config.slotCheckIntervalMS,
295
+ );
296
+ this.slotMonitor.start();
297
+
285
298
  return this.syncPromise;
286
299
  }
287
300
 
@@ -312,6 +325,8 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
312
325
  */
313
326
  public async stop() {
314
327
  this.log.debug('Stopping p2p client...');
328
+ await this.slotMonitor?.stop();
329
+ this.log.debug('Stopped slot monitor');
315
330
  await tryStop(this.txCollection);
316
331
  this.log.debug('Stopped tx collection service');
317
332
  await this.txFileStore?.stop();
@@ -320,6 +335,8 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
320
335
  this.log.debug('Stopped p2p service');
321
336
  await this.blockStream?.stop();
322
337
  this.log.debug('Stopped block downloader');
338
+ await this.txPool.stop();
339
+ this.log.debug('Stopped tx pool');
323
340
  await this.runningPromise;
324
341
  this.setCurrentState(P2PClientState.STOPPED);
325
342
  this.log.info('P2P client stopped');
@@ -339,9 +356,17 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
339
356
  public async broadcastProposal(proposal: BlockProposal): Promise<void> {
340
357
  this.log.verbose(`Broadcasting proposal for slot ${proposal.slotNumber} to peers`);
341
358
  // Store our own proposal so we can respond to req/resp requests for it
342
- const { totalForPosition } = await this.attestationPool.tryAddBlockProposal(proposal);
343
- if (totalForPosition > 1) {
344
- throw new Error(`Attempted to broadcast a duplicate block proposal for slot ${proposal.slotNumber}`);
359
+ const { count } = await this.attestationPool.tryAddBlockProposal(proposal);
360
+ if (count > 1) {
361
+ if (this.config.broadcastEquivocatedProposals) {
362
+ this.log.warn(`Broadcasting equivocated block proposal for slot ${proposal.slotNumber}`, {
363
+ slot: proposal.slotNumber,
364
+ archive: proposal.archive.toString(),
365
+ count,
366
+ });
367
+ } else {
368
+ throw new Error(`Attempted to broadcast a duplicate block proposal for slot ${proposal.slotNumber}`);
369
+ }
345
370
  }
346
371
  return this.p2pService.propagate(proposal);
347
372
  }
@@ -379,6 +404,10 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
379
404
  return this.attestationPool.addOwnCheckpointAttestations(attestations);
380
405
  }
381
406
 
407
+ public hasBlockProposalsForSlot(slot: SlotNumber): Promise<boolean> {
408
+ return this.attestationPool.hasBlockProposalsForSlot(slot);
409
+ }
410
+
382
411
  // REVIEW: https://github.com/AztecProtocol/aztec-packages/issues/7963
383
412
  // ^ This pattern is not my favorite (md)
384
413
  public registerBlockProposalHandler(handler: P2PBlockReceivedCallback): void {
@@ -393,10 +422,14 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
393
422
  this.p2pService.registerDuplicateProposalCallback(callback);
394
423
  }
395
424
 
425
+ public registerDuplicateAttestationCallback(callback: (info: DuplicateAttestationInfo) => void): void {
426
+ this.p2pService.registerDuplicateAttestationCallback(callback);
427
+ }
428
+
396
429
  /**
397
430
  * Uses the batched Request Response protocol to request a set of transactions from the network.
398
431
  */
399
- public async requestTxsByHash(txHashes: TxHash[], pinnedPeerId: PeerId | undefined): Promise<Tx[]> {
432
+ private async requestTxsByHash(txHashes: TxHash[], pinnedPeerId: PeerId | undefined): Promise<Tx[]> {
400
433
  const timeoutMs = 8000; // Longer timeout for now
401
434
  const maxRetryAttempts = 10; // Keep retrying within the timeout
402
435
  const requests = chunkTxHashesRequest(txHashes);
@@ -413,7 +446,7 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
413
446
 
414
447
  const txs = txBatches.flat();
415
448
  if (txs.length > 0) {
416
- await this.txPool.addTxs(txs);
449
+ await this.txPool.addPendingTxs(txs);
417
450
  }
418
451
 
419
452
  const txHashesStr = txHashes.map(tx => tx.toString()).join(', ');
@@ -423,79 +456,49 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
423
456
  return txs;
424
457
  }
425
458
 
426
- public getPendingTxs(limit?: number, after?: TxHash): Promise<Tx[]> {
427
- return this.getTxs('pending', limit, after);
428
- }
429
-
430
- public getPendingTxCount(): Promise<number> {
431
- return this.txPool.getPendingTxCount();
432
- }
433
-
434
- public async *iteratePendingTxs(): AsyncIterableIterator<Tx> {
435
- for (const txHash of await this.txPool.getPendingTxHashes()) {
436
- const tx = await this.txPool.getTxByHash(txHash);
437
- if (tx) {
438
- yield tx;
439
- }
440
- }
441
- }
442
-
443
- /**
444
- * Returns all transactions in the transaction pool.
445
- * @param filter - The type of txs to return
446
- * @param limit - How many txs to return
447
- * @param after - If paginating, the last known tx hash. Will return txs after this hash
448
- * @returns An array of Txs.
449
- */
450
- public async getTxs(filter: 'all' | 'pending' | 'mined', limit?: number, after?: TxHash): Promise<Tx[]> {
459
+ public async getPendingTxs(limit?: number, after?: TxHash): Promise<Tx[]> {
451
460
  if (limit !== undefined && limit <= 0) {
452
461
  throw new TypeError('limit must be greater than 0');
453
462
  }
454
463
 
455
- let txs: Tx[] | undefined = undefined;
456
- let txHashes: TxHash[];
457
-
458
- if (filter === 'all') {
459
- txs = await this.txPool.getAllTxs();
460
- txHashes = await Promise.all(txs.map(tx => tx.getTxHash()));
461
- } else if (filter === 'mined') {
462
- const minedTxHashes = await this.txPool.getMinedTxHashes();
463
- txHashes = minedTxHashes.map(([txHash]) => txHash);
464
- } else if (filter === 'pending') {
465
- txHashes = await this.txPool.getPendingTxHashes();
466
- } else {
467
- const _: never = filter;
468
- throw new Error(`Unknown filter ${filter}`);
469
- }
464
+ let txHashes = await this.txPool.getPendingTxHashes();
470
465
 
471
466
  let startIndex = 0;
472
- let endIndex: number | undefined = undefined;
473
-
474
467
  if (after) {
475
468
  startIndex = txHashes.findIndex(txHash => after.equals(txHash));
476
-
477
- // if we can't find the last tx in our set then return an empty array as pagination is no longer valid.
478
469
  if (startIndex === -1) {
479
470
  return [];
480
471
  }
481
-
482
- // increment by one because we don't want to return the same tx again
483
472
  startIndex++;
484
473
  }
485
474
 
486
- if (limit !== undefined) {
487
- endIndex = startIndex + limit;
488
- }
489
-
475
+ const endIndex = limit !== undefined ? startIndex + limit : undefined;
490
476
  txHashes = txHashes.slice(startIndex, endIndex);
491
- if (txs) {
492
- txs = txs.slice(startIndex, endIndex);
493
- } else {
494
- const maybeTxs = await Promise.all(txHashes.map(txHash => this.txPool.getTxByHash(txHash)));
495
- txs = maybeTxs.filter((tx): tx is Tx => !!tx);
477
+
478
+ const maybeTxs = await Promise.all(txHashes.map(txHash => this.txPool.getTxByHash(txHash)));
479
+ return maybeTxs.filter((tx): tx is Tx => !!tx);
480
+ }
481
+
482
+ public getPendingTxCount(): Promise<number> {
483
+ return this.txPool.getPendingTxCount();
484
+ }
485
+
486
+ public async *iteratePendingTxs(): AsyncIterableIterator<Tx> {
487
+ for (const txHash of await this.txPool.getPendingTxHashes()) {
488
+ const tx = await this.txPool.getTxByHash(txHash);
489
+ if (tx) {
490
+ yield tx;
491
+ }
496
492
  }
493
+ }
497
494
 
498
- return txs;
495
+ public async *iterateEligiblePendingTxs(): AsyncIterableIterator<Tx> {
496
+ for (const txHash of await this.txPool.getEligiblePendingTxHashes()) {
497
+ const tx = await this.txPool.getTxByHash(txHash);
498
+ if (tx) {
499
+ yield tx;
500
+ }
501
+ }
499
502
  }
500
503
 
501
504
  /**
@@ -573,15 +576,19 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
573
576
  }
574
577
 
575
578
  /**
576
- * Verifies the 'tx' and, if valid, adds it to local tx pool and forwards it to other peers.
577
- * @param tx - The tx to verify.
579
+ * Accepts a transaction, adds it to local tx pool and forwards it to other peers.
580
+ * @param tx - The tx to send.
578
581
  * @returns Empty promise.
579
582
  **/
580
583
  public async sendTx(tx: Tx): Promise<void> {
581
- const addedCount = await this.addTxsToPool([tx]);
582
- const txAddedSuccessfully = addedCount === 1;
583
- if (txAddedSuccessfully) {
584
+ this.#assertIsReady();
585
+ const result = await this.txPool.addPendingTxs([tx]);
586
+ if (result.accepted.length === 1) {
584
587
  await this.p2pService.propagate(tx);
588
+ } else {
589
+ this.log.warn(
590
+ `Tx ${tx.getTxHash()} not propagated: accepted=${result.accepted.length} ignored=${result.ignored.length} rejected=${result.rejected.length}`,
591
+ );
585
592
  }
586
593
  }
587
594
 
@@ -591,7 +598,7 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
591
598
  **/
592
599
  public async addTxsToPool(txs: Tx[]): Promise<number> {
593
600
  this.#assertIsReady();
594
- return await this.txPool.addTxs(txs);
601
+ return (await this.txPool.addPendingTxs(txs)).accepted.length;
595
602
  }
596
603
 
597
604
  /**
@@ -599,8 +606,9 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
599
606
  * @param txHash - Hash of the tx to query.
600
607
  * @returns Pending or mined depending on its status, or undefined if not found.
601
608
  */
602
- public getTxStatus(txHash: TxHash): Promise<'pending' | 'mined' | 'deleted' | undefined> {
603
- return this.txPool.getTxStatus(txHash);
609
+ public async getTxStatus(txHash: TxHash): Promise<'pending' | 'mined' | 'deleted' | undefined> {
610
+ const status = await this.txPool.getTxStatus(txHash);
611
+ return status === 'protected' ? 'pending' : status;
604
612
  }
605
613
 
606
614
  public getEnr(): ENR | undefined {
@@ -612,14 +620,12 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
612
620
  }
613
621
 
614
622
  /**
615
- * Deletes the 'txs' from the pool.
616
- * NOT used if we use sendTx as reconcileTxPool will handle this.
617
- * @param txHashes - Hashes of the transactions to delete.
618
- * @returns Empty promise.
623
+ * Handles failed transaction execution by removing txs from the pool.
624
+ * @param txHashes - Hashes of the transactions that failed execution.
619
625
  **/
620
- public async deleteTxs(txHashes: TxHash[]): Promise<void> {
626
+ public async handleFailedExecution(txHashes: TxHash[]): Promise<void> {
621
627
  this.#assertIsReady();
622
- await this.txPool.deleteTxs(txHashes);
628
+ await this.txPool.handleFailedExecution(txHashes);
623
629
  }
624
630
 
625
631
  /**
@@ -679,14 +685,13 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
679
685
  }
680
686
 
681
687
  /**
682
- * Mark all txs from these blocks as mined.
688
+ * Handles mined blocks by marking the txs in them as mined.
683
689
  * @param blocks - A list of existing blocks with txs that the P2P client needs to ensure the tx pool is reconciled with.
684
690
  * @returns Empty promise.
685
691
  */
686
- private async markTxsAsMinedFromBlocks(blocks: L2Block[]): Promise<void> {
692
+ private async handleMinedBlocks(blocks: L2Block[]): Promise<void> {
687
693
  for (const block of blocks) {
688
- const txHashes = block.body.txEffects.map(txEffect => txEffect.txHash);
689
- await this.txPool.markAsMined(txHashes, block.header);
694
+ await this.txPool.handleMinedBlock(block);
690
695
  }
691
696
  }
692
697
 
@@ -697,16 +702,14 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
697
702
  */
698
703
  private async handleLatestL2Blocks(blocks: L2Block[]): Promise<void> {
699
704
  if (!blocks.length) {
700
- return Promise.resolve();
705
+ return;
701
706
  }
702
707
 
703
- await this.markTxsAsMinedFromBlocks(blocks);
704
- await this.txPool.clearNonEvictableTxs();
708
+ await this.handleMinedBlocks(blocks);
709
+ await this.maybeCallPrepareForSlot();
705
710
  await this.startCollectingMissingTxs(blocks);
706
-
707
711
  const lastBlock = blocks.at(-1)!;
708
712
  await this.synchedLatestSlot.set(BigInt(lastBlock.header.getSlot()));
709
- this.log.verbose(`Synched to latest block ${lastBlock.number}`);
710
713
  }
711
714
 
712
715
  /** Request txs for unproven blocks so the prover node has more chances to get them. */
@@ -745,68 +748,31 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
745
748
  */
746
749
  private async handleFinalizedL2Blocks(blocks: L2Block[]): Promise<void> {
747
750
  if (!blocks.length) {
748
- return Promise.resolve();
751
+ return;
749
752
  }
750
- this.log.debug(`Handling finalized blocks ${blocks.length} up to ${blocks.at(-1)?.number}`);
751
-
752
- const lastBlockNum = blocks[blocks.length - 1].number;
753
- const lastBlockSlot = blocks[blocks.length - 1].header.getSlot();
754
-
755
- const txHashes = blocks.flatMap(block => block.body.txEffects.map(txEffect => txEffect.txHash));
756
- this.log.debug(`Deleting ${txHashes.length} txs from pool from finalized blocks up to ${lastBlockNum}`);
757
- await this.txPool.deleteTxs(txHashes, { permanently: true });
758
- await this.txPool.cleanupDeletedMinedTxs(lastBlockNum);
759
-
760
- await this.attestationPool.deleteOlderThan(lastBlockSlot);
761
753
 
762
- this.log.debug(`Synched to finalized block ${lastBlockNum} at slot ${lastBlockSlot}`);
754
+ // Finalization is monotonic, so we only need to call with the last block
755
+ const lastBlock = blocks.at(-1)!;
756
+ await this.txPool.handleFinalizedBlock(lastBlock.header);
757
+ await this.attestationPool.deleteOlderThan(lastBlock.header.getSlot());
763
758
  }
764
759
 
765
760
  /**
766
761
  * Updates the tx pool after a chain prune.
767
- * @param latestBlock - The block number the chain was pruned to.
762
+ * @param latestBlock - The block ID the chain was pruned to.
768
763
  */
769
- private async handlePruneL2Blocks(latestBlock: BlockNumber): Promise<void> {
770
- const txsToDelete = new Map<string, TxHash>();
771
- const minedTxs = await this.txPool.getMinedTxHashes();
772
-
773
- // Find transactions that reference pruned blocks in their historical header
774
- for (const tx of await this.txPool.getAllTxs()) {
775
- // every tx that's been generated against a block that has now been pruned is no longer valid
776
- if (tx.data.constants.anchorBlockHeader.globalVariables.blockNumber > latestBlock) {
777
- const txHash = tx.getTxHash();
778
- txsToDelete.set(txHash.toString(), txHash);
779
- }
780
- }
781
-
782
- this.log.info(`Detected chain prune. Removing ${txsToDelete.size} txs built against pruned blocks.`, {
783
- newLatestBlock: latestBlock,
784
- previousLatestBlock: await this.getSyncedLatestBlockNum(),
785
- txsToDelete: Array.from(txsToDelete.keys()),
786
- });
787
-
788
- // delete invalid txs (both pending and mined)
789
- await this.txPool.deleteTxs(Array.from(txsToDelete.values()));
790
-
791
- // everything left in the mined set was built against a block on the proven chain so its still valid
792
- // move back to pending the txs that were reorged out of the chain, unless txPoolDeleteTxsAfterReorg is set,
793
- // in which case we clean them up to avoid potential reorg loops
794
- // NOTE: we can't move _all_ txs back to pending because the tx pool could keep hold of mined txs for longer
795
- // (see this.keepProvenTxsFor)
796
- const minedTxsFromReorg: TxHash[] = [];
797
- for (const [txHash, blockNumber] of minedTxs) {
798
- // We keep the txsToDelete out of this list as they have already been deleted above
799
- if (blockNumber > latestBlock && !txsToDelete.has(txHash.toString())) {
800
- minedTxsFromReorg.push(txHash);
801
- }
802
- }
764
+ private async handlePruneL2Blocks(latestBlock: L2BlockId): Promise<void> {
765
+ await this.txPool.handlePrunedBlocks(latestBlock);
766
+ }
803
767
 
804
- if (this.config.txPoolDeleteTxsAfterReorg) {
805
- this.log.info(`Deleting ${minedTxsFromReorg.length} mined txs from reorg`);
806
- await this.txPool.deleteTxs(minedTxsFromReorg);
807
- } else {
808
- await this.txPool.markMinedAsPending(minedTxsFromReorg, latestBlock);
768
+ /** Checks if the slot has changed and calls prepareForSlot if so. */
769
+ private async maybeCallPrepareForSlot(): Promise<void> {
770
+ const { currentSlot } = this.epochCache.getCurrentAndNextSlot();
771
+ if (currentSlot <= this.lastSlotProcessed) {
772
+ return;
809
773
  }
774
+ this.lastSlotProcessed = currentSlot;
775
+ await this.txPool.prepareForSlot(currentSlot);
810
776
  }
811
777
 
812
778
  private async startServiceIfSynched() {
@@ -851,11 +817,23 @@ export class P2PClient<T extends P2PClientType = P2PClientType.Full>
851
817
  }
852
818
 
853
819
  /**
854
- * Marks transactions as non-evictable in the pool.
855
- * @param txHashes - Hashes of the transactions to mark as non-evictable.
820
+ * Protects existing transactions by hash for a given slot.
821
+ * Returns hashes of transactions that weren't found in the pool.
822
+ * @param txHashes - Hashes of the transactions to protect.
823
+ * @param blockHeader - The block header providing slot context.
824
+ * @returns Hashes of transactions not found in the pool.
825
+ */
826
+ public protectTxs(txHashes: TxHash[], blockHeader: BlockHeader): Promise<TxHash[]> {
827
+ return this.txPool.protectTxs(txHashes, blockHeader);
828
+ }
829
+
830
+ /**
831
+ * Prepares the pool for a new slot.
832
+ * Unprotects transactions from earlier slots and validates them.
833
+ * @param slotNumber - The slot number to prepare for
856
834
  */
857
- public markTxsAsNonEvictable(txHashes: TxHash[]): Promise<void> {
858
- return this.txPool.markTxsAsNonEvictable(txHashes);
835
+ public async prepareForSlot(slotNumber: SlotNumber): Promise<void> {
836
+ await this.txPool.prepareForSlot(slotNumber);
859
837
  }
860
838
 
861
839
  public handleAuthRequestFromPeer(authRequest: AuthRequest, peerId: PeerId): Promise<StatusMessage> {
package/src/config.ts CHANGED
@@ -45,6 +45,9 @@ export interface P2PConfig
45
45
  /** The frequency in which to check for new L2 blocks. */
46
46
  blockCheckIntervalMS: number;
47
47
 
48
+ /** The frequency in which to check for new L2 slots. */
49
+ slotCheckIntervalMS: number;
50
+
48
51
  /** The number of blocks to fetch in a single batch. */
49
52
  blockRequestBatchSize: number;
50
53
 
@@ -184,6 +187,12 @@ export interface P2PConfig
184
187
 
185
188
  /** Whether to run in fisherman mode: validates all proposals and attestations but does not broadcast attestations or participate in consensus */
186
189
  fishermanMode: boolean;
190
+
191
+ /** Broadcast block proposals even when a conflicting proposal for the same slot already exists in the pool (for testing purposes only). */
192
+ broadcastEquivocatedProposals?: boolean;
193
+
194
+ /** Minimum age (ms) a transaction must have been in the pool before it's eligible for block building. */
195
+ minTxPoolAgeMs: number;
187
196
  }
188
197
 
189
198
  export const DEFAULT_P2P_PORT = 40400;
@@ -204,6 +213,11 @@ export const p2pConfigMappings: ConfigMappingsType<P2PConfig> = {
204
213
  description: 'The frequency in which to check for new L2 blocks.',
205
214
  ...numberConfigHelper(100),
206
215
  },
216
+ slotCheckIntervalMS: {
217
+ env: 'P2P_SLOT_CHECK_INTERVAL_MS',
218
+ description: 'The frequency in which to check for new L2 slots.',
219
+ ...numberConfigHelper(1000),
220
+ },
207
221
  debugDisableColocationPenalty: {
208
222
  env: 'DEBUG_P2P_DISABLE_COLOCATION_PENALTY',
209
223
  description: 'DEBUG: Disable colocation penalty - NEVER set to true in production',
@@ -448,6 +462,16 @@ export const p2pConfigMappings: ConfigMappingsType<P2PConfig> = {
448
462
  'Whether to run in fisherman mode: validates all proposals and attestations but does not broadcast attestations or participate in consensus.',
449
463
  ...booleanConfigHelper(false),
450
464
  },
465
+ broadcastEquivocatedProposals: {
466
+ description:
467
+ 'Broadcast block proposals even when a conflicting proposal for the same slot already exists in the pool (for testing purposes only).',
468
+ ...booleanConfigHelper(false),
469
+ },
470
+ minTxPoolAgeMs: {
471
+ env: 'P2P_MIN_TX_POOL_AGE_MS',
472
+ description: 'Minimum age (ms) a transaction must have been in the pool before it is eligible for block building.',
473
+ ...numberConfigHelper(2_000),
474
+ },
451
475
  ...sharedSequencerConfigMappings,
452
476
  ...p2pReqRespConfigMappings,
453
477
  ...batchTxRequesterConfigMappings,
package/src/index.ts CHANGED
@@ -7,5 +7,6 @@ export * from './enr/index.js';
7
7
  export * from './config.js';
8
8
  export * from './mem_pools/attestation_pool/index.js';
9
9
  export * from './mem_pools/tx_pool/index.js';
10
+ export * from './mem_pools/tx_pool_v2/index.js';
10
11
  export * from './msg_validators/index.js';
11
12
  export * from './services/index.js';