@aztec/p2p 0.0.1-commit.1bb068fb5 → 0.0.1-commit.1dcfe2301

package/dest/client/p2p_client.js

@@ -371,19 +371,16 @@ function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
     return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
 }
 var _dec, _dec1, _initProto;
-import { GENESIS_BLOCK_HEADER_HASH } from '@aztec/constants';
-import { BlockNumber, SlotNumber } from '@aztec/foundation/branded-types';
+import { BlockNumber, CheckpointNumber, SlotNumber } from '@aztec/foundation/branded-types';
 import { createLogger } from '@aztec/foundation/log';
 import { RunningPromise } from '@aztec/foundation/promise';
 import { DateProvider } from '@aztec/foundation/timer';
 import { L2TipsKVStore } from '@aztec/kv-store/stores';
-import { L2BlockStream } from '@aztec/stdlib/block';
-import { getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
+import { GENESIS_BLOCK_HEADER_HASH, L2BlockStream } from '@aztec/stdlib/block';
 import { tryStop } from '@aztec/stdlib/interfaces/server';
 import { Attributes, WithTracer, getTelemetryClient, trackSpan } from '@aztec/telemetry-client';
 import { getP2PDefaultConfig } from '../config.js';
-import { ReqRespSubProtocol } from '../services/reqresp/interface.js';
-import { chunkTxHashesRequest } from '../services/reqresp/protocols/tx.js';
+import { TxPoolError } from '../errors/tx-pool.error.js';
 import { TxProvider } from '../services/tx_provider.js';
 import { P2PClientState } from './interface.js';
 _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
@@ -438,7 +435,7 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
     validatorAddresses;
     /** Tracks the last slot for which we called prepareForSlot */ lastSlotProcessed;
     /** Polls for slot changes and calls prepareForSlot on the tx pool */ slotMonitor;
-    constructor(_clientType, store, l2BlockSource, mempools, p2pService, txCollection, txFileStore, epochCache, config = {}, _dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('p2p')){
+    constructor(store, l2BlockSource, mempools, p2pService, txCollection, txFileStore, epochCache, config = {}, _dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('p2p')){
         super(telemetry, 'P2PClient'), this.store = store, this.l2BlockSource = l2BlockSource, this.p2pService = p2pService, this.txCollection = txCollection, this.txFileStore = txFileStore, this.epochCache = epochCache, this._dateProvider = _dateProvider, this.telemetry = telemetry, this.log = log, this.currentState = (_initProto(this), P2PClientState.IDLE), this.syncPromise = Promise.resolve(), this.syncResolve = undefined, this.latestBlockNumberAtStart = -1, this.provenBlockNumberAtStart = -1, this.finalizedBlockNumberAtStart = -1, this.validatorAddresses = [], this.lastSlotProcessed = SlotNumber.ZERO;
         this.config = {
             ...getP2PDefaultConfig(),
@@ -447,29 +444,6 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
         this.txPool = mempools.txPool;
         this.attestationPool = mempools.attestationPool;
         this.txProvider = new TxProvider(this.txCollection, this.txPool, this, this.log.createChild('tx-provider'), this.telemetry);
-        // Default to collecting all txs when we see a valid proposal
-        // This can be overridden by the validator client to validate, and it will call getTxsForBlockProposal on its own
-        // Note: Validators do NOT attest to individual blocks - attestations are only for checkpoint proposals.
-        // TODO(palla/txs): We should not trigger a request for txs on a proposal before fully validating it. We need to bring
-        // validator-client code into here so we can validate a proposal is reasonable.
-        this.registerBlockProposalHandler(async (block, sender)=>{
-            this.log.debug(`Received block proposal from ${sender.toString()}`);
-            // TODO(palla/txs): Need to subtract validatorReexecuteDeadlineMs from this deadline (see ValidatorClient.getReexecutionDeadline)
-            const constants = this.txCollection.getConstants();
-            const nextSlotTimestampSeconds = Number(getTimestampForSlot(SlotNumber(block.slotNumber + 1), constants));
-            const deadline = new Date(nextSlotTimestampSeconds * 1000);
-            const parentBlock = await this.l2BlockSource.getBlockHeaderByArchive(block.blockHeader.lastArchive.root);
-            if (!parentBlock) {
-                this.log.debug(`Cannot collect txs for proposal as parent block not found`);
-                return false;
-            }
-            const blockNumber = BlockNumber(parentBlock.getBlockNumber() + 1);
-            await this.txProvider.getTxsForBlockProposal(block, blockNumber, {
-                pinnedPeer: sender,
-                deadline
-            });
-            return true;
-        });
         this.l2Tips = new L2TipsKVStore(store, 'p2p_client');
         this.synchedLatestSlot = store.openSingleton('p2p_pool_last_l2_slot');
     }
@@ -491,6 +465,9 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
     getPeers(includePending) {
         return Promise.resolve(this.p2pService.getPeers(includePending));
     }
+    getGossipMeshPeerCount(topicType) {
+        return Promise.resolve(this.p2pService.getGossipMeshPeerCount(topicType));
+    }
     getL2BlockHash(number) {
         return this.l2Tips.getL2BlockHash(number);
     }
@@ -523,7 +500,7 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
                 break;
             case 'chain-pruned':
                 this.txCollection.stopCollectingForBlocksAfter(event.block.number);
-                await this.handlePruneL2Blocks(event.block);
+                await this.handlePruneL2Blocks(event.block, event.checkpoint);
                 break;
             case 'chain-checkpointed':
                 break;
@@ -594,6 +571,10 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
                 syncedFinalizedBlock
             });
         }
+        // Should never happen: all branches above call initBlockStream()
+        if (!this.blockStream) {
+            throw new Error('Block stream not initialized');
+        }
         this.blockStream.start();
         await this.txCollection.start();
         this.txFileStore?.start();
@@ -638,6 +619,10 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
     }
     /** Triggers a sync to the archiver. Used for testing. */ async sync() {
         this.initBlockStream();
+        // Should never happen: initBlockStream() creates blockStream if absent
+        if (!this.blockStream) {
+            throw new Error('Block stream not initialized');
+        }
         await this.blockStream.sync();
     }
     async broadcastProposal(proposal) {
@@ -664,6 +649,8 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
             // Store our own last-block proposal so we can respond to req/resp requests for it.
             await this.attestationPool.tryAddBlockProposal(blockProposal);
         }
+        // Gossipsub doesn't deliver own messages, so fire the all-nodes handler locally
+        await this.p2pService.notifyOwnCheckpointProposal(proposal.toCore());
         return this.p2pService.propagate(proposal);
     }
     async broadcastCheckpointAttestations(attestations) {
@@ -684,8 +671,11 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
     registerBlockProposalHandler(handler) {
         this.p2pService.registerBlockReceivedCallback(handler);
     }
-    registerCheckpointProposalHandler(handler) {
-        this.p2pService.registerCheckpointReceivedCallback(handler);
+    registerValidatorCheckpointProposalHandler(handler) {
+        this.p2pService.registerValidatorCheckpointReceivedCallback(handler);
+    }
+    registerAllNodesCheckpointProposalHandler(handler) {
+        this.p2pService.registerAllNodesCheckpointReceivedCallback(handler);
     }
     registerDuplicateProposalCallback(callback) {
         this.p2pService.registerDuplicateProposalCallback(callback);
@@ -693,23 +683,6 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
     registerDuplicateAttestationCallback(callback) {
         this.p2pService.registerDuplicateAttestationCallback(callback);
     }
-    /**
-   * Uses the batched Request Response protocol to request a set of transactions from the network.
-   */ async requestTxsByHash(txHashes, pinnedPeerId) {
-        const timeoutMs = 8000; // Longer timeout for now
-        const maxRetryAttempts = 10; // Keep retrying within the timeout
-        const requests = chunkTxHashesRequest(txHashes);
-        const maxPeers = Math.min(Math.ceil(requests.length / 3), 10);
-        const txBatches = await this.p2pService.sendBatchRequest(ReqRespSubProtocol.TX, requests, pinnedPeerId, timeoutMs, maxPeers, maxRetryAttempts);
-        const txs = txBatches.flat();
-        if (txs.length > 0) {
-            await this.txPool.addPendingTxs(txs);
-        }
-        const txHashesStr = txHashes.map((tx)=>tx.toString()).join(', ');
-        this.log.debug(`Requested txs ${txHashesStr} (${txs.length} / ${txHashes.length}) from peers`);
-        // We return all transactions, even the not found ones to the caller, such they can handle missing items themselves.
-        return txs;
-    }
     async getPendingTxs(limit, after) {
         if (limit !== undefined && limit <= 0) {
             throw new TypeError('limit must be greater than 0');
@@ -765,42 +738,6 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
         return this.txPool.hasTxs(txHashes);
     }
     /**
-   * Returns transactions in the transaction pool by hash.
-   * If a transaction is not in the pool, it will be requested from the network.
-   * @param txHashes - Hashes of the transactions to look for.
-   * @returns The txs found, or undefined if not found in the order requested.
-   */ async getTxsByHash(txHashes, pinnedPeerId) {
-        const txs = await Promise.all(txHashes.map((txHash)=>this.txPool.getTxByHash(txHash)));
-        const missingTxHashes = txs.map((tx, index)=>[
-                tx,
-                index
-            ]).filter(([tx, _index])=>!tx).map(([_tx, index])=>txHashes[index]);
-        if (missingTxHashes.length === 0) {
-            return txs;
-        }
-        const missingTxs = await this.requestTxsByHash(missingTxHashes, pinnedPeerId);
-        // TODO: optimize
-        // Merge the found txs in order
-        const mergingTxs = txHashes.map((txHash)=>{
-            // Is it in the txs list from the mempool?
-            for (const tx of txs){
-                if (tx !== undefined && tx.getTxHash().equals(txHash)) {
-                    return tx;
-                }
-            }
-            // Is it in the fetched missing txs?
-            // Note: this is an O(n^2) operation, but we expect the number of missing txs to be small.
-            for (const tx of missingTxs){
-                if (tx.getTxHash().equals(txHash)) {
-                    return tx;
-                }
-            }
-            // Otherwise return undefined
-            return undefined;
-        });
-        return mergingTxs;
-    }
-    /**
    * Returns an archived transaction in the transaction pool by its hash.
    * @param txHash - Hash of the archived transaction to look for.
    * @returns A single tx or undefined.
@@ -815,19 +752,20 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
         this.#assertIsReady();
         const result = await this.txPool.addPendingTxs([
             tx
-        ]);
+        ], {
+            feeComparisonOnly: true
+        });
         if (result.accepted.length === 1) {
             await this.p2pService.propagate(tx);
-        } else {
-            this.log.warn(`Tx ${tx.getTxHash()} not propagated: accepted=${result.accepted.length} ignored=${result.ignored.length} rejected=${result.rejected.length}`);
+            return;
         }
-    }
-    /**
-   * Adds transactions to the pool. Does not send to peers or validate the txs.
-   * @param txs - The transactions.
-   **/ async addTxsToPool(txs) {
-        this.#assertIsReady();
-        return (await this.txPool.addPendingTxs(txs)).accepted.length;
+        const txHashStr = tx.getTxHash().toString();
+        const reason = result.errors?.get(txHashStr);
+        if (reason) {
+            this.log.warn(`Tx ${txHashStr} not added to pool: ${reason.message}`);
+            throw new TxPoolError(reason);
+        }
+        this.log.warn(`Tx ${txHashStr} not propagated: accepted=${result.accepted.length} ignored=${result.ignored.length} rejected=${result.rejected.length}`);
     }
     /**
    * Returns whether the given tx hash is flagged as pending or mined.
@@ -955,17 +893,56 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
     }
     /**
    * Updates the tx pool after a chain prune.
+   * Detects epoch prunes (checkpoint number changed) and deletes all txs in that case.
    * @param latestBlock - The block ID the chain was pruned to.
-   */ async handlePruneL2Blocks(latestBlock) {
-        await this.txPool.handlePrunedBlocks(latestBlock);
+   * @param newCheckpoint - The checkpoint ID after the prune.
+   */ async handlePruneL2Blocks(latestBlock, newCheckpoint) {
+        const deleteAllTxs = this.config.txPoolDeleteTxsAfterReorg && await this.isEpochPrune(newCheckpoint);
+        await this.txPool.handlePrunedBlocks(latestBlock, {
+            deleteAllTxs
+        });
+    }
+    /**
+   * Returns true if the prune is an epoch prune (new checkpoint number is less than old).
+   * If the checkpoint number stays the same or increases, the prune is within a checkpoint.
+   */ async isEpochPrune(newCheckpoint) {
+        const tips = await this.l2Tips.getL2Tips();
+        const oldCheckpointNumber = tips.checkpointed.checkpoint.number;
+        if (oldCheckpointNumber <= CheckpointNumber.INITIAL) {
+            return false;
+        }
+        const newCheckpointNumber = newCheckpoint.number;
+        // We check that the new checkpoint number is less than the old checkpoint number in order to consider it an epoch prune.
+        // To be more certain that it is an epoch prune, we will check that at least 2 checkpoints were removed.
+        // This means we should avoid thinking checkpoints removed by L1 re-orgs are epoch prunes
+        const thresholdForEpochPrune = CheckpointNumber(oldCheckpointNumber - 2);
+        const isEpochPrune = newCheckpointNumber <= thresholdForEpochPrune;
+        if (isEpochPrune) {
+            this.log.info(`Detected epoch prune to ${newCheckpointNumber}`, {
+                oldCheckpointNumber,
+                newCheckpointNumber,
+                thresholdForEpochPrune
+            });
+        }
+        return isEpochPrune;
     }
     /** Checks if the slot has changed and calls prepareForSlot if so. */ async maybeCallPrepareForSlot() {
-        const { currentSlot } = this.epochCache.getCurrentAndNextSlot();
-        if (currentSlot <= this.lastSlotProcessed) {
+        // If we have a proposed checkpoint available, we want to prepare the target slot - otherwise we prepare the current slot
+        const l2Tips = await this.l2Tips.getL2Tips();
+        const hasProposedCheckpoint = l2Tips.proposedCheckpoint.checkpoint.number > l2Tips.checkpointed.checkpoint.number;
+        let slot;
+        if (this.epochCache.isProposerPipeliningEnabled() && hasProposedCheckpoint) {
+            const { targetSlot } = this.epochCache.getTargetAndNextSlot();
+            slot = targetSlot;
+        } else {
+            const { currentSlot } = this.epochCache.getCurrentAndNextSlot();
+            slot = currentSlot;
+        }
+        if (slot <= this.lastSlotProcessed) {
             return;
         }
-        this.lastSlotProcessed = currentSlot;
-        await this.txPool.prepareForSlot(currentSlot);
+        this.lastSlotProcessed = slot;
+        await this.txPool.prepareForSlot(slot);
     }
     async startServiceIfSynched() {
         if (this.currentState !== P2PClientState.SYNCHING) {
@@ -996,8 +973,8 @@ _dec = trackSpan('p2pClient.broadcastProposal', async (proposal)=>({
         this.currentState = newState;
         this.log.debug(`Moved from state ${P2PClientState[oldState]} to ${P2PClientState[this.currentState]}`);
     }
-    validate(txs) {
-        return this.p2pService.validate(txs);
+    validateTxsReceivedInBlockProposal(txs) {
+        return this.p2pService.validateTxsReceivedInBlockProposal(txs);
     }
     /**
    * Protects existing transactions by hash for a given slot.

package/dest/client/test/tx_proposal_collector/proposal_tx_collector_worker.js

@@ -4,13 +4,12 @@ import { createLogger } from '@aztec/foundation/log';
 import { sleep } from '@aztec/foundation/sleep';
 import { DateProvider, Timer, executeTimeout } from '@aztec/foundation/timer';
 import { openTmpStore } from '@aztec/kv-store/lmdb-v2';
-import { P2PClientType } from '@aztec/stdlib/p2p';
 import { getTelemetryClient } from '@aztec/telemetry-client';
 import { peerIdFromString } from '@libp2p/peer-id';
+import { BatchTxRequesterCollector, SendBatchRequestCollector } from '../../../services/index.js';
 import { RateLimitStatus } from '../../../services/reqresp/rate-limiter/rate_limiter.js';
-import { BatchTxRequesterCollector, SendBatchRequestCollector } from '../../../services/tx_collection/proposal_tx_collector.js';
-import { AlwaysTrueCircuitVerifier } from '../../../test-helpers/reqresp-nodes.js';
-import { BENCHMARK_CONSTANTS, InMemoryAttestationPool, InMemoryTxPool, UNLIMITED_RATE_LIMIT_QUOTA, calculateInternalTimeout, createMockEpochCache, createMockWorldStateSynchronizer } from '../../../test-helpers/testbench-utils.js';
+import { RequestTracker } from '../../../services/tx_collection/request_tracker.js';
+import { AlwaysTrueCircuitVerifier, BENCHMARK_CONSTANTS, InMemoryAttestationPool, InMemoryTxPool, UNLIMITED_RATE_LIMIT_QUOTA, calculateInternalTimeout, createMockEpochCache, createMockWorldStateSynchronizer } from '../../../test-helpers/index.js';
 import { createP2PClient } from '../../index.js';
 import { deserializeBlockProposal, deserializeTx, deserializeTxHash } from './proposal_tx_collector_worker_protocol.js';
 let client;
@@ -83,7 +82,7 @@ async function startClient(config, clientIndex) {
         store: kvStore,
         logger
     };
-    client = await createP2PClient(P2PClientType.Full, config, l2BlockSource, proofVerifier, worldState, epochCache, 'proposal-tx-collector-bench-worker', new DateProvider(), telemetry, deps);
+    client = await createP2PClient(config, l2BlockSource, proofVerifier, worldState, epochCache, 'proposal-tx-collector-bench-worker', new DateProvider(), telemetry, deps);
     await client.start();
     installUnlimitedRateLimits();
     for(let i = 0; i < 120; i++){
@@ -162,11 +161,11 @@ async function runCollector(cmd) {
     try {
         if (collectorType === 'batch-requester') {
             const collector = new BatchTxRequesterCollector(p2pService, logger, new DateProvider(), noopTxValidator);
-            const fetched = await executeTimeout((_signal)=>collector.collectTxs(parsedTxHashes, parsedProposal, pinnedPeer, internalTimeoutMs), timeoutMs, ()=>new Error(`Collector timed out after ${timeoutMs}ms`));
+            const fetched = await executeTimeout((_signal)=>collector.collectTxs(RequestTracker.create(parsedTxHashes, new Date(Date.now() + internalTimeoutMs)), parsedProposal, pinnedPeer), timeoutMs, ()=>new Error(`Collector timed out after ${timeoutMs}ms`));
             fetchedCount = fetched.length;
         } else {
             const collector = new SendBatchRequestCollector(p2pService, BENCHMARK_CONSTANTS.FIXED_MAX_PEERS, BENCHMARK_CONSTANTS.FIXED_MAX_RETRY_ATTEMPTS);
-            const fetched = await executeTimeout((_signal)=>collector.collectTxs(parsedTxHashes, parsedProposal, pinnedPeer, internalTimeoutMs), timeoutMs, ()=>new Error(`Collector timed out after ${timeoutMs}ms`));
+            const fetched = await executeTimeout((_signal)=>collector.collectTxs(RequestTracker.create(parsedTxHashes, new Date(Date.now() + internalTimeoutMs)), parsedProposal, pinnedPeer), timeoutMs, ()=>new Error(`Collector timed out after ${timeoutMs}ms`));
             fetchedCount = fetched.length;
         }
     } catch (err) {
@@ -189,9 +188,19 @@ async function stopClient() {
     txPool = undefined;
     attestationPool = undefined;
 }
+function gracefulExit(code = 0) {
+    try {
+        if (process.connected) {
+            process.disconnect();
+        }
+    } catch  {
+    // IPC channel already closed
+    }
+    setTimeout(()=>process.exit(code), 5000).unref();
+}
 process.on('disconnect', ()=>{
     ipcDisconnected = true;
-    void stopClient().finally(()=>process.exit(0));
+    void stopClient();
 });
 process.on('error', (err)=>{
     if (isIpcDisconnectError(err)) {
@@ -282,7 +291,7 @@ process.on('message', (msg)=>{
                             type: 'STOPPED',
                             requestId
                         });
-                        process.exit(0);
+                        gracefulExit(0);
                         break;
                     }
                 default:
@@ -298,7 +307,8 @@ process.on('message', (msg)=>{
                 error: err?.message ?? String(err)
             });
             if (msg.type === 'START') {
-                process.exit(1);
+                await stopClient();
+                gracefulExit(1);
             }
         }
     })();