@aztec/bb-prover 0.0.1-commit.e558bd1c → 0.0.1-commit.e57c76e

package/src/verifier/batch_chonk_verifier.ts

@@ -0,0 +1,415 @@
+import { BackendType, Barretenberg } from '@aztec/bb.js';
+import { FifoFrameReader } from '@aztec/foundation/fifo';
+import { createLogger } from '@aztec/foundation/log';
+import { SerialQueue } from '@aztec/foundation/queue';
+import { Timer } from '@aztec/foundation/timer';
+import { ProtocolCircuitVks } from '@aztec/noir-protocol-circuits-types/server/vks';
+import type { ClientProtocolCircuitVerifier, IVCProofVerificationResult } from '@aztec/stdlib/interfaces/server';
+import type { Tx } from '@aztec/stdlib/tx';
+
+import { Unpackr } from 'msgpackr';
+import { execFile } from 'node:child_process';
+import { rmSync } from 'node:fs';
+import { mkdtemp, rm } from 'node:fs/promises';
+import * as os from 'node:os';
+import * as path from 'node:path';
+import { promisify } from 'node:util';
+
+import type { BBConfig } from '../config.js';
+
+const execFileAsync = promisify(execFile);
+const RESULT_TIMEOUT_MS = 5 * 60 * 1000;
+const STOP_DRAIN_TIMEOUT_MS = 5_000;
+
+/** Result from the FIFO, matching the C++ VerifyResult struct. */
+interface FifoVerifyResult {
+  request_id: number;
+  status: number;
+  error_message: string;
+  time_in_verify_ms: number;
+}
+
+/** Maps client protocol artifacts used for chonk verification to VK indices. */
+const CHONK_VK_ARTIFACTS = ['HidingKernelToRollup', 'HidingKernelToPublic'] as const;
+
+interface PendingRequest {
+  resolve: (result: IVCProofVerificationResult) => void;
+  reject: (error: Error) => void;
+  totalTimer: Timer;
+  timeout: ReturnType<typeof setTimeout>;
+}
+
+/**
+ * Batch verifier for Chonk IVC proofs. Uses the bb batch verifier service
+ * which batches IPA verification into a constant number of SRS MSMs for better throughput.
+ *
+ * Architecture:
+ * - Spawns a persistent `bb msgpack run` process via Barretenberg (native backend)
+ * - Sends proofs via the msgpack RPC protocol (ChonkBatchVerifierQueue)
+ * - Receives results via a named FIFO pipe (async, out-of-order)
+ * - Bisects batch failures to isolate individual bad proofs
+ */
+export class BatchChonkVerifier implements ClientProtocolCircuitVerifier {
+  private bb!: Barretenberg;
+  private fifoDir: string | undefined;
+  private fifoPath = '';
+  private nextRequestId = 0;
+  private pendingRequests = new Map<number, PendingRequest>();
+  private sendQueue: SerialQueue;
+  private fifoReader: FifoFrameReader;
+  private logger = createLogger('bb-prover:batch_chonk_verifier');
+  /** Maps artifact name to VK index in the batch verifier. */
+  private vkIndexMap = new Map<string, number>();
+  /** Bound cleanup handler for process exit signals. */
+  private exitCleanup: (() => void) | null = null;
+  private stopped = false;
+  private fatalError: Error | undefined;
+  private pendingDrainedResolvers = new Set<() => void>();
+
+  private constructor(
+    private config: Pick<BBConfig, 'bbChonkVerifyConcurrency'> & Partial<Pick<BBConfig, 'bbBinaryPath'>>,
+    private vkBuffers: Uint8Array[],
+    private batchSize: number,
+    private label: string,
+  ) {
+    this.fifoReader = new FifoFrameReader();
+    this.sendQueue = new SerialQueue();
+    this.sendQueue.start(1);
+  }
+
+  /** Create and start a BatchChonkVerifier using the protocol circuit VKs. */
+  static async new(config: BBConfig, batchSize: number, label: string): Promise<BatchChonkVerifier> {
+    const vkBuffers: Uint8Array[] = [];
+    const vkIndexMap = new Map<string, number>();
+    for (const artifact of CHONK_VK_ARTIFACTS) {
+      const vk = ProtocolCircuitVks[artifact];
+      if (!vk) {
+        throw new Error(`Missing VK for ${artifact}`);
+      }
+      vkIndexMap.set(artifact, vkBuffers.length);
+      vkBuffers.push(vk.keyAsBytes);
+    }
+    const verifier = new BatchChonkVerifier(config, vkBuffers, batchSize, label);
+    verifier.vkIndexMap = vkIndexMap;
+    await verifier.start();
+    return verifier;
+  }
+
+  /** Create and start a BatchChonkVerifier with custom VKs (for testing). */
+  static async newForTesting(
+    config: Pick<BBConfig, 'bbChonkVerifyConcurrency'> & Partial<Pick<BBConfig, 'bbBinaryPath'>>,
+    vks: Uint8Array[],
+    batchSize: number,
+  ): Promise<BatchChonkVerifier> {
+    const verifier = new BatchChonkVerifier(config, vks, batchSize, 'test');
+    for (let i = 0; i < vks.length; i++) {
+      verifier.vkIndexMap.set(String(i), i);
+    }
+    await verifier.start();
+    return verifier;
+  }
+
+  private async start(): Promise<void> {
+    this.logger.info('Starting BatchChonkVerifier');
+
+    try {
+      this.bb = await Barretenberg.new({
+        bbPath: this.config.bbBinaryPath,
+        backend: BackendType.NativeUnixSocket,
+      });
+      await this.bb.initSRSChonk();
+
+      // Keep the FIFO in a private directory so cleanup has a single owner.
+      this.fifoDir = await mkdtemp(path.join(os.tmpdir(), `bb-batch-${this.label}-${process.pid}-`));
+      this.fifoPath = path.join(this.fifoDir, 'results.fifo');
+      await execFileAsync('mkfifo', [this.fifoPath]);
+      this.registerExitCleanup();
+      this.startFifoReader();
+
+      await this.bb.chonkBatchVerifierStart({
+        vks: this.vkBuffers,
+        numCores: this.config.bbChonkVerifyConcurrency || 0,
+        batchSize: this.batchSize,
+        fifoPath: this.fifoPath,
+      });
+    } catch (err) {
+      this.fifoReader.stop();
+      this.deregisterExitCleanup();
+      await this.cleanupFifo();
+      await this.bb?.destroy().catch(() => {});
+      throw err;
+    }
+    this.logger.info('BatchChonkVerifier started', { fifoPath: this.fifoPath });
+  }
+
+  public verifyProof(tx: Tx): Promise<IVCProofVerificationResult> {
+    const totalTimer = new Timer();
+    return (async () => {
+      const circuit = tx.data.forPublic ? 'HidingKernelToPublic' : 'HidingKernelToRollup';
+      const vkIndex = this.vkIndexMap.get(circuit);
+      if (vkIndex === undefined) {
+        throw new Error(`No VK index for circuit ${circuit}`);
+      }
+      const proofWithPubInputs = tx.chonkProof.attachPublicInputs(tx.data.publicInputs().toFields());
+      const proofFields = proofWithPubInputs.fieldsWithPublicInputs.map(f => f.toBuffer());
+      return await this.enqueueProof(vkIndex, proofFields);
+    })().catch(err => {
+      this.logger.warn(`Failed to verify Chonk proof for tx ${tx.getTxHash().toString()}: ${String(err)}`);
+      return { valid: false, durationMs: 0, totalDurationMs: totalTimer.ms() };
+    });
+  }
+
+  /** Enqueue raw proof fields for verification. Used directly by tests with custom VKs. */
+  public enqueueProof(vkIndex: number, proofFields: Uint8Array[]): Promise<IVCProofVerificationResult> {
+    if (this.stopped) {
+      return Promise.reject(new Error('BatchChonkVerifier stopped'));
+    }
+    if (this.fatalError) {
+      return Promise.reject(this.fatalError);
+    }
+
+    const totalTimer = new Timer();
+    const requestId = this.nextRequestId++;
+
+    const resultPromise = new Promise<IVCProofVerificationResult>((resolve, reject) => {
+      const timeout = setTimeout(() => {
+        const pending = this.pendingRequests.get(requestId);
+        if (!pending) {
+          return;
+        }
+        this.pendingRequests.delete(requestId);
+        pending.reject(new Error(`BatchChonkVerifier result timed out for request_id=${requestId}`));
+        this.notifyPendingDrained();
+      }, RESULT_TIMEOUT_MS);
+      // A pending result timer must never keep the host process alive on its own (e.g. an
+      // orphaned request at process exit); the FIFO reader keeps the loop alive while results
+      // are genuinely awaited.
+      timeout.unref();
+      this.pendingRequests.set(requestId, { resolve, reject, totalTimer, timeout });
+    });
+
+    void this.sendQueue
+      .put(async () => {
+        if (this.fatalError) {
+          throw this.fatalError;
+        }
+        await this.bb.chonkBatchVerifierQueue({
+          requestId,
+          vkIndex,
+          proofFields,
+        });
+      })
+      .catch(err => {
+        const pending = this.pendingRequests.get(requestId);
+        if (pending) {
+          this.pendingRequests.delete(requestId);
+          clearTimeout(pending.timeout);
+          pending.reject(err instanceof Error ? err : new Error(String(err)));
+          this.notifyPendingDrained();
+        }
+      });
+
+    return resultPromise;
+  }
+
+  public async stop(): Promise<void> {
+    this.logger.info('Stopping BatchChonkVerifier');
+    this.stopped = true;
+
+    try {
+      // Stop accepting new proofs and flush the send queue. Bound it so an unresponsive
+      // native process can't block teardown of our own event-loop handles indefinitely.
+      await this.withTimeout(this.sendQueue.end(), STOP_DRAIN_TIMEOUT_MS, 'send queue flush');
+
+      // Stop the bb service (flushes remaining proofs).
+      await this.withTimeout(this.bb.chonkBatchVerifierStop({}), STOP_DRAIN_TIMEOUT_MS, 'chonkBatchVerifierStop');
+
+      // Native stop flushes callbacks; keep the FIFO open until those frames are observed.
+      const drained = await this.waitForPendingRequestsToDrain(STOP_DRAIN_TIMEOUT_MS);
+      if (!drained) {
+        this.rejectPendingRequests(new Error('Timed out waiting for BatchChonkVerifier results during stop'));
+      }
+    } catch (err) {
+      this.logger.warn(`Error during BatchChonkVerifier graceful stop: ${err}`);
+      this.rejectPendingRequests(err instanceof Error ? err : new Error(String(err)));
+    } finally {
+      // Always release our own event-loop handles — the FIFO read stream (a blocking
+      // threadpool read that can't be unref'd), the unix socket, the native process, and the
+      // exit handler — so the host process exits cleanly even if the native backend is wedged.
+      this.fifoReader.stop();
+      this.deregisterExitCleanup();
+      await this.cleanupFifo();
+      await this.bb.destroy().catch(err => this.logger.warn(`Error destroying bb backend during stop: ${err}`));
+    }
+
+    this.logger.info('BatchChonkVerifier stopped');
+  }
+
+  /**
+   * Races a promise against a timeout so a wedged native backend can't block teardown. The
+   * timer is unref'd so it never keeps the process alive; the underlying promise stays handled
+   * by the race even if the timeout wins, so it cannot surface as an unhandled rejection.
+   */
+  private async withTimeout<T>(promise: Promise<T>, timeoutMs: number, label: string): Promise<T | void> {
+    let timer: ReturnType<typeof setTimeout> | undefined;
+    const timeout = new Promise<void>((_, reject) => {
+      timer = setTimeout(
+        () => reject(new Error(`BatchChonkVerifier ${label} timed out after ${timeoutMs}ms`)),
+        timeoutMs,
+      );
+      timer.unref();
+    });
+    try {
+      return await Promise.race([promise, timeout]);
+    } finally {
+      if (timer) {
+        clearTimeout(timer);
+      }
+    }
+  }
+
+  private startFifoReader(): void {
+    const unpackr = new Unpackr({ useRecords: false });
+
+    this.fifoReader.on('frame', (payload: Buffer) => {
+      try {
+        const result = unpackr.unpack(payload) as FifoVerifyResult;
+        this.handleResult(result);
+      } catch (err) {
+        this.logger.error(`FIFO: failed to decode msgpack result: ${err}`);
+        // A corrupt result stream cannot safely be matched to outstanding requests.
+        this.failVerifier(err instanceof Error ? err : new Error(String(err)));
+      }
+    });
+
+    this.fifoReader.on('error', (err: Error) => {
+      this.logger.error(`FIFO reader error: ${err}`);
+      this.failVerifier(err);
+    });
+
+    this.fifoReader.on('end', () => {
+      this.logger.debug('FIFO reader: stream ended');
+      if (!this.stopped) {
+        this.failVerifier(new Error('FIFO stream ended unexpectedly'));
+      }
+    });
+
+    this.fifoReader.start(this.fifoPath);
+  }
+
+  private handleResult(result: FifoVerifyResult): void {
+    const pending = this.pendingRequests.get(result.request_id);
+    if (!pending) {
+      this.logger.warn(`Received result for unknown request_id=${result.request_id}`);
+      return;
+    }
+    this.pendingRequests.delete(result.request_id);
+    clearTimeout(pending.timeout);
+
+    const valid = result.status === 0; // VerifyStatus::OK
+    const durationMs = result.time_in_verify_ms;
+    const totalDurationMs = pending.totalTimer.ms();
+
+    const ivcResult: IVCProofVerificationResult = { valid, durationMs, totalDurationMs };
+
+    if (!valid) {
+      this.logger.warn(`Proof verification failed for request_id=${result.request_id}: ${result.error_message}`);
+    } else {
+      this.logger.debug(`Proof verified`, {
+        requestId: result.request_id,
+        durationMs: Math.ceil(durationMs),
+        totalDurationMs: Math.ceil(totalDurationMs),
+      });
+    }
+
+    pending.resolve(ivcResult);
+    this.notifyPendingDrained();
+  }
+
+  private registerExitCleanup(): void {
+    this.exitCleanup = () => {
+      this.cleanupFifoSync();
+    };
+    process.on('exit', this.exitCleanup);
+  }
+
+  private deregisterExitCleanup(): void {
+    if (this.exitCleanup) {
+      process.removeListener('exit', this.exitCleanup);
+      this.exitCleanup = null;
+    }
+  }
+
+  private rejectPendingRequests(error: Error): void {
+    for (const [id, pending] of Array.from(this.pendingRequests)) {
+      pending.reject(error);
+      clearTimeout(pending.timeout);
+      this.pendingRequests.delete(id);
+    }
+    this.notifyPendingDrained();
+  }
+
+  private failVerifier(error: Error): void {
+    if (!this.fatalError) {
+      this.fatalError = error;
+    }
+    this.rejectPendingRequests(error);
+  }
+
+  private waitForPendingRequestsToDrain(timeoutMs: number): Promise<boolean> {
+    if (this.pendingRequests.size === 0) {
+      return Promise.resolve(true);
+    }
+
+    let timeout: ReturnType<typeof setTimeout> | undefined;
+    let onDrain: (() => void) | undefined;
+    const drained = new Promise<boolean>(resolve => {
+      onDrain = () => resolve(true);
+      this.pendingDrainedResolvers.add(onDrain);
+    });
+    const timedOut = new Promise<boolean>(resolve => {
+      timeout = setTimeout(() => resolve(false), timeoutMs);
+      timeout.unref();
+    });
+
+    return Promise.race([drained, timedOut]).finally(() => {
+      if (timeout) {
+        clearTimeout(timeout);
+      }
+      if (onDrain) {
+        this.pendingDrainedResolvers.delete(onDrain);
+      }
+    });
+  }
+
+  private notifyPendingDrained(): void {
+    if (this.pendingRequests.size > 0) {
+      return;
+    }
+    for (const resolve of Array.from(this.pendingDrainedResolvers)) {
+      resolve();
+    }
+  }
+
+  private async cleanupFifo(): Promise<void> {
+    if (this.fifoDir) {
+      await rm(this.fifoDir, { recursive: true, force: true }).catch(() => {});
+    } else if (this.fifoPath) {
+      await rm(this.fifoPath, { force: true }).catch(() => {});
+    }
+    this.fifoDir = undefined;
+    this.fifoPath = '';
+  }
+
+  private cleanupFifoSync(): void {
+    try {
+      if (this.fifoDir) {
+        rmSync(this.fifoDir, { recursive: true, force: true });
+      } else if (this.fifoPath) {
+        rmSync(this.fifoPath, { force: true });
+      }
+    } catch {
+      /* ignore */
+    }
+  }
+}

package/src/verifier/bb_verifier.ts

@@ -1,4 +1,3 @@
-import { runInDirectory } from '@aztec/foundation/fs';
 import { type Logger, createLogger } from '@aztec/foundation/log';
 import { Timer } from '@aztec/foundation/timer';
 import { ProtocolCircuitVks } from '@aztec/noir-protocol-circuits-types/server/vks';
@@ -15,28 +14,29 @@ import { Tx } from '@aztec/stdlib/tx';
 import type { VerificationKeyData } from '@aztec/stdlib/vks';
 
 import { promises as fs } from 'fs';
-import * as path from 'path';
 
-import {
-  BB_RESULT,
-  PROOF_FILENAME,
-  PUBLIC_INPUTS_FILENAME,
-  VK_FILENAME,
-  verifyChonkProof,
-  verifyProof,
-} from '../bb/execute.js';
+import { BBJsFactory } from '../bb/bb_js_backend.js';
 import type { BBConfig } from '../config.js';
 import { getUltraHonkFlavorForCircuit } from '../honk.js';
-import { writeChonkProofToPath } from '../prover/proof_utils.js';
 
 export class BBCircuitVerifier implements ClientProtocolCircuitVerifier {
+  private bbJsFactory: BBJsFactory;
+
   private constructor(
     private config: BBConfig,
     private logger: Logger,
-  ) {}
+  ) {
+    // BB_NUM_IVC_VERIFIERS bounds the number of long-lived bb processes the pool keeps alive.
+    // If 0, fall back to spawning a fresh bb per verification.
+    this.bbJsFactory = new BBJsFactory(config.bbBinaryPath, {
+      poolSize: config.numConcurrentIVCVerifiers > 0 ? config.numConcurrentIVCVerifiers : undefined,
+      logger,
+      debugDir: config.bbDebugOutputDir,
+    });
+  }
 
   public stop(): Promise<void> {
-    return Promise.resolve();
+    return this.bbJsFactory.destroy();
   }
 
   public static async new(config: BBConfig, logger = createLogger('bb-prover:verifier')) {
@@ -55,87 +55,77 @@ export class BBCircuitVerifier implements ClientProtocolCircuitVerifier {
     return vk;
   }
 
+  /** Verify an UltraHonk proof via bb.js API (no temp files). */
   public async verifyProofForCircuit(circuit: ServerProtocolArtifact, proof: Proof) {
-    const operation = async (bbWorkingDirectory: string) => {
-      const publicInputsFileName = path.join(bbWorkingDirectory, PUBLIC_INPUTS_FILENAME);
-      const proofFileName = path.join(bbWorkingDirectory, PROOF_FILENAME);
-      const verificationKeyPath = path.join(bbWorkingDirectory, VK_FILENAME);
-      const verificationKey = this.getVerificationKeyData(circuit);
+    const verificationKey = this.getVerificationKeyData(circuit);
+    const flavor = getUltraHonkFlavorForCircuit(circuit);
 
-      this.logger.debug(`${circuit} Verifying with key: ${verificationKey.keyAsFields.hash.toString()}`);
+    this.logger.debug(`${circuit} Verifying with key: ${verificationKey.keyAsFields.hash.toString()}`);
 
-      // TODO(https://github.com/AztecProtocol/aztec-packages/issues/13189): Put this proof parsing logic in the proof class.
-      await fs.writeFile(publicInputsFileName, proof.buffer.slice(0, proof.numPublicInputs * 32));
-      await fs.writeFile(proofFileName, proof.buffer.slice(proof.numPublicInputs * 32));
-      await fs.writeFile(verificationKeyPath, verificationKey.keyAsBytes);
+    // Split proof buffer into public input fields and proof fields (32-byte each)
+    const publicInputFields = splitBufferToFieldArrays(proof.buffer.subarray(0, proof.numPublicInputs * 32));
+    const proofFields = splitBufferToFieldArrays(proof.buffer.subarray(proof.numPublicInputs * 32));
 
-      const result = await verifyProof(
-        this.config.bbBinaryPath,
-        proofFileName,
-        verificationKeyPath!,
-        getUltraHonkFlavorForCircuit(circuit),
-        this.logger,
-      );
+    await using instance = await this.bbJsFactory.getInstance();
+    const { verified, durationMs } = await instance.verifyProof(
+      proofFields,
+      verificationKey.keyAsBytes,
+      publicInputFields,
+      flavor,
+    );
 
-      if (result.status === BB_RESULT.FAILURE) {
-        const errorMessage = `Failed to verify ${circuit} proof!`;
-        throw new Error(errorMessage);
-      }
+    if (!verified) {
+      throw new Error(`Failed to verify ${circuit} proof!`);
+    }
 
-      this.logger.debug(`${circuit} verification successful`, {
-        circuitName: mapProtocolArtifactNameToCircuitName(circuit),
-        duration: result.durationMs,
-        eventName: 'circuit-verification',
-        proofType: 'ultra-honk',
-      } satisfies CircuitVerificationStats);
-    };
-    await runInDirectory(this.config.bbWorkingDirectory, operation, this.config.bbSkipCleanup, this.logger);
+    this.logger.debug(`${circuit} verification successful`, {
+      circuitName: mapProtocolArtifactNameToCircuitName(circuit),
+      duration: durationMs,
+      eventName: 'circuit-verification',
+      proofType: 'ultra-honk',
+    } satisfies CircuitVerificationStats);
   }
 
+  /** Verify a Chonk (IVC) proof from a transaction via bb.js API. */
   public async verifyProof(tx: Tx): Promise<IVCProofVerificationResult> {
     const proofType = 'Chonk';
     try {
       const totalTimer = new Timer();
-      let verificationDuration = 0;
 
       const circuit: ClientProtocolArtifact = tx.data.forPublic ? 'HidingKernelToPublic' : 'HidingKernelToRollup';
+      const verificationKey = this.getVerificationKeyData(circuit);
+
+      // Reconstruct the full proof with public inputs prepended, then convert Fr[] to Uint8Array[]
+      const proofWithPubInputs = tx.chonkProof.attachPublicInputs(tx.data.publicInputs().toFields());
+      const fieldsAsBuffers = proofWithPubInputs.fieldsWithPublicInputs.map(f => new Uint8Array(f.toBuffer()));
 
-      // Block below is almost copy-pasted from verifyProofForCircuit
-      const operation = async (bbWorkingDirectory: string) => {
-        const proofPath = path.join(bbWorkingDirectory, PROOF_FILENAME);
-        await writeChonkProofToPath(tx.chonkProof.attachPublicInputs(tx.data.publicInputs().toFields()), proofPath);
-
-        const verificationKeyPath = path.join(bbWorkingDirectory, VK_FILENAME);
-        const verificationKey = this.getVerificationKeyData(circuit);
-        await fs.writeFile(verificationKeyPath, verificationKey.keyAsBytes);
-
-        const timer = new Timer();
-        const result = await verifyChonkProof(
-          this.config.bbBinaryPath,
-          proofPath,
-          verificationKeyPath,
-          this.logger,
-          this.config.bbIVCConcurrency,
-        );
-        verificationDuration = timer.ms();
-
-        if (result.status === BB_RESULT.FAILURE) {
-          const errorMessage = `Failed to verify ${proofType} proof for ${circuit}!`;
-          throw new Error(errorMessage);
-        }
-
-        this.logger.debug(`${proofType} verification successful`, {
-          circuitName: mapProtocolArtifactNameToCircuitName(circuit),
-          duration: result.durationMs,
-          eventName: 'circuit-verification',
-          proofType: 'chonk',
-        } satisfies CircuitVerificationStats);
-      };
-      await runInDirectory(this.config.bbWorkingDirectory, operation, this.config.bbSkipCleanup, this.logger);
-      return { valid: true, durationMs: verificationDuration, totalDurationMs: totalTimer.ms() };
+      await using instance = await this.bbJsFactory.getInstance();
+      const { verified, durationMs } = await instance.verifyChonkProof(fieldsAsBuffers, verificationKey.keyAsBytes);
+
+      if (!verified) {
+        throw new Error(`Failed to verify ${proofType} proof for ${circuit}!`);
+      }
+
+      this.logger.debug(`${proofType} verification successful`, {
+        circuitName: mapProtocolArtifactNameToCircuitName(circuit),
+        duration: durationMs,
+        eventName: 'circuit-verification',
+        proofType: 'chonk',
+      } satisfies CircuitVerificationStats);
+
+      return { valid: true, durationMs, totalDurationMs: totalTimer.ms() };
     } catch (err) {
       this.logger.warn(`Failed to verify ${proofType} proof for tx ${tx.getTxHash().toString()}: ${String(err)}`);
       return { valid: false, durationMs: 0, totalDurationMs: 0 };
     }
   }
 }
+
+/** Split a buffer into 32-byte Uint8Array field elements. */
+function splitBufferToFieldArrays(buffer: Buffer): Uint8Array[] {
+  const fields: Uint8Array[] = [];
+  for (let i = 0; i < buffer.length; i += 32) {
+    fields.push(new Uint8Array(buffer.subarray(i, i + 32)));
+  }
+  return fields;
+}

package/src/verifier/index.ts

@@ -1,2 +1,3 @@
+export * from './batch_chonk_verifier.js';
 export * from './bb_verifier.js';
 export * from './queued_chonk_verifier.js';

package/src/verifier/queued_chonk_verifier.ts

@@ -16,8 +16,6 @@ import {
 
 import { createHistogram } from 'node:perf_hooks';
 
-import type { BBConfig } from '../config.js';
-
 class IVCVerifierMetrics {
   private ivcVerificationHistogram: Histogram;
   private ivcTotalVerificationHistogram: Histogram;
@@ -86,15 +84,15 @@ export class QueuedIVCVerifier implements ClientProtocolCircuitVerifier {
   private metrics: IVCVerifierMetrics;
 
   public constructor(
-    config: BBConfig,
     private verifier: ClientProtocolCircuitVerifier,
+    concurrency: number,
     private telemetry: TelemetryClient = getTelemetryClient(),
     private logger = createLogger('bb-prover:queued_chonk_verifier'),
   ) {
     this.metrics = new IVCVerifierMetrics(this.telemetry, 'QueuedIVCVerifier');
     this.queue = new SerialQueue();
-    this.logger.info(`Starting QueuedIVCVerifier with ${config.numConcurrentIVCVerifiers} concurrent verifiers`);
-    this.queue.start(config.numConcurrentIVCVerifiers);
+    this.logger.info(`Starting QueuedIVCVerifier with ${concurrency} concurrent verifiers`);
+    this.queue.start(concurrency);
   }
 
   public async verifyProof(tx: Tx): Promise<IVCProofVerificationResult> {
@@ -103,7 +101,8 @@ export class QueuedIVCVerifier implements ClientProtocolCircuitVerifier {
     return result;
   }
 
-  stop(): Promise<void> {
-    return this.queue.end();
+  async stop(): Promise<void> {
+    await this.queue.end();
+    await this.verifier.stop();
   }
 }