@aztec/bb-prover 0.0.1-commit.b2a5d0dd1 → 0.0.1-commit.b3d3157a

package/dest/verifier/batch_chonk_verifier.js

@@ -6,19 +6,21 @@ import { Timer } from '@aztec/foundation/timer';
 import { ProtocolCircuitVks } from '@aztec/noir-protocol-circuits-types/server/vks';
 import { Unpackr } from 'msgpackr';
 import { execFile } from 'node:child_process';
-import { unlinkSync } from 'node:fs';
-import { unlink } from 'node:fs/promises';
+import { rmSync } from 'node:fs';
+import { mkdtemp, rm } from 'node:fs/promises';
 import * as os from 'node:os';
 import * as path from 'node:path';
 import { promisify } from 'node:util';
 const execFileAsync = promisify(execFile);
+const RESULT_TIMEOUT_MS = 5 * 60 * 1000;
+const STOP_DRAIN_TIMEOUT_MS = 5_000;
 /** Maps client protocol artifacts used for chonk verification to VK indices. */ const CHONK_VK_ARTIFACTS = [
     'HidingKernelToRollup',
     'HidingKernelToPublic'
 ];
 /**
  * Batch verifier for Chonk IVC proofs. Uses the bb batch verifier service
- * which batches IPA verification into a single SRS MSM for better throughput.
+ * which batches IPA verification into a constant number of SRS MSMs for better throughput.
  *
  * Architecture:
  * - Spawns a persistent `bb msgpack run` process via Barretenberg (native backend)
@@ -31,6 +33,7 @@ const execFileAsync = promisify(execFile);
     batchSize;
     label;
     bb;
+    fifoDir;
     fifoPath;
     nextRequestId;
     pendingRequests;
@@ -39,17 +42,22 @@ const execFileAsync = promisify(execFile);
     logger;
     /** Maps artifact name to VK index in the batch verifier. */ vkIndexMap;
     /** Bound cleanup handler for process exit signals. */ exitCleanup;
+    stopped;
+    fatalError;
+    pendingDrainedResolvers;
     constructor(config, vkBuffers, batchSize, label){
         this.config = config;
         this.vkBuffers = vkBuffers;
         this.batchSize = batchSize;
         this.label = label;
+        this.fifoPath = '';
         this.nextRequestId = 0;
         this.pendingRequests = new Map();
         this.logger = createLogger('bb-prover:batch_chonk_verifier');
         this.vkIndexMap = new Map();
         this.exitCleanup = null;
-        this.fifoPath = path.join(os.tmpdir(), `bb-batch-${label}-${process.pid}-${Date.now()}.fifo`);
+        this.stopped = false;
+        this.pendingDrainedResolvers = new Set();
         this.fifoReader = new FifoFrameReader();
         this.sendQueue = new SerialQueue();
         this.sendQueue.start(1);
@@ -80,47 +88,91 @@ const execFileAsync = promisify(execFile);
     }
     async start() {
         this.logger.info('Starting BatchChonkVerifier');
-        this.bb = await Barretenberg.new({
-            bbPath: this.config.bbBinaryPath,
-            backend: BackendType.NativeUnixSocket
-        });
-        await this.bb.initSRSChonk();
-        await execFileAsync('mkfifo', [
-            this.fifoPath
-        ]);
-        this.registerExitCleanup();
-        await this.bb.chonkBatchVerifierStart({
-            vks: this.vkBuffers,
-            numCores: this.config.bbChonkVerifyConcurrency || 0,
-            batchSize: this.batchSize,
-            fifoPath: this.fifoPath
-        });
-        this.startFifoReader();
+        try {
+            this.bb = await Barretenberg.new({
+                bbPath: this.config.bbBinaryPath,
+                backend: BackendType.NativeUnixSocket
+            });
+            await this.bb.initSRSChonk();
+            // Keep the FIFO in a private directory so cleanup has a single owner.
+            this.fifoDir = await mkdtemp(path.join(os.tmpdir(), `bb-batch-${this.label}-${process.pid}-`));
+            this.fifoPath = path.join(this.fifoDir, 'results.fifo');
+            await execFileAsync('mkfifo', [
+                this.fifoPath
+            ]);
+            this.registerExitCleanup();
+            this.startFifoReader();
+            await this.bb.chonkBatchVerifierStart({
+                vks: this.vkBuffers,
+                numCores: this.config.bbChonkVerifyConcurrency || 0,
+                batchSize: this.batchSize,
+                fifoPath: this.fifoPath
+            });
+        } catch (err) {
+            this.fifoReader.stop();
+            this.deregisterExitCleanup();
+            await this.cleanupFifo();
+            await this.bb?.destroy().catch(()=>{});
+            throw err;
+        }
         this.logger.info('BatchChonkVerifier started', {
             fifoPath: this.fifoPath
         });
     }
     verifyProof(tx) {
-        const circuit = tx.data.forPublic ? 'HidingKernelToPublic' : 'HidingKernelToRollup';
-        const vkIndex = this.vkIndexMap.get(circuit);
-        if (vkIndex === undefined) {
-            throw new Error(`No VK index for circuit ${circuit}`);
-        }
-        const proofWithPubInputs = tx.chonkProof.attachPublicInputs(tx.data.publicInputs().toFields());
-        const proofFields = proofWithPubInputs.fieldsWithPublicInputs.map((f)=>f.toBuffer());
-        return this.enqueueProof(vkIndex, proofFields);
+        const totalTimer = new Timer();
+        return (async ()=>{
+            const circuit = tx.data.forPublic ? 'HidingKernelToPublic' : 'HidingKernelToRollup';
+            const vkIndex = this.vkIndexMap.get(circuit);
+            if (vkIndex === undefined) {
+                throw new Error(`No VK index for circuit ${circuit}`);
+            }
+            const proofWithPubInputs = tx.chonkProof.attachPublicInputs(tx.data.publicInputs().toFields());
+            const proofFields = proofWithPubInputs.fieldsWithPublicInputs.map((f)=>f.toBuffer());
+            return await this.enqueueProof(vkIndex, proofFields);
+        })().catch((err)=>{
+            this.logger.warn(`Failed to verify Chonk proof for tx ${tx.getTxHash().toString()}: ${String(err)}`);
+            return {
+                valid: false,
+                durationMs: 0,
+                totalDurationMs: totalTimer.ms()
+            };
+        });
     }
     /** Enqueue raw proof fields for verification. Used directly by tests with custom VKs. */ enqueueProof(vkIndex, proofFields) {
+        if (this.stopped) {
+            return Promise.reject(new Error('BatchChonkVerifier stopped'));
+        }
+        if (this.fatalError) {
+            return Promise.reject(this.fatalError);
+        }
         const totalTimer = new Timer();
         const requestId = this.nextRequestId++;
         const resultPromise = new Promise((resolve, reject)=>{
+            const timeout = setTimeout(()=>{
+                const pending = this.pendingRequests.get(requestId);
+                if (!pending) {
+                    return;
+                }
+                this.pendingRequests.delete(requestId);
+                pending.reject(new Error(`BatchChonkVerifier result timed out for request_id=${requestId}`));
+                this.notifyPendingDrained();
+            }, RESULT_TIMEOUT_MS);
+            // A pending result timer must never keep the host process alive on its own (e.g. an
+            // orphaned request at process exit); the FIFO reader keeps the loop alive while results
+            // are genuinely awaited.
+            timeout.unref();
             this.pendingRequests.set(requestId, {
                 resolve,
                 reject,
-                totalTimer
+                totalTimer,
+                timeout
             });
         });
         void this.sendQueue.put(async ()=>{
+            if (this.fatalError) {
+                throw this.fatalError;
+            }
             await this.bb.chonkBatchVerifierQueue({
                 requestId,
                 vkIndex,
@@ -130,35 +182,62 @@ const execFileAsync = promisify(execFile);
             const pending = this.pendingRequests.get(requestId);
             if (pending) {
                 this.pendingRequests.delete(requestId);
+                clearTimeout(pending.timeout);
                 pending.reject(err instanceof Error ? err : new Error(String(err)));
+                this.notifyPendingDrained();
             }
         });
         return resultPromise;
     }
     async stop() {
         this.logger.info('Stopping BatchChonkVerifier');
-        // Stop accepting new proofs
-        await this.sendQueue.end();
-        // Stop the bb service (flushes remaining proofs)
+        this.stopped = true;
         try {
-            await this.bb.chonkBatchVerifierStop({});
+            // Stop accepting new proofs and flush the send queue. Bound it so an unresponsive
+            // native process can't block teardown of our own event-loop handles indefinitely.
+            await this.withTimeout(this.sendQueue.end(), STOP_DRAIN_TIMEOUT_MS, 'send queue flush');
+            // Stop the bb service (flushes remaining proofs).
+            await this.withTimeout(this.bb.chonkBatchVerifierStop({}), STOP_DRAIN_TIMEOUT_MS, 'chonkBatchVerifierStop');
+            // Native stop flushes callbacks; keep the FIFO open until those frames are observed.
+            const drained = await this.waitForPendingRequestsToDrain(STOP_DRAIN_TIMEOUT_MS);
+            if (!drained) {
+                this.rejectPendingRequests(new Error('Timed out waiting for BatchChonkVerifier results during stop'));
+            }
         } catch (err) {
-            this.logger.warn(`Error stopping batch verifier service: ${err}`);
-        }
-        // Stop FIFO reader
-        this.fifoReader.stop();
-        // Clean up FIFO file and deregister exit handler
-        await unlink(this.fifoPath).catch(()=>{});
-        this.deregisterExitCleanup();
-        // Reject any remaining pending requests
-        for (const [id, pending] of this.pendingRequests){
-            pending.reject(new Error('BatchChonkVerifier stopped'));
-            this.pendingRequests.delete(id);
+            this.logger.warn(`Error during BatchChonkVerifier graceful stop: ${err}`);
+            this.rejectPendingRequests(err instanceof Error ? err : new Error(String(err)));
+        } finally{
+            // Always release our own event-loop handles — the FIFO read stream (a blocking
+            // threadpool read that can't be unref'd), the unix socket, the native process, and the
+            // exit handler — so the host process exits cleanly even if the native backend is wedged.
+            this.fifoReader.stop();
+            this.deregisterExitCleanup();
+            await this.cleanupFifo();
+            await this.bb.destroy().catch((err)=>this.logger.warn(`Error destroying bb backend during stop: ${err}`));
         }
-        // Destroy bb process
-        await this.bb.destroy();
         this.logger.info('BatchChonkVerifier stopped');
     }
+    /**
+   * Races a promise against a timeout so a wedged native backend can't block teardown. The
+   * timer is unref'd so it never keeps the process alive; the underlying promise stays handled
+   * by the race even if the timeout wins, so it cannot surface as an unhandled rejection.
+   */ async withTimeout(promise, timeoutMs, label) {
+        let timer;
+        const timeout = new Promise((_, reject)=>{
+            timer = setTimeout(()=>reject(new Error(`BatchChonkVerifier ${label} timed out after ${timeoutMs}ms`)), timeoutMs);
+            timer.unref();
+        });
+        try {
+            return await Promise.race([
+                promise,
+                timeout
+            ]);
+        } finally{
+            if (timer) {
+                clearTimeout(timer);
+            }
+        }
+    }
     startFifoReader() {
         const unpackr = new Unpackr({
             useRecords: false
@@ -169,16 +248,18 @@ const execFileAsync = promisify(execFile);
                 this.handleResult(result);
             } catch (err) {
                 this.logger.error(`FIFO: failed to decode msgpack result: ${err}`);
+                // A corrupt result stream cannot safely be matched to outstanding requests.
+                this.failVerifier(err instanceof Error ? err : new Error(String(err)));
             }
         });
         this.fifoReader.on('error', (err)=>{
             this.logger.error(`FIFO reader error: ${err}`);
+            this.failVerifier(err);
         });
         this.fifoReader.on('end', ()=>{
             this.logger.debug('FIFO reader: stream ended');
-            for (const [id, pending] of this.pendingRequests){
-                pending.reject(new Error('FIFO stream ended unexpectedly'));
-                this.pendingRequests.delete(id);
+            if (!this.stopped) {
+                this.failVerifier(new Error('FIFO stream ended unexpectedly'));
             }
         });
         this.fifoReader.start(this.fifoPath);
@@ -190,6 +271,7 @@ const execFileAsync = promisify(execFile);
             return;
         }
         this.pendingRequests.delete(result.request_id);
+        clearTimeout(pending.timeout);
         const valid = result.status === 0; // VerifyStatus::OK
         const durationMs = result.time_in_verify_ms;
         const totalDurationMs = pending.totalTimer.ms();
@@ -208,25 +290,95 @@ const execFileAsync = promisify(execFile);
             });
         }
         pending.resolve(ivcResult);
+        this.notifyPendingDrained();
     }
     registerExitCleanup() {
-        // Signal handlers must be synchronous — unlinkSync is intentional here
         this.exitCleanup = ()=>{
-            try {
-                unlinkSync(this.fifoPath);
-            } catch  {
-            /* ignore */ }
+            this.cleanupFifoSync();
         };
         process.on('exit', this.exitCleanup);
-        process.on('SIGINT', this.exitCleanup);
-        process.on('SIGTERM', this.exitCleanup);
     }
     deregisterExitCleanup() {
         if (this.exitCleanup) {
             process.removeListener('exit', this.exitCleanup);
-            process.removeListener('SIGINT', this.exitCleanup);
-            process.removeListener('SIGTERM', this.exitCleanup);
             this.exitCleanup = null;
         }
     }
+    rejectPendingRequests(error) {
+        for (const [id, pending] of Array.from(this.pendingRequests)){
+            pending.reject(error);
+            clearTimeout(pending.timeout);
+            this.pendingRequests.delete(id);
+        }
+        this.notifyPendingDrained();
+    }
+    failVerifier(error) {
+        if (!this.fatalError) {
+            this.fatalError = error;
+        }
+        this.rejectPendingRequests(error);
+    }
+    waitForPendingRequestsToDrain(timeoutMs) {
+        if (this.pendingRequests.size === 0) {
+            return Promise.resolve(true);
+        }
+        let timeout;
+        let onDrain;
+        const drained = new Promise((resolve)=>{
+            onDrain = ()=>resolve(true);
+            this.pendingDrainedResolvers.add(onDrain);
+        });
+        const timedOut = new Promise((resolve)=>{
+            timeout = setTimeout(()=>resolve(false), timeoutMs);
+            timeout.unref();
+        });
+        return Promise.race([
+            drained,
+            timedOut
+        ]).finally(()=>{
+            if (timeout) {
+                clearTimeout(timeout);
+            }
+            if (onDrain) {
+                this.pendingDrainedResolvers.delete(onDrain);
+            }
+        });
+    }
+    notifyPendingDrained() {
+        if (this.pendingRequests.size > 0) {
+            return;
+        }
+        for (const resolve of Array.from(this.pendingDrainedResolvers)){
+            resolve();
+        }
+    }
+    async cleanupFifo() {
+        if (this.fifoDir) {
+            await rm(this.fifoDir, {
+                recursive: true,
+                force: true
+            }).catch(()=>{});
+        } else if (this.fifoPath) {
+            await rm(this.fifoPath, {
+                force: true
+            }).catch(()=>{});
+        }
+        this.fifoDir = undefined;
+        this.fifoPath = '';
+    }
+    cleanupFifoSync() {
+        try {
+            if (this.fifoDir) {
+                rmSync(this.fifoDir, {
+                    recursive: true,
+                    force: true
+                });
+            } else if (this.fifoPath) {
+                rmSync(this.fifoPath, {
+                    force: true
+                });
+            }
+        } catch  {
+        /* ignore */ }
+    }
 }

package/dest/verifier/bb_verifier.d.ts

@@ -8,11 +8,14 @@ import type { BBConfig } from '../config.js';
 export declare class BBCircuitVerifier implements ClientProtocolCircuitVerifier {
     private config;
     private logger;
+    private bbJsFactory;
     private constructor();
     stop(): Promise<void>;
     static new(config: BBConfig, logger?: Logger): Promise<BBCircuitVerifier>;
     getVerificationKeyData(circuit: ProtocolArtifact): VerificationKeyData;
+    /** Verify an UltraHonk proof via bb.js API (no temp files). */
     verifyProofForCircuit(circuit: ServerProtocolArtifact, proof: Proof): Promise<void>;
+    /** Verify a Chonk (IVC) proof from a transaction via bb.js API. */
     verifyProof(tx: Tx): Promise<IVCProofVerificationResult>;
 }
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYmJfdmVyaWZpZXIuZC50cyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbIi4uLy4uL3NyYy92ZXJpZmllci9iYl92ZXJpZmllci50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFDQSxPQUFPLEVBQUUsS0FBSyxNQUFNLEVBQWdCLE1BQU0sdUJBQXVCLENBQUM7QUFHbEUsT0FBTyxFQUVMLEtBQUssZ0JBQWdCLEVBQ3JCLEtBQUssc0JBQXNCLEVBRTVCLE1BQU0sMkNBQTJDLENBQUM7QUFDbkQsT0FBTyxLQUFLLEVBQUUsNkJBQTZCLEVBQUUsMEJBQTBCLEVBQUUsTUFBTSxpQ0FBaUMsQ0FBQztBQUNqSCxPQUFPLEtBQUssRUFBRSxLQUFLLEVBQUUsTUFBTSxzQkFBc0IsQ0FBQztBQUVsRCxPQUFPLEVBQUUsRUFBRSxFQUFFLE1BQU0sa0JBQWtCLENBQUM7QUFDdEMsT0FBTyxLQUFLLEVBQUUsbUJBQW1CLEVBQUUsTUFBTSxtQkFBbUIsQ0FBQztBQWE3RCxPQUFPLEtBQUssRUFBRSxRQUFRLEVBQUUsTUFBTSxjQUFjLENBQUM7QUFJN0MscUJBQWEsaUJBQWtCLFlBQVcsNkJBQTZCO0lBRW5FLE9BQU8sQ0FBQyxNQUFNO0lBQ2QsT0FBTyxDQUFDLE1BQU07SUFGaEIsT0FBTyxlQUdIO0lBRUcsSUFBSSxJQUFJLE9BQU8sQ0FBQyxJQUFJLENBQUMsQ0FFM0I7SUFFRCxPQUFvQixHQUFHLENBQUMsTUFBTSxFQUFFLFFBQVEsRUFBRSxNQUFNLFNBQXFDLDhCQU1wRjtJQUVNLHNCQUFzQixDQUFDLE9BQU8sRUFBRSxnQkFBZ0IsR0FBRyxtQkFBbUIsQ0FNNUU7SUFFWSxxQkFBcUIsQ0FBQyxPQUFPLEVBQUUsc0JBQXNCLEVBQUUsS0FBSyxFQUFFLEtBQUssaUJBbUMvRTtJQUVZLFdBQVcsQ0FBQyxFQUFFLEVBQUUsRUFBRSxHQUFHLE9BQU8sQ0FBQywwQkFBMEIsQ0FBQyxDQTZDcEU7Q0FDRiJ9
+//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYmJfdmVyaWZpZXIuZC50cyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbIi4uLy4uL3NyYy92ZXJpZmllci9iYl92ZXJpZmllci50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEVBQUUsS0FBSyxNQUFNLEVBQWdCLE1BQU0sdUJBQXVCLENBQUM7QUFHbEUsT0FBTyxFQUVMLEtBQUssZ0JBQWdCLEVBQ3JCLEtBQUssc0JBQXNCLEVBRTVCLE1BQU0sMkNBQTJDLENBQUM7QUFDbkQsT0FBTyxLQUFLLEVBQUUsNkJBQTZCLEVBQUUsMEJBQTBCLEVBQUUsTUFBTSxpQ0FBaUMsQ0FBQztBQUNqSCxPQUFPLEtBQUssRUFBRSxLQUFLLEVBQUUsTUFBTSxzQkFBc0IsQ0FBQztBQUVsRCxPQUFPLEVBQUUsRUFBRSxFQUFFLE1BQU0sa0JBQWtCLENBQUM7QUFDdEMsT0FBTyxLQUFLLEVBQUUsbUJBQW1CLEVBQUUsTUFBTSxtQkFBbUIsQ0FBQztBQUs3RCxPQUFPLEtBQUssRUFBRSxRQUFRLEVBQUUsTUFBTSxjQUFjLENBQUM7QUFHN0MscUJBQWEsaUJBQWtCLFlBQVcsNkJBQTZCO0lBSW5FLE9BQU8sQ0FBQyxNQUFNO0lBQ2QsT0FBTyxDQUFDLE1BQU07SUFKaEIsT0FBTyxDQUFDLFdBQVcsQ0FBYztJQUVqQyxPQUFPLGVBV047SUFFTSxJQUFJLElBQUksT0FBTyxDQUFDLElBQUksQ0FBQyxDQUUzQjtJQUVELE9BQW9CLEdBQUcsQ0FBQyxNQUFNLEVBQUUsUUFBUSxFQUFFLE1BQU0sU0FBcUMsOEJBTXBGO0lBRU0sc0JBQXNCLENBQUMsT0FBTyxFQUFFLGdCQUFnQixHQUFHLG1CQUFtQixDQU01RTtJQUVELCtEQUErRDtJQUNsRCxxQkFBcUIsQ0FBQyxPQUFPLEVBQUUsc0JBQXNCLEVBQUUsS0FBSyxFQUFFLEtBQUssaUJBNEIvRTtJQUVELG1FQUFtRTtJQUN0RCxXQUFXLENBQUMsRUFBRSxFQUFFLEVBQUUsR0FBRyxPQUFPLENBQUMsMEJBQTBCLENBQUMsQ0ErQnBFO0NBQ0YifQ==

package/dest/verifier/bb_verifier.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"bb_verifier.d.ts","sourceRoot":"","sources":["../../src/verifier/bb_verifier.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,KAAK,MAAM,EAAgB,MAAM,uBAAuB,CAAC;AAGlE,OAAO,EAEL,KAAK,gBAAgB,EACrB,KAAK,sBAAsB,EAE5B,MAAM,2CAA2C,CAAC;AACnD,OAAO,KAAK,EAAE,6BAA6B,EAAE,0BAA0B,EAAE,MAAM,iCAAiC,CAAC;AACjH,OAAO,KAAK,EAAE,KAAK,EAAE,MAAM,sBAAsB,CAAC;AAElD,OAAO,EAAE,EAAE,EAAE,MAAM,kBAAkB,CAAC;AACtC,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,mBAAmB,CAAC;AAa7D,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,cAAc,CAAC;AAI7C,qBAAa,iBAAkB,YAAW,6BAA6B;IAEnE,OAAO,CAAC,MAAM;IACd,OAAO,CAAC,MAAM;IAFhB,OAAO,eAGH;IAEG,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC,CAE3B;IAED,OAAoB,GAAG,CAAC,MAAM,EAAE,QAAQ,EAAE,MAAM,SAAqC,8BAMpF;IAEM,sBAAsB,CAAC,OAAO,EAAE,gBAAgB,GAAG,mBAAmB,CAM5E;IAEY,qBAAqB,CAAC,OAAO,EAAE,sBAAsB,EAAE,KAAK,EAAE,KAAK,iBAmC/E;IAEY,WAAW,CAAC,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC,0BAA0B,CAAC,CA6CpE;CACF"}
+{"version":3,"file":"bb_verifier.d.ts","sourceRoot":"","sources":["../../src/verifier/bb_verifier.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,MAAM,EAAgB,MAAM,uBAAuB,CAAC;AAGlE,OAAO,EAEL,KAAK,gBAAgB,EACrB,KAAK,sBAAsB,EAE5B,MAAM,2CAA2C,CAAC;AACnD,OAAO,KAAK,EAAE,6BAA6B,EAAE,0BAA0B,EAAE,MAAM,iCAAiC,CAAC;AACjH,OAAO,KAAK,EAAE,KAAK,EAAE,MAAM,sBAAsB,CAAC;AAElD,OAAO,EAAE,EAAE,EAAE,MAAM,kBAAkB,CAAC;AACtC,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,mBAAmB,CAAC;AAK7D,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,cAAc,CAAC;AAG7C,qBAAa,iBAAkB,YAAW,6BAA6B;IAInE,OAAO,CAAC,MAAM;IACd,OAAO,CAAC,MAAM;IAJhB,OAAO,CAAC,WAAW,CAAc;IAEjC,OAAO,eAWN;IAEM,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC,CAE3B;IAED,OAAoB,GAAG,CAAC,MAAM,EAAE,QAAQ,EAAE,MAAM,SAAqC,8BAMpF;IAEM,sBAAsB,CAAC,OAAO,EAAE,gBAAgB,GAAG,mBAAmB,CAM5E;IAED,+DAA+D;IAClD,qBAAqB,CAAC,OAAO,EAAE,sBAAsB,EAAE,KAAK,EAAE,KAAK,iBA4B/E;IAED,mEAAmE;IACtD,WAAW,CAAC,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC,0BAA0B,CAAC,CA+BpE;CACF"}

package/dest/verifier/bb_verifier.js

@@ -1,22 +1,92 @@
-import { runInDirectory } from '@aztec/foundation/fs';
+function _ts_add_disposable_resource(env, value, async) {
+    if (value !== null && value !== void 0) {
+        if (typeof value !== "object" && typeof value !== "function") throw new TypeError("Object expected.");
+        var dispose, inner;
+        if (async) {
+            if (!Symbol.asyncDispose) throw new TypeError("Symbol.asyncDispose is not defined.");
+            dispose = value[Symbol.asyncDispose];
+        }
+        if (dispose === void 0) {
+            if (!Symbol.dispose) throw new TypeError("Symbol.dispose is not defined.");
+            dispose = value[Symbol.dispose];
+            if (async) inner = dispose;
+        }
+        if (typeof dispose !== "function") throw new TypeError("Object not disposable.");
+        if (inner) dispose = function() {
+            try {
+                inner.call(this);
+            } catch (e) {
+                return Promise.reject(e);
+            }
+        };
+        env.stack.push({
+            value: value,
+            dispose: dispose,
+            async: async
+        });
+    } else if (async) {
+        env.stack.push({
+            async: true
+        });
+    }
+    return value;
+}
+function _ts_dispose_resources(env) {
+    var _SuppressedError = typeof SuppressedError === "function" ? SuppressedError : function(error, suppressed, message) {
+        var e = new Error(message);
+        return e.name = "SuppressedError", e.error = error, e.suppressed = suppressed, e;
+    };
+    return (_ts_dispose_resources = function _ts_dispose_resources(env) {
+        function fail(e) {
+            env.error = env.hasError ? new _SuppressedError(e, env.error, "An error was suppressed during disposal.") : e;
+            env.hasError = true;
+        }
+        var r, s = 0;
+        function next() {
+            while(r = env.stack.pop()){
+                try {
+                    if (!r.async && s === 1) return s = 0, env.stack.push(r), Promise.resolve().then(next);
+                    if (r.dispose) {
+                        var result = r.dispose.call(r.value);
+                        if (r.async) return s |= 2, Promise.resolve(result).then(next, function(e) {
+                            fail(e);
+                            return next();
+                        });
+                    } else s |= 1;
+                } catch (e) {
+                    fail(e);
+                }
+            }
+            if (s === 1) return env.hasError ? Promise.reject(env.error) : Promise.resolve();
+            if (env.hasError) throw env.error;
+        }
+        return next();
+    })(env);
+}
 import { createLogger } from '@aztec/foundation/log';
 import { Timer } from '@aztec/foundation/timer';
 import { ProtocolCircuitVks } from '@aztec/noir-protocol-circuits-types/server/vks';
 import { mapProtocolArtifactNameToCircuitName } from '@aztec/noir-protocol-circuits-types/types';
 import { promises as fs } from 'fs';
-import * as path from 'path';
-import { BB_RESULT, PROOF_FILENAME, PUBLIC_INPUTS_FILENAME, VK_FILENAME, verifyChonkProof, verifyProof } from '../bb/execute.js';
+import { BBJsFactory } from '../bb/bb_js_backend.js';
 import { getUltraHonkFlavorForCircuit } from '../honk.js';
-import { writeChonkProofToPath } from '../prover/proof_utils.js';
 export class BBCircuitVerifier {
     config;
     logger;
+    bbJsFactory;
     constructor(config, logger){
         this.config = config;
         this.logger = logger;
+        // BB_NUM_IVC_VERIFIERS bounds the number of long-lived bb processes the pool keeps alive.
+        // If 0, fall back to spawning a fresh bb per verification.
+        this.bbJsFactory = new BBJsFactory(config.bbBinaryPath, {
+            poolSize: config.numConcurrentIVCVerifiers > 0 ? config.numConcurrentIVCVerifiers : undefined,
+            logger,
+            debugDir: config.bbDebugOutputDir
+        });
     }
     stop() {
-        return Promise.resolve();
+        return this.bbJsFactory.destroy();
     }
     static async new(config, logger = createLogger('bb-prover:verifier')) {
         if (!config.bbWorkingDirectory) {
@@ -34,64 +104,76 @@ export class BBCircuitVerifier {
         }
         return vk;
     }
-    async verifyProofForCircuit(circuit, proof) {
-        const operation = async (bbWorkingDirectory)=>{
-            const publicInputsFileName = path.join(bbWorkingDirectory, PUBLIC_INPUTS_FILENAME);
-            const proofFileName = path.join(bbWorkingDirectory, PROOF_FILENAME);
-            const verificationKeyPath = path.join(bbWorkingDirectory, VK_FILENAME);
+    /** Verify an UltraHonk proof via bb.js API (no temp files). */ async verifyProofForCircuit(circuit, proof) {
+        const env = {
+            stack: [],
+            error: void 0,
+            hasError: false
+        };
+        try {
             const verificationKey = this.getVerificationKeyData(circuit);
+            const flavor = getUltraHonkFlavorForCircuit(circuit);
             this.logger.debug(`${circuit} Verifying with key: ${verificationKey.keyAsFields.hash.toString()}`);
-            // TODO(https://github.com/AztecProtocol/aztec-packages/issues/13189): Put this proof parsing logic in the proof class.
-            await fs.writeFile(publicInputsFileName, proof.buffer.slice(0, proof.numPublicInputs * 32));
-            await fs.writeFile(proofFileName, proof.buffer.slice(proof.numPublicInputs * 32));
-            await fs.writeFile(verificationKeyPath, verificationKey.keyAsBytes);
-            const result = await verifyProof(this.config.bbBinaryPath, proofFileName, verificationKeyPath, getUltraHonkFlavorForCircuit(circuit), this.logger);
-            if (result.status === BB_RESULT.FAILURE) {
-                const errorMessage = `Failed to verify ${circuit} proof!`;
-                throw new Error(errorMessage);
+            // Split proof buffer into public input fields and proof fields (32-byte each)
+            const publicInputFields = splitBufferToFieldArrays(proof.buffer.subarray(0, proof.numPublicInputs * 32));
+            const proofFields = splitBufferToFieldArrays(proof.buffer.subarray(proof.numPublicInputs * 32));
+            const instance = _ts_add_disposable_resource(env, await this.bbJsFactory.getInstance(), true);
+            const { verified, durationMs } = await instance.verifyProof(proofFields, verificationKey.keyAsBytes, publicInputFields, flavor);
+            if (!verified) {
+                throw new Error(`Failed to verify ${circuit} proof!`);
             }
             this.logger.debug(`${circuit} verification successful`, {
                 circuitName: mapProtocolArtifactNameToCircuitName(circuit),
-                duration: result.durationMs,
+                duration: durationMs,
                 eventName: 'circuit-verification',
                 proofType: 'ultra-honk'
             });
-        };
-        await runInDirectory(this.config.bbWorkingDirectory, operation, this.config.bbSkipCleanup, this.logger);
+        } catch (e) {
+            env.error = e;
+            env.hasError = true;
+        } finally{
+            const result = _ts_dispose_resources(env);
+            if (result) await result;
+        }
     }
-    async verifyProof(tx) {
+    /** Verify a Chonk (IVC) proof from a transaction via bb.js API. */ async verifyProof(tx) {
         const proofType = 'Chonk';
         try {
-            const totalTimer = new Timer();
-            let verificationDuration = 0;
-            const circuit = tx.data.forPublic ? 'HidingKernelToPublic' : 'HidingKernelToRollup';
-            // Block below is almost copy-pasted from verifyProofForCircuit
-            const operation = async (bbWorkingDirectory)=>{
-                const proofPath = path.join(bbWorkingDirectory, PROOF_FILENAME);
-                await writeChonkProofToPath(tx.chonkProof.attachPublicInputs(tx.data.publicInputs().toFields()), proofPath);
-                const verificationKeyPath = path.join(bbWorkingDirectory, VK_FILENAME);
+            const env = {
+                stack: [],
+                error: void 0,
+                hasError: false
+            };
+            try {
+                const totalTimer = new Timer();
+                const circuit = tx.data.forPublic ? 'HidingKernelToPublic' : 'HidingKernelToRollup';
                 const verificationKey = this.getVerificationKeyData(circuit);
-                await fs.writeFile(verificationKeyPath, verificationKey.keyAsBytes);
-                const timer = new Timer();
-                const result = await verifyChonkProof(this.config.bbBinaryPath, proofPath, verificationKeyPath, this.logger, this.config.bbIVCConcurrency);
-                verificationDuration = timer.ms();
-                if (result.status === BB_RESULT.FAILURE) {
-                    const errorMessage = `Failed to verify ${proofType} proof for ${circuit}!`;
-                    throw new Error(errorMessage);
+                // Reconstruct the full proof with public inputs prepended, then convert Fr[] to Uint8Array[]
+                const proofWithPubInputs = tx.chonkProof.attachPublicInputs(tx.data.publicInputs().toFields());
+                const fieldsAsBuffers = proofWithPubInputs.fieldsWithPublicInputs.map((f)=>new Uint8Array(f.toBuffer()));
+                const instance = _ts_add_disposable_resource(env, await this.bbJsFactory.getInstance(), true);
+                const { verified, durationMs } = await instance.verifyChonkProof(fieldsAsBuffers, verificationKey.keyAsBytes);
+                if (!verified) {
+                    throw new Error(`Failed to verify ${proofType} proof for ${circuit}!`);
                 }
                 this.logger.debug(`${proofType} verification successful`, {
                     circuitName: mapProtocolArtifactNameToCircuitName(circuit),
-                    duration: result.durationMs,
+                    duration: durationMs,
                     eventName: 'circuit-verification',
                     proofType: 'chonk'
                 });
-            };
-            await runInDirectory(this.config.bbWorkingDirectory, operation, this.config.bbSkipCleanup, this.logger);
-            return {
-                valid: true,
-                durationMs: verificationDuration,
-                totalDurationMs: totalTimer.ms()
-            };
+                return {
+                    valid: true,
+                    durationMs,
+                    totalDurationMs: totalTimer.ms()
+                };
+            } catch (e) {
+                env.error = e;
+                env.hasError = true;
+            } finally{
+                const result = _ts_dispose_resources(env);
+                if (result) await result;
+            }
         } catch (err) {
             this.logger.warn(`Failed to verify ${proofType} proof for tx ${tx.getTxHash().toString()}: ${String(err)}`);
             return {
@@ -102,3 +184,10 @@ export class BBCircuitVerifier {
         }
     }
 }
+/** Split a buffer into 32-byte Uint8Array field elements. */ function splitBufferToFieldArrays(buffer) {
+    const fields = [];
+    for(let i = 0; i < buffer.length; i += 32){
+        fields.push(new Uint8Array(buffer.subarray(i, i + 32)));
+    }
+    return fields;
+}