@aztec/aztec-node 0.0.1-commit.42ee6df9b → 0.0.1-commit.431c48d

package/src/sentinel/config.ts

@@ -2,8 +2,9 @@ import { type ConfigMappingsType, booleanConfigHelper, numberConfigHelper } from
 
 export type SentinelConfig = {
   sentinelHistoryLengthInEpochs: number;
-  sentinelHistoricProvenPerformanceLengthInEpochs: number;
+  sentinelHistoricEpochPerformanceLengthInEpochs: number;
   sentinelEnabled: boolean;
+  sentinelEpochEndBufferSlots: number;
 };
 
 export const sentinelConfigMappings: ConfigMappingsType<SentinelConfig> = {
@@ -13,8 +14,9 @@ export const sentinelConfigMappings: ConfigMappingsType<SentinelConfig> = {
     ...numberConfigHelper(24),
   },
   /**
-   * The number of L2 epochs kept of proven performance history for each validator.
-   * This value must be large enough so that we have proven performance for every validator
+   * The number of L2 epochs kept of per-epoch performance history for each validator. End-of-epoch
+   * activity is recorded here and used to decide consecutive-epoch inactivity slashing.
+   * This value must be large enough so that we have epoch performance for every validator
    * for at least slashInactivityConsecutiveEpochThreshold. Assuming this value is 3,
    * and the committee size is 48, and we have 10k validators, then we pick 48 out of 10k each draw.
    * For any fixed element, per-draw prob = 48/10000 = 0.0048.
@@ -24,9 +26,9 @@ export const sentinelConfigMappings: ConfigMappingsType<SentinelConfig> = {
    * - 95% chance: n = 1310
    * - 99% chance: n = 1749
    */
-  sentinelHistoricProvenPerformanceLengthInEpochs: {
-    description: 'The number of L2 epochs kept of proven performance history for each validator.',
-    env: 'SENTINEL_HISTORIC_PROVEN_PERFORMANCE_LENGTH_IN_EPOCHS',
+  sentinelHistoricEpochPerformanceLengthInEpochs: {
+    description: 'The number of L2 epochs kept of per-epoch performance history for each validator.',
+    env: 'SENTINEL_HISTORIC_EPOCH_PERFORMANCE_LENGTH_IN_EPOCHS',
     ...numberConfigHelper(2000),
   },
   sentinelEnabled: {
@@ -34,4 +36,14 @@ export const sentinelConfigMappings: ConfigMappingsType<SentinelConfig> = {
     env: 'SENTINEL_ENABLED',
     ...booleanConfigHelper(false),
   },
+  /**
+   * Number of L2 slots to wait after the end of an epoch before computing the epoch's performance.
+   * The buffer allows P2P attestations and the local archiver to settle. Higher values reduce the
+   * risk of misjudging late-arriving activity at the cost of delayed slashing.
+   */
+  sentinelEpochEndBufferSlots: {
+    description: 'Number of L2 slots after the end of an epoch before the sentinel evaluates it.',
+    env: 'SENTINEL_EPOCH_END_BUFFER_SLOTS',
+    ...numberConfigHelper(2),
+  },
 };

package/src/sentinel/factory.ts

@@ -3,7 +3,9 @@ import { createLogger } from '@aztec/foundation/log';
 import { createStore } from '@aztec/kv-store/lmdb-v2';
 import type { P2PClient } from '@aztec/p2p';
 import type { L2BlockSource } from '@aztec/stdlib/block';
-import type { SlasherConfig } from '@aztec/stdlib/interfaces/server';
+import type { CheckpointReexecutionTracker } from '@aztec/stdlib/checkpoint';
+import type { ChainConfig } from '@aztec/stdlib/config';
+import type { SlasherConfig, ValidatorClientConfig } from '@aztec/stdlib/interfaces/server';
 import type { DataStoreConfig } from '@aztec/stdlib/kv-store';
 
 import type { SentinelConfig } from './config.js';
@@ -14,18 +16,31 @@ export async function createSentinel(
   epochCache: EpochCache,
   archiver: L2BlockSource,
   p2p: P2PClient,
-  config: SentinelConfig & DataStoreConfig & SlasherConfig,
+  reexecutionTracker: CheckpointReexecutionTracker,
+  config: SentinelConfig &
+    DataStoreConfig &
+    SlasherConfig &
+    Pick<ChainConfig, 'l1ChainId' | 'rollupAddress'> &
+    Pick<ValidatorClientConfig, 'disableValidator'>,
   logger = createLogger('node:sentinel'),
 ): Promise<Sentinel | undefined> {
-  if (!config.sentinelEnabled) {
+  const runsValidator = !config.disableValidator;
+  if (!runsValidator && !config.sentinelEnabled) {
+    logger.verbose('Sentinel is disabled');
     return undefined;
   }
+  if (runsValidator) {
+    logger.info('Enabling sentinel since this node runs a validator');
+  } else {
+    logger.info('Enabling sentinel from SENTINEL_ENABLED configuration');
+  }
+
   const kvStore = await createStore('sentinel', SentinelStore.SCHEMA_VERSION, config, logger.getBindings());
   const storeHistoryLength = config.sentinelHistoryLengthInEpochs * epochCache.getL1Constants().epochDuration;
-  const storeHistoricProvenPerformanceLength = config.sentinelHistoricProvenPerformanceLengthInEpochs;
+  const storeHistoricEpochPerformanceLength = config.sentinelHistoricEpochPerformanceLengthInEpochs;
   const sentinelStore = new SentinelStore(kvStore, {
     historyLength: storeHistoryLength,
-    historicProvenPerformanceLength: storeHistoricProvenPerformanceLength,
+    historicEpochPerformanceLength: storeHistoricEpochPerformanceLength,
   });
-  return new Sentinel(epochCache, archiver, p2p, sentinelStore, config, logger);
+  return new Sentinel(epochCache, archiver, p2p, sentinelStore, reexecutionTracker, config, logger);
 }