@aztec/archiver 0.0.1-commit.f5d02921e → 0.0.1-commit.f7ea82942

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (71) hide show
  1. package/README.md +12 -6
  2. package/dest/archiver.d.ts +5 -3
  3. package/dest/archiver.d.ts.map +1 -1
  4. package/dest/archiver.js +15 -4
  5. package/dest/config.d.ts +3 -1
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +13 -2
  8. package/dest/errors.d.ts +17 -1
  9. package/dest/errors.d.ts.map +1 -1
  10. package/dest/errors.js +22 -0
  11. package/dest/factory.d.ts +1 -1
  12. package/dest/factory.d.ts.map +1 -1
  13. package/dest/factory.js +2 -1
  14. package/dest/index.d.ts +3 -2
  15. package/dest/index.d.ts.map +1 -1
  16. package/dest/index.js +2 -1
  17. package/dest/l1/data_retrieval.d.ts +19 -10
  18. package/dest/l1/data_retrieval.d.ts.map +1 -1
  19. package/dest/l1/data_retrieval.js +25 -32
  20. package/dest/l1/validate_historical_logs.d.ts +23 -0
  21. package/dest/l1/validate_historical_logs.d.ts.map +1 -0
  22. package/dest/l1/validate_historical_logs.js +108 -0
  23. package/dest/modules/data_store_updater.d.ts +12 -5
  24. package/dest/modules/data_store_updater.d.ts.map +1 -1
  25. package/dest/modules/data_store_updater.js +13 -3
  26. package/dest/modules/instrumentation.d.ts +7 -2
  27. package/dest/modules/instrumentation.d.ts.map +1 -1
  28. package/dest/modules/instrumentation.js +22 -6
  29. package/dest/modules/l1_synchronizer.d.ts +6 -2
  30. package/dest/modules/l1_synchronizer.d.ts.map +1 -1
  31. package/dest/modules/l1_synchronizer.js +213 -124
  32. package/dest/store/block_store.d.ts +11 -3
  33. package/dest/store/block_store.d.ts.map +1 -1
  34. package/dest/store/block_store.js +88 -6
  35. package/dest/store/kv_archiver_store.d.ts +11 -9
  36. package/dest/store/kv_archiver_store.d.ts.map +1 -1
  37. package/dest/store/kv_archiver_store.js +9 -7
  38. package/dest/store/l2_tips_cache.d.ts +1 -1
  39. package/dest/store/l2_tips_cache.d.ts.map +1 -1
  40. package/dest/store/l2_tips_cache.js +2 -2
  41. package/dest/store/log_store.d.ts +1 -1
  42. package/dest/store/log_store.d.ts.map +1 -1
  43. package/dest/store/log_store.js +2 -4
  44. package/dest/store/message_store.d.ts +3 -3
  45. package/dest/store/message_store.d.ts.map +1 -1
  46. package/dest/store/message_store.js +9 -10
  47. package/dest/test/fake_l1_state.d.ts +14 -3
  48. package/dest/test/fake_l1_state.d.ts.map +1 -1
  49. package/dest/test/fake_l1_state.js +55 -10
  50. package/dest/test/noop_l1_archiver.d.ts +1 -1
  51. package/dest/test/noop_l1_archiver.d.ts.map +1 -1
  52. package/dest/test/noop_l1_archiver.js +4 -2
  53. package/package.json +13 -13
  54. package/src/archiver.ts +28 -6
  55. package/src/config.ts +14 -1
  56. package/src/errors.ts +34 -0
  57. package/src/factory.ts +1 -0
  58. package/src/index.ts +2 -1
  59. package/src/l1/data_retrieval.ts +36 -45
  60. package/src/l1/validate_historical_logs.ts +140 -0
  61. package/src/modules/data_store_updater.ts +27 -3
  62. package/src/modules/instrumentation.ts +27 -7
  63. package/src/modules/l1_synchronizer.ts +274 -148
  64. package/src/store/block_store.ts +112 -4
  65. package/src/store/kv_archiver_store.ts +18 -10
  66. package/src/store/l2_tips_cache.ts +8 -2
  67. package/src/store/log_store.ts +2 -5
  68. package/src/store/message_store.ts +10 -12
  69. package/src/structs/inbox_message.ts +1 -1
  70. package/src/test/fake_l1_state.ts +75 -13
  71. package/src/test/noop_l1_archiver.ts +3 -1
@@ -1,33 +1,38 @@
1
1
  import type { BlobClientInterface } from '@aztec/blob-client/client';
2
2
  import { EpochCache } from '@aztec/epoch-cache';
3
- import { InboxContract, RollupContract } from '@aztec/ethereum/contracts';
3
+ import { InboxContract, type InboxContractState, RollupContract } from '@aztec/ethereum/contracts';
4
4
  import type { L1BlockId } from '@aztec/ethereum/l1-types';
5
+ import { getFinalizedL1Block } from '@aztec/ethereum/queries';
5
6
  import type { ViemPublicClient, ViemPublicDebugClient } from '@aztec/ethereum/types';
6
7
  import { asyncPool } from '@aztec/foundation/async-pool';
7
8
  import { maxBigint } from '@aztec/foundation/bigint';
8
9
  import { BlockNumber, CheckpointNumber, EpochNumber } from '@aztec/foundation/branded-types';
9
10
  import { Buffer16, Buffer32 } from '@aztec/foundation/buffer';
10
- import { pick } from '@aztec/foundation/collection';
11
+ import { partition, pick } from '@aztec/foundation/collection';
11
12
  import { Fr } from '@aztec/foundation/curves/bn254';
12
13
  import { type Logger, createLogger } from '@aztec/foundation/log';
14
+ import { retryTimes } from '@aztec/foundation/retry';
13
15
  import { count } from '@aztec/foundation/string';
14
16
  import { DateProvider, Timer, elapsed } from '@aztec/foundation/timer';
15
- import { isDefined } from '@aztec/foundation/types';
17
+ import { isDefined, isErrorClass } from '@aztec/foundation/types';
16
18
  import { type ArchiverEmitter, L2BlockSourceEvents, type ValidateCheckpointResult } from '@aztec/stdlib/block';
17
- import { PublishedCheckpoint } from '@aztec/stdlib/checkpoint';
19
+ import { Checkpoint, PublishedCheckpoint } from '@aztec/stdlib/checkpoint';
18
20
  import { type L1RollupConstants, getEpochAtSlot, getSlotAtNextL1Block } from '@aztec/stdlib/epoch-helpers';
19
21
  import { computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
20
22
  import { type Traceable, type Tracer, execInSpan, trackSpan } from '@aztec/telemetry-client';
21
23
 
22
24
  import { InitialCheckpointNumberNotSequentialError } from '../errors.js';
23
25
  import {
24
- retrieveCheckpointsFromRollup,
26
+ type RetrievedCheckpointFromCalldata,
27
+ getCheckpointBlobDataFromBlobs,
28
+ retrieveCheckpointCalldataFromRollup,
25
29
  retrieveL1ToL2Message,
26
30
  retrieveL1ToL2Messages,
27
31
  retrievedToPublishedCheckpoint,
28
32
  } from '../l1/data_retrieval.js';
29
33
  import type { KVArchiverDataStore } from '../store/kv_archiver_store.js';
30
34
  import type { L2TipsCache } from '../store/l2_tips_cache.js';
35
+ import { MessageStoreError } from '../store/message_store.js';
31
36
  import type { InboxMessage } from '../structs/inbox_message.js';
32
37
  import { ArchiverDataStoreUpdater } from './data_store_updater.js';
33
38
  import type { ArchiverInstrumentation } from './instrumentation.js';
@@ -64,6 +69,7 @@ export class ArchiverL1Synchronizer implements Traceable {
64
69
  private config: {
65
70
  batchSize: number;
66
71
  skipValidateCheckpointAttestations?: boolean;
72
+ skipPromoteProposedCheckpointDuringL1Sync?: boolean;
67
73
  maxAllowedEthClientDriftSeconds: number;
68
74
  },
69
75
  private readonly blobClient: BlobClientInterface,
@@ -89,6 +95,7 @@ export class ArchiverL1Synchronizer implements Traceable {
89
95
  public setConfig(newConfig: {
90
96
  batchSize: number;
91
97
  skipValidateCheckpointAttestations?: boolean;
98
+ skipPromoteProposedCheckpointDuringL1Sync?: boolean;
92
99
  maxAllowedEthClientDriftSeconds: number;
93
100
  }) {
94
101
  this.config = newConfig;
@@ -121,10 +128,15 @@ export class ArchiverL1Synchronizer implements Traceable {
121
128
 
122
129
  @trackSpan('Archiver.syncFromL1')
123
130
  public async syncFromL1(initialSyncComplete: boolean): Promise<void> {
131
+ // In between the various calls to L1, the block number can move meaning some of the following
132
+ // calls will return data for blocks that were not present during earlier calls. To combat this
133
+ // we ensure that all data retrieval methods only retrieve data up to the currentBlockNumber
134
+ // captured at the top of this function.
124
135
  const currentL1Block = await this.publicClient.getBlock({ includeTransactions: false });
125
136
  const currentL1BlockNumber = currentL1Block.number;
126
137
  const currentL1BlockHash = Buffer32.fromString(currentL1Block.hash);
127
138
  const currentL1Timestamp = currentL1Block.timestamp;
139
+ const currentL1BlockData = { l1BlockNumber: currentL1BlockNumber, l1BlockHash: currentL1BlockHash };
128
140
 
129
141
  if (this.l1BlockHash && currentL1BlockHash.equals(this.l1BlockHash)) {
130
142
  this.log.trace(`No new L1 blocks since last sync at L1 block ${this.l1BlockNumber}`);
@@ -141,45 +153,15 @@ export class ArchiverL1Synchronizer implements Traceable {
141
153
  );
142
154
  }
143
155
 
144
- // Load sync point for blocks and messages defaulting to start block
145
- const {
146
- blocksSynchedTo = this.l1Constants.l1StartBlock,
147
- messagesSynchedTo = {
148
- l1BlockNumber: this.l1Constants.l1StartBlock,
149
- l1BlockHash: this.l1Constants.l1StartBlockHash,
150
- },
151
- } = await this.store.getSynchPoint();
156
+ // Load sync point for blocks defaulting to start block
157
+ const { blocksSynchedTo = this.l1Constants.l1StartBlock } = await this.store.getSynchPoint();
158
+ this.log.debug(`Starting new archiver sync iteration`, { blocksSynchedTo, currentL1BlockData });
152
159
 
153
- this.log.debug(`Starting new archiver sync iteration`, {
154
- blocksSynchedTo,
155
- messagesSynchedTo,
156
- currentL1BlockNumber,
157
- currentL1BlockHash,
158
- });
160
+ // Sync L1 to L2 messages. We retry this a few times since there are error conditions that reset the sync point, requiring a new iteration.
161
+ // Note that we cannot just wait for the l1 synchronizer to loop again, since the synchronizer would report as synced up to the current L1
162
+ // block, when that wouldn't be the case, since L1 to L2 messages would need another iteration.
163
+ await retryTimes(() => this.handleL1ToL2Messages(currentL1BlockData), 'Handling L1 to L2 messages', 3, 0.1);
159
164
 
160
- // ********** Ensuring Consistency of data pulled from L1 **********
161
-
162
- /**
163
- * There are a number of calls in this sync operation to L1 for retrieving
164
- * events and transaction data. There are a couple of things we need to bear in mind
165
- * to ensure that data is read exactly once.
166
- *
167
- * The first is the problem of eventually consistent ETH service providers like Infura.
168
- * Each L1 read operation will query data from the last L1 block that it saw emit its kind of data.
169
- * (so pending L1 to L2 messages will read from the last L1 block that emitted a message and so on)
170
- * This will mean the archiver will lag behind L1 and will only advance when there's L2-relevant activity on the chain.
171
- *
172
- * The second is that in between the various calls to L1, the block number can move meaning some
173
- * of the following calls will return data for blocks that were not present during earlier calls.
174
- * To combat this for the time being we simply ensure that all data retrieval methods only retrieve
175
- * data up to the currentBlockNumber captured at the top of this function. We might want to improve on this
176
- * in future but for the time being it should give us the guarantees that we need
177
- */
178
-
179
- // ********** Events that are processed per L1 block **********
180
- await this.handleL1ToL2Messages(messagesSynchedTo, currentL1BlockNumber);
181
-
182
- // ********** Events that are processed per checkpoint **********
183
165
  if (currentL1BlockNumber > blocksSynchedTo) {
184
166
  // First we retrieve new checkpoints and L2 blocks and store them in the DB. This will also update the
185
167
  // pending chain validation status, proven checkpoint number, and synched L1 block number.
@@ -238,7 +220,11 @@ export class ArchiverL1Synchronizer implements Traceable {
238
220
  /** Query L1 for its finalized block and update the finalized checkpoint accordingly. */
239
221
  private async updateFinalizedCheckpoint(): Promise<void> {
240
222
  try {
241
- const finalizedL1Block = await this.publicClient.getBlock({ blockTag: 'finalized', includeTransactions: false });
223
+ const finalizedL1Block = await getFinalizedL1Block(this.publicClient);
224
+ if (!finalizedL1Block) {
225
+ this.log.trace(`Skipping finalized checkpoint update: L1 has no finalized block yet.`);
226
+ return;
227
+ }
242
228
  const finalizedL1BlockNumber = finalizedL1Block.number;
243
229
  const finalizedCheckpointNumber = await this.rollup.getProvenCheckpointNumber({
244
230
  blockNumber: finalizedL1BlockNumber,
@@ -290,6 +276,7 @@ export class ArchiverL1Synchronizer implements Traceable {
290
276
  `Pruning blocks after block ${lastCheckpointedBlockNumber} due to slot ${firstUncheckpointedBlockSlot} not being checkpointed`,
291
277
  { firstUncheckpointedBlockHeader: firstUncheckpointedBlockHeader.toInspect(), slotAtNextL1Block },
292
278
  );
279
+
293
280
  const prunedBlocks = await this.updater.removeUncheckpointedBlocksAfter(lastCheckpointedBlockNumber);
294
281
 
295
282
  if (prunedBlocks.length > 0) {
@@ -391,64 +378,87 @@ export class ArchiverL1Synchronizer implements Traceable {
391
378
  }
392
379
 
393
380
  @trackSpan('Archiver.handleL1ToL2Messages')
394
- private async handleL1ToL2Messages(messagesSyncPoint: L1BlockId, currentL1BlockNumber: bigint): Promise<void> {
395
- this.log.trace(`Handling L1 to L2 messages from ${messagesSyncPoint.l1BlockNumber} to ${currentL1BlockNumber}.`);
396
- if (currentL1BlockNumber <= messagesSyncPoint.l1BlockNumber) {
397
- return;
381
+ private async handleL1ToL2Messages(currentL1Block: L1BlockId): Promise<boolean> {
382
+ // Load the syncpoint, which may have been updated in a previous iteration
383
+ const {
384
+ messagesSynchedTo = {
385
+ l1BlockNumber: this.l1Constants.l1StartBlock,
386
+ l1BlockHash: this.l1Constants.l1StartBlockHash,
387
+ },
388
+ } = await this.store.getSynchPoint();
389
+
390
+ // Nothing to do if L1 block number has not moved forward
391
+ const currentL1BlockNumber = currentL1Block.l1BlockNumber;
392
+ if (currentL1BlockNumber <= messagesSynchedTo.l1BlockNumber) {
393
+ return true;
398
394
  }
399
395
 
400
- // Load remote and local inbox states.
401
- const localMessagesInserted = await this.store.getTotalL1ToL2MessageCount();
402
- const localLastMessage = await this.store.getLastL1ToL2Message();
396
+ // Compare local message store state with the remote. If they match, we just advance the match pointer.
403
397
  const remoteMessagesState = await this.inbox.getState({ blockNumber: currentL1BlockNumber });
404
- await this.store.setInboxTreeInProgress(remoteMessagesState.treeInProgress);
398
+ const localLastMessage = await this.store.getLastL1ToL2Message();
399
+ if (await this.localStateMatches(localLastMessage, remoteMessagesState)) {
400
+ this.log.trace(`Local L1 to L2 messages are already in sync with remote at L1 block ${currentL1BlockNumber}`);
401
+ await this.store.setMessageSyncState(currentL1Block, remoteMessagesState.treeInProgress);
402
+ return true;
403
+ }
405
404
 
406
- this.log.trace(`Retrieved remote inbox state at L1 block ${currentL1BlockNumber}.`, {
407
- localMessagesInserted,
408
- localLastMessage,
409
- remoteMessagesState,
410
- });
405
+ // If not, then we are out of sync. Most likely there are new messages on the inbox, so we try retrieving them.
406
+ // However, it could also be the case that there was an L1 reorg and our syncpoint is no longer valid.
407
+ // If that's the case, we'd get an exception out of the message store since the rolling hash of the first message
408
+ // we try to insert would not match the one in the db, in which case we rollback to the last common message with L1.
409
+ try {
410
+ await this.retrieveAndStoreMessages(messagesSynchedTo.l1BlockNumber, currentL1BlockNumber);
411
+ } catch (error) {
412
+ if (isErrorClass(error, MessageStoreError)) {
413
+ this.log.warn(
414
+ `Failed to store L1 to L2 messages retrieved from L1: ${error.message}. Rolling back syncpoint to retry.`,
415
+ { inboxMessage: error.inboxMessage },
416
+ );
417
+ await this.rollbackL1ToL2Messages(remoteMessagesState);
418
+ return false;
419
+ }
420
+ throw error;
421
+ }
411
422
 
412
- // Compare message count and rolling hash. If they match, no need to retrieve anything.
413
- if (
414
- remoteMessagesState.totalMessagesInserted === localMessagesInserted &&
415
- remoteMessagesState.messagesRollingHash.equals(localLastMessage?.rollingHash ?? Buffer16.ZERO)
416
- ) {
417
- this.log.trace(
418
- `No L1 to L2 messages to query between L1 blocks ${messagesSyncPoint.l1BlockNumber} and ${currentL1BlockNumber}.`,
423
+ // Note that, if there are no new messages to insert, but there was an L1 reorg that pruned out last messages,
424
+ // we'd notice by comparing our local state with the remote one again, and seeing they don't match even after
425
+ // our sync attempt. In this case, we also rollback our syncpoint, and trigger a retry.
426
+ const localLastMessageAfterSync = await this.store.getLastL1ToL2Message();
427
+ if (!(await this.localStateMatches(localLastMessageAfterSync, remoteMessagesState))) {
428
+ this.log.warn(
429
+ `Local L1 to L2 messages state does not match remote after sync attempt. Rolling back syncpoint to retry.`,
430
+ { localLastMessageAfterSync, remoteMessagesState },
419
431
  );
420
- return;
432
+ await this.rollbackL1ToL2Messages(remoteMessagesState);
433
+ return false;
421
434
  }
422
435
 
423
- // Check if our syncpoint is still valid. If not, there was an L1 reorg and we need to re-retrieve messages.
424
- // Note that we need to fetch it from logs and not from inbox state at the syncpoint l1 block number, since it
425
- // could be older than 128 blocks and non-archive nodes cannot resolve it.
426
- if (localLastMessage) {
427
- const remoteLastMessage = await this.retrieveL1ToL2Message(localLastMessage.leaf);
428
- this.log.trace(`Retrieved remote message for local last`, { remoteLastMessage, localLastMessage });
429
- if (!remoteLastMessage || !remoteLastMessage.rollingHash.equals(localLastMessage.rollingHash)) {
430
- this.log.warn(`Rolling back L1 to L2 messages due to hash mismatch or msg not found.`, {
431
- remoteLastMessage,
432
- messagesSyncPoint,
433
- localLastMessage,
434
- });
436
+ // Advance the syncpoint after a successful sync
437
+ await this.store.setMessageSyncState(currentL1Block, remoteMessagesState.treeInProgress);
438
+ return true;
439
+ }
435
440
 
436
- messagesSyncPoint = await this.rollbackL1ToL2Messages(localLastMessage, messagesSyncPoint);
437
- this.log.debug(`Rolled back L1 to L2 messages to L1 block ${messagesSyncPoint.l1BlockNumber}.`, {
438
- messagesSyncPoint,
439
- });
440
- }
441
- }
441
+ /** Checks if the local rolling hash and message count matches the remote state */
442
+ private async localStateMatches(localLastMessage: InboxMessage | undefined, remoteState: InboxContractState) {
443
+ const localMessageCount = await this.store.getTotalL1ToL2MessageCount();
444
+ this.log.trace(`Comparing local and remote inbox state`, { localMessageCount, localLastMessage, remoteState });
442
445
 
443
- // Retrieve and save messages in batches. Each batch is estimated to acommodate up to L2 'blockBatchSize' blocks,
446
+ return (
447
+ remoteState.totalMessagesInserted === localMessageCount &&
448
+ remoteState.messagesRollingHash.equals(localLastMessage?.rollingHash ?? Buffer16.ZERO)
449
+ );
450
+ }
451
+
452
+ /** Retrieves L1 to L2 messages from L1 in batches and stores them. */
453
+ private async retrieveAndStoreMessages(fromL1Block: bigint, toL1Block: bigint): Promise<void> {
444
454
  let searchStartBlock: bigint = 0n;
445
- let searchEndBlock: bigint = messagesSyncPoint.l1BlockNumber;
455
+ let searchEndBlock: bigint = fromL1Block;
446
456
 
447
457
  let lastMessage: InboxMessage | undefined;
448
458
  let messageCount = 0;
449
459
 
450
460
  do {
451
- [searchStartBlock, searchEndBlock] = this.nextRange(searchEndBlock, currentL1BlockNumber);
461
+ [searchStartBlock, searchEndBlock] = this.nextRange(searchEndBlock, toL1Block);
452
462
  this.log.trace(`Retrieving L1 to L2 messages in L1 blocks ${searchStartBlock}-${searchEndBlock}`);
453
463
  const messages = await retrieveL1ToL2Messages(this.inbox, searchStartBlock, searchEndBlock);
454
464
  const timer = new Timer();
@@ -460,81 +470,86 @@ export class ArchiverL1Synchronizer implements Traceable {
460
470
  lastMessage = msg;
461
471
  messageCount++;
462
472
  }
463
- } while (searchEndBlock < currentL1BlockNumber);
473
+ } while (searchEndBlock < toL1Block);
464
474
 
465
- // Log stats for messages retrieved (if any).
466
475
  if (messageCount > 0) {
467
476
  this.log.info(
468
477
  `Retrieved ${messageCount} new L1 to L2 messages up to message with index ${lastMessage?.index} for checkpoint ${lastMessage?.checkpointNumber}`,
469
478
  { lastMessage, messageCount },
470
479
  );
471
480
  }
472
-
473
- // Warn if the resulting rolling hash does not match the remote state we had retrieved.
474
- if (lastMessage && !lastMessage.rollingHash.equals(remoteMessagesState.messagesRollingHash)) {
475
- this.log.warn(`Last message retrieved rolling hash does not match remote state.`, {
476
- lastMessage,
477
- remoteMessagesState,
478
- });
479
- }
480
481
  }
481
482
 
482
- private async retrieveL1ToL2Message(leaf: Fr): Promise<InboxMessage | undefined> {
483
- const currentL1BlockNumber = await this.publicClient.getBlockNumber();
484
- let searchStartBlock: bigint = 0n;
485
- let searchEndBlock: bigint = this.l1Constants.l1StartBlock - 1n;
486
-
487
- do {
488
- [searchStartBlock, searchEndBlock] = this.nextRange(searchEndBlock, currentL1BlockNumber);
483
+ /**
484
+ * Rolls back local L1 to L2 messages to the last common message with L1, and updates the syncpoint to the L1 block of that message.
485
+ * If no common message is found, rolls back all messages and sets the syncpoint to the start block.
486
+ */
487
+ private async rollbackL1ToL2Messages(remoteMessagesState: InboxContractState): Promise<L1BlockId> {
488
+ const { treeInProgress: remoteTreeInProgress, messagesRollingHash: remoteRollingHash } = remoteMessagesState;
489
489
 
490
- const message = await retrieveL1ToL2Message(this.inbox, leaf, searchStartBlock, searchEndBlock);
491
-
492
- if (message) {
493
- return message;
490
+ // Slowly go back through our messages until we find the last common message. We could query the logs in
491
+ // batch as an optimization, but the depth of the reorg should not be deep, and this is a very rare case,
492
+ // so it's fine to query one log at a time.
493
+ let commonMsg: undefined | InboxMessage;
494
+ let messagesToDelete = 0;
495
+ this.log.verbose(`Searching most recent common L1 to L2 message`);
496
+ for await (const localMsg of this.store.iterateL1ToL2Messages({ reverse: true })) {
497
+ const logCtx = { remoteMsg: undefined as InboxMessage | undefined, localMsg, remoteMessagesState };
498
+
499
+ // First check if the local message rolling hash matches the current rolling hash of the inbox contract,
500
+ // which means we just need to rollback some local messages and we should be back in sync. This means there
501
+ // was an L1 reorg that removed some of the messages we had, but no new messages were added compared.
502
+ if (localMsg.rollingHash.equals(remoteRollingHash)) {
503
+ this.log.info(
504
+ `Found common L1 to L2 message at index ${localMsg.index} on L1 block ${localMsg.l1BlockNumber} matching current remote state`,
505
+ logCtx,
506
+ );
507
+ commonMsg = localMsg;
508
+ break;
494
509
  }
495
- } while (searchEndBlock < currentL1BlockNumber);
496
510
 
497
- return undefined;
498
- }
499
-
500
- private async rollbackL1ToL2Messages(
501
- localLastMessage: InboxMessage,
502
- messagesSyncPoint: L1BlockId,
503
- ): Promise<L1BlockId> {
504
- // Slowly go back through our messages until we find the last common message.
505
- // We could query the logs in batch as an optimization, but the depth of the reorg should not be deep, and this
506
- // is a very rare case, so it's fine to query one log at a time.
507
- let commonMsg: undefined | InboxMessage;
508
- this.log.verbose(`Searching most recent common L1 to L2 message at or before index ${localLastMessage.index}`);
509
- for await (const msg of this.store.iterateL1ToL2Messages({ reverse: true, end: localLastMessage.index })) {
510
- const remoteMsg = await this.retrieveL1ToL2Message(msg.leaf);
511
- const logCtx = { remoteMsg, localMsg: msg };
512
- if (remoteMsg && remoteMsg.rollingHash.equals(msg.rollingHash)) {
513
- this.log.verbose(
514
- `Found most recent common L1 to L2 message at index ${msg.index} on L1 block ${msg.l1BlockNumber}`,
511
+ // If there's no match with the current remote state, check if the message exists on the inbox contract at all
512
+ // by looking at the inbox events. If the L1 reorg *added* new messages in addition to deleting existing ones,
513
+ // then the current remote state's rolling hash will not match anything we have locally, so we need to check existence
514
+ // of individual messages via logs. Note we use logs and not historical queries so we don't have to depend on
515
+ // an archival rpc node, since the message could be from a long time ago if we're catching up with syncing.
516
+ const remoteMsg = await retrieveL1ToL2Message(this.inbox, localMsg);
517
+ logCtx.remoteMsg = remoteMsg;
518
+ if (remoteMsg && remoteMsg.rollingHash.equals(localMsg.rollingHash)) {
519
+ this.log.info(
520
+ `Found most recent common L1 to L2 message at index ${localMsg.index} on L1 block ${localMsg.l1BlockNumber}`,
515
521
  logCtx,
516
522
  );
517
523
  commonMsg = remoteMsg;
518
524
  break;
519
525
  } else if (remoteMsg) {
520
- this.log.debug(`Local L1 to L2 message with index ${msg.index} has different rolling hash`, logCtx);
526
+ this.log.debug(`Local L1 to L2 message with index ${localMsg.index} has different rolling hash`, logCtx);
527
+ messagesToDelete++;
521
528
  } else {
522
- this.log.debug(`Local L1 to L2 message with index ${msg.index} not found on L1`, logCtx);
529
+ this.log.debug(`Local L1 to L2 message with index ${localMsg.index} not found on L1`, logCtx);
530
+ messagesToDelete++;
523
531
  }
524
532
  }
525
533
 
526
- // Delete everything after the common message we found.
527
- const lastGoodIndex = commonMsg?.index;
528
- this.log.warn(`Deleting all local L1 to L2 messages after index ${lastGoodIndex ?? 'undefined'}`);
529
- await this.store.removeL1ToL2Messages(lastGoodIndex !== undefined ? lastGoodIndex + 1n : 0n);
534
+ // Delete everything after the common message we found, if anything needs to be deleted.
535
+ // Do not exit early if there are no messages to delete, we still want to update the syncpoint.
536
+ if (messagesToDelete > 0) {
537
+ const lastGoodIndex = commonMsg?.index;
538
+ this.log.warn(`Rolling back all local L1 to L2 messages after index ${lastGoodIndex ?? 'initial'}`);
539
+ await this.store.removeL1ToL2Messages(lastGoodIndex !== undefined ? lastGoodIndex + 1n : 0n);
540
+ }
530
541
 
531
542
  // Update the syncpoint so the loop below reprocesses the changed messages. We go to the block before
532
543
  // the last common one, so we force reprocessing it, in case new messages were added on that same L1 block
533
544
  // after the last common message.
534
545
  const syncPointL1BlockNumber = commonMsg ? commonMsg.l1BlockNumber - 1n : this.l1Constants.l1StartBlock;
535
546
  const syncPointL1BlockHash = await this.getL1BlockHash(syncPointL1BlockNumber);
536
- messagesSyncPoint = { l1BlockNumber: syncPointL1BlockNumber, l1BlockHash: syncPointL1BlockHash };
537
- await this.store.setMessageSynchedL1Block(messagesSyncPoint);
547
+ const messagesSyncPoint = { l1BlockNumber: syncPointL1BlockNumber, l1BlockHash: syncPointL1BlockHash };
548
+ await this.store.setMessageSyncState(messagesSyncPoint, remoteTreeInProgress);
549
+ this.log.verbose(`Updated messages syncpoint to L1 block ${syncPointL1BlockNumber}`, {
550
+ ...messagesSyncPoint,
551
+ remoteTreeInProgress,
552
+ });
538
553
  return messagesSyncPoint;
539
554
  }
540
555
 
@@ -733,22 +748,20 @@ export class ArchiverL1Synchronizer implements Traceable {
733
748
 
734
749
  this.log.trace(`Retrieving checkpoints from L1 block ${searchStartBlock} to ${searchEndBlock}`);
735
750
 
736
- // TODO(md): Retrieve from blob client then from consensus client, then from peers
737
- const retrievedCheckpoints = await execInSpan(this.tracer, 'Archiver.retrieveCheckpointsFromRollup', () =>
738
- retrieveCheckpointsFromRollup(
751
+ // First fetch calldata only, no blobs yet, since we may be able to just get that data out of the proposed chain
752
+ const calldataCheckpoints = await execInSpan(this.tracer, 'Archiver.retrieveCheckpointCalldataFromRollup', () =>
753
+ retrieveCheckpointCalldataFromRollup(
739
754
  this.rollup,
740
755
  this.publicClient,
741
756
  this.debugClient,
742
- this.blobClient,
743
757
  searchStartBlock, // TODO(palla/reorg): If the L2 reorg was due to an L1 reorg, we need to start search earlier
744
758
  searchEndBlock,
745
759
  this.instrumentation,
746
760
  this.log,
747
- !initialSyncComplete, // isHistoricalSync
748
761
  ),
749
762
  );
750
763
 
751
- if (retrievedCheckpoints.length === 0) {
764
+ if (calldataCheckpoints.length === 0) {
752
765
  // We are not calling `setBlockSynchedL1BlockNumber` because it may cause sync issues if based off infura.
753
766
  // See further details in earlier comments.
754
767
  this.log.trace(`Retrieved no new checkpoints from L1 block ${searchStartBlock} to ${searchEndBlock}`);
@@ -756,17 +769,43 @@ export class ArchiverL1Synchronizer implements Traceable {
756
769
  }
757
770
 
758
771
  this.log.debug(
759
- `Retrieved ${retrievedCheckpoints.length} new checkpoints between L1 blocks ${searchStartBlock} and ${searchEndBlock}`,
772
+ `Retrieved ${calldataCheckpoints.length} new checkpoint calldata between L1 blocks ${searchStartBlock} and ${searchEndBlock}`,
760
773
  {
761
- lastProcessedCheckpoint: retrievedCheckpoints[retrievedCheckpoints.length - 1].l1,
774
+ lastProcessedCheckpoint: calldataCheckpoints[calldataCheckpoints.length - 1].l1,
762
775
  searchStartBlock,
763
776
  searchEndBlock,
764
777
  },
765
778
  );
766
779
 
767
- const publishedCheckpoints = await Promise.all(retrievedCheckpoints.map(b => retrievedToPublishedCheckpoint(b)));
780
+ // Check if the last checkpoint matches the proposed one (so we can skip blob fetch).
781
+ // We only check the last one because the proposed checkpoint is always the most recent one,
782
+ // and if it's in a multi-checkpoint batch it will always be last (sorted by L1 block number).
783
+ const lastCalldataCheckpoint = calldataCheckpoints[calldataCheckpoints.length - 1];
784
+ const checkpointToPromote = await this.tryBuildPublishedCheckpointFromProposed(lastCalldataCheckpoint);
785
+
786
+ // Then fetch blobs in parallel and build the full published checkpoints
787
+ const toFetchBlobs = checkpointToPromote ? calldataCheckpoints.slice(0, -1) : calldataCheckpoints;
788
+ const blobFetched = await asyncPool(10, toFetchBlobs, async checkpoint =>
789
+ retrievedToPublishedCheckpoint({
790
+ ...checkpoint,
791
+ checkpointBlobData: await getCheckpointBlobDataFromBlobs(
792
+ this.blobClient,
793
+ checkpoint.l1.blockHash,
794
+ checkpoint.blobHashes,
795
+ checkpoint.checkpointNumber,
796
+ this.log,
797
+ !initialSyncComplete,
798
+ checkpoint.parentBeaconBlockRoot,
799
+ checkpoint.l1.timestamp,
800
+ ),
801
+ }),
802
+ );
803
+
804
+ // And add the promoted checkpoint to the list of all checkpoints
805
+ const publishedCheckpoints = checkpointToPromote ? [...blobFetched, checkpointToPromote] : blobFetched;
768
806
  const validCheckpoints: PublishedCheckpoint[] = [];
769
807
 
808
+ // Now loop through all checkpoints and validate their attestations
770
809
  for (const published of publishedCheckpoints) {
771
810
  const validationResult = this.config.skipValidateCheckpointAttestations
772
811
  ? { valid: true as const }
@@ -847,15 +886,34 @@ export class ArchiverL1Synchronizer implements Traceable {
847
886
  try {
848
887
  const updatedValidationResult =
849
888
  rollupStatus.validationResult === initialValidationResult ? undefined : rollupStatus.validationResult;
889
+
890
+ // Split valid checkpoints: the promoted one (if any) is persisted via the proposed-promotion path,
891
+ // the rest via addCheckpoints. Both paths run within the same store transaction for atomicity.
892
+ const [[maybeValidCheckpointToPromote], checkpointsToAdd] = partition(
893
+ validCheckpoints,
894
+ c => c.checkpoint.number === checkpointToPromote?.checkpoint.number,
895
+ );
896
+
850
897
  const [processDuration, result] = await elapsed(() =>
851
898
  execInSpan(this.tracer, 'Archiver.addCheckpoints', () =>
852
- this.updater.addCheckpoints(validCheckpoints, updatedValidationResult),
899
+ this.updater.addCheckpoints(
900
+ checkpointsToAdd,
901
+ updatedValidationResult,
902
+ maybeValidCheckpointToPromote && {
903
+ l1: lastCalldataCheckpoint.l1,
904
+ attestations: lastCalldataCheckpoint.attestations,
905
+ checkpoint: maybeValidCheckpointToPromote,
906
+ },
907
+ ),
853
908
  ),
854
909
  );
855
- this.instrumentation.processNewBlocks(
856
- processDuration / validCheckpoints.length,
857
- validCheckpoints.flatMap(c => c.checkpoint.blocks),
858
- );
910
+
911
+ if (checkpointsToAdd.length > 0) {
912
+ this.instrumentation.processNewCheckpointedBlocks(
913
+ processDuration / checkpointsToAdd.length,
914
+ checkpointsToAdd.flatMap(c => c.checkpoint.blocks),
915
+ );
916
+ }
859
917
 
860
918
  // If blocks were pruned due to conflict with L1 checkpoints, emit event
861
919
  if (result.prunedBlocks && result.prunedBlocks.length > 0) {
@@ -908,7 +966,7 @@ export class ArchiverL1Synchronizer implements Traceable {
908
966
  });
909
967
  }
910
968
  lastRetrievedCheckpoint = validCheckpoints.at(-1) ?? lastRetrievedCheckpoint;
911
- lastL1BlockWithCheckpoint = retrievedCheckpoints.at(-1)?.l1.blockNumber ?? lastL1BlockWithCheckpoint;
969
+ lastL1BlockWithCheckpoint = calldataCheckpoints.at(-1)?.l1.blockNumber ?? lastL1BlockWithCheckpoint;
912
970
  } while (searchEndBlock < currentL1BlockNumber);
913
971
 
914
972
  // Important that we update AFTER inserting the blocks.
@@ -917,6 +975,74 @@ export class ArchiverL1Synchronizer implements Traceable {
917
975
  return { ...rollupStatus, lastRetrievedCheckpoint, lastL1BlockWithCheckpoint };
918
976
  }
919
977
 
978
+ /** Checks if this checkpoint matches the local proposed one, and if so, loads local data to build a synthetic published checkpoint. */
979
+ private async tryBuildPublishedCheckpointFromProposed(
980
+ calldataCheckpoint: RetrievedCheckpointFromCalldata | undefined,
981
+ ): Promise<PublishedCheckpoint | undefined> {
982
+ const proposed = await this.store.getProposedCheckpointOnly();
983
+ if (
984
+ this.config.skipPromoteProposedCheckpointDuringL1Sync ||
985
+ !proposed ||
986
+ !calldataCheckpoint ||
987
+ proposed.checkpointNumber !== calldataCheckpoint.checkpointNumber
988
+ ) {
989
+ return undefined;
990
+ }
991
+
992
+ if (
993
+ !proposed.header.equals(calldataCheckpoint.header) ||
994
+ !proposed.archive.root.equals(calldataCheckpoint.archiveRoot)
995
+ ) {
996
+ this.log.warn(
997
+ `Local proposed checkpoint ${proposed.checkpointNumber} does not match checkpoint retrieved from L1, overriding with L1 data`,
998
+ {
999
+ proposedCheckpointNumber: proposed.checkpointNumber,
1000
+ proposedHeader: proposed.header.toInspect(),
1001
+ proposedArchiveRoot: proposed.archive.root.toString(),
1002
+ calldataCheckpointNumber: calldataCheckpoint.checkpointNumber,
1003
+ calldataHeader: calldataCheckpoint.header.toInspect(),
1004
+ calldataArchiveRoot: calldataCheckpoint.archiveRoot.toString(),
1005
+ },
1006
+ );
1007
+ return undefined;
1008
+ }
1009
+
1010
+ this.log.debug(
1011
+ `Building published checkpoint from proposed ${calldataCheckpoint.checkpointNumber} (skipping blob fetch)`,
1012
+ { proposedHeader: proposed.header.toInspect(), proposedArchiveRoot: proposed.archive.root.toString() },
1013
+ );
1014
+
1015
+ const blocks = await this.store.getBlocks(BlockNumber(proposed.startBlock), proposed.blockCount);
1016
+ if (blocks.length !== proposed.blockCount) {
1017
+ this.log.warn(
1018
+ `Local proposed checkpoint ${proposed.checkpointNumber} has wrong block count (expected ${proposed.blockCount} blocks starting at ${proposed.startBlock} but got ${blocks.length})`,
1019
+ {
1020
+ proposedCheckpointNumber: proposed.checkpointNumber,
1021
+ proposedStartBlock: proposed.startBlock,
1022
+ proposedBlockCount: proposed.blockCount,
1023
+ retrievedBlocks: blocks.map(b => b.number),
1024
+ },
1025
+ );
1026
+ return undefined;
1027
+ }
1028
+
1029
+ const checkpoint = Checkpoint.from({
1030
+ archive: proposed.archive,
1031
+ header: proposed.header,
1032
+ blocks,
1033
+ number: proposed.checkpointNumber,
1034
+ feeAssetPriceModifier: proposed.feeAssetPriceModifier,
1035
+ });
1036
+ const promotedCheckpoint = PublishedCheckpoint.from({
1037
+ checkpoint,
1038
+ l1: calldataCheckpoint.l1,
1039
+ attestations: calldataCheckpoint.attestations,
1040
+ });
1041
+ this.instrumentation.processCheckpointPromoted();
1042
+
1043
+ return promotedCheckpoint;
1044
+ }
1045
+
920
1046
  private async checkForNewCheckpointsBeforeL1SyncPoint(
921
1047
  status: RollupStatus,
922
1048
  blocksSynchedTo: bigint,