@axiomatic-labs/claudeflow 2.13.55 → 2.13.56

package/lib/doctor.js

@@ -129,6 +129,54 @@ function checkStaleLockfiles(cwd) {
   };
 }
 
+// Read the browser-error-daemon observer state from its pidfile.
+// Returns { running, pid, lockfile } — running=true only when the pid is
+// alive AND the lockfile exists. Used by both doctor and panel.
+function readObserverState(cwd, cdpPort) {
+  const lockfile = path.join(cwd, '.claudeflow', 'tmp', `.browser-cdp-${cdpPort}.pid`);
+  let pid = null;
+  try {
+    pid = parseInt(fs.readFileSync(lockfile, 'utf8').trim(), 10);
+  } catch {
+    return { running: false, pid: null, lockfile };
+  }
+  if (!Number.isFinite(pid) || pid <= 0) return { running: false, pid, lockfile };
+  let alive = false;
+  try { process.kill(pid, 0); alive = true; } catch (e) { alive = e.code === 'EPERM'; }
+  return { running: alive, pid, lockfile };
+}
+
+// Surface as a doctor/panel issue when the browser-error-daemon observer
+// is stopped while Playwright is configured. The observer collects console
+// errors + network failures during headed browser verification — when it's
+// down, those signals are silently lost, so the agent may verify a flow
+// that has console errors and not know it.
+function checkObserverState(cwd) {
+  const mcpPath = path.join(cwd, '.mcp.json');
+  let cfg;
+  try { cfg = JSON.parse(fs.readFileSync(mcpPath, 'utf8')); }
+  catch { return { id: 'observer-state', severity: 'info', message: 'No .mcp.json — observer not applicable.' }; }
+  const hasPlaywright = cfg.mcpServers
+    && Object.keys(cfg.mcpServers).some((s) => s.toLowerCase().includes('playwright'));
+  if (!hasPlaywright) {
+    return { id: 'observer-state', severity: 'info', message: 'Playwright not configured — observer not applicable.' };
+  }
+  const observer = readObserverState(cwd, deriveCdpPort(cwd));
+  if (observer.running) {
+    return {
+      id: 'observer-state',
+      severity: 'ok',
+      message: `browser-error-daemon running (pid ${observer.pid}).`,
+    };
+  }
+  return {
+    id: 'observer-state',
+    severity: 'mismatch',
+    message: 'browser-error-daemon is STOPPED while Playwright is configured. Console errors / network failures from headed sessions are NOT being collected — the agent may verify a flow with console errors and miss them. The observer should auto-start at SessionStart via `.claude/hooks/SessionStart/browser-error-daemon.js`; if it keeps stopping, inspect that hook for crashes or check the pidfile at `.claudeflow/tmp/.browser-cdp-<port>.pid`.',
+    detail: [{ lockfile: observer.lockfile, pid: observer.pid }],
+  };
+}
+
 function applyStaleLockfileFix(check) {
   for (const { file } of check.fix.stale) {
     try { fs.unlinkSync(file); } catch {}
@@ -163,6 +211,7 @@ async function run(argv = []) {
   const checks = [
     checkCdpPortMismatch(cwd),
     checkStaleLockfiles(cwd),
+    checkObserverState(cwd),
   ];
 
   for (const check of checks) printCheck(check);
@@ -202,6 +251,8 @@ module.exports = run;
 module.exports.deriveCdpPort = deriveCdpPort;
 module.exports.checkCdpPortMismatch = checkCdpPortMismatch;
 module.exports.checkStaleLockfiles = checkStaleLockfiles;
+module.exports.checkObserverState = checkObserverState;
+module.exports.readObserverState = readObserverState;
 module.exports.readPlaywrightCdpEndpoint = readPlaywrightCdpEndpoint;
 module.exports.applyCdpPortFix = applyCdpPortFix;
 module.exports.applyStaleLockfileFix = applyStaleLockfileFix;

package/lib/panel.js

@@ -19,6 +19,8 @@ const {
   deriveCdpPort,
   checkCdpPortMismatch,
   checkStaleLockfiles,
+  checkObserverState,
+  readObserverState: readObserverStateFromDoctor,
   readPlaywrightCdpEndpoint,
 } = require('./doctor.js');
 const {
@@ -211,19 +213,10 @@ function getMcpInfo(cwd) {
   };
 }
 
-function readObserverState(cwd, cdpPort) {
-  const lockfile = path.join(cwd, '.claudeflow', 'tmp', `.browser-cdp-${cdpPort}.pid`);
-  let pid = null;
-  try {
-    pid = parseInt(fs.readFileSync(lockfile, 'utf8').trim(), 10);
-  } catch {
-    return { running: false, pid: null, lockfile };
-  }
-  if (!Number.isFinite(pid) || pid <= 0) return { running: false, pid, lockfile };
-  let alive = false;
-  try { process.kill(pid, 0); alive = true; } catch (e) { alive = e.code === 'EPERM'; }
-  return { running: alive, pid, lockfile };
-}
+// Re-export the canonical helper from doctor.js so panel callers keep the
+// same name. The implementation moved to doctor.js so both surfaces (CLI
+// doctor + panel) share a single source of truth.
+const readObserverState = readObserverStateFromDoctor;
 
 function getSetupContextInfo(cwd) {
   const p = path.join(cwd, '.claudeflow', 'config', 'setup-context.json');
@@ -524,7 +517,11 @@ function getLogsInfo(cwd) {
 }
 
 function getDoctorInfo(cwd) {
-  const checks = [checkCdpPortMismatch(cwd), checkStaleLockfiles(cwd)];
+  const checks = [
+    checkCdpPortMismatch(cwd),
+    checkStaleLockfiles(cwd),
+    checkObserverState(cwd),
+  ];
   const issues = checks.filter((c) => c.severity !== 'ok' && c.severity !== 'info');
   return {
     issueCount: issues.length,
@@ -872,7 +869,15 @@ function severityFor(id) {
       if (s.logs.latestReminderStatus === 'heavy') return 'warn';
       return s.logs.total > 0 ? 'ok' : 'info';
     }
-    case 'mcp':      return !s.mcp.configFound ? 'info' : (s.mcp.playwright.match && s.mcp.staleLockfiles.length === 0 ? 'ok' : 'warn');
+    case 'mcp': {
+      if (!s.mcp.configFound) return 'info';
+      const playwrightOk = s.mcp.playwright.match && s.mcp.staleLockfiles.length === 0;
+      // Observer stopped while Playwright is configured = warn. Console errors
+      // and network failures from headed sessions are silently lost when the
+      // observer is down.
+      const observerOk = !s.mcp.playwright.match || (s.mcp.observer && s.mcp.observer.running);
+      return playwrightOk && observerOk ? 'ok' : 'warn';
+    }
     case 'setupContext': return !s.setupContext.exists ? 'err' : (s.setupContext.toolingComplete ? 'ok' : 'warn');
     case 'activeRun': return s.activeRun.active ? 'info' : 'info';
     case 'doctor':   return s.doctor.issueCount > 0 ? 'warn' : 'ok';
@@ -1294,7 +1299,7 @@ function renderMcp() {
       \${row('Playwright --cdp-endpoint port', String(m.playwright.configured || 'n/a'))}
       \${row('Computed port (from path)', String(m.playwright.computed))}
       \${row('Match', m.playwright.match ? 'YES' : 'NO', { kind: m.playwright.match ? 'ok' : 'err', text: m.playwright.match ? '✓' : '✗' })}
-      \${row('Observer', m.observer.running ? 'running (pid '+m.observer.pid+')' : 'stopped', { kind: m.observer.running ? 'ok' : 'info', text: m.observer.running ? '✓' : '·' })}
+      \${row('Observer', m.observer.running ? 'running (pid '+m.observer.pid+')' : 'STOPPED — browser errors NOT being collected', { kind: m.observer.running ? 'ok' : (m.playwright.match ? 'warn' : 'info'), text: m.observer.running ? '✓' : (m.playwright.match ? '⚠' : '·') })}
     </div>
     <h2 style="margin-top:18px">Stale lockfiles</h2>
     \${lockfiles}\`;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@axiomatic-labs/claudeflow",
-  "version": "2.13.55",
+  "version": "2.13.56",
   "description": "Claudeflow — AI-powered development toolkit for Claude Code. Skills, agents, hooks, and quality gates that ship production apps.",
   "bin": {
     "claudeflow": "./bin/cli.js"