@axiom-lattice/pg-stores 4.0.0 → 4.0.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@axiom-lattice/pg-stores",
-  "version": "4.0.0",
+  "version": "4.0.1",
   "description": "PG stores implementation for Axiom Lattice framework",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -25,7 +25,7 @@
     "@langchain/core": "1.1.30",
     "pg": "^8.16.3",
     "uuid": "^9.0.1",
-    "@axiom-lattice/core": "10.0.0",
+    "@axiom-lattice/core": "10.0.1",
     "@axiom-lattice/protocols": "6.0.0"
   },
   "devDependencies": {

package/src/PGVectorStoreProvider.ts

@@ -9,7 +9,11 @@ import { Pool } from "pg";
 import { PGVectorStore } from "@langchain/community/vectorstores/pgvector";
 import { Document } from "@langchain/core/documents";
 import { embeddingsLatticeManager } from "@axiom-lattice/core";
-import type { VectorStoreProvider, VectorStoreCreateParams } from "@axiom-lattice/protocols";
+import {
+  EMBEDDING_DEFAULT_KEY,
+  type VectorStoreProvider,
+  type VectorStoreCreateParams,
+} from "@axiom-lattice/protocols";
 import type { DocumentInterface } from "@langchain/core/documents";
 
 function safeTableName(name: string): string {
@@ -31,15 +35,22 @@ export class PGVectorStoreProvider implements VectorStoreProvider {
   async create(params: VectorStoreCreateParams): Promise<any> {
     const { tableName, embeddingKey } = params;
     const tenantId = params.tenantId ?? "default";
+    const requestedKey = embeddingKey || EMBEDDING_DEFAULT_KEY;
 
     // Tenant first, deployment second — the same order every model resolver
-    // uses. A tenant model key is `${providerId}/${modelId}` and only resolves
-    // in that tenant's namespace.
+    // uses. A concrete key that misses falls back to the tenant's embedding
+    // default, then to the deployment registration.
     const embeddings =
       (await embeddingsLatticeManager.getEmbeddingsClientWithTenant(
         tenantId,
-        embeddingKey
+        requestedKey
       )) ??
+      (requestedKey === EMBEDDING_DEFAULT_KEY
+        ? undefined
+        : await embeddingsLatticeManager.getEmbeddingsClientWithTenant(
+            tenantId,
+            EMBEDDING_DEFAULT_KEY
+          )) ??
       (await embeddingsLatticeManager.getEmbeddingsClientWithTenant(
         tenantId,
         "default"
@@ -48,7 +59,7 @@ export class PGVectorStoreProvider implements VectorStoreProvider {
     if (!embeddings) {
       throw new Error(
         `No embedding model "${embeddingKey}" registered for tenant "${tenantId}", ` +
-          `and no deployment default. Configure one in the model provider panel.`
+          `and no tenant or deployment default. Configure one in the model service panel.`
       );
     }
 

package/src/__tests__/AgentRunRetention.migrations.test.ts

@@ -34,7 +34,9 @@ describe("agent run retention migration", () => {
         (name) => name === createAgentRunRetentionMigration.name,
       ),
     ).toHaveLength(1);
-    expect(registeredMigrationNames.at(-1)).toBe(
+    // Registration order is not the apply order — the manager sorts by version —
+    // so assert presence rather than that this is the last line registered.
+    expect(registeredMigrationNames).toContain(
       agentRunProjectTaskRunningIndexMigration.name,
     );
   });

package/src/createPgStoreConfig.ts

@@ -109,6 +109,7 @@ import {
   addModelProviderModelExtra,
   addModelProviderModelDefault,
   addModelProviderModelKind,
+  addModelProviderKindDefault,
 } from "./migrations/model_provider_migrations";
 import { PostgreSQLCapabilityBundleStore } from "./stores/PostgreSQLCapabilityBundleStore";
 import { PostgreSQLProjectRoomStore } from "./stores/PostgreSQLProjectRoomStore";
@@ -222,6 +223,7 @@ export async function createPgStoreConfig(connectionString: string) {
   mm.register(createAgentRunRetentionMigration); // v201
   mm.register(createAgentRunProjectTaskMigration); // v203
   mm.register(agentRunProjectTaskRunningIndexMigration); // v204
+  mm.register(addModelProviderKindDefault);     // v207
 
   await mm.migrate();
 

package/src/migrations/model_provider_migrations.ts

@@ -256,3 +256,41 @@ export const addModelProviderModelKind: Migration = {
     `);
   },
 };
+
+/**
+ * One default per tenant **per kind**.
+ *
+ * v192's index was tenant-wide, so a tenant could have a default chat model
+ * *or* a default embedding model, never both. Each kind publishes its own
+ * alias key (`default`, `default:embedding`, `default:asr`), so the uniqueness
+ * constraint has to be per kind too.
+ *
+ * Existing rows satisfy the wider index unchanged: before this, at most one
+ * row per tenant could be the default.
+ *
+ * Note the `down` migration can legitimately fail once a tenant has one
+ * default per kind — the narrower index cannot represent that state. That is a
+ * deliberate one-way step.
+ */
+export const addModelProviderKindDefault: Migration = {
+  version: 207,
+  name: 'add_model_provider_kind_default',
+  up: async (client: PoolClient) => {
+    await client.query(`
+      DROP INDEX IF EXISTS uk_lattice_model_provider_models_tenant_default
+    `);
+    await client.query(`
+      CREATE UNIQUE INDEX IF NOT EXISTS uk_lattice_model_provider_models_tenant_kind_default
+      ON lattice_model_provider_models (tenant_id, kind) WHERE is_default
+    `);
+  },
+  down: async (client: PoolClient) => {
+    await client.query(`
+      DROP INDEX IF EXISTS uk_lattice_model_provider_models_tenant_kind_default
+    `);
+    await client.query(`
+      CREATE UNIQUE INDEX IF NOT EXISTS uk_lattice_model_provider_models_tenant_default
+      ON lattice_model_provider_models (tenant_id) WHERE is_default
+    `);
+  },
+};

package/src/stores/PostgreSQLModelProviderStore.ts

@@ -26,6 +26,7 @@ import {
   addModelProviderModelExtra,
   addModelProviderModelDefault,
   addModelProviderModelKind,
+  addModelProviderKindDefault,
 } from '../migrations/model_provider_migrations';
 import { encrypt, safeDecrypt } from '@axiom-lattice/core';
 
@@ -148,6 +149,7 @@ export class PostgreSQLModelProviderStore implements ModelProviderStore {
     this.migrationManager.register(addModelProviderModelExtra);     // v191
     this.migrationManager.register(addModelProviderModelDefault);   // v192
     this.migrationManager.register(addModelProviderModelKind);      // v193
+    this.migrationManager.register(addModelProviderKindDefault);    // v207
 
     // Auto-migrate by default
     if (options.autoMigrate !== false) {
@@ -610,30 +612,42 @@ export class PostgreSQLModelProviderStore implements ModelProviderStore {
         (model) => model.kind ?? currentKind.get(model.id) ?? "chat"
       );
 
-      // Whether this write is naming a default at all.
+      // Which kinds this write names a default for.
       //
-      // The unique index spans the *tenant*, while this method writes one
+      // The unique index is per *(tenant, kind)*, while this method writes one
       // provider. Two consequences:
       //
-      // 1. A swap (A was the default, B now is) would see two true rows
-      //    mid-statement — PostgreSQL checks a unique index per row, so whether
-      //    it fails would depend on which row the batch happened to process
-      //    first. Clearing tenant-wide *before* the upsert makes order
+      // 1. A swap (A was kind K's default, B now is) would see two true rows of
+      //    kind K mid-statement — PostgreSQL checks a unique index per row, so
+      //    whether it fails would depend on which row the batch happened to
+      //    process first. Clearing that kind before the upsert makes order
       //    irrelevant.
-      // 2. Once cleared, an omitted flag must resolve to `false`, not "keep":
-      //    keeping it would restore the old default alongside the new one.
-      const namesDefault = rows.some((model) => model.isDefault === true);
-      if (namesDefault) {
+      // 2. Once cleared, an omitted flag must resolve to `false` for the kinds
+      //    this write names — keeping it would restore the old default
+      //    alongside the new one. Other kinds keep their stored flag, so a chat
+      //    write cannot drop the tenant's embedding default.
+      const namedDefaultKinds = new Set<ModelKind>();
+      rows.forEach((model, index) => {
+        if (model.isDefault === true) {
+          namedDefaultKinds.add(effectiveKind[index] as ModelKind);
+        }
+      });
+
+      for (const kind of namedDefaultKinds) {
         await client.query(
-          `UPDATE lattice_model_provider_models SET is_default = FALSE WHERE tenant_id = $1`,
-          [tenantId]
+          `UPDATE lattice_model_provider_models
+              SET is_default = FALSE
+            WHERE tenant_id = $1 AND kind = $2 AND is_default`,
+          [tenantId, kind]
         );
       }
 
       const effectiveIsDefault = rows.map(
-        (model) =>
+        (model, index) =>
           model.isDefault ??
-          (namesDefault ? false : currentIsDefault.get(model.id)) ??
+          (namedDefaultKinds.has(effectiveKind[index] as ModelKind)
+            ? false
+            : currentIsDefault.get(model.id)) ??
           false
       );