@axiom-lattice/local-stores 2.0.7 → 2.0.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@axiom-lattice/local-stores",
-  "version": "2.0.7",
+  "version": "2.0.8",
   "description": "Local SQLite-based stores for Axiom Lattice framework",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -25,8 +25,8 @@
     "@types/sql.js": "^1.4.11",
     "sql.js": "^1.14.1",
     "uuid": "^14.0.1",
-    "@axiom-lattice/core": "3.0.7",
-    "@axiom-lattice/protocols": "3.0.2"
+    "@axiom-lattice/core": "3.1.0",
+    "@axiom-lattice/protocols": "3.0.3"
   },
   "devDependencies": {
     "@types/jest": "^29.5.14",

package/src/__tests__/LocalTaskStore.test.ts

@@ -0,0 +1,84 @@
+/**
+ * LocalTaskStore metadata filter tests
+ *
+ * The frontend queries training rounds with stringified JSON values
+ * (`metadata={"trainingRound":"true"}`), tuned for PostgreSQL's `metadata->>`
+ * text comparison. SQLite's json_extract returns INTEGER 1 for JSON true,
+ * so a naive text comparison filters the round out — the learning card
+ * shows no data.
+ */
+
+import { describe, expect, it, beforeEach, afterEach } from "@jest/globals";
+import { tmpdir } from "os";
+import path from "path";
+import { initDatabase, closeDatabase } from "../database";
+import { LocalTaskStore } from "../stores/LocalTaskStore";
+
+// sql.js persists to disk via DatabaseWrapper.save(), so each test needs a
+// unique file path (":memory:" is treated as a plain relative path).
+const nextDbPath = () =>
+  path.join(tmpdir(), `lt-task-test-${Date.now()}-${Math.random().toString(36).slice(2)}.db`);
+
+describe("LocalTaskStore metadata filter", () => {
+  let store: LocalTaskStore;
+
+  beforeEach(async () => {
+    const db = await initDatabase({ dbPath: nextDbPath() });
+    store = new LocalTaskStore(db);
+  });
+
+  afterEach(() => {
+    closeDatabase();
+  });
+
+  it("matches a boolean metadata value queried as the string 'true'", async () => {
+    await store.create({
+      tenantId: "t1",
+      ownerType: "agent",
+      ownerId: "agent-architect",
+      title: "round",
+      status: "in_progress",
+      metadata: { trainingRound: true, targetAgentId: "agent-x" },
+    } as never);
+
+    const byBoolean = await store.list({
+      tenantId: "t1",
+      ownerId: "agent-architect",
+      metadata: { trainingRound: "true", targetAgentId: "agent-x" },
+    } as never);
+    expect(byBoolean).toHaveLength(1);
+  });
+
+  it("still matches string metadata values", async () => {
+    await store.create({
+      tenantId: "t1",
+      ownerType: "agent",
+      ownerId: "agent-architect",
+      title: "round",
+      status: "pending",
+      metadata: { trainingRound: true, targetAgentId: "agent-x" },
+    } as never);
+
+    const byString = await store.list({
+      tenantId: "t1",
+      metadata: { targetAgentId: "agent-x" },
+    } as never);
+    expect(byString).toHaveLength(1);
+    const miss = await store.list({ tenantId: "t1", metadata: { targetAgentId: "agent-y" } } as never);
+    expect(miss).toHaveLength(0);
+  });
+
+  it("matches boolean false queried as the string 'false'", async () => {
+    await store.create({
+      tenantId: "t1",
+      ownerType: "agent",
+      ownerId: "agent-architect",
+      title: "t",
+      status: "pending",
+      metadata: { archived: false },
+    } as never);
+
+    const rows = await store.list({ tenantId: "t1", metadata: { archived: "false" } } as never);
+    expect(rows).toHaveLength(1);
+  });
+});

package/src/stores/LocalEvalStore.ts

@@ -79,6 +79,7 @@ CREATE TABLE IF NOT EXISTS lt_eval_runs (
   holdout INTEGER NOT NULL DEFAULT 0,
   env_project_id TEXT,
   env_workspace_id TEXT,
+  task_id TEXT,
   created_at TEXT NOT NULL,
   started_at TEXT,
   completed_at TEXT,
@@ -133,6 +134,7 @@ export class LocalEvalStore implements EvalStore {
     this.ensureColumn("lt_eval_runs", "interrupted_cases", "interrupted_cases INTEGER NOT NULL DEFAULT 0");
     this.ensureColumn("lt_eval_run_results", "interrupted", "interrupted INTEGER NOT NULL DEFAULT 0");
     this.ensureColumn("lt_eval_cases", "interrupt_policy", "interrupt_policy TEXT");
+    this.ensureColumn("lt_eval_runs", "task_id", "task_id TEXT");
     // Project name must be unique per tenant (eval-{agent-id} convention).
     // Repoint child rows (suites, runs) of duplicate projects onto the kept
     // project (newest by created_at, tie-break rowid — mirrors the pg
@@ -398,9 +400,9 @@ export class LocalEvalStore implements EvalStore {
   async createRun(tenantId: string, projectId: string, id: string, data: CreateEvalRunRequest): Promise<EvalRun> {
     const actualId = id || randomUUID();
     this.db.prepare(
-      `INSERT INTO lt_eval_runs (id, project_id, tenant_id, status, concurrency, total_cases, passed_cases, failed_cases, avg_score, holdout, env_project_id, env_workspace_id, created_at)
-       VALUES (?, ?, ?, 'running', ?, ?, 0, 0, 0, ?, ?, ?, ?)`,
-    ).run(actualId, projectId, tenantId, data.concurrency, data.totalCases, data.holdout ? 1 : 0, data.envProjectId || null, data.envWorkspaceId || null, nowISO());
+      `INSERT INTO lt_eval_runs (id, project_id, tenant_id, status, concurrency, total_cases, passed_cases, failed_cases, avg_score, holdout, env_project_id, env_workspace_id, task_id, created_at)
+       VALUES (?, ?, ?, 'running', ?, ?, 0, 0, 0, ?, ?, ?, ?, ?)`,
+    ).run(actualId, projectId, tenantId, data.concurrency, data.totalCases, data.holdout ? 1 : 0, data.envProjectId || null, data.envWorkspaceId || null, data.taskId || null, nowISO());
     return (await this.getRunById(tenantId, actualId))!;
   }
 
@@ -587,6 +589,7 @@ export class LocalEvalStore implements EvalStore {
       holdout: row.holdout ? Boolean(row.holdout) : undefined,
       envProjectId: row.env_project_id as string | undefined,
       envWorkspaceId: row.env_workspace_id as string | undefined,
+      taskId: row.task_id as string | undefined,
       createdAt: parseISO(row.created_at as string),
       startedAt: row.started_at ? parseISO(row.started_at as string) : undefined,
       completedAt: row.completed_at ? parseISO(row.completed_at as string) : undefined,

package/src/stores/LocalTaskStore.ts

@@ -6,6 +6,7 @@ import { DatabaseWrapper } from "../database";
 import type {
   TaskStore,
   TaskItem,
+  TaskFileRef,
   CreateTaskRequest,
   UpdateTaskRequest,
   TaskListFilter,
@@ -34,6 +35,7 @@ CREATE TABLE IF NOT EXISTS lt_tasks (
   failure_reason TEXT,
   workspace_id TEXT,
   project_id TEXT,
+  files TEXT,
   created_at TEXT NOT NULL,
   updated_at TEXT NOT NULL,
   PRIMARY KEY (tenant_id, id)
@@ -60,10 +62,22 @@ interface TaskRow {
   failure_reason: string | null;
   workspace_id: string | null;
   project_id: string | null;
+  files: string | null;
   created_at: string;
   updated_at: string;
 }
 
+function parseTaskFiles(raw: unknown): TaskFileRef[] | undefined {
+  if (!raw) return undefined;
+  try {
+    const parsed = typeof raw === "string" ? JSON.parse(raw) : raw;
+    if (!Array.isArray(parsed)) return undefined;
+    return parsed as TaskFileRef[];
+  } catch {
+    return undefined;
+  }
+}
+
 function mapRowToTask(row: TaskRow): TaskItem {
   return {
     id: row.id,
@@ -85,6 +99,7 @@ function mapRowToTask(row: TaskRow): TaskItem {
     failureReason: row.failure_reason || undefined,
     workspaceId: row.workspace_id ?? undefined,
     projectId: row.project_id ?? undefined,
+    files: parseTaskFiles(row.files),
     createdAt: parseISO(row.created_at),
     updatedAt: parseISO(row.updated_at),
   };
@@ -96,12 +111,24 @@ export class LocalTaskStore implements TaskStore {
   constructor(db: DatabaseWrapper) {
     this.db = db;
     ensureTable(db, DDL);
-    this.db.exec(`ALTER TABLE lt_tasks ADD COLUMN require_review INTEGER DEFAULT 0;`);
-    this.db.exec(`ALTER TABLE lt_tasks ADD COLUMN dependencies TEXT;`);
-    this.db.exec(`ALTER TABLE lt_tasks ADD COLUMN result TEXT;`);
-    this.db.exec(`ALTER TABLE lt_tasks ADD COLUMN failure_reason TEXT;`);
-    this.db.exec(`ALTER TABLE lt_tasks ADD COLUMN workspace_id TEXT;`);
-    this.db.exec(`ALTER TABLE lt_tasks ADD COLUMN project_id TEXT;`);
+    // Existing installs: add columns shipped after the original schema.
+    // sql.js bundles an older SQLite that does not support
+    // `ADD COLUMN IF NOT EXISTS`, so check via PRAGMA instead.
+    this.ensureColumn("lt_tasks", "require_review", "require_review INTEGER DEFAULT 0");
+    this.ensureColumn("lt_tasks", "dependencies", "dependencies TEXT");
+    this.ensureColumn("lt_tasks", "result", "result TEXT");
+    this.ensureColumn("lt_tasks", "failure_reason", "failure_reason TEXT");
+    this.ensureColumn("lt_tasks", "workspace_id", "workspace_id TEXT");
+    this.ensureColumn("lt_tasks", "project_id", "project_id TEXT");
+    this.ensureColumn("lt_tasks", "files", "files TEXT");
+  }
+
+  /** Add a column if it does not exist (SQLite version compatible). */
+  private ensureColumn(table: string, column: string, ddl: string): void {
+    const cols = this.db.prepare(`PRAGMA table_info(${table})`).all() as Array<{ name: string }>;
+    if (!cols.some((c) => c.name === column)) {
+      this.db.exec(`ALTER TABLE ${table} ADD COLUMN ${ddl}`);
+    }
   }
 
   async create(
@@ -111,7 +138,7 @@ export class LocalTaskStore implements TaskStore {
     const now = nowISO();
 
     this.db.prepare(
-      `INSERT INTO lt_tasks (id, tenant_id, owner_type, owner_id, title, description, status, priority, due_date, metadata, parent_id, source_id, context, require_review, dependencies, result, failure_reason, workspace_id, project_id, created_at, updated_at)
+      `INSERT INTO lt_tasks (id, tenant_id, owner_type, owner_id, title, description, status, priority, due_date, metadata, parent_id, source_id, context, require_review, dependencies, result, failure_reason, workspace_id, project_id, files, created_at, updated_at)
        VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
     ).run(
       id, params.tenantId, params.ownerType, params.ownerId, params.title,
@@ -123,6 +150,7 @@ export class LocalTaskStore implements TaskStore {
       params.dependencies ? JSON.stringify(params.dependencies) : null,
       params.result || null, params.failureReason || null,
       params.workspaceId || null, params.projectId || null,
+      params.files ? JSON.stringify(params.files) : null,
       now, now,
     );
 
@@ -157,8 +185,17 @@ export class LocalTaskStore implements TaskStore {
       for (const [key, value] of Object.entries(filter.metadata)) {
         const safeKey = key.replace(/[^a-zA-Z0-9_]/g, '');
         if (safeKey) {
-          conditions.push(`json_extract(metadata, '$.${safeKey}') = ?`);
-          params.push(String(value));
+          // Callers pass stringified JSON values ("true"/"false") following
+          // the PostgreSQL metadata->> text convention, but SQLite's
+          // json_extract returns INTEGER 1/0 for JSON booleans — match both.
+          const strVal = String(value);
+          if (strVal === 'true' || strVal === 'false') {
+            conditions.push(`(json_extract(metadata, '$.${safeKey}') = ? OR json_extract(metadata, '$.${safeKey}') = ?)`);
+            params.push(strVal, strVal === 'true' ? 1 : 0);
+          } else {
+            conditions.push(`json_extract(metadata, '$.${safeKey}') = ?`);
+            params.push(strVal);
+          }
         }
       }
     }
@@ -202,6 +239,7 @@ export class LocalTaskStore implements TaskStore {
     if (updates.failureReason !== undefined) { setClauses.push('failure_reason = ?'); values.push(updates.failureReason); }
     if (updates.workspaceId !== undefined) { setClauses.push('workspace_id = ?'); values.push(updates.workspaceId); }
     if (updates.projectId !== undefined) { setClauses.push('project_id = ?'); values.push(updates.projectId); }
+    if (updates.files !== undefined) { setClauses.push('files = ?'); values.push(JSON.stringify(updates.files)); }
 
     if (setClauses.length === 1) return existing;