@axa-fr/react-oidc 6.5.0-beta0 → 6.5.1

package/src/oidc/vanilla/oidc.ts

@@ -21,7 +21,7 @@ import {getParseQueryStringFromLocation} from "./route-utils";
 import {AuthorizationServiceConfigurationJson} from "@openid/appauth/src/authorization_service_configuration";
 import {computeTimeLeft, isTokensOidcValid, isTokensValid, parseOriginalTokens, setTokens} from "./parseTokens";
 
-const performTokenRequestAsync= async (url, details, extras) => {
+const performTokenRequestAsync= async (url, details, extras, oldTokens) => {
     
     for (let [key, value] of Object.entries(extras)) {
         if (details[key] === undefined) {
@@ -42,7 +42,6 @@ const performTokenRequestAsync= async (url, details, extras) => {
         headers: {
             'Content-Type': 'application/x-www-form-urlencoded;charset=UTF-8',
         },
-        //mode: 'cors',
         body: formBodyString,
     });
     if(response.status !== 200){
@@ -51,7 +50,7 @@ const performTokenRequestAsync= async (url, details, extras) => {
     const tokens = await response.json();
     return { 
         success : true,
-        data: parseOriginalTokens(tokens)
+        data: parseOriginalTokens(tokens, oldTokens)
     };
 }
 
@@ -154,12 +153,12 @@ const loginCallbackWithAutoTokensRenewAsync = async (oidc) => {
     return { state, callbackPath };
 }
 
-async function renewTokensAndStartTimerAsync(oidc, refreshToken, forceRefresh =false) {
-    const {tokens, status} = await oidc.synchroniseTokensAsync(refreshToken, 0, forceRefresh);
+async function renewTokensAndStartTimerAsync(oidc, refreshToken, forceRefresh =false, extras:StringMap=null) {
+    const {tokens, status} = await oidc.synchroniseTokensAsync(refreshToken, 0, forceRefresh, extras);
     oidc.tokens = tokens;
     const serviceWorker = await initWorkerAsync(oidc.configuration.service_worker_relative_url, oidc.configurationName);
     if (!serviceWorker) {
-        const session = initSession(this.configurationName, oidc.configuration.redirect_uri, oidc.configuration.storage);
+        const session = initSession(oidc.configurationName, oidc.configuration.redirect_uri, oidc.configuration.storage);
         await session.setTokens(oidc.tokens);
     }
     
@@ -169,17 +168,17 @@ async function renewTokensAndStartTimerAsync(oidc, refreshToken, forceRefresh =f
     }
 
     if (oidc.timeoutId) {
-        oidc.timeoutId = autoRenewTokens(oidc, tokens.refreshToken, oidc.tokens.expiresAt);
+        oidc.timeoutId = autoRenewTokens(oidc, tokens.refreshToken, oidc.tokens.expiresAt, extras);
     }
 }
 
-const autoRenewTokens = (oidc, refreshToken, expiresAt) => {
+const autoRenewTokens = (oidc, refreshToken, expiresAt, extras:StringMap=null) => {
     const refreshTimeBeforeTokensExpirationInSecond = oidc.configuration.refresh_time_before_tokens_expiration_in_second;
     return timer.setTimeout(async () => {
         const timeLeft = computeTimeLeft(refreshTimeBeforeTokensExpirationInSecond, expiresAt);
         const timeInfo = { timeLeft };
         oidc.publishEvent(Oidc.eventNames.token_timer, timeInfo);
-        await renewTokensAndStartTimerAsync(oidc, refreshToken);
+        await renewTokensAndStartTimerAsync(oidc, refreshToken, false, extras);
     }, 1000);
 }
 
@@ -224,7 +223,6 @@ const userInfoAsync = async (oidc) => {
        const res = await fetch(url, {
            headers: {
                authorization: `Bearer ${accessToken}`,
-               // credentials: 'include'
            }
        });
 
@@ -328,9 +326,7 @@ export class Oidc {
     public tokens: null;
     public events: Array<any>;
     private timeoutId: NodeJS.Timeout;
-    //private serviceWorker?: any;
     private configurationName: string;
-    //private session?: any;
     private checkSessionIFrame: CheckSessionIFrame;
     constructor(configuration:OidcConfiguration, configurationName="default") {
         let silent_login_uri = configuration.silent_login_uri;
@@ -349,8 +345,6 @@ export class Oidc {
       this.userInfo = null;
       this.events = [];
       this.timeoutId = null;
-      //this.serviceWorker = null;
-      //this.session = null;
       this.synchroniseTokensAsync.bind(this);
       this.loginCallbackWithAutoTokensRenewAsync.bind(this);
       this.initAsync.bind(this);
@@ -563,7 +557,6 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
                         serviceWorker.startKeepAliveServiceWorker();
                         // @ts-ignore
                         this.tokens = tokens;
-                        //this.serviceWorker = serviceWorker;
                         // @ts-ignore
                         this.timeoutId = autoRenewTokens(this, this.tokens.refreshToken, this.tokens.expiresAt);
                         const sessionState = await serviceWorker.getSessionStateAsync();
@@ -590,8 +583,6 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
                     if (tokens) {
                         // @ts-ignore
                         this.tokens = setTokens(tokens);
-                        //session.setTokens(this.tokens);
-                        //this.session = session;
                         // @ts-ignore
                         this.timeoutId = autoRenewTokens(this, tokens.refreshToken, this.tokens.expiresAt);
                         const sessionState = session.getSessionState();
@@ -627,7 +618,7 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
     }
 
     loginPromise: Promise<any>=null;
-    async loginAsync(callbackPath:string=undefined, extras:StringMap=null, state:string=undefined, isSilentSignin:boolean=false, scope:string=undefined, silentLoginOnly = false) {
+    async loginAsync(callbackPath:string=undefined, extras:StringMap=null, isSilentSignin:boolean=false, scope:string=undefined, silentLoginOnly = false) {
         if(this.loginPromise !== null){
             return this.loginPromise;
         }
@@ -638,6 +629,12 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
                 const url = callbackPath || location.pathname + (location.search || '') + (location.hash || '');
                
                 const configuration = this.configuration;
+            let state = undefined;
+            if(extras && "state" in extras){
+                state = extras["state"];
+                delete extras["state"];
+            }
+           
 
                 if(silentLoginOnly){
                     try {
@@ -651,7 +648,7 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
                             this.tokens = silentResult.tokens;
                             this.publishEvent(eventNames.token_aquired, {});
                             // @ts-ignore
-                            this.timeoutId = autoRenewTokens(this, this.tokens.refreshToken, this.tokens.expiresAt);
+                            this.timeoutId = autoRenewTokens(this, this.tokens.refreshToken, this.tokens.expiresAt, extras);
                             return {};
                         }
                     }catch (e) {
@@ -825,7 +822,6 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
             let nonceData = null;
             if(serviceWorker){
                 serviceWorker.startKeepAliveServiceWorker();
-                //const serviceWorker = serviceWorker;
                 await serviceWorker.initAsync(oidcServerConfiguration, "loginCallbackAsync");
                 const items = await serviceWorker.loadItemsAsync();
                 storage = new MemoryStorageBackend(serviceWorker.saveItemsAsync, items);
@@ -837,7 +833,6 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
                 await serviceWorker.setSessionStateAsync(sessionState);
                 nonceData = await serviceWorker.getNonceAsync();
             }else{
-                //this.session = initSession(this.configurationName, redirectUri, configuration.storage ?? sessionStorage);
                 const session = initSession(this.configurationName, redirectUri);
                 session.setSessionState(sessionState);
                 const items = await session.loadItemsAsync();
@@ -946,7 +941,7 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
         }
     }
 
-    async synchroniseTokensAsync(refreshToken, index=0, forceRefresh =false) {
+    async synchroniseTokensAsync(refreshToken, index=0, forceRefresh =false, extras:StringMap=null) {
         
             if (document.hidden) {
                 await sleepAsync(1000);
@@ -959,13 +954,17 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
                 numberTryOnline--;
                 this.publishEvent(eventNames.refreshTokensAsync, {message: `wait because navigator is offline try ${numberTryOnline}` });
             }
-
+        if(!extras){
+            extras = {}
+        }
         const configuration = this.configuration;
         const localsilentLoginAsync= async () => {
             try {
                 const loginParams = getLoginParams(this.configurationName, configuration.redirect_uri);
+                
                 const silent_token_response = await this.silentLoginAsync({
                     ...loginParams.extras,
+                    ...extras,
                     prompt: "none"
                 }, loginParams.state);
                 if (silent_token_response) {
@@ -988,7 +987,6 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
             
             if (index <=4) {
                 try {
-                    
                     const { status, tokens } = await this.syncTokensInfoAsync(configuration, this.configurationName, this.tokens, forceRefresh);
                     switch (status) {
                         case "SESSION_LOST":
@@ -1017,12 +1015,9 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
                             const clientId = configuration.client_id;
                             const redirectUri = configuration.redirect_uri;
                             const authority =  configuration.authority;
-                            let extras = {};
-                            if(configuration.token_request_extras) {
-                                for (let [key, value] of Object.entries(configuration.token_request_extras)) {
-                                    extras[key] = value;
-                                }
-                            }
+                            const tokenExtras = configuration.token_request_extras ? configuration.token_request_extras : {};
+                            let finalExtras = {...tokenExtras, ...extras};
+                            
                             const details = {
                                 client_id: clientId,
                                 redirect_uri: redirectUri,
@@ -1030,7 +1025,7 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
                                 refresh_token: tokens.refreshToken,
                             };
                             const oidcServerConfiguration = await this.initAsync(authority, configuration.authority_configuration);
-                            const tokenResponse = await performTokenRequestAsync(oidcServerConfiguration.tokenEndpoint, details, extras)
+                            const tokenResponse = await performTokenRequestAsync(oidcServerConfiguration.tokenEndpoint, details, finalExtras, tokens);
                             if (tokenResponse.success) {
                                 if(!isTokensOidcValid(tokenResponse.data, null, oidcServerConfiguration)){
                                     this.publishEvent(eventNames.refreshTokensAsync_error, {message: `refresh token return not valid tokens` });
@@ -1127,13 +1122,13 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
          })
      }
      
-     async renewTokensAsync (){
+     async renewTokensAsync (extras:StringMap=null){
          if(!this.timeoutId){
              return;
          }
          timer.clearTimeout(this.timeoutId);
          // @ts-ignore
-         await renewTokensAndStartTimerAsync(this, this.tokens.refreshToken, true);
+         await renewTokensAndStartTimerAsync(this, this.tokens.refreshToken, true, extras);
      }
      
      async destroyAsync(status) {

package/src/oidc/vanilla/parseTokens.ts

@@ -33,7 +33,7 @@ const extractAccessTokenPayload = tokens => {
 };
 
 
-export const setTokens = (tokens) =>{
+export const setTokens = (tokens, oldTokens=null) =>{
     
     if(!tokens){
         return null;
@@ -57,12 +57,19 @@ export const setTokens = (tokens) =>{
     const accessTokenExpiresAt =  (accessTokenPayload && accessTokenPayload.exp)? accessTokenPayload.exp : tokens.issuedAt + tokens.expiresIn;
     const expiresAt = idTokenExipreAt < accessTokenExpiresAt ? idTokenExipreAt : accessTokenExpiresAt;
     
-    return {...tokens, idTokenPayload: _idTokenPayload, accessTokenPayload, expiresAt};
+    const newTokens = {...tokens, idTokenPayload: _idTokenPayload, accessTokenPayload, expiresAt};
+    // When refresh_token is not rotated we reuse ald refresh_token
+    if(oldTokens != null && "refreshToken" in oldTokens && !("refreshToken" in tokens)){
+        const refreshToken = oldTokens.refreshToken
+        return {...newTokens, refreshToken};
+    } 
+    
+    return newTokens;
 }
 
 
 
-export const parseOriginalTokens= (tokens) =>{
+export const parseOriginalTokens= (tokens, oldTokens) =>{
     if(!tokens){
         return null;
     }
@@ -75,12 +82,16 @@ export const parseOriginalTokens= (tokens) =>{
         accessToken: tokens.access_token,
         expiresIn: tokens.expires_in,
         idToken: tokens.id_token,
-        refreshToken: tokens.refresh_token,
         scope: tokens.scope,
         tokenType: tokens.token_type,
         issuedAt: tokens.issued_at
     };
 
+    if("refresh_token" in tokens) {
+        // @ts-ignore
+        data.refreshToken= tokens.refresh_token;
+    }
+
 
     if(tokens.accessTokenPayload !== undefined){
         // @ts-ignore
@@ -92,7 +103,7 @@ export const parseOriginalTokens= (tokens) =>{
         data.idTokenPayload = tokens.idTokenPayload;
     }
 
-    return setTokens(data);
+    return setTokens(data, oldTokens);
 }
 
 export const computeTimeLeft = (refreshTimeBeforeTokensExpirationInSecond, expiresAt)=>{