@aws/lsp-codewhisperer 0.0.69 → 0.0.71

package/CHANGELOG.md

@@ -1,5 +1,61 @@
 # Changelog
 
+## [0.0.71](https://github.com/aws/language-servers/compare/lsp-codewhisperer/v0.0.70...lsp-codewhisperer/v0.0.71) (2025-08-04)
+
+
+### Features
+
+* adding inline chat telemetry ([#2001](https://github.com/aws/language-servers/issues/2001)) ([8b1c9c7](https://github.com/aws/language-servers/commit/8b1c9c7c3859cdfbbd0abb059066a5c6fe2ffaf2))
+* **amazonq:** implement displayFindings tool ([#2029](https://github.com/aws/language-servers/issues/2029)) ([da11663](https://github.com/aws/language-servers/commit/da1166340f3d13e1d7fd83b260359661443230ea))
+* improve code review tool reliability and error handling ([#2033](https://github.com/aws/language-servers/issues/2033)) ([124244e](https://github.com/aws/language-servers/commit/124244ee7d97adf71a52c4fde7ddb908dbc0bd08))
+* support http transport without authorization for MCP ([97e806c](https://github.com/aws/language-servers/commit/97e806ce7ea5e5be1fd60c4a4d9a54cf76c8f8cb))
+
+
+### Bug Fixes
+
+* add bash command parsing for telemetry metrics ([#2039](https://github.com/aws/language-servers/issues/2039)) ([01d8112](https://github.com/aws/language-servers/commit/01d811225281a2e32f9cd6dab1b575aad8c0b4d6))
+* adding acceptedCharacterCount to UserTriggerDecisionEvent ([#2014](https://github.com/aws/language-servers/issues/2014)) ([3f94486](https://github.com/aws/language-servers/commit/3f944865483a6913138335fe61eee70ae71d7c03))
+* adjust bash command categories ([#2030](https://github.com/aws/language-servers/issues/2030)) ([25ed99f](https://github.com/aws/language-servers/commit/25ed99fcf0eeaa86b0a5e040e90d69becf625c71))
+* adjust cross file context config ([#2011](https://github.com/aws/language-servers/issues/2011)) ([f7ade37](https://github.com/aws/language-servers/commit/f7ade3767e714d5178f24fd9cc90349c5f417979))
+* **amazonq:** fix for mcp server permissions ([#2026](https://github.com/aws/language-servers/issues/2026)) ([89ae720](https://github.com/aws/language-servers/commit/89ae720dc036a90338d192aca801a858e8fa19f8))
+* **amazonq:** fix for mcp server permissions to prefer workspace agent config files ([#2038](https://github.com/aws/language-servers/issues/2038)) ([d2ac614](https://github.com/aws/language-servers/commit/d2ac614f0f16faa8bf689ac9c8bff09d64fc3a3b))
+* **amazonq:** fix processing empty unsupported workspace file ([#2017](https://github.com/aws/language-servers/issues/2017)) ([9e4d0af](https://github.com/aws/language-servers/commit/9e4d0af244b5edba73771b6cb4290d922ef83c43))
+* correct the implementation of gathering open tabs in cross file context ([#2040](https://github.com/aws/language-servers/issues/2040)) ([b7b7a2b](https://github.com/aws/language-servers/commit/b7b7a2bd2020f50069ce89f6505cc2a36b1f3fa7))
+* remove malicious characters from prompt input ([#2009](https://github.com/aws/language-servers/issues/2009)) ([bf8a1e6](https://github.com/aws/language-servers/commit/bf8a1e6136801532132f2bf82def4ca5bf49c82f))
+* sanitize request input ([#2025](https://github.com/aws/language-servers/issues/2025)) ([7c0efd7](https://github.com/aws/language-servers/commit/7c0efd73d5e9a0e3f42d143a10c16782f6e35db8))
+* skip image sanitization ([#2031](https://github.com/aws/language-servers/issues/2031)) ([f02fc23](https://github.com/aws/language-servers/commit/f02fc231136940bd644c426d2b222ae2cba779c4))
+* sometimes Enter does not auto trigger ([#2005](https://github.com/aws/language-servers/issues/2005)) ([c9af035](https://github.com/aws/language-servers/commit/c9af0353a6c6f3b2ca4eead02f19e8ab5ddb8ef1))
+* use fast glob streaming when collecting files ([#2003](https://github.com/aws/language-servers/issues/2003)) ([f7c0a0b](https://github.com/aws/language-servers/commit/f7c0a0b0ef9ce3ecd620acfef00e55745db3d71f))
+* use new language server runtime ([#2023](https://github.com/aws/language-servers/issues/2023)) ([83ea1e4](https://github.com/aws/language-servers/commit/83ea1e42fe52990696eb9b878fa11e2c5331bec5))
+
+
+### Dependencies
+
+* The following workspace dependencies were updated
+  * dependencies
+    * @aws/lsp-core bumped from ^0.0.12 to ^0.0.13
+
+## [0.0.70](https://github.com/aws/language-servers/compare/lsp-codewhisperer/v0.0.69...lsp-codewhisperer/v0.0.70) (2025-07-29)
+
+
+### Features
+
+* **amazonq:** add new model error handling code ([#1972](https://github.com/aws/language-servers/issues/1972)) ([905f0fc](https://github.com/aws/language-servers/commit/905f0fcbb274926d22bcf30600ad4bd419ac8ee4))
+* **amazonq:** enable compaction, minor UI changes ([#1979](https://github.com/aws/language-servers/issues/1979)) ([2b56ca8](https://github.com/aws/language-servers/commit/2b56ca87f442a06b554043fee86edd79f96c638d))
+* **amazonq:** enhance workspaceContext classpath generation ([#1955](https://github.com/aws/language-servers/issues/1955)) ([f7ed20b](https://github.com/aws/language-servers/commit/f7ed20bc4010996c508f6ea8ca87950e117e43c1))
+* **amazonq:** redirect /review, rename CodeReview tool, emit metrics, modify prompts ([#1964](https://github.com/aws/language-servers/issues/1964)) ([ad8e2db](https://github.com/aws/language-servers/commit/ad8e2db77e34f369fef9af71cdda2d3522f555c6))
+* **amazonq:** revert auto-approve ([#2002](https://github.com/aws/language-servers/issues/2002)) ([c8181f7](https://github.com/aws/language-servers/commit/c8181f7a1de224dfcc7a77cd0bfc905fa1018372))
+* enhance profile fetching logs to diagnose developerProfiles errors ([#1969](https://github.com/aws/language-servers/issues/1969)) ([eb688c2](https://github.com/aws/language-servers/commit/eb688c272df1251cd5c14ada7894bcaf625b6453))
+
+
+### Bug Fixes
+
+* **amazonq:** wrong path in the logs for the function ([#1978](https://github.com/aws/language-servers/issues/1978)) ([ed8b4f6](https://github.com/aws/language-servers/commit/ed8b4f6755accb624e7dc8c645ecd5cd9370a0f2))
+* emit metric for tool error ([#1954](https://github.com/aws/language-servers/issues/1954)) ([c3bbcea](https://github.com/aws/language-servers/commit/c3bbceabcea3d7aea2e414abc632c3a744b0e02b))
+* enable repomap for all users ([#1967](https://github.com/aws/language-servers/issues/1967)) ([6954085](https://github.com/aws/language-servers/commit/69540851e54b65729b2affbe3ae7d98629bdb5f4))
+* move network commands out of ro category ([#1985](https://github.com/aws/language-servers/issues/1985)) ([3cc9fd9](https://github.com/aws/language-servers/commit/3cc9fd91ae2f78ee28e224d5390ba78509de3615))
+* remove malicious characters from MCP tool description ([#1977](https://github.com/aws/language-servers/issues/1977)) ([64d4e3e](https://github.com/aws/language-servers/commit/64d4e3ebade706b01d256682cafe8d4ff8b85f41))
+
 ## [0.0.69](https://github.com/aws/language-servers/compare/lsp-codewhisperer/v0.0.68...lsp-codewhisperer/v0.0.69) (2025-07-23)
 
 

package/out/language-server/agenticChat/agenticChatController.js

@@ -51,8 +51,8 @@ const errors_2 = require("./errors");
 const vscode_uri_1 = require("vscode-uri");
 const executeBash_2 = require("./tools/executeBash");
 const userWrittenCodeTracker_1 = require("../../shared/userWrittenCodeTracker");
-const qCodeReview_1 = require("./tools/qCodeAnalysis/qCodeReview");
-const qCodeReviewConstants_1 = require("./tools/qCodeAnalysis/qCodeReviewConstants");
+const codeReview_1 = require("./tools/qCodeAnalysis/codeReview");
+const codeReviewConstants_1 = require("./tools/qCodeAnalysis/codeReviewConstants");
 const mcpEventHandler_1 = require("./tools/mcp/mcpEventHandler");
 const mcpUtils_1 = require("./tools/mcp/mcpUtils");
 const mcpManager_1 = require("./tools/mcp/mcpManager");
@@ -64,7 +64,7 @@ const imageVerification_1 = require("../../shared/imageVerification");
 const path_1 = require("@aws/lsp-core/out/util/path");
 const agenticChatControllerHelper_1 = require("./utils/agenticChatControllerHelper");
 const activeUserTracker_1 = require("../../shared/activeUserTracker");
-const qAgenticChatServer_1 = require("./qAgenticChatServer");
+const displayFindings_1 = require("./tools/qCodeAnalysis/displayFindings");
 class AgenticChatController {
     #features;
     #chatSessionManagementService;
@@ -464,7 +464,8 @@ class AgenticChatController {
     }
     async onChatPrompt(params, token) {
         // Phase 1: Initial Setup - This happens only once
-        const maybeDefaultResponse = (0, utils_1.getDefaultChatResponse)(params.prompt.prompt);
+        params.prompt.prompt = (0, utils_2.sanitizeInput)(params.prompt.prompt || '');
+        const maybeDefaultResponse = !params.prompt.command && (0, utils_1.getDefaultChatResponse)(params.prompt.prompt);
         if (maybeDefaultResponse) {
             return maybeDefaultResponse;
         }
@@ -549,7 +550,7 @@ class AgenticChatController {
                 const promptId = crypto.randomUUID();
                 session.setCurrentPromptId(promptId);
                 // Start the compaction call
-                finalResult = await this.#runCompaction(compactionRequestInput, session, metric, chatResultStream, params.tabId, promptId, session.conversationId, token, triggerContext.documentReference);
+                finalResult = await this.#runCompaction(compactionRequestInput, session, metric, chatResultStream, params.tabId, promptId, types_1.CompactHistoryActionType.Manual, session.conversationId, token, triggerContext.documentReference);
             }
             else {
                 // Get the initial request input
@@ -615,7 +616,7 @@ class AgenticChatController {
      */
     #shouldCompact(currentRequestCount) {
         // 80% of 570K limit
-        if ((0, qAgenticChatServer_1.enabledCompaction)(this.#features.lsp.getClientInitializeParams()) && currentRequestCount > 456_000) {
+        if (currentRequestCount > 456_000) {
             this.#debug(`Current request total character count is: ${currentRequestCount}, prompting user to compact`);
             return true;
         }
@@ -626,7 +627,7 @@ class AgenticChatController {
     /**
      * Runs the compaction to compact history into a single summary
      */
-    async #runCompaction(compactionRequestInput, session, metric, chatResultStream, tabId, promptId, conversationIdentifier, token, documentReference) {
+    async #runCompaction(compactionRequestInput, session, metric, chatResultStream, tabId, promptId, type, conversationIdentifier, token, documentReference) {
         let currentRequestInput = { ...compactionRequestInput };
         let finalResult = null;
         metric.recordStart();
@@ -684,21 +685,25 @@ class AgenticChatController {
             });
         }
         await resultStreamWriter.close();
+        session.setConversationType('AgenticChatWithCompaction');
+        const conversationType = session.getConversationType();
+        metric.setDimension('cwsprChatConversationType', conversationType);
+        this.#telemetryController.emitCompactHistory(type, characterCount, this.#features.runtime.serverInfo.version ?? '');
         // Add loading message before making the request
         const loadingMessageId = `loading-${(0, uuid_1.v4)()}`;
         await chatResultStream.writeResultBlock({ ...constants_1.loadingMessage, messageId: loadingMessageId });
         this.#debug(`Compacting history with ${characterCount} characters`);
         this.#llmRequestStartTime = Date.now();
         // Phase 3: Request Execution
-        // Note: these logs are very noisy, but contain information redacted on the backend.
-        this.#debug(`generateAssistantResponse/SendMessage Request: ${JSON.stringify(currentRequestInput, undefined, 2)}`);
+        currentRequestInput = (0, utils_2.sanitizeRequestInput)(currentRequestInput);
+        this.#debug(`Compaction Request: ${JSON.stringify(currentRequestInput, undefined, 2)}`);
         const response = await session.getChatResponse(currentRequestInput);
         if (response.$metadata.requestId) {
             metric.mergeWith({
                 requestIds: [response.$metadata.requestId],
             });
         }
-        this.#features.logging.info(`generateAssistantResponse/SendMessage ResponseMetadata: ${lsp_core_2.loggingUtils.formatObj(response.$metadata)}`);
+        this.#features.logging.info(`Compaction ResponseMetadata: ${lsp_core_2.loggingUtils.formatObj(response.$metadata)}`);
         await chatResultStream.removeResultBlock(loadingMessageId);
         // Phase 4: Response Processing
         const result = await this.#processAgenticChatResponseWithTimeout(response, metric.mergeWith({
@@ -781,6 +786,7 @@ class AgenticChatController {
             await chatResultStream.writeResultBlock({ ...constants_1.loadingMessage, messageId: loadingMessageId });
             this.#llmRequestStartTime = Date.now();
             // Phase 3: Request Execution
+            currentRequestInput = (0, utils_2.sanitizeRequestInput)(currentRequestInput);
             // Note: these logs are very noisy, but contain information redacted on the backend.
             this.#debug(`generateAssistantResponse/SendMessage Request: ${JSON.stringify(currentRequestInput, this.#imageReplacer, 2)}`);
             const response = await session.getChatResponse(currentRequestInput);
@@ -923,13 +929,13 @@ class AgenticChatController {
         }
         if (this.#shouldCompact(currentRequestCount)) {
             const messageId = this.#getMessageIdForCompact((0, uuid_1.v4)());
-            const confirmationResult = this.#processCompactConfirmation(messageId);
+            const confirmationResult = this.#processCompactConfirmation(messageId, currentRequestCount);
             const cachedButtonBlockId = await chatResultStream.writeResultBlock(confirmationResult);
             await this.waitForCompactApproval(messageId, chatResultStream, cachedButtonBlockId, session);
             // Get the compaction request input
             const compactionRequestInput = this.#getCompactionRequestInput(session);
             // Start the compaction call
-            return await this.#runCompaction(compactionRequestInput, session, metric, chatResultStream, tabId, promptId, session.conversationId, token, documentReference);
+            return await this.#runCompaction(compactionRequestInput, session, metric, chatResultStream, tabId, promptId, types_1.CompactHistoryActionType.Nudge, session.conversationId, token, documentReference);
         }
         return (finalResult || {
             success: false,
@@ -1167,8 +1173,9 @@ class AgenticChatController {
                         }
                         break;
                     }
-                    case qCodeReview_1.QCodeReview.toolName:
-                        // no need to write tool message for code review
+                    case codeReview_1.CodeReview.toolName:
+                    case displayFindings_1.DisplayFindings.toolName:
+                        // no need to write tool message for CodeReview or DisplayFindings
                         break;
                     // — DEFAULT ⇒ Only MCP tools, but can also handle generic tool execution messages
                     default:
@@ -1219,7 +1226,7 @@ class AgenticChatController {
                         fileChange: { before: document?.getText() },
                     });
                 }
-                if (toolUse.name === qCodeReview_1.QCodeReview.toolName) {
+                if (toolUse.name === codeReview_1.CodeReview.toolName) {
                     try {
                         let initialInput = JSON.parse(JSON.stringify(toolUse.input));
                         let ruleArtifacts = await this.#additionalContextProvider.collectWorkspaceRules(tabId);
@@ -1232,7 +1239,7 @@ class AgenticChatController {
                         toolUse.input = initialInput;
                     }
                     catch (e) {
-                        this.#features.logging.warn(`could not parse QCodeReview tool input: ${e}`);
+                        this.#features.logging.warn(`could not parse CodeReview tool input: ${e}`);
                     }
                 }
                 // After approval, add the path to the approved paths in the session
@@ -1302,17 +1309,31 @@ class AgenticChatController {
                         this.#telemetryController.emitInteractWithAgenticChat('GeneratedDiff', tabId, session.pairProgrammingMode, session.getConversationType(), this.#abTestingAllocation?.experimentName, this.#abTestingAllocation?.userVariation);
                         await chatResultStream.writeResultBlock(chatResult);
                         break;
-                    case qCodeReview_1.QCodeReview.toolName:
+                    case codeReview_1.CodeReview.toolName:
                         // no need to write tool result for code review, this is handled by model via chat
                         // Push result in message so that it is picked by IDE plugin to show in issues panel
-                        const qCodeReviewResult = result;
-                        if (qCodeReviewResult?.output?.kind === 'json' &&
-                            qCodeReviewResult.output.success &&
-                            qCodeReviewResult.output.content?.findingsByFile) {
+                        const codeReviewResult = result;
+                        if (codeReviewResult?.output?.kind === 'json' &&
+                            codeReviewResult.output.success &&
+                            codeReviewResult.output.content?.findingsByFile) {
                             await chatResultStream.writeResultBlock({
                                 type: 'tool',
-                                messageId: toolUse.toolUseId + qCodeReviewConstants_1.FINDINGS_MESSAGE_SUFFIX,
-                                body: qCodeReviewResult.output.content.findingsByFile,
+                                messageId: toolUse.toolUseId + codeReviewConstants_1.CODE_REVIEW_FINDINGS_MESSAGE_SUFFIX,
+                                body: codeReviewResult.output.content.findingsByFile,
+                            });
+                        }
+                        break;
+                    case displayFindings_1.DisplayFindings.toolName:
+                        // no need to write tool result for code review, this is handled by model via chat
+                        // Push result in message so that it is picked by IDE plugin to show in issues panel
+                        const displayFindingsResult = result;
+                        if (displayFindingsResult?.output?.kind === 'json' &&
+                            displayFindingsResult.output.success &&
+                            displayFindingsResult.output.content !== undefined) {
+                            await chatResultStream.writeResultBlock({
+                                type: 'tool',
+                                messageId: toolUse.toolUseId + codeReviewConstants_1.DISPLAY_FINDINGS_MESSAGE_SUFFIX,
+                                body: JSON.stringify(displayFindingsResult.output.content),
                             });
                         }
                         break;
@@ -1336,7 +1357,7 @@ class AgenticChatController {
                             });
                         }
                     }
-                    this.#telemetryController.emitToolUseSuggested(toolUse, session.conversationId ?? '', this.#features.runtime.serverInfo.version ?? '', latency, session.pairProgrammingMode, this.#abTestingAllocation?.experimentName, this.#abTestingAllocation?.userVariation);
+                    this.#telemetryController.emitToolUseSuggested(toolUse, session.conversationId ?? '', this.#features.runtime.serverInfo.version ?? '', latency, session.pairProgrammingMode, this.#abTestingAllocation?.experimentName, this.#abTestingAllocation?.userVariation, 'Succeeded');
                 }
             }
             catch (err) {
@@ -1370,6 +1391,10 @@ class AgenticChatController {
                         throw err;
                     }
                 }
+                else {
+                    // only emit if this is an actual tool error (not a user rejecting/canceling tool)
+                    this.#telemetryController.emitToolUseSuggested(toolUse, session.conversationId ?? '', this.#features.runtime.serverInfo.version ?? '', undefined, session.pairProgrammingMode, this.#abTestingAllocation?.experimentName, this.#abTestingAllocation?.userVariation, 'Failed');
+                }
                 // display fs write failure status in the UX of that file card
                 if ((toolUse.name === toolConstants_1.FS_WRITE || toolUse.name === toolConstants_1.FS_REPLACE) && toolUse.toolUseId) {
                     const existingCard = chatResultStream.getMessageBlockId(toolUse.toolUseId);
@@ -1585,7 +1610,7 @@ class AgenticChatController {
         });
     }
     #getWritableStream(chatResultStream, toolUse) {
-        if (toolUse.name === qCodeReview_1.QCodeReview.toolName) {
+        if (toolUse.name === codeReview_1.CodeReview.toolName) {
             return this.#getToolOverWritableStream(chatResultStream, toolUse);
         }
         if (toolUse.name !== toolConstants_1.EXECUTE_BASH) {
@@ -1757,7 +1782,7 @@ class AgenticChatController {
             },
         });
     }
-    #processCompactConfirmation(messageId) {
+    #processCompactConfirmation(messageId, characterCount) {
         const buttons = [{ id: 'allow-tools', text: 'Allow', icon: 'ok', status: 'clear' }];
         const header = {
             icon: 'warning',
@@ -1765,7 +1790,7 @@ class AgenticChatController {
             body: constants_2.COMPACTION_HEADER_BODY,
             buttons,
         };
-        const body = constants_2.COMPACTION_BODY;
+        const body = (0, constants_2.COMPACTION_BODY)(Math.round((characterCount / chatDb_1.MaxOverallCharacters) * 100));
         return {
             type: 'tool',
             messageId,
@@ -2741,7 +2766,7 @@ class AgenticChatController {
                         {
                             messageId,
                             type: 'tool',
-                            body: constants_2.COMPACTION_BODY,
+                            body: 'Compaction is skipped.',
                             header: {
                                 body: constants_2.COMPACTION_HEADER_BODY,
                                 status: { icon: 'block', text: 'Ignored' },