@aws/lsp-codewhisperer 0.0.68 → 0.0.70

package/CHANGELOG.md

@@ -1,5 +1,45 @@
 # Changelog
 
+## [0.0.70](https://github.com/aws/language-servers/compare/lsp-codewhisperer/v0.0.69...lsp-codewhisperer/v0.0.70) (2025-07-29)
+
+
+### Features
+
+* **amazonq:** add new model error handling code ([#1972](https://github.com/aws/language-servers/issues/1972)) ([905f0fc](https://github.com/aws/language-servers/commit/905f0fcbb274926d22bcf30600ad4bd419ac8ee4))
+* **amazonq:** enable compaction, minor UI changes ([#1979](https://github.com/aws/language-servers/issues/1979)) ([2b56ca8](https://github.com/aws/language-servers/commit/2b56ca87f442a06b554043fee86edd79f96c638d))
+* **amazonq:** enhance workspaceContext classpath generation ([#1955](https://github.com/aws/language-servers/issues/1955)) ([f7ed20b](https://github.com/aws/language-servers/commit/f7ed20bc4010996c508f6ea8ca87950e117e43c1))
+* **amazonq:** redirect /review, rename CodeReview tool, emit metrics, modify prompts ([#1964](https://github.com/aws/language-servers/issues/1964)) ([ad8e2db](https://github.com/aws/language-servers/commit/ad8e2db77e34f369fef9af71cdda2d3522f555c6))
+* **amazonq:** revert auto-approve ([#2002](https://github.com/aws/language-servers/issues/2002)) ([c8181f7](https://github.com/aws/language-servers/commit/c8181f7a1de224dfcc7a77cd0bfc905fa1018372))
+* enhance profile fetching logs to diagnose developerProfiles errors ([#1969](https://github.com/aws/language-servers/issues/1969)) ([eb688c2](https://github.com/aws/language-servers/commit/eb688c272df1251cd5c14ada7894bcaf625b6453))
+
+
+### Bug Fixes
+
+* **amazonq:** wrong path in the logs for the function ([#1978](https://github.com/aws/language-servers/issues/1978)) ([ed8b4f6](https://github.com/aws/language-servers/commit/ed8b4f6755accb624e7dc8c645ecd5cd9370a0f2))
+* emit metric for tool error ([#1954](https://github.com/aws/language-servers/issues/1954)) ([c3bbcea](https://github.com/aws/language-servers/commit/c3bbceabcea3d7aea2e414abc632c3a744b0e02b))
+* enable repomap for all users ([#1967](https://github.com/aws/language-servers/issues/1967)) ([6954085](https://github.com/aws/language-servers/commit/69540851e54b65729b2affbe3ae7d98629bdb5f4))
+* move network commands out of ro category ([#1985](https://github.com/aws/language-servers/issues/1985)) ([3cc9fd9](https://github.com/aws/language-servers/commit/3cc9fd91ae2f78ee28e224d5390ba78509de3615))
+* remove malicious characters from MCP tool description ([#1977](https://github.com/aws/language-servers/issues/1977)) ([64d4e3e](https://github.com/aws/language-servers/commit/64d4e3ebade706b01d256682cafe8d4ff8b85f41))
+
+## [0.0.69](https://github.com/aws/language-servers/compare/lsp-codewhisperer/v0.0.68...lsp-codewhisperer/v0.0.69) (2025-07-23)
+
+
+### Features
+
+* enable webforms to blazor transformation via validation bypass ([#1929](https://github.com/aws/language-servers/issues/1929)) ([528f820](https://github.com/aws/language-servers/commit/528f8206b101e8f0c785b7fc0aceb87d6ef3de7b))
+
+
+### Bug Fixes
+
+* **amazonq:** revert commit f17b631d9e06371a11ef8e9cb1413762fb51a143 ([#1965](https://github.com/aws/language-servers/issues/1965)) ([8c2cab6](https://github.com/aws/language-servers/commit/8c2cab6995922c96030b5bbdf3cbbdef7eadd7c2))
+* **amazonq:** stop continuous monitor when WCS sees ServiceQuotaExceeded ([#1957](https://github.com/aws/language-servers/issues/1957)) ([81e19b9](https://github.com/aws/language-servers/commit/81e19b97017edddf486ac92fa6a8dc5fb184e008))
+* fix for mcp delete to remove it from mcp config file ([#1956](https://github.com/aws/language-servers/issues/1956)) ([ad71312](https://github.com/aws/language-servers/commit/ad713122fcb9da90c17301f1312de13ba1d28d01))
+
+
+### Reverts
+
+* revert for all commits for emergency deployment ([#1966](https://github.com/aws/language-servers/issues/1966)) ([519f75d](https://github.com/aws/language-servers/commit/519f75d22466b72702793b4f1d1ed846c02bbd14))
+
 ## [0.0.68](https://github.com/aws/language-servers/compare/lsp-codewhisperer/v0.0.67...lsp-codewhisperer/v0.0.68) (2025-07-22)
 
 

package/out/language-server/agenticChat/agenticChatController.js

@@ -51,8 +51,8 @@ const errors_2 = require("./errors");
 const vscode_uri_1 = require("vscode-uri");
 const executeBash_2 = require("./tools/executeBash");
 const userWrittenCodeTracker_1 = require("../../shared/userWrittenCodeTracker");
-const qCodeReview_1 = require("./tools/qCodeAnalysis/qCodeReview");
-const qCodeReviewConstants_1 = require("./tools/qCodeAnalysis/qCodeReviewConstants");
+const codeReview_1 = require("./tools/qCodeAnalysis/codeReview");
+const codeReviewConstants_1 = require("./tools/qCodeAnalysis/codeReviewConstants");
 const mcpEventHandler_1 = require("./tools/mcp/mcpEventHandler");
 const mcpUtils_1 = require("./tools/mcp/mcpUtils");
 const mcpManager_1 = require("./tools/mcp/mcpManager");
@@ -64,7 +64,6 @@ const imageVerification_1 = require("../../shared/imageVerification");
 const path_1 = require("@aws/lsp-core/out/util/path");
 const agenticChatControllerHelper_1 = require("./utils/agenticChatControllerHelper");
 const activeUserTracker_1 = require("../../shared/activeUserTracker");
-const qAgenticChatServer_1 = require("./qAgenticChatServer");
 class AgenticChatController {
     #features;
     #chatSessionManagementService;
@@ -549,7 +548,7 @@ class AgenticChatController {
                 const promptId = crypto.randomUUID();
                 session.setCurrentPromptId(promptId);
                 // Start the compaction call
-                finalResult = await this.#runCompaction(compactionRequestInput, session, metric, chatResultStream, params.tabId, promptId, session.conversationId, token, triggerContext.documentReference);
+                finalResult = await this.#runCompaction(compactionRequestInput, session, metric, chatResultStream, params.tabId, promptId, types_1.CompactHistoryActionType.Manual, session.conversationId, token, triggerContext.documentReference);
             }
             else {
                 // Get the initial request input
@@ -615,7 +614,7 @@ class AgenticChatController {
      */
     #shouldCompact(currentRequestCount) {
         // 80% of 570K limit
-        if ((0, qAgenticChatServer_1.enabledCompaction)(this.#features.lsp.getClientInitializeParams()) && currentRequestCount > 456_000) {
+        if (currentRequestCount > 456_000) {
             this.#debug(`Current request total character count is: ${currentRequestCount}, prompting user to compact`);
             return true;
         }
@@ -626,7 +625,7 @@ class AgenticChatController {
     /**
      * Runs the compaction to compact history into a single summary
      */
-    async #runCompaction(compactionRequestInput, session, metric, chatResultStream, tabId, promptId, conversationIdentifier, token, documentReference) {
+    async #runCompaction(compactionRequestInput, session, metric, chatResultStream, tabId, promptId, type, conversationIdentifier, token, documentReference) {
         let currentRequestInput = { ...compactionRequestInput };
         let finalResult = null;
         metric.recordStart();
@@ -684,21 +683,24 @@ class AgenticChatController {
             });
         }
         await resultStreamWriter.close();
+        session.setConversationType('AgenticChatWithCompaction');
+        const conversationType = session.getConversationType();
+        metric.setDimension('cwsprChatConversationType', conversationType);
+        this.#telemetryController.emitCompactHistory(type, characterCount, this.#features.runtime.serverInfo.version ?? '');
         // Add loading message before making the request
         const loadingMessageId = `loading-${(0, uuid_1.v4)()}`;
         await chatResultStream.writeResultBlock({ ...constants_1.loadingMessage, messageId: loadingMessageId });
         this.#debug(`Compacting history with ${characterCount} characters`);
         this.#llmRequestStartTime = Date.now();
         // Phase 3: Request Execution
-        // Note: these logs are very noisy, but contain information redacted on the backend.
-        this.#debug(`generateAssistantResponse/SendMessage Request: ${JSON.stringify(currentRequestInput, undefined, 2)}`);
+        this.#debug(`Compaction Request: ${JSON.stringify(currentRequestInput, undefined, 2)}`);
         const response = await session.getChatResponse(currentRequestInput);
         if (response.$metadata.requestId) {
             metric.mergeWith({
                 requestIds: [response.$metadata.requestId],
             });
         }
-        this.#features.logging.info(`generateAssistantResponse/SendMessage ResponseMetadata: ${lsp_core_2.loggingUtils.formatObj(response.$metadata)}`);
+        this.#features.logging.info(`Compaction ResponseMetadata: ${lsp_core_2.loggingUtils.formatObj(response.$metadata)}`);
         await chatResultStream.removeResultBlock(loadingMessageId);
         // Phase 4: Response Processing
         const result = await this.#processAgenticChatResponseWithTimeout(response, metric.mergeWith({
@@ -923,13 +925,13 @@ class AgenticChatController {
         }
         if (this.#shouldCompact(currentRequestCount)) {
             const messageId = this.#getMessageIdForCompact((0, uuid_1.v4)());
-            const confirmationResult = this.#processCompactConfirmation(messageId);
+            const confirmationResult = this.#processCompactConfirmation(messageId, currentRequestCount);
             const cachedButtonBlockId = await chatResultStream.writeResultBlock(confirmationResult);
             await this.waitForCompactApproval(messageId, chatResultStream, cachedButtonBlockId, session);
             // Get the compaction request input
             const compactionRequestInput = this.#getCompactionRequestInput(session);
             // Start the compaction call
-            return await this.#runCompaction(compactionRequestInput, session, metric, chatResultStream, tabId, promptId, session.conversationId, token, documentReference);
+            return await this.#runCompaction(compactionRequestInput, session, metric, chatResultStream, tabId, promptId, types_1.CompactHistoryActionType.Nudge, session.conversationId, token, documentReference);
         }
         return (finalResult || {
             success: false,
@@ -1141,35 +1143,24 @@ class AgenticChatController {
                         const { Tool } = toolMap[toolUse.name];
                         const tool = new Tool(this.#features);
                         // For MCP tools, get the permission from McpManager
-                        const permission = mcpManager_1.McpManager.instance.getToolPerm('Built-in', toolUse.name);
+                        // const permission = McpManager.instance.getToolPerm('Built-in', toolUse.name)
                         // If permission is 'alwaysAllow', we don't need to ask for acceptance
-                        const builtInPermission = permission !== 'alwaysAllow';
+                        // const builtInPermission = permission !== 'alwaysAllow'
                         // Get the approved paths from the session
                         const approvedPaths = session.approvedPaths;
                         // Pass the approved paths to the tool's requiresAcceptance method
                         const { requiresAcceptance, warning, commandCategory } = await tool.requiresAcceptance(toolUse.input, approvedPaths);
-                        const isExecuteBash = toolUse.name === toolConstants_1.EXECUTE_BASH;
-                        // check if tool execution's path is out of workspace
-                        const isOutOfWorkSpace = warning === constants_2.OUT_OF_WORKSPACE_WARNING_MSG;
-                        // check if tool involved secured files
-                        const isSecuredFilesInvoled = warning === constants_2.BINARY_FILE_WARNING_MSG || warning === constants_2.CREDENTIAL_FILE_WARNING_MSG;
                         // Honor built-in permission if available, otherwise use tool's requiresAcceptance
-                        let toolRequiresAcceptance = (builtInPermission || isOutOfWorkSpace || isSecuredFilesInvoled) ?? requiresAcceptance;
-                        // if the command is read-only and in-workspace --> flip back to no approval needed
-                        if (isExecuteBash &&
-                            commandCategory === executeBash_2.CommandCategory.ReadOnly &&
-                            !isOutOfWorkSpace &&
-                            !requiresAcceptance) {
-                            toolRequiresAcceptance = false;
-                        }
-                        if (toolRequiresAcceptance || isExecuteBash) {
+                        // const requiresAcceptance = builtInPermission || toolRequiresAcceptance
+                        if (requiresAcceptance || toolUse.name === toolConstants_1.EXECUTE_BASH) {
                             // for executeBash, we till send the confirmation message without action buttons
-                            const confirmationResult = this.#processToolConfirmation(toolUse, toolRequiresAcceptance, warning, commandCategory, toolUse.name, builtInPermission);
+                            const confirmationResult = this.#processToolConfirmation(toolUse, requiresAcceptance, warning, commandCategory);
                             cachedButtonBlockId = await chatResultStream.writeResultBlock(confirmationResult);
+                            const isExecuteBash = toolUse.name === toolConstants_1.EXECUTE_BASH;
                             if (isExecuteBash) {
                                 this.#telemetryController.emitInteractWithAgenticChat('GeneratedCommand', tabId, session.pairProgrammingMode, session.getConversationType(), this.#abTestingAllocation?.experimentName, this.#abTestingAllocation?.userVariation);
                             }
-                            if (toolRequiresAcceptance) {
+                            if (requiresAcceptance) {
                                 await this.waitForToolApproval(toolUse, chatResultStream, cachedButtonBlockId, session, toolUse.name);
                             }
                             if (isExecuteBash) {
@@ -1178,7 +1169,7 @@ class AgenticChatController {
                         }
                         break;
                     }
-                    case qCodeReview_1.QCodeReview.toolName:
+                    case codeReview_1.CodeReview.toolName:
                         // no need to write tool message for code review
                         break;
                     // — DEFAULT ⇒ Only MCP tools, but can also handle generic tool execution messages
@@ -1230,7 +1221,7 @@ class AgenticChatController {
                         fileChange: { before: document?.getText() },
                     });
                 }
-                if (toolUse.name === qCodeReview_1.QCodeReview.toolName) {
+                if (toolUse.name === codeReview_1.CodeReview.toolName) {
                     try {
                         let initialInput = JSON.parse(JSON.stringify(toolUse.input));
                         let ruleArtifacts = await this.#additionalContextProvider.collectWorkspaceRules(tabId);
@@ -1243,7 +1234,7 @@ class AgenticChatController {
                         toolUse.input = initialInput;
                     }
                     catch (e) {
-                        this.#features.logging.warn(`could not parse QCodeReview tool input: ${e}`);
+                        this.#features.logging.warn(`could not parse CodeReview tool input: ${e}`);
                     }
                 }
                 // After approval, add the path to the approved paths in the session
@@ -1313,17 +1304,17 @@ class AgenticChatController {
                         this.#telemetryController.emitInteractWithAgenticChat('GeneratedDiff', tabId, session.pairProgrammingMode, session.getConversationType(), this.#abTestingAllocation?.experimentName, this.#abTestingAllocation?.userVariation);
                         await chatResultStream.writeResultBlock(chatResult);
                         break;
-                    case qCodeReview_1.QCodeReview.toolName:
+                    case codeReview_1.CodeReview.toolName:
                         // no need to write tool result for code review, this is handled by model via chat
                         // Push result in message so that it is picked by IDE plugin to show in issues panel
-                        const qCodeReviewResult = result;
-                        if (qCodeReviewResult?.output?.kind === 'json' &&
-                            qCodeReviewResult.output.success &&
-                            qCodeReviewResult.output.content?.findingsByFile) {
+                        const codeReviewResult = result;
+                        if (codeReviewResult?.output?.kind === 'json' &&
+                            codeReviewResult.output.success &&
+                            codeReviewResult.output.content?.findingsByFile) {
                             await chatResultStream.writeResultBlock({
                                 type: 'tool',
-                                messageId: toolUse.toolUseId + qCodeReviewConstants_1.FINDINGS_MESSAGE_SUFFIX,
-                                body: qCodeReviewResult.output.content.findingsByFile,
+                                messageId: toolUse.toolUseId + codeReviewConstants_1.FINDINGS_MESSAGE_SUFFIX,
+                                body: codeReviewResult.output.content.findingsByFile,
                             });
                         }
                         break;
@@ -1347,7 +1338,7 @@ class AgenticChatController {
                             });
                         }
                     }
-                    this.#telemetryController.emitToolUseSuggested(toolUse, session.conversationId ?? '', this.#features.runtime.serverInfo.version ?? '', latency, session.pairProgrammingMode, this.#abTestingAllocation?.experimentName, this.#abTestingAllocation?.userVariation);
+                    this.#telemetryController.emitToolUseSuggested(toolUse, session.conversationId ?? '', this.#features.runtime.serverInfo.version ?? '', latency, session.pairProgrammingMode, this.#abTestingAllocation?.experimentName, this.#abTestingAllocation?.userVariation, 'Succeeded');
                 }
             }
             catch (err) {
@@ -1381,6 +1372,10 @@ class AgenticChatController {
                         throw err;
                     }
                 }
+                else {
+                    // only emit if this is an actual tool error (not a user rejecting/canceling tool)
+                    this.#telemetryController.emitToolUseSuggested(toolUse, session.conversationId ?? '', this.#features.runtime.serverInfo.version ?? '', undefined, session.pairProgrammingMode, this.#abTestingAllocation?.experimentName, this.#abTestingAllocation?.userVariation, 'Failed');
+                }
                 // display fs write failure status in the UX of that file card
                 if ((toolUse.name === toolConstants_1.FS_WRITE || toolUse.name === toolConstants_1.FS_REPLACE) && toolUse.toolUseId) {
                     const existingCard = chatResultStream.getMessageBlockId(toolUse.toolUseId);
@@ -1596,7 +1591,7 @@ class AgenticChatController {
         });
     }
     #getWritableStream(chatResultStream, toolUse) {
-        if (toolUse.name === qCodeReview_1.QCodeReview.toolName) {
+        if (toolUse.name === codeReview_1.CodeReview.toolName) {
             return this.#getToolOverWritableStream(chatResultStream, toolUse);
         }
         if (toolUse.name !== toolConstants_1.EXECUTE_BASH) {
@@ -1768,7 +1763,7 @@ class AgenticChatController {
             },
         });
     }
-    #processCompactConfirmation(messageId) {
+    #processCompactConfirmation(messageId, characterCount) {
         const buttons = [{ id: 'allow-tools', text: 'Allow', icon: 'ok', status: 'clear' }];
         const header = {
             icon: 'warning',
@@ -1776,7 +1771,7 @@ class AgenticChatController {
             body: constants_2.COMPACTION_HEADER_BODY,
             buttons,
         };
-        const body = constants_2.COMPACTION_BODY;
+        const body = (0, constants_2.COMPACTION_BODY)(Math.round((characterCount / chatDb_1.MaxOverallCharacters) * 100));
         return {
             type: 'tool',
             messageId,
@@ -1975,7 +1970,7 @@ class AgenticChatController {
                         ? `I need permission to read files.\n${formattedPaths.join('\n')}`
                         : `I need permission to read files outside the workspace.\n${formattedPaths.join('\n')}`;
                 }
-                else if (toolName === 'listDirectory') {
+                else {
                     const readFilePath = toolUse.input.path;
                     // Validate the path using our synchronous utility
                     (0, pathValidation_1.validatePathExists)(readFilePath);
@@ -1984,12 +1979,6 @@ class AgenticChatController {
                         ? `I need permission to list directories.\n\`${readFilePath}\``
                         : `I need permission to list directories outside the workspace.\n\`${readFilePath}\``;
                 }
-                else {
-                    const readFilePath = toolUse.input.path;
-                    body = builtInPermission
-                        ? `I need permission to search files.\n\`${readFilePath}\``
-                        : `I need permission to search files outside the workspace.\n\`${readFilePath}\``;
-                }
                 break;
             }
             default: {
@@ -2758,7 +2747,7 @@ class AgenticChatController {
                         {
                             messageId,
                             type: 'tool',
-                            body: constants_2.COMPACTION_BODY,
+                            body: 'Compaction is skipped.',
                             header: {
                                 body: constants_2.COMPACTION_HEADER_BODY,
                                 status: { icon: 'block', text: 'Ignored' },