@aws-amplify/storage 4.4.18 → 4.4.19

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.4.19](https://github.com/aws-amplify/amplify-js/compare/@aws-amplify/storage@4.4.18...@aws-amplify/storage@4.4.19) (2022-03-28)
+
+
+### Bug Fixes
+
+* **storage:** axios handler error handling fix ([#9587](https://github.com/aws-amplify/amplify-js/issues/9587)) ([2ceaa44](https://github.com/aws-amplify/amplify-js/commit/2ceaa44ce88c96e9121b903c0d9798e4a918df4a))
+
+
+
+
+
 ## [4.4.18](https://github.com/aws-amplify/amplify-js/compare/@aws-amplify/storage@4.4.17...@aws-amplify/storage@4.4.18) (2022-03-22)
 
 **Note:** Version bump only for package @aws-amplify/storage

package/dist/aws-amplify-storage.js

@@ -51050,6 +51050,10 @@ function isBlob(body) {
   return typeof Blob !== 'undefined' && body instanceof Blob;
 }
 
+function hasErrorResponse(error) {
+  return typeof error !== 'undefined' && Object.prototype.hasOwnProperty.call(error, 'response') && typeof error.response !== 'undefined' && Object.prototype.hasOwnProperty.call(error.response, 'status') && typeof error.response.status === 'number';
+}
+
 var normalizeHeaders = function normalizeHeaders(headers, normalizedName) {
   var e_1, _a;
 
@@ -51193,16 +51197,20 @@ function () {
         })
       };
     })["catch"](function (error) {
-      var _a, _b, _c; // Error
+      var _a, _b; // Error
 
 
       if (error.message !== _common_StorageErrorStrings__WEBPACK_IMPORTED_MODULE_4__["AWSS3ProviderUploadErrorStrings"].UPLOAD_PAUSED_MESSAGE) {
         logger.error(error.message);
       } // for axios' cancel error, we should re-throw it back so it's not considered an s3client error
-      // if we return empty, or an abitrary error HttpResponse, it will be hard to debug down the line
+      // if we return empty, or an abitrary error HttpResponse, it will be hard to debug down the line.
+      //
+      // for errors that does not have a 'response' object, it's very likely that it is an unexpected error for
+      // example a disconnect. Without it we cannot meaningfully reconstruct a HttpResponse, and the AWS SDK might
+      // consider the request successful by mistake. In this case we should also re-throw the error.
 
 
-      if (axios__WEBPACK_IMPORTED_MODULE_2___default.a.isCancel(error)) {
+      if (axios__WEBPACK_IMPORTED_MODULE_2___default.a.isCancel(error) || !hasErrorResponse(error)) {
         throw error;
       } // otherwise, we should re-construct an HttpResponse from the error, so that it can be passed down to other
       // aws sdk middleware (e.g retry, clock skew correction, error message serializing)
@@ -51210,9 +51218,9 @@ function () {
 
       return {
         response: new _aws_sdk_protocol_http__WEBPACK_IMPORTED_MODULE_0__["HttpResponse"]({
-          statusCode: (_a = error.response) === null || _a === void 0 ? void 0 : _a.status,
-          body: (_b = error.response) === null || _b === void 0 ? void 0 : _b.data,
-          headers: (_c = error.response) === null || _c === void 0 ? void 0 : _c.headers
+          statusCode: error.response.status,
+          body: (_a = error.response) === null || _a === void 0 ? void 0 : _a.data,
+          headers: (_b = error.response) === null || _b === void 0 ? void 0 : _b.headers
         })
       };
     }), requestTimeout(requestTimeoutInMs)];