@aws-amplify/api-graphql 4.0.19 → 4.0.20-api-graphql-eslint.dd94c10.0

package/src/internals/APIClient.ts

@@ -1,15 +1,18 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
-import { resolveOwnerFields } from '../utils/resolveOwnerFields';
 import {
+	AssociationBelongsTo,
+	AssociationHasOne,
 	GraphQLAuthMode,
-	ModelIntrospectionSchema,
 	ModelFieldType,
+	ModelIntrospectionSchema,
 	NonModelFieldType,
 	SchemaModel,
-	AssociationHasOne,
-	AssociationBelongsTo,
+	SchemaNonModel,
 } from '@aws-amplify/core/internals/utils';
+import { AmplifyServer } from '@aws-amplify/core/internals/adapter-core';
+import { CustomHeaders } from '@aws-amplify/data-schema-types';
+
 import {
 	AuthModeParams,
 	ClientWithModels,
@@ -21,18 +24,17 @@ import {
 	__authToken,
 	__headers,
 } from '../types';
-import { AmplifyServer } from '@aws-amplify/core/internals/adapter-core';
-import { CustomHeaders } from '@aws-amplify/data-schema-types';
-import { SchemaNonModel } from '@aws-amplify/core/dist/esm/singleton/API/types';
+import { resolveOwnerFields } from '../utils/resolveOwnerFields';
+
 import type { IndexMeta } from './operations/indexQuery';
 
-type LazyLoadOptions = {
+interface LazyLoadOptions {
 	authMode?: GraphQLAuthMode;
 	authToken?: string | undefined;
 	limit?: number | undefined;
 	nextToken?: string | undefined | null;
 	headers?: CustomHeaders | undefined;
-};
+}
 
 const connectionType = {
 	HAS_ONE: 'HAS_ONE',
@@ -54,9 +56,11 @@ export const flattenItems = (obj: Record<string, any>): Record<string, any> => {
 				res[prop] = value.items.map((item: Record<string, any>) =>
 					flattenItems(item),
 				);
+
 				return;
 			}
 			res[prop] = flattenItems(value);
+
 			return;
 		}
 
@@ -109,15 +113,17 @@ export function initializeModel(
 				connectionFields = modelField.association.associatedWith;
 			}
 
-			let targetNames: string[] = [];
+			const targetNames: string[] = [];
 			if (modelField.association && 'targetNames' in modelField.association) {
-				targetNames = modelField.association.targetNames;
+				targetNames.push(...modelField.association.targetNames);
 			}
 
 			switch (relationType) {
 				case connectionType.HAS_ONE:
-				case connectionType.BELONGS_TO:
+				case connectionType.BELONGS_TO: {
 					const sortKeyValues = relatedModelSKFieldNames.reduce(
+						// TODO(Eslint): is this implementation correct?
+						// eslint-disable-next-line array-callback-return
 						(acc: Record<string, any>, curVal) => {
 							if (record[curVal]) {
 								return (acc[curVal] = record[curVal]);
@@ -146,6 +152,7 @@ export function initializeModel(
 									},
 								);
 							}
+
 							return undefined;
 						};
 					} else {
@@ -166,12 +173,14 @@ export function initializeModel(
 									},
 								);
 							}
+
 							return undefined;
 						};
 					}
 
 					break;
-				case connectionType.HAS_MANY:
+				}
+				case connectionType.HAS_MANY: {
 					const parentPk = introModel.primaryKeyInfo.primaryKeyFieldName;
 					const parentSK = introModel.primaryKeyInfo.sortKeyFieldNames;
 
@@ -214,6 +223,7 @@ export function initializeModel(
 										authToken: options?.authToken || authToken,
 									});
 								}
+
 								return [];
 							};
 						} else {
@@ -231,6 +241,7 @@ export function initializeModel(
 										authToken: options?.authToken || authToken,
 									});
 								}
+
 								return [];
 							};
 						}
@@ -264,6 +275,7 @@ export function initializeModel(
 									authToken: options?.authToken || authToken,
 								});
 							}
+
 							return [];
 						};
 					} else {
@@ -281,11 +293,13 @@ export function initializeModel(
 									authToken: options?.authToken || authToken,
 								});
 							}
+
 							return [];
 						};
 					}
 
 					break;
+				}
 				default:
 					break;
 			}
@@ -309,12 +323,9 @@ export const graphQLOperationsInfo = {
 } as const;
 export type ModelOperation = keyof typeof graphQLOperationsInfo;
 
-type OperationPrefix =
-	(typeof graphQLOperationsInfo)[ModelOperation]['operationPrefix'];
-
 const SELECTION_SET_WILDCARD = '*';
 
-function defaultSelectionSetForNonModelWithIR(
+export function defaultSelectionSetForNonModelWithIR(
 	nonModelDefinition: SchemaNonModel,
 	modelIntrospection: ModelIntrospectionSchema,
 ): Record<string, unknown> {
@@ -346,6 +357,7 @@ function defaultSelectionSetForNonModelWithIR(
 				pair: (string | Record<string, unknown>)[] | undefined,
 			): pair is (string | Record<string, unknown>)[] => pair !== undefined,
 		);
+
 	return Object.fromEntries(mappedFields);
 }
 
@@ -365,6 +377,8 @@ function defaultSelectionSetForModel(modelDefinition: SchemaModel): string[] {
 					return `${name}.${SELECTION_SET_WILDCARD}`;
 				}
 			}
+
+			return undefined;
 		})
 		.filter(Boolean);
 
@@ -460,10 +474,13 @@ export function customSelectionSetToIR(
 			}
 
 			if (nested === SELECTION_SET_WILDCARD) {
-				const relatedModelDefinition = modelIntrospection.models[relatedModel];
+				const nestedRelatedModelDefinition =
+					modelIntrospection.models[relatedModel];
 
 				result = {
-					[fieldName]: modelsDefaultSelectionSetIR(relatedModelDefinition),
+					[fieldName]: modelsDefaultSelectionSetIR(
+						nestedRelatedModelDefinition,
+					),
 				};
 			} else {
 				result = {
@@ -527,6 +544,7 @@ const modelsDefaultSelectionSetIR = (relatedModelDefinition: SchemaModel) => {
 	const reduced = defaultSelectionSet.reduce(
 		(acc: Record<string, any>, curVal) => {
 			acc[curVal] = FIELD_IR;
+
 			return acc;
 		},
 		{},
@@ -594,9 +612,12 @@ function deepMergeSelectionSetObjects<T extends Record<string, any>>(
 
 	for (const key in source) {
 		// This verification avoids 'Prototype Pollution' issue
-		if (!source.hasOwnProperty(key)) continue;
+		if (!Object.prototype.hasOwnProperty.call(source, key)) continue;
 
-		if (target.hasOwnProperty(key) && isObject(target[key])) {
+		if (
+			Object.prototype.hasOwnProperty.call(target, key) &&
+			isObject(target[key])
+		) {
 			deepMergeSelectionSetObjects(source[key], target[key]);
 		} else {
 			target[key] = source[key];
@@ -659,6 +680,7 @@ export function generateGraphQLDocument(
 		const skQueryArgs = sk.reduce((acc: Record<string, any>, fieldName) => {
 			const fieldType = fields[fieldName].type;
 			acc[fieldName] = `Model${fieldType}KeyConditionInput`;
+
 			return acc;
 		}, {});
 
@@ -694,6 +716,8 @@ export function generateGraphQLDocument(
 					}${name}Input!`,
 				});
 			graphQLOperationType ?? (graphQLOperationType = 'mutation');
+		// TODO(Eslint): this this case clause correct without the break statement?
+		// eslint-disable-next-line no-fallthrough
 		case 'READ':
 			graphQLArguments ??
 				(graphQLArguments = isCustomPrimaryKey
@@ -709,6 +733,8 @@ export function generateGraphQLDocument(
 							[primaryKeyFieldName]: `${fields[primaryKeyFieldName].type}!`,
 						});
 			graphQLSelectionSet ?? (graphQLSelectionSet = selectionSetFields);
+		// TODO(Eslint): this this case clause correct without the break statement?
+		// eslint-disable-next-line no-fallthrough
 		case 'LIST':
 			graphQLArguments ??
 				(graphQLArguments = {
@@ -719,6 +745,8 @@ export function generateGraphQLDocument(
 			graphQLOperationType ?? (graphQLOperationType = 'query');
 			graphQLSelectionSet ??
 				(graphQLSelectionSet = `items { ${selectionSetFields} } nextToken __typename`);
+		// TODO(Eslint): this this case clause correct without the break statement?
+		// eslint-disable-next-line no-fallthrough
 		case 'INDEX_QUERY':
 			graphQLArguments ??
 				(graphQLArguments = {
@@ -730,6 +758,8 @@ export function generateGraphQLDocument(
 			graphQLOperationType ?? (graphQLOperationType = 'query');
 			graphQLSelectionSet ??
 				(graphQLSelectionSet = `items { ${selectionSetFields} } nextToken __typename`);
+		// TODO(Eslint): this this case clause correct without the break statement?
+		// eslint-disable-next-line no-fallthrough
 		case 'ONCREATE':
 		case 'ONUPDATE':
 		case 'ONDELETE':
@@ -750,13 +780,13 @@ export function generateGraphQLDocument(
 	const graphQLDocument = `${graphQLOperationType}${
 		graphQLArguments
 			? `(${Object.entries(graphQLArguments).map(
-					([fieldName, type]) => `\$${fieldName}: ${type}`,
+					([fieldName, type]) => `$${fieldName}: ${type}`,
 				)})`
 			: ''
 	} { ${graphQLFieldName}${
 		graphQLArguments
 			? `(${Object.keys(graphQLArguments).map(
-					fieldName => `${fieldName}: \$${fieldName}`,
+					fieldName => `${fieldName}: $${fieldName}`,
 				)})`
 			: ''
 	} { ${graphQLSelectionSet} } }`;
@@ -842,7 +872,7 @@ export function buildGraphQLVariables(
 				variables.limit = arg.limit;
 			}
 			break;
-		case 'INDEX_QUERY':
+		case 'INDEX_QUERY': {
 			const { pk, sk = [] } = indexMeta!;
 
 			variables[pk] = arg![pk];
@@ -861,6 +891,7 @@ export function buildGraphQLVariables(
 				variables.limit = arg.limit;
 			}
 			break;
+		}
 		case 'ONCREATE':
 		case 'ONUPDATE':
 		case 'ONDELETE':
@@ -873,9 +904,10 @@ export function buildGraphQLVariables(
 				'Internal error: Attempted to build variables for observeQuery. Please report this error.',
 			);
 			break;
-		default:
+		default: {
 			const exhaustiveCheck: never = operation;
 			throw new Error(`Unhandled operation case: ${exhaustiveCheck}`);
+		}
 	}
 
 	return variables;
@@ -969,9 +1001,9 @@ export function authModeParams(
 
 /**
  * Retrieves custom headers from either the client or request options.
- * @param {client} V6Client | V6ClientSSRRequest | V6ClientSSRCookies - for extracting client headers
- * @param {requestHeaders} [CustomHeaders] - request headers
- * @returns {CustomHeaders} - custom headers
+ * @param client V6Client | V6ClientSSRRequest | V6ClientSSRCookies - for extracting client headers
+ * @param requestHeaders {@link CustomHeaders} - request headers
+ * @returns custom headers as {@link CustomHeaders}
  */
 export function getCustomHeaders(
 	client: V6Client | ClientWithModels,

package/src/internals/InternalGraphQLAPI.ts

@@ -2,41 +2,40 @@
 // SPDX-License-Identifier: Apache-2.0
 import {
 	DocumentNode,
-	OperationDefinitionNode,
-	print,
-	parse,
 	GraphQLError,
+	OperationDefinitionNode,
 	OperationTypeNode,
+	parse,
+	print,
 } from 'graphql';
 import { Observable, catchError } from 'rxjs';
-import { AmplifyClassV6, ConsoleLogger } from '@aws-amplify/core';
+import { AmplifyClassV6 } from '@aws-amplify/core';
 import {
-	GraphQLAuthMode,
+	AmplifyUrl,
 	CustomUserAgentDetails,
+	GraphQLAuthMode,
 	getAmplifyUserAgent,
-	AmplifyUrl,
 } from '@aws-amplify/core/internals/utils';
-import {
-	GraphQLAuthError,
-	GraphQLResult,
-	GraphQLOperation,
-	GraphQLOptions,
-} from '../types';
 import { isCancelError as isCancelErrorREST } from '@aws-amplify/api-rest';
 import {
-	post,
 	cancel as cancelREST,
+	post,
 	updateRequestToBeCancellable,
 } from '@aws-amplify/api-rest/internals';
-import { AWSAppSyncRealTimeProvider } from '../Providers/AWSAppSyncRealTimeProvider';
 import { CustomHeaders, RequestOptions } from '@aws-amplify/data-schema-types';
+
+import { AWSAppSyncRealTimeProvider } from '../Providers/AWSAppSyncRealTimeProvider';
+import {
+	GraphQLAuthError,
+	GraphQLOperation,
+	GraphQLOptions,
+	GraphQLResult,
+} from '../types';
 import { resolveConfig, resolveLibraryOptions } from '../utils';
 import { repackageUnauthError } from '../utils/errors/repackageAuthError';
 
 const USER_AGENT_HEADER = 'x-amz-user-agent';
 
-const logger = new ConsoleLogger('GraphQLAPI');
-
 const isAmplifyInstance = (
 	amplify:
 		| AmplifyClassV6
@@ -70,11 +69,7 @@ export class InternalGraphQLAPIClass {
 		authMode: GraphQLAuthMode,
 		additionalHeaders: Record<string, string> = {},
 	) {
-		const {
-			region: region,
-			endpoint: appSyncGraphqlEndpoint,
-			apiKey,
-		} = resolveConfig(amplify);
+		const { apiKey } = resolveConfig(amplify);
 
 		let headers = {};
 
@@ -87,18 +82,17 @@ export class InternalGraphQLAPIClass {
 					'X-Api-Key': apiKey,
 				};
 				break;
-			case 'iam':
+			case 'iam': {
 				const session = await amplify.Auth.fetchAuthSession();
 				if (session.credentials === undefined) {
 					throw new Error(GraphQLAuthError.NO_CREDENTIALS);
 				}
 				break;
+			}
 			case 'oidc':
 			case 'userPool':
 				try {
-					let token;
-
-					token = (
+					const token = (
 						await amplify.Auth.fetchAuthSession()
 					).tokens?.accessToken.toString();
 
@@ -139,8 +133,7 @@ export class InternalGraphQLAPIClass {
 	 */
 	getGraphqlOperationType(operation: GraphQLOperation): OperationTypeNode {
 		const doc = parse(operation);
-		const definitions =
-			doc.definitions as ReadonlyArray<OperationDefinitionNode>;
+		const definitions = doc.definitions as readonly OperationDefinitionNode[];
 		const [{ operation: operationType }] = definitions;
 
 		return operationType;
@@ -176,7 +169,7 @@ export class InternalGraphQLAPIClass {
 
 		switch (operationType) {
 			case 'query':
-			case 'mutation':
+			case 'mutation': {
 				const abortController = new AbortController();
 
 				let responsePromise: Promise<GraphQLResult<T>>;
@@ -215,7 +208,9 @@ export class InternalGraphQLAPIClass {
 					responsePromise,
 					abortController,
 				);
+
 				return responsePromise;
+			}
 			case 'subscription':
 				return this._graphqlSubscribe(
 					amplify as AmplifyClassV6,
@@ -238,7 +233,7 @@ export class InternalGraphQLAPIClass {
 		authToken?: string,
 	): Promise<GraphQLResult<T>> {
 		const {
-			region: region,
+			region,
 			endpoint: appSyncGraphqlEndpoint,
 			customEndpoint,
 			customEndpointRegion,
@@ -356,7 +351,8 @@ export class InternalGraphQLAPIClass {
 
 		if (!endpoint) {
 			const error = new GraphQLError('No graphql endpoint provided.');
-
+			// TODO(Eslint): refactor this to throw an Error instead of a plain object
+			// eslint-disable-next-line no-throw-literal
 			throw {
 				data: {},
 				errors: [error],

package/src/internals/clientUtils.ts

@@ -2,8 +2,8 @@
 // SPDX-License-Identifier: Apache-2.0
 
 import type {
-	SchemaModel,
 	ModelAttribute,
+	SchemaModel,
 	SecondaryIndexAttribute,
 } from '@aws-amplify/core/internals/utils';
 

package/src/internals/generateClient.ts

@@ -1,20 +1,13 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 import { Hub } from '@aws-amplify/core';
-import { graphql, cancel, isCancelError } from './v6';
 import {
+	CustomMutations,
+	CustomQueries,
 	EnumTypes,
 	ModelTypes,
-	CustomQueries,
-	CustomMutations,
 } from '@aws-amplify/data-schema-types';
-import { generateEnumsProperty } from './utils/generateEnumsProperty';
-import { generateModelsProperty } from './utils/generateModelsProperty';
-import { isApiGraphQLConfig } from './utils/isApiGraphQLProviderConfig';
-import {
-	generateCustomQueriesProperty,
-	generateCustomMutationsProperty,
-} from './generateCustomOperationsProperty';
+
 import {
 	V6Client,
 	__amplify,
@@ -22,8 +15,17 @@ import {
 	__authToken,
 	__headers,
 } from '../types';
+
+import { cancel, graphql, isCancelError } from './v6';
+import { generateEnumsProperty } from './utils/clientProperties/generateEnumsProperty';
+import { generateModelsProperty } from './utils/clientProperties/generateModelsProperty';
+import { isApiGraphQLConfig } from './utils/runtimeTypeGuards/isApiGraphQLProviderConfig';
+import {
+	generateCustomMutationsProperty,
+	generateCustomQueriesProperty,
+} from './generateCustomOperationsProperty';
 import { ClientGenerationParams } from './types';
-import { isConfigureEventWithResourceConfig } from './utils/isConfigureEventWithResourceConfig';
+import { isConfigureEventWithResourceConfig } from './utils/runtimeTypeGuards/isConfigureEventWithResourceConfig';
 
 /**
  * @private

package/src/internals/generateCustomOperationsProperty.ts

@@ -1,14 +1,15 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
-import { CustomQueries, CustomMutations } from '@aws-amplify/data-schema-types';
-import { V6Client, __authMode, __authToken, __amplify } from '../types';
-
-import { customOpFactory } from './operations/custom';
+import { CustomMutations, CustomQueries } from '@aws-amplify/data-schema-types';
 import {
-	ModelIntrospectionSchema,
 	GraphQLProviderConfig,
+	ModelIntrospectionSchema,
 } from '@aws-amplify/core/internals/utils';
 
+import { V6Client, __amplify } from '../types';
+
+import { customOpFactory } from './operations/custom';
+
 type OpTypes = 'queries' | 'mutations';
 
 type CustomOpsProperty<
@@ -59,7 +60,7 @@ export function generateCustomOperationsProperty<
 			modelIntrospection,
 			operationTypeMap[operationsType],
 			operation,
-			useContext
+			useContext,
 		);
 	}
 

package/src/internals/operations/custom.ts

@@ -2,10 +2,18 @@
 // SPDX-License-Identifier: Apache-2.0
 import { AmplifyServer } from '@aws-amplify/core/internals/adapter-core';
 import {
-	initializeModel,
-	flattenItems,
+	CustomOperation,
+	ModelIntrospectionSchema,
+} from '@aws-amplify/core/internals/utils';
+
+import {
 	authModeParams,
+	defaultSelectionSetForNonModelWithIR,
+	flattenItems,
+	generateSelectionSet,
 	getCustomHeaders,
+	initializeModel,
+	selectionSetIRToString,
 } from '../APIClient';
 import {
 	AuthModeParams,
@@ -17,13 +25,6 @@ import {
 	V6Client,
 	V6ClientSSRRequest,
 } from '../../types';
-import {
-	ModelIntrospectionSchema,
-	SchemaModel,
-	SchemaNonModel,
-	CustomOperation,
-	CustomOperationArgument,
-} from '@aws-amplify/core/internals/utils';
 
 /**
  * Builds an operation function, embedded with all client and context data, that
@@ -165,9 +166,11 @@ function outerArguments(operation: CustomOperation): string {
 			const finalType = v.isArray
 				? `[${baseType}]${v.isArrayNullable ? '' : '!'}`
 				: baseType;
+
 			return `$${k}: ${finalType}`;
 		})
 		.join(', ');
+
 	return args.length > 0 ? `(${args})` : '';
 }
 
@@ -192,30 +195,10 @@ function outerArguments(operation: CustomOperation): string {
  */
 function innerArguments(operation: CustomOperation): string {
 	const args = Object.entries(operation.arguments)
-		.map(([k, v]) => `${k}: $${k}`)
+		.map(([k, _]) => `${k}: $${k}`)
 		.join(', ');
-	return args.length > 0 ? `(${args})` : '';
-}
 
-/**
- * Accepts a Model or NonModel from generated introspection schema and
- * generates the selection set string.
- *
- * @param nonModel Model or nonModel object from introspection schema.
- * @returns String selection set.
- */
-function modelishTypeSelectionSet(
-	nonModel: SchemaModel | SchemaNonModel,
-): string {
-	return Object.values(nonModel.fields)
-		.filter(
-			field =>
-				hasStringField(field, 'type') ||
-				hasStringField(field.type, 'nonModel') ||
-				hasStringField(field.type, 'enum'),
-		)
-		.map(field => field.name)
-		.join(' ');
+	return args.length > 0 ? `(${args})` : '';
 }
 
 /**
@@ -251,11 +234,13 @@ function operationSelectionSet(
 	) {
 		return '';
 	} else if (hasStringField(operation.type, 'nonModel')) {
-		const model = modelIntrospection.nonModels[operation.type.nonModel];
-		return `{${modelishTypeSelectionSet(model)}}`;
+		const nonModel = modelIntrospection.nonModels[operation.type.nonModel];
+
+		return `{${selectionSetIRToString(
+			defaultSelectionSetForNonModelWithIR(nonModel, modelIntrospection),
+		)}}`;
 	} else if (hasStringField(operation.type, 'model')) {
-		const nonModel = modelIntrospection.models[operation.type.model];
-		return `{${modelishTypeSelectionSet(nonModel)}}`;
+		return `{${generateSelectionSet(modelIntrospection, operation.type.model)}}`;
 	} else {
 		return '';
 	}
@@ -283,6 +268,7 @@ function operationVariables(
 			throw new Error(`${operation.name} requires arguments '${argDef.name}'`);
 		}
 	}
+
 	return variables;
 }
 

package/src/internals/operations/get.ts

@@ -2,13 +2,18 @@
 // SPDX-License-Identifier: Apache-2.0
 import { AmplifyServer } from '@aws-amplify/core/internals/adapter-core';
 import {
-	initializeModel,
-	generateGraphQLDocument,
+	ModelIntrospectionSchema,
+	SchemaModel,
+} from '@aws-amplify/core/internals/utils';
+
+import {
+	ModelOperation,
+	authModeParams,
 	buildGraphQLVariables,
 	flattenItems,
-	authModeParams,
-	ModelOperation,
+	generateGraphQLDocument,
 	getCustomHeaders,
+	initializeModel,
 } from '../APIClient';
 import {
 	AuthModeParams,
@@ -20,10 +25,6 @@ import {
 	V6Client,
 	V6ClientSSRRequest,
 } from '../../types';
-import {
-	ModelIntrospectionSchema,
-	SchemaModel,
-} from '@aws-amplify/core/internals/utils';
 
 export function getFactory(
 	client: ClientWithModels,