@avocadostudio-ai/orchestrator-core 0.27.0 → 0.29.0

package/dist/handler/create-orchestrator.js

@@ -21,7 +21,7 @@ import { mkdir, writeFile, readFile } from "node:fs/promises";
 import { resolve, basename } from "node:path";
 import { randomUUID } from "node:crypto";
 import { z } from "zod";
-import { operationSchema, blockManifestSchema, siteConfigSchema, declareBlockCatalogue, undeclaredBlockTypes, EDITOR_PROTOCOL_VERSION, withLoopbackSpellings, editorAllowHeaders, compareDraftSecret } from "@avocadostudio-ai/shared";
+import { operationSchema, blockManifestSchema, siteConfigSchema, declareBlockCatalogue, undeclaredBlockTypes, EDITOR_PROTOCOL_VERSION, withLoopbackSpellings, editorAllowHeaders, compareDraftSecret, buildBlockManifest } from "@avocadostudio-ai/shared";
 import { keyFileHint } from "../env-file-location.js";
 import { chatRequestBodySchema } from "../nlp/intent-detection.js";
 import { applyOpsAtomically, pickFocusBlockId, pickUpdatedSlug, toErrorDetail, classifyGuardrailError } from "../ops/ops-engine.js";
@@ -65,6 +65,7 @@ import { resolveCapabilities } from "../cms/adapter.js";
 import { mediaSourceFromUnknown } from "../cms/media-sources.js";
 import { extractAccessToken, isAccessGateEnabled, isValidAccessToken, mintAccessToken, verifyAccessPassword } from "../http/access-tokens.js";
 import { editorCredentials } from "../http/editor-credentials.js";
+import { OperationError } from "../errors.js";
 import { clearLibraryDispatch, declareLibraryMount, observeLibraryMount, registerLibraryDispatch } from "./library-mount.js";
 import { checkAuth, resolveAuth, CLOSED_HINT } from "./auth.js";
 import { setSiteAssetLister, invalidateSiteAssets } from "../state/site-assets.js";
@@ -1605,6 +1606,19 @@ export function createOrchestrator(config = {}) {
                         manifest = pm.data;
                 }
             }
+            /*
+             * No manifest in the request: use this mount's own. The editor sends one
+             * with every chat turn, but an MCP agent or a script calling /ops sends
+             * none, and without it every manifest check in the ops engine is skipped:
+             * read-only fields, fixed blocks, list discriminators, and list rows in a
+             * shape nothing renders. Library mode is the one host that already knows
+             * the site's blocks, the same ones `GET /blocks/manifest` serves.
+             */
+            if (!manifest) {
+                const own = buildBlockManifest();
+                if (own.blocks.length > 0)
+                    manifest = own;
+            }
             /*
              * Validate-only, before anything is snapshotted or bumped. This branch
              * did not exist: `dryRun` was parsed out of the body by nobody and the
@@ -1703,7 +1717,10 @@ export function createOrchestrator(config = {}) {
             }
             catch (error) {
                 const reason = toErrorDetail(error);
-                return jsonResponse({ error: reason, errorCode: classifyGuardrailError(reason) }, { status: 400, cors });
+                // An OperationError already knows its category; the text classifier is
+                // for errors that do not, and called a refused list row "internal_error".
+                const category = error instanceof OperationError ? error.category : undefined;
+                return jsonResponse({ error: reason, errorCode: category ?? classifyGuardrailError(reason) }, { status: 400, cors });
             }
         }
         /*

package/dist/ops/ops-engine.js

@@ -766,6 +766,73 @@ function _requireListDiscriminator(manifestByType, blockType, listKey, item) {
     const choices = admissible.length > 0 ? `: ${admissible.join(", ")}` : "";
     throw new OperationError(`A new ${listKey} row must set "${discriminator}", which names its type${choices}`, { category: "schema_violation" });
 }
+/*
+ * A list row must use the list's own field names.
+ *
+ * Integrations declare item schemas loose, so bookkeeping keys a CMS adds
+ * (`_type`, `_key`) ride through validation, and every field is optional. Such
+ * a schema accepts any object. A planner that had just written Avocado's
+ * built-in FAQ shape, `{ q, a }`, into a site whose accordion reads
+ * `{ title, body }` got an "applied" and a row that rendered empty, with the
+ * text present in the draft under names nothing reads.
+ *
+ * So a key is refused when the list neither declares it nor already holds it
+ * on another row: copying an existing row, undeclared keys and all, still
+ * works, and only a name the list has never seen is refused. The error names
+ * the fields the list does use, so the planner can correct itself. Lists with
+ * no declared item fields are left alone, since there is nothing to check
+ * against.
+ */
+/** Property names an item of `listKey` may carry, per the block's JSON Schema. */
+function _schemaItemKeys(definition, listKey) {
+    const props = definition.propsSchema?.properties;
+    const listSchema = props?.[listKey];
+    const keys = new Set();
+    const visit = (node) => {
+        if (!node || typeof node !== "object")
+            return;
+        const n = node;
+        for (const key of Object.keys(n.properties ?? {}))
+            keys.add(key);
+        for (const branch of [...(n.oneOf ?? []), ...(n.anyOf ?? []), ...(n.allOf ?? [])])
+            visit(branch);
+    };
+    visit(listSchema?.items);
+    return [...keys];
+}
+function _requireKnownItemKeys(manifestByType, blockType, listKey, list, item) {
+    const definition = manifestByType.get(blockType);
+    if (!definition)
+        return;
+    const listField = resolveManifestFieldMeta(definition).listFields[listKey];
+    if (!listField)
+        return;
+    const declared = new Set(Object.keys(listField.itemFields ?? {}));
+    for (const fields of Object.values(listField.itemFieldsByType ?? {})) {
+        for (const key of Object.keys(fields ?? {}))
+            declared.add(key);
+    }
+    if (listField.discriminator)
+        declared.add(listField.discriminator);
+    // The props schema names every item property, optional ones included; the
+    // field meta above names only what the panel offers.
+    for (const key of _schemaItemKeys(definition, listKey))
+        declared.add(key);
+    if (declared.size === 0)
+        return;
+    const known = new Set(declared);
+    for (const row of list) {
+        if (row && typeof row === "object" && !Array.isArray(row)) {
+            for (const key of Object.keys(row))
+                known.add(key);
+        }
+    }
+    const unknown = Object.keys(item).filter((key) => key !== "id" && !key.startsWith("_") && !known.has(key));
+    if (unknown.length === 0)
+        return;
+    throw new OperationError(`${listKey} rows have no field ${unknown.map((k) => `"${k}"`).join(", ")}. ` +
+        `Use the list's own fields: ${[...declared].filter((key) => !key.startsWith("_")).join(", ")}`, { category: "schema_violation" });
+}
 function _requireManifestComponent(manifestByType, blockType, operationName) {
     if (manifestByType.size === 0)
         return;
@@ -1449,6 +1516,7 @@ async function _applyOpsAtomicallyUnsafe(session, ops, options) {
                 // silently resolve to the first occurrence.
                 const newItem = structuredClone(op.item);
                 _requireListDiscriminator(manifestByType, block.type, op.listKey, newItem);
+                _requireKnownItemKeys(manifestByType, block.type, op.listKey, list, newItem);
                 if (typeof newItem.id !== "string" ||
                     newItem.id.length === 0 ||
                     _itemIndexById(nextList, newItem.id) !== -1) {
@@ -1476,6 +1544,7 @@ async function _applyOpsAtomicallyUnsafe(session, ops, options) {
                 // A patch must never clobber the stable item id (it's the addressing key).
                 const itemPatch = { ...op.patch };
                 delete itemPatch.id;
+                _requireKnownItemKeys(manifestByType, block.type, op.listKey, list, itemPatch);
                 const nextList = list.map((entry, idx) => {
                     if (idx !== targetIndex)
                         return entry;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@avocadostudio-ai/orchestrator-core",
-  "version": "0.27.0",
+  "version": "0.29.0",
   "type": "module",
   "exports": {
     "./package.json": "./package.json",
@@ -22,8 +22,8 @@
     "openai": "^4.87.1",
     "sharp": "^0.35.4",
     "zod": "^4.3.6",
-    "@avocadostudio-ai/migration-sdk": "^0.27.0",
-    "@avocadostudio-ai/shared": "^0.27.0"
+    "@avocadostudio-ai/migration-sdk": "^0.29.0",
+    "@avocadostudio-ai/shared": "^0.29.0"
   },
   "devDependencies": {
     "@anthropic-ai/claude-agent-sdk": "^0.3.220",