@averay/codeformat 0.1.6 → 0.1.8

package/index.js

@@ -1,3 +1,5 @@
+/* eslint sort-keys: "error" -- Organise rules */
+
 import typescriptPlugin from '@typescript-eslint/eslint-plugin';
 import typescriptParser from '@typescript-eslint/parser';
 import prettierConfig from 'eslint-config-prettier';
@@ -24,6 +26,11 @@ export function makeEslintConfig(options = {}) {
     // JavaScript & TypeScript
     {
       files: [`**/*.{${[...extensions.js, ...extensions.ts].join(',')}}`],
+      languageOptions: {
+        parserOptions: {
+          ...importPlugin.configs.recommended.parserOptions,
+        },
+      },
       plugins: {
         'eslint-comments': eslintCommentsPlugin,
         import: importPlugin,
@@ -32,17 +39,12 @@ export function makeEslintConfig(options = {}) {
         sonarjs: sonarjsPlugin,
         unicorn: unicornPlugin,
       },
-      languageOptions: {
-        parserOptions: {
-          ...importPlugin.configs.recommended.parserOptions,
-        },
-      },
+      rules: convertWarnsToErrors(rulesetShared),
       settings: {
         'import/parsers': {
           espree: extensions.js.map((extension) => `.${extension}`),
         },
       },
-      rules: convertWarnsToErrors(rulesetShared),
     },
 
     // TypeScript
@@ -55,13 +57,13 @@ export function makeEslintConfig(options = {}) {
       plugins: {
         '@typescript-eslint': typescriptPlugin,
       },
+      rules: convertWarnsToErrors(rulesetTypescript),
       settings: {
         ...importPlugin.configs.typescript.settings,
         'import/parsers': {
           '@typescript-eslint/parser': extensions.ts.map((extension) => `.${extension}`),
         },
       },
-      rules: convertWarnsToErrors(rulesetTypescript),
     },
 
     prettierConfig,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@averay/codeformat",
-  "version": "0.1.6",
+  "version": "0.1.8",
   "author": "Adam Averay (https://adamaveray.com.au/)",
   "homepage": "https://github.com/adamaveray/codeformat",
   "repository": {

package/rulesets/ruleset-shared.js

@@ -29,7 +29,7 @@ export default {
     'global-require': 'error',
     'grouped-accessor-pairs': ['error', 'getBeforeSet'],
     'guard-for-in': 'error',
-    'id-denylist': ['error', 'e', 'err', 'evt', 'cb'],
+    'id-denylist': ['error', 'cb', 'e', 'enc', 'err', 'evt'],
     'lines-between-class-members': 'error',
     'logical-assignment-operators': ['error', 'always'],
     'max-classes-per-file': ['error', 1],
@@ -165,7 +165,14 @@ export default {
     'no-unused-expressions': 'error',
     'no-unused-labels': 'error',
     'no-unused-private-class-members': 'error',
-    'no-unused-vars': 'error',
+    'no-unused-vars': [
+      'error',
+      {
+        argsIgnorePattern: '^_\\w*$',
+        caughtErrorsIgnorePattern: '^_\\w*$',
+        varsIgnorePattern: '^(_\\d*|React)$',
+      },
+    ],
     'no-use-before-define': 'error',
     'no-useless-backreference': 'error',
     'no-useless-call': 'error',

package/rulesets/ruleset-typescript.js

@@ -12,6 +12,31 @@ export default {
   ...typescriptPlugin.configs['recommended-requiring-type-checking'].rules,
   ...typescriptPlugin.configs.strict.rules,
 
+  // eslint-disable-next-line unicorn/no-useless-spread -- Keeps the unprefixed core rules together
+  ...{
+    'default-param-last': 'off',
+    'dot-notation': 'off',
+    'lines-between-class-members': 'off',
+    'no-array-constructor': 'off',
+    'no-dupe-class-members': 'off',
+    'no-empty-function': 'off',
+    'no-implied-eval': 'off',
+    'no-invalid-this': 'off',
+    'no-loop-func': 'off',
+    'no-loss-of-precision': 'off',
+    'no-magic-numbers': 'off',
+    'no-redeclare': 'off',
+    'no-restricted-imports': 'off',
+    'no-return-await': 'off',
+    'no-shadow': 'off',
+    'no-throw-literal': 'off',
+    'no-unused-expressions': 'off',
+    'no-unused-vars': 'off',
+    'no-use-before-define': 'off',
+    'no-useless-constructor': 'off',
+    'padding-line-between-statements': 'off',
+  },
+
   '@typescript-eslint/adjacent-overload-signatures': 'error',
   '@typescript-eslint/array-type': 'error',
   '@typescript-eslint/await-thenable': 'error',
@@ -112,6 +137,17 @@ export default {
   '@typescript-eslint/no-invalid-void-type': 'error',
   '@typescript-eslint/no-loop-func': 'error',
   '@typescript-eslint/no-loss-of-precision': 'error',
+  '@typescript-eslint/no-magic-numbers': [
+    'error',
+    {
+      detectObjects: true,
+      enforceConst: true,
+      ignore: [-1, 0, 1],
+      ignoreArrayIndexes: true,
+      ignoreClassFieldInitialValues: true,
+      ignoreDefaultValues: true,
+    },
+  ],
   '@typescript-eslint/no-meaningless-void-operator': 'error',
   '@typescript-eslint/no-misused-new': 'error',
   '@typescript-eslint/no-misused-promises': 'error',
@@ -122,7 +158,7 @@ export default {
   '@typescript-eslint/no-redeclare': 'error',
   '@typescript-eslint/no-require-imports': 'error',
   '@typescript-eslint/no-restricted-imports': 'error',
-  '@typescript-eslint/no-shadow': 'error',
+  '@typescript-eslint/no-shadow': ['error', { hoist: 'all' }],
   '@typescript-eslint/no-this-alias': 'error',
   '@typescript-eslint/no-throw-literal': 'error',
   '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
@@ -175,7 +211,10 @@ export default {
   '@typescript-eslint/restrict-plus-operands': 'error',
   '@typescript-eslint/restrict-template-expressions': 'error',
   '@typescript-eslint/return-await': 'error',
-  '@typescript-eslint/strict-boolean-expressions': ['error', { allowNullableString: true }],
+  '@typescript-eslint/strict-boolean-expressions': [
+    'error',
+    { allowNullableObject: false, allowNullableString: false, allowNumber: false, allowString: false },
+  ],
   '@typescript-eslint/switch-exhaustiveness-check': 'error',
   '@typescript-eslint/triple-slash-reference': 'error',
   '@typescript-eslint/unbound-method': 'off', // Does not support @autobind nor recognise binding in constructors