@aventara/core 1.0.0-rc.11 → 1.0.0-rc.12

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @aventara/core
 
+## 1.0.0-rc.12
+
+### Patch Changes
+
+- fdeee8a: A unique field a layer may not filter on is no longer an identifier of that layer. Exempting its `filter` (a write-only
+  `apiKey: ["select", "filter", "order"]`, an unsearchable `email: ["filter"]`, or a Pick that leaves `filter` out) used
+  to keep the field in the Contract's `identifiers`, so `find.unique`, `update.unique`, `upsert.unique`, `delete.unique`
+  and a nested `$connect`/`$connectOrCreate` still looked a record up by it and answered the row or `A2003`, over every
+  route including `/_all` and `/_transactions`. Such a selector is now refused `V1007` before the Adapter is called, a
+  compound identifier goes with any one of its fields, and the generated client and the server façades no longer offer
+  it. A layer that keeps a unique variant with no filterable identifier left fails at startup with
+  `COMPILER_MISSING_IDENTIFIER`, as hiding the identifier already did: under `exposed: false`, pick `id: ["select",
+  "filter"]`, not `id: ["select"]`, to keep `find.unique`. The agent skill's Pick example says so.
+
 ## 1.0.0-rc.11
 
 ### Patch Changes

package/ERRORS.md

@@ -1,6 +1,6 @@
 # Aventara error codes
 
-Every code `@aventara/core` 1.0.0-rc.11 answers, reports in a validation issue, or refuses to start with. Generated from `AvErrorCatalog` (exported by `@aventara/core`); do not edit.
+Every code `@aventara/core` 1.0.0-rc.12 answers, reports in a validation issue, or refuses to start with. Generated from `AvErrorCatalog` (exported by `@aventara/core`); do not edit.
 
 Branch on the code, never on the message. In code, `AvErrorCatalog[code]` gives the same entry: `{ code, kind, message, cause, fix, docs }`.
 
@@ -135,7 +135,7 @@ Each entry of `cause.issues[]` under `A2001`, `A2002`, `A2004`, `A2007` or `A200
 | [`COMPILER_MISSING_READ_COMPUTE`](https://aventara.razor34.dev/framework/docs/error-codes#compiler_missing_read_compute) | A selectable virtual field has no compute.read. | A VIRTUAL field that can be selected has no pipelines.compute.read stage. | Add a compute.read stage, or make the field write-only with capabilities.select: false. |
 | [`COMPILER_INVALID_COMPUTE_DEPENDENCY`](https://aventara.razor34.dev/framework/docs/error-codes#compiler_invalid_compute_dependency) | Invalid compute.read dependency. | A dependsOn entry that is not a stored scalar field of the same Resource. | List only stored scalar fields of the Resource in dependsOn. |
 | [`COMPILER_RESERVED_RESOURCE_NAME`](https://aventara.razor34.dev/framework/docs/error-codes#compiler_reserved_resource_name) | Reserved Resource name. | A model name starts with $, which is reserved for the framework's own names (ctx.$sql, $ref), or is the name of a member beside the Resources: all on serverClient (and so on Next.js's avClient), and on a host that adds its own, one of those (on Next.js: tx and transaction on avClient, appTx and transaction on avApp). | Rename the model; the table it maps to can keep its name. A host member's name is also left free when the layer it belongs to hides the Resource. |
-| [`COMPILER_MISSING_IDENTIFIER`](https://aventara.razor34.dev/framework/docs/error-codes#compiler_missing_identifier) | A unique operation has no identifier. | A layer exposes a unique variant (find.unique, update.unique, delete.unique, upsert.unique) and no complete identifier of the Resource: a Pick that did not pick one, or an Omit that hid every one. | Expose an identifier field (id, or every field of one unique), or exempt the unique variants. |
+| [`COMPILER_MISSING_IDENTIFIER`](https://aventara.razor34.dev/framework/docs/error-codes#compiler_missing_identifier) | A unique operation has no identifier. | A layer exposes a unique variant (find.unique, update.unique, delete.unique, upsert.unique) and no complete identifier of the Resource it may filter on: a Pick that did not pick one with its filter, or an Omit that hid every one or its filter. | Expose an identifier field with its filter (id, or every field of one unique), or exempt the unique variants. |
 | [`COMPILER_HIDDEN_REQUIRED_FIELD`](https://aventara.razor34.dev/framework/docs/error-codes#compiler_hidden_required_field) | A layer that creates a Resource hides a required field. | A layer still creates the Resource (a create or upsert variant, or a nested create) while a required field, or a required relation's reference field, is hidden or has its create capability exempted, and no compute.create fills it. | Expose the field, give it a compute.create stage, or exempt the layer's create operations. |
 | [`COMPILER_INVALID_VALIDATOR`](https://aventara.razor34.dev/framework/docs/error-codes#compiler_invalid_validator) | A field validator cannot apply. | A validator that is not built with AvZ, does not fit the field's type (AvZ.maxLength on an int, AvZ.maxItems on a field that is not a list), or sits on a relation or Json field. | Use an AvZ check that fits the field's type; a Json field's checks go in its json shape. |
 | [`COMPILER_INVALID_JSON_SHAPE`](https://aventara.razor34.dev/framework/docs/error-codes#compiler_invalid_json_shape) | A Json shape cannot apply. | A json shape on a field that is not a discovered Json field, a shape not built with AvZ, or one that admits null or absence at its top level. | Put the shape on a Json field, build it with AvZ, and keep its top level non-null (the column's nullability decides null). |

package/dist/compiler/contract-compiler-diagnostic.d.ts

@@ -7,8 +7,9 @@ export type AvContractCompilerDiagnosticCode = "COMPILER_UNKNOWN_RESOURCE" | "CO
  | "COMPILER_RESERVED_RESOURCE_NAME"
 /**
  * A layer exposes a unique operation variant (`find.unique`, `update.unique`,
- * `delete.unique`, `upsert.unique`) and no complete identifier of its Resource:
- * a Pick that did not pick one, or an Omit that hid every one.
+ * `delete.unique`, `upsert.unique`) and no complete identifier of its Resource
+ * it may filter on: a Pick that did not pick one with its filter, or an Omit
+ * that hid every one or its filter.
  */
  | "COMPILER_MISSING_IDENTIFIER"
 /**

package/dist/compiler/contract-compiler-diagnostic.guidance.js

@@ -71,8 +71,8 @@ export const CONTRACT_COMPILER_DIAGNOSTIC_GUIDANCE = {
     },
     COMPILER_MISSING_IDENTIFIER: {
         message: "A unique operation has no identifier.",
-        cause: "A layer exposes a unique variant (find.unique, update.unique, delete.unique, upsert.unique) and no complete identifier of the Resource: a Pick that did not pick one, or an Omit that hid every one.",
-        fix: "Expose an identifier field (id, or every field of one unique), or exempt the unique variants.",
+        cause: "A layer exposes a unique variant (find.unique, update.unique, delete.unique, upsert.unique) and no complete identifier of the Resource it may filter on: a Pick that did not pick one with its filter, or an Omit that hid every one or its filter.",
+        fix: "Expose an identifier field with its filter (id, or every field of one unique), or exempt the unique variants.",
     },
     COMPILER_HIDDEN_REQUIRED_FIELD: {
         message: "A layer that creates a Resource hides a required field.",

package/dist/compiler/contract.compiler.js

@@ -866,9 +866,14 @@ function pruneEmptyOperationFamilies(operations) {
 function identifierLabel(identifier) {
     return identifier.map((name) => `\`${name}\``).join(" and ");
 }
+function isAddressable(field, parentField) {
+    return (field?.kind === "scalar" &&
+        (capabilityIsEnabled(field.capabilities.filter) ||
+            !capabilityIsEnabled(parentField?.capabilities?.filter)));
+}
 function reconcileIdentifiers(walk, resource, parent, path) {
     resource.identifiers = parent.identifiers
-        .filter((identifier) => identifier.every((name) => resource.fields[name]?.kind === "scalar"))
+        .filter((identifier) => identifier.every((name) => isAddressable(resource.fields[name], parent.fields[name])))
         .map((identifier) => [...identifier]);
     const first = parent.identifiers[0];
     if (resource.identifiers.length > 0 || first === undefined) {
@@ -882,8 +887,8 @@ function reconcileIdentifiers(walk, resource, parent, path) {
         }
         const variantPath = `${path}.operations.${family}.${variant}`;
         walk.diagnostics.push(diagnostic("COMPILER_MISSING_IDENTIFIER", variantPath, walk.style === "pick"
-            ? `${variantPath} needs an identifier field; pick ${identifierLabel(first)} (or another complete identifier) too`
-            : `${variantPath} needs an identifier field, and the exemptions hide every complete identifier; keep ${identifierLabel(first)} (or another complete identifier) exposed, or exempt the operation too`));
+            ? `${variantPath} needs an identifier field; pick ${identifierLabel(first)} with its filter (or another complete identifier) too`
+            : `${variantPath} needs an identifier field, and the exemptions hide (or stop filtering on) every complete identifier; keep ${identifierLabel(first)} (or another complete identifier) exposed and filterable, or exempt the operation too`));
     }
 }
 function validateScalarReference(projection, field, path, diagnostics) {

package/dist/framework/contract-view.d.ts

@@ -319,6 +319,16 @@ type ExemptedFields<Fields, Block, Style> = Style extends "omit" ? [Block] exten
 };
 /** The fields an exemptions `fields` block leaves a Resource without. */
 type RemovedField<Fields, Block, Style> = Style extends "omit" ? WholeKey<Block> : Exclude<keyof Fields, GrantedFieldKey<Block>>;
+/** Whether a field's capabilities offer a filter operator. */
+type Filters<Field> = Field extends {
+    readonly capabilities: infer Caps;
+} ? [MemberTokens<NonNullable<Caps[keyof Caps & "filter"]>>] extends [never] ? false : true : false;
+/** The fields a `fields` block stops filtering on: the parent filters on them, the layer no longer does. */
+type UnfilteredField<Fields, Block, Style> = [Block] extends [never] ? never : {
+    [F in keyof Fields & keyof Block]-?: Filters<Fields[F]> extends true ? Filters<ExemptedField<Fields[F], NonNullable<Block[F]>, Style>> extends true ? never : F : never;
+}[keyof Fields & keyof Block];
+/** The fields no identifier of the layer may name. */
+type UnaddressableField<Fields, Block, Style> = RemovedField<Fields, Block, Style> | UnfilteredField<Fields, Block, Style>;
 /** One family's entry in an operations entry: `true` for a listed family. */
 type FamilyEntry<Operations, Family> = Operations extends readonly unknown[] ? Family extends Listed<Operations> ? true : unknown : [Operations] extends [boolean] ? Operations : Family extends keyof Operations ? NonNullable<Operations[Family]> : unknown;
 /** The keys of a per-variant object entry set to a literal `true`. */
@@ -342,7 +352,7 @@ type KeptOperations<Operations, Entry, Style, UniqueLost> = {
         readonly [V in KeptVariant<NonNullable<Operations[F]>, FamilyEntry<Entry, F>, Style, UniqueLost>]: NonNullable<Operations[F]>[V];
     };
 };
-/** A Resource's identifiers less those naming a removed field. */
+/** A Resource's identifiers less those naming an unaddressable field. */
 type KeptIdentifiers<Identifiers, Removed> = [Removed] extends [never] ? Identifiers : Identifiers extends readonly (infer Identifier)[] ? readonly (Identifier extends readonly (infer Field)[] ? [Extract<Field, Removed>] extends [never] ? Identifier : never : never)[] : Identifiers;
 /** Whether removing fields left a Resource with no identifier at all. */
 type IdentifiersLost<Identifiers, Removed> = [Removed] extends [never] ? false : [
@@ -359,9 +369,9 @@ type OperationsEntryOf<Entry> = (Entry & {
 type ExemptedResourceObject<in out Resource, in out FieldsBlock, in out OperationsEntry, in out Style> = {
     readonly [P in keyof Resource]: P extends "fields" ? ExemptedFields<Resource[P], FieldsBlock, Style> : P extends "operations" ? ExemptedOperations<Resource[P], OperationsEntry, Style, IdentifiersLost<Resource extends {
         readonly identifiers: infer Ids;
-    } ? Ids : never, RemovedField<Resource extends {
+    } ? Ids : never, UnaddressableField<Resource extends {
         readonly fields: infer Fields;
-    } ? Fields : never, FieldsBlock, Style>>> : P extends "identifiers" ? KeptIdentifiers<Resource[P], RemovedField<Resource extends {
+    } ? Fields : never, FieldsBlock, Style>>> : P extends "identifiers" ? KeptIdentifiers<Resource[P], UnaddressableField<Resource extends {
         readonly fields: infer Fields;
     } ? Fields : never, FieldsBlock, Style>> : Resource[P];
 };

package/dist/prebuilt/core-version.generated.d.ts

@@ -1,2 +1,2 @@
 /** The version of this `@aventara/core`. */
-export declare const CORE_VERSION = "1.0.0-rc.11";
+export declare const CORE_VERSION = "1.0.0-rc.12";

package/dist/prebuilt/core-version.generated.js

@@ -1 +1 @@
-export const CORE_VERSION = "1.0.0-rc.11";
+export const CORE_VERSION = "1.0.0-rc.12";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aventara/core",
-  "version": "1.0.0-rc.11",
+  "version": "1.0.0-rc.12",
   "license": "SEE LICENSE IN LICENSE",
   "description": "Core runtime, contract compiler, and extension APIs for Aventara.",
   "type": "module",