@avelonjs/next 0.3.5 → 0.3.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@avelonjs/next",
-  "version": "0.3.5",
+  "version": "0.3.6",
   "private": false,
   "description": "Next.js adapter for Avelon routing, server actions, and pages.",
   "license": "MIT",

package/src/cookies.ts

@@ -2,6 +2,8 @@ import { AsyncLocalStorage } from 'node:async_hooks'
 import type { CookieOptions } from '@avelonjs/core'
 import type { ReactNode } from 'react'
 
+import { reportFailure } from './failures'
+
 /** One cookie write queued during kernel dispatch. */
 export interface PendingCookie {
   /** Cookie name. */
@@ -111,24 +113,45 @@ function toNextCookieOptions(options?: CookieOptions): Record<string, unknown> {
   }
 }
 
-/** Writes queued cookies through `next/headers` when available. */
+interface NextCookieJar {
+  set: (name: string, value: string, options?: Record<string, unknown>) => void
+  delete: (name: string) => void
+}
+
+/** The request's cookie jar, or undefined outside a Next runtime. */
+async function nextCookieJar(): Promise<NextCookieJar | undefined> {
+  try {
+    const headers = (await import('next/headers')) as {
+      cookies: () => Promise<NextCookieJar>
+    }
+    return await headers.cookies()
+  } catch {
+    // Tests and non-Next hosts have no jar; the queue is already discarded.
+    return undefined
+  }
+}
+
+/**
+ * Writes queued cookies through `next/headers` when available.
+ *
+ * A rejected write is reported rather than swallowed. Next allows a cookie write only from a
+ * server action or a route handler, so a controller reached by a page that signs an actor in
+ * throws here — and swallowing it produced the worst shape of failure: the driver had already
+ * spent the actor's one-time token, the request redirected as though it had worked, and the
+ * reader arrived signed out with nothing written anywhere saying why.
+ */
 export async function flushOutgoingCookies(): Promise<void> {
   const pending = takePendingCookies()
   if (pending.length === 0) return
+  const jar = await nextCookieJar()
+  if (jar === undefined) return
   try {
-    const headers = (await import('next/headers')) as {
-      cookies: () => Promise<{
-        set: (name: string, value: string, options?: Record<string, unknown>) => void
-        delete: (name: string) => void
-      }>
-    }
-    const jar = await headers.cookies()
     for (const cookie of pending) {
       if (cookie.value === null) jar.delete(cookie.name)
       else jar.set(cookie.name, cookie.value, toNextCookieOptions(cookie.options))
     }
-  } catch {
-    // Tests and non-Next hosts keep the queue discarded after takePendingCookies.
+  } catch (error) {
+    reportFailure('cookies', pending.map((cookie) => cookie.name).join(', '), error)
   }
 }