@avalix/chroma 0.0.16 → 1.0.0

package/src/wallets/talisman.ts

@@ -3,6 +3,8 @@ import type { WalletAccount } from '../context-playwright/types.js'
 import fs from 'node:fs'
 import path from 'node:path'
 import process from 'node:process'
+import { findExtensionPopup as findExtensionPopupBase } from '../utils/find-extension-popup.js'
+import { DEFAULT_TEST_PASSWORD } from '../utils/test-defaults.js'
 
 // Talisman specific configuration
 // https://github.com/avalix-labs/polkadot-wallets/tree/main/talisman
@@ -12,33 +14,10 @@ export const TALISMAN_CONFIG = {
   extensionName: `talisman-extension-${VERSION}`,
 } as const
 
-/*
- * Helper function to find extension popup
- * Coverage excluded: requires real browser context with Chrome extension APIs.
- */
+// Talisman popup needs a fixed viewport to render correctly in headed runs.
 /* c8 ignore start */
-async function findExtensionPopup(context: BrowserContext, extensionId: string): Promise<Page> {
-  // Wait for extension popup to appear with retry logic
-  const maxAttempts = 10
-  const retryDelay = 500
-
-  for (let attempt = 0; attempt < maxAttempts; attempt++) {
-    const pages = context.pages()
-    for (const p of pages) {
-      if (p.url().includes(`chrome-extension://${extensionId}/`)) {
-        await p.setViewportSize({ width: 400, height: 600 })
-        await p.waitForLoadState('domcontentloaded')
-        return p
-      }
-    }
-
-    // If not found, wait a bit before retrying
-    if (attempt < maxAttempts - 1) {
-      await new Promise(resolve => setTimeout(resolve, retryDelay))
-    }
-  }
-
-  throw new Error(`Extension popup not found for ID: ${extensionId}`)
+function findExtensionPopup(context: BrowserContext, extensionId: string): Promise<Page> {
+  return findExtensionPopupBase(context, extensionId, { viewport: { width: 400, height: 600 } })
 }
 /* c8 ignore stop */
 
@@ -47,8 +26,9 @@ export async function getTalismanExtensionPath(): Promise<string> {
   const extensionsDir = path.resolve(process.cwd(), '.chroma')
   const extensionDir = path.join(extensionsDir, TALISMAN_CONFIG.extensionName)
 
-  // Check if extension exists
-  if (!fs.existsSync(extensionDir) || fs.readdirSync(extensionDir).length === 0) {
+  // Check if extension exists (readdir rejects if missing → treat as empty)
+  const entries = await fs.promises.readdir(extensionDir).catch(() => [] as string[])
+  if (entries.length === 0) {
     throw new Error(
       `Talisman extension not found at: ${extensionDir}\n\n`
       + `Please download the extension first by running:\n`
@@ -127,12 +107,10 @@ async function completeOnboarding(
 
 // Talisman specific Polkadot mnemonic import implementation
 export async function importPolkadotMnemonic(
-  page: Page & { __extensionContext: BrowserContext, __extensionId: string },
-  { seed, name = 'Test Account', password = 'h3llop0lkadot!' }: WalletAccount,
+  context: BrowserContext,
+  extensionId: string,
+  { seed, name = 'Test Account', password = DEFAULT_TEST_PASSWORD }: WalletAccount,
 ): Promise<void> {
-  const context = page.__extensionContext
-  const extensionId = page.__extensionId
-
   const extensionPage = await findOnboardingPage(context, extensionId)
 
   try {
@@ -159,12 +137,10 @@ export async function importPolkadotMnemonic(
 
 // Talisman specific Ethereum private key import implementation
 export async function importEthPrivateKey(
-  page: Page & { __extensionContext: BrowserContext, __extensionId: string },
-  { seed, name = 'Test Account', password = 'h3llop0lkadot!' }: WalletAccount,
+  context: BrowserContext,
+  extensionId: string,
+  { seed, name = 'Test Account', password = DEFAULT_TEST_PASSWORD }: WalletAccount,
 ): Promise<void> {
-  const context = page.__extensionContext
-  const extensionId = page.__extensionId
-
   const extensionPage = await findOnboardingPage(context, extensionId)
 
   try {
@@ -192,11 +168,10 @@ export async function importEthPrivateKey(
 
 // Talisman specific authorization implementation
 export async function authorizeTalisman(
-  page: Page & { __extensionContext: BrowserContext, __extensionId: string },
+  context: BrowserContext,
+  extensionId: string,
   options: { accountName?: string } = {},
 ): Promise<void> {
-  const context = page.__extensionContext
-  const extensionId = page.__extensionId
   const { accountName = 'Test Account' } = options
 
   const extensionPopup = await findExtensionPopup(context, extensionId)
@@ -219,11 +194,9 @@ export async function authorizeTalisman(
 
 // Talisman specific transaction approval implementation
 export async function approveTalismanTx(
-  page: Page & { __extensionContext: BrowserContext, __extensionId: string },
+  context: BrowserContext,
+  extensionId: string,
 ): Promise<void> {
-  const context = page.__extensionContext
-  const extensionId = page.__extensionId
-
   const extensionPopup = await findExtensionPopup(context, extensionId)
 
   if (await extensionPopup.getByRole('button', { name: 'Yes' }).isVisible()) {
@@ -235,11 +208,9 @@ export async function approveTalismanTx(
 
 // Talisman specific transaction rejection implementation
 export async function rejectTalismanTx(
-  page: Page & { __extensionContext: BrowserContext, __extensionId: string },
+  context: BrowserContext,
+  extensionId: string,
 ): Promise<void> {
-  const context = page.__extensionContext
-  const extensionId = page.__extensionId
-
   const extensionPopup = await findExtensionPopup(context, extensionId)
 
   const rejectButton = extensionPopup.getByTestId('connection-reject-button')