@avalabs/evm-module 0.0.17 → 0.0.18

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "@avalabs/evm-module",
-  "version": "0.0.17",
+  "version": "0.0.18",
   "main": "dist/index.cjs",
   "module": "dist/index.js",
   "typings": "dist/index.d.ts",
   "type": "module",
   "dependencies": {
-    "@avalabs/vm-module-types": "0.0.17",
+    "@avalabs/vm-module-types": "0.0.18",
     "@zodios/core": "10.9.6",
     "@avalabs/coingecko-sdk": "v2.8.0-alpha.193",
     "@avalabs/utils-sdk": "2.8.0-alpha.193",
@@ -32,7 +32,7 @@
     "ethers": "6.8.1",
     "@internal/tsup-config": "0.0.1",
     "eslint-config-custom": "0.0.1",
-    "@internal/utils": "0.0.3"
+    "@internal/utils": "0.0.4"
   },
   "peerDependencies": {
     "ethers": "^6.8.1"

package/src/handlers/eth-sign/eth-sign.test.ts

@@ -223,6 +223,44 @@ describe('ethSign', () => {
     testWithValidationResultType('Malicious');
   });
 
+  it('should add alert object with Warning type to displayData when schema validation error occurs in jsonRpc scan', async () => {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    (Blockaid as any).mockImplementation(() => ({
+      evm: {
+        jsonRpc: {
+          scan: jest.fn().mockRejectedValue({ message: 'schema validation error' }),
+        },
+      },
+    }));
+
+    mockParseRequestParams.mockReturnValueOnce({
+      success: true,
+      data: { method: RpcMethod.ETH_SIGN, data: 'data', address: '0xabc' },
+    });
+
+    const result = await ethSign({
+      request: mockRequest,
+      network: mockNetwork,
+      approvalController: mockApprovalController,
+      proxyApiUrl: PROXY_API_URL,
+    });
+
+    expect(result).toEqual({ result: '0x1234' });
+    expect(mockApprovalController.requestApproval).toHaveBeenCalledWith(
+      expect.objectContaining({
+        displayData: expect.objectContaining({
+          alert: {
+            type: AlertType.WARNING,
+            details: {
+              title: 'Suspicious Transaction',
+              description: 'Use caution, this transaction may be malicious.',
+            },
+          },
+        }),
+      }),
+    );
+  });
+
   it('should handle success case for approvalController.requestApproval', async () => {
     mockParseRequestParams.mockReturnValueOnce({
       success: true,

package/src/utils/process-transaction-simulation.ts

@@ -31,42 +31,31 @@ export const processTransactionSimulation = async ({
   chainId: number;
   proxyApiUrl: string;
 }) => {
-  const { validation, simulation } = await scanTransaction({
-    proxyApiUrl,
-    chainId,
-    params,
-    domain: dAppUrl,
-  });
-
   let alert: Alert | undefined;
-  if (!validation || validation.result_type === 'Error' || validation.result_type === 'Warning') {
-    alert = {
-      type: AlertType.WARNING,
-      details: {
-        title: 'Suspicious Transaction',
-        description: 'Use caution, this transaction may be malicious.',
-      },
-    };
-  } else if (validation.result_type === 'Malicious') {
-    alert = {
-      type: AlertType.DANGER,
-      details: {
-        title: 'Scam Transaction',
-        description: 'This transaction is malicious, do not proceed.',
-        actionTitles: {
-          reject: 'Reject Transaction',
-          proceed: 'Proceed Anyway',
-        },
-      },
-    };
-  }
-
   let balanceChange: BalanceChange | undefined;
   let tokenApprovals: TokenApprovals | undefined;
 
-  if (simulation?.status === 'Success') {
-    tokenApprovals = processTokenApprovals(request, simulation.account_summary.exposures);
-    balanceChange = processBalanceChange(simulation.account_summary.assets_diffs);
+  try {
+    const { validation, simulation } = await scanTransaction({
+      proxyApiUrl,
+      chainId,
+      params,
+      domain: dAppUrl,
+    });
+
+    if (!validation || validation.result_type === 'Error' || validation.result_type === 'Warning') {
+      alert = transactionAlerts[AlertType.WARNING];
+    } else if (validation.result_type === 'Malicious') {
+      alert = transactionAlerts[AlertType.DANGER];
+    }
+
+    if (simulation?.status === 'Success') {
+      tokenApprovals = processTokenApprovals(request, simulation.account_summary.exposures);
+      balanceChange = processBalanceChange(simulation.account_summary.assets_diffs);
+    }
+  } catch (error) {
+    console.error('processTransactionSimulation error', error);
+    alert = transactionAlerts[AlertType.WARNING];
   }
 
   return { alert, balanceChange, tokenApprovals };
@@ -251,44 +240,54 @@ export const processJsonRpcSimulation = async ({
   chainId: number;
   proxyApiUrl: string;
 }) => {
-  const { validation, simulation } = await scanJsonRpc({
-    proxyApiUrl,
-    chainId,
-    accountAddress,
-    data: data as Blockaid.Evm.JsonRpcScanParams.Data,
-    domain: dAppUrl,
-  });
-
   let alert: Alert | undefined;
-  if (!validation || validation.result_type === 'Error' || validation.result_type === 'Warning') {
-    alert = {
-      type: AlertType.WARNING,
-      details: {
-        title: 'Suspicious Transaction',
-        description: 'Use caution, this transaction may be malicious.',
-      },
-    };
-  } else if (validation.result_type === 'Malicious') {
-    alert = {
-      type: AlertType.DANGER,
-      details: {
-        title: 'Scam Transaction',
-        description: 'This transaction is malicious, do not proceed.',
-        actionTitles: {
-          reject: 'Reject Transaction',
-          proceed: 'Proceed Anyway',
-        },
-      },
-    };
-  }
-
   let balanceChange: BalanceChange | undefined;
   let tokenApprovals: TokenApprovals | undefined;
 
-  if (simulation?.status === 'Success') {
-    tokenApprovals = processTokenApprovals(request, simulation.account_summary.exposures);
-    balanceChange = processBalanceChange(simulation.account_summary.assets_diffs);
+  try {
+    const { validation, simulation } = await scanJsonRpc({
+      proxyApiUrl,
+      chainId,
+      accountAddress,
+      data: data as Blockaid.Evm.JsonRpcScanParams.Data,
+      domain: dAppUrl,
+    });
+
+    if (!validation || validation.result_type === 'Error' || validation.result_type === 'Warning') {
+      alert = transactionAlerts[AlertType.WARNING];
+    } else if (validation.result_type === 'Malicious') {
+      alert = transactionAlerts[AlertType.DANGER];
+    }
+
+    if (simulation?.status === 'Success') {
+      tokenApprovals = processTokenApprovals(request, simulation.account_summary.exposures);
+      balanceChange = processBalanceChange(simulation.account_summary.assets_diffs);
+    }
+  } catch (error) {
+    console.error('processJsonRpcSimulation error', error);
+    alert = transactionAlerts[AlertType.WARNING];
   }
 
   return { alert, balanceChange, tokenApprovals };
 };
+
+const transactionAlerts = {
+  [AlertType.WARNING]: {
+    type: AlertType.WARNING,
+    details: {
+      title: 'Suspicious Transaction',
+      description: 'Use caution, this transaction may be malicious.',
+    },
+  },
+  [AlertType.DANGER]: {
+    type: AlertType.DANGER,
+    details: {
+      title: 'Scam Transaction',
+      description: 'This transaction is malicious, do not proceed.',
+      actionTitles: {
+        reject: 'Reject Transaction',
+        proceed: 'Proceed Anyway',
+      },
+    },
+  },
+};