@autorest/python 6.6.0 → 6.7.0

package/autorest/codegen/models/client.py

@@ -236,11 +236,6 @@ class Client(_ClientConfigBase[ClientGlobalParameterList]):
         """Do we want a mixin ABC class for typing purposes?"""
         return any(o for o in self.operation_groups if o.is_mixin)
 
-    @property
-    def need_format_url(self) -> bool:
-        """Whether we need to format urls. If so, we need to vendor core."""
-        return any(rq for rq in self.request_builders if rq.parameters.path)
-
     @property
     def has_lro_operations(self) -> bool:
         """Are there any LRO operations in this SDK?"""
@@ -269,8 +264,8 @@ class Client(_ClientConfigBase[ClientGlobalParameterList]):
     @property
     def need_request_converter(self) -> bool:
         """
-        Whether we need to convert our created azure.core.rest.HttpRequests to
-        azure.core.pipeline.transport.HttpRequests
+        Whether we need to convert our created azure.core.rest.HttpRequest to
+        azure.core.pipeline.transport.HttpRequest
         """
         return (
             self.code_model.options["show_operations"]

package/autorest/codegen/models/code_model.py

@@ -129,18 +129,12 @@ class CodeModel:  # pylint: disable=too-many-public-methods
             return True
         if async_mode:
             return self.need_mixin_abc
-        return (
-            self.need_request_converter or self.need_format_url or self.need_mixin_abc
-        )
+        return self.need_request_converter or self.need_mixin_abc
 
     @property
     def need_request_converter(self) -> bool:
         return any(c for c in self.clients if c.need_request_converter)
 
-    @property
-    def need_format_url(self) -> bool:
-        return any(c for c in self.clients if c.need_format_url)
-
     @property
     def need_mixin_abc(self) -> bool:
         return any(c for c in self.clients if c.has_mixin)

package/autorest/codegen/models/lro_operation.py

@@ -128,6 +128,18 @@ class LROOperationBase(OperationBase[LROResponseType]):
                 "distributed_trace_async",
                 ImportType.AZURECORE,
             )
+        if (
+            self.code_model.options["models_mode"] == "dpg"
+            and self.lro_response
+            and self.lro_response.type
+            and self.lro_response.type.type == "model"
+        ):
+            # used in the case if initial operation returns none
+            # but final call returns a model
+            relative_path = "..." if async_mode else ".."
+            file_import.add_submodule_import(
+                f"{relative_path}_model_base", "_deserialize", ImportType.LOCAL
+            )
         file_import.add_submodule_import(
             "typing", "Union", ImportType.STDLIB, TypingSection.CONDITIONAL
         )

package/autorest/codegen/models/model_type.py

@@ -207,7 +207,10 @@ class ModelType(  # pylint: disable=abstract-method
 
     @property
     def has_readonly_or_constant_property(self) -> bool:
-        return any(x.readonly or x.constant for x in self.properties)
+        return any(
+            x.readonly or x.constant or x.visibility == ["read"]
+            for x in self.properties
+        )
 
     @property
     def discriminator(self) -> Optional[Property]:

package/autorest/codegen/models/operation.py

@@ -399,16 +399,30 @@ class OperationBase(  # pylint: disable=too-many-public-methods
             file_import.add_submodule_import(
                 f"{relative_path}_vendor", "_convert_request", ImportType.LOCAL
             )
-        if async_mode:
-            file_import.add_submodule_import(
-                "azure.core.pipeline.transport",
-                "AsyncHttpResponse",
-                ImportType.AZURECORE,
-            )
+        if self.code_model.need_request_converter:
+            if async_mode:
+                file_import.add_submodule_import(
+                    "azure.core.pipeline.transport",
+                    "AsyncHttpResponse",
+                    ImportType.AZURECORE,
+                )
+            else:
+                file_import.add_submodule_import(
+                    "azure.core.pipeline.transport",
+                    "HttpResponse",
+                    ImportType.AZURECORE,
+                )
         else:
-            file_import.add_submodule_import(
-                "azure.core.pipeline.transport", "HttpResponse", ImportType.AZURECORE
-            )
+            if async_mode:
+                file_import.add_submodule_import(
+                    "azure.core.rest",
+                    "AsyncHttpResponse",
+                    ImportType.AZURECORE,
+                )
+            else:
+                file_import.add_submodule_import(
+                    "azure.core.rest", "HttpResponse", ImportType.AZURECORE
+                )
         if (
             self.code_model.options["builders_visibility"] == "embedded"
             and not async_mode

package/autorest/codegen/models/property.py

@@ -29,6 +29,7 @@ class Property(BaseModel):  # pylint: disable=too-many-instance-attributes
         self.type = type
         self.optional: bool = self.yaml_data["optional"]
         self.readonly: bool = self.yaml_data.get("readonly", False)
+        self.visibility: List[str] = self.yaml_data.get("visibility", [])
         self.is_polymorphic: bool = self.yaml_data.get("isPolymorphic", False)
         self.is_discriminator: bool = yaml_data.get("isDiscriminator", False)
         self.client_default_value = yaml_data.get("clientDefaultValue", None)

package/autorest/codegen/models/request_builder.py

@@ -92,10 +92,6 @@ class RequestBuilderBase(BaseBuilder[ParameterListType]):
             ImportType.AZURECORE,
         )
 
-        if self.parameters.path:
-            file_import.add_submodule_import(
-                f"{relative_path}_vendor", "_format_url_section", ImportType.LOCAL
-            )
         if self.parameters.headers or self.parameters.query:
             file_import.add_submodule_import(
                 "azure.core.utils", "case_insensitive_dict", ImportType.AZURECORE

package/autorest/codegen/serializers/builder_serializer.py

@@ -1543,7 +1543,7 @@ class _LROOperationSerializer(_OperationSerializer[LROOperationType]):
         retval.append("if cont_token is None:")
         retval.append(
             f"    raw_result = {self._call_method}self.{builder.initial_operation.name}("
-            f"{'' if builder.lro_response and builder.lro_response.type else '  # type: ignore'}"
+            f"{'' if any(rsp.type for rsp in builder.initial_operation.responses) else '  # type: ignore'}"
         )
         retval.extend(
             [

package/autorest/codegen/serializers/general_serializer.py

@@ -109,10 +109,6 @@ class GeneralSerializer:
                 ImportType.AZURECORE,
             )
 
-        if self.code_model.need_format_url and not self.async_mode:
-            file_import.add_submodule_import("typing", "List", ImportType.STDLIB)
-            file_import.add_submodule_import("typing", "cast", ImportType.STDLIB)
-
         if self.code_model.need_mixin_abc:
             file_import.add_submodule_import(
                 "abc",

package/autorest/codegen/serializers/model_serializer.py

@@ -257,6 +257,9 @@ class DpgModelSerializer(_ModelSerializer):
             args.append(f'name="{prop.wire_name}"')
         if prop.readonly:
             args.append("readonly=True")
+        if prop.visibility:
+            v_list = ", ".join(f'"{x}"' for x in prop.visibility)
+            args.append(f"visibility=[{v_list}]")
         if prop.client_default_value is not None:
             args.append(f"default={prop.client_default_value_declaration}")
 
@@ -280,3 +283,11 @@ class DpgModelSerializer(_ModelSerializer):
                     f"{cast(ConstantType, prop.type).get_declaration()}"
                 )
         return init_args
+
+    @staticmethod
+    def _init_line_parameters(model: ModelType):
+        return [
+            p
+            for p in model.properties
+            if not p.is_discriminator and not p.constant and p.visibility != ["read"]
+        ]

package/autorest/codegen/templates/model_base.py.jinja2

@@ -136,7 +136,7 @@ def _serialize_datetime(o):
 
 def _is_readonly(p):
     try:
-        return p._readonly  # pylint: disable=protected-access
+        return p._visibility == ["read"]  # pylint: disable=protected-access
     except AttributeError:
         return False
 
@@ -634,14 +634,14 @@ class _RestField:
         name: typing.Optional[str] = None,
         type: typing.Optional[typing.Callable] = None,  # pylint: disable=redefined-builtin
         is_discriminator: bool = False,
-        readonly: bool = False,
+        visibility: typing.Optional[typing.List[str]] = None,
         default: typing.Any = _UNSET,
     ):
         self._type = type
         self._rest_name_input = name
         self._module: typing.Optional[str] = None
         self._is_discriminator = is_discriminator
-        self._readonly = readonly
+        self._visibility = visibility
         self._is_model = False
         self._default = default
 
@@ -681,10 +681,10 @@ def rest_field(
     *,
     name: typing.Optional[str] = None,
     type: typing.Optional[typing.Callable] = None,  # pylint: disable=redefined-builtin
-    readonly: bool = False,
+    visibility: typing.Optional[typing.List[str]] = None,
     default: typing.Any = _UNSET,
 ) -> typing.Any:
-    return _RestField(name=name, type=type, readonly=readonly, default=default)
+    return _RestField(name=name, type=type, visibility=visibility, default=default)
 
 
 def rest_discriminator(

package/autorest/codegen/templates/request_builder.py.jinja2

@@ -15,7 +15,7 @@
     {{ request_builder_serializer.construct_url(request_builder) }}
     {% if request_builder.parameters.path %}
     {{ op_tools.serialize(request_builder_serializer.serialize_path(request_builder)) | indent }}
-    _url: str = _format_url_section(_url, **path_format_arguments)  # type: ignore
+    _url: str = _url.format(**path_format_arguments)  # type: ignore
         {% endif %}
 
         {% if request_builder.parameters.query %}

package/autorest/codegen/templates/serialization.py.jinja2

@@ -664,8 +664,9 @@ class Serializer(object):
                                 _serialized.update(_new_attr)  # type: ignore
                             _new_attr = _new_attr[k]  # type: ignore
                             _serialized = _serialized[k]
-                except ValueError:
-                    continue
+                except ValueError as err:
+                    if isinstance(err, SerializationError):
+                        raise
 
         except (AttributeError, KeyError, TypeError) as err:
             msg = "Attribute {} in object {} cannot be serialized.\n{}".format(attr_name, class_name, str(target_obj))
@@ -905,7 +906,9 @@ class Serializer(object):
         for d in data:
             try:
                 serialized.append(self.serialize_data(d, iter_type, **kwargs))
-            except ValueError:
+            except ValueError as err:
+                if isinstance(err, SerializationError):
+                    raise
                 serialized.append(None)
 
         if div:
@@ -952,7 +955,9 @@ class Serializer(object):
         for key, value in attr.items():
             try:
                 serialized[self.serialize_unicode(key)] = self.serialize_data(value, dict_type, **kwargs)
-            except ValueError:
+            except ValueError as err:
+                if isinstance(err, SerializationError):
+                    raise
                 serialized[self.serialize_unicode(key)] = None
 
         if "xml" in serialization_ctxt:

package/autorest/codegen/templates/vendor.py.jinja2

@@ -11,21 +11,6 @@ def _convert_request(request, files=None):
         request.set_formdata_body(files)
     return request
 {% endif %}
-{% if code_model.need_format_url and not async_mode %}
-
-def _format_url_section(template, **kwargs):
-    components = template.split("/")
-    while components:
-        try:
-            return template.format(**kwargs)
-        except KeyError as key:
-            # Need the cast, as for some reasons "split" is typed as list[str | Any]
-            formatted_components = cast(List[str], template.split("/"))
-            components = [
-                c for c in formatted_components if "{{{}}}".format(key.args[0]) not in c
-            ]
-            template = "/".join(components)
-{% endif %}
 {% if code_model.need_mixin_abc %}
     {% for client in clients | selectattr("has_mixin") %}
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autorest/python",
-  "version": "6.6.0",
+  "version": "6.7.0",
   "description": "The Python extension for generators in AutoRest.",
   "main": "index.js",
   "repository": {
@@ -23,7 +23,7 @@
   },
   "devDependencies": {
     "@microsoft.azure/autorest.testserver": "^3.3.46",
-    "typescript": "^5.0.4"
+    "typescript": "~5.1.3"
   },
   "files": [
     "autorest/**/*.py",