@autorest/python 6.13.4 → 6.13.5

package/autorest/codegen/models/primitive_types.py

@@ -33,7 +33,7 @@ class PrimitiveType(BaseType):  # pylint: disable=abstract-method
         return self.docstring_type(**kwargs)
 
     def docstring_text(self, **kwargs: Any) -> str:
-        return self.docstring_type()
+        return self.docstring_type(**kwargs)
 
     def get_json_template_representation(
         self,
@@ -125,35 +125,36 @@ class BinaryType(PrimitiveType):
 
 
 class BinaryIteratorType(PrimitiveType):
-    """Type returned by response if response is a streamed response"""
+    def _iterator_name(self, **kwargs: Any) -> str:
+        return "AsyncIterator" if kwargs.pop("async_mode") else "Iterator"
 
     @property
     def serialization_type(self) -> str:
         return "IO"
 
     def docstring_type(self, **kwargs: Any) -> str:
-        return "AsyncIterator[bytes]" if kwargs.get("async_mode") else "Iterator[bytes]"
+        return f"{self._iterator_name(**kwargs)}[bytes]"
 
     def type_annotation(self, **kwargs: Any) -> str:
-        return self.docstring_type(**kwargs)
+        return f"{self._iterator_name(**kwargs)}[bytes]"
 
     def docstring_text(self, **kwargs: Any) -> str:
-        iterator = "Async iterator" if kwargs.get("async_mode") else "Iterator"
-        return f"{iterator} of the response bytes"
+        return f"{self._iterator_name(**kwargs)}[bytes]"
 
     @property
     def default_template_representation_declaration(self) -> str:
-        return self.get_declaration("Iterator[bytes]")
+        return self.get_declaration(b"bytes")
 
     def imports(self, **kwargs: Any) -> FileImport:
         file_import = FileImport(self.code_model)
-        iterator = "AsyncIterator" if kwargs.get("async_mode") else "Iterator"
-        file_import.add_submodule_import("typing", iterator, ImportType.STDLIB)
+        file_import.add_submodule_import(
+            "typing", self._iterator_name(**kwargs), ImportType.STDLIB
+        )
         return file_import
 
     @property
     def instance_check_template(self) -> str:
-        return "isinstance({}, Iterator)"
+        return "getattr({}, '__aiter__', None) is not None or getattr({}, '__iter__', None) is not None"
 
 
 class AnyType(PrimitiveType):

package/autorest/codegen/models/response.py

@@ -155,7 +155,11 @@ class Response(BaseModel):
             else None
         )
         # use ByteIteratorType if we are returning a binary type
-        if isinstance(type, BinaryType):
+        default_content_type = yaml_data.get("defaultContentType", "application/json")
+        if isinstance(type, BinaryType) or (
+            isinstance(type, ByteArraySchema)
+            and default_content_type != "application/json"
+        ):
             type = BinaryIteratorType(type.yaml_data, type.code_model)
         return cls(
             yaml_data=yaml_data,

package/autorest/codegen/serializers/builder_serializer.py

@@ -361,7 +361,9 @@ class _BuilderBaseSerializer(Generic[BuilderType]):  # pylint: disable=abstract-
                     "\n"
                 )
             )
-            docstring_type = param.docstring_type(async_mode=self.async_mode)
+            docstring_type = param.docstring_type(
+                async_mode=self.async_mode,
+            )
             description_list.append(
                 f":{param.docstring_type_keyword} {param.client_name}: {docstring_type}"
             )
@@ -1112,12 +1114,12 @@ class _OperationSerializer(
         if response.headers:
             retval.append("")
         deserialize_code: List[str] = []
-        no_stream_logic = False
+        stream_logic = True
         if builder.has_stream_response:
             if isinstance(response.type, ByteArraySchema):
                 deserialized = f"{'await ' if self.async_mode else ''}response.read()"
             else:
-                no_stream_logic = True
+                stream_logic = False
                 if self.code_model.options["version_tolerant"]:
                     deserialized = "response.iter_bytes()"
                 else:
@@ -1171,7 +1173,7 @@ class _OperationSerializer(
                 deserialize_code.append("else:")
                 deserialize_code.append("    deserialized = None")
         if len(deserialize_code) > 0:
-            if builder.expose_stream_keyword and not no_stream_logic:
+            if builder.expose_stream_keyword and stream_logic:
                 retval.append("if _stream:")
                 retval.append("    deserialized = response.iter_bytes()")
                 retval.append("else:")

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autorest/python",
-  "version": "6.13.4",
+  "version": "6.13.5",
   "description": "The Python extension for generators in AutoRest.",
   "main": "index.js",
   "repository": {